[jira] [Comment Edited] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out

2019-01-15 Thread Deepak Nigam (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743633#comment-16743633
 ] 

Deepak Nigam edited comment on OFBIZ-10666 at 1/16/19 5:35 AM:
---

Thanks for sharing "[the Onion 
parody|https://www.theonion.com/after-checking-your-bank-account-remember-to-log-out-1819584860];,
 [~jacques.le.roux]. It is quite interesting, however difficult to grasp in 
first few readings. ;)


was (Author: deepak.nigam):
Thanks for sharing "[the Onion 
parody|https://www.theonion.com/after-checking-your-bank-account-remember-to-log-out-1819584860];.
 It is quite interesting, however difficult to grasp in first few readings. ;)

> User's name is displayed on ecommerce even after user logs out
> --
>
> Key: OFBIZ-10666
> URL: https://issues.apache.org/jira/browse/OFBIZ-10666
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, 
> 4-NotYou.png, OFBIZ-10666.patch, OFBiz-10666.patch
>
>
> Steps to regenerate:
>  # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. 
> Welcome is displayed and user's name is not displayed when URL is opened. 
> (Please refer attachment: 1-OpenURL)
>  # Login at ecommerce by clicking on login and entering Username: "admin" and 
> Password: "ofbiz". Username will be displayed after user logs in. (Please 
> refer attachment: 2-LoggedIn)
>  # Logout of ecommerce by clicking on logout. User will be logged out and 
> login link will be displayed in place of logout link, but the name of user is 
> still displayed. (Please refer attachment: 3-LoggedOut)
> Actual: Username is still displayed after user logs out
>  
> Expected: Username should not be displayed after the user logs out
>  
> Note: Similar issue also exists when the user clicks on (Not You? Click Here) 
> link. (Please refer attachment: 4-NotYou)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10666) User's name is displayed on ecommerce even after user logs out

2019-01-15 Thread Deepak Nigam (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743633#comment-16743633
 ] 

Deepak Nigam commented on OFBIZ-10666:
--

Thanks for sharing "[the Onion 
parody|https://www.theonion.com/after-checking-your-bank-account-remember-to-log-out-1819584860];.
 It is quite interesting, however difficult to grasp in first few readings. ;)

> User's name is displayed on ecommerce even after user logs out
> --
>
> Key: OFBIZ-10666
> URL: https://issues.apache.org/jira/browse/OFBIZ-10666
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: 1-OpenURL.png, 2-LoggedIn.png, 3-LoggedOut.png, 
> 4-NotYou.png, OFBIZ-10666.patch, OFBiz-10666.patch
>
>
> Steps to regenerate:
>  # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]. 
> Welcome is displayed and user's name is not displayed when URL is opened. 
> (Please refer attachment: 1-OpenURL)
>  # Login at ecommerce by clicking on login and entering Username: "admin" and 
> Password: "ofbiz". Username will be displayed after user logs in. (Please 
> refer attachment: 2-LoggedIn)
>  # Logout of ecommerce by clicking on logout. User will be logged out and 
> login link will be displayed in place of logout link, but the name of user is 
> still displayed. (Please refer attachment: 3-LoggedOut)
> Actual: Username is still displayed after user logs out
>  
> Expected: Username should not be displayed after the user logs out
>  
> Note: Similar issue also exists when the user clicks on (Not You? Click Here) 
> link. (Please refer attachment: 4-NotYou)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-2364) Competitors & Partners - Sales Force Automation component

2019-01-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743254#comment-16743254
 ] 

Jacques Le Roux commented on OFBIZ-2364:


Hi Dennis,

I tend to agree, better though to get confirmation on the dev ML (no answer 
being considered a consensus to remove)

> Competitors & Partners - Sales Force Automation component
> -
>
> Key: OFBIZ-2364
> URL: https://issues.apache.org/jira/browse/OFBIZ-2364
> Project: OFBiz
>  Issue Type: New Feature
>  Components: marketing
>Affects Versions: Trunk
> Environment: Mac OS X
>Reporter: Vikas Mayur
>Priority: Minor
> Attachments: SFA Competitors & Partners.patch
>
>
> Competitors and Partners will be parties (generally PartyGroup) and are 
> related to other items including Accounts, Opportunities, and so on. 
> The screens for Competitor would include: Competitor Home, Accounts, 
> Opportunities. 
> The screens for Partner would include: Partner Home, Accounts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10795) Product dropdown should be replaced with product lookup on Edit Price Rule screen

2019-01-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743241#comment-16743241
 ] 

Jacques Le Roux commented on OFBIZ-10795:
-

Actually thinking more about it, OOTB we have a limited number of cases which 
could be problematic. So, for these cases (like products here) we could have a 
test to see if there is a large number of records and if it's the case show a 
lookup rather than a dropdown. We would then dynamically choose between a 
dropdown or  lookup. Is that what you had in mind Mohammad?

> Product dropdown should be replaced with product lookup on Edit Price Rule 
> screen
> -
>
> Key: OFBIZ-10795
> URL: https://issues.apache.org/jira/browse/OFBIZ-10795
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Mohammad Kathawala
>Assignee: Pradeep Choudhary
>Priority: Minor
> Fix For: Trunk, Release Branch 16.11, Release Branch 17.12
>
>
> On Edit Price Rule screen, all the products of the system are fetched in a 
> single dropdown.
> If a system has thousands or more products, then it will take too much time 
> to load those products in the dropdown and screen loading time will increase 
> or even it can make the system down.
>  
> We should have a product lookup here.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-2364) Competitors & Partners - Sales Force Automation component

2019-01-15 Thread Dennis Balkir (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743238#comment-16743238
 ] 

Dennis Balkir commented on OFBIZ-2364:
--

Hi [~jacques.le.roux],

I think it is safe to say, that there won't be any more development in this 
feature.
The suggestion would be to remove the menu points "Competitors & Partners" and 
"Documents" since they are both undefined links in the SfaMenus.xml and for 
this serve no further porpuse.

> Competitors & Partners - Sales Force Automation component
> -
>
> Key: OFBIZ-2364
> URL: https://issues.apache.org/jira/browse/OFBIZ-2364
> Project: OFBiz
>  Issue Type: New Feature
>  Components: marketing
>Affects Versions: Trunk
> Environment: Mac OS X
>Reporter: Vikas Mayur
>Priority: Minor
> Attachments: SFA Competitors & Partners.patch
>
>
> Competitors and Partners will be parties (generally PartyGroup) and are 
> related to other items including Accounts, Opportunities, and so on. 
> The screens for Competitor would include: Competitor Home, Accounts, 
> Opportunities. 
> The screens for Partner would include: Partner Home, Accounts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10813) Improve Accounting -> Financial Account container structure

2019-01-15 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-10813:
-

Assignee: Michael Brohl

> Improve Accounting -> Financial Account container structure
> ---
>
> Key: OFBIZ-10813
> URL: https://issues.apache.org/jira/browse/OFBIZ-10813
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-10813_FinAccountScreens.patch
>
>
> There were again some structural differences found, this time in Accounting 
> -> Financial Account.
>  I treated them like I did Accounting AR -> Main in OFBIZ-10469



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10813) Improve Accounting -> Financial Account container structure

2019-01-15 Thread Michael Brohl (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10813:
--
Description: 
There were again some structural differences found, this time in Accounting -> 
Financial Account.
 I treated them like I did Accounting AR -> Main in OFBIZ-10469

  was:
There were again some structural differences found, this time in Accounting -> 
Financial Account.
I treated them like I did Accounting AR -> Main in 
https://issues.apache.org/jira/browse/OFBIZ-10469


> Improve Accounting -> Financial Account container structure
> ---
>
> Key: OFBIZ-10813
> URL: https://issues.apache.org/jira/browse/OFBIZ-10813
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10813_FinAccountScreens.patch
>
>
> There were again some structural differences found, this time in Accounting 
> -> Financial Account.
>  I treated them like I did Accounting AR -> Main in OFBIZ-10469



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10813) Improve Accounting -> Financial Account container structure

2019-01-15 Thread Dennis Balkir (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743218#comment-16743218
 ] 

Dennis Balkir commented on OFBIZ-10813:
---

The patch I added treats this structural difference like it was done in 
Accounting AR and Accounting AP.
The changes also work with all past themes, too.

> Improve Accounting -> Financial Account container structure
> ---
>
> Key: OFBIZ-10813
> URL: https://issues.apache.org/jira/browse/OFBIZ-10813
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10813_FinAccountScreens.patch
>
>
> There were again some structural differences found, this time in Accounting 
> -> Financial Account.
> I treated them like I did Accounting AR -> Main in 
> https://issues.apache.org/jira/browse/OFBIZ-10469



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10813) Improve Accounting -> Financial Account container structure

2019-01-15 Thread Dennis Balkir (JIRA)
Dennis Balkir created OFBIZ-10813:
-

 Summary: Improve Accounting -> Financial Account container 
structure
 Key: OFBIZ-10813
 URL: https://issues.apache.org/jira/browse/OFBIZ-10813
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Dennis Balkir
 Attachments: OFBIZ-10813_FinAccountScreens.patch

There were again some structural differences found, this time in Accounting -> 
Financial Account.
I treated them like I did Accounting AR -> Main in 
https://issues.apache.org/jira/browse/OFBIZ-10469



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10813) Improve Accounting -> Financial Account container structure

2019-01-15 Thread Dennis Balkir (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Balkir updated OFBIZ-10813:
--
Attachment: OFBIZ-10813_FinAccountScreens.patch

> Improve Accounting -> Financial Account container structure
> ---
>
> Key: OFBIZ-10813
> URL: https://issues.apache.org/jira/browse/OFBIZ-10813
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Priority: Minor
> Attachments: OFBIZ-10813_FinAccountScreens.patch
>
>
> There were again some structural differences found, this time in Accounting 
> -> Financial Account.
> I treated them like I did Accounting AR -> Main in 
> https://issues.apache.org/jira/browse/OFBIZ-10469



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10812) ObjectType::doRealCompare returns null instead of a boolean in few places

2019-01-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10812.
---
   Resolution: Implemented
 Assignee: Jacques Le Roux
Fix Version/s: Upcoming Branch

Done at revision: 1851363  


> ObjectType::doRealCompare  returns  null instead of a boolean in few places
> ---
>
> Key: OFBIZ-10812
> URL: https://issues.apache.org/jira/browse/OFBIZ-10812
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> While reviewing OFBIZ-10811 I found that I could improve ObjectType class on 
> 2 points: 
> * doRealCompare returning null instead of a boolean
> * simpleTypeOrObjectConvert Javadoc (2 other instance not documented)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand

2019-01-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743088#comment-16743088
 ] 

Jacques Le Roux commented on OFBIZ-9677:


Thanks Paul,

Backported in
R18 r1851361
R17 r1851359
R16 r1851357

> In packing, only use reservations with stock on hand
> 
>
> Key: OFBIZ-9677
> URL: https://issues.apache.org/jira/browse/OFBIZ-9677
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Major
>  Labels: pack, reservation
> Fix For: Trunk
>
> Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, 
> OFBIZ-9677_PackingIgnoreBackorderReservations.patch
>
>
> During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the 
> order item. Some reservations are for back ordered items not on hand. These 
> reservations should not be used during packing, but they are.
> The attached patch fixes this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9677) In packing, only use reservations with stock on hand

2019-01-15 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9677:
---
Fix Version/s: (was: Trunk)
   18.12.01
   16.11.06
   17.12.01

> In packing, only use reservations with stock on hand
> 
>
> Key: OFBIZ-9677
> URL: https://issues.apache.org/jira/browse/OFBIZ-9677
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Major
>  Labels: pack, reservation
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, 
> OFBIZ-9677_PackingIgnoreBackorderReservations.patch
>
>
> During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the 
> order item. Some reservations are for back ordered items not on hand. These 
> reservations should not be used during packing, but they are.
> The attached patch fixes this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10812) ObjectType::doRealCompare returns null instead of a boolean in few places

2019-01-15 Thread Jacques Le Roux (JIRA)
Jacques Le Roux created OFBIZ-10812:
---

 Summary: ObjectType::doRealCompare  returns  null instead of a 
boolean in few places
 Key: OFBIZ-10812
 URL: https://issues.apache.org/jira/browse/OFBIZ-10812
 Project: OFBiz
  Issue Type: Improvement
Reporter: Jacques Le Roux


While reviewing OFBIZ-10811 I found that I could improve ObjectType class on 2 
points: 
* doRealCompare returning null instead of a boolean
* simpleTypeOrObjectConvert Javadoc (2 other instance not documented)




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9677) In packing, only use reservations with stock on hand

2019-01-15 Thread Paul Foxworthy (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743077#comment-16743077
 ] 

Paul Foxworthy commented on OFBIZ-9677:
---

There was a problem with a boundary condition when there is  single reservation 
and its quantity exactly matches the quantity to pack. The tests now pass 
locally. Committed in r1851353.

> In packing, only use reservations with stock on hand
> 
>
> Key: OFBIZ-9677
> URL: https://issues.apache.org/jira/browse/OFBIZ-9677
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Major
>  Labels: pack, reservation
> Fix For: Trunk
>
> Attachments: OFBIZ-9677_PackingIgnoreBackorderReservations.patch, 
> OFBIZ-9677_PackingIgnoreBackorderReservations.patch
>
>
> During packing, OFBiz looks for reservations (OrderItemShipGrpInvRes) for the 
> order item. Some reservations are for back ordered items not on hand. These 
> reservations should not be used during packing, but they are.
> The attached patch fixes this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10635) Correct behaviour of Autologin cookies

2019-01-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743075#comment-16743075
 ] 

Jacques Le Roux commented on OFBIZ-10635:
-

As reported by Deepak Nigam in dev ML there was a risk of NPE with userLogin w/ 
my last commit at r1851074  
Fixed in
trunk r1851350
R18 r1851351
R17 r1851352

> Correct behaviour of Autologin cookies
> --
>
> Key: OFBIZ-10635
> URL: https://issues.apache.org/jira/browse/OFBIZ-10635
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: OFBIZ-10635-R16.patch
>
>
> With OFBIZ-4959 I have cleaned a bit how the Autologin cookies behave. But I 
> followed the way it was initially done and when you think about it it does 
> not make sense.
> I introduced the "keep-autologin-cookie" attribute in the "webapp" element of 
> the ofbiz-component files. But after I created the securedLoginId cookies for 
> OFBIZ-10307 we no longer need to create Autologin cookies for applications 
> which don't use it.
> So I'll rename "keep-autologin-cookie" to "use-autologin-cookie", and only 
> create Autologin cookies when needed. No need to create and keep Autologin 
> cookies in applications that don't need it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10595) The query iCalendar/CALENDAR_PUB_DEMO/ no longer works

2019-01-15 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742960#comment-16742960
 ] 

Jacques Le Roux commented on OFBIZ-10595:
-

Thanks Jyri,

There is one problem with your patch: it's not built against the trunk. 

ControlFilter.java has changed recently with OFBIZ-10449. I had a look but I 
lack of time today. I'll certainly look later, in the meantime you may have a 
look at where your change in ControlFilter.java should be one. 

Also since it's only set in ICalWorker::setupRequest we need to check that the 
workEffortId attribute exists before changing it.

> The query iCalendar/CALENDAR_PUB_DEMO/ no longer works
> --
>
> Key: OFBIZ-10595
> URL: https://issues.apache.org/jira/browse/OFBIZ-10595
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 16.11.06
>
> Attachments: iCalendar.patch
>
>
> ControlFilter does not allow the untypical iCalendar/CALENDAR_PUB_DEMO/ query 
> to pass.
> This feature works in the stable version. So it's a change since then
> Thanks to Jyri Sillanpaa for the detailled report: 
> https://markmail.org/message/pfd62nom3ftnpgll



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10811) PaymentGatewayServices should be using ObjectType.simpleTypeConvert for all amount variables

2019-01-15 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10811:
--
Attachment: OFBIZ-10811.patch

> PaymentGatewayServices should be using ObjectType.simpleTypeConvert for all 
> amount variables
> 
>
> Key: OFBIZ-10811
> URL: https://issues.apache.org/jira/browse/OFBIZ-10811
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10811.patch
>
>
> Currently, it is direct typecasting into BigDecimal and it could throw 
> exception regarding string to BigDecimal typecasting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9853) Replace Inline js with External js in renderFieldGroupOpen macro

2019-01-15 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742950#comment-16742950
 ] 

Aditya Sharma commented on OFBIZ-9853:
--

Provided a patch.

Replaces js code as well as improved css. Toggle on click can be attached to li 
directly so there is no need to have a  element.

I will commit asap.

> Replace Inline js with External js in renderFieldGroupOpen macro
> 
>
> Key: OFBIZ-9853
> URL: https://issues.apache.org/jira/browse/OFBIZ-9853
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-9853.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10811) PaymentGatewayServices should be using ObjectType.simpleTypeConvert for all amount variables

2019-01-15 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-10811:
-

 Summary: PaymentGatewayServices should be using 
ObjectType.simpleTypeConvert for all amount variables
 Key: OFBIZ-10811
 URL: https://issues.apache.org/jira/browse/OFBIZ-10811
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana


Currently, it is direct typecasting into BigDecimal and it could throw 
exception regarding string to BigDecimal typecasting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9853) Replace Inline js with External js in renderFieldGroupOpen macro

2019-01-15 Thread Aditya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditya Sharma updated OFBIZ-9853:
-
Attachment: OFBIZ-9853.patch

> Replace Inline js with External js in renderFieldGroupOpen macro
> 
>
> Key: OFBIZ-9853
> URL: https://issues.apache.org/jira/browse/OFBIZ-9853
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
> Attachments: OFBIZ-9853.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10595) The query iCalendar/CALENDAR_PUB_DEMO/ no longer works

2019-01-15 Thread JIRA


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jyri Sillanpää updated OFBIZ-10595:
---
Attachment: iCalendar.patch

> The query iCalendar/CALENDAR_PUB_DEMO/ no longer works
> --
>
> Key: OFBIZ-10595
> URL: https://issues.apache.org/jira/browse/OFBIZ-10595
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 16.11.06
>
> Attachments: iCalendar.patch
>
>
> ControlFilter does not allow the untypical iCalendar/CALENDAR_PUB_DEMO/ query 
> to pass.
> This feature works in the stable version. So it's a change since then
> Thanks to Jyri Sillanpaa for the detailled report: 
> https://markmail.org/message/pfd62nom3ftnpgll



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10595) The query iCalendar/CALENDAR_PUB_DEMO/ no longer works

2019-01-15 Thread JIRA


[ 
https://issues.apache.org/jira/browse/OFBIZ-10595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742888#comment-16742888
 ] 

Jyri Sillanpää commented on OFBIZ-10595:


Patch attached that fixes the issue. Any comments?

[^iCalendar.patch]

> The query iCalendar/CALENDAR_PUB_DEMO/ no longer works
> --
>
> Key: OFBIZ-10595
> URL: https://issues.apache.org/jira/browse/OFBIZ-10595
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 16.11.06
>
> Attachments: iCalendar.patch
>
>
> ControlFilter does not allow the untypical iCalendar/CALENDAR_PUB_DEMO/ query 
> to pass.
> This feature works in the stable version. So it's a change since then
> Thanks to Jyri Sillanpaa for the detailled report: 
> https://markmail.org/message/pfd62nom3ftnpgll



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)