[jira] [Commented] (OFBIZ-10831) Re-reservation of Inventory Items when Ship Group Destination Address or Shipment Method is updated in Sales Order
[ https://issues.apache.org/jira/browse/OFBIZ-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765752#comment-16765752 ] Jacques Le Roux commented on OFBIZ-10831: - HI Vijay, Sure a patch is always welcom, please follow https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices, thanks > Re-reservation of Inventory Items when Ship Group Destination Address or > Shipment Method is updated in Sales Order > -- > > Key: OFBIZ-10831 > URL: https://issues.apache.org/jira/browse/OFBIZ-10831 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11 >Reporter: Vijay Ganesh >Priority: Major > Fix For: Release Branch 16.11 > > > Hi, > We came across this issue recently and also have fixed the same. > After creating a sales order and approving it, we created a shipment and > receive all the items and change the status to Packed. > Moving to the sales order edit screen. We are able to update the Ship Group > Destination Address or Shipment Method. Even without changing anything if we > simply click the update button, Inventory re-reservation service is being > called and getting re-reserved. Since there are no records in the > [OrderItemShipGrpInvRes|https://localhost:8443/webtools/control/FindGeneric?entityName=OrderItemShipGrpInvRes] > Entity, the inventory values are getting re-reserved again and this is a > major issue. > For a Sales Order of quantity 10, after approving and creating a shipment, we > issue 10 items and change status to packed. Now we go to the Order View/Edit > Screen and update the shipment method/Address or simply click the update > button and the quantity in the Shipment for that order changes to 20 which > should not happen. > > The fix we made is passing a hidden variable from the shipping Info Section > and when clicking the update button, we pass that value to the Inventory > Re-reservation event and check the value in that method. > In the loadCartForUpdate method in OrderService.java, we pass the checkValue > to see whether this request is coming from the Shipping Information update > section and prevent the cancelOrderInventoryReservation service from calling. > In the saveUpdatedCartToOrder method in OrderService.java using the same > checkValue, we prevent the reserveInventory service from calling. > This occurs when an existing shipment is in packed status for an order and > that order's shipping information needs to be edited. > This was an issue in our case and we fixed this way. > If it is ok we will provide the patch here?. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10830) Added translations es and es-CL in Product Component
[ https://issues.apache.org/jira/browse/OFBIZ-10830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane closed OFBIZ-10830. -- Resolution: Implemented Fix Version/s: (was: Trunk) Upcoming Branch > Added translations es and es-CL in Product Component > > > Key: OFBIZ-10830 > URL: https://issues.apache.org/jira/browse/OFBIZ-10830 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Jonathan >Assignee: Swapnil M Mane >Priority: Minor > Labels: productui > Fix For: Upcoming Branch > > Attachments: Product_translations_es_esCL.patch > > > Added translations es, es-CL in files: > * ProductUiLabels > * ProductEntityLabels -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10830) Added translations es and es-CL in Product Component
[ https://issues.apache.org/jira/browse/OFBIZ-10830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764970#comment-16764970 ] Swapnil M Mane commented on OFBIZ-10830: Hello [~cardenasvar], I was writing the comment below! ;) Thanks [~cardenasvar] for your contribution. Your patch is committed at rev #1853370 in the trunk. I see a typo for ProductAssocType.description.PRODUCT_CONF, I fixed it in my commit. You can also see your duplicate label from Label Manager [https://demo-trunk.ofbiz.apache.org/webtools/control/SearchLabels] Select the File Name, and it will list down if any label is duplicate. > Added translations es and es-CL in Product Component > > > Key: OFBIZ-10830 > URL: https://issues.apache.org/jira/browse/OFBIZ-10830 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Jonathan >Assignee: Swapnil M Mane >Priority: Minor > Labels: productui > Fix For: Trunk > > Attachments: Product_translations_es_esCL.patch > > > Added translations es, es-CL in files: > * ProductUiLabels > * ProductEntityLabels -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10830) Added translations es and es-CL in Product Component
[ https://issues.apache.org/jira/browse/OFBIZ-10830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan updated OFBIZ-10830: - Labels: productid (was: ) > Added translations es and es-CL in Product Component > > > Key: OFBIZ-10830 > URL: https://issues.apache.org/jira/browse/OFBIZ-10830 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Jonathan >Assignee: Swapnil M Mane >Priority: Minor > Labels: productid > Fix For: Trunk > > Attachments: Product_translations_es_esCL.patch > > > Added translations es, es-CL in files: > * ProductUiLabels > * ProductEntityLabels -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10830) Added translations es and es-CL in Product Component
[ https://issues.apache.org/jira/browse/OFBIZ-10830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan updated OFBIZ-10830: - Labels: productui (was: productid) > Added translations es and es-CL in Product Component > > > Key: OFBIZ-10830 > URL: https://issues.apache.org/jira/browse/OFBIZ-10830 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Jonathan >Assignee: Swapnil M Mane >Priority: Minor > Labels: productui > Fix For: Trunk > > Attachments: Product_translations_es_esCL.patch > > > Added translations es, es-CL in files: > * ProductUiLabels > * ProductEntityLabels -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10830) Added translations es and es-CL in Product Component
[ https://issues.apache.org/jira/browse/OFBIZ-10830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764964#comment-16764964 ] Jonathan commented on OFBIZ-10830: -- Hello Swapnil, I have something to correct or is the patch well generated? > Added translations es and es-CL in Product Component > > > Key: OFBIZ-10830 > URL: https://issues.apache.org/jira/browse/OFBIZ-10830 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Jonathan >Assignee: Swapnil M Mane >Priority: Minor > Fix For: Trunk > > Attachments: Product_translations_es_esCL.patch > > > Added translations es, es-CL in files: > * ProductUiLabels > * ProductEntityLabels -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10832) simpleTypeConvert always returns Null for Document, Document Type and Notation Node
[
https://issues.apache.org/jira/browse/OFBIZ-10832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764889#comment-16764889
]
Swapnil M Mane commented on OFBIZ-10832:
Hello team,
I have attached the patch to fix the issue.
Since we can't get the value of Document, Document Type and Notation Node from
getTextContent() method, we should simply return the same object.
Please have a look into the patch and let me know if you any feedback.
Thanks!
> simpleTypeConvert always returns Null for Document, Document Type and
> Notation Node
> ---
>
> Key: OFBIZ-10832
> URL: https://issues.apache.org/jira/browse/OFBIZ-10832
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Major
> Attachments: OFBIZ-10832.patch
>
>
> simpleTypeConvert always returns Null for Document, Document Type and
> Notation Node
> The ObjectType.simpleTypeConvert method always returns null for Document,
> Document Type and Notation Node.
> As per the current code, getTextContent() method is used get text content of
> the node and its descendants but the node.getTextContent() always return Null
> for the following Node type
> DOCUMENT_NODE, DOCUMENT_TYPE_NODE, NOTATION_NODE [1]
> {code:java}
> if (obj instanceof Node) {
> Node node = (Node) obj;
> String nodeValue = node.getTextContent();
> if ("String".equals(type) || "java.lang.String".equals(type)) {
> return nodeValue;
> }
> return simpleTypeConvert(nodeValue, type, format, timeZone, locale,
> noTypeFail);
> }
> {code}
> Since we can't get the text value of Document, Document Type and Notation
> Node, we should simply return the same object.
> [1]
> [https://docs.oracle.com/javase/7/docs/api/org/w3c/dom/Node.html#getTextContent(])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10832) simpleTypeConvert always returns Null for Document, Document Type and Notation Node
[
https://issues.apache.org/jira/browse/OFBIZ-10832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil M Mane updated OFBIZ-10832:
---
Attachment: OFBIZ-10832.patch
> simpleTypeConvert always returns Null for Document, Document Type and
> Notation Node
> ---
>
> Key: OFBIZ-10832
> URL: https://issues.apache.org/jira/browse/OFBIZ-10832
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Major
> Attachments: OFBIZ-10832.patch
>
>
> simpleTypeConvert always returns Null for Document, Document Type and
> Notation Node
> The ObjectType.simpleTypeConvert method always returns null for Document,
> Document Type and Notation Node.
> As per the current code, getTextContent() method is used get text content of
> the node and its descendants but the node.getTextContent() always return Null
> for the following Node type
> DOCUMENT_NODE, DOCUMENT_TYPE_NODE, NOTATION_NODE [1]
> {code:java}
> if (obj instanceof Node) {
> Node node = (Node) obj;
> String nodeValue = node.getTextContent();
> if ("String".equals(type) || "java.lang.String".equals(type)) {
> return nodeValue;
> }
> return simpleTypeConvert(nodeValue, type, format, timeZone, locale,
> noTypeFail);
> }
> {code}
> Since we can't get the text value of Document, Document Type and Notation
> Node, we should simply return the same object.
> [1]
> [https://docs.oracle.com/javase/7/docs/api/org/w3c/dom/Node.html#getTextContent(])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10832) simpleTypeConvert always returns Null for Document, Document Type and Notation Node
[
https://issues.apache.org/jira/browse/OFBIZ-10832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764885#comment-16764885
]
Swapnil M Mane commented on OFBIZ-10832:
Thanks, Deepak! :-)
> simpleTypeConvert always returns Null for Document, Document Type and
> Notation Node
> ---
>
> Key: OFBIZ-10832
> URL: https://issues.apache.org/jira/browse/OFBIZ-10832
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Major
>
> simpleTypeConvert always returns Null for Document, Document Type and
> Notation Node
> The ObjectType.simpleTypeConvert method always returns null for Document,
> Document Type and Notation Node.
> As per the current code, getTextContent() method is used get text content of
> the node and its descendants but the node.getTextContent() always return Null
> for the following Node type
> DOCUMENT_NODE, DOCUMENT_TYPE_NODE, NOTATION_NODE [1]
> {code:java}
> if (obj instanceof Node) {
> Node node = (Node) obj;
> String nodeValue = node.getTextContent();
> if ("String".equals(type) || "java.lang.String".equals(type)) {
> return nodeValue;
> }
> return simpleTypeConvert(nodeValue, type, format, timeZone, locale,
> noTypeFail);
> }
> {code}
> Since we can't get the text value of Document, Document Type and Notation
> Node, we should simply return the same object.
> [1]
> [https://docs.oracle.com/javase/7/docs/api/org/w3c/dom/Node.html#getTextContent(])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10832) simpleTypeConvert always returns Null for Document, Document Type and Notation Node
[
https://issues.apache.org/jira/browse/OFBIZ-10832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764818#comment-16764818
]
Swapnil M Mane commented on OFBIZ-10832:
This issue is caught after this improvement OFBIZ-10712
Previously, modelService.makeValid method was used only when the service
definition has a permission service call.
Now, this method is used every time, which internally calls simpleTypeConvert
method. This is how we are able to get this issue.
> simpleTypeConvert always returns Null for Document, Document Type and
> Notation Node
> ---
>
> Key: OFBIZ-10832
> URL: https://issues.apache.org/jira/browse/OFBIZ-10832
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Major
>
> simpleTypeConvert always returns Null for Document, Document Type and
> Notation Node
> The ObjectType.simpleTypeConvert method always returns null for Document,
> Document Type and Notation Node.
> As per the current code, getTextContent() method is used get text content of
> the node and its descendants but the node.getTextContent() always return Null
> for the following Node type
> DOCUMENT_NODE, DOCUMENT_TYPE_NODE, NOTATION_NODE [1]
> {code:java}
> if (obj instanceof Node) {
> Node node = (Node) obj;
> String nodeValue = node.getTextContent();
> if ("String".equals(type) || "java.lang.String".equals(type)) {
> return nodeValue;
> }
> return simpleTypeConvert(nodeValue, type, format, timeZone, locale,
> noTypeFail);
> }
> {code}
> Since we can't get the text value of Document, Document Type and Notation
> Node, we should simply return the same object.
> [1]
> [https://docs.oracle.com/javase/7/docs/api/org/w3c/dom/Node.html#getTextContent(])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10832) simpleTypeConvert always returns Null for Document, Document Type and Notation Node
[
https://issues.apache.org/jira/browse/OFBIZ-10832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764820#comment-16764820
]
Deepak Dixit commented on OFBIZ-10832:
--
Good catch Swapnil!!
> simpleTypeConvert always returns Null for Document, Document Type and
> Notation Node
> ---
>
> Key: OFBIZ-10832
> URL: https://issues.apache.org/jira/browse/OFBIZ-10832
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Swapnil M Mane
>Assignee: Swapnil M Mane
>Priority: Major
>
> simpleTypeConvert always returns Null for Document, Document Type and
> Notation Node
> The ObjectType.simpleTypeConvert method always returns null for Document,
> Document Type and Notation Node.
> As per the current code, getTextContent() method is used get text content of
> the node and its descendants but the node.getTextContent() always return Null
> for the following Node type
> DOCUMENT_NODE, DOCUMENT_TYPE_NODE, NOTATION_NODE [1]
> {code:java}
> if (obj instanceof Node) {
> Node node = (Node) obj;
> String nodeValue = node.getTextContent();
> if ("String".equals(type) || "java.lang.String".equals(type)) {
> return nodeValue;
> }
> return simpleTypeConvert(nodeValue, type, format, timeZone, locale,
> noTypeFail);
> }
> {code}
> Since we can't get the text value of Document, Document Type and Notation
> Node, we should simply return the same object.
> [1]
> [https://docs.oracle.com/javase/7/docs/api/org/w3c/dom/Node.html#getTextContent(])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10832) simpleTypeConvert always returns Null for Document, Document Type and Notation Node
Swapnil M Mane created OFBIZ-10832:
--
Summary: simpleTypeConvert always returns Null for Document,
Document Type and Notation Node
Key: OFBIZ-10832
URL: https://issues.apache.org/jira/browse/OFBIZ-10832
Project: OFBiz
Issue Type: Bug
Affects Versions: Release Branch 16.11, Trunk, Release Branch 17.12,
Release Branch 18.12
Reporter: Swapnil M Mane
Assignee: Swapnil M Mane
simpleTypeConvert always returns Null for Document, Document Type and Notation
Node
The ObjectType.simpleTypeConvert method always returns null for Document,
Document Type and Notation Node.
As per the current code, getTextContent() method is used get text content of
the node and its descendants but the node.getTextContent() always return Null
for the following Node type
DOCUMENT_NODE, DOCUMENT_TYPE_NODE, NOTATION_NODE [1]
{code:java}
if (obj instanceof Node) {
Node node = (Node) obj;
String nodeValue = node.getTextContent();
if ("String".equals(type) || "java.lang.String".equals(type)) {
return nodeValue;
}
return simpleTypeConvert(nodeValue, type, format, timeZone, locale,
noTypeFail);
}
{code}
Since we can't get the text value of Document, Document Type and Notation Node,
we should simply return the same object.
[1]
[https://docs.oracle.com/javase/7/docs/api/org/w3c/dom/Node.html#getTextContent(])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-10145: -- Attachment: init-gradle-wrapper.sh > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper.sh, init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764738#comment-16764738 ] Nicolas Malin commented on OFBIZ-10145: --- Hello, I updated the script with a version for 17.12 [^init-gradle-wrapper.sh] and an other for 18.12 and trunk [^init-gradle-wrapper-trunk-and-18.sh] I will check the documentation > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-10145: -- Attachment: init-gradle-wrapper-trunk-and-18.sh > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
