[jira] [Commented] (OFBIZ-10606) Webapp related code should be extracted from ‘ComponentConfig’
[
https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779328#comment-16779328
]
Jacques Le Roux commented on OFBIZ-10606:
-
Thanks Mathieu
> Webapp related code should be extracted from ‘ComponentConfig’
> ---
>
> Key: OFBIZ-10606
> URL: https://issues.apache.org/jira/browse/OFBIZ-10606
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10606_0001-Add-WebAppCache.patch,
> OFBIZ-10606_0001-Add-WebAppCache.patch,
> OFBIZ-10606_0002-Add-tests-for-WebAppCache.patch,
> OFBIZ-10606_0003-Refactor-WebAppCache.patch,
> OFBIZ-10606_0004-Inline-getAppBarWebInfos-String-Comparator-String-pr.patch,
> OFBIZ-10606_0005-Use-Optional-for-getWebappInfo.patch
>
>
> The {{ComponentConfig}} mixes various concerns which should be separated to
> make the code more understandable. The method touching the {{serverWebApps}}
> static member could be put in a separated class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10842) No userLogin given in calculateProductPrice service call context
[ https://issues.apache.org/jira/browse/OFBIZ-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10842. --- Resolution: Fixed Fix Version/s: 18.12.01 16.11.06 17.12.01 Thanks Danny, I fixed it following your advice in trunk r1854457 R17 r1854458 R18 r1854459 R16 r1854460 > No userLogin given in calculateProductPrice service call context > > > Key: OFBIZ-10842 > URL: https://issues.apache.org/jira/browse/OFBIZ-10842 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk >Reporter: Danny Trunk >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > > The call context for calculateProductPrice doesn't contain the userLogin: > [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java?view=markup#l1195] > As this is needed in the customPriceCalcService: > [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347] > > So currently there's no chance to get the user information in a custom price > calc service. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10842) No userLogin given in calculateProductPrice service call context
[ https://issues.apache.org/jira/browse/OFBIZ-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779173#comment-16779173 ] Danny Trunk edited comment on OFBIZ-10842 at 2/27/19 11:50 AM: --- I was thinking about this as well when creating the issue, but I think it is a bug. As mentioned in [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347] it is looking for a userLogin in context which is never set before. I did a workaround in my customPriceCalcService for now as we are using Spring Security. You can also consider it as an improvement if you want. It's up to you. was (Author: dtrunk90): I was thinking about this as well when creating the issue, but I think it is a bug. As mentioned in [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347] it is looking for a userLogin in context which is never set before. I did a workaround in my customPriceCalcService for now as we are using Spring Security. You can also consider it as an improvement if you want. > No userLogin given in calculateProductPrice service call context > > > Key: OFBIZ-10842 > URL: https://issues.apache.org/jira/browse/OFBIZ-10842 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk >Reporter: Danny Trunk >Assignee: Jacques Le Roux >Priority: Major > > The call context for calculateProductPrice doesn't contain the userLogin: > [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java?view=markup#l1195] > As this is needed in the customPriceCalcService: > [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347] > > So currently there's no chance to get the user information in a custom price > calc service. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10842) No userLogin given in calculateProductPrice service call context
[ https://issues.apache.org/jira/browse/OFBIZ-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779173#comment-16779173 ] Danny Trunk commented on OFBIZ-10842: - I was thinking about this as well when creating the issue, but I think it is a bug. As mentioned in [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347] it is looking for a userLogin in context which is never set before. I did a workaround in my customPriceCalcService for now as we are using Spring Security. You can also consider it as an improvement if you want. > No userLogin given in calculateProductPrice service call context > > > Key: OFBIZ-10842 > URL: https://issues.apache.org/jira/browse/OFBIZ-10842 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk >Reporter: Danny Trunk >Assignee: Jacques Le Roux >Priority: Major > > The call context for calculateProductPrice doesn't contain the userLogin: > [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java?view=markup#l1195] > As this is needed in the customPriceCalcService: > [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347] > > So currently there's no chance to get the user information in a custom price > calc service. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10842) No userLogin given in calculateProductPrice service call context
[ https://issues.apache.org/jira/browse/OFBIZ-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779166#comment-16779166 ] Jacques Le Roux commented on OFBIZ-10842: - Thanks Danny, I wonder if we can consider this a bug. I'm not against backporting just wondering if it's rather not an improvement. > No userLogin given in calculateProductPrice service call context > > > Key: OFBIZ-10842 > URL: https://issues.apache.org/jira/browse/OFBIZ-10842 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk >Reporter: Danny Trunk >Assignee: Jacques Le Roux >Priority: Major > > The call context for calculateProductPrice doesn't contain the userLogin: > [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java?view=markup#l1195] > As this is needed in the customPriceCalcService: > [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347] > > So currently there's no chance to get the user information in a custom price > calc service. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10842) No userLogin given in calculateProductPrice service call context
[ https://issues.apache.org/jira/browse/OFBIZ-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10842: --- Assignee: Jacques Le Roux > No userLogin given in calculateProductPrice service call context > > > Key: OFBIZ-10842 > URL: https://issues.apache.org/jira/browse/OFBIZ-10842 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk >Reporter: Danny Trunk >Assignee: Jacques Le Roux >Priority: Major > > The call context for calculateProductPrice doesn't contain the userLogin: > [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java?view=markup#l1195] > As this is needed in the customPriceCalcService: > [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347] > > So currently there's no chance to get the user information in a custom price > calc service. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10833) CMS add content not working
[ https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779145#comment-16779145 ] Jacques Le Roux commented on OFBIZ-10833: - I indeed get "There is no Content PUBLISH_POINT for this WebSite!" on trunk demo as locally, when I saw it working locally a week ago. I guess a change committed between must be the reason. > CMS add content not working > --- > > Key: OFBIZ-10833 > URL: https://issues.apache.org/jira/browse/OFBIZ-10833 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk, 17.12.01 >Reporter: Ingo Wolfmayr >Assignee: Swapnil M Mane >Priority: Major > Attachments: OFBIZ-10833.patch > > > On demo: content --> "CmsSite" --> CMS: > Right click on one of the items to add "New Long Text" or "Image". > After saving the new content: > Edit WebSite CMS For: [] > "There is no Content PUBLISH_POINT for this WebSite!" > Having the same problem on a 17.12 local installation. > h1. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779092#comment-16779092
]
Jacques Le Roux edited comment on OFBIZ-10757 at 2/27/19 10:07 AM:
---
Taher,
I don't think we should let all the work to Deepak ;). When you say
bq. so perhaps it might be cleaner to avoid mixing concepts in one commit.
If you think about {{CacheSoftReference::finalize}} it's actually also a
warning shown by Java 11. There is another which is
{{SafeObjectInputStream.java:83: warning: [deprecation]
getProxyClass(ClassLoader,Class...) in Proxy has been deprecated}}
that I tried to fix yesterday but it's a bit more complicated because of the
need of an InvocationHandler.
bq. Maybe the getInstance method can also get some love, it throws too many
exceptions at the moment which kind of seems also too verbose?
I just tried to restrict to InvocationTargetException, but Eclipse (compliance
11, did not try to compile) does not agree and needs also those exceptions. We
need to improve the Javadoc actually.
was (Author: jacques.le.roux):
Taher,
I don't think we should let all the work to Deepak ;). When you say
bq. so perhaps it might be cleaner to avoid mixing concepts in one commit.
If you think about {{ CacheSoftReference::finalize}} it's actually also a
warning shown by Java 11. There is another which is
{{SafeObjectInputStream.java:83: warning: [deprecation]
getProxyClass(ClassLoader,Class...) in Proxy has been deprecated}}
that I tried to fix yesterday but it's a bit more complicated because of the
need of an InvocationHandler.
bq. Maybe the getInstance method can also get some love, it throws too many
exceptions at the moment which kind of seems also too verbose?
I just tried to restrict to InvocationTargetException, but Eclipse (compliance
11, did not try to compile) does not agree and needs also those exceptions. We
need to improve the Javadoc actually.
> Upgrade OFBiz to use Java JDK Version 11
>
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch,
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch,
> OFBIZ-10757-plugins.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779092#comment-16779092
]
Jacques Le Roux commented on OFBIZ-10757:
-
Taher,
I don't think we should let all the work to Deepak ;). When you say
bq. so perhaps it might be cleaner to avoid mixing concepts in one commit.
If you think about {{ CacheSoftReference::finalize}} it's actually also a
warning shown by Java 11. There is another which is
{{SafeObjectInputStream.java:83: warning: [deprecation]
getProxyClass(ClassLoader,Class...) in Proxy has been deprecated}}
that I tried to fix yesterday but it's a bit more complicated because of the
need of an InvocationHandler.
bq. Maybe the getInstance method can also get some love, it throws too many
exceptions at the moment which kind of seems also too verbose?
I just tried to restrict to InvocationTargetException, but Eclipse (compliance
11, did not try to compile) does not agree and needs also those exceptions. We
need to improve the Javadoc actually.
> Upgrade OFBiz to use Java JDK Version 11
>
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
> Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch,
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch,
> OFBIZ-10757-plugins.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10833) CMS add content not working
[ https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779058#comment-16779058 ] Ingo Wolfmayr commented on OFBIZ-10833: --- Hi Swapnil, thanks for your work!!! Unfortunately I cannot get it to work. I installed a fresh system with the current trunk and applied the patch. I also added a "print" output to get sure the code is reached - it does. *Manually creating content* via "create new content": The file is uploaded but the dataresource has no reference to it. *Using CMS (fresh trunk on OfbizSite):* right click "new Image". The image apears for about a second and disapears - "content association" is not created but content is created correctly and accessible via content search. Creating other content types via CMS does have the same problem. So I don't now by now if its a CMS problem or connected to issue you described. Best regards, Ingo > CMS add content not working > --- > > Key: OFBIZ-10833 > URL: https://issues.apache.org/jira/browse/OFBIZ-10833 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk, 17.12.01 >Reporter: Ingo Wolfmayr >Assignee: Swapnil M Mane >Priority: Major > Attachments: OFBIZ-10833.patch > > > On demo: content --> "CmsSite" --> CMS: > Right click on one of the items to add "New Long Text" or "Image". > After saving the new content: > Edit WebSite CMS For: [] > "There is no Content PUBLISH_POINT for this WebSite!" > Having the same problem on a 17.12 local installation. > h1. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777817#comment-16777817 ] Jacques Le Roux edited comment on OFBIZ-10757 at 2/27/19 9:14 AM: -- I think bumping java to 11 should be done _after_ Deepak completes his prep work. His commit is more of a preparation for java 11, so perhaps it might be cleaner to avoid mixing concepts in one commit. On the other hand, the patch looks much better. Maybe the getInstance method can also get some love, it throws too many exceptions at the moment which kind of seems also too verbose? was (Author: taher): I think bumping java to 11 should be done _after_ Deepak completes his prep work. His commit is more of a preparation for java 11, so perhaps it might be cleaner to avoid mixing concepts in one commit. On the other hand, the patch looks much better. Maybe the getInstance method can also get some love, it throws too many exceptions at the moment which kind of seems also too verbose? > Upgrade OFBiz to use Java JDK Version 11 > > > Key: OFBIZ-10757 > URL: https://issues.apache.org/jira/browse/OFBIZ-10757 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, > OFBIZ-10757-plugins.patch, OFBIZ-10757-plugins.patch > > > To implement as per [Discussion > Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache
[ https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779029#comment-16779029 ] Suraj Khurana commented on OFBIZ-10579: --- Hello Jacques, Didn't got a chance yet. Will check soon. Till then, if any further ideas/corrections in patch, please proceed. Engaged in some other high priority work for now. Thanks in advance !! > Date filtered queries with caching should be restricted to cache > > > Key: OFBIZ-10579 > URL: https://issues.apache.org/jira/browse/OFBIZ-10579 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10579.patch, OFBIZ-10579.patch > > > As per discussion on Dev ML > https://markmail.org/thread/3qnkihmsyhly3lsg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10842) No userLogin given in calculateProductPrice service call context
[
https://issues.apache.org/jira/browse/OFBIZ-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779028#comment-16779028
]
Danny Trunk edited comment on OFBIZ-10842 at 2/27/19 8:30 AM:
--
Adding
{code:java}
priceContext.put("userLogin", cart.getUserLogin());{code}
in ShoppingCartItem#updatePrice should do the trick. Same for
{code:java}
priceContext.put("autoUserLogin", cart.getAutoUserLogin());
{code}
which is also missing.
was (Author: dtrunk90):
Adding
{{{code:java}}}
priceContext.put("userLogin", cart.getUserLogin());`
{{{code}}} in ShoppingCartItem#updatePrice should do the trick. Same for
{{{code:java}}}
priceContext.put("autoUserLogin", cart.getAutoUserLogin());
{{{code}}}
which is also missing.
> No userLogin given in calculateProductPrice service call context
>
>
> Key: OFBIZ-10842
> URL: https://issues.apache.org/jira/browse/OFBIZ-10842
> Project: OFBiz
> Issue Type: Bug
> Components: order, product
>Affects Versions: Trunk
>Reporter: Danny Trunk
>Priority: Major
>
> The call context for calculateProductPrice doesn't contain the userLogin:
> [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java?view=markup#l1195]
> As this is needed in the customPriceCalcService:
> [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347]
>
> So currently there's no chance to get the user information in a custom price
> calc service.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10842) No userLogin given in calculateProductPrice service call context
[
https://issues.apache.org/jira/browse/OFBIZ-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779028#comment-16779028
]
Danny Trunk edited comment on OFBIZ-10842 at 2/27/19 8:29 AM:
--
Adding
{{{code:java}}}
priceContext.put("userLogin", cart.getUserLogin());`
{{{code}}} in ShoppingCartItem#updatePrice should do the trick. Same for
{{{code:java}}}
priceContext.put("autoUserLogin", cart.getAutoUserLogin());
{{{code}}}
which is also missing.
was (Author: dtrunk90):
Adding `priceContext.put("userLogin", cart.getUserLogin());` in
`ShoppingCartItem#updatePrice` should do the trick. Same for
`priceContext.put("autoUserLogin", cart.getAutoUserLogin());` which is also
missing.
> No userLogin given in calculateProductPrice service call context
>
>
> Key: OFBIZ-10842
> URL: https://issues.apache.org/jira/browse/OFBIZ-10842
> Project: OFBiz
> Issue Type: Bug
> Components: order, product
>Affects Versions: Trunk
>Reporter: Danny Trunk
>Priority: Major
>
> The call context for calculateProductPrice doesn't contain the userLogin:
> [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java?view=markup#l1195]
> As this is needed in the customPriceCalcService:
> [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347]
>
> So currently there's no chance to get the user information in a custom price
> calc service.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10842) No userLogin given in calculateProductPrice service call context
[
https://issues.apache.org/jira/browse/OFBIZ-10842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779028#comment-16779028
]
Danny Trunk commented on OFBIZ-10842:
-
Adding `priceContext.put("userLogin", cart.getUserLogin());` in
`ShoppingCartItem#updatePrice` should do the trick. Same for
`priceContext.put("autoUserLogin", cart.getAutoUserLogin());` which is also
missing.
> No userLogin given in calculateProductPrice service call context
>
>
> Key: OFBIZ-10842
> URL: https://issues.apache.org/jira/browse/OFBIZ-10842
> Project: OFBiz
> Issue Type: Bug
> Components: order, product
>Affects Versions: Trunk
>Reporter: Danny Trunk
>Priority: Major
>
> The call context for calculateProductPrice doesn't contain the userLogin:
> [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java?view=markup#l1195]
> As this is needed in the customPriceCalcService:
> [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347]
>
> So currently there's no chance to get the user information in a custom price
> calc service.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10842) No userLogin given in calculateProductPrice service call context
Danny Trunk created OFBIZ-10842: --- Summary: No userLogin given in calculateProductPrice service call context Key: OFBIZ-10842 URL: https://issues.apache.org/jira/browse/OFBIZ-10842 Project: OFBiz Issue Type: Bug Components: order, product Affects Versions: Trunk Reporter: Danny Trunk The call context for calculateProductPrice doesn't contain the userLogin: [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java?view=markup#l1195] As this is needed in the customPriceCalcService: [https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/price/PriceServices.java?view=markup#l347] So currently there's no chance to get the user information in a custom price calc service. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
