[jira] [Updated] (OFBIZ-10866) Use the ‘application’ and ‘distribution’ plugins

2019-03-18 Thread Mathieu Lirzin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin updated OFBIZ-10866:
---
Attachment: OFBIZ-10866_Use-the-application-and-distribution-plugin.patch

> Use the ‘application’ and ‘distribution’ plugins
> 
>
> Key: OFBIZ-10866
> URL: https://issues.apache.org/jira/browse/OFBIZ-10866
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-10866_Use-the-application-and-distribution-plugin.patch
>
>
> Gradle provides some useful standard plugins for launching and packaging 
> applications via the the {{application}} and {{distribution}} plugins.
>  * The [{{application}} 
> plugin|https://docs.gradle.org/current/userguide/application_plugin.html] 
> provides a {{run}} task which is an alternative to the rule based generated 
> run tasks.  Arbitrary command line arguments can be passed to OFBiz via the 
> {{--args}} option.
>  * The [{{distribution}} 
> plugin|https://docs.gradle.org/current/userguide/distribution_plugin.html] is 
> complementing the {{application}} plugin by providing a straightforward and 
> easy way to distribute OFBiz with its dependencies which is convenient in a 
> deployment context.  After extracting the distribution archive, OFBiz can 
> then be launched via a robust shell or batch script.
> The default targets must be been refined to not build the distribution 
> archives which can be a bit long in the context of OFBiz where we have a lot 
> of dependencies.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10866) Use the ‘application’ and ‘distribution’ plugins

2019-03-18 Thread Mathieu Lirzin (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathieu Lirzin updated OFBIZ-10866:
---
Attachment: (was: 
OFBIZ-10866_Use-the-application-and-distribution-plugin.patch)

> Use the ‘application’ and ‘distribution’ plugins
> 
>
> Key: OFBIZ-10866
> URL: https://issues.apache.org/jira/browse/OFBIZ-10866
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Gradle provides some useful standard plugins for launching and packaging 
> applications via the the {{application}} and {{distribution}} plugins.
>  * The [{{application}} 
> plugin|https://docs.gradle.org/current/userguide/application_plugin.html] 
> provides a {{run}} task which is an alternative to the rule based generated 
> run tasks.  Arbitrary command line arguments can be passed to OFBiz via the 
> {{--args}} option.
>  * The [{{distribution}} 
> plugin|https://docs.gradle.org/current/userguide/distribution_plugin.html] is 
> complementing the {{application}} plugin by providing a straightforward and 
> easy way to distribute OFBiz with its dependencies which is convenient in a 
> deployment context.  After extracting the distribution archive, OFBiz can 
> then be launched via a robust shell or batch script.
> The default targets must be been refined to not build the distribution 
> archives which can be a bit long in the context of OFBiz where we have a lot 
> of dependencies.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10866) Use the ‘application’ and ‘distribution’ plugins

2019-03-18 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795447#comment-16795447
 ] 

Mathieu Lirzin commented on OFBIZ-10866:


Hello Taher,

The behaviour of rule-tasks has been relaxed to depend on the {{:jar}} task 
instead of the {{:build}} task to not trigger the compilation of the 
distribution archives.  The side effect of this change is that unit tests are 
not triggered by those rule-tasks anymore which is matching the behavior of the 
{{:run}} task.

> Use the ‘application’ and ‘distribution’ plugins
> 
>
> Key: OFBIZ-10866
> URL: https://issues.apache.org/jira/browse/OFBIZ-10866
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-10866_Use-the-application-and-distribution-plugin.patch
>
>
> Gradle provides some useful standard plugins for launching and packaging 
> applications via the the {{application}} and {{distribution}} plugins.
>  * The [{{application}} 
> plugin|https://docs.gradle.org/current/userguide/application_plugin.html] 
> provides a {{run}} task which is an alternative to the rule based generated 
> run tasks.  Arbitrary command line arguments can be passed to OFBiz via the 
> {{--args}} option.
>  * The [{{distribution}} 
> plugin|https://docs.gradle.org/current/userguide/distribution_plugin.html] is 
> complementing the {{application}} plugin by providing a straightforward and 
> easy way to distribute OFBiz with its dependencies which is convenient in a 
> deployment context.  After extracting the distribution archive, OFBiz can 
> then be launched via a robust shell or batch script.
> The default targets must be been refined to not build the distribution 
> archives which can be a bit long in the context of OFBiz where we have a lot 
> of dependencies.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10866) Use the ‘application’ and ‘distribution’ plugins

2019-03-18 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795139#comment-16795139
 ] 

Taher Alkhateeb commented on OFBIZ-10866:
-

Hi Mathieu,

Quick question, does this affect the way the rule-tasks operate (ofbiz, 
ofbizDebug, etc ...) or does it operate as intended?

> Use the ‘application’ and ‘distribution’ plugins
> 
>
> Key: OFBIZ-10866
> URL: https://issues.apache.org/jira/browse/OFBIZ-10866
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-10866_Use-the-application-and-distribution-plugin.patch
>
>
> Gradle provides some useful standard plugins for launching and packaging 
> applications via the the {{application}} and {{distribution}} plugins.
>  * The [{{application}} 
> plugin|https://docs.gradle.org/current/userguide/application_plugin.html] 
> provides a {{run}} task which is an alternative to the rule based generated 
> run tasks.  Arbitrary command line arguments can be passed to OFBiz via the 
> {{--args}} option.
>  * The [{{distribution}} 
> plugin|https://docs.gradle.org/current/userguide/distribution_plugin.html] is 
> complementing the {{application}} plugin by providing a straightforward and 
> easy way to distribute OFBiz with its dependencies which is convenient in a 
> deployment context.  After extracting the distribution archive, OFBiz can 
> then be launched via a robust shell or batch script.
> The default targets must be been refined to not build the distribution 
> archives which can be a bit long in the context of OFBiz where we have a lot 
> of dependencies.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

2019-03-18 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795051#comment-16795051
 ] 

Swapnil M Mane commented on OFBIZ-4690:
---

No worries [~jacques.le.roux], please take your time. :)

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 
> --
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>Reporter: Ankit Jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

2019-03-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795047#comment-16795047
 ] 

Jacques Le Roux commented on OFBIZ-4690:


Hi Swapnil,

Bear with me, being buzy I'll not be able to answer before a week or two...

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 
> --
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>Reporter: Ankit Jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

2019-03-18 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794917#comment-16794917
 ] 

Swapnil M Mane commented on OFBIZ-4690:
---

Thank you [~ankit.jain] and [~jacques.le.roux] for your contribution.

I think we should handle the following case:
A transaction in running in which Picklist entity is updated, now if the 
transaction is rollback the picklist status will not be updated but since we 
call the cancelPicklistAndItems in async mode, the picklist item's status will 
get updated.

So the situation here is status of Picklist is not updated, but status of 
Picklist items are updated.

Here are two possible solutions:

1.) Run the eca on "commit" event.
2.) Call cancelPicklistAndItems action service in sync mode.

Please let me know thoughts or and let me know if I missed anything.

Thanks!

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 
> --
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release 10.04, Release Branch 11.04, Trunk
>Reporter: Ankit Jain
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId 
> should also get Cancel. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10866) Use the ‘application’ and ‘distribution’ plugins

2019-03-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794820#comment-16794820
 ] 

Jacques Le Roux commented on OFBIZ-10866:
-

Hi Mathieu,

Yes but currently {{gradlew clean build}} generates both archives in ~20 sec. 
As I said not a big deal with me, just saying.

> Use the ‘application’ and ‘distribution’ plugins
> 
>
> Key: OFBIZ-10866
> URL: https://issues.apache.org/jira/browse/OFBIZ-10866
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-10866_Use-the-application-and-distribution-plugin.patch
>
>
> Gradle provides some useful standard plugins for launching and packaging 
> applications via the the {{application}} and {{distribution}} plugins.
>  * The [{{application}} 
> plugin|https://docs.gradle.org/current/userguide/application_plugin.html] 
> provides a {{run}} task which is an alternative to the rule based generated 
> run tasks.  Arbitrary command line arguments can be passed to OFBiz via the 
> {{--args}} option.
>  * The [{{distribution}} 
> plugin|https://docs.gradle.org/current/userguide/distribution_plugin.html] is 
> complementing the {{application}} plugin by providing a straightforward and 
> easy way to distribute OFBiz with its dependencies which is convenient in a 
> deployment context.  After extracting the distribution archive, OFBiz can 
> then be launched via a robust shell or batch script.
> The default targets must be been refined to not build the distribution 
> archives which can be a bit long in the context of OFBiz where we have a lot 
> of dependencies.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)