[jira] [Closed] (OFBIZ-10929) Duplicate a ShoppingCartItem didn't propage OrderItemAttributes
[
https://issues.apache.org/jira/browse/OFBIZ-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-10929.
-
Resolution: Fixed
Fix Version/s: 18.12.01
Upcoming Branch
16.11.06
17.12.01
> Duplicate a ShoppingCartItem didn't propage OrderItemAttributes
> ---
>
> Key: OFBIZ-10929
> URL: https://issues.apache.org/jira/browse/OFBIZ-10929
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk, 17.12.01, 16.11.05, 18.12.01
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 17.12.01, 16.11.06, Upcoming Branch, 18.12.01
>
>
> When you clone a ShoppingCartItem by constructor
> {code:java}
> new ShoppingCartItem(ShoppingCartItem item){code}
> Values contains on list OrderItemAttributes aren't propage to the new
> shoppingCartItem due to (ShoppingCartItem.java:682)
> {code:java}
> if (UtilValidate.isEmpty(item.getOrderItemAttributes())) {
> this.orderItemAttributes = new HashMap<>();
> this.orderItemAttributes.putAll(item.getOrderItemAttributes());
> }
> {code}
> isEmpty instead of isNotEmpty
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10929) Duplicate a ShoppingCartItem didn't propage OrderItemAttributes
[
https://issues.apache.org/jira/browse/OFBIZ-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819430#comment-16819430
]
Nicolas Malin commented on OFBIZ-10929:
---
Commit the correction at revision :
* trunk : 1857657
* 18.12 : 1857658
* 17.12 : 1857659
* 16.10 : 1857660
> Duplicate a ShoppingCartItem didn't propage OrderItemAttributes
> ---
>
> Key: OFBIZ-10929
> URL: https://issues.apache.org/jira/browse/OFBIZ-10929
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Trunk, 17.12.01, 16.11.05, 18.12.01
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>
> When you clone a ShoppingCartItem by constructor
> {code:java}
> new ShoppingCartItem(ShoppingCartItem item){code}
> Values contains on list OrderItemAttributes aren't propage to the new
> shoppingCartItem due to (ShoppingCartItem.java:682)
> {code:java}
> if (UtilValidate.isEmpty(item.getOrderItemAttributes())) {
> this.orderItemAttributes = new HashMap<>();
> this.orderItemAttributes.putAll(item.getOrderItemAttributes());
> }
> {code}
> isEmpty instead of isNotEmpty
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10929) Duplicate a ShoppingCartItem didn't propage OrderItemAttributes
Nicolas Malin created OFBIZ-10929:
-
Summary: Duplicate a ShoppingCartItem didn't propage
OrderItemAttributes
Key: OFBIZ-10929
URL: https://issues.apache.org/jira/browse/OFBIZ-10929
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: 16.11.05, Trunk, 17.12.01, 18.12.01
Reporter: Nicolas Malin
Assignee: Nicolas Malin
When you clone a ShoppingCartItem by constructor
{code:java}
new ShoppingCartItem(ShoppingCartItem item){code}
Values contains on list OrderItemAttributes aren't propage to the new
shoppingCartItem due to (ShoppingCartItem.java:682)
{code:java}
if (UtilValidate.isEmpty(item.getOrderItemAttributes())) {
this.orderItemAttributes = new HashMap<>();
this.orderItemAttributes.putAll(item.getOrderItemAttributes());
}
{code}
isEmpty instead of isNotEmpty
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10844) Ecommerce AnonContactus.ftl doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-10844: Attachment: OFBIZ-10844.patch > Ecommerce AnonContactus.ftl doesn't work > > > Key: OFBIZ-10844 > URL: https://issues.apache.org/jira/browse/OFBIZ-10844 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: 16.11.04 > Environment: Win10 + OFBiz 16.11.04 + mysql. >Reporter: Schumann Ye >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-10844.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Ecommerce "Contact Us" with anonymous login doesn't work after filling in > email and all necessary info. > The root cause is the simple method "sendContactUsEmailToCompany" within > the file > \applications\party\minilang\communication\CommunicationEventServices.xml has > defined the field "sendFrom" as inputted email address from the anonymous > users. > To fix it, it should be changed as follows: > > While the email "yourmailaddr...@example.com" should have been properly set > up in your system. > It works for me! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10844) Ecommerce AnonContactus.ftl doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818966#comment-16818966 ] Pawan Verma commented on OFBIZ-10844: - As per my understanding, sendFrom email cannot be the customer's email address. Email settings for this email are maintained at ProductStoreEmailSetting with CONT_NOTI_EMAIL as emailType and like other notifications, we should use ProductStoreEmailSetting.fromAddress to send this email which is configurable. I have attached a patch for this change, please have a look and let me know your thoughts on this. Thanks! > Ecommerce AnonContactus.ftl doesn't work > > > Key: OFBIZ-10844 > URL: https://issues.apache.org/jira/browse/OFBIZ-10844 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: 16.11.04 > Environment: Win10 + OFBiz 16.11.04 + mysql. >Reporter: Schumann Ye >Assignee: Pawan Verma >Priority: Minor > Original Estimate: 0h > Remaining Estimate: 0h > > Ecommerce "Contact Us" with anonymous login doesn't work after filling in > email and all necessary info. > The root cause is the simple method "sendContactUsEmailToCompany" within > the file > \applications\party\minilang\communication\CommunicationEventServices.xml has > defined the field "sendFrom" as inputted email address from the anonymous > users. > To fix it, it should be changed as follows: > > While the email "yourmailaddr...@example.com" should have been properly set > up in your system. > It works for me! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10927) Can't set (expected) start and end date of project when creating a project
[ https://issues.apache.org/jira/browse/OFBIZ-10927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-10927: --- Assignee: Pawan Verma > Can't set (expected) start and end date of project when creating a project > -- > > Key: OFBIZ-10927 > URL: https://issues.apache.org/jira/browse/OFBIZ-10927 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pawan Verma >Priority: Major > > When a new project is initialised the expected start and end date are > essential for resource allocation, defining phases and tasks. > However, it is not possible to set these dates. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10837) Improve ObjectInputStream class
[ https://issues.apache.org/jira/browse/OFBIZ-10837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10837. --- Resolution: Implemented For more than 2 weeks, every evening check that there are no "Incompatible class" in demos (trunk, R16) log. I did not find any since and nobody reported anything. So I close, we can still reopen if needed. > Improve ObjectInputStream class > --- > > Key: OFBIZ-10837 > URL: https://issues.apache.org/jira/browse/OFBIZ-10837 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 16.11, Release Branch 17.12, Release > Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > > As reported by FindBugs and Sonar, it's troubling (a Bad practice in > Sonar[1], a code smell in Findbugs[2]) when extending to use the same name > than the extended Object.[3] > [1] > [https://sbforge.org/sonar/rules/show/findbugs:NM_SAME_SIMPLE_NAME_AS_SUPERCLASS?layout=false] > [2] [https://logging.apache.org/log4j/log4j-2.2/log4j-jul/findbugs.html] > [3] Bug: The class name org.apache.ofbiz.base.util.ObjectInputStream shadows > the simple name of the superclass java.io.ObjectInputStream > This class has a simple name that is identical to that of its superclass, > except that its superclass is in a different package (e.g., alpha.Foo extends > beta.Foo). This can be exceptionally confusing, create lots of situations in > which you have to look at import statements to resolve references and creates > many opportunities to accidentally define methods that do not override > methods in their superclasses. > Rank: Troubling (14), confidence: High > Pattern: NM_SAME_SIMPLE_NAME_AS_SUPERCLASS > Type: Nm, Category: BAD_PRACTICE (Bad practice) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10921) Marital Status not managed properly in Person entity
[ https://issues.apache.org/jira/browse/OFBIZ-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818801#comment-16818801 ] Jacques Le Roux commented on OFBIZ-10921: - +1 Paul > Marital Status not managed properly in Person entity > > > Key: OFBIZ-10921 > URL: https://issues.apache.org/jira/browse/OFBIZ-10921 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > Currently, *maritalStatus* is managed as an indicator (Y/N) in *Person* > entity. I think we can enhance it and make it derived from *Enumeration* > pattern. > > *Classification of legal marital status* > > - 1 - Married (and not separated) ... > - 2 - Widowed (including living common law) ... > - 3 - Separated (and not Divorced) ... > - 4 - Divorced (including living common law) ... > - 5 - Single (including living common law) > Please refer discussion over ML: > [https://markmail.org/message/5b33qm3osy76if24] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10921) Marital Status not managed properly in Person entity
[ https://issues.apache.org/jira/browse/OFBIZ-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818753#comment-16818753 ] Paul Foxworthy commented on OFBIZ-10921: Thanks Pierre. I agree implementers may well change this to suit their own needs. Changing marital status to an enum will facilitate customisation, so I'd be happy for Suraj to proceed with that. And I'm happy with attached patches for different use cases. After that, there should probably be some default demonstration data as there is for many other entities. Some implementers will not care much about this and won't change from the defaults. So I'd prefer that our demonstration data should be minimal and lowest common denominator. When a new OFBiz developer uses the standard demo data, we should keep it simple and minimise the chance of embarrassment, distraction and objections from potential clients. > Marital Status not managed properly in Person entity > > > Key: OFBIZ-10921 > URL: https://issues.apache.org/jira/browse/OFBIZ-10921 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > Currently, *maritalStatus* is managed as an indicator (Y/N) in *Person* > entity. I think we can enhance it and make it derived from *Enumeration* > pattern. > > *Classification of legal marital status* > > - 1 - Married (and not separated) ... > - 2 - Widowed (including living common law) ... > - 3 - Separated (and not Divorced) ... > - 4 - Divorced (including living common law) ... > - 5 - Single (including living common law) > Please refer discussion over ML: > [https://markmail.org/message/5b33qm3osy76if24] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10921) Marital Status not managed properly in Person entity
[ https://issues.apache.org/jira/browse/OFBIZ-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818737#comment-16818737 ] Pierre Smits commented on OFBIZ-10921: -- I don't believe that one single solution to this issue will satisfy any adopter (in whatever country, governed by whatever moral code or legal regulation). I would therefore suggest that we do not implement any given solution to enhance this in our code base, but rather have those propositions live here as attached patches. That way, each adopter can choose whatever fits and apply locally in their implementation. Best regards, Pierre Smits > Marital Status not managed properly in Person entity > > > Key: OFBIZ-10921 > URL: https://issues.apache.org/jira/browse/OFBIZ-10921 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > Currently, *maritalStatus* is managed as an indicator (Y/N) in *Person* > entity. I think we can enhance it and make it derived from *Enumeration* > pattern. > > *Classification of legal marital status* > > - 1 - Married (and not separated) ... > - 2 - Widowed (including living common law) ... > - 3 - Separated (and not Divorced) ... > - 4 - Divorced (including living common law) ... > - 5 - Single (including living common law) > Please refer discussion over ML: > [https://markmail.org/message/5b33qm3osy76if24] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10612) Cannot bill to clients that are not Groups
[ https://issues.apache.org/jira/browse/OFBIZ-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818730#comment-16818730 ] Pierre Smits commented on OFBIZ-10612: -- Hi [~Suastiastu], It seems you're requesting an improvement. You can set the a party that is to be billed/invoiced for time spent on a project. Can you elaborate on the use case? > Cannot bill to clients that are not Groups > -- > > Key: OFBIZ-10612 > URL: https://issues.apache.org/jira/browse/OFBIZ-10612 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Affects Versions: 16.11.05 >Reporter: Greg Finlayson >Priority: Major > Attachments: image-2018-10-22-00-44-07-313.png, image.png > > > I cannot bill a project to a client which is not a group > !image-2018-10-22-00-44-07-313.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10612) Cannot bill to clients that are not Groups
[ https://issues.apache.org/jira/browse/OFBIZ-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10612: - Attachment: image.png > Cannot bill to clients that are not Groups > -- > > Key: OFBIZ-10612 > URL: https://issues.apache.org/jira/browse/OFBIZ-10612 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Affects Versions: 16.11.05 >Reporter: Greg Finlayson >Priority: Major > Attachments: image-2018-10-22-00-44-07-313.png, image.png > > > I cannot bill a project to a client which is not a group > !image-2018-10-22-00-44-07-313.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10921) Marital Status not managed properly in Person entity
[ https://issues.apache.org/jira/browse/OFBIZ-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818726#comment-16818726 ] Paul Foxworthy commented on OFBIZ-10921: Of course how this attribute will be used will vary from one OFBiz implementation to another. It may be necessary and appropriate to ask this question and expect one of these answers for a specific system. But I am uncomfortable about the assumptions and intrusiveness of this list. There are situations such as employment where it is discriminatory and illegal to ask this sort of question. I don't think the detailed legal status of a customer's relationship is relevant to a business trying to sell goods or services. Some indication of household status might be useful for demographics and marketing. If it's clearer to a customer what you want to know and why, they would be more likely to answer the question. So I suggest standard OFBiz demonstrates a different list along these lines: Single (never married, separated, divorced, widowed) Partnered (married or de facto) Rather Not Say > Marital Status not managed properly in Person entity > > > Key: OFBIZ-10921 > URL: https://issues.apache.org/jira/browse/OFBIZ-10921 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > Currently, *maritalStatus* is managed as an indicator (Y/N) in *Person* > entity. I think we can enhance it and make it derived from *Enumeration* > pattern. > > *Classification of legal marital status* > > - 1 - Married (and not separated) ... > - 2 - Widowed (including living common law) ... > - 3 - Separated (and not Divorced) ... > - 4 - Divorced (including living common law) ... > - 5 - Single (including living common law) > Please refer discussion over ML: > [https://markmail.org/message/5b33qm3osy76if24] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10928) In creating new task on a project, phases of other projects are shown
Pierre Smits created OFBIZ-10928: Summary: In creating new task on a project, phases of other projects are shown Key: OFBIZ-10928 URL: https://issues.apache.org/jira/browse/OFBIZ-10928 Project: OFBiz Issue Type: Bug Components: projectmgr Affects Versions: Release Branch 16.11, Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Pierre Smits When creating a new task on an existing project (see [1]), the phases of other projects are shown and selectable. This should not be possible. A project manager may only create tasks for the projects he is managing, and should only be able create tasks for phases in another project when he is in a project. [1] https://demo-trunk.ofbiz.apache.org/projectmgr/control/EditProjectTasks?projectId=9000 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-8143) When Creating an Order from a Quote, the items are added to the purchase order in reverse order
[ https://issues.apache.org/jira/browse/OFBIZ-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818715#comment-16818715 ] Nicolas Malin commented on OFBIZ-8143: -- Hello, we had the problem drop ship process and we solved it with different way [^OFBIZ-8143-other-implementation.patch]. I didn't test form Quote, maybe this solution from standard cart work also from Quote > When Creating an Order from a Quote, the items are added to the purchase > order in reverse order > --- > > Key: OFBIZ-8143 > URL: https://issues.apache.org/jira/browse/OFBIZ-8143 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Forrest Rae >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-8143-other-implementation.patch, OFBIZ-8143.patch > > > When creating an order from a Quote, if a purchase order is required (due to > dropship) the items are added to the purchase order in reverse order as they > appear on the quote and sales order. This is because the call to > ShoppingCartItem.makePurchaseOrderItem() is made with the first argument > always set to 0, thus adding the all items as the first item. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-8143) When Creating an Order from a Quote, the items are added to the purchase order in reverse order
[ https://issues.apache.org/jira/browse/OFBIZ-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-8143: - Attachment: OFBIZ-8143-other-implementation.patch > When Creating an Order from a Quote, the items are added to the purchase > order in reverse order > --- > > Key: OFBIZ-8143 > URL: https://issues.apache.org/jira/browse/OFBIZ-8143 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Forrest Rae >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-8143-other-implementation.patch, OFBIZ-8143.patch > > > When creating an order from a Quote, if a purchase order is required (due to > dropship) the items are added to the purchase order in reverse order as they > appear on the quote and sales order. This is because the call to > ShoppingCartItem.makePurchaseOrderItem() is made with the first argument > always set to 0, thus adding the all items as the first item. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10927) Can't set (expected) start and end date of project when creating a project
Pierre Smits created OFBIZ-10927: Summary: Can't set (expected) start and end date of project when creating a project Key: OFBIZ-10927 URL: https://issues.apache.org/jira/browse/OFBIZ-10927 Project: OFBiz Issue Type: Bug Components: projectmgr Affects Versions: Release Branch 16.11, Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Pierre Smits When a new project is initialised the expected start and end date are essential for resource allocation, defining phases and tasks. However, it is not possible to set these dates. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7934) Add tax to billed hours
[ https://issues.apache.org/jira/browse/OFBIZ-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-7934: Component/s: (was: scrum) (was: projectmgr) > Add tax to billed hours > --- > > Key: OFBIZ-7934 > URL: https://issues.apache.org/jira/browse/OFBIZ-7934 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Major > Labels: billing, invoice, project, scrum, tax > > Following the discussion on this thread : > https://lists.apache.org/thread.html/ff183c2f074bc35479a07b5acf80b58721d66b8b8c6b753f97f755aa@%3Cuser.ofbiz.apache.org%3E > To sum up : When creating an invoice from a project (from thje Scrum or > Project component), we can't apply any taxes because there is no Product > associated to the invoice item (the billied hours). > The main solution aims to link the WorkEffort, on which the hours are spent, > to a Product by using the entity WorkEffortGoodSatandard. > This Jira can be used to improve/complete the solution and to pass from > conception step to implementation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7934) Add tax to billed hours
[ https://issues.apache.org/jira/browse/OFBIZ-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818709#comment-16818709 ] Pierre Smits commented on OFBIZ-7934: - This is not an issue regarding the projec component or scrum, but solely an issue regarding accounting. Removing superfluous components. > Add tax to billed hours > --- > > Key: OFBIZ-7934 > URL: https://issues.apache.org/jira/browse/OFBIZ-7934 > Project: OFBiz > Issue Type: Improvement > Components: accounting, projectmgr, scrum >Affects Versions: Trunk >Reporter: Montalbano Florian >Priority: Major > Labels: billing, invoice, project, scrum, tax > > Following the discussion on this thread : > https://lists.apache.org/thread.html/ff183c2f074bc35479a07b5acf80b58721d66b8b8c6b753f97f755aa@%3Cuser.ofbiz.apache.org%3E > To sum up : When creating an invoice from a project (from thje Scrum or > Project component), we can't apply any taxes because there is no Product > associated to the invoice item (the billied hours). > The main solution aims to link the WorkEffort, on which the hours are spent, > to a Product by using the entity WorkEffortGoodSatandard. > This Jira can be used to improve/complete the solution and to pass from > conception step to implementation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-6039) Orders and Consents
[ https://issues.apache.org/jira/browse/OFBIZ-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-6039. Resolution: Won't Do I close this issue as regard comments > Orders and Consents > --- > > Key: OFBIZ-6039 > URL: https://issues.apache.org/jira/browse/OFBIZ-6039 > Project: OFBiz > Issue Type: New Feature > Components: order >Reporter: Kongrath Suankaewmanee >Priority: Minor > Labels: agreement(s) > > We need to be able to make a relationship between the agreements with orders. > And I still don't see anywhere to link agreements with a specific order. > In the business case, By confirming the purchase order, customer need to > agree on the purchase terms. Also, there will need to be a specific indicator > in the database to capture that the customer has indeed agreed to the terms > and the datetime stamp of this consent. > This is our solution and maybe a best way to add a new entity. > AgreementOrderAppl: > agreementId > agreementItemSeqId > orderId > orderItemSeqId > Link: > http://ofbiz.135035.n4.nabble.com/orders-and-contracts-td2248364.html#a2248681 > Any opinions here? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10922) Update build.gradle to the latest dependencies
[
https://issues.apache.org/jira/browse/OFBIZ-10922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818680#comment-16818680
]
Jacques Le Roux commented on OFBIZ-10922:
-
h2. Note about plugins:
I tried to updated lucene from 7.5.0 to 8.0.0 but got this:
{noformat}
C:\projectsASF\ofbiz\plugins\lucene\src\main\java\org\apache\ofbiz\content\test\LuceneTests.java:102:
error: no suitable method found for create(int)
TopScoreDocCollector collector = TopScoreDocCollector.create(10);
^
method TopScoreDocCollector.create(int,int) is not applicable
(actual and formal argument lists differ in length)
method TopScoreDocCollector.create(int,ScoreDoc,int) is not applicable
(actual and formal argument lists differ in length)
{noformat}
Upgrading poi from 3.17 to 4.1.0 seems to work but I did not test it
Upgrading cas-server-core from 3.3.5 to 4.2.7 gives this:
{noformat}
C:\projectsASF\ofbiz\plugins\ldap\src\main\java\org\apache\ofbiz\ldap\activedirectory\OFBizActiveDirectoryAuthenticationHandler.java:32:
error: cannot find symbol
import org.jasig.cas.util.LdapUtils;
^
symbol: class LdapUtils
location: package org.jasig.cas.util
C:\projectsASF\ofbiz\plugins\ldap\src\main\java\org\apache\ofbiz\ldap\openldap\OFBizLdapAuthenticationHandler.java:30:
error: cannot find symbol
import org.jasig.cas.util.LdapUtils;
^
symbol: class LdapUtils
location: package org.jasig.cas.util
C:\projectsASF\ofbiz\framework\entity\src\main\java\org\apache\ofbiz\entity\connection\DBCPConnectionFactory.java:114:
warning: [deprecation] setEnableAutoCommitOnReturn(boolean) in
PoolableConnectionFactory has been depreca
factory.setEnableAutoCommitOnReturn(false);
^
C:\projectsASF\ofbiz\plugins\ldap\src\main\java\org\apache\ofbiz\ldap\activedirectory\OFBizActiveDirectoryAuthenticationHandler.java:94:
error: cannot find symbol
attribute = LdapUtils.getFilterWithValues(attribute, username);
^
symbol: variable LdapUtils
location: class OFBizActiveDirectoryAuthenticationHandler
C:\projectsASF\ofbiz\plugins\ldap\src\main\java\org\apache\ofbiz\ldap\openldap\OFBizLdapAuthenticationHandler.java:79:
error: cannot find symbol
attribute = LdapUtils.getFilterWithValues(attribute, username);
^
symbol: variable LdapUtils
location: class OFBizLdapAuthenticationHandler
4 errors
{noformat}
> Update build.gradle to the latest dependencies
> --
>
> Key: OFBIZ-10922
> URL: https://issues.apache.org/jira/browse/OFBIZ-10922
> Project: OFBiz
> Issue Type: Sub-task
> Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10922.patch, OFBIZ-10922.patch, OFBIZ-10922.patch,
> report.txt
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10925) Wrong permission check in ProductScreens#FindProduct
[
https://issues.apache.org/jira/browse/OFBIZ-10925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818674#comment-16818674
]
Deepak Dixit commented on OFBIZ-10925:
--
This has been done at
OFBiz trunk framework at r#1857617
OFBiz R18.12 framework at r#1857619
OFBiz R17.12 framework at r#1857620
OFBiz R16.11 at r#1857621
This permission check was from the beginning of this feature, committed at
r#1032077
Thanks Dennis Balkir for your contribution.
> Wrong permission check in ProductScreens#FindProduct
>
>
> Key: OFBIZ-10925
> URL: https://issues.apache.org/jira/browse/OFBIZ-10925
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Reporter: Dennis Balkir
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-10925_ProductScreens.patch
>
>
> The permission service {{acctgAgreementPermissionCheck}} is used in the
> screen {{FindProduct}} in {{ProductScreens.xml}}. This doesn't really make
> sense, since there is no connection to the accounting application here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10925) Wrong permission check in ProductScreens#FindProduct
[
https://issues.apache.org/jira/browse/OFBIZ-10925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit closed OFBIZ-10925.
Resolution: Fixed
Fix Version/s: 16.11.06
> Wrong permission check in ProductScreens#FindProduct
>
>
> Key: OFBIZ-10925
> URL: https://issues.apache.org/jira/browse/OFBIZ-10925
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Reporter: Dennis Balkir
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 16.11.06
>
> Attachments: OFBIZ-10925_ProductScreens.patch
>
>
> The permission service {{acctgAgreementPermissionCheck}} is used in the
> screen {{FindProduct}} in {{ProductScreens.xml}}. This doesn't really make
> sense, since there is no connection to the accounting application here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
