[jira] [Commented] (OFBIZ-10932) Updating an OrderItem loses supplierProductId

2019-04-18 Thread Paul Foxworthy (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821681#comment-16821681
 ] 

Paul Foxworthy commented on OFBIZ-10932:


Thanks [~swapnilmmane]

> Updating an OrderItem loses supplierProductId
> -
>
> Key: OFBIZ-10932
> URL: https://issues.apache.org/jira/browse/OFBIZ-10932
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 17.12.01, 18.12.01
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
>  Labels: order, order_item
> Fix For: Trunk, 17.12.01, 18.12.01
>
> Attachments: 
> OFBIZ-10932_Preserve_supplierProductId_when_updating_OrderItem.patch
>
>
> When you edit on order item, the details are reloaded into a shopping cart 
> and after editing the order is updated from the cart. At present the 
> supplierProductId for the order item is not read into the cart.
>  
> Try this in the demo site:
> Product GZ-1000 has several suppliers, including BigSupplier
>  Order-Order Entry
>  In Purchase Order, choose BigSupplier, click Continue
>  In "Enter Order, Agreements and Ship Dates", click Continue
>  In Create Purchase Order, enter Product ID of GZ-1000 and Quantity of 500
>  Click Finalize Order
>  Click Continue several times to reach Purchase Order: Order Confirmation
>  Click Create Order
>  Note Purchase Order number. When I did this, it was 1
>  Applications - Web Tools
>  Click Entity Data Maintenance
>  In Filter by Entity Name, choose OrderItem, click Apply
>  Click OrderItem in the Entity Name column
>  Enter Purchase Order number, e.g. 1
>  Scroll down and click Search
>  Observe that the OrderItem has a SupplierProductId of BKGZ_1000 as you'd 
> expect
>  Applications - Order - Find Order
>  Enter Order ID (e.g. 1) and click Find
>  In Actions, click Edit Items
>  Change Unit Price from 3.75 to 4.00, check checkbox next to Unit Price, and 
> click Update Selected Items
>  Return to Entity Data Maintenance in the Web Tools, and find the OrderItem 
> for the purchase order again
>  You'll see that the SupplierProductId has been lost
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10932) Updating an OrderItem loses supplierProductId

2019-04-18 Thread Paul Foxworthy (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821680#comment-16821680
 ] 

Paul Foxworthy commented on OFBIZ-10932:


Fixed in trunk in r1857781.

Fixed in 17.12 in r1857783.

Fixed in 18.12 in r1857784.

> Updating an OrderItem loses supplierProductId
> -
>
> Key: OFBIZ-10932
> URL: https://issues.apache.org/jira/browse/OFBIZ-10932
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 17.12.01, 18.12.01
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
>  Labels: order, order_item
> Fix For: Trunk, 17.12.01, 18.12.01
>
> Attachments: 
> OFBIZ-10932_Preserve_supplierProductId_when_updating_OrderItem.patch
>
>
> When you edit on order item, the details are reloaded into a shopping cart 
> and after editing the order is updated from the cart. At present the 
> supplierProductId for the order item is not read into the cart.
>  
> Try this in the demo site:
> Product GZ-1000 has several suppliers, including BigSupplier
>  Order-Order Entry
>  In Purchase Order, choose BigSupplier, click Continue
>  In "Enter Order, Agreements and Ship Dates", click Continue
>  In Create Purchase Order, enter Product ID of GZ-1000 and Quantity of 500
>  Click Finalize Order
>  Click Continue several times to reach Purchase Order: Order Confirmation
>  Click Create Order
>  Note Purchase Order number. When I did this, it was 1
>  Applications - Web Tools
>  Click Entity Data Maintenance
>  In Filter by Entity Name, choose OrderItem, click Apply
>  Click OrderItem in the Entity Name column
>  Enter Purchase Order number, e.g. 1
>  Scroll down and click Search
>  Observe that the OrderItem has a SupplierProductId of BKGZ_1000 as you'd 
> expect
>  Applications - Order - Find Order
>  Enter Order ID (e.g. 1) and click Find
>  In Actions, click Edit Items
>  Change Unit Price from 3.75 to 4.00, check checkbox next to Unit Price, and 
> click Update Selected Items
>  Return to Entity Data Maintenance in the Web Tools, and find the OrderItem 
> for the purchase order again
>  You'll see that the SupplierProductId has been lost
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10932) Updating an OrderItem loses supplierProductId

2019-04-18 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821677#comment-16821677
 ] 

Swapnil M Mane commented on OFBIZ-10932:


Good catch, thanks [~paul_foxworthy].
The patch looks good to me and working as expected.

> Updating an OrderItem loses supplierProductId
> -
>
> Key: OFBIZ-10932
> URL: https://issues.apache.org/jira/browse/OFBIZ-10932
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 17.12.01, 18.12.01
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
>  Labels: order, order_item
> Fix For: Trunk, 17.12.01, 18.12.01
>
> Attachments: 
> OFBIZ-10932_Preserve_supplierProductId_when_updating_OrderItem.patch
>
>
> When you edit on order item, the details are reloaded into a shopping cart 
> and after editing the order is updated from the cart. At present the 
> supplierProductId for the order item is not read into the cart.
>  
> Try this in the demo site:
> Product GZ-1000 has several suppliers, including BigSupplier
>  Order-Order Entry
>  In Purchase Order, choose BigSupplier, click Continue
>  In "Enter Order, Agreements and Ship Dates", click Continue
>  In Create Purchase Order, enter Product ID of GZ-1000 and Quantity of 500
>  Click Finalize Order
>  Click Continue several times to reach Purchase Order: Order Confirmation
>  Click Create Order
>  Note Purchase Order number. When I did this, it was 1
>  Applications - Web Tools
>  Click Entity Data Maintenance
>  In Filter by Entity Name, choose OrderItem, click Apply
>  Click OrderItem in the Entity Name column
>  Enter Purchase Order number, e.g. 1
>  Scroll down and click Search
>  Observe that the OrderItem has a SupplierProductId of BKGZ_1000 as you'd 
> expect
>  Applications - Order - Find Order
>  Enter Order ID (e.g. 1) and click Find
>  In Actions, click Edit Items
>  Change Unit Price from 3.75 to 4.00, check checkbox next to Unit Price, and 
> click Update Selected Items
>  Return to Entity Data Maintenance in the Web Tools, and find the OrderItem 
> for the purchase order again
>  You'll see that the SupplierProductId has been lost
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10932) Updating an OrderItem loses supplierProductId

2019-04-18 Thread Paul Foxworthy (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Foxworthy updated OFBIZ-10932:
---
Fix Version/s: Trunk
   18.12.01
   17.12.01

> Updating an OrderItem loses supplierProductId
> -
>
> Key: OFBIZ-10932
> URL: https://issues.apache.org/jira/browse/OFBIZ-10932
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 17.12.01, 18.12.01
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
>  Labels: order, order_item
> Fix For: Trunk, 17.12.01, 18.12.01
>
> Attachments: 
> OFBIZ-10932_Preserve_supplierProductId_when_updating_OrderItem.patch
>
>
> When you edit on order item, the details are reloaded into a shopping cart 
> and after editing the order is updated from the cart. At present the 
> supplierProductId for the order item is not read into the cart.
>  
> Try this in the demo site:
> Product GZ-1000 has several suppliers, including BigSupplier
>  Order-Order Entry
>  In Purchase Order, choose BigSupplier, click Continue
>  In "Enter Order, Agreements and Ship Dates", click Continue
>  In Create Purchase Order, enter Product ID of GZ-1000 and Quantity of 500
>  Click Finalize Order
>  Click Continue several times to reach Purchase Order: Order Confirmation
>  Click Create Order
>  Note Purchase Order number. When I did this, it was 1
>  Applications - Web Tools
>  Click Entity Data Maintenance
>  In Filter by Entity Name, choose OrderItem, click Apply
>  Click OrderItem in the Entity Name column
>  Enter Purchase Order number, e.g. 1
>  Scroll down and click Search
>  Observe that the OrderItem has a SupplierProductId of BKGZ_1000 as you'd 
> expect
>  Applications - Order - Find Order
>  Enter Order ID (e.g. 1) and click Find
>  In Actions, click Edit Items
>  Change Unit Price from 3.75 to 4.00, check checkbox next to Unit Price, and 
> click Update Selected Items
>  Return to Entity Data Maintenance in the Web Tools, and find the OrderItem 
> for the purchase order again
>  You'll see that the SupplierProductId has been lost
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10932) Updating an OrderItem loses supplierProductId

2019-04-18 Thread Paul Foxworthy (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Foxworthy updated OFBIZ-10932:
---
Description: 
When you edit on order item, the details are reloaded into a shopping cart and 
after editing the order is updated from the cart. At present the 
supplierProductId for the order item is not read into the cart.

 

Try this in the demo site:

Product GZ-1000 has several suppliers, including BigSupplier
 Order-Order Entry
 In Purchase Order, choose BigSupplier, click Continue
 In "Enter Order, Agreements and Ship Dates", click Continue
 In Create Purchase Order, enter Product ID of GZ-1000 and Quantity of 500
 Click Finalize Order
 Click Continue several times to reach Purchase Order: Order Confirmation
 Click Create Order
 Note Purchase Order number. When I did this, it was 1
 Applications - Web Tools
 Click Entity Data Maintenance
 In Filter by Entity Name, choose OrderItem, click Apply
 Click OrderItem in the Entity Name column
 Enter Purchase Order number, e.g. 1
 Scroll down and click Search
 Observe that the OrderItem has a SupplierProductId of BKGZ_1000 as you'd expect
 Applications - Order - Find Order
 Enter Order ID (e.g. 1) and click Find
 In Actions, click Edit Items
 Change Unit Price from 3.75 to 4.00, check checkbox next to Unit Price, and 
click Update Selected Items
 Return to Entity Data Maintenance in the Web Tools, and find the OrderItem for 
the purchase order again
 You'll see that the SupplierProductId has been lost

 

  was:
When you edit on order item, the details are reloaded into a shopping cart and 
efter editing the order is updated from the cart. At present the 
supplierProductId for the order item is not read into the cart.

 

Try this in the demo site:

Product GZ-1000 has several suppliers, including BigSupplier
Order-Order Entry
In Purchase Order, choose BigSupplier, click Continue
In "Enter Order, Agreements and Ship Dates", click Continue
In Create Purchase Order, enter Product ID of GZ-1000 and Quantity of 500
Click Finalize Order
Click Continue several times to reach Purchase Order: Order Confirmation
Click Create Order
Note Purchase Order number. When I did this, it was 1
Applications - Web Tools
Click Entity Data Maintenance
In Filter by Entity Name, choose OrderItem, click Apply
Click OrderItem in the Entity Name column
Enter Purchase Order number, e.g. 1
Scroll down and click Search
Observe that the OrderItem has a SupplierProductId of BKGZ_1000 as you'd expect
Applications - Order - Find Order
Enter Order ID (e.g. 1) and click Find
In Actions, click Edit Items
Change Unit Price from 3.75 to 4.00, check checkbox next to Unit Price, and 
click Update Selected Items
Return to Entity Data Maintenance in the Web Tools, and find the OrderItem for 
the purchase order again
You'll see that the SupplierProductId has been lost

 


> Updating an OrderItem loses supplierProductId
> -
>
> Key: OFBIZ-10932
> URL: https://issues.apache.org/jira/browse/OFBIZ-10932
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 17.12.01, 18.12.01
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
>  Labels: order, order_item
> Attachments: 
> OFBIZ-10932_Preserve_supplierProductId_when_updating_OrderItem.patch
>
>
> When you edit on order item, the details are reloaded into a shopping cart 
> and after editing the order is updated from the cart. At present the 
> supplierProductId for the order item is not read into the cart.
>  
> Try this in the demo site:
> Product GZ-1000 has several suppliers, including BigSupplier
>  Order-Order Entry
>  In Purchase Order, choose BigSupplier, click Continue
>  In "Enter Order, Agreements and Ship Dates", click Continue
>  In Create Purchase Order, enter Product ID of GZ-1000 and Quantity of 500
>  Click Finalize Order
>  Click Continue several times to reach Purchase Order: Order Confirmation
>  Click Create Order
>  Note Purchase Order number. When I did this, it was 1
>  Applications - Web Tools
>  Click Entity Data Maintenance
>  In Filter by Entity Name, choose OrderItem, click Apply
>  Click OrderItem in the Entity Name column
>  Enter Purchase Order number, e.g. 1
>  Scroll down and click Search
>  Observe that the OrderItem has a SupplierProductId of BKGZ_1000 as you'd 
> expect
>  Applications - Order - Find Order
>  Enter Order ID (e.g. 1) and click Find
>  In Actions, click Edit Items
>  Change Unit Price from 3.75 to 4.00, check checkbox next to Unit Price, and 
> click Update Selected Items
>  Return to Entity Data Maintenance in the Web Tools, and find the OrderItem 
> for the purchase order again
>  You'll see that the SupplierProductId has been lost
>  



--
This message was 

[jira] [Updated] (OFBIZ-10932) Updating an OrderItem loses supplierProductId

2019-04-18 Thread Paul Foxworthy (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Foxworthy updated OFBIZ-10932:
---
Attachment: 
OFBIZ-10932_Preserve_supplierProductId_when_updating_OrderItem.patch

> Updating an OrderItem loses supplierProductId
> -
>
> Key: OFBIZ-10932
> URL: https://issues.apache.org/jira/browse/OFBIZ-10932
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, 17.12.01, 18.12.01
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
>  Labels: order, order_item
> Attachments: 
> OFBIZ-10932_Preserve_supplierProductId_when_updating_OrderItem.patch
>
>
> When you edit on order item, the details are reloaded into a shopping cart 
> and efter editing the order is updated from the cart. At present the 
> supplierProductId for the order item is not read into the cart.
>  
> Try this in the demo site:
> Product GZ-1000 has several suppliers, including BigSupplier
> Order-Order Entry
> In Purchase Order, choose BigSupplier, click Continue
> In "Enter Order, Agreements and Ship Dates", click Continue
> In Create Purchase Order, enter Product ID of GZ-1000 and Quantity of 500
> Click Finalize Order
> Click Continue several times to reach Purchase Order: Order Confirmation
> Click Create Order
> Note Purchase Order number. When I did this, it was 1
> Applications - Web Tools
> Click Entity Data Maintenance
> In Filter by Entity Name, choose OrderItem, click Apply
> Click OrderItem in the Entity Name column
> Enter Purchase Order number, e.g. 1
> Scroll down and click Search
> Observe that the OrderItem has a SupplierProductId of BKGZ_1000 as you'd 
> expect
> Applications - Order - Find Order
> Enter Order ID (e.g. 1) and click Find
> In Actions, click Edit Items
> Change Unit Price from 3.75 to 4.00, check checkbox next to Unit Price, and 
> click Update Selected Items
> Return to Entity Data Maintenance in the Web Tools, and find the OrderItem 
> for the purchase order again
> You'll see that the SupplierProductId has been lost
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10932) Updating an OrderItem loses supplierProductId

2019-04-18 Thread Paul Foxworthy (JIRA)
Paul Foxworthy created OFBIZ-10932:
--

 Summary: Updating an OrderItem loses supplierProductId
 Key: OFBIZ-10932
 URL: https://issues.apache.org/jira/browse/OFBIZ-10932
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Trunk, 17.12.01, 18.12.01
Reporter: Paul Foxworthy
Assignee: Paul Foxworthy


When you edit on order item, the details are reloaded into a shopping cart and 
efter editing the order is updated from the cart. At present the 
supplierProductId for the order item is not read into the cart.

 

Try this in the demo site:

Product GZ-1000 has several suppliers, including BigSupplier
Order-Order Entry
In Purchase Order, choose BigSupplier, click Continue
In "Enter Order, Agreements and Ship Dates", click Continue
In Create Purchase Order, enter Product ID of GZ-1000 and Quantity of 500
Click Finalize Order
Click Continue several times to reach Purchase Order: Order Confirmation
Click Create Order
Note Purchase Order number. When I did this, it was 1
Applications - Web Tools
Click Entity Data Maintenance
In Filter by Entity Name, choose OrderItem, click Apply
Click OrderItem in the Entity Name column
Enter Purchase Order number, e.g. 1
Scroll down and click Search
Observe that the OrderItem has a SupplierProductId of BKGZ_1000 as you'd expect
Applications - Order - Find Order
Enter Order ID (e.g. 1) and click Find
In Actions, click Edit Items
Change Unit Price from 3.75 to 4.00, check checkbox next to Unit Price, and 
click Update Selected Items
Return to Entity Data Maintenance in the Web Tools, and find the OrderItem for 
the purchase order again
You'll see that the SupplierProductId has been lost

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10927) Can't set (expected) start and end date of project when creating a project

2019-04-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821223#comment-16821223
 ] 

Jacques Le Roux commented on OFBIZ-10927:
-

+1

> Can't set (expected) start and end date of project when creating a project
> --
>
> Key: OFBIZ-10927
> URL: https://issues.apache.org/jira/browse/OFBIZ-10927
> Project: OFBiz
>  Issue Type: Bug
>  Components: projectmgr
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10927.patch
>
>
> When a new project is initialised the expected start and end date are 
> essential for resource allocation, defining phases and tasks. 
> However, it is not possible to set these dates.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10931) Improve the selection of the parent period for CustomTimePeriod update

2019-04-18 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10931:
-
Summary: Improve the selection of the parent period for CustomTimePeriod 
update  (was: Have type-ahead function in stead of drop-down for 
CustomTimePeriod update)

> Improve the selection of the parent period for CustomTimePeriod update
> --
>
> Key: OFBIZ-10931
> URL: https://issues.apache.org/jira/browse/OFBIZ-10931
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Priority: Major
>  Labels: CustomTimePeriod
>
> Currently in the overviews of Edit Custom Time Periods screen (see [1]) the 
> user can select a parent period for any given period record. This is done 
> through a drop down widget from EditCustomTimePeriod.ftl
> The construct for the values shown is: 
>  # the organisationPartyId, 
>  # the periodTypeId, and 
>  # the periodNum
>  # the customPeriodId
> The page shows the drop-down values as following examples:
>  * Company Fiscal Quarter: 2 [6011]
>  
>  * Company Fiscal Quarter: 3 [6012]
>  * Company Fiscal Quarter: 5 [6014]
>  * Company Fiscal Quarter: 2 [6016]
>  * Company Fiscal Quarter: 3 [6017]
>  * Company Fiscal Year: 1 [6010]
>  * Company Fiscal Year: 1 [6015]
> As can be observed, the information provided is confusing. And when the 
> number of periods to select from gets long (consider the hierarchy: 
> month-quarter-year) it is easy to make mistakes. 
> Furthermore, given that there is a hierarchy between periods, it should not 
> be possible to select a period that is outside the higher order. Meaning 
> there is a FISCAL_MONTH defined for say fromDate=2019-03-01 and thruDate = 
> 2019-03-31, then It can not belong to a FISCAL_YEAR that either ends before 
> the fromDate of the FISCAL_MONTH period or start after the thruDate of the 
> FISCAL_MONTH.
>  
>  
>  
> [1] 
> https://demo-stable.ofbiz.apache.org/accounting/control/EditCustomTimePeriod



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10931) Have type-ahead function in stead of drop-down for CustomTimePeriod update

2019-04-18 Thread Pierre Smits (JIRA)
Pierre Smits created OFBIZ-10931:


 Summary: Have type-ahead function in stead of drop-down for 
CustomTimePeriod update
 Key: OFBIZ-10931
 URL: https://issues.apache.org/jira/browse/OFBIZ-10931
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Release Branch 16.11, Trunk, Release Branch 17.12, 
Release Branch 18.12
Reporter: Pierre Smits


Currently in the overviews of Edit Custom Time Periods screen (see [1]) the 
user can select a parent period for any given period record. This is done 
through a drop down widget from EditCustomTimePeriod.ftl
The construct for the values shown is: 
 # the organisationPartyId, 
 # the periodTypeId, and 
 # the periodNum
 # the customPeriodId

The page shows the drop-down values as following examples:
 * Company Fiscal Quarter: 2 [6011]
 
 * Company Fiscal Quarter: 3 [6012]
 * Company Fiscal Quarter: 5 [6014]
 * Company Fiscal Quarter: 2 [6016]
 * Company Fiscal Quarter: 3 [6017]
 * Company Fiscal Year: 1 [6010]
 * Company Fiscal Year: 1 [6015]

As can be observed, the information provided is confusing. And when the number 
of periods to select from gets long (consider the hierarchy: 
month-quarter-year) it is easy to make mistakes. 

Furthermore, given that there is a hierarchy between periods, it should not be 
possible to select a period that is outside the higher order. Meaning there is 
a FISCAL_MONTH defined for say fromDate=2019-03-01 and thruDate = 2019-03-31, 
then It can not belong to a FISCAL_YEAR that either ends before the fromDate of 
the FISCAL_MONTH period or start after the thruDate of the FISCAL_MONTH.

 

 

 

[1] https://demo-stable.ofbiz.apache.org/accounting/control/EditCustomTimePeriod



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10905) Have a service that runs periodically to generate CustomTimePeriod records

2019-04-18 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10905:
-
Labels: CustomTimePeriod  (was: )

> Have a service that runs periodically to generate CustomTimePeriod records
> --
>
> Key: OFBIZ-10905
> URL: https://issues.apache.org/jira/browse/OFBIZ-10905
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, 
> Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: CustomTimePeriod
>
> Currently no service exists that creates CustomTimePeriod records on a 
> scheduled basis. One could think of:
>  * a yearly schedule that creates the next fiscal year period
>  * a quarterly schedule that creates the next fiscal quartered period
>  * a monthly schedule that creates the next fiscal month period
>  * etc.
> With each record referencing the appropriate parent, e.g.:
>  * the fiscal month referencing the fiscal quarter
>  * the fiscal quarter referencing the fiscal year
>  * etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10927) Can't set (expected) start and end date of project when creating a project

2019-04-18 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10927:
-

Assignee: Suraj Khurana  (was: Pawan Verma)

> Can't set (expected) start and end date of project when creating a project
> --
>
> Key: OFBIZ-10927
> URL: https://issues.apache.org/jira/browse/OFBIZ-10927
> Project: OFBiz
>  Issue Type: Bug
>  Components: projectmgr
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10927.patch
>
>
> When a new project is initialised the expected start and end date are 
> essential for resource allocation, defining phases and tasks. 
> However, it is not possible to set these dates.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10927) Can't set (expected) start and end date of project when creating a project

2019-04-18 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-10927:

Attachment: OFBIZ-10927.patch

> Can't set (expected) start and end date of project when creating a project
> --
>
> Key: OFBIZ-10927
> URL: https://issues.apache.org/jira/browse/OFBIZ-10927
> Project: OFBiz
>  Issue Type: Bug
>  Components: projectmgr
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10927.patch
>
>
> When a new project is initialised the expected start and end date are 
> essential for resource allocation, defining phases and tasks. 
> However, it is not possible to set these dates.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10927) Can't set (expected) start and end date of project when creating a project

2019-04-18 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821100#comment-16821100
 ] 

Pawan Verma commented on OFBIZ-10927:
-

Yes, I also belive that expected start and end date should be available while 
creating new project. I have attached a patch for the task. Thanks!

> Can't set (expected) start and end date of project when creating a project
> --
>
> Key: OFBIZ-10927
> URL: https://issues.apache.org/jira/browse/OFBIZ-10927
> Project: OFBiz
>  Issue Type: Bug
>  Components: projectmgr
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10927.patch
>
>
> When a new project is initialised the expected start and end date are 
> essential for resource allocation, defining phases and tasks. 
> However, it is not possible to set these dates.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10905) Have a service that runs periodically to generate CustomTimePeriod records

2019-04-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820970#comment-16820970
 ] 

Pierre Smits commented on OFBIZ-10905:
--

Requirement: create only CustomTimePeriod records for parties that are enabled 
for accounting (have a record in PartyAcctgPreference), and are considered to 
be active.

> Have a service that runs periodically to generate CustomTimePeriod records
> --
>
> Key: OFBIZ-10905
> URL: https://issues.apache.org/jira/browse/OFBIZ-10905
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11, 
> Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> Currently no service exists that creates CustomTimePeriod records on a 
> scheduled basis. One could think of:
>  * a yearly schedule that creates the next fiscal year period
>  * a quarterly schedule that creates the next fiscal quartered period
>  * a monthly schedule that creates the next fiscal month period
>  * etc.
> With each record referencing the appropriate parent, e.g.:
>  * the fiscal month referencing the fiscal quarter
>  * the fiscal quarter referencing the fiscal year
>  * etc.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2019-04-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820944#comment-16820944
 ] 

Jacques Le Roux commented on OFBIZ-4160:


Thanks Pierre,

Looking forward...

> Tax not added for order shipping or promotion
> -
>
> Key: OFBIZ-4160
> URL: https://issues.apache.org/jira/browse/OFBIZ-4160
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
> Environment: rev 1065908
>Reporter: Paul Foxworthy
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: VAT, tax
> Fix For: 17.12.01
>
> Attachments: OFBIZ-4160_shipping_tax.patch, 
> OFBIZ-4160_weighted_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is 
> made, the relevant tax rows from the TaxAuthorityRateProduct table are not 
> being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov, see 
> http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2019-04-18 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820915#comment-16820915
 ] 

Pierre Smits commented on OFBIZ-4160:
-

Hi Jacques,

Of course, if and when that leads to more parties contributing

> Tax not added for order shipping or promotion
> -
>
> Key: OFBIZ-4160
> URL: https://issues.apache.org/jira/browse/OFBIZ-4160
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
> Environment: rev 1065908
>Reporter: Paul Foxworthy
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: VAT, tax
> Fix For: 17.12.01
>
> Attachments: OFBIZ-4160_shipping_tax.patch, 
> OFBIZ-4160_weighted_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is 
> made, the relevant tax rows from the TaxAuthorityRateProduct table are not 
> being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov, see 
> http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7138) Manage Triangular European VAT

2019-04-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820847#comment-16820847
 ] 

Jacques Le Roux commented on OFBIZ-7138:


Pierre, in such case can't we simply don't apply VAT to the order? It begins to 
become more complex if the order has different shipping groups with different 
destinations where VAT applies and not.

> Manage Triangular European VAT 
> ---
>
> Key: OFBIZ-7138
> URL: https://issues.apache.org/jira/browse/OFBIZ-7138
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>  Labels: tax, vat
>
> I open an issue related to mailing thread 
> https://lists.apache.org/thread.html/Z8ksgxdskmbcg9n
> The origin came from here :
> {quote}
> In Europe with the B2B drop shipment process we have a specific rule to 
> calculate the VAT.
> The particularity comes from the purchase order, applying the VAT of the 
> product origin country if billing address OR shipping address is in the same 
> country.
> 1. I'm a French society that ordered product from Italy to sale in Denmark -> 
> No VAT
> 2. I'm a French society that ordered product from Italy to sale in Italy -> 
> Italian VAT
> 3. I'm a French society that ordered product from France to sale in Italy -> 
> French VAT
> Currently to resolve the taxAuth in OFBiz we use the shipping address only, 
> so we can see that the point 3. isn't covered because the product wasn't 
> shipped in France.
> {quote}
> I will load a patch in few week ;)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10500) Tax calculation incorrect when creating orders

2019-04-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10500.
---
Resolution: Invalid

I close. I agree with Ankush, it's working. I did a test for [~wp.rauchholz] 
and [it worked|https://markmail.org/message/wnuo5ng5pdpg7jex]. After that I 
updated [the point on VAT in 
FAQ|https://cwiki.apache.org/confluence/display/OFBIZ/FAQ+-+Tips+-+Tricks+-+Cookbook+-+HowTo#FAQ-Tips-Tricks-Cookbook-HowTo-PricesWithVAT]

Thanks Ankush. Please reopen Frank if you disagree and have more to say, thanks

> Tax calculation incorrect when creating orders
> --
>
> Key: OFBIZ-10500
> URL: https://issues.apache.org/jira/browse/OFBIZ-10500
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11
> Environment: OpenJDK 1.8.0_151 64bit on Ubuntu 16.04
>Reporter: Frank Herrman
>Assignee: Ankush Upadhyay
>Priority: Major
> Attachments: Invoice.png, OrderReview.png, Schermafbeelding 
> 2018-07-30 om 10.15.51.png, Schermafbeelding 2018-07-30 om 10.16.16.png, 
> Shipping.png, Stores.png, VAT.png
>
>
> After a 
> [discussion|https://lists.apache.org/thread.html/adf568edad92255340697f78ea4f34a07e328cc1689b8fb73e16fa53@%3Cuser.ofbiz.apache.org%3E]
>  on the user mailinglist we concluded there seems to be an issue with the tax 
> calculations.
> *Steps to reproduce*
>  * Create a tax authority for a specific country (e.g. The Netherlands in my 
> case)
>  * Set sales tax rate of 21% for your store with this Tax Authority
>  * Create a product and enter a price either including or excluding taxes and 
> set the corresponding flag for tax included y/n.
>  * Go to the order manager and order entry. Fill in the details, select the 
> product and go to the review page. It now shows the incorrect sales tax and 
> price.
> Let's say we have a product of 20 euro incl. taxes. With 21% that comes down 
> to 3.47 euro of taxes and a price of 16.53 euro. Instead Ofbiz shows a price 
> of 20 euro excl. taxes and adds 4.20 euros in taxes.
> *What I tried*
> Changing the price to price excl. VAT and set the flag to 'N' and visa versa. 
> Both gave the same error. 
> *Possible solution*
> I digged into the code and ended up in the file:
> {{applications/order/groovyScripts/entry/OrderReadHelper.java}}
> The function in line 2401
> {code:java}
> public static BigDecimal getOrderItemSubTotal(GenericValue orderItem, 
> List adjustments, boolean forTax, boolean forShipping){code}
> returns the price of one item there. It uses this piece of code:
> {code:java}
> orderItem.getBigDecimal("unitPrice");{code}
> The line item is always the price including taxes. When I adjust this price 
> (by dividing it by 1.21) I do get the correct price in the review page. I do 
> not, however, get the right tax amount. This is calculated elsewhere and 
> still using the 20 euro price I guess. Anyway, it does show I was in the 
> right spot.
> I'm not familiar enough with Ofbiz to create a full patch, but I think the 
> easiest way to go is to add another column to order items where the value 
> excl. taxes is stored which can be used in places where needed. This does not 
> affect the whole system. On the other hand I'm not sure where the order items 
> are stored, since when you are on the review page it is not stored in 
> database yet. Probably just in the session? Should make things even easier.
> The attachments show an example. I have stored a product of 20 euro 
> (screenshot directly taken from the database tool) and I have set-up a tax 
> exempt in this case for a customer which shows 4.20 euro sales tax. If I turn 
> off the tax exempt the grand total becomes 24.20 euros, so it is not related 
> to the exempt.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10500) Tax calculation incorrect when creating orders

2019-04-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10500:

Description: 
After a 
[discussion|https://lists.apache.org/thread.html/adf568edad92255340697f78ea4f34a07e328cc1689b8fb73e16fa53@%3Cuser.ofbiz.apache.org%3E]
 on the user mailinglist we concluded there seems to be an issue with the tax 
calculations.

*Steps to reproduce*
 * Create a tax authority for a specific country (e.g. The Netherlands in my 
case)
 * Set sales tax rate of 21% for your store with this Tax Authority
 * Create a product and enter a price either including or excluding taxes and 
set the corresponding flag for tax included y/n.
 * Go to the order manager and order entry. Fill in the details, select the 
product and go to the review page. It now shows the incorrect sales tax and 
price.

Let's say we have a product of 20 euro incl. taxes. With 21% that comes down to 
3.47 euro of taxes and a price of 16.53 euro. Instead Ofbiz shows a price of 20 
euro excl. taxes and adds 4.20 euros in taxes.

*What I tried*

Changing the price to price excl. VAT and set the flag to 'N' and visa versa. 
Both gave the same error. 

*Possible solution*

I digged into the code and ended up in the file:

{{applications/order/groovyScripts/entry/OrderReadHelper.java}}

The function in line 2401
{code:java}
public static BigDecimal getOrderItemSubTotal(GenericValue orderItem, 
List adjustments, boolean forTax, boolean forShipping){code}
returns the price of one item there. It uses this piece of code:
{code:java}
orderItem.getBigDecimal("unitPrice");{code}
The line item is always the price including taxes. When I adjust this price (by 
dividing it by 1.21) I do get the correct price in the review page. I do not, 
however, get the right tax amount. This is calculated elsewhere and still using 
the 20 euro price I guess. Anyway, it does show I was in the right spot.

I'm not familiar enough with Ofbiz to create a full patch, but I think the 
easiest way to go is to add another column to order items where the value excl. 
taxes is stored which can be used in places where needed. This does not affect 
the whole system. On the other hand I'm not sure where the order items are 
stored, since when you are on the review page it is not stored in database yet. 
Probably just in the session? Should make things even easier.

The attachments show an example. I have stored a product of 20 euro (screenshot 
directly taken from the database tool) and I have set-up a tax exempt in this 
case for a customer which shows 4.20 euro sales tax. If I turn off the tax 
exempt the grand total becomes 24.20 euros, so it is not related to the exempt.

 

  was:
After a 
[discussion|https://lists.apache.org/thread.html/adf568edad92255340697f78ea4f34a07e328cc1689b8fb73e16fa53@%3Cuser.ofbiz.apache.org%3E]
 on the user mailinglist we concluded there seems to be an issue with the tax 
calculations.

*Steps to reproduce*
 * Create a tax authority for a specific country (e.g. The Netherlands in my 
case)
 * Set sales tax rate of 21% for your store with this Tax Authority
 * Create a product and enter a price either including or excluding taxes and 
set the corresponding flag for tax included y/n.
 * Go to the order manager and order entry. Fill in the details, select the 
product and go to the review page. It now shows the incorrect sales tax and 
price.

Let's say we have a product of 20 euro incl. taxes. With 21% that comes down to 
3.47 euro of taxes and a price of 16.53 euro. Instead Ofbiz shows a price of 20 
euro excl. taxes and adds 4.20 euros in taxes.

*What I tried*

Changing the price to price excl. VAT and set the flag to 'N' and visa versa. 
Both gave the same error. 

*Possible solution*

I digged into the code and ended up in the file:

{{ applications/order/groovyScripts/entry/OrderReadHelper.java}}

The function in line 2401
{code:java}
public static BigDecimal getOrderItemSubTotal(GenericValue orderItem, 
List adjustments, boolean forTax, boolean forShipping){code}
returns the price of one item there. It uses this piece of code:
{code:java}
orderItem.getBigDecimal("unitPrice");{code}
The line item is always the price including taxes. When I adjust this price (by 
dividing it by 1.21) I do get the correct price in the review page. I do not, 
however, get the right tax amount. This is calculated elsewhere and still using 
the 20 euro price I guess. Anyway, it does show I was in the right spot.

I'm not familiar enough with Ofbiz to create a full patch, but I think the 
easiest way to go is to add another column to order items where the value excl. 
taxes is stored which can be used in places where needed. This does not affect 
the whole system. On the other hand I'm not sure where the order items are 
stored, since when you are on the review page it is not stored in database yet. 
Probably just in the session? Should make 

[jira] [Commented] (OFBIZ-4160) Tax not added for order shipping or promotion

2019-04-18 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820837#comment-16820837
 ] 

Jacques Le Roux commented on OFBIZ-4160:


Hi Benjamin, Pierre,

Should we not create a Jira to make shipping VAT rate possibly different than 
product VAT rate?

> Tax not added for order shipping or promotion
> -
>
> Key: OFBIZ-4160
> URL: https://issues.apache.org/jira/browse/OFBIZ-4160
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk
> Environment: rev 1065908
>Reporter: Paul Foxworthy
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: VAT, tax
> Fix For: 17.12.01
>
> Attachments: OFBIZ-4160_shipping_tax.patch, 
> OFBIZ-4160_weighted_shipping_tax.patch
>
>
> When shipping is calculated for the entire order or a promotion adjustment is 
> made, the relevant tax rows from the TaxAuthorityRateProduct table are not 
> being found.
> Here's a patch.
> This bug was discovered independently by Sergei Biletnikov, see 
> http://ofbiz.135035.n4.nabble.com/VAT-is-not-applied-for-the-shipping-td3234699.html.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-4763) create and use startup profiles

2019-04-18 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-4763.
--
Resolution: Won't Do
  Assignee: Jacques Le Roux

> create and use startup profiles
> ---
>
> Key: OFBIZ-4763
> URL: https://issues.apache.org/jira/browse/OFBIZ-4763
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Erwan de FERRIERES
>Assignee: Jacques Le Roux
>Priority: Major
>
> from this thread 
> http://ofbiz.135035.n4.nabble.com/OFBiz-integration-in-Apache-sonar-instance-td4484597.html
> we should be able to choose a profile when starting OFBiz, which will 
> configure at least the ports used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)