[jira] [Commented] (OFBIZ-10940) Ensure html verbosity is following general setup
[ https://issues.apache.org/jira/browse/OFBIZ-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826131#comment-16826131 ] Pierre Smits commented on OFBIZ-10940: -- Thank you, Jacques, for your assistance to get this into the repo. Anyway, you beat me on the scrum aspect. > Ensure html verbosity is following general setup > > > Key: OFBIZ-10940 > URL: https://issues.apache.org/jira/browse/OFBIZ-10940 > Project: OFBiz > Issue Type: Bug > Components: birt, scrum >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: OFBIZ-10940-Birt.patch > > > Currently the configuration of the Birt component does not follow the - de > facto - standard of having the html code reference the OFBiz widget and > templates. See [1] vs [2] > [1] view-source:[https://demo-trunk.ofbiz.apache.org/birt/control/main] > [2] view-source:[https://demo-trunk.ofbiz.apache.org/accounting/control/main] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10940) Ensure html verbosity is following general setup
[ https://issues.apache.org/jira/browse/OFBIZ-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10940. --- Resolution: Fixed Fix Version/s: 18.12.01 16.11.06 17.12.01 Fixed in trunk r1858141 R18 r1858142 R17 r1858143 R16 r1858144 (by hand) > Ensure html verbosity is following general setup > > > Key: OFBIZ-10940 > URL: https://issues.apache.org/jira/browse/OFBIZ-10940 > Project: OFBiz > Issue Type: Bug > Components: birt, scrum >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: OFBIZ-10940-Birt.patch > > > Currently the configuration of the Birt component does not follow the - de > facto - standard of having the html code reference the OFBiz widget and > templates. See [1] vs [2] > [1] view-source:[https://demo-trunk.ofbiz.apache.org/birt/control/main] > [2] view-source:[https://demo-trunk.ofbiz.apache.org/accounting/control/main] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10940) Ensure html verbosity is following general setup
[ https://issues.apache.org/jira/browse/OFBIZ-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10940: Component/s: scrum Thanks Pierre, This is also true for the 2 web.xml files in scrum component. I checked the 3 of them and it was initially like that with no given reason. So I will do the same change for all of them. > Ensure html verbosity is following general setup > > > Key: OFBIZ-10940 > URL: https://issues.apache.org/jira/browse/OFBIZ-10940 > Project: OFBiz > Issue Type: Bug > Components: birt, scrum >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10940-Birt.patch > > > Currently the configuration of the Birt component does not follow the - de > facto - standard of having the html code reference the OFBiz widget and > templates. See [1] vs [2] > [1] view-source:[https://demo-trunk.ofbiz.apache.org/birt/control/main] > [2] view-source:[https://demo-trunk.ofbiz.apache.org/accounting/control/main] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10940) Ensure html verbosity is following general setup
[ https://issues.apache.org/jira/browse/OFBIZ-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10940: --- Assignee: Jacques Le Roux (was: Pierre Smits) > Ensure html verbosity is following general setup > > > Key: OFBIZ-10940 > URL: https://issues.apache.org/jira/browse/OFBIZ-10940 > Project: OFBiz > Issue Type: Bug > Components: birt >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-10940-Birt.patch > > > Currently the configuration of the Birt component does not follow the - de > facto - standard of having the html code reference the OFBiz widget and > templates. See [1] vs [2] > [1] view-source:[https://demo-trunk.ofbiz.apache.org/birt/control/main] > [2] view-source:[https://demo-trunk.ofbiz.apache.org/accounting/control/main] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10940) Ensure html verbosity is following general setup
[ https://issues.apache.org/jira/browse/OFBIZ-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826035#comment-16826035 ] Pierre Smits commented on OFBIZ-10940: -- You can review this independently of OFBIZ-10923, as it should stand on its own and no changes in that other ticket involves web.xml. > Ensure html verbosity is following general setup > > > Key: OFBIZ-10940 > URL: https://issues.apache.org/jira/browse/OFBIZ-10940 > Project: OFBiz > Issue Type: Bug > Components: birt >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10940-Birt.patch > > > Currently the configuration of the Birt component does not follow the - de > facto - standard of having the html code reference the OFBiz widget and > templates. See [1] vs [2] > [1] view-source:[https://demo-trunk.ofbiz.apache.org/birt/control/main] > [2] view-source:[https://demo-trunk.ofbiz.apache.org/accounting/control/main] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10940) Ensure html verbosity is following general setup
[ https://issues.apache.org/jira/browse/OFBIZ-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826023#comment-16826023 ] Jacques Le Roux edited comment on OFBIZ-10940 at 4/25/19 12:36 PM: --- Ha wait, I confused with OFBIZ-10923. I have to review the whole thing. was (Author: jacques.le.roux): Ha wait, I confused with OFBIZ-10923. I have to review the whole thing (I remove my comment about comitting) > Ensure html verbosity is following general setup > > > Key: OFBIZ-10940 > URL: https://issues.apache.org/jira/browse/OFBIZ-10940 > Project: OFBiz > Issue Type: Bug > Components: birt >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10940-Birt.patch > > > Currently the configuration of the Birt component does not follow the - de > facto - standard of having the html code reference the OFBiz widget and > templates. See [1] vs [2] > [1] view-source:[https://demo-trunk.ofbiz.apache.org/birt/control/main] > [2] view-source:[https://demo-trunk.ofbiz.apache.org/accounting/control/main] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (OFBIZ-10940) Ensure html verbosity is following general setup
[ https://issues.apache.org/jira/browse/OFBIZ-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10940: Comment: was deleted (was: If nobody disagree I will commit these changes in a week) > Ensure html verbosity is following general setup > > > Key: OFBIZ-10940 > URL: https://issues.apache.org/jira/browse/OFBIZ-10940 > Project: OFBiz > Issue Type: Bug > Components: birt >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10940-Birt.patch > > > Currently the configuration of the Birt component does not follow the - de > facto - standard of having the html code reference the OFBiz widget and > templates. See [1] vs [2] > [1] view-source:[https://demo-trunk.ofbiz.apache.org/birt/control/main] > [2] view-source:[https://demo-trunk.ofbiz.apache.org/accounting/control/main] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10940) Ensure html verbosity is following general setup
[ https://issues.apache.org/jira/browse/OFBIZ-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826023#comment-16826023 ] Jacques Le Roux commented on OFBIZ-10940: - Ha wait, I confused with OFBIZ-10923. I have to review the whole thing (I remove my comment about comitting) > Ensure html verbosity is following general setup > > > Key: OFBIZ-10940 > URL: https://issues.apache.org/jira/browse/OFBIZ-10940 > Project: OFBiz > Issue Type: Bug > Components: birt >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10940-Birt.patch > > > Currently the configuration of the Birt component does not follow the - de > facto - standard of having the html code reference the OFBiz widget and > templates. See [1] vs [2] > [1] view-source:[https://demo-trunk.ofbiz.apache.org/birt/control/main] > [2] view-source:[https://demo-trunk.ofbiz.apache.org/accounting/control/main] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10940) Ensure html verbosity is following general setup
[ https://issues.apache.org/jira/browse/OFBIZ-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826017#comment-16826017 ] Jacques Le Roux commented on OFBIZ-10940: - Hi Pierre, Do you plan to provide something regarding "compressHTML"? > Ensure html verbosity is following general setup > > > Key: OFBIZ-10940 > URL: https://issues.apache.org/jira/browse/OFBIZ-10940 > Project: OFBiz > Issue Type: Bug > Components: birt >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10940-Birt.patch > > > Currently the configuration of the Birt component does not follow the - de > facto - standard of having the html code reference the OFBiz widget and > templates. See [1] vs [2] > [1] view-source:[https://demo-trunk.ofbiz.apache.org/birt/control/main] > [2] view-source:[https://demo-trunk.ofbiz.apache.org/accounting/control/main] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10940) Ensure html verbosity is following general setup
[ https://issues.apache.org/jira/browse/OFBIZ-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826016#comment-16826016 ] Jacques Le Roux commented on OFBIZ-10940: - If nobody disagree I will commit these changes in a week > Ensure html verbosity is following general setup > > > Key: OFBIZ-10940 > URL: https://issues.apache.org/jira/browse/OFBIZ-10940 > Project: OFBiz > Issue Type: Bug > Components: birt >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10940-Birt.patch > > > Currently the configuration of the Birt component does not follow the - de > facto - standard of having the html code reference the OFBiz widget and > templates. See [1] vs [2] > [1] view-source:[https://demo-trunk.ofbiz.apache.org/birt/control/main] > [2] view-source:[https://demo-trunk.ofbiz.apache.org/accounting/control/main] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with Quill.
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825985#comment-16825985 ] Jacques Le Roux commented on OFBIZ-10093: - Because of OFBIZ-5537, we should also check http://codemirror.net/ > Replace ELRTE plugin with Quill. > > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > > As there is no support for elrte since elrte-1.3 > [https://github.com/Studio-42/elRTE] it is to be replaced with some other > good editor & we found Quill Js editor as quite suitable: > * 139 releases > * Good community support of 101 contributors > * Licence - BSD 3-Clause "New" or "Revised" License > Links for reference: > [https://quilljs.com/] > [https://github.com/quilljs/quill] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId
[
https://issues.apache.org/jira/browse/OFBIZ-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Swapnil M Mane reassigned OFBIZ-10958:
--
Assignee: Swapnil M Mane (was: Ulrich Heidfeld)
> Service createProductFeature ignores passed productFeatureId
>
>
> Key: OFBIZ-10958
> URL: https://issues.apache.org/jira/browse/OFBIZ-10958
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Swapnil M Mane
>Priority: Minor
> Attachments: OFBIZ-10958_Fix_createProductFeature.patch
>
>
> Service "createProductFeature" ignores passed productFeatureId caused by
> overwritten output parameter. If I do following changes, this problem
> disappears.
> original:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="false"/>
>
>
>
> {code}
> Fix:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="true"/>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId
[
https://issues.apache.org/jira/browse/OFBIZ-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Heidfeld updated OFBIZ-10958:
Attachment: OFBIZ-10958_Fix_createProductFeature.patch
> Service createProductFeature ignores passed productFeatureId
>
>
> Key: OFBIZ-10958
> URL: https://issues.apache.org/jira/browse/OFBIZ-10958
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10958_Fix_createProductFeature.patch
>
>
> Service "createProductFeature" ignores passed productFeatureId caused by
> overwritten output parameter. If I do following changes, this problem
> disappears.
> original:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="false"/>
>
>
>
> {code}
> Fix:
> {code:xml}
> default-entity-name="ProductFeature" auth="true">
> Create a ProductFeature record
>
> optional="true"/>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-10958) Service createProductFeature ignores passed productFeatureId
Ulrich Heidfeld created OFBIZ-10958:
---
Summary: Service createProductFeature ignores passed
productFeatureId
Key: OFBIZ-10958
URL: https://issues.apache.org/jira/browse/OFBIZ-10958
Project: OFBiz
Issue Type: Bug
Affects Versions: Trunk
Reporter: Ulrich Heidfeld
Assignee: Ulrich Heidfeld
Service "createProductFeature" ignores passed productFeatureId caused by
overwritten output parameter. If I do following changes, this problem
disappears.
original:
{code:xml}
Create a ProductFeature record
{code}
Fix:
{code:xml}
Create a ProductFeature record
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10940) Ensure html verbosity is following general setup
[ https://issues.apache.org/jira/browse/OFBIZ-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10940: Description: Currently the configuration of the Birt component does not follow the - de facto - standard of having the html code reference the OFBiz widget and templates. See [1] vs [2] [1] view-source:[https://demo-trunk.ofbiz.apache.org/birt/control/main] [2] view-source:[https://demo-trunk.ofbiz.apache.org/accounting/control/main] was: Currently the configuration of the Bird component does not follow the - de facto - standard of having the html code reference the OFBiz widget and templates. See [1] vs [2] [1] view-source:https://demo-trunk.ofbiz.apache.org/birt/control/main [2] view-source:https://demo-trunk.ofbiz.apache.org/accounting/control/main > Ensure html verbosity is following general setup > > > Key: OFBIZ-10940 > URL: https://issues.apache.org/jira/browse/OFBIZ-10940 > Project: OFBiz > Issue Type: Bug > Components: birt >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10940-Birt.patch > > > Currently the configuration of the Birt component does not follow the - de > facto - standard of having the html code reference the OFBiz widget and > templates. See [1] vs [2] > [1] view-source:[https://demo-trunk.ofbiz.apache.org/birt/control/main] > [2] view-source:[https://demo-trunk.ofbiz.apache.org/accounting/control/main] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10957) Visit/Visitor specific client IPs tracking exclusion
[ https://issues.apache.org/jira/browse/OFBIZ-10957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10957: - Labels: ip-exclusion performance tracking visit (was: ip-exclusion tracking visit) > Visit/Visitor specific client IPs tracking exclusion > > > Key: OFBIZ-10957 > URL: https://issues.apache.org/jira/browse/OFBIZ-10957 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 13.07 >Reporter: Giulio Speri >Assignee: Giulio Speri >Priority: Major > Labels: ip-exclusion, performance, tracking, visit > > I shortly explain the server architecture on which OFBiz is running: hosted > by a third party supplier, there are two (virtual) machines where Apache > OFBiz 13.07.03 is running behind Apache2 web server (so we have two web > fronts). > On other two different machines there are the database (MariaDB) and HaProxy > has a load balancer. > HaProxy is configured to perform its Health Checks on the backend servers > with a Http GET on the Home Page of one of the two sites. > Visit and Visitor tracking are enabled, for BI and analytics purposes, so we > cannot turn them off. > These two combined things caused the Visit and Visitor tables to explode in > dimensions (we counted about 19M records of Visit and about 67M of Visitors, > with the 86% of those caused by the load balancer), since each hit of the > HaProxy store a Visit and a Visitor record on the db (plus some other record > of other entities, like ShoppingList, due to and > events). > A bad side effect of this situation, on the long run, is an overall > performance degradation, and an increase in webfront unavailability time > windows during the day: it's not necessary to say that our customer was not > so happy about this. > > The difficult part of figuring out this problem, was that we did not have > direct access to HaProxy and DB machines, to check logs. > > The solution we thought and implemented, was to exclude from Visit/Visitor > tracking specific IP addresses (for our case we were interested in HaProxy > IP). > The Visit and Visitor records (along with firstvisit and preprocessor events) > are created mainly in the ControlServlet class, using VisitHandler > getVisit/getVisitor/getVisitId methods. > > Our idea consist in reading from a .properties file one or more IP addresses > we would like to exclude from tracking and then check them against the client > ip address the request is coming from. > If the client ip address is in the "exclusion list", then do not persist > visit/visitor and do not run firstvisit events neither for it. > > The idea is quite simple, but we noticed in few days, a meaningful > improvement in overall system performance and stability/availability. > > This kind of exclusion could be also useful in case we do not want to track > or register internal IP addresses (ie: mainly used for testing). > > However this solution, should be integrated with a service (cron or scheduled > in ofbiz) that keeps the number of records in the tables limited (for example > keep only the last month of visit/visitor); I think that these two solutions > together, could do the job well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10957) Visit/Visitor specific client IPs tracking exclusion
[ https://issues.apache.org/jira/browse/OFBIZ-10957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giulio Speri updated OFBIZ-10957: - Labels: ip-exclusion tracking visit (was: ) > Visit/Visitor specific client IPs tracking exclusion > > > Key: OFBIZ-10957 > URL: https://issues.apache.org/jira/browse/OFBIZ-10957 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 13.07 >Reporter: Giulio Speri >Assignee: Giulio Speri >Priority: Major > Labels: ip-exclusion, tracking, visit > > I shortly explain the server architecture on which OFBiz is running: hosted > by a third party supplier, there are two (virtual) machines where Apache > OFBiz 13.07.03 is running behind Apache2 web server (so we have two web > fronts). > On other two different machines there are the database (MariaDB) and HaProxy > has a load balancer. > HaProxy is configured to perform its Health Checks on the backend servers > with a Http GET on the Home Page of one of the two sites. > Visit and Visitor tracking are enabled, for BI and analytics purposes, so we > cannot turn them off. > These two combined things caused the Visit and Visitor tables to explode in > dimensions (we counted about 19M records of Visit and about 67M of Visitors, > with the 86% of those caused by the load balancer), since each hit of the > HaProxy store a Visit and a Visitor record on the db (plus some other record > of other entities, like ShoppingList, due to and > events). > A bad side effect of this situation, on the long run, is an overall > performance degradation, and an increase in webfront unavailability time > windows during the day: it's not necessary to say that our customer was not > so happy about this. > > The difficult part of figuring out this problem, was that we did not have > direct access to HaProxy and DB machines, to check logs. > > The solution we thought and implemented, was to exclude from Visit/Visitor > tracking specific IP addresses (for our case we were interested in HaProxy > IP). > The Visit and Visitor records (along with firstvisit and preprocessor events) > are created mainly in the ControlServlet class, using VisitHandler > getVisit/getVisitor/getVisitId methods. > > Our idea consist in reading from a .properties file one or more IP addresses > we would like to exclude from tracking and then check them against the client > ip address the request is coming from. > If the client ip address is in the "exclusion list", then do not persist > visit/visitor and do not run firstvisit events neither for it. > > The idea is quite simple, but we noticed in few days, a meaningful > improvement in overall system performance and stability/availability. > > This kind of exclusion could be also useful in case we do not want to track > or register internal IP addresses (ie: mainly used for testing). > > However this solution, should be integrated with a service (cron or scheduled > in ofbiz) that keeps the number of records in the tables limited (for example > keep only the last month of visit/visitor); I think that these two solutions > together, could do the job well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10957) Visit/Visitor specific client IPs tracking exclusion
Giulio Speri created OFBIZ-10957: Summary: Visit/Visitor specific client IPs tracking exclusion Key: OFBIZ-10957 URL: https://issues.apache.org/jira/browse/OFBIZ-10957 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Release Branch 13.07 Reporter: Giulio Speri Assignee: Giulio Speri I shortly explain the server architecture on which OFBiz is running: hosted by a third party supplier, there are two (virtual) machines where Apache OFBiz 13.07.03 is running behind Apache2 web server (so we have two web fronts). On other two different machines there are the database (MariaDB) and HaProxy has a load balancer. HaProxy is configured to perform its Health Checks on the backend servers with a Http GET on the Home Page of one of the two sites. Visit and Visitor tracking are enabled, for BI and analytics purposes, so we cannot turn them off. These two combined things caused the Visit and Visitor tables to explode in dimensions (we counted about 19M records of Visit and about 67M of Visitors, with the 86% of those caused by the load balancer), since each hit of the HaProxy store a Visit and a Visitor record on the db (plus some other record of other entities, like ShoppingList, due to and events). A bad side effect of this situation, on the long run, is an overall performance degradation, and an increase in webfront unavailability time windows during the day: it's not necessary to say that our customer was not so happy about this. The difficult part of figuring out this problem, was that we did not have direct access to HaProxy and DB machines, to check logs. The solution we thought and implemented, was to exclude from Visit/Visitor tracking specific IP addresses (for our case we were interested in HaProxy IP). The Visit and Visitor records (along with firstvisit and preprocessor events) are created mainly in the ControlServlet class, using VisitHandler getVisit/getVisitor/getVisitId methods. Our idea consist in reading from a .properties file one or more IP addresses we would like to exclude from tracking and then check them against the client ip address the request is coming from. If the client ip address is in the "exclusion list", then do not persist visit/visitor and do not run firstvisit events neither for it. The idea is quite simple, but we noticed in few days, a meaningful improvement in overall system performance and stability/availability. This kind of exclusion could be also useful in case we do not want to track or register internal IP addresses (ie: mainly used for testing). However this solution, should be integrated with a service (cron or scheduled in ofbiz) that keeps the number of records in the tables limited (for example keep only the last month of visit/visitor); I think that these two solutions together, could do the job well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585446#comment-16585446
]
Jacques Le Roux edited comment on OFBIZ-10438 at 4/25/19 8:50 AM:
--
Hi [~shi.jinghai]/[~rishisolankii] ,
As discussed on the dev mailing list, I am able to reproduce the issue on the
local machine (Derby database) also using the SVN trunk code. Here are the
steps to reproduce it:
1) Log in to the 'ordermgr' with admin/ofbiz credentials.
2) Click on the 'orderentry' menu.
3) Under the 'Sales Order' section provide the details as follows:
Product Store: OFBiz E-Commerce Store
Sales Channel: Web Channel
User Login Id: admin
Customer: Demo Customer
4) Click on the 'Continue' button on the top right on the section.
5) Leave the details on next page as it is and click on the 'Continue'.
6) Select the product 'WG-9943' and enter any quantity (say 1). Click on the
'Add To Cart' button.
7) On the next page select Color, Size and Unit of Measure. Click on 'Add To
Cart' button again.
8) You will be landed to an error page saying: "
|{color:#ff}*:ERROR MESSAGE:*{color}|
|org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
[additem]; this request does not exist or cannot be called directly.|
Please find the attached image 'URL-Error-additem.png' for your reference.
9) Now change the product to 'GZ-2644' and click on 'Add To Cart' button.
10) Click on the 'Quick Finalize Order' link on the top right corner.
11) Click on the radio button for selecting the shipping address.
12) You will be landed to an error page saying: "
|{color:#ff}*:ERROR MESSAGE:*{color}|
|org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
[updateCheckoutOptions]; this request does not exist or cannot be called
directly.|
Please find the attached image "URL-Error-SelectShipping.png" for your
reference.
It might be possible that demo instance is not up-to-date with the latest code
base and we are not able to regenerate it there.
was (Author: deepak.nigam):
Hi [~shi.jinghai]/[~rishisolankii] ,
As discussed on the dev mailing list, I am able to reproduce the issue on the
local machine (Derby database) also using the SVN trunk code. Here are the
steps to reproduce it:
1) Log in to the 'ordermgr' with admin/ofbiz credentials.
2) Click on the 'orderentry' menu.
3) Under the 'Sales Order' section provide the details as follows:
Product Store: OFBiz E-Commerce Store
Sales Channel: Web Channel
User Login Id: admin
Customer: Demo Customer
4) Click on the 'Continue' button on the top right on the section.
5) Leave the details on next page as it is and click on the 'Continue'.
6) Select the product 'WG-9943' and enter any quantity (say 1). Click on the
'Add To Cart' button.
7) On the next page select Color, Size and Unit of Measure. Click on 'Add To
Cart' button again.
8) You will be landed to an error page saying: "
|{color:#ff}*:ERROR MESSAGE:*{color}|
|org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
[additem]; this request does not exist or cannot be called directly.|
"
Please find the attached image 'URL-Error-additem.png' for your reference.
9) Now change the product to 'GZ-2644' and click on 'Add To Cart' button.
10) Click on the 'Quick Finalize Order' link on the top right corner.
11) Click on the radio button for selecting the shipping address.
12) You will be landed to an error page saying: "
|{color:#ff}*:ERROR MESSAGE:*{color}|
|org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
[updateCheckoutOptions]; this request does not exist or cannot be called
directly.|
"
Please find the attached image "URL-Error-SelectShipping.png" for your
reference.
It might be possible that demo instance is not up-to-date with the latest code
base and we are not able to regenerate it there.
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png,
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request
[jira] [Closed] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.
[
https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-10895.
---
Resolution: Fixed
Fix Version/s: 18.12.01
Fixed in
trunk r1858092
R18 r1858094
> Unknown request [images]; this request does not exist or cannot be called
> directly.
> ---
>
> Key: OFBIZ-10895
> URL: https://issues.apache.org/jira/browse/OFBIZ-10895
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01
>
>
> This error happens in many occasions:
> Inside another request (here LookupProduct)
> {noformat}
> 2019-03-31 12:32:26,215 |jsse-nio-8443-exec-2 |ControlServlet
> |T| [[[LookupProduct(Domain:https://localhost)] Request Begun,
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]-
> total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [images]; this request does not exist or cannot be called directly.
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
> [tomcat-embed-websocket-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
> [ofbiz.jar:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408)
> [tomcat-coyote-9.0.16.jar:9.0.16]
>
[jira] [Commented] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.
[
https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825853#comment-16825853
]
Jacques Le Roux commented on OFBIZ-10895:
-
This has been somehow broken by OFBIZ-10438 but actually it was already broken
before but not for the same reason. Finally r1838081 (for OFBIZ-10438) allows
to easy fix it when in previous versions (pre R18) it would need another fix.
Since it's only annoying text in log I'll let users search the solution for pre
R18 versions and will fix it only for trunk and R18.
> Unknown request [images]; this request does not exist or cannot be called
> directly.
> ---
>
> Key: OFBIZ-10895
> URL: https://issues.apache.org/jira/browse/OFBIZ-10895
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This error happens in many occasions:
> Inside another request (here LookupProduct)
> {noformat}
> 2019-03-31 12:32:26,215 |jsse-nio-8443-exec-2 |ControlServlet
> |T| [[[LookupProduct(Domain:https://localhost)] Request Begun,
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]-
> total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [images]; this request does not exist or cannot be called directly.
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
> [tomcat-embed-websocket-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
> [ofbiz.jar:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
>
[jira] [Assigned] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.
[
https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-10895:
---
Assignee: Jacques Le Roux
> Unknown request [images]; this request does not exist or cannot be called
> directly.
> ---
>
> Key: OFBIZ-10895
> URL: https://issues.apache.org/jira/browse/OFBIZ-10895
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This error happens in many occasions:
> Inside another request (here LookupProduct)
> {noformat}
> 2019-03-31 12:32:26,215 |jsse-nio-8443-exec-2 |ControlServlet
> |T| [[[LookupProduct(Domain:https://localhost)] Request Begun,
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]-
> total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [images]; this request does not exist or cannot be called directly.
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
> ~[ofbiz.jar:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
> [tomcat-embed-websocket-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
> [ofbiz.jar:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
> [ofbiz.jar:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127)
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408)
> [tomcat-coyote-9.0.16.jar:9.0.16]
> at
>
[jira] [Commented] (OFBIZ-10091) Unnecessary throws clauses in renderer classes?
[
https://issues.apache.org/jira/browse/OFBIZ-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825840#comment-16825840
]
Michael Brohl commented on OFBIZ-10091:
---
{quote}Are you still interested in working on that?
{quote}
Yes, I think this should be corrected. Might need some time to do it because of
other activities though.
> Unnecessary throws clauses in renderer classes?
> ---
>
> Key: OFBIZ-10091
> URL: https://issues.apache.org/jira/browse/OFBIZ-10091
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Priority: Minor
>
> During the refactoring work I found that there are several classes in
> org.apache.ofbiz.widget.renderer.macro which state in their method
> declarations that they throw TemplateException and/or IOException.
> In many cases, there is either no evidence of these Exceptions or they are
> catched inside the methods.
> One example is the MacroFormRenderer constructor which says it throws
> TemplateException but does not.
> The method declarations in the interfaces of org.apache.ofbiz.widget.renderer
> all say that IOException is thrown.
> It might be that I overlook something and I did not dig much deeper into the
> code so I first want to ask what the reasons are or if it would not be
> reasonable to make a difference in interfaces and implementations and only
> declare that a method throws a specific exception if it really does?
> Thanks for your help,
> regards,
> Michael
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only
[
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-10438:
Description:
As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no matter
what request it is.
I like Mathieu's comment on adding a method attribute to the request-map
element, it's almost the same as we implemented in our openapi:
{code:java}
{code}
The difference is that we DON'T support method list expression:
{code:java}
...
{code}
was:
As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no matter
what request it is.
I like Mathieu's comment on adding a method attribute to the request-map
element, it's almost the same as we implemented in our openapi:
{code:java}
{code}
The difference is that we DON'T support method list expression:
{code:java}
...
{code}
> Add method attribute to request-map to controll a uri can be called GET or
> POST only
>
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch,
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch,
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch,
> OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png,
> URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map
> element, it's almost the same as we implemented in our openapi:
> {code:java}
>
>
>
>
>
>
> {code}
> The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
