[jira] [Updated] (OFBIZ-11001) Applicable Promo Recommendations

2019-04-30 Thread Rishi Solanki (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rishi Solanki updated OFBIZ-11001:
--
Description: 
Proposal is to add user selection ability for promotion. That means user can 
select her own choice of promotion from the list of promotion applicable to 
current cart. Right now promotion engine based on algorithm implemented decide 
which promotion will be apply to cart from the list of promotion. For example, 
if promotion engine find 3 promotion applicable for the current cart then based 
on algorithm implemented it apply the maximum amount value promotion to the 
cart.
  
 Coming back to proposal with some use cases;
  
 Use Case 1: Promotion engine find three promotions applicable to cart or item 
as P1, P2 and P3. And as per algorithm promo engine decide to apply P1. Now if 
user want to go with P2 or P3 then she can do that.
  
 Use Case 2: In #1 user can also choose to not take any promotion, remove the 
P1 and submit the order without promotion.
  
 Use Case 3: Item1 and item2 will have two promotions common as P1 and P2. Now 
user can opt which promotion should applicable to which item. That means user 
can apply P1 or P2 on item1 or item2 based on her preference.
  
 Use Case 4: In #3 if user wants then she can opt to select promotion for one 
item and can remove promo from other.

[Reference 
Thread|https://ofbiz.markmail.org/search/?q=Applicable%20Promo%20Recommendations#query:Applicable%20Promo%20Recommendations+page:1+mid:qvc5zimtu7txbiiy+state:results]

  was:
Proposal is to add user selection ability for promotion. That means user can 
select her own choice of promotion from the list of promotion applicable to 
current cart. Right now promotion engine based on algorithm implemented decide 
which promotion will be apply to cart from the list of promotion. For example, 
if promotion engine find 3 promotion applicable for the current cart then based 
on algorithm implemented it apply the maximum amount value promotion to the 
cart.
 
Coming back to proposal with some use cases;
 
Use Case 1: Promotion engine find three promotions applicable to cart or item 
as P1, P2 and P3. And as per algorithm promo engine decide to apply P1. Now if 
user want to go with P2 or P3 then she can do that.
 
Use Case 2: In #1 user can also choose to not take any promotion, remove the P1 
and submit the order without promotion.
 
Use Case 3: Item1 and item2 will have two promotions common as P1 and P2. Now 
user can opt which promotion should applicable to which item. That means user 
can apply P1 or P2 on item1 or item2 based on her preference.
 
Use Case 4: In #3 if user wants then she can opt to select promotion for one 
item and can remove promo from other.


> Applicable Promo Recommendations
> 
>
> Key: OFBIZ-11001
> URL: https://issues.apache.org/jira/browse/OFBIZ-11001
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce, product
>Affects Versions: Trunk
>Reporter: Rishi Solanki
>Priority: Major
>
> Proposal is to add user selection ability for promotion. That means user can 
> select her own choice of promotion from the list of promotion applicable to 
> current cart. Right now promotion engine based on algorithm implemented 
> decide which promotion will be apply to cart from the list of promotion. For 
> example, if promotion engine find 3 promotion applicable for the current cart 
> then based on algorithm implemented it apply the maximum amount value 
> promotion to the cart.
>   
>  Coming back to proposal with some use cases;
>   
>  Use Case 1: Promotion engine find three promotions applicable to cart or 
> item as P1, P2 and P3. And as per algorithm promo engine decide to apply P1. 
> Now if user want to go with P2 or P3 then she can do that.
>   
>  Use Case 2: In #1 user can also choose to not take any promotion, remove the 
> P1 and submit the order without promotion.
>   
>  Use Case 3: Item1 and item2 will have two promotions common as P1 and P2. 
> Now user can opt which promotion should applicable to which item. That means 
> user can apply P1 or P2 on item1 or item2 based on her preference.
>   
>  Use Case 4: In #3 if user wants then she can opt to select promotion for one 
> item and can remove promo from other.
> [Reference 
> Thread|https://ofbiz.markmail.org/search/?q=Applicable%20Promo%20Recommendations#query:Applicable%20Promo%20Recommendations+page:1+mid:qvc5zimtu7txbiiy+state:results]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11001) Applicable Promo Recommendations

2019-04-30 Thread Rishi Solanki (JIRA)
Rishi Solanki created OFBIZ-11001:
-

 Summary: Applicable Promo Recommendations
 Key: OFBIZ-11001
 URL: https://issues.apache.org/jira/browse/OFBIZ-11001
 Project: OFBiz
  Issue Type: New Feature
  Components: ecommerce, product
Affects Versions: Trunk
Reporter: Rishi Solanki


Proposal is to add user selection ability for promotion. That means user can 
select her own choice of promotion from the list of promotion applicable to 
current cart. Right now promotion engine based on algorithm implemented decide 
which promotion will be apply to cart from the list of promotion. For example, 
if promotion engine find 3 promotion applicable for the current cart then based 
on algorithm implemented it apply the maximum amount value promotion to the 
cart.
 
Coming back to proposal with some use cases;
 
Use Case 1: Promotion engine find three promotions applicable to cart or item 
as P1, P2 and P3. And as per algorithm promo engine decide to apply P1. Now if 
user want to go with P2 or P3 then she can do that.
 
Use Case 2: In #1 user can also choose to not take any promotion, remove the P1 
and submit the order without promotion.
 
Use Case 3: Item1 and item2 will have two promotions common as P1 and P2. Now 
user can opt which promotion should applicable to which item. That means user 
can apply P1 or P2 on item1 or item2 based on her preference.
 
Use Case 4: In #3 if user wants then she can opt to select promotion for one 
item and can remove promo from other.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10966) JSON entity data import and export utility

2019-04-30 Thread Jayansh Shinde (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830289#comment-16830289
 ] 

Jayansh Shinde edited comment on OFBIZ-10966 at 5/1/19 4:42 AM:


Thanks Nicolas!

I think just adding tags create/create-update/create-replace/delete as root 
element, absent of this root tags will be treated as "create-update" 
by-default. Handling would be similar to current implementation.

 
{code:java}
 {"create-replace": {“Party”: 
{"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
,{"Product": {"productId": "10001", "productName":"Round Hat", "InternalName": 
"RoundHat" }}}
{code}
Please help me out if you have any better idea!


was (Author: jayansh):
Thanks Nicolas!

I think just adding tags create/create-update/create-replace/delete as root 
element, absent of this root tags will be treated as "create" by-default. 
Handling would be similar to current implementation.

 {code}
 {"create-replace": {“Party”: 
{"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
,{"Product": {"productId": "10001", "productName":"Round Hat", "InternalName": 
"RoundHat" }}}
{code}
 Please help me out if you have any better idea!

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Priority: Minor
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10966) JSON entity data import and export utility

2019-04-30 Thread Jayansh Shinde (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830289#comment-16830289
 ] 

Jayansh Shinde edited comment on OFBIZ-10966 at 5/1/19 4:42 AM:


Thanks Nicolas!

I think just adding tags create/create-update/create-replace/delete as root 
element, absent of this root tags will be treated as "create-update" 
by-default. Handling would be similar to current implementation.

 
{code:java}
 {"create-replace": {“Party”: 
{"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
,{"Product": {"productId": "10001", "productName":"Round Hat", "InternalName": 
"RoundHat" }}}
{code}
Please help me out if you have any better idea!

Reference: 
[https://cwiki.apache.org/confluence/display/OFBIZ/Handling+of+External+data]


was (Author: jayansh):
Thanks Nicolas!

I think just adding tags create/create-update/create-replace/delete as root 
element, absent of this root tags will be treated as "create-update" 
by-default. Handling would be similar to current implementation.

 
{code:java}
 {"create-replace": {“Party”: 
{"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
,{"Product": {"productId": "10001", "productName":"Round Hat", "InternalName": 
"RoundHat" }}}
{code}
Please help me out if you have any better idea!

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Priority: Minor
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10895) Unknown request [images]; this request does not exist or cannot be called directly.

2019-04-30 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830465#comment-16830465
 ] 

Jacques Le Roux commented on OFBIZ-10895:
-

In a 1st effort I commited in 
trunk r1858444
R18 r1858445
R17 r1858447
R16 r1858448



> Unknown request [images]; this request does not exist or cannot be called 
> directly.
> ---
>
> Key: OFBIZ-10895
> URL: https://issues.apache.org/jira/browse/OFBIZ-10895
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, themes
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> This error happens in many occasions:
> Inside another request (here LookupProduct)
> {noformat}
> 2019-03-31 12:32:26,215 |jsse-nio-8443-exec-2 |ControlServlet
> |T| [[[LookupProduct(Domain:https://localhost)] Request Begun, 
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[images(Domain:https://localhost)] Request Begun, encoding=[UTF-8]- 
> total:0.0,since last(Begin):0.0]]
> 2019-03-31 12:32:26,222 |jsse-nio-8443-exec-7 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
> [images]; this request does not exist or cannot be called directly.
> at 
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212) 
> [ofbiz.jar:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
> [tomcat-embed-websocket-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:191)
>  [ofbiz.jar:?]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156)
>  [ofbiz.jar:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:127) 
> [javax.servlet-api-4.0.1.jar:4.0.1]
> at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:200)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:490)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139) 
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) 
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:668)
>  [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) 
> [tomcat-catalina-9.0.16.jar:9.0.16]
> at 
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:408) 
> 

[jira] [Commented] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2019-04-30 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830290#comment-16830290
 ] 

Suraj Khurana commented on OFBIZ-10518:
---

Removed unused Debug.log statements and also returned success from service if 
allocation plan is not found instead of returning error.



Done under rev #1858428 in Trunk.

 

> Inventory (Supply) Allocation Planning
> --
>
> Key: OFBIZ-10518
> URL: https://issues.apache.org/jira/browse/OFBIZ-10518
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order, product
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: CreateAllocationPlan-Step1.png, 
> CreateAllocationPlan-Step2.png, CreateAllocationPlanEditMode-Step2.png, 
> EditAllocationPlan.png, FindAllocationPlan.png, OFBiz-10518-UI.patch, 
> OFBiz-10518-data.patch, OFBiz-10518-entity-model.patch, 
> OFBiz-10518-secas.patch, OFBiz-10518-services.patch, 
> OFBiz-10518-ui-labels.patch, OFBiz-10518.patch, OFBiz-10518.patch, 
> OFBiz-10518.patch, OFBiz-10518.patch, OFBiz-10518.patch, OFBiz-10518.patch, 
> ViewAllocationPlan.png
>
>
> In the current implementation of inventory reservation flow, inventory gets 
> reserved for the order based on the reservation algorithm (FIFO, LIFO etc). 
> Many times, the fulfilment cycle of the order is too long or due to some 
> unexpected circumstances, the order holds the inventory for a long time. In 
> such scenarios, inventory availability becomes one of the major bottlenecks 
> in fulfilling the other sales order and businesses often remains short 
> supplied against the demand.
>   
>  We can provide a feature (Create, Find and Edit supply allocation screen) to 
> allocate the available and any future supply judiciously amongst existing 
> customers orders by considering different factors like estimated delivery 
> dates, order priority, customer preference etc.
>  
> Following are the details design notes for the same:
>  
> An order in the approved status will be considered as ‘Eligible for 
> Allocation’. The proposed supply allocation planning will have the following 
> set of features:
>  
> *Create Allocation Plan:*
> The authorized user will be able to initiate the process by setting the 
> desired product. 
>  
> *View/Edit Allocation Plan:*
> 1) The system would search and list all the order lines which are eligible 
> for allocation for that particular product.
> 2) The user can filter and sort the orders by various parameters like Sale 
> Channel, Customer, Order Id, Estimated Ship Date etc.
> 3) The user can then prioritize the order by moving up or down the given 
> order in the priority ranking. Higher is the order in display result list, 
> higher will be the priority it would get during reservations.
> 4) The user can set the ‘Allocated Quantity’ against ordered quantity at 
> order item line level.
> 5) Once the Allocation Plan is submitted, the system would auto-assign the 
> priority and set the allocated quantity for each of the submitted orders to 
> be honoured during order reservations at any point in time.
> 7) Incoming shipments would be reserved by honouring the same allocation plan 
> during order promising cycle.
> 8) After allocating supply as per the allocation plan, any excess stock 
> should be reserved based on the standard FIFO method.
> 9) If any of the items of an order is not planned via the Allocation Plan, 
> then also it should be reserved based on default FIFO criteria.
> 10) The allocation for all the sales orders should be allowed for revision 
> unless the Shipment Plan is created against them.
>  
> *Find Allocation Plan:*
> The authorized user can search allocation plan(s) with filters like Plan Id, 
> Order Id, Product Id, Plan Method, Status etc.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10966) JSON entity data import and export utility

2019-04-30 Thread Jayansh Shinde (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830289#comment-16830289
 ] 

Jayansh Shinde commented on OFBIZ-10966:


Thanks Nicolas!

I think just adding tags create/create-update/create-replace/delete as root 
element, absent of this root tags will be treated as "create" by-default. 
Handling would be similar to current implementation.

 {code}
 {"create-replace": {“Party”: 
{"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
,{"Product": {"productId": "10001", "productName":"Round Hat", "InternalName": 
"RoundHat" }}}
{code}
 Please help me out if you have any better idea!

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Priority: Minor
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code

2019-04-30 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830198#comment-16830198
 ] 

Jacques Le Roux commented on OFBIZ-10187:
-

Thanks Michael,

I tested your R16 patch going to https://localhost:8443/cmssite in debug mode 
and it works properly: +1 for backporting.
Actually the only difference with later is the introduction of Birt Flexible 
Reports after R16.

> OWASP sanitizer breaks proper rendering of HTML code
> 
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch 
> 18.12
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
>  Labels: backport-needed
> Fix For: 17.12.01, 18.12.01
>
> Attachments: OFBIZ-10187_Sanitizer.patch, 
> OFBIZ-10187_Sanitizer_16.11.patch, OFBIZ-10187_Sanitizer_New.patch
>
>
> The current implementation of the sanitizer breaks the proper rendering of 
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>     
>           src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" 
> alt="" />
>                  
>                      
>                          Lorem ipsum dolor sit amet
>                          At vero eos et accusam et justo
>                          
>                              Lorem ipsum dolor sit amet, consetetur 
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
>                              takimata sanctus est Lorem ipsum dolor sit amet.
>                          
>                           href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>                      
>                  
>              {code}
> will be rendered to
> {code:java}
>     
>           src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg" 
> alt="" />
>                  
>                      
>                          Lorem ipsum dolor sit amet
>                          At vero eos et accusam et justo
>                          
>                              Lorem ipsum dolor sit amet, consetetur 
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
>                              takimata sanctus est Lorem ipsum dolor sit amet.
>                          
>                           href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>                      
>                  
>              {code}
> I do not see any reason to not allow class attributes in html code. There 
> might be other problems with these rules but this is a showstopper.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-9153) webpos can not check out in ofbiz 16.11.01 and also in16.11 Release Branch Demo

2019-04-30 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-9153:

  Assignee: Jacques Le Roux

Oops, I did not intend to close yet (started with that) :D

> webpos can not check out in ofbiz 16.11.01 and also in16.11 Release Branch 
> Demo
> ---
>
> Key: OFBIZ-9153
> URL: https://issues.apache.org/jira/browse/OFBIZ-9153
> Project: OFBiz
>  Issue Type: Bug
>  Components: webpos
>Affects Versions: 16.11.01
>Reporter: 李浩
>Assignee: Jacques Le Roux
>Priority: Major
>
>  in Keyboard Shortcuts's"F7 PAY BY CC
> "
> is not credit card pay but actualy is checkout and insert order.
> F8  CHECKOUT  actualy just focus on product amount.
> If we checkout ,will encount an error"INSERT on table 'ORDER_HEADER' caused a 
> violation of foreign key constraint 'ORDER_HDR_SCENUM' for key 
> (POS_SALES_CHANNEL)."background
> the reason is enum_id column of ofbiz.ENUMERATION table does not contain the 
> data "POS_SALES_CHANNEL".
> so now webpos demo can not check out and create order.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9153) webpos can not check out in ofbiz 16.11.01 and also in16.11 Release Branch Demo

2019-04-30 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9153.
--
Resolution: Fixed

I can' reproduce this error either in R16 or trunk but I get this error


{noformat}
2019-04-30 12:20:50,272 |jsse-nio-8443-exec-2 |GenericDelegator  
|E| Failure in create operation for entity [OrderHeader]: 
org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
[GenericEntity:OrderHeader][agr
eementId,null()][billingAccountId,null()][createdBy,admin(java.lang.String)][createdStamp,2019-04-30
 12:20:50.181(java.sql.Timestamp)][createdTxStamp,2019-04-30 
12:20:49.945(java.sql.Timestamp)][currencyUom,USD(java.lang.String)][entryDa
te,2019-04-30 
12:20:50.04(java.sql.Timestamp)][grandTotal,2974.99000(java.math.BigDecimal)][invoicePerShipment,Y(java.lang.String)][lastUpdatedStamp,2019-04-30
 12:20:50.181(java.sql.Timestamp)][lastUpdatedTxStamp,2019-04-30 12:20:49.945(
java.sql.Timestamp)][needsInventoryIssuance,Y(java.lang.String)][orderDate,2019-04-30
 
12:20:50.04(java.sql.Timestamp)][orderId,RSCO10050(java.lang.String)][orderName,null()][orderTypeId,SALES_ORDER(java.lang.String)][originFacilityId,MyR
etailStore(java.lang.String)][productStoreId,9100(java.lang.String)][salesChannelEnumId,POS_SALES_CHANNEL(java.lang.String)][statusId,ORDER_CREATED(java.lang.String)][terminalId,pos-1(java.lang.String)][transactionId,10010(java.lang.Stri
ng)] (SQL Exception while executing the following:INSERT INTO 
OFBIZ.ORDER_HEADER (ORDER_ID, ORDER_TYPE_ID, ORDER_NAME, EXTERNAL_ID, 
SALES_CHANNEL_ENUM_ID, ORDER_DATE, PRIORITY, ENTRY_DATE, 
PICK_SHEET_PRINTED_DATE, VISIT_ID, STATUS_ID, CR
EATED_BY, FIRST_ATTEMPT_ORDER_ID, CURRENCY_UOM, SYNC_STATUS_ID, 
BILLING_ACCOUNT_ID, ORIGIN_FACILITY_ID, WEB_SITE_ID, PRODUCT_STORE_ID, 
AGREEMENT_ID, TERMINAL_ID, TRANSACTION_ID, AUTO_ORDER_SHOPPING_LIST_ID, 
NEEDS_INVENTORY_ISSUANCE, IS_R
USH_ORDER, INTERNAL_CODE, REMAINING_SUB_TOTAL, GRAND_TOTAL, IS_VIEWED, 
INVOICE_PER_SHIPMENT, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 'ORDER_HEADER' 
caused a violation of foreign key constraint 'ORDER_HDR_SCENUM' for key 
(POS_SALES_CHANNEL).  The statement has been rolled back.)). Rolling back 
transaction.
2019-04-30 12:20:50,272 |jsse-nio-8443-exec-2 |TransactionUtil   
|I| Transaction rollback only not set, rollback only is already set.
2019-04-30 12:20:50,272 |jsse-nio-8443-exec-2 |OrderServices 
|E| Cannot create OrderHeader entity; problems with insert
{noformat}

After selecting  
# GZ-1005 '.NIT Gizmo ', 
# paying cash using the F3 button (also there it's does not work very well if 
you don't put the right amount from start, but that's another hair of the yak)
# checking out using the F8 button

So we should close this issue and open a new one for the issue above. I'll do 
so in a week w/o comments.

> webpos can not check out in ofbiz 16.11.01 and also in16.11 Release Branch 
> Demo
> ---
>
> Key: OFBIZ-9153
> URL: https://issues.apache.org/jira/browse/OFBIZ-9153
> Project: OFBiz
>  Issue Type: Bug
>  Components: webpos
>Affects Versions: 16.11.01
>Reporter: 李浩
>Priority: Major
>
>  in Keyboard Shortcuts's"F7 PAY BY CC
> "
> is not credit card pay but actualy is checkout and insert order.
> F8  CHECKOUT  actualy just focus on product amount.
> If we checkout ,will encount an error"INSERT on table 'ORDER_HEADER' caused a 
> violation of foreign key constraint 'ORDER_HDR_SCENUM' for key 
> (POS_SALES_CHANNEL)."background
> the reason is enum_id column of ofbiz.ENUMERATION table does not contain the 
> data "POS_SALES_CHANNEL".
> so now webpos demo can not check out and create order.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10999) Have all @deprecated show when it will be removed from the repo

2019-04-30 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830072#comment-16830072
 ] 

Pierre Smits commented on OFBIZ-10999:
--

Jacques,

What was the gist of the discussion back then? There were a lot of follow-up 
suggestions (actionable items?), but were they followed up/through?

The thing is that we have about 200 functions marked deprecated, and easy way 
of telling when they were deprecated or when they will be removed.

> Have all @deprecated show when it will be removed from the repo
> ---
>
> Key: OFBIZ-10999
> URL: https://issues.apache.org/jira/browse/OFBIZ-10999
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> Currently we don't provide any information on functions with @deprecated when 
> they will be removed from the repo.
> I suggest we add a 'Will be removed at ' + a designator for a release branch 
> after the latest available to the @deprecated, when a function is to be 
> deprecated.
> As an example:
>  * Currently latest available branch is: release18.12
>  * if a contributor deprecates a function now, the statement would be: 
> @deprecated Will be removed at release branch 20.12
> This would leave adopters with enough time to plan for migrations, and at the 
> moment the new branch is cut contributors can easily find what needs to be 
> removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10999) Have all @deprecated show when it will be removed from the repo

2019-04-30 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830069#comment-16830069
 ] 

Jacques Le Roux commented on OFBIZ-10999:
-

Hi Pierre,

You did not participate to this discussion 
https://markmail.org/message/ufjgf3tyanfatlw3. Could you please review it, and 
maybe add your opinions/ideas there, thanks.

> Have all @deprecated show when it will be removed from the repo
> ---
>
> Key: OFBIZ-10999
> URL: https://issues.apache.org/jira/browse/OFBIZ-10999
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> Currently we don't provide any information on functions with @deprecated when 
> they will be removed from the repo.
> I suggest we add a 'Will be removed at ' + a designator for a release branch 
> after the latest available to the @deprecated, when a function is to be 
> deprecated.
> As an example:
>  * Currently latest available branch is: release18.12
>  * if a contributor deprecates a function now, the statement would be: 
> @deprecated Will be removed at release branch 20.12
> This would leave adopters with enough time to plan for migrations, and at the 
> moment the new branch is cut contributors can easily find what needs to be 
> removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11000) Integrate birt functionalities into the bi component

2019-04-30 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11000:
-
Description: Per discussion in dev@. See 
[https://ofbiz.markmail.org/search/?q=bi%2Fbirt+integration#query:bi%2Fbirt%20integration+page:1+mid:mw4vyqfihtv3qgfb+state:results]
 or [[DISCUSSION] bi/birt component 
integration|https://lists.apache.org/thread.html/7f7db5645bba8b9de3a0189356300afd0d7651646671ad782b0a557f@%3Cdev.ofbiz.apache.org%3E]
  (was: Per discussion in dev@. See 
https://ofbiz.markmail.org/search/?q=bi%2Fbirt+integration#query:bi%2Fbirt%20integration+page:1+mid:mw4vyqfihtv3qgfb+state:results)

> Integrate birt functionalities into the bi component
> 
>
> Key: OFBIZ-11000
> URL: https://issues.apache.org/jira/browse/OFBIZ-11000
> Project: OFBiz
>  Issue Type: Improvement
>  Components: bi, birt
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: birt, dwh, refactor
>
> Per discussion in dev@. See 
> [https://ofbiz.markmail.org/search/?q=bi%2Fbirt+integration#query:bi%2Fbirt%20integration+page:1+mid:mw4vyqfihtv3qgfb+state:results]
>  or [[DISCUSSION] bi/birt component 
> integration|https://lists.apache.org/thread.html/7f7db5645bba8b9de3a0189356300afd0d7651646671ad782b0a557f@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema

2019-04-30 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829983#comment-16829983
 ] 

Pierre Smits commented on OFBIZ-10990:
--

No worries, Swapnil,

I value each and every input. 

Could you share your thoughts on [[DISCUSSION] bi/birt component 
integration|https://lists.apache.org/thread.html/7f7db5645bba8b9de3a0189356300afd0d7651646671ad782b0a557f@%3Cdev.ofbiz.apache.org%3E]
 ?

> Improve the SalesInvoiceItemStarSchema
> --
>
> Key: OFBIZ-10990
> URL: https://issues.apache.org/jira/browse/OFBIZ-10990
> Project: OFBiz
>  Issue Type: Improvement
>  Components: bi
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Priority: Major
>  Labels: birt, dwh
>
> The star schema should be improved to include elements from:
>  * Customer dimension
>  * Country dimension
>  * Store dimension
>  * Catalog dimension
>  * Channel dimension



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema

2019-04-30 Thread Swapnil Shah (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829976#comment-16829976
 ] 

Swapnil Shah commented on OFBIZ-10990:
--

I am not sure if i would be able to browse through all the tix history anytime 
soon. Please feel free to ignore and move on if raised issues are already being 
handled one way or other. I just happened to stumble upon this ticket and 
shared few thoughts from the targetted end user perspective on BI and reporting 
. 

> Improve the SalesInvoiceItemStarSchema
> --
>
> Key: OFBIZ-10990
> URL: https://issues.apache.org/jira/browse/OFBIZ-10990
> Project: OFBiz
>  Issue Type: Improvement
>  Components: bi
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Priority: Major
>  Labels: birt, dwh
>
> The star schema should be improved to include elements from:
>  * Customer dimension
>  * Country dimension
>  * Store dimension
>  * Catalog dimension
>  * Channel dimension



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)