[jira] [Comment Edited] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance
[ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837958#comment-16837958 ] bd2019us edited comment on OFBIZ-10934 at 5/11/19 10:35 PM: [^affected_files][^OFBIZ10934-MORE.patch] Attached are # A list of all files which have a likely applicable replaceAll() -> replace conversion followed by the line number # A diff of the patch applied to all affected_file items beginning with 'ofbiz/' Some items are applicable to the ofbiz-framework and are not included in the sample patch. Though this may not comprehensively represent all the replaceAll() replace() in the code-base, these patches take care almost all instances that explicitly do not use a regex expression was (Author: bd2019us): [^affected_files][^OFBIZ10934-MORE.patch] Attached are # A list of all files which have a likely applicable replaceAll() -> replace conversion # A diff of the patch applied to all affected_file items beginning with 'ofbiz/' Some items are applicable to the ofbiz-framework and are not included in the sample patch. Though this may not comprehensively represent all the replaceAll() replace() in the code-base, these patches take care almost all instances that explicitly do not use a regex expression > Performance Increase: Using replace() instead of replaceAll() when a regex is > not used increases performance > > > Key: OFBIZ-10934 > URL: https://issues.apache.org/jira/browse/OFBIZ-10934 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: bd2019us >Priority: Trivial > Labels: pull-request-available > Attachments: OFBIZ-10934.patch, OFBIZ10934-MORE.patch, affected_files > > > Affected files: > # framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java > # > framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java > # > framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java > # framework/base/src/main/java/org/apache/ofbiz/base/util/KeyStoreUtil.java > When replaceAll() is utilized and no regex is used, replaceAll() can be > replaced with replace() for better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance
[ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837958#comment-16837958 ] bd2019us commented on OFBIZ-10934: -- [^affected_files][^OFBIZ10934-MORE.patch] Attached are # A list of all files which have a likely applicable replaceAll() -> replace conversion # A diff of the patch applied to all affected_file items beginning with 'ofbiz/' Some items are applicable to the ofbiz-framework and are not included in the sample patch. Though this may not comprehensively represent all the replaceAll() replace() in the code-base, these patches take care almost all instances that explicitly do not use a regex expression > Performance Increase: Using replace() instead of replaceAll() when a regex is > not used increases performance > > > Key: OFBIZ-10934 > URL: https://issues.apache.org/jira/browse/OFBIZ-10934 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: bd2019us >Priority: Trivial > Labels: pull-request-available > Attachments: OFBIZ-10934.patch, OFBIZ10934-MORE.patch, affected_files > > > Affected files: > # framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java > # > framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java > # > framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java > # framework/base/src/main/java/org/apache/ofbiz/base/util/KeyStoreUtil.java > When replaceAll() is utilized and no regex is used, replaceAll() can be > replaced with replace() for better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance
[ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bd2019us updated OFBIZ-10934: - Attachment: affected_files > Performance Increase: Using replace() instead of replaceAll() when a regex is > not used increases performance > > > Key: OFBIZ-10934 > URL: https://issues.apache.org/jira/browse/OFBIZ-10934 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: bd2019us >Priority: Trivial > Labels: pull-request-available > Attachments: OFBIZ-10934.patch, OFBIZ10934-MORE.patch, affected_files > > > Affected files: > # framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java > # > framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java > # > framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java > # framework/base/src/main/java/org/apache/ofbiz/base/util/KeyStoreUtil.java > When replaceAll() is utilized and no regex is used, replaceAll() can be > replaced with replace() for better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance
[ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bd2019us updated OFBIZ-10934: - Attachment: OFBIZ10934-MORE.patch > Performance Increase: Using replace() instead of replaceAll() when a regex is > not used increases performance > > > Key: OFBIZ-10934 > URL: https://issues.apache.org/jira/browse/OFBIZ-10934 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: bd2019us >Priority: Trivial > Labels: pull-request-available > Attachments: OFBIZ-10934.patch, OFBIZ10934-MORE.patch, affected_files > > > Affected files: > # framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java > # > framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java > # > framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java > # framework/base/src/main/java/org/apache/ofbiz/base/util/KeyStoreUtil.java > When replaceAll() is utilized and no regex is used, replaceAll() can be > replaced with replace() for better performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11019) Cleaning the bloated ‘Security’ interface
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11019: --- Description: The ‘hasPermission(String, HttpSession)’ method declaration from the ‘Security’ interface is breaking the minimality principle of interfaces because it is easily expressible in term of ‘hasPermission(String, GenericEntity)’. As a consequence a static helper method should be implemented to achieve same convenience without polluting the ‘Security’ interface. Other methods in that interface are suffering from the same issue. was:The ‘hasPermission(String, HttpSession)’ method declaration from the ‘Security’ interface is breaking the minimality principle of interfaces because it is easily expressible in term of ‘hasPermission(String, GenericEntity)’. As a consequence a static helper method should be implemented to achieve same convenience without polluting the ‘Security’ interface. > Cleaning the bloated ‘Security’ interface > - > > Key: OFBIZ-11019 > URL: https://issues.apache.org/jira/browse/OFBIZ-11019 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Attachments: > OFBIZ-11019_Relax-the-contract-of-the-Security-interfac.patch > > > The ‘hasPermission(String, HttpSession)’ method declaration from the > ‘Security’ interface is breaking the minimality principle of interfaces > because it is easily expressible in term of ‘hasPermission(String, > GenericEntity)’. As a consequence a static helper method should be > implemented to achieve same convenience without polluting the ‘Security’ > interface. > Other methods in that interface are suffering from the same issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11019) Cleaning the bloated ‘Security’ interface
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11019: --- Summary: Cleaning the bloated ‘Security’ interface (was: Removing ‘hasPermission(String, HttpSession)’ from ‘Security’) > Cleaning the bloated ‘Security’ interface > - > > Key: OFBIZ-11019 > URL: https://issues.apache.org/jira/browse/OFBIZ-11019 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Attachments: > OFBIZ-11019_Relax-the-contract-of-the-Security-interfac.patch > > > The ‘hasPermission(String, HttpSession)’ method declaration from the > ‘Security’ interface is breaking the minimality principle of interfaces > because it is easily expressible in term of ‘hasPermission(String, > GenericEntity)’. As a consequence a static helper method should be > implemented to achieve same convenience without polluting the ‘Security’ > interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11019) Removing ‘hasPermission(String, HttpSession)’ from ‘Security’
[
https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837929#comment-16837929
]
Mathieu Lirzin commented on OFBIZ-11019:
After a deeper look at the {{security}} interface it seems that every method
signature referencing {{HttpSession}} should be deprecated and replaced by a
static helper method like what is done for
{{hasPermission(String,HttpSession)}} as a consequence I will provide extra
patches for that.
> Removing ‘hasPermission(String, HttpSession)’ from ‘Security’
> -
>
> Key: OFBIZ-11019
> URL: https://issues.apache.org/jira/browse/OFBIZ-11019
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11019_Relax-the-contract-of-the-Security-interfac.patch
>
>
> The ‘hasPermission(String, HttpSession)’ method declaration from the
> ‘Security’ interface is breaking the minimality principle of interfaces
> because it is easily expressible in term of ‘hasPermission(String,
> GenericEntity)’. As a consequence a static helper method should be
> implemented to achieve same convenience without polluting the ‘Security’
> interface.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837927#comment-16837927 ] Mathieu Lirzin commented on OFBIZ-10757: Committed [^OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch] in revision 1859123 on trunk, in revision 1859124 on release18.12 and in revision 1859125 on release17.12. I didn't backport it to release16.11 since patch application failed. > Upgrade OFBiz to use Java JDK Version 11 > > > Key: OFBIZ-10757 > URL: https://issues.apache.org/jira/browse/OFBIZ-10757 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, > OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch > > > To implement as per [Discussion > Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10757: --- Attachment: OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch > Upgrade OFBiz to use Java JDK Version 11 > > > Key: OFBIZ-10757 > URL: https://issues.apache.org/jira/browse/OFBIZ-10757 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, > OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, > OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch > > > To implement as per [Discussion > Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10901) Editable screens/forms are shown to user with only VIEW permissions
[ https://issues.apache.org/jira/browse/OFBIZ-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837909#comment-16837909 ] Pawan Verma commented on OFBIZ-10901: - I think we need to make a list of suspected area and possibly create sub-tickets for each component to make it easy for development and review. Please provide an example of a suspected area so that the one who work one this gets a clear idea. Thoughts, please! > Editable screens/forms are shown to user with only VIEW permissions > --- > > Key: OFBIZ-10901 > URL: https://issues.apache.org/jira/browse/OFBIZ-10901 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > > Edit screens should not be shown to users who have only VIEW permissions. > They should be shown only display screens. > When such a user is misled and enters data to change the record an error is > thrown. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11001) Applicable Promo Recommendations
[ https://issues.apache.org/jira/browse/OFBIZ-11001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837851#comment-16837851 ] Rishi Solanki commented on OFBIZ-11001: --- Dear All, While designing this feature I'm thinking to use ProductStorePromoAppl.manualOnly flag. I research around this flag and saw that the flag is usually used to skip the promotion while evaluation. Which means while applying or listing promos for the current cart promo engine skip all the manuanOnly promotions. We can use this flag to manually apply the promotions by customer/user. Please comment on if I skip any other use of the same flag. In case all agree then we can proceed with this flag to design the feature. > Applicable Promo Recommendations > > > Key: OFBIZ-11001 > URL: https://issues.apache.org/jira/browse/OFBIZ-11001 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce, product >Affects Versions: Trunk >Reporter: Rishi Solanki >Priority: Major > > Proposal is to add user selection ability for promotion. That means user can > select her own choice of promotion from the list of promotion applicable to > current cart. Right now promotion engine based on algorithm implemented > decide which promotion will be apply to cart from the list of promotion. For > example, if promotion engine find 3 promotion applicable for the current cart > then based on algorithm implemented it apply the maximum amount value > promotion to the cart. > > Coming back to proposal with some use cases; > > Use Case 1: Promotion engine find three promotions applicable to cart or > item as P1, P2 and P3. And as per algorithm promo engine decide to apply P1. > Now if user want to go with P2 or P3 then she can do that. > > Use Case 2: In #1 user can also choose to not take any promotion, remove the > P1 and submit the order without promotion. > > Use Case 3: Item1 and item2 will have two promotions common as P1 and P2. > Now user can opt which promotion should applicable to which item. That means > user can apply P1 or P2 on item1 or item2 based on her preference. > > Use Case 4: In #3 if user wants then she can opt to select promotion for one > item and can remove promo from other. > [Reference > Thread|https://ofbiz.markmail.org/search/?q=Applicable%20Promo%20Recommendations#query:Applicable%20Promo%20Recommendations+page:1+mid:qvc5zimtu7txbiiy+state:results] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
[ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana reassigned OFBIZ-11021: - Assignee: Suraj Khurana (was: Pawan Verma) > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart > > > Key: OFBIZ-11021 > URL: https://issues.apache.org/jira/browse/OFBIZ-11021 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11021.patch > > > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart. > > Suppose we have two items in the cart: > # The first item is drop-shippable. > # The second item is not drop-shippable. > For the first item, the implementation works fine. > For the second item, this is not working correctly. > > For drop shipment process, cart method 'createDropShipGroups' decides > RequirementMethodEnumId in the order of property set at ProductStore -> > ProductFacility -> Product which work fine in case of all drop-ship products > and if the drop-ship product(s) is added last in the cart. > > The issue I found is that if a combination of a dropship and non-drop ship > products are added into the cart and the non-drop shippable product(s) is > added after the drop shippable product(s) then the non-drop-shippable > products also considered as drop-shippable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
[ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837826#comment-16837826 ] Suraj Khurana commented on OFBIZ-11021: --- +1. Patch looks good to me. > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart > > > Key: OFBIZ-11021 > URL: https://issues.apache.org/jira/browse/OFBIZ-11021 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: OFBIZ-11021.patch > > > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart. > > Suppose we have two items in the cart: > # The first item is drop-shippable. > # The second item is not drop-shippable. > For the first item, the implementation works fine. > For the second item, this is not working correctly. > > For drop shipment process, cart method 'createDropShipGroups' decides > RequirementMethodEnumId in the order of property set at ProductStore -> > ProductFacility -> Product which work fine in case of all drop-ship products > and if the drop-ship product(s) is added last in the cart. > > The issue I found is that if a combination of a dropship and non-drop ship > products are added into the cart and the non-drop shippable product(s) is > added after the drop shippable product(s) then the non-drop-shippable > products also considered as drop-shippable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10800) Unable to remove items from onePageCheckout screen of ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837792#comment-16837792 ] Dhaval Wagela commented on OFBIZ-10800: --- Hello [~suraj.khurana] I have updated the Affect Versions. Thanks > Unable to remove items from onePageCheckout screen of ecommerce > --- > > Key: OFBIZ-10800 > URL: https://issues.apache.org/jira/browse/OFBIZ-10800 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Arpit Mor >Assignee: Dhaval Wagela >Priority: Major > Attachments: 1-ToOnePageCheckout.png, 2-Remove.png, 3-NoAddress2.png, > 4-EmptyLine.png, 5-ScreenResolution.png, 6-100%Zoom.png, 7-80%Zoom.png, > OFBIZ-10800.patch, OFBIZ.10800.patch > > > Steps to regenerate: > # Login to URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/control/checkLogin/main] > # Add items to cart > # Click on One Page Checkout at top right of the page (Please refer > attachment: 1-ToOnePageCheckout) > Actual: Remove link is not working on onePageCheckout screen (Please refer > attachment: 2-Remove) > > Note: Following UI issues were also found on page > # Product image is not displayed on screen and UI is not proper (Please > refer attachment: 2-Remove) > # If in step 2 of the page, address line 2 is empty then on clicking on > continue to step 3, empty line is displayed (Please refer attachments: > 3-NoAddress2 and 4-EmptyLine) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10800) Unable to remove items from onePageCheckout screen of ecommerce
[ https://issues.apache.org/jira/browse/OFBIZ-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhaval Wagela updated OFBIZ-10800: -- Affects Version/s: Release Branch 18.12 Release Branch 17.12 Release Branch 16.11 > Unable to remove items from onePageCheckout screen of ecommerce > --- > > Key: OFBIZ-10800 > URL: https://issues.apache.org/jira/browse/OFBIZ-10800 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Arpit Mor >Assignee: Dhaval Wagela >Priority: Major > Attachments: 1-ToOnePageCheckout.png, 2-Remove.png, 3-NoAddress2.png, > 4-EmptyLine.png, 5-ScreenResolution.png, 6-100%Zoom.png, 7-80%Zoom.png, > OFBIZ-10800.patch, OFBIZ.10800.patch > > > Steps to regenerate: > # Login to URL: > [https://demo-trunk.ofbiz.apache.org/ecommerce/control/checkLogin/main] > # Add items to cart > # Click on One Page Checkout at top right of the page (Please refer > attachment: 1-ToOnePageCheckout) > Actual: Remove link is not working on onePageCheckout screen (Please refer > attachment: 2-Remove) > > Note: Following UI issues were also found on page > # Product image is not displayed on screen and UI is not proper (Please > refer attachment: 2-Remove) > # If in step 2 of the page, address line 2 is empty then on clicking on > continue to step 3, empty line is displayed (Please refer attachments: > 3-NoAddress2 and 4-EmptyLine) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
[ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11021: Attachment: OFBIZ-11021.patch > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart > > > Key: OFBIZ-11021 > URL: https://issues.apache.org/jira/browse/OFBIZ-11021 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: OFBIZ-11021.patch > > > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart. > > Suppose we have two items in the cart: > # The first item is drop-shippable. > # The second item is not drop-shippable. > For the first item, the implementation works fine. > For the second item, this is not working correctly. > > For drop shipment process, cart method 'createDropShipGroups' decides > RequirementMethodEnumId in the order of property set at ProductStore -> > ProductFacility -> Product which work fine in case of all drop-ship products > and if the drop-ship product(s) is added last in the cart. > > The issue I found is that if a combination of a dropship and non-drop ship > products are added into the cart and the non-drop shippable product(s) is > added after the drop shippable product(s) then the non-drop-shippable > products also considered as drop-shippable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
[ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837786#comment-16837786 ] Pawan Verma commented on OFBIZ-11021: - Attached patch with the proper implementation. > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart > > > Key: OFBIZ-11021 > URL: https://issues.apache.org/jira/browse/OFBIZ-11021 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: OFBIZ-11021.patch > > > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart. > > Suppose we have two items in the cart: > # The first item is drop-shippable. > # The second item is not drop-shippable. > For the first item, the implementation works fine. > For the second item, this is not working correctly. > > For drop shipment process, cart method 'createDropShipGroups' decides > RequirementMethodEnumId in the order of property set at ProductStore -> > ProductFacility -> Product which work fine in case of all drop-ship products > and if the drop-ship product(s) is added last in the cart. > > The issue I found is that if a combination of a dropship and non-drop ship > products are added into the cart and the non-drop shippable product(s) is > added after the drop shippable product(s) then the non-drop-shippable > products also considered as drop-shippable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11018) Redirection of pathAlias to aliasTo does not work properly
[ https://issues.apache.org/jira/browse/OFBIZ-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837783#comment-16837783 ] Jacques Le Roux commented on OFBIZ-11018: - Thanks Pawan, I'll check that next week > Redirection of pathAlias to aliasTo does not work properly > -- > > Key: OFBIZ-11018 > URL: https://issues.apache.org/jira/browse/OFBIZ-11018 > Project: OFBiz > Issue Type: Bug > Components: cmssite, content >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: OFBIZ-11018.patch, OFBIZ-11018.patch > > > Link of discussion: [https://markmail.org/message/s37whdteejqdzkha] > In CMS, we can redirect the user to different path alias using 'aliasTo' > field of *WebSitePathAlias* entity. > Example - > fromDate="2019-05-01 00:00:00.0" aliasTo="newDemoHome" /> > Based on the above data, if the user hit the > [https://localhost:8443/cmssite/cms/demoHome], the CMS will internally render > the content for 'newDemoHome' pathAlias. > As per my observation, the content for "newDemoHome" is renderd properly (as > expected) but the URL of the page (in browser) doesn't change. > We should also update the URL also, i.e. change browser URL from > [https://localhost:8443/cmssite/cms/demoHome] to > [https://localhost:8443/cmssite/cms/newDemoHome] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-11018) Redirection of pathAlias to aliasTo does not work properly
[
https://issues.apache.org/jira/browse/OFBIZ-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837778#comment-16837778
]
Pawan Verma edited comment on OFBIZ-11018 at 5/11/19 7:40 AM:
--
Hello [~jacques.le.roux],
Thanks for reviewing this.
Edit WebSite Path Alias is not working, I have logged OFBIZ-11022 for this.
{code:java}
java.lang.IllegalArgumentException: Passed List had more than one value.
{code}
For this error: As I see from the data provided by you two *WebSitePathAlias*
records has been created in the system as both have different fromDate with the
same pathAlias. Code is using queryOne to fetch the record, I have updated it
to use queryFirst instead(*Updated patch for this*).
For checking this functionality:
I would suggest creating two new pathAlias from the content screen or manual
XML data. Original pathAlias should not have any content associated with
it(existing condition) and associate content with the aliasTo.
Please let me know in case of any concern. Thanks!
was (Author: pawan.verma):
Hello [~jacques.le.roux],
Thanks for reviewing this.
Edit WebSite Path Alias is not working, I have logged
[OFBIZ-11022|https://issues.apache.org/jira/browse/OFBIZ-11022] for this.
{code:java}
java.lang.IllegalArgumentException: Passed List had more than one value.
{code}
For this error: As I see from the data provided by you two *WebSitePathAlias*
records has been created in the system as both have different fromDate with the
same pathAlias. Code is using queryOne to fetch the record, I have updated it
to use queryFirst instead(*Updated patch for this*).
For checking this functionality:
I would suggest creating two new pathAlias from the content screen or manual
XML data. Original pathAlias should not have any content associated with
it(existing condition) and associate content with the aliasTo.
Please let me know in case of any concern. Thanks!
> Redirection of pathAlias to aliasTo does not work properly
> --
>
> Key: OFBIZ-11018
> URL: https://issues.apache.org/jira/browse/OFBIZ-11018
> Project: OFBiz
> Issue Type: Bug
> Components: cmssite, content
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-11018.patch, OFBIZ-11018.patch
>
>
> Link of discussion: [https://markmail.org/message/s37whdteejqdzkha]
> In CMS, we can redirect the user to different path alias using 'aliasTo'
> field of *WebSitePathAlias* entity.
> Example -
> fromDate="2019-05-01 00:00:00.0" aliasTo="newDemoHome" />
> Based on the above data, if the user hit the
> [https://localhost:8443/cmssite/cms/demoHome], the CMS will internally render
> the content for 'newDemoHome' pathAlias.
> As per my observation, the content for "newDemoHome" is renderd properly (as
> expected) but the URL of the page (in browser) doesn't change.
> We should also update the URL also, i.e. change browser URL from
> [https://localhost:8443/cmssite/cms/demoHome] to
> [https://localhost:8443/cmssite/cms/newDemoHome]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11018) Redirection of pathAlias to aliasTo does not work properly
[ https://issues.apache.org/jira/browse/OFBIZ-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11018: Attachment: OFBIZ-11018.patch > Redirection of pathAlias to aliasTo does not work properly > -- > > Key: OFBIZ-11018 > URL: https://issues.apache.org/jira/browse/OFBIZ-11018 > Project: OFBiz > Issue Type: Bug > Components: cmssite, content >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: OFBIZ-11018.patch, OFBIZ-11018.patch > > > Link of discussion: [https://markmail.org/message/s37whdteejqdzkha] > In CMS, we can redirect the user to different path alias using 'aliasTo' > field of *WebSitePathAlias* entity. > Example - > fromDate="2019-05-01 00:00:00.0" aliasTo="newDemoHome" /> > Based on the above data, if the user hit the > [https://localhost:8443/cmssite/cms/demoHome], the CMS will internally render > the content for 'newDemoHome' pathAlias. > As per my observation, the content for "newDemoHome" is renderd properly (as > expected) but the URL of the page (in browser) doesn't change. > We should also update the URL also, i.e. change browser URL from > [https://localhost:8443/cmssite/cms/demoHome] to > [https://localhost:8443/cmssite/cms/newDemoHome] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11018) Redirection of pathAlias to aliasTo does not work properly
[
https://issues.apache.org/jira/browse/OFBIZ-11018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837778#comment-16837778
]
Pawan Verma commented on OFBIZ-11018:
-
Hello [~jacques.le.roux],
Thanks for reviewing this.
Edit WebSite Path Alias is not working, I have logged
[OFBIZ-11022|https://issues.apache.org/jira/browse/OFBIZ-11022] for this.
{code:java}
java.lang.IllegalArgumentException: Passed List had more than one value.
{code}
For this error: As I see from the data provided by you two *WebSitePathAlias*
records has been created in the system as both have different fromDate with the
same pathAlias. Code is using queryOne to fetch the record, I have updated it
to use queryFirst instead(*Updated patch for this*).
For checking this functionality:
I would suggest creating two new pathAlias from the content screen or manual
XML data. Original pathAlias should not have any content associated with
it(existing condition) and associate content with the aliasTo.
Please let me know in case of any concern. Thanks!
> Redirection of pathAlias to aliasTo does not work properly
> --
>
> Key: OFBIZ-11018
> URL: https://issues.apache.org/jira/browse/OFBIZ-11018
> Project: OFBiz
> Issue Type: Bug
> Components: cmssite, content
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-11018.patch
>
>
> Link of discussion: [https://markmail.org/message/s37whdteejqdzkha]
> In CMS, we can redirect the user to different path alias using 'aliasTo'
> field of *WebSitePathAlias* entity.
> Example -
> fromDate="2019-05-01 00:00:00.0" aliasTo="newDemoHome" />
> Based on the above data, if the user hit the
> [https://localhost:8443/cmssite/cms/demoHome], the CMS will internally render
> the content for 'newDemoHome' pathAlias.
> As per my observation, the content for "newDemoHome" is renderd properly (as
> expected) but the URL of the page (in browser) doesn't change.
> We should also update the URL also, i.e. change browser URL from
> [https://localhost:8443/cmssite/cms/demoHome] to
> [https://localhost:8443/cmssite/cms/newDemoHome]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-11022) Edit WebSite Path Alias is not working
Pawan Verma created OFBIZ-11022: --- Summary: Edit WebSite Path Alias is not working Key: OFBIZ-11022 URL: https://issues.apache.org/jira/browse/OFBIZ-11022 Project: OFBiz Issue Type: Bug Components: content Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Pawan Verma Steps to regenerate: # Login into content # Select any website(Preferably CmsSite as it has pathAlias) # Click on pathAlias tab # Select any pathAlias to edit See edit option is not available on screen, Create option is available which is creating new pathAlias instead of edit. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
[ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11021: Description: The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart. Suppose we have two items in the cart: # The first item is drop-shippable. # The second item is not drop-shippable. For the first item, the implementation works fine. For the second item, this is not working correctly. For drop shipment process, cart method 'createDropShipGroups' decides RequirementMethodEnumId in the order of property set at ProductStore -> ProductFacility -> Product which work fine in case of all drop-ship products and if the drop-ship product(s) is added last in the cart. The issue I found is that if a combination of a dropship and non-drop ship products are added into the cart and the non-drop shippable product(s) is added after the drop shippable product(s) then the non-drop-shippable products also considered as drop-shippable. was: The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart. Suppose we have two items in the cart: # The first item is drop-shippable. # The second item is not drop-shippable. For the first item, the implementation works fine. For the second item, this is not working correctly. For drop shipment process, cart method 'createDropShipGroups' decides RequirementMethodEnumId in the order of property set at ProductStore -> ProductFacility -> Product which work fine in case of all drop-ship products and if the drop-ship product(s) is added last in the cart. The issue I found is that if a combination of a dropship and non-drop ship products are added into the cart and the non-drop shippable product(s) is added after the drop shippable product(s) then the non-drop-shippable products also considered as drop-shippable. > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart > > > Key: OFBIZ-11021 > URL: https://issues.apache.org/jira/browse/OFBIZ-11021 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Pawan Verma >Priority: Major > > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart. > > Suppose we have two items in the cart: > # The first item is drop-shippable. > # The second item is not drop-shippable. > For the first item, the implementation works fine. > For the second item, this is not working correctly. > > For drop shipment process, cart method 'createDropShipGroups' decides > RequirementMethodEnumId in the order of property set at ProductStore -> > ProductFacility -> Product which work fine in case of all drop-ship products > and if the drop-ship product(s) is added last in the cart. > > The issue I found is that if a combination of a dropship and non-drop ship > products are added into the cart and the non-drop shippable product(s) is > added after the drop shippable product(s) then the non-drop-shippable > products also considered as drop-shippable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
Pawan Verma created OFBIZ-11021: --- Summary: The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart Key: OFBIZ-11021 URL: https://issues.apache.org/jira/browse/OFBIZ-11021 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk, Release Branch 18.12 Reporter: Pawan Verma The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart. Suppose we have two items in the cart: # The first item is drop-shippable. # The second item is not drop-shippable. For the first item, the implementation works fine. For the second item, this is not working correctly. For drop shipment process, cart method 'createDropShipGroups' decides RequirementMethodEnumId in the order of property set at ProductStore -> ProductFacility -> Product which work fine in case of all drop-ship products and if the drop-ship product(s) is added last in the cart. The issue I found is that if a combination of a dropship and non-drop ship products are added into the cart and the non-drop shippable product(s) is added after the drop shippable product(s) then the non-drop-shippable products also considered as drop-shippable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
[ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11021: --- Assignee: Pawan Verma > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart > > > Key: OFBIZ-11021 > URL: https://issues.apache.org/jira/browse/OFBIZ-11021 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart. > > Suppose we have two items in the cart: > # The first item is drop-shippable. > # The second item is not drop-shippable. > For the first item, the implementation works fine. > For the second item, this is not working correctly. > > For drop shipment process, cart method 'createDropShipGroups' decides > RequirementMethodEnumId in the order of property set at ProductStore -> > ProductFacility -> Product which work fine in case of all drop-ship products > and if the drop-ship product(s) is added last in the cart. > > The issue I found is that if a combination of a dropship and non-drop ship > products are added into the cart and the non-drop shippable product(s) is > added after the drop shippable product(s) then the non-drop-shippable > products also considered as drop-shippable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
