[jira] [Assigned] (OFBIZ-11035) Add timezone support to recurring job temporal expressions
[ https://issues.apache.org/jira/browse/OFBIZ-11035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11035: --- Assignee: Pawan Verma > Add timezone support to recurring job temporal expressions > -- > > Key: OFBIZ-11035 > URL: https://issues.apache.org/jira/browse/OFBIZ-11035 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > > Link of the discussion: [https://markmail.org/message/jsjqmjypaihbbldn] > *As per Scott:* > Trying to decide on the best way to define a *temporal* *expression* for a > recurring job where the *temporal* *expression* should be evaluated using a > *timezone* other than whatever the default *timezone* is for the system. > The use case is having a system that runs on UTC time but needs to send a > report at 5 pm Pacific Time every day regardless of whether or not daylight > savings is in effect. > Two options: > # Add a field to *JobSandbox* such as recurrenceTimeZone (or better name!) > # Use whatever *timezone* is available in the RunTime data service context > Based on the discussion on Dev Mailing list #1 will be used to implement this > feature. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10992) No pre-filled value while selecting "facilityId To" on Transfer Inventory Item screen
[ https://issues.apache.org/jira/browse/OFBIZ-10992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-10992: --- Sprint: Community Day (May 2019) > No pre-filled value while selecting "facilityId To" on Transfer Inventory > Item screen > - > > Key: OFBIZ-10992 > URL: https://issues.apache.org/jira/browse/OFBIZ-10992 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Aishwary Shrivastava >Assignee: Swapnil M Mane >Priority: Minor > Attachments: NewFacility.png, OFBIZ-10992.patch, > TransferInventoryItem.png > > > While creating Transfer Inventory Item from warehouse, there are no prefiled > values in selecting FacilityId To. > Steps to regenerate: > # Go to Facilities. > # Select Inventory Xfers. > # Create Transfer Inventory Item From any Warehouse. > # Fill values in the feilds. > # Try to click on FacilityIdTo field > Attached the screenshots for creating new inventory item transfer screen and > new facility screen. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841700#comment-16841700
]
Jacques Le Roux commented on OFBIZ-10187:
-
Hi Dennis,
It's from 2011:
https://github.com/OWASP/java-html-sanitizer/blame/master/src/main/java/org/owasp/html/examples/EbayPolicyExample.java
Not sure why you missed it.
> OWASP sanitizer breaks proper rendering of HTML code
>
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch
> 18.12
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
> Labels: backport-needed
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments:
> OFBIZ-10187_Rewrite-CustomPermissivePolicy-matchesEithe.patch,
> OFBIZ-10187_Sanitizer.patch, OFBIZ-10187_Sanitizer_16.11.patch,
> OFBIZ-10187_Sanitizer_New.patch
>
>
> The current implementation of the sanitizer breaks the proper rendering of
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> will be rendered to
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> I do not see any reason to not allow class attributes in html code. There
> might be other problems with these rules but this is a showstopper.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10996) Have a Supplier dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10996: - Attachment: OFBIZ-10996-SupplierDimension.patch > Have a Supplier dimension > - > > Key: OFBIZ-10996 > URL: https://issues.apache.org/jira/browse/OFBIZ-10996 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SupplierDimension, birt, dimension, dww, supplier > Attachments: OFBIZ-10996-SupplierDimension.patch > > > The component would benefit from a Supplier dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10997) Have an Employee dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10997: - Attachment: OFBIZ-10997-EmployeeDimension.patch > Have an Employee dimension > -- > > Key: OFBIZ-10997 > URL: https://issues.apache.org/jira/browse/OFBIZ-10997 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: EmployeeDimension, birt, dimension, dwh, employee > Attachments: OFBIZ-10997-EmployeeDimension.patch > > > The component would benefit from an employee dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11034) Have a Carrier dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11034: - Attachment: OFBIZ-11034-CarrierDimension.patch > Have a Carrier dimension > > > Key: OFBIZ-11034 > URL: https://issues.apache.org/jira/browse/OFBIZ-11034 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CarrierDimension, birt, carrier, dimension, dwh > Attachments: OFBIZ-11034-CarrierDimension.patch > > > The component would benefit from a Carrier dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11026) HR Doc drive by process
[ https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841441#comment-16841441 ] Jacques Le Roux commented on OFBIZ-11026: - Thanks Olivier, it's clear to me > HR Doc drive by process > --- > > Key: OFBIZ-11026 > URL: https://issues.apache.org/jira/browse/OFBIZ-11026 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: Documentation, humanres > Attachments: OFBIZ-11026_hr-intro.adoc.patch, > OFBIZ-11026_humanres.adoc.patch, > OFBIZ-11026_humanres.adoc_with_hr-about-doc.patch > > > Currently HR doc main chapters are on core HR object, I propose to group them > in a chapter and having a chapter by process in the same level bot group in > the HR Process. > Each process is described via a scenario explained like a tutorial, and each > time a core object is used, a link is done to its chapter. > To help review : doc with these modifications are available at > [https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources] > and Apache OFBiz standard (without modifications) is available too at > https://ofbizadoc.ofbizextra.org/html5/user-manual-std.html#_human_resources > current HR TOC > -- > 3.2. Human Resources > 3.2.1. About Human Resources > 3.2.2. Human Resources Processes > 3.2.3. Employee Positions > 3.2.4. Employees > 3.2.5. Employments > 3.2.6. Performance Review > 3.2.7. Qualifications > 3.2.8. Recruitment > 3.2.9. Skills > 3.2.10. Resumes > 3.2.11. Training > 3.2.12. Leave > 3.2.13. Security > 3.2.14. Global HR Settings > 3.2.15. Glossary > Proposed HR TOC > > 4. Human Resources > 4.1. About this documentation > 4.2. About Human Resources > 4.3. HR Processes > 4.3.1. Organization, Job Position and Definition > 4.3.2. Recruitment, Candidate Selection and Hiring > 4.3.3. Employee Training and Development > 4.3.4. Performance Management and Employee Evaluation > 4.3.5. Employee Salary and Benefits Administration > 4.4. HR core object > 4.4.1. Employee Positions > 4.4.2. Employees > 4.4.3. Employments > 4.4.4. Performance Review > 4.4.5. Qualifications > 4.4.6. Recruitment > 4.4.7. Skills > 4.4.8. Resumes > 4.4.9. Training > 4.4.10. Leave > 4.4.11. Security > 4.5. Global HR Settings > 4.5.1. Skills Types > 4.6. HR Data model > 4.6.1. Employee Position > 4.6.2. Employment > 4.6.3. Qualification, Skill, Review > 4.6.4. HR App intra-application integration > 4.7. Glossary -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11026) HR Doc drive by process
[ https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11026: --- Attachment: OFBIZ-11026_humanres.adoc_with_hr-about-doc.patch > HR Doc drive by process > --- > > Key: OFBIZ-11026 > URL: https://issues.apache.org/jira/browse/OFBIZ-11026 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: Documentation, humanres > Attachments: OFBIZ-11026_hr-intro.adoc.patch, > OFBIZ-11026_humanres.adoc.patch, > OFBIZ-11026_humanres.adoc_with_hr-about-doc.patch > > > Currently HR doc main chapters are on core HR object, I propose to group them > in a chapter and having a chapter by process in the same level bot group in > the HR Process. > Each process is described via a scenario explained like a tutorial, and each > time a core object is used, a link is done to its chapter. > To help review : doc with these modifications are available at > [https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources] > and Apache OFBiz standard (without modifications) is available too at > https://ofbizadoc.ofbizextra.org/html5/user-manual-std.html#_human_resources > current HR TOC > -- > 3.2. Human Resources > 3.2.1. About Human Resources > 3.2.2. Human Resources Processes > 3.2.3. Employee Positions > 3.2.4. Employees > 3.2.5. Employments > 3.2.6. Performance Review > 3.2.7. Qualifications > 3.2.8. Recruitment > 3.2.9. Skills > 3.2.10. Resumes > 3.2.11. Training > 3.2.12. Leave > 3.2.13. Security > 3.2.14. Global HR Settings > 3.2.15. Glossary > Proposed HR TOC > > 4. Human Resources > 4.1. About this documentation > 4.2. About Human Resources > 4.3. HR Processes > 4.3.1. Organization, Job Position and Definition > 4.3.2. Recruitment, Candidate Selection and Hiring > 4.3.3. Employee Training and Development > 4.3.4. Performance Management and Employee Evaluation > 4.3.5. Employee Salary and Benefits Administration > 4.4. HR core object > 4.4.1. Employee Positions > 4.4.2. Employees > 4.4.3. Employments > 4.4.4. Performance Review > 4.4.5. Qualifications > 4.4.6. Recruitment > 4.4.7. Skills > 4.4.8. Resumes > 4.4.9. Training > 4.4.10. Leave > 4.4.11. Security > 4.5. Global HR Settings > 4.5.1. Skills Types > 4.6. HR Data model > 4.6.1. Employee Position > 4.6.2. Employment > 4.6.3. Qualification, Skill, Review > 4.6.4. HR App intra-application integration > 4.7. Glossary -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11039) add a chapter "About this documentation"
[ https://issues.apache.org/jira/browse/OFBIZ-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11039: --- Attachment: Employee_Main_Screen.png HR-Employee_Submenu_Rainbow_Stone.png HR-Employee_Submenu_Tomahawk.png HR_Application_Submenu_Rainbow_Stone.png HR_Application_Submenu_Tomahawk.png > add a chapter "About this documentation" > > > Key: OFBIZ-11039 > URL: https://issues.apache.org/jira/browse/OFBIZ-11039 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Fix For: Trunk > > Attachments: Employee_Main_Screen.png, > HR-Employee_Submenu_Rainbow_Stone.png, HR-Employee_Submenu_Tomahawk.png, > HR_Application_Submenu_Rainbow_Stone.png, > HR_Application_Submenu_Tomahawk.png, hr-about-doc.adoc > > > This chapter present the main OFBiz GUI rules with some screenshot and link > between tutorial and video of "Scenario GUI Test" > Currently it's in HR, but when other application will be done it can be > generalize and go to User Manual introduction. > The file hr-about-doc.adoc associated with this task is included via a > include:: line in the humanres.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11039) add a chapter "About this documentation"
[ https://issues.apache.org/jira/browse/OFBIZ-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11039: --- Attachment: hr-about-doc.adoc > add a chapter "About this documentation" > > > Key: OFBIZ-11039 > URL: https://issues.apache.org/jira/browse/OFBIZ-11039 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Fix For: Trunk > > Attachments: hr-about-doc.adoc > > > This chapter present the main OFBiz GUI rules with some screenshot and link > between tutorial and video of "Scenario GUI Test" > Currently it's in HR, but when other application will be done it can be > generalize and go to User Manual introduction. > The file hr-about-doc.adoc associated with this task is included via a > include:: line in the humanres.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11039) add a chapter "About this documentation"
Olivier Heintz created OFBIZ-11039: -- Summary: add a chapter "About this documentation" Key: OFBIZ-11039 URL: https://issues.apache.org/jira/browse/OFBIZ-11039 Project: OFBiz Issue Type: Sub-task Components: humanres Affects Versions: Trunk Reporter: Olivier Heintz Fix For: Trunk This chapter present the main OFBiz GUI rules with some screenshot and link between tutorial and video of "Scenario GUI Test" Currently it's in HR, but when other application will be done it can be generalize and go to User Manual introduction. The file hr-about-doc.adoc associated with this task is included via a include:: line in the humanres.adoc -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11037) Improve PartyAcctgPrefAndGroup to reflect all fields from the PartyAcctgPreference entity
[ https://issues.apache.org/jira/browse/OFBIZ-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11037: - Attachment: OFBIZ-11037-Party.patch.diff > Improve PartyAcctgPrefAndGroup to reflect all fields from the > PartyAcctgPreference entity > - > > Key: OFBIZ-11037 > URL: https://issues.apache.org/jira/browse/OFBIZ-11037 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: internalOrganisation, view > Attachments: OFBIZ-11037-Party.patch.diff > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11038) Unable to view a PartyContent on view profile page of a party
[ https://issues.apache.org/jira/browse/OFBIZ-11038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11038: -- Attachment: Error_message.png PartyContent_View.png > Unable to view a PartyContent on view profile page of a party > - > > Key: OFBIZ-11038 > URL: https://issues.apache.org/jira/browse/OFBIZ-11038 > Project: OFBiz > Issue Type: Bug > Components: party >Reporter: Devanshu Vyas >Priority: Minor > Attachments: Error_message.png, PartyContent_View.png > > > * Go to [partymgr|https://demo-trunk.ofbiz.apache.org/partymgr/control/main] > * Search any party(e.g. DemoCustomer) > * Go to the [party > profile|https://demo-trunk.ofbiz.apache.org/partymgr/control/viewprofile?partyId=DemoCustomer] > page > * Go to Party Content section on the page and upload a file > * Select a purpose(Logo Image Url) and click on the Upload button > * On page refresh, click on the view button to view the image uploaded. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11037) Improve PartyAcctgPrefAndGroup to reflect all fields from the PartyAcctgPreference entity
Pierre Smits created OFBIZ-11037: Summary: Improve PartyAcctgPrefAndGroup to reflect all fields from the PartyAcctgPreference entity Key: OFBIZ-11037 URL: https://issues.apache.org/jira/browse/OFBIZ-11037 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Pierre Smits -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11037) Improve PartyAcctgPrefAndGroup to reflect all fields from the PartyAcctgPreference entity
[ https://issues.apache.org/jira/browse/OFBIZ-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-11037: Assignee: Pierre Smits > Improve PartyAcctgPrefAndGroup to reflect all fields from the > PartyAcctgPreference entity > - > > Key: OFBIZ-11037 > URL: https://issues.apache.org/jira/browse/OFBIZ-11037 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: internalOrganisation, view > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11038) Unable to view a PartyContent on view profile page of a party
Devanshu Vyas created OFBIZ-11038: - Summary: Unable to view a PartyContent on view profile page of a party Key: OFBIZ-11038 URL: https://issues.apache.org/jira/browse/OFBIZ-11038 Project: OFBiz Issue Type: Bug Components: party Reporter: Devanshu Vyas Attachments: Error_message.png, PartyContent_View.png * Go to [partymgr|https://demo-trunk.ofbiz.apache.org/partymgr/control/main] * Search any party(e.g. DemoCustomer) * Go to the [party profile|https://demo-trunk.ofbiz.apache.org/partymgr/control/viewprofile?partyId=DemoCustomer] page * Go to Party Content section on the page and upload a file * Select a purpose(Logo Image Url) and click on the Upload button * On page refresh, click on the view button to view the image uploaded. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10969) Unable to create Employments
[ https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841406#comment-16841406 ] Jacques Le Roux commented on OFBIZ-10969: - Thanks Olivier, That all makes sense. It seems to me that we should wait for recruitment test scenario to be enforced before committing, right? > Unable to create Employments > > > Key: OFBIZ-10969 > URL: https://issues.apache.org/jira/browse/OFBIZ-10969 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Attachments: Image1.png > > > Steps to regenerate: > # Login to the URL: > [https://demo-trunk.ofbiz.apache.org/humanres/control/main] > # Click on Employments > # Click on New Employments > # Click on Create > Actual: Error message is displayed. Please refer attachment: Image1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11037) Improve PartyAcctgPrefAndGroup to reflect all fields from the PartyAcctgPreference entity
[ https://issues.apache.org/jira/browse/OFBIZ-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11037: - Labels: internalOrganisation view (was: ) > Improve PartyAcctgPrefAndGroup to reflect all fields from the > PartyAcctgPreference entity > - > > Key: OFBIZ-11037 > URL: https://issues.apache.org/jira/browse/OFBIZ-11037 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: internalOrganisation, view > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11026) HR Doc drive by process
[ https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841397#comment-16841397 ] Olivier Heintz commented on OFBIZ-11026: Hi Jacques, I want to do too many modifications in one time ;), your remark is link to the Jira I have just created OFBIZ-11036 to have one more level for each application and not too long chapter number > HR Doc drive by process > --- > > Key: OFBIZ-11026 > URL: https://issues.apache.org/jira/browse/OFBIZ-11026 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: Documentation, humanres > Attachments: OFBIZ-11026_hr-intro.adoc.patch, > OFBIZ-11026_humanres.adoc.patch > > > Currently HR doc main chapters are on core HR object, I propose to group them > in a chapter and having a chapter by process in the same level bot group in > the HR Process. > Each process is described via a scenario explained like a tutorial, and each > time a core object is used, a link is done to its chapter. > To help review : doc with these modifications are available at > [https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources] > and Apache OFBiz standard (without modifications) is available too at > https://ofbizadoc.ofbizextra.org/html5/user-manual-std.html#_human_resources > current HR TOC > -- > 3.2. Human Resources > 3.2.1. About Human Resources > 3.2.2. Human Resources Processes > 3.2.3. Employee Positions > 3.2.4. Employees > 3.2.5. Employments > 3.2.6. Performance Review > 3.2.7. Qualifications > 3.2.8. Recruitment > 3.2.9. Skills > 3.2.10. Resumes > 3.2.11. Training > 3.2.12. Leave > 3.2.13. Security > 3.2.14. Global HR Settings > 3.2.15. Glossary > Proposed HR TOC > > 4. Human Resources > 4.1. About this documentation > 4.2. About Human Resources > 4.3. HR Processes > 4.3.1. Organization, Job Position and Definition > 4.3.2. Recruitment, Candidate Selection and Hiring > 4.3.3. Employee Training and Development > 4.3.4. Performance Management and Employee Evaluation > 4.3.5. Employee Salary and Benefits Administration > 4.4. HR core object > 4.4.1. Employee Positions > 4.4.2. Employees > 4.4.3. Employments > 4.4.4. Performance Review > 4.4.5. Qualifications > 4.4.6. Recruitment > 4.4.7. Skills > 4.4.8. Resumes > 4.4.9. Training > 4.4.10. Leave > 4.4.11. Security > 4.5. Global HR Settings > 4.5.1. Skills Types > 4.6. HR Data model > 4.6.1. Employee Position > 4.6.2. Employment > 4.6.3. Qualification, Skill, Review > 4.6.4. HR App intra-application integration > 4.7. Glossary -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11036) User Manual : change the level of from 2 to 1
[
https://issues.apache.org/jira/browse/OFBIZ-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Heintz updated OFBIZ-11036:
---
Description:
If is on level 1, it become a main separator in
TOC not a chapter
TOC become
{code:java}
...
2. Quick start
Core Business Applications
3. Accounting
4. Human Resources
{code}
and so we have one more level (in TOC) for each application
was:
{{If is on level 1, it become a main separator in
TOC not a chapter}}
{{ TOC become}}
{{}}
...
2. Quick start
Core Business Applications
3. Accounting
4. Human Resources
{{and so we have one more level (in TOC) for each application}}
> User Manual : change the level of from 2 to 1
> --
>
> Key: OFBIZ-11036
> URL: https://issues.apache.org/jira/browse/OFBIZ-11036
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>
> If is on level 1, it become a main separator in
> TOC not a chapter
> TOC become
> {code:java}
> ...
> 2. Quick start
> Core Business Applications
> 3. Accounting
> 4. Human Resources
> {code}
> and so we have one more level (in TOC) for each application
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841384#comment-16841384
]
Jacques Le Roux commented on OFBIZ-10187:
-
Actually I checked the changes since Nov 24th (or something like that) and,
from what I recall, there were no changes in this part. But I could have missed
something. I think it's safe to add them, even it's not a biggie.
> OWASP sanitizer breaks proper rendering of HTML code
>
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch
> 18.12
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
> Labels: backport-needed
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments:
> OFBIZ-10187_Rewrite-CustomPermissivePolicy-matchesEithe.patch,
> OFBIZ-10187_Sanitizer.patch, OFBIZ-10187_Sanitizer_16.11.patch,
> OFBIZ-10187_Sanitizer_New.patch
>
>
> The current implementation of the sanitizer breaks the proper rendering of
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> will be rendered to
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> I do not see any reason to not allow class attributes in html code. There
> might be other problems with these rules but this is a showstopper.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-11036) User Manual : change the level of from 2 to 1
Olivier Heintz created OFBIZ-11036:
--
Summary: User Manual : change the level of from 2 to 1
Key: OFBIZ-11036
URL: https://issues.apache.org/jira/browse/OFBIZ-11036
Project: OFBiz
Issue Type: Sub-task
Components: ALL APPLICATIONS
Affects Versions: Trunk
Reporter: Olivier Heintz
{{If is on level 1, it become a main separator in
TOC not a chapter}}
{{ TOC become}}
{{}}
...
2. Quick start
Core Business Applications
3. Accounting
4. Human Resources
{{and so we have one more level (in TOC) for each application}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841370#comment-16841370
]
Dennis Balkir commented on OFBIZ-10187:
---
Hi Jacques,
you are right, these are missing in my version.
I checked it and it seems, that the ebay version on github was changed on 25th
march this year, so it might be possible, that the missing components just
weren't in this file as I used it as a template for my changes.
I didn't add them myself, because I thought, that they are not important enough
to put them inside of an OFBiz policy opposing to the ones I added, which are
quite important for current development with HTML 5.
> OWASP sanitizer breaks proper rendering of HTML code
>
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch
> 18.12
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
> Labels: backport-needed
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments:
> OFBIZ-10187_Rewrite-CustomPermissivePolicy-matchesEithe.patch,
> OFBIZ-10187_Sanitizer.patch, OFBIZ-10187_Sanitizer_16.11.patch,
> OFBIZ-10187_Sanitizer_New.patch
>
>
> The current implementation of the sanitizer breaks the proper rendering of
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> will be rendered to
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> I do not see any reason to not allow class attributes in html code. There
> might be other problems with these rules but this is a showstopper.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841361#comment-16841361
]
Jacques Le Roux commented on OFBIZ-10187:
-
To be totally clear I compared the 2 versions. This is what I found:
You added
.allowAttributes("target").matching(NAME).onElements("a")
and the elements "header", "picture", "source", "section", "nav", "footer"
On the other side there is more:
.allowAttributes("background").matching(ONSITE_URL)
.onElements("table")
.allowAttributes("background").matching(ONSITE_URL)
.onElements("td", "th", "tr")
Are the later missing on purpose?
I was also surprised how slight is
https://github.com/OWASP/java-html-sanitizer/blob/master/src/main/java/org/owasp/html/examples/SlashdotPolicyExample.java
Anyway I'll try to use that as safe in a 1st step and will reserve eBay one as
permissive as you did (ie will not change anything from your work).
> OWASP sanitizer breaks proper rendering of HTML code
>
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch
> 18.12
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
> Labels: backport-needed
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments:
> OFBIZ-10187_Rewrite-CustomPermissivePolicy-matchesEithe.patch,
> OFBIZ-10187_Sanitizer.patch, OFBIZ-10187_Sanitizer_16.11.patch,
> OFBIZ-10187_Sanitizer_New.patch
>
>
> The current implementation of the sanitizer breaks the proper rendering of
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> will be rendered to
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> I do not see any reason to not allow class attributes in html code. There
> might be other problems with these rules but this is a showstopper.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10969) Unable to create Employments
[ https://issues.apache.org/jira/browse/OFBIZ-10969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841341#comment-16841341 ] Olivier Heintz commented on OFBIZ-10969: In the HR test scenario, I start by create an employee and after an employment, so all works ! In the recruitment test scenario I will create a Party (without role EMPLOYEE) and after selection process I will test createEmployment to check if it do the EMPLOYEE role creation. For now, I have added in the createEmployment service the call to ensurePartyRoleTo service, so now it works, even if before, partyTo is'nt associated to roleType EMPLOYEE. And update the OFBIZ-11028 patch Jacques, thank you for the test. > Unable to create Employments > > > Key: OFBIZ-10969 > URL: https://issues.apache.org/jira/browse/OFBIZ-10969 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Jacques Le Roux >Priority: Major > Attachments: Image1.png > > > Steps to regenerate: > # Login to the URL: > [https://demo-trunk.ofbiz.apache.org/humanres/control/main] > # Click on Employments > # Click on New Employments > # Click on Create > Actual: Error message is displayed. Please refer attachment: Image1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10991) Have a SalesChannel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841338#comment-16841338 ] Pierre Smits edited comment on OFBIZ-10991 at 5/16/19 1:30 PM: --- Thank you for your feedback and suggestion(s), [~suraj.khurana] The project does not need, IMO, contributors that 'manage' tickets. A 'parent' ticket works well for sub-tasks, not for other tickets (well, maybe for new feature tickets). After all, any contributor is quite capable of working a ticket without management. We're all volunteers here. And each should be able to get an overview of what his set of open tickets are. But if you want an overview (or more) of what is being worked on in the greater context of this ticket, have a look at: # [OFBiz BI page|https://cwiki.apache.org/confluence/display/OFBIZ/Business+Intelligence] # [Apache OFBiz (dashboard)|https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603] was (Author: pfm.smits): Thank you for your feedback and suggestion(s), [~suraj.khurana] The project does not, IMO, contributors that 'manage' tickets. A 'parent' ticket works well for sub-tasks, not for other tickets (well, maybe for new feature tickets). After all, any contributor is quite capable of working a ticket without management. We're all volunteers here. And each should be able to get an overview of what his set of open tickets are. But if you want an overview (or more) of what is being worked on in the greater context of this ticket, have a look at: # [OFBiz BI page|https://cwiki.apache.org/confluence/display/OFBIZ/Business+Intelligence] # [Apache OFBiz (dashboard)|https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603] > Have a SalesChannel dimension > - > > Key: OFBIZ-10991 > URL: https://issues.apache.org/jira/browse/OFBIZ-10991 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh > > The component would benefit from a sales channel dimension for future fact > tables and star schema view entities -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10991) Have a SalesChannel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841338#comment-16841338 ] Pierre Smits edited comment on OFBIZ-10991 at 5/16/19 1:28 PM: --- Thank you for your feedback and suggestion(s), [~suraj.khurana] The project does not, IMO, contributors that 'manage' tickets. A 'parent' ticket works well for sub-tasks, not for other tickets (well, maybe for new feature tickets). After all, any contributor is quite capable of working a ticket without management. We're all volunteers here. And each should be able to get an overview of what his set of open tickets are. But if you want an overview (or more) of what is being worked on in the greater context of this ticket, have a look at: # [OFBiz BI page|https://cwiki.apache.org/confluence/display/OFBIZ/Business+Intelligence] # [Apache OFBiz (dashboard)|https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603] was (Author: pfm.smits): Thank you for your feedback and suggestion(s), [~suraj.khurana] The project does not, IMO, contributors that 'manage' tickets. A 'parent' ticket works well for sub-tasks, not for other tickets (well, maybe for new feature tickets). After all, any contributor is quite capable of working a ticket without management. We're all volunteers here. And each should be able to get an overview of what his set of open tickets are. But if you want an overview (or more) of what is being worked on in the greater context of this ticket, have a look at: # [https://cwiki.apache.org/confluence/display/OFBIZ/Business+Intelligence] # [[Apache OFBiz (dashboard)|https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603] > Have a SalesChannel dimension > - > > Key: OFBIZ-10991 > URL: https://issues.apache.org/jira/browse/OFBIZ-10991 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh > > The component would benefit from a sales channel dimension for future fact > tables and star schema view entities -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10991) Have a SalesChannel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841338#comment-16841338 ] Pierre Smits commented on OFBIZ-10991: -- Thank you for your feedback and suggestion(s), [~suraj.khurana] The project does not, IMO, contributors that 'manage' tickets. A 'parent' ticket works well for sub-tasks, not for other tickets (well, maybe for new feature tickets). After all, any contributor is quite capable of working a ticket without management. We're all volunteers here. And each should be able to get an overview of what his set of open tickets are. But if you want an overview (or more) of what is being worked on in the greater context of this ticket, have a look at: # [https://cwiki.apache.org/confluence/display/OFBIZ/Business+Intelligence] # [[Apache OFBiz (dashboard)|https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603]|https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603] > Have a SalesChannel dimension > - > > Key: OFBIZ-10991 > URL: https://issues.apache.org/jira/browse/OFBIZ-10991 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh > > The component would benefit from a sales channel dimension for future fact > tables and star schema view entities -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10991) Have a SalesChannel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841338#comment-16841338 ] Pierre Smits edited comment on OFBIZ-10991 at 5/16/19 1:27 PM: --- Thank you for your feedback and suggestion(s), [~suraj.khurana] The project does not, IMO, contributors that 'manage' tickets. A 'parent' ticket works well for sub-tasks, not for other tickets (well, maybe for new feature tickets). After all, any contributor is quite capable of working a ticket without management. We're all volunteers here. And each should be able to get an overview of what his set of open tickets are. But if you want an overview (or more) of what is being worked on in the greater context of this ticket, have a look at: # [https://cwiki.apache.org/confluence/display/OFBIZ/Business+Intelligence] # [[Apache OFBiz (dashboard)|https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603] was (Author: pfm.smits): Thank you for your feedback and suggestion(s), [~suraj.khurana] The project does not, IMO, contributors that 'manage' tickets. A 'parent' ticket works well for sub-tasks, not for other tickets (well, maybe for new feature tickets). After all, any contributor is quite capable of working a ticket without management. We're all volunteers here. And each should be able to get an overview of what his set of open tickets are. But if you want an overview (or more) of what is being worked on in the greater context of this ticket, have a look at: # [https://cwiki.apache.org/confluence/display/OFBIZ/Business+Intelligence] # [[Apache OFBiz (dashboard)|https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603]|https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603] > Have a SalesChannel dimension > - > > Key: OFBIZ-10991 > URL: https://issues.apache.org/jira/browse/OFBIZ-10991 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh > > The component would benefit from a sales channel dimension for future fact > tables and star schema view entities -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11028) field emplFromDate is forgot in PayHistory entity
[ https://issues.apache.org/jira/browse/OFBIZ-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11028: --- Attachment: OFBIZ-11028.patch > field emplFromDate is forgot in PayHistory entity > - > > Key: OFBIZ-11028 > URL: https://issues.apache.org/jira/browse/OFBIZ-11028 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Trunk, 17.12.01, 18.12.01 >Reporter: Olivier Heintz >Assignee: Jacques Le Roux >Priority: Major > Labels: humanres > Fix For: Trunk > > Attachments: OFBIZ-11028.patch, OFBIZ-11028.patch > > > A Employment can have multiple PayHistory and should have multiple > because PayHistory should show history of Pay for a employment ! > Currently, in PayHistory the field fromDate from Employment is confused with > fromDate about the current record, it's necessary to have a field > emplFromDate (to have the complete employment primaryKey). > Currently user interface for PayHistory is not working, when modifying a > PayRecord the current should be expire and a new one should be created. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
[ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841293#comment-16841293 ] Jacques Le Roux edited comment on OFBIZ-11021 at 5/16/19 12:50 PM: --- Thanks, It would be hard to make it more clear :) BTW my comment was more for new issues to come ;) was (Author: jacques.le.roux): Thanks, It would be hard to make it more clear :) > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart > > > Key: OFBIZ-11021 > URL: https://issues.apache.org/jira/browse/OFBIZ-11021 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11021.patch > > > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart. > > Suppose we have two items in the cart: > # The first item is drop-shippable. > # The second item is not drop-shippable. > For the first item, the implementation works fine. > For the second item, this is not working correctly. > > For drop shipment process, cart method 'createDropShipGroups' decides > RequirementMethodEnumId in the order of property set at ProductStore -> > ProductFacility -> Product which work fine in case of all drop-ship products > and if the drop-ship product(s) is added last in the cart. > > The issue I found is that if a combination of a dropship and non-drop ship > products are added into the cart and the non-drop shippable product(s) is > added after the drop shippable product(s) then the non-drop-shippable > products also considered as drop-shippable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
[ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841277#comment-16841277 ] Jacques Le Roux edited comment on OFBIZ-11021 at 5/16/19 12:49 PM: --- Sure [~jacques.le.roux], RequirementMethodEnumId should be decided in the order of property set at ProductStore -> Facility -> Product for each order item which was not working if the non-drop shippable product(s) is added after the drop shippable product(s). *Original Flow:* requirementMethodEnumId was initialized outside the loop and once it is initialized with Product level information it never gets re-initialized if Product is non-drop shippable. I have updated the code to use the storeRequirementMethodEnumId variable for store level information which is defined outside the loop and this will be used to initialize requirementMethodEnumId for each order item and then product level information can override it. That means for each product *ProductStore -> Facility -> Product* this rule will work properly. Hope It is more clear now. Thanks! was (Author: pawan.verma): Sure [~jacques.le.roux], RequirementMethodEnumId should be decided in the order of property set at ProductStore -> Facility -> Product for each order item which was not working if the non-drop shippable product(s) is added after the drop shippable product(s). *Original Flow:* requirementMethodEnumId was initialized outside the loop and once it is initialized with Product level information it never gets re-initialized if Product is non-drop shippable. I have updated the code to use the storeRequirementMethodEnumId variable for store level information which is defined outside the loop and this will be used to initialize requirementMethodEnumId for each order item and then product level information can override it. That means for each product *ProductStore -> Facility -> Product* this rule will work properly. Hope It is more clear now. Thanks! > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart > > > Key: OFBIZ-11021 > URL: https://issues.apache.org/jira/browse/OFBIZ-11021 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11021.patch > > > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart. > > Suppose we have two items in the cart: > # The first item is drop-shippable. > # The second item is not drop-shippable. > For the first item, the implementation works fine. > For the second item, this is not working correctly. > > For drop shipment process, cart method 'createDropShipGroups' decides > RequirementMethodEnumId in the order of property set at ProductStore -> > ProductFacility -> Product which work fine in case of all drop-ship products > and if the drop-ship product(s) is added last in the cart. > > The issue I found is that if a combination of a dropship and non-drop ship > products are added into the cart and the non-drop shippable product(s) is > added after the drop shippable product(s) then the non-drop-shippable > products also considered as drop-shippable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
[ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841293#comment-16841293 ] Jacques Le Roux commented on OFBIZ-11021: - Thanks, It would be hard to make it more clear :) > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart > > > Key: OFBIZ-11021 > URL: https://issues.apache.org/jira/browse/OFBIZ-11021 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11021.patch > > > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart. > > Suppose we have two items in the cart: > # The first item is drop-shippable. > # The second item is not drop-shippable. > For the first item, the implementation works fine. > For the second item, this is not working correctly. > > For drop shipment process, cart method 'createDropShipGroups' decides > RequirementMethodEnumId in the order of property set at ProductStore -> > ProductFacility -> Product which work fine in case of all drop-ship products > and if the drop-ship product(s) is added last in the cart. > > The issue I found is that if a combination of a dropship and non-drop ship > products are added into the cart and the non-drop shippable product(s) is > added after the drop shippable product(s) then the non-drop-shippable > products also considered as drop-shippable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841292#comment-16841292
]
Jacques Le Roux commented on OFBIZ-10187:
-
Thanks Dennis,
Yes it quite helps :)
> OWASP sanitizer breaks proper rendering of HTML code
>
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch
> 18.12
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
> Labels: backport-needed
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments:
> OFBIZ-10187_Rewrite-CustomPermissivePolicy-matchesEithe.patch,
> OFBIZ-10187_Sanitizer.patch, OFBIZ-10187_Sanitizer_16.11.patch,
> OFBIZ-10187_Sanitizer_New.patch
>
>
> The current implementation of the sanitizer breaks the proper rendering of
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> will be rendered to
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> I do not see any reason to not allow class attributes in html code. There
> might be other problems with these rules but this is a showstopper.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10991) Have a SalesChannel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841290#comment-16841290 ] Suraj Khurana commented on OFBIZ-10991: --- Hello [~pfm.smits], I think it would be better if we create a parent ticket with all this subtask so that this effort is properly managed. Just my two cents !! > Have a SalesChannel dimension > - > > Key: OFBIZ-10991 > URL: https://issues.apache.org/jira/browse/OFBIZ-10991 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh > > The component would benefit from a sales channel dimension for future fact > tables and star schema view entities -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java
[
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839737#comment-16839737
]
Jacques Le Roux edited comment on OFBIZ-11029 at 5/16/19 12:46 PM:
---
Thanks Aditya for changing the affected versions.
Pawan, though in this case it's obvious, in generarl we never know when a bug
will be fixed. So, by and large, we use releases branches in affected versions
and not directly a release version.
was (Author: jacques.le.roux):
Thanks Aditya for changing the affected versions.
Pawan, though in this case it's obvious, in generarlwe never know when a bug
will be fixed. So, by and large, we use releases branches in affected versions
and not directly a release version.
> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Denglong Zhou
>Assignee: Aditya Sharma
>Priority: Major
> Labels: product, variant
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-11029.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct =
> ProductWorker.getParentProduct(variantProduct.getString("productId"),
> variantProduct.getDelegator());
> if (virtualProduct == null ||
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null ||
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
[ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841277#comment-16841277 ] Pawan Verma commented on OFBIZ-11021: - Sure [~jacques.le.roux], RequirementMethodEnumId should be decided in the order of property set at ProductStore -> Facility -> Product for each order item which was not working if the non-drop shippable product(s) is added after the drop shippable product(s). *Original Flow:* requirementMethodEnumId was initialized outside the loop and once it is initialized with Product level information it never gets re-initialized if Product is non-drop shippable. I have updated the code to use the storeRequirementMethodEnumId variable for store level information which is defined outside the loop and this will be used to initialize requirementMethodEnumId for each order item and then product level information can override it. That means for each product *ProductStore -> Facility -> Product* this rule will work properly. Hope It is more clear now. Thanks! > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart > > > Key: OFBIZ-11021 > URL: https://issues.apache.org/jira/browse/OFBIZ-11021 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11021.patch > > > The drop-ship process behaves incorrectly when a combination of drop-ship and > non-drop-ship products are added into the cart. > > Suppose we have two items in the cart: > # The first item is drop-shippable. > # The second item is not drop-shippable. > For the first item, the implementation works fine. > For the second item, this is not working correctly. > > For drop shipment process, cart method 'createDropShipGroups' decides > RequirementMethodEnumId in the order of property set at ProductStore -> > ProductFacility -> Product which work fine in case of all drop-ship products > and if the drop-ship product(s) is added last in the cart. > > The issue I found is that if a combination of a dropship and non-drop ship > products are added into the cart and the non-drop shippable product(s) is > added after the drop shippable product(s) then the non-drop-shippable > products also considered as drop-shippable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java
[
https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841228#comment-16841228
]
Denglong Zhou commented on OFBIZ-11029:
---
Thanks you all for the quick fix, great team!
> Issue in function getVariantSelectionFeatures of ProductWorker.java
> ---
>
> Key: OFBIZ-11029
> URL: https://issues.apache.org/jira/browse/OFBIZ-11029
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12,
> Release Branch 18.12
>Reporter: Denglong Zhou
>Assignee: Aditya Sharma
>Priority: Major
> Labels: product, variant
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-11029.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> {code:java}
> //代码占位符
> public static List getVariantSelectionFeatures(GenericValue
> variantProduct) {
> if (!"Y".equals(variantProduct.getString("isVariant"))) {
> return null;
> }
> GenericValue virtualProduct =
> ProductWorker.getParentProduct(variantProduct.getString("productId"),
> variantProduct.getDelegator());
> if (virtualProduct == null ||
> !"Y".equals(virtualProduct.getString("productId"))) {
> return null;
> }
> {code}
> for the above coding, i guess the part colored by red should be the following,
> {code:java}
> //代码占位符
> if (virtualProduct == null ||
> !"Y".equals(virtualProduct.getString("isVirtual"))) {
> {code}
> thanks!
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10945) loadSalesInvoiceFact doesn't get invoked on setInvoiceStatus
[
https://issues.apache.org/jira/browse/OFBIZ-10945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-10945:
-
Labels: Fact SalesInvoiceItemFact SalesInvoiceItemStarSchema birt dwh
invoice (was: Fact SalesInvoiceItemStarSchema birt dwh invoice)
> loadSalesInvoiceFact doesn't get invoked on setInvoiceStatus
>
>
> Key: OFBIZ-10945
> URL: https://issues.apache.org/jira/browse/OFBIZ-10945
> Project: OFBiz
> Issue Type: Bug
> Components: bi
>Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11,
> Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Priority: Major
> Labels: Fact, SalesInvoiceItemFact, SalesInvoiceItemStarSchema,
> birt, dwh, invoice
>
> When the data warehouse has been initialised in the BI component, and a new
> sales invoice is generated and set to status 'Ready for Posting' following
> seca
> {code:java}
>
> value="INVOICE_READY"/>
> to-field-name="oldStatusId"/>
> run-as-user="system"/>
>
> {code}
> should load new records in the SalesInvoiceItemFact table.
> This does not happen.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10945) loadSalesInvoiceFact doesn't get invoked on setInvoiceStatus
[
https://issues.apache.org/jira/browse/OFBIZ-10945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-10945:
-
Labels: Fact SalesInvoiceItemStarSchema birt dwh invoice (was: )
> loadSalesInvoiceFact doesn't get invoked on setInvoiceStatus
>
>
> Key: OFBIZ-10945
> URL: https://issues.apache.org/jira/browse/OFBIZ-10945
> Project: OFBiz
> Issue Type: Bug
> Components: bi
>Affects Versions: Trunk, Release Branch 15.12, Release Branch 16.11,
> Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Priority: Major
> Labels: Fact, SalesInvoiceItemStarSchema, birt, dwh, invoice
>
> When the data warehouse has been initialised in the BI component, and a new
> sales invoice is generated and set to status 'Ready for Posting' following
> seca
> {code:java}
>
> value="INVOICE_READY"/>
> to-field-name="oldStatusId"/>
> run-as-user="system"/>
>
> {code}
> should load new records in the SalesInvoiceItemFact table.
> This does not happen.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10956) Have a service to load records in the CountryDimension
[ https://issues.apache.org/jira/browse/OFBIZ-10956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10956: - Labels: CountryDimension birt country dimension dwh service (was: birt dwh) > Have a service to load records in the CountryDimension > -- > > Key: OFBIZ-10956 > URL: https://issues.apache.org/jira/browse/OFBIZ-10956 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: CountryDimension, birt, country, dimension, dwh, service > > Depending on [OFBIZ-10954|https://issues.apache.org/jira/browse/OFBIZ-10954] > The service should be invoked on initialisation of the data warehouse. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11030: - Labels: Fact dwh services (was: dwh services) > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Labels: Fact, dwh, services > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11012) Documentation: SalesInvoiceItemStarSchema Design Updates
[ https://issues.apache.org/jira/browse/OFBIZ-11012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11012: - Labels: birt dwh starschema (was: birt dwh) > Documentation: SalesInvoiceItemStarSchema Design Updates > > > Key: OFBIZ-11012 > URL: https://issues.apache.org/jira/browse/OFBIZ-11012 > Project: OFBiz > Issue Type: Task > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Swapnil Shah >Priority: Major > Labels: birt, dwh, starschema > > Update the documentation when the entity has changed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11033) service 'loadSalesOrderItemFact' has hard coded currencyUomId
[ https://issues.apache.org/jira/browse/OFBIZ-11033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11033: - Labels: Fact SalesOrder SalesOrderItemFact birt dwh (was: dwh) > service 'loadSalesOrderItemFact' has hard coded currencyUomId > - > > Key: OFBIZ-11033 > URL: https://issues.apache.org/jira/browse/OFBIZ-11033 > Project: OFBiz > Issue Type: Bug > Components: bi >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12, Release Branch 16.11, Release Branch 17.12, Release > Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: Fact, SalesOrder, SalesOrderItemFact, birt, dwh > > Currency conversion in the loadSalesOrderItemFact does not work with the > currency of the internal organisation but has a hardcoded USD. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10948) Convert DimensionServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10948: - Labels: Minilang dimension dwh groovy, (was: Minilang groovy,) > Convert DimensionServices.xml minilang to groovy > > > Key: OFBIZ-10948 > URL: https://issues.apache.org/jira/browse/OFBIZ-10948 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: Minilang, dimension, dwh, groovy, > > With the purpose to deprecate mini-lang OFBIZ-9350, convert > DimensionServices.xml -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10947) Have DateDimension have a dimensionId that is based on the natural key
[ https://issues.apache.org/jira/browse/OFBIZ-10947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10947: - Labels: DateDimension birt dimension dwh (was: DateDimension birt dwh) > Have DateDimension have a dimensionId that is based on the natural key > -- > > Key: OFBIZ-10947 > URL: https://issues.apache.org/jira/browse/OFBIZ-10947 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: DateDimension, birt, dimension, dwh > Attachments: OFBIZ-10947-BI.patch > > > Currently the record sequencer (delegator.getNextSeqId) is used to determine > the dimensionId for the DateDimension. This is unnecessary as the date (when > correctly formatted) can be used. > When formatted as 'MMdd' a dimensionId could be 20190423, which is a > correctly 'sequenced' primary key. > It also makes it easier to set the foreign-key in fact tables by generating > it based on the date, than by retrieving the dimensionId based on a retrieval > through the getDimensionIdFromNaturalKey service. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10953) have CurrencyDimension have a dimensionId that is based on the natural key
[ https://issues.apache.org/jira/browse/OFBIZ-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10953: - Labels: CurrencyDimension birt currency dimension dwh (was: birt dwh) > have CurrencyDimension have a dimensionId that is based on the natural key > -- > > Key: OFBIZ-10953 > URL: https://issues.apache.org/jira/browse/OFBIZ-10953 > Project: OFBiz > Issue Type: Bug > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CurrencyDimension, birt, currency, dimension, dwh > Attachments: OFBIZ-10953-BI.patch > > > Currently the record sequencer (delegator.getNextSeqId) is used to determine > the dimensionId for the CurrencyDimension. This is unnecessary as the uomId > from the UOM table can be used for currency. > It also makes it easier to set the foreign-key in fact tables by generating > it based on the date provided, than by retrieving the dimensionId based on a > retrieval through the getDimensionIdFromNaturalKey service. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10990: - Labels: SalesInvoiceItemStarSchema birt dwh star starschema (was: birt dwh) > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: SalesInvoiceItemStarSchema, birt, dwh, star, starschema > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11031) Improve SalesOrderItemFact table
[ https://issues.apache.org/jira/browse/OFBIZ-11031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11031: - Labels: Fact SalesOrder SalesOrderItemFact birt dwh (was: dwh) > Improve SalesOrderItemFact table > > > Key: OFBIZ-11031 > URL: https://issues.apache.org/jira/browse/OFBIZ-11031 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Priority: Major > Labels: Fact, SalesOrder, SalesOrderItemFact, birt, dwh > > Improve the SalesOrderFactTable to include additional dimensions -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10986) Have a Store Dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10986: - Labels: StoreDimension birt dimension dwh store (was: birt dwh) > Have a Store Dimension > -- > > Key: OFBIZ-10986 > URL: https://issues.apache.org/jira/browse/OFBIZ-10986 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: StoreDimension, birt, dimension, dwh, store > > The component would benefit from a store dimension for future fact tables and > star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10987) Have a Catalog Dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10987: - Labels: CatalogDimension birt catalog dimension dwh (was: ) > Have a Catalog Dimension > > > Key: OFBIZ-10987 > URL: https://issues.apache.org/jira/browse/OFBIZ-10987 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CatalogDimension, birt, catalog, dimension, dwh > > The component would benefit from a catalog dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10991) Have a SalesChannel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10991: - Labels: SalesChannel SalesChannelDimension birt dimension dwh (was: ) > Have a SalesChannel dimension > - > > Key: OFBIZ-10991 > URL: https://issues.apache.org/jira/browse/OFBIZ-10991 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh > > The component would benefit from a sales channel dimension for future fact > tables and star schema view entities -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10995) Have a Brand dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10995: - Labels: BrandDimension birt brand dimension dwh (was: BrandDimension birt dwh) > Have a Brand dimension > -- > > Key: OFBIZ-10995 > URL: https://issues.apache.org/jira/browse/OFBIZ-10995 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: BrandDimension, birt, brand, dimension, dwh > > The component would benefit from a brand dimension for future fact tables and > star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10996) Have a Supplier dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10996: - Labels: SupplierDimension birt dimension dww supplier (was: birt dww) > Have a Supplier dimension > - > > Key: OFBIZ-10996 > URL: https://issues.apache.org/jira/browse/OFBIZ-10996 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SupplierDimension, birt, dimension, dww, supplier > > The component would benefit from a Supplier dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10946) Have a service to load records in the CustomerDimension
[ https://issues.apache.org/jira/browse/OFBIZ-10946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10946: - Labels: CustomerDimension birt customer dimension dwh (was: CustomerDimension birt dwh) > Have a service to load records in the CustomerDimension > --- > > Key: OFBIZ-10946 > URL: https://issues.apache.org/jira/browse/OFBIZ-10946 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CustomerDimension, birt, customer, dimension, dwh > Attachments: OFBIZ-10946-BI.patch > > > Depending on OFBIZ-10944. > The service must be invoked when a party gets the 'Customer' role. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10954) Have a Country Dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10954: - Labels: CountryDimension birt country dimension dwh geo (was: birt dwh) > Have a Country Dimension > > > Key: OFBIZ-10954 > URL: https://issues.apache.org/jira/browse/OFBIZ-10954 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CountryDimension, birt, country, dimension, dwh, geo > Attachments: OFBIZ-10954-BI.patch > > > The component would benefit from a country dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10997) Have an Employee dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10997: - Labels: EmployeeDimension birt dimension dwh employee (was: EmployeeDimension birt dwh) > Have an Employee dimension > -- > > Key: OFBIZ-10997 > URL: https://issues.apache.org/jira/browse/OFBIZ-10997 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: EmployeeDimension, birt, dimension, dwh, employee > > The component would benefit from an employee dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11034) Have a Carrier dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11034: - Labels: CarrierDimension birt carrier dimension dwh (was: CarrierDimension birt dwh) > Have a Carrier dimension > > > Key: OFBIZ-11034 > URL: https://issues.apache.org/jira/browse/OFBIZ-11034 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CarrierDimension, birt, carrier, dimension, dwh > > The component would benefit from a Carrier dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10944) Have a Customer Dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10944: - Labels: CustomerDimension birt customer dimension dwh (was: CustomerDimension birt dwh) > Have a Customer Dimension > - > > Key: OFBIZ-10944 > URL: https://issues.apache.org/jira/browse/OFBIZ-10944 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CustomerDimension, birt, customer, dimension, dwh > Attachments: OFBIZ-10944-BI.patch > > > The component would benefit from a customer dimension for future fact tables > and star schema view entities -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10998) Have a Time dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10998: - Labels: TimeDimension birt dimension dwh time (was: birt dwh) > Have a Time dimension > - > > Key: OFBIZ-10998 > URL: https://issues.apache.org/jira/browse/OFBIZ-10998 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: TimeDimension, birt, dimension, dwh, time > Attachments: OFBIZ-10998.patch > > > The component would benefit from a time dimension for future fact tables and > star schema view entities. > Per comments in OFBIZ-10990 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10989) Have a Facility dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10989: - Labels: FacilityDimension birt dimension dwh facility (was: FacilityDimension birt dwh) > Have a Facility dimension > - > > Key: OFBIZ-10989 > URL: https://issues.apache.org/jira/browse/OFBIZ-10989 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: FacilityDimension, birt, dimension, dwh, facility > > The component would benefit from a facility dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10988) Have a ProductCategory Dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10988: - Labels: ProductCategory ProductCategoryDimension birt dimension dwh (was: ProductCategoryDimension birt dwh) > Have a ProductCategory Dimension > > > Key: OFBIZ-10988 > URL: https://issues.apache.org/jira/browse/OFBIZ-10988 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: ProductCategory, ProductCategoryDimension, birt, > dimension, dwh > > The component would benefit from a product category dimension for future fact > tables and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10988) Have a ProductCategory Dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10988: - Labels: ProductCategoryDimension birt dwh (was: ) > Have a ProductCategory Dimension > > > Key: OFBIZ-10988 > URL: https://issues.apache.org/jira/browse/OFBIZ-10988 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: ProductCategoryDimension, birt, dwh > > The component would benefit from a product category dimension for future fact > tables and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10989) Have a Facility dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10989: - Labels: FacilityDimension birt dwh (was: ) > Have a Facility dimension > - > > Key: OFBIZ-10989 > URL: https://issues.apache.org/jira/browse/OFBIZ-10989 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: FacilityDimension, birt, dwh > > The component would benefit from a facility dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10947) Have DateDimension have a dimensionId that is based on the natural key
[ https://issues.apache.org/jira/browse/OFBIZ-10947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10947: - Labels: DateDimension birt dwh (was: birt dwh) > Have DateDimension have a dimensionId that is based on the natural key > -- > > Key: OFBIZ-10947 > URL: https://issues.apache.org/jira/browse/OFBIZ-10947 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: DateDimension, birt, dwh > Attachments: OFBIZ-10947-BI.patch > > > Currently the record sequencer (delegator.getNextSeqId) is used to determine > the dimensionId for the DateDimension. This is unnecessary as the date (when > correctly formatted) can be used. > When formatted as 'MMdd' a dimensionId could be 20190423, which is a > correctly 'sequenced' primary key. > It also makes it easier to set the foreign-key in fact tables by generating > it based on the date, than by retrieving the dimensionId based on a retrieval > through the getDimensionIdFromNaturalKey service. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10997) Have an Employee dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10997: - Labels: EmployeeDimension birt dwh (was: birt dwh) > Have an Employee dimension > -- > > Key: OFBIZ-10997 > URL: https://issues.apache.org/jira/browse/OFBIZ-10997 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: EmployeeDimension, birt, dwh > > The component would benefit from an employee dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10946) Have a service to load records in the CustomerDimension
[ https://issues.apache.org/jira/browse/OFBIZ-10946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10946: - Labels: CustomerDimension birt dwh (was: birt dwh) > Have a service to load records in the CustomerDimension > --- > > Key: OFBIZ-10946 > URL: https://issues.apache.org/jira/browse/OFBIZ-10946 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CustomerDimension, birt, dwh > Attachments: OFBIZ-10946-BI.patch > > > Depending on OFBIZ-10944. > The service must be invoked when a party gets the 'Customer' role. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10944) Have a Customer Dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10944: - Labels: CustomerDimension birt dwh (was: birt) > Have a Customer Dimension > - > > Key: OFBIZ-10944 > URL: https://issues.apache.org/jira/browse/OFBIZ-10944 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CustomerDimension, birt, dwh > Attachments: OFBIZ-10944-BI.patch > > > The component would benefit from a customer dimension for future fact tables > and star schema view entities -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11034) Have a Carrier dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11034: - Labels: CarrierDimension birt dwh (was: birt dwh) > Have a Carrier dimension > > > Key: OFBIZ-11034 > URL: https://issues.apache.org/jira/browse/OFBIZ-11034 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CarrierDimension, birt, dwh > > The component would benefit from a Carrier dimension for future fact tables > and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10995) Have a Brand dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10995: - Labels: BrandDimension birt dwh (was: birt dwh) > Have a Brand dimension > -- > > Key: OFBIZ-10995 > URL: https://issues.apache.org/jira/browse/OFBIZ-10995 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: BrandDimension, birt, dwh > > The component would benefit from a brand dimension for future fact tables and > star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11035) Add timezone support to recurring job temporal expressions
Pawan Verma created OFBIZ-11035: --- Summary: Add timezone support to recurring job temporal expressions Key: OFBIZ-11035 URL: https://issues.apache.org/jira/browse/OFBIZ-11035 Project: OFBiz Issue Type: Improvement Components: framework/webtools Affects Versions: Trunk Reporter: Pawan Verma Link of the discussion: [https://markmail.org/message/jsjqmjypaihbbldn] *As per Scott:* Trying to decide on the best way to define a *temporal* *expression* for a recurring job where the *temporal* *expression* should be evaluated using a *timezone* other than whatever the default *timezone* is for the system. The use case is having a system that runs on UTC time but needs to send a report at 5 pm Pacific Time every day regardless of whether or not daylight savings is in effect. Two options: # Add a field to *JobSandbox* such as recurrenceTimeZone (or better name!) # Use whatever *timezone* is available in the RunTime data service context Based on the discussion on Dev Mailing list #1 will be used to implement this feature. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841172#comment-16841172
]
Dennis Balkir edited comment on OFBIZ-10187 at 5/16/19 9:54 AM:
Hi Jacques,
sorry for my late response, but I thought that you solved this for you after
you wrote this comment.
{quote}Mmm, finally it's not as deprecated as I thought. Because [I looked at a
fork|https://github.com/andresriancho/owaspantisamy] when I look at what I
think it's the original I see it's maintained:
[https://github.com/nahsra/antisamy]
[https://github.com/nahsra/antisamy/issues/10]
Still we are actually using [https://github.com/OWASP/java-html-sanitizer]
which is clearly well maintianed, and turning to antisamy does not seem to be
better for us.
{quote}
I actually got this CustomPolicy Class from the github project that you linked
in one of your first comments:
{quote}I don't remember all about prepackaged policies from the top of my head
and when looking for references from
[https://github.com/OWASP/java-html-sanitizer] I got this
{quote}
This is the example class featured in the project:
[https://github.com/OWASP/java-html-sanitizer/blob/master/src/main/java/org/owasp/html/examples/EbayPolicyExample.java]
I just added some important things that were missing and were not violateble
with cross scripting, including some HTML 5 elements, since they were not at
all featured in this example.
I hope this helps, if there are any more questions, feel free to ask.
was (Author: dennis balkir):
Hi Jacques,
sorry for my late response, but I thought that you solved this for you after
you wrote this comment.
{quote}Mmm, finally it's not as deprecated as I thought. Because [I looked at a
fork|https://github.com/andresriancho/owaspantisamy] when I look at what I
think it's the original I see it's maintained:
[https://github.com/nahsra/antisamy]
[https://github.com/nahsra/antisamy/issues/10]
Still we are actually using [https://github.com/OWASP/java-html-sanitizer]
which is clearly well maintianed, and turning to antisamy does not seem to be
better for us.
{quote}
I actuall got this CustomPolicy Class from the github project that you linked
in one of your first comments:
{quote}I don't remember all about prepackaged policies from the top of my head
and when looking for references from
[https://github.com/OWASP/java-html-sanitizer] I got this
{quote}
This is the example class featured in the project:
[https://github.com/OWASP/java-html-sanitizer/blob/master/src/main/java/org/owasp/html/examples/EbayPolicyExample.java]
I just added some important things that were missing and were not violateble
with cross scripting, including some HTML 5 elements, since they were not at
all featured in this example.
I hope this helps, if there are any more questions, feel free to ask.
> OWASP sanitizer breaks proper rendering of HTML code
>
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch
> 18.12
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
> Labels: backport-needed
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments:
> OFBIZ-10187_Rewrite-CustomPermissivePolicy-matchesEithe.patch,
> OFBIZ-10187_Sanitizer.patch, OFBIZ-10187_Sanitizer_16.11.patch,
> OFBIZ-10187_Sanitizer_New.patch
>
>
> The current implementation of the sanitizer breaks the proper rendering of
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> will be rendered to
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet,
[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841172#comment-16841172
]
Dennis Balkir commented on OFBIZ-10187:
---
Hi Jacques,
sorry for my late response, but I thought that you solved this for you after
you wrote this comment.
{quote}Mmm, finally it's not as deprecated as I thought. Because [I looked at a
fork|https://github.com/andresriancho/owaspantisamy] when I look at what I
think it's the original I see it's maintained:
[https://github.com/nahsra/antisamy]
[https://github.com/nahsra/antisamy/issues/10]
Still we are actually using [https://github.com/OWASP/java-html-sanitizer]
which is clearly well maintianed, and turning to antisamy does not seem to be
better for us.
{quote}
I actuall got this CustomPolicy Class from the github project that you linked
in one of your first comments:
{quote}I don't remember all about prepackaged policies from the top of my head
and when looking for references from
[https://github.com/OWASP/java-html-sanitizer] I got this
{quote}
This is the example class featured in the project:
[https://github.com/OWASP/java-html-sanitizer/blob/master/src/main/java/org/owasp/html/examples/EbayPolicyExample.java]
I just added some important things that were missing and were not violateble
with cross scripting, including some HTML 5 elements, since they were not at
all featured in this example.
I hope this helps, if there are any more questions, feel free to ask.
> OWASP sanitizer breaks proper rendering of HTML code
>
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch
> 18.12
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
> Labels: backport-needed
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments:
> OFBIZ-10187_Rewrite-CustomPermissivePolicy-matchesEithe.patch,
> OFBIZ-10187_Sanitizer.patch, OFBIZ-10187_Sanitizer_16.11.patch,
> OFBIZ-10187_Sanitizer_New.patch
>
>
> The current implementation of the sanitizer breaks the proper rendering of
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> will be rendered to
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> I do not see any reason to not allow class attributes in html code. There
> might be other problems with these rules but this is a showstopper.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code
[
https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841159#comment-16841159
]
Jacques Le Roux commented on OFBIZ-10187:
-
Hi [~mbrohl], [~Dennis Balkir]
Sorry to ask you again:
{quote}While working on OFBIZ-10054, I noticed that I think you somehow
"translated" an antisamy xml example inspired by eBay to create
CustomPermissivePolicy.java. Is that right?
If yes, I believe you did so because the AntiSamy API has not been updated
since 2013. Is that right too? I ask that because I believe it would be
interesting to translate also the safer policy inspired by Slashdot and I'd
like to know your experience, thanks.
{quote}
I'd like to know because I want something safer than a policy similar to eBay's
to use in OFBIZ-5254
Thanks
> OWASP sanitizer breaks proper rendering of HTML code
>
>
> Key: OFBIZ-10187
> URL: https://issues.apache.org/jira/browse/OFBIZ-10187
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Trunk, 16.11.04, Release Branch 17.12, Release Branch
> 18.12
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Critical
> Labels: backport-needed
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments:
> OFBIZ-10187_Rewrite-CustomPermissivePolicy-matchesEithe.patch,
> OFBIZ-10187_Sanitizer.patch, OFBIZ-10187_Sanitizer_16.11.patch,
> OFBIZ-10187_Sanitizer_New.patch
>
>
> The current implementation of the sanitizer breaks the proper rendering of
> html code. In our case, class attributes are stripped from the html content.
> Example:
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> will be rendered to
> {code:java}
>
> src="<@ofbizContentUrl>/webcontent/img/slider/1.jpg"
> alt="" />
>
>
> Lorem ipsum dolor sit amet
> At vero eos et accusam et justo
>
> Lorem ipsum dolor sit amet, consetetur
> sadipscing elitr, dolores et ea rebum. Stet clita kasd gubergren, no sea
> takimata sanctus est Lorem ipsum dolor sit amet.
>
> href="<@ofbizUrl>cms/~webpage_id=100">weitere Informationen
>
>
> {code}
> I do not see any reason to not allow class attributes in html code. There
> might be other problems with these rules but this is a showstopper.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-5254) Services allow arbitrary HTML for parameters with allow-html set to "safe"
[
https://issues.apache.org/jira/browse/OFBIZ-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-5254:
---
Priority: Critical (was: Major)
> Services allow arbitrary HTML for parameters with allow-html set to "safe"
> --
>
> Key: OFBIZ-5254
> URL: https://issues.apache.org/jira/browse/OFBIZ-5254
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Christoph Neuroth
>Assignee: Jacques Le Roux
>Priority: Critical
> Labels: security
> Attachments: OFBIZ-5254.patch
>
>
> For any given service with allow-html=safe parameters, the parameter data is
> not properly validated. See Model.Service.java:588:
> {code}
>
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> {code}
> Looking at that method:
> {code}
> public static String checkStringForHtmlSafeOnly(String valueName, String
> value, List errorMessageList) {
> ValidationErrorList vel = new ValidationErrorList();
> value = defaultWebValidator.getValidSafeHTML(valueName, value,
> Integer.MAX_VALUE, true, vel);
> errorMessageList.addAll(UtilGenerics.checkList(vel.errors(),
> String.class));
> return value;
> }
> {code}
> you can see that it expects the defaultWebValidator.getValidSafeHTML would
> add all validation errors to the given ValidationErrorList, but if you look
> at the implementation of ESAPI that is not the case. First, consider the
> overloaded getValidSafeHTML that takes the ValidationErrorList:
> {code}public String getValidSafeHTML(String context, String input,
> int maxLength, boolean allowNull, ValidationErrorList errors) throws
> IntrusionException {
> try {
> return getValidSafeHTML(context, input, maxLength,
> allowNull);
> } catch (ValidationException e) {
> errors.addError(context, e);
> }
> return input;
> }
> {code}
> Then, step into that method to see that ValidationExceptions are only thrown
> for things like exceeding the maximum length - not for policy violations that
> can be "cleaned", such as tags that are not allowed by the policy:
> {code}
> AntiSamy as = new AntiSamy();
> CleanResults test = as.scan(input, antiSamyPolicy);
> List errors = test.getErrorMessages();
> if ( errors.size() > 0 ) {
> // just create new exception to get it logged
> and intrusion detected
> new ValidationException( "Invalid HTML input:
> context=" + context, "Invalid HTML input: context=" + context + ", errors=" +
> errors, context );
> }
> {code}
> I guess that is an expected, although maybe not clearly documented behavior
> of ESAPI: Non-cleanable violations throw the exception and therefore will
> fail the ofbiz service, while non-allowed tags are cleaned. However, if you
> consider ModelService:588 and following lines again:
> {code}
> StringUtil.checkStringForHtmlSafeOnly(modelParam.name, value,
> errorMessageList);
> //(...)
> if (errorMessageList.size() > 0) {
> throw new ServiceValidationException(errorMessageList, this,
> mode);
> }
> {code}
> the cleaned return value is ignored. Therefore, you will see an
> "IntrusionDetection" in the logs, giving you a false sense of security but
> the unfiltered HTML will still go into the service. So, if you want the
> service to fail if non-allowed HTML is encountered, you should use
> isValidSafeHTML instead. If you want the incoming HTML to be filtered, you
> should use the return value of getValidSafeHTML.
> Some additional notes on this:
> * When changing this, it should be properly documented as users may well be
> relying on this behavior - for example, we send full HTML mails to our
> customers for their ecommerce purchases and require HTML to go through - so
> maybe for services like the communicationEvents allowing only safe HTML might
> not be desired.
> * The ESAPI code samples above are from version 1.4.4. I was really surprised
> to find a JAR that is not only outdated, but patched and built by a third
> party, without even indicating that in the filename in OfBiz trunk. This has
> been there for years (see OFBIZ-3135) and should really be replaced with an
> official, up to date version since that issue was fixed upstream years ago.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OFBIZ-11034) Have a Carrier dimension
Pierre Smits created OFBIZ-11034: Summary: Have a Carrier dimension Key: OFBIZ-11034 URL: https://issues.apache.org/jira/browse/OFBIZ-11034 Project: OFBiz Issue Type: Improvement Components: bi Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Pierre Smits Assignee: Pierre Smits The component would benefit from a Carrier dimension for future fact tables and star schema view entities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
