[jira] [Commented] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848629#comment-16848629 ] Rohit Koushal commented on OFBIZ-11056: --- Thanks [~jacques.le.roux]. (y) > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Samuel Trégouët >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-11056.patch > > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848625#comment-16848625
]
Swapnil M Mane edited comment on OFBIZ-10145 at 5/27/19 5:41 AM:
-
Thanks [~jacques.le.roux], you are correct for R17 Gradle release should be
3.2.1 (I have done the suggested change in script and uploaded it again)
Hello [~soledad] and team,
I have done the following changes in script, please have a look
For R17 - [^init-gradle-wrapper.sh]
For R18 and trunk - [^init-gradle-wrapper-trunk-and-18.sh]
1.) Since we are putting the script at location $OFBIZ_HOME/gradle, I have
changed the GRADLE_WRAPPER_OFBIZ_PATH from
{code:java}
$OFBIZ_HOME/gradle/wrapper/{code}
to
{code:java}
$OFBIZ_HOME/gradle/{code}
otherwise script was giving the message "Location seems to be incorrect",
even when run from OFBiz root.
2.) Changed the Gradle release to 3.2.1 for R17.
3.) Done some improvements in messages which is to be shown to the user.
Please have a look and let me know your thoughts.
Thanks!
was (Author: swapnilmmane):
Thanks [~jacques.le.roux], you are correct for R17 Gradle release should be
3.2.1 (I have done the suggested change in script and uploaded it again)
Hello [~soledad] and team,
I have done the following changes in script, please have a look
1.) Since we are putting the script at location $OFBIZ_HOME/gradle, I have
changed the GRADLE_WRAPPER_OFBIZ_PATH from
{code:java}
$OFBIZ_HOME/gradle/wrapper/{code}
to
{code:java}
$OFBIZ_HOME/gradle/{code}
otherwise script was giving the message "Location seems to be incorrect",
even when run from OFBiz root.
2.) Changed the Gradle release to 3.2.1 for R17.
3.) Done some improvements in messages which is to be shown to the user.
Please have a look and let me know your thoughts.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848625#comment-16848625
]
Swapnil M Mane commented on OFBIZ-10145:
Thanks [~jacques.le.roux], you are correct for R17 Gradle release should be
3.2.1 (I have done the suggested change in script and uploaded it again)
Hello [~soledad] and team,
I have done the following changes in script, please have a look
1.) Since we are putting the script at location $OFBIZ_HOME/gradle, I have
changed the GRADLE_WRAPPER_OFBIZ_PATH from
{code:java}
$OFBIZ_HOME/gradle/wrapper/{code}
to
{code:java}
$OFBIZ_HOME/gradle/{code}
otherwise script was giving the message "Location seems to be incorrect",
even when run from OFBiz root.
2.) Changed the Gradle release to 3.2.1 for R17.
3.) Done some improvements in messages which is to be shown to the user.
Please have a look and let me know your thoughts.
Thanks!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swapnil M Mane updated OFBIZ-10145: --- Attachment: init-gradle-wrapper.sh init-gradle-wrapper-trunk-and-18.sh > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Blocker > Fix For: 17.12.01 > > Attachments: init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11069) Add coalesce to aggregate-function of model view
[
https://issues.apache.org/jira/browse/OFBIZ-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848557#comment-16848557
]
Shi Jinghai commented on OFBIZ-11069:
-
Hi Jacques and Pierre,
Thanks for the comments and votes!
On the example of sku and product instance, it's more and more common in our
life, a product has one or two identity code, for example, a mobile has one or
two IMEI, a computor has a Serial Number, a car has an engine code and a
VIN(Vehicle Identification Number), a cloth has a RFID and etc. If no
objection, I'll create a new Jira on this topic.
> Add coalesce to aggregate-function of model view
>
>
> Key: OFBIZ-11069
> URL: https://issues.apache.org/jira/browse/OFBIZ-11069
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Reporter: Shi Jinghai
>Priority: Trivial
> Labels: IoT, ModelViewEntity
> Fix For: Trunk
>
> Attachments: ModelViewEntity-function-coalesce.patch
>
>
> While in our IoT case, a product may have a sku product id as well as a
> productId (product instance) by identified from unique id i.e. an EPC.
> When building operation/inventory reports, to be compatible with previous
> implement, I have to merge the sku product Id column into the productId
> column, so comes the coalesce patch.
> The usage example:
> {code:java}
> function="coalesce">
>
>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-10797) CSS Styling for Party Content progress bar is wrong in multiple theme
[ https://issues.apache.org/jira/browse/OFBIZ-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-10797. - Thanks Ayushi Rathod for reporting the issue and providing the patch. > CSS Styling for Party Content progress bar is wrong in multiple theme > - > > Key: OFBIZ-10797 > URL: https://issues.apache.org/jira/browse/OFBIZ-10797 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Ayushi Rathod >Assignee: Suraj Khurana >Priority: Minor > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: OFBIZ-10797.patch, OFBIZ_ProgressBar_CSS.png > > > Steps to replicate: > # Login to demo-trunk: URL - > [https://demo-trunk.ofbiz.apache.org/partymgr/control/main] > # Find a Party > # Go to Party Content section > # Upload a file and click on Upload > # Notice the progress bar while the file is uploading > Actual - The styling for the progress bar is not correct > Please refer the screenshot attached over ticket -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10797) CSS Styling for Party Content progress bar is wrong in multiple theme
[ https://issues.apache.org/jira/browse/OFBIZ-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-10797: -- Sprint: OFBiz Community Day (May 2019) > CSS Styling for Party Content progress bar is wrong in multiple theme > - > > Key: OFBIZ-10797 > URL: https://issues.apache.org/jira/browse/OFBIZ-10797 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Ayushi Rathod >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-10797.patch, OFBIZ_ProgressBar_CSS.png > > > Steps to replicate: > # Login to demo-trunk: URL - > [https://demo-trunk.ofbiz.apache.org/partymgr/control/main] > # Find a Party > # Go to Party Content section > # Upload a file and click on Upload > # Notice the progress bar while the file is uploading > Actual - The styling for the progress bar is not correct > Please refer the screenshot attached over ticket -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7257) View Image button on order detail page is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-7257: - Flags: Patch > View Image button on order detail page is not working > - > > Key: OFBIZ-7257 > URL: https://issues.apache.org/jira/browse/OFBIZ-7257 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Avnindra Sharma >Assignee: Devanshu Vyas >Priority: Major > Attachments: OFBIZ-7257.patch > > > Item image is not getting open on clicking ViewImage on order detail page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7257) View Image button on order detail page is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848426#comment-16848426 ] Devanshu Vyas commented on OFBIZ-7257: -- As per the listed implementation plan, I have prepared a patch file. I haven't prepared any new OrderContentType data in the system as of now, but I am ready if the community approves. I am thinking of adding just one at this time, 'Document'. > View Image button on order detail page is not working > - > > Key: OFBIZ-7257 > URL: https://issues.apache.org/jira/browse/OFBIZ-7257 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Avnindra Sharma >Assignee: Devanshu Vyas >Priority: Major > Attachments: OFBIZ-7257.patch > > > Item image is not getting open on clicking ViewImage on order detail page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7257) View Image button on order detail page is not working
[ https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-7257: - Attachment: OFBIZ-7257.patch > View Image button on order detail page is not working > - > > Key: OFBIZ-7257 > URL: https://issues.apache.org/jira/browse/OFBIZ-7257 > Project: OFBiz > Issue Type: Bug > Components: order >Reporter: Avnindra Sharma >Assignee: Devanshu Vyas >Priority: Major > Attachments: OFBIZ-7257.patch > > > Item image is not getting open on clicking ViewImage on order detail page. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11017) In demo data many parties are incorrectly set with role 'INTERNAL_ORGANIZATIO'
[ https://issues.apache.org/jira/browse/OFBIZ-11017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848424#comment-16848424 ] Pierre Smits commented on OFBIZ-11017: -- If it is not a priority for you, you should consider removing yourself as the assignee. So that another contributor can JFDI. > In demo data many parties are incorrectly set with role 'INTERNAL_ORGANIZATIO' > -- > > Key: OFBIZ-11017 > URL: https://issues.apache.org/jira/browse/OFBIZ-11017 > Project: OFBiz > Issue Type: Bug > Components: accounting, marketing >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12, Release Branch 16.11, Release Branch 17.12, Release > Branch 18.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-11017-DemoData.patch > > > Many organisational units in the demo data set are type-casted wrongly as > 'INTERNAL_ORGANIZATIO', in stead of e.g. department, team, etc. > This occurs in: > * AccountingDemoData.xml > * MarketingDemoData.xml -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848421#comment-16848421 ] Pierre Smits edited comment on OFBIZ-7963 at 5/26/19 12:53 PM: --- You keep mentioning to have the sonar task to be available for local execution. I understand this as having adopters (and their developers) to be able to execute such and post the results to the sonarcloud.io service for the project. This should be considered as undesirable, as it may lead to having the service show results not applicable to the code base of the project (what is in its repos). Any adopter can have in their own environment their own - specific - setup (with adjustments to their own gradle code). But it should not dictate the setup for the project. You're talking about 'how could we test them before committing'. Let me do my thing and you'll get something that works. Now you're not. Are you saying that current buildbot configuration does not offer such flexibility? was (Author: pfm.smits): You keep mentioning to have the sonar task to be available for local execution. I understand this as having adopters (and their developers) to be able to execute such and post the results to the sonarcloud.io service for the project. This should be considered as undesirable, as it may lead to having the service show results not applicable to the code base of the projects (what is in its repos). Any adopter can have in their own environment their own - specific - setup (with adjustments to gradle). But it should not dictate the setup for the project. You're talking about 'how could we test them before committing'. Let me do my thing and you'll get something that works. Now you're not. Are you saying that current buildbot configuration does not offer such flexibility? > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revive INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10733) HTML Code is rendering in Sales Invoice
[ https://issues.apache.org/jira/browse/OFBIZ-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848423#comment-16848423 ] Sanjay Yadav commented on OFBIZ-10733: -- Thanks Chandrashekhar. > HTML Code is rendering in Sales Invoice > --- > > Key: OFBIZ-10733 > URL: https://issues.apache.org/jira/browse/OFBIZ-10733 > Project: OFBiz > Issue Type: Bug > Components: accounting > Environment: demo-trunk >Reporter: Sanjay Yadav >Assignee: Amit Gadaley >Priority: Major > Attachments: InvoiceWithHtmlCode.pdf > > > Steps to regenerate issue - > # Go to Url - > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10002] > # Invoice section > # Click PDF button > Actual - Opened a Sales Invoice with HTML code > Expected - HTML code should not display in the invoice. Please refer > attachment for quick review. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-7963: Description: As ever the devil is in details. There is no longer a Sonar plugin available https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should rather refer to http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle Anyway the most important part is to revive INFRA-3590 was: As ever the devil is in details. There is no longer a Sonar plugin available https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should rather refer to http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle Anyway the most important part is to revivify INFRA-3590 > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revive INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11070) Refactor EntityDataLoadContainer
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11070: --- Sprint: OFBiz Community Day (May 2019) > Refactor EntityDataLoadContainer > > > Key: OFBIZ-11070 > URL: https://issues.apache.org/jira/browse/OFBIZ-11070 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Attachments: > OFBIZ-11070_0001-Rewrite-EntityDataLoadContainer-isPropertySet.patch, > OFBIZ-11070_0002-Rewrite-EntityDataLoadContainer-isDataReadersEnabled.patch, > OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoadFiles.patch, > OFBIZ-11070_0004-Add-static-modifiers-in-EntityDataLoadConta.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848421#comment-16848421 ] Pierre Smits commented on OFBIZ-7963: - You keep mentioning to have the sonar task to be available for local execution. I understand this as having adopters (and their developers) to be able to execute such and post the results to the sonarcloud.io service for the project. This should be considered as undesirable, as it may lead to having the service show results not applicable to the code base of the projects (what is in its repos). Any adopter can have in their own environment their own - specific - setup (with adjustments to gradle). But it should not dictate the setup for the project. You're talking about 'how could we test them before committing'. Let me do my thing and you'll get something that works. Now you're not. Are you saying that current buildbot configuration does not offer such flexibility? > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11017) In demo data many parties are incorrectly set with role 'INTERNAL_ORGANIZATIO'
[ https://issues.apache.org/jira/browse/OFBIZ-11017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848418#comment-16848418 ] Jacques Le Roux commented on OFBIZ-11017: - Yes, but not a 1st priority. When I speak about side effects, I mean at least: * integration tests are passing. * no UI side effects (few manual cursory tests are enough) > In demo data many parties are incorrectly set with role 'INTERNAL_ORGANIZATIO' > -- > > Key: OFBIZ-11017 > URL: https://issues.apache.org/jira/browse/OFBIZ-11017 > Project: OFBiz > Issue Type: Bug > Components: accounting, marketing >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12, Release Branch 16.11, Release Branch 17.12, Release > Branch 18.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-11017-DemoData.patch > > > Many organisational units in the demo data set are type-casted wrongly as > 'INTERNAL_ORGANIZATIO', in stead of e.g. department, team, etc. > This occurs in: > * AccountingDemoData.xml > * MarketingDemoData.xml -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848415#comment-16848415 ] Jacques Le Roux commented on OFBIZ-7963: bq. Due to secret key(s) required by SonarCloud.io this service will not work (ever) when done locally. You don't share secret keys with just anybody. The risk of the result getting messed is ever present. Hu? I don't get it, the sonarqube task runs locally, even if it reports an error. bq. What you're referring to are missing inclusion/exclusion aspects. These should (must??) not be included in the gradle task, but should rather be included in the CI setup (as parameters) to ensure flexibility. Which flexibility are your referring about? The code structure is the same locally or on Buildbot. I don't see a reason it would not work locally. We don't use Buildbot specific parameters so far, all tasks are usable locally. How could we test them before committing else? > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848397#comment-16848397 ] Jacques Le Roux edited comment on OFBIZ-7963 at 5/26/19 12:14 PM: -- Thanks Pierre, # was almost already clear to me, I only mentionned Travis because Fabrice Bellingard did so. I understand that the patch is necessary for us because we use only Buildbot as CI tool. # I know now that Travis is not part of CI ASF services. # no comment # I don't need to ask infra, if the Gradle patch works. It does not for now and we (the community as a whole) need to investigate, of course in terms of our priorities... I must add that I'd like to have this Gradle task working because it could then be used not only locally (why not) but especially in Buildbot. So like we have shared demos, shared tests (thanks to Buildbot and Infra team continued support) we would have shared [continuous inspection of code quality.|https://en.wikipedia.org/wiki/SonarQube] was (Author: jacques.le.roux): Thanks Pierre, # was almost already clear to me, I only mentionned Travis because Fabrice Bellingard did so. I understand that the patch is necessary for us because we use only Buildbot as CI tool. # I know now that Travis is not part of CI ASF services. # no comment # I don't need to ask infra, if the Gradle patch works. It does not for now and we (the community as a whole) need to investigate, of course in terms of our priorities... I must add that I'd like to have this Gradle task working because it could then be used not only locally (why not) but especially in Buildbot. So like we have shared demos, shared tests (thanks to Buildbot and Infra team continued support) we would have shared [continuous inspection of code quality.|https://en.wikipedia.org/wiki/SonarQube] We only make real progress as a whole team, and that's what I'm really concerned about :) > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11070) Refactor EntityDataLoadContainer
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11070: --- Attachment: OFBIZ-11070_0001-Rewrite-EntityDataLoadContainer-isPropertySet.patch OFBIZ-11070_0002-Rewrite-EntityDataLoadContainer-isDataReadersEnabled.patch OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoadFiles.patch OFBIZ-11070_0004-Add-static-modifiers-in-EntityDataLoadConta.patch > Refactor EntityDataLoadContainer > > > Key: OFBIZ-11070 > URL: https://issues.apache.org/jira/browse/OFBIZ-11070 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Attachments: > OFBIZ-11070_0001-Rewrite-EntityDataLoadContainer-isPropertySet.patch, > OFBIZ-11070_0002-Rewrite-EntityDataLoadContainer-isDataReadersEnabled.patch, > OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoadFiles.patch, > OFBIZ-11070_0004-Add-static-modifiers-in-EntityDataLoadConta.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11070) Refactor EntityDataLoadContainer
Mathieu Lirzin created OFBIZ-11070: -- Summary: Refactor EntityDataLoadContainer Key: OFBIZ-11070 URL: https://issues.apache.org/jira/browse/OFBIZ-11070 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Mathieu Lirzin Assignee: Mathieu Lirzin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9382) Enhance the BIRT plugin with an install routine to load necessary data
[ https://issues.apache.org/jira/browse/OFBIZ-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-9382: Description: After installing the BIRT plugin, the user has to load some data in the right order to be able to use it in the backend. Flexible reports, for example, is not accessible because of missing security data. To make life easier for adopters and their users, we should think about a plugin specific gradle task for the plugin to automatically load at least the minimal data set to get things running. was: After installing the BIRT plugin, the user has to load some data in the right order to be able to use it in the backend. Flexible reports, for example, is not accessible because of missing security data. To make live easier for users, we should think about a plugin specific gradle task for the plugin to automatically load at least the minimal data set to get things running. > Enhance the BIRT plugin with an install routine to load necessary data > -- > > Key: OFBIZ-9382 > URL: https://issues.apache.org/jira/browse/OFBIZ-9382 > Project: OFBiz > Issue Type: Improvement > Components: birt >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Jacques Le Roux >Priority: Minor > Labels: bi, dwh, reporting > > After installing the BIRT plugin, the user has to load some data in the right > order to be able to use it in the backend. Flexible reports, for example, is > not accessible because of missing security data. > To make life easier for adopters and their users, we should think about a > plugin specific gradle task for the plugin to automatically load at least the > minimal data set to get things running. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-9382) Enhance the BIRT plugin with an install routine to load necessary data
[ https://issues.apache.org/jira/browse/OFBIZ-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-9382: Labels: bi dwh reporting (was: ) > Enhance the BIRT plugin with an install routine to load necessary data > -- > > Key: OFBIZ-9382 > URL: https://issues.apache.org/jira/browse/OFBIZ-9382 > Project: OFBiz > Issue Type: Improvement > Components: birt >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Jacques Le Roux >Priority: Minor > Labels: bi, dwh, reporting > > After installing the BIRT plugin, the user has to load some data in the right > order to be able to use it in the backend. Flexible reports, for example, is > not accessible because of missing security data. > To make live easier for users, we should think about a plugin specific gradle > task for the plugin to automatically load at least the minimal data set to > get things running. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11017) In demo data many parties are incorrectly set with role 'INTERNAL_ORGANIZATIO'
[ https://issues.apache.org/jira/browse/OFBIZ-11017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848411#comment-16848411 ] Pierre Smits commented on OFBIZ-11017: -- Jacques, Are you still working this ticket? > In demo data many parties are incorrectly set with role 'INTERNAL_ORGANIZATIO' > -- > > Key: OFBIZ-11017 > URL: https://issues.apache.org/jira/browse/OFBIZ-11017 > Project: OFBiz > Issue Type: Bug > Components: accounting, marketing >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12, Release Branch 16.11, Release Branch 17.12, Release > Branch 18.12 >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-11017-DemoData.patch > > > Many organisational units in the demo data set are type-casted wrongly as > 'INTERNAL_ORGANIZATIO', in stead of e.g. department, team, etc. > This occurs in: > * AccountingDemoData.xml > * MarketingDemoData.xml -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848402#comment-16848402 ] Pierre Smits commented on OFBIZ-7963: - Jacques, Due to secret key(s) required by SonarCloud.io this service will not work (ever) when done locally. You don't share secret keys with just anybody. The risk of the result getting messed is ever present. You're saying that the patch does not work. That is an incorrect/incomplete statement. What you're referring to are missing inclusion/exclusion aspects. These should (must??) not be included in the gradle task, but should rather be included in the CI setup (as parameters) to ensure flexibility. > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848397#comment-16848397 ] Jacques Le Roux edited comment on OFBIZ-7963 at 5/26/19 10:52 AM: -- Thanks Pierre, # was almost already clear to me, I only mentionned Travis because Fabrice Bellingard did so. I understand that the patch is necessary for us because we use only Buildbot as CI tool. # I know now that Travis is not part of CI ASF services. # no comment # I don't need to ask infra, if the Gradle patch works. It does not for now and we (the community as a whole) need to investigate, of course in terms of our priorities... I must add that I'd like to have this Gradle task working because it could then be used not only locally (why not) but especially in Buildbot. So like we have shared demos, shared tests (thanks to Buildbot and Infra team continued support) we would have shared [continuous inspection of code quality.|https://en.wikipedia.org/wiki/SonarQube] We only make real progress as a whole team, and that's what I'm really concerned about :) was (Author: jacques.le.roux): Thanks Pierre, # was almost already clear to me, I only mentionned Travis because Fabrice Bellingard did so. I understand that the patch is necessary for us because we use only Buildbot as CI tool. # I know now that Travis is not part of CI ASF services. # no comment # I don't need to ask infra, if the Gradle patch works. It does not for now and we (the community as a whole) need to investigate, of course in terms of our priorities... I must add that I'd like to have this Gradle task working because it could then be used not only locally (why not) but especially in Buildbot. So like we have shared demos, shared tests (thanks to Buildbot) we would have shared [continuous inspection of code quality.|https://en.wikipedia.org/wiki/SonarQube] We only make real progress as a whole team, and that's what I'm really concerned about :) > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848397#comment-16848397 ] Jacques Le Roux commented on OFBIZ-7963: Thanks Pierre, # was almost already clear to me, I only mentionned Travis because Fabrice Bellingard did so. I understand that the patch is necessary for us because we use only Buildbot as CI tool. # I know now that Travis is not part of CI ASF services. # no comment # I don't need to ask infra, if the Gradle patch works. It does not for now and we (the community as a whole) need to investigate, of course in terms of our priorities... I must add that I'd like to have this Gradle task working because it could then be used not only locally (why not) but especially in Buildbot. So like we have shared demos, shared tests (thanks to Buildbot) we would have shared [continuous inspection of code quality.|https://en.wikipedia.org/wiki/SonarQube] We only make real progress as a whole team, and that's what I'm really concerned about :) > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-11064) Use Groovy Truth instead of UtilValidate Class in Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11064.
---
Resolution: Implemented
Fix Version/s: Upcoming Branch
Thanks Pawan,
Your patch is in trunk at 1860051
I just removed WebSiteForms.xml that you inadvertently added to the framework
patch ;)
> Use Groovy Truth instead of UtilValidate Class in Groovy
>
>
> Key: OFBIZ-11064
> URL: https://issues.apache.org/jira/browse/OFBIZ-11064
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11064-plugins.patch, OFBIZ-11064.patch,
> OFBIZ-11064.patch
>
>
> As we all know, Groovy is a powerful language with great built-in functions.
> Groovy Truth[1] is one of them, which is not used properly in our code base.
> We have used UtilValidate Class to validate arguments for Empty or NotEmpty,
> which can easily be done in groovy with built-in functionality.
>
> Current Code: if (UtilValidate.isNotEmpty(locations)) \{ ... }
>
> Groovy Built-in Code: if (locations) \{ ... }
>
> IMO, We should use this Groovy Truth feature instead of UtilValidate Class.
> Please let me know your thoughts on this. Thanks!
> [1] - [http://groovy-lang.org/semantics.html#Groovy-Truth]
>
> We need to careful for some points while we change this:
> Like:
> maxRetry = 0
> if (!maxRetry) {
> // Not set, use a default
> maxRetry = -1
> }
> Because groovy evaluates zero to be false, it wouldn't be possible to set
> maxRetry to zero. So it's best not to use groovy truth for null-checks on
> numbers in some cases.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11064) Use Groovy Truth instead of UtilValidate Class in Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-11064:
---
Assignee: Jacques Le Roux (was: Pawan Verma)
> Use Groovy Truth instead of UtilValidate Class in Groovy
>
>
> Key: OFBIZ-11064
> URL: https://issues.apache.org/jira/browse/OFBIZ-11064
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-11064-plugins.patch, OFBIZ-11064.patch,
> OFBIZ-11064.patch
>
>
> As we all know, Groovy is a powerful language with great built-in functions.
> Groovy Truth[1] is one of them, which is not used properly in our code base.
> We have used UtilValidate Class to validate arguments for Empty or NotEmpty,
> which can easily be done in groovy with built-in functionality.
>
> Current Code: if (UtilValidate.isNotEmpty(locations)) \{ ... }
>
> Groovy Built-in Code: if (locations) \{ ... }
>
> IMO, We should use this Groovy Truth feature instead of UtilValidate Class.
> Please let me know your thoughts on this. Thanks!
> [1] - [http://groovy-lang.org/semantics.html#Groovy-Truth]
>
> We need to careful for some points while we change this:
> Like:
> maxRetry = 0
> if (!maxRetry) {
> // Not set, use a default
> maxRetry = -1
> }
> Because groovy evaluates zero to be false, it wouldn't be possible to set
> maxRetry to zero. So it's best not to use groovy truth for null-checks on
> numbers in some cases.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11066) Have a service to load records in the organisation dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11066: - Attachment: OFBIZ-11066-OrgDimService.patch > Have a service to load records in the organisation dimension > > > Key: OFBIZ-11066 > URL: https://issues.apache.org/jira/browse/OFBIZ-11066 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: OrganisationDimension, birt, dimension, dwh, service > Attachments: OFBIZ-11066-OrgDimService.patch > > > For dwh initialisation. Applicable to internal (accounting) organisations. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848385#comment-16848385 ] Pierre Smits edited comment on OFBIZ-7963 at 5/26/19 10:09 AM: --- Jacques, To clarify some things: # The Jenkins+Sonar aspect is based on a sonarqube service provided by the ASF that has been deprecated in favour of the 3rd party Sonar service (sonarcloud.io). So there is only the in-house CI services (buildbot and Jenkins). I have explained in the referenced tickets that the in-house Sonar service was going away. I have also explained that in order to have this (code analysis) working, the patch is required. So without the patch there is no code analysis. # CI is not vague! Whether projects want to use CI (or not, and with what) is up to the projects. The ASF provides only buildbot and Jenkins. Travis is not an ASF service. It is a 3rd party service. # Ultimately it is you who is concerned about buildbot+sonar. The rest does not care, as long as the service to the project is as expected. If it were that important to other contributors (or even you), then this would have been resolved ages ago. # Everyone with privileges has access to ASF services, or can request them via INFRA. was (Author: pfm.smits): Jacques, To clarify some things: # The Jenkins+Sonar aspect is based on a sonarqube service provided by the ASF that has been deprecated in favour of the 3rd party Sonar service (sonarcloud.io). So there is only the in-house CI services (buildbot and Jenkins). I have explained in the referenced tickets that the in-house Sonar service was going away. I have also explained that in order to have this (code analysis) working, the patch is required. So without the patch there is no code analysis. # CI is not vague! Whether projects want to use CI (or not, and with what) is up to the projects. The ASF provides only buildbot and Jenkins. Travis is not an ASF service. It is a 3rd party service. # Ultimately it is you who is concerned about buildbot+sonar. The rest does not care, as long as the service to the project is as expected. If it were, then this would have been resolved ages ago. # Everyone with privileges has access to ASF services, or can request them via INFRA. > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848385#comment-16848385 ] Pierre Smits edited comment on OFBIZ-7963 at 5/26/19 10:08 AM: --- Jacques, To clarify some things: # The Jenkins+Sonar aspect is based on a sonarqube service provided by the ASF that has been deprecated in favour of the 3rd party Sonar service (sonarcloud.io). So there is only the in-house CI services (buildbot and Jenkins). I have explained in the referenced tickets that the in-house Sonar service was going away. I have also explained that in order to have this (code analysis) working, the patch is required. So without the patch there is no code analysis. # CI is not vague! Whether projects want to use CI (or not, and with what) is up to the projects. The ASF provides only buildbot and Jenkins. Travis is not an ASF service. It is a 3rd party service. # Ultimately it is you who is concerned about buildbot+sonar. The rest does not care, as long as the service to the project is as expected. If it were, then this would have been resolved ages ago. # Everyone with privileges has access to ASF services, or can request them via INFRA. was (Author: pfm.smits): Jacques, To clarify some things: # The Jenkins+Sonar aspect is based on a sonarqube service provided by the ASF that has been deprecated in favour of the 3rd party Sonar service (sonarcloud.io). So there is only the in-house CI services (buildbot and Jenkins). I have explained in the referenced tickets that the in-house Sonar service was going away. I have also explained that in order to have this (code analysis) working, the patch is required. So without the patch there is no code analysis. # CI is not vague! Whether projects want to use CI (or not, and with what) is up to the projects. The ASF provides only buildbot and Jenkins. Travis is not an ASF service. It is a 3rd party service. # Ultimately it is you who is concerned about buildbot+sonar. The rest does not care, as long as the service to the project is as expected. # Everyone with privileges has access to ASF services, or can request them via INFRA. > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848385#comment-16848385 ] Pierre Smits edited comment on OFBIZ-7963 at 5/26/19 9:59 AM: -- Jacques, To clarify some things: # The Jenkins+Sonar aspect is based on a sonarqube service provided by the ASF that has been deprecated in favour of the 3rd party Sonar service (sonarcloud.io). So there is only the in-house CI services (buildbot and Jenkins). I have explained in the referenced tickets that the in-house Sonar service was going away. I have also explained that in order to have this (code analysis) working, the patch is required. So without the patch there is no code analysis. # CI is not vague! Whether projects want to use CI (or not, and with what) is up to the projects. The ASF provides only buildbot and Jenkins. Travis is not an ASF service. It is a 3rd party service. # Ultimately it is you who is concerned about buildbot+sonar. The rest does not care, as long as the service to the project is as expected. # Everyone with privileges has access to ASF services, or can request them via INFRA. was (Author: pfm.smits): Jacques, To clarify some things: # The Jenkins+Sonar aspect is based on a sonarqube service provided by the ASF that has been deprecated in favour of the 3rd party Sonar service (sonarcloud.io). So there is only the in-house CI services (buildbot and Jenkins). I have explained in the referenced tickets that the in-house Sonar service was going away. I have also explained that in order to have this (code analysis) working, the patch is required. So without the patch there is no code analysis. # CI is not vague! What projects use to have CI (or not, and with what) is up to the projects. The ASF provides only buildbot and Jenkins. Travis is not an ASF service. It is a 3rd party service. # Ultimately it is you who is concerned about buildbot+sonar. The rest does not care, as long as the service to the project is as expected. # Everyone with privileges has access to ASF services, or can request them via INFRA. > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848385#comment-16848385 ] Pierre Smits commented on OFBIZ-7963: - Jacques, To clarify some things: # The Jenkins+Sonar aspect is based on a sonarqube service provided by the ASF that has been deprecated in favour of the 3rd party Sonar service (sonarcloud.io). So there is only the in-house CI services (buildbot and Jenkins). I have explained in the referenced tickets that the in-house Sonar service was going away. I have also explained that in order to have this (code analysis) working, the patch is required. So without the patch there is no code analysis. # CI is not vague! What projects use to have CI (or not, and with what) is up to the projects. The ASF provides only buildbot and Jenkins. Travis is not an ASF service. It is a 3rd party service. # Ultimately it is you who is concerned about buildbot+sonar. The rest does not care, as long as the service to the project is as expected. # Everyone with privileges has access to ASF services, or can request them via INFRA. > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11064) Use Groovy Truth instead of UtilValidate Class in Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Verma updated OFBIZ-11064:
Attachment: OFBIZ-11064.patch
> Use Groovy Truth instead of UtilValidate Class in Groovy
>
>
> Key: OFBIZ-11064
> URL: https://issues.apache.org/jira/browse/OFBIZ-11064
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11064-plugins.patch, OFBIZ-11064.patch,
> OFBIZ-11064.patch
>
>
> As we all know, Groovy is a powerful language with great built-in functions.
> Groovy Truth[1] is one of them, which is not used properly in our code base.
> We have used UtilValidate Class to validate arguments for Empty or NotEmpty,
> which can easily be done in groovy with built-in functionality.
>
> Current Code: if (UtilValidate.isNotEmpty(locations)) \{ ... }
>
> Groovy Built-in Code: if (locations) \{ ... }
>
> IMO, We should use this Groovy Truth feature instead of UtilValidate Class.
> Please let me know your thoughts on this. Thanks!
> [1] - [http://groovy-lang.org/semantics.html#Groovy-Truth]
>
> We need to careful for some points while we change this:
> Like:
> maxRetry = 0
> if (!maxRetry) {
> // Not set, use a default
> maxRetry = -1
> }
> Because groovy evaluates zero to be false, it wouldn't be possible to set
> maxRetry to zero. So it's best not to use groovy truth for null-checks on
> numbers in some cases.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11064) Use Groovy Truth instead of UtilValidate Class in Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848384#comment-16848384
]
Pawan Verma commented on OFBIZ-11064:
-
Thanks, [~jacques.le.roux] for the review.
My bad! I have updated the patch. Thanks!
> Use Groovy Truth instead of UtilValidate Class in Groovy
>
>
> Key: OFBIZ-11064
> URL: https://issues.apache.org/jira/browse/OFBIZ-11064
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11064-plugins.patch, OFBIZ-11064.patch,
> OFBIZ-11064.patch
>
>
> As we all know, Groovy is a powerful language with great built-in functions.
> Groovy Truth[1] is one of them, which is not used properly in our code base.
> We have used UtilValidate Class to validate arguments for Empty or NotEmpty,
> which can easily be done in groovy with built-in functionality.
>
> Current Code: if (UtilValidate.isNotEmpty(locations)) \{ ... }
>
> Groovy Built-in Code: if (locations) \{ ... }
>
> IMO, We should use this Groovy Truth feature instead of UtilValidate Class.
> Please let me know your thoughts on this. Thanks!
> [1] - [http://groovy-lang.org/semantics.html#Groovy-Truth]
>
> We need to careful for some points while we change this:
> Like:
> maxRetry = 0
> if (!maxRetry) {
> // Not set, use a default
> maxRetry = -1
> }
> Because groovy evaluates zero to be false, it wouldn't be possible to set
> maxRetry to zero. So it's best not to use groovy truth for null-checks on
> numbers in some cases.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848380#comment-16848380 ] Jacques Le Roux commented on OFBIZ-7963: bq. What are you talking about when stating: 'if it still works'? Jenkins+Sonar like you got results at OFBIZ-10919 and OFBIZ-10918 bq. The solution is intended to work with ASF services, meaning the CI and the repos available. CI is vague, at the ASF some use Jenkins, others Travis, we use Builbot. I understand that ultimately we want to use Builbot+Gradle with sonarqube task bq. Agree to what? IIUC, the community already agreed to the fact that code analysis is beneficial to the project. Yes, as stated above "ultimately we want to use Builbot+Gradle with sonarqube task". But in the meantime we could use Jenkins+Sonar (if it still works, I don't know what you did there, and I have no access) > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11069) Add coalesce to aggregate-function of model view
[
https://issues.apache.org/jira/browse/OFBIZ-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848365#comment-16848365
]
Pierre Smits commented on OFBIZ-11069:
--
Hi Jinghai,
+1 on introducing the coalesce functionality.
In the example provided you're talking about the skuProductId field coming from
the same entity as the productId. I have looked at the various entities, but
there is no such 'skuProductId' field in the model. Is this intentional? Or
just a prelude to have the field introduced into the Product entity?
> Add coalesce to aggregate-function of model view
>
>
> Key: OFBIZ-11069
> URL: https://issues.apache.org/jira/browse/OFBIZ-11069
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Reporter: Shi Jinghai
>Priority: Trivial
> Labels: IoT, ModelViewEntity
> Fix For: Trunk
>
> Attachments: ModelViewEntity-function-coalesce.patch
>
>
> While in our IoT case, a product may have a sku product id as well as a
> productId (product instance) by identified from unique id i.e. an EPC.
> When building operation/inventory reports, to be compatible with previous
> implement, I have to merge the sku product Id column into the productId
> column, so comes the coalesce patch.
> The usage example:
> {code:java}
> function="coalesce">
>
>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11069) Add coalesce to aggregate-function of model view
[
https://issues.apache.org/jira/browse/OFBIZ-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848363#comment-16848363
]
Jacques Le Roux commented on OFBIZ-11069:
-
HI Jinghai,
Sounds good to me: +1
> Add coalesce to aggregate-function of model view
>
>
> Key: OFBIZ-11069
> URL: https://issues.apache.org/jira/browse/OFBIZ-11069
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Reporter: Shi Jinghai
>Priority: Trivial
> Labels: IoT, ModelViewEntity
> Fix For: Trunk
>
> Attachments: ModelViewEntity-function-coalesce.patch
>
>
> While in our IoT case, a product may have a sku product id as well as a
> productId (product instance) by identified from unique id i.e. an EPC.
> When building operation/inventory reports, to be compatible with previous
> implement, I have to merge the sku product Id column into the productId
> column, so comes the coalesce patch.
> The usage example:
> {code:java}
> function="coalesce">
>
>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848362#comment-16848362 ] Pierre Smits commented on OFBIZ-7963: - Agree to what? IIUC, the community already agreed to the fact that code analysis is beneficial to the project. > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848361#comment-16848361 ] Pierre Smits commented on OFBIZ-7963: - What are you talking about when stating: 'if it still works'? The solution is intended to work with ASF services, meaning the CI and the repos available. > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848357#comment-16848357 ] Jacques Le Roux commented on OFBIZ-7963: BTW if it still works and the community agrees about that, why not using, at least in the meantime, Jenkins and the Git mirror repos? > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, > OFBIZ-7963-sonar.patch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task
[
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848356#comment-16848356
]
Jacques Le Roux commented on OFBIZ-7963:
Hi Pierre,
Your last patch gives the same "result" than I put above (normal it's the same
thing).
I looked at the reason it fails. This is related:
[https://github.com/SonarOpenCommunity/sonar-cxx/wiki/FAQ] (look for "Q: ERROR:
Caused by: File [...] can't be indexed twice.").
They explain:
{noformat}
An example could look like this:
sonar.sources=.
sonar.tests=.
sonar.test.inclusions=**/*Test*/**
sonar.exclusions=**/*Test*/**
{noformat}
Should those be properties in sonarqube section? What should we put there
actually? Would you mind investigating?
If I understand well the 1st test failing
(MultivaluedMapContextAdapterTests.java) is the 1st running, all others are the
same. So as long as we have not defined some sonarqube parameters (maybe
beggining with the explanation above) we will not get any usable result, as you
did with OFBIZ-10919 and OFBIZ-10918. If I refer to INFRA-18188, where Jenkins
was used, it's not that easy to transpose to Gradle: Jenkins do the job for you
there as says Fabrice Bellingard.
So you don't need to answer my questions at OFBIZ-10917, I think I got the big
picture and I guess we "only" need now to correctly define the properties in
sonarqube section...
> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch,
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should
> rather refer to
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revivify INFRA-3590
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10917) establish code analysis with Sonar
[ https://issues.apache.org/jira/browse/OFBIZ-10917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815141#comment-16815141 ] Jacques Le Roux edited comment on OFBIZ-10917 at 5/26/19 7:22 AM: -- Hi Jacques, Regarding your questions: # No I did not. I used (the) existing services available to me due to my privileges in another project. # This is still not finalised. See status of the ticket and of the sub-task(S). # INFRA is in the progress of migrating the analysis service to Sonarcloud. See [1]. Until then it is where it is. # What kind of notifications would you like to see? Please raise your issue on the dev ml # INFRA-18099 is related to a different project. But INFRA-18188 deals with getting appropriate Sonar plugins for the OFBiz code # The ticket is still open. Lets first finalise this and its sub-tasks before taking a next one. [1] https://issues.apache.org/jira/browse/INFRA-18188?focusedCommentId=16814239=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16814239 was (Author: pfm.smits): Hi Jacques, Regarding your questions: # No I did not. I used (the) existing services available to me due to my privileges in another project. # This is still not finalised. See status of the ticket and of the sub-task(S). # INFRA is in the progress of migrating the analysis service to Sonarcloud. See [1]. Until then it is where it is. # What kind of notifications would you like to see? Please raise your issue on the dev ml # INFRA-18099 is related to a different project. But INFRA-18188 deals with getting appropriate Sonar plugins for the OFBiz code # The ticket is still open. Lets first finalise this and its sub-tasks before taking a next one. [1] [https://issues.apache.org/jira/browse/INFRA-18188?focusedCommentId=16814239=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16814239|http://example.com] > establish code analysis with Sonar > -- > > Key: OFBIZ-10917 > URL: https://issues.apache.org/jira/browse/OFBIZ-10917 > Project: OFBiz > Issue Type: Task > Components: ALL COMPONENTS, ALL PLUGINS >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > > The ASF provides code analysis functionality through [1] with Sonar > Our code contributors will benefit from more insight through this tool for > each of the components in: > # ofbiz-framework, see [2] > # ofbiz-plugins, see [3] > [1] [https://builds.apache.org/analysis/] > [2] [ofbiz-framework|https://github.com/apache/ofbiz-framework] > [3] [ofbiz-plugins|https://github.com/apache/ofbiz-plugins] > Currently the Sonar implementation provides analysis functionalities for: > # Java > # Javascript -- This message was sent by Atlassian JIRA (v7.6.3#76005)
