[jira] [Commented] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859323#comment-16859323
]
Mathieu Lirzin commented on OFBIZ-11014:
‘StringUtil#toMap’ is only used in the ‘CollectionConverters.StringToMap’
converter so in order to clean ‘StringUtil’ it seems better to inline it. I
will commit [^OFBIZ-11014_0015-Inline-StringUtil-toMap.patch] which is doing
that in a couple of days if nobody disagrees.
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch,
> OFBIZ-11014_0015-Inline-StringUtil-toMap.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11014:
---
Attachment: OFBIZ-11014_0015-Inline-StringUtil-toMap.patch
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch,
> OFBIZ-11014_0015-Inline-StringUtil-toMap.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11014:
---
Attachment: (was: OFBIZ-11014_Inline-StringUtil-toMap.patch)
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-11014) StringUtil cleanup
[
https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11014:
---
Attachment: OFBIZ-11014_Inline-StringUtil-toMap.patch
> StringUtil cleanup
> --
>
> Key: OFBIZ-11014
> URL: https://issues.apache.org/jira/browse/OFBIZ-11014
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch,
> OFBIZ-11014_0002-Rewrite-StringUtil-join-method.patch,
> OFBIZ-11014_0003-Remove-unused-StringUtil-append-method.patch,
> OFBIZ-11014_0004-Remove-unused-StringUtil-split-overload.patch,
> OFBIZ-11014_0005-Inline-StringUtil-quoteStrList-method.patch,
> OFBIZ-11014_0006-Remove-unused-StringUtil-strToMap-overload.patch,
> OFBIZ-11014_0007-Remove-unused-StringUtil-mapToStr-method.patch,
> OFBIZ-11014_0008-Remove-unused-StringUtil-convertChar-method.patch,
> OFBIZ-11014_0009-Remove-unused-StringUtil-removeNumeric-meth.patch,
> OFBIZ-11014_0010-Remove-unused-StringUtil-collapseNewlines-m.patch,
> OFBIZ-11014_0011-Remove-unused-StringUtil-collapseSpaces-met.patch,
> OFBIZ-11014_0012-Remove-unused-StringUtil-collapseCharacter.patch,
> OFBIZ-11014_0013-Remove-unused-StringUtil-appendTo-methods.patch,
> OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch,
> OFBIZ-11014_Inline-StringUtil-toMap.patch
>
>
> {{StringUtil}} contains stuff that is not useful with recent version of Java.
> For example the {{StringUtil#split}} method could be replaced by the
> {{String#split}} method. As a consequence {{StringUtil}} should be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (OFBIZ-11070) Refactor EntityDataLoadContainer
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin closed OFBIZ-11070. -- I don't want to investigate more on why [^OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoadFiles.patch] is failing, so I am closing this ticket. Thanks Jacques for taking care of the revert. > Refactor EntityDataLoadContainer > > > Key: OFBIZ-11070 > URL: https://issues.apache.org/jira/browse/OFBIZ-11070 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11070_0001-Rewrite-EntityDataLoadContainer-isPropertySet.patch, > OFBIZ-11070_0002-Rewrite-EntityDataLoadContainer-isDataReadersEnabled.patch, > OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoadFiles.patch, > OFBIZ-11070_0004-Add-static-modifiers-in-EntityDataLoadConta.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11070) Refactor EntityDataLoadContainer
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859287#comment-16859287 ] Jacques Le Roux commented on OFBIZ-11070: - Thanks Mathieu, Bisect is one of the tools that makes Git apart. Will you close this issue as is or will your fix the problem you crossed before? > Refactor EntityDataLoadContainer > > > Key: OFBIZ-11070 > URL: https://issues.apache.org/jira/browse/OFBIZ-11070 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11070_0001-Rewrite-EntityDataLoadContainer-isPropertySet.patch, > OFBIZ-11070_0002-Rewrite-EntityDataLoadContainer-isDataReadersEnabled.patch, > OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoadFiles.patch, > OFBIZ-11070_0004-Add-static-modifiers-in-EntityDataLoadConta.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10844) Ecommerce AnonContactus.ftl doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859232#comment-16859232 ] Jacques Le Roux commented on OFBIZ-10844: - The patch looks good to me too > Ecommerce AnonContactus.ftl doesn't work > > > Key: OFBIZ-10844 > URL: https://issues.apache.org/jira/browse/OFBIZ-10844 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 > Environment: Win10 + OFBiz 16.11.04 + mysql. >Reporter: Schumann Ye >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-10844.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Ecommerce "Contact Us" with anonymous login doesn't work after filling in > email and all necessary info. > The root cause is the simple method "sendContactUsEmailToCompany" within > the file > \applications\party\minilang\communication\CommunicationEventServices.xml has > defined the field "sendFrom" as inputted email address from the anonymous > users. > To fix it, it should be changed as follows: > > While the email "yourmailaddr...@example.com" should have been properly set > up in your system. > It works for me! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11070) Refactor EntityDataLoadContainer
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859231#comment-16859231 ] Mathieu Lirzin commented on OFBIZ-11070: After bisecting I identified that the revision 1860063 corresponding to [^OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoadFiles.patch] was the root cause for the regression. As a consequence I am reapplying the other patches which are not concerned with the regression. > Refactor EntityDataLoadContainer > > > Key: OFBIZ-11070 > URL: https://issues.apache.org/jira/browse/OFBIZ-11070 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11070_0001-Rewrite-EntityDataLoadContainer-isPropertySet.patch, > OFBIZ-11070_0002-Rewrite-EntityDataLoadContainer-isDataReadersEnabled.patch, > OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoadFiles.patch, > OFBIZ-11070_0004-Add-static-modifiers-in-EntityDataLoadConta.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859228#comment-16859228 ] Mathieu Lirzin edited comment on OFBIZ-10817 at 6/8/19 2:14 PM: Lambda expressions are not meant to be stored inside variables. In most cases it is better to define a static method and use a method reference instead. Static methods have the benefits of having a more explicit signature and some javadoc attached to them. I have included [^OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch] which is rewriting current implementation to use method references. If nobody disagrees I will commit the patch in a couple of days. was (Author: mthl): Lambda expressions are not meant to be stored inside variables. In most cases it is better to define a static method and use a method reference instead. Static methods have the benefits of having a more explicit signature and some javadoc attached to them. I have included [^OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch] which is rewriting current implementing to use method references. If nobody disagrees I will commit the patch in a couple of days. > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch, > OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch, > Sélection_236.png, Sélection_237.png > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859228#comment-16859228 ] Mathieu Lirzin commented on OFBIZ-10817: Lambda expressions are not meant to be stored inside variables. In most cases it is better to define a static method and use a method reference instead. Static methods have the benefits of having a more explicit signature and some javadoc attached to them. I have included [^OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch] which is rewriting current implementing to use method references. If nobody disagrees I will commit the patch in a couple of days. > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch, > OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch, > Sélection_236.png, Sélection_237.png > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10817: --- Attachment: OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch > Configure stackTrace displaying on ftl rendering > > > Key: OFBIZ-10817 > URL: https://issues.apache.org/jira/browse/OFBIZ-10817 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Attachments: Failure.png, FailureSafe.png, OFBIZ-10817.patch, > OFBIZ-10817.patch, OFBIZ-10817.patch, > OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch, > Sélection_236.png, Sélection_237.png > > > Currently when freemarker failed to execute a template, you have on end > screen rendered all java stack trace generate. > I propose to improve this to display the stack trace only when the property > widget.verbose is true, no regression during development and when you switch > to production site, in general your widget.verbose is false so end user > haven't stack trace (that totally unused for them). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page
[ https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859204#comment-16859204 ] Jacques Le Roux commented on OFBIZ-11095: - Sorry Nitish, it's still not right, the images are flattened a bit > Ecommerce image distorted in trunk demo main page > - > > Key: OFBIZ-11095 > URL: https://issues.apache.org/jira/browse/OFBIZ-11095 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-11095.patch, OFBIZ-11095.patch > > > Due to recent bootstrap changes, ecommerce image is distorted in trunk demo > main page -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859169#comment-16859169 ] Swapnil M Mane edited comment on OFBIZ-10145 at 6/8/19 10:05 AM: - Thank you [~jacques.le.roux], I like the suggestion of calling init-gradle-wrapper script from both gradlew and gradlew.bat script. In this way, life our users will became easy, no action will be required from their side. And as you nicely mentioned we need to make sure we are handling the 'init-gradle-wrapper' script always while upgrading the gradle. Just I am not sure about recommendation for customizing the Gradle Wrapper file. Let's see what are the thoughts our fellow team members. Thanks! was (Author: swapnilmmane): Thank you [~jacques.le.roux], I like the suggestion of calling init-gradle-wrapper script from both gradlew and gradlew.bat script. In this way, life our users will became easy, no action will be required from their side. And as you nicely mentioned we need to make sure we are handling the 'init-gradle-wrapper' script always while upgrading the gradle. Let's see what are the thoughts our fellow team members. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes
[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859169#comment-16859169 ] Swapnil M Mane commented on OFBIZ-10145: Thank you [~jacques.le.roux], I like the suggestion of calling init-gradle-wrapper script from both gradlew and gradlew.bat script. In this way, life our users will became easy, no action will be required from their side. And as you nicely mentioned we need to make sure we are handling the 'init-gradle-wrapper' script always while upgrading the gradle. Let's see what are the thoughts our fellow team members. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > - > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle >Affects Versions: 17.12.01, 16.11.06, 18.12.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11089) Have a service to load records in the sales promo dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11089: - Attachment: OFBIZ-11089-SalesPromoDimService.diff > Have a service to load records in the sales promo dimension > --- > > Key: OFBIZ-11089 > URL: https://issues.apache.org/jira/browse/OFBIZ-11089 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesPromoDimension, birt, dimension, dwh, service > Attachments: OFBIZ-11089-SalesPromoDimService.diff, > OFBIZ-11089-SalesPromoDimService.diff > > > For dwh initialisation -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11087) Have a service to load records in the project task dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11087: - Attachment: OFBIZ-11087-ProjectTaskDimService.diff > Have a service to load records in the project task dimension > > > Key: OFBIZ-11087 > URL: https://issues.apache.org/jira/browse/OFBIZ-11087 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: ProjectTaskDimension, birt, dimension, dwh, service > Attachments: OFBIZ-11087-ProjectTaskDimService.diff, > OFBIZ-11087-ProjectTaskDimService.diff > > > For dwh initialisation -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11085) Have a service to load records in the carrier dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11085: - Attachment: OFBIZ-11085-CarrierDimService.diff > Have a service to load records in the carrier dimension > --- > > Key: OFBIZ-11085 > URL: https://issues.apache.org/jira/browse/OFBIZ-11085 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CarrierDimension, birt, carrier, dimension, dwh, service > Attachments: OFBIZ-11085-CarrierDimService.diff, > OFBIZ-11085-CarrierDimService.diff > > > for dwh initialisation -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11077) Have a service to load records in the pos terminal dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11077: - Attachment: OFBIZ-11077-PosTerminalDimService.diff > Have a service to load records in the pos terminal dimension > > > Key: OFBIZ-11077 > URL: https://issues.apache.org/jira/browse/OFBIZ-11077 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: PosTerminalDimension, birt, dwh, initialisation, pos, > service > Attachments: OFBIZ-11077-PosTerminalDimService.diff, > OFBIZ-11077-PosTerminalDimService.diff > > > For dwh initialisation -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11076) Have a service to load records in the project dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11076: - Attachment: OFBIZ-11076-ProjectDimService.diff > Have a service to load records in the project dimension > --- > > Key: OFBIZ-11076 > URL: https://issues.apache.org/jira/browse/OFBIZ-11076 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: ProjectDimension, birt, dwh, initialisation, project, > service > Attachments: OFBIZ-11076-ProjectDimService.diff, > OFBIZ-11076-ProjectDimService.diff > > > For dwh initialisation -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10844) Ecommerce AnonContactus.ftl doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859163#comment-16859163 ] Suraj Khurana commented on OFBIZ-10844: --- Patch looks good to me. I will continue with this soon. > Ecommerce AnonContactus.ftl doesn't work > > > Key: OFBIZ-10844 > URL: https://issues.apache.org/jira/browse/OFBIZ-10844 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 > Environment: Win10 + OFBiz 16.11.04 + mysql. >Reporter: Schumann Ye >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-10844.patch > > Original Estimate: 0h > Remaining Estimate: 0h > > Ecommerce "Contact Us" with anonymous login doesn't work after filling in > email and all necessary info. > The root cause is the simple method "sendContactUsEmailToCompany" within > the file > \applications\party\minilang\communication\CommunicationEventServices.xml has > defined the field "sendFrom" as inputted email address from the anonymous > users. > To fix it, it should be changed as follows: > > While the email "yourmailaddr...@example.com" should have been properly set > up in your system. > It works for me! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11074) Have a service to load records in the sales channel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11074: - Attachment: OFBIZ-11074-ChannelDimService.diff > Have a service to load records in the sales channel dimension > - > > Key: OFBIZ-11074 > URL: https://issues.apache.org/jira/browse/OFBIZ-11074 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dwh, > initialisation, service > Attachments: OFBIZ-11074-ChannelDimService.diff, > OFBIZ-11074-ChannelDimService.diff > > > For dwh initialisation -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11092) Have a service to load records in the asset dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11092: - Attachment: OFBIZ-11091-AssetDimService.diff > Have a service to load records in the asset dimension > - > > Key: OFBIZ-11092 > URL: https://issues.apache.org/jira/browse/OFBIZ-11092 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: AssetDimension, asset, birt, dimension, dwh, service > Attachments: OFBIZ-11091-AssetDimService.diff > > > For dwh initialisation -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page
[ https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859145#comment-16859145 ] Nitish Mishra commented on OFBIZ-11095: --- Yes, I have made some correction in patch Please check it now.[^OFBIZ-11095.patch] > Ecommerce image distorted in trunk demo main page > - > > Key: OFBIZ-11095 > URL: https://issues.apache.org/jira/browse/OFBIZ-11095 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-11095.patch, OFBIZ-11095.patch > > > Due to recent bootstrap changes, ecommerce image is distorted in trunk demo > main page -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page
[ https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitish Mishra updated OFBIZ-11095: -- Attachment: OFBIZ-11095.patch > Ecommerce image distorted in trunk demo main page > - > > Key: OFBIZ-11095 > URL: https://issues.apache.org/jira/browse/OFBIZ-11095 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-11095.patch, OFBIZ-11095.patch > > > Due to recent bootstrap changes, ecommerce image is distorted in trunk demo > main page -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page
[ https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859139#comment-16859139 ] Jacques Le Roux edited comment on OFBIZ-11095 at 6/8/19 8:09 AM: - Wait no, I was too fast, it's better but there is still a deformation. Compare an original image (eg: https://demo-trunk.ofbiz.apache.org/images/products/WG-5569/small.png) with the one rendered on main page with the patch was (Author: jacques.le.roux): Wait no, I was too fast, it's better but there is still a deformation. Compare an original image (eg: https://demo-trunk.ofbiz.apache.org/images/products/WG-5569/small.png) with he one rendered on main page with the patch > Ecommerce image distorted in trunk demo main page > - > > Key: OFBIZ-11095 > URL: https://issues.apache.org/jira/browse/OFBIZ-11095 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-11095.patch > > > Due to recent bootstrap changes, ecommerce image is distorted in trunk demo > main page -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page
[ https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859139#comment-16859139 ] Jacques Le Roux commented on OFBIZ-11095: - Wait no, I was too fast, it's better but there is still a deformation. Compare an original image (eg: https://demo-trunk.ofbiz.apache.org/images/products/WG-5569/small.png) with he one rendered on main page with the patch > Ecommerce image distorted in trunk demo main page > - > > Key: OFBIZ-11095 > URL: https://issues.apache.org/jira/browse/OFBIZ-11095 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-11095.patch > > > Due to recent bootstrap changes, ecommerce image is distorted in trunk demo > main page -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OFBIZ-10885) Blank page appears after using Tell-A-Friend functionality while adding item to cart
[ https://issues.apache.org/jira/browse/OFBIZ-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana resolved OFBIZ-10885. --- Resolution: Fixed Fix Version/s: 18.12.01 16.11.06 17.12.01 This has been committed to Trunk at rev#1860801 Release18.12 at rev#1860803 Release17.12 at rev#1860804 Release16.11 at rev#1860807 > Blank page appears after using Tell-A-Friend functionality while adding item > to cart > > > Key: OFBIZ-10885 > URL: https://issues.apache.org/jira/browse/OFBIZ-10885 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Ravi Lodhi >Assignee: Suraj Khurana >Priority: Minor > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: OFBIZ-10885.patch > > > Steps to reproduce: > 1) Go to [https://demo-trunk.ofbiz.apache.org/ecomseo > ]2) Click on any products from the Popular categories section. I clicked on > Tiny Gizmo. > 3) You will be redirected to the product detail page. You can see a link > "Tell-A-Friend" just below the product's pricing detail. > 4) Click on "Tell-A-Friend" link. A model will appear. Fill the necessary > detail and submit the form. > 5) Now add that item into the cart by clicking the "Add To Cart" button. > 6) A blank page with a message "Tell A Friend Sorry" appears. > Expected: User should be redirected to the same product detail page after > successfully adding an item. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10885) Blank page appears after using Tell-A-Friend functionality while adding item to cart
[ https://issues.apache.org/jira/browse/OFBIZ-10885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-10885. - Thanks Ravi Lodhi for reporting and Nitish Mishra for providing the patch. > Blank page appears after using Tell-A-Friend functionality while adding item > to cart > > > Key: OFBIZ-10885 > URL: https://issues.apache.org/jira/browse/OFBIZ-10885 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Ravi Lodhi >Assignee: Suraj Khurana >Priority: Minor > Fix For: 17.12.01, 16.11.06, 18.12.01 > > Attachments: OFBIZ-10885.patch > > > Steps to reproduce: > 1) Go to [https://demo-trunk.ofbiz.apache.org/ecomseo > ]2) Click on any products from the Popular categories section. I clicked on > Tiny Gizmo. > 3) You will be redirected to the product detail page. You can see a link > "Tell-A-Friend" just below the product's pricing detail. > 4) Click on "Tell-A-Friend" link. A model will appear. Fill the necessary > detail and submit the form. > 5) Now add that item into the cart by clicking the "Add To Cart" button. > 6) A blank page with a message "Tell A Friend Sorry" appears. > Expected: User should be redirected to the same product detail page after > successfully adding an item. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page
[ https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859131#comment-16859131 ] Jacques Le Roux commented on OFBIZ-11095: - It works, thanks Nitish! > Ecommerce image distorted in trunk demo main page > - > > Key: OFBIZ-11095 > URL: https://issues.apache.org/jira/browse/OFBIZ-11095 > Project: OFBiz > Issue Type: Sub-task > Components: ecommerce >Affects Versions: Trunk >Reporter: Nitish Mishra >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-11095.patch > > > Due to recent bootstrap changes, ecommerce image is distorted in trunk demo > main page -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-11096) ShoppingCart's autoUserLogin does not got reinitialized when user tries to logout using ecommerce's autoLogout
Pawan Verma created OFBIZ-11096: --- Summary: ShoppingCart's autoUserLogin does not got reinitialized when user tries to logout using ecommerce's autoLogout Key: OFBIZ-11096 URL: https://issues.apache.org/jira/browse/OFBIZ-11096 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Pawan Verma Steps to regenerate: 1. Login into e-commerce application with any user(I've used DemoCustomer) 2. Browse the website and/or wait till the session become ideal. 3. The system will set userLogin to ShoppingCart's autoUserLogin, which is actually correct behavior. 4. Now, when user logout from the Logout button session and ShoppingCart's autoUserLogin got reinitialized. 5. But when the user tries to Logout using *Not You? Click Here(autoLogout)* link only session got reinitialized, ShoppingCart's autoUserLogin does not get reinitialized. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
