[jira] [Assigned] (OFBIZ-8939) Unit test case for service - CheckCreateStockRequirementQoh

2019-06-21 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-8939:


Assignee: Suraj Khurana  (was: Anushi Gupta)

> Unit test case for service - CheckCreateStockRequirementQoh
> ---
>
> Key: OFBIZ-8939
> URL: https://issues.apache.org/jira/browse/OFBIZ-8939
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-8939.patch, OFBIZ-8939.patch
>
>
> Unit test case for service - CheckCreateStockRequirementQoh



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10853) AutoDescription of promotion showing invalid text

2019-06-21 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10853.
-

Thanks Lalit Dashora for reporting the issue and providing the patch.

> AutoDescription of promotion showing invalid text
> -
>
> Key: OFBIZ-10853
> URL: https://issues.apache.org/jira/browse/OFBIZ-10853
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Upcoming Branch, Release Branch 18.12
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 18.12.01
>
> Attachments: OFBIZ-10853-issue-in-promo-autoDescription.patch
>
>
> Steps to replicate
>  1. Navigate to [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
>  2. Click on view all promotion in special offer section.
>  3. click on the detail of promotion.
>  4. Promotion detail will be shown. See the generated description.
>  5. 
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/showPromotionDetails?productPromoId=9019]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10674) Not able to delete organization unit

2019-06-21 Thread Rohit Hukkeri (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870086#comment-16870086
 ] 

Rohit Hukkeri commented on OFBIZ-10674:
---

Hello Jason,

As per the description in the ticket I followed the steps to regenerate but IMO 
there is no any issue in adding and removing the newly added accounting 
settings.From here there should not be any means to delete the created party.

Please add more clear steps to regenerate issue.If you thought issue still 
exist then you can generate thread on Mailing list.

Thanks and Regards,

Rohit Hukkeri

> Not able to delete organization unit
> 
>
> Key: OFBIZ-10674
> URL: https://issues.apache.org/jira/browse/OFBIZ-10674
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, party
>Affects Versions: 16.11.05
>Reporter: Jason Hao
>Priority: Major
>
> I tried to add new Organization by doing steps below:
>  # create a party as organization unit
>  # In Accouting-> AccountingOrgGlSettings add a new organization unit
>  
> But when I want to delete it, I found there is no means to delete either the 
> party or the settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10979) Example tab is displayed twice in order tab section

2019-06-21 Thread Prakhar Kumar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870082#comment-16870082
 ] 

Prakhar Kumar commented on OFBIZ-10979:
---

Hello [~ashish.sharma],

 

Example tab is not getting displayed twice. I think you got confused between 
'Example' and 'Example Ext'. Also, I am not able to identify the other issue 
reported. Can you please make it more clear?

> Example tab is displayed twice in order tab section
> ---
>
> Key: OFBIZ-10979
> URL: https://issues.apache.org/jira/browse/OFBIZ-10979
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Ashish Sharma
>Assignee: Prakhar Kumar
>Priority: Trivial
> Fix For: Trunk
>
> Attachments: OFBIZ-10979.docx
>
>
> *Step to reproduce*
> 1. Open - https://demo-trunk.ofbiz.apache.org/catalog/control/main
> 2. Navigate to order tab.
> 3. Click on plus icon
> *Actual Result:* Example tab is displayed twice.
>  Order status spelling is not correct.
> *Screen print attached*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10979) Example tab is displayed twice in order tab section

2019-06-21 Thread Prakhar Kumar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870082#comment-16870082
 ] 

Prakhar Kumar edited comment on OFBIZ-10979 at 6/22/19 5:55 AM:


Hello [~ashish.sharma],

Example tab is not getting displayed twice. I think you got confused between 
'Example' and 'Example Ext'. Also, I am not able to identify the other issue 
reported. Can you please make it more clear?


was (Author: prakhar.kumar):
Hello [~ashish.sharma],

 

Example tab is not getting displayed twice. I think you got confused between 
'Example' and 'Example Ext'. Also, I am not able to identify the other issue 
reported. Can you please make it more clear?

> Example tab is displayed twice in order tab section
> ---
>
> Key: OFBIZ-10979
> URL: https://issues.apache.org/jira/browse/OFBIZ-10979
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Ashish Sharma
>Assignee: Prakhar Kumar
>Priority: Trivial
> Fix For: Trunk
>
> Attachments: OFBIZ-10979.docx
>
>
> *Step to reproduce*
> 1. Open - https://demo-trunk.ofbiz.apache.org/catalog/control/main
> 2. Navigate to order tab.
> 3. Click on plus icon
> *Actual Result:* Example tab is displayed twice.
>  Order status spelling is not correct.
> *Screen print attached*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-8939) Unit test case for service - CheckCreateStockRequirementQoh

2019-06-21 Thread Anushi Gupta (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870081#comment-16870081
 ] 

Anushi Gupta commented on OFBIZ-8939:
-

Updated patch for the unit test of CheckCreateStockRequirementQoh service from 
XML to DSL and also verified the same.

> Unit test case for service - CheckCreateStockRequirementQoh
> ---
>
> Key: OFBIZ-8939
> URL: https://issues.apache.org/jira/browse/OFBIZ-8939
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Anushi Gupta
>Priority: Minor
> Attachments: OFBIZ-8939.patch, OFBIZ-8939.patch
>
>
> Unit test case for service - CheckCreateStockRequirementQoh



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870080#comment-16870080
 ] 

Jacques Le Roux commented on OFBIZ-10145:
-

Hi Swapnil,

I thought about it again. Actually what are we doing when we upgrade Gradle in 
trunk? We update the gradlew scripts and the wrapper files, eg see 
[r1776532|http://svn.apache.org/viewvc?view=revision=1776532] and 
[r1848062|http://svn.apache.org/viewvc?view=revision=1848062].

With the Windows way that's all we need to do. Just update gradlew.bat in the 
trunk and the wrapper files in tools. A change must though be done in current 
gradlew.bat: the wrapper must always be copied over in trunk from the tools, 
somehow like in Buildbot. Not a big deal, we speak about 50 Kb. Like before, to 
use the latest version of Gradle, the user must SVN update his/her working copy.

There is only one drawback with this strategy, the user must have an Internet 
connexion. At some point it needs it: to SVN update the trunk. But later the 
connexion may be missing. A smal change in init-gradle-wrapper.ps1, [too catch 
the connexion 
error|https://stackoverflow.com/questions/19122378/powershell-web-request-without-throwing-exception-on-4xx-5xx]
 is enough. 

If the user did not run gradlew at the same moment than SVN updating, s/he must 
wait the next time a connexion is available to get the new Gradle version. In 
this case, I don't expect much issues with the possible but hopefully rare 
discrepancy between gradlew.bat and the wrapper.

What do you think?


> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, init-gradle-wrapper-R16.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-8939) Unit test case for service - CheckCreateStockRequirementQoh

2019-06-21 Thread Anushi Gupta (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anushi Gupta updated OFBIZ-8939:

Attachment: OFBIZ-8939.patch

> Unit test case for service - CheckCreateStockRequirementQoh
> ---
>
> Key: OFBIZ-8939
> URL: https://issues.apache.org/jira/browse/OFBIZ-8939
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Anushi Gupta
>Priority: Minor
> Attachments: OFBIZ-8939.patch, OFBIZ-8939.patch
>
>
> Unit test case for service - CheckCreateStockRequirementQoh



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10538) Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity

2019-06-21 Thread Amit Gadaley (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley reassigned OFBIZ-10538:


Assignee: Amit Gadaley

> Promised Datetime & Current Promised Date values not getting updated in 
> OISGIR Entity
> -
>
> Key: OFBIZ-10538
> URL: https://issues.apache.org/jira/browse/OFBIZ-10538
> Project: OFBiz
>  Issue Type: Bug
>  Components: order, product
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Amit Gadaley
>Priority: Major
>
> While creating the sales order from the backend, if we set the 'Ship Before 
> Date' it will be stored in OrderItemShipGroup.shipByDate field and same will 
> be propagated to OrderItemShipGrpInvRes.promisedDateTime and 
> OrderItemShipGrpInvRes.currentPromisedDate fields.
>   
>  On updating the 'Ship Before Date' from the order view page later, the 
> promisedDateTime and currentPromisedDate get updated in OrderItemShipGroup 
> entity but remains the same in OrderItemShipGroupInvRes entity. 
>   
>  As OrderItemShipGrpInvRes.promisedDateTime & 
> OrderItemShipGrpInvRes.currentPromisedDate are being used in many services 
> like 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity', 
> 'reserveProductInventory' etc., we should also update these on updating the 
> 'Ship Before Date' from the order overview page. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10792) When shopping list is added to cart only one of the item is added to cart instead of all items in the list

2019-06-21 Thread Ritesh Kumar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ritesh Kumar reassigned OFBIZ-10792:


Assignee: (was: Ritesh Kumar)

> When shopping list is added to cart only one of the item is added to cart 
> instead of all items in the list
> --
>
> Key: OFBIZ-10792
> URL: https://issues.apache.org/jira/browse/OFBIZ-10792
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Rashi Dhagat
>Priority: Major
> Attachments: Shopping List.gif
>
>
> Steps to regenerate:
>  # Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList]
>  # Create a new shopping list
>  # Add items in the list
>  # Click on "Add List To Cart".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10792) When shopping list is added to cart only one of the item is added to cart instead of all items in the list

2019-06-21 Thread Ritesh Kumar (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870079#comment-16870079
 ] 

Ritesh Kumar commented on OFBIZ-10792:
--

This does happen only in the case of configurable products. However, we can 
still configure such products on their view page and add to cart from there.
Any user wishing to use this feature (adding a wishlist to cart) can always 
customize according to his/her need.

> When shopping list is added to cart only one of the item is added to cart 
> instead of all items in the list
> --
>
> Key: OFBIZ-10792
> URL: https://issues.apache.org/jira/browse/OFBIZ-10792
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Rashi Dhagat
>Assignee: Ritesh Kumar
>Priority: Major
> Attachments: Shopping List.gif
>
>
> Steps to regenerate:
>  # Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList]
>  # Create a new shopping list
>  # Add items in the list
>  # Click on "Add List To Cart".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-8861) Unit test case for service - GetReturnAmountByOrder

2019-06-21 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-8861.


Thanks Avnindra Sharma for reporting and Yogesh Naroliya for providing the 
updated patch.

> Unit test case for service - GetReturnAmountByOrder
> ---
>
> Key: OFBIZ-8861
> URL: https://issues.apache.org/jira/browse/OFBIZ-8861
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8861.patch, OFBIZ-8861.patch
>
>
> Unit test case for service - GetReturnAmountByOrder



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page

2019-06-21 Thread Nitish Mishra (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitish Mishra updated OFBIZ-11095:
--
Attachment: OFBIZ-11095.patch

> Ecommerce image distorted in trunk demo main page
> -
>
> Key: OFBIZ-11095
> URL: https://issues.apache.org/jira/browse/OFBIZ-11095
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Nitish Mishra
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-11095.patch, OFBIZ-11095.patch, OFBIZ-11095.patch
>
>
> Due to recent bootstrap changes, ecommerce image is distorted in trunk demo 
> main page



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10742) Survey form does not appears when survey product added to an order

2019-06-21 Thread Amit Gadaley (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amit Gadaley closed OFBIZ-10742.

Resolution: Cannot Reproduce

> Survey form does not appears when survey product added to an order
> --
>
> Key: OFBIZ-10742
> URL: https://issues.apache.org/jira/browse/OFBIZ-10742
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Amit Gadaley
>Assignee: Amit Gadaley
>Priority: Major
> Fix For: Trunk
>
>
> Survey form does not appear when survey product added to an order.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page

2019-06-21 Thread Nitish Mishra (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870068#comment-16870068
 ] 

Nitish Mishra commented on OFBIZ-11095:
---

[~jacques.le.roux] I have updated the patch

[^OFBIZ-11095.patch]

> Ecommerce image distorted in trunk demo main page
> -
>
> Key: OFBIZ-11095
> URL: https://issues.apache.org/jira/browse/OFBIZ-11095
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Nitish Mishra
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-11095.patch, OFBIZ-11095.patch, OFBIZ-11095.patch
>
>
> Due to recent bootstrap changes, ecommerce image is distorted in trunk demo 
> main page



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10671) Error message is displayed when user having space in username logs in at ecommerce

2019-06-21 Thread Praveen Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Sharma reassigned OFBIZ-10671:
--

Assignee: Praveen Sharma

> Error message is displayed when user having space in username logs in at 
> ecommerce
> --
>
> Key: OFBIZ-10671
> URL: https://issues.apache.org/jira/browse/OFBIZ-10671
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Praveen Sharma
>Priority: Major
> Attachments: 1-Register.png, 2-Redirected.png, 3-Login.png
>
>
> Steps to regenerate:
>  # Open URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
>  # Click on register in header section
>  # Provide all the mandatory information but provide a user name such that is 
> contains a space (like: Walter White or Jesse Pinkman) (Please refer 
> attachment: 1-Register)
>  # Click on save button
> Actual: When user clicks on save button then he is redirected to main page of 
> ecommerce and an error message is displayed. (Please refer attachment: 
> 2-Redirected)
> Similarly when user with space in username tries to login, error message is 
> displayed. (Please refer attachment: 3-Login)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9579) Required field indicator (*) is missing on some forms

2019-06-21 Thread Aditi Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditi Patidar closed OFBIZ-9579.

Resolution: Fixed

> Required field indicator (*) is missing on some forms
> -
>
> Key: OFBIZ-9579
> URL: https://issues.apache.org/jira/browse/OFBIZ-9579
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Trivial
>
> This is an umbrella issue, work to be done in sub-tasks or here if it's only 
> in one form



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-8808) JUnit test case for Creating a Retrun Header

2019-06-21 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-8808.


Thanks Avnindra Sharma for reporting and Yogesh Naroliya for providing the 
updated patch.

> JUnit test case for Creating a Retrun Header
> 
>
> Key: OFBIZ-8808
> URL: https://issues.apache.org/jira/browse/OFBIZ-8808
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8808.patch, OFBIZ-8808.patch
>
>
> Unit test case for service - createReturnHeader



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10794) Promotion condition/action type of few promotion not showing

2019-06-21 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10794.
-

Thanks Lalit Dashora for reporting the issue and providing the patch.

> Promotion condition/action type of few promotion not showing
> 
>
> Key: OFBIZ-10794
> URL: https://issues.apache.org/jira/browse/OFBIZ-10794
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 18.12.01
>
> Attachments: OFBIZ-10794.patch
>
>
> Steps to replicate:
> 1. Open 
> https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductPromoRules?productPromoId=9000
>  with login credentials admin/ofbiz
> 2. Validate that the condition type and action type is not shown in dropdown.
> 3. Now validate the inputParamEnumId, productPromoActionEnumId of 
> productPromoAction and productPromoCond entity.
> 4. Also try to change the condition type and click on update button. Error is 
> rendering on screen.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10794) Promotion condition/action type of few promotion not showing

2019-06-21 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana resolved OFBIZ-10794.
---
   Resolution: Fixed
Fix Version/s: 18.12.01

It has been fixed on 
OOTB Trunk at rev #1861811

Release 18.12 ar rev#1861812

> Promotion condition/action type of few promotion not showing
> 
>
> Key: OFBIZ-10794
> URL: https://issues.apache.org/jira/browse/OFBIZ-10794
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 18.12.01
>
> Attachments: OFBIZ-10794.patch
>
>
> Steps to replicate:
> 1. Open 
> https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductPromoRules?productPromoId=9000
>  with login credentials admin/ofbiz
> 2. Validate that the condition type and action type is not shown in dropdown.
> 3. Now validate the inputParamEnumId, productPromoActionEnumId of 
> productPromoAction and productPromoCond entity.
> 4. Also try to change the condition type and click on update button. Error is 
> rendering on screen.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10350) use of oversized images OOTB --> Products --> Content

2019-06-21 Thread Rohit Hukkeri (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870059#comment-16870059
 ] 

Rohit Hukkeri commented on OFBIZ-10350:
---

Hello Rajesh,

Can you please add some more details on the ticket as I can't find the issue on 
the given sections in the link.

Regards,

Rohit Hukkeri 

> use of oversized images OOTB --> Products --> Content
> -
>
> Key: OFBIZ-10350
> URL: https://issues.apache.org/jira/browse/OFBIZ-10350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Priority: Minor
>
> Hi,
>  
> the "Content" tab of product management screen in OOTB displays very large 
> images in a small constrained areas.
> Eg:
> In screen
> [https://demo-stable.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1000]
>  
> there are 2 photos in "Override Simple Fields" section. Both the images are 
> linked
> to respective sizes which is OK. However for display also the image source is
> set as the respective size which IMHO will load larger images  unnecessarily .
> I feel all the thumbs can be created using the same "small" sized image and 
> they can be  linked to  respective sizes ( which is happening already).
> The same problem is more pronounced in "Add Additional Images" section as the 
> thumbnails are linked to the "original" size itself ( which can be huge). I 
> feel there  also theycan/should be linked to the small size.
>  
> regds
> mallah.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10643) Google reCAPTCHA in E-Commerce Application

2019-06-21 Thread Priya Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Priya Sharma reassigned OFBIZ-10643:


Assignee: Priya Sharma

> Google reCAPTCHA in E-Commerce Application
> --
>
> Key: OFBIZ-10643
> URL: https://issues.apache.org/jira/browse/OFBIZ-10643
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce
>Reporter: Deepak Nigam
>Assignee: Priya Sharma
>Priority: Major
>
> Google reCAPTCHA is a security feature that protects websites forms from spam 
> entries while letting real people pass through with ease. It can be used for 
> login, registration, password recovery, comments, popular contact forms, etc.
> Users are required to confirm that they are not a robot before the form can 
> be submitted. It’s easy for people and hard for bots. 
>  
> For more information about Google reCAPTCHA, please visit 
> [here|https://developers.google.com/recaptcha/].
>  
> I think this feature will be useful for OFBiz e-commerce also.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11061) UI issue on contactus page of ecommerce

2019-06-21 Thread Sasikant Biswal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sasikant Biswal reassigned OFBIZ-11061:
---

Assignee: Sasikant Biswal

> UI issue on contactus page of ecommerce
> ---
>
> Key: OFBIZ-11061
> URL: https://issues.apache.org/jira/browse/OFBIZ-11061
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Sasikant Biswal
>Priority: Minor
> Attachments: Image1.1.png, Image1.2.png, Image1.3.png
>
>
> Steps to regenerate:
>  * Navigate to [https://demo-trunk.ofbiz.apache.org/ecomseo/]
>  * Click on Login
>  * Enter valid username and password
>  * Click on login button
>  * Click on Contact Us
> Actual: From, subject and message label are not displayed properly on some 
> resolution. Please refer attachment: Image1.1, Image1.2, Image1.3
> Note: This issue is resolution specific if you are unable to generate the 
> issue then increase the resolution of your screen or zoom in the page on 
> browser



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9004) Unit test case for service - createAcctgTransEntry

2019-06-21 Thread Yogesh Naroliya (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yogesh Naroliya reassigned OFBIZ-9004:
--

Assignee: Yogesh Naroliya

> Unit test case for service -  createAcctgTransEntry
> ---
>
> Key: OFBIZ-9004
> URL: https://issues.apache.org/jira/browse/OFBIZ-9004
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Yogesh Naroliya
>Priority: Minor
> Attachments: OFBIZ-9004.patch
>
>
> Unit test case for service -  createAcctgTransEntry



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9090) Unit test case for service - createProductConfigOption

2019-06-21 Thread Yogesh Naroliya (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yogesh Naroliya reassigned OFBIZ-9090:
--

Assignee: Yogesh Naroliya

> Unit test case for service - createProductConfigOption
> --
>
> Key: OFBIZ-9090
> URL: https://issues.apache.org/jira/browse/OFBIZ-9090
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Pradhan Yash Sharma
>Assignee: Yogesh Naroliya
>Priority: Minor
> Attachments: OFBIZ-9090.patch
>
>
> Unit test case for service - createProductConfigOption



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9093) Unit test case for service - createPaymentContent

2019-06-21 Thread Yogesh Naroliya (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yogesh Naroliya reassigned OFBIZ-9093:
--

Assignee: Yogesh Naroliya

> Unit test case for service -  createPaymentContent
> --
>
> Key: OFBIZ-9093
> URL: https://issues.apache.org/jira/browse/OFBIZ-9093
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Yogesh Naroliya
>Priority: Minor
> Attachments: OFBIZ-9093.patch
>
>
> Unit test case for service -  createPaymentContent



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9092) Unit test case for service - getPayments

2019-06-21 Thread Yogesh Naroliya (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yogesh Naroliya reassigned OFBIZ-9092:
--

Assignee: Yogesh Naroliya

> Unit test case for service -  getPayments
> -
>
> Key: OFBIZ-9092
> URL: https://issues.apache.org/jira/browse/OFBIZ-9092
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Deepak Nigam
>Assignee: Yogesh Naroliya
>Priority: Minor
> Attachments: OFBIZ-9092.patch
>
>
> Unit test case for service -  getPayments



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11061) UI issue on contactus page of ecommerce

2019-06-21 Thread Praveen Sharma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Praveen Sharma reassigned OFBIZ-11061:
--

Assignee: (was: Praveen Sharma)

> UI issue on contactus page of ecommerce
> ---
>
> Key: OFBIZ-11061
> URL: https://issues.apache.org/jira/browse/OFBIZ-11061
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Priority: Minor
> Attachments: Image1.1.png, Image1.2.png, Image1.3.png
>
>
> Steps to regenerate:
>  * Navigate to [https://demo-trunk.ofbiz.apache.org/ecomseo/]
>  * Click on Login
>  * Enter valid username and password
>  * Click on login button
>  * Click on Contact Us
> Actual: From, subject and message label are not displayed properly on some 
> resolution. Please refer attachment: Image1.1, Image1.2, Image1.3
> Note: This issue is resolution specific if you are unable to generate the 
> issue then increase the resolution of your screen or zoom in the page on 
> browser



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869899#comment-16869899
 ] 

Jacques Le Roux commented on OFBIZ-10145:
-

Hi Swapnil,
bq. we should also have existance check for gradle-wrapper.properties file.
I propose another change, please see below.

You are right about the Wrapper version for already installed trunk. Running 
something like {{gradlew wrapper --gradle-version=5.0 --distribution-type=bin}} 
(w/ --gradle-version changed when needed) in gradlew.bat after loading the 
wrapper should be enough (ie before {{@rem Execute Gradle}}.

It took 35 sec on my machine the 1st time, then it's only 1 sec. Of course when 
the version change that's another story, but it's then "expected". Something 
similar could be done for *nix version, I guess. It applies to Buildbot as well 
(w/o changing [ofbiz.conf 
file|https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/ofbiz.conf]).

Unfortunately, I stumbled upon this [Gradle 
bug|https://github.com/gradle/gradle/issues/7883] (ouch!) and I'll see later 
how it's possible to do better.

Here is the current state: [^gradlew.bat.patch]

About gradle-wrapper.properties check. I changed the check to verify if the 
gradle\wrapper directory exists, simpler ;) So we should remove this directory. 
That's actually what I expected when I wrote {{md %APP_HOME%\gradle\wrapper}} 
now replaced by {{md WRAPPER_CLASSPATH}}

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, init-gradle-wrapper-R16.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-21 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10145:

Attachment: gradlew.bat.patch

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, init-gradle-wrapper-R16.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-21 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10145:

Attachment: (was: gradlew.bat.patch)

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-21 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-10145:

Attachment: gradlew.bat.patch

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, init-gradle-wrapper-R16.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10800) Unable to remove items from onePageCheckout screen of ecommerce

2019-06-21 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10800:
-

Assignee: Suraj Khurana  (was: Dhaval Wagela)

> Unable to remove items from onePageCheckout screen of ecommerce
> ---
>
> Key: OFBIZ-10800
> URL: https://issues.apache.org/jira/browse/OFBIZ-10800
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Arpit Mor
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: 1-ToOnePageCheckout.png, 2-Remove.png, 3-NoAddress2.png, 
> 4-EmptyLine.png, 5-ScreenResolution.png, 6-100%Zoom.png, 7-80%Zoom.png, 
> OFBIZ-10800.patch, OFBIZ.10800.patch
>
>
> Steps to regenerate:
>  # Login to URL: 
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/checkLogin/main]
>  # Add items to cart
>  # Click on One Page Checkout at top right of the page (Please refer 
> attachment: 1-ToOnePageCheckout)
> Actual: Remove link is not working on onePageCheckout screen (Please refer 
> attachment: 2-Remove)
>  
> Note: Following UI issues were also found on page
>  # Product image is not displayed on screen and UI is not proper (Please 
> refer attachment: 2-Remove)
>  # If in step 2 of the page, address line 2 is empty then on clicking on 
> continue to step 3, empty line is displayed (Please refer attachments: 
> 3-NoAddress2 and 4-EmptyLine)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7467) WebSocket Example - Push Notifications

2019-06-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869468#comment-16869468
 ] 

Jacques Le Roux commented on OFBIZ-7467:


It could be due to a missing ofbiz-example-discoverable as it was in  
[^OFBIZ-7467.patch] or a related thing. I need to refresh my mind about it, by 
reading also in OFBIZ-7073

> WebSocket Example - Push Notifications
> --
>
> Key: OFBIZ-7467
> URL: https://issues.apache.org/jira/browse/OFBIZ-7467
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 16.11.01, 17.12.01
>
> Attachments: OFBIZ-7467.patch, OFBIZ-7483-Screen-Shot.png
>
>
> This is a ticket for adding working example (in example application) of 
> WebSocket support that has been done in OFBIZ-7073



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (OFBIZ-7467) WebSocket Example - Push Notifications

2019-06-21 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-7467:


Again this fails, at least I can't see the example working on screen

> WebSocket Example - Push Notifications
> --
>
> Key: OFBIZ-7467
> URL: https://issues.apache.org/jira/browse/OFBIZ-7467
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 16.11.01, 17.12.01
>
> Attachments: OFBIZ-7467.patch, OFBIZ-7483-Screen-Shot.png
>
>
> This is a ticket for adding working example (in example application) of 
> WebSocket support that has been done in OFBIZ-7073



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869463#comment-16869463
 ] 

Jacques Le Roux commented on OFBIZ-10639:
-

Thanks Aditya,

Yes I get the same with 
https://www.google.fr/search?q=gdpr+cookie+duration=UTF-8 though I could not 
find a defintive legal definition at 
http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm. I must say I did not 
dig into links at bottom ;)

We have also the Session, AutoLogin, Visitor and Site Id cookies with such a 
duration. I think it's OK and we can use the same for the consent.

> Cookie Consent In E-Commerce
> 
>
> Key: OFBIZ-10639
> URL: https://issues.apache.org/jira/browse/OFBIZ-10639
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Priority: Minor
> Attachments: OFBIZ-10639.patch, OFBIZ-10639.patch, 
> image-2019-06-18-16-55-24-395.png
>
>
> As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] 
> The Cookie Law is a piece of privacy legislation that requires websites to 
> get consent from visitors to store or retrieve any information on their 
> computer, smartphone or tablet. It was designed to protect online privacy, by 
> making consumers aware of how information about them is collected and used 
> online, and give them a choice to allow it or not. 
>   
>  The EU Cookie Legislation began as a directive from the European Union. Some 
> variation on the policy has since been adopted by all countries within the EU.
>   
>  The EU Cookie Legislation requires 4 actions from website owners who use 
> cookies:
>  1. When someone visits your website, you need to let them know that your 
> site uses cookies. 
>  2. You need to provide detailed information regarding how that cookie data 
> will be utilized. 
>  3. You need to provide visitors with some means of accepting or refusing the 
> use of cookies in your site. 
>  4. If they refuse, you need to ensure that cookies will not be placed on 
> their machine.
>  
>  For more information about EU cookie policy, please visit 
> [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm].
>   
>  As this crucial feature is missing in OFBiz E-Commerce application, we 
> should work towards its implementation. There are numerous open-source jQuery 
> plugins available which we can use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10610) New Communications not Entering

2019-06-21 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10610.
---
Resolution: Abandoned

This works OOTB on trunk demo. I believe it's a MSSQL issue only, w/o solution 
provided. Please reopen otherwise

> New Communications not Entering
> ---
>
> Key: OFBIZ-10610
> URL: https://issues.apache.org/jira/browse/OFBIZ-10610
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: 16.11.05
> Environment: using ubuntu front end and MSSQL 2012 database, edge 
> browser on windows 10.
>Reporter: Greg Finlayson
>Priority: Major
>
> I cannot enter new communications in the communications screen as the insert 
> fails with the following error:
>  
> The Following Errors Occurred:
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: 
> Service invocation error (Could not commit transaction for service 
> [createCommunicationEvent] call: Roll back error, could not commit 
> transaction, was rolled back instead because of: Failure in create operation 
> for entity [CommunicationEvent]: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:CommunicationEvent][communicationEventId,10031(java.lang.String)][communicationEventTypeId,EMAIL_COMMUNICATION(java.lang.String)][contactListId,null()][contactMechIdFrom,13271(java.lang.String)][contactMechIdTo,14832(java.lang.String)][contactMechTypeId,DOMAIN_NAME(java.lang.String)][content,null()][contentMimeTypeId,text/plain(java.lang.String)][createdStamp,2018-10-21
>  14:45:04.533(java.sql.Timestamp)][createdTxStamp,2018-10-21 
> 14:45:03.319(java.sql.Timestamp)][datetimeEnded,2018-10-12 
> 00:00:00.0(java.sql.Timestamp)][datetimeStarted,2018-10-12 
> 00:00:00.0(java.sql.Timestamp)][entryDate,2018-10-21 
> 14:45:04.533(java.sql.Timestamp)][lastUpdatedStamp,2018-10-21 
> 14:45:04.533(java.sql.Timestamp)][lastUpdatedTxStamp,2018-10-21 
> 14:45:03.319(java.sql.Timestamp)][messageId,null()][note,null()][parentCommEventId,null()][partyIdFrom,10001(java.lang.String)][partyIdTo,13295(java.lang.String)][reasonEnumId,null()][roleTypeIdFrom,_NA_(java.lang.String)][roleTypeIdTo,_NA_(java.lang.String)][statusId,COM_PENDING(java.lang.String)][subject,Enquiry
>  regarding documents(java.lang.String)] (SQL Exception while executing the 
> following:INSERT INTO dbo.COMMUNICATION_EVENT (COMMUNICATION_EVENT_ID, 
> COMMUNICATION_EVENT_TYPE_ID, ORIG_COMM_EVENT_ID, PARENT_COMM_EVENT_ID, 
> STATUS_ID, CONTACT_MECH_TYPE_ID, CONTACT_MECH_ID_FROM, CONTACT_MECH_ID_TO, 
> ROLE_TYPE_ID_FROM, ROLE_TYPE_ID_TO, PARTY_ID_FROM, PARTY_ID_TO, ENTRY_DATE, 
> DATETIME_STARTED, DATETIME_ENDED, SUBJECT, CONTENT_MIME_TYPE_ID, CONTENT, 
> NOTE, REASON_ENUM_ID, CONTACT_LIST_ID, HEADER_STRING, FROM_STRING, TO_STRING, 
> CC_STRING, BCC_STRING, MESSAGE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, 
> CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (Cannot insert 
> duplicate key row in object 'dbo.COMMUNICATION_EVENT' with unique index 
> 'COMMEVT_MSG_ID'. The duplicate key value is ().)). Rolling back 
> transaction.org.apache.ofbiz.entity.GenericEntityException: Error while 
> inserting: 
> [GenericEntity:CommunicationEvent][communicationEventId,10031(java.lang.String)][communicationEventTypeId,EMAIL_COMMUNICATION(java.lang.String)][contactListId,null()][contactMechIdFrom,13271(java.lang.String)][contactMechIdTo,14832(java.lang.String)][contactMechTypeId,DOMAIN_NAME(java.lang.String)][content,null()]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2019-06-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869416#comment-16869416
 ] 

Jacques Le Roux commented on OFBIZ-4361:


Hi Guys, what is the situation here?

> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release 
> Branch 17.12
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: security
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, 
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch, 
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10903) Make Gradle createPlugin task reflect the actual file/folder structure

2019-06-21 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-10903:
---

Assignee: Pawan Verma  (was: Michael Brohl)

> Make Gradle createPlugin task reflect the actual file/folder structure
> --
>
> Key: OFBIZ-10903
> URL: https://issues.apache.org/jira/browse/OFBIZ-10903
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Gradle
>Reporter: Michael Brohl
>Assignee: Pawan Verma
>Priority: Minor
>
> Just recognized that at least the groovyScripts folder is still named 
> "script". Have to check if there is anything else mising or has to be 
> corrected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10903) Make Gradle createPlugin task reflect the actual file/folder structure

2019-06-21 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869406#comment-16869406
 ] 

Pawan Verma commented on OFBIZ-10903:
-

Hello [~mbrohl],

I am working on this task. Thanks!

> Make Gradle createPlugin task reflect the actual file/folder structure
> --
>
> Key: OFBIZ-10903
> URL: https://issues.apache.org/jira/browse/OFBIZ-10903
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Gradle
>Reporter: Michael Brohl
>Assignee: Pawan Verma
>Priority: Minor
>
> Just recognized that at least the groovyScripts folder is still named 
> "script". Have to check if there is anything else mising or has to be 
> corrected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-21 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869382#comment-16869382
 ] 

Swapnil M Mane edited comment on OFBIZ-10145 at 6/21/19 10:56 AM:
--

Thanks so much [~jacques.le.roux] and [~soledad], this work is going in great 
direction :)

I think, we should also have existance check for gradle-wrapper.properties file.
Here is the patch [^OFBIZ-10145_wrapper_properties_check.patch] for same, 
please have a look.


Also, I am thinking about the use case, how we will change the 
gradle-wrapper.jar and gradle-wrapper.properties on user's machine when we 
upgrade our Gradle version in trunk.
E.g. currently we are using Gradle v5.0 on the trunk, in future when we upgrade 
the Gradle to next version let say v5.4.1.
In this case, the gradle-wrapper.jar and gradle-wrapper.properties will be not 
be updated on user's machine because as per our script it will only check the 
files with name (gradle-wrapper.jar and gradle-wrapper.properties) should exist 
in OFBiz_Root/gradle/wrapper directory.
And the script will found the old files in OFBiz_Root/gradle/wrapper directory, 
thus will not download the new jar and properties files.

Please let me know if I am missing anything.

Thanks!


was (Author: swapnilmmane):
Thanks so much [~jacques.le.roux] and [~soledad], this work is going in great 
direction :) 

I think, we should also have existance check for gradle-wrapper.properties file.
Here is the patch [^OFBIZ-10145_wrapper_properties_check.patch] for same, 
please have a look.

Thanks!

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-21 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869382#comment-16869382
 ] 

Swapnil M Mane commented on OFBIZ-10145:


Thanks so much [~jacques.le.roux] and [~soledad], this work is going in great 
direction :) 

I think, we should also have existance check for gradle-wrapper.properties file.
Here is the patch [^OFBIZ-10145_wrapper_properties_check.patch] for same, 
please have a look.

Thanks!

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-21 Thread Swapnil M Mane (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil M Mane updated OFBIZ-10145:
---
Attachment: OFBIZ-10145_wrapper_properties_check.patch

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-21 Thread Nicolas Malin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869338#comment-16869338
 ] 

Nicolas Malin commented on OFBIZ-10145:
---

Ok,

I commit the first version on trunk at 1861766

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, gradlew.bat.patch, 
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869307#comment-16869307
 ] 

Jacques Le Roux commented on OFBIZ-10145:
-

Hi Nicolas,

Yes that sounds good to me. There are 3 aspects to it: branches, demos and 
Buildbot. 
# Branches, we can indeed discuss on dev ML as you suggest. 
For Windows I just have to create dedicated init-gradle-wrapper.ps1 scripts by 
branches
# Demos would follow since it would all depends on gradlew and added 
init-gradle-wrapper scripts 
# Buildbot uses tools as wrapper repo, it's already OK and works for 2 weeks, 
nothing needs to be changed


> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, gradlew.bat.patch, 
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-21 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869306#comment-16869306
 ] 

Aditya Sharma edited comment on OFBIZ-10639 at 6/21/19 9:04 AM:


As per the post I explored, it can last maximum 1 year.

Citation from the [post|https://www.cookiebot.com/en/gdpr-cookies/] at Cookiebot
{quote}Every 12 months, upon the user’s first visit to the site, the consent 
pops up again asking for a renewal of the consent.
{quote}
Citation from the 
[post|https://www.iubenda.com/en/help/5525-cookies-gdpr-requirements] at 
iubenda.com
{quote}The Authority prescribes a maximum validity (the ability to “remember” 
or “keep track” of the consent) of 12 months from the last site visit. The 
iubenda Cookie Solution makes use of this method of “consent tracking”.
{quote}
 


was (Author: aditya.sharma):
As per the post I explored, it can last maximum 1 year. Citation from the 
[post|https://www.cookiebot.com/en/gdpr-cookies/] at Cookiebot
{quote}Every 12 months, upon the user’s first visit to the site, the consent 
pops up again asking for a renewal of the consent.
{quote}
Citation from the 
[post|https://www.iubenda.com/en/help/5525-cookies-gdpr-requirements] at 
iubenda.com
{quote}The Authority prescribes a maximum validity (the ability to “remember” 
or “keep track” of the consent) of 12 months from the last site visit. The 
iubenda Cookie Solution makes use of this method of “consent tracking”.
{quote}
 

> Cookie Consent In E-Commerce
> 
>
> Key: OFBIZ-10639
> URL: https://issues.apache.org/jira/browse/OFBIZ-10639
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Priority: Minor
> Attachments: OFBIZ-10639.patch, OFBIZ-10639.patch, 
> image-2019-06-18-16-55-24-395.png
>
>
> As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] 
> The Cookie Law is a piece of privacy legislation that requires websites to 
> get consent from visitors to store or retrieve any information on their 
> computer, smartphone or tablet. It was designed to protect online privacy, by 
> making consumers aware of how information about them is collected and used 
> online, and give them a choice to allow it or not. 
>   
>  The EU Cookie Legislation began as a directive from the European Union. Some 
> variation on the policy has since been adopted by all countries within the EU.
>   
>  The EU Cookie Legislation requires 4 actions from website owners who use 
> cookies:
>  1. When someone visits your website, you need to let them know that your 
> site uses cookies. 
>  2. You need to provide detailed information regarding how that cookie data 
> will be utilized. 
>  3. You need to provide visitors with some means of accepting or refusing the 
> use of cookies in your site. 
>  4. If they refuse, you need to ensure that cookies will not be placed on 
> their machine.
>  
>  For more information about EU cookie policy, please visit 
> [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm].
>   
>  As this crucial feature is missing in OFBiz E-Commerce application, we 
> should work towards its implementation. There are numerous open-source jQuery 
> plugins available which we can use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-21 Thread Aditya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869306#comment-16869306
 ] 

Aditya Sharma commented on OFBIZ-10639:
---

As per the post I explored, it can last maximum 1 year. Citation from the 
[post|https://www.cookiebot.com/en/gdpr-cookies/] at Cookiebot
{quote}Every 12 months, upon the user’s first visit to the site, the consent 
pops up again asking for a renewal of the consent.
{quote}
Citation from the 
[post|https://www.iubenda.com/en/help/5525-cookies-gdpr-requirements] at 
iubenda.com
{quote}The Authority prescribes a maximum validity (the ability to “remember” 
or “keep track” of the consent) of 12 months from the last site visit. The 
iubenda Cookie Solution makes use of this method of “consent tracking”.
{quote}
 

> Cookie Consent In E-Commerce
> 
>
> Key: OFBIZ-10639
> URL: https://issues.apache.org/jira/browse/OFBIZ-10639
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Priority: Minor
> Attachments: OFBIZ-10639.patch, OFBIZ-10639.patch, 
> image-2019-06-18-16-55-24-395.png
>
>
> As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] 
> The Cookie Law is a piece of privacy legislation that requires websites to 
> get consent from visitors to store or retrieve any information on their 
> computer, smartphone or tablet. It was designed to protect online privacy, by 
> making consumers aware of how information about them is collected and used 
> online, and give them a choice to allow it or not. 
>   
>  The EU Cookie Legislation began as a directive from the European Union. Some 
> variation on the policy has since been adopted by all countries within the EU.
>   
>  The EU Cookie Legislation requires 4 actions from website owners who use 
> cookies:
>  1. When someone visits your website, you need to let them know that your 
> site uses cookies. 
>  2. You need to provide detailed information regarding how that cookie data 
> will be utilized. 
>  3. You need to provide visitors with some means of accepting or refusing the 
> use of cookies in your site. 
>  4. If they refuse, you need to ensure that cookies will not be placed on 
> their machine.
>  
>  For more information about EU cookie policy, please visit 
> [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm].
>   
>  As this crucial feature is missing in OFBiz E-Commerce application, we 
> should work towards its implementation. There are numerous open-source jQuery 
> plugins available which we can use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-21 Thread Nicolas Malin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869279#comment-16869279
 ] 

Nicolas Malin commented on OFBIZ-10145:
---

Super Jacques,

To move forward, I propose to commit on trunk only with your solution and open 
a discussion on the rule to resolve the gradle-wrapper.jar
As it will be present on trunk it would be really easy to test and have an 
opinion.

After the discussion, I perform on release branches

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, gradlew.bat.patch, 
> init-gradle-wrapper-R16.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper.ps1, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, 
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10320) A potential bug in Email ForgotPassword Notification

2019-06-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869278#comment-16869278
 ] 

Jacques Le Roux commented on OFBIZ-10320:
-

Hi Schumann Ye,

Can you reproduce the same in trunk HEAD?

> A potential bug in Email ForgotPassword Notification
> 
>
> Key: OFBIZ-10320
> URL: https://issues.apache.org/jira/browse/OFBIZ-10320
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: 16.11.04
> Environment: OS: Windows Server 2008 R2
> Database: MySQL 5.7
> JDK: 1.8.0_131
>Reporter: Schumann Ye
>Priority: Minor
>
> Work Steps:
>  # In the login page: [https://www.myowndomain.com/webtools/control/main], 
> then click login, then click "forget your passwords".
>  # Then fill in the User Name that I have already created before, which is 
> associated with a primary email address.
>  # Then click "continue" and then hit "email password";
>  # As I have set the fields correctly in the file general.properties and also 
> in database table ofbiz.system_property, I receive a system email telling me 
> to "click here to reset password" with a link.
> Then click the link and following the instructions to fill in the new 
> passwords and then the following error messages pop up. Generally speaking, 
> the error is about java.lang.NullPointerException.
> (BTW, I tried it a couple of times with different locales like en and zh_CN 
> but all failed.)
>  
> Here below I highlighted somethings strange, where I have added some 
> debugging texts (in yellow background) to see what's going on.
> Obviously, in my debugging text Tag ---801--- the keyValue is missing (null).
> Maybe that's why it throws a java.lang.NullPointerException.
>  
> However, when I compare the codes (where it concerns) of EntityCrypto.java 
> and LoginWorker.java between 11.04 and 11.03, {color:#f79232}I could not find 
> the difference So I do NOT understand why it works in my 11.03 but not 
> 11.04.{color}
>  
>  
> {code}
> 2018-03-28 10:00:59,870 |http-nio-443-exec-4  |ServerHitBin  
> |I| Visit delegatorName=default, ServerHitBin delegatorName=default
> 2018-03-28 10:00:59,878 |http-nio-443-exec-4  |ControlServlet    
> |T| [[[forgotPassword_step2(Domain:https://www.myowndomain.com)] Request 
> Done- total:0.146,since last([forgotPassword_s...):0.146]]
> 2018-03-28 10:01:02,961 |http-nio-443-exec-1  |ControlServlet    
> |T| [[[forgotPassword_step3(Domain:https://www.myowndomain.com)] Request 
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> {color:#f79232}2018-03-28 10:01:02,988 |http-nio-443-exec-1  |EntityCrypto
>   |I| ---804---originalKeyName---is---loginSecretKeyString{color}
> {color:#f79232}2018-03-28 10:01:02,988 |http-nio-443-exec-1  |EntityCrypto
>   |I| ---805---originalKeyName---is---loginSecretKeyString{color}
> {color:#f79232}2018-03-28 10:01:02,988 |http-nio-443-exec-1  |EntityCrypto
>   |I| 
> [---806---hashRequest---is---org.apache.shiro.crypto.hash.SimpleHashRequest@327dc55e|mailto:---806---hashRequest---is---org.apache.shiro.crypto.hash.SimpleHashRequest@327dc55e]{color}
> 2018-03-28 10:01:03,066 |http-nio-443-exec-1  |ServiceDispatcher 
> |I| Service auth failed for userLoginId [MyCreatedUser] because UserLogin 
> record currentPassword fields did not match; note that the UserLogin object 
> passed into a service may need to have the currentPassword encrypted.
> 2018-03-28 10:01:03,067 |http-nio-443-exec-1  |ServiceDispatcher 
> |T| Sync service [order/getUserPreferenceGroup] finished in [2] milliseconds
> 2018-03-28 10:01:03,076 |http-nio-443-exec-1  |ScreenFactory 
> |I| Got 1 screens in 0.009s from: 
> file:/D:/apache-ofbiz-16.11.04/applications/securityext/widget/EmailSecurityScreens.xml
> 2018-03-28 10:01:03,137 |http-nio-443-exec-1  |UtilProperties    
> |I| ResourceBundle EmailPasswordUiLabels (en) created in 0.061s with 6 
> properties
> 2018-03-28 10:01:03,217 |http-nio-443-exec-1  |UtilProperties    
> |I| ResourceBundle SecurityUiLabels (en) created in 0.08s with 58 properties
> 2018-03-28 10:01:03,238 |http-nio-443-exec-1  |EmailServices 
> |I| Expanded email subject to: New Password Sent (MyCreatedUser)
> 2018-03-28 10:01:07,710 |http-nio-443-exec-1  |ServiceDispatcher 
> |T| Sync service [order/sendMailHiddenInLog] finished in [4471] milliseconds
> 2018-03-28 10:01:07,711 |http-nio-443-exec-1  |ServiceDispatcher 
> |T| Sync service [order/sendMailHiddenInLogFromScreen] finished in [4678] 
> milliseconds
> 2018-03-28 10:01:07,722 |http-nio-443-exec-1  |RequestHandler    
> |I| Ran Event 
> 

[jira] [Commented] (OFBIZ-10461) Texts of checkboxes sometimes have whitespaces

2019-06-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869276#comment-16869276
 ] 

Jacques Le Roux commented on OFBIZ-10461:
-

Hi Guys,

I stumbled upon this issue by chance, could we not agree, commit and close? 
Thanks.

> Texts of checkboxes sometimes have whitespaces
> --
>
> Key: OFBIZ-10461
> URL: https://issues.apache.org/jira/browse/OFBIZ-10461
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: OFBIZ-10461_RemoveBlanksBetweenCheckboxesAndLabels.patch
>
>
> On some pages, when there are checkboxes, the text after the checkbox has a 
> rendered whitespace in front of it.
> A good example for this can be seen right here:
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist]
> The first checkboxes do not have this rendered whitespace, the lines after 
> that do have it.
> This issue can be fixed simply through removing the whitespaces inside the 
> .ftl files.
>  
> After that there an added styling should create a new gap between the 
> checkbox and the following text, but this time all the gaps would have the 
> same distance.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)