[jira] [Updated] (OFBIZ-9299) Logo image not showing on party profile

2019-06-22 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9299:
---
Summary: Logo image not showing on party profile   (was: image content)

> Logo image not showing on party profile 
> 
>
> Key: OFBIZ-9299
> URL: https://issues.apache.org/jira/browse/OFBIZ-9299
> Project: OFBiz
>  Issue Type: Bug
>  Components: party, themes
>Affects Versions: Release Branch 16.11
>Reporter: Moatasim Al Masri
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: Rainbow, theme
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: Capture1.PNG, Capture2.PNG, OFBIZ-9299.patch
>
>
> logo image not displayed untill we press in content component
> see attached capture two images
> we can upload this image from party profile --> Party Content



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.

2019-06-22 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870336#comment-16870336
 ] 

Jacques Le Roux commented on OFBIZ-10150:
-

I agree with Pierre ans Suraj, better do it for all possible combinations. 
Maybe not obvious, so baby steps are indicated, and committing the current 
patch would be the 1st step.

> supplierProductId Should Have Consistent Types Across Entities.
> ---
>
> Key: OFBIZ-10150
> URL: https://issues.apache.org/jira/browse/OFBIZ-10150
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order, product
>Affects Versions: Trunk
> Environment: all
>Reporter: jesse thomas
>Assignee: Rohit Hukkeri
>Priority: Minor
> Attachments: OFBIZ-10150.patch
>
>
> During some data migration I hit an issue where my data for supplierProductId 
> was too long. So I looked up the fields and noticed that the order item 
> entity had a different type for the field than the supplier product entity. I 
> think it would be a good idea to pick one so the two fields can be treated 
> consistently. I would vote for id-long, but I think either way it would be 
> good to have them be the same type. There are other fields that have this 
> issue too if you are interested?
>   
> Thanks!
> applications/datamodel/entitydef/order-entitymodel.xml:  
>  
> applications/datamodel/entitydef/product-entitymodel.xml:  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7257) View Image button on order detail page is not working

2019-06-22 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870291#comment-16870291
 ] 

Jacques Le Roux commented on OFBIZ-7257:


Thanks Guys,

Devanshu, did you create a Jira for the minor Tika issue we spotted?

> View Image button on order detail page is not working
> -
>
> Key: OFBIZ-7257
> URL: https://issues.apache.org/jira/browse/OFBIZ-7257
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7257.patch, OFBIZ-7257.patch, OFBIZ-7257.patch
>
>
> Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9299) image content

2019-06-22 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9299.
--
   Resolution: Fixed
Fix Version/s: 18.12.01
   16.11.06
   17.12.01

> image content
> -
>
> Key: OFBIZ-9299
> URL: https://issues.apache.org/jira/browse/OFBIZ-9299
> Project: OFBiz
>  Issue Type: Bug
>  Components: party, themes
>Affects Versions: Release Branch 16.11
>Reporter: Moatasim Al Masri
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: Rainbow, theme
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: Capture1.PNG, Capture2.PNG, OFBIZ-9299.patch
>
>
> logo image not displayed untill we press in content component
> see attached capture two images
> we can upload this image from party profile --> Party Content



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9299) image content

2019-06-22 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870284#comment-16870284
 ] 

Jacques Le Roux commented on OFBIZ-9299:


Thanks Mohammed Rehan,

Your patch is in 
trunk r1861869 
R18 r1861870
R17 r1861871 (conflict in Content.ftl handled by hand)
R16 r1861872 (conflict in Content.ftl handled by hand)

Thanks Moatasim Al Masri for reporting!


> image content
> -
>
> Key: OFBIZ-9299
> URL: https://issues.apache.org/jira/browse/OFBIZ-9299
> Project: OFBiz
>  Issue Type: Bug
>  Components: party, themes
>Affects Versions: Release Branch 16.11
>Reporter: Moatasim Al Masri
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: Rainbow, theme
> Attachments: Capture1.PNG, Capture2.PNG, OFBIZ-9299.patch
>
>
> logo image not displayed untill we press in content component
> see attached capture two images
> we can upload this image from party profile --> Party Content



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9299) image content

2019-06-22 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9299:
---
Component/s: themes

> image content
> -
>
> Key: OFBIZ-9299
> URL: https://issues.apache.org/jira/browse/OFBIZ-9299
> Project: OFBiz
>  Issue Type: Bug
>  Components: party, themes
>Affects Versions: Release Branch 16.11
>Reporter: Moatasim Al Masri
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: Rainbow, theme
> Attachments: Capture1.PNG, Capture2.PNG, OFBIZ-9299.patch
>
>
> logo image not displayed untill we press in content component
> see attached capture two images
> we can upload this image from party profile --> Party Content



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9299) image content

2019-06-22 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9299:
---
Component/s: (was: content)
 party

> image content
> -
>
> Key: OFBIZ-9299
> URL: https://issues.apache.org/jira/browse/OFBIZ-9299
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 16.11
>Reporter: Moatasim Al Masri
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: Rainbow, theme
> Attachments: Capture1.PNG, Capture2.PNG, OFBIZ-9299.patch
>
>
> logo image not displayed untill we press in content component
> see attached capture two images
> we can upload this image from party profile --> Party Content



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9299) image content

2019-06-22 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-9299:
--

Assignee: Jacques Le Roux  (was: Mohammed Rehan Khan)

> image content
> -
>
> Key: OFBIZ-9299
> URL: https://issues.apache.org/jira/browse/OFBIZ-9299
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Release Branch 16.11
>Reporter: Moatasim Al Masri
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: Rainbow, theme
> Attachments: Capture1.PNG, Capture2.PNG, OFBIZ-9299.patch
>
>
> logo image not displayed untill we press in content component
> see attached capture two images
> we can upload this image from party profile --> Party Content



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page

2019-06-22 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870282#comment-16870282
 ] 

Jacques Le Roux commented on OFBIZ-11095:
-

Thanks Nitish,

Commited in trunk at revision: 1861867. I did not close because I'm unsure R18 
needs the same. Please let me know and if not you may close as fixed for 
Upcoming Branch.


> Ecommerce image distorted in trunk demo main page
> -
>
> Key: OFBIZ-11095
> URL: https://issues.apache.org/jira/browse/OFBIZ-11095
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Nitish Mishra
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-11095.patch, OFBIZ-11095.patch, OFBIZ-11095.patch
>
>
> Due to recent bootstrap changes, ecommerce image is distorted in trunk demo 
> main page



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page

2019-06-22 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859145#comment-16859145
 ] 

Jacques Le Roux edited comment on OFBIZ-11095 at 6/22/19 2:01 PM:
--

Yes, I have made some correction in patch

 Please check it now.[^OFBIZ-11095.patch]


was (Author: nitish.mishra):
Yes, I have made some correction in patch

 

Please check it now.[^OFBIZ-11095.patch]

> Ecommerce image distorted in trunk demo main page
> -
>
> Key: OFBIZ-11095
> URL: https://issues.apache.org/jira/browse/OFBIZ-11095
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Nitish Mishra
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-11095.patch, OFBIZ-11095.patch, OFBIZ-11095.patch
>
>
> Due to recent bootstrap changes, ecommerce image is distorted in trunk demo 
> main page



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11095) Ecommerce image distorted in trunk demo main page

2019-06-22 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-11095:
---

Assignee: Jacques Le Roux  (was: Deepak Dixit)

> Ecommerce image distorted in trunk demo main page
> -
>
> Key: OFBIZ-11095
> URL: https://issues.apache.org/jira/browse/OFBIZ-11095
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Nitish Mishra
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-11095.patch, OFBIZ-11095.patch, OFBIZ-11095.patch
>
>
> Due to recent bootstrap changes, ecommerce image is distorted in trunk demo 
> main page



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10858) Last Categories section is blank

2019-06-22 Thread Priya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870278#comment-16870278
 ] 

Priya Sharma commented on OFBIZ-10858:
--

Sorry for the misinterpretation, the issue does exist on the stable branch as 
well, it's only that we can't catch it since the empty bullet is not displayed. 
I will provide the patch for the stable branch as well.

> Last Categories section is blank 
> -
>
> Key: OFBIZ-10858
> URL: https://issues.apache.org/jira/browse/OFBIZ-10858
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: 16.11.05
>Reporter: Rashi Dhagat
>Assignee: Priya Sharma
>Priority: Major
> Attachments: LastCategories1.jpg, LastCategoriesRefreshed.jpg, 
> LastCategories_1strow.jpg, OFBIZ-10858.patch
>
>
> Issue 1:
> 1. Open [https://demo-trunk.ofbiz.apache.org/ecomseo]
> 2. Click on a category from the Categories section
> 3. Refresh the page
> *Actual:*
> 1. Last Categories is blank
> 2. If we refresh the page then only the search category visible with the last 
> row blank with a bullet.
> Issue 1:
> 1. Open [https://demo-trunk.ofbiz.apache.org/ecomseo]
> 2. Click on a category from the Categories section
> 3. Again, open the [https://demo-trunk.ofbiz.apache.org/ecomseo] in the new 
> tab
> *Actual:* 1st row is blank with searched categories



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10145) Remove the Gradle wrapper from our release packages and add a step to our build notes

2019-06-22 Thread Swapnil M Mane (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870277#comment-16870277
 ] 

Swapnil M Mane commented on OFBIZ-10145:


Thanks [~jacques.le.roux] for your comments, all the points makes sense to me :)
As you already mentioned,
{quote}the user must have an Internet connexion
{quote}
This is only the point we need to think on, let's see what are the thoughts our 
fellow team members.

Thanks!

> Remove the Gradle wrapper from our release packages and add a step to our 
> build notes
> -
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 17.12.01, 16.11.06, 18.12.01
>Reporter: Jacques Le Roux
>Assignee: Nicolas Malin
>Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, 
> OFBIZ-10145_wrapper_properties_check.patch, gradlew.bat.patch, 
> gradlew.bat.patch, init-gradle-wrapper-R16.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, 
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, 
> init-gradle-wrapper.sh, init-gradlew-readme-R16.patch, 
> init-gradlew-readme-R17.1.patch, init-gradlew-readme-R17.1.patch, 
> init-gradlew-readme.patch, init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, 
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to 
> remove the gradle-wrapper.jar file from the next packaged releases and  use 
> [~jacopoc]'s related proposition to document how to have Gradle working in 
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the 
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the 
> gradle-wrapper.jar. This might change in the future (versions, etc.), so 
> indeed maybe simply asking to download is enough, cf  
> https://www.google.com/search?q=gradle-wrapper.jar+download=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in 
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10858) Last Categories section is blank

2019-06-22 Thread Priya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870238#comment-16870238
 ] 

Priya Sharma edited comment on OFBIZ-10858 at 6/22/19 1:24 PM:
---

Though it is interesting to note that I am unable to map this behavior on 
[https://demo-stable.ofbiz.apache.org/ecommerce|https://demo-stable.ofbiz.apache.org/ecommerce/]

The above-mentioned categories never appear in the last search categories 
section, neither the empty bullet is displayed. This also raises the question 
as to which behavior is desired.

Please provide your views.


was (Author: priya.sharma.9362):
Though it is interesting to note that I am unable to map this behavior on 
[https://demo-stable.ofbiz.apache.org/ecommerce|https://demo-stable.ofbiz.apache.org/ecommerce/]

The above-mentioned categories never appear in the last search categories 
section. This also raises the question as to which behavior is desired.

Please provide your views.

> Last Categories section is blank 
> -
>
> Key: OFBIZ-10858
> URL: https://issues.apache.org/jira/browse/OFBIZ-10858
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: 16.11.05
>Reporter: Rashi Dhagat
>Assignee: Priya Sharma
>Priority: Major
> Attachments: LastCategories1.jpg, LastCategoriesRefreshed.jpg, 
> LastCategories_1strow.jpg, OFBIZ-10858.patch
>
>
> Issue 1:
> 1. Open [https://demo-trunk.ofbiz.apache.org/ecomseo]
> 2. Click on a category from the Categories section
> 3. Refresh the page
> *Actual:*
> 1. Last Categories is blank
> 2. If we refresh the page then only the search category visible with the last 
> row blank with a bullet.
> Issue 1:
> 1. Open [https://demo-trunk.ofbiz.apache.org/ecomseo]
> 2. Click on a category from the Categories section
> 3. Again, open the [https://demo-trunk.ofbiz.apache.org/ecomseo] in the new 
> tab
> *Actual:* 1st row is blank with searched categories



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10239) Improve GeneralLedgerServices to set AcctgTrans's transition date as payment's effective date

2019-06-22 Thread Rishi Solanki (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870271#comment-16870271
 ] 

Rishi Solanki commented on OFBIZ-10239:
---

Test fail is testAcctgTransOnPaymentSentToSupplier and in test ECA 
createAcctgTransAndEntriesForOutgoingPayment due to association not found 
between payment and accounting trans. We need to fix the service for the case 
so that test case get passed. Will look into it in more details and get it 
commit.

 

[~paulfoxworthy] I agree with you on point shipment receipt and customer refund 
payment application. And the above test case get failed, very soon I will 
propose fix for this. In case you have any suggestions/direction then please 
share. Thanks!

> Improve GeneralLedgerServices to set AcctgTrans's transition date as 
> payment's effective date
> -
>
> Key: OFBIZ-10239
> URL: https://issues.apache.org/jira/browse/OFBIZ-10239
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Reporter: Aishwary Shrivastava
>Assignee: Rishi Solanki
>Priority: Minor
> Attachments: OFBIZ-10239.patch, 
> OFBIZ-10239_SetAccountingTransactionDates.patch
>
>
> Whenever user applies a payment, the {color:#008000}transactionDate 
> {color}set on AcctgTransEntries is set by 
> {color:#80}now-timestamp{color}, this can result in wrong accounting 
> reports, if the payment was received earlier but applied later.
> For example, if someone receives a payment on 28 of Dec and applies the 
> payment on 3rd of Jan, the yearly accounting reports will show that 
> transaction in the new year, rather than in the previous year.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-06-22 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11105:
-

Assignee: Suraj Khurana

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Lalit Dashora
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11105.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-06-22 Thread Lalit Dashora (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora reassigned OFBIZ-11105:
-

Assignee: (was: Lalit Dashora)

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Lalit Dashora
>Priority: Major
> Attachments: OFBIZ-11105.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-06-22 Thread Lalit Dashora (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora reassigned OFBIZ-11105:
-

Assignee: Lalit Dashora

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
> Attachments: OFBIZ-11105.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number

2019-06-22 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870259#comment-16870259
 ] 

Pierre Smits commented on OFBIZ-0:
--

Should we not work towards a solution that when no contact type has been 
selected that a default is set?

> Able to add phone no. as contact type without adding number
> ---
>
> Key: OFBIZ-0
> URL: https://issues.apache.org/jira/browse/OFBIZ-0
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Rashi Dhagat
>Priority: Major
> Attachments: HC-0.patch
>
>
> Steps to regenerate:
>  # Open url 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile]
>  # Click on "Create new" in Contact Information section
>  # Select phone no as contact type
>  # Click on Create
>  # Click on Save
> Actual: Able to add phone no as contact type without adding no.
> Expected: Error message should be displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Issue Comment Deleted] (OFBIZ-11110) Able to add phone no. as contact type without adding number

2019-06-22 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-0:
-
Comment: was deleted

(was: Should we not work towards a solution that when no contact type has been 
selected that a default is set?)

> Able to add phone no. as contact type without adding number
> ---
>
> Key: OFBIZ-0
> URL: https://issues.apache.org/jira/browse/OFBIZ-0
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Rashi Dhagat
>Priority: Major
> Attachments: HC-0.patch
>
>
> Steps to regenerate:
>  # Open url 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile]
>  # Click on "Create new" in Contact Information section
>  # Select phone no as contact type
>  # Click on Create
>  # Click on Save
> Actual: Able to add phone no as contact type without adding no.
> Expected: Error message should be displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10960) UI fix on Party Manager screen

2019-06-22 Thread Sasikant Biswal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sasikant Biswal reassigned OFBIZ-10960:
---

Assignee: Sasikant Biswal

> UI fix on Party Manager screen
> --
>
> Key: OFBIZ-10960
> URL: https://issues.apache.org/jira/browse/OFBIZ-10960
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Sourabh Punyani
>Assignee: Sasikant Biswal
>Priority: Trivial
> Attachments: Image1.png
>
>
> Separators should not be there before first menu item on Find Party.
> https://demo-trunk.ofbiz.apache.org/partymgr/control/main?externalLoginKey=EL0b278ddf-49af-43f8-adec-cc3c81d75bee
> Please refer attachment Image1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10960) UI fix on Party Manager screen

2019-06-22 Thread Sasikant Biswal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sasikant Biswal reassigned OFBIZ-10960:
---

Assignee: (was: Sasikant Biswal)

> UI fix on Party Manager screen
> --
>
> Key: OFBIZ-10960
> URL: https://issues.apache.org/jira/browse/OFBIZ-10960
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Sourabh Punyani
>Priority: Trivial
> Attachments: Image1.png
>
>
> Separators should not be there before first menu item on Find Party.
> https://demo-trunk.ofbiz.apache.org/partymgr/control/main?externalLoginKey=EL0b278ddf-49af-43f8-adec-cc3c81d75bee
> Please refer attachment Image1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10900) Agreement overview does not show names of parties

2019-06-22 Thread Pierre Smits (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870258#comment-16870258
 ] 

Pierre Smits commented on OFBIZ-10900:
--

Thanks to all for collaborating on this ticket.

> Agreement overview does not show names of parties
> -
>
> Key: OFBIZ-10900
> URL: https://issues.apache.org/jira/browse/OFBIZ-10900
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
>  Labels: agreements
> Fix For: 17.12.01, 16.11.06, Upcoming Branch, 18.12.01
>
> Attachments: OFBIZ-10900.patch
>
>
> See: 
>  * [https://demo-stable.ofbiz.apache.org/accounting/control/FindAgreement]
>  * [https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement]
> While the individual agreements (e.g. 
> [https://demo-stable.ofbiz.apache.org/accounting/control/EditAgreement?agreementId=8000)]
>  shows the names of the parties involved, the overview does not



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11121) Order status history should show party id instead of login id .

2019-06-22 Thread Ashish Kumar Pandey (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Kumar Pandey updated OFBIZ-11121:

Affects Version/s: (was: 17.12.01)
   Release Branch 17.12
   Release Branch 16.11

> Order status history should show  party id instead of login id .
> 
>
> Key: OFBIZ-11121
> URL: https://issues.apache.org/jira/browse/OFBIZ-11121
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Kumar Pandey
>Assignee: Ashish Kumar Pandey
>Priority: Minor
> Attachments: orderStatus.png
>
>
> Order status history  is showing login id which is not correct instead it 
> should show the partyId



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10900) Agreement overview does not show names of parties

2019-06-22 Thread Pierre Smits (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10900:
-
Labels: agreements  (was: )

> Agreement overview does not show names of parties
> -
>
> Key: OFBIZ-10900
> URL: https://issues.apache.org/jira/browse/OFBIZ-10900
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
>  Labels: agreements
> Fix For: 17.12.01, 16.11.06, Upcoming Branch, 18.12.01
>
> Attachments: OFBIZ-10900.patch
>
>
> See: 
>  * [https://demo-stable.ofbiz.apache.org/accounting/control/FindAgreement]
>  * [https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement]
> While the individual agreements (e.g. 
> [https://demo-stable.ofbiz.apache.org/accounting/control/EditAgreement?agreementId=8000)]
>  shows the names of the parties involved, the overview does not



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10581) While registering for new customer, In phone numbers section input type is not defined.

2019-06-22 Thread Rohit Hukkeri (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870257#comment-16870257
 ] 

Rohit Hukkeri commented on OFBIZ-10581:
---

Hello,

I don't found any issue with the data type of phone number.IMO it is the 
conceptual level thing rather than code level improvement.

I think this ticket needs to be closed.

Regards 

Rohit Hukkeri

> While registering for new customer, In phone numbers section input type is 
> not defined. 
> 
>
> Key: OFBIZ-10581
> URL: https://issues.apache.org/jira/browse/OFBIZ-10581
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Rajat Temaniya
>Priority: Major
> Attachments: Screen Shot 2018-09-22 at 4.13.40 PM.png
>
>
> Follow the process to find this issue:
> 1) Go to this link [ 
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/newcustomer] ].
>  2) Fill the required information about user.
>  3) Go to the phone number section in the input box it must be type 
> restricted now it is taking string and number both.
>    Improvement required: Input type, Length or placeholder 
> Issue:- Right now its taking any type without verifying.
> Please find attachment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11122) FTL Error on Order Entry Payment screen

2019-06-22 Thread Shikha Jaiswal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shikha Jaiswal updated OFBIZ-11122:
---
Attachment: Screenshot - Order Entry Payment.png

> FTL Error on Order Entry Payment screen
> ---
>
> Key: OFBIZ-11122
> URL: https://issues.apache.org/jira/browse/OFBIZ-11122
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11
>Reporter: Shikha Jaiswal
>Priority: Minor
> Attachments: Screenshot - Order Entry Payment.png
>
>
> *Steps to regenerate:*
> # Open 
> [https://demo-stable.ofbiz.apache.org/ordermgr/control/orderentry|https://demo-stable.ofbiz.apache.org/ordermgr/control/orderentry]
> # Set Customer
> # Add product to cart
> # Click on Finalize Order
> # Select Shipping address and method
> # Select Term and click on Continue
> # FTL error renders. 
> Refer attachment



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11122) FTL Error on Order Entry Payment screen

2019-06-22 Thread Shikha Jaiswal (JIRA)
Shikha Jaiswal created OFBIZ-11122:
--

 Summary: FTL Error on Order Entry Payment screen
 Key: OFBIZ-11122
 URL: https://issues.apache.org/jira/browse/OFBIZ-11122
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 16.11
Reporter: Shikha Jaiswal


*Steps to regenerate:*
# Open 
[https://demo-stable.ofbiz.apache.org/ordermgr/control/orderentry|https://demo-stable.ofbiz.apache.org/ordermgr/control/orderentry]
# Set Customer
# Add product to cart
# Click on Finalize Order
# Select Shipping address and method
# Select Term and click on Continue
# FTL error renders. 

Refer attachment



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-06-22 Thread Lalit Dashora (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora updated OFBIZ-11105:
--
Affects Version/s: (was: Upcoming Branch)
   Release Branch 18.12

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
> Attachments: OFBIZ-11105.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10844) Ecommerce AnonContactus.ftl doesn't work

2019-06-22 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-10844.
---

Thanks, Schumann Ye for reporting and Suraj Khurana and Jacques Le Roux for the 
review.

> Ecommerce AnonContactus.ftl doesn't work
> 
>
> Key: OFBIZ-10844
> URL: https://issues.apache.org/jira/browse/OFBIZ-10844
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
> Environment: Win10 + OFBiz 16.11.04 + mysql.
>Reporter: Schumann Ye
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: 17.12.01, 16.11.06, Upcoming Branch, 18.12.01
>
> Attachments: OFBIZ-10844.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Ecommerce "Contact Us" with anonymous login doesn't work after filling in 
> email and all necessary info.
> The root cause is the simple method "sendContactUsEmailToCompany" within
> the file 
> \applications\party\minilang\communication\CommunicationEventServices.xml has 
> defined the field "sendFrom" as inputted email address from the anonymous 
> users. 
> To fix it, it should be changed as follows:
> 
> While the email "yourmailaddr...@example.com" should have been properly set 
> up in your system.
> It works for me!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10883) Picklist is in Input status even after order is completed

2019-06-22 Thread Shikha Jaiswal (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870252#comment-16870252
 ] 

Shikha Jaiswal commented on OFBIZ-10883:


Hi Suraj,

I have attached the updated patch.

> Picklist is in Input status even after order is completed
> -
>
> Key: OFBIZ-10883
> URL: https://issues.apache.org/jira/browse/OFBIZ-10883
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 16.11
>Reporter: Rashi Dhagat
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10883-new.patch, OFBIZ-10883.patch, 
> OrderStatus.jpg, PicklistStatus.jpg
>
>
> Steps to regenerate:
> 1. Open https://demo-stable.ofbiz.apache.org/ordermgr/control/main
> 2. Create order
> 3. Open 
> https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse
> 4. Create Picking
> 5. Click on Packing under the facility
> 6. Enter order id and click on pack order
> 7. Enter package detail and complete packaging
> 8. Open 
> https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse
> Actual: Picklist is in the input status  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10883) Picklist is in Input status even after order is completed

2019-06-22 Thread Shikha Jaiswal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shikha Jaiswal updated OFBIZ-10883:
---
Attachment: OFBIZ-10883-new.patch

> Picklist is in Input status even after order is completed
> -
>
> Key: OFBIZ-10883
> URL: https://issues.apache.org/jira/browse/OFBIZ-10883
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 16.11
>Reporter: Rashi Dhagat
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10883-new.patch, OFBIZ-10883.patch, 
> OrderStatus.jpg, PicklistStatus.jpg
>
>
> Steps to regenerate:
> 1. Open https://demo-stable.ofbiz.apache.org/ordermgr/control/main
> 2. Create order
> 3. Open 
> https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse
> 4. Create Picking
> 5. Click on Packing under the facility
> 6. Enter order id and click on pack order
> 7. Enter package detail and complete packaging
> 8. Open 
> https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse
> Actual: Picklist is in the input status  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10739) Request details is overlapping with language and cart summary

2019-06-22 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10739.
-

Thanks Ashish Sharma for reporting and Ashish Kumar Pandey for providing the 
patch.

> Request details is overlapping with language and cart summary
> -
>
> Key: OFBIZ-10739
> URL: https://issues.apache.org/jira/browse/OFBIZ-10739
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Ashish Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10739.patch, Screen Shot 2018-12-22 at 12.39.49 
> PM.png
>
>
> *Step to reproduce*
> Login with valid username and password.
> Navigate to request tab
> *Expected result:* Request details should be properly aligned.
> *Actual result:*  Request details is overlapping with language and cart 
> summary.
>  
> Screen print attached



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-06-22 Thread Lalit Dashora (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870251#comment-16870251
 ] 

Lalit Dashora commented on OFBIZ-11105:
---

Hi,

I have done all the improvements related to the usage of inputParamEnumId and 
customMethodId in promotion management. Please find the attached patch. Here is 
the parent ticket OFBIZ-10370.

Thanks!

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
> Attachments: OFBIZ-11105.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-06-22 Thread Lalit Dashora (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora updated OFBIZ-11105:
--
Attachment: OFBIZ-11105.patch

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
> Attachments: OFBIZ-11105.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11121) Order status history should show party id instead of login id .

2019-06-22 Thread Ashish Kumar Pandey (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Kumar Pandey updated OFBIZ-11121:

Attachment: orderStatus.png

> Order status history should show  party id instead of login id .
> 
>
> Key: OFBIZ-11121
> URL: https://issues.apache.org/jira/browse/OFBIZ-11121
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: 17.12.01
>Reporter: Ashish Kumar Pandey
>Priority: Minor
> Attachments: orderStatus.png
>
>
> Order status history  is showing login id which is not correct instead it 
> should show the partyId



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11121) Order status history should show party id instead of login id .

2019-06-22 Thread Ashish Kumar Pandey (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Kumar Pandey reassigned OFBIZ-11121:
---

Assignee: Ashish Kumar Pandey

> Order status history should show  party id instead of login id .
> 
>
> Key: OFBIZ-11121
> URL: https://issues.apache.org/jira/browse/OFBIZ-11121
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: 17.12.01
>Reporter: Ashish Kumar Pandey
>Assignee: Ashish Kumar Pandey
>Priority: Minor
> Attachments: orderStatus.png
>
>
> Order status history  is showing login id which is not correct instead it 
> should show the partyId



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11121) Order status history should show party id instead of login id .

2019-06-22 Thread Ashish Kumar Pandey (JIRA)
Ashish Kumar Pandey created OFBIZ-11121:
---

 Summary: Order status history should show  party id instead of 
login id .
 Key: OFBIZ-11121
 URL: https://issues.apache.org/jira/browse/OFBIZ-11121
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: 17.12.01
Reporter: Ashish Kumar Pandey


Order status history  is showing login id which is not correct instead it 
should show the partyId



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11105) Add backward compatibility for inputParamEnumId in promotion management

2019-06-22 Thread Lalit Dashora (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lalit Dashora updated OFBIZ-11105:
--
Affects Version/s: Upcoming Branch

> Add backward compatibility for inputParamEnumId in promotion management
> ---
>
> Key: OFBIZ-11105
> URL: https://issues.apache.org/jira/browse/OFBIZ-11105
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-8939) Unit test case for service - CheckCreateStockRequirementQoh

2019-06-22 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-8939.


Thanks Avnindra Sharma for reporting the ticket and Anushi Gupta for providing 
the updated patch.

> Unit test case for service - CheckCreateStockRequirementQoh
> ---
>
> Key: OFBIZ-8939
> URL: https://issues.apache.org/jira/browse/OFBIZ-8939
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8939.patch, OFBIZ-8939.patch
>
>
> Unit test case for service - CheckCreateStockRequirementQoh



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11110) Able to add phone no. as contact type without adding number

2019-06-22 Thread Pradeep Choudhary (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary reassigned OFBIZ-0:
-

Assignee: (was: Pradeep Choudhary)

> Able to add phone no. as contact type without adding number
> ---
>
> Key: OFBIZ-0
> URL: https://issues.apache.org/jira/browse/OFBIZ-0
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Rashi Dhagat
>Priority: Major
> Attachments: HC-0.patch
>
>
> Steps to regenerate:
>  # Open url 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile]
>  # Click on "Create new" in Contact Information section
>  # Select phone no as contact type
>  # Click on Create
>  # Click on Save
> Actual: Able to add phone no as contact type without adding no.
> Expected: Error message should be displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7257) View Image button on order detail page is not working

2019-06-22 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam closed OFBIZ-7257.
---

Thanks, Avnindra Sharma for reporting the original issue, Devanshu Vyas for 
providing the patch and Jacques for review and suggestions.

> View Image button on order detail page is not working
> -
>
> Key: OFBIZ-7257
> URL: https://issues.apache.org/jira/browse/OFBIZ-7257
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7257.patch, OFBIZ-7257.patch, OFBIZ-7257.patch
>
>
> Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-7257) View Image button on order detail page is not working

2019-06-22 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam resolved OFBIZ-7257.
-
Resolution: Implemented

> View Image button on order detail page is not working
> -
>
> Key: OFBIZ-7257
> URL: https://issues.apache.org/jira/browse/OFBIZ-7257
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7257.patch, OFBIZ-7257.patch, OFBIZ-7257.patch
>
>
> Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7257) View Image button on order detail page is not working

2019-06-22 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-7257:

Fix Version/s: Upcoming Branch

> View Image button on order detail page is not working
> -
>
> Key: OFBIZ-7257
> URL: https://issues.apache.org/jira/browse/OFBIZ-7257
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Deepak Nigam
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7257.patch, OFBIZ-7257.patch, OFBIZ-7257.patch
>
>
> Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number

2019-06-22 Thread Pradeep Choudhary (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870242#comment-16870242
 ] 

Pradeep Choudhary commented on OFBIZ-0:
---

Overrided 'contactNumber' field in 'updatePartyTelecomNumber' and 
'updateTelecomNumber' service and marked optional="false". It will validate the 
empty contact number values and prevent user to add empty values for Telecom 
Number form.

 

Added patch for the same.

> Able to add phone no. as contact type without adding number
> ---
>
> Key: OFBIZ-0
> URL: https://issues.apache.org/jira/browse/OFBIZ-0
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Rashi Dhagat
>Assignee: Pradeep Choudhary
>Priority: Major
> Attachments: HC-0.patch
>
>
> Steps to regenerate:
>  # Open url 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile]
>  # Click on "Create new" in Contact Information section
>  # Select phone no as contact type
>  # Click on Create
>  # Click on Save
> Actual: Able to add phone no as contact type without adding no.
> Expected: Error message should be displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7257) View Image button on order detail page is not working

2019-06-22 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam updated OFBIZ-7257:

Affects Version/s: Trunk

> View Image button on order detail page is not working
> -
>
> Key: OFBIZ-7257
> URL: https://issues.apache.org/jira/browse/OFBIZ-7257
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Deepak Nigam
>Priority: Major
> Attachments: OFBIZ-7257.patch, OFBIZ-7257.patch, OFBIZ-7257.patch
>
>
> Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7257) View Image button on order detail page is not working

2019-06-22 Thread Deepak Nigam (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870241#comment-16870241
 ] 

Deepak Nigam commented on OFBIZ-7257:
-

Implemented: The feature where a user will be able to add different types of 
content(image, document, URL, etc.) to an order.

Committed at -r1861853 in the trunk.

> View Image button on order detail page is not working
> -
>
> Key: OFBIZ-7257
> URL: https://issues.apache.org/jira/browse/OFBIZ-7257
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Avnindra Sharma
>Assignee: Deepak Nigam
>Priority: Major
> Attachments: OFBIZ-7257.patch, OFBIZ-7257.patch, OFBIZ-7257.patch
>
>
> Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10844) Ecommerce AnonContactus.ftl doesn't work

2019-06-22 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870239#comment-16870239
 ] 

Pawan Verma commented on OFBIZ-10844:
-

Hi [~suraj.khurana],

Yeah, I would love to. Thanks!

> Ecommerce AnonContactus.ftl doesn't work
> 
>
> Key: OFBIZ-10844
> URL: https://issues.apache.org/jira/browse/OFBIZ-10844
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
> Environment: Win10 + OFBiz 16.11.04 + mysql.
>Reporter: Schumann Ye
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10844.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Ecommerce "Contact Us" with anonymous login doesn't work after filling in 
> email and all necessary info.
> The root cause is the simple method "sendContactUsEmailToCompany" within
> the file 
> \applications\party\minilang\communication\CommunicationEventServices.xml has 
> defined the field "sendFrom" as inputted email address from the anonymous 
> users. 
> To fix it, it should be changed as follows:
> 
> While the email "yourmailaddr...@example.com" should have been properly set 
> up in your system.
> It works for me!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10858) Last Categories section is blank

2019-06-22 Thread Priya Sharma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870238#comment-16870238
 ] 

Priya Sharma commented on OFBIZ-10858:
--

Though it is interesting to note that I am unable to map this behavior on 
[https://demo-stable.ofbiz.apache.org/ecommerce|https://demo-stable.ofbiz.apache.org/ecommerce/]

The above-mentioned categories never appear in the last search categories 
section. This also raises the question as to which behavior is desired.

Please provide your views.

> Last Categories section is blank 
> -
>
> Key: OFBIZ-10858
> URL: https://issues.apache.org/jira/browse/OFBIZ-10858
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: 16.11.05
>Reporter: Rashi Dhagat
>Assignee: Priya Sharma
>Priority: Major
> Attachments: LastCategories1.jpg, LastCategoriesRefreshed.jpg, 
> LastCategories_1strow.jpg, OFBIZ-10858.patch
>
>
> Issue 1:
> 1. Open [https://demo-trunk.ofbiz.apache.org/ecomseo]
> 2. Click on a category from the Categories section
> 3. Refresh the page
> *Actual:*
> 1. Last Categories is blank
> 2. If we refresh the page then only the search category visible with the last 
> row blank with a bullet.
> Issue 1:
> 1. Open [https://demo-trunk.ofbiz.apache.org/ecomseo]
> 2. Click on a category from the Categories section
> 3. Again, open the [https://demo-trunk.ofbiz.apache.org/ecomseo] in the new 
> tab
> *Actual:* 1st row is blank with searched categories



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10844) Ecommerce AnonContactus.ftl doesn't work

2019-06-22 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-10844:
---

Assignee: Pawan Verma  (was: Suraj Khurana)

> Ecommerce AnonContactus.ftl doesn't work
> 
>
> Key: OFBIZ-10844
> URL: https://issues.apache.org/jira/browse/OFBIZ-10844
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
> Environment: Win10 + OFBiz 16.11.04 + mysql.
>Reporter: Schumann Ye
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10844.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Ecommerce "Contact Us" with anonymous login doesn't work after filling in 
> email and all necessary info.
> The root cause is the simple method "sendContactUsEmailToCompany" within
> the file 
> \applications\party\minilang\communication\CommunicationEventServices.xml has 
> defined the field "sendFrom" as inputted email address from the anonymous 
> users. 
> To fix it, it should be changed as follows:
> 
> While the email "yourmailaddr...@example.com" should have been properly set 
> up in your system.
> It works for me!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11112) Error message not properly displayed while adding postal address

2019-06-22 Thread Shubham Choudhary (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shubham Choudhary reassigned OFBIZ-2:
-

Assignee: Shubham Choudhary

> Error message not properly displayed while adding postal address
> 
>
> Key: OFBIZ-2
> URL: https://issues.apache.org/jira/browse/OFBIZ-2
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Rashi Dhagat
>Assignee: Shubham Choudhary
>Priority: Minor
> Attachments: PostalAddressError.png
>
>
> Steps to regenerate:
>  # Open url 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile]
>  # Click on "Create new" in Contact Information section
>  # Select postal address as contact type
>  # Click on Create
>  # Click on Save
> Actual: Error message is not properly visible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11110) Able to add phone no. as contact type without adding number

2019-06-22 Thread Pradeep Choudhary (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Choudhary updated OFBIZ-0:
--
Attachment: HC-0.patch

> Able to add phone no. as contact type without adding number
> ---
>
> Key: OFBIZ-0
> URL: https://issues.apache.org/jira/browse/OFBIZ-0
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
>Reporter: Rashi Dhagat
>Assignee: Pradeep Choudhary
>Priority: Major
> Attachments: HC-0.patch
>
>
> Steps to regenerate:
>  # Open url 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile]
>  # Click on "Create new" in Contact Information section
>  # Select phone no as contact type
>  # Click on Create
>  # Click on Save
> Actual: Able to add phone no as contact type without adding no.
> Expected: Error message should be displayed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10900) Agreement overview does not show names of parties

2019-06-22 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-10900.
---

> Agreement overview does not show names of parties
> -
>
> Key: OFBIZ-10900
> URL: https://issues.apache.org/jira/browse/OFBIZ-10900
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 17.12.01, 16.11.06, Upcoming Branch, 18.12.01
>
> Attachments: OFBIZ-10900.patch
>
>
> See: 
>  * [https://demo-stable.ofbiz.apache.org/accounting/control/FindAgreement]
>  * [https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement]
> While the individual agreements (e.g. 
> [https://demo-stable.ofbiz.apache.org/accounting/control/EditAgreement?agreementId=8000)]
>  shows the names of the parties involved, the overview does not



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10844) Ecommerce AnonContactus.ftl doesn't work

2019-06-22 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870235#comment-16870235
 ] 

Suraj Khurana commented on OFBIZ-10844:
---

Hi [~pawan.verma],

Would you like to take it to the repo, as now you are also a committer. :)

Cheers !!

> Ecommerce AnonContactus.ftl doesn't work
> 
>
> Key: OFBIZ-10844
> URL: https://issues.apache.org/jira/browse/OFBIZ-10844
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
> Environment: Win10 + OFBiz 16.11.04 + mysql.
>Reporter: Schumann Ye
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10844.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Ecommerce "Contact Us" with anonymous login doesn't work after filling in 
> email and all necessary info.
> The root cause is the simple method "sendContactUsEmailToCompany" within
> the file 
> \applications\party\minilang\communication\CommunicationEventServices.xml has 
> defined the field "sendFrom" as inputted email address from the anonymous 
> users. 
> To fix it, it should be changed as follows:
> 
> While the email "yourmailaddr...@example.com" should have been properly set 
> up in your system.
> It works for me!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10489) Unnecessary ship groups in orders

2019-06-22 Thread Mohammad Kathawala (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870233#comment-16870233
 ] 

Mohammad Kathawala commented on OFBIZ-10489:


The issue is generated because of the code committed in the patch from the 
ticket https://issues.apache.org/jira/browse/OFBIZ-5416. Here the code was 
properly handled in _ShoppingCartEvents.java_ but not in 
_ShoppingCartHelper.java._

Did the same handling in _ShoppingCartHelper.java_  in the patch 
*OFBIZ-10489.patch*.

> Unnecessary ship groups in orders
> -
>
> Key: OFBIZ-10489
> URL: https://issues.apache.org/jira/browse/OFBIZ-10489
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Oleg Andreyev
>Assignee: Mohammad Kathawala
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10489.patch, empty_ship_group.diff
>
>
> Under some conditions, checkout creates extra ship groups in the order.
> Steps to reproduce:
>  # create a couple of products P1 and P2 (just to get clear results).
>  # create a new order and add 1 P1 and 1 P2
>  # change quantity P1 to 2 (or both) and Recalculate Order (key step really)
>  # finish checkout
> You will see 2 order items linked with ship group 1 and another ship 
> group 2 that should not have been created. You may see in the patch that 
> the code address a ship group using index of the order item and the shopping 
> cart creates new ship group if the index is greater than the number of 
> existing groups. 
> In one of my projects based on 16.11, I noticed even more serious trouble 
> that takes place if both products are drop-shipping order but don't explain 
> it here because it seems do not appear in the trunk.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10489) Unnecessary ship groups in orders

2019-06-22 Thread Mohammad Kathawala (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Kathawala updated OFBIZ-10489:
---
Attachment: OFBIZ-10489.patch

> Unnecessary ship groups in orders
> -
>
> Key: OFBIZ-10489
> URL: https://issues.apache.org/jira/browse/OFBIZ-10489
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Oleg Andreyev
>Assignee: Mohammad Kathawala
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10489.patch, empty_ship_group.diff
>
>
> Under some conditions, checkout creates extra ship groups in the order.
> Steps to reproduce:
>  # create a couple of products P1 and P2 (just to get clear results).
>  # create a new order and add 1 P1 and 1 P2
>  # change quantity P1 to 2 (or both) and Recalculate Order (key step really)
>  # finish checkout
> You will see 2 order items linked with ship group 1 and another ship 
> group 2 that should not have been created. You may see in the patch that 
> the code address a ship group using index of the order item and the shopping 
> cart creates new ship group if the index is greater than the number of 
> existing groups. 
> In one of my projects based on 16.11, I noticed even more serious trouble 
> that takes place if both products are drop-shipping order but don't explain 
> it here because it seems do not appear in the trunk.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10900) Agreement overview does not show names of parties

2019-06-22 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-10900:
---

Assignee: Pawan Verma

> Agreement overview does not show names of parties
> -
>
> Key: OFBIZ-10900
> URL: https://issues.apache.org/jira/browse/OFBIZ-10900
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10900.patch
>
>
> See: 
>  * [https://demo-stable.ofbiz.apache.org/accounting/control/FindAgreement]
>  * [https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement]
> While the individual agreements (e.g. 
> [https://demo-stable.ofbiz.apache.org/accounting/control/EditAgreement?agreementId=8000)]
>  shows the names of the parties involved, the overview does not



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10900) Agreement overview does not show names of parties

2019-06-22 Thread Akash Jain (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain reassigned OFBIZ-10900:
--

Assignee: (was: Pawan Verma)

> Agreement overview does not show names of parties
> -
>
> Key: OFBIZ-10900
> URL: https://issues.apache.org/jira/browse/OFBIZ-10900
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Pierre Smits
>Priority: Major
> Attachments: OFBIZ-10900.patch
>
>
> See: 
>  * [https://demo-stable.ofbiz.apache.org/accounting/control/FindAgreement]
>  * [https://demo-trunk.ofbiz.apache.org/accounting/control/FindAgreement]
> While the individual agreements (e.g. 
> [https://demo-stable.ofbiz.apache.org/accounting/control/EditAgreement?agreementId=8000)]
>  shows the names of the parties involved, the overview does not



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11115) Production Run Job is not created for product type MARKETING_PKG_AUTO

2019-06-22 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-5:
---

Assignee: Pawan Verma

> Production Run Job is not created for product type MARKETING_PKG_AUTO
> -
>
> Key: OFBIZ-5
> URL: https://issues.apache.org/jira/browse/OFBIZ-5
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Shikha Jaiswal
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-5-16.11.patch, OFBIZ-5.patch
>
>
> *Steps to regenerate:*
> # Create the order for product GZ-BASKET
> # Job should be created automatically for this product as it is of type 
> MARKETING_PKG_AUTO
> *Actual:*
> Job is not created and the order goes in the backorder status.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11117) Create New Shipment screen should have Create button instead of Update button

2019-06-22 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-7:

Affects Version/s: Trunk

> Create New Shipment screen should have Create button instead of Update button
> -
>
> Key: OFBIZ-7
> URL: https://issues.apache.org/jira/browse/OFBIZ-7
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Chandrashekhar Dhakad
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: CreateNewShipmentButton.png, OFBIZ-7.patch
>
>
> *Steps to regenerate:*
> 1) Login to facility component 
> ([https://demo-trunk.ofbiz.apache.org/facility/control/main]).
> 2) Navigate to Shipments screen 
> ([https://demo-trunk.ofbiz.apache.org/facility/control/FindShipment]).
> 3) Click on New Shipment button to create a new Shipment.
> 4) New Shipment screen is having the Update button instead of Create button.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-11117) Create New Shipment screen should have Create button instead of Update button

2019-06-22 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-7.
---

Thanks: Chandrashekhar Dhakad for your contribution.

> Create New Shipment screen should have Create button instead of Update button
> -
>
> Key: OFBIZ-7
> URL: https://issues.apache.org/jira/browse/OFBIZ-7
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Chandrashekhar Dhakad
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: CreateNewShipmentButton.png, OFBIZ-7.patch
>
>
> *Steps to regenerate:*
> 1) Login to facility component 
> ([https://demo-trunk.ofbiz.apache.org/facility/control/main]).
> 2) Navigate to Shipments screen 
> ([https://demo-trunk.ofbiz.apache.org/facility/control/FindShipment]).
> 3) Click on New Shipment button to create a new Shipment.
> 4) New Shipment screen is having the Update button instead of Create button.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10903) Make Gradle createPlugin task reflect the actual file/folder structure

2019-06-22 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-10903:

Affects Version/s: Release Branch 18.12
   Trunk

> Make Gradle createPlugin task reflect the actual file/folder structure
> --
>
> Key: OFBIZ-10903
> URL: https://issues.apache.org/jira/browse/OFBIZ-10903
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Gradle
>Affects Versions: Trunk, Release Branch 18.12
>Reporter: Michael Brohl
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch, 18.12.01
>
> Attachments: OFBIZ-10903.patch
>
>
> Just recognized that at least the groovyScripts folder is still named 
> "script". Have to check if there is anything else mising or has to be 
> corrected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10903) Make Gradle createPlugin task reflect the actual file/folder structure

2019-06-22 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-10903:

Fix Version/s: (was: Release Branch 18.12)
   18.12.01

> Make Gradle createPlugin task reflect the actual file/folder structure
> --
>
> Key: OFBIZ-10903
> URL: https://issues.apache.org/jira/browse/OFBIZ-10903
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Gradle
>Reporter: Michael Brohl
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch, 18.12.01
>
> Attachments: OFBIZ-10903.patch
>
>
> Just recognized that at least the groovyScripts folder is still named 
> "script". Have to check if there is anything else mising or has to be 
> corrected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10903) Make Gradle createPlugin task reflect the actual file/folder structure

2019-06-22 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-10903:

Fix Version/s: Release Branch 18.12

> Make Gradle createPlugin task reflect the actual file/folder structure
> --
>
> Key: OFBIZ-10903
> URL: https://issues.apache.org/jira/browse/OFBIZ-10903
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Gradle
>Reporter: Michael Brohl
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch, Release Branch 18.12
>
> Attachments: OFBIZ-10903.patch
>
>
> Just recognized that at least the groovyScripts folder is still named 
> "script". Have to check if there is anything else mising or has to be 
> corrected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10966) JSON entity data import and export utility

2019-06-22 Thread Jayansh Shinde (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870213#comment-16870213
 ] 

Jayansh Shinde commented on OFBIZ-10966:


I have attached a patch for same!!!

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-11109) Getting an error while creating event from SFA without providing event name

2019-06-22 Thread Mridul Pathak (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mridul Pathak closed OFBIZ-11109.
-

Thanks [~harman.kaur] for reporting and [~aditi17] for providing the patch.

> Getting an error while creating event from SFA without providing event name
> ---
>
> Key: OFBIZ-11109
> URL: https://issues.apache.org/jira/browse/OFBIZ-11109
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Harman kaur Matharu
>Assignee: Mridul Pathak
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-11109.patch, Screenshot from 2019-06-22 
> 11-43-54.png
>
>
>  Steps-
> 1) Navigate to SFA than events.
> 2) Click on create button.
> 3) Enter only Party Id and proceed to Create Event.
> Expected: Event should be successfully created.
> Actual: Error message gets displayed, which does not make any sense to the 
> system user. 
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10960) UI fix on Party Manager screen

2019-06-22 Thread Sasikant Biswal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sasikant Biswal reassigned OFBIZ-10960:
---

Assignee: Sasikant Biswal

> UI fix on Party Manager screen
> --
>
> Key: OFBIZ-10960
> URL: https://issues.apache.org/jira/browse/OFBIZ-10960
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Sourabh Punyani
>Assignee: Sasikant Biswal
>Priority: Trivial
> Attachments: Image1.png
>
>
> Separators should not be there before first menu item on Find Party.
> https://demo-trunk.ofbiz.apache.org/partymgr/control/main?externalLoginKey=EL0b278ddf-49af-43f8-adec-cc3c81d75bee
> Please refer attachment Image1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-11109) Getting an error while creating event from SFA without providing event name

2019-06-22 Thread Mridul Pathak (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mridul Pathak resolved OFBIZ-11109.
---
   Resolution: Fixed
Fix Version/s: 18.12.01
   16.11.06
   17.12.01

Fixed in trunk r1861838, 18.12 r1861842, 17.12 r1861843, 16.11 r1861844.

> Getting an error while creating event from SFA without providing event name
> ---
>
> Key: OFBIZ-11109
> URL: https://issues.apache.org/jira/browse/OFBIZ-11109
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Harman kaur Matharu
>Assignee: Mridul Pathak
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-11109.patch, Screenshot from 2019-06-22 
> 11-43-54.png
>
>
>  Steps-
> 1) Navigate to SFA than events.
> 2) Click on create button.
> 3) Enter only Party Id and proceed to Create Event.
> Expected: Event should be successfully created.
> Actual: Error message gets displayed, which does not make any sense to the 
> system user. 
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11115) Production Run Job is not created for product type MARKETING_PKG_AUTO

2019-06-22 Thread Shikha Jaiswal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shikha Jaiswal reassigned OFBIZ-5:
--

Assignee: (was: Shikha Jaiswal)

> Production Run Job is not created for product type MARKETING_PKG_AUTO
> -
>
> Key: OFBIZ-5
> URL: https://issues.apache.org/jira/browse/OFBIZ-5
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Shikha Jaiswal
>Priority: Major
> Attachments: OFBIZ-5-16.11.patch, OFBIZ-5.patch
>
>
> *Steps to regenerate:*
> # Create the order for product GZ-BASKET
> # Job should be created automatically for this product as it is of type 
> MARKETING_PKG_AUTO
> *Actual:*
> Job is not created and the order goes in the backorder status.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9093) Unit test case for service - createPaymentContent

2019-06-22 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-9093:


Assignee: Suraj Khurana  (was: Yogesh Naroliya)

> Unit test case for service -  createPaymentContent
> --
>
> Key: OFBIZ-9093
> URL: https://issues.apache.org/jira/browse/OFBIZ-9093
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-9093.patch, OFBIZ-9093.patch
>
>
> Unit test case for service -  createPaymentContent



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11115) Production Run Job is not created for product type MARKETING_PKG_AUTO

2019-06-22 Thread Shikha Jaiswal (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shikha Jaiswal updated OFBIZ-5:
---
Attachment: OFBIZ-5-16.11.patch
OFBIZ-5.patch

> Production Run Job is not created for product type MARKETING_PKG_AUTO
> -
>
> Key: OFBIZ-5
> URL: https://issues.apache.org/jira/browse/OFBIZ-5
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Shikha Jaiswal
>Assignee: Shikha Jaiswal
>Priority: Major
> Attachments: OFBIZ-5-16.11.patch, OFBIZ-5.patch
>
>
> *Steps to regenerate:*
> # Create the order for product GZ-BASKET
> # Job should be created automatically for this product as it is of type 
> MARKETING_PKG_AUTO
> *Actual:*
> Job is not created and the order goes in the backorder status.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11115) Production Run Job is not created for product type MARKETING_PKG_AUTO

2019-06-22 Thread Shikha Jaiswal (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870209#comment-16870209
 ] 

Shikha Jaiswal commented on OFBIZ-5:


For creating a job, createProductionRunForMktgPkg service runs which calculate 
the quantity to produce.

The condition qtyToProduce = qtyRequired.min(mktgPackagesAvailable) does not 
work for MARKETING_PKG_AUTO product as here qtyRequired is 
BigDecimal.ZERO.subtract(ATP of product) and mktgPackagesAvailable returned by 
service getMktgPackagesAvailable is ATP of product. So the above condition 
always returns the qtyToProduce as a negative value which does not allow to 
create production run.

In the present state of getMktgPackagesAvailable service, if product type is 
MARKETING_PKG_AUTO then return it's own ATP instead of returning its component 
ATP which causes this issue as earlier it was returning the component ATP.

I have provided the patch for a fix in which I have set qtyToProduce = 
qtyRequired in case of MARKETING_PKG_AUTO product so that it creates the 
production run for the order.


> Production Run Job is not created for product type MARKETING_PKG_AUTO
> -
>
> Key: OFBIZ-5
> URL: https://issues.apache.org/jira/browse/OFBIZ-5
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Shikha Jaiswal
>Assignee: Shikha Jaiswal
>Priority: Major
>
> *Steps to regenerate:*
> # Create the order for product GZ-BASKET
> # Job should be created automatically for this product as it is of type 
> MARKETING_PKG_AUTO
> *Actual:*
> Job is not created and the order goes in the backorder status.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11120) Issue while creating an order for product of type (Fixed) Asset Usage

2019-06-22 Thread Vedansh Tiwari (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vedansh Tiwari updated OFBIZ-11120:
---
 Attachment: ProductAO1.png
 ProductAO2.png
 ProductAO03.png
 ProductAO04.png
Description: 
Steps to regenerate
 # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem]
 # Click on the product lookup icon
 # Click on the "Find" button
 # Select the "(Fixed) Asset Usage" product  (FORKLIFT_PROPANE)
 # Click on "Add to order" button             

Actual: Error message "The following occurred: Enter Booking Information Before 
Adding to Cart" is showing. Please refer the attachment: ProductAO1.jpg

Expected: Error message should be corrected

 

Issue 2: 

Steps to regenerate:
 # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem]
 # Click on the product lookup icon
 # Click on the "Find" button
 # Select the "(Fixed) Asset Usage" product  (FORKLIFT_PROPANE)
 # Click on "Add to order" button 
 # Select the date and time
 # Click on the "Add to cart"
 # Again click on the product look-up for selecting the product.
              

 Actual: UI issue on the model. Please refer the attachment: ProductAO04

 

Note: please refer the attachment.

  was:
Steps to regenerate
 # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem]
 # Click on the product lookup icon
 # Click on the "Find" button
 # Select the "(Fixed) Asset Usage" product  (FORKLIFT_PROPANE)
 # Click on "Add to order" button             

Actual: Error message "The following occurred: Enter Booking Information Before 
Adding to Cart" is showing

Expected: Error message should be corrected

 

Issue 2: 

Steps to regenerate:
 # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem]
 # Click on the product lookup icon
 # Click on the "Find" button
 # Select the "(Fixed) Asset Usage" product  (FORKLIFT_PROPANE)
 # Click on "Add to order" button 
 # Select the date and time
 # Click on the "Add to cart"
 # Again click on the product look-up for selecting product.               

 


> Issue while creating an order for product of type (Fixed) Asset Usage
> -
>
> Key: OFBIZ-11120
> URL: https://issues.apache.org/jira/browse/OFBIZ-11120
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Vedansh Tiwari
>Priority: Major
> Fix For: Trunk, Release Branch 16.11
>
> Attachments: ProductAO03.png, ProductAO04.png, ProductAO1.png, 
> ProductAO2.png
>
>
> Steps to regenerate
>  # Login to URL: 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem]
>  # Click on the product lookup icon
>  # Click on the "Find" button
>  # Select the "(Fixed) Asset Usage" product  (FORKLIFT_PROPANE)
>  # Click on "Add to order" button             
> Actual: Error message "The following occurred: Enter Booking Information 
> Before Adding to Cart" is showing. Please refer the attachment: ProductAO1.jpg
> Expected: Error message should be corrected
>  
> Issue 2: 
> Steps to regenerate:
>  # Login to URL: 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem]
>  # Click on the product lookup icon
>  # Click on the "Find" button
>  # Select the "(Fixed) Asset Usage" product  (FORKLIFT_PROPANE)
>  # Click on "Add to order" button 
>  # Select the date and time
>  # Click on the "Add to cart"
>  # Again click on the product look-up for selecting the product.
>               
>  Actual: UI issue on the model. Please refer the attachment: ProductAO04
>  
> Note: please refer the attachment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9093) Unit test case for service - createPaymentContent

2019-06-22 Thread Yogesh Naroliya (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yogesh Naroliya updated OFBIZ-9093:
---
Attachment: OFBIZ-9093.patch

> Unit test case for service -  createPaymentContent
> --
>
> Key: OFBIZ-9093
> URL: https://issues.apache.org/jira/browse/OFBIZ-9093
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Yogesh Naroliya
>Priority: Minor
> Attachments: OFBIZ-9093.patch, OFBIZ-9093.patch
>
>
> Unit test case for service -  createPaymentContent



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9093) Unit test case for service - createPaymentContent

2019-06-22 Thread Yogesh Naroliya (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870208#comment-16870208
 ] 

Yogesh Naroliya commented on OFBIZ-9093:


Hello team,
I have updated patch for the unit test of *createPaymentContent* service from 
XML to DSL. 
Also verified the patch using the following command:
{code:java}
 ./gradlew "ofbiz --test component=accounting --test suitename=accountingests"
{code}
Please have a look and let me know in case of any concerns.
Thanks in advance !!

> Unit test case for service -  createPaymentContent
> --
>
> Key: OFBIZ-9093
> URL: https://issues.apache.org/jira/browse/OFBIZ-9093
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Yogesh Naroliya
>Priority: Minor
> Attachments: OFBIZ-9093.patch, OFBIZ-9093.patch
>
>
> Unit test case for service -  createPaymentContent



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10310) Issue with Status of invoice

2019-06-22 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10310.
-

Thanks Aayush Jain for reporting and Devanshu Vyas for providing the patch.

> Issue with Status of invoice
> 
>
> Key: OFBIZ-10310
> URL: https://issues.apache.org/jira/browse/OFBIZ-10310
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Aayush jain
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-10310.patch, OFBIZ-10310_InvoicePaidStatus.png
>
>
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/findInvoices
> 2. Navigate to view Invoice with Outstanding amount
> 3. Change the status to paid for Outstanding amount
> Actual Result: 
> The status will be change to paid with an error message "Cannot change status 
> to 'paid', invoice 8005 has an unapplied balance of 33.99"
> Expected Result:
> Status of invoice should not be allowed to be changed to paid for Invoice 
> with Outstanding amount. 
> I Think its a UI Issue. Thanks!  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10310) Issue with Status of invoice

2019-06-22 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana resolved OFBIZ-10310.
---
   Resolution: Fixed
Fix Version/s: 18.12.01
   16.11.06
   17.12.01

This has been committed to:
Trunk at rev #1861837

Release18.12 at rev# 1861839

Release17.12 at rev#1861840

Release16.11 at rev#1861841

> Issue with Status of invoice
> 
>
> Key: OFBIZ-10310
> URL: https://issues.apache.org/jira/browse/OFBIZ-10310
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Aayush jain
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-10310.patch, OFBIZ-10310_InvoicePaidStatus.png
>
>
> Steps:
> 1. Open URL 
> https://demo-trunk.ofbiz.apache.org/accounting/control/findInvoices
> 2. Navigate to view Invoice with Outstanding amount
> 3. Change the status to paid for Outstanding amount
> Actual Result: 
> The status will be change to paid with an error message "Cannot change status 
> to 'paid', invoice 8005 has an unapplied balance of 33.99"
> Expected Result:
> Status of invoice should not be allowed to be changed to paid for Invoice 
> with Outstanding amount. 
> I Think its a UI Issue. Thanks!  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10903) Make Gradle createPlugin task reflect the actual file/folder structure

2019-06-22 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870203#comment-16870203
 ] 

Pawan Verma commented on OFBIZ-10903:
-

I have also updated the tutorial document as well: 
[https://cwiki.apache.org/confluence/x/cQFk]

> Make Gradle createPlugin task reflect the actual file/folder structure
> --
>
> Key: OFBIZ-10903
> URL: https://issues.apache.org/jira/browse/OFBIZ-10903
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Gradle
>Reporter: Michael Brohl
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10903.patch
>
>
> Just recognized that at least the groovyScripts folder is still named 
> "script". Have to check if there is anything else mising or has to be 
> corrected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7610) Product Price set based on 'Purchase Price Agreement' isn't honored while same is used during ordering

2019-06-22 Thread Ankush Upadhyay (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870201#comment-16870201
 ] 

Ankush Upadhyay commented on OFBIZ-7610:


[~suraj.khurana],

Thanks for the patch review and yes it is better to add check inside the 
service. I have updated patch by incorporating suggested changes.

Please review it and let me know if this looks as expected and if we can commit 
it.

> Product Price set based on 'Purchase Price Agreement' isn't honored while 
> same is used during ordering
> --
>
> Key: OFBIZ-7610
> URL: https://issues.apache.org/jira/browse/OFBIZ-7610
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Swapnil Shah
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-7610.patch, SA_1.png, SA_2.png, SA_3.png, 
> SA_4.png, SA_5.png
>
>
> Once any Purchase Agreement is created with supplier for certain products at 
> pre-determined price, its get successfully transformed into SupplierProduct. 
> But at the time of Purchase order creation is same agreement is enforced then 
> agreement prices for products are ignored while setting the price on cart and 
> eventually on order itself.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11117) Create New Shipment screen should have Create button instead of Update button

2019-06-22 Thread Pawan Verma (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-7:
---

Assignee: Pawan Verma

> Create New Shipment screen should have Create button instead of Update button
> -
>
> Key: OFBIZ-7
> URL: https://issues.apache.org/jira/browse/OFBIZ-7
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Chandrashekhar Dhakad
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: CreateNewShipmentButton.png, OFBIZ-7.patch
>
>
> *Steps to regenerate:*
> 1) Login to facility component 
> ([https://demo-trunk.ofbiz.apache.org/facility/control/main]).
> 2) Navigate to Shipments screen 
> ([https://demo-trunk.ofbiz.apache.org/facility/control/FindShipment]).
> 3) Click on New Shipment button to create a new Shipment.
> 4) New Shipment screen is having the Update button instead of Create button.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7610) Product Price set based on 'Purchase Price Agreement' isn't honored while same is used during ordering

2019-06-22 Thread Ankush Upadhyay (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-7610:
---
Attachment: OFBIZ-7610.patch

> Product Price set based on 'Purchase Price Agreement' isn't honored while 
> same is used during ordering
> --
>
> Key: OFBIZ-7610
> URL: https://issues.apache.org/jira/browse/OFBIZ-7610
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Swapnil Shah
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-7610.patch, SA_1.png, SA_2.png, SA_3.png, 
> SA_4.png, SA_5.png
>
>
> Once any Purchase Agreement is created with supplier for certain products at 
> pre-determined price, its get successfully transformed into SupplierProduct. 
> But at the time of Purchase order creation is same agreement is enforced then 
> agreement prices for products are ignored while setting the price on cart and 
> eventually on order itself.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11120) Issue while creating an order for product of type (Fixed) Asset Usage

2019-06-22 Thread Vedansh Tiwari (JIRA)
Vedansh Tiwari created OFBIZ-11120:
--

 Summary: Issue while creating an order for product of type (Fixed) 
Asset Usage
 Key: OFBIZ-11120
 URL: https://issues.apache.org/jira/browse/OFBIZ-11120
 Project: OFBiz
  Issue Type: Bug
  Components: order
Reporter: Vedansh Tiwari
 Fix For: Release Branch 16.11, Trunk


Steps to regenerate
 # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem]
 # Click on the product lookup icon
 # Click on the "Find" button
 # Select the "(Fixed) Asset Usage" product  (FORKLIFT_PROPANE)
 # Click on "Add to order" button             

Actual: Error message "The following occurred: Enter Booking Information Before 
Adding to Cart" is showing

Expected: Error message should be corrected

 

Issue 2: 

Steps to regenerate:
 # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem]
 # Click on the product lookup icon
 # Click on the "Find" button
 # Select the "(Fixed) Asset Usage" product  (FORKLIFT_PROPANE)
 # Click on "Add to order" button 
 # Select the date and time
 # Click on the "Add to cart"
 # Again click on the product look-up for selecting product.               

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10966) JSON entity data import and export utility

2019-06-22 Thread Jayansh Shinde (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayansh Shinde updated OFBIZ-10966:
---
Attachment: OFBIZ-10966.patch

> JSON entity data import and export utility
> --
>
> Key: OFBIZ-10966
> URL: https://issues.apache.org/jira/browse/OFBIZ-10966
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Reporter: Jayansh Shinde
>Assignee: Jayansh Shinde
>Priority: Minor
> Attachments: OFBIZ-10966.patch
>
>
> Currently, we support import/export entity data in XML format.
>  Nowadays JSON is widely used in industry, we can have support for JSON 
> format which looks quite similar to XML support.
> Here is example of XML data and it's JSON version
> {code:java}
> 
> {code}
> {code:java}
> {“Party”: 
> {"partyId":"123456","partyTypeId":"PERSON","statusId":"PARTY_ENABLED”}}
> {code}
>  
> *Design Proposal*
> We can write *entityImportJson* and *entityImportDirJson* services for 
> importing JSON from screen and directory respectively.
> And the *entityExportAllJson* service for exporting entity data in JSON.
>  
> *Import Design*
>  The import service will perform following operations:
>  1.) Validate the input JSON data (I am in process of exploring the way for 
> this)
>  2.) On successful validation, convert JSON to OFBiz's entity model 
> (GenericValue)
>  3.) The GenericValue will be inserted in database by some handler class for 
> e.g we can write JsonDataHandler, it will convert given JSON to 
> List, and finally write it to database (Similar pattern is used 
> in XML import).
>  
> *Export Design*
>  Based on existing XML pattern the writeXmlText method of GenericEntity class 
> write the exported data in XML format. 
>  In the similar way, we can implement writeJsonText to export data in JSON 
> format.
> Please free feel to share your thought.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7610) Product Price set based on 'Purchase Price Agreement' isn't honored while same is used during ordering

2019-06-22 Thread Ankush Upadhyay (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankush Upadhyay updated OFBIZ-7610:
---
Attachment: (was: OFBIZ-7610.patch)

> Product Price set based on 'Purchase Price Agreement' isn't honored while 
> same is used during ordering
> --
>
> Key: OFBIZ-7610
> URL: https://issues.apache.org/jira/browse/OFBIZ-7610
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Swapnil Shah
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: SA_1.png, SA_2.png, SA_3.png, SA_4.png, SA_5.png
>
>
> Once any Purchase Agreement is created with supplier for certain products at 
> pre-determined price, its get successfully transformed into SupplierProduct. 
> But at the time of Purchase order creation is same agreement is enforced then 
> agreement prices for products are ignored while setting the price on cart and 
> eventually on order itself.
> Please refer to attached screenshot for reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11119) Sales By Store Report not working

2019-06-22 Thread Chandan Khandelwal (JIRA)
Chandan Khandelwal created OFBIZ-9:
--

 Summary: Sales By Store Report not working
 Key: OFBIZ-9
 URL: https://issues.apache.org/jira/browse/OFBIZ-9
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Trunk
Reporter: Chandan Khandelwal
Assignee: Chandan Khandelwal
 Attachments: SalesByStoreReport.png

Order > Reports >  Sales by Store Report (Select All Order Status)
 
The Following Errors Occurred:

Unable to transform FO file: org.apache.fop.apps.FOPException: 
org.xml.sax.SAXParseException; lineNumber: 31; columnNumber: 174; The content 
of elements must consist of well-formed character data or markup. 
javax.xml.transform.TransformerException: org.xml.sax.SAXParseException; 
lineNumber: 31; columnNumber: 174; The content of elements must consist of 
well-formed character data or markup.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11117) Create New Shipment screen should have Create button instead of Update button

2019-06-22 Thread Chandrashekhar Dhakad (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chandrashekhar Dhakad reassigned OFBIZ-7:
-

Assignee: (was: Chandrashekhar Dhakad)

> Create New Shipment screen should have Create button instead of Update button
> -
>
> Key: OFBIZ-7
> URL: https://issues.apache.org/jira/browse/OFBIZ-7
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Chandrashekhar Dhakad
>Priority: Minor
> Attachments: CreateNewShipmentButton.png, OFBIZ-7.patch
>
>
> *Steps to regenerate:*
> 1) Login to facility component 
> ([https://demo-trunk.ofbiz.apache.org/facility/control/main]).
> 2) Navigate to Shipments screen 
> ([https://demo-trunk.ofbiz.apache.org/facility/control/FindShipment]).
> 3) Click on New Shipment button to create a new Shipment.
> 4) New Shipment screen is having the Update button instead of Create button.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-11111) Unable to cancel the order

2019-06-22 Thread Komal Dayle (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Komal Dayle reassigned OFBIZ-1:
---

Assignee: Komal Dayle

> Unable to cancel the order
> --
>
> Key: OFBIZ-1
> URL: https://issues.apache.org/jira/browse/OFBIZ-1
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Ashish Sharma
>Assignee: Komal Dayle
>Priority: Major
> Attachments: OFBIZ-1.png
>
>
> *Step to reproduce*
> 1. Login [https://demo-trunk.ofbiz.apache.org/ecomseo] with a valid username 
> and password.
> 2. Place an order.
> 3. Navigate to order history and click on view link.
> 4. Click on the cancel link in the order item section.
> *Actual Result:* The Error message is displayed.
> *Note* - Issue is working fine on 
> "[https://demo-trunk.ofbiz.apache.org/ecommerce/control/main];
> *Screen print attached*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10903) Make Gradle createPlugin task reflect the actual file/folder structure

2019-06-22 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870199#comment-16870199
 ] 

Pawan Verma commented on OFBIZ-10903:
-

Also, migrated to release18 at rev #1861835 and #1861836.

> Make Gradle createPlugin task reflect the actual file/folder structure
> --
>
> Key: OFBIZ-10903
> URL: https://issues.apache.org/jira/browse/OFBIZ-10903
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Gradle
>Reporter: Michael Brohl
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10903.patch
>
>
> Just recognized that at least the groovyScripts folder is still named 
> "script". Have to check if there is anything else mising or has to be 
> corrected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11109) Getting an error while creating event from SFA without providing event name

2019-06-22 Thread Aditi Patidar (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aditi Patidar updated OFBIZ-11109:
--
Affects Version/s: Release Branch 18.12
   Release Branch 17.12

> Getting an error while creating event from SFA without providing event name
> ---
>
> Key: OFBIZ-11109
> URL: https://issues.apache.org/jira/browse/OFBIZ-11109
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Harman kaur Matharu
>Assignee: Mridul Pathak
>Priority: Major
> Attachments: OFBIZ-11109.patch, Screenshot from 2019-06-22 
> 11-43-54.png
>
>
>  Steps-
> 1) Navigate to SFA than events.
> 2) Click on create button.
> 3) Enter only Party Id and proceed to Create Event.
> Expected: Event should be successfully created.
> Actual: Error message gets displayed, which does not make any sense to the 
> system user. 
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-11117) Create New Shipment screen should have Create button instead of Update button

2019-06-22 Thread Chandrashekhar Dhakad (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870198#comment-16870198
 ] 

Chandrashekhar Dhakad commented on OFBIZ-7:
---

Added code to show *Create* button for create shipment screen and *Update* 
button for update shipment screen.

Provided patch for the same.

> Create New Shipment screen should have Create button instead of Update button
> -
>
> Key: OFBIZ-7
> URL: https://issues.apache.org/jira/browse/OFBIZ-7
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Chandrashekhar Dhakad
>Assignee: Chandrashekhar Dhakad
>Priority: Minor
> Attachments: CreateNewShipmentButton.png, OFBIZ-7.patch
>
>
> *Steps to regenerate:*
> 1) Login to facility component 
> ([https://demo-trunk.ofbiz.apache.org/facility/control/main]).
> 2) Navigate to Shipments screen 
> ([https://demo-trunk.ofbiz.apache.org/facility/control/FindShipment]).
> 3) Click on New Shipment button to create a new Shipment.
> 4) New Shipment screen is having the Update button instead of Create button.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7257) View Image button on order detail page is not working

2019-06-22 Thread Deepak Nigam (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Nigam reassigned OFBIZ-7257:
---

Assignee: Deepak Nigam  (was: Avnindra Sharma)

> View Image button on order detail page is not working
> -
>
> Key: OFBIZ-7257
> URL: https://issues.apache.org/jira/browse/OFBIZ-7257
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Avnindra Sharma
>Assignee: Deepak Nigam
>Priority: Major
> Attachments: OFBIZ-7257.patch, OFBIZ-7257.patch, OFBIZ-7257.patch
>
>
> Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10903) Make Gradle createPlugin task reflect the actual file/folder structure

2019-06-22 Thread Pawan Verma (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870195#comment-16870195
 ] 

Pawan Verma commented on OFBIZ-10903:
-

Minor improvement for removing old groovy scripts directory has been done at 
rev #1861834. Thanks, Deepak Dixit for reporting.

> Make Gradle createPlugin task reflect the actual file/folder structure
> --
>
> Key: OFBIZ-10903
> URL: https://issues.apache.org/jira/browse/OFBIZ-10903
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Gradle
>Reporter: Michael Brohl
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10903.patch
>
>
> Just recognized that at least the groovyScripts folder is still named 
> "script". Have to check if there is anything else mising or has to be 
> corrected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7257) View Image button on order detail page is not working

2019-06-22 Thread Devanshu Vyas (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870190#comment-16870190
 ] 

Devanshu Vyas commented on OFBIZ-7257:
--

Thanks [~deepaknigam.1...@gmail.com] for the quick review.
I uploaded the latest patch with proper description.

As a side note, the attached file will be download if the 
content-disposition-type is set to attachment or it will be displayed if set to 
inline.

> View Image button on order detail page is not working
> -
>
> Key: OFBIZ-7257
> URL: https://issues.apache.org/jira/browse/OFBIZ-7257
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Avnindra Sharma
>Assignee: Avnindra Sharma
>Priority: Major
> Attachments: OFBIZ-7257.patch, OFBIZ-7257.patch, OFBIZ-7257.patch
>
>
> Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7257) View Image button on order detail page is not working

2019-06-22 Thread Devanshu Vyas (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Devanshu Vyas updated OFBIZ-7257:
-
Attachment: OFBIZ-7257.patch

> View Image button on order detail page is not working
> -
>
> Key: OFBIZ-7257
> URL: https://issues.apache.org/jira/browse/OFBIZ-7257
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Avnindra Sharma
>Assignee: Avnindra Sharma
>Priority: Major
> Attachments: OFBIZ-7257.patch, OFBIZ-7257.patch, OFBIZ-7257.patch
>
>
> Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11118) Error rendering template on Sales Order : Order Entry Payment Settings page

2019-06-22 Thread Ravi Lodhi (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravi Lodhi updated OFBIZ-8:
---
Description: 
Steps to reproduce-
 1) Log in to order manager and navigate to order entry page 
([https://demo-stable.ofbiz.apache.org/ordermgr/control/orderentry]).
2) Select any customer and continue.
 3) Enter Order Currency, Agreements, and Ship Dates or just leave as blank and 
continue.
 4) Add the product(s) to order and click on the *Finalize Order* link.
 5) Add/Select Ship-To Settings and continue.
 6) Select a shipping method and continue.
 7) Add Order Terms if any and continue. 
 8) The following error will appear on Sales Order: Order Entry Payment 
Settings page -
{noformat}
Error rendering included template at location 
[component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl]: 
freemarker.template.TemplateNotFoundException: Template not found for name 
"component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl". 
The name was interpreted by this TemplateLoader: MultiTemplateLoader(loader1 = 
org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@2831db0,
 loader2 = StringTemplateLoader(Map { })). 
{noformat}

  was:
Steps to reproduce-
 1) Log in to order manager and navigate to order entry page 
(https://demo-stable.ofbiz.apache.org/ordermgr/control/orderentry).
 ]2) Select any customer and continue.
 3) Enter Order Currency, Agreements, and Ship Dates or just leave as blank and 
continue.
 4) Add the product(s) to order and click on the *Finalize Order* link.
 5) Add/Select Ship-To Settings and continue.
 6) Select a shipping method and continue.
 7) Add Order Terms if any and continue. 
 8) The following error will appear on Sales Order: Order Entry Payment 
Settings page -
{noformat}
Error rendering included template at location 
[component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl]: 
freemarker.template.TemplateNotFoundException: Template not found for name 
"component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl". 
The name was interpreted by this TemplateLoader: MultiTemplateLoader(loader1 = 
org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@2831db0,
 loader2 = StringTemplateLoader(Map { })). 
{noformat}


> Error rendering template on Sales Order : Order Entry Payment Settings page
> ---
>
> Key: OFBIZ-8
> URL: https://issues.apache.org/jira/browse/OFBIZ-8
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11
>Reporter: Ravi Lodhi
>Priority: Minor
> Attachments: OrderEntryPaymentSetttingsError.png
>
>
> Steps to reproduce-
>  1) Log in to order manager and navigate to order entry page 
> ([https://demo-stable.ofbiz.apache.org/ordermgr/control/orderentry]).
> 2) Select any customer and continue.
>  3) Enter Order Currency, Agreements, and Ship Dates or just leave as blank 
> and continue.
>  4) Add the product(s) to order and click on the *Finalize Order* link.
>  5) Add/Select Ship-To Settings and continue.
>  6) Select a shipping method and continue.
>  7) Add Order Terms if any and continue. 
>  8) The following error will appear on Sales Order: Order Entry Payment 
> Settings page -
> {noformat}
> Error rendering included template at location 
> [component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl]:
>  freemarker.template.TemplateNotFoundException: Template not found for name 
> "component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl".
>  The name was interpreted by this TemplateLoader: MultiTemplateLoader(loader1 
> = 
> org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@2831db0,
>  loader2 = StringTemplateLoader(Map { })). 
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-11118) Error rendering template on Sales Order : Order Entry Payment Settings page

2019-06-22 Thread Ravi Lodhi (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravi Lodhi updated OFBIZ-8:
---
Description: 
Steps to reproduce-
 1) Log in to order manager and navigate to order entry page 
(https://demo-stable.ofbiz.apache.org/ordermgr/control/orderentry).
 ]2) Select any customer and continue.
 3) Enter Order Currency, Agreements, and Ship Dates or just leave as blank and 
continue.
 4) Add the product(s) to order and click on the *Finalize Order* link.
 5) Add/Select Ship-To Settings and continue.
 6) Select a shipping method and continue.
 7) Add Order Terms if any and continue. 
 8) The following error will appear on Sales Order: Order Entry Payment 
Settings page -
{noformat}
Error rendering included template at location 
[component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl]: 
freemarker.template.TemplateNotFoundException: Template not found for name 
"component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl". 
The name was interpreted by this TemplateLoader: MultiTemplateLoader(loader1 = 
org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@2831db0,
 loader2 = StringTemplateLoader(Map { })). 
{noformat}

  was:
Steps to reproduce-
1) Log in to order manager and navigate to order entry page 
([https://demo-stable.ofbiz.apache.org/ordermgr/control/orderentry).
]2) Select any customer and continue.
3) Enter Order Currency, Agreements, and Ship Dates or just leave as blank and 
continue.
4) Add the product(s) to order and click on the *Finalize Order* link.
5) Add/Select Ship-To Settings and continue.
6) Select a shipping method and continue.
7) Add Order Terms if any and continue. 
8) The following error will appear on Sales Order: Order Entry Payment Settings 
page -
{noformat}
Error rendering included template at location 
[component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl]: 
freemarker.template.TemplateNotFoundException: Template not found for name 
"component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl". 
The name was interpreted by this TemplateLoader: MultiTemplateLoader(loader1 = 
org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@2831db0,
 loader2 = StringTemplateLoader(Map { })). 
{noformat}


> Error rendering template on Sales Order : Order Entry Payment Settings page
> ---
>
> Key: OFBIZ-8
> URL: https://issues.apache.org/jira/browse/OFBIZ-8
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11
>Reporter: Ravi Lodhi
>Priority: Minor
> Attachments: OrderEntryPaymentSetttingsError.png
>
>
> Steps to reproduce-
>  1) Log in to order manager and navigate to order entry page 
> (https://demo-stable.ofbiz.apache.org/ordermgr/control/orderentry).
>  ]2) Select any customer and continue.
>  3) Enter Order Currency, Agreements, and Ship Dates or just leave as blank 
> and continue.
>  4) Add the product(s) to order and click on the *Finalize Order* link.
>  5) Add/Select Ship-To Settings and continue.
>  6) Select a shipping method and continue.
>  7) Add Order Terms if any and continue. 
>  8) The following error will appear on Sales Order: Order Entry Payment 
> Settings page -
> {noformat}
> Error rendering included template at location 
> [component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl]:
>  freemarker.template.TemplateNotFoundException: Template not found for name 
> "component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl".
>  The name was interpreted by this TemplateLoader: MultiTemplateLoader(loader1 
> = 
> org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@2831db0,
>  loader2 = StringTemplateLoader(Map { })). 
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11118) Error rendering template on Sales Order : Order Entry Payment Settings page

2019-06-22 Thread Ravi Lodhi (JIRA)
Ravi Lodhi created OFBIZ-8:
--

 Summary: Error rendering template on Sales Order : Order Entry 
Payment Settings page
 Key: OFBIZ-8
 URL: https://issues.apache.org/jira/browse/OFBIZ-8
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 16.11
Reporter: Ravi Lodhi
 Attachments: OrderEntryPaymentSetttingsError.png

Steps to reproduce-
1) Log in to order manager and navigate to order entry page 
([https://demo-stable.ofbiz.apache.org/ordermgr/control/orderentry).
]2) Select any customer and continue.
3) Enter Order Currency, Agreements, and Ship Dates or just leave as blank and 
continue.
4) Add the product(s) to order and click on the *Finalize Order* link.
5) Add/Select Ship-To Settings and continue.
6) Select a shipping method and continue.
7) Add Order Terms if any and continue. 
8) The following error will appear on Sales Order: Order Entry Payment Settings 
page -
{noformat}
Error rendering included template at location 
[component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl]: 
freemarker.template.TemplateNotFoundException: Template not found for name 
"component://common-theme/template/includes/SetDependentDropdownValuesJs.ftl". 
The name was interpreted by this TemplateLoader: MultiTemplateLoader(loader1 = 
org.apache.ofbiz.base.util.template.FreeMarkerWorker$FlexibleTemplateLoader@2831db0,
 loader2 = StringTemplateLoader(Map { })). 
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7257) View Image button on order detail page is not working

2019-06-22 Thread Deepak Nigam (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870186#comment-16870186
 ] 

Deepak Nigam commented on OFBIZ-7257:
-

[~devanshu.vyas], I tested your patch on my local machine and it is looking 
good to me. Just a small improvement, change the description to 'Document' in 
the OrderContentType you have added.



> View Image button on order detail page is not working
> -
>
> Key: OFBIZ-7257
> URL: https://issues.apache.org/jira/browse/OFBIZ-7257
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Reporter: Avnindra Sharma
>Assignee: Avnindra Sharma
>Priority: Major
> Attachments: OFBIZ-7257.patch, OFBIZ-7257.patch
>
>
> Item image is not getting open on clicking ViewImage on order detail page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9092) Unit test case for service - getPayments

2019-06-22 Thread Mridul Pathak (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mridul Pathak closed OFBIZ-9092.


Thanks [~deepak.nigam] for reporting and providing initial patch and 
[~yogesh.naroliya] for providing the updated patch.

> Unit test case for service -  getPayments
> -
>
> Key: OFBIZ-9092
> URL: https://issues.apache.org/jira/browse/OFBIZ-9092
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Deepak Nigam
>Assignee: Mridul Pathak
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9092.patch, OFBIZ-9092.patch
>
>
> Unit test case for service -  getPayments



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10971) Use ReturnContactMech entity

2019-06-22 Thread Swapnil M Mane (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil M Mane reassigned OFBIZ-10971:
--

Assignee: (was: Swapnil M Mane)

> Use ReturnContactMech entity
> 
>
> Key: OFBIZ-10971
> URL: https://issues.apache.org/jira/browse/OFBIZ-10971
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Vaibhav Jain
>Priority: Major
>
> Use ReturnContactMech entity to capture the contactMech information of 
> parties involved in a return like OrderContactMech is used of orders



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


  1   2   3   >