[jira] [Commented] (OFBIZ-11182) PicklistStatusHistory doesn't follow history entity status pattern

2019-09-04 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922429#comment-16922429
 ] 

Nicolas Malin commented on OFBIZ-11182:
---

hmmm, the service is already done, just lost it during creation patch ... I 
will upload it soon

> PicklistStatusHistory doesn't  follow history entity status pattern
> ---
>
> Key: OFBIZ-11182
> URL: https://issues.apache.org/jira/browse/OFBIZ-11182
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11182.patch
>
>
> The entity PicklistStatusHistory record each status change realized on 
> picklist.
> It can't be convert to entity-auto easily because PicklistStatusHistory's 
> fields pattern doesn't follow same entities like ShipmentStatus and 
> PartyStatus.
> I propose to deprecate the entity PicklistStatusHistory:
> {code:java}
>   table-name="PICKLIST_STATUS_HISTORY"
> package-name="org.apache.ofbiz.shipment.picklist"
> title="Picklist Status History">
>   
>   
>   
>   
>   
>   
>   ...
> 
> {code}
> and replace it with an entity managed natively by entity-auto engine
> {code:java}
>   package-name="org.apache.ofbiz.shipment.picklist"
> title="Picklist Status History">
> 
> 
> 
> 
> 
> 
> ...
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Closed] (OFBIZ-11180) Service parameter default-value attribut can support flexible string

2019-09-04 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin closed OFBIZ-11180.
-
Resolution: Implemented

I loaded it in trunk at 1866380.

> Service parameter default-value attribut can support flexible string
> 
>
> Key: OFBIZ-11180
> URL: https://issues.apache.org/jira/browse/OFBIZ-11180
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11180.patch
>
>
> When you define a service with default-value, you can't set simple dynamic 
> resolution for the value.
> The idea is to extend the default-value attribut on service parameter to 
> support the FlexibleStringExpander syntax and realize the expand on service 
> context.
> Example :
> {code:java}
>   engine="entity-auto" invoke="create" auth="true">
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-11180) Service parameter default-value attribut can support flexible string

2019-09-04 Thread Swapnil M Mane (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922415#comment-16922415
 ] 

Swapnil M Mane commented on OFBIZ-11180:


:D Nice, thanks [~soledad], this is better and beautiful ;)!

> Service parameter default-value attribut can support flexible string
> 
>
> Key: OFBIZ-11180
> URL: https://issues.apache.org/jira/browse/OFBIZ-11180
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11180.patch
>
>
> When you define a service with default-value, you can't set simple dynamic 
> resolution for the value.
> The idea is to extend the default-value attribut on service parameter to 
> support the FlexibleStringExpander syntax and realize the expand on service 
> context.
> Example :
> {code:java}
>   engine="entity-auto" invoke="create" auth="true">
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Comment Edited] (OFBIZ-11180) Service parameter default-value attribut can support flexible string

2019-09-04 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922410#comment-16922410
 ] 

Nicolas Malin edited comment on OFBIZ-11180 at 9/4/19 11:54 AM:


Thanks both for the review,

[~swapnilmmane] I can't follow your suggestion, because adding now on the 
service context it's just useless ! Uel is own friend ;) : 
${date:nowTimestamp()}


was (Author: soledad):
Thanks both for the review,

[~swapnilmmane] I can't follow your suggestion, becasue adding now on the 
service context it's just useless ! Uel is own friend ;) : 
${date:nowTimestamp()}

> Service parameter default-value attribut can support flexible string
> 
>
> Key: OFBIZ-11180
> URL: https://issues.apache.org/jira/browse/OFBIZ-11180
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11180.patch
>
>
> When you define a service with default-value, you can't set simple dynamic 
> resolution for the value.
> The idea is to extend the default-value attribut on service parameter to 
> support the FlexibleStringExpander syntax and realize the expand on service 
> context.
> Example :
> {code:java}
>   engine="entity-auto" invoke="create" auth="true">
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-11180) Service parameter default-value attribut can support flexible string

2019-09-04 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922410#comment-16922410
 ] 

Nicolas Malin commented on OFBIZ-11180:
---

Thanks both for the review,

[~swapnilmmane] I can't follow your suggestion, becasue adding now on the 
service context it's just useless ! Uel is own friend ;) : 
${date:nowTimestamp()}

> Service parameter default-value attribut can support flexible string
> 
>
> Key: OFBIZ-11180
> URL: https://issues.apache.org/jira/browse/OFBIZ-11180
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11180.patch
>
>
> When you define a service with default-value, you can't set simple dynamic 
> resolution for the value.
> The idea is to extend the default-value attribut on service parameter to 
> support the FlexibleStringExpander syntax and realize the expand on service 
> context.
> Example :
> {code:java}
>   engine="entity-auto" invoke="create" auth="true">
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-11164) Convert CommunicationEventServices.xml mini lang to groovy

2019-09-04 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922318#comment-16922318
 ] 

Jacques Le Roux commented on OFBIZ-11164:
-

Eclipse is not only for Java hence I guess more parametrisations

> Convert CommunicationEventServices.xml mini lang to groovy
> --
>
> Key: OFBIZ-11164
> URL: https://issues.apache.org/jira/browse/OFBIZ-11164
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11164-createCommEvent.patch, OFBIZ-11164.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-11179) Change current view-link requirement to allow use of entity-condition only in view-entities

2019-09-04 Thread Leila Mekika (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922311#comment-16922311
 ] 

Leila Mekika commented on OFBIZ-11179:
--

Hello [~jacques.le.roux] , thanks for the test.

I added it in applications/datamodel/entitydef/product-entitymodel.xml (sorry, 
the package-name was not clear)

 

> Change current view-link requirement to allow use of  entity-condition only 
> in view-entities
> 
>
> Key: OFBIZ-11179
> URL: https://issues.apache.org/jira/browse/OFBIZ-11179
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Leila Mekika
>Priority: Minor
> Attachments: ExampleWithoutKeyMap.xml, OFBIZ-11179.patch
>
>
> To explain the subject, i will give an example encountered recently:
> We used, for a customer project, a view with Agreement, Virtual and Variant 
> product entities and where the agreement can be attached to a virtual OR a 
> variant product.
>  So to make a view returning Variant Product, Virtual Product AND Agreement 
> informations, i could not create a view, as the key-map link is mandatory and 
> made it impossible.
> I can not have an alternative relation to the same entity so we have to 
> duplicate member-entity and an alternative relation path. The result is a 
> complicated and ugly entity-view
> I think this can have been much simpler if i could have done it directly 
> through the entity-condition (see the AGPA/PDTA view link in attached file 
> ExampleWithoutKeyMap.xml)
> So the purpose of this jira is to add the possibility to create a view-link 
> without key map,  if there is an entity-condition.
> You can test by applying the given patch and add the entity view from 
> attached file ExampleWithoutKeyMap.xml



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (OFBIZ-11184) No option for passing rounding mode to the ofbizCurrency Macro

2019-09-04 Thread Murugeswari (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Murugeswari updated OFBIZ-11184:

Description: 
No option to pass roundingMode to the Ofbiz Currency macro.

Please refer attached screenshot, there is difference in line item total and 
header total.

Is there any way, to match line item total and header total with 2 decimal.

  was:
No option to pass roundingMode to the Ofbiz Currency macro.

Please refer attached screenshot, there is difference in line item total and 
header total.

Is there any way, to match line item total and header total.


> No option for passing rounding mode to the ofbizCurrency Macro 
> ---
>
> Key: OFBIZ-11184
> URL: https://issues.apache.org/jira/browse/OFBIZ-11184
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 16.11
>Reporter: Murugeswari
>Priority: Minor
> Attachments: Capture.PNG
>
>
> No option to pass roundingMode to the Ofbiz Currency macro.
> Please refer attached screenshot, there is difference in line item total and 
> header total.
> Is there any way, to match line item total and header total with 2 decimal.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (OFBIZ-11184) No option for passing rounding mode to the ofbizCurrency Macro

2019-09-04 Thread Murugeswari (Jira)
Murugeswari created OFBIZ-11184:
---

 Summary: No option for passing rounding mode to the ofbizCurrency 
Macro 
 Key: OFBIZ-11184
 URL: https://issues.apache.org/jira/browse/OFBIZ-11184
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Affects Versions: Release Branch 16.11
Reporter: Murugeswari
 Attachments: Capture.PNG

No option to pass roundingMode to the Ofbiz Currency macro.

Please refer attached screenshot, there is difference in line item total and 
header total.

Is there any way, to match line item total and header total.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-11181) paymentMethodId choices wrong in form for creating/editing a received payment

2019-09-04 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922271#comment-16922271
 ] 

Jacques Le Roux commented on OFBIZ-11181:
-

Thanks Parminder,

I'll have a look ASAP (ie not very soon)

> paymentMethodId choices wrong in form for creating/editing a received payment
> -
>
> Key: OFBIZ-11181
> URL: https://issues.apache.org/jira/browse/OFBIZ-11181
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
> Environment: Ofbiz 16.11.05 on Fedora 30 with OpenJDK 64-Bit Server 
> VM (build 25.222-b10, mixed mode) and mariadb-server.x86_64 3:10.3.17-1.fc30 
> as database
>Reporter: Parminder
>Assignee: Jacques Le Roux
>Priority: Major
>
> {color:#737373}There is a bug in the forms   for 
> Payment{color}{color:#737373} method field(drop down) for Incoming payment. 
> Payment methods should be{color}
> {color:#737373} whatever is  defined for getting the payments from customers 
> like  {color}{color:#737373}Company Check, Cash etc. etc. but it is showing 
> the methods which are{color}{color:#737373} applicable for outgoing payments 
> such as Petty cash and defined{color}{color:#737373} Financial accounts (from 
> where you pay the suppliers).{color}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-7113) Refactoring permission model call

2019-09-04 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922254#comment-16922254
 ] 

Jacques Le Roux commented on OFBIZ-7113:


Hi Nicolas,

I'm not sure why the Thai  was 
changed. But anyway when I try to revert nothing change. Certainly an encoding 
thing, it's OK with me, like all the rest (quick review)

> Refactoring permission model call
> -
>
> Key: OFBIZ-7113
> URL: https://issues.apache.org/jira/browse/OFBIZ-7113
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-7113.patch, OFBIZ-7113.patch, OFBIZ-7113.patch
>
>
> With the subject on mailing list "Permission service not on the same 
> transaction" : http://markmail.org/message/34vxi4ntmbj7vzcr
> I started the improvement but the java code need to be clean and refactoring. 
> I share my first draft patch, but need more works. I realize :
>  * unified call evalPermission
>  * move all related field for permission service on ModelService to 
> ModelPermission
>  * Remove  deprecated code
>  * start labelized error message  
>  * add new attributes on permission model : required-new-transaction and 
> return-error-on-failure



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-11164) Convert CommunicationEventServices.xml mini lang to groovy

2019-09-04 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922244#comment-16922244
 ] 

Nicolas Malin commented on OFBIZ-11164:
---

{quote}
Maybe beware of stuff like OFBIZ-11175 though. It's hard to debug in Eclipse 
18.12 at least (I hope I only need to update for the Groovy plugin to be able 
to put breakpoints :/)

September 4: for debugging Groovy in Eclipse, I forgot OFBIZ-10226 which I 
believe is the real reason.

{quote}

I didn't know, with intellij I didn't detected any problem to debug

> Convert CommunicationEventServices.xml mini lang to groovy
> --
>
> Key: OFBIZ-11164
> URL: https://issues.apache.org/jira/browse/OFBIZ-11164
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11164-createCommEvent.patch, OFBIZ-11164.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Comment Edited] (OFBIZ-11164) Convert CommunicationEventServices.xml mini lang to groovy

2019-09-04 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915629#comment-16915629
 ] 

Jacques Le Roux edited comment on OFBIZ-11164 at 9/4/19 7:08 AM:
-

Maybe beware of stuff like OFBIZ-11175 though. It's hard to debug in Eclipse 
18.12 at least (I hope I only need to update for the Groovy plugin to be able 
to put breakpoints :/)

September 4: for debugging Groovy in Eclipse, I forgot OFBIZ-10226 which I 
believe is the real reason.


was (Author: jacques.le.roux):
Maybe beware of stuff like OFBIZ-11175 though. It's hard to debug in Eclipse 
18.12 at least (I hope I only need to update for the Groovy plugin to be able 
to put brealpoints :/)

> Convert CommunicationEventServices.xml mini lang to groovy
> --
>
> Key: OFBIZ-11164
> URL: https://issues.apache.org/jira/browse/OFBIZ-11164
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11164-createCommEvent.patch, OFBIZ-11164.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-11180) Service parameter default-value attribut can support flexible string

2019-09-04 Thread Swapnil M Mane (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921975#comment-16921975
 ] 

Swapnil M Mane commented on OFBIZ-11180:


Looks good addition to me as well, +1
Very small suggestion, can we rename 'now' variable name to 'nowTimestamp' to 
maintain consistency.

Thanks!

> Service parameter default-value attribut can support flexible string
> 
>
> Key: OFBIZ-11180
> URL: https://issues.apache.org/jira/browse/OFBIZ-11180
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11180.patch
>
>
> When you define a service with default-value, you can't set simple dynamic 
> resolution for the value.
> The idea is to extend the default-value attribut on service parameter to 
> support the FlexibleStringExpander syntax and realize the expand on service 
> context.
> Example :
> {code:java}
>   engine="entity-auto" invoke="create" auth="true">
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)