[jira] [Comment Edited] (OFBIZ-11038) Unable to view a PartyContent on view profile page of a party

2019-09-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924527#comment-16924527
 ] 

Jacques Le Roux edited comment on OFBIZ-11038 at 9/6/19 7:36 PM:
-

Hi Pawan,

Since this is a bug it should be backported and then the "Fix Version/s:" field 
would contain the version/s where it has been backported, thanks.


was (Author: jacques.le.roux):
Hi Pawan,

Since this is a bug it should be backported and then the "Fix Version/s:" field 
would contain the version where it has been backported, thanks.

> Unable to view a PartyContent on view profile page of a party
> -
>
> Key: OFBIZ-11038
> URL: https://issues.apache.org/jira/browse/OFBIZ-11038
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: Error_message.png, OFBIZ-11038.patch, 
> PartyContent_View.png
>
>
> * Go to [partymgr|https://demo-trunk.ofbiz.apache.org/partymgr/control/main]
>  * Search any party(e.g. DemoCustomer)
>  * Go to the [party 
> profile|https://demo-trunk.ofbiz.apache.org/partymgr/control/viewprofile?partyId=DemoCustomer]
>  page
>  * Go to Party Content section on the page and upload a file
>  * Select a purpose(Logo Image Url) and click on the Upload button
>  * After uploading success message will be displayed as Party data object 
> created successfully.
>  * Then view button will be displayed under the Party Content section, click 
> on the view button to view the image uploaded.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2019-09-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924551#comment-16924551
 ] 

Jacques Le Roux commented on OFBIZ-4361:


While working on OFBIZ-10751 I re-read comments I made in OFBIZ-9833 & 
OFBIZ-10307. I stumbled upon 
https://github.com/auth0/java-jwt#using-a-keyprovider. though I did not yet 
clarified all the points, now that we use {{com.auth0:java-jwt:3.8.2}}, I think 
we should consider to do something like in the example demonstrated in this 
page but as suggested there:
bq. "with a simple key rotation using JWKS, try the jwks-rsa-java library."

> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release 
> Branch 17.12
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: security
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, 
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch, 
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-11038) Unable to view a PartyContent on view profile page of a party

2019-09-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924527#comment-16924527
 ] 

Jacques Le Roux commented on OFBIZ-11038:
-

Hi Pawan,

Since this is a bug it should be backported and then the "Fix Version/s:" field 
would contain the version where it has been backported, thanks.

> Unable to view a PartyContent on view profile page of a party
> -
>
> Key: OFBIZ-11038
> URL: https://issues.apache.org/jira/browse/OFBIZ-11038
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: Error_message.png, OFBIZ-11038.patch, 
> PartyContent_View.png
>
>
> * Go to [partymgr|https://demo-trunk.ofbiz.apache.org/partymgr/control/main]
>  * Search any party(e.g. DemoCustomer)
>  * Go to the [party 
> profile|https://demo-trunk.ofbiz.apache.org/partymgr/control/viewprofile?partyId=DemoCustomer]
>  page
>  * Go to Party Content section on the page and upload a file
>  * Select a purpose(Logo Image Url) and click on the Upload button
>  * After uploading success message will be displayed as Party data object 
> created successfully.
>  * Then view button will be displayed under the Party Content section, click 
> on the view button to view the image uploaded.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-10751) Document how to store the JWT secret key

2019-09-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924526#comment-16924526
 ] 

Jacques Le Roux commented on OFBIZ-10751:
-

I 'd like to backport but there is a tree conflict. Anyway I'll want for 
answers to [[DISCUSSION] Non official yet 
documentation|https://markmail.org/message/4isdk7tj7c2nxhdr]

> Document how to store the JWT secret key
> 
>
> Key: OFBIZ-10751
> URL: https://issues.apache.org/jira/browse/OFBIZ-10751
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> AS discussed in dev ML at https://markmail.org/message/dtjnu7fdi5noeagk and 
> previously in OFBIZ-9833 & OFBIZ-10307 we want to document how to store the 
> JWT secret key. We agreed about keeping it as a property OOTB; and giving a 
> link from the security properties file to suggest how to better do it in 
> production.
> Remains to create the documentation and link to it. I believe an .adoc 
> document in security component fits.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Comment Edited] (OFBIZ-11182) PicklistStatusHistory doesn't follow history entity status pattern

2019-09-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924520#comment-16924520
 ] 

Jacques Le Roux edited comment on OFBIZ-11182 at 9/6/19 6:59 PM:
-

+1 for commit (w/o forgetting the wiki page ;))


was (Author: jacques.le.roux):
+1 for commit

> PicklistStatusHistory doesn't  follow history entity status pattern
> ---
>
> Key: OFBIZ-11182
> URL: https://issues.apache.org/jira/browse/OFBIZ-11182
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11182.patch, OFBIZ-11182.patch
>
>
> The entity PicklistStatusHistory record each status change realized on 
> picklist.
> It can't be convert to entity-auto easily because PicklistStatusHistory's 
> fields pattern doesn't follow same entities like ShipmentStatus and 
> PartyStatus.
> I propose to deprecate the entity PicklistStatusHistory:
> {code:java}
>   table-name="PICKLIST_STATUS_HISTORY"
> package-name="org.apache.ofbiz.shipment.picklist"
> title="Picklist Status History">
>   
>   
>   
>   
>   
>   
>   ...
> 
> {code}
> and replace it with an entity managed natively by entity-auto engine
> {code:java}
>   package-name="org.apache.ofbiz.shipment.picklist"
> title="Picklist Status History">
> 
> 
> 
> 
> 
> 
> ...
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-11182) PicklistStatusHistory doesn't follow history entity status pattern

2019-09-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924520#comment-16924520
 ] 

Jacques Le Roux commented on OFBIZ-11182:
-

+1 for commit

> PicklistStatusHistory doesn't  follow history entity status pattern
> ---
>
> Key: OFBIZ-11182
> URL: https://issues.apache.org/jira/browse/OFBIZ-11182
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11182.patch, OFBIZ-11182.patch
>
>
> The entity PicklistStatusHistory record each status change realized on 
> picklist.
> It can't be convert to entity-auto easily because PicklistStatusHistory's 
> fields pattern doesn't follow same entities like ShipmentStatus and 
> PartyStatus.
> I propose to deprecate the entity PicklistStatusHistory:
> {code:java}
>   table-name="PICKLIST_STATUS_HISTORY"
> package-name="org.apache.ofbiz.shipment.picklist"
> title="Picklist Status History">
>   
>   
>   
>   
>   
>   
>   ...
> 
> {code}
> and replace it with an entity managed natively by entity-auto engine
> {code:java}
>   package-name="org.apache.ofbiz.shipment.picklist"
> title="Picklist Status History">
> 
> 
> 
> 
> 
> 
> ...
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2019-09-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924347#comment-16924347
 ] 

Jacques Le Roux commented on OFBIZ-4361:


Hi Nicolas,

+1 for backporting, I tried, it should not be too hard :)

> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release 
> Branch 17.12
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: security
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, 
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch, 
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Comment Edited] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2019-09-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924346#comment-16924346
 ] 

Jacques Le Roux edited comment on OFBIZ-4361 at 9/6/19 3:42 PM:


At revision: 1866518, I have slightly modified the security.properties filen 
also adding a reference to 
https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/framework/security/src/docs/asciidoc/_include/sy-password-and-JWT.adoc

Please review...



was (Author: jacques.le.roux):
At revision: 1866518, I have slightly modified the security.properties filen 
also adding a reference to 

Please review...


> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release 
> Branch 17.12
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: security
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, 
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch, 
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2019-09-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924346#comment-16924346
 ] 

Jacques Le Roux commented on OFBIZ-4361:


At revision: 1866518, I have slightly modified the security.properties filen 
also adding a reference to 

Please review...


> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release 
> Branch 17.12
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: security
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, 
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch, 
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Closed] (OFBIZ-10751) Document how to store the JWT secret key

2019-09-06 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10751.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Implemented at r1866519

All reviews are welcome

> Document how to store the JWT secret key
> 
>
> Key: OFBIZ-10751
> URL: https://issues.apache.org/jira/browse/OFBIZ-10751
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> AS discussed in dev ML at https://markmail.org/message/dtjnu7fdi5noeagk and 
> previously in OFBIZ-9833 & OFBIZ-10307 we want to document how to store the 
> JWT secret key. We agreed about keeping it as a property OOTB; and giving a 
> link from the security properties file to suggest how to better do it in 
> production.
> Remains to create the documentation and link to it. I believe an .adoc 
> document in security component fits.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"

2019-09-06 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924324#comment-16924324
 ] 

Nicolas Malin commented on OFBIZ-4361:
--

Thanks Jacques for your review and commit.

It's huge improvement for forgot password process, I propose to backport on 
18.12 if no body is against, after  we consider as done the review from other


> Any ecommerce user has the ability to reset anothers password (including 
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release 
> Branch 14.12, Trunk, Release Branch 15.12, Release Branch 16.11, Release 
> Branch 17.12
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: security
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch, 
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch, 
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to 
> reset another users password, including "admin" without permission.  By 
> simply entering "admin" and clicking "Email Password", the following is 
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password.  It is also 
> possible to generate a dictionary attack against ofbiz because there is no 
> capta code required.  This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name 
> is optionally in the format of an email address, and maybe require a capta 
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was 
> generated via an ecommerce transaction.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (OFBIZ-11186) Fix syntax error on groovy

2019-09-06 Thread Gil Portenseigne (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne updated OFBIZ-11186:
-
Fix Version/s: 18.12.01
   17.12.01
Affects Version/s: Release Branch 18.12
   Release Branch 17.12

> Fix syntax error on groovy
> --
>
> Key: OFBIZ-11186
> URL: https://issues.apache.org/jira/browse/OFBIZ-11186
> Project: OFBiz
>  Issue Type: Bug
>  Components: party, product
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Samuel Trégouët
>Assignee: Gil Portenseigne
>Priority: Major
> Fix For: 17.12.01, Upcoming Branch, 18.12.01
>
> Attachments: 0001-fix-syntax-error-in-groovyScrip.patch
>
>
> Two syntax errors detected when trying to compile groovy
>  
> ShowVisits.groovy bug introduced in svn commit 1797373
> ImageFrame.groovy bug introduced in svn commit 1860051



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-11186) Fix syntax error on groovy

2019-09-06 Thread Gil Portenseigne (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924317#comment-16924317
 ] 

Gil Portenseigne commented on OFBIZ-11186:
--

Commited in :

18.12 r1866515

17.11 r1866516

> Fix syntax error on groovy
> --
>
> Key: OFBIZ-11186
> URL: https://issues.apache.org/jira/browse/OFBIZ-11186
> Project: OFBiz
>  Issue Type: Bug
>  Components: party, product
>Affects Versions: Trunk
>Reporter: Samuel Trégouët
>Assignee: Gil Portenseigne
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: 0001-fix-syntax-error-in-groovyScrip.patch
>
>
> Two syntax errors detected when trying to compile groovy
>  
> ShowVisits.groovy bug introduced in svn commit 1797373
> ImageFrame.groovy bug introduced in svn commit 1860051



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-11182) PicklistStatusHistory doesn't follow history entity status pattern

2019-09-06 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924311#comment-16924311
 ] 

Nicolas Malin commented on OFBIZ-11182:
---

now it's better :)

> PicklistStatusHistory doesn't  follow history entity status pattern
> ---
>
> Key: OFBIZ-11182
> URL: https://issues.apache.org/jira/browse/OFBIZ-11182
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11182.patch, OFBIZ-11182.patch
>
>
> The entity PicklistStatusHistory record each status change realized on 
> picklist.
> It can't be convert to entity-auto easily because PicklistStatusHistory's 
> fields pattern doesn't follow same entities like ShipmentStatus and 
> PartyStatus.
> I propose to deprecate the entity PicklistStatusHistory:
> {code:java}
>   table-name="PICKLIST_STATUS_HISTORY"
> package-name="org.apache.ofbiz.shipment.picklist"
> title="Picklist Status History">
>   
>   
>   
>   
>   
>   
>   ...
> 
> {code}
> and replace it with an entity managed natively by entity-auto engine
> {code:java}
>   package-name="org.apache.ofbiz.shipment.picklist"
> title="Picklist Status History">
> 
> 
> 
> 
> 
> 
> ...
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (OFBIZ-11182) PicklistStatusHistory doesn't follow history entity status pattern

2019-09-06 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin updated OFBIZ-11182:
--
Attachment: OFBIZ-11182.patch

> PicklistStatusHistory doesn't  follow history entity status pattern
> ---
>
> Key: OFBIZ-11182
> URL: https://issues.apache.org/jira/browse/OFBIZ-11182
> Project: OFBiz
>  Issue Type: Improvement
>  Components: product
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-11182.patch, OFBIZ-11182.patch
>
>
> The entity PicklistStatusHistory record each status change realized on 
> picklist.
> It can't be convert to entity-auto easily because PicklistStatusHistory's 
> fields pattern doesn't follow same entities like ShipmentStatus and 
> PartyStatus.
> I propose to deprecate the entity PicklistStatusHistory:
> {code:java}
>   table-name="PICKLIST_STATUS_HISTORY"
> package-name="org.apache.ofbiz.shipment.picklist"
> title="Picklist Status History">
>   
>   
>   
>   
>   
>   
>   ...
> 
> {code}
> and replace it with an entity managed natively by entity-auto engine
> {code:java}
>   package-name="org.apache.ofbiz.shipment.picklist"
> title="Picklist Status History">
> 
> 
> 
> 
> 
> 
> ...
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Closed] (OFBIZ-11186) Fix syntax error on groovy

2019-09-06 Thread Gil Portenseigne (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne closed OFBIZ-11186.

Resolution: Fixed

Commited in trunk r1866513

 

Thanks [~stregouet] !

> Fix syntax error on groovy
> --
>
> Key: OFBIZ-11186
> URL: https://issues.apache.org/jira/browse/OFBIZ-11186
> Project: OFBiz
>  Issue Type: Bug
>  Components: party, product
>Affects Versions: Trunk
>Reporter: Samuel Trégouët
>Assignee: Gil Portenseigne
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: 0001-fix-syntax-error-in-groovyScrip.patch
>
>
> Two syntax errors detected when trying to compile groovy
>  
> ShowVisits.groovy bug introduced in svn commit 1797373
> ImageFrame.groovy bug introduced in svn commit 1860051



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (OFBIZ-11186) Fix syntax error on groovy

2019-09-06 Thread Gil Portenseigne (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924309#comment-16924309
 ] 

Gil Portenseigne commented on OFBIZ-11186:
--

I did close too fast, and will backport into releases

> Fix syntax error on groovy
> --
>
> Key: OFBIZ-11186
> URL: https://issues.apache.org/jira/browse/OFBIZ-11186
> Project: OFBiz
>  Issue Type: Bug
>  Components: party, product
>Affects Versions: Trunk
>Reporter: Samuel Trégouët
>Assignee: Gil Portenseigne
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: 0001-fix-syntax-error-in-groovyScrip.patch
>
>
> Two syntax errors detected when trying to compile groovy
>  
> ShowVisits.groovy bug introduced in svn commit 1797373
> ImageFrame.groovy bug introduced in svn commit 1860051



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Closed] (OFBIZ-11177) Get correct information history for Company Header in pdf document

2019-09-06 Thread Gil Portenseigne (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne closed OFBIZ-11177.

Fix Version/s: Upcoming Branch
   Resolution: Implemented

Commited in trunk rev 1866511

 

Thanks Carl

> Get correct information history for Company Header in pdf document 
> ---
>
> Key: OFBIZ-11177
> URL: https://issues.apache.org/jira/browse/OFBIZ-11177
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Demus Carl
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11177.patch
>
>
> Company header information doesn't keep historical data when data fetching 
> during the PDF generation process, it's can be problematic if the 
> informations has changed.
>  
> I propose a filtering by reference date for order and invoice.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Assigned] (OFBIZ-11177) Get correct information history for Company Header in pdf document

2019-09-06 Thread Gil Portenseigne (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne reassigned OFBIZ-11177:


Assignee: Gil Portenseigne

> Get correct information history for Company Header in pdf document 
> ---
>
> Key: OFBIZ-11177
> URL: https://issues.apache.org/jira/browse/OFBIZ-11177
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Demus Carl
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-11177.patch
>
>
> Company header information doesn't keep historical data when data fetching 
> during the PDF generation process, it's can be problematic if the 
> informations has changed.
>  
> I propose a filtering by reference date for order and invoice.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Assigned] (OFBIZ-11186) Fix syntax error on groovy

2019-09-06 Thread Gil Portenseigne (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gil Portenseigne reassigned OFBIZ-11186:


Assignee: Gil Portenseigne

> Fix syntax error on groovy
> --
>
> Key: OFBIZ-11186
> URL: https://issues.apache.org/jira/browse/OFBIZ-11186
> Project: OFBiz
>  Issue Type: Bug
>  Components: party, product
>Affects Versions: Trunk
>Reporter: Samuel Trégouët
>Assignee: Gil Portenseigne
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: 0001-fix-syntax-error-in-groovyScrip.patch
>
>
> Two syntax errors detected when trying to compile groovy
>  
> ShowVisits.groovy bug introduced in svn commit 1797373
> ImageFrame.groovy bug introduced in svn commit 1860051



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (OFBIZ-11186) Fix syntax error on groovy

2019-09-06 Thread Jira


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Samuel Trégouët updated OFBIZ-11186:

Attachment: 0001-fix-syntax-error-in-groovyScrip.patch

> Fix syntax error on groovy
> --
>
> Key: OFBIZ-11186
> URL: https://issues.apache.org/jira/browse/OFBIZ-11186
> Project: OFBiz
>  Issue Type: Bug
>  Components: party, product
>Affects Versions: Trunk
>Reporter: Samuel Trégouët
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: 0001-fix-syntax-error-in-groovyScrip.patch
>
>
> Two syntax errors detected when trying to compile groovy
>  
> ShowVisits.groovy bug introduced in svn commit 1797373
> ImageFrame.groovy bug introduced in svn commit 1860051



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (OFBIZ-11186) Fix syntax error on groovy

2019-09-06 Thread Jira
Samuel Trégouët created OFBIZ-11186:
---

 Summary: Fix syntax error on groovy
 Key: OFBIZ-11186
 URL: https://issues.apache.org/jira/browse/OFBIZ-11186
 Project: OFBiz
  Issue Type: Bug
  Components: party, product
Affects Versions: Trunk
Reporter: Samuel Trégouët
 Fix For: Upcoming Branch


Two syntax errors detected when trying to compile groovy

 

ShowVisits.groovy bug introduced in svn commit 1797373

ImageFrame.groovy bug introduced in svn commit 1860051



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (OFBIZ-11038) Unable to view a PartyContent on view profile page of a party

2019-09-06 Thread Swapnil M Mane (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil M Mane updated OFBIZ-11038:
---
Sprint:   (was: OFBiz Community Day (Aug 2019))

> Unable to view a PartyContent on view profile page of a party
> -
>
> Key: OFBIZ-11038
> URL: https://issues.apache.org/jira/browse/OFBIZ-11038
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: Error_message.png, OFBIZ-11038.patch, 
> PartyContent_View.png
>
>
> * Go to [partymgr|https://demo-trunk.ofbiz.apache.org/partymgr/control/main]
>  * Search any party(e.g. DemoCustomer)
>  * Go to the [party 
> profile|https://demo-trunk.ofbiz.apache.org/partymgr/control/viewprofile?partyId=DemoCustomer]
>  page
>  * Go to Party Content section on the page and upload a file
>  * Select a purpose(Logo Image Url) and click on the Upload button
>  * After uploading success message will be displayed as Party data object 
> created successfully.
>  * Then view button will be displayed under the Party Content section, click 
> on the view button to view the image uploaded.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)