[jira] [Commented] (OFBIZ-11192) Use ‘java.nio.file’ API instead of ‘java.io’ when manipulating files
[
https://issues.apache.org/jira/browse/OFBIZ-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937229#comment-16937229
]
Mathieu Lirzin commented on OFBIZ-11192:
Committed [^OFBIZ-11192_0004-Refactor-ComponentContainer-loadComponentFr.patch]
in revision 1867499.
> Use ‘java.nio.file’ API instead of ‘java.io’ when manipulating files
>
>
> Key: OFBIZ-11192
> URL: https://issues.apache.org/jira/browse/OFBIZ-11192
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11192_0001-Refactor-ComponentLoaderConfig-class.patch,
> OFBIZ-11192_0002-Convert-Config-ofbizHome-and-Config-logDir-.patch,
> OFBIZ-11192_0003-Use-java.nio.file-API-in-ComponentContainer.patch,
> OFBIZ-11192_0004-Refactor-ComponentContainer-loadComponentFr.patch
>
>
> Since Java 1.7 the {{java.nio.file}} package provides a more modern way to
> manipulate the filesystem than {{java.io}}. For example the presence of a
> Path class allows more typesafe manipulation of file and directory names than
> using plain strings.
> Currently OFBiz uses {{java.io}} exclusively but it would improve safety,
> maintainability and readability to move to the new {{java.nio.file}} API
> instead.
> Some documentation regarding how to migrate to new API is available:
> * https://docs.oracle.com/javase/tutorial/essential/io/fileio.html
> * https://docs.oracle.com/javase/tutorial/essential/io/legacy.html#mapping
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11192) Use ‘java.nio.file’ API instead of ‘java.io’ when manipulating files
[
https://issues.apache.org/jira/browse/OFBIZ-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11192:
---
Attachment:
OFBIZ-11192_0004-Refactor-ComponentContainer-loadComponentFr.patch
> Use ‘java.nio.file’ API instead of ‘java.io’ when manipulating files
>
>
> Key: OFBIZ-11192
> URL: https://issues.apache.org/jira/browse/OFBIZ-11192
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11192_0001-Refactor-ComponentLoaderConfig-class.patch,
> OFBIZ-11192_0002-Convert-Config-ofbizHome-and-Config-logDir-.patch,
> OFBIZ-11192_0003-Use-java.nio.file-API-in-ComponentContainer.patch,
> OFBIZ-11192_0004-Refactor-ComponentContainer-loadComponentFr.patch
>
>
> Since Java 1.7 the {{java.nio.file}} package provides a more modern way to
> manipulate the filesystem than {{java.io}}. For example the presence of a
> Path class allows more typesafe manipulation of file and directory names than
> using plain strings.
> Currently OFBiz uses {{java.io}} exclusively but it would improve safety,
> maintainability and readability to move to the new {{java.nio.file}} API
> instead.
> Some documentation regarding how to migrate to new API is available:
> * https://docs.oracle.com/javase/tutorial/essential/io/fileio.html
> * https://docs.oracle.com/javase/tutorial/essential/io/legacy.html#mapping
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11208) OrderReadHelper.getOrderItemAttributes as non static function
[
https://issues.apache.org/jira/browse/OFBIZ-11208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937227#comment-16937227
]
Mathieu Lirzin commented on OFBIZ-11208:
I like the pattern, however I think the functionality should be moved to a
dedicated inner class with a meaningful name because it feels weird to
instantiate an *Helper class.
> OrderReadHelper.getOrderItemAttributes as non static function
> -
>
> Key: OFBIZ-11208
> URL: https://issues.apache.org/jira/browse/OFBIZ-11208
> Project: OFBiz
> Issue Type: Improvement
> Components: order
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>
> Currenlty if we use the java helper class OrderReadHelper to resolve the
> orderItemAttributes, it didn't use the a local cache and call each time the
> delegator throw a static function.
> I propose to use also as non static function optimise database calling when
> you have multiple get to do.
> Origin: On customer site we have a huge table orderItemAttributes (8M tuples)
> with several call. Use a local cache throw OrderReadHelper divide by nine the
> calling.
> {code:java}
> public String getOrderItemAttribute(String orderItemSeqId, String
> attributeName) {
> GenericValue orderItemAttribute = null;
> if (orderHeader != null) {
> if (orderItemAttributes == null) {
> try{
>orderItemAttributes =
> EntityQuery.use(orderHeader.getDelegator()) .from("OrderItemAttribute")
> .where("orderId", getOrderId()) .queryList();
> } catch (GenericEntityException e) { Debug.logError(e, module); }
> }
> orderItemAttribute = EntityUtil.getFirst(
> EntityUtil.filterByAnd(orderItemAttributes,
> UtilMisc.toMap("orderItemSeqId", orderItemSeqId, "attrName",
> attributeName)));
> }
> return orderItemAttribute != null ?
> orderItemAttribute.getString("attrValue"): null;
> }
> {code}
> At the first call, we populate the OrderReadHelper with all
> orderItemAttributes liked to an order, and after just filter with the
> orderItemSeqId and the attribute name wanted
> Example:
> {code:java}
> OrderReadHelper orh = new OrderReadHelper(orderHeader)
> ...
> for (GenericValue orderItem : orh.getOrderItems()) {
> listAttr <<
>[startValue :
> orh.getOrderItemAttribute(orderItem.orderItemSeqId, "MyStartValue"),
> endValue :
> orh.getOrderItemAttribute(orderItem.orderItemSeqId, "MyEndValue")]
> }
> {code}
> We request only for the first passage, after for all other line we use the
> local OrderReadHelper cache.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11208) OrderReadHelper.getOrderItemAttributes as non static function
[
https://issues.apache.org/jira/browse/OFBIZ-11208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-11208:
--
Description:
Currenlty if we use the java helper class OrderReadHelper to resolve the
orderItemAttributes, it didn't use the a local cache and call each time the
delegator throw a static function.
I propose to use also as non static function optimise database calling when you
have multiple get to do.
Origin: On customer site we have a huge table orderItemAttributes (8M tuples)
with several call. Use a local cache throw OrderReadHelper divide by nine the
calling.
{code:java}
public String getOrderItemAttribute(String orderItemSeqId, String
attributeName) {
GenericValue orderItemAttribute = null;
if (orderHeader != null) {
if (orderItemAttributes == null) {
try{
orderItemAttributes =
EntityQuery.use(orderHeader.getDelegator()) .from("OrderItemAttribute")
.where("orderId", getOrderId()) .queryList();
} catch (GenericEntityException e) { Debug.logError(e, module); }
}
orderItemAttribute = EntityUtil.getFirst(
EntityUtil.filterByAnd(orderItemAttributes,
UtilMisc.toMap("orderItemSeqId", orderItemSeqId, "attrName",
attributeName)));
}
return orderItemAttribute != null ?
orderItemAttribute.getString("attrValue"): null;
}
{code}
At the first call, we populate the OrderReadHelper with all orderItemAttributes
liked to an order, and after just filter with the orderItemSeqId and the
attribute name wanted
Example:
{code:java}
OrderReadHelper orh = new OrderReadHelper(orderHeader)
...
for (GenericValue orderItem : orh.getOrderItems()) {
listAttr <<
[startValue :
orh.getOrderItemAttribute(orderItem.orderItemSeqId, "MyStartValue"),
endValue :
orh.getOrderItemAttribute(orderItem.orderItemSeqId, "MyEndValue")]
}
{code}
We request only for the first passage, after for all other line we use the
local OrderReadHelper cache.
was:Currenltu if we use the java helper class
> OrderReadHelper.getOrderItemAttributes as non static function
> -
>
> Key: OFBIZ-11208
> URL: https://issues.apache.org/jira/browse/OFBIZ-11208
> Project: OFBiz
> Issue Type: Improvement
> Components: order
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>
> Currenlty if we use the java helper class OrderReadHelper to resolve the
> orderItemAttributes, it didn't use the a local cache and call each time the
> delegator throw a static function.
> I propose to use also as non static function optimise database calling when
> you have multiple get to do.
> Origin: On customer site we have a huge table orderItemAttributes (8M tuples)
> with several call. Use a local cache throw OrderReadHelper divide by nine the
> calling.
> {code:java}
> public String getOrderItemAttribute(String orderItemSeqId, String
> attributeName) {
> GenericValue orderItemAttribute = null;
> if (orderHeader != null) {
> if (orderItemAttributes == null) {
> try{
>orderItemAttributes =
> EntityQuery.use(orderHeader.getDelegator()) .from("OrderItemAttribute")
> .where("orderId", getOrderId()) .queryList();
> } catch (GenericEntityException e) { Debug.logError(e, module); }
> }
> orderItemAttribute = EntityUtil.getFirst(
> EntityUtil.filterByAnd(orderItemAttributes,
> UtilMisc.toMap("orderItemSeqId", orderItemSeqId, "attrName",
> attributeName)));
> }
> return orderItemAttribute != null ?
> orderItemAttribute.getString("attrValue"): null;
> }
> {code}
> At the first call, we populate the OrderReadHelper with all
> orderItemAttributes liked to an order, and after just filter with the
> orderItemSeqId and the attribute name wanted
> Example:
> {code:java}
> OrderReadHelper orh = new OrderReadHelper(orderHeader)
> ...
> for (GenericValue orderItem : orh.getOrderItems()) {
> listAttr <<
>[startValue :
> orh.getOrderItemAttribute(orderItem.orderItemSeqId, "MyStartValue"),
> endValue :
> orh.getOrderItemAttribute(orderItem.orderItemSeqId, "MyEndValue")]
> }
> {code}
> We request only for the first passage, after for all other line we use the
> local OrderReadHelper cache.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11208) OrderReadHelper.getOrderItemAttributes as non static function
[ https://issues.apache.org/jira/browse/OFBIZ-11208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-11208: -- Description: Currenltu if we use the java helper class > OrderReadHelper.getOrderItemAttributes as non static function > - > > Key: OFBIZ-11208 > URL: https://issues.apache.org/jira/browse/OFBIZ-11208 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > > Currenltu if we use the java helper class -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11208) OrderReadHelper.getOrderItemAttributes as non static function
[ https://issues.apache.org/jira/browse/OFBIZ-11208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-11208: - Assignee: Nicolas Malin > OrderReadHelper.getOrderItemAttributes as non static function > - > > Key: OFBIZ-11208 > URL: https://issues.apache.org/jira/browse/OFBIZ-11208 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11208) OrderReadHelper.getOrderItemAttributes as non static function
Nicolas Malin created OFBIZ-11208: - Summary: OrderReadHelper.getOrderItemAttributes as non static function Key: OFBIZ-11208 URL: https://issues.apache.org/jira/browse/OFBIZ-11208 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Trunk Reporter: Nicolas Malin -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7664) Inconsistencies on the title and the label on button of create forms.
[ https://issues.apache.org/jira/browse/OFBIZ-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936627#comment-16936627 ] Jacques Le Roux commented on OFBIZ-7664: Thanks Swapnil > Inconsistencies on the title and the label on button of create forms. > - > > Key: OFBIZ-7664 > URL: https://issues.apache.org/jira/browse/OFBIZ-7664 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Rahul bhammarker >Assignee: Rahul bhammarker >Priority: Minor > Fix For: 17.12.01, 16.11.07, 18.12.01 > > > There are inconsistencies in the form title and the action label on the the > button of create forms such as Catalog > Products > New Product > the form title is "Edit Product" and the button label is "Create Product". > There are various fomrs like this in other components. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-7664) Inconsistencies on the title and the label on button of create forms.
[ https://issues.apache.org/jira/browse/OFBIZ-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7664. -- Fix Version/s: 18.12.01 16.11.07 17.12.01 Resolution: Fixed > Inconsistencies on the title and the label on button of create forms. > - > > Key: OFBIZ-7664 > URL: https://issues.apache.org/jira/browse/OFBIZ-7664 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Rahul bhammarker >Assignee: Rahul bhammarker >Priority: Minor > Fix For: 17.12.01, 16.11.07, 18.12.01 > > > There are inconsistencies in the form title and the action label on the the > button of create forms such as Catalog > Products > New Product > the form title is "Edit Product" and the button label is "Create Product". > There are various fomrs like this in other components. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma reassigned OFBIZ-10111: Assignee: Priya Sharma > The child event added is not listed in the Child Work Efforts. While if we > add an existing event it is listed in the WorkEffort component > - > > Key: OFBIZ-10111 > URL: https://issues.apache.org/jira/browse/OFBIZ-10111 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-10111.patch, screenshot-1.png > > > Steps to regenerate: > 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events] > 2) Click on the event created. > 3) To create the child events, click on the "Children" button. > 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill > in the details of the child events. Click on the Save button. > Actual: The child event added is not listed in the Child Work Efforts. While > if we add an existing event it is listed. > 5) Open URL > [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001] > 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details > below" label is repeated twice. > Note: ScreenShot Attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11207) Send upload form with even-update-area doesn't works
[
https://issues.apache.org/jira/browse/OFBIZ-11207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-11207.
-
Fix Version/s: 18.12.01
Upcoming Branch
17.12.01
Resolution: Fixed
Commited at :
* trunk 1867435
* 18.12 1867437
* 17.12 1867438
Thanks to Samuel Trégouët for the correction
> Send upload form with even-update-area doesn't works
>
>
> Key: OFBIZ-11207
> URL: https://issues.apache.org/jira/browse/OFBIZ-11207
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk, 17.12.01, Release Branch 18.12
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Fix For: 17.12.01, Upcoming Branch, 18.12.01
>
> Attachments: OFBIZ-11207.patch
>
>
> When you create a xml form with upload as type, you can't use
> on-event-update-area element to submit it by ajax.
> Otherwise, OFBiz return an error message on 'uploadFile is empty.'
> To solve it, Samuel Tregouet suggest to analyse the enctype's form before
> submit to move on FormData instead a direct serialize [1]
> {code}
>
> ...
> area-target="FileDisplaying"/>
> {code}
> [1]
> https://developer.mozilla.org/en-US/docs/Web/API/FormData/Using_FormData_Objects
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11206) Edit the user login security question from party profile
[ https://issues.apache.org/jira/browse/OFBIZ-11206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936520#comment-16936520 ] Nicolas Malin commented on OFBIZ-11206: --- Right, I will add a control in this way > Edit the user login security question from party profile > > > Key: OFBIZ-11206 > URL: https://issues.apache.org/jira/browse/OFBIZ-11206 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Attachments: OFBIZ-11206.patch, OFBIZ-11206.patch > > > Currenlty we have a system to call a password hints when you lost your > password with answer to a security question linked to the userLogin. > The problem that you can only set this security question at the user login > creation and never create or edit it after. > I add with this issue: service, form, and label to edit it on the > ProfileEditUserLogin [1] page. > [1] > https://localhost:8443/partymgr/control/ProfileEditUserLogin?partyId=admin=admin -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7664) Inconsistencies on the title and the label on button of create forms.
[ https://issues.apache.org/jira/browse/OFBIZ-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16936478#comment-16936478 ] Swapnil M Mane commented on OFBIZ-7664: --- [~jleroux] and team IMO, we should close this task. > Inconsistencies on the title and the label on button of create forms. > - > > Key: OFBIZ-7664 > URL: https://issues.apache.org/jira/browse/OFBIZ-7664 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Rahul bhammarker >Assignee: Rahul bhammarker >Priority: Minor > > There are inconsistencies in the form title and the action label on the the > button of create forms such as Catalog > Products > New Product > the form title is "Edit Product" and the button label is "Create Product". > There are various fomrs like this in other components. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-5441) URLs in PDF files are not handled correctly
[
https://issues.apache.org/jira/browse/OFBIZ-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Priya Sharma reassigned OFBIZ-5441:
---
Assignee: Priya Sharma
> URLs in PDF files are not handled correctly
> ---
>
> Key: OFBIZ-5441
> URL: https://issues.apache.org/jira/browse/OFBIZ-5441
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Priya Sharma
>Priority: Minor
>
> When a PDF file contains a reference to a promotion like when you buy a
> WG-5569 (Tiny Chrome Widget) and get a free WG- (Micro Chrome Widget).
> You end with a corresponding invoice containing < your favorite widgets and gizmos and get a free href="/ecommerce/control/product?category_id=20111product_id=WG-">Micro
> Chrome Widget!>> instead of a real link.
> It's possible to generare a link in a PDF with FOP, we need to
> # dynamically define a fop.base using a ftl transform refs:
> http://xmlgraphics.apache.org/fop/0.95/configuration.html#general-elements
> http://xmlgraphics.apache.org/fop/faq.html#MalformedURL
> # here is an example from ProductionRun.fo.ftl
> {code}
>
> external-destination="<@ofbizContentUrl>/content/control/ViewBinaryDataResource?dataResourceId=${productionRunContent.drDataResourceId}">${uiLabelMap.CommonView}
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
