[jira] [Commented] (OFBIZ-11192) Use ‘java.nio.file’ API instead of ‘java.io’ when manipulating files
[
https://issues.apache.org/jira/browse/OFBIZ-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950290#comment-16950290
]
Jacques Le Roux commented on OFBIZ-11192:
-
It's OK with me, do as you feel :)
> Use ‘java.nio.file’ API instead of ‘java.io’ when manipulating files
>
>
> Key: OFBIZ-11192
> URL: https://issues.apache.org/jira/browse/OFBIZ-11192
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11192_0001-Refactor-ComponentLoaderConfig-class.patch,
> OFBIZ-11192_0002-Convert-Config-ofbizHome-and-Config-logDir-.patch,
> OFBIZ-11192_0003-Use-java.nio.file-API-in-ComponentContainer.patch,
> OFBIZ-11192_0004-Refactor-ComponentContainer-loadComponentFr.patch,
> OFBIZ-11192_0005-Use-Path-for-component-config-rootLocation-.patch
>
>
> Since Java 1.7 the {{java.nio.file}} package provides a more modern way to
> manipulate the filesystem than {{java.io}}. For example the presence of a
> Path class allows more typesafe manipulation of file and directory names than
> using plain strings.
> Currently OFBiz uses {{java.io}} exclusively but it would improve safety,
> maintainability and readability to move to the new {{java.nio.file}} API
> instead.
> Some documentation regarding how to migrate to new API is available:
> * https://docs.oracle.com/javase/tutorial/essential/io/fileio.html
> * https://docs.oracle.com/javase/tutorial/essential/io/legacy.html#mapping
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11192) Use ‘java.nio.file’ API instead of ‘java.io’ when manipulating files
[
https://issues.apache.org/jira/browse/OFBIZ-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950285#comment-16950285
]
Mathieu Lirzin commented on OFBIZ-11192:
Hello Jacques,
Well actually this is a "background task" which is not completed yet. For
example {{UtilXml}} and {{FileUtil}} are still using the old API. I would find
it convenient to keep this issue open to avoid having to create a new ticket
each time I am contributing something related to topic.
However this is maybe not matching OFBiz JIRA conventions, So feel free to
propose an alternative process if that's the case.
> Use ‘java.nio.file’ API instead of ‘java.io’ when manipulating files
>
>
> Key: OFBIZ-11192
> URL: https://issues.apache.org/jira/browse/OFBIZ-11192
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11192_0001-Refactor-ComponentLoaderConfig-class.patch,
> OFBIZ-11192_0002-Convert-Config-ofbizHome-and-Config-logDir-.patch,
> OFBIZ-11192_0003-Use-java.nio.file-API-in-ComponentContainer.patch,
> OFBIZ-11192_0004-Refactor-ComponentContainer-loadComponentFr.patch,
> OFBIZ-11192_0005-Use-Path-for-component-config-rootLocation-.patch
>
>
> Since Java 1.7 the {{java.nio.file}} package provides a more modern way to
> manipulate the filesystem than {{java.io}}. For example the presence of a
> Path class allows more typesafe manipulation of file and directory names than
> using plain strings.
> Currently OFBiz uses {{java.io}} exclusively but it would improve safety,
> maintainability and readability to move to the new {{java.nio.file}} API
> instead.
> Some documentation regarding how to migrate to new API is available:
> * https://docs.oracle.com/javase/tutorial/essential/io/fileio.html
> * https://docs.oracle.com/javase/tutorial/essential/io/legacy.html#mapping
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes
[ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950278#comment-16950278 ] Jacques Le Roux commented on OFBIZ-11229: - Thanks Nicolas Your patch is in trunk r1868395 R18 r1868396 R17 r1868397 R16 is harder to backport I gave up. I wondered about duplicating convertToString(). But since the idea is to replace OfbizUrlTransform by UrlRegexpTransform it's not a problem. Note: I only created this issue as a bug because OFBIZ-4361 depends on it. Else it would be an improvement. > Merge UrlRegexpTransform and OfbizUrlTransform classes > -- > > Key: OFBIZ-11229 > URL: https://issues.apache.org/jira/browse/OFBIZ-11229 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch > > > This improvemnt follows Paul's suggestion and this discussion which contains > other references: > https://markmail.org/message/bobj2uhnkzjddrtt. > Globally can be summarised by my comment in this thread: > bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used > it everywhere. Now there are maybe few features in OfbizUrlTransform that are > not in UrlRegexpTransform. That needs to be checked. If we can merge > OfbizUrlTransform in UrlRegexpTransform then the later could be used > everywhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11192) Use ‘java.nio.file’ API instead of ‘java.io’ when manipulating files
[
https://issues.apache.org/jira/browse/OFBIZ-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950267#comment-16950267
]
Jacques Le Roux commented on OFBIZ-11192:
-
Hi Mathieu,
I only did a quick review of one patch, but I think we can close here, right?
> Use ‘java.nio.file’ API instead of ‘java.io’ when manipulating files
>
>
> Key: OFBIZ-11192
> URL: https://issues.apache.org/jira/browse/OFBIZ-11192
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11192_0001-Refactor-ComponentLoaderConfig-class.patch,
> OFBIZ-11192_0002-Convert-Config-ofbizHome-and-Config-logDir-.patch,
> OFBIZ-11192_0003-Use-java.nio.file-API-in-ComponentContainer.patch,
> OFBIZ-11192_0004-Refactor-ComponentContainer-loadComponentFr.patch,
> OFBIZ-11192_0005-Use-Path-for-component-config-rootLocation-.patch
>
>
> Since Java 1.7 the {{java.nio.file}} package provides a more modern way to
> manipulate the filesystem than {{java.io}}. For example the presence of a
> Path class allows more typesafe manipulation of file and directory names than
> using plain strings.
> Currently OFBiz uses {{java.io}} exclusively but it would improve safety,
> maintainability and readability to move to the new {{java.nio.file}} API
> instead.
> Some documentation regarding how to migrate to new API is available:
> * https://docs.oracle.com/javase/tutorial/essential/io/fileio.html
> * https://docs.oracle.com/javase/tutorial/essential/io/legacy.html#mapping
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-8869) Unit test case for service - ProcessRepairReplacementReturn
[ https://issues.apache.org/jira/browse/OFBIZ-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8869. -- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Avnindra and Suraj for your patches, Suraj your patch is in trunk at revision: 1868389 > Unit test case for service - ProcessRepairReplacementReturn > --- > > Key: OFBIZ-8869 > URL: https://issues.apache.org/jira/browse/OFBIZ-8869 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8869.patch, OFBIZ-8869.patch > > > Unit test case for service - ProcessRepairReplacementReturn -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-8869) Unit test case for service - ProcessRepairReplacementReturn
[ https://issues.apache.org/jira/browse/OFBIZ-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-8869: -- Assignee: Jacques Le Roux > Unit test case for service - ProcessRepairReplacementReturn > --- > > Key: OFBIZ-8869 > URL: https://issues.apache.org/jira/browse/OFBIZ-8869 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-8869.patch, OFBIZ-8869.patch > > > Unit test case for service - ProcessRepairReplacementReturn -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-8868) Unit test case for service - ProcessRefundReturnForReplacement
[ https://issues.apache.org/jira/browse/OFBIZ-8868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-8868. -- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Suraj, Your patch is in trunk at r1868388 > Unit test case for service - ProcessRefundReturnForReplacement > -- > > Key: OFBIZ-8868 > URL: https://issues.apache.org/jira/browse/OFBIZ-8868 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8868.patch, OFBIZ-8868.patch > > > Unit test case for service - ProcessRefundReturnForReplacement -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-8868) Unit test case for service - ProcessRefundReturnForReplacement
[ https://issues.apache.org/jira/browse/OFBIZ-8868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-8868: -- Assignee: Jacques Le Roux > Unit test case for service - ProcessRefundReturnForReplacement > -- > > Key: OFBIZ-8868 > URL: https://issues.apache.org/jira/browse/OFBIZ-8868 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Avnindra Sharma >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-8868.patch, OFBIZ-8868.patch > > > Unit test case for service - ProcessRefundReturnForReplacement -- This message was sent by Atlassian Jira (v8.3.4#803005)
