[jira] [Commented] (OFBIZ-10799) User is unable to update the review of product.
[ https://issues.apache.org/jira/browse/OFBIZ-10799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951634#comment-16951634 ] Deepak Dixit commented on OFBIZ-10799: -- After reviewing, I think it will not solve the reported issue. > User is unable to update the review of product. > --- > > Key: OFBIZ-10799 > URL: https://issues.apache.org/jira/browse/OFBIZ-10799 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Ashish Sharma >Assignee: Rohit Hukkeri >Priority: Major > Fix For: 17.12.01, 16.11.07, 18.12.01 > > Attachments: OFBIZ-10799-1.patch, OFBIZ-10799.patch, Screenshot > 2019-10-04 at 1.02.15 PM.png > > > *See: https://demo-trunk.ofbiz.apache.org/catalog/control/FindReviews* > > *Step to Reproduce* > # Login with valid username and password. > # Navigate to catalog->review. > # Search for product in which review is available or click on find. > # Click on update button. > *Expected Result:* User should be able to update the review of product. > *Actual Result:* Once click on update button. Blank screen is displayed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10799) User is unable to update the review of product.
[ https://issues.apache.org/jira/browse/OFBIZ-10799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951628#comment-16951628 ] Rohit Hukkeri edited comment on OFBIZ-10799 at 10/15/19 5:51 AM: - As per the discussion with Pawan, I have found that sending only the required parameters to search product reviews instead of searching a particular review will solve the issue. As after updating review user should have the same behaviour as earlier. Providing an updated patch consists of a redirect request with a minimal set of required parameters. Thanks, Deepak and Pawan for the valuable inputs. was (Author: rohit.hukkeri): As per the discussion with Pawan, I have found that sending only the required parameters to search product reviews instead of searching a particular review will solve the issue. As after updating review user should have the same behaviour as earlier. Providing an updated patch consists of a redirect request with minimal set of required parameters. > User is unable to update the review of product. > --- > > Key: OFBIZ-10799 > URL: https://issues.apache.org/jira/browse/OFBIZ-10799 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Ashish Sharma >Assignee: Rohit Hukkeri >Priority: Major > Fix For: 17.12.01, 16.11.07, 18.12.01 > > Attachments: OFBIZ-10799-1.patch, OFBIZ-10799.patch, Screenshot > 2019-10-04 at 1.02.15 PM.png > > > *See: https://demo-trunk.ofbiz.apache.org/catalog/control/FindReviews* > > *Step to Reproduce* > # Login with valid username and password. > # Navigate to catalog->review. > # Search for product in which review is available or click on find. > # Click on update button. > *Expected Result:* User should be able to update the review of product. > *Actual Result:* Once click on update button. Blank screen is displayed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10799) User is unable to update the review of product.
[ https://issues.apache.org/jira/browse/OFBIZ-10799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri updated OFBIZ-10799: -- Attachment: OFBIZ-10799-1.patch > User is unable to update the review of product. > --- > > Key: OFBIZ-10799 > URL: https://issues.apache.org/jira/browse/OFBIZ-10799 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12 >Reporter: Ashish Sharma >Assignee: Rohit Hukkeri >Priority: Major > Fix For: 17.12.01, 16.11.07, 18.12.01 > > Attachments: OFBIZ-10799-1.patch, OFBIZ-10799.patch, Screenshot > 2019-10-04 at 1.02.15 PM.png > > > *See: https://demo-trunk.ofbiz.apache.org/catalog/control/FindReviews* > > *Step to Reproduce* > # Login with valid username and password. > # Navigate to catalog->review. > # Search for product in which review is available or click on find. > # Click on update button. > *Expected Result:* User should be able to update the review of product. > *Actual Result:* Once click on update button. Blank screen is displayed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11252) FTL error for purchase order with Bulk Item Type
Devanshu Vyas created OFBIZ-11252:
-
Summary: FTL error for purchase order with Bulk Item Type
Key: OFBIZ-11252
URL: https://issues.apache.org/jira/browse/OFBIZ-11252
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: Trunk
Reporter: Devanshu Vyas
Steps to regenerate:
1. Login into the ordermgr application and click on Order Entry tab
2. Create PO with any supplier
3. Fill details and click on Continue
4. Now select Product Category with Item type Bulk and add the description and
Click on add to order
5. Finalize order with Finalize Order button
6. Add Term type, ship group option, etc details and create Order.
7. Scroll down to Order Items section and See the FTL error on the screen.
{code:java}
The following has evaluated to null or missing: ==> product [in template
"component://order/template/order/OrderItems.ftl" at line 252, column 71]
Tip: If the failing expression is known to legally refer to something that's
sometimes null or missing, either specify a default value like
myOptionalVar!myDefault, or use <#if
myOptionalVar??>when-present<#else>when-missing. (These only cover the last
step of the expression; to cover the whole expression, use parenthesis:
(myOptionalVar.foo)!myDefault, (myOptionalVar.foo)?? FTL stack trace
("~" means nesting-related): - Failed at: #if "SERVICE" ==
product.productTypeI... [in template
"component://order/template/order/OrderItems.ftl" at line 252, column 53]
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11251: --- Attachment: OFBIZ-11251-Use-checkstyle-linting-tool.patch > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11251: --- Attachment: (was: OFBIZ-11251-Use-checkstyle-linting-tool.patch) > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11251: --- Attachment: OFBIZ-11251-Use-checkstyle-linting-tool.patch > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11251: --- Attachment: (was: OFBIZ-11251-Use-checkstyle-linting-tool.patch) > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11251: --- Description: Linting [1] is a software engineering practice which make the code more readable and maintainable by improving its consistency and avoiding potential programming mistakes. Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which provides such facility. The lint actions are triggered when running ‘gradle check’. There are a lot reported errors that will need to be fixed incrementally in the future. We ensure that new errors will not be introduced by defining a global threshold of “allowed” errors corresponding to the sum of errors currently found in the framework and in the official plugins. [1] https://en.wikipedia.org/wiki/Lint_(software) [2] https://checkstyle.org/ [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html was: Linting [1] is a software engineering practice which make the code more readable and maintainable by improving its consistency and avoiding potential programming mistakes. Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which provides such facility. The lint actions are triggered when running ‘gradle check’. There are a lot reported errors that will need to be fixed incrementally in the future. We ensure that new errors will not be introduced by defining a global threshold of 41546 “allowed” errors corresponding to the sum of errors currently found in the framework and in the official plugins. [1] https://en.wikipedia.org/wiki/Lint_(software) [2] https://checkstyle.org/ [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11251: --- Attachment: OFBIZ-11251-Use-checkstyle-linting-tool.patch > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of 41546 “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11251: --- Attachment: (was: OFBIZ-11251-Use-checkstyle-linting-tool.patch) > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of 41546 “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin reassigned OFBIZ-11251: -- Assignee: Mathieu Lirzin > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of 41546 “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11251: --- Attachment: OFBIZ-11251-Use-checkstyle-linting-tool.patch > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11251-Use-checkstyle-linting-tool.patch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of 41546 “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11251) Use ‘checkstyle’ linting tool
[ https://issues.apache.org/jira/browse/OFBIZ-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11251: --- Description: Linting [1] is a software engineering practice which make the code more readable and maintainable by improving its consistency and avoiding potential programming mistakes. Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which provides such facility. The lint actions are triggered when running ‘gradle check’. There are a lot reported errors that will need to be fixed incrementally in the future. We ensure that new errors will not be introduced by defining a global threshold of 41546 “allowed” errors corresponding to the sum of errors currently found in the framework and in the official plugins. [1] https://en.wikipedia.org/wiki/Lint_(software) [2] https://checkstyle.org/ [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html was: Linting [1] is a software engineering practice which make the code more readable and maintainable by improving its consistency and avoiding potential programming mistakes. Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which provides such facility. The lint actions are triggered when running ‘gradle check’. There are a lot reported errors that will need to be fixed incrementally in the future. We ensure that new errors will not be introduced by defining a global threshold of 41546 “allowed” errors corresponding to the sum of errors currently found in the framework and in the official plugins. > Use ‘checkstyle’ linting tool > - > > Key: OFBIZ-11251 > URL: https://issues.apache.org/jira/browse/OFBIZ-11251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Priority: Minor > Fix For: Upcoming Branch > > > Linting [1] is a software engineering practice which make the code > more readable and maintainable by improving its consistency and > avoiding potential programming mistakes. > Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which > provides such facility. The lint actions are triggered when running > ‘gradle check’. > There are a lot reported errors that will need to be fixed > incrementally in the future. We ensure that new errors will not be > introduced by defining a global threshold of 41546 “allowed” errors > corresponding to the sum of errors currently found in the framework > and in the official plugins. > [1] https://en.wikipedia.org/wiki/Lint_(software) > [2] https://checkstyle.org/ > [3] https://docs.gradle.org/current/userguide/checkstyle_plugin.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11251) Use ‘checkstyle’ linting tool
Mathieu Lirzin created OFBIZ-11251: -- Summary: Use ‘checkstyle’ linting tool Key: OFBIZ-11251 URL: https://issues.apache.org/jira/browse/OFBIZ-11251 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Mathieu Lirzin Fix For: Upcoming Branch Linting [1] is a software engineering practice which make the code more readable and maintainable by improving its consistency and avoiding potential programming mistakes. Gradle provides a core plugin for the ‘checkstyle’ tool [2][3] which provides such facility. The lint actions are triggered when running ‘gradle check’. There are a lot reported errors that will need to be fixed incrementally in the future. We ensure that new errors will not be introduced by defining a global threshold of 41546 “allowed” errors corresponding to the sum of errors currently found in the framework and in the official plugins. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11248) Convert AutoAcctgAgreementTests Unit Tests from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11248. --- Fix Version/s: Upcoming Branch Resolution: Implemented Works well, Thanks Devanshu for your contribution. Your slightly modified patch is in Trunk at r#1868449. > Convert AutoAcctgAgreementTests Unit Tests from XML to Groovy > - > > Key: OFBIZ-11248 > URL: https://issues.apache.org/jira/browse/OFBIZ-11248 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11248.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11248) Convert AutoAcctgAgreementTests Unit Tests from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11248: --- Assignee: Pawan Verma > Convert AutoAcctgAgreementTests Unit Tests from XML to Groovy > - > > Key: OFBIZ-11248 > URL: https://issues.apache.org/jira/browse/OFBIZ-11248 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11248.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11250) Getting a warning while testing a unit test case
Devanshu Vyas created OFBIZ-11250: - Summary: Getting a warning while testing a unit test case Key: OFBIZ-11250 URL: https://issues.apache.org/jira/browse/OFBIZ-11250 Project: OFBiz Issue Type: Bug Reporter: Devanshu Vyas While converting a XML unit test case to groovy, I encountered this warning after the test case successful completion. WARNING: The web application [ebay] appears to have started a thread named [Log4j2-TF-8-Scheduled-2] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread: sun.misc.Unsafe.park(Native Method) java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215) java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078) java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:1093) java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:809) java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) java.lang.Thread.run(Thread.java:748) Oct 14, 2019 3:44:32 PM org.apache.catalina.loader.WebappClassLoaderBase clearReferencesThreads WARNING: The web application [ebay] appears to have started a thread named [AsyncAppender-async] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread: sun.misc.Unsafe.park(Native Method) java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) java.util.concurrent.ArrayBlockingQueue.take(ArrayBlockingQueue.java:403) org.apache.logging.log4j.core.appender.AsyncAppender$AsyncThread.run(AsyncAppender.java:398) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11250) Getting a warning while testing a unit test case
[ https://issues.apache.org/jira/browse/OFBIZ-11250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950986#comment-16950986 ] Devanshu Vyas commented on OFBIZ-11250: --- I found this log while working on the OFBIZ-11248 ticket. > Getting a warning while testing a unit test case > > > Key: OFBIZ-11250 > URL: https://issues.apache.org/jira/browse/OFBIZ-11250 > Project: OFBiz > Issue Type: Bug >Reporter: Devanshu Vyas >Priority: Trivial > > While converting a XML unit test case to groovy, I encountered this warning > after the test case successful completion. > > WARNING: The web application [ebay] appears to have started a thread named > [Log4j2-TF-8-Scheduled-2] but has failed to stop it. This is very likely to > create a memory leak. Stack trace of thread: > sun.misc.Unsafe.park(Native Method) > java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215) > > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078) > > java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:1093) > > java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:809) > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074) > > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134) > > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > java.lang.Thread.run(Thread.java:748) > Oct 14, 2019 3:44:32 PM org.apache.catalina.loader.WebappClassLoaderBase > clearReferencesThreads > WARNING: The web application [ebay] appears to have started a thread named > [AsyncAppender-async] but has failed to stop it. This is very likely to > create a memory leak. Stack trace of thread: > sun.misc.Unsafe.park(Native Method) > java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) > > java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039) > java.util.concurrent.ArrayBlockingQueue.take(ArrayBlockingQueue.java:403) > > org.apache.logging.log4j.core.appender.AsyncAppender$AsyncThread.run(AsyncAppender.java:398) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11248) Convert AutoAcctgAgreementTests Unit Tests from XML to Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950983#comment-16950983
]
Devanshu Vyas commented on OFBIZ-11248:
---
I have added a patch file for the unit test case. To test this, use the below
command.
{code:java}
./gradlew "ofbiz --test component=accounting --test suitename=accountingtests"
{code}
> Convert AutoAcctgAgreementTests Unit Tests from XML to Groovy
> -
>
> Key: OFBIZ-11248
> URL: https://issues.apache.org/jira/browse/OFBIZ-11248
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11248.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11248) Convert AutoAcctgAgreementTests Unit Tests from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devanshu Vyas updated OFBIZ-11248: -- Attachment: OFBIZ-11248.patch > Convert AutoAcctgAgreementTests Unit Tests from XML to Groovy > - > > Key: OFBIZ-11248 > URL: https://issues.apache.org/jira/browse/OFBIZ-11248 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11248.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11249) Upgrade Tomcat from 9.0.26 to 9.0.27
[ https://issues.apache.org/jira/browse/OFBIZ-11249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950885#comment-16950885 ] Jacques Le Roux commented on OFBIZ-11249: - Done at r1868437. That's where you see how the Tomcat team takes care of their users :) > Upgrade Tomcat from 9.0.26 to 9.0.27 > > > Key: OFBIZ-11249 > URL: https://issues.apache.org/jira/browse/OFBIZ-11249 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > I noticed in the announce: > bq. Update to Commons Daemon 1.2.2 to pick up the fix for a regression in > Commons Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when > running on a Windows OS that had not been fully updated. > I did not cross it though I use a Windows 7 which can no longer be completly > updated for 2 years (yes you can), better be safe than sorry -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11249) Upgrade Tomcat from 9.0.26 to 9.0.27
[ https://issues.apache.org/jira/browse/OFBIZ-11249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11249. --- Resolution: Done > Upgrade Tomcat from 9.0.26 to 9.0.27 > > > Key: OFBIZ-11249 > URL: https://issues.apache.org/jira/browse/OFBIZ-11249 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > I noticed in the announce: > bq. Update to Commons Daemon 1.2.2 to pick up the fix for a regression in > Commons Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when > running on a Windows OS that had not been fully updated. > I did not cross it though I use a Windows 7 which can no longer be completly > updated for 2 years (yes you can), better be safe than sorry -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11249) Upgrade Tomcat from 9.0.26 to 9.0.27
Jacques Le Roux created OFBIZ-11249: --- Summary: Upgrade Tomcat from 9.0.26 to 9.0.27 Key: OFBIZ-11249 URL: https://issues.apache.org/jira/browse/OFBIZ-11249 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: Upcoming Branch I noticed in the announce: bq. Update to Commons Daemon 1.2.2 to pick up the fix for a regression in Commons Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when running on a Windows OS that had not been fully updated. I did not cross it though I use a Windows 7 which can no longer be completly updated for 2 years (yes you can), better be safe than sorry -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11248) Convert AutoAcctgAgreementTests Unit Tests from XML to Groovy
Pawan Verma created OFBIZ-11248: --- Summary: Convert AutoAcctgAgreementTests Unit Tests from XML to Groovy Key: OFBIZ-11248 URL: https://issues.apache.org/jira/browse/OFBIZ-11248 Project: OFBiz Issue Type: Sub-task Affects Versions: Trunk Reporter: Pawan Verma -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11247) Providing utilities for integration tests
[
https://issues.apache.org/jira/browse/OFBIZ-11247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950873#comment-16950873
]
Jacques Le Roux commented on OFBIZ-11247:
-
First step to simply using "userLogin" in tests implemeted at revision: 1868436
> Providing utilities for integration tests
> -
>
> Key: OFBIZ-11247
> URL: https://issues.apache.org/jira/browse/OFBIZ-11247
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS, framework
>Reporter: Jacques Le Roux
>Priority: Minor
>
> At https://markmail.org/message/bdf4ntvwwdl4hxtx [~mthl] suggested:
> {quote}
> In order to avoid repetitive code a nice first helper method would be
> for example one for retrieving the default userLogin like what is done
> in 'QuoteTests.groovy'
> {code:java}
> // Retrieves a particular login record.
> GenericValue getUserLogin(String userLoginId) {
> GenericValue userLogin = EntityQuery.use(delegator)
> .from('UserLogin').where(userLoginId: userLoginId).queryOne()
> assert userLogin
> return userLogin
> }
> {code}
> We could even add a default login user.
> {code:java}
> // Retrieves the default login record.
> GenericValue getUserLogin() {
> return getUserLogin('system');
> }
> {code}
> I guess we should add such method directly in the 'OFBizTestCase' class
> to be able to reuse it in all test cases and avoid having to pass the
> 'delegator' and 'dispatcher' as method arguments.
> The creation of the service input map of your example would look like
> this:
> {code:java}
> void testSendOrderChangeNotification() {
> Map serviceCtx = [
> orderId: 'TEST_DEMO10090',
> sendTo: 'test_em...@example.com',
> userLogin: getUserLogin()
> ]
> Map serviceResult =
> dispatcher.runSync('sendOrderChangeNotification', serviceCtx)
> assert ServiceUtil.isSuccess(serviceResult)
> assert serviceResult.emailType.equals("PRDS_ODR_CHANGE")
> }
> {code}
> In any case I think that finding the generic and reusable helper methods
> can be done incrementally.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11247) Providing utilities for integration tests
Jacques Le Roux created OFBIZ-11247:
---
Summary: Providing utilities for integration tests
Key: OFBIZ-11247
URL: https://issues.apache.org/jira/browse/OFBIZ-11247
Project: OFBiz
Issue Type: Improvement
Components: ALL APPLICATIONS, framework
Reporter: Jacques Le Roux
At https://markmail.org/message/bdf4ntvwwdl4hxtx [~mthl] suggested:
{quote}
In order to avoid repetitive code a nice first helper method would be
for example one for retrieving the default userLogin like what is done
in 'QuoteTests.groovy'
{code:java}
// Retrieves a particular login record.
GenericValue getUserLogin(String userLoginId) {
GenericValue userLogin = EntityQuery.use(delegator)
.from('UserLogin').where(userLoginId: userLoginId).queryOne()
assert userLogin
return userLogin
}
{code}
We could even add a default login user.
{code:java}
// Retrieves the default login record.
GenericValue getUserLogin() {
return getUserLogin('system');
}
{code}
I guess we should add such method directly in the 'OFBizTestCase' class
to be able to reuse it in all test cases and avoid having to pass the
'delegator' and 'dispatcher' as method arguments.
The creation of the service input map of your example would look like
this:
{code:java}
void testSendOrderChangeNotification() {
Map serviceCtx = [
orderId: 'TEST_DEMO10090',
sendTo: 'test_em...@example.com',
userLogin: getUserLogin()
]
Map serviceResult = dispatcher.runSync('sendOrderChangeNotification',
serviceCtx)
assert ServiceUtil.isSuccess(serviceResult)
assert serviceResult.emailType.equals("PRDS_ODR_CHANGE")
}
{code}
In any case I think that finding the generic and reusable helper methods
can be done incrementally.
{quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11247) Providing utilities for integration tests
[
https://issues.apache.org/jira/browse/OFBIZ-11247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950845#comment-16950845
]
Jacques Le Roux commented on OFBIZ-11247:
-
We can start with above Mathieu's proposition
> Providing utilities for integration tests
> -
>
> Key: OFBIZ-11247
> URL: https://issues.apache.org/jira/browse/OFBIZ-11247
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS, framework
>Reporter: Jacques Le Roux
>Priority: Minor
>
> At https://markmail.org/message/bdf4ntvwwdl4hxtx [~mthl] suggested:
> {quote}
> In order to avoid repetitive code a nice first helper method would be
> for example one for retrieving the default userLogin like what is done
> in 'QuoteTests.groovy'
> {code:java}
> // Retrieves a particular login record.
> GenericValue getUserLogin(String userLoginId) {
> GenericValue userLogin = EntityQuery.use(delegator)
> .from('UserLogin').where(userLoginId: userLoginId).queryOne()
> assert userLogin
> return userLogin
> }
> {code}
> We could even add a default login user.
> {code:java}
> // Retrieves the default login record.
> GenericValue getUserLogin() {
> return getUserLogin('system');
> }
> {code}
> I guess we should add such method directly in the 'OFBizTestCase' class
> to be able to reuse it in all test cases and avoid having to pass the
> 'delegator' and 'dispatcher' as method arguments.
> The creation of the service input map of your example would look like
> this:
> {code:java}
> void testSendOrderChangeNotification() {
> Map serviceCtx = [
> orderId: 'TEST_DEMO10090',
> sendTo: 'test_em...@example.com',
> userLogin: getUserLogin()
> ]
> Map serviceResult =
> dispatcher.runSync('sendOrderChangeNotification', serviceCtx)
> assert ServiceUtil.isSuccess(serviceResult)
> assert serviceResult.emailType.equals("PRDS_ODR_CHANGE")
> }
> {code}
> In any case I think that finding the generic and reusable helper methods
> can be done incrementally.
> {quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes
[ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950826#comment-16950826 ] Jacques Le Roux commented on OFBIZ-11229: - Ha forgot to mention that of course I did not put the general.properties in ;) > Merge UrlRegexpTransform and OfbizUrlTransform classes > -- > > Key: OFBIZ-11229 > URL: https://issues.apache.org/jira/browse/OFBIZ-11229 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch > > > This improvemnt follows Paul's suggestion and this discussion which contains > other references: > https://markmail.org/message/bobj2uhnkzjddrtt. > Globally can be summarised by my comment in this thread: > bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used > it everywhere. Now there are maybe few features in OfbizUrlTransform that are > not in UrlRegexpTransform. That needs to be checked. If we can merge > OfbizUrlTransform in UrlRegexpTransform then the later could be used > everywhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-9004) Unit test case for service - createAcctgTransEntry
[ https://issues.apache.org/jira/browse/OFBIZ-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9004. -- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Deepak, Suraj, Suraj, you patch is in trunk at revision: 1868433 > Unit test case for service - createAcctgTransEntry > --- > > Key: OFBIZ-9004 > URL: https://issues.apache.org/jira/browse/OFBIZ-9004 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-9004.patch, OFBIZ-9004.patch > > > Unit test case for service - createAcctgTransEntry -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-9004) Unit test case for service - createAcctgTransEntry
[ https://issues.apache.org/jira/browse/OFBIZ-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9004: -- Assignee: Jacques Le Roux (was: Suraj Khurana) > Unit test case for service - createAcctgTransEntry > --- > > Key: OFBIZ-9004 > URL: https://issues.apache.org/jira/browse/OFBIZ-9004 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-9004.patch, OFBIZ-9004.patch > > > Unit test case for service - createAcctgTransEntry -- This message was sent by Atlassian Jira (v8.3.4#803005)
