[jira] [Commented] (OFBIZ-11007) REST: adding segmented URI support
[
https://issues.apache.org/jira/browse/OFBIZ-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960155#comment-16960155
]
Mathieu Lirzin commented on OFBIZ-11007:
Committed [^restful_URIs.patch] in revision 1868963.
I have provided [^OFBIZ-11007_refactor-entitymaint.patch] which is an updated
version of [^entitymaint_example.patch]. Can someone familiar with OFBiz
screen incantations (Groovy/FTL/XML) take a look at it to check if the
implementation is correct?
> REST: adding segmented URI support
> --
>
> Key: OFBIZ-11007
> URL: https://issues.apache.org/jira/browse/OFBIZ-11007
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
> Environment:
>Reporter: Artemiy Rozovyk
>Assignee: Mathieu Lirzin
>Priority: Minor
> Labels: REST, URI
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11007_refactor-entitymaint.patch,
> entitymaint_example.patch, restful_URIs.patch
>
>
> Following the discussion on making OFBiz RESTful OFBIZ-4274 i implemented the
> support of segmented URIs without interfering with current mechanisms of URI
> resolution nor with _overrideView()_ feature.
> Combined with work on associating URIs and HTTP methods done by [~mthl] in
> OFBIZ-10438 , we are now able to provide RESTful APIs as follows:
> {code:java}
>
> ...
>
> ...
>
> ...
> {code}
> After we matched a request-map having parametrized URI as in
> {code:java}
> uri="foo/bar/{baz}"
> {code}
> the value is available inside the request attributes with the corresponding
> key (here _"baz"_)
> The *restful_URIs.patch* allows segmented URI support.
> The *entitymaint_example.patch* is a modified _entitymaint_ part that serves
> as an example of possible application of new system.
> Any questions or comments are welcomed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11007) REST: adding segmented URI support
[
https://issues.apache.org/jira/browse/OFBIZ-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11007:
---
Attachment: OFBIZ-11007_refactor-entitymaint.patch
> REST: adding segmented URI support
> --
>
> Key: OFBIZ-11007
> URL: https://issues.apache.org/jira/browse/OFBIZ-11007
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
> Environment:
>Reporter: Artemiy Rozovyk
>Assignee: Mathieu Lirzin
>Priority: Minor
> Labels: REST, URI
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11007_refactor-entitymaint.patch,
> entitymaint_example.patch, restful_URIs.patch
>
>
> Following the discussion on making OFBiz RESTful OFBIZ-4274 i implemented the
> support of segmented URIs without interfering with current mechanisms of URI
> resolution nor with _overrideView()_ feature.
> Combined with work on associating URIs and HTTP methods done by [~mthl] in
> OFBIZ-10438 , we are now able to provide RESTful APIs as follows:
> {code:java}
>
> ...
>
> ...
>
> ...
> {code}
> After we matched a request-map having parametrized URI as in
> {code:java}
> uri="foo/bar/{baz}"
> {code}
> the value is available inside the request attributes with the corresponding
> key (here _"baz"_)
> The *restful_URIs.patch* allows segmented URI support.
> The *entitymaint_example.patch* is a modified _entitymaint_ part that serves
> as an example of possible application of new system.
> Any questions or comments are welcomed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11007) REST: adding segmented URI support
[
https://issues.apache.org/jira/browse/OFBIZ-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin reassigned OFBIZ-11007:
--
Assignee: Mathieu Lirzin
> REST: adding segmented URI support
> --
>
> Key: OFBIZ-11007
> URL: https://issues.apache.org/jira/browse/OFBIZ-11007
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
> Environment:
>Reporter: Artemiy Rozovyk
>Assignee: Mathieu Lirzin
>Priority: Minor
> Labels: REST, URI
> Fix For: Upcoming Branch
>
> Attachments: entitymaint_example.patch, restful_URIs.patch
>
>
> Following the discussion on making OFBiz RESTful OFBIZ-4274 i implemented the
> support of segmented URIs without interfering with current mechanisms of URI
> resolution nor with _overrideView()_ feature.
> Combined with work on associating URIs and HTTP methods done by [~mthl] in
> OFBIZ-10438 , we are now able to provide RESTful APIs as follows:
> {code:java}
>
> ...
>
> ...
>
> ...
> {code}
> After we matched a request-map having parametrized URI as in
> {code:java}
> uri="foo/bar/{baz}"
> {code}
> the value is available inside the request attributes with the corresponding
> key (here _"baz"_)
> The *restful_URIs.patch* allows segmented URI support.
> The *entitymaint_example.patch* is a modified _entitymaint_ part that serves
> as an example of possible application of new system.
> Any questions or comments are welcomed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11007) REST: adding segmented URI support
[
https://issues.apache.org/jira/browse/OFBIZ-11007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mathieu Lirzin updated OFBIZ-11007:
---
Issue Type: New Feature (was: Improvement)
> REST: adding segmented URI support
> --
>
> Key: OFBIZ-11007
> URL: https://issues.apache.org/jira/browse/OFBIZ-11007
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
> Environment:
>Reporter: Artemiy Rozovyk
>Assignee: Mathieu Lirzin
>Priority: Minor
> Labels: REST, URI
> Fix For: Upcoming Branch
>
> Attachments: entitymaint_example.patch, restful_URIs.patch
>
>
> Following the discussion on making OFBiz RESTful OFBIZ-4274 i implemented the
> support of segmented URIs without interfering with current mechanisms of URI
> resolution nor with _overrideView()_ feature.
> Combined with work on associating URIs and HTTP methods done by [~mthl] in
> OFBIZ-10438 , we are now able to provide RESTful APIs as follows:
> {code:java}
>
> ...
>
> ...
>
> ...
> {code}
> After we matched a request-map having parametrized URI as in
> {code:java}
> uri="foo/bar/{baz}"
> {code}
> the value is available inside the request attributes with the corresponding
> key (here _"baz"_)
> The *restful_URIs.patch* allows segmented URI support.
> The *entitymaint_example.patch* is a modified _entitymaint_ part that serves
> as an example of possible application of new system.
> Any questions or comments are welcomed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process
[
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959867#comment-16959867
]
Gil Portenseigne commented on OFBIZ-11204:
--
Thanks [~jleroux] and [~mthl] for your feedbacks :)
> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11204.patch, OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2
> |GenericDelegator |E| Failure in create operation for entity
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
> (SQL Exception while executing the following:INSERT INTO
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD,
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP,
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value
> violates unique constraint "pk_service_semaphore" Detail: Key
> (service_name)=(xxx) already exists.)). Rolling back transaction.
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2
> |ServiceSemaphore |E| null
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException:
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting:
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19
>
[jira] [Closed] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process
[
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gil Portenseigne closed OFBIZ-11204.
Fix Version/s: Trunk
Resolution: Fixed
Commited in trunk r1868942
> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11204.patch, OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2
> |GenericDelegator |E| Failure in create operation for entity
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
> (SQL Exception while executing the following:INSERT INTO
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD,
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP,
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value
> violates unique constraint "pk_service_semaphore" Detail: Key
> (service_name)=(xxx) already exists.)). Rolling back transaction.
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2
> |ServiceSemaphore |E| null
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException:
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting:
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19
>
[jira] [Updated] (OFBIZ-11260) remove ServiceEventHandler.checkSecureParameter
[ https://issues.apache.org/jira/browse/OFBIZ-11260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samuel Trégouët updated OFBIZ-11260: Attachment: 01-lint.patch 02-remove-checkSecureParameter.patch > remove ServiceEventHandler.checkSecureParameter > --- > > Key: OFBIZ-11260 > URL: https://issues.apache.org/jira/browse/OFBIZ-11260 > Project: OFBiz > Issue Type: Bug >Reporter: Samuel Trégouët >Priority: Minor > Attachments: 01-lint.patch, 02-remove-checkSecureParameter.patch > > > As discussed on d...@ofbiz.apache.org [1] I see no reason to keep this > function, so I suggest to remove it (patch attached with some checkstyle > linting recommendatione applied) > > > [1] > https://lists.apache.org/thread.html/a59689954e2ef5ad8289bfda70bc54ad795dcff6bd12d5aa11755ca4@%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11260) remove ServiceEventHandler.checkSecureParameter
Samuel Trégouët created OFBIZ-11260: --- Summary: remove ServiceEventHandler.checkSecureParameter Key: OFBIZ-11260 URL: https://issues.apache.org/jira/browse/OFBIZ-11260 Project: OFBiz Issue Type: Bug Reporter: Samuel Trégouët As discussed on d...@ofbiz.apache.org [1] I see no reason to keep this function, so I suggest to remove it (patch attached with some checkstyle linting recommendatione applied) [1] https://lists.apache.org/thread.html/a59689954e2ef5ad8289bfda70bc54ad795dcff6bd12d5aa11755ca4@%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-11236: - Assignee: Aditya Sharma > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Aditya Sharma >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11045) Activate / Finish EmplPositionType ValidResponsibilities
[ https://issues.apache.org/jira/browse/OFBIZ-11045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-11045. - Fix Version/s: (was: Trunk) 18.12.01 Resolution: Done > Activate / Finish EmplPositionType ValidResponsibilities > > > Key: OFBIZ-11045 > URL: https://issues.apache.org/jira/browse/OFBIZ-11045 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Aditya Sharma >Priority: Major > Labels: humanres > Fix For: 18.12.01 > > Attachments: OFBIZ_11045.patch > > > Most of code / form / screen exist to manage EmpPositionType, but > * one menu item is missing > * screen menu field are forgot > * entity name is wrong in the entityCondition in Form > Included Patch contain corrections for that points -- This message was sent by Atlassian Jira (v8.3.4#803005)
