[jira] [Closed] (OFBIZ-11277) Convert AutoAcctgInvoiceTests Unit Test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11277. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks, [~jleroux] for the review. > Convert AutoAcctgInvoiceTests Unit Test from XML to Groovy > -- > > Key: OFBIZ-11277 > URL: https://issues.apache.org/jira/browse/OFBIZ-11277 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11277.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11274) Cannot set property 'value' of null in lookup.js set_multivalues() function
[
https://issues.apache.org/jira/browse/OFBIZ-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971311#comment-16971311
]
Aditya Sharma commented on OFBIZ-11274:
---
Give me some time, I will give it try.
> Cannot set property 'value' of null in lookup.js set_multivalues() function
> ---
>
> Key: OFBIZ-11274
> URL: https://issues.apache.org/jira/browse/OFBIZ-11274
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Priority: Major
> Labels: pull-request-available
> Attachments: OFBIZ-11274-lookup-set-multi.patch
>
>
> Reference to the thread on dev list:
> [https://ofbiz.markmail.org/thread/3j7cndhig5oknknq]
> Attempts to call lookup.js function set_multivalues() from a lookup screen
> fail with the console logging error:
> {noformat}
> Uncaught TypeError: Cannot set property 'value' of null
> at set_multivalues (fieldlookup.js:769)
> at :1:1{noformat}
> No framework or plugins appear to currently use this function.
> The set_multivalues() function should be useful for populating multiple
> fields (e.g. a Postal Address) on a form from a lookup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11274) Cannot set property 'value' of null in lookup.js set_multivalues() function
[
https://issues.apache.org/jira/browse/OFBIZ-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma updated OFBIZ-11274:
--
Description:
Reference to the thread on dev list:
[https://ofbiz.markmail.org/thread/3j7cndhig5oknknq]
Attempts to call lookup.js function set_multivalues() from a lookup screen fail
with the console logging error:
{noformat}
Uncaught TypeError: Cannot set property 'value' of null
at set_multivalues (fieldlookup.js:769)
at :1:1{noformat}
No framework or plugins appear to currently use this function.
The set_multivalues() function should be useful for populating multiple fields
(e.g. a Postal Address) on a form from a lookup.
was:
Attempts to call lookup.js function set_multivalues() from a lookup screen fail
with the console logging error:
{noformat}
Uncaught TypeError: Cannot set property 'value' of null
at set_multivalues (fieldlookup.js:769)
at :1:1{noformat}
No framework or plugins appear to currently use this function.
The set_multivalues() function should be useful for populating multiple fields
(e.g. a Postal Address) on a form from a lookup.
> Cannot set property 'value' of null in lookup.js set_multivalues() function
> ---
>
> Key: OFBIZ-11274
> URL: https://issues.apache.org/jira/browse/OFBIZ-11274
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Priority: Major
> Labels: pull-request-available
> Attachments: OFBIZ-11274-lookup-set-multi.patch
>
>
> Reference to the thread on dev list:
> [https://ofbiz.markmail.org/thread/3j7cndhig5oknknq]
> Attempts to call lookup.js function set_multivalues() from a lookup screen
> fail with the console logging error:
> {noformat}
> Uncaught TypeError: Cannot set property 'value' of null
> at set_multivalues (fieldlookup.js:769)
> at :1:1{noformat}
> No framework or plugins appear to currently use this function.
> The set_multivalues() function should be useful for populating multiple
> fields (e.g. a Postal Address) on a form from a lookup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11274) Cannot set property 'value' of null in lookup.js set_multivalues() function
[
https://issues.apache.org/jira/browse/OFBIZ-11274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971213#comment-16971213
]
Daniel Watford commented on OFBIZ-11274:
[~mthl] I've not been able to find a good candidate lookup that would benefit
from using set_multvalues. This might suggest it isn't really needed, or might
just be down to my lack of experience with the various ofbiz components.
Thinking on this further, perhaps having the lookup form specify the inputs to
be populated (as is the case with set_multivalues) would couple the lookup form
and calling page too tightly, and might be something to be discouraged.
Having lookup forms limited to calling set_value with with an ID value (and
possibly a description) might be enough. I can retrieve any other information
needed for display by hooking into the 'lookup:changed' jquery event fired when
a lookup field is updated.
I'm happy to close this ticket unless others have reason to explore
set_multivalues() further.
> Cannot set property 'value' of null in lookup.js set_multivalues() function
> ---
>
> Key: OFBIZ-11274
> URL: https://issues.apache.org/jira/browse/OFBIZ-11274
> Project: OFBiz
> Issue Type: Bug
> Components: themes
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Priority: Major
> Labels: pull-request-available
> Attachments: OFBIZ-11274-lookup-set-multi.patch
>
>
> Attempts to call lookup.js function set_multivalues() from a lookup screen
> fail with the console logging error:
> {noformat}
> Uncaught TypeError: Cannot set property 'value' of null
> at set_multivalues (fieldlookup.js:769)
> at :1:1{noformat}
> No framework or plugins appear to currently use this function.
> The set_multivalues() function should be useful for populating multiple
> fields (e.g. a Postal Address) on a form from a lookup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11253) Improve webtools/control/FindGeneric
[ https://issues.apache.org/jira/browse/OFBIZ-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-11253. - Resolution: Done Load it on trunk with commit 2c58133e50a61c8caf57aee47e1f786a8f3eaaa8 > Improve webtools/control/FindGeneric > > > Key: OFBIZ-11253 > URL: https://issues.apache.org/jira/browse/OFBIZ-11253 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Trivial > Attachments: ImproveFindGeneric.patch > > > Recently I updated the script to generate xml form to introduce new feature > like : > * set equals as operator by defaut on pk instead of contains > * add on tooltip the raw field name > * add possibility to filter on internal field > * add sort on column > During this work I also view that the ModelFormField contains an 'IF forest' > to analyse each field. I rewrited it to consolidate by type the analyze. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11277) Convert AutoAcctgInvoiceTests Unit Test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11277: --- Assignee: Pawan Verma (was: Jacques Le Roux) > Convert AutoAcctgInvoiceTests Unit Test from XML to Groovy > -- > > Key: OFBIZ-11277 > URL: https://issues.apache.org/jira/browse/OFBIZ-11277 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11277.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11277) Convert AutoAcctgInvoiceTests Unit Test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971106#comment-16971106 ] Jacques Le Roux commented on OFBIZ-11277: - Works for me, thanks Pawan: +1 > Convert AutoAcctgInvoiceTests Unit Test from XML to Groovy > -- > > Key: OFBIZ-11277 > URL: https://issues.apache.org/jira/browse/OFBIZ-11277 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11277.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11277) Convert AutoAcctgInvoiceTests Unit Test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11277: --- Assignee: Jacques Le Roux (was: Pawan Verma) > Convert AutoAcctgInvoiceTests Unit Test from XML to Groovy > -- > > Key: OFBIZ-11277 > URL: https://issues.apache.org/jira/browse/OFBIZ-11277 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11277.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11280) Invalid verify code for the New Product Announcements
Jacques Le Roux created OFBIZ-11280:
---
Summary: Invalid verify code for the New Product Announcements
Key: OFBIZ-11280
URL: https://issues.apache.org/jira/browse/OFBIZ-11280
Project: OFBiz
Issue Type: Bug
Components: ecommerce, product
Affects Versions: Trunk
Reporter: Jacques Le Roux
You need to set date to receive email, this is not the easiest part.
The same exists for the Newsletter.
The process is that
# you ask for New Product Announcements or subscribe to Newsletter on the
ecommerce main page (same in ecomseo)
# You then receive a 1st "Subscription Verify Email" email, saying "To complete
your subscription click the on the following link:"
# You click on the link saying "Please click here to verify your subscription."
# You then receive a 2nd "Subscribe Contact List New Product Announcements"
email saying "Successfully subscribed from New Product Announcements contact
list."
# You may click on a link saying "If this was by mistake, click here to
unsubscribe your subscription again."
# If you do, you receive a 3rd ""Verify Unsubscribe Contact List New Product
Announcements"" email saying "To complete your unsubscription click the on the
following link:"
# Then the error message, or a similar one for the newsletter, appears
#
The error in log is
{noformat}
2019-11-09 13:24:29,263 |jsse-nio-8443-exec-1 |ControlServlet
|T| [[[ecomseo::contactListOptOut (Domain:https://localhost)] Request Begun,
encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2019-11-09 13:24:29,263 |jsse-nio-8443-exec-1 |LoginWorker
|I| Running autoLogin check.
2019-11-09 13:24:29,282 |jsse-nio-8443-exec-1 |TransactionUtil
|W| Calling transaction setRollbackOnly; this stack trace shows where this is
happening:
java.lang.Exception: Error in simple-method [Update Add Party To ContactList No
User Login
[file:/C:/projectsASF/Git/ofbiz-framework/applications/marketing/minilang/marketing/contact/ContactListServices.xml#updateContactListPartyNoUserLo
gin]]: ; [Invalid verify code for the New Product Announcements]
at
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:358)
[main/:?]
at
org.apache.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:292)
[main/:?]
at org.apache.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:581)
[main/:?]
at
org.apache.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:274)
[main/:?]
at
org.apache.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:293)
[main/:?]
at
org.apache.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:79)
[main/:?]
at
org.apache.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:48)
[main/:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:417)
[main/:?]
at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
[main/:?]
at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
[main/:?]
at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:253)
[main/:?]
at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:819)
[main/:?]
at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:542)
[main/:?]
at
org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:232)
[main/:?]
at
org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:96)
[main/:?]
at
org.apache.ofbiz.product.category.SeoControlServlet.doGet(SeoControlServlet.java:88)
[main/:?]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
[javax.servlet-api-4.0.1.jar:4.0.1]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
[javax.servlet-api-4.0.1.jar:4.0.1]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
[tomcat-catalina-9.0.27.jar:9.0.27]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-9.0.27.jar:9.0.27]
at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
[tomcat-embed-websocket-9.0.27.jar:9.0.27]
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-9.0.27.jar:9.0.27]
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-9.0.27.jar:9.0.27]
at
org.apache.ofbiz.product.category.SeoContextFilter.doFilter(SeoContextFilter.java:223)
[main/:?]
at
[jira] [Closed] (OFBIZ-2330) Main task for securing URLs in Freemarker templates files
[ https://issues.apache.org/jira/browse/OFBIZ-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2330. -- Fix Version/s: 18.12.01 17.12.01 Assignee: Jacques Le Roux Resolution: Fixed All is done here, and after OFBIZ-11260 there is no point to let this open > Main task for securing URLs in Freemarker templates files > - > > Key: OFBIZ-2330 > URL: https://issues.apache.org/jira/browse/OFBIZ-2330 > Project: OFBiz > Issue Type: Task > Components: ALL COMPONENTS >Affects Versions: Release Branch 09.04, Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 18.12.01 > > > The idea is to create a new subtask for each issue reported. > This to avoid ending with a mess since a sole issue can be used for several > issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-9804) Link in verification email for Newsletter gives security error
[
https://issues.apache.org/jira/browse/OFBIZ-9804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-9804.
--
Fix Version/s: 18.12.01
17.12.01
Resolution: Fixed
Fixed in
trunk 045f97b
R18 8a0ae589
R17 ff75d41c
I changed ContactListEmailTemplate.ftl to also use GET. Because we dont' want a
form to ask, but only to hide parameters.
Handles the emails also in ecomseo after OFBIZ-11278
I have still to see why I get this message at the end of the process:
"Invalid verify code for the New Product Announcements"
ie when using the link in the last (3rd) email:
"Subscribe Contact List New Product Announcements"
This will be another Jira..!
> Link in verification email for Newsletter gives security error
> --
>
> Key: OFBIZ-9804
> URL: https://issues.apache.org/jira/browse/OFBIZ-9804
> Project: OFBiz
> Issue Type: Sub-task
> Components: ecommerce
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Aditya Sharma
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: screenshot-1.png
>
>
> Steps to generate:
> 1. Go to Ecommerce store https://localhost:8443/ecommerce/control/main
> 2. In "Sign Up For Contact List" panel from the left menu, select Newsletter,
> provide email and click on subscribe button.(Here you should have email
> configuration to receive email)
> 3. Click on the verification link in the email.
> It gives following error message
> {quote}The Following Errors Occurred:
> Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException:
> Found URL parameter [contactListId] passed to secure (https) request-map with
> uri [updateContactListPartyNoUserLogin] with an event that calls service
> [updateContactListPartyNoUserLogin]; this is not allowed for security
> reasons! The data should be encrypted by making it part of the request body
> (a form field) instead of the request URL. Moreover it would be kind if you
> could create a Jira sub-task of
> https://issues.apache.org/jira/browse/OFBIZ-2330 (check before if a sub-task
> for this error does not exist). If you are not sure how to create a Jira
> issue please have a look before at
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices
> Thank you in advance for your help.{quote}
> Try with the trunk link:
> https://demo-trunk.ofbiz.apache.org/ecommerce/control/updateContactListPartyNoUserLogin?contactListId=9000=_NA_=2017-10-04%2010:48:46.531=CLPT_ACCEPTED=9084207171=/ecommerce=10010
> Stable 16 link:
> https://demo-stable.ofbiz.apache.org/ecommerce/control/updateContactListPartyNoUserLogin?contactListId=9000=_NA_=2017-10-04%2010:48:46.531=CLPT_ACCEPTED=9084207171=/ecommerce=10010
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11278) SeoContextFilter.java is not able to handle query strings
[ https://issues.apache.org/jira/browse/OFBIZ-11278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971085#comment-16971085 ] Jacques Le Roux commented on OFBIZ-11278: - On Mathieu's request on dev ml, in trunk 61ade2a R18 361c809d22 R17 0d6bfb2ca8 I removed a trailing blank (lint issue) and used empty to check request::getParameterMap result > SeoContextFilter.java is not able to handle query strings > - > > Key: OFBIZ-11278 > URL: https://issues.apache.org/jira/browse/OFBIZ-11278 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 18.12.01 > > > While working on OFBIZ-9804 I was confronted with misc. issues. One of them > was that SeoContextFilter.java was not handling query strings. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-2618) double forward slashes in ecommerce emails
[
https://issues.apache.org/jira/browse/OFBIZ-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-2618.
--
Fix Version/s: 18.12.01
17.12.01
Resolution: Fixed
Backported in
R18 c432d048
R17 6254c0ce
> double forward slashes in ecommerce emails
> --
>
> Key: OFBIZ-2618
> URL: https://issues.apache.org/jira/browse/OFBIZ-2618
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Release Branch 09.04, Trunk
>Reporter: BJ Freeman
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01, 14.12.01, 12.04.06, 13.07.02
>
> Attachments: OFBIZ-2618.patch, Ofbiz_2618_ecommerceEmail.patch
>
>
> in the widets
> value="${baseSecureUrl}/ecommerce/control/"/>
> has a trailing forward slash
> then the added url has a leading forward slash
> /orderstatus?orderId=
> so you get
> /ecommerce/control//orderstatus?orderId=
> removed the trailing forward slash
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11279) Equivalent of svn:auto-props properties on the server:
Jacques Le Roux created OFBIZ-11279: --- Summary: Equivalent of svn:auto-props properties on the server: Key: OFBIZ-11279 URL: https://issues.apache.org/jira/browse/OFBIZ-11279 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux We should have an equivalent of svn:auto-props properties on the server: https://help.github.com/articles/dealing-with-line-endings/#per-repository-settings -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11276) Update the SvnCheckout Gradle task to use Github svn repo
[ https://issues.apache.org/jira/browse/OFBIZ-11276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11276: Summary: Update the SvnCheckout Gradle task to use Github svn repo (was: Update the SvnCheckout Gradle task to used Github svn repo) > Update the SvnCheckout Gradle task to use Github svn repo > - > > Key: OFBIZ-11276 > URL: https://issues.apache.org/jira/browse/OFBIZ-11276 > Project: OFBiz > Issue Type: Sub-task > Components: Gradle >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 18.12.01 > > > While working on the RAT build (OFBIZ-11270). I used a Github specific > feature which allows to export a file from an automated mirrored svn repo > there. I have just used this feature to temporary fix the pull plugins source > tasks which were still relying on the now read-only ASF svn repo. -- This message was sent by Atlassian Jira (v8.3.4#803005)
