[jira] [Updated] (OFBIZ-11284) We have build problems in branches with plugins

2019-11-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11284:

Parent: OFBIZ-11268
Issue Type: Sub-task  (was: Bug)

> We have build problems in branches with plugins
> ---
>
> Key: OFBIZ-11284
> URL: https://issues.apache.org/jira/browse/OFBIZ-11284
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Release Branch 17.12, Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
>
> There are discrepancies between Gitbox and Github Subversion. Mostly diamond 
> use on Github Subversion not in Gitbox , and few others



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11284) We have build problems in branches with plugins

2019-11-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11284.
---
Fix Version/s: 18.12.01
   17.12.01
   Resolution: Fixed

Fixed with
R18 cab753894fe8
R17 8ea3cd238579

> We have build problems in branches with plugins
> ---
>
> Key: OFBIZ-11284
> URL: https://issues.apache.org/jira/browse/OFBIZ-11284
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12, Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
>
> There are discrepancies between Gitbox and Github Subversion. Mostly diamond 
> use on Github Subversion not in Gitbox , and few others



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11284) We have build problems in branches with plugins

2019-11-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16975184#comment-16975184
 ] 

Jacques Le Roux commented on OFBIZ-11284:
-

The problems is my trick of using Subversion over Github in build.gradle does 
not work (yet?) for branches (it stays at trunk). I'm looking at that...

> We have build problems in branches with plugins
> ---
>
> Key: OFBIZ-11284
> URL: https://issues.apache.org/jira/browse/OFBIZ-11284
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12, Release Branch 18.12
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> There are discrepancies between Gitbox and Github Subversion. Mostly diamond 
> use on Github Subversion not in Gitbox , and few others



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11284) We have build problems in branches with plugins

2019-11-15 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-11284:
---

 Summary: We have build problems in branches with plugins
 Key: OFBIZ-11284
 URL: https://issues.apache.org/jira/browse/OFBIZ-11284
 Project: OFBiz
  Issue Type: Bug
Affects Versions: Release Branch 17.12, Release Branch 18.12
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux


There are discrepancies between Gitbox and Github Subversion. Mostly diamond 
use on Github Subversion not in Gitbox , and few others



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11282) Fix the Buildbot config

2019-11-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11282.
---
Resolution: Fixed

Oops it's not that, we have build problems with branches 

> Fix the Buildbot config
> ---
>
> Key: OFBIZ-11282
> URL: https://issues.apache.org/jira/browse/OFBIZ-11282
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: BuildBot
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 17.12, Release Branch 18.12
>
>
> I thought all was OK with Buildbot because it went well when launched by hand 
> from IRC.
> But if you get to at https://ci.apache.org/waterfall and look for "ofb" you 
> will find that ofbizBranch17Framework and ofbizBranch18Framework have an 
> issue, the same.
> Though they use the same step for checkout than ofbizBranch17FrameworkPlugin 
> and ofbizBranch18FrameworkPlugin, for which it works.
> Also all builds need to be registered with Infra, they only work when 
> launched by hand from IRC.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11283) Number problem cancelling order item

2019-11-15 Thread Ingo Wolfmayr (Jira)
Ingo Wolfmayr created OFBIZ-11283:
-

 Summary: Number problem cancelling order item
 Key: OFBIZ-11283
 URL: https://issues.apache.org/jira/browse/OFBIZ-11283
 Project: OFBiz
  Issue Type: Bug
Reporter: Ingo Wolfmayr


If an order item has a quantity greater then 1000, cancelling the order item 
via the order form in backend does not work.

In the Demo (trunk) environment: the quantity of 1200 to cancel is displayed as 
"1,200" in the quantity input field.

--> an error is displayed

On my local installation I use a different locale and it is displayed as 
"1.200".

--> interprets the dot as a comma and the quantity of 1,2 is cancelled

To reproduce: go to ofbiz Demo

Create Order: Order Mgt --> Order Entry --> Sales Order (Customer: 
DemoCustomer) --> ProductId: GZ-2644, Quantity 1200 --> Finalize order

 

On order: Edit Items --> click checkbox next to quantity -->cancel selected 
items

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11281) Possible Nullpointer in StringUtil#strToMap

2019-11-15 Thread Ulrich Heidfeld (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974979#comment-16974979
 ] 

Ulrich Heidfeld commented on OFBIZ-11281:
-

Hello [~mthl],
 thanks for your teaching words. 
In our project, we are using something like:
 StringUtil.strToMap(UtilProperties.getPropertyValue(...))
If there is no according property value, an empty string will be returned.

I would prefer null instead of Collections.emptyMap as return value because we 
don't need to initiate a map if it has no informations in it. In addition, if a 
date time isn't set in properties, an empty value could be take as wrong date.

> Possible Nullpointer in StringUtil#strToMap
> ---
>
> Key: OFBIZ-11281
> URL: https://issues.apache.org/jira/browse/OFBIZ-11281
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Nicolas Malin
>Priority: Critical
> Fix For: 17.12.01, Upcoming Branch, 18.12.01
>
> Attachments: 
> OFBIZ-11281_Possible_Nullpointer_in_StringUtil#strToMap.patch
>
>
> StringUtil#strToMap(String, String, boolean, String) throws Nullpointer for 
> StringUtil.strToMap("", false).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (OFBIZ-11282) Fix the Buildbot config

2019-11-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-11282:
-

Actually it's quite weird it now works for framework only but no longer for 
framework+plugins.
The reason is perhaps that the branches parameter of scheduler is deprecated 
and we should rather user change_filter. Anyway, since it worked previously 
framework+plugins, back to the syntax I used then.

> Fix the Buildbot config
> ---
>
> Key: OFBIZ-11282
> URL: https://issues.apache.org/jira/browse/OFBIZ-11282
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: BuildBot
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 17.12, Release Branch 18.12
>
>
> I thought all was OK with Buildbot because it went well when launched by hand 
> from IRC.
> But if you get to at https://ci.apache.org/waterfall and look for "ofb" you 
> will find that ofbizBranch17Framework and ofbizBranch18Framework have an 
> issue, the same.
> Though they use the same step for checkout than ofbizBranch17FrameworkPlugin 
> and ofbizBranch18FrameworkPlugin, for which it works.
> Also all builds need to be registered with Infra, they only work when 
> launched by hand from IRC.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11282) Fix the Buildbot config

2019-11-15 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11282.
---
Fix Version/s: Release Branch 18.12
   Release Branch 17.12
 Assignee: Jacques Le Roux
   Resolution: Fixed

It's OK now the branches schedulers needed a change. Now waiting for Infra

> Fix the Buildbot config
> ---
>
> Key: OFBIZ-11282
> URL: https://issues.apache.org/jira/browse/OFBIZ-11282
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: BuildBot
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 17.12, Release Branch 18.12
>
>
> I thought all was OK with Buildbot because it went well when launched by hand 
> from IRC.
> But if you get to at https://ci.apache.org/waterfall and look for "ofb" you 
> will find that ofbizBranch17Framework and ofbizBranch18Framework have an 
> issue, the same.
> Though they use the same step for checkout than ofbizBranch17FrameworkPlugin 
> and ofbizBranch18FrameworkPlugin, for which it works.
> Also all builds need to be registered with Infra, they only work when 
> launched by hand from IRC.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11253) Improve webtools/control/FindGeneric

2019-11-15 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-11253.

Resolution: Implemented

Closing ticket with correct resolution per project's convention.

> Improve webtools/control/FindGeneric
> 
>
> Key: OFBIZ-11253
> URL: https://issues.apache.org/jira/browse/OFBIZ-11253
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: ImproveFindGeneric.patch
>
>
> Recently I updated the script to generate xml form to introduce new feature 
> like :
> * set equals as operator by defaut on pk instead of contains
> * add on tooltip the raw field name
> * add possibility to filter on internal field
> * add sort on column
> During this work I also view that the ModelFormField contains an 'IF forest' 
> to analyse each field. I rewrited it to consolidate by type the analyze.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (OFBIZ-11253) Improve webtools/control/FindGeneric

2019-11-15 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reopened OFBIZ-11253:
--

Reopening ticket to set correct resolution as per project's convention for 
improvements.

> Improve webtools/control/FindGeneric
> 
>
> Key: OFBIZ-11253
> URL: https://issues.apache.org/jira/browse/OFBIZ-11253
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: ImproveFindGeneric.patch
>
>
> Recently I updated the script to generate xml form to introduce new feature 
> like :
> * set equals as operator by defaut on pk instead of contains
> * add on tooltip the raw field name
> * add possibility to filter on internal field
> * add sort on column
> During this work I also view that the ModelFormField contains an 'IF forest' 
> to analyse each field. I rewrited it to consolidate by type the analyze.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11282) Fix the Buildbot config

2019-11-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16974922#comment-16974922
 ] 

Jacques Le Roux commented on OFBIZ-11282:
-

I created INFRA-19443 for commits triggers

> Fix the Buildbot config
> ---
>
> Key: OFBIZ-11282
> URL: https://issues.apache.org/jira/browse/OFBIZ-11282
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: BuildBot
>Reporter: Jacques Le Roux
>Priority: Major
>
> I thought all was OK with Buildbot because it went well when launched by hand 
> from IRC.
> But if you get to at https://ci.apache.org/waterfall and look for "ofb" you 
> will find that ofbizBranch17Framework and ofbizBranch18Framework have an 
> issue, the same.
> Though they use the same step for checkout than ofbizBranch17FrameworkPlugin 
> and ofbizBranch18FrameworkPlugin, for which it works.
> Also all builds need to be registered with Infra, they only work when 
> launched by hand from IRC.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)