[jira] [Commented] (OFBIZ-8297) Convert
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028186#comment-17028186 ] Pierre Smits commented on OFBIZ-8297: - Michael, First you claimed that the provided patch would break functionality. However if you would have looked a little further you would have found that the key-value pair exists in CommonSystemPropertyData since 2012-02-01 see [https://fisheye.apache.org/browse/ofbiz-framework/framework/common/data/CommonSystemPropertyData.xml?r2=13ff4e3f4c6f41864d62c6cdb6931a02f4b85e73=c690a5aba578f0df25df572cec734f4eb3c57038] The CommonSystemPropertyData is loaded as seed data (see the ofbiz-component.xml. In 2019 you claimed the patch was incomplete, without providing additional information. It seems to me you were 'managing' the ticket and expecting others (me) to resolve your concerns, instead of working it yourself. > Convert -- > > Key: OFBIZ-8297 > URL: https://issues.apache.org/jira/browse/OFBIZ-8297 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-8297-AgreementScreens.xml.patch, > OFBIZ-8297-AgreementScreens.xml.patch > > > * files when it comes to retrieving configuration variables. This doesn't work > in a multi-tenant setup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10587) _WARNING_MESSAGE_
[ https://issues.apache.org/jira/browse/OFBIZ-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028185#comment-17028185 ] Michael Brohl commented on OFBIZ-10587: --- Thanks for the hint, Jacques. > _WARNING_MESSAGE_ > - > > Key: OFBIZ-10587 > URL: https://issues.apache.org/jira/browse/OFBIZ-10587 > Project: OFBiz > Issue Type: Wish > Components: ALL COMPONENTS >Reporter: Niklas Fallik >Assignee: Michael Brohl >Priority: Major > > Hi there, > I am looking for a way to display warning messages. We are using > EVENT_MESSAGE and ERROR_MESSAGE which we can pass to the frontend to display > to the user, but it turned out that it would be nice to have a type for > warnings like WARNING_MESSAGE. > I figured out that the java classes ServiceEventHandler and > ScriptEventHandler deal with those message types. > I really would appreciate if anyone already had a solution for this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10587) _WARNING_MESSAGE_
[
https://issues.apache.org/jira/browse/OFBIZ-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028184#comment-17028184
]
Jacques Le Roux commented on OFBIZ-10587:
-
Michael,
I'm sure you are aware, but in case as it's not obvious (below I use * for any
char);
{noformat}
*_MESSAGE_*{noformat}
(mostly _ERROR_MESSAGE_ , ERROR_MESSAGE_LIST and ModelService.ERROR_MESSAGE_*
but also EVENT) are used in conditional expressions (not only Java) like
{noformat}
if (*_MESSAGE_*) { {{noformat}
I don't think adding WARNING_MESSAGE would have an impact. So just telling, in
case it could be used in such and other expressions than conditional.
I just used the same in OFBIZ-11329 for setUserTimeZone.js. That's why I tell
you that. There is not need to worry about WARNING there, again just telling.
> _WARNING_MESSAGE_
> -
>
> Key: OFBIZ-10587
> URL: https://issues.apache.org/jira/browse/OFBIZ-10587
> Project: OFBiz
> Issue Type: Wish
> Components: ALL COMPONENTS
>Reporter: Niklas Fallik
>Assignee: Michael Brohl
>Priority: Major
>
> Hi there,
> I am looking for a way to display warning messages. We are using
> EVENT_MESSAGE and ERROR_MESSAGE which we can pass to the frontend to display
> to the user, but it turned out that it would be nice to have a type for
> warnings like WARNING_MESSAGE.
> I figured out that the java classes ServiceEventHandler and
> ScriptEventHandler deal with those message types.
> I really would appreciate if anyone already had a solution for this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-10191) Translate invoice type dropdown
[ https://issues.apache.org/jira/browse/OFBIZ-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10191. - Resolution: Implemented Thanks Ingo. > Translate invoice type dropdown > --- > > Key: OFBIZ-10191 > URL: https://issues.apache.org/jira/browse/OFBIZ-10191 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Ingo Wolfmayr >Assignee: Michael Brohl >Priority: Trivial > Attachments: ofbiz.patch > > > It would be nice if the "Invoice item type" (Invoice --> items) would display > in the locale language. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10191) Translate invoice type dropdown
[ https://issues.apache.org/jira/browse/OFBIZ-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028178#comment-17028178 ] ASF subversion and git services commented on OFBIZ-10191: - Commit db92854bcef2f47a733555b6a819c081eb72518a in ofbiz-framework's branch refs/heads/trunk from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=db92854 ] Improved: Translate invoice type dropdown (OFBIZ-10191) Thanks Ingo Wolfmayr for reporting and providing the patch. > Translate invoice type dropdown > --- > > Key: OFBIZ-10191 > URL: https://issues.apache.org/jira/browse/OFBIZ-10191 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Ingo Wolfmayr >Assignee: Michael Brohl >Priority: Trivial > Attachments: ofbiz.patch > > > It would be nice if the "Invoice item type" (Invoice --> items) would display > in the locale language. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10792) When shopping list is added to cart only one of the item is added to cart instead of all items in the list
[ https://issues.apache.org/jira/browse/OFBIZ-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028177#comment-17028177 ] Jacques Le Roux commented on OFBIZ-10792: - Agreed > When shopping list is added to cart only one of the item is added to cart > instead of all items in the list > -- > > Key: OFBIZ-10792 > URL: https://issues.apache.org/jira/browse/OFBIZ-10792 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Minor > Attachments: Shopping List.gif > > > Steps to regenerate: > # Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList] > # Create a new shopping list > # Add items in the list > # Click on "Add List To Cart". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10191) Translate invoice type dropdown
[ https://issues.apache.org/jira/browse/OFBIZ-10191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10191: - Assignee: Michael Brohl > Translate invoice type dropdown > --- > > Key: OFBIZ-10191 > URL: https://issues.apache.org/jira/browse/OFBIZ-10191 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Ingo Wolfmayr >Assignee: Michael Brohl >Priority: Trivial > Attachments: ofbiz.patch > > > It would be nice if the "Invoice item type" (Invoice --> items) would display > in the locale language. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10193) remove hardcoded viewSize for product search
[ https://issues.apache.org/jira/browse/OFBIZ-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10193: - Assignee: Michael Brohl > remove hardcoded viewSize for product search > > > Key: OFBIZ-10193 > URL: https://issues.apache.org/jira/browse/OFBIZ-10193 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Wai >Assignee: Michael Brohl >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10193) remove hardcoded viewSize for product search
[ https://issues.apache.org/jira/browse/OFBIZ-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028175#comment-17028175 ] Michael Brohl commented on OFBIZ-10193: --- Hi [~wt] , do you plan to add mor explanation to this issue or even provide a patch? > remove hardcoded viewSize for product search > > > Key: OFBIZ-10193 > URL: https://issues.apache.org/jira/browse/OFBIZ-10193 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk >Reporter: Wai >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11150) Form widget field with input-method="time-dropdown" unable to understand the default time
[
https://issues.apache.org/jira/browse/OFBIZ-11150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11150:
Parent: OFBIZ-10750
Issue Type: Sub-task (was: Bug)
> Form widget field with input-method="time-dropdown" unable to understand the
> default time
> -
>
> Key: OFBIZ-11150
> URL: https://issues.apache.org/jira/browse/OFBIZ-11150
> Project: OFBiz
> Issue Type: Sub-task
> Components: example
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Minor
>
> I noticed this error in the example component some time ago (months), it's
> still there:
> {noformat}
> 2019-08-12 13:28:32,868 |jsse-nio-8443-exec-8 |MacroFormRenderer
> |W| Form widget field [field4] with input-method="time-dropdown" was not able
> to understand the default time [2019-08-12%20132832.833]. The
> parsing
> error was: Timestamp format must be -mm-dd hh:mm:ss[.f]
> 2019-08-12 13:28:32,877 |jsse-nio-8443-exec-8 |MacroFormRenderer
> |W| Form widget field [field5] with input-method="time-dropdown" was not able
> to understand the default time [2019-08-12%20132832.833]. The
> parsing
> error was: Timestamp format must be -mm-dd hh:mm:ss[.f]
> 2019-08-12 13:28:32,918 |jsse-nio-8443-exec-8 |MacroFormRenderer
> |W| Form widget field [field12] with input-method="time-dropdown" was not
> able to understand the default time [2019-08-12%20132832.833].
> The parsing
> error was: Timestamp format must be -mm-dd hh:mm:ss[.f]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-10233) Could not get e-mail to work - New of biz setup
[ https://issues.apache.org/jira/browse/OFBIZ-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10233. - Assignee: Michael Brohl Resolution: Not A Problem Hi [~tadhanom] , those questions are better adressed in the user mailing list. For this issue, the configuration in the .properties is overridden by a SystemDefault entry in the database, which is written when loading the default data. > Could not get e-mail to work - New of biz setup > --- > > Key: OFBIZ-10233 > URL: https://issues.apache.org/jira/browse/OFBIZ-10233 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Release Branch 16.11 > Environment: build: 16.11 on Ubuntu 16.04.3 LTS > >Reporter: Michael Adhanom >Assignee: Michael Brohl >Priority: Major > Attachments: OFBiz_FetchLogs.webarchive, generl.properties.txt > > > > Could not get e-mail services to work on a new ofbiz installation. Trace log > shows mail failed because "Mail notifications disabled in > general.properties", even though this is enabled: > /ofbiz/framework/common/config/general.properties > # – mail notifications enabled (Y|N) > mail.notifications.enabled=Y > > Log snippet (full log attached): > 2018-02-22 17:40:05,387 |OFBiz-JobQueue-0 |EmailServices |I| Mail > notifications disabled in general.properties; mail with subject [New Account > Created] not sent to addressee [tesfamicael.adha...@mkdecision.com] > 2018-02-22 17:40:35,094 |OFBiz-JobQueue-1 |EmailServices |I| Mail > notifications disabled in general.properties; mail with subject [test message > to admin] not sent to addressee [ofbizt...@example.com] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11202) Issue in validating date of format yyyy-MM-dd'T'HH:mm:ss
[ https://issues.apache.org/jira/browse/OFBIZ-11202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11202: Parent: OFBIZ-10750 Issue Type: Sub-task (was: Bug) > Issue in validating date of format -MM-dd'T'HH:mm:ss > > > Key: OFBIZ-11202 > URL: https://issues.apache.org/jira/browse/OFBIZ-11202 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Lalit Dashora >Assignee: Lalit Dashora >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10325) EntityOne.java doesn't throw proper exception if field is not available in entity
[ https://issues.apache.org/jira/browse/OFBIZ-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028169#comment-17028169 ] Michael Brohl commented on OFBIZ-10325: --- Hi [~surajk] , is there anything open with this issue or can it be closed? > EntityOne.java doesn't throw proper exception if field is not available in > entity > - > > Key: OFBIZ-10325 > URL: https://issues.apache.org/jira/browse/OFBIZ-10325 > Project: OFBiz > Issue Type: Improvement >Reporter: Suraj Khurana >Priority: Major > Attachments: PartyProfile.png > > > Using entity-one tag in xml services, if field is not a part of entity, > proper exception message should be thrown with returned error service > response. > Suppose: > > > > > > partyId is not part of ProductFacility entity, if such code is used inside > any xml service, than proper exception should be thrown from EntityOne.java > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10991) Have a SalesChannel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028167#comment-17028167 ] Jacques Le Roux commented on OFBIZ-10991: - Thanks Pierre > Have a SalesChannel dimension > - > > Key: OFBIZ-10991 > URL: https://issues.apache.org/jira/browse/OFBIZ-10991 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh > > The component would benefit from a sales channel dimension for future fact > tables and star schema view entities -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11244) Remove the user login security question
[ https://issues.apache.org/jira/browse/OFBIZ-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-11244: - Assignee: Michael Brohl > Remove the user login security question > --- > > Key: OFBIZ-11244 > URL: https://issues.apache.org/jira/browse/OFBIZ-11244 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, framework, party >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Michael Brohl >Priority: Major > > After our discussion in dev ML at > https://markmail.org/message/2dhc4al4adwgvl7z we will remove this feature. > This [~paulfoxworthy]'s remark is notably important: > bq. Security is only as good as its weakest link ( > https://www.schneier.com/essays/archives/2005/02/the_curse_of_the_sec.html) , > and security questions can be a real weakness. Any organisation using OFBiz > that really hates passwords could look at security keys from Yubico or the > like. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11244) Remove the user login security question
[ https://issues.apache.org/jira/browse/OFBIZ-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028166#comment-17028166 ] Jacques Le Roux commented on OFBIZ-11244: - Hi Michael, I'm currently focused on OFBIZ-11306, so feel free to assign to yourself > Remove the user login security question > --- > > Key: OFBIZ-11244 > URL: https://issues.apache.org/jira/browse/OFBIZ-11244 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, framework, party >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Jacques Le Roux >Priority: Major > > After our discussion in dev ML at > https://markmail.org/message/2dhc4al4adwgvl7z we will remove this feature. > This [~paulfoxworthy]'s remark is notably important: > bq. Security is only as good as its weakest link ( > https://www.schneier.com/essays/archives/2005/02/the_curse_of_the_sec.html) , > and security questions can be a real weakness. Any organisation using OFBiz > that really hates passwords could look at security keys from Yubico or the > like. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11134) Adds a few german translation improvements in HumanResUiLabels
[ https://issues.apache.org/jira/browse/OFBIZ-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028149#comment-17028149 ] Jacques Le Roux edited comment on OFBIZ-11134 at 2/1/20 5:46 PM: - No, but the "Fix Version/s:" field is not correctly filled, in any cases ;) was (Author: jacques.le.roux): No, but the "Fix Version/s:" field is not correctly filles, in any cases ;) > Adds a few german translation improvements in HumanResUiLabels > -- > > Key: OFBIZ-11134 > URL: https://issues.apache.org/jira/browse/OFBIZ-11134 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Ulrich Heidfeld >Assignee: Michael Brohl >Priority: Trivial > Fix For: 17.12.01, Upcoming Branch, 18.12.01 > > Attachments: OFBIZ-11134.patch > > > In our project we have some german translation improvements in > HumanResUiLabels. So I'll provide a small patch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11215) Email password is not working
[ https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11215: Fix Version/s: (was: 16.11.07) (was: 17.12.01) 18.12.01 > Email password is not working > - > > Key: OFBIZ-11215 > URL: https://issues.apache.org/jira/browse/OFBIZ-11215 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Major > Fix For: 18.12.01 > > > Steps to regenerate: > # User should be on the login page > [https://demo-stable.ofbiz.apache.org/ecommerce/control/login] > # Enter username > # Click on email password > Actual: Email is not received. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11134) Adds a few german translation improvements in HumanResUiLabels
[ https://issues.apache.org/jira/browse/OFBIZ-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028149#comment-17028149 ] Jacques Le Roux commented on OFBIZ-11134: - No, but the "Fix Version/s:" field is not correctly filles, in any cases ;) > Adds a few german translation improvements in HumanResUiLabels > -- > > Key: OFBIZ-11134 > URL: https://issues.apache.org/jira/browse/OFBIZ-11134 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Ulrich Heidfeld >Assignee: Michael Brohl >Priority: Trivial > Fix For: 17.12.01, Upcoming Branch, 18.12.01 > > Attachments: OFBIZ-11134.patch > > > In our project we have some german translation improvements in > HumanResUiLabels. So I'll provide a small patch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10991) Have a SalesChannel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841938#comment-16841938 ] Jacques Le Roux edited comment on OFBIZ-10991 at 2/1/20 5:01 PM: - Hi Pierre, Not sure why I can't get to https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603 bq. The dashboard you requested either does not exist or you don't have access to it. If you think this message is wrong, please contact your JIRA administrators. was (Author: jacques.le.roux): Hi Pierre, Not sure why I can't get to https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12310603: bq. The dashboard you requested either does not exist or you don't have access to it. If you think this message is wrong, please contact your JIRA administrators. > Have a SalesChannel dimension > - > > Key: OFBIZ-10991 > URL: https://issues.apache.org/jira/browse/OFBIZ-10991 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh > > The component would benefit from a sales channel dimension for future fact > tables and star schema view entities -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11215) Email password is not working
[ https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028144#comment-17028144 ] Pierre Smits commented on OFBIZ-11215: -- See the first comment by Jacques. > Email password is not working > - > > Key: OFBIZ-11215 > URL: https://issues.apache.org/jira/browse/OFBIZ-11215 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 16.11.07 > > > Steps to regenerate: > # User should be on the login page > [https://demo-stable.ofbiz.apache.org/ecommerce/control/login] > # Enter username > # Click on email password > Actual: Email is not received. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11215) Email password is not working
[ https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028143#comment-17028143 ] Michael Brohl commented on OFBIZ-11215: --- Which discussion do you mean, Pierre? > Email password is not working > - > > Key: OFBIZ-11215 > URL: https://issues.apache.org/jira/browse/OFBIZ-11215 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 16.11.07 > > > Steps to regenerate: > # User should be on the login page > [https://demo-stable.ofbiz.apache.org/ecommerce/control/login] > # Enter username > # Click on email password > Actual: Email is not received. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11215) Email password is not working
[ https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028138#comment-17028138 ] Pierre Smits commented on OFBIZ-11215: -- Has the discussion on dev@ been started? If so, the thread should be referenced in the description of the ticket. > Email password is not working > - > > Key: OFBIZ-11215 > URL: https://issues.apache.org/jira/browse/OFBIZ-11215 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 16.11.07 > > > Steps to regenerate: > # User should be on the login page > [https://demo-stable.ofbiz.apache.org/ecommerce/control/login] > # Enter username > # Click on email password > Actual: Email is not received. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10587) _WARNING_MESSAGE_
[ https://issues.apache.org/jira/browse/OFBIZ-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028107#comment-17028107 ] Michael Brohl commented on OFBIZ-10587: --- We are currently working on a solution for it in a project and maybe can contribute it. Will apply a patch when done. > _WARNING_MESSAGE_ > - > > Key: OFBIZ-10587 > URL: https://issues.apache.org/jira/browse/OFBIZ-10587 > Project: OFBiz > Issue Type: Wish > Components: ALL COMPONENTS >Reporter: Niklas Fallik >Assignee: Michael Brohl >Priority: Major > > Hi there, > I am looking for a way to display warning messages. We are using > EVENT_MESSAGE and ERROR_MESSAGE which we can pass to the frontend to display > to the user, but it turned out that it would be nice to have a type for > warnings like WARNING_MESSAGE. > I figured out that the java classes ServiceEventHandler and > ScriptEventHandler deal with those message types. > I really would appreciate if anyone already had a solution for this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10587) _WARNING_MESSAGE_
[ https://issues.apache.org/jira/browse/OFBIZ-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10587: - Assignee: Michael Brohl > _WARNING_MESSAGE_ > - > > Key: OFBIZ-10587 > URL: https://issues.apache.org/jira/browse/OFBIZ-10587 > Project: OFBiz > Issue Type: Wish > Components: ALL COMPONENTS >Reporter: Niklas Fallik >Assignee: Michael Brohl >Priority: Major > > Hi there, > I am looking for a way to display warning messages. We are using > EVENT_MESSAGE and ERROR_MESSAGE which we can pass to the frontend to display > to the user, but it turned out that it would be nice to have a type for > warnings like WARNING_MESSAGE. > I figured out that the java classes ServiceEventHandler and > ScriptEventHandler deal with those message types. > I really would appreciate if anyone already had a solution for this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema
[ https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-10990: Assignee: Pierre Smits > Improve the SalesInvoiceItemStarSchema > -- > > Key: OFBIZ-10990 > URL: https://issues.apache.org/jira/browse/OFBIZ-10990 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesInvoiceItemStarSchema, birt, dwh, star, starschema > > The star schema should be improved to include elements from: > * Customer dimension > * Country dimension > * Store dimension > * Catalog dimension > * Channel dimension -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10772) OFBiz On a Diet
[
https://issues.apache.org/jira/browse/OFBIZ-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-10772:
-
Assignee: Michael Brohl
> OFBiz On a Diet
> ---
>
> Key: OFBIZ-10772
> URL: https://issues.apache.org/jira/browse/OFBIZ-10772
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Minor
>
> OFBiz is laden with superfluous redundancies and approaches for 'novice'
> developers, when it comes to handling labels (titles) for screens and fields
> in forms in both Freemarker templates and widgets.
> In screens we have defined elements such as:
> {code:java}
>
> {code}
> and
>
> {code:java}
>
> {code}
> Equally so we have defined elements in widget forms and templates, such as:
> {code:java}
> ${uiLabelMap.FormFieldTitle_}
> {code}
> or
> {code:java}
> ${uiLabelMap.}
> {code}
> This all has led to a situation where we have a product that, label-wise,
> overflown with exceptions on exceptions, and unnecessary 'explanations' -
> such as the 'componentName', or 'PageTitle' or 'FormFieldTitle_', in any of
> the files.
> Equally so, having to have the name of the component in the identifier of a
> label is unnecessary and reduces reuse. An 'Amount' label has the same
> meaning everywhere (given its context), so there is no need to have
> definitions like:
> * AccountingAmount
> * PaymentAmount
> * ProductAmount
> * OrderAmount
> * TermAmount
> * FormFieldTitle_amount
> * etc.
> Having done a quick assessment I get to over 90.000 unnecessary identifiers
> in our files that hampers us in reusing labels as much as possible.
> We can save 100.000s of bytes in our product by removing these unnecessary
> 'novice' developer requirements, resulting in cost- and time-saving benefits
> for our adopters, their developers and our contributors.
> This is the umbrella ticket to capture related sub-tasks (tickets/sub-tasks).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10772) OFBiz On a Diet
[
https://issues.apache.org/jira/browse/OFBIZ-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028104#comment-17028104
]
Michael Brohl commented on OFBIZ-10772:
---
[~pierresmits], do you want to work on this by starting a discussion and get
consensus to do any of the action items?
It's over a year and nothing seems to happen. thanks for your feedback.
> OFBiz On a Diet
> ---
>
> Key: OFBIZ-10772
> URL: https://issues.apache.org/jira/browse/OFBIZ-10772
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Minor
>
> OFBiz is laden with superfluous redundancies and approaches for 'novice'
> developers, when it comes to handling labels (titles) for screens and fields
> in forms in both Freemarker templates and widgets.
> In screens we have defined elements such as:
> {code:java}
>
> {code}
> and
>
> {code:java}
>
> {code}
> Equally so we have defined elements in widget forms and templates, such as:
> {code:java}
> ${uiLabelMap.FormFieldTitle_}
> {code}
> or
> {code:java}
> ${uiLabelMap.}
> {code}
> This all has led to a situation where we have a product that, label-wise,
> overflown with exceptions on exceptions, and unnecessary 'explanations' -
> such as the 'componentName', or 'PageTitle' or 'FormFieldTitle_', in any of
> the files.
> Equally so, having to have the name of the component in the identifier of a
> label is unnecessary and reduces reuse. An 'Amount' label has the same
> meaning everywhere (given its context), so there is no need to have
> definitions like:
> * AccountingAmount
> * PaymentAmount
> * ProductAmount
> * OrderAmount
> * TermAmount
> * FormFieldTitle_amount
> * etc.
> Having done a quick assessment I get to over 90.000 unnecessary identifiers
> in our files that hampers us in reusing labels as much as possible.
> We can save 100.000s of bytes in our product by removing these unnecessary
> 'novice' developer requirements, resulting in cost- and time-saving benefits
> for our adopters, their developers and our contributors.
> This is the umbrella ticket to capture related sub-tasks (tickets/sub-tasks).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-10779) Remove 'duplicate' labels
[ https://issues.apache.org/jira/browse/OFBIZ-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10779. - Resolution: Not A Problem This issue does not have any content for over a year now, closing. It can be reopened anytime when it is needed. > Remove 'duplicate' labels > - > > Key: OFBIZ-10779 > URL: https://issues.apache.org/jira/browse/OFBIZ-10779 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10792) When shopping list is added to cart only one of the item is added to cart instead of all items in the list
[ https://issues.apache.org/jira/browse/OFBIZ-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10792: - Assignee: Michael Brohl > When shopping list is added to cart only one of the item is added to cart > instead of all items in the list > -- > > Key: OFBIZ-10792 > URL: https://issues.apache.org/jira/browse/OFBIZ-10792 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Minor > Attachments: Shopping List.gif > > > Steps to regenerate: > # Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList] > # Create a new shopping list > # Add items in the list > # Click on "Add List To Cart". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10792) When shopping list is added to cart only one of the item is added to cart instead of all items in the list
[ https://issues.apache.org/jira/browse/OFBIZ-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028101#comment-17028101 ] Michael Brohl commented on OFBIZ-10792: --- I would leave this open as it is a bug anyway. I'll see if we can work on this. > When shopping list is added to cart only one of the item is added to cart > instead of all items in the list > -- > > Key: OFBIZ-10792 > URL: https://issues.apache.org/jira/browse/OFBIZ-10792 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Minor > Attachments: Shopping List.gif > > > Steps to regenerate: > # Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList] > # Create a new shopping list > # Add items in the list > # Click on "Add List To Cart". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10792) When shopping list is added to cart only one of the item is added to cart instead of all items in the list
[ https://issues.apache.org/jira/browse/OFBIZ-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10792: -- Component/s: ecommerce > When shopping list is added to cart only one of the item is added to cart > instead of all items in the list > -- > > Key: OFBIZ-10792 > URL: https://issues.apache.org/jira/browse/OFBIZ-10792 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Rashi Dhagat >Priority: Minor > Attachments: Shopping List.gif > > > Steps to regenerate: > # Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList] > # Create a new shopping list > # Add items in the list > # Click on "Add List To Cart". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10792) When shopping list is added to cart only one of the item is added to cart instead of all items in the list
[ https://issues.apache.org/jira/browse/OFBIZ-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10792: -- Priority: Minor (was: Major) > When shopping list is added to cart only one of the item is added to cart > instead of all items in the list > -- > > Key: OFBIZ-10792 > URL: https://issues.apache.org/jira/browse/OFBIZ-10792 > Project: OFBiz > Issue Type: Bug >Reporter: Rashi Dhagat >Priority: Minor > Attachments: Shopping List.gif > > > Steps to regenerate: > # Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList] > # Create a new shopping list > # Add items in the list > # Click on "Add List To Cart". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10819) Wish SOAP interface Would work OOTB with .NET
[ https://issues.apache.org/jira/browse/OFBIZ-10819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10819: - Assignee: Michael Brohl > Wish SOAP interface Would work OOTB with .NET > - > > Key: OFBIZ-10819 > URL: https://issues.apache.org/jira/browse/OFBIZ-10819 > Project: OFBiz > Issue Type: Wish > Components: framework >Affects Versions: 16.11.05 >Reporter: Greg Finlayson >Assignee: Michael Brohl >Priority: Major > > So I am trying to use findPartyFromEmailAddress SOAP service from a .NET > client. > I know the username and password arguments are getting passed correctly, > because if I change them to be incorrect, then I get errors. However I just > get a > > | http-nio-8443-exec-1 |RequestHandler Ran Event soap:# from [request], > result is null > (not exactly that because this software doesn't let me use the square > brackets as they appear). > How to debug this? The function ought be returning the partyID. Is there a > more detailed logging of the call to SOAP which can be turned on in OFBIz? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10819) Wish SOAP interface Would work OOTB with .NET
[ https://issues.apache.org/jira/browse/OFBIZ-10819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-10819. - Resolution: Not A Problem As Jacques explained, please use the mailing lists. > Wish SOAP interface Would work OOTB with .NET > - > > Key: OFBIZ-10819 > URL: https://issues.apache.org/jira/browse/OFBIZ-10819 > Project: OFBiz > Issue Type: Wish > Components: framework >Affects Versions: 16.11.05 >Reporter: Greg Finlayson >Assignee: Michael Brohl >Priority: Major > > So I am trying to use findPartyFromEmailAddress SOAP service from a .NET > client. > I know the username and password arguments are getting passed correctly, > because if I change them to be incorrect, then I get errors. However I just > get a > > | http-nio-8443-exec-1 |RequestHandler Ran Event soap:# from [request], > result is null > (not exactly that because this software doesn't let me use the square > brackets as they appear). > How to debug this? The function ought be returning the partyID. Is there a > more detailed logging of the call to SOAP which can be turned on in OFBIz? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10091) Unnecessary throws clauses in renderer classes?
[ https://issues.apache.org/jira/browse/OFBIZ-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028095#comment-17028095 ] Michael Brohl commented on OFBIZ-10091: --- Will work on this. > Unnecessary throws clauses in renderer classes? > --- > > Key: OFBIZ-10091 > URL: https://issues.apache.org/jira/browse/OFBIZ-10091 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > During the refactoring work I found that there are several classes in > org.apache.ofbiz.widget.renderer.macro which state in their method > declarations that they throw TemplateException and/or IOException. > In many cases, there is either no evidence of these Exceptions or they are > catched inside the methods. > One example is the MacroFormRenderer constructor which says it throws > TemplateException but does not. > The method declarations in the interfaces of org.apache.ofbiz.widget.renderer > all say that IOException is thrown. > It might be that I overlook something and I did not dig much deeper into the > code so I first want to ask what the reasons are or if it would not be > reasonable to make a difference in interfaces and implementations and only > declare that a method throws a specific exception if it really does? > Thanks for your help, > regards, > Michael -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10091) Unnecessary throws clauses in renderer classes?
[ https://issues.apache.org/jira/browse/OFBIZ-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10091: - Assignee: Michael Brohl > Unnecessary throws clauses in renderer classes? > --- > > Key: OFBIZ-10091 > URL: https://issues.apache.org/jira/browse/OFBIZ-10091 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > During the refactoring work I found that there are several classes in > org.apache.ofbiz.widget.renderer.macro which state in their method > declarations that they throw TemplateException and/or IOException. > In many cases, there is either no evidence of these Exceptions or they are > catched inside the methods. > One example is the MacroFormRenderer constructor which says it throws > TemplateException but does not. > The method declarations in the interfaces of org.apache.ofbiz.widget.renderer > all say that IOException is thrown. > It might be that I overlook something and I did not dig much deeper into the > code so I first want to ask what the reasons are or if it would not be > reasonable to make a difference in interfaces and implementations and only > declare that a method throws a specific exception if it really does? > Thanks for your help, > regards, > Michael -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration
[
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028093#comment-17028093
]
Michael Brohl commented on OFBIZ-10973:
---
Isn't the implementation explicitely for the third party provider msg91? IMO
this is the same case as a PayPal or WorldPay integration.
Renaming to just msggateway is more confusing because it reads as if it is a
generic msg gateway functionality.
I would suggest to rename it to msggateway-msg91 which allows to have other
future msg gateway components with the same naming scheme.
> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send
> sms".
> But could we not have another name, more explicit, for this component, like
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not
> associate the name of an open source component to a commercial services
> provider (with a free SMS quota option). Even if hopefully it will stay as
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11020) Use Random.nextDouble() instead of Math.random()
[
https://issues.apache.org/jira/browse/OFBIZ-11020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028091#comment-17028091
]
Michael Brohl commented on OFBIZ-11020:
---
Hi [~bd2019us] ,
thanks for your contribution.
Your patch does not apply directly for current trunk. Also, is there a reason
why you replaces Math.random only partially?
See CommonEvents:
{code:java}
for (int i = 0; i < circlesToDraw; i++) {
Random rand = new Random();
int circleRadius = (int) (rand.nextDouble() * height / 2.0);
int circleX = (int) (Math.random() * width - circleRadius);
int circleY = (int) (Math.random() * height - circleRadius);
g.drawOval(circleX, circleY, circleRadius * 2, circleRadius *
2);
}
{code}
> Use Random.nextDouble() instead of Math.random()
>
>
> Key: OFBIZ-11020
> URL: https://issues.apache.org/jira/browse/OFBIZ-11020
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Reporter: bd2019us
>Assignee: Michael Brohl
>Priority: Trivial
> Attachments: OFBIZ-11020.patch
>
>
> When using Math.random instead of Random.nextDouble, there is a slight
> performance cost. Due to Math.random invoking an instance of Random This cost
> can be alleviated by directly using Random.nextDouble. This also allows for
> more control over the randomization in the future.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11020) Use Random.nextDouble() instead of Math.random()
[ https://issues.apache.org/jira/browse/OFBIZ-11020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028088#comment-17028088 ] Michael Brohl commented on OFBIZ-11020: --- https://stackoverflow.com/questions/738629/math-random-versus-random-nextintint#738651 > Use Random.nextDouble() instead of Math.random() > > > Key: OFBIZ-11020 > URL: https://issues.apache.org/jira/browse/OFBIZ-11020 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: bd2019us >Assignee: Michael Brohl >Priority: Trivial > Attachments: OFBIZ-11020.patch > > > When using Math.random instead of Random.nextDouble, there is a slight > performance cost. Due to Math.random invoking an instance of Random This cost > can be alleviated by directly using Random.nextDouble. This also allows for > more control over the randomization in the future. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11020) Use Random.nextDouble() instead of Math.random()
[ https://issues.apache.org/jira/browse/OFBIZ-11020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-11020: - Assignee: Michael Brohl > Use Random.nextDouble() instead of Math.random() > > > Key: OFBIZ-11020 > URL: https://issues.apache.org/jira/browse/OFBIZ-11020 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: bd2019us >Assignee: Michael Brohl >Priority: Trivial > Attachments: OFBIZ-11020.patch > > > When using Math.random instead of Random.nextDouble, there is a slight > performance cost. Due to Math.random invoking an instance of Random This cost > can be alleviated by directly using Random.nextDouble. This also allows for > more control over the randomization in the future. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11215) Email password is not working
[ https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028083#comment-17028083 ] Michael Brohl commented on OFBIZ-11215: --- Since we decided to put out 17.12 I think we should try to backport. > Email password is not working > - > > Key: OFBIZ-11215 > URL: https://issues.apache.org/jira/browse/OFBIZ-11215 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 16.11.07 > > > Steps to regenerate: > # User should be on the login page > [https://demo-stable.ofbiz.apache.org/ecommerce/control/login] > # Enter username > # Click on email password > Actual: Email is not received. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11215) Email password is not working
[ https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-11215: -- Fix Version/s: 16.11.07 17.12.01 > Email password is not working > - > > Key: OFBIZ-11215 > URL: https://issues.apache.org/jira/browse/OFBIZ-11215 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Priority: Major > Fix For: 17.12.01, 16.11.07 > > > Steps to regenerate: > # User should be on the login page > [https://demo-stable.ofbiz.apache.org/ecommerce/control/login] > # Enter username > # Click on email password > Actual: Email is not received. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11215) Email password is not working
[ https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-11215: - Assignee: Michael Brohl > Email password is not working > - > > Key: OFBIZ-11215 > URL: https://issues.apache.org/jira/browse/OFBIZ-11215 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 16.11.07 > > > Steps to regenerate: > # User should be on the login page > [https://demo-stable.ofbiz.apache.org/ecommerce/control/login] > # Enter username > # Click on email password > Actual: Email is not received. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11329) setUserTimeZone should ran only once based on error
[
https://issues.apache.org/jira/browse/OFBIZ-11329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028081#comment-17028081
]
James Yong commented on OFBIZ-11329:
Thanks for the patch.
*Review for OFBIZ-11329:
*
(1) Improvement to SetTimeZoneFromBrowser javascript function is good. i.e. it
will only set value in sessionStorage if response is success.
(2) Instead of hardcoding in java code the exemption of csrfToken check for
SetTimeZoneFromBrowser, should set security csrf-token to false in the
corresponding request map with some comments. But as SetTimeZoneFromBrowser can
change the data in the database, I think it should not be exempted from CSRF
token check.
(3) Note that the existing implementation of SetTimeZoneFromBrowser doesn't
check whether the submitted timezone is valid or different from the UserLogin's
lastTimeZone. Not sure if this should be in another JIRA issue.
*Review for OFBIZ-11306:*
(1) In line 304 of CsrfUtil.java:
{code:java}
request.setAttribute("_ERROR_MESSAGE_",
"Invalid or missing CSRF token to path '" +
request.getPathInfo() + "'. Click here to
continue.");
if (throwRequestHandlerExceptionOnMissingLocalRequest) {
throw new RequestHandlerExceptionAllowExternalRequests();
}
{code}
there should be no need to check for
throwRequestHandlerExceptionOnMissingLocalRequest. The property is for missing
request map but we are handling missing or invalid CSRF token.
(2) Found that additional info which should be returned from ajax request of
SetTimeZoneFromBrowser, due to the jsonResponseFromRequestAttribute service and
my implementation of OFBIZ-11306.
> setUserTimeZone should ran only once based on error
> ---
>
> Key: OFBIZ-11329
> URL: https://issues.apache.org/jira/browse/OFBIZ-11329
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework, webpos
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: James Yong
>Priority: Minor
> Attachments: OFBIZ-11329-plugins.patch, OFBIZ-11329.patch,
> OFBIZ-11329.patch
>
>
> This will be useful when committing CSRF solution as explained in OFBIZ-11306
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11244) Remove the user login security question
[ https://issues.apache.org/jira/browse/OFBIZ-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028080#comment-17028080 ] Michael Brohl commented on OFBIZ-11244: --- Hi [~jleroux] , are you working on it? Else we could work out the patch. > Remove the user login security question > --- > > Key: OFBIZ-11244 > URL: https://issues.apache.org/jira/browse/OFBIZ-11244 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce, framework, party >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Jacques Le Roux >Priority: Major > > After our discussion in dev ML at > https://markmail.org/message/2dhc4al4adwgvl7z we will remove this feature. > This [~paulfoxworthy]'s remark is notably important: > bq. Security is only as good as its weakest link ( > https://www.schneier.com/essays/archives/2005/02/the_curse_of_the_sec.html) , > and security questions can be a real weakness. Any organisation using OFBiz > that really hates passwords could look at security keys from Yubico or the > like. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11291) Alternate KeyWord Thesaurus functionality does not work properly
[ https://issues.apache.org/jira/browse/OFBIZ-11291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-11291: - Assignee: Michael Brohl > Alternate KeyWord Thesaurus functionality does not work properly > > > Key: OFBIZ-11291 > URL: https://issues.apache.org/jira/browse/OFBIZ-11291 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Michael Brohl >Priority: Minor > > Steps to regenerate: > # Login at [https://localhost:8443/catalog/control/main] > # Go to Thesaurus. > # Create Some new Thesaurus. > # Try to add alternate for any existing Thesaurus, it's not working here. > # Also, try to delete all Thesaurus using Delete All button, it is also not > working. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11291) Alternate KeyWord Thesaurus functionality does not work properly
[ https://issues.apache.org/jira/browse/OFBIZ-11291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028078#comment-17028078 ] Michael Brohl commented on OFBIZ-11291: --- We'll work on this. > Alternate KeyWord Thesaurus functionality does not work properly > > > Key: OFBIZ-11291 > URL: https://issues.apache.org/jira/browse/OFBIZ-11291 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Pawan Verma >Assignee: Michael Brohl >Priority: Minor > > Steps to regenerate: > # Login at [https://localhost:8443/catalog/control/main] > # Go to Thesaurus. > # Create Some new Thesaurus. > # Try to add alternate for any existing Thesaurus, it's not working here. > # Also, try to delete all Thesaurus using Delete All button, it is also not > working. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11292) Edit CompDoc doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-11292. - Resolution: Won't Fix Hi [~anushi.gupta10] , thanks for reporting the issue. We decided to remove the CompDoc component so there is no need to put work on this. > Edit CompDoc doesn't work > - > > Key: OFBIZ-11292 > URL: https://issues.apache.org/jira/browse/OFBIZ-11292 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk >Reporter: Anushi Gupta >Assignee: Michael Brohl >Priority: Major > > Steps to regenerate: > 1. Login at https://demo-trunk.ofbiz.apache.org/content/control/FindCompDoc > 2. Find CompDoc > 3. Try to edit CompDoc, its not working. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11292) Edit CompDoc doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-11292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-11292: - Assignee: Michael Brohl > Edit CompDoc doesn't work > - > > Key: OFBIZ-11292 > URL: https://issues.apache.org/jira/browse/OFBIZ-11292 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Trunk >Reporter: Anushi Gupta >Assignee: Michael Brohl >Priority: Major > > Steps to regenerate: > 1. Login at https://demo-trunk.ofbiz.apache.org/content/control/FindCompDoc > 2. Find CompDoc > 3. Try to edit CompDoc, its not working. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11134) Adds a few german translation improvements in HumanResUiLabels
[ https://issues.apache.org/jira/browse/OFBIZ-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-11134: - Assignee: Michael Brohl (was: Ulrich Heidfeld) > Adds a few german translation improvements in HumanResUiLabels > -- > > Key: OFBIZ-11134 > URL: https://issues.apache.org/jira/browse/OFBIZ-11134 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Ulrich Heidfeld >Assignee: Michael Brohl >Priority: Trivial > Fix For: 17.12.01, Upcoming Branch, 18.12.01 > > Attachments: OFBIZ-11134.patch > > > In our project we have some german translation improvements in > HumanResUiLabels. So I'll provide a small patch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11134) Adds a few german translation improvements in HumanResUiLabels
[ https://issues.apache.org/jira/browse/OFBIZ-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028074#comment-17028074 ] Michael Brohl commented on OFBIZ-11134: --- Although this is an improvement, I would also like to backport this to the 17.12/18.12 release branches. Any objections? > Adds a few german translation improvements in HumanResUiLabels > -- > > Key: OFBIZ-11134 > URL: https://issues.apache.org/jira/browse/OFBIZ-11134 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Ulrich Heidfeld >Assignee: Ulrich Heidfeld >Priority: Trivial > Fix For: 17.12.01, Upcoming Branch, 18.12.01 > > Attachments: OFBIZ-11134.patch > > > In our project we have some german translation improvements in > HumanResUiLabels. So I'll provide a small patch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11134) Adds a few german translation improvements in HumanResUiLabels
[ https://issues.apache.org/jira/browse/OFBIZ-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-11134: -- Fix Version/s: 18.12.01 Upcoming Branch 17.12.01 > Adds a few german translation improvements in HumanResUiLabels > -- > > Key: OFBIZ-11134 > URL: https://issues.apache.org/jira/browse/OFBIZ-11134 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Ulrich Heidfeld >Assignee: Ulrich Heidfeld >Priority: Trivial > Fix For: 17.12.01, Upcoming Branch, 18.12.01 > > Attachments: OFBIZ-11134.patch > > > In our project we have some german translation improvements in > HumanResUiLabels. So I'll provide a small patch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11134) Adds a few german translation improvements in HumanResUiLabels
[ https://issues.apache.org/jira/browse/OFBIZ-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028073#comment-17028073 ] ASF subversion and git services commented on OFBIZ-11134: - Commit e4335b66c23eab356019c6995e7942628f17ac9c in ofbiz-framework's branch refs/heads/trunk from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e4335b6 ] Improvement: German translation improvements in HumanResUiLabels (OFBIZ-11134) Thanks Ulrich Heidfeld for reporting and providing the patch. > Adds a few german translation improvements in HumanResUiLabels > -- > > Key: OFBIZ-11134 > URL: https://issues.apache.org/jira/browse/OFBIZ-11134 > Project: OFBiz > Issue Type: Improvement > Components: humanres >Affects Versions: Trunk >Reporter: Ulrich Heidfeld >Assignee: Ulrich Heidfeld >Priority: Trivial > Attachments: OFBIZ-11134.patch > > > In our project we have some german translation improvements in > HumanResUiLabels. So I'll provide a small patch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10991) Have a SalesChannel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028072#comment-17028072 ] Michael Brohl commented on OFBIZ-10991: --- Please see my comment on the dev mailing list: https://lists.apache.org/thread.html/raf82778c1352273bdb9fb9d0081a0d9c354d4b7b4d7e40735662e094%40%3Cdev.ofbiz.apache.org%3E > Have a SalesChannel dimension > - > > Key: OFBIZ-10991 > URL: https://issues.apache.org/jira/browse/OFBIZ-10991 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh > > The component would benefit from a sales channel dimension for future fact > tables and star schema view entities -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11074) Have a service to load records in the sales channel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11074: - Attachment: (was: OFBIZ-11074-ChannelDimService.diff) > Have a service to load records in the sales channel dimension > - > > Key: OFBIZ-11074 > URL: https://issues.apache.org/jira/browse/OFBIZ-11074 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dwh, > initialisation, service > > For dwh initialisation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11074) Have a service to load records in the sales channel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11074: - Attachment: (was: OFBIZ-11074-ChannelDimService.diff) > Have a service to load records in the sales channel dimension > - > > Key: OFBIZ-11074 > URL: https://issues.apache.org/jira/browse/OFBIZ-11074 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dwh, > initialisation, service > > For dwh initialisation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11145) Add Party Content does not create new content
[ https://issues.apache.org/jira/browse/OFBIZ-11145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028061#comment-17028061 ] Michael Brohl commented on OFBIZ-11145: --- [~rahul.chohal] are you working on this issue or can it be assigned to someone else? > Add Party Content does not create new content > - > > Key: OFBIZ-11145 > URL: https://issues.apache.org/jira/browse/OFBIZ-11145 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Rahul Chohal >Priority: Major > > Steps to regenerate: > # Login into Partymgr component. > # Select any party and go to Party Content tab > # Under form *Add Party Content,* fill details and try to create content > This works on demo-stable.ofbiz.apache.org but not on > demo-trunk.ofbiz.apache.org. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11150) Form widget field with input-method="time-dropdown" unable to understand the default time
[
https://issues.apache.org/jira/browse/OFBIZ-11150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-11150:
-
Assignee: Michael Brohl
> Form widget field with input-method="time-dropdown" unable to understand the
> default time
> -
>
> Key: OFBIZ-11150
> URL: https://issues.apache.org/jira/browse/OFBIZ-11150
> Project: OFBiz
> Issue Type: Bug
> Components: example
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Minor
>
> I noticed this error in the example component some time ago (months), it's
> still there:
> {noformat}
> 2019-08-12 13:28:32,868 |jsse-nio-8443-exec-8 |MacroFormRenderer
> |W| Form widget field [field4] with input-method="time-dropdown" was not able
> to understand the default time [2019-08-12%20132832.833]. The
> parsing
> error was: Timestamp format must be -mm-dd hh:mm:ss[.f]
> 2019-08-12 13:28:32,877 |jsse-nio-8443-exec-8 |MacroFormRenderer
> |W| Form widget field [field5] with input-method="time-dropdown" was not able
> to understand the default time [2019-08-12%20132832.833]. The
> parsing
> error was: Timestamp format must be -mm-dd hh:mm:ss[.f]
> 2019-08-12 13:28:32,918 |jsse-nio-8443-exec-8 |MacroFormRenderer
> |W| Form widget field [field12] with input-method="time-dropdown" was not
> able to understand the default time [2019-08-12%20132832.833].
> The parsing
> error was: Timestamp format must be -mm-dd hh:mm:ss[.f]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11157) How can we process MRP messages ?
[ https://issues.apache.org/jira/browse/OFBIZ-11157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-11157. - Assignee: Michael Brohl Resolution: Not A Problem Hi [~Bertou] , please address support questions to the mailing lists, in this case [u...@ofbiz.apache.org|mailto:u...@ofbiz.apache.org] seems appropriate. > How can we process MRP messages ? > - > > Key: OFBIZ-11157 > URL: https://issues.apache.org/jira/browse/OFBIZ-11157 > Project: OFBiz > Issue Type: Test > Components: manufacturing >Reporter: Bertrand >Assignee: Michael Brohl >Priority: Minor > > Hi, > We are currently testing OFBiz both to learn it and to see until what extend > it could be used in our just new born start up, and my question is related to > the MRP: I got MRP results and I can check the calculation is fine but I > wonder *how I can process the message ie create a purchase order from the > message. Is there a particular screen / access ?* > I noticed there is an MRP documentation on the Confluence wiki but did not > get it as I have not yet been through the contibutor registration process (I > sent an e-mail a few days ago for that purpose). > So any piece of information will be very helpful for us. > Note that it is quite an exciting moment for us as we have been through Sales > + Configurated product, automatically creating a Work Order (MTO way as we > expected), processing the WO and completing production ! We missed the > procurement side: letting the system suggesting what we have to pruchase > thanks to the MRP calculation. > Best regards > Bertrand -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11202) Issue in validating date of format yyyy-MM-dd'T'HH:mm:ss
[ https://issues.apache.org/jira/browse/OFBIZ-11202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028048#comment-17028048 ] Michael Brohl commented on OFBIZ-11202: --- [~lalit.dashora] can you elaborate a bit more about this issue and how to get there? > Issue in validating date of format -MM-dd'T'HH:mm:ss > > > Key: OFBIZ-11202 > URL: https://issues.apache.org/jira/browse/OFBIZ-11202 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Lalit Dashora >Assignee: Lalit Dashora >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11205) Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
[
https://issues.apache.org/jira/browse/OFBIZ-11205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028047#comment-17028047
]
Michael Brohl commented on OFBIZ-11205:
---
How does the idea behind this change interfere with the proposed goal to have
all ressources (incl. Groovy scripts) inside the ofbiz.jar to be deployed?
Aren't these goals conflicting each other?
> Move Groovy scripts from /groovyScripts/ to /src/main/groovy/
> --
>
> Key: OFBIZ-11205
> URL: https://issues.apache.org/jira/browse/OFBIZ-11205
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> As mentioned in this discussion: https://markmail.org/message/2grqu63yvfpvxzz6
> {quote}
> Here is the (simple) plan:
> 1. We move all Groovy scripts from /groovyScripts/ to /src/main/groovy/
> 2. We add the necessary packages names
> 3. Devs can then open "gradlew --continuous" in a terminal and let it like
> that. It will continuously build on any changes in Gradle sourcesets
> So, if you modify a Groovy scripts while running an OFBiz instance, the
> changes will be reflected in the instance and you can check possible syntax
> or alike issues in the terminal running the continuous build. It's very fast
> since only changes have an impact on the build.
> I'm sure there are other benefits to follow "the common convention of putting
> groovy compiled sources in ${COMPONENT}/src/main/groovy.", as suggested
> Mathieu.
> {quote}
> [~paulfoxworthy] added
> bq. This will encourage and accelerate moving Java services to Groovy, I
> think.
> And [~gil portenseigne]:
> bq. The main advantage I see is, beside compilation, the integration in your
> IDE, that was not optimum, and the possibility to re-use methods from these
> script migrated to explicit classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028046#comment-17028046 ] Michael Brohl commented on OFBIZ-10290: --- Hi [~holivier] , I tried to apply your patch but the format seems to be incorrect. Can you please provide a standard patch? Thank you! > Add Document Content: acc-agreements.adoc > - > > Key: OFBIZ-10290 > URL: https://issues.apache.org/jira/browse/OFBIZ-10290 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Assignee: Olivier Heintz >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: 18.12.01 > > Attachments: > 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo.patch > > > Add content for acc-agreements.doc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10833) CMS add content not working
[ https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028044#comment-17028044 ] Michael Brohl commented on OFBIZ-10833: --- Hi [~swapnilmmane] , are you still working on this issue or should we take it and investigate further? > CMS add content not working > --- > > Key: OFBIZ-10833 > URL: https://issues.apache.org/jira/browse/OFBIZ-10833 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk, 17.12.01 >Reporter: Ingo Wolfmayr >Assignee: Swapnil Mane >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: LogCreateContent.txt, OFBIZ-10833.patch, > cms_addImage.patch > > > On demo: content --> "CmsSite" --> CMS: > Right click on one of the items to add "New Long Text" or "Image". > After saving the new content: > Edit WebSite CMS For: [] > "There is no Content PUBLISH_POINT for this WebSite!" > Having the same problem on a 17.12 local installation. > h1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10991) Have a SalesChannel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10991: - Attachment: (was: OFBIZ-10991-SalesChannel.patch) > Have a SalesChannel dimension > - > > Key: OFBIZ-10991 > URL: https://issues.apache.org/jira/browse/OFBIZ-10991 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh > > The component would benefit from a sales channel dimension for future fact > tables and star schema view entities -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10991) Have a SalesChannel dimension
[ https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028040#comment-17028040 ] Pierre Smits commented on OFBIZ-10991: -- [~jleroux] The issue with your link is that it contains a colon at the end. That is why it won't work. > Have a SalesChannel dimension > - > > Key: OFBIZ-10991 > URL: https://issues.apache.org/jira/browse/OFBIZ-10991 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh > Attachments: OFBIZ-10991-SalesChannel.patch > > > The component would benefit from a sales channel dimension for future fact > tables and star schema view entities -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11329) setUserTimeZone should ran only once based on error
[ https://issues.apache.org/jira/browse/OFBIZ-11329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028038#comment-17028038 ] Jacques Le Roux commented on OFBIZ-11329: - Also I forgot the plugins, here is the patch [^OFBIZ-11329-plugins.patch] . Due to my tools config, there are a lot of EOL spaces removed. Should not be an issue, it's only 1 file > setUserTimeZone should ran only once based on error > --- > > Key: OFBIZ-11329 > URL: https://issues.apache.org/jira/browse/OFBIZ-11329 > Project: OFBiz > Issue Type: Sub-task > Components: framework, webpos >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: James Yong >Priority: Minor > Attachments: OFBIZ-11329-plugins.patch, OFBIZ-11329.patch, > OFBIZ-11329.patch > > > This will be useful when committing CSRF solution as explained in OFBIZ-11306 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11329) setUserTimeZone should ran only once based on error
[ https://issues.apache.org/jira/browse/OFBIZ-11329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11329: Attachment: OFBIZ-11329-plugins.patch > setUserTimeZone should ran only once based on error > --- > > Key: OFBIZ-11329 > URL: https://issues.apache.org/jira/browse/OFBIZ-11329 > Project: OFBiz > Issue Type: Sub-task > Components: framework, webpos >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: James Yong >Priority: Minor > Attachments: OFBIZ-11329-plugins.patch, OFBIZ-11329.patch, > OFBIZ-11329.patch > > > This will be useful when committing CSRF solution as explained in OFBIZ-11306 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10753) Improve error message page to support Theming
[
https://issues.apache.org/jira/browse/OFBIZ-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-10753.
---
Fix Version/s: 18.12.01
17.12.01
Resolution: Implemented
Backported for security reason
> Improve error message page to support Theming
> -
>
> Key: OFBIZ-10753
> URL: https://issues.apache.org/jira/browse/OFBIZ-10753
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: OFBIZ-10753.patch, Sélection_224.png
>
>
> Currently when OFBiz raise an error, we use a jsp page to display it.
> On common-controler.xml :
> {code:java}
> /error/error.jsp{code}
> This method isn't support by the theming. I propose two improvements :
> * use FlexibleLocation to resolve the error page :
> {code:java}
> component://common/webcommon/error/error.ftl{code}
> * improve theme to support the error message page
> {code:java}
>encoder="html" compress="false">
>location="component://common-theme/template/macro/HtmlScreenMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlFormMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlTreeMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl"/>
> + location="component://common-theme/template/ErrorPage.ftl"/>
> {code}
> By the way you can define your error page by the theme in first step and we
> would use the rendering type in future to display the error no only in html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (OFBIZ-10753) Improve error message page to support Theming
[
https://issues.apache.org/jira/browse/OFBIZ-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reopened OFBIZ-10753:
-
Reopening because of backports
> Improve error message page to support Theming
> -
>
> Key: OFBIZ-10753
> URL: https://issues.apache.org/jira/browse/OFBIZ-10753
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-10753.patch, Sélection_224.png
>
>
> Currently when OFBiz raise an error, we use a jsp page to display it.
> On common-controler.xml :
> {code:java}
> /error/error.jsp{code}
> This method isn't support by the theming. I propose two improvements :
> * use FlexibleLocation to resolve the error page :
> {code:java}
> component://common/webcommon/error/error.ftl{code}
> * improve theme to support the error message page
> {code:java}
>encoder="html" compress="false">
>location="component://common-theme/template/macro/HtmlScreenMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlFormMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlTreeMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl"/>
> + location="component://common-theme/template/ErrorPage.ftl"/>
> {code}
> By the way you can define your error page by the theme in first step and we
> would use the rendering type in future to display the error no only in html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10753) Improve error message page to support Theming
[
https://issues.apache.org/jira/browse/OFBIZ-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028033#comment-17028033
]
ASF subversion and git services commented on OFBIZ-10753:
-
Commit 2342e0e8bc213d73ef0b6c88335072b1dde1eac2 in ofbiz-framework's branch
refs/heads/release18.12 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2342e0e ]
Improved: Improve error message page to support Theming
(OFBIZ-10753)
When OFBiz raise an error, the framework use a jsp page to display it.
I improved the error page generation to support also ftl template rendering and
by this way extend the theme engine to support to overide it
On controler.xml we can now use :
/error/error.jsp
or
component://common/webcommon/error/Error.ftl
(default configuration)
On your theme you can add your own error page :
...
+
The component://common/webcommon/error/Error.ftl contains the logic theming
connection and to simplify source code, all framework old error page
(error.jsp) have been removed to centralize all on this new page.
Thanks to Marine Desmarchelier for the error page design
git-svn-id:
https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856175
13f79535-47bb-0310-9956-ffa450edef68
> Improve error message page to support Theming
> -
>
> Key: OFBIZ-10753
> URL: https://issues.apache.org/jira/browse/OFBIZ-10753
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-10753.patch, Sélection_224.png
>
>
> Currently when OFBiz raise an error, we use a jsp page to display it.
> On common-controler.xml :
> {code:java}
> /error/error.jsp{code}
> This method isn't support by the theming. I propose two improvements :
> * use FlexibleLocation to resolve the error page :
> {code:java}
> component://common/webcommon/error/error.ftl{code}
> * improve theme to support the error message page
> {code:java}
>encoder="html" compress="false">
>location="component://common-theme/template/macro/HtmlScreenMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlFormMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlTreeMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl"/>
> + location="component://common-theme/template/ErrorPage.ftl"/>
> {code}
> By the way you can define your error page by the theme in first step and we
> would use the rendering type in future to display the error no only in html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10753) Improve error message page to support Theming
[
https://issues.apache.org/jira/browse/OFBIZ-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028032#comment-17028032
]
ASF subversion and git services commented on OFBIZ-10753:
-
Commit 9b9db9e5111dc5bdf3c3a2fed39e81563343d7ef in ofbiz-framework's branch
refs/heads/release17.12 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9b9db9e ]
Improved: Improve error message page to support Theming
(OFBIZ-10753)
When OFBiz raise an error, the framework use a jsp page to display it.
I improved the error page generation to support also ftl template rendering and
by this way extend the theme engine to support to overide it
On controler.xml we can now use :
/error/error.jsp
or
component://common/webcommon/error/Error.ftl
(default configuration)
On your theme you can add your own error page :
...
+
The component://common/webcommon/error/Error.ftl contains the logic theming
connection and to simplify source code, all framework old error page
(error.jsp) have been removed to centralize all on this new page.
Thanks to Marine Desmarchelier for the error page design
git-svn-id:
https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856175
13f79535-47bb-0310-9956-ffa450edef68
# Conflicts:
#
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java
# themes/common/template/ErrorPage.ftl
> Improve error message page to support Theming
> -
>
> Key: OFBIZ-10753
> URL: https://issues.apache.org/jira/browse/OFBIZ-10753
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-10753.patch, Sélection_224.png
>
>
> Currently when OFBiz raise an error, we use a jsp page to display it.
> On common-controler.xml :
> {code:java}
> /error/error.jsp{code}
> This method isn't support by the theming. I propose two improvements :
> * use FlexibleLocation to resolve the error page :
> {code:java}
> component://common/webcommon/error/error.ftl{code}
> * improve theme to support the error message page
> {code:java}
>encoder="html" compress="false">
>location="component://common-theme/template/macro/HtmlScreenMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlFormMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlTreeMacroLibrary.ftl"/>
>location="component://common-theme/template/macro/HtmlMenuMacroLibrary.ftl"/>
> + location="component://common-theme/template/ErrorPage.ftl"/>
> {code}
> By the way you can define your error page by the theme in first step and we
> would use the rendering type in future to display the error no only in html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
