[jira] [Commented] (OFBIZ-11343) External Server Picture OK in product Catalog but not in eCommerce/econseo
[ https://issues.apache.org/jira/browse/OFBIZ-11343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035125#comment-17035125 ] Pierre Smits commented on OFBIZ-11343: -- Adding to the comment provided by Michael: the default image location for images in the product component is defined in the file 'catalog.properties'. With an adjustment there the default location can be changed to a location elsewhere. It is even possible to have a location outside of the OFBiz structure through a symbolic link inside the OFBiz structure. However that does not cater to integration with modern CDN solutions, where images can be on a different server than where the OFBiz server resided. > External Server Picture OK in product Catalog but not in eCommerce/econseo > -- > > Key: OFBIZ-11343 > URL: https://issues.apache.org/jira/browse/OFBIZ-11343 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, 17.12.01, Release Branch 16.11, 16.11.07, > 16.11.08, Release Branch 17.12, Release Branch 18.12, 18.12.01 > Environment: Ofbiz : Version SVN At revision 1873844. > Ubuntu 18.04.4 LTS (Virtual Machine) > openjdk version "11.0.6" 2020-01-14 > OpenJDK Runtime Environment (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1) > OpenJDK 64-Bit Server VM (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1, mixed > mode, sharing) >Reporter: Jean-Yves Landry >Assignee: Michael Brohl >Priority: Minor > Labels: images > Attachments: image-2020-02-10-01-12-27-323.png > > > In Catalog, we can use an URL referring to a picture stored on a foreign WEB > Server and it seems to work just fine. > EX: product -> content -> Override simple field -> Small Image > [http://192.168.202.246/bibb.png] > !image-2020-02-10-01-12-27-323.png! > > However, in "eCommerce" or "ecomseo", the picture does not display. > Instead of a valid URL, the system reference: > [https://192.168.202.246:8443/ecomseo/product/http%3A%2F%2F192.168.202.246%2Fbibb.png] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11343) External Server Picture OK in product Catalog but not in eCommerce/econseo
[ https://issues.apache.org/jira/browse/OFBIZ-11343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reopened OFBIZ-11343: -- This is indeed an issue. While the design of the functions is good in the product component, it is flawed in the commerce (and maybe also in others where images are shown). The functionality (as in the product component) should work everywhere. > External Server Picture OK in product Catalog but not in eCommerce/econseo > -- > > Key: OFBIZ-11343 > URL: https://issues.apache.org/jira/browse/OFBIZ-11343 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, 17.12.01, Release Branch 16.11, 16.11.07, > 16.11.08, Release Branch 17.12, Release Branch 18.12, 18.12.01 > Environment: Ofbiz : Version SVN At revision 1873844. > Ubuntu 18.04.4 LTS (Virtual Machine) > openjdk version "11.0.6" 2020-01-14 > OpenJDK Runtime Environment (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1) > OpenJDK 64-Bit Server VM (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1, mixed > mode, sharing) >Reporter: Jean-Yves Landry >Assignee: Michael Brohl >Priority: Minor > Labels: images > Attachments: image-2020-02-10-01-12-27-323.png > > > In Catalog, we can use an URL referring to a picture stored on a foreign WEB > Server and it seems to work just fine. > EX: product -> content -> Override simple field -> Small Image > [http://192.168.202.246/bibb.png] > !image-2020-02-10-01-12-27-323.png! > > However, in "eCommerce" or "ecomseo", the picture does not display. > Instead of a valid URL, the system reference: > [https://192.168.202.246:8443/ecomseo/product/http%3A%2F%2F192.168.202.246%2Fbibb.png] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11343) External Server Picture OK in product Catalog but not in eCommerce/econseo
[ https://issues.apache.org/jira/browse/OFBIZ-11343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11343: - Affects Version/s: 18.12.01 Release Branch 18.12 Release Branch 17.12 16.11.08 17.12.01 16.11.07 > External Server Picture OK in product Catalog but not in eCommerce/econseo > -- > > Key: OFBIZ-11343 > URL: https://issues.apache.org/jira/browse/OFBIZ-11343 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, 17.12.01, Release Branch 16.11, 16.11.07, > 16.11.08, Release Branch 17.12, Release Branch 18.12, 18.12.01 > Environment: Ofbiz : Version SVN At revision 1873844. > Ubuntu 18.04.4 LTS (Virtual Machine) > openjdk version "11.0.6" 2020-01-14 > OpenJDK Runtime Environment (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1) > OpenJDK 64-Bit Server VM (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1, mixed > mode, sharing) >Reporter: Jean-Yves Landry >Assignee: Michael Brohl >Priority: Minor > Labels: images > Attachments: image-2020-02-10-01-12-27-323.png > > > In Catalog, we can use an URL referring to a picture stored on a foreign WEB > Server and it seems to work just fine. > EX: product -> content -> Override simple field -> Small Image > [http://192.168.202.246/bibb.png] > !image-2020-02-10-01-12-27-323.png! > > However, in "eCommerce" or "ecomseo", the picture does not display. > Instead of a valid URL, the system reference: > [https://192.168.202.246:8443/ecomseo/product/http%3A%2F%2F192.168.202.246%2Fbibb.png] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11343) External Server Picture OK in product Catalog but not in eCommerce/econseo
[ https://issues.apache.org/jira/browse/OFBIZ-11343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11343: - Affects Version/s: Release Branch 16.11 > External Server Picture OK in product Catalog but not in eCommerce/econseo > -- > > Key: OFBIZ-11343 > URL: https://issues.apache.org/jira/browse/OFBIZ-11343 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11 > Environment: Ofbiz : Version SVN At revision 1873844. > Ubuntu 18.04.4 LTS (Virtual Machine) > openjdk version "11.0.6" 2020-01-14 > OpenJDK Runtime Environment (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1) > OpenJDK 64-Bit Server VM (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1, mixed > mode, sharing) >Reporter: Jean-Yves Landry >Assignee: Michael Brohl >Priority: Minor > Attachments: image-2020-02-10-01-12-27-323.png > > > In Catalog, we can use an URL referring to a picture stored on a foreign WEB > Server and it seems to work just fine. > EX: product -> content -> Override simple field -> Small Image > [http://192.168.202.246/bibb.png] > !image-2020-02-10-01-12-27-323.png! > > However, in "eCommerce" or "ecomseo", the picture does not display. > Instead of a valid URL, the system reference: > [https://192.168.202.246:8443/ecomseo/product/http%3A%2F%2F192.168.202.246%2Fbibb.png] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11343) External Server Picture OK in product Catalog but not in eCommerce/econseo
[ https://issues.apache.org/jira/browse/OFBIZ-11343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11343: - Labels: images (was: ) > External Server Picture OK in product Catalog but not in eCommerce/econseo > -- > > Key: OFBIZ-11343 > URL: https://issues.apache.org/jira/browse/OFBIZ-11343 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk, Release Branch 16.11 > Environment: Ofbiz : Version SVN At revision 1873844. > Ubuntu 18.04.4 LTS (Virtual Machine) > openjdk version "11.0.6" 2020-01-14 > OpenJDK Runtime Environment (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1) > OpenJDK 64-Bit Server VM (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1, mixed > mode, sharing) >Reporter: Jean-Yves Landry >Assignee: Michael Brohl >Priority: Minor > Labels: images > Attachments: image-2020-02-10-01-12-27-323.png > > > In Catalog, we can use an URL referring to a picture stored on a foreign WEB > Server and it seems to work just fine. > EX: product -> content -> Override simple field -> Small Image > [http://192.168.202.246/bibb.png] > !image-2020-02-10-01-12-27-323.png! > > However, in "eCommerce" or "ecomseo", the picture does not display. > Instead of a valid URL, the system reference: > [https://192.168.202.246:8443/ecomseo/product/http%3A%2F%2F192.168.202.246%2Fbibb.png] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10953) have CurrencyDimension have a dimensionId that is based on the natural key
[
https://issues.apache.org/jira/browse/OFBIZ-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035108#comment-17035108
]
Jacopo Cappellato commented on OFBIZ-10953:
---
Hi [~pierresmits],
this is not what I was trying to convey; quoting myself:
{quote}In my opinion, rather than relaxing the "surrogate key" rule for
dimension tables by introducing exceptions to it, it would be better to improve
the implementation of surrogate keys in our BI component
{quote}
So, just to be super clear to avoid that my comment is misinterpreted:
* I didn't say that this *needs* to be done before *anything is added to the
BI component*
* I was not talking about *corrections* that are required: the current code is
not broken or wrong, I see this just as an opportunity for an improvement
* this enhancement would involve the implementation of a new method, db
independent, to define/generate numeric sequences: so it is not a matter of
*correcting* field type or entity engine definitions
* I mentioned this enhancement in this context because we were talking about
the best practices around "surrogate keys" from the DWHT book and this is
something that was in my mind since long: however it is off topic for this
ticket, nor it is blocking any enhancements to be contributed to the BI
component, and it was not my intention to shift the conversation away from the
topic
> have CurrencyDimension have a dimensionId that is based on the natural key
> --
>
> Key: OFBIZ-10953
> URL: https://issues.apache.org/jira/browse/OFBIZ-10953
> Project: OFBiz
> Issue Type: Improvement
> Components: bi
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Labels: CurrencyDimension, birt, currency, dimension, dwh
> Attachments: 20200208_094840.jpg, OFBIZ-10953-BI.patch
>
>
> Currently the record sequencer (delegator.getNextSeqId) is used to determine
> the dimensionId for the CurrencyDimension. This is unnecessary as the uomId
> from the UOM table can be used for currency.
> It also makes it easier to set the foreign-key in fact tables by generating
> it based on the date provided, than by retrieving the dimensionId based on a
> retrieval through the getDimensionIdFromNaturalKey service.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11343) External Server Picture OK in product Catalog but not in eCommerce/econseo
[ https://issues.apache.org/jira/browse/OFBIZ-11343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-11343. - Resolution: Not A Problem > External Server Picture OK in product Catalog but not in eCommerce/econseo > -- > > Key: OFBIZ-11343 > URL: https://issues.apache.org/jira/browse/OFBIZ-11343 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk > Environment: Ofbiz : Version SVN At revision 1873844. > Ubuntu 18.04.4 LTS (Virtual Machine) > openjdk version "11.0.6" 2020-01-14 > OpenJDK Runtime Environment (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1) > OpenJDK 64-Bit Server VM (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1, mixed > mode, sharing) >Reporter: Jean-Yves Landry >Assignee: Michael Brohl >Priority: Minor > Attachments: image-2020-02-10-01-12-27-323.png > > > In Catalog, we can use an URL referring to a picture stored on a foreign WEB > Server and it seems to work just fine. > EX: product -> content -> Override simple field -> Small Image > [http://192.168.202.246/bibb.png] > !image-2020-02-10-01-12-27-323.png! > > However, in "eCommerce" or "ecomseo", the picture does not display. > Instead of a valid URL, the system reference: > [https://192.168.202.246:8443/ecomseo/product/http%3A%2F%2F192.168.202.246%2Fbibb.png] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17035073#comment-17035073 ] Devanshu Vyas commented on OFBIZ-11236: --- Guys, I think we are dragging this ticket a bit much. My humble opinion was to add a feature to edit/delete a note for user convenience, like if he/she added the note mistakenly or made a simple typo which could make the statement different to what was intended. Now, after listening to all the discussion here, I would like to rephrase my statement and to say that we should have a feature to at least expire a note so that an incorrect note should not be associated with the shipment. As for what [~pierresmits] said, "Many companies have strict policies regarding preserving the audit trail (for legal purposes)". I think CRUD services should be available in the system, but using them depends on the user/company. Agree with [~mbrohl] that time should not be a factor for reviewing a new feature and adding the complete set of CRUD services. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11343) External Server Picture OK in product Catalog but not in eCommerce/econseo
[ https://issues.apache.org/jira/browse/OFBIZ-11343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034979#comment-17034979 ] Jean-Yves Landry commented on OFBIZ-11343: -- Go ahead > External Server Picture OK in product Catalog but not in eCommerce/econseo > -- > > Key: OFBIZ-11343 > URL: https://issues.apache.org/jira/browse/OFBIZ-11343 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk > Environment: Ofbiz : Version SVN At revision 1873844. > Ubuntu 18.04.4 LTS (Virtual Machine) > openjdk version "11.0.6" 2020-01-14 > OpenJDK Runtime Environment (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1) > OpenJDK 64-Bit Server VM (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1, mixed > mode, sharing) >Reporter: Jean-Yves Landry >Assignee: Michael Brohl >Priority: Minor > Attachments: image-2020-02-10-01-12-27-323.png > > > In Catalog, we can use an URL referring to a picture stored on a foreign WEB > Server and it seems to work just fine. > EX: product -> content -> Override simple field -> Small Image > [http://192.168.202.246/bibb.png] > !image-2020-02-10-01-12-27-323.png! > > However, in "eCommerce" or "ecomseo", the picture does not display. > Instead of a valid URL, the system reference: > [https://192.168.202.246:8443/ecomseo/product/http%3A%2F%2F192.168.202.246%2Fbibb.png] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11327) Unable to upload content at view profile screen
[ https://issues.apache.org/jira/browse/OFBIZ-11327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034879#comment-17034879 ] Michael Brohl commented on OFBIZ-11327: --- This seem to work on the stable demo, I just checked. The screenshot you provided does show a local instance of OFBiz. Please provide informations about the version used. If it is trunk, please checkout to the newest version. The problem might have been fixed already by the latest change for OFBIZ-5048. > Unable to upload content at view profile screen > --- > > Key: OFBIZ-11327 > URL: https://issues.apache.org/jira/browse/OFBIZ-11327 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Mohammed Rehan Khan >Assignee: Michael Brohl >Priority: Minor > Attachments: FileManager-Ecommerce.png > > > Steps to regenerate - > # Open URL https://demo-stable.ofbiz.apache.org/ecommerce/control/main > # Click on the profile tab > # Go to file manager section > # Upload any type of content > Error - No uploaded content found in the context > Expected - User should be able to upload content > Please refer attachment -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11327) Unable to upload content at view profile screen
[ https://issues.apache.org/jira/browse/OFBIZ-11327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-11327: - Assignee: Michael Brohl > Unable to upload content at view profile screen > --- > > Key: OFBIZ-11327 > URL: https://issues.apache.org/jira/browse/OFBIZ-11327 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Mohammed Rehan Khan >Assignee: Michael Brohl >Priority: Minor > Attachments: FileManager-Ecommerce.png > > > Steps to regenerate - > # Open URL https://demo-stable.ofbiz.apache.org/ecommerce/control/main > # Click on the profile tab > # Go to file manager section > # Upload any type of content > Error - No uploaded content found in the context > Expected - User should be able to upload content > Please refer attachment -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11343) External Server Picture OK in product Catalog but not in eCommerce/econseo
[ https://issues.apache.org/jira/browse/OFBIZ-11343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034874#comment-17034874 ] Michael Brohl commented on OFBIZ-11343: --- [~jylandry], thank you for your your bug report. Are you aware that the project has made the switch to a Git managed repository? You seem to be on the old SVN trunk which is not updated anymore. Regarding the issue itself: I think this is "by design". The ecommerce components expect to find the pictures in the /images/product/ subfolder. If you want to add "free text" content like an image Url, please have a look at the content part of the product management functionality. I would not call it a bug, so if noone objects I would like to close this as "Not a problem". > External Server Picture OK in product Catalog but not in eCommerce/econseo > -- > > Key: OFBIZ-11343 > URL: https://issues.apache.org/jira/browse/OFBIZ-11343 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk > Environment: Ofbiz : Version SVN At revision 1873844. > Ubuntu 18.04.4 LTS (Virtual Machine) > openjdk version "11.0.6" 2020-01-14 > OpenJDK Runtime Environment (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1) > OpenJDK 64-Bit Server VM (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1, mixed > mode, sharing) >Reporter: Jean-Yves Landry >Priority: Minor > Attachments: image-2020-02-10-01-12-27-323.png > > > In Catalog, we can use an URL referring to a picture stored on a foreign WEB > Server and it seems to work just fine. > EX: product -> content -> Override simple field -> Small Image > [http://192.168.202.246/bibb.png] > !image-2020-02-10-01-12-27-323.png! > > However, in "eCommerce" or "ecomseo", the picture does not display. > Instead of a valid URL, the system reference: > [https://192.168.202.246:8443/ecomseo/product/http%3A%2F%2F192.168.202.246%2Fbibb.png] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11343) External Server Picture OK in product Catalog but not in eCommerce/econseo
[ https://issues.apache.org/jira/browse/OFBIZ-11343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-11343: - Assignee: Michael Brohl > External Server Picture OK in product Catalog but not in eCommerce/econseo > -- > > Key: OFBIZ-11343 > URL: https://issues.apache.org/jira/browse/OFBIZ-11343 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk > Environment: Ofbiz : Version SVN At revision 1873844. > Ubuntu 18.04.4 LTS (Virtual Machine) > openjdk version "11.0.6" 2020-01-14 > OpenJDK Runtime Environment (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1) > OpenJDK 64-Bit Server VM (build 11.0.6+10-post-Ubuntu-1ubuntu118.04.1, mixed > mode, sharing) >Reporter: Jean-Yves Landry >Assignee: Michael Brohl >Priority: Minor > Attachments: image-2020-02-10-01-12-27-323.png > > > In Catalog, we can use an URL referring to a picture stored on a foreign WEB > Server and it seems to work just fine. > EX: product -> content -> Override simple field -> Small Image > [http://192.168.202.246/bibb.png] > !image-2020-02-10-01-12-27-323.png! > > However, in "eCommerce" or "ecomseo", the picture does not display. > Instead of a valid URL, the system reference: > [https://192.168.202.246:8443/ecomseo/product/http%3A%2F%2F192.168.202.246%2Fbibb.png] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11346) Provide a FileItem entry in UtilHttp.getMultiPartParameterMap
[ https://issues.apache.org/jira/browse/OFBIZ-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-11346: -- Attachment: OFBIZ-11346.patch > Provide a FileItem entry in UtilHttp.getMultiPartParameterMap > - > > Key: OFBIZ-11346 > URL: https://issues.apache.org/jira/browse/OFBIZ-11346 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-11346.patch > > > In OFBIZ-5048 I proposed to change the file item entry from ByteBuffer to > FileItem for easier access to the file temporarily stored on the server. This > broke existing functionality and was reverted by me today. > I now propose to add a FileItem entry to the multipart map to allow direct > acces to the file item and remain compatible with the services using this > functionality. > A patch will follow. > I also propose to backport this to the 17.12/18.12 branches to provide the > functionality which was reverted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11346) Provide a FileItem entry in UtilHttp.getMultiPartParameterMap
Michael Brohl created OFBIZ-11346: - Summary: Provide a FileItem entry in UtilHttp.getMultiPartParameterMap Key: OFBIZ-11346 URL: https://issues.apache.org/jira/browse/OFBIZ-11346 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 Reporter: Michael Brohl Assignee: Michael Brohl In OFBIZ-5048 I proposed to change the file item entry from ByteBuffer to FileItem for easier access to the file temporarily stored on the server. This broke existing functionality and was reverted by me today. I now propose to add a FileItem entry to the multipart map to allow direct acces to the file item and remain compatible with the services using this functionality. A patch will follow. I also propose to backport this to the 17.12/18.12 branches to provide the functionality which was reverted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event
[ https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-5048. Resolution: Implemented Reverted the latest change, the iriginal improvement remains untouched. > Multi Part Input Parameters not Available in Groovy Event > - > > Key: OFBIZ-5048 > URL: https://issues.apache.org/jira/browse/OFBIZ-5048 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Vikramjit Singh >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, > OFBIZ-5048V2.patch > > > If form is of type enctype="multipart/form-data" and we are handling it's > submission through Groovy Event then in the parameters Map Ofbiz does not set > the multipart input parameters from request parameters. > The same are available when multipart form submission is handled through > service. > The reason being the code that sets the multipart parameters in request > attribute is only available in ServiceEventHandler.java and in > GroovyEventHandler the multipart are never set. > So I have created a method getMultiPartParameterMap in the class > UtilHttp.java and put the common logic in that method so that when > getCombinedMap method is called from the GroovEventHandler the method also > call getMultiPartParameterMap and in the ServiceEventHandler I have written a > call for getMultiPartParameterMap method. > I am attaching the Patch Kindly Verify the same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event
[ https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034828#comment-17034828 ] ASF subversion and git services commented on OFBIZ-5048: Commit de75e163fba948b0459d866292a80831ae449ce2 in ofbiz-framework's branch refs/heads/release18.12 from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=de75e16 ] Revert "Multi Part Input Parameters not Available in Groovy Event (OFBIZ-5048)" This reverts commit 02d59bcd5b0b9040a2fda777d26c0879139ae646. > Multi Part Input Parameters not Available in Groovy Event > - > > Key: OFBIZ-5048 > URL: https://issues.apache.org/jira/browse/OFBIZ-5048 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Vikramjit Singh >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, > OFBIZ-5048V2.patch > > > If form is of type enctype="multipart/form-data" and we are handling it's > submission through Groovy Event then in the parameters Map Ofbiz does not set > the multipart input parameters from request parameters. > The same are available when multipart form submission is handled through > service. > The reason being the code that sets the multipart parameters in request > attribute is only available in ServiceEventHandler.java and in > GroovyEventHandler the multipart are never set. > So I have created a method getMultiPartParameterMap in the class > UtilHttp.java and put the common logic in that method so that when > getCombinedMap method is called from the GroovEventHandler the method also > call getMultiPartParameterMap and in the ServiceEventHandler I have written a > call for getMultiPartParameterMap method. > I am attaching the Patch Kindly Verify the same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event
[ https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034827#comment-17034827 ] ASF subversion and git services commented on OFBIZ-5048: Commit ec3dd184d900b18394adfd739073f5dbf0833bad in ofbiz-framework's branch refs/heads/release17.12 from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ec3dd18 ] Revert "Multi Part Input Parameters not Available in Groovy Event (OFBIZ-5048)" This reverts commit 832217135a4f1e6cffef2ef15d115f43613166bc. > Multi Part Input Parameters not Available in Groovy Event > - > > Key: OFBIZ-5048 > URL: https://issues.apache.org/jira/browse/OFBIZ-5048 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Vikramjit Singh >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, > OFBIZ-5048V2.patch > > > If form is of type enctype="multipart/form-data" and we are handling it's > submission through Groovy Event then in the parameters Map Ofbiz does not set > the multipart input parameters from request parameters. > The same are available when multipart form submission is handled through > service. > The reason being the code that sets the multipart parameters in request > attribute is only available in ServiceEventHandler.java and in > GroovyEventHandler the multipart are never set. > So I have created a method getMultiPartParameterMap in the class > UtilHttp.java and put the common logic in that method so that when > getCombinedMap method is called from the GroovEventHandler the method also > call getMultiPartParameterMap and in the ServiceEventHandler I have written a > call for getMultiPartParameterMap method. > I am attaching the Patch Kindly Verify the same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event
[ https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034825#comment-17034825 ] ASF subversion and git services commented on OFBIZ-5048: Commit 3788f6766a01eb476c15d32e6b9d9127061d12f4 in ofbiz-framework's branch refs/heads/trunk from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3788f67 ] Revert "Multi Part Input Parameters not Available in Groovy Event (OFBIZ-5048)" This reverts commit 8af3e9ce6b4c8d003f760e60c17dfa371745b4fd. > Multi Part Input Parameters not Available in Groovy Event > - > > Key: OFBIZ-5048 > URL: https://issues.apache.org/jira/browse/OFBIZ-5048 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Vikramjit Singh >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, > OFBIZ-5048V2.patch > > > If form is of type enctype="multipart/form-data" and we are handling it's > submission through Groovy Event then in the parameters Map Ofbiz does not set > the multipart input parameters from request parameters. > The same are available when multipart form submission is handled through > service. > The reason being the code that sets the multipart parameters in request > attribute is only available in ServiceEventHandler.java and in > GroovyEventHandler the multipart are never set. > So I have created a method getMultiPartParameterMap in the class > UtilHttp.java and put the common logic in that method so that when > getCombinedMap method is called from the GroovEventHandler the method also > call getMultiPartParameterMap and in the ServiceEventHandler I have written a > call for getMultiPartParameterMap method. > I am attaching the Patch Kindly Verify the same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event
[ https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034823#comment-17034823 ] Michael Brohl commented on OFBIZ-5048: -- For easier access I'd propose to add a FileItem entry instead of just replacing the ByteBuffer. Will create a new issue for it. > Multi Part Input Parameters not Available in Groovy Event > - > > Key: OFBIZ-5048 > URL: https://issues.apache.org/jira/browse/OFBIZ-5048 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Vikramjit Singh >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, > OFBIZ-5048V2.patch > > > If form is of type enctype="multipart/form-data" and we are handling it's > submission through Groovy Event then in the parameters Map Ofbiz does not set > the multipart input parameters from request parameters. > The same are available when multipart form submission is handled through > service. > The reason being the code that sets the multipart parameters in request > attribute is only available in ServiceEventHandler.java and in > GroovyEventHandler the multipart are never set. > So I have created a method getMultiPartParameterMap in the class > UtilHttp.java and put the common logic in that method so that when > getCombinedMap method is called from the GroovEventHandler the method also > call getMultiPartParameterMap and in the ServiceEventHandler I have written a > call for getMultiPartParameterMap method. > I am attaching the Patch Kindly Verify the same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event
[ https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034819#comment-17034819 ] Michael Brohl commented on OFBIZ-5048: -- My suggested change to provide a FileItem instead of a ByteBuffer breaks all services which make use of it. I will revert the change. > Multi Part Input Parameters not Available in Groovy Event > - > > Key: OFBIZ-5048 > URL: https://issues.apache.org/jira/browse/OFBIZ-5048 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Vikramjit Singh >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, > OFBIZ-5048V2.patch > > > If form is of type enctype="multipart/form-data" and we are handling it's > submission through Groovy Event then in the parameters Map Ofbiz does not set > the multipart input parameters from request parameters. > The same are available when multipart form submission is handled through > service. > The reason being the code that sets the multipart parameters in request > attribute is only available in ServiceEventHandler.java and in > GroovyEventHandler the multipart are never set. > So I have created a method getMultiPartParameterMap in the class > UtilHttp.java and put the common logic in that method so that when > getCombinedMap method is called from the GroovEventHandler the method also > call getMultiPartParameterMap and in the ServiceEventHandler I have written a > call for getMultiPartParameterMap method. > I am attaching the Patch Kindly Verify the same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-5048) Multi Part Input Parameters not Available in Groovy Event
[ https://issues.apache.org/jira/browse/OFBIZ-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reopened OFBIZ-5048: -- > Multi Part Input Parameters not Available in Groovy Event > - > > Key: OFBIZ-5048 > URL: https://issues.apache.org/jira/browse/OFBIZ-5048 > Project: OFBiz > Issue Type: New Feature > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Vikramjit Singh >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: GroovyEventMultipartParametes.patch, OFBIZ-5048.patch, > OFBIZ-5048V2.patch > > > If form is of type enctype="multipart/form-data" and we are handling it's > submission through Groovy Event then in the parameters Map Ofbiz does not set > the multipart input parameters from request parameters. > The same are available when multipart form submission is handled through > service. > The reason being the code that sets the multipart parameters in request > attribute is only available in ServiceEventHandler.java and in > GroovyEventHandler the multipart are never set. > So I have created a method getMultiPartParameterMap in the class > UtilHttp.java and put the common logic in that method so that when > getCombinedMap method is called from the GroovEventHandler the method also > call getMultiPartParameterMap and in the ServiceEventHandler I have written a > call for getMultiPartParameterMap method. > I am attaching the Patch Kindly Verify the same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11306) POC for CSRF Token
[
https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034784#comment-17034784
]
Jacques Le Roux commented on OFBIZ-11306:
-
Hi James,
Regarding the issue related to "segmented URIs" (OFBIZ-11007). With minor
changes I was able to make the entity/edit request to works. I notably had to
change from a GET to a POST request. It was needed because else the request
parameters were lost, not sure why yet...
PUT and DELETE works with a small change: {noformat}""{noformat}
replaced by "/" at the top of ViewGeneric.ftl (not sure from where comes
{noformat}""{noformat}...
For the remaining issue with view/entityref_list I have noted your remark about:
{code:java}
if (search) {
list = "$list?search=$search"
main = "$main?search=$search"
} else if (forstatic) {
list = "$list?forstatic=$forstatic"
main = "$main?forstatic=$forstatic"
}
{code}
So still a WIP but the end seems near, here is the latest patch:
[^OFBIZ-11306-alternative.patch]
> POC for CSRF Token
> --
>
> Key: OFBIZ-11306
> URL: https://issues.apache.org/jira/browse/OFBIZ-11306
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Labels: CSRF
> Fix For: Upcoming Branch
>
> Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java,
> CsrfUtil.java, OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-v2.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch,
> OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch,
> OFBIZ-11306_Plugins.patch
>
>
> CRSF tokens are generated using SecureRandom class (maybe later a JWT with a
> "time out").
> They are stored in the user sessions (for AJAX calls and unauthenticated HTTP
> calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during
> POST request.
> # In *controllers* a new csrf-token attribute is added to the security tag to
> exempt or force CSRF token check.
> # In *Widget Forms* a hidden token field is auto-generated.
> # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the
> change. Using <@ofbizUrl> macro to generate the CSRF token means there is no
> need to manually add the CSRF token field to each form in the ftl files. It
> will save time for users doing custom implementation and maintenance. While
> there is CSRF token in the form URL, the token is invalidated during form
> submission. So it's uniqueand harmless even though the CSRF token of the form
> submission is shown in the browser address bar.
> # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added
> through OfbizUtil.js (itself called at start in decorators and such)
> # The html metadata is storing the csrf token used by JQuery AJAX. This token
> will not change to another value after it is consumed
> # Csrf tokens for the user are removed from the UtilCache when the user logs
> out or session invalidated.
> The general rule are as follows:
> * RequestMap configured with 'get' method will be exempted from CSRF token
> check.
> * RequestMap configured with 'post' or 'all' method will be subjected to CSRF
> token check. (Note there are discussions that RequestMap with ‘all’ method
> should also not be subjected to CSRF token check. This will be done after
> ensuring a separate uri is used when posting changes.)
> * "main" request URIs are exempted from CSRF token check.
> * Setting csrf-token to false or true on the Request Map will override the
> general rules above.
> To implement:
> * -Allow token map size to be configurable in properties.- OK that's done
> locally
> To Discuss:
> * Invalidate authenticated user session when CSRF token check fails.
> * Configure the general rules in a Service method (which will be run inside
> the constructor of RequestMap class) when determining the final
> securityCsrfToken value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11306) POC for CSRF Token
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11306: Attachment: OFBIZ-11306-alternative.patch > POC for CSRF Token > -- > > Key: OFBIZ-11306 > URL: https://issues.apache.org/jira/browse/OFBIZ-11306 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Labels: CSRF > Fix For: Upcoming Branch > > Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, > CsrfUtil.java, OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-v2.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch > > > CRSF tokens are generated using SecureRandom class (maybe later a JWT with a > "time out"). > They are stored in the user sessions (for AJAX calls and unauthenticated HTTP > calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during > POST request. > # In *controllers* a new csrf-token attribute is added to the security tag to > exempt or force CSRF token check. > # In *Widget Forms* a hidden token field is auto-generated. > # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the > change. Using <@ofbizUrl> macro to generate the CSRF token means there is no > need to manually add the CSRF token field to each form in the ftl files. It > will save time for users doing custom implementation and maintenance. While > there is CSRF token in the form URL, the token is invalidated during form > submission. So it's uniqueand harmless even though the CSRF token of the form > submission is shown in the browser address bar. > # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added > through OfbizUtil.js (itself called at start in decorators and such) > # The html metadata is storing the csrf token used by JQuery AJAX. This token > will not change to another value after it is consumed > # Csrf tokens for the user are removed from the UtilCache when the user logs > out or session invalidated. > The general rule are as follows: > * RequestMap configured with 'get' method will be exempted from CSRF token > check. > * RequestMap configured with 'post' or 'all' method will be subjected to CSRF > token check. (Note there are discussions that RequestMap with ‘all’ method > should also not be subjected to CSRF token check. This will be done after > ensuring a separate uri is used when posting changes.) > * "main" request URIs are exempted from CSRF token check. > * Setting csrf-token to false or true on the Request Map will override the > general rules above. > To implement: > * -Allow token map size to be configurable in properties.- OK that's done > locally > To Discuss: > * Invalidate authenticated user session when CSRF token check fails. > * Configure the general rules in a Service method (which will be run inside > the constructor of RequestMap class) when determining the final > securityCsrfToken value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10953) have CurrencyDimension have a dimensionId that is based on the natural key
[ https://issues.apache.org/jira/browse/OFBIZ-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034591#comment-17034591 ] Pierre Smits commented on OFBIZ-10953: -- Hi [~jacopoc], So you're saying that before anything is added to the BI component, the field type definitions need to be corrected for it (in line with the pre-bigdata dogma, and before paradigm shifts involving Data Lakes and Data Vaults), plus the entity engine xml file needs to be corrected accordingly? > have CurrencyDimension have a dimensionId that is based on the natural key > -- > > Key: OFBIZ-10953 > URL: https://issues.apache.org/jira/browse/OFBIZ-10953 > Project: OFBiz > Issue Type: Improvement > Components: bi >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: CurrencyDimension, birt, currency, dimension, dwh > Attachments: 20200208_094840.jpg, OFBIZ-10953-BI.patch > > > Currently the record sequencer (delegator.getNextSeqId) is used to determine > the dimensionId for the CurrencyDimension. This is unnecessary as the uomId > from the UOM table can be used for currency. > It also makes it easier to set the foreign-key in fact tables by generating > it based on the date provided, than by retrieving the dimensionId based on a > retrieval through the getDimensionIdFromNaturalKey service. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034567#comment-17034567 ] Gaudin Pierre commented on OFBIZ-11236: --- Thanks Jacques, I'll check it . > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034530#comment-17034530 ] Jacques Le Roux edited comment on OFBIZ-11236 at 2/11/20 3:08 PM: -- Hi [~gpierre], I agree with you and Michael, still my question remains (unrelated to the recent conversation): bq. But I see no notes at the bottom of shipment. Nor can I update or delete this note. I used shipmentId=9996 of Demo1002 order. Could I miss something? I see a note in [~pierresmits]'s image, I wonder why it did not work for me. I'll have a look when more pressing things will fade. Inthe meantime could you confirm it works for you with the shipmentId=9996 of Demo1002 order? Thanks in advance. was (Author: jacques.le.roux): Hi [~gpierre], I agree with you and Michael, still my question remains (unrelated to the recent conversation): bq. But I see no notes at the bottom of shipment. Nor can I update or delete this note. I used shipmentId=9996 of Demo1002 order. Could I miss something? I see a note in [~pierresmits]'s image, I wonder why it did not work for me. I'll have a look when more pressent things will fade. Inthe meantime could you confirm it works for you with the shipmentId=9996 of Demo1002 order? Thanks in advance. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034530#comment-17034530 ] Jacques Le Roux edited comment on OFBIZ-11236 at 2/11/20 3:03 PM: -- Hi [~gpierre], I agree with you and Michael, still my question remains (unrelated to the recent conversation): bq. But I see no notes at the bottom of shipment. Nor can I update or delete this note. I used shipmentId=9996 of Demo1002 order. Could I miss something? I see a note in [~pierresmits]'s image, I wonder why it did not work for me. I'll have a look when more pressent things will fade. Inthe meantime could you confirm it works for you with the shipmentId=9996 of Demo1002 order? Thanks in advance. was (Author: jacques.le.roux): Hi [~gpierre], Still my question remains (unrelated to the recent conversation): bq. But I see no notes at the bottom of shipment. Nor can I update or delete this note. I used shipmentId=9996 of Demo1002 order. Could I miss something? I see a note in [~pierresmits]'s image, I wonder why it did not work for me. I'll have a look when more pressent things will fade. Inthe meantime could you confirm it works for you with the shipmentId=9996 of Demo1002 order? Thanks in advance. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034530#comment-17034530 ] Jacques Le Roux commented on OFBIZ-11236: - Hi [~gpierre], Still my question remains (unrelated to the recent conversation): bq. But I see no notes at the bottom of shipment. Nor can I update or delete this note. I used shipmentId=9996 of Demo1002 order. Could I miss something? I see a note in [~pierresmits]'s image, I wonder why it did not work for me. I'll have a look when more pressent things will fade. Inthe meantime could you confirm it works for you with the shipmentId=9996 of Demo1002 order? Thanks in advance. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034425#comment-17034425 ] Jacques Le Roux edited comment on OFBIZ-11236 at 2/11/20 2:25 PM: -- Hi Pierre, Faster or slower is not my preocupation. Thi is a contribution that you can inprove if you want but i just think, as [~devanshu.vyas] says, that the delete service should be added in the same commit as other services. was (Author: gpierre): Hi Pierre, Faster or slower is not my preocupation. Thi is a contribution that you can inprove if you want but i just think, as [~devanshu.vyas] says, that the delete service should be added in the same commit as other services. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[
https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034468#comment-17034468
]
Michael Brohl commented on OFBIZ-11236:
---
{quote}As Jacques has told me a few times in the past 12 years (and I am
paraphrasing here): something done in less than 10 mins should be good enough
for the next step.
{quote}
I do not think that this is a formula which is valid. Time should not be a
factor when we talk about a *new feature*.
Quality, consistency and completeness should be the main factors to review for
new features. If a feature is committed in an incomplete state it is likely to
stay there in this state for a long time. We struggle with these from time to
time.
So if we have this new feature for shipment notes, it should be complete with
create/update/delete services and functionality in the UI to use them. It would
not be complete if it would only contain, say, a create shipment note
funtionality only.
This should be worked out as long as it takes to be complete.
> Add shipment notes
> --
>
> Key: OFBIZ-11236
> URL: https://issues.apache.org/jira/browse/OFBIZ-11236
> Project: OFBiz
> Issue Type: New Feature
> Components: product
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
> Labels: shipment
> Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot
> 2020-02-11 at 08.53.37.png
>
>
> Hello,
> For many entities there are associated notes. However, there are no notes
> associated with shipments.
> The purpose of this patch is therefore to add notes to the shipments.
> A new tab called "note" appears when displaying a shipment. From this tab it
> is possible to add a note. From the shipment overview a section displays the
> notes associated with the shipment.
> For this new feature a "ShipmentNote" entity has been added. In the same way,
> all the services allowing the management of notes have been associated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034438#comment-17034438 ] Pierre Smits commented on OFBIZ-11236: -- Pierre, I totally have no issues with you doing your thing the way you want to do it. But consider this: Devanshu asked you to consider the delete function for this and you did a new contribution, and then Jacques brought up the other delete and update issue requiring more time to get this ticket closed. Both valid things to consider at another time. But before long another 'what about'-thing will be brought forward. And on and on And then this relatively small, but good, contribution will balloon into something even more time consuming. We should avoid that. As Jacques has told me a few times in the past 12 years (and I am paraphrasing here): something done in less than 10 mins should be good enough for the next step. We don't need to get perfect be the enemy of good enough. Best regards, Pierre > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10577) New Feature: Inventory Cycle Count
[ https://issues.apache.org/jira/browse/OFBIZ-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034428#comment-17034428 ] Pierre Smits commented on OFBIZ-10577: -- HI Yashwant, I had a look at your public fork (on Github) and your development/feature branch (OFBIZ-10577), and the subsequent PR from your OFBIZ-10577 branch in your master branch. That PR is not necessary (as it is all within your public fork of the official OFBiz repository). The only thing left to do, if you're confident that it is good enough and can be brought to the attention of the project (for testing and reviewing) is to submit a PR from your OFBIZ-10577 branch to the master branch of the official OFBiz repository on Github. My apologies if the above seems a bit confusing, but it is the only way to explain it here. Pierre > New Feature: Inventory Cycle Count > -- > > Key: OFBIZ-10577 > URL: https://issues.apache.org/jira/browse/OFBIZ-10577 > Project: OFBiz > Issue Type: New Feature > Components: hhfacility >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Yashwant Dhakad >Priority: Major > Attachments: OFBIZ-10577-Database-Changes.patch, OFBIZ-10577.patch, > screenshot-1-find-session.png, screenshot-2-pending-locations.png, > screenshot-3-add-location-to-session.png, > screenshot-4-list-of-review-session.png, > screenshot-5-review-session-detail.png, screenshot-6-accept-session.png, > screenshot-7-complete-review.png, screenshot-8-report-screen.png > > > *Here are the design notes for cycle count workflow:* > *Find Session Screen:* In this screen, we will show all the sessions created > in the system with respect to the facility, locations, inventory count item, > current status, and created date. We have a search field to filter the > records on the basis of the facility, status. > *Find Pending Locations:* In this screen, we have a table listing all the > pending locations whose countings are pending and we can create a session for > them. All details regarding the pending locations are listed here with the > location, next count date, last count date and days extended for the count, > total inventory item and product for this location. We have facets for > filtering the records on the basis of the facility, not scanned since and > scheduled for next scan. Also, we have a global search at the top of the > screen. In Pending Locations screen, we have a Create Session button. To > create a session we can either select one or more records from the below list > or create a new session by yourself. > In Create Session screen, the basic overview is shown in the "Overview" > section and the items are listed in the "Items" section. We can create a new > line item by clicking on the 'Add' button and we can also update the item > quantity. After completing this, we can proceed with this session and mark it > with 'Pending for Review' status from the 'Status' button at the top of the > screen or we can simply 'Reject'. 'Reject' status button is available at the > top of the screen. > *Find Review Screen:* In this screen, we have a table listing all the > locations pending for the review. All the details regarding the review > sessions are listed with the facility, locations and counted inventory item. > We have facets for filtering records on the basis of the facility. By > clicking any session we can go to its detail screen, where basic details > regarding this session are listed in the 'Overview' section and items are > listed in the 'Items' section. We can select any number of rows and mark them > as 'Accept' or 'Reject'. When these items are marked as 'Accepted' then the > variance is created and these are added in the Count Progress report. Only > authorized persons can accept or reject the sessions and once the session is > accepted it is marked as 'Completed'. > *Count Progress Report:* In this screen, User can view the advanced counting > related analytics with respect to all the 'Completed' status session from > Reports Screen. We can filter the records on the basis of the facility and > within the date range. We can also see the percentage of the total locations, > inventory items counted and errors occurred during the process. Item variance > details are listed in the below section in tabular form. > Following changes to the existing data model to support end to end counting > process flow: > *New entities:* > *InventoryCount* > inventoryCountId > uploadedByUserLogin > facilityId > statusId > createdDatetime > *InventoryCountItem* > inventoryCountId > inventoryCountItemSeqId > inventoryItemId > itemStatusId > locationSeqId > productId > productIdentifier > quantity > *InventoryCountVariance* > inventoryCountId
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034425#comment-17034425 ] Gaudin Pierre commented on OFBIZ-11236: --- Hi Pierre, Faster or slower is not my preocupation. Thi is a contribution that you can inprove if you want but i just think, as [~devanshu.vyas] says, that the delete service should be added in the same commit as other services. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034423#comment-17034423 ] Pierre Smits commented on OFBIZ-11236: -- But I feel the available contributions are good enough for a first merge. Anything else can be done afterwards. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11236: - Labels: shipment (was: ) > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Labels: shipment > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-11236: Assignee: (was: Pierre Smits) > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034413#comment-17034413 ] Pierre Smits commented on OFBIZ-11236: -- Hi Pierre, if you feel that doing so will aid in getting stuff into the codebase faster rather than slower, feel free to do so. > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034411#comment-17034411
]
Pierre Smits commented on OFBIZ-11317:
--
You're welcome.
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11236) Add shipment notes
[ https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034410#comment-17034410 ] Gaudin Pierre commented on OFBIZ-11236: --- Hi Pierre, Can we kepp this jira simple and add all the CRD's services at once? > Add shipment notes > -- > > Key: OFBIZ-11236 > URL: https://issues.apache.org/jira/browse/OFBIZ-11236 > Project: OFBiz > Issue Type: New Feature > Components: product >Affects Versions: Trunk >Reporter: Gaudin Pierre >Assignee: Pierre Smits >Priority: Minor > Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot > 2020-02-11 at 08.53.37.png > > > Hello, > For many entities there are associated notes. However, there are no notes > associated with shipments. > The purpose of this patch is therefore to add notes to the shipments. > A new tab called "note" appears when displaying a shipment. From this tab it > is possible to add a note. From the shipment overview a section displays the > notes associated with the shipment. > For this new feature a "ShipmentNote" entity has been added. In the same way, > all the services allowing the management of notes have been associated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034408#comment-17034408
]
Jacques Le Roux commented on OFBIZ-11317:
-
Thanks Pierre
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10577) New Feature: Inventory Cycle Count
[ https://issues.apache.org/jira/browse/OFBIZ-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034401#comment-17034401 ] Yashwant Dhakad edited comment on OFBIZ-10577 at 2/11/20 12:24 PM: --- Hi Pierre, Thank you for your suggestion. I have created a new branch on my fork repository and created [pull request|[https://github.com/yashwantdhakad/ofbiz-framework/pull/1]|https://github.com/yashwantdhakad/ofbiz-framework/pull/1] in that and if all the changes look good then I will create a pull request for Apache OFBiz repository. was (Author: yashwant.dhakad): Hi Pierre, Thank you for your suggestion. I have created a new branch on my fork repository and created [pull request|[https://github.com/yashwantdhakad/ofbiz-framework/pull/1] in that and if all the changes look good then I will create a pull request for Apache OFBiz repository. > New Feature: Inventory Cycle Count > -- > > Key: OFBIZ-10577 > URL: https://issues.apache.org/jira/browse/OFBIZ-10577 > Project: OFBiz > Issue Type: New Feature > Components: hhfacility >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Yashwant Dhakad >Priority: Major > Attachments: OFBIZ-10577-Database-Changes.patch, OFBIZ-10577.patch, > screenshot-1-find-session.png, screenshot-2-pending-locations.png, > screenshot-3-add-location-to-session.png, > screenshot-4-list-of-review-session.png, > screenshot-5-review-session-detail.png, screenshot-6-accept-session.png, > screenshot-7-complete-review.png, screenshot-8-report-screen.png > > > *Here are the design notes for cycle count workflow:* > *Find Session Screen:* In this screen, we will show all the sessions created > in the system with respect to the facility, locations, inventory count item, > current status, and created date. We have a search field to filter the > records on the basis of the facility, status. > *Find Pending Locations:* In this screen, we have a table listing all the > pending locations whose countings are pending and we can create a session for > them. All details regarding the pending locations are listed here with the > location, next count date, last count date and days extended for the count, > total inventory item and product for this location. We have facets for > filtering the records on the basis of the facility, not scanned since and > scheduled for next scan. Also, we have a global search at the top of the > screen. In Pending Locations screen, we have a Create Session button. To > create a session we can either select one or more records from the below list > or create a new session by yourself. > In Create Session screen, the basic overview is shown in the "Overview" > section and the items are listed in the "Items" section. We can create a new > line item by clicking on the 'Add' button and we can also update the item > quantity. After completing this, we can proceed with this session and mark it > with 'Pending for Review' status from the 'Status' button at the top of the > screen or we can simply 'Reject'. 'Reject' status button is available at the > top of the screen. > *Find Review Screen:* In this screen, we have a table listing all the > locations pending for the review. All the details regarding the review > sessions are listed with the facility, locations and counted inventory item. > We have facets for filtering records on the basis of the facility. By > clicking any session we can go to its detail screen, where basic details > regarding this session are listed in the 'Overview' section and items are > listed in the 'Items' section. We can select any number of rows and mark them > as 'Accept' or 'Reject'. When these items are marked as 'Accepted' then the > variance is created and these are added in the Count Progress report. Only > authorized persons can accept or reject the sessions and once the session is > accepted it is marked as 'Completed'. > *Count Progress Report:* In this screen, User can view the advanced counting > related analytics with respect to all the 'Completed' status session from > Reports Screen. We can filter the records on the basis of the facility and > within the date range. We can also see the percentage of the total locations, > inventory items counted and errors occurred during the process. Item variance > details are listed in the below section in tabular form. > Following changes to the existing data model to support end to end counting > process flow: > *New entities:* > *InventoryCount* > inventoryCountId > uploadedByUserLogin > facilityId > statusId > createdDatetime > *InventoryCountItem* > inventoryCountId > inventoryCountItemSeqId > inventoryItemId > itemStatusId > locationSeqId > productId >
[jira] [Comment Edited] (OFBIZ-10577) New Feature: Inventory Cycle Count
[ https://issues.apache.org/jira/browse/OFBIZ-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034401#comment-17034401 ] Yashwant Dhakad edited comment on OFBIZ-10577 at 2/11/20 12:24 PM: --- Hi Pierre, Thank you for your suggestion. I have created a new branch on my fork repository and created [pull request|[https://github.com/yashwantdhakad/ofbiz-framework/pull/1]] in that and if all the changes look good then I will create a pull request for Apache OFBiz repository. was (Author: yashwant.dhakad): Hi Pierre, Thank you for your suggestion. I have created a new branch on my fork repository and created [pull request|[https://github.com/yashwantdhakad/ofbiz-framework/pull/1]|https://github.com/yashwantdhakad/ofbiz-framework/pull/1] in that and if all the changes look good then I will create a pull request for Apache OFBiz repository. > New Feature: Inventory Cycle Count > -- > > Key: OFBIZ-10577 > URL: https://issues.apache.org/jira/browse/OFBIZ-10577 > Project: OFBiz > Issue Type: New Feature > Components: hhfacility >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Yashwant Dhakad >Priority: Major > Attachments: OFBIZ-10577-Database-Changes.patch, OFBIZ-10577.patch, > screenshot-1-find-session.png, screenshot-2-pending-locations.png, > screenshot-3-add-location-to-session.png, > screenshot-4-list-of-review-session.png, > screenshot-5-review-session-detail.png, screenshot-6-accept-session.png, > screenshot-7-complete-review.png, screenshot-8-report-screen.png > > > *Here are the design notes for cycle count workflow:* > *Find Session Screen:* In this screen, we will show all the sessions created > in the system with respect to the facility, locations, inventory count item, > current status, and created date. We have a search field to filter the > records on the basis of the facility, status. > *Find Pending Locations:* In this screen, we have a table listing all the > pending locations whose countings are pending and we can create a session for > them. All details regarding the pending locations are listed here with the > location, next count date, last count date and days extended for the count, > total inventory item and product for this location. We have facets for > filtering the records on the basis of the facility, not scanned since and > scheduled for next scan. Also, we have a global search at the top of the > screen. In Pending Locations screen, we have a Create Session button. To > create a session we can either select one or more records from the below list > or create a new session by yourself. > In Create Session screen, the basic overview is shown in the "Overview" > section and the items are listed in the "Items" section. We can create a new > line item by clicking on the 'Add' button and we can also update the item > quantity. After completing this, we can proceed with this session and mark it > with 'Pending for Review' status from the 'Status' button at the top of the > screen or we can simply 'Reject'. 'Reject' status button is available at the > top of the screen. > *Find Review Screen:* In this screen, we have a table listing all the > locations pending for the review. All the details regarding the review > sessions are listed with the facility, locations and counted inventory item. > We have facets for filtering records on the basis of the facility. By > clicking any session we can go to its detail screen, where basic details > regarding this session are listed in the 'Overview' section and items are > listed in the 'Items' section. We can select any number of rows and mark them > as 'Accept' or 'Reject'. When these items are marked as 'Accepted' then the > variance is created and these are added in the Count Progress report. Only > authorized persons can accept or reject the sessions and once the session is > accepted it is marked as 'Completed'. > *Count Progress Report:* In this screen, User can view the advanced counting > related analytics with respect to all the 'Completed' status session from > Reports Screen. We can filter the records on the basis of the facility and > within the date range. We can also see the percentage of the total locations, > inventory items counted and errors occurred during the process. Item variance > details are listed in the below section in tabular form. > Following changes to the existing data model to support end to end counting > process flow: > *New entities:* > *InventoryCount* > inventoryCountId > uploadedByUserLogin > facilityId > statusId > createdDatetime > *InventoryCountItem* > inventoryCountId > inventoryCountItemSeqId > inventoryItemId > itemStatusId > locationSeqId > productId >
[jira] [Commented] (OFBIZ-10577) New Feature: Inventory Cycle Count
[ https://issues.apache.org/jira/browse/OFBIZ-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034401#comment-17034401 ] Yashwant Dhakad commented on OFBIZ-10577: - Hi Pierre, Thank you for your suggestion. I have created a new branch on my fork repository and created [pull request|[https://github.com/yashwantdhakad/ofbiz-framework/pull/1] in that and if all the changes look good then I will create a pull request for Apache OFBiz repository. > New Feature: Inventory Cycle Count > -- > > Key: OFBIZ-10577 > URL: https://issues.apache.org/jira/browse/OFBIZ-10577 > Project: OFBiz > Issue Type: New Feature > Components: hhfacility >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Yashwant Dhakad >Priority: Major > Attachments: OFBIZ-10577-Database-Changes.patch, OFBIZ-10577.patch, > screenshot-1-find-session.png, screenshot-2-pending-locations.png, > screenshot-3-add-location-to-session.png, > screenshot-4-list-of-review-session.png, > screenshot-5-review-session-detail.png, screenshot-6-accept-session.png, > screenshot-7-complete-review.png, screenshot-8-report-screen.png > > > *Here are the design notes for cycle count workflow:* > *Find Session Screen:* In this screen, we will show all the sessions created > in the system with respect to the facility, locations, inventory count item, > current status, and created date. We have a search field to filter the > records on the basis of the facility, status. > *Find Pending Locations:* In this screen, we have a table listing all the > pending locations whose countings are pending and we can create a session for > them. All details regarding the pending locations are listed here with the > location, next count date, last count date and days extended for the count, > total inventory item and product for this location. We have facets for > filtering the records on the basis of the facility, not scanned since and > scheduled for next scan. Also, we have a global search at the top of the > screen. In Pending Locations screen, we have a Create Session button. To > create a session we can either select one or more records from the below list > or create a new session by yourself. > In Create Session screen, the basic overview is shown in the "Overview" > section and the items are listed in the "Items" section. We can create a new > line item by clicking on the 'Add' button and we can also update the item > quantity. After completing this, we can proceed with this session and mark it > with 'Pending for Review' status from the 'Status' button at the top of the > screen or we can simply 'Reject'. 'Reject' status button is available at the > top of the screen. > *Find Review Screen:* In this screen, we have a table listing all the > locations pending for the review. All the details regarding the review > sessions are listed with the facility, locations and counted inventory item. > We have facets for filtering records on the basis of the facility. By > clicking any session we can go to its detail screen, where basic details > regarding this session are listed in the 'Overview' section and items are > listed in the 'Items' section. We can select any number of rows and mark them > as 'Accept' or 'Reject'. When these items are marked as 'Accepted' then the > variance is created and these are added in the Count Progress report. Only > authorized persons can accept or reject the sessions and once the session is > accepted it is marked as 'Completed'. > *Count Progress Report:* In this screen, User can view the advanced counting > related analytics with respect to all the 'Completed' status session from > Reports Screen. We can filter the records on the basis of the facility and > within the date range. We can also see the percentage of the total locations, > inventory items counted and errors occurred during the process. Item variance > details are listed in the below section in tabular form. > Following changes to the existing data model to support end to end counting > process flow: > *New entities:* > *InventoryCount* > inventoryCountId > uploadedByUserLogin > facilityId > statusId > createdDatetime > *InventoryCountItem* > inventoryCountId > inventoryCountItemSeqId > inventoryItemId > itemStatusId > locationSeqId > productId > productIdentifier > quantity > *InventoryCountVariance* > inventoryCountId > inventoryCountItemSeqId > inventoryItemId > productId > productIdentifier > locationSeqId > systemQuantityOnHand > actualQuantityOnHand > varianceQuantityOnHand > totalCost > actualCost > costVariance > actualValue > totalValue > valueVariance > unitCost > ***Extended entity:* > *FacilityLocation* > locked >
[jira] [Comment Edited] (OFBIZ-10577) New Feature: Inventory Cycle Count
[ https://issues.apache.org/jira/browse/OFBIZ-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033461#comment-17033461 ] Yashwant Dhakad edited comment on OFBIZ-10577 at 2/11/20 12:21 PM: --- Thanks [~pierresmits] for your response. I agree with your above feedback on using github (or any other git repo tool). I've created a pull request for all the code changes of this feature. Please refer: [https://github.com/yashwantdhakad/ofbiz-framework/pull/1] Please review the changes and provide your valuable feedback. Thanks! was (Author: yashwant.dhakad): Thanks [~pierresmits] for your response. I agree with your above feedback on using github (or any other git repo tool). I've created a pull request for all the code changes of this feature. Please refer: [|https://github.com/apache/ofbiz-framework/pull/11] [https://github.com/yashwantdhakad/ofbiz-framework/pull/1] Please review the changes and provide your valuable feedback. Thanks! > New Feature: Inventory Cycle Count > -- > > Key: OFBIZ-10577 > URL: https://issues.apache.org/jira/browse/OFBIZ-10577 > Project: OFBiz > Issue Type: New Feature > Components: hhfacility >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Yashwant Dhakad >Priority: Major > Attachments: OFBIZ-10577-Database-Changes.patch, OFBIZ-10577.patch, > screenshot-1-find-session.png, screenshot-2-pending-locations.png, > screenshot-3-add-location-to-session.png, > screenshot-4-list-of-review-session.png, > screenshot-5-review-session-detail.png, screenshot-6-accept-session.png, > screenshot-7-complete-review.png, screenshot-8-report-screen.png > > > *Here are the design notes for cycle count workflow:* > *Find Session Screen:* In this screen, we will show all the sessions created > in the system with respect to the facility, locations, inventory count item, > current status, and created date. We have a search field to filter the > records on the basis of the facility, status. > *Find Pending Locations:* In this screen, we have a table listing all the > pending locations whose countings are pending and we can create a session for > them. All details regarding the pending locations are listed here with the > location, next count date, last count date and days extended for the count, > total inventory item and product for this location. We have facets for > filtering the records on the basis of the facility, not scanned since and > scheduled for next scan. Also, we have a global search at the top of the > screen. In Pending Locations screen, we have a Create Session button. To > create a session we can either select one or more records from the below list > or create a new session by yourself. > In Create Session screen, the basic overview is shown in the "Overview" > section and the items are listed in the "Items" section. We can create a new > line item by clicking on the 'Add' button and we can also update the item > quantity. After completing this, we can proceed with this session and mark it > with 'Pending for Review' status from the 'Status' button at the top of the > screen or we can simply 'Reject'. 'Reject' status button is available at the > top of the screen. > *Find Review Screen:* In this screen, we have a table listing all the > locations pending for the review. All the details regarding the review > sessions are listed with the facility, locations and counted inventory item. > We have facets for filtering records on the basis of the facility. By > clicking any session we can go to its detail screen, where basic details > regarding this session are listed in the 'Overview' section and items are > listed in the 'Items' section. We can select any number of rows and mark them > as 'Accept' or 'Reject'. When these items are marked as 'Accepted' then the > variance is created and these are added in the Count Progress report. Only > authorized persons can accept or reject the sessions and once the session is > accepted it is marked as 'Completed'. > *Count Progress Report:* In this screen, User can view the advanced counting > related analytics with respect to all the 'Completed' status session from > Reports Screen. We can filter the records on the basis of the facility and > within the date range. We can also see the percentage of the total locations, > inventory items counted and errors occurred during the process. Item variance > details are listed in the below section in tabular form. > Following changes to the existing data model to support end to end counting > process flow: > *New entities:* > *InventoryCount* > inventoryCountId > uploadedByUserLogin > facilityId > statusId > createdDatetime > *InventoryCountItem* > inventoryCountId >
[jira] [Comment Edited] (OFBIZ-10577) New Feature: Inventory Cycle Count
[ https://issues.apache.org/jira/browse/OFBIZ-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033461#comment-17033461 ] Yashwant Dhakad edited comment on OFBIZ-10577 at 2/11/20 12:19 PM: --- Thanks [~pierresmits] for your response. I agree with your above feedback on using github (or any other git repo tool). I've created a pull request for all the code changes of this feature. Please refer: [https://github.com/yashwantdhakad/ofbiz-framework/pull/1] [|https://github.com/apache/ofbiz-framework/pull/11] Please review the changes and provide your valuable feedback. Thanks! was (Author: yashwant.dhakad): Thanks [~pierresmits] for your response. I agree with your above feedback on using github (or any other git repo tool). I've created a pull request for all the code changes of this feature. Please refer: [https://github.com/apache/ofbiz-framework/pull/11] Please review the changes and provide your valuable feedback. Thanks! > New Feature: Inventory Cycle Count > -- > > Key: OFBIZ-10577 > URL: https://issues.apache.org/jira/browse/OFBIZ-10577 > Project: OFBiz > Issue Type: New Feature > Components: hhfacility >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Yashwant Dhakad >Priority: Major > Attachments: OFBIZ-10577-Database-Changes.patch, OFBIZ-10577.patch, > screenshot-1-find-session.png, screenshot-2-pending-locations.png, > screenshot-3-add-location-to-session.png, > screenshot-4-list-of-review-session.png, > screenshot-5-review-session-detail.png, screenshot-6-accept-session.png, > screenshot-7-complete-review.png, screenshot-8-report-screen.png > > > *Here are the design notes for cycle count workflow:* > *Find Session Screen:* In this screen, we will show all the sessions created > in the system with respect to the facility, locations, inventory count item, > current status, and created date. We have a search field to filter the > records on the basis of the facility, status. > *Find Pending Locations:* In this screen, we have a table listing all the > pending locations whose countings are pending and we can create a session for > them. All details regarding the pending locations are listed here with the > location, next count date, last count date and days extended for the count, > total inventory item and product for this location. We have facets for > filtering the records on the basis of the facility, not scanned since and > scheduled for next scan. Also, we have a global search at the top of the > screen. In Pending Locations screen, we have a Create Session button. To > create a session we can either select one or more records from the below list > or create a new session by yourself. > In Create Session screen, the basic overview is shown in the "Overview" > section and the items are listed in the "Items" section. We can create a new > line item by clicking on the 'Add' button and we can also update the item > quantity. After completing this, we can proceed with this session and mark it > with 'Pending for Review' status from the 'Status' button at the top of the > screen or we can simply 'Reject'. 'Reject' status button is available at the > top of the screen. > *Find Review Screen:* In this screen, we have a table listing all the > locations pending for the review. All the details regarding the review > sessions are listed with the facility, locations and counted inventory item. > We have facets for filtering records on the basis of the facility. By > clicking any session we can go to its detail screen, where basic details > regarding this session are listed in the 'Overview' section and items are > listed in the 'Items' section. We can select any number of rows and mark them > as 'Accept' or 'Reject'. When these items are marked as 'Accepted' then the > variance is created and these are added in the Count Progress report. Only > authorized persons can accept or reject the sessions and once the session is > accepted it is marked as 'Completed'. > *Count Progress Report:* In this screen, User can view the advanced counting > related analytics with respect to all the 'Completed' status session from > Reports Screen. We can filter the records on the basis of the facility and > within the date range. We can also see the percentage of the total locations, > inventory items counted and errors occurred during the process. Item variance > details are listed in the below section in tabular form. > Following changes to the existing data model to support end to end counting > process flow: > *New entities:* > *InventoryCount* > inventoryCountId > uploadedByUserLogin > facilityId > statusId > createdDatetime > *InventoryCountItem* > inventoryCountId > inventoryCountItemSeqId
[jira] [Comment Edited] (OFBIZ-10577) New Feature: Inventory Cycle Count
[ https://issues.apache.org/jira/browse/OFBIZ-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033461#comment-17033461 ] Yashwant Dhakad edited comment on OFBIZ-10577 at 2/11/20 12:19 PM: --- Thanks [~pierresmits] for your response. I agree with your above feedback on using github (or any other git repo tool). I've created a pull request for all the code changes of this feature. Please refer: [|https://github.com/apache/ofbiz-framework/pull/11] [https://github.com/yashwantdhakad/ofbiz-framework/pull/1] Please review the changes and provide your valuable feedback. Thanks! was (Author: yashwant.dhakad): Thanks [~pierresmits] for your response. I agree with your above feedback on using github (or any other git repo tool). I've created a pull request for all the code changes of this feature. Please refer: [https://github.com/yashwantdhakad/ofbiz-framework/pull/1] [|https://github.com/apache/ofbiz-framework/pull/11] Please review the changes and provide your valuable feedback. Thanks! > New Feature: Inventory Cycle Count > -- > > Key: OFBIZ-10577 > URL: https://issues.apache.org/jira/browse/OFBIZ-10577 > Project: OFBiz > Issue Type: New Feature > Components: hhfacility >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Yashwant Dhakad >Priority: Major > Attachments: OFBIZ-10577-Database-Changes.patch, OFBIZ-10577.patch, > screenshot-1-find-session.png, screenshot-2-pending-locations.png, > screenshot-3-add-location-to-session.png, > screenshot-4-list-of-review-session.png, > screenshot-5-review-session-detail.png, screenshot-6-accept-session.png, > screenshot-7-complete-review.png, screenshot-8-report-screen.png > > > *Here are the design notes for cycle count workflow:* > *Find Session Screen:* In this screen, we will show all the sessions created > in the system with respect to the facility, locations, inventory count item, > current status, and created date. We have a search field to filter the > records on the basis of the facility, status. > *Find Pending Locations:* In this screen, we have a table listing all the > pending locations whose countings are pending and we can create a session for > them. All details regarding the pending locations are listed here with the > location, next count date, last count date and days extended for the count, > total inventory item and product for this location. We have facets for > filtering the records on the basis of the facility, not scanned since and > scheduled for next scan. Also, we have a global search at the top of the > screen. In Pending Locations screen, we have a Create Session button. To > create a session we can either select one or more records from the below list > or create a new session by yourself. > In Create Session screen, the basic overview is shown in the "Overview" > section and the items are listed in the "Items" section. We can create a new > line item by clicking on the 'Add' button and we can also update the item > quantity. After completing this, we can proceed with this session and mark it > with 'Pending for Review' status from the 'Status' button at the top of the > screen or we can simply 'Reject'. 'Reject' status button is available at the > top of the screen. > *Find Review Screen:* In this screen, we have a table listing all the > locations pending for the review. All the details regarding the review > sessions are listed with the facility, locations and counted inventory item. > We have facets for filtering records on the basis of the facility. By > clicking any session we can go to its detail screen, where basic details > regarding this session are listed in the 'Overview' section and items are > listed in the 'Items' section. We can select any number of rows and mark them > as 'Accept' or 'Reject'. When these items are marked as 'Accepted' then the > variance is created and these are added in the Count Progress report. Only > authorized persons can accept or reject the sessions and once the session is > accepted it is marked as 'Completed'. > *Count Progress Report:* In this screen, User can view the advanced counting > related analytics with respect to all the 'Completed' status session from > Reports Screen. We can filter the records on the basis of the facility and > within the date range. We can also see the percentage of the total locations, > inventory items counted and errors occurred during the process. Item variance > details are listed in the below section in tabular form. > Following changes to the existing data model to support end to end counting > process flow: > *New entities:* > *InventoryCount* > inventoryCountId > uploadedByUserLogin > facilityId > statusId > createdDatetime >
[jira] [Assigned] (OFBIZ-10665) 2 add to cart buttons in reference to single product at compare product page
[ https://issues.apache.org/jira/browse/OFBIZ-10665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-10665: -- Assignee: Akash Jain (was: Ritesh Kumar) > 2 add to cart buttons in reference to single product at compare product page > > > Key: OFBIZ-10665 > URL: https://issues.apache.org/jira/browse/OFBIZ-10665 > Project: OFBiz > Issue Type: Bug >Reporter: Dikpal Kanungo >Assignee: Akash Jain >Priority: Minor > Attachments: 2 add to cart button.png, OFBIZ-10665.patch > > > When we navigate to Compare product page, there is no use of 2 add to cart > product in reference to the single product. > Steps to regenerate- > 1. Navigate to - demo-trunk.ofbiz.apache.org/ecommerce > 2. Click on add to compare button for the products - Round Gizmo and Tiny > Chrome Widget. > 3. Click on 'Compare All' > Please have a look at the attached screenshot. > > Cheers, > Dikpal !2 add to cart button.png!!2 add to cart button.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10624) Dropdown/facet at Reports under 'Sale Orders By Channel' is not working fine.
[ https://issues.apache.org/jira/browse/OFBIZ-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-10624: -- Assignee: Akash Jain (was: Ritesh Kumar) > Dropdown/facet at Reports under 'Sale Orders By Channel' is not working fine. > - > > Key: OFBIZ-10624 > URL: https://issues.apache.org/jira/browse/OFBIZ-10624 > Project: OFBiz > Issue Type: Bug >Reporter: Dikpal Kanungo >Assignee: Akash Jain >Priority: Trivial > Attachments: Facet.png, OFBIZ-10624.patch > > > The facet should always display 'Select' or default option value (web > channel) in the list, right now it is blank. When a user clicks directly on > 'Run' without selecting any value from facet it generated the report > associated with the first element (web channel) in the list, though nothing > is selected from the list in the facet. !Facet.png! > Please have a look at the attached screenshot for quick reference. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10629) View Request button should not display when there is no customer request data on Quote Items screen
[ https://issues.apache.org/jira/browse/OFBIZ-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-10629: -- Assignee: Akash Jain (was: Kumar Rahul) > View Request button should not display when there is no customer request data > on Quote Items screen > --- > > Key: OFBIZ-10629 > URL: https://issues.apache.org/jira/browse/OFBIZ-10629 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Ritesh Kumar >Assignee: Akash Jain >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10629.patch > > > Currently on the Quote Items screen, in the view request column, a button > link is shown even though there is no customer request data. > Steps to regenerate: > * Create a quote from ordermgs> Quotes screen. > * On the Quote items screen, create Quote item. While creating, do not add > cust request value. > * when an item is added to quote, check the view request column, a button > link will be visible. This button link should not be visible if cust request > data is not there. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034308#comment-17034308
]
Pierre Smits commented on OFBIZ-11317:
--
Thanks Jacques.
A new search (after the aforementioned fix) revealed only hard coded ' Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034303#comment-17034303
]
Jacques Le Roux commented on OFBIZ-11317:
-
Thanks Pierre,
Are we sure it's the only one?
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034299#comment-17034299 ] Aditya Sharma commented on OFBIZ-11333: --- Sure [~mbrohl]. > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034296#comment-17034296 ] Pierre Smits commented on OFBIZ-11333: -- When the code is 'good-enough' and validated (and we can assume it is as it wouldn't be in the code base if it weren't), then there is no need to revert. > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034293#comment-17034293 ] Michael Brohl commented on OFBIZ-11333: --- Hi [~adityasharma] , my question regarding internationalization was triggered by your issue comments only, I did not look deeper into the overall solution so far. I'd suggest to leave the Jira open for review, hope to have a deeper look in the next couple days. > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034290#comment-17034290 ] Aditya Sharma commented on OFBIZ-11333: --- Hi [~mbrohl], I think I made a misassumption that internationalization was the only concern and for rest of code we are good to go. Thus, I committed the code after making the improvement in internationalization. If you think I should revert it, please feel free to let me know, will proceed accordingly. Thank you! > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11317) Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
[
https://issues.apache.org/jira/browse/OFBIZ-11317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits reopened OFBIZ-11317:
--
Reopened, due to missed aspect in header.ftl in the bluelight theme.
I have created [https://github.com/apache/ofbiz-framework/pull/13] to address
this.
> Add 'controlPath' attribute to 'ofbizUrl' freemarker macro
> --
>
> Key: OFBIZ-11317
> URL: https://issues.apache.org/jira/browse/OFBIZ-11317
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11317.patch, OFBIZ-11317.patch,
> OFBIZ-11317_Plugins.patch
>
>
> Currently the ofbizUrl freemarker macro doesn't support uri for other OFBiz
> web application.
> Adding the controlPath attribute to allow the controls by ofbizUrl to support
> uri to other OFBiz web application.
> +*Sample Example*+
> Before:
> class="buttontext">${requestItem.productId!}
> After:
> EditProduct?productId=${requestItem.productId!}"
> class="buttontext">${requestItem.productId!}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034272#comment-17034272 ] Jacques Le Roux commented on OFBIZ-11333: - Michael, bq. Not sure who now committet this, I had expected that there would be a review process before... It's in the 1st line of the commit: " from Aditya Sharma" > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034263#comment-17034263 ] ASF subversion and git services commented on OFBIZ-11333: - Commit 0cd36fe73d12acf0b62b68d647786eb88ef7272b in ofbiz-plugins's branch refs/heads/release17.12 from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=0cd36fe ] Implemented: Cookie Consent In E-Commerce (OFBIZ-11333) Implemented internationalisation by initialising the plugin in header.ftl and using uiLabels for title, message and labels. Thanks Michael Brohl for your inputs > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034262#comment-17034262 ] ASF subversion and git services commented on OFBIZ-11333: - Commit cea914ad86f8e8dde4dd256fead3f2996bacfa63 in ofbiz-plugins's branch refs/heads/release17.12 from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=cea914a ] Implemented: Cookie Consent In E-Commerce (OFBIZ-11333) The Cookie Law is a piece of privacy legislation that requires websites to get consent from visitors to store or retrieve any information on their computer, smartphone or tablet. It was designed to protect online privacy, by making consumers aware of how information about them is collected and used online, and give them a choice to allow it or not. The EU Cookie Legislation began as a directive from the European Union. Some variation on the policy has since been adopted by all countries within the EU. The EU Cookie Legislation requires 4 actions from website owners who use cookies: 1. When someone visits your website, you need to let them know that your site uses cookies. 2. You need to provide detailed information regarding how that cookie data will be utilized. 3. You need to provide visitors with some means of accepting or refusing the use of cookies in your site. 4. If they refuse, you need to ensure that cookies will not be placed on their machine. Used bsgdprcookies plugin to implement the feature. Thanks Deepak Nigam for initiating and providing initial patch. Thanks Deepak Nigam, Pierre Smits, Michael Brohl, Jacques Le Roux and Swapnil M Mane for inputs. > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034260#comment-17034260 ] ASF subversion and git services commented on OFBIZ-11333: - Commit 93f513517ff1042b0e0fc721b9d6a136fa78ef8d in ofbiz-plugins's branch refs/heads/release18.12 from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=93f5135 ] Implemented: Cookie Consent In E-Commerce (OFBIZ-11333) Implemented internationalisation by initialising the plugin in header.ftl and using uiLabels for title, message and labels. Thanks Michael Brohl for your inputs > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034259#comment-17034259 ] ASF subversion and git services commented on OFBIZ-11333: - Commit 8b45efaee30b037ca719fc4781f078438f46789e in ofbiz-plugins's branch refs/heads/release18.12 from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=8b45efa ] Implemented: Cookie Consent In E-Commerce (OFBIZ-11333) The Cookie Law is a piece of privacy legislation that requires websites to get consent from visitors to store or retrieve any information on their computer, smartphone or tablet. It was designed to protect online privacy, by making consumers aware of how information about them is collected and used online, and give them a choice to allow it or not. The EU Cookie Legislation began as a directive from the European Union. Some variation on the policy has since been adopted by all countries within the EU. The EU Cookie Legislation requires 4 actions from website owners who use cookies: 1. When someone visits your website, you need to let them know that your site uses cookies. 2. You need to provide detailed information regarding how that cookie data will be utilized. 3. You need to provide visitors with some means of accepting or refusing the use of cookies in your site. 4. If they refuse, you need to ensure that cookies will not be placed on their machine. Used bsgdprcookies plugin to implement the feature. Thanks Deepak Nigam for initiating and providing initial patch. Thanks Deepak Nigam, Pierre Smits, Michael Brohl, Jacques Le Roux and Swapnil M Mane for inputs. > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034233#comment-17034233 ] Michael Brohl commented on OFBIZ-11333: --- Not sure who now committet this, I had expected that there would be a review process before... > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034224#comment-17034224 ] ASF subversion and git services commented on OFBIZ-11333: - Commit 031fb51255ad5b5dc8a27b8d040bf62b93fb1511 in ofbiz-plugins's branch refs/heads/trunk from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=031fb51 ] Implemented: Cookie Consent In E-Commerce (OFBIZ-11333) Implemented internationalisation by initialising the plugin in header.ftl and using uiLabels for title, message and labels. Thanks Michael Brohl for your inputs > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034225#comment-17034225 ] ASF subversion and git services commented on OFBIZ-11333: - Commit 6f17e2253e3a586e48f39d6e37ed367bff03ee9c in ofbiz-plugins's branch refs/heads/trunk from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=6f17e22 ] Merge pull request #5 from adityasharma7/OFBIZ-11333 Implemented: Cookie Consent In E-Commerce > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11333) Cookie Consent In E-Commerce
[ https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034223#comment-17034223 ] ASF subversion and git services commented on OFBIZ-11333: - Commit e8021b7ede817af1b97972522c8565caab208ccd in ofbiz-plugins's branch refs/heads/trunk from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=e8021b7 ] Implemented: Cookie Consent In E-Commerce (OFBIZ-11333) The Cookie Law is a piece of privacy legislation that requires websites to get consent from visitors to store or retrieve any information on their computer, smartphone or tablet. It was designed to protect online privacy, by making consumers aware of how information about them is collected and used online, and give them a choice to allow it or not. The EU Cookie Legislation began as a directive from the European Union. Some variation on the policy has since been adopted by all countries within the EU. The EU Cookie Legislation requires 4 actions from website owners who use cookies: 1. When someone visits your website, you need to let them know that your site uses cookies. 2. You need to provide detailed information regarding how that cookie data will be utilized. 3. You need to provide visitors with some means of accepting or refusing the use of cookies in your site. 4. If they refuse, you need to ensure that cookies will not be placed on their machine. Used bsgdprcookies plugin to implement the feature. Thanks Deepak Nigam for initiating and providing initial patch. Thanks Deepak Nigam, Pierre Smits, Michael Brohl, Jacques Le Roux and Swapnil M Mane for inputs. > Cookie Consent In E-Commerce > > > Key: OFBIZ-11333 > URL: https://issues.apache.org/jira/browse/OFBIZ-11333 > Project: OFBiz > Issue Type: New Feature > Components: ecommerce >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Deepak Nigam >Assignee: Aditya Sharma >Priority: Minor > Labels: compliance, law > > This ticket has been cloned from OFBIZ-10639: in the original ticket the work > was completed and committed only to the Release Branch 16.11; this new ticket > has been created to implement a solution for the other branches. > = > As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] > The Cookie Law is a piece of privacy legislation that requires websites to > get consent from visitors to store or retrieve any information on their > computer, smartphone or tablet. It was designed to protect online privacy, by > making consumers aware of how information about them is collected and used > online, and give them a choice to allow it or not. > > The EU Cookie Legislation began as a directive from the European Union. Some > variation on the policy has since been adopted by all countries within the EU. > > The EU Cookie Legislation requires 4 actions from website owners who use > cookies: > 1. When someone visits your website, you need to let them know that your > site uses cookies. > 2. You need to provide detailed information regarding how that cookie data > will be utilized. > 3. You need to provide visitors with some means of accepting or refusing the > use of cookies in your site. > 4. If they refuse, you need to ensure that cookies will not be placed on > their machine. > > For more information about EU cookie policy, please visit > [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm]. > > As this crucial feature is missing in OFBiz E-Commerce application, we > should work towards its implementation. There are numerous open-source jQuery > plugins available which we can use. -- This message was sent by Atlassian Jira (v8.3.4#803005)
