[jira] [Commented] (OFBIZ-11423) Put the TOCs on left in generated AsciiDoc documentation
[
https://issues.apache.org/jira/browse/OFBIZ-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046264#comment-17046264
]
ASF subversion and git services commented on OFBIZ-11423:
-
Commit 028b122cbac99fb0abe11742ab8460566672fd6f in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=028b122 ]
Improved: Put the TOCs on left in generated AsciiDoc documentation
(OFBIZ-11423)
Following discussions
* AsciiDoc generated online documentation and releases
* New Online Help, need some ideas
threads on dev ML
I propose as suggested Oliver to put TOCs at the left. If I refer to
https://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/119
toc: 'left@'
should be put in the main build.gradle
Thanks: Olivier Heintz for the suggestion
> Put the TOCs on left in generated AsciiDoc documentation
>
>
> Key: OFBIZ-11423
> URL: https://issues.apache.org/jira/browse/OFBIZ-11423
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> Following discussions
> * [AsciiDoc generated online documentation and
> releases|https://markmail.org/message/x7sv2mpvtytr4vl4]
> * [New Online Help, need some
> ideas|https://markmail.org/message/ky5ejcpk6bphkk6t]
> I propose as suggested Oliver to put TOCs at the left. If I refer
> tohttps://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/119 "{{toc:
> 'left@'}}" should be put in the main build.gradle
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11423) Put the TOCs on left in generated AsciiDoc documentation
[
https://issues.apache.org/jira/browse/OFBIZ-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11423.
---
Fix Version/s: 17.12.01
18.12.01
Resolution: Done
> Put the TOCs on left in generated AsciiDoc documentation
>
>
> Key: OFBIZ-11423
> URL: https://issues.apache.org/jira/browse/OFBIZ-11423
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.01, 17.12.01
>
>
> Following discussions
> * [AsciiDoc generated online documentation and
> releases|https://markmail.org/message/x7sv2mpvtytr4vl4]
> * [New Online Help, need some
> ideas|https://markmail.org/message/ky5ejcpk6bphkk6t]
> I propose as suggested Oliver to put TOCs at the left. If I refer
> tohttps://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/119 "{{toc:
> 'left@'}}" should be put in the main build.gradle
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (OFBIZ-10883) Picklist is in Input status even after order is completed
[ https://issues.apache.org/jira/browse/OFBIZ-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reopened OFBIZ-10883: --- Reopening because of newly introduced checkstyle issues. > Picklist is in Input status even after order is completed > - > > Key: OFBIZ-10883 > URL: https://issues.apache.org/jira/browse/OFBIZ-10883 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Suraj Khurana >Priority: Major > Fix For: 18.12.01, 17.12.02 > > Attachments: OFBIZ-10883-new.patch, OFBIZ-10883.patch, > OrderStatus.jpg, PicklistStatus.jpg > > > Steps to regenerate: > 1. Open https://demo-stable.ofbiz.apache.org/ordermgr/control/main > 2. Create order > 3. Open > https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse > 4. Create Picking > 5. Click on Packing under the facility > 6. Enter order id and click on pack order > 7. Enter package detail and complete packaging > 8. Open > https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse > Actual: Picklist is in the input status > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10883) Picklist is in Input status even after order is completed
[ https://issues.apache.org/jira/browse/OFBIZ-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046172#comment-17046172 ] Pawan Verma commented on OFBIZ-10883: - Hello [~surajk], Thanks, for sending this to the repository. This commit introduced new CheckStyle issues, Could you please take care? Thanks! > Picklist is in Input status even after order is completed > - > > Key: OFBIZ-10883 > URL: https://issues.apache.org/jira/browse/OFBIZ-10883 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Suraj Khurana >Priority: Major > Fix For: 18.12.01, 17.12.02 > > Attachments: OFBIZ-10883-new.patch, OFBIZ-10883.patch, > OrderStatus.jpg, PicklistStatus.jpg > > > Steps to regenerate: > 1. Open https://demo-stable.ofbiz.apache.org/ordermgr/control/main > 2. Create order > 3. Open > https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse > 4. Create Picking > 5. Click on Packing under the facility > 6. Enter order id and click on pack order > 7. Enter package detail and complete packaging > 8. Open > https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse > Actual: Picklist is in the input status > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046149#comment-17046149 ] Priya Sharma commented on OFBIZ-11383: -- Hey Bejamin, Thanks for the review, but I guess the conversion would not fix your issue, as I was not aware of it and so did not keep that in mind. I tried to convert the exact mini-lang version to groovy keeping almost all other things as is. > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045911#comment-17045911 ] Pierre Smits edited comment on OFBIZ-11030 at 2/26/20 9:30 PM: --- Thanks [~sberg], I did some aceptance testing with the changes, and it seems to look good. Except for the loading of the InventoryItemFact entity. Compare OFBIZ-11030-InventoryItemFact-test to OFBIZ-11030-InventoryItemFact-DemoTrunk. Did you experience the same? Maybe you could have a look at this? And there are some flaws implemented previously (e.g. compare OFBIZ-11030-Order-SalesOrder-overview to OFBIZ-11030-SalesOrderItemFact-test, where order DEMO10090 is not included in the SalesOrderItemFact, or the flaws in OFBIZ-11030-SalesInvoiceItemFact-test) With the GIGO (Garbage In Garbage Out) regarding the pre-change code the project should decide wether or not accept the migration. I suggest it should, and deal with the bug fixes at a later date. was (Author: pfm.smits): Thanks [~sberg], I did some aceptance testing with the changes, and it seems to look good. Except for the loading of the InventoryItemFact entity. Compare OFBIZ-11030-InventoryItemFact-test to OFBIZ-11030-InventoryItemFact-DemoTrunk. Maybe you could have a look at this? And there are some flaws implemented previously (e.g. compare OFBIZ-11030-Order-SalesOrder-overview to OFBIZ-11030-SalesOrderItemFact-test, where order DEMO10090 is not included in the SalesOrderItemFact, or the flaws in OFBIZ-11030-SalesInvoiceItemFact-test) With the GIGO (Garbage In Garbage Out) regarding the pre-change code the project should decide wether or not accept the migration. I suggest it should, and deal with the bug fixes at a later date. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045911#comment-17045911 ] Pierre Smits commented on OFBIZ-11030: -- Thanks [~sberg], I did some aceptance testing with the changes, and it seems to look good. Except for the loading of the InventoryItemFact entity. Compare OFBIZ-11030-InventoryItemFact-test to OFBIZ-11030-InventoryItemFact-DemoTrunk. Maybe you could have a look at this? And there are some flaws implemented previously (e.g. compare OFBIZ-11030-Order-SalesOrder-overview to OFBIZ-11030-SalesOrderItemFact-test, where order DEMO10090 is not included in the SalesOrderItemFact, or the flaws in OFBIZ-11030-SalesInvoiceItemFact-test) With the GIGO (Garbage In Garbage Out) regarding the pre-change code the project should decide wether or not accept the migration. I suggest it should, and deal with the bug fixes at a later date. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11030: - Attachment: OFBIZ-11030-InventoryItemFact-test.png > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11030: - Attachment: (was: OFBIZ-11030-InventoryItemFact-test.png) > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11030: - Attachment: OFBIZ-11030-SalesInvoiceItemFact-test.png OFBIZ-11030-InventoryItemFact-test.png OFBIZ-11030-InventoryItemFact-DemoTrunk.png OFBIZ-11030-SalesOrderItemFact-test.png OFBIZ-11030-Order-SalesOrder-overview.png > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11423) Put the TOCs on left in generated AsciiDoc documentation
[
https://issues.apache.org/jira/browse/OFBIZ-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045853#comment-17045853
]
ASF subversion and git services commented on OFBIZ-11423:
-
Commit be7438fb6f9a1f504bf7c7f7a119ef23cdeb1ba2 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=be7438f ]
Improved: Put the TOCs on left in generated AsciiDoc documentation
(OFBIZ-11423)
Following discussions
* AsciiDoc generated online documentation and releases
* New Online Help, need some ideas
threads on dev ML
I propose as suggested Oliver to put TOCs at the left. If I refer to
https://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/119
toc: 'left@'
should be put in the main build.gradle
Thanks: Olivier Heintz for the suggestion
> Put the TOCs on left in generated AsciiDoc documentation
>
>
> Key: OFBIZ-11423
> URL: https://issues.apache.org/jira/browse/OFBIZ-11423
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> Following discussions
> * [AsciiDoc generated online documentation and
> releases|https://markmail.org/message/x7sv2mpvtytr4vl4]
> * [New Online Help, need some
> ideas|https://markmail.org/message/ky5ejcpk6bphkk6t]
> I propose as suggested Oliver to put TOCs at the left. If I refer
> tohttps://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/119 "{{toc:
> 'left@'}}" should be put in the main build.gradle
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11423) Put the TOC on left in generated AsciiDoc documentation
[
https://issues.apache.org/jira/browse/OFBIZ-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11423:
Issue Type: Improvement (was: Bug)
Priority: Trivial (was: Major)
> Put the TOC on left in generated AsciiDoc documentation
> ---
>
> Key: OFBIZ-11423
> URL: https://issues.apache.org/jira/browse/OFBIZ-11423
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> Following discussions
> * [AsciiDoc generated online documentation and
> releases|https://markmail.org/message/x7sv2mpvtytr4vl4]
> * [New Online Help, need some
> ideas|https://markmail.org/message/ky5ejcpk6bphkk6t]
> I propose as suggested Oliver to put TOCs at the left. If I refer
> tohttps://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/119 "{{toc:
> 'left@'}}" should be put in the main build.gradle
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11423) Put the TOCs on left in generated AsciiDoc documentation
[
https://issues.apache.org/jira/browse/OFBIZ-11423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11423:
Summary: Put the TOCs on left in generated AsciiDoc documentation (was:
Put the TOC on left in generated AsciiDoc documentation)
> Put the TOCs on left in generated AsciiDoc documentation
>
>
> Key: OFBIZ-11423
> URL: https://issues.apache.org/jira/browse/OFBIZ-11423
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
>
> Following discussions
> * [AsciiDoc generated online documentation and
> releases|https://markmail.org/message/x7sv2mpvtytr4vl4]
> * [New Online Help, need some
> ideas|https://markmail.org/message/ky5ejcpk6bphkk6t]
> I propose as suggested Oliver to put TOCs at the left. If I refer
> tohttps://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/119 "{{toc:
> 'left@'}}" should be put in the main build.gradle
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11423) Put the TOC on left in generated AsciiDoc documentation
Jacques Le Roux created OFBIZ-11423:
---
Summary: Put the TOC on left in generated AsciiDoc documentation
Key: OFBIZ-11423
URL: https://issues.apache.org/jira/browse/OFBIZ-11423
Project: OFBiz
Issue Type: Bug
Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Following discussions
* [AsciiDoc generated online documentation and
releases|https://markmail.org/message/x7sv2mpvtytr4vl4]
* [New Online Help, need some
ideas|https://markmail.org/message/ky5ejcpk6bphkk6t]
I propose as suggested Oliver to put TOCs at the left. If I refer
tohttps://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/119 "{{toc:
'left@'}}" should be put in the main build.gradle
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045680#comment-17045680
]
Benjamin Jugl commented on OFBIZ-10688:
---
The service has been converted to goovy in OFBIZ-11383. I will review the
patch. We should however separate the conversion and the fix. So I will base my
development on the conversion once it is done.
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045674#comment-17045674 ] Benjamin Jugl commented on OFBIZ-11383: --- Hi there. This service was subject to Issue OFBIZ-10688. Thank you for the groovy conversion. I will check it as you demanded and additionally check if the Bug of former mentioned issue is still occuring. You might already have fixed it, if not, I would gladly use your conversion as a starting point. Greetings! > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11418) Use FlexibleStringExpander in form widget lookup field field target parameters
[ https://issues.apache.org/jira/browse/OFBIZ-11418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford updated OFBIZ-11418: --- Labels: patch-available (was: ) > Use FlexibleStringExpander in form widget lookup field field target parameters > -- > > Key: OFBIZ-11418 > URL: https://issues.apache.org/jira/browse/OFBIZ-11418 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Major > Labels: patch-available > Time Spent: 10m > Remaining Estimate: 0h > > OFBIZ-11330 added use of FlexibleStringExpander when generating the > parameter-name for a Form Widget Field. > The form widget's Lookup field makes use of a target-parameter attribute to > determine the input fields which should be read from when making a lookup > request. > Since we can now generate field parameter names from FlexibleStringExpander > expressions it seems appropriate to be able to populate the target-parameter > with the same expressions. Not doing so means that we can potentially > generate parameter names that cannot be referenced by a lookup field. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11306) POC for CSRF Token
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045635#comment-17045635 ] Jacques Le Roux commented on OFBIZ-11306: - I removed the [remote "origin"] block from my local config and now there is a POC-for-CSRF-Token-OFBIZ-11306 branch at https://github.com/apache/ofbiz-framework but for a reason the 'Compare and pull request" button fails. OK, enough for today on this... > POC for CSRF Token > -- > > Key: OFBIZ-11306 > URL: https://issues.apache.org/jira/browse/OFBIZ-11306 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Labels: CSRF > Fix For: Upcoming Branch > > Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, > CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative merged with James's.patch, OFBIZ-11306-alternative > merged with James's.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-v2.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > partyTokenMap.webtools.txt > > > CRSF tokens are generated using SecureRandom class (maybe later a JWT with a > "time out"). > They are stored in the user sessions (for AJAX calls and unauthenticated HTTP > calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during > POST request. > # In *controllers* a new csrf-token attribute is added to the security tag to > exempt or force CSRF token check. > # In *Widget Forms* a hidden token field is auto-generated. > # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the > change. Using <@ofbizUrl> macro to generate the CSRF token means there is no > need to manually add the CSRF token field to each form in the ftl files. It > will save time for users doing custom implementation and maintenance. While > there is CSRF token in the form URL, the token is invalidated during form > submission. So it's uniqueand harmless even though the CSRF token of the form > submission is shown in the browser address bar. > # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added > through OfbizUtil.js (itself called at start in decorators and such) > # The html metadata is storing the csrf token used by JQuery AJAX. This token > will not change to another value after it is consumed > # Csrf tokens for the user are removed from the UtilCache when the user logs > out or session invalidated. > The general rule are as follows: > * RequestMap configured with 'get' method will be exempted from CSRF token > check. > * RequestMap configured with 'post' or 'all' method will be subjected to CSRF > token check. (Note there are discussions that RequestMap with ‘all’ method > should also not be subjected to CSRF token check. This will be done after > ensuring a separate uri is used when posting changes.) > * "main" request URIs are exempted from CSRF token check. > * Setting csrf-token to false or true on the Request Map will override the > general rules above. > To Discuss: > * Invalidate authenticated user session when CSRF token check fails. > * Configure the general rules in a Service method (which will be run inside > the constructor of RequestMap class) when determining the final > securityCsrfToken value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11306) POC for CSRF Token
[
https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045625#comment-17045625
]
Jacques Le Roux commented on OFBIZ-11306:
-
Hi James,
Despite having this local Git config:
{noformat}
[remote "origin"]
url = https://gitbox.apache.org/repos/asf/ofbiz-framework.git
fetch = +refs/pull/*/merge:refs/remotes/origin/pr/*
fetch = +refs/heads/*:refs/remotes/origin/*
puttykeyfile = C:\\asfjler...@apache.org.private.ppk
[remote "OFBiz"]
url = https://github.com/apache/ofbiz-framework.git
fetch = +refs/pull/*/merge:refs/remotes/OFBiz/pr/*
fetch = +refs/heads/*:refs/remotes/OFBiz/*
{noformat}
and pushing to "OFBiz" remote, my local branch finally ended at
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=shortlog;h=refs/heads/POC-for-CSRF-Token-OFBIZ-11306
instead of a branch of https://github.com/JacquesLeRoux/ofbiz-framework to
where I expect to push the new local branch.
I don't think it's a big deal for 2 reasons:
* we are near an end and mostly need reviews and tests from others now
* we are both committers
So we can not only both work from this feature branch but also others can.
> POC for CSRF Token
> --
>
> Key: OFBIZ-11306
> URL: https://issues.apache.org/jira/browse/OFBIZ-11306
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Labels: CSRF
> Fix For: Upcoming Branch
>
> Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java,
> CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch,
> OFBIZ-11306-alternative merged with James's.patch, OFBIZ-11306-alternative
> merged with James's.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch,
> OFBIZ-11306-v2.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch,
> OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch,
> OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch,
> OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch,
> partyTokenMap.webtools.txt
>
>
> CRSF tokens are generated using SecureRandom class (maybe later a JWT with a
> "time out").
> They are stored in the user sessions (for AJAX calls and unauthenticated HTTP
> calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during
> POST request.
> # In *controllers* a new csrf-token attribute is added to the security tag to
> exempt or force CSRF token check.
> # In *Widget Forms* a hidden token field is auto-generated.
> # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the
> change. Using <@ofbizUrl> macro to generate the CSRF token means there is no
> need to manually add the CSRF token field to each form in the ftl files. It
> will save time for users doing custom implementation and maintenance. While
> there is CSRF token in the form URL, the token is invalidated during form
> submission. So it's uniqueand harmless even though the CSRF token of the form
> submission is shown in the browser address bar.
> # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added
> through OfbizUtil.js (itself called at start in decorators and such)
> # The html metadata is storing the csrf token used by JQuery AJAX. This token
> will not change to another value after it is consumed
> # Csrf tokens for the user are removed from the UtilCache when the user logs
> out or session invalidated.
> The general rule are as follows:
> * RequestMap configured with 'get' method will be exempted from CSRF token
> check.
> * RequestMap configured with 'post' or 'all' method will be subjected to CSRF
> token check. (Note there are discussions that RequestMap with ‘all’ method
> should also not be subjected to CSRF token check. This will be done after
> ensuring a separate uri is used when posting changes.)
> * "main" request URIs are exempted from CSRF token check.
> * Setting csrf-token to false or true on the Request Map will override the
> general rules above.
> To Discuss:
> * Invalidate authenticated user session when CSRF token check fails.
> * Configure the general rules in a Service method (which will be run inside
> the constructor of
[jira] [Commented] (OFBIZ-11306) POC for CSRF Token
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045609#comment-17045609 ] ASF subversion and git services commented on OFBIZ-11306: - Commit 69b551038801e53c1cd3b8c03ddf1fab0198c3fc in ofbiz-framework's branch refs/heads/POC-for-CSRF-Token-OFBIZ-11306 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=69b5510 ] Creates new POC-for-CSRF-Token-OFBIZ-11306 branch To share with James and others and later when OK to create a PR > POC for CSRF Token > -- > > Key: OFBIZ-11306 > URL: https://issues.apache.org/jira/browse/OFBIZ-11306 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Labels: CSRF > Fix For: Upcoming Branch > > Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, > CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative merged with James's.patch, OFBIZ-11306-alternative > merged with James's.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-v2.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > partyTokenMap.webtools.txt > > > CRSF tokens are generated using SecureRandom class (maybe later a JWT with a > "time out"). > They are stored in the user sessions (for AJAX calls and unauthenticated HTTP > calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during > POST request. > # In *controllers* a new csrf-token attribute is added to the security tag to > exempt or force CSRF token check. > # In *Widget Forms* a hidden token field is auto-generated. > # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the > change. Using <@ofbizUrl> macro to generate the CSRF token means there is no > need to manually add the CSRF token field to each form in the ftl files. It > will save time for users doing custom implementation and maintenance. While > there is CSRF token in the form URL, the token is invalidated during form > submission. So it's uniqueand harmless even though the CSRF token of the form > submission is shown in the browser address bar. > # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added > through OfbizUtil.js (itself called at start in decorators and such) > # The html metadata is storing the csrf token used by JQuery AJAX. This token > will not change to another value after it is consumed > # Csrf tokens for the user are removed from the UtilCache when the user logs > out or session invalidated. > The general rule are as follows: > * RequestMap configured with 'get' method will be exempted from CSRF token > check. > * RequestMap configured with 'post' or 'all' method will be subjected to CSRF > token check. (Note there are discussions that RequestMap with ‘all’ method > should also not be subjected to CSRF token check. This will be done after > ensuring a separate uri is used when posting changes.) > * "main" request URIs are exempted from CSRF token check. > * Setting csrf-token to false or true on the Request Map will override the > general rules above. > To Discuss: > * Invalidate authenticated user session when CSRF token check fails. > * Configure the general rules in a Service method (which will be run inside > the constructor of RequestMap class) when determining the final > securityCsrfToken value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11419) hr-glossary.adoc: line 22: id assigned to block already in use: ANNUAL_REVENUE
[
https://issues.apache.org/jira/browse/OFBIZ-11419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-11419.
-
Fix Version/s: Upcoming Branch
Resolution: Fixed
> hr-glossary.adoc: line 22: id assigned to block already in use: ANNUAL_REVENUE
> --
>
> Key: OFBIZ-11419
> URL: https://issues.apache.org/jira/browse/OFBIZ-11419
> Project: OFBiz
> Issue Type: Bug
> Components: humanres
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Olivier Heintz
>Priority: Minor
> Labels: documentation
> Fix For: Upcoming Branch
>
> Attachments:
> 0001-fixed-remove-ANNUAL_REVENUE-from-hr-glossary-it-s-al.patch
>
>
> Hi [~holivier] ,
> after merging all documentation into trunk and fixing a bug, the following
> warnings occur:
> {code:java}
> > Task :generateOfbizDocumentation
> Feb 25, 2020 10:42:35 PM
> uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb next_section
> WARNUNG:
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc: line
> 22: id assigned to block already in use: ANNUAL_REVENUE
> id assigned to block already in use: ANNUAL_REVENUE ::
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc ::
> /Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include//Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc:22
>
> (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:next_section)
> Feb 25, 2020 10:42:39 PM
> uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/document.rb parse
> WARNUNG:
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc: line
> 22: id assigned to block already in use: ANNUAL_REVENUE
> id assigned to block already in use: ANNUAL_REVENUE ::
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc ::
> /Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include//Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc:22
> (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/document.rb:parse)
> {code}
> I guess it is because ANNUAL_REVENUE is used in both acc-glossary.adoc and
> hr-glossary.adoc.
> Can you please check? Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-6033) InduceModelFromDb field definitions
[ https://issues.apache.org/jira/browse/OFBIZ-6033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045589#comment-17045589 ] Jacques Le Roux commented on OFBIZ-6033: Somehow related to OFBIZ-6510 > InduceModelFromDb field definitions > > > Key: OFBIZ-6033 > URL: https://issues.apache.org/jira/browse/OFBIZ-6033 > Project: OFBiz > Issue Type: Improvement >Affects Versions: 13.07.01 >Reporter: Ralf >Priority: Minor > > webtools/control/view/ModelInduceFromDb > (1) > creates some fields like this: > invalid-LONGTEXT:2147483647:0 > when reading the structure of a mysql (e.g. wordpress) database. > For example for some fields of this structure (in wordpress > /wp-admin/includes/schema.php) > CREATE TABLE $wpdb->posts ( > ID bigint(20) unsigned NOT NULL auto_increment, > post_author bigint(20) unsigned NOT NULL default '0', > post_date datetime NOT NULL default '-00-00 00:00:00', > post_date_gmt datetime NOT NULL default '-00-00 00:00:00', > post_content longtext NOT NULL, > post_title text NOT NULL, > post_excerpt text NOT NULL, > post_status varchar(20) NOT NULL default 'publish', > comment_status varchar(20) NOT NULL default 'open', > ping_status varchar(20) NOT NULL default 'open', > post_password varchar(20) NOT NULL default '', > post_name varchar(200) NOT NULL default '', > to_ping text NOT NULL, > pinged text NOT NULL, > post_modified datetime NOT NULL default '-00-00 00:00:00', > post_modified_gmt datetime NOT NULL default '-00-00 00:00:00', > post_content_filtered longtext NOT NULL, > post_parent bigint(20) unsigned NOT NULL default '0', > guid varchar(255) NOT NULL default '', > menu_order int(11) NOT NULL default '0', > post_type varchar(20) NOT NULL default 'post', > post_mime_type varchar(100) NOT NULL default '', > comment_count bigint(20) NOT NULL default '0', > PRIMARY KEY (ID), > KEY post_name (post_name), > KEY type_status_date (post_type,post_status,post_date,ID), > KEY post_parent (post_parent), > KEY post_author (post_author) > ) $charset_collate;\n"; > it creates: > package-name="" > title="None" > copyright="Copyright 2001-2015 The Apache Software Foundation"> > > > > > > > > > >type="invalid-LONGTEXT:2147483647:0"> > > > > > > > > > > > > > > > (2) regarding font color: > the output of ModelInduceFromDb seems to be formatted white, > so it is only readable in browsers "view source". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-5486) ModelInduceFromDb.jsp entitymodel.xml output saved to hot-deploy component causes start to fail
[
https://issues.apache.org/jira/browse/OFBIZ-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-5486:
---
Description:
I get this error when I paste the results of ModelInduceFromDb.jsp
entitymodel.xml output to the corresponding hot-deploy component:
{noformat}
2014-01-14 10:58:24,066 (main) [DelegatorFactoryImpl.java:30 :INFO ] Creating
new delegator [default] (main)
2014-01-14 10:58:25,728 (main) [UtilXml.java:1047:WARN ]
[UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with
publicId [-//OFBiz//DTD Entity Model//EN] and the file/resource is
[entitymodel.dtd]
2014-01-14 10:58:25,934 (main) [DelegatorFactoryImpl.java:35 :ERROR]
exception report --
Error creating delegator
Exception: org.ofbiz.entity.GenericEntityConfException
Message: Error getting document from resource handler (Error reading
ComponentResourceHandler from XML file [legacydb] with loaderName [main] and
location [entitydef/entitymodel.xml]
(http://ofbiz.apache.org/dtds/entitymodel.dtd))
cause -
Exception: org.ofbiz.base.config.GenericConfigException
Message: Error reading ComponentResourceHandler from XML file [legacydb] with
loaderName [main] and location [entitydef/entitymodel.xml]
(http://ofbiz.apache.org/dtds/entitymodel.dtd)
cause -
Exception: java.io.FileNotFoundException
Message: http://ofbiz.apache.org/dtds/entitymodel.dtd
{noformat}
was:
I get this error when I paste the results of ModelInduceFromDb.jsp
entitymodel.xml output to the corresponding hot-deploy component:
2014-01-14 10:58:24,066 (main) [DelegatorFactoryImpl.java:30 :INFO ] Creating
new delegator [default] (main)
2014-01-14 10:58:25,728 (main) [UtilXml.java:1047:WARN ]
[UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with
publicId [-//OFBiz//DTD Entity Model//EN] and the file/resource is
[entitymodel.dtd]
2014-01-14 10:58:25,934 (main) [DelegatorFactoryImpl.java:35 :ERROR]
exception report --
Error creating delegator
Exception: org.ofbiz.entity.GenericEntityConfException
Message: Error getting document from resource handler (Error reading
ComponentResourceHandler from XML file [legacydb] with loaderName [main] and
location [entitydef/entitymodel.xml]
(http://ofbiz.apache.org/dtds/entitymodel.dtd))
cause -
Exception: org.ofbiz.base.config.GenericConfigException
Message: Error reading ComponentResourceHandler from XML file [legacydb] with
loaderName [main] and location [entitydef/entitymodel.xml]
(http://ofbiz.apache.org/dtds/entitymodel.dtd)
cause -
Exception: java.io.FileNotFoundException
Message: http://ofbiz.apache.org/dtds/entitymodel.dtd
> ModelInduceFromDb.jsp entitymodel.xml output saved to hot-deploy component
> causes start to fail
> ---
>
> Key: OFBIZ-5486
> URL: https://issues.apache.org/jira/browse/OFBIZ-5486
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Christian Carlow
>Assignee: Adam Heath
>Priority: Major
>
> I get this error when I paste the results of ModelInduceFromDb.jsp
> entitymodel.xml output to the corresponding hot-deploy component:
> {noformat}
> 2014-01-14 10:58:24,066 (main) [DelegatorFactoryImpl.java:30 :INFO ] Creating
> new delegator [default] (main)
> 2014-01-14 10:58:25,728 (main) [UtilXml.java:1047:WARN ]
> [UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with
> publicId [-//OFBiz//DTD Entity Model//EN] and the file/resource is
> [entitymodel.dtd]
> 2014-01-14 10:58:25,934 (main) [DelegatorFactoryImpl.java:35 :ERROR]
> exception report
> --
> Error creating delegator
> Exception: org.ofbiz.entity.GenericEntityConfException
> Message: Error getting document from resource handler (Error reading
> ComponentResourceHandler from XML file [legacydb] with loaderName [main] and
> location [entitydef/entitymodel.xml]
> (http://ofbiz.apache.org/dtds/entitymodel.dtd))
> cause
> -
> Exception: org.ofbiz.base.config.GenericConfigException
> Message: Error reading ComponentResourceHandler from XML file [legacydb] with
> loaderName [main] and location [entitydef/entitymodel.xml]
> (http://ofbiz.apache.org/dtds/entitymodel.dtd)
>
[jira] [Closed] (OFBIZ-5486) ModelInduceFromDb.jsp entitymodel.xml output saved to hot-deploy component causes start to fail
[ https://issues.apache.org/jira/browse/OFBIZ-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5486. -- Resolution: Won't Fix Not really a duplicate of OFBIZ-6510 but it's time to close here > ModelInduceFromDb.jsp entitymodel.xml output saved to hot-deploy component > causes start to fail > --- > > Key: OFBIZ-5486 > URL: https://issues.apache.org/jira/browse/OFBIZ-5486 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Adam Heath >Priority: Major > > I get this error when I paste the results of ModelInduceFromDb.jsp > entitymodel.xml output to the corresponding hot-deploy component: > > 2014-01-14 10:58:24,066 (main) [DelegatorFactoryImpl.java:30 :INFO ] Creating > new delegator [default] (main) > 2014-01-14 10:58:25,728 (main) [UtilXml.java:1047:WARN ] > [UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with > publicId [-//OFBiz//DTD Entity Model//EN] and the file/resource is > [entitymodel.dtd] > 2014-01-14 10:58:25,934 (main) [DelegatorFactoryImpl.java:35 :ERROR] > exception report > -- > Error creating delegator > Exception: org.ofbiz.entity.GenericEntityConfException > Message: Error getting document from resource handler (Error reading > ComponentResourceHandler from XML file [legacydb] with loaderName [main] and > location [entitydef/entitymodel.xml] > (http://ofbiz.apache.org/dtds/entitymodel.dtd)) > cause > - > Exception: org.ofbiz.base.config.GenericConfigException > Message: Error reading ComponentResourceHandler from XML file [legacydb] with > loaderName [main] and location [entitydef/entitymodel.xml] > (http://ofbiz.apache.org/dtds/entitymodel.dtd) > cause > - > Exception: java.io.FileNotFoundException > Message: http://ofbiz.apache.org/dtds/entitymodel.dtd > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11419) hr-glossary.adoc: line 22: id assigned to block already in use: ANNUAL_REVENUE
[
https://issues.apache.org/jira/browse/OFBIZ-11419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045571#comment-17045571
]
ASF subversion and git services commented on OFBIZ-11419:
-
Commit c0a9714ef14f37c02270f953f28925f9ad415c0d in ofbiz-framework's branch
refs/heads/trunk from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c0a9714 ]
Fixed: hr-glossary.adoc: line 22: id assigned to block already in use:
ANNUAL_REVENUE
(OFBIZ-11419)
Thanks Olivier Heintz for providing the patch.
> hr-glossary.adoc: line 22: id assigned to block already in use: ANNUAL_REVENUE
> --
>
> Key: OFBIZ-11419
> URL: https://issues.apache.org/jira/browse/OFBIZ-11419
> Project: OFBiz
> Issue Type: Bug
> Components: humanres
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Olivier Heintz
>Priority: Minor
> Labels: documentation
> Attachments:
> 0001-fixed-remove-ANNUAL_REVENUE-from-hr-glossary-it-s-al.patch
>
>
> Hi [~holivier] ,
> after merging all documentation into trunk and fixing a bug, the following
> warnings occur:
> {code:java}
> > Task :generateOfbizDocumentation
> Feb 25, 2020 10:42:35 PM
> uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb next_section
> WARNUNG:
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc: line
> 22: id assigned to block already in use: ANNUAL_REVENUE
> id assigned to block already in use: ANNUAL_REVENUE ::
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc ::
> /Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include//Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc:22
>
> (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:next_section)
> Feb 25, 2020 10:42:39 PM
> uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/document.rb parse
> WARNUNG:
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc: line
> 22: id assigned to block already in use: ANNUAL_REVENUE
> id assigned to block already in use: ANNUAL_REVENUE ::
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc ::
> /Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include//Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc:22
> (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/document.rb:parse)
> {code}
> I guess it is because ANNUAL_REVENUE is used in both acc-glossary.adoc and
> hr-glossary.adoc.
> Can you please check? Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11394) Convert getSubContentWithPermCheck service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma reassigned OFBIZ-11394: Assignee: Priya Sharma (was: Devanshu Vyas) > Convert getSubContentWithPermCheck service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11394 > URL: https://issues.apache.org/jira/browse/OFBIZ-11394 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > > Convert getSubContentWithPermCheck service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10883) Picklist is in Input status even after order is completed
[ https://issues.apache.org/jira/browse/OFBIZ-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045557#comment-17045557 ] ASF subversion and git services commented on OFBIZ-10883: - Commit 545be005768ba98606517b52329fd605606a7a3f in ofbiz-framework's branch refs/heads/release17.12 from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=545be00 ] Fixed: Picklist is in Input status even after order is completed. (OFBIZ-10883) Thanks Rashi Dhagat for reporting, Shikha Jaiswal for the patch and Pawan Verma for review. > Picklist is in Input status even after order is completed > - > > Key: OFBIZ-10883 > URL: https://issues.apache.org/jira/browse/OFBIZ-10883 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10883-new.patch, OFBIZ-10883.patch, > OrderStatus.jpg, PicklistStatus.jpg > > > Steps to regenerate: > 1. Open https://demo-stable.ofbiz.apache.org/ordermgr/control/main > 2. Create order > 3. Open > https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse > 4. Create Picking > 5. Click on Packing under the facility > 6. Enter order id and click on pack order > 7. Enter package detail and complete packaging > 8. Open > https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse > Actual: Picklist is in the input status > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10883) Picklist is in Input status even after order is completed
[ https://issues.apache.org/jira/browse/OFBIZ-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-10883. - Fix Version/s: 17.12.02 18.12.01 Resolution: Fixed Thanks Rashi Dhagat for reporting, Shikha Jaiswal for the patch and Pawan Verma for review. > Picklist is in Input status even after order is completed > - > > Key: OFBIZ-10883 > URL: https://issues.apache.org/jira/browse/OFBIZ-10883 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Suraj Khurana >Priority: Major > Fix For: 18.12.01, 17.12.02 > > Attachments: OFBIZ-10883-new.patch, OFBIZ-10883.patch, > OrderStatus.jpg, PicklistStatus.jpg > > > Steps to regenerate: > 1. Open https://demo-stable.ofbiz.apache.org/ordermgr/control/main > 2. Create order > 3. Open > https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse > 4. Create Picking > 5. Click on Packing under the facility > 6. Enter order id and click on pack order > 7. Enter package detail and complete packaging > 8. Open > https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse > Actual: Picklist is in the input status > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10883) Picklist is in Input status even after order is completed
[ https://issues.apache.org/jira/browse/OFBIZ-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1704#comment-1704 ] ASF subversion and git services commented on OFBIZ-10883: - Commit 9b3968ef11e55ee552199a4491dab8d08b25e674 in ofbiz-framework's branch refs/heads/release18.12 from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9b3968e ] Fixed: Picklist is in Input status even after order is completed. (OFBIZ-10883) Thanks Rashi Dhagat for reporting, Shikha Jaiswal for the patch and Pawan Verma for review. > Picklist is in Input status even after order is completed > - > > Key: OFBIZ-10883 > URL: https://issues.apache.org/jira/browse/OFBIZ-10883 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10883-new.patch, OFBIZ-10883.patch, > OrderStatus.jpg, PicklistStatus.jpg > > > Steps to regenerate: > 1. Open https://demo-stable.ofbiz.apache.org/ordermgr/control/main > 2. Create order > 3. Open > https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse > 4. Create Picking > 5. Click on Packing under the facility > 6. Enter order id and click on pack order > 7. Enter package detail and complete packaging > 8. Open > https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse > Actual: Picklist is in the input status > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10883) Picklist is in Input status even after order is completed
[ https://issues.apache.org/jira/browse/OFBIZ-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045553#comment-17045553 ] ASF subversion and git services commented on OFBIZ-10883: - Commit d98d9ccbfa3ff9007c1d828a7a585961afeea254 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d98d9cc ] Fixed: Picklist is in Input status even after order is completed. (OFBIZ-10883) Thanks Rashi Dhagat for reporting, Shikha Jaiswal for the patch and Pawan Verma for review. > Picklist is in Input status even after order is completed > - > > Key: OFBIZ-10883 > URL: https://issues.apache.org/jira/browse/OFBIZ-10883 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Rashi Dhagat >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10883-new.patch, OFBIZ-10883.patch, > OrderStatus.jpg, PicklistStatus.jpg > > > Steps to regenerate: > 1. Open https://demo-stable.ofbiz.apache.org/ordermgr/control/main > 2. Create order > 3. Open > https://demo-stable.ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse > 4. Create Picking > 5. Click on Packing under the facility > 6. Enter order id and click on pack order > 7. Enter package detail and complete packaging > 8. Open > https://demo-trunk.ofbiz.apache.org/facility/control/PicklistManage?facilityId=WebStoreWarehouse > Actual: Picklist is in the input status > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11422) Convert PartyServices.xml mini-lang to groovy
Sebastian Berg created OFBIZ-11422: -- Summary: Convert PartyServices.xml mini-lang to groovy Key: OFBIZ-11422 URL: https://issues.apache.org/jira/browse/OFBIZ-11422 Project: OFBiz Issue Type: Sub-task Components: party Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045547#comment-17045547 ] Sebastian Berg commented on OFBIZ-11030: I have reuploaded the patch, it should work now. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11030: --- Attachment: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11419) hr-glossary.adoc: line 22: id assigned to block already in use: ANNUAL_REVENUE
[
https://issues.apache.org/jira/browse/OFBIZ-11419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045535#comment-17045535
]
Olivier Heintz commented on OFBIZ-11419:
Thank [~mbrohl] to point to this error
I have remove the duplicate one in HR, the patch is generated with git
format-patch
[^0001-fixed-remove-ANNUAL_REVENUE-from-hr-glossary-it-s-al.patch]
^so you can apply it with^
{code:java}
git am 0001-fixed-remove-ANNUAL_REVENUE-from-hr-glossary-it-s-al.patch{code}
> hr-glossary.adoc: line 22: id assigned to block already in use: ANNUAL_REVENUE
> --
>
> Key: OFBIZ-11419
> URL: https://issues.apache.org/jira/browse/OFBIZ-11419
> Project: OFBiz
> Issue Type: Bug
> Components: humanres
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Olivier Heintz
>Priority: Minor
> Labels: documentation
> Attachments:
> 0001-fixed-remove-ANNUAL_REVENUE-from-hr-glossary-it-s-al.patch
>
>
> Hi [~holivier] ,
> after merging all documentation into trunk and fixing a bug, the following
> warnings occur:
> {code:java}
> > Task :generateOfbizDocumentation
> Feb 25, 2020 10:42:35 PM
> uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb next_section
> WARNUNG:
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc: line
> 22: id assigned to block already in use: ANNUAL_REVENUE
> id assigned to block already in use: ANNUAL_REVENUE ::
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc ::
> /Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include//Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc:22
>
> (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:next_section)
> Feb 25, 2020 10:42:39 PM
> uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/document.rb parse
> WARNUNG:
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc: line
> 22: id assigned to block already in use: ANNUAL_REVENUE
> id assigned to block already in use: ANNUAL_REVENUE ::
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc ::
> /Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include//Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc:22
> (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/document.rb:parse)
> {code}
> I guess it is because ANNUAL_REVENUE is used in both acc-glossary.adoc and
> hr-glossary.adoc.
> Can you please check? Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11419) hr-glossary.adoc: line 22: id assigned to block already in use: ANNUAL_REVENUE
[
https://issues.apache.org/jira/browse/OFBIZ-11419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045535#comment-17045535
]
Olivier Heintz edited comment on OFBIZ-11419 at 2/26/20 1:31 PM:
-
Thank [~mbrohl] to point to this error
I have checked and then, removed the duplicate one in HR, the patch is
generated with git format-patch
[^0001-fixed-remove-ANNUAL_REVENUE-from-hr-glossary-it-s-al.patch]
^so you can apply it with^
{code:java}
git am 0001-fixed-remove-ANNUAL_REVENUE-from-hr-glossary-it-s-al.patch{code}
was (Author: holivier):
Thank [~mbrohl] to point to this error
I have remove the duplicate one in HR, the patch is generated with git
format-patch
[^0001-fixed-remove-ANNUAL_REVENUE-from-hr-glossary-it-s-al.patch]
^so you can apply it with^
{code:java}
git am 0001-fixed-remove-ANNUAL_REVENUE-from-hr-glossary-it-s-al.patch{code}
> hr-glossary.adoc: line 22: id assigned to block already in use: ANNUAL_REVENUE
> --
>
> Key: OFBIZ-11419
> URL: https://issues.apache.org/jira/browse/OFBIZ-11419
> Project: OFBiz
> Issue Type: Bug
> Components: humanres
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Olivier Heintz
>Priority: Minor
> Labels: documentation
> Attachments:
> 0001-fixed-remove-ANNUAL_REVENUE-from-hr-glossary-it-s-al.patch
>
>
> Hi [~holivier] ,
> after merging all documentation into trunk and fixing a bug, the following
> warnings occur:
> {code:java}
> > Task :generateOfbizDocumentation
> Feb 25, 2020 10:42:35 PM
> uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb next_section
> WARNUNG:
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc: line
> 22: id assigned to block already in use: ANNUAL_REVENUE
> id assigned to block already in use: ANNUAL_REVENUE ::
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc ::
> /Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include//Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc:22
>
> (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:next_section)
> Feb 25, 2020 10:42:39 PM
> uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/document.rb parse
> WARNUNG:
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc: line
> 22: id assigned to block already in use: ANNUAL_REVENUE
> id assigned to block already in use: ANNUAL_REVENUE ::
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc ::
> /Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include//Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc:22
> (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/document.rb:parse)
> {code}
> I guess it is because ANNUAL_REVENUE is used in both acc-glossary.adoc and
> hr-glossary.adoc.
> Can you please check? Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11419) hr-glossary.adoc: line 22: id assigned to block already in use: ANNUAL_REVENUE
[
https://issues.apache.org/jira/browse/OFBIZ-11419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Heintz updated OFBIZ-11419:
---
Attachment: 0001-fixed-remove-ANNUAL_REVENUE-from-hr-glossary-it-s-al.patch
> hr-glossary.adoc: line 22: id assigned to block already in use: ANNUAL_REVENUE
> --
>
> Key: OFBIZ-11419
> URL: https://issues.apache.org/jira/browse/OFBIZ-11419
> Project: OFBiz
> Issue Type: Bug
> Components: humanres
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Olivier Heintz
>Priority: Minor
> Labels: documentation
> Attachments:
> 0001-fixed-remove-ANNUAL_REVENUE-from-hr-glossary-it-s-al.patch
>
>
> Hi [~holivier] ,
> after merging all documentation into trunk and fixing a bug, the following
> warnings occur:
> {code:java}
> > Task :generateOfbizDocumentation
> Feb 25, 2020 10:42:35 PM
> uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb next_section
> WARNUNG:
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc: line
> 22: id assigned to block already in use: ANNUAL_REVENUE
> id assigned to block already in use: ANNUAL_REVENUE ::
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc ::
> /Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include//Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc:22
>
> (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:next_section)
> Feb 25, 2020 10:42:39 PM
> uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/document.rb parse
> WARNUNG:
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc: line
> 22: id assigned to block already in use: ANNUAL_REVENUE
> id assigned to block already in use: ANNUAL_REVENUE ::
> ../../applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc ::
> /Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include//Users/mbrohl/Projects/apache-ofbiz/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/hr-glossary.adoc:22
> (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/document.rb:parse)
> {code}
> I guess it is because ANNUAL_REVENUE is used in both acc-glossary.adoc and
> hr-glossary.adoc.
> Can you please check? Thanks!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11046) add a HR Data model chapter
[ https://issues.apache.org/jira/browse/OFBIZ-11046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045520#comment-17045520 ] Olivier Heintz commented on OFBIZ-11046: these patch are not related to overall automatic migration form docbook to asciidoc, it's enhancement on documentation I will create a dedicated PR in future > add a HR Data model chapter > --- > > Key: OFBIZ-11046 > URL: https://issues.apache.org/jira/browse/OFBIZ-11046 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: humanres > Fix For: Trunk > > Attachments: EmplPosition.png, EmplPositionDetail.png, > Employment.png, EmploymentApp.png, OFBIZ_11046_humanres.adoc.patch, > PartyHumanRes.png, PerfReview.png, ability.png, hr-data-model.adoc > > > Add some UML diagram about main HR entities. > Each diagram contain not all associated entities but only one important to > have a first understanding about the main entity of the diagram. > In the doc, each diagram is associated with some link to others diagram to > easily naviguate. > This chapter could be included in hr-documentation just before hr-glossary -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11039) add a chapter "About this documentation"
[ https://issues.apache.org/jira/browse/OFBIZ-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045519#comment-17045519 ] Olivier Heintz commented on OFBIZ-11039: these patch are not related to overall automatic migration form docbook to asciidoc, it's enhancement on documentation I will create a dedicated PR in future > add a chapter "About this documentation" > > > Key: OFBIZ-11039 > URL: https://issues.apache.org/jira/browse/OFBIZ-11039 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Fix For: Trunk > > Attachments: Employee_Main_Screen.png, > HR-Employee_Submenu_Rainbow_Stone.png, HR-Employee_Submenu_Tomahawk.png, > HR_Application_Submenu_Rainbow_Stone.png, > HR_Application_Submenu_Tomahawk.png, hr-about-doc.adoc > > > This chapter present the main OFBiz GUI rules with some screenshot and link > between tutorial and video of "Scenario GUI Test" > Currently it's in HR, but when other application will be done it can be > generalize and go to User Manual introduction. > The file hr-about-doc.adoc associated with this task is included via a > include:: line in the humanres.adoc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-6638) TrialBalance PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-6638: -- Assignee: Jacques Le Roux (was: Rohit Koushal) > TrialBalance PDF export fails > - > > Key: OFBIZ-6638 > URL: https://issues.apache.org/jira/browse/OFBIZ-6638 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png > > > # Get to > http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company > #pick a "Custom Time Period Id" (default works also) > #Submit > Then the CSV export works but not the PDF, this in trunk demo. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11027) HR Doc, Associated a scenario UI test for each process
[ https://issues.apache.org/jira/browse/OFBIZ-11027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045480#comment-17045480 ] Olivier Heintz commented on OFBIZ-11027: these patch are not related to overall automatic migration form docbook to asciidoc, it's enhancement on documentation I will create a dedicated PR in future > HR Doc, Associated a scenario UI test for each process > -- > > Key: OFBIZ-11027 > URL: https://issues.apache.org/jira/browse/OFBIZ-11027 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: Documentation, humanres, tutorial > Attachments: OFBIZ-11027_hr-intro.adoc.patch, > hr-tuto-define-company-organization.adoc, hr-tuto-employment-and-salary.adoc > > > I propose that in HR documentation, each process is described via a scenario > explained like a tutorial. > To realize the tutorial, and to have more quality, I propose to create a UI > Test for each process. > In these tests, some user messages are added and a video recording is in > place when it run, so result is usable as a tutorial > With this method to create tutorial we are sure it are up to date and it > works ! > Currently a tutorial / test exist for process "Organization, Job Position and > Definition" and it run ona daily base on Apache OFBiz trunk demo. > A second one exist for process "Employee Salary and Benefits Administration" > but for runing some modification /enhancement are needed, so currenlty it not > run on Apache OFBiz trunk demo. > Result video are readeable > https://video.ploud.fr/video-channels/ofbizextra_tutorial/videos > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11026) HR Doc drive by process
[ https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045474#comment-17045474 ] Olivier Heintz commented on OFBIZ-11026: Currently I'm working on global migration from docbook to asciidoc and so I don't want mixed "automatic migration" and enhancement. I will re-start to ask for a review for this task when overall migration will be finished. > HR Doc drive by process > --- > > Key: OFBIZ-11026 > URL: https://issues.apache.org/jira/browse/OFBIZ-11026 > Project: OFBiz > Issue Type: Sub-task > Components: humanres >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Michael Brohl >Priority: Major > Labels: Documentation, humanres > Attachments: OFBIZ-11026_hr-intro.adoc.patch, > OFBIZ-11026_humanres.adoc.patch, > OFBIZ-11026_humanres.adoc_with_hr-about-doc.patch > > > Currently HR doc main chapters are on core HR object, I propose to group them > in a chapter and having a chapter by process in the same level bot group in > the HR Process. > Each process is described via a scenario explained like a tutorial, and each > time a core object is used, a link is done to its chapter. > To help review : doc with these modifications are available at > [https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources] > and Apache OFBiz standard (without modifications) is available too at > https://ofbizadoc.ofbizextra.org/html5/user-manual-std.html#_human_resources > current HR TOC > -- > 3.2. Human Resources > 3.2.1. About Human Resources > 3.2.2. Human Resources Processes > 3.2.3. Employee Positions > 3.2.4. Employees > 3.2.5. Employments > 3.2.6. Performance Review > 3.2.7. Qualifications > 3.2.8. Recruitment > 3.2.9. Skills > 3.2.10. Resumes > 3.2.11. Training > 3.2.12. Leave > 3.2.13. Security > 3.2.14. Global HR Settings > 3.2.15. Glossary > Proposed HR TOC > > 4. Human Resources > 4.1. About this documentation > 4.2. About Human Resources > 4.3. HR Processes > 4.3.1. Organization, Job Position and Definition > 4.3.2. Recruitment, Candidate Selection and Hiring > 4.3.3. Employee Training and Development > 4.3.4. Performance Management and Employee Evaluation > 4.3.5. Employee Salary and Benefits Administration > 4.4. HR core object > 4.4.1. Employee Positions > 4.4.2. Employees > 4.4.3. Employments > 4.4.4. Performance Review > 4.4.5. Qualifications > 4.4.6. Recruitment > 4.4.7. Skills > 4.4.8. Resumes > 4.4.9. Training > 4.4.10. Leave > 4.4.11. Security > 4.5. Global HR Settings > 4.5.1. Skills Types > 4.6. HR Data model > 4.6.1. Employee Position > 4.6.2. Employment > 4.6.3. Qualification, Skill, Review > 4.6.4. HR App intra-application integration > 4.7. Glossary -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10255) Add Document Content: humanres.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045468#comment-17045468 ] Olivier Heintz commented on OFBIZ-10255: I have worked on humanres documentation to add some HR process example. Currently these documentations are not yet included. I propose to not close this task until these documentations are review and included (or rejected) > Add Document Content: humanres.adoc > --- > > Key: OFBIZ-10255 > URL: https://issues.apache.org/jira/browse/OFBIZ-10255 > Project: OFBiz > Issue Type: Sub-task >Reporter: Sharan Foga >Assignee: Sharan Foga >Priority: Minor > Attachments: OFBIZ-10255.patch, humanres.adoc, humanres.adoc.patch > > > Using details from the OFBiz wiki workspaces and the Human Resources Guide > and other human resources asciidoc file, write or organise the content for > the humanres.adoc file. > An copy of the existing file will be attached. > Please update the template and re-attach it. > NOTE: This document might not be able to be completed until other sections > for Human Resources are done. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045450#comment-17045450 ] Pierre Smits commented on OFBIZ-11030: -- When trying to apply the patch I get an error as shown in uploaded image. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11030: - Attachment: OFBIZ-11030-applyPatch-error.png > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045403#comment-17045403 ] Pierre Smits commented on OFBIZ-11030: -- HI [~sberg], A cursory review looks good. I will test later today. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11030: --- Attachment: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10571) [FB] Package org.apache.ofbiz.minilang
[ https://issues.apache.org/jira/browse/OFBIZ-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-10571. - Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Girish Vasmatkar for reporting the issue and providing the patch. > [FB] Package org.apache.ofbiz.minilang > -- > > Key: OFBIZ-10571 > URL: https://issues.apache.org/jira/browse/OFBIZ-10571 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Girish Vasmatkar >Assignee: Suraj Khurana >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10571.patch > > > * [Should be a static inner > class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC] > This class is an inner class, but does not use its embedded reference to the > object which created it. This reference makes the instances of the class > larger, and may keep the reference to the creator object alive longer than > necessary. If possible, the class should be made static. > *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC* > *org.apache.ofbiz.minilang.method.callops.CallService*** > > * [Could be refactored into a named static inner > class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_ANON] > This class is an inner class, but does not use its embedded reference to the > object which created it. This reference makes the instances of the class > larger, and may keep the reference to the creator object alive longer than > necessary. If possible, the class should be made into a _static_ inner > class. Since anonymous inner classes cannot be marked as static, doing this > will require refactoring the inner class so that it is a named inner class. > *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC_ANON* > *org.apache.ofbiz.minilang.method.conditional.CombinedConditional* > > * [Boxing/unboxing to parse a > primitive|http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING] > A boxed primitive is created from a String, just to extract the unboxed > primitive value. It is more efficient to just call the static parseXXX method. > ** > *Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING* > *org.apache.ofbiz.minilang.method.otherops.Calculate* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10571) [FB] Package org.apache.ofbiz.minilang
[ https://issues.apache.org/jira/browse/OFBIZ-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045371#comment-17045371 ] ASF subversion and git services commented on OFBIZ-10571: - Commit cc52b981510caeed57ae4cb0d70f13c0017d4445 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=cc52b98 ] Improved: Defects reported by code analysis tool. (OFBIZ-10571) Following refactoring done - -- Refactored code to fall in line with some java standards. -- Based on FindBugs suggestion, refactored some classes to have static nested classes instead of inner class. Thanks Girish Vasmatkar for reporting the issue and providing the patch. > [FB] Package org.apache.ofbiz.minilang > -- > > Key: OFBIZ-10571 > URL: https://issues.apache.org/jira/browse/OFBIZ-10571 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Girish Vasmatkar >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-10571.patch > > > * [Should be a static inner > class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC] > This class is an inner class, but does not use its embedded reference to the > object which created it. This reference makes the instances of the class > larger, and may keep the reference to the creator object alive longer than > necessary. If possible, the class should be made static. > *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC* > *org.apache.ofbiz.minilang.method.callops.CallService*** > > * [Could be refactored into a named static inner > class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_ANON] > This class is an inner class, but does not use its embedded reference to the > object which created it. This reference makes the instances of the class > larger, and may keep the reference to the creator object alive longer than > necessary. If possible, the class should be made into a _static_ inner > class. Since anonymous inner classes cannot be marked as static, doing this > will require refactoring the inner class so that it is a named inner class. > *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC_ANON* > *org.apache.ofbiz.minilang.method.conditional.CombinedConditional* > > * [Boxing/unboxing to parse a > primitive|http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING] > A boxed primitive is created from a String, just to extract the unboxed > primitive value. It is more efficient to just call the static parseXXX method. > ** > *Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING* > *org.apache.ofbiz.minilang.method.otherops.Calculate* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11420) Migration from docbook to asciidoc breaks current help system
[ https://issues.apache.org/jira/browse/OFBIZ-11420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-11420. - Fix Version/s: Upcoming Branch Resolution: Fixed Thanks Olivier, a quick check in accounting shows the help screens again. > Migration from docbook to asciidoc breaks current help system > - > > Key: OFBIZ-11420 > URL: https://issues.apache.org/jira/browse/OFBIZ-11420 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS, ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Olivier Heintz >Priority: Major > Fix For: Upcoming Branch > > Time Spent: 20m > Remaining Estimate: 0h > > The latest changes to migrate the docbook based help system to asciidoc > breaks the help system, which is not changed accordingly to support asciidoc. > We need to reintroduce the docbook files and stay with them until the help > system is changed to support asciidoc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11420) Migration from docbook to asciidoc breaks current help system
[ https://issues.apache.org/jira/browse/OFBIZ-11420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045364#comment-17045364 ] ASF subversion and git services commented on OFBIZ-11420: - Commit 5c882509321573c75beb95fd102f060a34103d4a in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5c88250 ] Documented: revert remove docbook help files for commonext-SETUP (OFBIZ-11420) Removing Help files in docbook format break the current online help > Migration from docbook to asciidoc breaks current help system > - > > Key: OFBIZ-11420 > URL: https://issues.apache.org/jira/browse/OFBIZ-11420 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS, ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Olivier Heintz >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The latest changes to migrate the docbook based help system to asciidoc > breaks the help system, which is not changed accordingly to support asciidoc. > We need to reintroduce the docbook files and stay with them until the help > system is changed to support asciidoc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11420) Migration from docbook to asciidoc breaks current help system
[ https://issues.apache.org/jira/browse/OFBIZ-11420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045366#comment-17045366 ] ASF subversion and git services commented on OFBIZ-11420: - Commit 820f67a6355bb22beb9a2dff5e20654e8121020a in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=820f67a ] Documented: revert remove docbook help files for humanres (OFBIZ-11420) Removing Help files in docbook format break the current online help > Migration from docbook to asciidoc breaks current help system > - > > Key: OFBIZ-11420 > URL: https://issues.apache.org/jira/browse/OFBIZ-11420 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS, ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Olivier Heintz >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The latest changes to migrate the docbook based help system to asciidoc > breaks the help system, which is not changed accordingly to support asciidoc. > We need to reintroduce the docbook files and stay with them until the help > system is changed to support asciidoc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11420) Migration from docbook to asciidoc breaks current help system
[ https://issues.apache.org/jira/browse/OFBIZ-11420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045363#comment-17045363 ] ASF subversion and git services commented on OFBIZ-11420: - Commit 2766510aafcd11f24148782817e850a5d50ce1c7 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2766510 ] Documented: revert remove docbook help files for accounting (OFBIZ-11420) Removing Help files in docbook format break the current online help > Migration from docbook to asciidoc breaks current help system > - > > Key: OFBIZ-11420 > URL: https://issues.apache.org/jira/browse/OFBIZ-11420 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS, ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Olivier Heintz >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The latest changes to migrate the docbook based help system to asciidoc > breaks the help system, which is not changed accordingly to support asciidoc. > We need to reintroduce the docbook files and stay with them until the help > system is changed to support asciidoc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11420) Migration from docbook to asciidoc breaks current help system
[ https://issues.apache.org/jira/browse/OFBIZ-11420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045365#comment-17045365 ] ASF subversion and git services commented on OFBIZ-11420: - Commit c34919683bee28c8fca74d0b65477fcc19121561 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c349196 ] Documented: revert remove docbook help files for content (OFBIZ-11420) Removing Help files in docbook format break the current online help > Migration from docbook to asciidoc breaks current help system > - > > Key: OFBIZ-11420 > URL: https://issues.apache.org/jira/browse/OFBIZ-11420 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS, ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Olivier Heintz >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The latest changes to migrate the docbook based help system to asciidoc > breaks the help system, which is not changed accordingly to support asciidoc. > We need to reintroduce the docbook files and stay with them until the help > system is changed to support asciidoc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11420) Migration from docbook to asciidoc breaks current help system
[ https://issues.apache.org/jira/browse/OFBIZ-11420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045354#comment-17045354 ] Olivier Heintz commented on OFBIZ-11420: this PR #33 contain revert for * accounting * commonext-SETUP * content * humanres > Migration from docbook to asciidoc breaks current help system > - > > Key: OFBIZ-11420 > URL: https://issues.apache.org/jira/browse/OFBIZ-11420 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS, ALL COMPONENTS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Olivier Heintz >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The latest changes to migrate the docbook based help system to asciidoc > breaks the help system, which is not changed accordingly to support asciidoc. > We need to reintroduce the docbook files and stay with them until the help > system is changed to support asciidoc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11376) Remove createTopic service (unused)
[ https://issues.apache.org/jira/browse/OFBIZ-11376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045328#comment-17045328 ] Jacques Le Roux commented on OFBIZ-11376: - Ah forgot, I also removed the related, commented out, fields in CMSForms.xml > Remove createTopic service (unused) > --- > > Key: OFBIZ-11376 > URL: https://issues.apache.org/jira/browse/OFBIZ-11376 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Image 005.png, OFBIZ-11376-updated.patch, > OFBIZ-11376.patch > > > Convert createTopic service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11306) POC for CSRF Token
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11306: Attachment: OFBIZ-11306-alternative merged with James's.patch > POC for CSRF Token > -- > > Key: OFBIZ-11306 > URL: https://issues.apache.org/jira/browse/OFBIZ-11306 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Labels: CSRF > Fix For: Upcoming Branch > > Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, > CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative merged with James's.patch, OFBIZ-11306-alternative > merged with James's.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-v2.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > partyTokenMap.webtools.txt > > > CRSF tokens are generated using SecureRandom class (maybe later a JWT with a > "time out"). > They are stored in the user sessions (for AJAX calls and unauthenticated HTTP > calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during > POST request. > # In *controllers* a new csrf-token attribute is added to the security tag to > exempt or force CSRF token check. > # In *Widget Forms* a hidden token field is auto-generated. > # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the > change. Using <@ofbizUrl> macro to generate the CSRF token means there is no > need to manually add the CSRF token field to each form in the ftl files. It > will save time for users doing custom implementation and maintenance. While > there is CSRF token in the form URL, the token is invalidated during form > submission. So it's uniqueand harmless even though the CSRF token of the form > submission is shown in the browser address bar. > # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added > through OfbizUtil.js (itself called at start in decorators and such) > # The html metadata is storing the csrf token used by JQuery AJAX. This token > will not change to another value after it is consumed > # Csrf tokens for the user are removed from the UtilCache when the user logs > out or session invalidated. > The general rule are as follows: > * RequestMap configured with 'get' method will be exempted from CSRF token > check. > * RequestMap configured with 'post' or 'all' method will be subjected to CSRF > token check. (Note there are discussions that RequestMap with ‘all’ method > should also not be subjected to CSRF token check. This will be done after > ensuring a separate uri is used when posting changes.) > * "main" request URIs are exempted from CSRF token check. > * Setting csrf-token to false or true on the Request Map will override the > general rules above. > To Discuss: > * Invalidate authenticated user session when CSRF token check fails. > * Configure the general rules in a Service method (which will be run inside > the constructor of RequestMap class) when determining the final > securityCsrfToken value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11306) POC for CSRF Token
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045319#comment-17045319 ] Jacques Le Roux commented on OFBIZ-11306: - Here is the last patch before forking: [^OFBIZ-11306-alternative merged with James's.patch] > POC for CSRF Token > -- > > Key: OFBIZ-11306 > URL: https://issues.apache.org/jira/browse/OFBIZ-11306 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Labels: CSRF > Fix For: Upcoming Branch > > Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, > CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative merged with James's.patch, OFBIZ-11306-alternative > merged with James's.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-v2.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > partyTokenMap.webtools.txt > > > CRSF tokens are generated using SecureRandom class (maybe later a JWT with a > "time out"). > They are stored in the user sessions (for AJAX calls and unauthenticated HTTP > calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during > POST request. > # In *controllers* a new csrf-token attribute is added to the security tag to > exempt or force CSRF token check. > # In *Widget Forms* a hidden token field is auto-generated. > # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the > change. Using <@ofbizUrl> macro to generate the CSRF token means there is no > need to manually add the CSRF token field to each form in the ftl files. It > will save time for users doing custom implementation and maintenance. While > there is CSRF token in the form URL, the token is invalidated during form > submission. So it's uniqueand harmless even though the CSRF token of the form > submission is shown in the browser address bar. > # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added > through OfbizUtil.js (itself called at start in decorators and such) > # The html metadata is storing the csrf token used by JQuery AJAX. This token > will not change to another value after it is consumed > # Csrf tokens for the user are removed from the UtilCache when the user logs > out or session invalidated. > The general rule are as follows: > * RequestMap configured with 'get' method will be exempted from CSRF token > check. > * RequestMap configured with 'post' or 'all' method will be subjected to CSRF > token check. (Note there are discussions that RequestMap with ‘all’ method > should also not be subjected to CSRF token check. This will be done after > ensuring a separate uri is used when posting changes.) > * "main" request URIs are exempted from CSRF token check. > * Setting csrf-token to false or true on the Request Map will override the > general rules above. > To Discuss: > * Invalidate authenticated user session when CSRF token check fails. > * Configure the general rules in a Service method (which will be run inside > the constructor of RequestMap class) when determining the final > securityCsrfToken value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11082) Improve the SalesInvoiceItemFact regarding dimensions
[ https://issues.apache.org/jira/browse/OFBIZ-11082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11082: - Description: Improve the SIIF to include various dimensions, e.g. * OrganisationDimension * CustomerDimension * sales channel * etc was: Improve the SIIF to include various dimensions, e.g. * store * sales channel * etc > Improve the SalesInvoiceItemFact regarding dimensions > - > > Key: OFBIZ-11082 > URL: https://issues.apache.org/jira/browse/OFBIZ-11082 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: Fact, SalesInvoiceItemFact, birt, dwh > > Improve the SIIF to include various dimensions, e.g. > * OrganisationDimension > * CustomerDimension > * sales channel > * etc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044415#comment-17044415 ] Priya Sharma edited comment on OFBIZ-11383 at 2/26/20 9:40 AM: --- Hello All, I have added the patch with the following changes: * Updated the service definition * Added a new service for the groovy version of it * Removed the mini-lang version of the service Since the service handles many cases, I would request someone to please verify the patch thoroughly, as I could not verify all the test cases, the eCommerce UI does not support adding images or files, only text data can be added. Please verify and let me know if I missed something. Thanks! was (Author: priya.sharma.9362): Hello All, I have added the patch with the following changes: * Updated the service definition * Added a new service for the groovy version of it * Removed the minilang version of the service Since the service handles many cases, I would request someone to please verify the patch thoroughly, as I could not verify all the test cases, the ecommerce UI doesnot support adding images or files, only text data can be added. Please verify and let me know if I missed something. Thanks! > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11421) Correcting Typos in web-theme.xsd
[ https://issues.apache.org/jira/browse/OFBIZ-11421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-11421: Assignee: (was: Pierre Smits) > Correcting Typos in web-theme.xsd > - > > Key: OFBIZ-11421 > URL: https://issues.apache.org/jira/browse/OFBIZ-11421 > Project: OFBiz > Issue Type: Improvement > Components: site >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11421) Correcting Typos in web-theme.xsd
[ https://issues.apache.org/jira/browse/OFBIZ-11421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045302#comment-17045302 ] Pierre Smits commented on OFBIZ-11421: -- Patch available via PR#1 > Correcting Typos in web-theme.xsd > - > > Key: OFBIZ-11421 > URL: https://issues.apache.org/jira/browse/OFBIZ-11421 > Project: OFBiz > Issue Type: Improvement > Components: site >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11421) Correcting Typos in web-theme.xsd
[ https://issues.apache.org/jira/browse/OFBIZ-11421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11421: - Priority: Minor (was: Major) > Correcting Typos in web-theme.xsd > - > > Key: OFBIZ-11421 > URL: https://issues.apache.org/jira/browse/OFBIZ-11421 > Project: OFBiz > Issue Type: Improvement > Components: site >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11421) Correcting Typos in web-theme.xsd
Pierre Smits created OFBIZ-11421: Summary: Correcting Typos in web-theme.xsd Key: OFBIZ-11421 URL: https://issues.apache.org/jira/browse/OFBIZ-11421 Project: OFBiz Issue Type: Improvement Components: site Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-9761: - Fix Version/s: (was: Release Branch 16.11) > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Suraj Khurana >Priority: Major > Labels: backport-needed > Fix For: 17.12.01 > > Attachments: OFBIZ-9761-16.11.patch, OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11308) German translation typo in PartyUiLabels
[ https://issues.apache.org/jira/browse/OFBIZ-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-11308: -- Fix Version/s: (was: Release Branch 18.12) (was: Upcoming Branch) 18.12.01 > German translation typo in PartyUiLabels > > > Key: OFBIZ-11308 > URL: https://issues.apache.org/jira/browse/OFBIZ-11308 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Ingo Könemann >Assignee: Michael Brohl >Priority: Trivial > Fix For: 18.12.01, 17.12.01 > > Attachments: OFBIZ-11308_GermanTranslation.patch > > > There is a typo in the german PartyUiLabels for > "PartyPostalAddressSuccessfullyUpdated". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-10607: -- Fix Version/s: (was: Release Branch 18.12) (was: Upcoming Branch) 18.12.01 > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Michael Brohl >Priority: Minor > Labels: backport-needed > Fix For: 18.12.01, 17.12.01 > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11160) Add button for 'Gift Message is shown on completed order
[ https://issues.apache.org/jira/browse/OFBIZ-11160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11160: Fix Version/s: (was: Release Branch 18.12) (was: Upcoming Branch) 18.12.01 > Add button for 'Gift Message is shown on completed order > > > Key: OFBIZ-11160 > URL: https://issues.apache.org/jira/browse/OFBIZ-11160 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 13.07, Release Branch 14.12, Release > Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch > 17.12, Trunk >Reporter: Pierre Smits >Assignee: Pawan Verma >Priority: Major > Fix For: 18.12.01, 17.12.01 > > Attachments: OFBIZ-11160.patch > > > On an completed order the 'Add' button for a gift message should not be > shown, as the order has been completed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11319) processorder is submitted as GET instead of POST
[ https://issues.apache.org/jira/browse/OFBIZ-11319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11319: - Fix Version/s: (was: Release Branch 17.12) 17.12.01 > processorder is submitted as GET instead of POST > > > Key: OFBIZ-11319 > URL: https://issues.apache.org/jira/browse/OFBIZ-11319 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Release Branch 18.12, 17.12.01 > > Attachments: OFBIZ-11319_Plugins.patch, OFBIZ-11319_Plugins.patch > > > During checkout of shopping cart, it is observed that the processorder of the > form action is submitted as GET which is incorrect. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11308) German translation typo in PartyUiLabels
[ https://issues.apache.org/jira/browse/OFBIZ-11308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11308: - Fix Version/s: (was: Release Branch 17.12) 17.12.01 > German translation typo in PartyUiLabels > > > Key: OFBIZ-11308 > URL: https://issues.apache.org/jira/browse/OFBIZ-11308 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Ingo Könemann >Assignee: Michael Brohl >Priority: Trivial > Fix For: Release Branch 18.12, 17.12.01, Upcoming Branch > > Attachments: OFBIZ-11308_GermanTranslation.patch > > > There is a typo in the german PartyUiLabels for > "PartyPostalAddressSuccessfullyUpdated". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11160) Add button for 'Gift Message is shown on completed order
[ https://issues.apache.org/jira/browse/OFBIZ-11160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11160: - Fix Version/s: (was: Release Branch 17.12) 17.12.01 > Add button for 'Gift Message is shown on completed order > > > Key: OFBIZ-11160 > URL: https://issues.apache.org/jira/browse/OFBIZ-11160 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 13.07, Release Branch 14.12, Release > Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch > 17.12, Trunk >Reporter: Pierre Smits >Assignee: Pawan Verma >Priority: Major > Fix For: Release Branch 18.12, 17.12.01, Upcoming Branch > > Attachments: OFBIZ-11160.patch > > > On an completed order the 'Add' button for a gift message should not be > shown, as the order has been completed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10859) Incorrect decorator being used over view all promotions and view promotion details screen causing back navigation
[ https://issues.apache.org/jira/browse/OFBIZ-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10859: - Fix Version/s: (was: Release Branch 17.12) (was: Upcoming Branch) 17.12.01 > Incorrect decorator being used over view all promotions and view promotion > details screen causing back navigation > - > > Key: OFBIZ-10859 > URL: https://issues.apache.org/jira/browse/OFBIZ-10859 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Ratnesh Upadhyay >Assignee: Rishi Solanki >Priority: Major > Fix For: Release Branch 18.12, 17.12.01 > > Attachments: OFBIZ-10859.patch > > > There is no back navigation available from view all promotions and show > promotion details screens instead it's showing cart and checkout options. > Steps to replicate the issue: > * Go to Order Manager > Order Entry > * Provide ordering details > * On create sales order screen, click upon 'View All Promotions' button > displayed under Special Offers button. > The same issue persist with _Adjustment_ - Promotion details button appeared > in order items section after adding GZ-2644 item to cart. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10607) ‘EntityOperator#getId()’ is not used in the framework
[ https://issues.apache.org/jira/browse/OFBIZ-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10607: - Fix Version/s: (was: Release Branch 17.12) 17.12.01 > ‘EntityOperator#getId()’ is not used in the framework > - > > Key: OFBIZ-10607 > URL: https://issues.apache.org/jira/browse/OFBIZ-10607 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Mathieu Lirzin >Assignee: Michael Brohl >Priority: Minor > Labels: backport-needed > Fix For: Release Branch 18.12, 17.12.01, Upcoming Branch > > Attachments: OFBIZ-10607_Remove-EntityOperator-requestId.patch > > > While reading some code with [~gil portenseigne] we found that > ‘EntityOperator#getId()’ is not used anywhere in the framework. it was added > in 2010 by [~doogie] in revision 948448 to “Allow for dynamic registering of > additional operators for extensions.”. > If this code is still useful outside of the framework, OFBiz should provide a > test demonstrated its purpose and describing how to use it. Otherwise we > should simply delete it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-9761) Update regex used for validating credit cards
[ https://issues.apache.org/jira/browse/OFBIZ-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-9761: Fix Version/s: (was: Release Branch 17.12) 17.12.01 > Update regex used for validating credit cards > -- > > Key: OFBIZ-9761 > URL: https://issues.apache.org/jira/browse/OFBIZ-9761 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Amit Gadaley >Assignee: Suraj Khurana >Priority: Major > Labels: backport-needed > Fix For: Release Branch 16.11, 17.12.01 > > Attachments: OFBIZ-9761-16.11.patch, OFBIZ-9761.patch > > > Update regex used for validating credit cards: > MasterCard numbers either start with the numbers 51 through 55 or with the > numbers 2221 through 2720. All have 16 digits. > Discover card numbers begin with 6011 or 65. All have 16 digits. > JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning > with 35 have 16 digits. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.
[
https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-6993:
Fix Version/s: (was: Release Branch 17.12)
17.12.01
> Cannot find the declaration of element 'web-app' in version 3.0 files.
> --
>
> Key: OFBIZ-6993
> URL: https://issues.apache.org/jira/browse/OFBIZ-6993
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
>Affects Versions: Release Branch 15.12, Trunk
>Reporter: Forrest Rae
>Assignee: Mathieu Lirzin
>Priority: Major
> Fix For: Release Branch 18.12, 17.12.01
>
> Attachments:
> 0001-Fixed-when-it-comes-to-web.xml-we-should-rely-solely.patch, web-app.patch
>
>
> Been seeing the error below in the logs. Strangely, I've not been able to
> catch the exception in a debugger, but was able to isolate it to the
> definition of the web-app with version 3.0. The error disapears when you
> change the definition from
> {code:xml}
>
> {code}
> to this:
> {code:xml}
> xmlns="http://java.sun.com/xml/ns/javaee;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd;>
> {code}
> I only tested on 15.12 and Trunk, but it probably affects any release running
> Tomcat 7.0.48 or higher. Here is the error:
> {noformat}
> [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester
> error
> [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot
> find the declaration of element 'web-app'.
> [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24;
> cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
> [java] at
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown
> Source)
> [java] at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown
> Source)
> [java] at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> Source)
> [java] at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> Source)
> [java] at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> Source)
> [java] at
> org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown
> Source)
> [java] at
> org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
> [java] at
> org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
> Source)
> [java] at
> org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
> Source)
> [java] at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
> Source)
> [java] at
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
> Source)
> [java] at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
> Source)
> [java] at org.apache.xerces.parsers.XML11Configuration.parse(Unknown
> Source)
> [java] at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
> [java] at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown
> Source)
> [java] at
> org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
> [java] at
> org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
> [java] at
> org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
> [java] at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
> [java] at
> org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
> [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [java] at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [java] at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [java] at java.lang.reflect.Method.invoke(Method.java:498)
> [java] at
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
> [java] at
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
> [java] at freemarker.core.MethodCall._eval(MethodCall.java:62)
> [java] at freemarker.core.Expression.eval(Expression.java:78)
> [java] at freemarker.core.Assignment.accept(Assignment.java:70)
> [java] at freemarker.core.Environment.visit(Environment.java:312)
> [java] at freemarker.core.MixedContent.accept(MixedContent.java:62)
> [java] at
> freemarker.core.Environment.visitByHiddingParent(Environment.java:333)
> [java] at
>
[jira] [Closed] (OFBIZ-11376) Remove createTopic service (unused)
[ https://issues.apache.org/jira/browse/OFBIZ-11376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11376. --- Fix Version/s: Upcoming Branch Assignee: Priya Sharma (was: Jacques Le Roux) Resolution: Done Thanks Priya! > Remove createTopic service (unused) > --- > > Key: OFBIZ-11376 > URL: https://issues.apache.org/jira/browse/OFBIZ-11376 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Image 005.png, OFBIZ-11376-updated.patch, > OFBIZ-11376.patch > > > Convert createTopic service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11376) Remove createTopic service (unused)
[ https://issues.apache.org/jira/browse/OFBIZ-11376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045270#comment-17045270 ] ASF subversion and git services commented on OFBIZ-11376: - Commit d003807154442d5b40edbec88520a1df05760a91 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d003807 ] Improved: Remove createTopic service (unused) (OFBIZ-11376) I could not find any references for this service in the code base, i.e. this service has not been used anywhere, do we still want to keep it? Thanks: Devanshu Vyas for report, Priya Sharma for the proposition and the fix > Remove createTopic service (unused) > --- > > Key: OFBIZ-11376 > URL: https://issues.apache.org/jira/browse/OFBIZ-11376 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Jacques Le Roux >Priority: Minor > Attachments: Image 005.png, OFBIZ-11376-updated.patch, > OFBIZ-11376.patch > > > Convert createTopic service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11376) Remove createTopic service (unused)
[ https://issues.apache.org/jira/browse/OFBIZ-11376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11376: Summary: Remove createTopic service (unused) (was: Convert createTopic service from mini-lang to groovy DSL) > Remove createTopic service (unused) > --- > > Key: OFBIZ-11376 > URL: https://issues.apache.org/jira/browse/OFBIZ-11376 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Jacques Le Roux >Priority: Minor > Attachments: Image 005.png, OFBIZ-11376-updated.patch, > OFBIZ-11376.patch > > > Convert createTopic service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045266#comment-17045266 ] Michael Brohl commented on OFBIZ-10290: --- We talked through Slack: the latest changes removed the docbook files but the help system is not changed to work with asciidoc. I created OFBIZ-11420 for it. > Add Document Content: acc-agreements.adoc > - > > Key: OFBIZ-10290 > URL: https://issues.apache.org/jira/browse/OFBIZ-10290 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > Attachments: > 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo.patch, > 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo_diff.patch, > image-2020-02-26-09-00-03-460.png, image-2020-02-26-09-00-03-695.png > > > Add content for acc-agreements.doc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11376) Convert createTopic service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11376: --- Assignee: Jacques Le Roux (was: Priya Sharma) > Convert createTopic service from mini-lang to groovy DSL > > > Key: OFBIZ-11376 > URL: https://issues.apache.org/jira/browse/OFBIZ-11376 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Jacques Le Roux >Priority: Minor > Attachments: Image 005.png, OFBIZ-11376-updated.patch, > OFBIZ-11376.patch > > > Convert createTopic service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8297) Convert
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045255#comment-17045255 ] Jacques Le Roux commented on OFBIZ-8297: Good news, thanks for the investigation Pierre. > Convert -- > > Key: OFBIZ-8297 > URL: https://issues.apache.org/jira/browse/OFBIZ-8297 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Labels: configuration > Attachments: OFBIZ-8297-AgreementScreens.xml.patch, > OFBIZ-8297-AgreementScreens.xml.patch > > > * files when it comes to retrieving runtime configuration variables. > While this flawed approach is most prevalent when working with a multi-tenant > setup, where default values of runtime configuration parameters can differ > from tenant to tenant, it is also a wrong approach when using OFBiz in > controlled production setups. > When an adopter is required to change the value of a runtime configuration > parameter, it is required to go into a code upgrade process instead of > changing the value through the admin component (web tools). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11306) POC for CSRF Token
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045251#comment-17045251 ] Jacques Le Roux commented on OFBIZ-11306: - I'll not for the plugins repo because the change is quite simple. I just updated the patch. > POC for CSRF Token > -- > > Key: OFBIZ-11306 > URL: https://issues.apache.org/jira/browse/OFBIZ-11306 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Labels: CSRF > Fix For: Upcoming Branch > > Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, > CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-v2.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > partyTokenMap.webtools.txt > > > CRSF tokens are generated using SecureRandom class (maybe later a JWT with a > "time out"). > They are stored in the user sessions (for AJAX calls and unauthenticated HTTP > calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during > POST request. > # In *controllers* a new csrf-token attribute is added to the security tag to > exempt or force CSRF token check. > # In *Widget Forms* a hidden token field is auto-generated. > # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the > change. Using <@ofbizUrl> macro to generate the CSRF token means there is no > need to manually add the CSRF token field to each form in the ftl files. It > will save time for users doing custom implementation and maintenance. While > there is CSRF token in the form URL, the token is invalidated during form > submission. So it's uniqueand harmless even though the CSRF token of the form > submission is shown in the browser address bar. > # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added > through OfbizUtil.js (itself called at start in decorators and such) > # The html metadata is storing the csrf token used by JQuery AJAX. This token > will not change to another value after it is consumed > # Csrf tokens for the user are removed from the UtilCache when the user logs > out or session invalidated. > The general rule are as follows: > * RequestMap configured with 'get' method will be exempted from CSRF token > check. > * RequestMap configured with 'post' or 'all' method will be subjected to CSRF > token check. (Note there are discussions that RequestMap with ‘all’ method > should also not be subjected to CSRF token check. This will be done after > ensuring a separate uri is used when posting changes.) > * "main" request URIs are exempted from CSRF token check. > * Setting csrf-token to false or true on the Request Map will override the > general rules above. > To Discuss: > * Invalidate authenticated user session when CSRF token check fails. > * Configure the general rules in a Service method (which will be run inside > the constructor of RequestMap class) when determining the final > securityCsrfToken value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11306) POC for CSRF Token
[ https://issues.apache.org/jira/browse/OFBIZ-11306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11306: Attachment: OFBIZ-11306_Plugins.patch > POC for CSRF Token > -- > > Key: OFBIZ-11306 > URL: https://issues.apache.org/jira/browse/OFBIZ-11306 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Labels: CSRF > Fix For: Upcoming Branch > > Attachments: CsrfTokenAjaxTransform.java, CsrfTokenTransform.java, > CsrfUtil.java, OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative merged with James's.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-alternative.patch, > OFBIZ-11306-alternative.patch, OFBIZ-11306-v2.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, OFBIZ-11306.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > OFBIZ-11306_Plugins.patch, OFBIZ-11306_Plugins.patch, > partyTokenMap.webtools.txt > > > CRSF tokens are generated using SecureRandom class (maybe later a JWT with a > "time out"). > They are stored in the user sessions (for AJAX calls and unauthenticated HTTP > calls) or OFBiz UtilCache (for authenticated HTTP calls), and verified during > POST request. > # In *controllers* a new csrf-token attribute is added to the security tag to > exempt or force CSRF token check. > # In *Widget Forms* a hidden token field is auto-generated. > # In *FTL form* a CSRF token is passed through <@ofbizUrl> to automatise the > change. Using <@ofbizUrl> macro to generate the CSRF token means there is no > need to manually add the CSRF token field to each form in the ftl files. It > will save time for users doing custom implementation and maintenance. While > there is CSRF token in the form URL, the token is invalidated during form > submission. So it's uniqueand harmless even though the CSRF token of the form > submission is shown in the browser address bar. > # For *Ajax calls* an ajaxPrefilter function (observer on DOM ready) is added > through OfbizUtil.js (itself called at start in decorators and such) > # The html metadata is storing the csrf token used by JQuery AJAX. This token > will not change to another value after it is consumed > # Csrf tokens for the user are removed from the UtilCache when the user logs > out or session invalidated. > The general rule are as follows: > * RequestMap configured with 'get' method will be exempted from CSRF token > check. > * RequestMap configured with 'post' or 'all' method will be subjected to CSRF > token check. (Note there are discussions that RequestMap with ‘all’ method > should also not be subjected to CSRF token check. This will be done after > ensuring a separate uri is used when posting changes.) > * "main" request URIs are exempted from CSRF token check. > * Setting csrf-token to false or true on the Request Map will override the > general rules above. > To Discuss: > * Invalidate authenticated user session when CSRF token check fails. > * Configure the general rules in a Service method (which will be run inside > the constructor of RequestMap class) when determining the final > securityCsrfToken value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8297) Convert
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045248#comment-17045248 ] Pierre Smits commented on OFBIZ-8297: - The minilang element as used in screen definitions like EditAgreementItem uses the java class 'PropertyToField'. This java class applies the 'EntityUtilProperties' function to retrieve the appropriate data from the SystemProperties entity (and if not available there, from the appropriate .properties file. Will close with resolution 'Not an issue'. > Convert -- > > Key: OFBIZ-8297 > URL: https://issues.apache.org/jira/browse/OFBIZ-8297 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Labels: configuration > Attachments: OFBIZ-8297-AgreementScreens.xml.patch, > OFBIZ-8297-AgreementScreens.xml.patch > > > * files when it comes to retrieving runtime configuration variables. > While this flawed approach is most prevalent when working with a multi-tenant > setup, where default values of runtime configuration parameters can differ > from tenant to tenant, it is also a wrong approach when using OFBiz in > controlled production setups. > When an adopter is required to change the value of a runtime configuration > parameter, it is required to go into a code upgrade process instead of > changing the value through the admin component (web tools). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-8297) Convert
[ https://issues.apache.org/jira/browse/OFBIZ-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-8297. --- Resolution: Not A Problem > Convert -- > > Key: OFBIZ-8297 > URL: https://issues.apache.org/jira/browse/OFBIZ-8297 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Minor > Labels: configuration > Attachments: OFBIZ-8297-AgreementScreens.xml.patch, > OFBIZ-8297-AgreementScreens.xml.patch > > > * files when it comes to retrieving runtime configuration variables. > While this flawed approach is most prevalent when working with a multi-tenant > setup, where default values of runtime configuration parameters can differ > from tenant to tenant, it is also a wrong approach when using OFBiz in > controlled production setups. > When an adopter is required to change the value of a runtime configuration > parameter, it is required to go into a code upgrade process instead of > changing the value through the admin component (web tools). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11312) DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks
[ https://issues.apache.org/jira/browse/OFBIZ-11312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11312. --- Fix Version/s: 17.12.01 18.12.01 Resolution: Fixed Thanks Benjamin, Good job, you did not oversimplified, you [rather improved what was there before furure was used|http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/DatabaseUtil.java?revision=1053722=markup=1139851] > DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to > connection-locks > -- > > Key: OFBIZ-11312 > URL: https://issues.apache.org/jira/browse/OFBIZ-11312 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.01, 17.12.01 > > Attachments: OFBIZ-11312_getColumnInfo_connection_locks_001.patch > > > The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using > a List> object. This does not work properly > as it runs into connection-locks. When debugging the error does not occur. I > assume that the slower pace of debugging prevents the error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045227#comment-17045227 ] Michael Brohl commented on OFBIZ-10290: --- [~holivier] can you please check? > Add Document Content: acc-agreements.adoc > - > > Key: OFBIZ-10290 > URL: https://issues.apache.org/jira/browse/OFBIZ-10290 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > Attachments: > 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo.patch, > 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo_diff.patch, > image-2020-02-26-09-00-03-460.png, image-2020-02-26-09-00-03-695.png > > > Add content for acc-agreements.doc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045225#comment-17045225 ] Pierre Smits commented on OFBIZ-10290: -- Is some additional work required? When opening the help page in [https://demo-trunk.ofbiz.apache.org/accounting/control/EditAgreement?agreementId=DS-1000-PURCH] , I now see a blank page. See the OFBiz-Accounting-EditAgreement-help-adoc image. Previously we had more content, see the OFBIZ-Accounting-EditAgreement-help-xml image > Add Document Content: acc-agreements.adoc > - > > Key: OFBIZ-10290 > URL: https://issues.apache.org/jira/browse/OFBIZ-10290 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > Attachments: > 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo.patch, > 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo_diff.patch, > image-2020-02-26-09-00-03-460.png, image-2020-02-26-09-00-03-695.png > > > Add content for acc-agreements.doc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10290: - Attachment: image-2020-02-26-09-00-03-460.png > Add Document Content: acc-agreements.adoc > - > > Key: OFBIZ-10290 > URL: https://issues.apache.org/jira/browse/OFBIZ-10290 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > Attachments: > 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo.patch, > 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo_diff.patch, > image-2020-02-26-09-00-03-460.png, image-2020-02-26-09-00-03-695.png > > > Add content for acc-agreements.doc -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10290) Add Document Content: acc-agreements.adoc
[ https://issues.apache.org/jira/browse/OFBIZ-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-10290: - Attachment: image-2020-02-26-09-00-03-695.png > Add Document Content: acc-agreements.adoc > - > > Key: OFBIZ-10290 > URL: https://issues.apache.org/jira/browse/OFBIZ-10290 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Sharan Foga >Assignee: Michael Brohl >Priority: Minor > Labels: accounting, asciidoc, documentation > Fix For: Upcoming Branch > > Attachments: > 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo.patch, > 0001-Agreement-Help-Docbook-file-migration-to-asciidoc-fo_diff.patch, > image-2020-02-26-09-00-03-460.png, image-2020-02-26-09-00-03-695.png > > > Add content for acc-agreements.doc -- This message was sent by Atlassian Jira (v8.3.4#803005)
