[jira] [Commented] (OFBIZ-11394) Convert getSubContentWithPermCheck service from mini-lang to groovy DSL

2020-03-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053125#comment-17053125
 ] 

Jacques Le Roux commented on OFBIZ-11394:
-

Note: for an obscure reason (I think I cherry-picked the wrong commit when 
bacporting for OFBIZ-11437) this was backported in R17 and R18. It's OK like 
that dead unused code can be pruned without consequences.

The commits are 
R18 - 
https://github.com/apache/ofbiz-framework/commit/38deff91acf1b05e75dc532b3f792368c561330c
R17 - 
https://github.com/apache/ofbiz-framework/commit/3d9b551d65a24d4ad0554db862af5aaac110633d

> Convert getSubContentWithPermCheck service from mini-lang to groovy DSL
> ---
>
> Key: OFBIZ-11394
> URL: https://issues.apache.org/jira/browse/OFBIZ-11394
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Priya Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11394.patch
>
>
> Convert getSubContentWithPermCheck service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11393) Convert getSubSubContentWithPermCheck service from mini-lang to groovy DSL

2020-03-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051177#comment-17051177
 ] 

Jacques Le Roux edited comment on OFBIZ-11393 at 3/6/20, 7:52 AM:
--

The utility of this service has been discussed on OFBIZ-11394.

And as per the discussion there we are removing the references for this service 
as it is not used OOTB and so no need to convert it to groovy.

Thanks!

 


was (Author: priya.sharma.9362):
The utility of this service has been discussed on 
https://issues.apache.org/jira/browse/OFBIZ-11394.

And as per the discussion there we are removing the references for this service 
as it is not used OOTB and so no need to convert it to groovy.

Thanks!

 

> Convert getSubSubContentWithPermCheck service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11393
> URL: https://issues.apache.org/jira/browse/OFBIZ-11393
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Sourabh Punyani
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11393.patch
>
>
> Convert getSubSubContentWithPermCheck service code from mini-lang to groovy 
> DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-05 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11437.
---
Resolution: Implemented

Done, the other backports can stay as is. It's only about pruning dead code. 
I'll update the real Jira for that though...

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-05 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053115#comment-17053115
 ] 

Pierre Smits commented on OFBIZ-11437:
--

IMO, we should not have back ported this to the r17.12 branch. But rather with 
this enhancement, work towards getting the first release of 18.11 out asap.

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053114#comment-17053114
 ] 

ASF subversion and git services commented on OFBIZ-11437:
-

Commit 2981ad988eda16e6ce7fc4568f6f063b8352be9f in ofbiz-framework's branch 
refs/heads/release18.12 from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2981ad9 ]

Improved: Add 2020 version of Incoterms

(OFBIZ-11437)

Alter the parent type and descriptions of existing Incoterm TermTypes to
indicate the version of Incoterms they relate to.

Added new Incoterm TermTypes and descriptions correspoding to the
Incoterms 2020 set.


> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053113#comment-17053113
 ] 

ASF subversion and git services commented on OFBIZ-11437:
-

Commit 0355006c62e33eac0867e2be88ffb435941830d4 in ofbiz-framework's branch 
refs/heads/release17.12 from Daniel Watford
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0355006 ]

Improved: Add 2020 version of Incoterms
(OFBIZ-11437)

Alter the parent type and descriptions of existing Incoterm TermTypes to
indicate the version of Incoterms they relate to.

Added new Incoterm TermTypes and descriptions correspoding to the
Incoterms 2020 set.

Conflicts handled by hand:
applications/datamodel/data/seed/PartySeedData.xml
applications/party/config/PartyEntityLabels.xml


> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053107#comment-17053107
 ] 

Jacques Le Roux commented on OFBIZ-11437:
-

Hi Daniel,

Indeed, sorry I missed your 1st message, looking at it... Thanks for the 
reminder...

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10407) create a docker image from the ofbiz system

2020-03-05 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-10407:


Assignee: (was: Pierre Smits)

> create a docker image from the ofbiz system
> ---
>
> Key: OFBIZ-10407
> URL: https://issues.apache.org/jira/browse/OFBIZ-10407
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Hans Bakker
>Priority: Major
>  Labels: DevOps
> Attachments: docker.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Attached an initial docker version from OFBiz copied from our GrowERP 
> production system translated to svn repositories.
> I propose to create a docker directory in the ofbiz framework root of which a 
> patch is attached.
> The image result is stored in hub.docker.com under the name ofbiz/full-trunk.
> It can be started in a docker environment with the following command:
> docker run -p 80:8080 -p 443:8443 ofbiz/full-trunk
>  and after about 30 seconds it can be show in the browser under:
>  [https://0.0.0.0/catalog/control/main]
>  the image can be created by executing this command in the ofbiz root when 
> the patch is applied:
>  docker build -t ofbiz/full-trunk docker
> the password to the ofbiz account at hub.docker.com will be supplied upon 
> request.
>   
> see the discussion in the mailinglist at 
> https://markmail.org/message/n7wcgroslj7v3gfe?q=docker+ofbiz
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (OFBIZ-11437) Add 2020 version of Incoterms

2020-03-05 Thread Daniel Watford (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Watford reopened OFBIZ-11437:


Hi [~jleroux]

Re-opened as changes are missing missing from R17 and R18 branches.

> Add 2020 version of Incoterms
> -
>
> Key: OFBIZ-11437
> URL: https://issues.apache.org/jira/browse/OFBIZ-11437
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> PartySeedData.xml includes a number of TermType entries corresponding to 
> Incoterms ([https://en.wikipedia.org/wiki/Incoterms])
> Incoterms 2020 came into effect on January 1st 2020 
> ([https://iccwbo.org/resources-for-business/incoterms-rules/]) but all other 
> versions of Incoterms remain valid as long as both parties to a 
> contract/agreement agree on the version in force.
> The Incoterms listed in PartySeedData are out of date and also appear to be 
> dated from the 2010 and 2000 version of Incoterms.
> This ticket is for the updating of PartySeedData to include the 2020 
> Incoterms. Existing incoterms should be maintained with their current IDs, 
> but their parent terms and their descriptions can be altered to indicate the 
> incoterms version they refer to. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11439) Convert ProductFeatureServices.xml mini lang to groovy

2020-03-05 Thread Nicolas Malin (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Malin reassigned OFBIZ-11439:
-

Assignee: Nicolas Malin  (was: Sebastian Berg)

> Convert ProductFeatureServices.xml mini lang to groovy
> --
>
> Key: OFBIZ-11439
> URL: https://issues.apache.org/jira/browse/OFBIZ-11439
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11439-Convert-ProductFeatureServices.xml-mini-lang-to-groovy.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11434) Forum Articles do not respond to pagination

2020-03-05 Thread Benjamin Jugl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jugl updated OFBIZ-11434:
--
Attachment: OFBIZ-11434.patch

> Forum Articles do not respond to pagination
> ---
>
> Key: OFBIZ-11434
> URL: https://issues.apache.org/jira/browse/OFBIZ-11434
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: OFBIZ-11434.patch
>
>
> Neither the view-size nor the view-index have any effect on the shown 
> articles in the forum.
> To reproduce:
>  # Log into the Frontend (ecommerce) as admin
>  # go to Browse Forums
>  # click any link ("Ask the Experts" was used for testing)
>  # Create "New Message" 21 times
>  # Try using the pagination
> Should be: The view should be limited to 20 items on the first page,  if the 
> view-size is 20. The second page should only display the 21st entry. 
> Is: The list always shows all 21 entries.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11439) Convert ProductFeatureServices.xml mini lang to groovy

2020-03-05 Thread Sebastian Berg (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Berg updated OFBIZ-11439:
---
Attachment: 
OFBIZ-11439-Convert-ProductFeatureServices.xml-mini-lang-to-groovy.patch

> Convert ProductFeatureServices.xml mini lang to groovy
> --
>
> Key: OFBIZ-11439
> URL: https://issues.apache.org/jira/browse/OFBIZ-11439
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11439-Convert-ProductFeatureServices.xml-mini-lang-to-groovy.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11442) Convert OrderReturnService mini-lang to groovy

2020-03-05 Thread Sebastian Berg (Jira)
Sebastian Berg created OFBIZ-11442:
--

 Summary: Convert OrderReturnService mini-lang to groovy
 Key: OFBIZ-11442
 URL: https://issues.apache.org/jira/browse/OFBIZ-11442
 Project: OFBiz
  Issue Type: Sub-task
  Components: order
Affects Versions: Trunk
Reporter: Sebastian Berg
Assignee: Sebastian Berg
 Fix For: Upcoming Branch






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL

2020-03-05 Thread Sebastian Berg (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052201#comment-17052201
 ] 

Sebastian Berg commented on OFBIZ-9984:
---

Hi,

I would like to convert the remaining Methods in OrderServices.xml to groovy. 
Do you mind if I take this one on me [~pgil]?

> Convert OrderServices.xml mini-lang to groovyDSL
> 
>
> Key: OFBIZ-9984
> URL: https://issues.apache.org/jira/browse/OFBIZ-9984
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Gil Portenseigne
>Priority: Minor
>  Labels: groovy, mini-lang
> Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some 
> mini-lang service to groovy script.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11441) createMissingCategoryAndProductAltUrls service misses a transaction

2020-03-05 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11441.
---
Fix Version/s: 17.12.02
   18.12.01
   Resolution: Fixed

> createMissingCategoryAndProductAltUrls service misses a transaction 
> 
>
> Key: OFBIZ-11441
> URL: https://issues.apache.org/jira/browse/OFBIZ-11441
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.02
>
>
> I'm not sure if this is always an issue, but getting to CreateSeoProdCatalog 
> throws this error in log:
> {noformat}
> 2020-03-04 17:11:50,610 |jsse-nio-9443-exec-6 |ControlServlet
> |T| [[[catalog::CreateSeoProdCatalog (Domain:https://localhost)] Request 
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-03-04 17:11:50,640 |jsse-nio-9443-exec-6 |GenericDelegator  
> |E| ERROR: Cannot do a find that returns an EntityListIterator with no 
> transaction in place. Wrap this call in a transaction.
> java.lang.Exception: Stack Trace
> at 
> org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1523) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.queryIterator(EntityQuery.java:397) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.getFieldList(EntityQuery.java:533) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery$getFieldList$6.call(Unknown Source) 
> [main/:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAltUrlInline(CatalogServices.groovy:403) 
> [script:?]
> at 
> CatalogServices$createMissingCategoryAltUrlInline.callCurrent(Unknown Source) 
> [script:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:156)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:168)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAndProductAltUrls(CatalogServices.groovy:306)
>  [script:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_202]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1217) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:821) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:44) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.Script.invokeMethod(Script.java:77) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> org.apache.ofbiz.service.engine.GroovyEngine.runSync(GroovyEngine.java:110) 
> [main/:?]
> {noformat}
> There is no others impacts. Maybe it was "broken by" OFBIZ-10808
> You can reproduce by getting to Catalogs in catalog webapp, selecting a 
> catalog there and using "Create SEO category/products"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11441) createMissingCategoryAndProductAltUrls service misses a transaction

2020-03-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051939#comment-17051939
 ] 

ASF subversion and git services commented on OFBIZ-11441:
-

Commit b57123406259c901f219de325636b5990ce6603f in ofbiz-framework's branch 
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b571234 ]

Fixed: createMissingCategoryAndProductAltUrls service misses a transaction
(OFBIZ-11441)

Not sure why it had use-transaction="false", makes no sens to me, too old to
check, not a big deal I guess


> createMissingCategoryAndProductAltUrls service misses a transaction 
> 
>
> Key: OFBIZ-11441
> URL: https://issues.apache.org/jira/browse/OFBIZ-11441
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> I'm not sure if this is always an issue, but getting to CreateSeoProdCatalog 
> throws this error in log:
> {noformat}
> 2020-03-04 17:11:50,610 |jsse-nio-9443-exec-6 |ControlServlet
> |T| [[[catalog::CreateSeoProdCatalog (Domain:https://localhost)] Request 
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-03-04 17:11:50,640 |jsse-nio-9443-exec-6 |GenericDelegator  
> |E| ERROR: Cannot do a find that returns an EntityListIterator with no 
> transaction in place. Wrap this call in a transaction.
> java.lang.Exception: Stack Trace
> at 
> org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1523) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.queryIterator(EntityQuery.java:397) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.getFieldList(EntityQuery.java:533) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery$getFieldList$6.call(Unknown Source) 
> [main/:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAltUrlInline(CatalogServices.groovy:403) 
> [script:?]
> at 
> CatalogServices$createMissingCategoryAltUrlInline.callCurrent(Unknown Source) 
> [script:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:156)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:168)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAndProductAltUrls(CatalogServices.groovy:306)
>  [script:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_202]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1217) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:821) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:44) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.Script.invokeMethod(Script.java:77) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> org.apache.ofbiz.service.engine.GroovyEngine.runSync(GroovyEngine.java:110) 
> [main/:?]
> {noformat}
> There is no others impacts. Maybe it was "broken by" OFBIZ-10808
> You can reproduce by getting to Catalogs in catalog webapp, selecting a 
> catalog there and using "Create SEO category/products"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11441) createMissingCategoryAndProductAltUrls service misses a transaction

2020-03-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051940#comment-17051940
 ] 

ASF subversion and git services commented on OFBIZ-11441:
-

Commit 667a2018b9540ff043859fa54aee6e778ef245cc in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=667a201 ]

Fixed: createMissingCategoryAndProductAltUrls service misses a transaction
(OFBIZ-11441)

Not sure why it had use-transaction="false", makes no sens to me, too old to
check, not a big deal I guess

# Conflicts:
#   applications/product/servicedef/services.xml


> createMissingCategoryAndProductAltUrls service misses a transaction 
> 
>
> Key: OFBIZ-11441
> URL: https://issues.apache.org/jira/browse/OFBIZ-11441
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> I'm not sure if this is always an issue, but getting to CreateSeoProdCatalog 
> throws this error in log:
> {noformat}
> 2020-03-04 17:11:50,610 |jsse-nio-9443-exec-6 |ControlServlet
> |T| [[[catalog::CreateSeoProdCatalog (Domain:https://localhost)] Request 
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-03-04 17:11:50,640 |jsse-nio-9443-exec-6 |GenericDelegator  
> |E| ERROR: Cannot do a find that returns an EntityListIterator with no 
> transaction in place. Wrap this call in a transaction.
> java.lang.Exception: Stack Trace
> at 
> org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1523) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.queryIterator(EntityQuery.java:397) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.getFieldList(EntityQuery.java:533) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery$getFieldList$6.call(Unknown Source) 
> [main/:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAltUrlInline(CatalogServices.groovy:403) 
> [script:?]
> at 
> CatalogServices$createMissingCategoryAltUrlInline.callCurrent(Unknown Source) 
> [script:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:156)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:168)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAndProductAltUrls(CatalogServices.groovy:306)
>  [script:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_202]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1217) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:821) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:44) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.Script.invokeMethod(Script.java:77) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> org.apache.ofbiz.service.engine.GroovyEngine.runSync(GroovyEngine.java:110) 
> [main/:?]
> {noformat}
> There is no others impacts. Maybe it was "broken by" OFBIZ-10808
> You can reproduce by getting to Catalogs in catalog webapp, selecting a 
> catalog there and using "Create SEO category/products"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-05 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051818#comment-17051818
 ] 

Pawan Verma edited comment on OFBIZ-5426 at 3/5/20, 9:02 AM:
-

I have created a new 
[PR|[https://github.com/apache/ofbiz-framework/pull/44|https://github.com/apache/ofbiz-framework/pull/44/files]]with
 suggested changes, Please have a look! 


was (Author: pawan.verma):
I have created a new 
[PR|[https://github.com/apache/ofbiz-framework/pull/44/files]] with suggested 
changes, Please have a look! 

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-05 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051818#comment-17051818
 ] 

Pawan Verma edited comment on OFBIZ-5426 at 3/5/20, 9:02 AM:
-

I have created a new PR [https://github.com/apache/ofbiz-framework/pull/44 
|https://github.com/apache/ofbiz-framework/pull/44/files]with suggested 
changes, Please have a look! 


was (Author: pawan.verma):
I have created a new 
[PR|[https://github.com/apache/ofbiz-framework/pull/44|https://github.com/apache/ofbiz-framework/pull/44/files]]with
 suggested changes, Please have a look! 

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11441) createMissingCategoryAndProductAltUrls service misses a transaction

2020-03-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051915#comment-17051915
 ] 

ASF subversion and git services commented on OFBIZ-11441:
-

Commit 784a299968090b09c11a8ceacbe57d459a267a27 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=784a299 ]

Fixed: createMissingCategoryAndProductAltUrls service misses a transaction
(OFBIZ-11441)

Not sure why it had use-transaction="false", makes no sens to me, too old to
check, not a big deal I guess


> createMissingCategoryAndProductAltUrls service misses a transaction 
> 
>
> Key: OFBIZ-11441
> URL: https://issues.apache.org/jira/browse/OFBIZ-11441
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> I'm not sure if this is always an issue, but getting to CreateSeoProdCatalog 
> throws this error in log:
> {noformat}
> 2020-03-04 17:11:50,610 |jsse-nio-9443-exec-6 |ControlServlet
> |T| [[[catalog::CreateSeoProdCatalog (Domain:https://localhost)] Request 
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-03-04 17:11:50,640 |jsse-nio-9443-exec-6 |GenericDelegator  
> |E| ERROR: Cannot do a find that returns an EntityListIterator with no 
> transaction in place. Wrap this call in a transaction.
> java.lang.Exception: Stack Trace
> at 
> org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1523) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.queryIterator(EntityQuery.java:397) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.getFieldList(EntityQuery.java:533) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery$getFieldList$6.call(Unknown Source) 
> [main/:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAltUrlInline(CatalogServices.groovy:403) 
> [script:?]
> at 
> CatalogServices$createMissingCategoryAltUrlInline.callCurrent(Unknown Source) 
> [script:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:156)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:168)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAndProductAltUrls(CatalogServices.groovy:306)
>  [script:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_202]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1217) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:821) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:44) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.Script.invokeMethod(Script.java:77) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> org.apache.ofbiz.service.engine.GroovyEngine.runSync(GroovyEngine.java:110) 
> [main/:?]
> {noformat}
> There is no others impacts. Maybe it was "broken by" OFBIZ-10808
> You can reproduce by getting to Catalogs in catalog webapp, selecting a 
> catalog there and using "Create SEO category/products"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11441) createMissingCategoryAndProductAltUrls service misses a transaction

2020-03-05 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11441:

Summary: createMissingCategoryAndProductAltUrls service misses a 
transaction   (was: runSync (serviceInvoker method in Groovy engine) misses a 
transaction )

> createMissingCategoryAndProductAltUrls service misses a transaction 
> 
>
> Key: OFBIZ-11441
> URL: https://issues.apache.org/jira/browse/OFBIZ-11441
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> I'm not sure if this is always an issue, but getting to CreateSeoProdCatalog 
> throws this error in log:
> {noformat}
> 2020-03-04 17:11:50,610 |jsse-nio-9443-exec-6 |ControlServlet
> |T| [[[catalog::CreateSeoProdCatalog (Domain:https://localhost)] Request 
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-03-04 17:11:50,640 |jsse-nio-9443-exec-6 |GenericDelegator  
> |E| ERROR: Cannot do a find that returns an EntityListIterator with no 
> transaction in place. Wrap this call in a transaction.
> java.lang.Exception: Stack Trace
> at 
> org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1523) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.queryIterator(EntityQuery.java:397) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.getFieldList(EntityQuery.java:533) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery$getFieldList$6.call(Unknown Source) 
> [main/:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAltUrlInline(CatalogServices.groovy:403) 
> [script:?]
> at 
> CatalogServices$createMissingCategoryAltUrlInline.callCurrent(Unknown Source) 
> [script:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:156)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:168)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAndProductAltUrls(CatalogServices.groovy:306)
>  [script:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_202]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1217) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:821) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:44) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.Script.invokeMethod(Script.java:77) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> org.apache.ofbiz.service.engine.GroovyEngine.runSync(GroovyEngine.java:110) 
> [main/:?]
> {noformat}
> There is no others impacts. Maybe it was "broken by" OFBIZ-10808
> You can reproduce by getting to Catalogs in catalog webapp, selecting a 
> catalog there and using "Create SEO category/products"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11441) runSync (serviceInvoker method in Groovy engine) misses a transaction

2020-03-05 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-11441:
---

Assignee: Jacques Le Roux

> runSync (serviceInvoker method in Groovy engine) misses a transaction 
> --
>
> Key: OFBIZ-11441
> URL: https://issues.apache.org/jira/browse/OFBIZ-11441
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> I'm not sure if this is always an issue, but getting to CreateSeoProdCatalog 
> throws this error in log:
> {noformat}
> 2020-03-04 17:11:50,610 |jsse-nio-9443-exec-6 |ControlServlet
> |T| [[[catalog::CreateSeoProdCatalog (Domain:https://localhost)] Request 
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-03-04 17:11:50,640 |jsse-nio-9443-exec-6 |GenericDelegator  
> |E| ERROR: Cannot do a find that returns an EntityListIterator with no 
> transaction in place. Wrap this call in a transaction.
> java.lang.Exception: Stack Trace
> at 
> org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1523) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.queryIterator(EntityQuery.java:397) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.getFieldList(EntityQuery.java:533) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery$getFieldList$6.call(Unknown Source) 
> [main/:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAltUrlInline(CatalogServices.groovy:403) 
> [script:?]
> at 
> CatalogServices$createMissingCategoryAltUrlInline.callCurrent(Unknown Source) 
> [script:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:156)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:168)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAndProductAltUrls(CatalogServices.groovy:306)
>  [script:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_202]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1217) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:821) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:44) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.Script.invokeMethod(Script.java:77) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> org.apache.ofbiz.service.engine.GroovyEngine.runSync(GroovyEngine.java:110) 
> [main/:?]
> {noformat}
> There is no others impacts. Maybe it was "broken by" OFBIZ-10808
> You can reproduce by getting to Catalogs in catalog webapp, selecting a 
> catalog there and using "Create SEO category/products"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11236) Add shipment notes

2020-03-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051904#comment-17051904
 ] 

Jacques Le Roux commented on OFBIZ-11236:
-

Hi Pierre,

Any chances? I have this pending somehow, please let me know if you expect to 
do it "soon", TIA

> Add shipment notes
> --
>
> Key: OFBIZ-11236
> URL: https://issues.apache.org/jira/browse/OFBIZ-11236
> Project: OFBiz
>  Issue Type: New Feature
>  Components: product
>Affects Versions: Trunk
>Reporter: Gaudin Pierre
>Priority: Minor
>  Labels: shipment
> Attachments: OFBIZ-11236_shipmentNotesV3.patch, Screen Shot 
> 2020-02-11 at 08.53.37.png
>
>
> Hello,
> For many entities there are associated notes. However, there are no notes 
> associated with shipments.
> The purpose of this patch is therefore to add notes to the shipments.
> A new tab called "note" appears when displaying a shipment. From this tab it 
> is possible to add a note. From the shipment overview a section displays the 
> notes associated with the shipment.
> For this new feature a "ShipmentNote" entity has been added. In the same way, 
> all the services allowing the management of notes have been associated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11402) Convert CommonServices.xml from mini lang to groovy

2020-03-05 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051902#comment-17051902
 ] 

Nicolas Malin commented on OFBIZ-11402:
---

Thanks [~wpaetzold] , my remarks :

{code:java}
UtilValidate.is[Not]Empty{code}
are useless :
 * 'if (UtilValidate.isNotEmpty(parameters.purposeEnumId)) {' == 'if 
(parameters.purposeEnumId) {'
 * 'if (UtilValidate.isEmpty(parameters.defaultRoundingMode {' == 'if 
(!parameters.defaultRoundingMode) {'

{code:java}if(parameters.uomId.equals(parameters.uomIdTo)){code}
* can be replace by if '(parameters.uomId == parameters.uomIdTo)', .equals is 
useless in groovy


{code:java}
List uomConversions = 
from("UomConversionDated").where(condition).orderBy("-fromDate").cache().queryList()
uomConversion = uomConversions.get(0)
{code}
* you can do : uomConversion = 
from("UomConversionDated").where(condition).orderBy("-fromDate").cache().queryFirst()

{code:java}
 logVerbose("Uom conversion of ["+ parameters.originalValue + "] from ["+ 
parameters.uomId +"] to ["+ parameters.uomIdTo +"] using conversion factor ["+ 
uomConversion.conversionFactor +"], result is ["+ convertedValue +"]")
{code}
* You can GString to help readability

{code:java}
List geoAssoc = from("GeoAssoc")
.where(geoId: parameters.geoId, geoAssocTypeId: 
parameters.geoAssocTypeId)
.queryList()
...
for (GenericValue geo : geoAssoc){
geoList << geo.geoIdTo
}
{code}

* You can go fast : geoList = from("GeoAssoc").where(geoId: parameters.geoId, 
geoAssocTypeId: parameters.geoAssocTypeId).getFieldList('geoIdTo')


{code:java}
GenericValue uomConversion = from("UomConversion")
.where(uomId: parameters.uomId, uomIdTo: parameters.uomIdTo)
.queryOne()
if (UtilValidate.isNotEmpty(uomConversion)){
exist = true
}
else {
exist = false
}
result.exist = exist
{code}
* :) result.exist = from("UomConversion").where(uomId: parameters.uomId, 
uomIdTo: parameters.uomIdTo).queryCount() == 1


{code:java}
EntityCondition condition = EntityCondition.makeCondition([
EntityCondition.makeCondition("uomId", parameters.uomId),
EntityCondition.makeCondition("uomIdTo", parameters.uomIdTo)
])
if (UtilValidate.isNotEmpty(parameters.purposeEnumId)){
condition = EntityCondition.makeCondition([
EntityCondition.makeCondition("purposeEnumId", 
parameters.purposeEnumId),
condition
])
}
{code}
* you can use directly a Map, EntityCondition is useless


{code:java}
if(UtilValidate.isNotEmpty(uomConversion.roundingMode)){
roundingMode = uomConversion.roundingMode
}
else {
roundingMode = parameters.defaultRoundingMode
}
{code}
* you can do: roundingMode = uomConversion.roundingMode ?: 
parameters.defaultRoundingMode




> Convert CommonServices.xml from mini lang to groovy
> ---
>
> Key: OFBIZ-11402
> URL: https://issues.apache.org/jira/browse/OFBIZ-11402
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Wiebke Pätzold
>Priority: Minor
>  Labels: groovy, mini-lang, refactoring
> Attachments: OFBIZ-11402.patch
>
>
> With the work on OFBIZ-11291 and OFBIZ-11357 parts of CommonServices.xml were 
> converted to Groovy. We should convert the whole into Groovy now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11441) runSync (serviceInvoker method in Groovy engine) misses a transaction

2020-03-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051894#comment-17051894
 ] 

Jacques Le Roux commented on OFBIZ-11441:
-

I tried to create a new catalog using "New Prod Catalog" in Catalogs page 
(catalog/control/FindCatalog) and this issue does not appear. Must be related 
to CreateSeoProdCatalog, and maybe other cases.




> runSync (serviceInvoker method in Groovy engine) misses a transaction 
> --
>
> Key: OFBIZ-11441
> URL: https://issues.apache.org/jira/browse/OFBIZ-11441
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> I'm not sure if this is always an issue, but getting to CreateSeoProdCatalog 
> throws this error in log:
> {noformat}
> 2020-03-04 17:11:50,610 |jsse-nio-9443-exec-6 |ControlServlet
> |T| [[[catalog::CreateSeoProdCatalog (Domain:https://localhost)] Request 
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-03-04 17:11:50,640 |jsse-nio-9443-exec-6 |GenericDelegator  
> |E| ERROR: Cannot do a find that returns an EntityListIterator with no 
> transaction in place. Wrap this call in a transaction.
> java.lang.Exception: Stack Trace
> at 
> org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1523) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.queryIterator(EntityQuery.java:397) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery.getFieldList(EntityQuery.java:533) 
> [main/:?]
> at 
> org.apache.ofbiz.entity.util.EntityQuery$getFieldList$6.call(Unknown Source) 
> [main/:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAltUrlInline(CatalogServices.groovy:403) 
> [script:?]
> at 
> CatalogServices$createMissingCategoryAltUrlInline.callCurrent(Unknown Source) 
> [script:?]
> at 
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:156)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:168)
>  [groovy-2.5.8.jar:2.5.8]
> at 
> CatalogServices.createMissingCategoryAndProductAltUrls(CatalogServices.groovy:306)
>  [script:?]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_202]
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_202]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
> at 
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1217) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:821) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:44) 
> [groovy-2.5.8.jar:2.5.8]
> at groovy.lang.Script.invokeMethod(Script.java:77) 
> [groovy-2.5.8.jar:2.5.8]
> at 
> org.apache.ofbiz.service.engine.GroovyEngine.runSync(GroovyEngine.java:110) 
> [main/:?]
> {noformat}
> There is no others impacts. Maybe it was "broken by" OFBIZ-10808
> You can reproduce by getting to Catalogs in catalog webapp, selecting a 
> catalog there and using "Create SEO category/products"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11436) Convert ProductContentServices.xml mini lang to groovy

2020-03-05 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051872#comment-17051872
 ] 

Nicolas Malin edited comment on OFBIZ-11436 at 3/5/20, 8:08 AM:


Thanks [~sberg] for your patch, my remarks :
{code:java}
UtilValidate.is[Not]Empty{code}
are useless :
 * 'if (UtilValidate.isNotEmpty(parameters.metaDescription)) {' == 'if 
(parameters.metaDescription) {'
 * 'if (UtilValidate.isEmpty(updateProductPromoContentMap.thruDate)) {' == 'if 
(!updateProductPromoContentMap.thruDate) {'

 

 
{code:java}
  Map updateContent = parameters
 run service:"updateContent", with: updateContent
{code}
 
 * You can write directly 'run service:"updateContent", with: parameters'

 
{code:java}
.where([dataResourceId: productContent.dataResourceId]){code}
 * [ ] are useless you can also do : .where(dataResourceId: 
productContent.dataResourceId)

 
{code:java}
productContents = from("ProductContentAndInfo").where([productId: 
parameters.productId, productContentTypeId: "PAGE_TITLE"]).queryList()
if (UtilValidate.isNotEmpty(productContents)) {
GenericValue productContent = productContents.get(0){code}
You can replace by a direct GenericValue resolution :

 
{code:java}
GenericValue productContent = from("ProductContentAndInfo").where(productId: 
parameters.productId, productContentTypeId: "PAGE_TITLE").queryFirst()
if (productContent) { ...{code}


was (Author: soledad):
Thanks [~sberg] for you patch, my remarks :
{code:java}
UtilValidate.is[Not]Empty{code}
are useless :
 * 'if (UtilValidate.isNotEmpty(parameters.metaDescription)) {' == 'if 
(parameters.metaDescription) {'
 * 'if (UtilValidate.isEmpty(updateProductPromoContentMap.thruDate)) {' == 'if 
(!updateProductPromoContentMap.thruDate) {'

 

 
{code:java}
  Map updateContent = parameters
 run service:"updateContent", with: updateContent
{code}
 
 * You can write directly 'run service:"updateContent", with: parameters'

 
{code:java}
.where([dataResourceId: productContent.dataResourceId]){code}
 * [ ] are useless you can also do : .where(dataResourceId: 
productContent.dataResourceId)

 
{code:java}
productContents = from("ProductContentAndInfo").where([productId: 
parameters.productId, productContentTypeId: "PAGE_TITLE"]).queryList()
if (UtilValidate.isNotEmpty(productContents)) {
GenericValue productContent = productContents.get(0){code}
You can replace by a direct GenericValue resolution :

 
{code:java}
GenericValue productContent = from("ProductContentAndInfo").where(productId: 
parameters.productId, productContentTypeId: "PAGE_TITLE").queryFirst()
if (productContent) { ...{code}

> Convert ProductContentServices.xml mini lang to groovy
> --
>
> Key: OFBIZ-11436
> URL: https://issues.apache.org/jira/browse/OFBIZ-11436
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11436-ProductContentServices.xml-minilang-to-groovy.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11436) Convert ProductContentServices.xml mini lang to groovy

2020-03-05 Thread Nicolas Malin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051872#comment-17051872
 ] 

Nicolas Malin commented on OFBIZ-11436:
---

Thanks [~sberg] for you patch, my remarks :
{code:java}
UtilValidate.is[Not]Empty{code}
are useless :
 * 'if (UtilValidate.isNotEmpty(parameters.metaDescription)) {' == 'if 
(parameters.metaDescription) {'
 * 'if (UtilValidate.isEmpty(updateProductPromoContentMap.thruDate)) {' == 'if 
(!updateProductPromoContentMap.thruDate) {'

 

 
{code:java}
  Map updateContent = parameters
 run service:"updateContent", with: updateContent
{code}
 
 * You can write directly 'run service:"updateContent", with: parameters'

 
{code:java}
.where([dataResourceId: productContent.dataResourceId]){code}
 * [ ] are useless you can also do : .where(dataResourceId: 
productContent.dataResourceId)

 
{code:java}
productContents = from("ProductContentAndInfo").where([productId: 
parameters.productId, productContentTypeId: "PAGE_TITLE"]).queryList()
if (UtilValidate.isNotEmpty(productContents)) {
GenericValue productContent = productContents.get(0){code}
You can replace by a direct GenericValue resolution :

 
{code:java}
GenericValue productContent = from("ProductContentAndInfo").where(productId: 
parameters.productId, productContentTypeId: "PAGE_TITLE").queryFirst()
if (productContent) { ...{code}

> Convert ProductContentServices.xml mini lang to groovy
> --
>
> Key: OFBIZ-11436
> URL: https://issues.apache.org/jira/browse/OFBIZ-11436
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11436-ProductContentServices.xml-minilang-to-groovy.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11441) runSync (serviceInvoker method in Groovy engine) misses a transaction

2020-03-05 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-11441:
---

 Summary: runSync (serviceInvoker method in Groovy engine) misses a 
transaction 
 Key: OFBIZ-11441
 URL: https://issues.apache.org/jira/browse/OFBIZ-11441
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Jacques Le Roux


I'm not sure if this is always an issue, but getting to CreateSeoProdCatalog 
throws this error in log:

{noformat}
2020-03-04 17:11:50,610 |jsse-nio-9443-exec-6 |ControlServlet
|T| [[[catalog::CreateSeoProdCatalog (Domain:https://localhost)] Request Begun, 
encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-03-04 17:11:50,640 |jsse-nio-9443-exec-6 |GenericDelegator  
|E| ERROR: Cannot do a find that returns an EntityListIterator with no 
transaction in place. Wrap this call in a transaction.
java.lang.Exception: Stack Trace
at 
org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1523) 
[main/:?]
at 
org.apache.ofbiz.entity.util.EntityQuery.queryIterator(EntityQuery.java:397) 
[main/:?]
at 
org.apache.ofbiz.entity.util.EntityQuery.getFieldList(EntityQuery.java:533) 
[main/:?]
at org.apache.ofbiz.entity.util.EntityQuery$getFieldList$6.call(Unknown 
Source) [main/:?]
at 
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
 [groovy-2.5.8.jar:2.5.8]
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
 [groovy-2.5.8.jar:2.5.8]
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127)
 [groovy-2.5.8.jar:2.5.8]
at 
CatalogServices.createMissingCategoryAltUrlInline(CatalogServices.groovy:403) 
[script:?]
at 
CatalogServices$createMissingCategoryAltUrlInline.callCurrent(Unknown Source) 
[script:?]
at 
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
 [groovy-2.5.8.jar:2.5.8]
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:156)
 [groovy-2.5.8.jar:2.5.8]
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:168)
 [groovy-2.5.8.jar:2.5.8]
at 
CatalogServices.createMissingCategoryAndProductAltUrls(CatalogServices.groovy:306)
 [script:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_202]
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:1.8.0_202]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[?:1.8.0_202]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
at 
org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101) 
[groovy-2.5.8.jar:2.5.8]
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323) 
[groovy-2.5.8.jar:2.5.8]
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1217) 
[groovy-2.5.8.jar:2.5.8]
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041) 
[groovy-2.5.8.jar:2.5.8]
at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:821) 
[groovy-2.5.8.jar:2.5.8]
at 
groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:44) 
[groovy-2.5.8.jar:2.5.8]
at groovy.lang.Script.invokeMethod(Script.java:77) 
[groovy-2.5.8.jar:2.5.8]
at 
org.apache.ofbiz.service.engine.GroovyEngine.runSync(GroovyEngine.java:110) 
[main/:?]
{noformat}

There is no others impacts. Maybe it was "broken by" OFBIZ-10808

You can reproduce by getting to Catalogs in catalog webapp, selecting a catalog 
there and using "Create SEO category/products"






--
This message was sent by Atlassian Jira
(v8.3.4#803005)