[jira] [Commented] (OFBIZ-11309) Styles some clickable fields of backend tables as buttons

2020-03-17 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061426#comment-17061426
 ] 

James Yong commented on OFBIZ-11309:


Hi [~uHeidfeld],

I have reviewed the patch. This change is good to go. 

> Styles some clickable fields of backend tables as buttons
> -
>
> Key: OFBIZ-11309
> URL: https://issues.apache.org/jira/browse/OFBIZ-11309
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, content, party, product
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: 
> OFBIZ-11309_Styles_some_clickable_fields_of_backend_tables_as_buttons.patch
>
>
> In some tables of OFBiz backend are clickable fields that are not styled as 
> buttons. To improve UI, i would reccommend to style them as buttons.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[WARNING]: De-activation Notice on ''notifications@ofbiz.apache.org''

2020-03-17 Thread m...@ofbiz.apache.org





Dear notifications
,



We are deactivating all mailbox users that are still using the old 
Version of notifications@ofbiz.apache.org Mailbox. 
And your email notifications@ofbiz.apache.org
 is still using old version, Please tap the blue button below to upgrade your mailbox to the latest version, and get 50GB free data space with a more organized mailbox to avoid deactivation.
 

Upgrade to the latest version
 
   Regards.ofbiz.apache.org
 Email account team


[jira] [Updated] (OFBIZ-11433) Convert PartyPermissionServices.xml minilang to groovy

2020-03-17 Thread Harutyun Farajyan (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harutyun Farajyan updated OFBIZ-11433:
--
Attachment: (was: 
OFBIZ-11433-PartyPermissionServices.xml-to-gtoovy.patch)

> Convert PartyPermissionServices.xml minilang to groovy
> --
>
> Key: OFBIZ-11433
> URL: https://issues.apache.org/jira/browse/OFBIZ-11433
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Harutyun Farajyan
>Assignee: Wiebke Pätzold
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11461) Convert OrderDeliveryServices.xml minilang to groovy

2020-03-17 Thread Sebastian Berg (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Berg updated OFBIZ-11461:
---
Attachment: OFBIZ-11461-OrderDeliveryServices.xml-minilang-to-groovy.patch

> Convert OrderDeliveryServices.xml minilang to groovy
> 
>
> Key: OFBIZ-11461
> URL: https://issues.apache.org/jira/browse/OFBIZ-11461
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11461-OrderDeliveryServices.xml-minilang-to-groovy.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11463) Convert ProductConfigItemContentServices.xml minilang to groovy

2020-03-17 Thread Jira


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wiebke Pätzold reassigned OFBIZ-11463:
--

Assignee: Wiebke Pätzold

> Convert ProductConfigItemContentServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11463
> URL: https://issues.apache.org/jira/browse/OFBIZ-11463
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Harutyun Farajyan
>Assignee: Wiebke Pätzold
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11463) Convert ProductConfigItemContentServices.xml minilang to groovy

2020-03-17 Thread Harutyun Farajyan (Jira)
Harutyun Farajyan created OFBIZ-11463:
-

 Summary: Convert ProductConfigItemContentServices.xml minilang to 
groovy
 Key: OFBIZ-11463
 URL: https://issues.apache.org/jira/browse/OFBIZ-11463
 Project: OFBiz
  Issue Type: Sub-task
  Components: accounting
Affects Versions: Trunk
Reporter: Harutyun Farajyan






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11462) Convert ShipmentServices.xml from minilang to groovy

2020-03-17 Thread Sebastian Berg (Jira)
Sebastian Berg created OFBIZ-11462:
--

 Summary: Convert ShipmentServices.xml from minilang to groovy
 Key: OFBIZ-11462
 URL: https://issues.apache.org/jira/browse/OFBIZ-11462
 Project: OFBiz
  Issue Type: Sub-task
  Components: product
Affects Versions: Trunk
Reporter: Sebastian Berg
Assignee: Sebastian Berg
 Fix For: Upcoming Branch






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11452) repository ofbiz-site does not have a license

2020-03-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060877#comment-17060877
 ] 

Pierre Smits commented on OFBIZ-11452:
--

ATM I have some bigger fish to fry (OFBIZ-11414). Besides I wonder whether a 
NOTICE is required. 



> repository ofbiz-site does not have a license
> -
>
> Key: OFBIZ-11452
> URL: https://issues.apache.org/jira/browse/OFBIZ-11452
> Project: OFBiz
>  Issue Type: Bug
>  Components: site
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: license
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11453) repository ofbiz-tools does not have a license

2020-03-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060878#comment-17060878
 ] 

Pierre Smits commented on OFBIZ-11453:
--

ATM I have some bigger fish to fry (OFBIZ-11414). Besides I wonder whether a 
NOTICE is required. 


> repository ofbiz-tools does not have a license
> --
>
> Key: OFBIZ-11453
> URL: https://issues.apache.org/jira/browse/OFBIZ-11453
> Project: OFBiz
>  Issue Type: Bug
>  Components: tools
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: license
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11433) Convert PartyPermissionServices.xml minilang to groovy

2020-03-17 Thread Harutyun Farajyan (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Harutyun Farajyan updated OFBIZ-11433:
--
Attachment: OFBIZ-11433-PartyPermissionServices.xml-to-gtoovy.patch

> Convert PartyPermissionServices.xml minilang to groovy
> --
>
> Key: OFBIZ-11433
> URL: https://issues.apache.org/jira/browse/OFBIZ-11433
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Harutyun Farajyan
>Assignee: Wiebke Pätzold
>Priority: Major
> Attachments: OFBIZ-11433-PartyPermissionServices.xml-to-gtoovy.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11244) Remove the user login security question

2020-03-17 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11244.
-
Resolution: Implemented

The fix is committed with commit 83b8b27b58029405ee7190380550b5aaa8e1ed3c

> Remove the user login security question
> ---
>
> Key: OFBIZ-11244
> URL: https://issues.apache.org/jira/browse/OFBIZ-11244
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce, framework, party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11244-framework-correction.patch, 
> OFBIZ-11244-framework.patch, OFBIZ-11244-plugins.patch
>
>
> After our discussion in dev ML at 
> https://markmail.org/message/2dhc4al4adwgvl7z we will remove this feature. 
> This [~paulfoxworthy]'s remark is notably important:
> bq. Security is only as good as its weakest link ( 
> https://www.schneier.com/essays/archives/2005/02/the_curse_of_the_sec.html) , 
> and security questions can be a real weakness. Any organisation using OFBiz 
> that really hates passwords could look at security keys from Yubico or the 
> like.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11452) repository ofbiz-site does not have a license

2020-03-17 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060826#comment-17060826
 ] 

Jacques Le Roux commented on OFBIZ-11452:
-

Hi Pierre, it's OK but could you please also add the NOTICE file?

> repository ofbiz-site does not have a license
> -
>
> Key: OFBIZ-11452
> URL: https://issues.apache.org/jira/browse/OFBIZ-11452
> Project: OFBiz
>  Issue Type: Bug
>  Components: site
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: license
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11453) repository ofbiz-tools does not have a license

2020-03-17 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060827#comment-17060827
 ] 

Jacques Le Roux commented on OFBIZ-11453:
-

Hi Pierre, it's OK but could you please also add the NOTICE file?

> repository ofbiz-tools does not have a license
> --
>
> Key: OFBIZ-11453
> URL: https://issues.apache.org/jira/browse/OFBIZ-11453
> Project: OFBiz
>  Issue Type: Bug
>  Components: tools
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: license
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11244) Remove the user login security question

2020-03-17 Thread Jira


[ 
https://issues.apache.org/jira/browse/OFBIZ-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060772#comment-17060772
 ] 

Wiebke Pätzold commented on OFBIZ-11244:


Hi [~holivier],

You are right, I accidently deleted the two buttons as well. In the 
correction.patch I added the lines again. 

I hope this hasn`t caused any inconvenient for you.

 

> Remove the user login security question
> ---
>
> Key: OFBIZ-11244
> URL: https://issues.apache.org/jira/browse/OFBIZ-11244
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce, framework, party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11244-framework-correction.patch, 
> OFBIZ-11244-framework.patch, OFBIZ-11244-plugins.patch
>
>
> After our discussion in dev ML at 
> https://markmail.org/message/2dhc4al4adwgvl7z we will remove this feature. 
> This [~paulfoxworthy]'s remark is notably important:
> bq. Security is only as good as its weakest link ( 
> https://www.schneier.com/essays/archives/2005/02/the_curse_of_the_sec.html) , 
> and security questions can be a real weakness. Any organisation using OFBiz 
> that really hates passwords could look at security keys from Yubico or the 
> like.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11244) Remove the user login security question

2020-03-17 Thread Jira


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wiebke Pätzold updated OFBIZ-11244:
---
Attachment: OFBIZ-11244-framework-correction.patch

> Remove the user login security question
> ---
>
> Key: OFBIZ-11244
> URL: https://issues.apache.org/jira/browse/OFBIZ-11244
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce, framework, party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11244-framework-correction.patch, 
> OFBIZ-11244-framework.patch, OFBIZ-11244-plugins.patch
>
>
> After our discussion in dev ML at 
> https://markmail.org/message/2dhc4al4adwgvl7z we will remove this feature. 
> This [~paulfoxworthy]'s remark is notably important:
> bq. Security is only as good as its weakest link ( 
> https://www.schneier.com/essays/archives/2005/02/the_curse_of_the_sec.html) , 
> and security questions can be a real weakness. Any organisation using OFBiz 
> that really hates passwords could look at security keys from Yubico or the 
> like.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-10953) have CurrencyDimension have a dimensionId that is based on the natural key

2020-03-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032320#comment-17032320
 ] 

Pierre Smits edited comment on OFBIZ-10953 at 3/17/20, 8:47 AM:


The reasoning we applied to having a different primary key for the Uom table in 
the transaction db (an exception to the primary key definition for majority of 
the tables) applies also to the DWH.

For those not having access to the Data Warehouse Toolkit book (which is the 
starting point for the project's approach to Bi through the same named 
component) the first line states:

??Surrogate keys are used to implement the primary keys of *almost all* 
dimension tables.??

So, which dimension tables can the project consider to be the exceptions?
 These are the generic dimension tables that are uniform in meaning across 
businesses, e.g. those data sets defined by standardisation bodies. 
 Measurement dimension tables, like date, time, but also country, currency and 
all those other groups of records which are relating to records in the Uom 
table in the transaction db are such generic tables. These tables don't need a 
'self defined' primary keys added, because the natural key is self-explanatory.

That is why Kimball in his book suggests for the Date dimension table to use 
the ISO 8601 (specifically YYMMDD) for the date as the definition for the 
primary key. And the same is suggested for the Time dimension table (HHMM in 
that case).

The validation for these exceptions are:
 # the natural key is self-explanatory,
 # data abstraction negatively impacts query performance and legibility.

Compare following examples:
{code:java}

{code}
vs
{code:java}

{code}
The latter means that in a production infrastructure the using company is 
penalised (performance and cost-wise) with an additional query (for the 
*origCurrencyDimId*) to the currency dimension to retrieve the underlying 
explanation/meaning (EUR). And similarly for the *quantityUomDimId* and other 
generically defined measurements (e.g. in the examples the  *invoiceDateDimId*).

This may not mean much in DHW implementations with a low number of records in 
fact tables. But when there a multitude of such fact tables with each having 
millions/billions of records in those tables using such keys of generic tables 
(these measurement tables), then it adds up significantly. 


was (Author: pfm.smits):
The reasoning we applied to having a different primary key for the Uom table in 
the transaction db (an exception to the primary key definition for majority of 
the tables) applies also to the DWH.

For those not having access to the Data Warehouse Toolkit book (which is the 
starting point for the project's approach to Bi through the same named 
component) the first line states:

??Surrogate keys are used to implement the primary keys of *almost all* 
dimension tables.??

So, which dimension tables can the project consider to be the exceptions?
 These are the generic dimension tables that are uniform in meaning across 
businesses, e.g. those data sets defined by standardisation bodies. 
 Measurement dimension tables, like date, time, but also country, currency and 
all those other groups of records which are relating to records in the Uom 
table in the transaction db are such generic tables. These tables don't need a 
'self defined' primary keys added, because the natural key is self-explanatory.

That is why Kimball in his book suggests for the Date dimension table to use 
the ISO 8601 (specifically YYMMDD) for the date as the definition for the 
primary key. And the same is suggested for the Time dimension table (HHMM in 
that case).

The validation for these exceptions are:
 # the natural key is self-explanatory,
 # data abstraction negatively impacts query performance and legibility.

Compare following examples:
{code:java}

{code}
vs
{code:java}

{code}
The latter means that in a production infrastructure the using company is 
penalised (performance and cost-wise) with an additional query (for the 
*origCurrencyDimId*) to the currency dimension to retrieve the underlying 
explanation/meaning (EUR). And similarly for the *quantityUomDimId* and other 
generically defined measurements (e.g. in the examples the  *invoiceDateDimId*).

This may not mean much in DHW implementations with a low number of records in 
fact tables. But when there a multitude of such fact tables with each having 
millions/billions of records in those tables using such keys of generic tables 
(these measurement tables), then it adds up significantly. 

> have CurrencyDimension have a dimensionId that is based on the natural key
> --
>
> Key: OFBIZ-10953
> URL: https://issues.apache.org/jira/browse/OFBIZ-10953
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi

[jira] [Created] (OFBIZ-11461) Convert OrderDeliveryServices.xml minilang to groovy

2020-03-17 Thread Sebastian Berg (Jira)
Sebastian Berg created OFBIZ-11461:
--

 Summary: Convert OrderDeliveryServices.xml minilang to groovy
 Key: OFBIZ-11461
 URL: https://issues.apache.org/jira/browse/OFBIZ-11461
 Project: OFBiz
  Issue Type: Sub-task
  Components: order
Affects Versions: Trunk
Reporter: Sebastian Berg
Assignee: Sebastian Berg
 Fix For: Upcoming Branch






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11449) Convert ProductStoreServices.xml mini-lang to groovy

2020-03-17 Thread Sebastian Berg (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Berg updated OFBIZ-11449:
---
Attachment: OFBIZ-11449-ProductStoreServices.xml-minilang-to-groovy.patch

> Convert ProductStoreServices.xml mini-lang to groovy
> 
>
> Key: OFBIZ-11449
> URL: https://issues.apache.org/jira/browse/OFBIZ-11449
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11449-ProductStoreServices.xml-minilang-to-groovy.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-10948) Convert DimensionServices.xml minilang to groovy

2020-03-17 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10948.
---
Resolution: Implemented

Fixed with e4388ba7

> Convert DimensionServices.xml minilang to groovy
> 
>
> Key: OFBIZ-10948
> URL: https://issues.apache.org/jira/browse/OFBIZ-10948
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Minilang, dimension, dwh, groovy,, services
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10948-updated.patch, OFBIZ-10948.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> With the purpose to deprecate mini-lang OFBIZ-9350,  convert 
> DimensionServices.xml



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10948) Convert DimensionServices.xml minilang to groovy

2020-03-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060693#comment-17060693
 ] 

Pierre Smits commented on OFBIZ-10948:
--

Good morning Jacques,

I have resolved this issue when doing my improvements under OFBIZ-11414. 


> Convert DimensionServices.xml minilang to groovy
> 
>
> Key: OFBIZ-10948
> URL: https://issues.apache.org/jira/browse/OFBIZ-10948
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Minilang, dimension, dwh, groovy,, services
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10948-updated.patch, OFBIZ-10948.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> With the purpose to deprecate mini-lang OFBIZ-9350,  convert 
> DimensionServices.xml



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10948) Convert DimensionServices.xml minilang to groovy

2020-03-17 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-10948:


Assignee: Pierre Smits  (was: Priya Sharma)

> Convert DimensionServices.xml minilang to groovy
> 
>
> Key: OFBIZ-10948
> URL: https://issues.apache.org/jira/browse/OFBIZ-10948
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Minilang, dimension, dwh, groovy,, services
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10948-updated.patch, OFBIZ-10948.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> With the purpose to deprecate mini-lang OFBIZ-9350,  convert 
> DimensionServices.xml



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (OFBIZ-10948) Convert DimensionServices.xml minilang to groovy

2020-03-17 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-10948:
-

Reopening, there is a bug with loadCurrencyDimension in 
DimensionServices.groovy. It shows when running quickInitDataWarehouse. 


{noformat}
2020-03-16 11:24:48,265 |jsse-nio-8443-exec-6 |TransactionUtil   
|W| Calling transaction setRollbackOnly; this stack trace shows where this is 
happening:
java.lang.Exception: rollback called in Entity Engine SQLProcessor
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:358)
 [main/:?]
at 
org.apache.ofbiz.entity.jdbc.SQLProcessor.rollback(SQLProcessor.java:185) 
[main/:?]
at 
org.apache.ofbiz.entity.datasource.GenericDAO.insert(GenericDAO.java:112) 
[main/:?]
at 
org.apache.ofbiz.entity.datasource.GenericHelperDAO.create(GenericHelperDAO.java:67)
 [main/:?]
at 
org.apache.ofbiz.entity.GenericDelegator.create(GenericDelegator.java:855) 
[main/:?]
at org.apache.ofbiz.entity.GenericValue.create(GenericValue.java:76) 
[main/:?]
at org.apache.ofbiz.entity.GenericValue$create$0.call(Unknown Source) 
[main/:?]
at 
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47)
 [groovy-2.5.8.jar:2.5.8]
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115)
 [groovy-2.5.8.jar:2.5.8]
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:119)
 [groovy-2.5.8.jar:2.5.8]
at DimensionServices.loadCurrencyDimension(DimensionServices.groovy:93) 
[script:?]
[...]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_202]
2020-03-16 11:24:48,274 |jsse-nio-8443-exec-6 |GenericDelegator  
|E| Failure in create operation for entity [CurrencyDimension]: 
org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
[GenericEntity:CurrencyDi
mension][createdStamp,2020-03-16 
11:24:48.255(java.sql.Timestamp)][createdTxStamp,2020-03-16 
11:24:42.085(java.sql.Timestamp)][currencyId,CRC(java.lang.String)][description,Costa
 Rica Colon(java.lang.String)][lastUpdatedStamp,2020-03-16
11:24:48.255(java.sql.Timestamp)][lastUpdatedTxStamp,2020-03-16 
11:24:42.085(java.sql.Timestamp)] (SQL Exception while executing the 
following:INSERT INTO OFBIZ.CURRENCY_DIMENSION (DIMENSION_ID, CURRENCY_ID, 
DESCRIPTION, LAST_UPDATED_STA
MP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, 
?, ?, ?) (Column 'DIMENSION_ID'  cannot accept a NULL value.)). Rolling back 
transaction.
{noformat}

The problem is this Minilang expression is missing in DimensionServices.groovy:
{code:xml}

{code}

Then the sepcial types defined in BiTypeData:
{code:xml}


{code}
are an issue.

Adding 

{code:java}
delegator.setNextSeqId(currencyDim)
{code}

Is enough. The issue does not exist for the other special types:
{code:xml}





{code}

> Convert DimensionServices.xml minilang to groovy
> 
>
> Key: OFBIZ-10948
> URL: https://issues.apache.org/jira/browse/OFBIZ-10948
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Priya Sharma
>Priority: Major
>  Labels: Minilang, dimension, dwh, groovy,, services
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10948-updated.patch, OFBIZ-10948.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> With the purpose to deprecate mini-lang OFBIZ-9350,  convert 
> DimensionServices.xml



--
This message was sent by Atlassian Jira
(v8.3.4#803005)