[jira] [Commented] (OFBIZ-11638) Convert all RequirementCustRequest related CRUD services from simple to entity-auto
[ https://issues.apache.org/jira/browse/OFBIZ-11638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101388#comment-17101388 ] ASF subversion and git services commented on OFBIZ-11638: - Commit 112a5929e91ae85b34ac017dfa5420ee67c0f27a in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=112a592 ] Improved: Converted all RequirementCustRequest related CRUD services from simple to entity-auto (#102) (OFBIZ-11638) Also, renamed associatedRequirementWithRequestItem to proper name and corrected occurences including tests. > Convert all RequirementCustRequest related CRUD services from simple to > entity-auto > --- > > Key: OFBIZ-11638 > URL: https://issues.apache.org/jira/browse/OFBIZ-11638 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11638) Convert all RequirementCustRequest related CRUD services from simple to entity-auto
[ https://issues.apache.org/jira/browse/OFBIZ-11638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11638. - Fix Version/s: Upcoming Branch Resolution: Implemented > Convert all RequirementCustRequest related CRUD services from simple to > entity-auto > --- > > Key: OFBIZ-11638 > URL: https://issues.apache.org/jira/browse/OFBIZ-11638 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #117: Improved: Update Data Sets
sonarcloud[bot] commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-624825445 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #117: Improved: Update Data Sets
PierreSmits opened a new pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117 (OFBIZ-6976)(OFBIZ-11649)(OFBIZ-11650)(OFBIZ-11655) added: party data into PartyComponentData from other components removed: party data from Accounting component removed: party data from Order component removed: party data from Marketing plugin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-11650) Improve Order Component data set(s)
[ https://issues.apache.org/jira/browse/OFBIZ-11650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-11650: Assignee: Pierre Smits > Improve Order Component data set(s) > --- > > Key: OFBIZ-11650 > URL: https://issues.apache.org/jira/browse/OFBIZ-11650 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: configuration, data, demo, test > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11649) Improve Party Component data set(s)
[ https://issues.apache.org/jira/browse/OFBIZ-11649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-11649: Assignee: Pierre Smits > Improve Party Component data set(s) > --- > > Key: OFBIZ-11649 > URL: https://issues.apache.org/jira/browse/OFBIZ-11649 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: configuration, data, demo, test > > See description in parent ticket -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11655) Improve Marketing plugin data set(s)
[ https://issues.apache.org/jira/browse/OFBIZ-11655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-11655: Assignee: Pierre Smits > Improve Marketing plugin data set(s) > > > Key: OFBIZ-11655 > URL: https://issues.apache.org/jira/browse/OFBIZ-11655 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: configuration, data, demo, test > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11648) Improve Product Component data sets
[ https://issues.apache.org/jira/browse/OFBIZ-11648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-11648: Assignee: Pierre Smits > Improve Product Component data sets > --- > > Key: OFBIZ-11648 > URL: https://issues.apache.org/jira/browse/OFBIZ-11648 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: data, demo, test > > See also description in parent ticket. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11043) DemoLeadOwner and DemoLeadOwner1 have too much rigths
[
https://issues.apache.org/jira/browse/OFBIZ-11043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-11043:
-
Labels: configuration data demo test (was: configuration data)
> DemoLeadOwner and DemoLeadOwner1 have too much rigths
> -
>
> Key: OFBIZ-11043
> URL: https://issues.apache.org/jira/browse/OFBIZ-11043
> Project: OFBiz
> Issue Type: Improvement
> Components: marketing
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Major
> Labels: configuration, data, demo, test
> Fix For: Upcoming Branch
>
>
> Since pre Apache era we have those 2 FIXMEs:
> {code:xml}
>
> fromDate="2001-05-13 00:00:00.000"/>
>
> fromDate="2001-05-13 00:00:00.000"/>
> {code}
> I even wonder what the goal of these users is.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11644) Convert all TechDataCalendarWeek related CRUD services from simple to entity-auto
[ https://issues.apache.org/jira/browse/OFBIZ-11644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11644. - Fix Version/s: Upcoming Branch Resolution: Implemented > Convert all TechDataCalendarWeek related CRUD services from simple to > entity-auto > - > > Key: OFBIZ-11644 > URL: https://issues.apache.org/jira/browse/OFBIZ-11644 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11661) Upgrade Gradle and Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100801#comment-17100801 ] James Yong commented on OFBIZ-11661: Hi [~jleroux], Thanks for the check and fix. > Upgrade Gradle and Groovy > - > > Key: OFBIZ-11661 > URL: https://issues.apache.org/jira/browse/OFBIZ-11661 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Current Gradle version used in OFBiz trunk is 5.0. > Propose to update to Gradle 6.3 which is the current stable version. > Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is > 2.5.8. > Suggest to upgrade Groovy to 2.5.11 which is the current stable version. > For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3 > --distribution-type=bin > For Groovy upgrade, I updated the build.gradle with the new Groovy version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11644) Convert all TechDataCalendarWeek related CRUD services from simple to entity-auto
[ https://issues.apache.org/jira/browse/OFBIZ-11644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100802#comment-17100802 ] ASF subversion and git services commented on OFBIZ-11644: - Commit 4cb9fc7e8090cd2123f09986bbe25badcf0570f0 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4cb9fc7 ] Improved: Converted all TechDataCalendarWeek related CRUD services from simple to entity-auto (#109) (OFBIZ-11644) > Convert all TechDataCalendarWeek related CRUD services from simple to > entity-auto > - > > Key: OFBIZ-11644 > URL: https://issues.apache.org/jira/browse/OFBIZ-11644 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11661) Upgrade Gradle and Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11661. --- Resolution: Implemented > Upgrade Gradle and Groovy > - > > Key: OFBIZ-11661 > URL: https://issues.apache.org/jira/browse/OFBIZ-11661 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Current Gradle version used in OFBiz trunk is 5.0. > Propose to update to Gradle 6.3 which is the current stable version. > Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is > 2.5.8. > Suggest to upgrade Groovy to 2.5.11 which is the current stable version. > For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3 > --distribution-type=bin > For Groovy upgrade, I updated the build.gradle with the new Groovy version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11661) Upgrade Gradle and Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100787#comment-17100787 ] ASF subversion and git services commented on OFBIZ-11661: - Commit 5ff7852e506f342cad63ec65f86910ea1c15d9bc in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5ff7852 ] Improvement: Upgrade Gradle and Groovy (OFBIZ-11661) Increases tasks.checkstyleMain.maxErrors from 36894 to 37094 Too much detected after Gradle upgrade to fix manually The checkstyle plugin is automatically updated with the Gradle version (you don't define a checkstyle plugin version) > Upgrade Gradle and Groovy > - > > Key: OFBIZ-11661 > URL: https://issues.apache.org/jira/browse/OFBIZ-11661 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Current Gradle version used in OFBiz trunk is 5.0. > Propose to update to Gradle 6.3 which is the current stable version. > Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is > 2.5.8. > Suggest to upgrade Groovy to 2.5.11 which is the current stable version. > For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3 > --distribution-type=bin > For Groovy upgrade, I updated the build.gradle with the new Groovy version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11661) Upgrade Gradle and Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100785#comment-17100785 ] ASF subversion and git services commented on OFBIZ-11661: - Commit 00ec6c677b7948178e1232b3d463ce49b69d62eb in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=00ec6c6 ] Improvement: Upgrade Gradle and Groovy (OFBIZ-11661) Fixes a known issue with config/checkstyle/checkstyle.xml: TreeWalker is not allowed as a parent of LineLength Please review 'Parent Module' section for this Check in web documentation if Check is standard > Upgrade Gradle and Groovy > - > > Key: OFBIZ-11661 > URL: https://issues.apache.org/jira/browse/OFBIZ-11661 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Current Gradle version used in OFBiz trunk is 5.0. > Propose to update to Gradle 6.3 which is the current stable version. > Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is > 2.5.8. > Suggest to upgrade Groovy to 2.5.11 which is the current stable version. > For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3 > --distribution-type=bin > For Groovy upgrade, I updated the build.gradle with the new Groovy version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11661) Upgrade Gradle and Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100780#comment-17100780
]
Jacques Le Roux edited comment on OFBIZ-11661 at 5/6/20, 1:02 PM:
--
OK this remembers something I already fought with:
{noformat}
gradlew check --stacktrace
[...]
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot
initialize module TreeWalker - TreeWalker is not allowed as a parent of
LineLength Please review 'Parent Module' section for this Check in web
documentation if
eck is standard.
at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:472)
at
com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:198)
at
com.puppycrawl.tools.checkstyle.ant.CheckstyleAntTask.createRootModule(CheckstyleAntTask.java:402)
... 111 more
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: TreeWalker
is not allowed as a parent of LineLength Please review 'Parent Module' section
for this Check in web documentation if Check is standard.
at
com.puppycrawl.tools.checkstyle.TreeWalker.setupChild(TreeWalker.java:147)
at
com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:198)
at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:467)
... 113 more
{noformat}
Looking at it...
was (Author: jacques.le.roux):
OK this remembers something I already fight with:
{noformat}
gradlew check --stacktrace
[...]
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot
initialize module TreeWalker - TreeWalker is not allowed as a parent of
LineLength Please review 'Parent Module' section for this Check in web
documentation if
eck is standard.
at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:472)
at
com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:198)
at
com.puppycrawl.tools.checkstyle.ant.CheckstyleAntTask.createRootModule(CheckstyleAntTask.java:402)
... 111 more
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: TreeWalker
is not allowed as a parent of LineLength Please review 'Parent Module' section
for this Check in web documentation if Check is standard.
at
com.puppycrawl.tools.checkstyle.TreeWalker.setupChild(TreeWalker.java:147)
at
com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:198)
at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:467)
... 113 more
{noformat}
Looking at it...
> Upgrade Gradle and Groovy
> -
>
> Key: OFBIZ-11661
> URL: https://issues.apache.org/jira/browse/OFBIZ-11661
> Project: OFBiz
> Issue Type: Improvement
> Components: Gradle
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Current Gradle version used in OFBiz trunk is 5.0.
> Propose to update to Gradle 6.3 which is the current stable version.
> Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is
> 2.5.8.
> Suggest to upgrade Groovy to 2.5.11 which is the current stable version.
> For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3
> --distribution-type=bin
> For Groovy upgrade, I updated the build.gradle with the new Groovy version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11661) Upgrade Gradle and Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11661: --- Assignee: Jacques Le Roux (was: James Yong) > Upgrade Gradle and Groovy > - > > Key: OFBIZ-11661 > URL: https://issues.apache.org/jira/browse/OFBIZ-11661 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: James Yong >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > Current Gradle version used in OFBiz trunk is 5.0. > Propose to update to Gradle 6.3 which is the current stable version. > Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is > 2.5.8. > Suggest to upgrade Groovy to 2.5.11 which is the current stable version. > For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3 > --distribution-type=bin > For Groovy upgrade, I updated the build.gradle with the new Groovy version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11661) Upgrade Gradle and Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100780#comment-17100780
]
Jacques Le Roux commented on OFBIZ-11661:
-
OK this remembers something I already fight with:
{noformat}
gradlew check --stacktrace
[...]
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot
initialize module TreeWalker - TreeWalker is not allowed as a parent of
LineLength Please review 'Parent Module' section for this Check in web
documentation if
eck is standard.
at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:472)
at
com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:198)
at
com.puppycrawl.tools.checkstyle.ant.CheckstyleAntTask.createRootModule(CheckstyleAntTask.java:402)
... 111 more
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: TreeWalker
is not allowed as a parent of LineLength Please review 'Parent Module' section
for this Check in web documentation if Check is standard.
at
com.puppycrawl.tools.checkstyle.TreeWalker.setupChild(TreeWalker.java:147)
at
com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:198)
at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:467)
... 113 more
{noformat}
Looking at it...
> Upgrade Gradle and Groovy
> -
>
> Key: OFBIZ-11661
> URL: https://issues.apache.org/jira/browse/OFBIZ-11661
> Project: OFBiz
> Issue Type: Improvement
> Components: Gradle
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Current Gradle version used in OFBiz trunk is 5.0.
> Propose to update to Gradle 6.3 which is the current stable version.
> Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is
> 2.5.8.
> Suggest to upgrade Groovy to 2.5.11 which is the current stable version.
> For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3
> --distribution-type=bin
> For Groovy upgrade, I updated the build.gradle with the new Groovy version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11661) Upgrade Gradle and Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100777#comment-17100777
]
Jacques Le Roux commented on OFBIZ-11661:
-
Hi James,
We have an issue with the Gradle check task
https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1325/steps/shell_2/logs/stdio
I reproduce locally:
{noformat}
C:\projectsASF\Git\ofbiz-framework>g check
C:\projectsASF\Git\ofbiz-framework>gradlew check
Downloading https://services.gradle.org/distributions/gradle-6.3-bin.zip
.
Welcome to Gradle 6.3!
Here are the highlights of this release:
- Java 14 support
- Improved error messages for unexpected failures
For more details see https://docs.gradle.org/6.3/release-notes.html
Starting a Gradle Daemon (subsequent builds will be faster)
> Configure project :
You are using one or more deprecated Asciidoctor Gradle plugin features. To
help with migration run with --warning-mode=all.
> Task :compileJava
> Task :compileGroovy
> Task :processResources
> Task :classes
> Task :checkstyleMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Unable to create Root Module: config
> {C:\projectsASF\Git\ofbiz-framework\config\checkstyle\checkstyle.xml},
> classpath
> {C:\projectsASF\Git\ofbiz-framework\build\classes\java\main;C:\projectsASF\Git\ofbiz-framework\build\classes\groovy\m
ain;C:\projectsASF\Git\ofbiz-framework\build\resources\main;Z:\Gradle\caches\modules-2\files-2.1\org.apache.tika\tika-parsers\1.24\282c0ecd31cb235f7d96bef18b8cdcb56573a195\tika-parsers-1.24.jar;Z:\Gradle\caches\modules-2\files-2.1\org.ow
{noformat}
Same when runnin build task which chains check task. I did not find yet a
solution...
> Upgrade Gradle and Groovy
> -
>
> Key: OFBIZ-11661
> URL: https://issues.apache.org/jira/browse/OFBIZ-11661
> Project: OFBiz
> Issue Type: Improvement
> Components: Gradle
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Current Gradle version used in OFBiz trunk is 5.0.
> Propose to update to Gradle 6.3 which is the current stable version.
> Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is
> 2.5.8.
> Suggest to upgrade Groovy to 2.5.11 which is the current stable version.
> For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3
> --distribution-type=bin
> For Groovy upgrade, I updated the build.gradle with the new Groovy version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11661) Upgrade Gradle and Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-11661: - > Upgrade Gradle and Groovy > - > > Key: OFBIZ-11661 > URL: https://issues.apache.org/jira/browse/OFBIZ-11661 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > Current Gradle version used in OFBiz trunk is 5.0. > Propose to update to Gradle 6.3 which is the current stable version. > Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is > 2.5.8. > Suggest to upgrade Groovy to 2.5.11 which is the current stable version. > For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3 > --distribution-type=bin > For Groovy upgrade, I updated the build.gradle with the new Groovy version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11661) Upgrade Gradle and Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11661: Fix Version/s: (was: Trunk) Upcoming Branch Affects Version/s: (was: Upcoming Branch) Trunk > Upgrade Gradle and Groovy > - > > Key: OFBIZ-11661 > URL: https://issues.apache.org/jira/browse/OFBIZ-11661 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > Current Gradle version used in OFBiz trunk is 5.0. > Propose to update to Gradle 6.3 which is the current stable version. > Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is > 2.5.8. > Suggest to upgrade Groovy to 2.5.11 which is the current stable version. > For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3 > --distribution-type=bin > For Groovy upgrade, I updated the build.gradle with the new Groovy version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11661) Upgrade Gradle and Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong closed OFBIZ-11661. -- Assignee: James Yong Resolution: Implemented > Upgrade Gradle and Groovy > - > > Key: OFBIZ-11661 > URL: https://issues.apache.org/jira/browse/OFBIZ-11661 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > > Current Gradle version used in OFBiz trunk is 5.0. > Propose to update to Gradle 6.3 which is the current stable version. > Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is > 2.5.8. > Suggest to upgrade Groovy to 2.5.11 which is the current stable version. > For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3 > --distribution-type=bin > For Groovy upgrade, I updated the build.gradle with the new Groovy version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11661) Upgrade Gradle and Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100766#comment-17100766 ] James Yong commented on OFBIZ-11661: Some prior discussion at [https://lists.apache.org/thread.html/%3cpony-1f120a9c0f9db36b405ee0b2fc2dd9d09df46c43-a4dc7b40171f2560e3d3aa94e4c13a3acce86...@dev.ofbiz.apache.org%3E] > Upgrade Gradle and Groovy > - > > Key: OFBIZ-11661 > URL: https://issues.apache.org/jira/browse/OFBIZ-11661 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Upcoming Branch >Reporter: James Yong >Priority: Minor > Fix For: Trunk > > > Current Gradle version used in OFBiz trunk is 5.0. > Propose to update to Gradle 6.3 which is the current stable version. > Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is > 2.5.8. > Suggest to upgrade Groovy to 2.5.11 which is the current stable version. > For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3 > --distribution-type=bin > For Groovy upgrade, I updated the build.gradle with the new Groovy version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11661) Upgrade Gradle and Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100753#comment-17100753 ] ASF subversion and git services commented on OFBIZ-11661: - Commit ff219500248373fafb39ee57f12f30147df318a7 in ofbiz-framework's branch refs/heads/trunk from James Yong [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ff21950 ] Improvement: Upgrade Gradle and Groovy (OFBIZ-11661) Upgrade to Gradle 6.3 and Groovy 2.5.11. Both are current stable versions. > Upgrade Gradle and Groovy > - > > Key: OFBIZ-11661 > URL: https://issues.apache.org/jira/browse/OFBIZ-11661 > Project: OFBiz > Issue Type: Improvement > Components: Gradle >Affects Versions: Upcoming Branch >Reporter: James Yong >Priority: Minor > Fix For: Trunk > > > Current Gradle version used in OFBiz trunk is 5.0. > Propose to update to Gradle 6.3 which is the current stable version. > Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is > 2.5.8. > Suggest to upgrade Groovy to 2.5.11 which is the current stable version. > For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3 > --distribution-type=bin > For Groovy upgrade, I updated the build.gradle with the new Groovy version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-3169) Implementation of Budget functionality.
[ https://issues.apache.org/jira/browse/OFBIZ-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-3169. --- Resolution: Implemented Not assigning a Fix Version, as such info is missing in the ticket. > Implementation of Budget functionality. > --- > > Key: OFBIZ-3169 > URL: https://issues.apache.org/jira/browse/OFBIZ-3169 > Project: OFBiz > Issue Type: New Feature > Components: accounting >Affects Versions: Release Branch 13.07, Release Branch 14.12, Release > Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch > 17.12, Trunk >Reporter: ashish tiwari >Priority: Minor > Labels: Forecasting, SFA, budget > > This is regarding Budget functionality implementation in OFBiz. I have found > that enitities related to budget functionality are present in OFbiz but I > was not able to find the functional implementation for the same. So I needed > to confirm is this functionality implemented or not. > In case it is not I am interested in implementing the same in OFbiz. I have > found a general flow of the budget process and i am mentioning the steps in > this mail. So please go throurgh the steps and you are requested to give in > your comments regarding the same. > 1. Request for the budget is generated by the Deptartment. > 2. Budget request is submitted to board of directors/higher officials for > approval. > 3. Budget request is either approved or rejected. > 4. If the budget is approved it is created as annual budget(Total cost in the > budget is alloted to Department). > 5. Now item wise budget is allocated to different items by Department Head. > 6. Profits achieved can be calculated on the basis of fiscal years for a > budget by compairing the proposed budget and the actual budget. > 7. All the data regarding the budgets created are maintained. > Waiting for your comments. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] surajkhurana commented on a change in pull request #113: Improved: Convert EntitySyncServices.xml mini-lang to groovy (OFBIZ-11660)
surajkhurana commented on a change in pull request #113: URL: https://github.com/apache/ofbiz-framework/pull/113#discussion_r420732381 ## File path: framework/entityext/servicedef/services.xml ## @@ -447,7 +447,7 @@ under the License. + location="component://entityext/groovyScripts/EntitySyncServices.groovy" invoke="entitySyncPermissionCheck"> Review comment: IMO, this can be made simpler using: After this, you didn't need a groovy method. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] surajkhurana commented on a change in pull request #113: Improved: Convert EntitySyncServices.xml mini-lang to groovy (OFBIZ-11660)
surajkhurana commented on a change in pull request #113: URL: https://github.com/apache/ofbiz-framework/pull/113#discussion_r420732381 ## File path: framework/entityext/servicedef/services.xml ## @@ -447,7 +447,7 @@ under the License. + location="component://entityext/groovyScripts/EntitySyncServices.groovy" invoke="entitySyncPermissionCheck"> Review comment: IMO, this can be made simpler using: ``` ``` After this, you didn't need a groovy method. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11652) Improve Accounting Component data set(s)
[ https://issues.apache.org/jira/browse/OFBIZ-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100717#comment-17100717 ] ASF subversion and git services commented on OFBIZ-11652: - Commit a58d78a79efa54310d2d239d41fcff698be52608 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a58d78a ] Improved: Accounting seed data (OFBIZ-11652) (#116) * Improved: Accounting Component - improve seed data (OFBIZ-11652) Adding role type records relating to budget entities * Improved: Accounting Component - improve seed data (OFBIZ-11652) Adding role type records relating to budget entities > Improve Accounting Component data set(s) > > > Key: OFBIZ-11652 > URL: https://issues.apache.org/jira/browse/OFBIZ-11652 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: configuration, data, demo, test > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11652) Improve Accounting Component data set(s)
[ https://issues.apache.org/jira/browse/OFBIZ-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100719#comment-17100719 ] ASF subversion and git services commented on OFBIZ-11652: - Commit a58d78a79efa54310d2d239d41fcff698be52608 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a58d78a ] Improved: Accounting seed data (OFBIZ-11652) (#116) * Improved: Accounting Component - improve seed data (OFBIZ-11652) Adding role type records relating to budget entities * Improved: Accounting Component - improve seed data (OFBIZ-11652) Adding role type records relating to budget entities > Improve Accounting Component data set(s) > > > Key: OFBIZ-11652 > URL: https://issues.apache.org/jira/browse/OFBIZ-11652 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: configuration, data, demo, test > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11664) Convert all ElectronicText related CRUD services from simple to entity-auto
Suraj Khurana created OFBIZ-11664: - Summary: Convert all ElectronicText related CRUD services from simple to entity-auto Key: OFBIZ-11664 URL: https://issues.apache.org/jira/browse/OFBIZ-11664 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana There are two separate variations available of service definition, we can convert createElectronicTextForm and updateElectronicTextForm from simple to entity-auto -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11652) Improve Accounting Component data set(s)
[ https://issues.apache.org/jira/browse/OFBIZ-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100718#comment-17100718 ] ASF subversion and git services commented on OFBIZ-11652: - Commit a58d78a79efa54310d2d239d41fcff698be52608 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a58d78a ] Improved: Accounting seed data (OFBIZ-11652) (#116) * Improved: Accounting Component - improve seed data (OFBIZ-11652) Adding role type records relating to budget entities * Improved: Accounting Component - improve seed data (OFBIZ-11652) Adding role type records relating to budget entities > Improve Accounting Component data set(s) > > > Key: OFBIZ-11652 > URL: https://issues.apache.org/jira/browse/OFBIZ-11652 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: configuration, data, demo, test > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11663) Convert all CustRequestItem related CRUD services from simple to entity-auto
Suraj Khurana created OFBIZ-11663: - Summary: Convert all CustRequestItem related CRUD services from simple to entity-auto Key: OFBIZ-11663 URL: https://issues.apache.org/jira/browse/OFBIZ-11663 Project: OFBiz Issue Type: Sub-task Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11662) Convert all GlReconciliationEntry related CRUD services from simple to entity-auto
Suraj Khurana created OFBIZ-11662: - Summary: Convert all GlReconciliationEntry related CRUD services from simple to entity-auto Key: OFBIZ-11662 URL: https://issues.apache.org/jira/browse/OFBIZ-11662 Project: OFBiz Issue Type: Sub-task Components: accounting Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11661) Upgrade Gradle and Groovy
James Yong created OFBIZ-11661: -- Summary: Upgrade Gradle and Groovy Key: OFBIZ-11661 URL: https://issues.apache.org/jira/browse/OFBIZ-11661 Project: OFBiz Issue Type: Improvement Components: Gradle Affects Versions: Upcoming Branch Reporter: James Yong Fix For: Trunk Current Gradle version used in OFBiz trunk is 5.0. Propose to update to Gradle 6.3 which is the current stable version. Gradle 6.3 requires groovy 2.5.10, but Groovy version used in OFBiz trunk is 2.5.8. Suggest to upgrade Groovy to 2.5.11 which is the current stable version. For Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.3 --distribution-type=bin For Groovy upgrade, I updated the build.gradle with the new Groovy version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #116: Improved: Accounting seed data (OFBIZ-11652)
sonarcloud[bot] commented on pull request #116: URL: https://github.com/apache/ofbiz-framework/pull/116#issuecomment-624592817 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=116=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=116=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=116=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=116=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=116=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=116=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=116=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=116=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=116=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=116=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=116=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=116) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=116=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=116=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #115: IKm
sonarcloud[bot] commented on pull request #115: URL: https://github.com/apache/ofbiz-framework/pull/115#issuecomment-624591670 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=115=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=115=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=115=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=115=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=115=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=115=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=115=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=115=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=115=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=115=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=115=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=115) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=115=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=115=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #116: Improved: Accounting seed data (OFBIZ-11652)
PierreSmits opened a new pull request #116: URL: https://github.com/apache/ofbiz-framework/pull/116 (OFBIZ-11652) Adding (and correcting) role type records relating to budget entities This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #115: IKm
PierreSmits opened a new pull request #115: URL: https://github.com/apache/ofbiz-framework/pull/115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11652) Improve Accounting Component data set(s)
[ https://issues.apache.org/jira/browse/OFBIZ-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100669#comment-17100669 ] ASF subversion and git services commented on OFBIZ-11652: - Commit a7328da044be3c03e41388232b7390a7727932de in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a7328da ] Improved: Accounting Component - improve seed data (OFBIZ-11652) Adding role type records relating to budget entities > Improve Accounting Component data set(s) > > > Key: OFBIZ-11652 > URL: https://issues.apache.org/jira/browse/OFBIZ-11652 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: configuration, data, demo, test > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #114: Improved: Accounting Component - improve seed data (OFBIZ-11652)
sonarcloud[bot] commented on pull request #114: URL: https://github.com/apache/ofbiz-framework/pull/114#issuecomment-624575935 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=114=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=114=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=114=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=114=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=114=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=114=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=114=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=114=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=114=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=114=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=114=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=114) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=114=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=114=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #114: Improved: Accounting Component - improve seed data (OFBIZ-11652)
PierreSmits opened a new pull request #114: URL: https://github.com/apache/ofbiz-framework/pull/114 (OFBIZ-11652) Adding role type records relating to budget entities This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-11652) Improve Accounting Component data set(s)
[ https://issues.apache.org/jira/browse/OFBIZ-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits reassigned OFBIZ-11652: Assignee: Pierre Smits > Improve Accounting Component data set(s) > > > Key: OFBIZ-11652 > URL: https://issues.apache.org/jira/browse/OFBIZ-11652 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: configuration, data, demo, test > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11043) DemoLeadOwner and DemoLeadOwner1 have too much rigths
[
https://issues.apache.org/jira/browse/OFBIZ-11043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-11043:
-
Labels: configuration data (was: Demo)
> DemoLeadOwner and DemoLeadOwner1 have too much rigths
> -
>
> Key: OFBIZ-11043
> URL: https://issues.apache.org/jira/browse/OFBIZ-11043
> Project: OFBiz
> Issue Type: Improvement
> Components: marketing
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Pierre Smits
>Priority: Major
> Labels: configuration, data
> Fix For: Upcoming Branch
>
>
> Since pre Apache era we have those 2 FIXMEs:
> {code:xml}
>
> fromDate="2001-05-13 00:00:00.000"/>
>
> fromDate="2001-05-13 00:00:00.000"/>
> {code}
> I even wonder what the goal of these users is.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-6976) Updating data sets
[
https://issues.apache.org/jira/browse/OFBIZ-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-6976:
Description:
This is a placeholder issue.
Having correct data shipped with OFBiz is key to not only
# have a good operational state (meaning adopters can work with OFBiz out of
the box)
# have a good data set for demonstration purposes
# have a good data set to enable unit, system integration and acceptance testing
Re aspect 1:
This encompasses all security, system property and other seed data sets
Re aspect 2:
This encompasses all data records in the various DemoData.xml files. This kind
of data needs to be coherent from the perspective of the main internal
organisation (or the legal demo party) that operates the OFBiz implementation.
Re aspect 3:
The data set for this aspect encompasses all data under aspect 1 and 2.
With a good data set for demonstration purposes it is easier for potential
adopters (and their influencers) to see the added value of implementing OFBiz
in their company/organisation, while at the same time it helps developers to
understand the coherence between widgets, templates, services, functions and
the data counter parts.
Demo data sets should be grouped in accordance to the component load order (as
defined in e.g. component-load.xml, see links below). The first appearance of a
data record of the demo kind should also (as much as possible) be in accordance
with where the related entity is defined and where the first appearance of
related seed data records are defined. For guidance see the entity reference
(per link below)
Example 1:
The ProductStore entity is defined in the entity model for the Product
component (the product-entitymodel.xml).
Thus any new demo record regarding this ProductStore entity should first appear
in the ProductDemoData.xml file.
Example 2:
Following record is defined in WorkEffortTypeData.xml
{code:java}
{code}
Thus any first appearance of a demo record for the WorkEffort entity with the
defined workEffortTypeId="PROJECT" should appear in the WorkEffortDemoData.xml
file
With the above we minimise the risk of duplication and dependency mismatches
was:
This is a placeholder issue.
Having correct data shipped with OFBiz is key to not only
# have a good operational state (meaning adopters can work with OFBiz out of
the box)
# have a good data set for demonstration purposes
# have a good data set to enable unit, system integration and acceptance testing
Re aspect 1:
This encompasses all security, system property and other seed data sets
Re aspect 2:
This encompasses all data records in the various DemoData.xml files. This kind
of data needs to be coherent from the perspective of the main internal
organisation (or the legal demo party) that operates the OFBiz implementation.
Re aspect 3:
The data set for this aspect encompasses all data under aspect 1 and 2.
With a good data set for demonstration purposes it is easier for potential
adopters (and their influencers) to see the added value of implementing OFBiz
in their company/organisation, while at the same time it helps developers to
understand the coherence between widgets, templates, services, functions and
the data counter parts.
Demo data sets should be grouped in accordance to the component load order (as
defined in e.g. component-load.xml, see links below). The first appearance of a
data record of the demo kind should also (as much as possible) be in accordance
with where the related entity is defined and where the first appearance of
related seed data records are defined.
Example 1:
The ProductStore entity is defined in the entity model for the Product
component (the product-entitymodel.xml).
Thus any new demo record regarding this ProductStore entity should first appear
in the ProductDemoData.xml file.
Example 2:
Following record is defined in WorkEffortTypeData.xml
{code:java}
{code}
Thus any first appearance of a demo record for the WorkEffort entity with the
defined workEffortTypeId="PROJECT" should appear in the WorkEffortDemoData.xml
file
With the above we minimise the risk of duplication and dependency mismatches
> Updating data sets
> --
>
> Key: OFBIZ-6976
> URL: https://issues.apache.org/jira/browse/OFBIZ-6976
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Labels: Demo, configuration, data, test
>
> This is a placeholder issue.
> Having correct data shipped with OFBiz is key to not only
> # have a good operational state (meaning adopters can work with OFBiz out of
> the box)
> # have a good data set for demonstration purposes
> # have a good data set to enable unit, system
[jira] [Updated] (OFBIZ-4674) Human Resource Manager Tree
[ https://issues.apache.org/jira/browse/OFBIZ-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-4674: Labels: treemap (was: ) > Human Resource Manager Tree > --- > > Key: OFBIZ-4674 > URL: https://issues.apache.org/jira/browse/OFBIZ-4674 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Trunk > Environment: Latest Trunk >Reporter: Jacopo Cappellato >Assignee: Ashish Vijaywargiya >Priority: Major > Labels: treemap > Attachments: ASF.LICENSE.NOT.GRANTED--HR Tree Before Sample > Accounting Data Loaded.jpg, ASF.LICENSE.NOT.GRANTED--HR Tree With Sample > Accounting Data Loaded.jpg, HumanResAcctData.xml, OFBIZ ISSUES-Excel > Sheet_V1.xlsx > > > In the latest trunk the tree off the HR Main menu has some questionable > behavior: > # The developer and test persons created in the Accounting application > behave like organizations. > They display the organization icon and context menu. > For example: > Go to Human Resources Main > In the tree open the nodes Development Department > Development Team 1 > Right Click on any of the children Developer1-3. > Developers 1-3 are persons but the context menu presents the functions for > an organization (Add Employee Position / Add Internal Organization). > The Testing entities have the same behavior. > See attached AcctHRBefore.jpg > Expected parties that are persons would not have context functions. > Expected Accounting entities to display icons and behavior in the manner of > the Programmer and Demo Employee created by HumanResDemoData.xml. > For example load the attached HumanResAcctData.xml using Webtools > Entity > Import > Absolute Filename or URL to see the expected result as shown in > attache AcctHRAfter.jpg > # The context menu Add Internal Organization allows duplicate organization > entities in the tree. > This by itself does not make business sense and it permits the creation of > recursive structures by selecting the name of the parent for the child. > For example: > Go to Human Resources Main In the tree right click on "Development > department" > In the context menu select Add Internal Organization In the drop down list > select "DEV" Click Create After refresh open the "Development department". > It now contains a child "Development department" which has a child > "Development department" etc etc. > It is also possible to create recursion by adding an organizations parent as > a child. > Substitute party_id "Company" for "DEV" in the above exercise. > Expected unique nodes > # Selecting Add Employee Position or Add Person from the context menu opens > the corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process
[
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100525#comment-17100525
]
Jacques Le Roux commented on OFBIZ-11204:
-
Hi Suraj,
OK on my side for all supported release branches
> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11204.patch, OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2
> |GenericDelegator |E| Failure in create operation for entity
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
> (SQL Exception while executing the following:INSERT INTO
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD,
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP,
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value
> violates unique constraint "pk_service_semaphore" Detail: Key
> (service_name)=(xxx) already exists.)). Rolling back transaction.
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2
> |ServiceSemaphore |E| null
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException:
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting:
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19
>
[jira] [Commented] (OFBIZ-10975) Improve the buttons on edit credit card page
[ https://issues.apache.org/jira/browse/OFBIZ-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100507#comment-17100507 ] Sourabh Punyani commented on OFBIZ-10975: - Hello [~pawan], Thanks for reviewing the patch. I have tested the patch and it is working fine. > Improve the buttons on edit credit card page > > > Key: OFBIZ-10975 > URL: https://issues.apache.org/jira/browse/OFBIZ-10975 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Padmavati Rawat >Assignee: Pawan Verma >Priority: Major > Attachments: Buttonissue.png, OFBIZ-10975.patch, OFBIZ-10975.patch > > > Steps: > 1. Visit the demo-trunk.ofbiz.apache.org/ecommerce. > 2. Login to the system. > 3. Add Credit card details for the customer on the customer profile page. > 4. Check the Go Back and Save button after adding the credit card details. > Actual: > Go Back and Save button display twice on the header of the page, after adding > the credit card for the customer. > Expected: > The buttons should not be displayed twice after adding the credit card > details. > Please refer screenshot; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process
[
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100503#comment-17100503
]
Suraj Khurana commented on OFBIZ-11204:
---
Hello team,
We are facing this issue on release branch, can we backport?
> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11204.patch, OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2
> |GenericDelegator |E| Failure in create operation for entity
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
> (SQL Exception while executing the following:INSERT INTO
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD,
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP,
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value
> violates unique constraint "pk_service_semaphore" Detail: Key
> (service_name)=(xxx) already exists.)). Rolling back transaction.
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2
> |ServiceSemaphore |E| null
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException:
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting:
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19
>
[jira] [Closed] (OFBIZ-10538) Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity
[ https://issues.apache.org/jira/browse/OFBIZ-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-10538. --- Fix Version/s: 17.12.04 18.12.01 Resolution: Fixed Thanks, everyone for the contribution. > Promised Datetime & Current Promised Date values not getting updated in > OISGIR Entity > - > > Key: OFBIZ-10538 > URL: https://issues.apache.org/jira/browse/OFBIZ-10538 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Pawan Verma >Priority: Major > Fix For: 18.12.01, 17.12.04 > > Attachments: OFBIZ-10538.patch > > > While creating the sales order from the backend, if we set the 'Ship Before > Date' it will be stored in OrderItemShipGroup.shipByDate field and same will > be propagated to OrderItemShipGrpInvRes.promisedDateTime and > OrderItemShipGrpInvRes.currentPromisedDate fields. > > On updating the 'Ship Before Date' from the order view page later, the > promisedDateTime and currentPromisedDate get updated in OrderItemShipGroup > entity but remains the same in OrderItemShipGroupInvRes entity. > > As OrderItemShipGrpInvRes.promisedDateTime & > OrderItemShipGrpInvRes.currentPromisedDate are being used in many services > like 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity', > 'reserveProductInventory' etc., we should also update these on updating the > 'Ship Before Date' from the order overview page. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10538) Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity
[ https://issues.apache.org/jira/browse/OFBIZ-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100499#comment-17100499 ] ASF subversion and git services commented on OFBIZ-10538: - Commit 454230e6133445d73f24d29d5a38c34e5a5c5333 in ofbiz-framework's branch refs/heads/release17.12 from Pawan Verma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=454230e ] Fixed: Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity (OFBIZ-10538) Thanks: Deepak, Taher, Ravi, Amit, Suraj for the contribution. > Promised Datetime & Current Promised Date values not getting updated in > OISGIR Entity > - > > Key: OFBIZ-10538 > URL: https://issues.apache.org/jira/browse/OFBIZ-10538 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Pawan Verma >Priority: Major > Attachments: OFBIZ-10538.patch > > > While creating the sales order from the backend, if we set the 'Ship Before > Date' it will be stored in OrderItemShipGroup.shipByDate field and same will > be propagated to OrderItemShipGrpInvRes.promisedDateTime and > OrderItemShipGrpInvRes.currentPromisedDate fields. > > On updating the 'Ship Before Date' from the order view page later, the > promisedDateTime and currentPromisedDate get updated in OrderItemShipGroup > entity but remains the same in OrderItemShipGroupInvRes entity. > > As OrderItemShipGrpInvRes.promisedDateTime & > OrderItemShipGrpInvRes.currentPromisedDate are being used in many services > like 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity', > 'reserveProductInventory' etc., we should also update these on updating the > 'Ship Before Date' from the order overview page. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10538) Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity
[ https://issues.apache.org/jira/browse/OFBIZ-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100498#comment-17100498 ] ASF subversion and git services commented on OFBIZ-10538: - Commit ae511e474088c29883ce7c6df0d39484654d5e79 in ofbiz-framework's branch refs/heads/release18.12 from Pawan Verma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ae511e4 ] Fixed: Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity (OFBIZ-10538) Thanks: Deepak, Taher, Ravi, Amit, Suraj for the contribution. > Promised Datetime & Current Promised Date values not getting updated in > OISGIR Entity > - > > Key: OFBIZ-10538 > URL: https://issues.apache.org/jira/browse/OFBIZ-10538 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Pawan Verma >Priority: Major > Attachments: OFBIZ-10538.patch > > > While creating the sales order from the backend, if we set the 'Ship Before > Date' it will be stored in OrderItemShipGroup.shipByDate field and same will > be propagated to OrderItemShipGrpInvRes.promisedDateTime and > OrderItemShipGrpInvRes.currentPromisedDate fields. > > On updating the 'Ship Before Date' from the order view page later, the > promisedDateTime and currentPromisedDate get updated in OrderItemShipGroup > entity but remains the same in OrderItemShipGroupInvRes entity. > > As OrderItemShipGrpInvRes.promisedDateTime & > OrderItemShipGrpInvRes.currentPromisedDate are being used in many services > like 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity', > 'reserveProductInventory' etc., we should also update these on updating the > 'Ship Before Date' from the order overview page. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10538) Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity
[ https://issues.apache.org/jira/browse/OFBIZ-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100497#comment-17100497 ] ASF subversion and git services commented on OFBIZ-10538: - Commit f2165421f63d0d0847501cc5fc7ef4f2f96b8b6a in ofbiz-framework's branch refs/heads/trunk from Pawan Verma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f216542 ] Fixed: Promised Datetime & Current Promised Date values not getting updated in OISGIR Entity (OFBIZ-10538) Thanks: Deepak, Taher, Ravi, Amit, Suraj for the contribution. > Promised Datetime & Current Promised Date values not getting updated in > OISGIR Entity > - > > Key: OFBIZ-10538 > URL: https://issues.apache.org/jira/browse/OFBIZ-10538 > Project: OFBiz > Issue Type: Bug > Components: order, product >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Pawan Verma >Priority: Major > Attachments: OFBIZ-10538.patch > > > While creating the sales order from the backend, if we set the 'Ship Before > Date' it will be stored in OrderItemShipGroup.shipByDate field and same will > be propagated to OrderItemShipGrpInvRes.promisedDateTime and > OrderItemShipGrpInvRes.currentPromisedDate fields. > > On updating the 'Ship Before Date' from the order view page later, the > promisedDateTime and currentPromisedDate get updated in OrderItemShipGroup > entity but remains the same in OrderItemShipGroupInvRes entity. > > As OrderItemShipGrpInvRes.promisedDateTime & > OrderItemShipGrpInvRes.currentPromisedDate are being used in many services > like 'getOrderItemShipGroupEstimatedShipDate', 'getItemBackOrderedQuantity', > 'reserveProductInventory' etc., we should also update these on updating the > 'Ship Before Date' from the order overview page. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8522) Unit test case for service - createPartyPostalAddress
[ https://issues.apache.org/jira/browse/OFBIZ-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100494#comment-17100494 ] ASF subversion and git services commented on OFBIZ-8522: Commit d753c10265518d56167ab77c895ff31cfa969d57 in ofbiz-framework's branch refs/heads/trunk from Pawan Verma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d753c10 ] Improved: Unit test case for service - createPartyPostalAddress (#106) (OFBIZ-8522) > Unit test case for service - createPartyPostalAddress > - > > Key: OFBIZ-8522 > URL: https://issues.apache.org/jira/browse/OFBIZ-8522 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Akash Jain >Assignee: Pawan Verma >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-8522.patch > > > Unit test case for service - createPartyPostalAddress -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-8522) Unit test case for service - createPartyPostalAddress
[ https://issues.apache.org/jira/browse/OFBIZ-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-8522. -- Fix Version/s: (was: Trunk) Upcoming Branch Resolution: Implemented > Unit test case for service - createPartyPostalAddress > - > > Key: OFBIZ-8522 > URL: https://issues.apache.org/jira/browse/OFBIZ-8522 > Project: OFBiz > Issue Type: Sub-task > Components: party >Reporter: Akash Jain >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8522.patch > > > Unit test case for service - createPartyPostalAddress -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-9088) Unit test case for service - addProductCategoryToCategory
[ https://issues.apache.org/jira/browse/OFBIZ-9088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-9088. -- Fix Version/s: Upcoming Branch Resolution: Implemented > Unit test case for service - addProductCategoryToCategory > - > > Key: OFBIZ-9088 > URL: https://issues.apache.org/jira/browse/OFBIZ-9088 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-9088.patch > > > Unit test case for service - addProductCategoryToCategory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9088) Unit test case for service - addProductCategoryToCategory
[ https://issues.apache.org/jira/browse/OFBIZ-9088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100493#comment-17100493 ] ASF subversion and git services commented on OFBIZ-9088: Commit ff53e54a4ed487eed48067ab35b6faa5799b7db2 in ofbiz-framework's branch refs/heads/trunk from Pawan Verma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ff53e54 ] Improved: Groovy DSL test case for service addProductCategoryToCategory and getProductCategoryAndLimitedMembers (#111) * Improved: Groovy DSL test case for service addProductCategoryToCategory and getProductCategoryAndLimitedMembers (OFBIZ-9088) Thanks: Pradhan Yash Sharma for report and initial patch and Suraj and Jacques for the review. > Unit test case for service - addProductCategoryToCategory > - > > Key: OFBIZ-9088 > URL: https://issues.apache.org/jira/browse/OFBIZ-9088 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Pradhan Yash Sharma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-9088.patch > > > Unit test case for service - addProductCategoryToCategory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #111: Improved: Groovy DSL test case for service addProductCategoryToCategory and getProductCategoryAndLimitedMembers
sonarcloud[bot] removed a comment on pull request #111: URL: https://github.com/apache/ofbiz-framework/pull/111#issuecomment-623916620 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=111) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=111=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=111=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #111: Improved: Groovy DSL test case for service addProductCategoryToCategory and getProductCategoryAndLimitedMembers
sonarcloud[bot] commented on pull request #111: URL: https://github.com/apache/ofbiz-framework/pull/111#issuecomment-624457663 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=111=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=111) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=111=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=111=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (OFBIZ-9243) load demo data failure
[ https://issues.apache.org/jira/browse/OFBIZ-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100491#comment-17100491 ] Deepak Dixit edited comment on OFBIZ-9243 at 5/6/20, 6:01 AM: -- I think we can close this issue. was (Author: deepak.dixit): I think we can close this issue now, As we did an significant effort to move demo data in data model component. > load demo data failure > -- > > Key: OFBIZ-9243 > URL: https://issues.apache.org/jira/browse/OFBIZ-9243 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Wai >Assignee: Deepak Dixit >Priority: Major > Attachments: ofbiz-framework-buildbot gradlew loadDefault.log.txt > > > checkout latest ofbiz-framework and ofbiz-plugins > $ gradlew cleanAll build > $ gradlew loadDefault...using derby > console output... > 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer > |I| 00040 of 17229 from > file:/ofbiz-framework/plugins/webpos/data/PosSyncSettings.xml > 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer > |I| The following errors occurred in the data load: > 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer > |I| [loadData]: Error loading XML Resource > "file:/ofbiz-framework/plugins/ebay/data/DemoEbayData.xml"; Error was: A > transaction error occurred reading data > 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer > |I| [loadData]: Error loading XML Resource > "file:/ofbiz-framework/plugins/myportal/data/MyPortalDemoData.xml"; Error > was: A transaction error occurred reading data > 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer > |I| =-=-=-=-=-=-= Finished the data load with 17229 rows changed. > }} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9243) load demo data failure
[ https://issues.apache.org/jira/browse/OFBIZ-9243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100491#comment-17100491 ] Deepak Dixit commented on OFBIZ-9243: - I think we can close this issue now, As we did an significant effort to move demo data in data model component. > load demo data failure > -- > > Key: OFBIZ-9243 > URL: https://issues.apache.org/jira/browse/OFBIZ-9243 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Wai >Assignee: Deepak Dixit >Priority: Major > Attachments: ofbiz-framework-buildbot gradlew loadDefault.log.txt > > > checkout latest ofbiz-framework and ofbiz-plugins > $ gradlew cleanAll build > $ gradlew loadDefault...using derby > console output... > 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer > |I| 00040 of 17229 from > file:/ofbiz-framework/plugins/webpos/data/PosSyncSettings.xml > 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer > |I| The following errors occurred in the data load: > 2017-03-02 17:18:32,143 |main |EntityDataLoadContainer > |I| [loadData]: Error loading XML Resource > "file:/ofbiz-framework/plugins/ebay/data/DemoEbayData.xml"; Error was: A > transaction error occurred reading data > 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer > |I| [loadData]: Error loading XML Resource > "file:/ofbiz-framework/plugins/myportal/data/MyPortalDemoData.xml"; Error > was: A transaction error occurred reading data > 2017-03-02 17:18:32,144 |main |EntityDataLoadContainer > |I| =-=-=-=-=-=-= Finished the data load with 17229 rows changed. > }} -- This message was sent by Atlassian Jira (v8.3.4#803005)
