[jira] [Comment Edited] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL

2020-05-10 Thread Priya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104089#comment-17104089
 ] 

Priya Sharma edited comment on OFBIZ-11383 at 5/11/20, 5:49 AM:


Hi Jacques, I think Benjamin has already provided the updated patch with the 
changes he suggested.

Please let me know if anything else is required from my side.


was (Author: priya.sharma.9362):
Hi Jacques, I think Benjamin has already provided the updated patch with the 
changes he suggested.

So I don't think I will do any more changes to it.

> Convert createArticleContent service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11383
> URL: https://issues.apache.org/jira/browse/OFBIZ-11383
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch
>
>
> Convert createArticleContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL

2020-05-10 Thread Priya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104089#comment-17104089
 ] 

Priya Sharma commented on OFBIZ-11383:
--

Hi Jacques, I think Benjamin has already provided the updated patch with the 
changes he suggested.

So I don't think I will do any more changes to it.

> Convert createArticleContent service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11383
> URL: https://issues.apache.org/jira/browse/OFBIZ-11383
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch
>
>
> Convert createArticleContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11115) Production Run Job is not created for product type MARKETING_PKG_AUTO

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-5.
---
Resolution: Cannot Reproduce

Thanks, [~shikha.jaiswal] for the double check. I am closing as Cannot 
Reproduce.

> Production Run Job is not created for product type MARKETING_PKG_AUTO
> -
>
> Key: OFBIZ-5
> URL: https://issues.apache.org/jira/browse/OFBIZ-5
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Shikha Jaiswal
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-5-16.11.patch, OFBIZ-5.patch
>
>
> *Steps to regenerate:*
> # Create the order for product GZ-BASKET
> # Job should be created automatically for this product as it is of type 
> MARKETING_PKG_AUTO
> *Actual:*
> Job is not created and the order goes in the backorder status.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-8459) InventoryItemStatus is not updated to INV_PROMISED status while creating sales order for serialized product

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-8459:
--

Assignee: Pawan Verma

> InventoryItemStatus is not updated to INV_PROMISED status while creating 
> sales order for serialized product
> ---
>
> Key: OFBIZ-8459
> URL: https://issues.apache.org/jira/browse/OFBIZ-8459
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 14.12, Release Branch 15.12, Trunk
>Reporter: Vaibhav Jain
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-8459.patch, OFBIZ-8459.patch
>
>
> Steps to regenerate the issue:
> # Create a serialized product and receive single inventory item (feed serial 
> number) of the specific product.
> # Check the status of the inventory item in InventoryItem and 
> InventoryItemStatus entities it should be INV_AVAILABLE.
> # Create sales order of this serialized product.
> # Status of the inventory item in InventoryItem entity is changed to 
> 'INV_PROMISED' but InventoryItemStatus entity still shows 'INV_AVAILABLE'.
> Expected :
> In InventoryItemStatus current status should also be 'INV_PROMISED' as of 
> InventoryItem.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11504) Solr Configuration Problem on Demo Instance

2020-05-10 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103880#comment-17103880
 ] 

Jacques Le Roux commented on OFBIZ-11504:
-

Hi Ravi,

It's easier to create a completeSolrUrl, as you suggested, in 
solrconfig.properties. Because with EntityUtilProperties we would need to pass 
a delegator to makeSolrWebappUrl(). Maybe you simply meant that (ie 
UtilProperties instead of EntityUtilProperties?

> Solr Configuration Problem on Demo Instance
> ---
>
> Key: OFBIZ-11504
> URL: https://issues.apache.org/jira/browse/OFBIZ-11504
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ravi Lodhi
>Priority: Minor
> Attachments: DemoStableRebuildSolrIndex.png, DemoTrunkErrorLogs.txt, 
> DemoTrunkRebuildSolrIndexError.png
>
>
> Unable to build Solr Index on demo-trunk and demo-stable instances.
>  
> *Demo Trunk:* Getting connection error while running *rebuildSolrIndex* 
> service from webtools on 
> [demo-trunk|https://demo-trunk.ofbiz.apache.org/webtools/control/runService] 
> instance. Below is the error message-
>  
> {code:java}
> org.apache.http.conn.HttpHostConnectException: Connect to localhost:8443 
> [localhost/127.0.0.1] failed: Connection refused (Connection refused){code}
>  
> *Demo Stable:* I also tried running the same service from webtools on 
> [demo-stable|https://demo-stable.ofbiz.apache.org/webtools/control/runService]
>  instance and getting below error-
>  
>  
> {code:java}
> javax.net.ssl.SSLPeerUnverifiedException: Host name 'localhost' does not 
> match the certificate subject provided by the peer 
> (CN=demo-old.ofbiz.apache.org). Please find the attached screenshots for the 
> same.{code}
>  
>  
> It seems like some configurations are missing for solr plugins on these demo 
> instances.
> Please find attached the error logs from demo-trunk instance as shared by 
> [~jleroux]. Thanks Jacques for providing the error logs from the instance.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11504) Solr Configuration Problem on Demo Instance

2020-05-10 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103880#comment-17103880
 ] 

Jacques Le Roux edited comment on OFBIZ-11504 at 5/10/20, 5:01 PM:
---

Hi Ravi,

That sounds like a good idea. But it's easier to create a completeSolrUrl, as 
you suggested, in solrconfig.properties. Because with EntityUtilProperties we 
would need to pass a delegator to makeSolrWebappUrl(). Maybe you simply meant 
that (ie UtilProperties instead of EntityUtilProperties?


was (Author: jacques.le.roux):
Hi Ravi,

It's easier to create a completeSolrUrl, as you suggested, in 
solrconfig.properties. Because with EntityUtilProperties we would need to pass 
a delegator to makeSolrWebappUrl(). Maybe you simply meant that (ie 
UtilProperties instead of EntityUtilProperties?

> Solr Configuration Problem on Demo Instance
> ---
>
> Key: OFBIZ-11504
> URL: https://issues.apache.org/jira/browse/OFBIZ-11504
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ravi Lodhi
>Priority: Minor
> Attachments: DemoStableRebuildSolrIndex.png, DemoTrunkErrorLogs.txt, 
> DemoTrunkRebuildSolrIndexError.png
>
>
> Unable to build Solr Index on demo-trunk and demo-stable instances.
>  
> *Demo Trunk:* Getting connection error while running *rebuildSolrIndex* 
> service from webtools on 
> [demo-trunk|https://demo-trunk.ofbiz.apache.org/webtools/control/runService] 
> instance. Below is the error message-
>  
> {code:java}
> org.apache.http.conn.HttpHostConnectException: Connect to localhost:8443 
> [localhost/127.0.0.1] failed: Connection refused (Connection refused){code}
>  
> *Demo Stable:* I also tried running the same service from webtools on 
> [demo-stable|https://demo-stable.ofbiz.apache.org/webtools/control/runService]
>  instance and getting below error-
>  
>  
> {code:java}
> javax.net.ssl.SSLPeerUnverifiedException: Host name 'localhost' does not 
> match the certificate subject provided by the peer 
> (CN=demo-old.ofbiz.apache.org). Please find the attached screenshots for the 
> same.{code}
>  
>  
> It seems like some configurations are missing for solr plugins on these demo 
> instances.
> Please find attached the error logs from demo-trunk instance as shared by 
> [~jleroux]. Thanks Jacques for providing the error logs from the instance.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10905) Have a service that runs periodically to generate CustomTimePeriod records

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10905:
-
Issue Type: New Feature  (was: Improvement)

> Have a service that runs periodically to generate CustomTimePeriod records
> --
>
> Key: OFBIZ-10905
> URL: https://issues.apache.org/jira/browse/OFBIZ-10905
> Project: OFBiz
>  Issue Type: New Feature
>  Components: accounting
>Affects Versions: Release Branch 15.12, Release Branch 16.11, Release 
> Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: CustomTimePeriod
>
> Currently no service exists that creates CustomTimePeriod records on a 
> scheduled basis. One could think of:
>  * a yearly schedule that creates the next fiscal year period
>  * a quarterly schedule that creates the next fiscal quartered period
>  * a monthly schedule that creates the next fiscal month period
> Considerations regarding requirements:
>  # Following requirements are to be considered static:
>  ## the highest granularity regarding a custom time period is a year 
> (parameter value = YEAR)
>  # Following requirements are to be configured/set via SystemProperty records:
>  ## the applicability based on data PeriodType records: currently we can 
> derive/identify two categories: FISCAL and SALES;
>  ## the highest period granularity is static and set to "YEAR"
>  ## the lowest period granularity is configurable and set to "MONTH";
>  ## whether intermediate granularities (between lowest and highest) should be 
> created for a given type (see 2.1) (intermediate indicator: "true"/"false" or 
> "Y"/"N").
>  # A CustomTimePeriod is only to be created:
>  ## when a PartyAcctgPreference record exists, and
>  ## when the 'enableAccounting' field of that record has the value set to "Y"
>  # Each lower granularity CustomTimePeriod record must reference higher 
> granularity CustomTimePeriod record (Parent/Child principle), when 
> requirement consideration 2.4 is set to true or Y.
> Based on requirement considerations stated above, following examples can be 
> thought of:
>  # with lowest granularity set to "MONTH" and intermediate indicator = "N" 
> and type ="FISCAL:
> {code:java}
>  fromDate="2020-01-01 00:00:00.000" thruDate="2020-01-31 23:59:59.000" 
> isClosed="N" periodNum="2020" periodName="2020-JAN" 
> organizationPartyId="Company" />
>  fromDate="2020-01-02 00:00:00.000" thruDate="2020-02-29 23:59:59.000" 
> isClosed="N" periodNum="2020" periodName="2020-FEB" 
> organizationPartyId="Company" />
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10905) Have a service that runs periodically to generate CustomTimePeriod records

2020-05-10 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103875#comment-17103875
 ] 

Jacques Le Roux commented on OFBIZ-10905:
-

Hi Pierre,

Have you an idea about what would create and store this information?

> Have a service that runs periodically to generate CustomTimePeriod records
> --
>
> Key: OFBIZ-10905
> URL: https://issues.apache.org/jira/browse/OFBIZ-10905
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 15.12, Release Branch 16.11, Release 
> Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: CustomTimePeriod
>
> Currently no service exists that creates CustomTimePeriod records on a 
> scheduled basis. One could think of:
>  * a yearly schedule that creates the next fiscal year period
>  * a quarterly schedule that creates the next fiscal quartered period
>  * a monthly schedule that creates the next fiscal month period
> Considerations regarding requirements:
>  # Following requirements are to be considered static:
>  ## the highest granularity regarding a custom time period is a year 
> (parameter value = YEAR)
>  # Following requirements are to be configured/set via SystemProperty records:
>  ## the applicability based on data PeriodType records: currently we can 
> derive/identify two categories: FISCAL and SALES;
>  ## the highest period granularity is static and set to "YEAR"
>  ## the lowest period granularity is configurable and set to "MONTH";
>  ## whether intermediate granularities (between lowest and highest) should be 
> created for a given type (see 2.1) (intermediate indicator: "true"/"false" or 
> "Y"/"N").
>  # A CustomTimePeriod is only to be created:
>  ## when a PartyAcctgPreference record exists, and
>  ## when the 'enableAccounting' field of that record has the value set to "Y"
>  # Each lower granularity CustomTimePeriod record must reference higher 
> granularity CustomTimePeriod record (Parent/Child principle), when 
> requirement consideration 2.4 is set to true or Y.
> Based on requirement considerations stated above, following examples can be 
> thought of:
>  # with lowest granularity set to "MONTH" and intermediate indicator = "N" 
> and type ="FISCAL:
> {code:java}
>  fromDate="2020-01-01 00:00:00.000" thruDate="2020-01-31 23:59:59.000" 
> isClosed="N" periodNum="2020" periodName="2020-JAN" 
> organizationPartyId="Company" />
>  fromDate="2020-01-02 00:00:00.000" thruDate="2020-02-29 23:59:59.000" 
> isClosed="N" periodNum="2020" periodName="2020-FEB" 
> organizationPartyId="Company" />
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11519) Convert testCreateFixedAssetMaint test from XML to Groovy

2020-05-10 Thread Rohit Hukkeri (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092285#comment-17092285
 ] 

Rohit Hukkeri edited comment on OFBIZ-11519 at 5/10/20, 2:17 PM:
-

Hello,

Please find the attached patch for testCreateFixedAssetMaintTest test

Thanks!


was (Author: rohit.hukkeri):
Hello [~pawan],

Please find the attached patch for testCreateFixedAssetMaintTest test

Thanks!

> Convert testCreateFixedAssetMaint test from XML to Groovy
> -
>
> Key: OFBIZ-11519
> URL: https://issues.apache.org/jira/browse/OFBIZ-11519
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11519.patch
>
>
> Convert testCreateFixedAssetMaint test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11688) unable to load main class org.gradle.wrapper.GradleWrapperMain

2020-05-10 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103799#comment-17103799
 ] 

Jacques Le Roux edited comment on OFBIZ-11688 at 5/10/20, 1:36 PM:
---

Please subscribe to the user ML for such questions and then use your email 
client.
See why here http://ofbiz.apache.org/mailing-lists.html.

You will get a better support, people can answer you on the ML.
The wider the audience the better the answers you might get.

Thanks

This said did you read the README.adoc Asciidoc file? (Yes we still miss a 
conversion to HTML, you can use 
>https://asciidoctor.org/docs/convert-documents/#converting-a-document-to-html)

Long story short: did you run {{./gradle/init-gradle-wrapper}} ? If that's your 
problem please close.


was (Author: jacques.le.roux):
Please subscribe to the user ML for such questions and then use your email 
client.
See why here http://ofbiz.apache.org/mailing-lists.html.

You will get a better support, people can answer you on the ML.
The wider the audience the better the answers you might get.

Thanks

This said did you read the README.adoc Asciidoc file? (Yes we still miss a 
conversion to HTML, you can use 
>https://asciidoctor.org/docs/convert-documents/#converting-a-document-to-html)

Long story short: did you run ./gradle/init-gradle-wrapper ? If that's your 
problem please close.

> unable to load main class org.gradle.wrapper.GradleWrapperMain
> --
>
> Key: OFBIZ-11688
> URL: https://issues.apache.org/jira/browse/OFBIZ-11688
> Project: OFBiz
>  Issue Type: Bug
>Reporter: muhammad
>Priority: Major
>
> Hi everybody,
>  
> I'm fedora user, for run ofbiz i meet an error!!!
> Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain
> How to fix it?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11688) unable to load main class org.gradle.wrapper.GradleWrapperMain

2020-05-10 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103799#comment-17103799
 ] 

Jacques Le Roux commented on OFBIZ-11688:
-

Please subscribe to the user ML for such questions and then use your email 
client.
See why here http://ofbiz.apache.org/mailing-lists.html.

You will get a better support, people can answer you on the ML.
The wider the audience the better the answers you might get.

Thanks

This said did you read the README.adoc Asciidoc file? (Yes we still miss a 
conversion to HTML, you can use 
>https://asciidoctor.org/docs/convert-documents/#converting-a-document-to-html)

Long story short: did you run ./gradle/init-gradle-wrapper ? If that's your 
problem please close.

> unable to load main class org.gradle.wrapper.GradleWrapperMain
> --
>
> Key: OFBIZ-11688
> URL: https://issues.apache.org/jira/browse/OFBIZ-11688
> Project: OFBiz
>  Issue Type: Bug
>Reporter: muhammad
>Priority: Major
>
> Hi everybody,
>  
> I'm fedora user, for run ofbiz i meet an error!!!
> Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain
> How to fix it?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11435) Remove and/or replace deprecated services

2020-05-10 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103791#comment-17103791
 ] 

Jacques Le Roux commented on OFBIZ-11435:
-

Thanks Suraj,

Here is the policy about that:
 
[https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-Handlingdeprecatedservices]
Not sure it's really helpful, looking at the log is easier, maybe we should 
simplify the policy and ask to refer to the log...

The idea is that you fill a line like
bq. 
in the depracated service definition. So captureBillingAccountPayments indeed 
should be be removed

Here is what I find in the current log today:
{noformat}
the service lookupParty has been deprecated and replaced by performFindParty, 
since Upcoming Branch because '
the service deleteRateAmount has been deprecated and replaced by 
expireRateAmount, since Release 18.12
the service captureBillingAccountPayment has been deprecated and replaced by 
captureBillingAccountPayments, since Releases 17.12
the service addRequirementTask has been deprecated and replaced by 
createWorkRequirementFulfillment, since Upcoming Branch because '
the service createQuoteWorkEffort has been deprecated and replaced by 
ensureWorkEffortAndCreateQuoteWorkEffort, since Release 18.12 because '
the service addPriceRuleToMarketingCampaign has been deprecated and replaced by 
createMarketingCampaignPrice, since Release 18.12 because '
the service removePriceRuleFromMarketingCampaign has been deprecated and 
replaced by deleteMarketingCampaignPrice, since Release 18.12 because '
the service addPromoToMarketingCampaign has been deprecated and replaced by 
createMarketingCampaignPromo, since Release 18.12 because '
the service removePromoFromMarketingCampaign has been deprecated and replaced 
by deleteMarketingCampaignPromo, since Release 18.12 because '
the service lookupParty has been deprecated and replaced by performFindParty, 
since Upcoming Branch because '
the service captureBillingAccountPayment has been deprecated and replaced by 
captureBillingAccountPayments, since Releases 17.12
the service deleteRateAmount has been deprecated and replaced by 
expireRateAmount, since Release 18.12
the service createQuoteWorkEffort has been deprecated and replaced by 
ensureWorkEffortAndCreateQuoteWorkEffort, since Release 18.12 because '
the service addRequirementTask has been deprecated and replaced by 
createWorkRequirementFulfillment, since Upcoming Branch because '
the service addPriceRuleToMarketingCampaign has been deprecated and replaced by 
createMarketingCampaignPrice, since Release 18.12 because '
the service removePriceRuleFromMarketingCampaign has been deprecated and 
replaced by deleteMarketingCampaignPrice, since Release 18.12 because '
the service addPromoToMarketingCampaign has been deprecated and replaced by 
createMarketingCampaignPromo, since Release 18.12 because '
the service removePromoFromMarketingCampaign has been deprecated and replaced 
by deleteMarketingCampaignPromo, since Release 18.12 because '
{noformat}


> Remove and/or replace deprecated services
> -
>
> Key: OFBIZ-11435
> URL: https://issues.apache.org/jira/browse/OFBIZ-11435
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: refactoring
>
> In the code base (in trunk) there are several services call functions which 
> have been deprecated and replaced by newer functions, such as:
>  * deleteRateAmount -> expireRateAmount
>  * captureBillingAccountPayment -> captureBillingAccountPayments
>  * createQuoteWorkEffort -> ensureWorkEffortAndCreateQuoteWorkEffort
>  * addPriceRuleToMarketingCampaign -> createMarketingCampaignPrice
>  * removePriceRuleFromMarketingCampaign -> deleteMarketingCampaignPrice
>  * addPromoToMarketingCampaign -> createMarketingCampaignPromo
>  * removePromoFromMarketingCampaign -> deleteMarketingCampaignPromo
> These must be removed from trunk, when the time is there (to be done 
> periodically). This is a long running ticket intended to enable committers to 
> associate a removal to a ticket upon periodical clean-up without having to 
> create new tickets.
> It is suggested that committer the ticket under which a the replacement is 
> committed is referenced here as a link.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10905) Have a service that runs periodically to generate CustomTimePeriod records

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10905:
-
Description: 
Currently no service exists that creates CustomTimePeriod records on a 
scheduled basis. One could think of:
 * a yearly schedule that creates the next fiscal year period
 * a quarterly schedule that creates the next fiscal quartered period
 * a monthly schedule that creates the next fiscal month period

Considerations regarding requirements:
 # Following requirements are to be considered static:
 ## the highest granularity regarding a custom time period is a year (parameter 
value = YEAR)
 # Following requirements are to be configured/set via SystemProperty records:
 ## the applicability based on data PeriodType records: currently we can 
derive/identify two categories: FISCAL and SALES;
 ## the highest period granularity is static and set to "YEAR"
 ## the lowest period granularity is configurable and set to "MONTH";
 ## whether intermediate granularities (between lowest and highest) should be 
created for a given type (see 2.1) (intermediate indicator: "true"/"false" or 
"Y"/"N").
 # A CustomTimePeriod is only to be created:
 ## when a PartyAcctgPreference record exists, and
 ## when the 'enableAccounting' field of that record has the value set to "Y"
 # Each lower granularity CustomTimePeriod record must reference higher 
granularity CustomTimePeriod record (Parent/Child principle), when requirement 
consideration 2.4 is set to true or Y.

Based on requirement considerations stated above, following examples can be 
thought of:
 # with lowest granularity set to "MONTH" and intermediate indicator = "N" and 
type ="FISCAL:

{code:java}


{code}
 

  was:
Currently no service exists that creates CustomTimePeriod records on a 
scheduled basis. One could think of:
 * a yearly schedule that creates the next fiscal year period
 * a quarterly schedule that creates the next fiscal quartered period
 * a monthly schedule that creates the next fiscal month period

Considerations regarding requirements:
 # Following requirements are to be considered static:
 ## the highest granularity regarding a custom time period is a year (parameter 
value = YEAR)
 # Following requirements are to be configured/set via SystemProperty records:
 ## the applicability based on data PeriodType records: currently we can 
derive/identify two categories: FISCAL and SALES;
 ## the highest period granularity is static and set to "YEAR"
 ## the lowest period granularity is configurable and set to "MONTH";
 ## whether intermediate granularities (between lowest and highest) should be 
created for a given type (see 2.1) (intermediate indicator: "true"/"false" or 
"Y"/"N").
 # A CustomTimePeriod is only to be created:
 ## when a PartyAcctgPreference record exists, and
 ## when the 'enableAccounting' field of that record has the value set to "Y"
 # Each lower granularity CustomTimePeriod record must reference higher 
granularity CustomTimePeriod record (Parent/Child principle).

Based on requirement considerations stated above, following examples can be 
thought of:
 # with lowest granularity set to "MONTH" and intermediate indicator = "N" and 
type ="FISCAL:

{code:java}


{code}

 


> Have a service that runs periodically to generate CustomTimePeriod records
> --
>
> Key: OFBIZ-10905
> URL: https://issues.apache.org/jira/browse/OFBIZ-10905
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 15.12, Release Branch 16.11, Release 
> Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: CustomTimePeriod
>
> Currently no service exists that creates CustomTimePeriod records on a 
> scheduled basis. One could think of:
>  * a yearly schedule that creates the next fiscal year period
>  * a quarterly schedule that creates the next fiscal quartered period
>  * a monthly schedule that creates the next fiscal month period
> Considerations regarding requirements:
>  # Following requirements are to be considered static:
>  ## the highest granularity regarding a custom time period is a year 
> (parameter value = YEAR)
>  # Following requirements are to be configured/set via SystemProperty records:
>  ## the applicability based on data PeriodType records: currently we can 
> derive/identify two categories: FISCAL and SALES;
>  ## the highest period granularity is static and set to "YEAR"
>  ## the lowest period granularity is configurable and set to "MONTH";
>  ## whether intermediate granularities (between lowest and highest) should be 
> created for a given type (see 2.1) (intermediate indicator: "true"/"false" or 
> "Y"/"N").
>  # A CustomTimePeriod 

[jira] [Updated] (OFBIZ-10905) Have a service that runs periodically to generate CustomTimePeriod records

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10905:
-
Description: 
Currently no service exists that creates CustomTimePeriod records on a 
scheduled basis. One could think of:
 * a yearly schedule that creates the next fiscal year period
 * a quarterly schedule that creates the next fiscal quartered period
 * a monthly schedule that creates the next fiscal month period

Considerations regarding requirements:
 # Following requirements are to be considered static:
 ## the highest granularity regarding a custom time period is a year (parameter 
value = YEAR)
 # Following requirements are to be configured/set via SystemProperty records:
 ## the applicability based on data PeriodType records: currently we can 
derive/identify two categories: FISCAL and SALES;
 ## the highest period granularity is static and set to "YEAR"
 ## the lowest period granularity is configurable and set to "MONTH";
 ## whether intermediate granularities (between lowest and highest) should be 
created for a given type (see 2.1) (intermediate indicator: "true"/"false" or 
"Y"/"N").
 # A CustomTimePeriod is only to be created:
 ## when a PartyAcctgPreference record exists, and
 ## when the 'enableAccounting' field of that record has the value set to "Y"
 # Each lower granularity CustomTimePeriod record must reference higher 
granularity CustomTimePeriod record (Parent/Child principle).

Based on requirement considerations stated above, following examples can be 
thought of:
 # with lowest granularity set to "MONTH" and intermediate indicator = "N" and 
type ="FISCAL:

{code:java}


{code}

 

  was:
Currently no service exists that creates CustomTimePeriod records on a 
scheduled basis. One could think of:
 * a yearly schedule that creates the next fiscal year period
 * a quarterly schedule that creates the next fiscal quartered period
 * a monthly schedule that creates the next fiscal month period
 * etc.

With each record referencing the appropriate parent, e.g.:
 * the fiscal month referencing the fiscal quarter
 * the fiscal quarter referencing the fiscal year
 * etc.


> Have a service that runs periodically to generate CustomTimePeriod records
> --
>
> Key: OFBIZ-10905
> URL: https://issues.apache.org/jira/browse/OFBIZ-10905
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 15.12, Release Branch 16.11, Release 
> Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: CustomTimePeriod
>
> Currently no service exists that creates CustomTimePeriod records on a 
> scheduled basis. One could think of:
>  * a yearly schedule that creates the next fiscal year period
>  * a quarterly schedule that creates the next fiscal quartered period
>  * a monthly schedule that creates the next fiscal month period
> Considerations regarding requirements:
>  # Following requirements are to be considered static:
>  ## the highest granularity regarding a custom time period is a year 
> (parameter value = YEAR)
>  # Following requirements are to be configured/set via SystemProperty records:
>  ## the applicability based on data PeriodType records: currently we can 
> derive/identify two categories: FISCAL and SALES;
>  ## the highest period granularity is static and set to "YEAR"
>  ## the lowest period granularity is configurable and set to "MONTH";
>  ## whether intermediate granularities (between lowest and highest) should be 
> created for a given type (see 2.1) (intermediate indicator: "true"/"false" or 
> "Y"/"N").
>  # A CustomTimePeriod is only to be created:
>  ## when a PartyAcctgPreference record exists, and
>  ## when the 'enableAccounting' field of that record has the value set to "Y"
>  # Each lower granularity CustomTimePeriod record must reference higher 
> granularity CustomTimePeriod record (Parent/Child principle).
> Based on requirement considerations stated above, following examples can be 
> thought of:
>  # with lowest granularity set to "MONTH" and intermediate indicator = "N" 
> and type ="FISCAL:
> {code:java}
>  fromDate="2020-01-01 00:00:00.000" thruDate="2020-01-31 23:59:59.000" 
> isClosed="N" periodNum="2020" periodName="2020-JAN" 
> organizationPartyId="Company" />
>  fromDate="2020-01-02 00:00:00.000" thruDate="2020-02-29 23:59:59.000" 
> isClosed="N" periodNum="2020" periodName="2020-FEB" 
> organizationPartyId="Company" />
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #130: Improved: Converted CustomTimePeriod related services from simple to entity-auto

2020-05-10 Thread GitBox


sonarcloud[bot] commented on pull request #130:
URL: https://github.com/apache/ofbiz-framework/pull/130#issuecomment-626308753


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=130=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=130=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=130=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=130=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=130=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=130=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=130=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=130=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=130=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=130=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=130=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=130)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=130=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=130=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] surajkhurana opened a new pull request #130: Improved: Converted CustomTimePeriod related services from simple to entity-auto

2020-05-10 Thread GitBox


surajkhurana opened a new pull request #130:
URL: https://github.com/apache/ofbiz-framework/pull/130


   (OFBIZ-11689)
   Thanks Pierre for reporting.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-11690) Convert removeWorkEffortFixedAssetStd service from simple to entity-auto

2020-05-10 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11690:
--
Labels: Refactoring  (was: )

> Convert removeWorkEffortFixedAssetStd service from simple to entity-auto
> 
>
> Key: OFBIZ-11690
> URL: https://issues.apache.org/jira/browse/OFBIZ-11690
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: workeffort
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: Refactoring
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11690) Convert removeWorkEffortFixedAssetStd service from simple to entity-auto

2020-05-10 Thread Suraj Khurana (Jira)
Suraj Khurana created OFBIZ-11690:
-

 Summary: Convert removeWorkEffortFixedAssetStd service from simple 
to entity-auto
 Key: OFBIZ-11690
 URL: https://issues.apache.org/jira/browse/OFBIZ-11690
 Project: OFBiz
  Issue Type: Sub-task
  Components: workeffort
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11689) Convert CustomTimePeriod services from simple to entity-auto

2020-05-10 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11689:
-

Assignee: Suraj Khurana

> Convert CustomTimePeriod services from simple to entity-auto
> 
>
> Key: OFBIZ-11689
> URL: https://issues.apache.org/jira/browse/OFBIZ-11689
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework/common
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: refactoring
>
> Applicable services:
>  * createCustomTimePeriod
>  * updateCustomTimePeriod
>  * deleteCustomTimePeriod



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11640) Convert all AcctgTrans related CRUD services from simple to entity-auto

2020-05-10 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11640:
--
Labels: Refactoring  (was: )

> Convert all AcctgTrans related CRUD services from simple to entity-auto
> ---
>
> Key: OFBIZ-11640
> URL: https://issues.apache.org/jira/browse/OFBIZ-11640
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: Refactoring
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11640) Convert all AcctgTrans related CRUD services from simple to entity-auto

2020-05-10 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11640.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

This has been successfully pushed to trunk. All test passed.

> Convert all AcctgTrans related CRUD services from simple to entity-auto
> ---
>
> Key: OFBIZ-11640
> URL: https://issues.apache.org/jira/browse/OFBIZ-11640
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #103: Improved: Converted all AcctgTrans related CRUD services from simple to entity-auto

2020-05-10 Thread GitBox


sonarcloud[bot] commented on pull request #103:
URL: https://github.com/apache/ofbiz-framework/pull/103#issuecomment-626306759


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=103)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=103=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=103=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #103: Improved: Converted all AcctgTrans related CRUD services from simple to entity-auto

2020-05-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #103:
URL: https://github.com/apache/ofbiz-framework/pull/103#issuecomment-626305063


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=103)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=103=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=103=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11640) Convert all AcctgTrans related CRUD services from simple to entity-auto

2020-05-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103748#comment-17103748
 ] 

ASF subversion and git services commented on OFBIZ-11640:
-

Commit 10a8f7a0931d898d3d9f701012efd93ab960f1d7 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=10a8f7a ]

Improved: Converted all AcctgTrans related CRUD services from simple to 
entity-auto (#103)

* Improved: Converted all AcctgTrans related CRUD services from simple to 
entity-auto
(OFBIZ-11640)

> Convert all AcctgTrans related CRUD services from simple to entity-auto
> ---
>
> Key: OFBIZ-11640
> URL: https://issues.apache.org/jira/browse/OFBIZ-11640
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11269) Update pages of ofbiz website

2020-05-10 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11269.
---
Resolution: Done

I have removed the last references to Svn

> Update pages of ofbiz website
> -
>
> Key: OFBIZ-11269
> URL: https://issues.apache.org/jira/browse/OFBIZ-11269
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: site
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Deepak Dixit
>Priority: Major
> Attachments: OFBiz_Getting_started_Developers.patch, 
> OFBiz_Getting_started_Developers.txt, OFBiz_Source_Repository.patch, 
> OFBiz_Source_Repository.txt, OFBiz_Source_Repository.txt, 
> developers.tpl.php.patch, developers.tpl.php.patch, 
> source-repositories.tpl.php.patch, source-repositories.tpl.php.patch
>
>
> Update pages of the website to reflect the migration from svn to git/Github.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11269) Update pages of ofbiz website

2020-05-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103745#comment-17103745
 ] 

ASF subversion and git services commented on OFBIZ-11269:
-

Commit 41bfc5e2ce86fd4beda8d9e6ce523564896efde8 in ofbiz-site's branch 
refs/heads/master from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-site.git;h=41bfc5e ]

Improved: Update pages of ofbiz website

(OFBIZ-11269)

Updates the source-repositories page by removing last Svn references


> Update pages of ofbiz website
> -
>
> Key: OFBIZ-11269
> URL: https://issues.apache.org/jira/browse/OFBIZ-11269
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: site
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Deepak Dixit
>Priority: Major
> Attachments: OFBiz_Getting_started_Developers.patch, 
> OFBiz_Getting_started_Developers.txt, OFBiz_Source_Repository.patch, 
> OFBiz_Source_Repository.txt, OFBiz_Source_Repository.txt, 
> developers.tpl.php.patch, developers.tpl.php.patch, 
> source-repositories.tpl.php.patch, source-repositories.tpl.php.patch
>
>
> Update pages of the website to reflect the migration from svn to git/Github.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #103: Improved: Converted all AcctgTrans related CRUD services from simple to entity-auto

2020-05-10 Thread GitBox


sonarcloud[bot] commented on pull request #103:
URL: https://github.com/apache/ofbiz-framework/pull/103#issuecomment-626305063


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=103)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=103=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=103=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #103: Improved: Converted all AcctgTrans related CRUD services from simple to entity-auto

2020-05-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #103:
URL: https://github.com/apache/ofbiz-framework/pull/103#issuecomment-623059389


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=103=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=103)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=103=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=103=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #129: Improved: Converted all GlReconciliationEntry related CRUD services from simple to entity-auto

2020-05-10 Thread GitBox


sonarcloud[bot] commented on pull request #129:
URL: https://github.com/apache/ofbiz-framework/pull/129#issuecomment-626304903


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=129=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=129=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=129=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=129=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=129=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=129=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=129=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=129=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=129=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=129=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=129=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=129)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=129=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=129=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] surajkhurana opened a new pull request #129: Improved: Converted all GlReconciliationEntry related CRUD services from simple to entity-auto

2020-05-10 Thread GitBox


surajkhurana opened a new pull request #129:
URL: https://github.com/apache/ofbiz-framework/pull/129


   
   
   (OFBIZ-11662)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Comment Edited] (OFBIZ-11504) Solr Configuration Problem on Demo Instance

2020-05-10 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103319#comment-17103319
 ] 

Jacques Le Roux edited comment on OFBIZ-11504 at 5/10/20, 10:15 AM:


Hi Jacques,

I have tested the Solr connection by writing custom code in groovy and 
executing it from programmable export tab. I just replaced the 
solrWebappDomainName from localhost to demo-trunk.ofbiz.apache.org. This forms 
the below url as per the current implementation-

[https://demo-trunk.ofbiz.apache.org:8443/solr]

The above url is giving "Connection Refused" error just because of the port as 
domain already includes it. It's working fine with this url - 
https://demo-trunk.ofbiz.apache.org/solr

There is code in SolrUtil class to set the port (default to same as OFBiz 
server) -

{code}
if (UtilValidate.isNotEmpty(solrWebappPortOverride)) {
 solrPort = solrWebappPortOverride;
} else {
 solrPort = UtilProperties.getPropertyValue("url", 
("https".equals(solrWebappProtocol) ? "port.https" : "port.http"), 
("https".equals(solrWebappProtocol) ? "8443" : "8080"));
}
{code}

I have tried to change the port for Solr by setting solrWebappPortOverride 
property. But it's not working. Even after changing the port, it was running on 
the same port as OFBiz.  But that is a different issue.

 

So how should I proceed now?
Should we introduce one new property say completeSolrUrl which contains full 
path like this 
[https://demo-trunk.ofbiz.apache.org/solr|https://demo-trunk.ofbiz.apache.org:8443/solr]
  and the EntityUtilProperties to read the same. So that it can be modified 
from DB. Then modification in makeSolrWebappUrl() method of SolrUtil class to 
give preference to completeSolrUrl if set.


was (Author: lodhiravi):
Hi Jacques,

I have tested the Solr connection by writing custom code in groovy and 
executing it from programmable export tab. I just replaced the 
solrWebappDomainName from localhost to demo-trunk.ofbiz.apache.org. This forms 
the below url as per the current implementation-

[https://demo-trunk.ofbiz.apache.org:8443/solr]

The above url is giving "Connection Refused" error just because of the port as 
domain already includes it. It's working fine with this url - 
[https://demo-trunk.ofbiz.apache.org/solr|https://demo-trunk.ofbiz.apache.org:8443/solr]

There is code in SolrUtil class to set the port (default to same as OFBiz 
server) -

{code}
if (UtilValidate.isNotEmpty(solrWebappPortOverride)) {
 solrPort = solrWebappPortOverride;
} else {
 solrPort = UtilProperties.getPropertyValue("url", 
("https".equals(solrWebappProtocol) ? "port.https" : "port.http"), 
("https".equals(solrWebappProtocol) ? "8443" : "8080"));
}
{code}

I have tried to change the port for Solr by setting solrWebappPortOverride 
property. But it's not working. Even after changing the port, it was running on 
the same port as OFBiz.  But that is a different issue.

 

So how should I proceed now?
Should we introduce one new property say completeSolrUrl which contains full 
path like this 
[https://demo-trunk.ofbiz.apache.org/solr|https://demo-trunk.ofbiz.apache.org:8443/solr]
  and the EntityUtilProperties to read the same. So that it can be modified 
from DB. Then modification in makeSolrWebappUrl() method of SolrUtil class to 
give preference to completeSolrUrl if set.

> Solr Configuration Problem on Demo Instance
> ---
>
> Key: OFBIZ-11504
> URL: https://issues.apache.org/jira/browse/OFBIZ-11504
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ravi Lodhi
>Priority: Minor
> Attachments: DemoStableRebuildSolrIndex.png, DemoTrunkErrorLogs.txt, 
> DemoTrunkRebuildSolrIndexError.png
>
>
> Unable to build Solr Index on demo-trunk and demo-stable instances.
>  
> *Demo Trunk:* Getting connection error while running *rebuildSolrIndex* 
> service from webtools on 
> [demo-trunk|https://demo-trunk.ofbiz.apache.org/webtools/control/runService] 
> instance. Below is the error message-
>  
> {code:java}
> org.apache.http.conn.HttpHostConnectException: Connect to localhost:8443 
> [localhost/127.0.0.1] failed: Connection refused (Connection refused){code}
>  
> *Demo Stable:* I also tried running the same service from webtools on 
> [demo-stable|https://demo-stable.ofbiz.apache.org/webtools/control/runService]
>  instance and getting below error-
>  
>  
> {code:java}
> javax.net.ssl.SSLPeerUnverifiedException: Host name 'localhost' does not 
> match the certificate subject provided by the peer 
> (CN=demo-old.ofbiz.apache.org). Please find the attached screenshots for the 
> same.{code}
>  
>  
> It seems like some configurations are missing for solr plugins on these demo 
> instances.
> Please find attached the error logs 

[jira] [Assigned] (OFBIZ-6189) Have configuration options for accounting

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-6189:
---

Assignee: Pierre Smits

> Have configuration options for accounting
> -
>
> Key: OFBIZ-6189
> URL: https://issues.apache.org/jira/browse/OFBIZ-6189
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, multi-tenant
> Attachments: OFBIZ-6189-accounting-systemproperties.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #128: Improved: accounting component - have configuration options in db (OFBIZ-6189)

2020-05-10 Thread GitBox


sonarcloud[bot] commented on pull request #128:
URL: https://github.com/apache/ofbiz-framework/pull/128#issuecomment-626299673


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=128=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=128=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=128=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=128=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=128=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=128=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=128=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=128=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=128=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=128=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=128=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=128)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=128=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=128=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #128: Improved: accounting component - have configuration options in db (OFBIZ-6189)

2020-05-10 Thread GitBox


PierreSmits opened a new pull request #128:
URL: https://github.com/apache/ofbiz-framework/pull/128


   (OFBIZ-6189)
   
   added: SystemProperty records in AccountingSystemPropertyData.xml
   added: reference of AccountingSystemPropertyData.xml to load at seed loading 
moment



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #117: Improved: Update Data Sets

2020-05-10 Thread GitBox


sonarcloud[bot] commented on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-626299015


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-626298621


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-626164215


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #117: Improved: Update Data Sets

2020-05-10 Thread GitBox


sonarcloud[bot] commented on pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-626298621


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-6189) Have configuration options for accounting

2020-05-10 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103726#comment-17103726
 ] 

Pierre Smits commented on OFBIZ-6189:
-

Reworking the patch to a GitHub PR.

> Have configuration options for accounting
> -
>
> Key: OFBIZ-6189
> URL: https://issues.apache.org/jira/browse/OFBIZ-6189
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: configuration, multi-tenant
> Attachments: OFBIZ-6189-accounting-systemproperties.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11435) Remove and/or replace deprecated services

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11435:


Assignee: (was: Pierre Smits)

> Remove and/or replace deprecated services
> -
>
> Key: OFBIZ-11435
> URL: https://issues.apache.org/jira/browse/OFBIZ-11435
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: refactoring
>
> In the code base (in trunk) there are several services call functions which 
> have been deprecated and replaced by newer functions, such as:
>  * deleteRateAmount -> expireRateAmount
>  * captureBillingAccountPayment -> captureBillingAccountPayments
>  * createQuoteWorkEffort -> ensureWorkEffortAndCreateQuoteWorkEffort
>  * addPriceRuleToMarketingCampaign -> createMarketingCampaignPrice
>  * removePriceRuleFromMarketingCampaign -> deleteMarketingCampaignPrice
>  * addPromoToMarketingCampaign -> createMarketingCampaignPromo
>  * removePromoFromMarketingCampaign -> deleteMarketingCampaignPromo
> These must be removed from trunk, when the time is there (to be done 
> periodically). This is a long running ticket intended to enable committers to 
> associate a removal to a ticket upon periodical clean-up without having to 
> create new tickets.
> It is suggested that committer the ticket under which a the replacement is 
> committed is referenced here as a link.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11520) Convert testCreateFixedAssetMeter test from XML to Groovy

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11520:
---

Assignee: Pawan Verma  (was: Rohit Hukkeri)

> Convert testCreateFixedAssetMeter test from XML to Groovy
> -
>
> Key: OFBIZ-11520
> URL: https://issues.apache.org/jira/browse/OFBIZ-11520
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11520.patch
>
>
> Convert testCreateFixedAssetMeter test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11519) Convert testCreateFixedAssetMaint test from XML to Groovy

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11519:
---

Assignee: Pawan Verma  (was: Rohit Hukkeri)

> Convert testCreateFixedAssetMaint test from XML to Groovy
> -
>
> Key: OFBIZ-11519
> URL: https://issues.apache.org/jira/browse/OFBIZ-11519
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11519.patch
>
>
> Convert testCreateFixedAssetMaint test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11435) Remove and/or replace deprecated services

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11435:
-
Description: 
In the code base (in trunk) there are several services call functions which 
have been deprecated and replaced by newer functions, such as:
 * deleteRateAmount -> expireRateAmount
 * captureBillingAccountPayment -> captureBillingAccountPayments
 * createQuoteWorkEffort -> ensureWorkEffortAndCreateQuoteWorkEffort
 * addPriceRuleToMarketingCampaign -> createMarketingCampaignPrice
 * removePriceRuleFromMarketingCampaign -> deleteMarketingCampaignPrice
 * addPromoToMarketingCampaign -> createMarketingCampaignPromo
 * removePromoFromMarketingCampaign -> deleteMarketingCampaignPromo

These must be removed from trunk, when the time is there (to be done 
periodically). This is a long running ticket intended to enable committers to 
associate a removal to a ticket upon periodical clean-up without having to 
create new tickets.

It is suggested that committer the ticket under which a the replacement is 
committed is referenced here as a link.

  was:
Several services call functions which have been deprecated and replaced by 
newer functions in old release branches, like:
* deleteRateAmount -> expireRateAmount
* captureBillingAccountPayment -> captureBillingAccountPayments
* createQuoteWorkEffort -> ensureWorkEffortAndCreateQuoteWorkEffort
* addPriceRuleToMarketingCampaign -> createMarketingCampaignPrice
* removePriceRuleFromMarketingCampaign -> deleteMarketingCampaignPrice
* addPromoToMarketingCampaign -> createMarketingCampaignPromo
* removePromoFromMarketingCampaign -> deleteMarketingCampaignPromo

These must be removed from trunk.


> Remove and/or replace deprecated services
> -
>
> Key: OFBIZ-11435
> URL: https://issues.apache.org/jira/browse/OFBIZ-11435
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: refactoring
>
> In the code base (in trunk) there are several services call functions which 
> have been deprecated and replaced by newer functions, such as:
>  * deleteRateAmount -> expireRateAmount
>  * captureBillingAccountPayment -> captureBillingAccountPayments
>  * createQuoteWorkEffort -> ensureWorkEffortAndCreateQuoteWorkEffort
>  * addPriceRuleToMarketingCampaign -> createMarketingCampaignPrice
>  * removePriceRuleFromMarketingCampaign -> deleteMarketingCampaignPrice
>  * addPromoToMarketingCampaign -> createMarketingCampaignPromo
>  * removePromoFromMarketingCampaign -> deleteMarketingCampaignPromo
> These must be removed from trunk, when the time is there (to be done 
> periodically). This is a long running ticket intended to enable committers to 
> associate a removal to a ticket upon periodical clean-up without having to 
> create new tickets.
> It is suggested that committer the ticket under which a the replacement is 
> committed is referenced here as a link.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11517) Convert testCancelFixedAssetStdCost test from XML to Groovy

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11517:
---

Assignee: Pawan Verma  (was: Rohit Hukkeri)

> Convert testCancelFixedAssetStdCost test from XML to Groovy
> ---
>
> Key: OFBIZ-11517
> URL: https://issues.apache.org/jira/browse/OFBIZ-11517
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11517.patch
>
>
> Convert testCancelFixedAssetStdCost test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11565) Convert testGetRatesAmountsFromPartyId test from XML to Groovy

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11565:
---

Assignee: Pawan Verma  (was: Anushi Gupta)

> Convert testGetRatesAmountsFromPartyId test from XML to Groovy
> --
>
> Key: OFBIZ-11565
> URL: https://issues.apache.org/jira/browse/OFBIZ-11565
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11565.patch
>
>
> Convert testGetRatesAmountsFromPartyId test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11563) Convert testGetRateAmount test from XML to Groovy

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11563:
---

Assignee: Pawan Verma  (was: Anushi Gupta)

> Convert testGetRateAmount test from XML to Groovy
> -
>
> Key: OFBIZ-11563
> URL: https://issues.apache.org/jira/browse/OFBIZ-11563
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11563.patch
>
>
> Convert testGetRateAmount test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11564) COnvert testGetRatesAmountsFromWorkEffortId test from XML to Groovy

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-11564:
---

Assignee: Pawan Verma  (was: Anushi Gupta)

> COnvert testGetRatesAmountsFromWorkEffortId test from XML to Groovy
> ---
>
> Key: OFBIZ-11564
> URL: https://issues.apache.org/jira/browse/OFBIZ-11564
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11564.patch
>
>
> COnvert testGetRatesAmountsFromWorkEffortId test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11665) Theme files loading taking longer time

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma updated OFBIZ-11665:

Issue Type: Improvement  (was: Bug)

> Theme files loading taking longer time
> --
>
> Key: OFBIZ-11665
> URL: https://issues.apache.org/jira/browse/OFBIZ-11665
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 18.12.01, 17.12.04
>
> Attachments: OFBIZ-11665.patch
>
>
> Discussion Link: [https://markmail.org/message/nbmgrbzdwiqagzr2]
>  
> OFBiz searches all the Theme.xml files under ofbiz.home with 'themes' as a 
> partial path written under ThemeFactory.pullModelThemesFromXmlToCache(). The 
> problem occurs mainly when the runtime data is huge in the system, and it 
> increases the time since the current code also scans the Theme.xml under 
> runtime directory.
> A solution comes to mind which is to include 'themes' directory in the 
> basePath for the searching of Theme.xml file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11665) Theme files loading taking longer time

2020-05-10 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103720#comment-17103720
 ] 

Pawan Verma commented on OFBIZ-11665:
-

Hi [~pierresmits]

A system takes too much time because of poor implementation can be considered 
both as a bug or an improvement.  I have no issue to change the type to 
improvement. Changing it. Thanks!

> Theme files loading taking longer time
> --
>
> Key: OFBIZ-11665
> URL: https://issues.apache.org/jira/browse/OFBIZ-11665
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 18.12.01, 17.12.04
>
> Attachments: OFBIZ-11665.patch
>
>
> Discussion Link: [https://markmail.org/message/nbmgrbzdwiqagzr2]
>  
> OFBiz searches all the Theme.xml files under ofbiz.home with 'themes' as a 
> partial path written under ThemeFactory.pullModelThemesFromXmlToCache(). The 
> problem occurs mainly when the runtime data is huge in the system, and it 
> increases the time since the current code also scans the Theme.xml under 
> runtime directory.
> A solution comes to mind which is to include 'themes' directory in the 
> basePath for the searching of Theme.xml file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10975) Buttons on edit credit card page are shown twice

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-10975:
-
Summary: Buttons on edit credit card page are shown twice  (was: Improve 
the buttons on edit credit card page)

> Buttons on edit credit card page are shown twice
> 
>
> Key: OFBIZ-10975
> URL: https://issues.apache.org/jira/browse/OFBIZ-10975
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Padmavati Rawat
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 18.12.01, 17.12.04
>
> Attachments: Buttonissue.png, OFBIZ-10975.patch, OFBIZ-10975.patch
>
>
> Steps:
> 1. Visit the demo-trunk.ofbiz.apache.org/ecommerce.
> 2. Login to the system.
> 3. Add Credit card details for the customer on the customer profile page.
> 4. Check the Go Back and Save button after adding the credit card details.
> Actual:
> Go Back and Save button display twice on the header of the page, after adding 
> the credit card for the customer.
> Expected:
> The buttons should not be displayed twice after adding the credit card 
> details.
> Please refer screenshot;



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11666) Use OFBizTestCase's from method utility instead of using EntityQuery in each test case

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-11666.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Use OFBizTestCase's from method utility instead of using EntityQuery in each 
> test case
> --
>
> Key: OFBIZ-11666
> URL: https://issues.apache.org/jira/browse/OFBIZ-11666
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> As we have added EntityQuery's from method in OFBIZ-11247 we should use this 
> utility instead of using EntityQuery in each test case



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11665) Theme files loading taking longer time

2020-05-10 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103719#comment-17103719
 ] 

Pierre Smits commented on OFBIZ-11665:
--

Hi [~pawan],

This is in essence an improvement, not a bug fix.

> Theme files loading taking longer time
> --
>
> Key: OFBIZ-11665
> URL: https://issues.apache.org/jira/browse/OFBIZ-11665
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 18.12.01, 17.12.04
>
> Attachments: OFBIZ-11665.patch
>
>
> Discussion Link: [https://markmail.org/message/nbmgrbzdwiqagzr2]
>  
> OFBiz searches all the Theme.xml files under ofbiz.home with 'themes' as a 
> partial path written under ThemeFactory.pullModelThemesFromXmlToCache(). The 
> problem occurs mainly when the runtime data is huge in the system, and it 
> increases the time since the current code also scans the Theme.xml under 
> runtime directory.
> A solution comes to mind which is to include 'themes' directory in the 
> basePath for the searching of Theme.xml file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11666) Use OFBizTestCase's from method utility instead of using EntityQuery in each test case

2020-05-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103718#comment-17103718
 ] 

ASF subversion and git services commented on OFBIZ-11666:
-

Commit df0c4415689db4cd2e374942cc4806ca9a6bc91c in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=df0c441 ]

Improved: Use OFBizTestCase's from method utility instead of using EntityQuery 
in each test case (#119)

(OFBIZ-11666)

Also, removed some unused imports from the test cases files.

> Use OFBizTestCase's from method utility instead of using EntityQuery in each 
> test case
> --
>
> Key: OFBIZ-11666
> URL: https://issues.apache.org/jira/browse/OFBIZ-11666
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
>
> As we have added EntityQuery's from method in OFBIZ-11247 we should use this 
> utility instead of using EntityQuery in each test case



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11665) Theme files loading taking longer time

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-11665.
---
Fix Version/s: 17.12.04
   18.12.01
   Resolution: Fixed

> Theme files loading taking longer time
> --
>
> Key: OFBIZ-11665
> URL: https://issues.apache.org/jira/browse/OFBIZ-11665
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 18.12.01, 17.12.04
>
> Attachments: OFBIZ-11665.patch
>
>
> Discussion Link: [https://markmail.org/message/nbmgrbzdwiqagzr2]
>  
> OFBiz searches all the Theme.xml files under ofbiz.home with 'themes' as a 
> partial path written under ThemeFactory.pullModelThemesFromXmlToCache(). The 
> problem occurs mainly when the runtime data is huge in the system, and it 
> increases the time since the current code also scans the Theme.xml under 
> runtime directory.
> A solution comes to mind which is to include 'themes' directory in the 
> basePath for the searching of Theme.xml file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11665) Theme files loading taking longer time

2020-05-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103717#comment-17103717
 ] 

ASF subversion and git services commented on OFBIZ-11665:
-

Commit 6b04468f4559a31d9bc9d043060fac8f7b5a5cdd in ofbiz-framework's branch 
refs/heads/release17.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6b04468 ]

Fixed: Theme files loading taking longer time
(OFBIZ-11665)

Thanks: Pierre and Jacques for the review.


> Theme files loading taking longer time
> --
>
> Key: OFBIZ-11665
> URL: https://issues.apache.org/jira/browse/OFBIZ-11665
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-11665.patch
>
>
> Discussion Link: [https://markmail.org/message/nbmgrbzdwiqagzr2]
>  
> OFBiz searches all the Theme.xml files under ofbiz.home with 'themes' as a 
> partial path written under ThemeFactory.pullModelThemesFromXmlToCache(). The 
> problem occurs mainly when the runtime data is huge in the system, and it 
> increases the time since the current code also scans the Theme.xml under 
> runtime directory.
> A solution comes to mind which is to include 'themes' directory in the 
> basePath for the searching of Theme.xml file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11665) Theme files loading taking longer time

2020-05-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103716#comment-17103716
 ] 

ASF subversion and git services commented on OFBIZ-11665:
-

Commit e15c82b2542717bff5ad57cebc6c106fed192614 in ofbiz-framework's branch 
refs/heads/release18.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e15c82b ]

Fixed: Theme files loading taking longer time
(OFBIZ-11665)

Thanks: Pierre and Jacques for the review.


> Theme files loading taking longer time
> --
>
> Key: OFBIZ-11665
> URL: https://issues.apache.org/jira/browse/OFBIZ-11665
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-11665.patch
>
>
> Discussion Link: [https://markmail.org/message/nbmgrbzdwiqagzr2]
>  
> OFBiz searches all the Theme.xml files under ofbiz.home with 'themes' as a 
> partial path written under ThemeFactory.pullModelThemesFromXmlToCache(). The 
> problem occurs mainly when the runtime data is huge in the system, and it 
> increases the time since the current code also scans the Theme.xml under 
> runtime directory.
> A solution comes to mind which is to include 'themes' directory in the 
> basePath for the searching of Theme.xml file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11665) Theme files loading taking longer time

2020-05-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103714#comment-17103714
 ] 

ASF subversion and git services commented on OFBIZ-11665:
-

Commit 8bd7b9b6f9dac17d2afcd76e9305b5ed0bd2be1c in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8bd7b9b ]

Fixed: Theme files loading taking longer time
(OFBIZ-11665)

Thanks: Pierre and Jacques for the review.


> Theme files loading taking longer time
> --
>
> Key: OFBIZ-11665
> URL: https://issues.apache.org/jira/browse/OFBIZ-11665
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-11665.patch
>
>
> Discussion Link: [https://markmail.org/message/nbmgrbzdwiqagzr2]
>  
> OFBiz searches all the Theme.xml files under ofbiz.home with 'themes' as a 
> partial path written under ThemeFactory.pullModelThemesFromXmlToCache(). The 
> problem occurs mainly when the runtime data is huge in the system, and it 
> increases the time since the current code also scans the Theme.xml under 
> runtime directory.
> A solution comes to mind which is to include 'themes' directory in the 
> basePath for the searching of Theme.xml file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-10975) Improve the buttons on edit credit card page

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-10975.
---
Fix Version/s: 17.12.04
   18.12.01
   Resolution: Fixed

> Improve the buttons on edit credit card page
> 
>
> Key: OFBIZ-10975
> URL: https://issues.apache.org/jira/browse/OFBIZ-10975
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Padmavati Rawat
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 18.12.01, 17.12.04
>
> Attachments: Buttonissue.png, OFBIZ-10975.patch, OFBIZ-10975.patch
>
>
> Steps:
> 1. Visit the demo-trunk.ofbiz.apache.org/ecommerce.
> 2. Login to the system.
> 3. Add Credit card details for the customer on the customer profile page.
> 4. Check the Go Back and Save button after adding the credit card details.
> Actual:
> Go Back and Save button display twice on the header of the page, after adding 
> the credit card for the customer.
> Expected:
> The buttons should not be displayed twice after adding the credit card 
> details.
> Please refer screenshot;



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10975) Improve the buttons on edit credit card page

2020-05-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103706#comment-17103706
 ] 

ASF subversion and git services commented on OFBIZ-10975:
-

Commit 369088d7320fa4b14e11d78d0ecfae0d16675246 in ofbiz-plugins's branch 
refs/heads/release17.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=369088d ]

Fixed: Improve the buttons on edit credit card page
(OFBIZ-10975)

Thanks: Sourabh and Suraj for your contribution.


> Improve the buttons on edit credit card page
> 
>
> Key: OFBIZ-10975
> URL: https://issues.apache.org/jira/browse/OFBIZ-10975
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Padmavati Rawat
>Assignee: Pawan Verma
>Priority: Major
> Attachments: Buttonissue.png, OFBIZ-10975.patch, OFBIZ-10975.patch
>
>
> Steps:
> 1. Visit the demo-trunk.ofbiz.apache.org/ecommerce.
> 2. Login to the system.
> 3. Add Credit card details for the customer on the customer profile page.
> 4. Check the Go Back and Save button after adding the credit card details.
> Actual:
> Go Back and Save button display twice on the header of the page, after adding 
> the credit card for the customer.
> Expected:
> The buttons should not be displayed twice after adding the credit card 
> details.
> Please refer screenshot;



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10975) Improve the buttons on edit credit card page

2020-05-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103705#comment-17103705
 ] 

ASF subversion and git services commented on OFBIZ-10975:
-

Commit aa7008407b47049a0c518ccb498c91fd8edccd27 in ofbiz-plugins's branch 
refs/heads/release18.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=aa70084 ]

Fixed: Improve the buttons on edit credit card page
(OFBIZ-10975)

Thanks: Sourabh and Suraj for your contribution.


> Improve the buttons on edit credit card page
> 
>
> Key: OFBIZ-10975
> URL: https://issues.apache.org/jira/browse/OFBIZ-10975
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Padmavati Rawat
>Assignee: Pawan Verma
>Priority: Major
> Attachments: Buttonissue.png, OFBIZ-10975.patch, OFBIZ-10975.patch
>
>
> Steps:
> 1. Visit the demo-trunk.ofbiz.apache.org/ecommerce.
> 2. Login to the system.
> 3. Add Credit card details for the customer on the customer profile page.
> 4. Check the Go Back and Save button after adding the credit card details.
> Actual:
> Go Back and Save button display twice on the header of the page, after adding 
> the credit card for the customer.
> Expected:
> The buttons should not be displayed twice after adding the credit card 
> details.
> Please refer screenshot;



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10975) Improve the buttons on edit credit card page

2020-05-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103704#comment-17103704
 ] 

ASF subversion and git services commented on OFBIZ-10975:
-

Commit b7baeb2b5fce33a2ddf4255782691248f12d44a1 in ofbiz-plugins's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=b7baeb2 ]

Fixed: Improve the buttons on edit credit card page
(OFBIZ-10975)

Thanks: Sourabh and Suraj for your contribution.


> Improve the buttons on edit credit card page
> 
>
> Key: OFBIZ-10975
> URL: https://issues.apache.org/jira/browse/OFBIZ-10975
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Padmavati Rawat
>Assignee: Pawan Verma
>Priority: Major
> Attachments: Buttonissue.png, OFBIZ-10975.patch, OFBIZ-10975.patch
>
>
> Steps:
> 1. Visit the demo-trunk.ofbiz.apache.org/ecommerce.
> 2. Login to the system.
> 3. Add Credit card details for the customer on the customer profile page.
> 4. Check the Go Back and Save button after adding the credit card details.
> Actual:
> Go Back and Save button display twice on the header of the page, after adding 
> the credit card for the customer.
> Expected:
> The buttons should not be displayed twice after adding the credit card 
> details.
> Please refer screenshot;



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-8408) Convert existing CRUD services into entity-auto

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-8408:

Labels: refactoring  (was: )

> Convert existing CRUD services into entity-auto
> ---
>
> Key: OFBIZ-8408
> URL: https://issues.apache.org/jira/browse/OFBIZ-8408
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Deepak Dixit
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: refactoring
>
> Convert existing CRUD services into entity-auto.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11662) Convert all GlReconciliationEntry related CRUD services from simple to entity-auto

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11662:
-
Labels: refactoring  (was: )

> Convert all GlReconciliationEntry related CRUD services from simple to 
> entity-auto
> --
>
> Key: OFBIZ-11662
> URL: https://issues.apache.org/jira/browse/OFBIZ-11662
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: refactoring
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11689) Convert CustomTimePeriod services from simple to entity-auto

2020-05-10 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-11689:


 Summary: Convert CustomTimePeriod services from simple to 
entity-auto
 Key: OFBIZ-11689
 URL: https://issues.apache.org/jira/browse/OFBIZ-11689
 Project: OFBiz
  Issue Type: Sub-task
  Components: framework/common
Affects Versions: Trunk
Reporter: Pierre Smits


Applicable services:
 * createCustomTimePeriod

 * updateCustomTimePeriod

 * deleteCustomTimePeriod



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9350) Deprecate Mini Lang

2020-05-10 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103701#comment-17103701
 ] 

Pierre Smits commented on OFBIZ-9350:
-

There may be some services invoking minilang functions that are listed as  to 
be migrated to groovy and may be better be migrated to entity-auto services. 
See related ticket OFBIZ-8408

> Deprecate Mini Lang
> ---
>
> Key: OFBIZ-9350
> URL: https://issues.apache.org/jira/browse/OFBIZ-9350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: documentation, refactoring
>
> According to the proposal thread in [1] we decided to deprecate mini lang.
> This issue tracks the next steps proposed in the aformentioned thread, namely:
> 1. create a Wiki page for the documentation and description of the migration 
> process and how mini lang will be replaced.
> 2. prominently state in the Wiki that minilang will be deprecated, e.g. in [2]
> 3. put deprecation tags in the corresponding code
> 4. kindly ask contributors with open patches written in mini lang to replace 
> them by Groovy code [3]
> 5. start an initiative to replace existing mini lang code with Groovy code 
> where applicable. This needs some more planning and discussion which parts 
> we'll like to replace with Groovy code and which parts will better be 
> replaced by some kind of DSL. A good starting point can be [4][5][6].
> [1] 
> [https://lists.apache.org/thread.html/253b41060a295b8ab68bc78763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E]
>  [2] 
> [https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference]
>  [3] does anyone know a way to batch comment Jira issues like it is possible 
> in Redmine?
>  [4] 
> [https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic]
>  [5] 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide]
>  [6] [https://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11667) Improve logging for services run on global-commit/global-rollback

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-11667.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Improve logging for services run on global-commit/global-rollback
> -
>
> Key: OFBIZ-11667
> URL: https://issues.apache.org/jira/browse/OFBIZ-11667
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/service
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11667.patch, OFBIZ-11667.patch
>
>
> Improve logging for services run on global-commit/global-rollback



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11667) Improve logging for services run on global-commit/global-rollback

2020-05-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103700#comment-17103700
 ] 

ASF subversion and git services commented on OFBIZ-11667:
-

Commit de07647bfe3b22f94f60e535cc6835af8be859e2 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=de07647 ]

Improved: Improve logging for services run on global-commit/global-rollback
(OFBIZ-11667)

Thanks: Jacques and Suraj for the review.


> Improve logging for services run on global-commit/global-rollback
> -
>
> Key: OFBIZ-11667
> URL: https://issues.apache.org/jira/browse/OFBIZ-11667
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/service
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11667.patch, OFBIZ-11667.patch
>
>
> Improve logging for services run on global-commit/global-rollback



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11670) Add support for Limit and offset in EntityQuery

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-11670.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Add support for Limit and offset in EntityQuery
> ---
>
> Key: OFBIZ-11670
> URL: https://issues.apache.org/jira/browse/OFBIZ-11670
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/entity
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11670.patch
>
>
> As we have support for limit and offset in all delegator methods via 
> EntityFindOptions, We should also add support for limit and offset in 
> EntityQuery.
> It will be pretty easy to use these features via EntityQuery and it also 
> doesn't need many changes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11670) Add support for Limit and offset in EntityQuery

2020-05-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103697#comment-17103697
 ] 

ASF subversion and git services commented on OFBIZ-11670:
-

Commit 12ef8dc443b936c9dbd407b16c3de65cf6a9 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=12ef222 ]

Improved: Add support for Limit and offset in EntityQuery
(OFBIZ-11670)

Thanks: Jacques and Suraj for the review.


> Add support for Limit and offset in EntityQuery
> ---
>
> Key: OFBIZ-11670
> URL: https://issues.apache.org/jira/browse/OFBIZ-11670
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/entity
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11670.patch
>
>
> As we have support for limit and offset in all delegator methods via 
> EntityFindOptions, We should also add support for limit and offset in 
> EntityQuery.
> It will be pretty easy to use these features via EntityQuery and it also 
> doesn't need many changes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11688) unable to load main class org.gradle.wrapper.GradleWrapperMain

2020-05-10 Thread muhammad (Jira)
muhammad created OFBIZ-11688:


 Summary: unable to load main class 
org.gradle.wrapper.GradleWrapperMain
 Key: OFBIZ-11688
 URL: https://issues.apache.org/jira/browse/OFBIZ-11688
 Project: OFBiz
  Issue Type: Bug
Reporter: muhammad


Hi everybody,

 

I'm fedora user, for run ofbiz i meet an error!!!

Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain

How to fix it?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #18: improved: update data set(s) various plugins (OFBIZ-6976)

2020-05-10 Thread GitBox


sonarcloud[bot] removed a comment on pull request #18:
URL: https://github.com/apache/ofbiz-plugins/pull/18#issuecomment-625746388


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #18: improved: update data set(s) various plugins (OFBIZ-6976)

2020-05-10 Thread GitBox


sonarcloud[bot] commented on pull request #18:
URL: https://github.com/apache/ofbiz-plugins/pull/18#issuecomment-626290204


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=18=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=18=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (OFBIZ-8014) Introduce the "Product" Screen under Party app to manage the products supplied by any supplier

2020-05-10 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-8014:
--

Assignee: Chinmay Patidar  (was: Pawan Verma)

> Introduce the "Product" Screen under Party app to manage the products 
> supplied by any supplier
> --
>
> Key: OFBIZ-8014
> URL: https://issues.apache.org/jira/browse/OFBIZ-8014
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Affects Versions: Release Branch 14.12, 16.11.01, Release Branch 15.12
>Reporter: Swapnil Shah
>Assignee: Chinmay Patidar
>Priority: Major
> Attachments: OFBIZ-8014.patch, OFBIZ-8014.patch, SupplierProduct.png
>
>
> Currently, upon logging into the Party application (or login as supplier 
> itself) and go to any specific supplier view then there is no way to manage 
> the list of supplied products. 
> # We can try introducing the "Product" tab/screen along with other tabs. (to 
> begin with we can simply mimic the Supplier screen from Catalog app e.g., 
> https://ofbiz-vm.apache.org:8443/catalog/control/EditProductSuppliers?productId=MAT_A_COST)
>  
> # We can also choose to show the "Products" tab for only Parties in supplier 
> role and later can try to extend for other roles with further needed 
> refinements. 
> Please refer to attached screenshot for the same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-8014) Introduce the "Product" Screen under Party app to manage the products supplied by any supplier

2020-05-10 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103689#comment-17103689
 ] 

Pawan Verma commented on OFBIZ-8014:


I picked it because we have Swapnil's strong arguments and Jacques +1 for the 
commit. So thought we are unanimous for the implementation.

As we have a difference in opinion, I agree this should be concluded first on 
dev ML.

[~chinmay.patidar] Could you please start a thread so that we can conclude this 
one? 

> Introduce the "Product" Screen under Party app to manage the products 
> supplied by any supplier
> --
>
> Key: OFBIZ-8014
> URL: https://issues.apache.org/jira/browse/OFBIZ-8014
> Project: OFBiz
>  Issue Type: New Feature
>  Components: party
>Affects Versions: Release Branch 14.12, 16.11.01, Release Branch 15.12
>Reporter: Swapnil Shah
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-8014.patch, OFBIZ-8014.patch, SupplierProduct.png
>
>
> Currently, upon logging into the Party application (or login as supplier 
> itself) and go to any specific supplier view then there is no way to manage 
> the list of supplied products. 
> # We can try introducing the "Product" tab/screen along with other tabs. (to 
> begin with we can simply mimic the Supplier screen from Catalog app e.g., 
> https://ofbiz-vm.apache.org:8443/catalog/control/EditProductSuppliers?productId=MAT_A_COST)
>  
> # We can also choose to show the "Products" tab for only Parties in supplier 
> role and later can try to extend for other roles with further needed 
> refinements. 
> Please refer to attached screenshot for the same.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL

2020-05-10 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103686#comment-17103686
 ] 

Jacques Le Roux commented on OFBIZ-11383:
-

Hi Priya,

Will you improve the patch?

> Convert createArticleContent service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11383
> URL: https://issues.apache.org/jira/browse/OFBIZ-11383
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch
>
>
> Convert createArticleContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-6164) Improve configurability of OFBiz

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6164:

Labels: configuration multi-tenant  (was: multi-tenant)

> Improve configurability of OFBiz
> 
>
> Key: OFBIZ-6164
> URL: https://issues.apache.org/jira/browse/OFBIZ-6164
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: configuration, multi-tenant
>
> The configuration of an OFBiz is determined by 2 aspects:
>  # configuration settings required to successfully start the implementation
>  # configuration settings required to have component functions work properly
> The latter involve default choices for various functions to cater to the 
> usability of business processes (and therefore screen/forms and/or 
> screens/templates.
> Several of these configuration settings are already loaded into the 
> SystemProperty table in the underlying RDBMS, to enable adjustments of the 
> systemPropertyValue while the implementation is in use. While it is not 
> expected that these settings change often, it is possible that they are 
> required to be changed during the lifespan of the company/organisation. 
> However, it should not be required to go through a deployment process of 
> regarding such changed configuration settings in the OFBiz production 
> instance (which most - if not all - companies/organisations require when 
> files are changes).
> Having all configuration settings of components in the SystemProperty table 
> enhances the usability of OFBiz allowing system administrators to adjust the 
> value(s) of system property records while the instance keeps running.
> Some examples of the latter kind of configuration settings expected to change 
> during the lifespan of the company (and the production instance of OFBiz) are:
> {code:java}
>      systemPropertyId="defaultFromEmailAddress" 
> systemPropertyValue="ofbizt...@example.com" description="general default 
> 'fromEmailAddress' can be overridden in: EmailTemplateSetting"/>
>      systemPropertyId="mail.notifications.enabled" systemPropertyValue="N" 
> description="mail notifications enabled (Y|N)"/>
>      systemPropertyId="mail.smtp.relay.host" description="the default mail server 
> to use"/>
>      systemPropertyId="mail.smtp.auth.user" description="SMTP Auth username 
> setting"/>
>      systemPropertyId="mail.smtp.auth.password" description="SMTP Auth password 
> setting"/>
> {code}
>  
> Furthermore, in a multi-tenancy OFBiz setup, configurations can differ per 
> tenant.
> This is a placeholder issue to capture related issues to improve the 
> configurability of OFBiz.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-6168) Move hard coded 'require_*' options in SetupEvents.xml to SystemProperty entity records.

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits closed OFBIZ-6168.
---
Resolution: Duplicate

Closing as being a duplicate of OFBIZ-6166

> Move hard coded 'require_*' options in SetupEvents.xml to SystemProperty 
> entity records.
> 
>
> Key: OFBIZ-6168
> URL: https://issues.apache.org/jira/browse/OFBIZ-6168
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, multi-tenant
>
> In UsersEvents.xml various create methods (e.g. createCustomer) have hard 
> coded configuration options, like .
> These kind of configurations shouldn't be hard coded, but configurable 
> through SystemProperty entity records.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-6168) Move hard coded 'require_*' options in SetupEvents.xml to SystemProperty entity records.

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-6168:
---

Assignee: Pierre Smits

> Move hard coded 'require_*' options in SetupEvents.xml to SystemProperty 
> entity records.
> 
>
> Key: OFBIZ-6168
> URL: https://issues.apache.org/jira/browse/OFBIZ-6168
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: commonext
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: configuration, multi-tenant
>
> In UsersEvents.xml various create methods (e.g. createCustomer) have hard 
> coded configuration options, like .
> These kind of configurations shouldn't be hard coded, but configurable 
> through SystemProperty entity records.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-6164) Improve configurability of OFBiz

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6164:

Description: 
The configuration of an OFBiz is determined by 2 aspects:
 # configuration settings required to successfully start the implementation
 # configuration settings required to have component functions work properly

The latter involve default choices for various functions to cater to the 
usability of business processes (and therefore screen/forms and/or 
screens/templates.

Several of these configuration settings are already loaded into the 
SystemProperty table in the underlying RDBMS, to enable adjustments of the 
systemPropertyValue while the implementation is in use. While it is not 
expected that these settings change often, it is possible that they are 
required to be changed during the lifespan of the company/organisation. 

However, it should not be required to go through a deployment process of 
regarding such changed configuration settings in the OFBiz production instance 
(which most - if not all - companies/organisations require when files are 
changes).

Having all configuration settings of components in the SystemProperty table 
enhances the usability of OFBiz allowing system administrators to adjust the 
value(s) of system property records while the instance keeps running.


Some examples of the latter kind of configuration settings expected to change 
during the lifespan of the company (and the production instance of OFBiz) are:
{code:java}
    
    
    
    
    
{code}
 


Furthermore, in a multi-tenancy OFBiz setup, configurations can differ per 
tenant.

This is a placeholder issue to capture related issues to improve the 
configurability of OFBiz.

  was:
Conf

In a multi-tenancy setup configurations can differ per tenant. This is a 
placeholder issue to capture related issues to improve the configurability of 
OFBiz per tenant.


> Improve configurability of OFBiz
> 
>
> Key: OFBIZ-6164
> URL: https://issues.apache.org/jira/browse/OFBIZ-6164
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: multi-tenant
>
> The configuration of an OFBiz is determined by 2 aspects:
>  # configuration settings required to successfully start the implementation
>  # configuration settings required to have component functions work properly
> The latter involve default choices for various functions to cater to the 
> usability of business processes (and therefore screen/forms and/or 
> screens/templates.
> Several of these configuration settings are already loaded into the 
> SystemProperty table in the underlying RDBMS, to enable adjustments of the 
> systemPropertyValue while the implementation is in use. While it is not 
> expected that these settings change often, it is possible that they are 
> required to be changed during the lifespan of the company/organisation. 
> However, it should not be required to go through a deployment process of 
> regarding such changed configuration settings in the OFBiz production 
> instance (which most - if not all - companies/organisations require when 
> files are changes).
> Having all configuration settings of components in the SystemProperty table 
> enhances the usability of OFBiz allowing system administrators to adjust the 
> value(s) of system property records while the instance keeps running.
> Some examples of the latter kind of configuration settings expected to change 
> during the lifespan of the company (and the production instance of OFBiz) are:
> {code:java}
>      systemPropertyId="defaultFromEmailAddress" 
> systemPropertyValue="ofbizt...@example.com" description="general default 
> 'fromEmailAddress' can be overridden in: EmailTemplateSetting"/>
>      systemPropertyId="mail.notifications.enabled" systemPropertyValue="N" 
> description="mail notifications enabled (Y|N)"/>
>      systemPropertyId="mail.smtp.relay.host" description="the default mail server 
> to use"/>
>      systemPropertyId="mail.smtp.auth.user" description="SMTP Auth username 
> setting"/>
>      systemPropertyId="mail.smtp.auth.password" description="SMTP Auth password 
> setting"/>
> {code}
>  
> Furthermore, in a multi-tenancy OFBiz setup, configurations can differ per 
> tenant.
> This is a placeholder issue to capture related issues to improve the 
> configurability of OFBiz.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-6164) Improve configurability of OFBiz

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6164:

Summary: Improve configurability of OFBiz  (was: Improve configurability of 
OFBiz regarding multi-tenancy)

> Improve configurability of OFBiz
> 
>
> Key: OFBIZ-6164
> URL: https://issues.apache.org/jira/browse/OFBIZ-6164
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: multi-tenant
>
> Conf
> In a multi-tenancy setup configurations can differ per tenant. This is a 
> placeholder issue to capture related issues to improve the configurability of 
> OFBiz per tenant.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-6164) Improve configurability of OFBiz regarding multi-tenancy

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-6164:

Description: 
Conf

In a multi-tenancy setup configurations can differ per tenant. This is a 
placeholder issue to capture related issues to improve the configurability of 
OFBiz per tenant.

  was:In a multi-tenancy setup configurations can differ per tenant. This is a 
placeholder issue to capture related issues to improve the configurability of 
OFBiz per tenant.


> Improve configurability of OFBiz regarding multi-tenancy
> 
>
> Key: OFBIZ-6164
> URL: https://issues.apache.org/jira/browse/OFBIZ-6164
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: multi-tenant
>
> Conf
> In a multi-tenancy setup configurations can differ per tenant. This is a 
> placeholder issue to capture related issues to improve the configurability of 
> OFBiz per tenant.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11687) Clicking on column title generates a "405" error

2020-05-10 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-11687:


 Summary: Clicking  on column title generates a "405" error
 Key: OFBIZ-11687
 URL: https://issues.apache.org/jira/browse/OFBIZ-11687
 Project: OFBiz
  Issue Type: Bug
  Components: framework/webtools
Affects Versions: Trunk
Reporter: Pierre Smits


When clicking on a column title to sort the result in the results overview 
generates following error:
{code:java}
405 The requested method GET is not allowed for this URL.
{code}

To reproduce:
# Go to: 
https://demo-trunk.ofbiz.apache.org/webtools/control/entity/find/SystemProperty?systemResourceId_op=equals_fld1_op=opLessThan_op=equals_ic=Y_fld0_op=greaterThan_ic=Y_fld0_op=greaterThan_fld0_op=greaterThan_collapsed=true_fld0_op=greaterThan_ic=Y=Y_op=contains_fld1_op=opLessThan&_method=GET_fld1_op=opLessThan_op=contains_fld1_op=opLessThan_ic=Y_SIZE_1=200_INDEX_1=0
# Click on column title 'System Resource ID' to sort the result
See error shown



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11268) SVN to GIT Migration

2020-05-10 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11268:


Assignee: (was: Pierre Smits)

> SVN to GIT Migration
> 
>
> Key: OFBIZ-11268
> URL: https://issues.apache.org/jira/browse/OFBIZ-11268
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Deepak Dixit
>Priority: Major
>
> This is the parent task to track actions needed as a result of the SVN to Git 
> migration.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)