[jira] [Commented] (OFBIZ-2219) Special issue to allow submitting patches for online help update

[A.I (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116457#comment-17116457
 ] 

A.I commented on OFBIZ-2219:


Can this do both ways? Apache Ofbiz say Java 1.8 SDK. Latest JDBC on MS 
mssql-jdbc-8.2.2.jre8, mssql-jdbc-8.2.2.jre11, mssql-jdbc-8.2.2.jre13 to work 
with mssql2019. Because on the Apache OfBiz website it has only talked about 
lower version. My aim is to make mssql2019 work with Ofbiz 17.12.03.

> Special issue to allow submitting patches for online help update
> 
>
> Key: OFBIZ-2219
> URL: https://issues.apache.org/jira/browse/OFBIZ-2219
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: HelpAccounting.jpg, 
> OFBIZ-2219_DocbookAccountingHelp10.patch, build.xml
>
>
> *This issue should not be closed, at least until the online help is 
> completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from 
> OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan 
> if she could update this links, while she is improving documentation, and she 
> agreed. So this issue is to allow her, and anybody else, to submit patches to 
> improve the online help (not only accounting of course hence the ALL 
> COMPONENTS)
> We commit only the [ones 
> completed|https://issues.apache.org/jira/browse/OFBIZ-4175?focusedCommentId=12993718=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12993718]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc

[Aditya Sharma (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116452#comment-17116452
 ] 

Aditya Sharma commented on OFBIZ-11574:
---

Great. I will cherry-pick and backport the changes then.

> DATAMODEL_CHANGE migration to asciidoc
> --
>
> Key: OFBIZ-11574
> URL: https://issues.apache.org/jira/browse/OFBIZ-11574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format 
> to asciidoc
> Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine 
> chapter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

[Aditya Sharma (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116441#comment-17116441
 ] 

Aditya Sharma edited comment on OFBIZ-11304 at 5/26/20, 5:30 AM:
-

Reference to recent discussion on dev mailing list:

[https://markmail.org/message/4x6tt4qebx4hqv7x]

Quoting my comment:
{quote}I think *check styles* plugin is important for us and we should think of 
introducing a pre-commit hook that checks only for the staged changes. This 
will help developers to know about the lint issues before the commit itself.

Some reference I found that achieves the above case. Though I didn't try any of 
these solutions.

[https://ebaytech.berlin/checkstyle-on-changed-files-with-gradle-1619e49dbe4e] 
[https://stackoverflow.com/questions/43730901/is-there-a-way-to-run-checkstyle-on-only-files-that-have-changes-in-vcs]
 [https://ealebed.github.io/posts/2020/gradle-checkstyle-on-changed-files-only/]
{quote}
 

Adding to that

 I think we can also use a Gradle plugin to add pre-commit hook. This way it 
can be more configurable for the OFBiz community to make appropriate changes to 
it when needed.

Here is the link to PR I have created
 [https://github.com/apache/ofbiz-framework/pull/161/files]

In this PR, check style works only on staged files.

To test the above PR:
 1. Create a test branch on local
 2. Add some spacing or any other change in java file that doesn't comply to 
standards
 3. Try a test commit

I can think of only one issue with above code that if the file staged already 
has some lint issues it will show errors. We can also fix them with the current 
work mentioning it in commit message, this will reduce the existing burden. 
Though we can always use no-verify flag to bypass the pre-commit hook.
{code:java}
git commit --no-verify
 
{code}
{{Wdyat?}}


was (Author: aditya.sharma):
Reference to recent discussion on dev mailing list:

[https://markmail.org/message/4x6tt4qebx4hqv7x]

Quoting my comment:
{quote}I think *check styles* plugin is important for us and we should think of 
introducing a pre-commit hook that checks only for the staged changes. This 
will help developers to know about the lint issues before the commit itself.

Some reference I found that achieves the above case. Though I didn't try any of 
these solutions.

[https://ebaytech.berlin/checkstyle-on-changed-files-with-gradle-1619e49dbe4e] 
[https://stackoverflow.com/questions/43730901/is-there-a-way-to-run-checkstyle-on-only-files-that-have-changes-in-vcs]
 [https://ealebed.github.io/posts/2020/gradle-checkstyle-on-changed-files-only/]
{quote}
 

Adding to that

 I think we can also use a Gradle plugin to add pre-commit hook. This way it 
can be more configurable for the OFBiz community to make appropriate changes to 
it when needed.

Here is the link to PR I have created
 [https://github.com/apache/ofbiz-framework/pull/161/files]

In this PR, check style works only on staged files.

To test the above PR:
 1. Create a test branch on local
 2. Add some spacing or any other change in java file that doesn't comply to 
standards
 3. Try a test commit

I can think of only one issue with above code that if the file staged already 
has some lint issues it will show errors. We can also fix them with the current 
work mentioning it commit, this will reduce the existing burden. Though we can 
always use no-verify flag to bypass the pre-commit hook.
{code:java}
git commit --no-verify
 
{code}
{{Wdyat?}}

> Install a Checkstyle pre-push (on every committer machine?)
> ---
>
> Key: OFBIZ-11304
> URL: https://issues.apache.org/jira/browse/OFBIZ-11304
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by 
> the check gradle task. It's "hard" to exactly know from where lint errors  
> come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like 
> https://gist.github.com/davetron5000/37350 to complement 
> tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when 
> a lint error is present in the commit. 
> Every committer would have it installed locally and the problem would be gone 
> with some committers good will. I started a discussion about it at 
> https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same 
> proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

[Aditya Sharma (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116441#comment-17116441
 ] 

Aditya Sharma edited comment on OFBIZ-11304 at 5/26/20, 5:29 AM:
-

Reference to recent discussion on dev mailing list:

[https://markmail.org/message/4x6tt4qebx4hqv7x]

Quoting my comment:
{quote}I think *check styles* plugin is important for us and we should think of 
introducing a pre-commit hook that checks only for the staged changes. This 
will help developers to know about the lint issues before the commit itself.

Some reference I found that achieves the above case. Though I didn't try any of 
these solutions.

[https://ebaytech.berlin/checkstyle-on-changed-files-with-gradle-1619e49dbe4e] 
[https://stackoverflow.com/questions/43730901/is-there-a-way-to-run-checkstyle-on-only-files-that-have-changes-in-vcs]
 [https://ealebed.github.io/posts/2020/gradle-checkstyle-on-changed-files-only/]
{quote}
 

Adding to that

 I think we can also use a Gradle plugin to add pre-commit hook. This way it 
can be more configurable for the OFBiz community to make appropriate changes to 
it when needed.

Here is the link to PR I have created
 [https://github.com/apache/ofbiz-framework/pull/161/files]

In this PR, check style works only on staged files.

To test the above PR:
 1. Create a test branch on local
 2. Add some spacing or any other change in java file that doesn't comply to 
standards
 3. Try a test commit

I can think of only one issue with above code that if the file staged already 
has some lint issues it will show errors. We can also fix them with the current 
work mentioning it commit, this will reduce the existing burden. Though we can 
always use no-verify flag to bypass the pre-commit hook.
{code:java}
git commit --no-verify
 
{code}
{{Wdyat?}}


was (Author: aditya.sharma):
Reference to recent discussion on dev mailing list:

https://markmail.org/message/4x6tt4qebx4hqv7x

Quoting my comment:
{quote}I think *check styles* plugin is important for us and we should think of 
introducing a pre-commit hook that checks only for the staged changes. This 
will help developers to know about the lint issues before the commit itself.

Some reference I found that achieves the above case. Though I didn't try any of 
these solutions.

[https://ebaytech.berlin/checkstyle-on-changed-files-with-gradle-1619e49dbe4e] 
[https://stackoverflow.com/questions/43730901/is-there-a-way-to-run-checkstyle-on-only-files-that-have-changes-in-vcs]
 [https://ealebed.github.io/posts/2020/gradle-checkstyle-on-changed-files-only/]
{quote}
 

Adding to that

 I think we can also use a Gradle plugin to add pre-commit hook. This way it 
can be more configurable for the OFBiz community to make appropriate changes to 
it when needed.

Here is the link to PR I have created
[https://github.com/apache/ofbiz-framework/pull/161/files]

In this PR, check style works only on staged files.

To test the above PR:
1. Create a test branch on local
2. Add some spacing or any other change in java file that doesn't comply to 
standards
3. Try a test commit 

I can think of only one issue with above code that if the file staged already 
has some lint issues it will show errors. We can also fix them with the current 
work mentioning it commit, this will reduce the existing burden. Though we can 
always use no-verify flag to bypass the pre-commit hook.

{{}}
{code:java}
git commit --no-verify
 
{code}
{{Wdyat?}}

> Install a Checkstyle pre-push (on every committer machine?)
> ---
>
> Key: OFBIZ-11304
> URL: https://issues.apache.org/jira/browse/OFBIZ-11304
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by 
> the check gradle task. It's "hard" to exactly know from where lint errors  
> come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like 
> https://gist.github.com/davetron5000/37350 to complement 
> tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when 
> a lint error is present in the commit. 
> Every committer would have it installed locally and the problem would be gone 
> with some committers good will. I started a discussion about it at 
> https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same 
> proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

[Aditya Sharma (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116441#comment-17116441
 ] 

Aditya Sharma commented on OFBIZ-11304:
---

Reference to recent discussion on dev mailing list:

https://markmail.org/message/4x6tt4qebx4hqv7x

Quoting my comment:
{quote}I think *check styles* plugin is important for us and we should think of 
introducing a pre-commit hook that checks only for the staged changes. This 
will help developers to know about the lint issues before the commit itself.

Some reference I found that achieves the above case. Though I didn't try any of 
these solutions.

[https://ebaytech.berlin/checkstyle-on-changed-files-with-gradle-1619e49dbe4e] 
[https://stackoverflow.com/questions/43730901/is-there-a-way-to-run-checkstyle-on-only-files-that-have-changes-in-vcs]
 [https://ealebed.github.io/posts/2020/gradle-checkstyle-on-changed-files-only/]
{quote}
 

Adding to that

 I think we can also use a Gradle plugin to add pre-commit hook. This way it 
can be more configurable for the OFBiz community to make appropriate changes to 
it when needed.

Here is the link to PR I have created
[https://github.com/apache/ofbiz-framework/pull/161/files]

In this PR, check style works only on staged files.

To test the above PR:
1. Create a test branch on local
2. Add some spacing or any other change in java file that doesn't comply to 
standards
3. Try a test commit 

I can think of only one issue with above code that if the file staged already 
has some lint issues it will show errors. We can also fix them with the current 
work mentioning it commit, this will reduce the existing burden. Though we can 
always use no-verify flag to bypass the pre-commit hook.

{{}}
{code:java}
git commit --no-verify
 
{code}
{{Wdyat?}}

> Install a Checkstyle pre-push (on every committer machine?)
> ---
>
> Key: OFBIZ-11304
> URL: https://issues.apache.org/jira/browse/OFBIZ-11304
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by 
> the check gradle task. It's "hard" to exactly know from where lint errors  
> come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like 
> https://gist.github.com/davetron5000/37350 to complement 
> tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when 
> a lint error is present in the commit. 
> Every committer would have it installed locally and the problem would be gone 
> with some committers good will. I started a discussion about it at 
> https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same 
> proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-2219) Special issue to allow submitting patches for online help update

[A.I (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116434#comment-17116434
 ] 

A.I commented on OFBIZ-2219:


Exception in thread "main" java.lang.UnsupportedClassVersionError: 
com/microsoft/sqlserver/jdbc/SQLServerDriver has been compiled by a more recent 
version of the Java Runtime (class file version 55.0), this version of the Java 
Runtime only recognizes class file versions up to 52.0

> Special issue to allow submitting patches for online help update
> 
>
> Key: OFBIZ-2219
> URL: https://issues.apache.org/jira/browse/OFBIZ-2219
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: HelpAccounting.jpg, 
> OFBIZ-2219_DocbookAccountingHelp10.patch, build.xml
>
>
> *This issue should not be closed, at least until the online help is 
> completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from 
> OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan 
> if she could update this links, while she is improving documentation, and she 
> agreed. So this issue is to allow her, and anybody else, to submit patches to 
> improve the online help (not only accounting of course hence the ALL 
> COMPONENTS)
> We commit only the [ones 
> completed|https://issues.apache.org/jira/browse/OFBIZ-4175?focusedCommentId=12993718=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12993718]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11740) Handle FileLength Checkstyle rule

[Suraj Khurana (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116428#comment-17116428
 ] 

Suraj Khurana commented on OFBIZ-11740:
---

Thanks Jacques for creating the ticket.

> Handle FileLength Checkstyle rule 
> --
>
> Key: OFBIZ-11740
> URL: https://issues.apache.org/jira/browse/OFBIZ-11740
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: filesLengths.txt
>
>
> Hi All,
> [~surajk] rightly mentioned directly to me in Slack that we have no 
> FileLength checkstyle rule and the max default is 2000 lines: 
> https://checkstyle.sourceforge.io/config_sizes.html#FileLength
> We have some very large Java files in trunk  ( see [^filesLengths.txt])  and 
> few (19) are longer than 2000 lines:
> {noformat}
> 2059 
> ./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
> 2131 
> ./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartEvents.java
> 2581 
> ./applications/product/src/main/java/org/apache/ofbiz/product/product/ProductSearch.java
> 2631 
> ./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java
> 2643 
> ./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReturnServices.java
> 2662 
> ./framework/entity/src/main/java/org/apache/ofbiz/entity/GenericDelegator.java
> 2676 
> ./applications/party/src/main/java/org/apache/ofbiz/party/party/PartyServices.java
> 2811 
> ./framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
> 2953 
> ./plugins/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayStore.java
> 3133 
> ./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReadHelper.java
> 3433 
> ./framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
> 3638 
> ./applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
> 3712 
> ./applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java
> 3720 
> ./applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/PaymentGatewayServices.java
> 3734 
> ./applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java
> 4417 
> ./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
> 5437 
> ./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
> 7194 
> ./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java
> {noformat}
> The question is should we increase to hide the issue (19 errors) or try to 
> split those files, if it makes sense in some cases...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11472) Demo instance setup for OFBiz 17.12 release and obsolete 13.07 demo

[Swapnil Mane (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116423#comment-17116423
 ] 

Swapnil Mane commented on OFBIZ-11472:
--

Thank you [~jleroux], was waiting for your approval.
Closing the ticket, thanks!

> Demo instance setup for OFBiz 17.12 release and obsolete 13.07 demo
> ---
>
> Key: OFBIZ-11472
> URL: https://issues.apache.org/jira/browse/OFBIZ-11472
> Project: OFBiz
>  Issue Type: Task
>  Components: Demo
>Reporter: Swapnil Mane
>Assignee: Swapnil Mane
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As discussed at [https://s.apache.org/kn1f9] thread,
> We will setup new demo instance for 17.12 and obsolete 13.07. 
> The OFBiz demos are hosted at ofbiz-vm3.apache.org VM
> Currently, OFBiz has three demo instance:
> -- Previous Stable Release 13.07 - Demo
> https://demo-old.ofbiz.apache.org/ordermgr/control/main
> -- Current Stable Release 16.11 - Demo
> https://demo-stable.ofbiz.apache.org/ordermgr/control/main
> -- Developer Trunk - Demo
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/main
> So, as per new plan.
> https://demo-old.ofbiz.apache.org will point to 16.11 (which is currently 
> pointed at https://demo-stable.ofbiz.apache.org)
> And the newly setup 17.12 will be served at 
> https://demo-stable.ofbiz.apache.org
>  
> For this, we will need to make changes in the deployment scripts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-11472) Demo instance setup for OFBiz 17.12 release and obsolete 13.07 demo

[Swapnil Mane (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Mane closed OFBIZ-11472.

Resolution: Done

> Demo instance setup for OFBiz 17.12 release and obsolete 13.07 demo
> ---
>
> Key: OFBIZ-11472
> URL: https://issues.apache.org/jira/browse/OFBIZ-11472
> Project: OFBiz
>  Issue Type: Task
>  Components: Demo
>Reporter: Swapnil Mane
>Assignee: Swapnil Mane
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As discussed at [https://s.apache.org/kn1f9] thread,
> We will setup new demo instance for 17.12 and obsolete 13.07. 
> The OFBiz demos are hosted at ofbiz-vm3.apache.org VM
> Currently, OFBiz has three demo instance:
> -- Previous Stable Release 13.07 - Demo
> https://demo-old.ofbiz.apache.org/ordermgr/control/main
> -- Current Stable Release 16.11 - Demo
> https://demo-stable.ofbiz.apache.org/ordermgr/control/main
> -- Developer Trunk - Demo
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/main
> So, as per new plan.
> https://demo-old.ofbiz.apache.org will point to 16.11 (which is currently 
> pointed at https://demo-stable.ofbiz.apache.org)
> And the newly setup 17.12 will be served at 
> https://demo-stable.ofbiz.apache.org
>  
> For this, we will need to make changes in the deployment scripts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-11691) Create a simple INSTALL file with minimum installation information and redirection to more documentation

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11691.
---
Fix Version/s: 17.12.04
   18.12.01
   Resolution: Implemented

> Create a simple INSTALL file with minimum installation information and 
> redirection to more documentation
> 
>
> Key: OFBIZ-11691
> URL: https://issues.apache.org/jira/browse/OFBIZ-11691
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.04
>
> Attachments: INSTALL
>
>
> This follows the https://markmail.org/message/xi2bcvnmpdfvfgk2 discussion in 
> dev ML.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11691) Create a simple INSTALL file with minimum installation information and redirection to more documentation

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116137#comment-17116137
 ] 

ASF subversion and git services commented on OFBIZ-11691:
-

Commit 742802afbde4d0ca772e486f15a020673c62f2bc in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=742802a ]

Documented: Create a simple INSTALL file with minimum installation information 
and redirection to more documentation

(OFBIZ-11691)

Following https://markmail.org/message/xi2bcvnmpdfvfgk2 discussion on dev ML
here is the file I suggest. If we are OK we can backport it to the supported
release branches. Of course I'm open to modifications...

Thanks for their answers: Deepak Nigam, Michael Brohl, Pierre Smits and
Taher Alkhateeb


> Create a simple INSTALL file with minimum installation information and 
> redirection to more documentation
> 
>
> Key: OFBIZ-11691
> URL: https://issues.apache.org/jira/browse/OFBIZ-11691
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: INSTALL
>
>
> This follows the https://markmail.org/message/xi2bcvnmpdfvfgk2 discussion in 
> dev ML.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11691) Create a simple INSTALL file with minimum installation information and redirection to more documentation

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116136#comment-17116136
 ] 

ASF subversion and git services commented on OFBIZ-11691:
-

Commit 17f4d36ec1daf2b5ed149e88f07c01d9f2de36aa in ofbiz-framework's branch 
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=17f4d36 ]

Documented: Create a simple INSTALL file with minimum installation information 
and redirection to more documentation

(OFBIZ-11691)

Following https://markmail.org/message/xi2bcvnmpdfvfgk2 discussion on dev ML
here is the file I suggest. If we are OK we can backport it to the supported
release branches. Of course I'm open to modifications...

Thanks for their answers: Deepak Nigam, Michael Brohl, Pierre Smits and
Taher Alkhateeb


> Create a simple INSTALL file with minimum installation information and 
> redirection to more documentation
> 
>
> Key: OFBIZ-11691
> URL: https://issues.apache.org/jira/browse/OFBIZ-11691
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: INSTALL
>
>
> This follows the https://markmail.org/message/xi2bcvnmpdfvfgk2 discussion in 
> dev ML.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-11741) Headerize external script in multi-block html template

[James Yong (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-11741:
---
Attachment: OFBIZ-11741.patch

> Headerize external script in multi-block html template
> --
>
> Key: OFBIZ-11741
> URL: https://issues.apache.org/jira/browse/OFBIZ-11741
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11741.patch
>
>
> Allow external scripts within the multi-block html template, to be rendered 
> within the html head tag, when a new attribute data-import is set to “head” 
> e.g.
> {code:xml}
>  type="application/javascript" data-import="head">
> {code}
> With the new feature we can define external scripts in the multi-block html 
> template that is using the library, instead of setting in 
> layoutSetting.javaScripts.
> This new feature helps with dependency management of Javascript and also 
> reduce CSP errors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11741) Headerize external script in multi-block html template

[James Yong (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116127#comment-17116127
 ] 

James Yong commented on OFBIZ-11741:


Uploaded patch using jstree library as example

> Headerize external script in multi-block html template
> --
>
> Key: OFBIZ-11741
> URL: https://issues.apache.org/jira/browse/OFBIZ-11741
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11741.patch
>
>
> Allow external scripts within the multi-block html template, to be rendered 
> within the html head tag, when a new attribute data-import is set to “head” 
> e.g.
> {code:xml}
>  type="application/javascript" data-import="head">
> {code}
> With the new feature we can define external scripts in the multi-block html 
> template that is using the library, instead of setting in 
> layoutSetting.javaScripts.
> This new feature helps with dependency management of Javascript and also 
> reduce CSP errors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (OFBIZ-11741) Headerize external script in multi-block html template

[James Yong (Jira)]

James Yong created OFBIZ-11741:
--

 Summary: Headerize external script in multi-block html template
 Key: OFBIZ-11741
 URL: https://issues.apache.org/jira/browse/OFBIZ-11741
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Trunk


Allow external scripts within the multi-block html template, to be rendered 
within the html head tag, when a new attribute data-import is set to “head” e.g.

{code:xml}

{code}

With the new feature we can define external scripts in the multi-block html 
template that is using the library, instead of setting in 
layoutSetting.javaScripts.

This new feature helps with dependency management of Javascript and also reduce 
CSP errors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11677) Tree on main page of the humanres component doesn't show names of persons

[Pierre Smits (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116123#comment-17116123
 ] 

Pierre Smits commented on OFBIZ-11677:
--

Thanks [~pawan] for your assistance to get this merged into the code base.

> Tree on main page of the humanres component doesn't show names of persons
> -
>
> Key: OFBIZ-11677
> URL: https://issues.apache.org/jira/browse/OFBIZ-11677
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Usability, tree
> Fix For: Upcoming Branch
>
> Attachments: Screen Shot 2020-05-08 at 14.02.10.png
>
>
> See attached screenshot



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc

[Olivier Heintz (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116122#comment-17116122
 ] 

Olivier Heintz commented on OFBIZ-11574:


Thanks [~adityasharma] for the commit,

Yes it's a good idea to put it 18.12

> DATAMODEL_CHANGE migration to asciidoc
> --
>
> Key: OFBIZ-11574
> URL: https://issues.apache.org/jira/browse/OFBIZ-11574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format 
> to asciidoc
> Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine 
> chapter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-10613) Enhance entity "GlXbrlClass"

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116067#comment-17116067
 ] 

ASF subversion and git services commented on OFBIZ-10613:
-

Commit a82c3032ad5ef183cfabb6709d3476377e8d0996 in ofbiz-framework's branch 
refs/heads/trunk from Aditya Sharma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a82c303 ]

Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

- DATAMODEL_CHANGE migration to asciidoc and add a included in
developer_manual
- Readme migration to asciidoc

* Documented: theme/README.md change theme/README.adoc but with very
simple content
(OFBIZ-11574)

README.md  has been migrated to asciidoc as doc/themes.adoc previously
but remove README.md has been forgot.
In this commit README.md is removed and a new README.adoc is created
with only a brief component definition and link to the theme
documentation (and developer-manual which included theme.adoc)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md 
which was added with OFBIZ-10613 and missing in adoc file

Co-authored-by: holivier 

> Enhance entity "GlXbrlClass"
> 
>
> Key: OFBIZ-10613
> URL: https://issues.apache.org/jira/browse/OFBIZ-10613
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: reporting
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10613-accounting-entitymodel.xml.patch
>
>
> See [https://en.wikipedia.org/wiki/XBRL]
> Currently the entity does not allow to capture the hierarchy between records. 
> In order to enable this, and work with nested accounting reporting in 
> downstream solutions, a parent field needs to be added.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116064#comment-17116064
 ] 

ASF subversion and git services commented on OFBIZ-11574:
-

Commit a82c3032ad5ef183cfabb6709d3476377e8d0996 in ofbiz-framework's branch 
refs/heads/trunk from Aditya Sharma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a82c303 ]

Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

- DATAMODEL_CHANGE migration to asciidoc and add a included in
developer_manual
- Readme migration to asciidoc

* Documented: theme/README.md change theme/README.adoc but with very
simple content
(OFBIZ-11574)

README.md  has been migrated to asciidoc as doc/themes.adoc previously
but remove README.md has been forgot.
In this commit README.md is removed and a new README.adoc is created
with only a brief component definition and link to the theme
documentation (and developer-manual which included theme.adoc)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md 
which was added with OFBIZ-10613 and missing in adoc file

Co-authored-by: holivier 

> DATAMODEL_CHANGE migration to asciidoc
> --
>
> Key: OFBIZ-11574
> URL: https://issues.apache.org/jira/browse/OFBIZ-11574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format 
> to asciidoc
> Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine 
> chapter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116065#comment-17116065
 ] 

ASF subversion and git services commented on OFBIZ-11574:
-

Commit a82c3032ad5ef183cfabb6709d3476377e8d0996 in ofbiz-framework's branch 
refs/heads/trunk from Aditya Sharma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a82c303 ]

Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

- DATAMODEL_CHANGE migration to asciidoc and add a included in
developer_manual
- Readme migration to asciidoc

* Documented: theme/README.md change theme/README.adoc but with very
simple content
(OFBIZ-11574)

README.md  has been migrated to asciidoc as doc/themes.adoc previously
but remove README.md has been forgot.
In this commit README.md is removed and a new README.adoc is created
with only a brief component definition and link to the theme
documentation (and developer-manual which included theme.adoc)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md 
which was added with OFBIZ-10613 and missing in adoc file

Co-authored-by: holivier 

> DATAMODEL_CHANGE migration to asciidoc
> --
>
> Key: OFBIZ-11574
> URL: https://issues.apache.org/jira/browse/OFBIZ-11574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format 
> to asciidoc
> Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine 
> chapter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116066#comment-17116066
 ] 

ASF subversion and git services commented on OFBIZ-11574:
-

Commit a82c3032ad5ef183cfabb6709d3476377e8d0996 in ofbiz-framework's branch 
refs/heads/trunk from Aditya Sharma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a82c303 ]

Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

- DATAMODEL_CHANGE migration to asciidoc and add a included in
developer_manual
- Readme migration to asciidoc

* Documented: theme/README.md change theme/README.adoc but with very
simple content
(OFBIZ-11574)

README.md  has been migrated to asciidoc as doc/themes.adoc previously
but remove README.md has been forgot.
In this commit README.md is removed and a new README.adoc is created
with only a brief component definition and link to the theme
documentation (and developer-manual which included theme.adoc)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md 
which was added with OFBIZ-10613 and missing in adoc file

Co-authored-by: holivier 

> DATAMODEL_CHANGE migration to asciidoc
> --
>
> Key: OFBIZ-11574
> URL: https://issues.apache.org/jira/browse/OFBIZ-11574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format 
> to asciidoc
> Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine 
> chapter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-11677) Tree on main page of the humanres component doesn't show names of persons

[Pawan Verma (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-11677.
---
Fix Version/s: Upcoming Branch
   Resolution: Fixed

Thanks, [~pierresmits]!

> Tree on main page of the humanres component doesn't show names of persons
> -
>
> Key: OFBIZ-11677
> URL: https://issues.apache.org/jira/browse/OFBIZ-11677
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Usability, tree
> Fix For: Upcoming Branch
>
> Attachments: Screen Shot 2020-05-08 at 14.02.10.png
>
>
> See attached screenshot



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116063#comment-17116063
 ] 

ASF subversion and git services commented on OFBIZ-11574:
-

Commit a82c3032ad5ef183cfabb6709d3476377e8d0996 in ofbiz-framework's branch 
refs/heads/trunk from Aditya Sharma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a82c303 ]

Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

- DATAMODEL_CHANGE migration to asciidoc and add a included in
developer_manual
- Readme migration to asciidoc

* Documented: theme/README.md change theme/README.adoc but with very
simple content
(OFBIZ-11574)

README.md  has been migrated to asciidoc as doc/themes.adoc previously
but remove README.md has been forgot.
In this commit README.md is removed and a new README.adoc is created
with only a brief component definition and link to the theme
documentation (and developer-manual which included theme.adoc)

* Documented: datamodel markdown migration to asciidoc
(OFBIZ-11574)

Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md 
which was added with OFBIZ-10613 and missing in adoc file

Co-authored-by: holivier 

> DATAMODEL_CHANGE migration to asciidoc
> --
>
> Key: OFBIZ-11574
> URL: https://issues.apache.org/jira/browse/OFBIZ-11574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format 
> to asciidoc
> Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine 
> chapter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc

[Aditya Sharma (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116083#comment-17116083
 ] 

Aditya Sharma commented on OFBIZ-11574:
---

Hi [~holivier],

I think this should go to release branch 18.12 as it is still unreleased.

What do you think?

> DATAMODEL_CHANGE migration to asciidoc
> --
>
> Key: OFBIZ-11574
> URL: https://issues.apache.org/jira/browse/OFBIZ-11574
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: documentation
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format 
> to asciidoc
> Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine 
> chapter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11677) Tree on main page of the humanres component doesn't show names of persons

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116058#comment-17116058
 ] 

ASF subversion and git services commented on OFBIZ-11677:
-

Commit 52732c88072b8b2394b351c1d02b7ae04ac56e06 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=52732c8 ]

Fixed: organisation tree in humanres doesn't show person names (OFBIZ-11677) 
(#121)

* Fixed: Tree on main page of the humanres component doesn't show names of 
persons

(OFBIZ-11677)

When parties are assigned to employee positions their names aren't shown in the 
tree
fixed: the function that retrieves the person record of the assigned party was 
using
the wrong variable in the query, resulting in a null being returned. 
Corrected the variable
added/improved: retrieval of the middleName value of the person record, added 
it to the title
improved: ordering of the names making up the title.
improved: applying proper case to variable names

* Fixed: Tree on main page of the humanres component doesn't show names of 
persons

(OFBIZ-11677)

invoking PartyHelper.getPartyName instead of custom code
code clean-up

Thanks to Pawan Verma for the review and the suggestion

> Tree on main page of the humanres component doesn't show names of persons
> -
>
> Key: OFBIZ-11677
> URL: https://issues.apache.org/jira/browse/OFBIZ-11677
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Usability, tree
> Attachments: Screen Shot 2020-05-08 at 14.02.10.png
>
>
> See attached screenshot



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11677) Tree on main page of the humanres component doesn't show names of persons

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116059#comment-17116059
 ] 

ASF subversion and git services commented on OFBIZ-11677:
-

Commit 52732c88072b8b2394b351c1d02b7ae04ac56e06 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=52732c8 ]

Fixed: organisation tree in humanres doesn't show person names (OFBIZ-11677) 
(#121)

* Fixed: Tree on main page of the humanres component doesn't show names of 
persons

(OFBIZ-11677)

When parties are assigned to employee positions their names aren't shown in the 
tree
fixed: the function that retrieves the person record of the assigned party was 
using
the wrong variable in the query, resulting in a null being returned. 
Corrected the variable
added/improved: retrieval of the middleName value of the person record, added 
it to the title
improved: ordering of the names making up the title.
improved: applying proper case to variable names

* Fixed: Tree on main page of the humanres component doesn't show names of 
persons

(OFBIZ-11677)

invoking PartyHelper.getPartyName instead of custom code
code clean-up

Thanks to Pawan Verma for the review and the suggestion

> Tree on main page of the humanres component doesn't show names of persons
> -
>
> Key: OFBIZ-11677
> URL: https://issues.apache.org/jira/browse/OFBIZ-11677
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Usability, tree
> Attachments: Screen Shot 2020-05-08 at 14.02.10.png
>
>
> See attached screenshot



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-11693) Help system using asciidoc files

[Olivier Heintz (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-11693:
---
Attachment: 
OFBIZ-11693_0003-Documented-Migrate-CommonExtHelData.xml-to-added-som.patch

> Help system using asciidoc files
> 
>
> Key: OFBIZ-11693
> URL: https://issues.apache.org/jira/browse/OFBIZ-11693
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: documentation, help, help-system
> Attachments: 
> OFBIZ-11693_0001-Improvement-Help-link-using-asciidoc-files-via-gener.patch, 
> OFBIZ-11693_0002-Documented-Migrate-AccountingHelData.xml-to-added-so.patch, 
> OFBIZ-11693_0003-Documented-Migrate-CommonExtHelData.xml-to-added-som.patch, 
> ofbiz.conf.patch
>
>
> a very simple solution which is a link to a documentation site.
> This solution use
>  1. at application level, a default proprety for documentation website uri
>  2. at the screen level
>  * it would be possible to give a other uri (for user documentation)
>  * if the anchor in the user documentation for this screen is put, the new 
> help is used otherwise the older link is used



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11677) Tree on main page of the humanres component doesn't show names of persons

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116056#comment-17116056
 ] 

ASF subversion and git services commented on OFBIZ-11677:
-

Commit 52732c88072b8b2394b351c1d02b7ae04ac56e06 in ofbiz-framework's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=52732c8 ]

Fixed: organisation tree in humanres doesn't show person names (OFBIZ-11677) 
(#121)

* Fixed: Tree on main page of the humanres component doesn't show names of 
persons

(OFBIZ-11677)

When parties are assigned to employee positions their names aren't shown in the 
tree
fixed: the function that retrieves the person record of the assigned party was 
using
the wrong variable in the query, resulting in a null being returned. 
Corrected the variable
added/improved: retrieval of the middleName value of the person record, added 
it to the title
improved: ordering of the names making up the title.
improved: applying proper case to variable names

* Fixed: Tree on main page of the humanres component doesn't show names of 
persons

(OFBIZ-11677)

invoking PartyHelper.getPartyName instead of custom code
code clean-up

Thanks to Pawan Verma for the review and the suggestion

> Tree on main page of the humanres component doesn't show names of persons
> -
>
> Key: OFBIZ-11677
> URL: https://issues.apache.org/jira/browse/OFBIZ-11677
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Usability, tree
> Attachments: Screen Shot 2020-05-08 at 14.02.10.png
>
>
> See attached screenshot



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11693) Help system using asciidoc files

[Olivier Heintz (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116052#comment-17116052
 ] 

Olivier Heintz commented on OFBIZ-11693:


Pending infrastructure changes

new migration from helpData.xml to screen  Help system using asciidoc files
> 
>
> Key: OFBIZ-11693
> URL: https://issues.apache.org/jira/browse/OFBIZ-11693
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: documentation, help, help-system
> Attachments: 
> OFBIZ-11693_0001-Improvement-Help-link-using-asciidoc-files-via-gener.patch, 
> OFBIZ-11693_0002-Documented-Migrate-AccountingHelData.xml-to-added-so.patch, 
> OFBIZ-11693_0003-Documented-Migrate-CommonExtHelData.xml-to-added-som.patch, 
> ofbiz.conf.patch
>
>
> a very simple solution which is a link to a documentation site.
> This solution use
>  1. at application level, a default proprety for documentation website uri
>  2. at the screen level
>  * it would be possible to give a other uri (for user documentation)
>  * if the anchor in the user documentation for this screen is put, the new 
> help is used otherwise the older link is used



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-11740) Handle FileLength Checkstyle rule

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11740:

Description: 
Hi All,

[~surajk] rightly mentioned directly to me in Slack that we have no FileLength 
checkstyle rule and the max default is 2000 lines: 
https://checkstyle.sourceforge.io/config_sizes.html#FileLength

We have some very large Java files in trunk  [^filesLengths.txt]  and few (19) 
are longer than 2000 lines:

{noformat}
2059 
./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
2131 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartEvents.java
2581 
./applications/product/src/main/java/org/apache/ofbiz/product/product/ProductSearch.java
2631 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java
2643 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReturnServices.java
2662 
./framework/entity/src/main/java/org/apache/ofbiz/entity/GenericDelegator.java
2676 
./applications/party/src/main/java/org/apache/ofbiz/party/party/PartyServices.java
2811 
./framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
2953 
./plugins/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayStore.java
3133 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReadHelper.java
3433 
./framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
3638 
./applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
3712 
./applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java
3720 
./applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/PaymentGatewayServices.java
3734 
./applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java
4417 
./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
5437 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
7194 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java
{noformat}

The question is should we increase to hide the issue (19 errors) or try to 
split those files, if it makes sense in some cases...



  was:
Hi All,

[~surajk] rightly mentioned that we have no FileLength checkstyle rule and the 
max default is 2000 lines: 
https://checkstyle.sourceforge.io/config_sizes.html#FileLength

We have some very large Java files in trunk and few (19) are longer than 2000 
lines:

{noformat}
2059 
./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
2131 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartEvents.java
2581 
./applications/product/src/main/java/org/apache/ofbiz/product/product/ProductSearch.java
2631 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java
2643 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReturnServices.java
2662 
./framework/entity/src/main/java/org/apache/ofbiz/entity/GenericDelegator.java
2676 
./applications/party/src/main/java/org/apache/ofbiz/party/party/PartyServices.java
2811 
./framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
2953 
./plugins/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayStore.java
3133 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReadHelper.java
3433 
./framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
3638 
./applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
3712 
./applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java
3720 
./applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/PaymentGatewayServices.java
3734 
./applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java
4417 
./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
5437 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
7194 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java
{noformat}

The question is should we increase to hide the issue (19 errors) or try to 
split those files, if it makes sense in some cases...




> Handle FileLength Checkstyle rule 
> --
>
> Key: OFBIZ-11740
> URL: https://issues.apache.org/jira/browse/OFBIZ-11740
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>

[jira] [Updated] (OFBIZ-11740) Handle FileLength Checkstyle rule

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11740:

Description: 
Hi All,

[~surajk] rightly mentioned directly to me in Slack that we have no FileLength 
checkstyle rule and the max default is 2000 lines: 
https://checkstyle.sourceforge.io/config_sizes.html#FileLength

We have some very large Java files in trunk  ( see [^filesLengths.txt])  and 
few (19) are longer than 2000 lines:

{noformat}
2059 
./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
2131 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartEvents.java
2581 
./applications/product/src/main/java/org/apache/ofbiz/product/product/ProductSearch.java
2631 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java
2643 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReturnServices.java
2662 
./framework/entity/src/main/java/org/apache/ofbiz/entity/GenericDelegator.java
2676 
./applications/party/src/main/java/org/apache/ofbiz/party/party/PartyServices.java
2811 
./framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
2953 
./plugins/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayStore.java
3133 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReadHelper.java
3433 
./framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
3638 
./applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
3712 
./applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java
3720 
./applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/PaymentGatewayServices.java
3734 
./applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java
4417 
./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
5437 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
7194 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java
{noformat}

The question is should we increase to hide the issue (19 errors) or try to 
split those files, if it makes sense in some cases...



  was:
Hi All,

[~surajk] rightly mentioned directly to me in Slack that we have no FileLength 
checkstyle rule and the max default is 2000 lines: 
https://checkstyle.sourceforge.io/config_sizes.html#FileLength

We have some very large Java files in trunk  [^filesLengths.txt]  and few (19) 
are longer than 2000 lines:

{noformat}
2059 
./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
2131 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartEvents.java
2581 
./applications/product/src/main/java/org/apache/ofbiz/product/product/ProductSearch.java
2631 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java
2643 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReturnServices.java
2662 
./framework/entity/src/main/java/org/apache/ofbiz/entity/GenericDelegator.java
2676 
./applications/party/src/main/java/org/apache/ofbiz/party/party/PartyServices.java
2811 
./framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
2953 
./plugins/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayStore.java
3133 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReadHelper.java
3433 
./framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
3638 
./applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
3712 
./applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java
3720 
./applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/PaymentGatewayServices.java
3734 
./applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java
4417 
./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
5437 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
7194 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java
{noformat}

The question is should we increase to hide the issue (19 errors) or try to 
split those files, if it makes sense in some cases...




> Handle FileLength Checkstyle rule 
> --
>
> Key: OFBIZ-11740
> URL: https://issues.apache.org/jira/browse/OFBIZ-11740
> Project: OFBiz
>  Issue Type: 

[jira] [Created] (OFBIZ-11740) Handle FileLength Checkstyle rule

[Jacques Le Roux (Jira)]

Jacques Le Roux created OFBIZ-11740:
---

 Summary: Handle FileLength Checkstyle rule 
 Key: OFBIZ-11740
 URL: https://issues.apache.org/jira/browse/OFBIZ-11740
 Project: OFBiz
  Issue Type: Sub-task
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Jacques Le Roux
 Attachments: filesLengths.txt

Hi All,

[~surajk] rightly mentioned that we have no FileLength checkstyle rule and the 
max default is 2000 lines: 
https://checkstyle.sourceforge.io/config_sizes.html#FileLength

We have some very large Java files in trunk and few (19) are longer than 2000 
lines:

{noformat}
2059 
./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
2131 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartEvents.java
2581 
./applications/product/src/main/java/org/apache/ofbiz/product/product/ProductSearch.java
2631 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java
2643 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReturnServices.java
2662 
./framework/entity/src/main/java/org/apache/ofbiz/entity/GenericDelegator.java
2676 
./applications/party/src/main/java/org/apache/ofbiz/party/party/PartyServices.java
2811 
./framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
2953 
./plugins/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayStore.java
3133 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReadHelper.java
3433 
./framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
3638 
./applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
3712 
./applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java
3720 
./applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/PaymentGatewayServices.java
3734 
./applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java
4417 
./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
5437 
./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
7194 
./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java
{noformat}

The question is should we increase to hide the issue (19 errors) or try to 
split those files, if it makes sense in some cases...





--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-9350) Deprecate Mini Lang

[Carsten Schinzer (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Schinzer updated OFBIZ-9350:

Description: 
According to the proposal thread in [1] we decided to deprecate mini lang.

This issue tracks the next steps proposed in the aformentioned thread, namely:

1. create a Wiki page for the documentation and description of the migration 
process and how mini lang will be replaced.

2. prominently state in the Wiki that minilang will be deprecated, e.g. in [2]

3. put deprecation tags in the corresponding code

4. kindly ask contributors with open patches written in mini lang to replace 
them by Groovy code [3]

5. start an initiative to replace existing mini lang code with Groovy code 
where applicable. This needs some more planning and discussion which parts 
we'll like to replace with Groovy code and which parts will better be replaced 
by some kind of DSL. A good starting point can be [4][5][6].

[1] 
[https://lists.apache.org/thread.html/253b41060a295b8ab68bc78763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E]
 [2] 
[https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference]
 [3] does anyone know a way to batch comment Jira issues like it is possible in 
Redmine?
 [4] 
[https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic]
 [5] 
[https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide]
 [6] [https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions]

  was:
According to the proposal thread in [1] we decided to deprecate mini lang.

This issue tracks the next steps proposed in the aformentioned thread, namely:

1. create a Wiki page for the documentation and description of the migration 
process and how mini lang will be replaced.

2. prominently state in the Wiki that minilang will be deprecated, e.g. in [2]

3. put deprecation tags in the corresponding code

4. kindly ask contributors with open patches written in mini lang to replace 
them by Groovy code [3]

5. start an initiative to replace existing mini lang code with Groovy code 
where applicable. This needs some more planning and discussion which parts 
we'll like to replace with Groovy code and which parts will better be replaced 
by some kind of DSL. A good starting point can be [4][5][6].

[1] 
[https://lists.apache.org/thread.html/253b41060a295b8ab68bc78763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E]
 [2] 
[https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference]
 [3] does anyone know a way to batch comment Jira issues like it is possible in 
Redmine?
 [4] 
[https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic]
 [5] 
[https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide]
 [6] [https://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions]


> Deprecate Mini Lang
> ---
>
> Key: OFBIZ-9350
> URL: https://issues.apache.org/jira/browse/OFBIZ-9350
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: documentation, refactoring
>
> According to the proposal thread in [1] we decided to deprecate mini lang.
> This issue tracks the next steps proposed in the aformentioned thread, namely:
> 1. create a Wiki page for the documentation and description of the migration 
> process and how mini lang will be replaced.
> 2. prominently state in the Wiki that minilang will be deprecated, e.g. in [2]
> 3. put deprecation tags in the corresponding code
> 4. kindly ask contributors with open patches written in mini lang to replace 
> them by Groovy code [3]
> 5. start an initiative to replace existing mini lang code with Groovy code 
> where applicable. This needs some more planning and discussion which parts 
> we'll like to replace with Groovy code and which parts will better be 
> replaced by some kind of DSL. A good starting point can be [4][5][6].
> [1] 
> [https://lists.apache.org/thread.html/253b41060a295b8ab68bc78763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E]
>  [2] 
> [https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference]
>  [3] does anyone know a way to batch comment Jira issues like it is possible 
> in Redmine?
>  [4] 
> [https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic]
>  [5] 
> [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide]
>  [6] [https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions]



--
This 

[jira] [Updated] (OFBIZ-11692) Convert checkStatusCustRequest from mini-lang to groovy

[Carsten Schinzer (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Schinzer updated OFBIZ-11692:
-
Description: 
See OFBIZ-9350 for motivation

+Acceptance:+
 * I can run a unit test on 
component://order/groovyScripts/request/CheckStatusCustRequest.groovy (if 
unit-testing for groovy scripts is a practice in OFBiz)
 * The new service implementation is configured in 
component://servicedef/services_request.xml (line130-131)
 * The test-suite custrequesttests is extended by an integration test for the 
newly implemented service

  was:See OFBIZ-9350 for motivation


> Convert checkStatusCustRequest from mini-lang to groovy
> ---
>
> Key: OFBIZ-11692
> URL: https://issues.apache.org/jira/browse/OFBIZ-11692
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Carsten Schinzer
>Priority: Major
>  Labels: refactoring, request
>
> See OFBIZ-9350 for motivation
> +Acceptance:+
>  * I can run a unit test on 
> component://order/groovyScripts/request/CheckStatusCustRequest.groovy (if 
> unit-testing for groovy scripts is a practice in OFBiz)
>  * The new service implementation is configured in 
> component://servicedef/services_request.xml (line130-131)
>  * The test-suite custrequesttests is extended by an integration test for the 
> newly implemented service



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (OFBIZ-11739) Change resource with RESOURCE in all application components

[Suraj Khurana (Jira)]

Suraj Khurana created OFBIZ-11739:
-

 Summary: Change resource with RESOURCE in all application 
components
 Key: OFBIZ-11739
 URL: https://issues.apache.org/jira/browse/OFBIZ-11739
 Project: OFBiz
  Issue Type: Sub-task
  Components: ALL APPLICATIONS
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana


As we have done it for modules, it is better to get this done for all resource 
variables as well.
Also, we should make module ans resource variable as private instead of public



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[Jacques Le Roux (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115967#comment-17115967
 ] 

Jacques Le Roux commented on OFBIZ-11737:
-

Suraj,
bq. I was referring this change after applying patch,
OK clear, we can close for me

> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11737.patch
>
>
> As per discussion on dev ML 
> ([https://markmail.org/message/ydopesbn2ccckdjx|https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[Suraj Khurana (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11737.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks Jacques for review and taking care of document update.

> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11737.patch
>
>
> As per discussion on dev ML 
> ([https://markmail.org/message/ydopesbn2ccckdjx|https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115962#comment-17115962
 ] 

ASF subversion and git services commented on OFBIZ-11737:
-

Commit d6ebef619349f809062641d1b558cacdec3da208 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d6ebef6 ]

Improved: Improved: Changed lineSplit value to 150.
(OFBIZ-11737)
Earlier it was 120, as per discussion over ML we decided to make it 150 instead.


> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11737.patch
>
>
> As per discussion on dev ML 
> ([https://markmail.org/message/ydopesbn2ccckdjx|https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115960#comment-17115960
 ] 

ASF subversion and git services commented on OFBIZ-11737:
-

Commit 758fe338125c5e2cea4a3ef40beb89fa0db36510 in ofbiz-tools's branch 
refs/heads/master from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;h=758fe33 ]

Improved: Changed lineSplit related values to 150 (#4)

(OFBIZ-11737)
Earlier it was 120, as per discussion over ML we decided to make it 150 instead.
Thanks Jacques Le Roux

> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11737.patch
>
>
> As per discussion on dev ML 
> ([https://markmail.org/message/ydopesbn2ccckdjx|https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115956#comment-17115956
 ] 

ASF subversion and git services commented on OFBIZ-11737:
-

Commit 595973a8f0753c5669bffd62519614d98f5cd863 in ofbiz-tools's branch 
refs/heads/surajkhurana-OFBIZ-11737 from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;h=595973a ]

Improved: Changed lineSplit related values to 150

(OFBIZ-11737)
Earlier it was 120, as per discussion over ML we decided to make it 150 instead.
Thanks Jacques Le Roux

> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11737.patch
>
>
> As per discussion on dev ML 
> ([https://markmail.org/message/ydopesbn2ccckdjx|https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[Suraj Khurana (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115926#comment-17115926
 ] 

Suraj Khurana commented on OFBIZ-11737:
---

Hey Jacques,

I was referring this change after applying patch, I am using IntelliJ and it 
worked for me. Haven't committed it yet :) 
Thanks for reminding about eclipse setting file and Coding Convention document.

 

> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11737.patch
>
>
> As per discussion on dev ML 
> ([https://markmail.org/message/ydopesbn2ccckdjx|https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11738) Tooling - Link from JIRA Commits to Fisheye

[Pierre Smits (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115902#comment-17115902
 ] 

Pierre Smits commented on OFBIZ-11738:
--

Given that GitHub integration would work the same way as the Fisheye 
integration to investigate commits as they are linked in Jira tickets, I 
propose that we move to have GitHub commit links shown in tickets.

> Tooling - Link from JIRA Commits to Fisheye
> ---
>
> Key: OFBIZ-11738
> URL: https://issues.apache.org/jira/browse/OFBIZ-11738
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Carsten Schinzer
>Priority: Minor
>
> When trying to investigate commits related and linked with an OFBIZ Jira 
> Ticket by clicking the link offered in JIRA, user is asked to authenticate 
> for a tool called Fisheye.
> It is unclear which credentials are to be used there and how this integrates 
> with the other tooling for OFBiz.
> I have tested the ASF-CWiki as well as the ASF-Jira credentials - don't work. 
> Expectedly also the Github credentials dont work either.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (OFBIZ-11692) Convert checkStatusCustRequest from mini-lang to groovy

[Carsten Schinzer (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Schinzer reassigned OFBIZ-11692:


Assignee: Carsten Schinzer

> Convert checkStatusCustRequest from mini-lang to groovy
> ---
>
> Key: OFBIZ-11692
> URL: https://issues.apache.org/jira/browse/OFBIZ-11692
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Carsten Schinzer
>Priority: Major
>  Labels: refactoring, request
>
> See OFBIZ-9350 for motivation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (OFBIZ-11738) Tooling - Link from JIRA Commits to Fisheye

[Carsten Schinzer (Jira)]

Carsten Schinzer created OFBIZ-11738:


 Summary: Tooling - Link from JIRA Commits to Fisheye
 Key: OFBIZ-11738
 URL: https://issues.apache.org/jira/browse/OFBIZ-11738
 Project: OFBiz
  Issue Type: Improvement
Reporter: Carsten Schinzer


When trying to investigate commits related and linked with an OFBIZ Jira Ticket 
by clicking the link offered in JIRA, user is asked to authenticate for a tool 
called Fisheye.

It is unclear which credentials are to be used there and how this integrates 
with the other tooling for OFBiz.

I have tested the ASF-CWiki as well as the ASF-Jira credentials - don't work. 
Expectedly also the Github credentials dont work either.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

[Jacques Le Roux (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115890#comment-17115890
 ] 

Jacques Le Roux commented on OFBIZ-11304:
-

I created INFRA-20314 for that

> Install a Checkstyle pre-push (on every committer machine?)
> ---
>
> Key: OFBIZ-11304
> URL: https://issues.apache.org/jira/browse/OFBIZ-11304
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by 
> the check gradle task. It's "hard" to exactly know from where lint errors  
> come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like 
> https://gist.github.com/davetron5000/37350 to complement 
> tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when 
> a lint error is present in the commit. 
> Every committer would have it installed locally and the problem would be gone 
> with some committers good will. I started a discussion about it at 
> https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same 
> proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11304:

Summary: Install a Checkstyle pre-push (on every committer machine?)  (was: 
Install a Checkstyle pre-push on every committer machine)

> Install a Checkstyle pre-push (on every committer machine?)
> ---
>
> Key: OFBIZ-11304
> URL: https://issues.apache.org/jira/browse/OFBIZ-11304
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by 
> the check gradle task. It's "hard" to exactly know from where lint errors  
> come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like 
> https://gist.github.com/davetron5000/37350 to complement 
> tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when 
> a lint error is present in the commit. 
> Every committer would have it installed locally and the problem would be gone 
> with some committers good will. I started a discussion about it at 
> https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same 
> proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #121: Fixed: organisation tree in humanres doesn't show person names (OFBIZ-11677)

[GitBox]

PierreSmits commented on pull request #121:
URL: https://github.com/apache/ofbiz-framework/pull/121#issuecomment-633478394


   Thanks @JacquesLeRoux 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push on every committer machine

[Jacques Le Roux (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115888#comment-17115888
 ] 

Jacques Le Roux commented on OFBIZ-11304:
-

Yes indeed. I'll create an Infra Jira to see if they can/want to do it or if we 
should

> Install a Checkstyle pre-push on every committer machine
> 
>
> Key: OFBIZ-11304
> URL: https://issues.apache.org/jira/browse/OFBIZ-11304
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by 
> the check gradle task. It's "hard" to exactly know from where lint errors  
> come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like 
> https://gist.github.com/davetron5000/37350 to complement 
> tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when 
> a lint error is present in the commit. 
> Every committer would have it installed locally and the problem would be gone 
> with some committers good will. I started a discussion about it at 
> https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same 
> proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #121: Fixed: organisation tree in humanres doesn't show person names (OFBIZ-11677)

[GitBox]

JacquesLeRoux commented on pull request #121:
URL: https://github.com/apache/ofbiz-framework/pull/121#issuecomment-633476935


   I'll try this afternoon...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[Jacques Le Roux (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115880#comment-17115880
 ] 

Jacques Le Roux commented on OFBIZ-11737:
-

Also that's not enough, we need to change in
* https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions
* and 
https://svn.apache.org/repos/asf/ofbiz/tools/wiki-files/OFBizJavaFormatter.xml
 

> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11737.patch
>
>
> As per discussion on dev ML 
> ([https://markmail.org/message/ydopesbn2ccckdjx|https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push on every committer machine

[Pierre Smits (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115879#comment-17115879
 ] 

Pierre Smits commented on OFBIZ-11304:
--

IMO, we should not have to ask from committers to have additional tooling 
installed, when the CI can take care of this.

> Install a Checkstyle pre-push on every committer machine
> 
>
> Key: OFBIZ-11304
> URL: https://issues.apache.org/jira/browse/OFBIZ-11304
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by 
> the check gradle task. It's "hard" to exactly know from where lint errors  
> come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like 
> https://gist.github.com/davetron5000/37350 to complement 
> tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when 
> a lint error is present in the commit. 
> Every committer would have it installed locally and the problem would be gone 
> with some committers good will. I started a discussion about it at 
> https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same 
> proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[Jacques Le Roux (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115876#comment-17115876
 ] 

Jacques Le Roux commented on OFBIZ-11737:
-

Hi Surag, it's still 37101, plugins included

> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11737.patch
>
>
> As per discussion on dev ML 
> ([https://markmail.org/message/ydopesbn2ccckdjx|https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-11304) Install a Checkstyle pre-push on every committer machine

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11304:

Parent Issue: OFBIZ-11350  (was: OFBIZ-11268)

> Install a Checkstyle pre-push on every committer machine
> 
>
> Key: OFBIZ-11304
> URL: https://issues.apache.org/jira/browse/OFBIZ-11304
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by 
> the check gradle task. It's "hard" to exactly know from where lint errors  
> come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like 
> https://gist.github.com/davetron5000/37350 to complement 
> tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when 
> a lint error is present in the commit. 
> Every committer would have it installed locally and the problem would be gone 
> with some committers good will. I started a discussion about it at 
> https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same 
> proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (OFBIZ-10931) Improve the selection of the parent period for CustomTimePeriod update

[Pierre Smits (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-10931:


Assignee: Pierre Smits

> Improve the selection of the parent period for CustomTimePeriod update
> --
>
> Key: OFBIZ-10931
> URL: https://issues.apache.org/jira/browse/OFBIZ-10931
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: CustomTimePeriod
>
> Currently in the overviews of Edit Custom Time Periods screen (see [1]) the 
> user can select a parent period for any given period record. This is done 
> through a drop down widget from EditCustomTimePeriod.ftl
> The construct for the values shown is: 
>  # the organisationPartyId, 
>  # the periodTypeId, and 
>  # the periodNum
>  # the customPeriodId
> The page shows the drop-down values as following examples:
>  * Company Fiscal Quarter: 2 [6011]
>  
>  * Company Fiscal Quarter: 3 [6012]
>  * Company Fiscal Quarter: 5 [6014]
>  * Company Fiscal Quarter: 2 [6016]
>  * Company Fiscal Quarter: 3 [6017]
>  * Company Fiscal Year: 1 [6010]
>  * Company Fiscal Year: 1 [6015]
> As can be observed, the information provided is confusing. And when the 
> number of periods to select from gets long (consider the hierarchy: 
> month-quarter-year) it is easy to make mistakes. 
> Furthermore, given that there is a hierarchy between periods, it should not 
> be possible to select a period that is outside the higher order. Meaning 
> there is a FISCAL_MONTH defined for say fromDate=2019-03-01 and thruDate = 
> 2019-03-31, then It can not belong to a FISCAL_YEAR that either ends before 
> the fromDate of the FISCAL_MONTH period or start after the thruDate of the 
> FISCAL_MONTH.
>  
>  
>  
> [1] 
> https://demo-stable.ofbiz.apache.org/accounting/control/EditCustomTimePeriod



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-6704) Creating & Closing Custom Time Periods

[Pierre Smits (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115863#comment-17115863
 ] 

Pierre Smits commented on OFBIZ-6704:
-

Creation of CustomTimePeriod records has been partially addressed in OFBIZ-10905

> Creating & Closing Custom Time Periods
> --
>
> Key: OFBIZ-6704
> URL: https://issues.apache.org/jira/browse/OFBIZ-6704
> Project: OFBiz
>  Issue Type: Bug
>Reporter: David Hughes-Owens
>Assignee: Pierre Smits
>Priority: Major
>
> I have been looking at the functionality around creating and closing time 
> periods.
> I have uncovered a potential issue with the Thru Date of a period and the 
> closing process.
> For example, January period runs form 01-01-2015 to 31-01-2015. The form & 
> thru dates are date formats and require no time input. 
> When you do a period close the code creates the accounting transaction 
> between P and Retained Earnings. 
> However, this transaction is time stamped  and creates a transaction date of 
> 30-01-2015 23:59:59. I believe this is due to the service taking the thru 
> date as 31-01-2015 00:00:00. When it should be 31-01-2015 23:59:59.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (OFBIZ-6704) Creating & Closing Custom Time Periods

[Pierre Smits (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-6704:
---

Assignee: Pierre Smits

> Creating & Closing Custom Time Periods
> --
>
> Key: OFBIZ-6704
> URL: https://issues.apache.org/jira/browse/OFBIZ-6704
> Project: OFBiz
>  Issue Type: Bug
>Reporter: David Hughes-Owens
>Assignee: Pierre Smits
>Priority: Major
>
> I have been looking at the functionality around creating and closing time 
> periods.
> I have uncovered a potential issue with the Thru Date of a period and the 
> closing process.
> For example, January period runs form 01-01-2015 to 31-01-2015. The form & 
> thru dates are date formats and require no time input. 
> When you do a period close the code creates the accounting transaction 
> between P and Retained Earnings. 
> However, this transaction is time stamped  and creates a transaction date of 
> 30-01-2015 23:59:59. I believe this is due to the service taking the thru 
> date as 31-01-2015 00:00:00. When it should be 31-01-2015 23:59:59.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-9122) Check GeoData against 2016 updates for ISO region codes

[Pierre Smits (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-9122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115861#comment-17115861
 ] 

Pierre Smits commented on OFBIZ-9122:
-

Is this still an issue?

> Check GeoData against 2016 updates for ISO region codes
> ---
>
> Key: OFBIZ-9122
> URL: https://issues.apache.org/jira/browse/OFBIZ-9122
> Project: OFBiz
>  Issue Type: Task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Paul Foxworthy
>Assignee: Paul Foxworthy
>Priority: Minor
>
> The International Organization for Standardization (ISO) has released an 
> update to its list of country and region codes
> Below is the list of links to the new codes for different countries.
> Please check the OFBiz Geo codes in the files GeoData_xx.xml in 
> framework/common/data 
> (https://fisheye6.atlassian.com/browse/ofbiz/trunk/framework/common/data)
> If any changes to GeoData are needed, attach a patch here or just go ahead 
> and commit the change, and add a comment here. Once you have completed the 
> review, move the line for a country from "TO REVIEW" below to "COMPLETED".
> Thanks in anticipation!
> TO REVIEW:
> AW /Aruba/
> BD  /Bangladesh/
> BF   /Burkina Faso/
> BR  /Brazil/
> BT  /Bhutan/
> CD /Congo (the Democratic 
> Republic of the)/
> CI    /Côte d'Ivoire/
> CL  /Chile/
> CO    /Colombia/
> CZ /Czechia/
> DJ  /Djibouti/
> DO   /Dominican Republic (the)/
> DZ /Algeria/
> ES /Spain/
> FI    /Finland/
> FJ  /Fiji/
> GD   /Grenada/
> GR   /Greece/
> ID    /Indonesia/
> IL    /Israel/
> IQ  /Iraq/
> KE    /Kenya/
> KG   /Kyrgyzstan/
> KH /Cambodia/
> KR /Korea (the Republic of)/
> KZ  /Kazakhstan/
> LA  /Lao People's 
> Democratic Republic (the)/
> MM    /Myanmar/
> MV /Maldives/
> MX  /Mexico/
> NA  /Namibia/
> PW /Palau/
> RW /Rwanda/
> SI  /Slovenia/
> TG  /Togo/
> TJ    /Tajikistan/
> TV  /Tuvalu/
> TW    /Taiwan (Province of 
> China)/
> UG /Uganda/
> YE  /Yemen/
> COMPLETED:
> AU   /Australia/
> FR    /France/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[Suraj Khurana (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11737:
--
Description: 
As per discussion on dev ML 
([https://markmail.org/message/ydopesbn2ccckdjx|https://markmail.org/message/ydopesbn2ccckdjx)]

we are good to change line length to 150 instead of 120

  was:
As per discussion on dev ML ([https://markmail.org/message/ydopesbn2ccckdjx)]

we are good to change line length to 150 instead of 120


> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11737.patch
>
>
> As per discussion on dev ML 
> ([https://markmail.org/message/ydopesbn2ccckdjx|https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (OFBIZ-11382) Convert getContentAndDataResource service from mini-lang to groovy DSL

[Suraj Khurana (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11382:
-

Assignee: Suraj Khurana  (was: Ravi Lodhi)

> Convert getContentAndDataResource service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11382
> URL: https://issues.apache.org/jira/browse/OFBIZ-11382
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11382_Trunk.patch
>
>
> Convert getContentAndDataResource service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (OFBIZ-11377) Convert createContentFromDataResource service from mini-lang to groovy DSL

[Suraj Khurana (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11377:
-

Assignee: Suraj Khurana  (was: Anushi Gupta)

> Convert createContentFromDataResource service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11377
> URL: https://issues.apache.org/jira/browse/OFBIZ-11377
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11377.patch
>
>
> Convert createContentFromDataResource service code from mini-lang to groovy 
> DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[Suraj Khurana (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115823#comment-17115823
 ] 

Suraj Khurana commented on OFBIZ-11737:
---

Attached Patch, also updated max errors as checked after ./gradlew check
37101 -> 27599

> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11737.patch
>
>
> As per discussion on dev ML ([https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[Suraj Khurana (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11737:
--
Attachment: OFBIZ-11737.patch

> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11737.patch
>
>
> As per discussion on dev ML ([https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-11372) Convert createDownloadContent service from mini-lang to groovy DSL

[Suraj Khurana (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11372.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Slightly modified patch uploaded into trunk.

 

> Convert createDownloadContent service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11372
> URL: https://issues.apache.org/jira/browse/OFBIZ-11372
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11372.patch
>
>
> Convert createDownloadContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11373) Convert updateDownloadContent service from mini-lang to groovy DSL

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115811#comment-17115811
 ] 

ASF subversion and git services commented on OFBIZ-11373:
-

Commit 7aa3db4c45f55ab2cb8c471481bb75db7e8f980b in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7aa3db4 ]

Improved: Converted createDownloadContent,updateDownloadContent services from 
mini-lang to groovy.
(OFBIZ-11372)(OFBIZ-11373)
Thanks Devanshu Vyas for reporting, Harman Kaur and Rahul for initial patch, 
Pawan for review.


> Convert updateDownloadContent service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11373
> URL: https://issues.apache.org/jira/browse/OFBIZ-11373
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11373.patch
>
>
> Convert updateDownloadContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-11373) Convert updateDownloadContent service from mini-lang to groovy DSL

[Suraj Khurana (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11373.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Slightly modified patch uploaded into trunk.

 

> Convert updateDownloadContent service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11373
> URL: https://issues.apache.org/jira/browse/OFBIZ-11373
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11373.patch
>
>
> Convert updateDownloadContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11372) Convert createDownloadContent service from mini-lang to groovy DSL

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115810#comment-17115810
 ] 

ASF subversion and git services commented on OFBIZ-11372:
-

Commit 7aa3db4c45f55ab2cb8c471481bb75db7e8f980b in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7aa3db4 ]

Improved: Converted createDownloadContent,updateDownloadContent services from 
mini-lang to groovy.
(OFBIZ-11372)(OFBIZ-11373)
Thanks Devanshu Vyas for reporting, Harman Kaur and Rahul for initial patch, 
Pawan for review.


> Convert createDownloadContent service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11372
> URL: https://issues.apache.org/jira/browse/OFBIZ-11372
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11372.patch
>
>
> Convert createDownloadContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (OFBIZ-11373) Convert updateDownloadContent service from mini-lang to groovy DSL

[Suraj Khurana (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11373:
-

Assignee: Suraj Khurana  (was: Harman kaur Matharu)

> Convert updateDownloadContent service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11373
> URL: https://issues.apache.org/jira/browse/OFBIZ-11373
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11373.patch
>
>
> Convert updateDownloadContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (OFBIZ-11372) Convert createDownloadContent service from mini-lang to groovy DSL

[Suraj Khurana (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11372:
-

Assignee: Suraj Khurana  (was: Rahul Marjiwe)

> Convert createDownloadContent service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11372
> URL: https://issues.apache.org/jira/browse/OFBIZ-11372
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11372.patch
>
>
> Convert createDownloadContent service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[Suraj Khurana (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11737:
--
Parent: OFBIZ-11350
Issue Type: Sub-task  (was: Improvement)

> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>
> As per discussion on dev ML ([https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[Suraj Khurana (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11737:
--
Issue Type: Improvement  (was: Bug)

> Improve LineLength for checkstyle.xml
> -
>
> Key: OFBIZ-11737
> URL: https://issues.apache.org/jira/browse/OFBIZ-11737
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>
> As per discussion on dev ML ([https://markmail.org/message/ydopesbn2ccckdjx)]
> we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

[Gil Portenseigne (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115799#comment-17115799
 ] 

Gil Portenseigne commented on OFBIZ-11204:
--

Hello [~lodhiravi],

This improvement tend to reduce a lot the error log noise. But, if my memory is 
clear, i think the multi thread part make it complicated to remove completly 
the issue.

If you have a way to improve this contribution, that'd be great !

Thanks

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11204.patch, OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |ServiceSemaphore  |E| null 
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 

[jira] [Created] (OFBIZ-11737) Improve LineLength for checkstyle.xml

[Suraj Khurana (Jira)]

Suraj Khurana created OFBIZ-11737:
-

 Summary: Improve LineLength for checkstyle.xml
 Key: OFBIZ-11737
 URL: https://issues.apache.org/jira/browse/OFBIZ-11737
 Project: OFBiz
  Issue Type: Bug
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana


As per discussion on dev ML ([https://markmail.org/message/ydopesbn2ccckdjx)]

we are good to change line length to 150 instead of 120



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-7002) Images are not rendered in content

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7002.
--
Resolution: Cannot Reproduce

> Images are not rendered in content
> --
>
> Key: OFBIZ-7002
> URL: https://issues.apache.org/jira/browse/OFBIZ-7002
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Release Branch 12.04, Release Branch 13.07, Release 
> Branch 14.12, Release Branch 15.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-7002.patch, OFBIZ-7002.patch
>
>
> When you get to 
> {code}
> content/control/WebSiteCms?webSiteId=CmsSite 
> {code}
> and add a new image in the tree, it's no rendered. Same at 
> {code}
> content/control/EditLayout?drDataResourceId=NOCONTENTFOUND=NOCONTENTFOUND
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-10038) In Rainbow theme the navigation banner is not high enough

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-10038.
---
Resolution: Cannot Reproduce

> In Rainbow theme the navigation banner is not high enough
> -
>
> Key: OFBIZ-10038
> URL: https://issues.apache.org/jira/browse/OFBIZ-10038
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Julien NICOLAS
>Priority: Minor
> Attachments: Image 004.png, Image 005.png, Image 006.png
>
>
> During my test for OFBIZ-9978 I found this trivial UI issue in lookups. It's 
> unrelated with changes for OFBIZ-9978 because it's reproductible on trunk 
> demo today !Image 005.png! 
> 
> But is OK in stable !Image 004.png!. 
> 
> It's ok with other themes on trunk demo today, at least Tomahawk !Image 
> 006.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-9142) Analyse a crash on stable demo (R16.11)

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-9142.
--
Resolution: Not A Problem

> Analyse a crash on stable demo (R16.11)
> ---
>
> Key: OFBIZ-9142
> URL: https://issues.apache.org/jira/browse/OFBIZ-9142
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: 16.11.01
>Reporter: Jacques Le Roux
>Priority: Major
> Attachments: stable_crash.zip
>
>
> Today the stable demo crashed. It's not the 1st time, so I grabed the 
> console.log to see what happened. I have no time yet, but I attach it here to 
> see if the same happen again later and then decide...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-6723) With the introduction of jGrowl to show notifications the WebtoolsLayoutDemo screen is ambiguous

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6723.
--
Resolution: Not A Problem

> With the introduction of jGrowl to show notifications the WebtoolsLayoutDemo 
> screen is ambiguous
> 
>
> Key: OFBIZ-6723
> URL: https://issues.apache.org/jira/browse/OFBIZ-6723
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Trivial
> Attachments: Image 081.png
>
>
> Before it was less obvious because part of the screen but now it's annoying 
> since it seems to show errors when it's actually demonstrating features



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-3877) New Web Service Style

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-3877.
--
Resolution: Abandoned

> New Web Service Style
> -
>
> Key: OFBIZ-3877
> URL: https://issues.apache.org/jira/browse/OFBIZ-3877
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
> Environment: Windows, Ubuntu Linux
>Reporter: Chatree Srichart
>Priority: Minor
> Attachments: ASF.LICENSE.NOT.GRANTED--webui empty UI.jpg, 
> webservice.tar.bz2, webui.png, webui.tar.bz2
>
>
> This is a new stub for new web service style that use a normal style (not 
> hash map [key/value]).
> [[ Installation ]]
> - Extract webservice.zip file (attached file) to hot-deploy directory of 
> OFBiz framework
> - run ant task for apply patch in webservice directory with:
>ant reapply-ofbiz-patches 
> [[ Features ]]
> 1.) New classes
> There is new important class
> org.ofbiz.webapp.webservice.event.WebServiceEventHandler
> which corresponds to earlier
> org.ofbiz.webapp.event.SOAPEventHandler
> but tries to support document style web services using
> SOAP with XML-format, or REST with XML and JSON-formats.
> This handler class uses other class:
> org.ofbiz.service.webservice.WebServiceModel
> which wraps inside class
> org.ofbiz.service.ModelService
> and contains support for WSDL-generation, WADL-generation
> and conversion between Java Maps and XML-object models.
> WSDL=Web Service Definition Language for SOAP-interface
> http://www.w3.org/TR/wsdl
> WADL=Web Application Description Language for REST-interface
> http://www.w3.org/Submission/wadl/
> There is another new important class
> org.ofbiz.service.webservice.engine.WebServiceClientEngine
> which corresponds to earlier
> org.ofbiz.service.engine.SOAPClientEngine
> but tries to support document style web services using
> SOAP with XML-format. Web services can be called using
> their WSDL-document or messages can be specified in
> services.xml without using WSDL-document. engine-attribute
> in services description is set to "webservice". Location
> of WSDL-document is given in attribute wsdlLocation or
> it can be left out if messages are described with attribute-
> definitions. Name of service in WSDL is given in
> attribute webServiceName and name of operation to be
> invoked in attribute invoke. One service-definition is
> needed for one web service-operation pair.
> Example of web service definitions are in file:
> framework/common/servicedef/services_test.xml
> This engine class uses other class:
> org.ofbiz.service.webservice.WebServiceClientModel
> which extends org.ofbiz.service.webservice.WebServiceModel
> and contains support for filling attribute definitions
> in org.ofbiz.service.ModelService from WSDL-document.
> 2.) Service definitions
> Web service interface can be used only if service definition
> file services.xml is completed with additional definitions.
> Schema of this file is extended.
> attribute-elements can have nested attribute elements
> which describe structure of Java maps and lists.
> If attribute has type Map, it should have nested attributes
> which describe contents of this map.
> If attribute has type List, it should have nested attributes
> which describe element contents of this list.
> If List has simple elements, there must be only one
> nested attribute, which describes element.
> If List has element which is map or other list, there
> must be one nested attribute stating that the element
> is Map or List, and then this attribute should have
> nested attributes describing structure of Map or
> structure of list element.
> There are also two new modes for attributes
> ERROR which means that attribute is responded as error message
> OUTERROR which means that attribute is responded as error
>  or as success message
> These modes are needed for web services to describe
> which parameters will go to detail-elements of SOAP Fault response
> or REST error messages. Also in WSDL- and WADL-files will be
> generated XML-schema for general response messages.
> File framework\webapp\servicedef\services_test.xml
> can be used as example of attribute definitions.
> This file is used in unit tests of web service interface.
> 3.) Web service requests
> In REST-services HTTP GET-method is used in services whose
> name start with words "find" or "get". These services should
> have input parameters in one level, so that they can be
> given as query parameters in URL. HTTP DELETE-method is used
> with services whose name start with word "remove". Other services
> are used with HTTP POST-method and PUT-method. Service must
> look itself for method name POST or PUT, if it is required
> to operate differently in insert or update cases.
> List of links to all WSDL-documents can be requested with URL:
> 

[jira] [Commented] (OFBIZ-10917) establish code analysis with Sonar

[Jacques Le Roux (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-10917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115784#comment-17115784
 ] 

Jacques Le Roux commented on OFBIZ-10917:
-

I know it's only for PRs but we have Sonar running at no cost (no work to do) 
in GH, should we not close here?

> establish code analysis with Sonar
> --
>
> Key: OFBIZ-10917
> URL: https://issues.apache.org/jira/browse/OFBIZ-10917
> Project: OFBiz
>  Issue Type: Task
>  Components: ALL COMPONENTS, ALL PLUGINS
>Reporter: Pierre Smits
>Assignee: Aditya Sharma
>Priority: Major
>
> The ASF provides code analysis functionality through [1] with Sonar
> Our code contributors will benefit from more insight through this tool for 
> each of the components in:
>  # ofbiz-framework, see [2]
>  # ofbiz-plugins, see [3]
> [1] [https://builds.apache.org/analysis/]
> [2] [ofbiz-framework|https://github.com/apache/ofbiz-framework]
> [3] [ofbiz-plugins|https://github.com/apache/ofbiz-plugins]
> Currently the Sonar implementation provides analysis functionalities for:
>  # Java
>  # Javascript



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11472) Demo instance setup for OFBiz 17.12 release and obsolete 13.07 demo

[Jacques Le Roux (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115782#comment-17115782
 ] 

Jacques Le Roux commented on OFBIZ-11472:
-

Hi Swapnil,

I think we can close here, right?

> Demo instance setup for OFBiz 17.12 release and obsolete 13.07 demo
> ---
>
> Key: OFBIZ-11472
> URL: https://issues.apache.org/jira/browse/OFBIZ-11472
> Project: OFBiz
>  Issue Type: Task
>  Components: Demo
>Reporter: Swapnil Mane
>Assignee: Swapnil Mane
>Priority: Minor
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> As discussed at [https://s.apache.org/kn1f9] thread,
> We will setup new demo instance for 17.12 and obsolete 13.07. 
> The OFBiz demos are hosted at ofbiz-vm3.apache.org VM
> Currently, OFBiz has three demo instance:
> -- Previous Stable Release 13.07 - Demo
> https://demo-old.ofbiz.apache.org/ordermgr/control/main
> -- Current Stable Release 16.11 - Demo
> https://demo-stable.ofbiz.apache.org/ordermgr/control/main
> -- Developer Trunk - Demo
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/main
> So, as per new plan.
> https://demo-old.ofbiz.apache.org will point to 16.11 (which is currently 
> pointed at https://demo-stable.ofbiz.apache.org)
> And the newly setup 17.12 will be served at 
> https://demo-stable.ofbiz.apache.org
>  
> For this, we will need to make changes in the deployment scripts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #121: Fixed: organisation tree in humanres doesn't show person names (OFBIZ-11677)

[GitBox]

PierreSmits commented on pull request #121:
URL: https://github.com/apache/ofbiz-framework/pull/121#issuecomment-633419845


   Anyone willing to assist (review) to get this PR merged into the code base?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (OFBIZ-11692) Convert checkStatusCustRequest from mini-lang to groovy

[Pierre Smits (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11692:


Assignee: (was: Pierre Smits)

> Convert checkStatusCustRequest from mini-lang to groovy
> ---
>
> Key: OFBIZ-11692
> URL: https://issues.apache.org/jira/browse/OFBIZ-11692
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: refactoring, request
>
> See OFBIZ-9350 for motivation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #121: Fixed: organisation tree in humanres doesn't show person names (OFBIZ-11677)

[GitBox]

PierreSmits commented on pull request #121:
URL: https://github.com/apache/ofbiz-framework/pull/121#issuecomment-633416674


   @verma-pawan 
   
   I trust that nothing now stands in the way to get this merged into the code 
base. Will you assist?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (OFBIZ-11715) Simplify Quote menu labels

[Pierre Smits (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-11715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-11715:
-
Sprint: OFBiz Community Day (May 2020)

> Simplify Quote menu labels
> --
>
> Key: OFBIZ-11715
> URL: https://issues.apache.org/jira/browse/OFBIZ-11715
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: menus, usability
> Fix For: Upcoming Branch
>
> Attachments: Screen Shot 2020-05-18 at 13.43.15.png, Screen Shot 
> 2020-05-20 at 08.41.33.png
>
>
> See attached image:
> Every menu item in the QuoteTabBar includes the word 'Quote'. This is 
> unnecessary, as everything in that menu is quote related.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-7963) Create a Gradle Sonar task

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7963.
--
Resolution: Won't Do

We have a Sonar task running for PR, that's enough for me

> Create a Gradle Sonar task
> --
>
> Key: OFBIZ-7963
> URL: https://issues.apache.org/jira/browse/OFBIZ-7963
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-7963-sonar.patch, OFBIZ-7963-sonar.patch, 
> OFBIZ-7963-sonar.patch
>
>
> As ever the devil is in details. There is no longer a Sonar plugin available 
> https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should 
> rather refer to 
> http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle
> Anyway the most important part is to revive INFRA-3590



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11693) Help system using asciidoc files

[Jacques Le Roux (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115749#comment-17115749
 ] 

Jacques Le Roux commented on OFBIZ-11693:
-

Olivier, since you created INFRA-20311 you are the only one able to change 
there from "Waiting for user" to "Waiting for infra". Please do, else with all 
the work they have they may forget it...

> Help system using asciidoc files
> 
>
> Key: OFBIZ-11693
> URL: https://issues.apache.org/jira/browse/OFBIZ-11693
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: documentation, help, help-system
> Attachments: 
> OFBIZ-11693_0001-Improvement-Help-link-using-asciidoc-files-via-gener.patch, 
> OFBIZ-11693_0002-Documented-Migrate-AccountingHelData.xml-to-added-so.patch, 
> ofbiz.conf.patch
>
>
> a very simple solution which is a link to a documentation site.
> This solution use
>  1. at application level, a default proprety for documentation website uri
>  2. at the screen level
>  * it would be possible to give a other uri (for user documentation)
>  * if the anchor in the user documentation for this screen is put, the new 
> help is used otherwise the older link is used



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (OFBIZ-5836) Integrate web analytics into the website

[Pierre Smits (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-5836:
---

Assignee: Pierre Smits  (was: Sharan Foga)

> Integrate web analytics into the website
> 
>
> Key: OFBIZ-5836
> URL: https://issues.apache.org/jira/browse/OFBIZ-5836
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Demo, site
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>  Labels: traffic, visit
>
> Have some kind of web analytics integrated in the website to be able to some 
> kind analysis on visits, traffic etc.
> Refereces:
> * http://en.wikipedia.org/wiki/Web_analytics
> * http://en.wikipedia.org/wiki/List_of_web_analytics_software



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-5836) Integrate web analytics into the website

[Pierre Smits (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-5836:

Component/s: Demo

> Integrate web analytics into the website
> 
>
> Key: OFBIZ-5836
> URL: https://issues.apache.org/jira/browse/OFBIZ-5836
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: Demo, site
>Reporter: Pierre Smits
>Assignee: Sharan Foga
>Priority: Minor
>  Labels: traffic, visit
>
> Have some kind of web analytics integrated in the website to be able to some 
> kind analysis on visits, traffic etc.
> Refereces:
> * http://en.wikipedia.org/wiki/Web_analytics
> * http://en.wikipedia.org/wiki/List_of_web_analytics_software



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-5836) Integrate web analytics into the website

[Pierre Smits (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits updated OFBIZ-5836:

Labels: traffic visit  (was: )

> Integrate web analytics into the website
> 
>
> Key: OFBIZ-5836
> URL: https://issues.apache.org/jira/browse/OFBIZ-5836
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: site
>Reporter: Pierre Smits
>Assignee: Sharan Foga
>Priority: Minor
>  Labels: traffic, visit
>
> Have some kind of web analytics integrated in the website to be able to some 
> kind analysis on visits, traffic etc.
> Refereces:
> * http://en.wikipedia.org/wiki/Web_analytics
> * http://en.wikipedia.org/wiki/List_of_web_analytics_software



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-11693) Help system using asciidoc files

[Jacques Le Roux (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115746#comment-17115746
 ] 

Jacques Le Roux commented on OFBIZ-11693:
-

Thanks Olivier,

Looks good to me, I made few modifications. Nothing functional, only the titles 
and removed a duplicated line in RAT build, please review. We can't commit yet 
because the tree structure is not ready: 
https://ci.apache.org/projects/ofbiz/site/

Also while at it I'd like to finalise INFRA-20148 before committing...

> Help system using asciidoc files
> 
>
> Key: OFBIZ-11693
> URL: https://issues.apache.org/jira/browse/OFBIZ-11693
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: documentation, help, help-system
> Attachments: 
> OFBIZ-11693_0001-Improvement-Help-link-using-asciidoc-files-via-gener.patch, 
> OFBIZ-11693_0002-Documented-Migrate-AccountingHelData.xml-to-added-so.patch, 
> ofbiz.conf.patch
>
>
> a very simple solution which is a link to a documentation site.
> This solution use
>  1. at application level, a default proprety for documentation website uri
>  2. at the screen level
>  * it would be possible to give a other uri (for user documentation)
>  * if the anchor in the user documentation for this screen is put, the new 
> help is used otherwise the older link is used



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-5836) Integrate web analytics into the website

[Pierre Smits (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115744#comment-17115744
 ] 

Pierre Smits commented on OFBIZ-5836:
-

It seems to me, that - apart from a few  interested parties, those in control 
of the project aren't interested in knowing:
- which pages (both in site and demos) are visited
- where the visitors are coming from
- where the visitors abandon leave the site and demos.



> Integrate web analytics into the website
> 
>
> Key: OFBIZ-5836
> URL: https://issues.apache.org/jira/browse/OFBIZ-5836
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: site
>Reporter: Pierre Smits
>Assignee: Sharan Foga
>Priority: Minor
>
> Have some kind of web analytics integrated in the website to be able to some 
> kind analysis on visits, traffic etc.
> Refereces:
> * http://en.wikipedia.org/wiki/Web_analytics
> * http://en.wikipedia.org/wiki/List_of_web_analytics_software



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-5836) Integrate web analytics into the website

[Pierre Smits (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115742#comment-17115742
 ] 

Pierre Smits commented on OFBIZ-5836:
-

There have been a few discussions in the past about having visit analytics 
integrated in our static and demo sites. That this ticket has been concluded by 
now gives me the impression that these discussion haven't led to something that 
can be regarded as a consensus or a resolution.



> Integrate web analytics into the website
> 
>
> Key: OFBIZ-5836
> URL: https://issues.apache.org/jira/browse/OFBIZ-5836
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: site
>Reporter: Pierre Smits
>Assignee: Sharan Foga
>Priority: Minor
>
> Have some kind of web analytics integrated in the website to be able to some 
> kind analysis on visits, traffic etc.
> Refereces:
> * http://en.wikipedia.org/wiki/Web_analytics
> * http://en.wikipedia.org/wiki/List_of_web_analytics_software



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (OFBIZ-9976) Introduce require.js to organise JavaScript files

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-9976:
---
Parent: (was: OFBIZ-1319)
Issue Type: Improvement  (was: Sub-task)

> Introduce require.js to organise JavaScript files
> -
>
> Key: OFBIZ-9976
> URL: https://issues.apache.org/jira/browse/OFBIZ-9976
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Major
>
> As suggested by [~jacques.le.roux] in 
> http://markmail.org/message/eec2anlwdt4azaac and 
> http://ofbiz.markmail.org/thread/ti54omjdt4fy662m and as per the discussion 
> with [~amardeepsj] in OFBIZ-7758, introduce require.js http://requirejs.org/ 
> to load javascript files.
> Require.js offers a lot of benefits some of them includes:
> * Asynchronous module loading.
> * Well-structured code
> * Creating and re-using modules without polluting the global namespace
> * Explicit defining of dependencies between module



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-7362) Add paginate target to list forms to fix the pagination error

[Jacques Le Roux (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115727#comment-17115727
 ] 

Jacques Le Roux commented on OFBIZ-7362:


I guess the situation here has not changed?

> Add paginate target to list forms to fix the pagination error
> -
>
> Key: OFBIZ-7362
> URL: https://issues.apache.org/jira/browse/OFBIZ-7362
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
>Priority: Major
>
> I found issue in pagination on some screens when we do any operation (like 
> update, delete) on list item.
> For example: I have updated the content type from list in Content Setup Menu 
> in Content application and then clicked on next link of pagination, I got the 
> following error:
> {code}
> The Following Errors Occurred:
> Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found URL 
> parameter [contentTypeId] passed to secure (https) request-map with uri 
> [updateContentType] with an event that calls service [updateContentType]; 
> this is not allowed for security reasons!
> {code}
> The above error is unexpected as I just tried to see next list records of 
> ContentType. The reason of error is pagination URL which is same as URL of 
> page i.e. updateContentType. This URL is the update operation URL and it is 
> not redirected to appropriate page after operation.
> Pagination target URL should be independent of page URL and it should be 
> added on form using paginate-target attribute of form widget.
> This is a parent ticket and child tickets will be added in it for components.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (OFBIZ-1319) Split javascript files to have more generic ones includable in all screens, and the more specific ones included more locally

[Jacques Le Roux (Jira)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-1319.
--
Resolution: Implemented

> Split javascript files to have more generic ones includable in all screens, 
> and the more specific ones included more locally
> 
>
> Key: OFBIZ-1319
> URL: https://issues.apache.org/jira/browse/OFBIZ-1319
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> From a David's E. Jones comment on ML :
> We should split up javascript files to have the more generic ones includable 
> in all screens, and the more specific ones (like the toggle* and selectAll* 
> methods in there) into a file that can be included more locally. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-5836) Integrate web analytics into the website

[Jacques Le Roux (Jira)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115725#comment-17115725
 ] 

Jacques Le Roux commented on OFBIZ-5836:


After almost 6 years, should we not close here?

> Integrate web analytics into the website
> 
>
> Key: OFBIZ-5836
> URL: https://issues.apache.org/jira/browse/OFBIZ-5836
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: site
>Reporter: Pierre Smits
>Assignee: Sharan Foga
>Priority: Minor
>
> Have some kind of web analytics integrated in the website to be able to some 
> kind analysis on visits, traffic etc.
> Refereces:
> * http://en.wikipedia.org/wiki/Web_analytics
> * http://en.wikipedia.org/wiki/List_of_web_analytics_software



--
This message was sent by Atlassian Jira
(v8.3.4#803005)