[GitHub] [ofbiz-framework] surajkhurana merged pull request #180: Improved: Enforce noninstantiability to GroovyUtil Class.
surajkhurana merged pull request #180: URL: https://github.com/apache/ofbiz-framework/pull/180 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] surajkhurana merged pull request #178: Improved: Enforce noninstantiability to ConfigXMLReader Class
surajkhurana merged pull request #178: URL: https://github.com/apache/ofbiz-framework/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126970#comment-17126970 ] Jacques Le Roux commented on OFBIZ-11304: - Thanks Aditya, I continued a previous discussion about that at https://markmail.org/message/luomxqcmerwro2ry > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11769) Improvement, grp1: Add icon management, name and tooltips abstraction
[ https://issues.apache.org/jira/browse/OFBIZ-11769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11769: --- Attachment: (was: OFBIZ-11769_0001-Add-icon-management-name-and-tooltips-abstraction.patch) > Improvement, grp1: Add icon management, name and tooltips abstraction > - > > Key: OFBIZ-11769 > URL: https://issues.apache.org/jira/browse/OFBIZ-11769 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: > OFBIZ-11769_0001-Add-icon-management-name-and-tooltips-abstraction.patch > > > Add icon management, name and tooltips abstraction > two properties files, to be able to use a logical name not a "path" in link, > hyperlink ... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11769) Improvement, grp1: Add icon management, name and tooltips abstraction
[ https://issues.apache.org/jira/browse/OFBIZ-11769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-11769: --- Attachment: OFBIZ-11769_0001-Add-icon-management-name-and-tooltips-abstraction.patch > Improvement, grp1: Add icon management, name and tooltips abstraction > - > > Key: OFBIZ-11769 > URL: https://issues.apache.org/jira/browse/OFBIZ-11769 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Attachments: > OFBIZ-11769_0001-Add-icon-management-name-and-tooltips-abstraction.patch > > > Add icon management, name and tooltips abstraction > two properties files, to be able to use a logical name not a "path" in link, > hyperlink ... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11693) Help system using asciidoc files
[ https://issues.apache.org/jira/browse/OFBIZ-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126762#comment-17126762 ] ASF subversion and git services commented on OFBIZ-11693: - Commit 211540a9665abb526d9e426f47bc7dc8af7e94dd in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=211540a ] Documented: Help link using asciidoc files via generated html (OFBIZ-11693) Migrate AccountingHelData.xml to added some Help system using asciidoc files > > > Key: OFBIZ-11693 > URL: https://issues.apache.org/jira/browse/OFBIZ-11693 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: documentation, help, help-system > Attachments: > OFBIZ-11693_0001-Improvement-Help-link-using-asciidoc-files-via-gener.patch, > OFBIZ-11693_0002-Documented-Migrate-AccountingHelData.xml-to-added-so.patch, > OFBIZ-11693_0003-Documented-Migrate-CommonExtHelData.xml-to-added-som.patch, > ofbiz.conf.patch, ofbiz.conf.patch > > > a very simple solution which is a link to a documentation site. > This solution use > 1. at application level, a default proprety for documentation website uri > 2. at the screen level > * it would be possible to give a other uri (for user documentation) > * if the anchor in the user documentation for this screen is put, the new > help is used otherwise the older link is used -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #65: OFBIZ-11587 docbook to asciidoc
sonarcloud[bot] commented on pull request #65: URL: https://github.com/apache/ofbiz-framework/pull/65#issuecomment-639464042 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=65) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=65=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #65: OFBIZ-11587 docbook to asciidoc
sonarcloud[bot] removed a comment on pull request #65: URL: https://github.com/apache/ofbiz-framework/pull/65#issuecomment-630146642 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=65) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=65=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=65=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11693) Help system using asciidoc files
[ https://issues.apache.org/jira/browse/OFBIZ-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126737#comment-17126737 ] ASF subversion and git services commented on OFBIZ-11693: - Commit 4568c6f55a734d3c4247a01ba0f692cdf7cc0480 in ofbiz-framework's branch refs/heads/release18.12 from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4568c6f ] Improvement: Help link using asciidoc files via generated html (OFBIZ-11693) Change release to 18.12 for all asciidoc files where there is still 17.12 > Help system using asciidoc files > > > Key: OFBIZ-11693 > URL: https://issues.apache.org/jira/browse/OFBIZ-11693 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: documentation, help, help-system > Attachments: > OFBIZ-11693_0001-Improvement-Help-link-using-asciidoc-files-via-gener.patch, > OFBIZ-11693_0002-Documented-Migrate-AccountingHelData.xml-to-added-so.patch, > OFBIZ-11693_0003-Documented-Migrate-CommonExtHelData.xml-to-added-som.patch, > ofbiz.conf.patch, ofbiz.conf.patch > > > a very simple solution which is a link to a documentation site. > This solution use > 1. at application level, a default proprety for documentation website uri > 2. at the screen level > * it would be possible to give a other uri (for user documentation) > * if the anchor in the user documentation for this screen is put, the new > help is used otherwise the older link is used -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11742) AsciidoctorTask is deprecated in favor of AsciidoctorCompatibilityTask
[ https://issues.apache.org/jira/browse/OFBIZ-11742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126712#comment-17126712 ] Carsten Schinzer commented on OFBIZ-11742: -- Yep, it is not in the set of warnings that Michael Brohl mentioned on that ticket and it is highlighted as a manifest error in my IDE. Jacques Le Roux (Jira) schrieb am Di. 26. Mai 2020 um -- --- Dr. Carsten Schinzer *Inhaber* t +49 89 88569642 | f +49 89 99964059 | m +49 159 05269462 DCS Verkaufssysteme Gerner Str. 27 | 80638 München | Germany > AsciidoctorTask is deprecated in favor of AsciidoctorCompatibilityTask > -- > > Key: OFBIZ-11742 > URL: https://issues.apache.org/jira/browse/OFBIZ-11742 > Project: OFBiz > Issue Type: Bug > Components: Gradle >Affects Versions: Trunk > Environment: IntelliJ IDEA Community Edition >Reporter: Carsten Schinzer >Priority: Minor > > in build.gradle (commit > [5e1a23d|https://github.com/apache/ofbiz-framework/commit/5e1a23de1c6cc92fa10cd6008e2e758cdf7ffe4f], > line #498) the context help states that: > @Deprecated class AsciidoctorTask extends AsciidoctorCompatibilityTask > This is just a wrapper class in a legacy package. All of the code has moved > to AsciidoctorCompatibilityTask. > Also, the gradle viewer in my IDE states that the following rows contain > syntax errors, yet it builds: > attributes \ > 'doctype': 'book', > 'experimental': '', > 'icons': 'font', > 'sectnums': '', > 'chapter-label': '', > 'toc': 'left@', > 'toclevels': '3' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126706#comment-17126706
]
Ulrich Heidfeld commented on OFBIZ-11743:
-
Hi [~nmalin],
i have spotted this issue only in menu items. For example this can be tested by
applying following changes:
{code:java}
diff --git a/framework/webtools/widget/Menus.xml
b/framework/webtools/widget/Menus.xml
index 0dab587..02f4a24 100644
--- a/framework/webtools/widget/Menus.xml
+++ b/framework/webtools/widget/Menus.xml
@@ -112,7 +112,7 @@
-
+
diff --git a/framework/webtools/widget/ServiceScreens.xml
b/framework/webtools/widget/ServiceScreens.xml
index 38f7266..d03c1ab 100644
--- a/framework/webtools/widget/ServiceScreens.xml
+++ b/framework/webtools/widget/ServiceScreens.xml
@@ -263,6 +263,8 @@
+
+
{code}
The second parameter is not available in opening modal.
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
> Attachments: Capture d’écran de 2020-05-29 17-11-58.png
>
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-framework] PierreSmits edited a comment on pull request #117: Improved: Update Data Sets
PierreSmits edited a comment on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-639308014 How is this check fail possible? 2 days ago everything was fine, and now it is stating that it failed. The only thing changed is added a few records in the demo set. https://github.com/apache/ofbiz-framework/pull/117#issuecomment-639298833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #191: Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support fo
sonarcloud[bot] removed a comment on pull request #191: URL: https://github.com/apache/ofbiz-framework/pull/191#issuecomment-639398377 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=SECURITY_HOTSPOT) [2 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=CODE_SMELL) [38 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=191) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=191=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=191=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #191: Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support for Entity
sonarcloud[bot] commented on pull request #191: URL: https://github.com/apache/ofbiz-framework/pull/191#issuecomment-639402499 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=191) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=191=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=191=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #191: Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support for Entity
sonarcloud[bot] commented on pull request #191: URL: https://github.com/apache/ofbiz-framework/pull/191#issuecomment-639398377 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=SECURITY_HOTSPOT) [2 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=CODE_SMELL) [38 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=191) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=191=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=191=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11789) Implement EntityBatchIterator for large data set queries
[ https://issues.apache.org/jira/browse/OFBIZ-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126641#comment-17126641 ] Pawan Verma commented on OFBIZ-11789: - Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support for EntityBatchIterator to EntityQuery via 'queryBatchIterator'(OFBIZ-11789) Modified GenericDao#makeOffsetString to have OFFSET/FETCH style by default Modified entityengine's MySQL and Postgres data sources to have LIMIT/OFFSET style, rest can work with default OFFSET/FETCH style PR Link: [https://github.com/apache/ofbiz-framework/pull/191] Thanks: [~lektran] for the help. This can be tested using EntityQuery#queryBatchIterator() method for any entity that has large data. See the logs to verify its working. > Implement EntityBatchIterator for large data set queries > > > Key: OFBIZ-11789 > URL: https://issues.apache.org/jira/browse/OFBIZ-11789 > Project: OFBiz > Issue Type: Improvement > Components: framework/entity >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Dev Mail Thread: > [https://markmail.org/search/EntityBatchIterator+for+large+data+set+queries] > While working on the large database we have figured out that very large > queries consume all memory and crash ofbiz(because queryIterator() doesn't > really work, it's no different from queryList()) > The EntityListIterator attempts to use a cursor to iterate over large result > sets but in reality most databases do not give us a cursor unless we ask for > it in a very specific way, and instead you get back the full result set and > potentially consume a large amount of memory. For example, the MySql details > are here (ResultSet section): > [https://dev.mysql.com/doc/connector-j/5.1/en/connector-j-reference-implementation-notes.html] > To work around this we've built the EntityBatchIterator which instead > basically just pages through results like you would do on a webpage that uses > pagination. The iterator takes an EntityQuery and when next() is called it > grabs the first 500 records and returns the first record, call next again and > you get the second record, once you've called next 500 times it runs the > query again with an offset and grabs the next 500 and so on until there are > no more records. > The main downsides to this approach are: > 1. Same as when using limit/offset you want to be sure your results will come > back in a consistent order to avoid accidentally skipping some rows and > seeing other rows twice. > 2. Because the results are a combination of many queries rather than a single > query, some of the data may change while you are paging through it. i.e. if > you were to sort by lastUpdatedTxStamp you may see some rows twice as they > are updated by other transactions (this might be a good thing in some cases). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] verma-pawan opened a new pull request #191: Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support for EntityBatc
verma-pawan opened a new pull request #191: URL: https://github.com/apache/ofbiz-framework/pull/191 Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support for EntityBatchIterator to EntityQuery via 'queryBatchIterator'(OFBIZ-11789) Modified GenericDao#makeOffsetString to have OFFSET/FETCH style by default Modified entityengine's MySQL and Postgres data sources to have LIMIT/OFFSET style, rest can work with default OFFSET/FETCH style Thanks: Scott for the help. Improved: Implemented: Documented: Completed: Reverted: Fixed: (OFBIZ-) Explanation Thanks: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #190: Improved: tomahawk - simplified uris (OFBIZ-11798)
sonarcloud[bot] commented on pull request #190: URL: https://github.com/apache/ofbiz-framework/pull/190#issuecomment-639320649 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=190=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=190=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=190=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=190=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=190=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=190=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=190=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=190=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=190=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=190=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=190=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=190) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=190=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=190=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #190: Improved: tomahawk - simplified uris (OFBIZ-11798)
PierreSmits opened a new pull request #190: URL: https://github.com/apache/ofbiz-framework/pull/190 implement changes to the rainbow theme to provide simplified uris in the main menu. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-11798) Adjustment of tomahawk theme to work with simplified uris
Pierre Smits created OFBIZ-11798: Summary: Adjustment of tomahawk theme to work with simplified uris Key: OFBIZ-11798 URL: https://issues.apache.org/jira/browse/OFBIZ-11798 Project: OFBiz Issue Type: Sub-task Components: themes Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits implement changes to the tomahawk theme to provide simplified uris in the main menu. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11795) Adjustment of flatgrey theme to work with simplified uris
[ https://issues.apache.org/jira/browse/OFBIZ-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits updated OFBIZ-11795: - Description: implement changes to the flatgrey theme to provide simplified uris in the main menu. (was: implement changes to the flattery to provide simplified uris in the main menu.) > Adjustment of flatgrey theme to work with simplified uris > - > > Key: OFBIZ-11795 > URL: https://issues.apache.org/jira/browse/OFBIZ-11795 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: refactoring, usability > > implement changes to the flatgrey theme to provide simplified uris in the > main menu. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11723) Enforce noninstantiability to FinAccountHelper Class
[
https://issues.apache.org/jira/browse/OFBIZ-11723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126495#comment-17126495
]
ASF subversion and git services commented on OFBIZ-11723:
-
Commit b08fa4a9441f4f67b210b29ef424f0eaf6ff0433 in ofbiz-plugins's branch
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=b08fa4a ]
Improved: Enforce noninstantiability to FinAccountHelper Class. (#22)
(OFBIZ-11723)
Made class as final, added private constructor, also made data members as
private, defined getter and changed related occurrences.
> Enforce noninstantiability to FinAccountHelper Class
>
>
> Key: OFBIZ-11723
> URL: https://issues.apache.org/jira/browse/OFBIZ-11723
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>
> - Make FinAccountHelper class as final.
> - Add a private constructor.
> - Make the following public static variable as private.
> {code:java}
> public static final String MODULE = FinAccountHelper.class.getName();
> public static final int decimals =
> UtilNumber.getBigDecimalScale("finaccount.decimals");
> public static final RoundingMode rounding =
> UtilNumber.getRoundingMode("finaccount.rounding");
> public static final BigDecimal ZERO = BigDecimal.ZERO.setScale(decimals,
> rounding);
> public static final String giftCertFinAccountTypeId = "GIFTCERT_ACCOUNT";
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11723) Enforce noninstantiability to FinAccountHelper Class
[
https://issues.apache.org/jira/browse/OFBIZ-11723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Suraj Khurana closed OFBIZ-11723.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
> Enforce noninstantiability to FinAccountHelper Class
>
>
> Key: OFBIZ-11723
> URL: https://issues.apache.org/jira/browse/OFBIZ-11723
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
>
> - Make FinAccountHelper class as final.
> - Add a private constructor.
> - Make the following public static variable as private.
> {code:java}
> public static final String MODULE = FinAccountHelper.class.getName();
> public static final int decimals =
> UtilNumber.getBigDecimalScale("finaccount.decimals");
> public static final RoundingMode rounding =
> UtilNumber.getRoundingMode("finaccount.rounding");
> public static final BigDecimal ZERO = BigDecimal.ZERO.setScale(decimals,
> rounding);
> public static final String giftCertFinAccountTypeId = "GIFTCERT_ACCOUNT";
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11723) Enforce noninstantiability to FinAccountHelper Class
[
https://issues.apache.org/jira/browse/OFBIZ-11723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126494#comment-17126494
]
ASF subversion and git services commented on OFBIZ-11723:
-
Commit 73b15e98677567787e983db5d76df0f296070a44 in ofbiz-framework's branch
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=73b15e9 ]
Improved: Enforce noninstantiability to FinAccountHelper Class. (#171)
(OFBIZ-11723)
Made class as final, added private constructor, also made data members as
private, defined getter methods and changed related occurrences.
> Enforce noninstantiability to FinAccountHelper Class
>
>
> Key: OFBIZ-11723
> URL: https://issues.apache.org/jira/browse/OFBIZ-11723
> Project: OFBiz
> Issue Type: Sub-task
> Components: order
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
>
> - Make FinAccountHelper class as final.
> - Add a private constructor.
> - Make the following public static variable as private.
> {code:java}
> public static final String MODULE = FinAccountHelper.class.getName();
> public static final int decimals =
> UtilNumber.getBigDecimalScale("finaccount.decimals");
> public static final RoundingMode rounding =
> UtilNumber.getRoundingMode("finaccount.rounding");
> public static final BigDecimal ZERO = BigDecimal.ZERO.setScale(decimals,
> rounding);
> public static final String giftCertFinAccountTypeId = "GIFTCERT_ACCOUNT";
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #189: Improved: rainbow - simplified uris (OFBIZ-11797)
PierreSmits opened a new pull request #189: URL: https://github.com/apache/ofbiz-framework/pull/189 implement changes to the rainbow theme to provide simplified uris in the main menu. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] surajkhurana merged pull request #171: Improved: Enforce noninstantiability to FinAccountHelper Class.
surajkhurana merged pull request #171: URL: https://github.com/apache/ofbiz-framework/pull/171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] surajkhurana merged pull request #22: Improved: Enforce noninstantiability to FinAccountHelper Class.
surajkhurana merged pull request #22: URL: https://github.com/apache/ofbiz-plugins/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-11797) Adjustment of rainbow theme to work with simplified uris
Pierre Smits created OFBIZ-11797: Summary: Adjustment of rainbow theme to work with simplified uris Key: OFBIZ-11797 URL: https://issues.apache.org/jira/browse/OFBIZ-11797 Project: OFBiz Issue Type: Sub-task Components: themes Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits implement changes to the rainbow theme to provide simplified uris in the main menu. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #117: Improved: Update Data Sets
PierreSmits commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-639308014 How is this check fail possible? 2 days ago everything was fine, and now it is stating that it failed. The only thing changed is added a few records in the demo set. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-11796) Unnecessary iterations for all productFacilities in setLastInventoryCount
Suraj Khurana created OFBIZ-11796: - Summary: Unnecessary iterations for all productFacilities in setLastInventoryCount Key: OFBIZ-11796 URL: https://issues.apache.org/jira/browse/OFBIZ-11796 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Trunk, Release Branch 18.12, Release Branch 17.12 Reporter: Suraj Khurana Assignee: Suraj Khurana In the service setLastInventoryCount, which updates lastInventoryCount for product facility records, it works on inventoryItemDetail changes on availableToPromiseDiff. In parameter: InventoryItemId So it should be updating productFacilities entertaining both productId and facilityId of same inventoryItemId. Currently, it it unnecessary updating all the facilities inventory on a single inventory item update. It can be major performance factor on a production system working highly on inventory updates. -- This message was sent by Atlassian Jira (v8.3.4#803005)
