[jira] [Assigned] (OFBIZ-11559) Convert testToPayment test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri reassigned OFBIZ-11559: - Assignee: Rohit Hukkeri > Convert testToPayment test from XML to Groovy > - > > Key: OFBIZ-11559 > URL: https://issues.apache.org/jira/browse/OFBIZ-11559 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > > Convert testToPaymenttest from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134520#comment-17134520 ] Jacques Le Roux commented on OFBIZ-11304: - Mmm, BTW as Samuel noticed at top this does not handle PR pushes This is where we need something from infra... belt and suspenders... Also Mathieu preferred a pre-push when you make several commits before pushing... Too bad nobody spoke about those comments in dev ML. Anyway we still can easily change that. > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134510#comment-17134510 ] Jacques Le Roux commented on OFBIZ-11304: - Yes please, you may also assign yourself since you did the job ;) > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134351#comment-17134351 ] Aditya Sharma commented on OFBIZ-11304: --- Hi Jacques, I think we only use checkstyle plugin for trunk so backporting may not be needed. Should we close it then? > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134333#comment-17134333 ] ASF subversion and git services commented on OFBIZ-11304: - Commit 4be47732c7b29b9cbae8675ff7d5686f4e84891f in ofbiz-framework's branch refs/heads/trunk from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4be4773 ] Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304) * Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304) Used git-hooks-gradle-plugin with MIT license that helps configure shared Git hooks with Gradle buildscript https://github.com/jakemarsden/git-hooks-gradle-plugin * Improved: used exisiting checkstyleMain to check for the voilations (OFBIZ-11304) checkstyleMain will only fail in case when maxErrors increases Thank you Jacques for the suggestion * Improved: getChangedFiles() to check all the files (OFBIZ-11304) Initially the method only checks for the java files, so removed the code to filter java files * Removed: custom checkstyle gradle task (OFBIZ-11304) Existing checkstyleMain task fulfills the requirement Thank you Jacques, Mathieu, Samuel, and Pierre for your valuable inputs. > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134329#comment-17134329 ] ASF subversion and git services commented on OFBIZ-11304: - Commit 4be47732c7b29b9cbae8675ff7d5686f4e84891f in ofbiz-framework's branch refs/heads/trunk from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4be4773 ] Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304) * Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304) Used git-hooks-gradle-plugin with MIT license that helps configure shared Git hooks with Gradle buildscript https://github.com/jakemarsden/git-hooks-gradle-plugin * Improved: used exisiting checkstyleMain to check for the voilations (OFBIZ-11304) checkstyleMain will only fail in case when maxErrors increases Thank you Jacques for the suggestion * Improved: getChangedFiles() to check all the files (OFBIZ-11304) Initially the method only checks for the java files, so removed the code to filter java files * Removed: custom checkstyle gradle task (OFBIZ-11304) Existing checkstyleMain task fulfills the requirement Thank you Jacques, Mathieu, Samuel, and Pierre for your valuable inputs. > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134332#comment-17134332 ] ASF subversion and git services commented on OFBIZ-11304: - Commit 4be47732c7b29b9cbae8675ff7d5686f4e84891f in ofbiz-framework's branch refs/heads/trunk from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4be4773 ] Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304) * Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304) Used git-hooks-gradle-plugin with MIT license that helps configure shared Git hooks with Gradle buildscript https://github.com/jakemarsden/git-hooks-gradle-plugin * Improved: used exisiting checkstyleMain to check for the voilations (OFBIZ-11304) checkstyleMain will only fail in case when maxErrors increases Thank you Jacques for the suggestion * Improved: getChangedFiles() to check all the files (OFBIZ-11304) Initially the method only checks for the java files, so removed the code to filter java files * Removed: custom checkstyle gradle task (OFBIZ-11304) Existing checkstyleMain task fulfills the requirement Thank you Jacques, Mathieu, Samuel, and Pierre for your valuable inputs. > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134331#comment-17134331 ] ASF subversion and git services commented on OFBIZ-11304: - Commit 4be47732c7b29b9cbae8675ff7d5686f4e84891f in ofbiz-framework's branch refs/heads/trunk from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4be4773 ] Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304) * Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304) Used git-hooks-gradle-plugin with MIT license that helps configure shared Git hooks with Gradle buildscript https://github.com/jakemarsden/git-hooks-gradle-plugin * Improved: used exisiting checkstyleMain to check for the voilations (OFBIZ-11304) checkstyleMain will only fail in case when maxErrors increases Thank you Jacques for the suggestion * Improved: getChangedFiles() to check all the files (OFBIZ-11304) Initially the method only checks for the java files, so removed the code to filter java files * Removed: custom checkstyle gradle task (OFBIZ-11304) Existing checkstyleMain task fulfills the requirement Thank you Jacques, Mathieu, Samuel, and Pierre for your valuable inputs. > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134330#comment-17134330 ] ASF subversion and git services commented on OFBIZ-11304: - Commit 4be47732c7b29b9cbae8675ff7d5686f4e84891f in ofbiz-framework's branch refs/heads/trunk from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4be4773 ] Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304) * Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304) Used git-hooks-gradle-plugin with MIT license that helps configure shared Git hooks with Gradle buildscript https://github.com/jakemarsden/git-hooks-gradle-plugin * Improved: used exisiting checkstyleMain to check for the voilations (OFBIZ-11304) checkstyleMain will only fail in case when maxErrors increases Thank you Jacques for the suggestion * Improved: getChangedFiles() to check all the files (OFBIZ-11304) Initially the method only checks for the java files, so removed the code to filter java files * Removed: custom checkstyle gradle task (OFBIZ-11304) Existing checkstyleMain task fulfills the requirement Thank you Jacques, Mathieu, Samuel, and Pierre for your valuable inputs. > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134334#comment-17134334 ] Aditya Sharma commented on OFBIZ-11304: --- Thanks Jacques for sharing the detailed verification! I have merged the PR to trunk and will backport. > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] adityasharma7 merged pull request #161: Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304)
adityasharma7 merged pull request #161: URL: https://github.com/apache/ofbiz-framework/pull/161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-11781) Print pick sheet has distorted currency symbol
[ https://issues.apache.org/jira/browse/OFBIZ-11781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11781: Summary: Print pick sheet has distorted currency symbol (was: Print pick sheet has currency symbol) > Print pick sheet has distorted currency symbol > -- > > Key: OFBIZ-11781 > URL: https://issues.apache.org/jira/browse/OFBIZ-11781 > Project: OFBiz > Issue Type: Bug > Components: hhfacility >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11781.patch, orderPickSheet.pdf > > > Steps to regenerate: > # Login into facility > # Click on pickling tab > # Click on Print Pick Sheet button for any order (I tried it with WSCO1) > # Now see the Currency symbol is distorted for all the amounts. > See attached Pick sheet report for more details. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11820) Resolve issues in the test scripts for the base component
[ https://issues.apache.org/jira/browse/OFBIZ-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134203#comment-17134203 ] Priya Sharma commented on OFBIZ-11820: -- Thanks Jacques, Closing the ticket as per your explanation. > Resolve issues in the test scripts for the base component > - > > Key: OFBIZ-11820 > URL: https://issues.apache.org/jira/browse/OFBIZ-11820 > Project: OFBiz > Issue Type: Bug >Reporter: Priya Sharma >Priority: Major > Attachments: Screenshot from 2020-06-12 15-36-01.png > > > Execute the tests for the base component using the following command > ./gradlew "ofbiz --test component=base --test suitename=basetests" > A lot of error logs are generated on the console. Refer screenshot. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11820) Resolve issues in the test scripts for the base component
[ https://issues.apache.org/jira/browse/OFBIZ-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma closed OFBIZ-11820. Resolution: Not A Problem > Resolve issues in the test scripts for the base component > - > > Key: OFBIZ-11820 > URL: https://issues.apache.org/jira/browse/OFBIZ-11820 > Project: OFBiz > Issue Type: Bug >Reporter: Priya Sharma >Priority: Major > Attachments: Screenshot from 2020-06-12 15-36-01.png > > > Execute the tests for the base component using the following command > ./gradlew "ofbiz --test component=base --test suitename=basetests" > A lot of error logs are generated on the console. Refer screenshot. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element
[ https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134190#comment-17134190 ] Nicolas Malin commented on OFBIZ-11809: --- Thanks both for your review, It's not really currently finish, I just expose own work. This will be more interesting with the work on sub-decorator and inherit form. I'm focused to consolidate all concepts on presentation slide. I hope to expose this soon :) However, I appreciate your return > Access to the current screen from any widget element > > > Key: OFBIZ-11809 > URL: https://issues.apache.org/jira/browse/OFBIZ-11809 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Major > Labels: screen, widget > Attachments: OFBIZ-11808-OFBIZ-11809.patch > > > During the rendering process, an element have no information on the screen > that it depend. This not really help to automatism some refresh treatment and > force the developer to know the screen structure where is the element. > To solve this situation we implement a new class, ScreenStack that permit at > every time for an element to identify who it depend. This help to resolve the > unique Id that the screen take and can be exploit by the theme. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11819) Allow definition of external style sheet in multi-block html template
[ https://issues.apache.org/jira/browse/OFBIZ-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong closed OFBIZ-11819. -- Resolution: Implemented > Allow definition of external style sheet in multi-block html template > -- > > Key: OFBIZ-11819 > URL: https://issues.apache.org/jira/browse/OFBIZ-11819 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-11819.patch > > > Propose new function to set the external style sheet in multi-block html > template. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element
[ https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134170#comment-17134170 ] James Yong commented on OFBIZ-11809: Reviewed the patch. Looks good. > Access to the current screen from any widget element > > > Key: OFBIZ-11809 > URL: https://issues.apache.org/jira/browse/OFBIZ-11809 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Major > Labels: screen, widget > Attachments: OFBIZ-11808-OFBIZ-11809.patch > > > During the rendering process, an element have no information on the screen > that it depend. This not really help to automatism some refresh treatment and > force the developer to know the screen structure where is the element. > To solve this situation we implement a new class, ScreenStack that permit at > every time for an element to identify who it depend. This help to resolve the > unique Id that the screen take and can be exploit by the theme. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11820) Resolve issues in the test scripts for the base component
[ https://issues.apache.org/jira/browse/OFBIZ-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134155#comment-17134155 ] Jacques Le Roux commented on OFBIZ-11820: - Hi Priya, As long as the test an integration tests pass we have not to worry. Some tests generate errors and that's normal. We can close here :) > Resolve issues in the test scripts for the base component > - > > Key: OFBIZ-11820 > URL: https://issues.apache.org/jira/browse/OFBIZ-11820 > Project: OFBiz > Issue Type: Bug >Reporter: Priya Sharma >Priority: Major > Attachments: Screenshot from 2020-06-12 15-36-01.png > > > Execute the tests for the base component using the following command > ./gradlew "ofbiz --test component=base --test suitename=basetests" > A lot of error logs are generated on the console. Refer screenshot. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134147#comment-17134147
]
Jacques Le Roux edited comment on OFBIZ-11304 at 6/12/20, 11:55 AM:
HI Aditya,
This is what I get for a checkout:
{noformat}
C:\projectsASF\Git\ofbiz-framework>git checkout
M build.gradle
M
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
Your branch is up to date with 'origin/trunk'.
{noformat}
That makes sense and is not blocking. Also with
{noformat}
$ git.exe checkout release18.12
error: Your local changes to the following files would be overwritten by
checkout:
build.gradle
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
Please commit your changes or stash them before you switch branches.
Aborting
{noformat}
Again that makes sense and is not blocking.
With rebase, I get:
{noformat}
$ git rebase remotes/origin/trunk
error: cannot rebase: You have unstaged changes.
error: Please commit or stash them.
{noformat}
Again that makes sense and is not blocking.
After a no-verify:
{noformat}
C:\projectsASF\Git\ofbiz-framework>git commit --no-verify -a -m"test"
[trunk 746c1041c4] test
2 files changed, 34 insertions(+), 3 deletions(-)
C:\projectsASF\Git\ofbiz-framework>git checkout
Your branch is ahead of 'origin/trunk' by 1 commit.
(use "git push" to publish your local commits)
C:\projectsASF\Git\ofbiz-framework>git rebase remotes/origin/trunk
Current branch trunk is up to date.
{noformat}
Again that makes sense and is not blocking.
If I use git rebase -i, I get to this in my system editor:
{noformat}
pick 746c1041c4 test
# Rebase ed6a6fe3d3..746c1041c4 onto ed6a6fe3d3 (1 command)
#
# Commands:
# p, pick = use commit
# r, reword = use commit, but edit the commit message
# e, edit = use commit, but stop for amending
# s, squash = use commit, but meld into previous commit
# f, fixup = like "squash", but discard this commit's log message
# x, exec = run command (the rest of the line) using shell
# b, break = stop here (continue rebase later with 'git rebase --continue')
# d, drop = remove commit
# l, label = label current HEAD with a name
# t, reset = reset HEAD to a label
# m, merge [-C | -c ] [# ]
# . create a merge commit using the original merge commit's
# . message (or the oneline, if no original merge commit was
# . specified). Use -c to reword the commit message.
#
# These lines can be re-ordered; they are executed from top to bottom.
#
# If you remove a line here THAT COMMIT WILL BE LOST.
#
# However, if you remove everything, the rebase will be aborted.
#
{noformat}
I let it like that, then exited. I did not test all options. Again that makes
sense and is not blocking. I made a hard reset and all is OK with me.
So I agree we have no problems with that. At least so far and if ever we cross
issues they should not be hard to resolve or bypass. In any case we can
temporarily revert the commit.
So+1 for commit as is, TIA
was (Author: jacques.le.roux):
HI Aditya,
This is what I get for a checkout:
{noformat}
C:\projectsASF\Git\ofbiz-framework>git checkout
M build.gradle
M
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
Your branch is up to date with 'origin/trunk'.
{noformat}
That makes sense and is not blocking. Also with
{noformat}
$ git.exe checkout release18.12
error: Your local changes to the following files would be overwritten by
checkout:
build.gradle
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
Please commit your changes or stash them before you switch branches.
Aborting
{noformat}
Again that makes sense and is not blocking.
With rebase, I get:
{noformat}
$ git rebase remotes/origin/trunk
error: cannot rebase: You have unstaged changes.
error: Please commit or stash them.
{noformat}
Again that makes sense and is not blocking.
After a no-verify:
{noformat}
C:\projectsASF\Git\ofbiz-framework>git commit --no-verify -a -m"test"
[trunk 746c1041c4] test
2 files changed, 34 insertions(+), 3 deletions(-)
C:\projectsASF\Git\ofbiz-framework>git checkout
Your branch is ahead of 'origin/trunk' by 1 commit.
(use "git push" to publish your local commits)
C:\projectsASF\Git\ofbiz-framework>git rebase remotes/origin/trunk
Current branch trunk is up to date.
{noformat}
Again that makes sense and is not blocking.
If I use git rebase -i, I get to this in my system editor:
{noformat}
pick 746c1041c4 test
# Rebase ed6a6fe3d3..746c1041c4 onto ed6a6fe3d3 (1 command)
#
# Commands:
# p, pick = use commit
# r, reword = use commit, but edit the commit message
# e, edit = use commit, but stop for amending
# s, squash = use commit, but meld into previous commit
# f, fixup = like "squash", but discard this commit's log
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[
https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134147#comment-17134147
]
Jacques Le Roux commented on OFBIZ-11304:
-
HI Aditya,
This is what I get for a checkout:
{noformat}
C:\projectsASF\Git\ofbiz-framework>git checkout
M build.gradle
M
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
Your branch is up to date with 'origin/trunk'.
{noformat}
That makes sense and is not blocking. Also with
{noformat}
$ git.exe checkout release18.12
error: Your local changes to the following files would be overwritten by
checkout:
build.gradle
framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
Please commit your changes or stash them before you switch branches.
Aborting
{noformat}
Again that makes sense and is not blocking.
With rebase, I get:
{noformat}
$ git rebase remotes/origin/trunk
error: cannot rebase: You have unstaged changes.
error: Please commit or stash them.
{noformat}
Again that makes sense and is not blocking.
After a no-verify:
{noformat}
C:\projectsASF\Git\ofbiz-framework>git commit --no-verify -a -m"test"
[trunk 746c1041c4] test
2 files changed, 34 insertions(+), 3 deletions(-)
C:\projectsASF\Git\ofbiz-framework>git checkout
Your branch is ahead of 'origin/trunk' by 1 commit.
(use "git push" to publish your local commits)
C:\projectsASF\Git\ofbiz-framework>git rebase remotes/origin/trunk
Current branch trunk is up to date.
{noformat}
Again that makes sense and is not blocking.
If I use git rebase -i, I get to this in my system editor:
{noformat}
pick 746c1041c4 test
# Rebase ed6a6fe3d3..746c1041c4 onto ed6a6fe3d3 (1 command)
#
# Commands:
# p, pick = use commit
# r, reword = use commit, but edit the commit message
# e, edit = use commit, but stop for amending
# s, squash = use commit, but meld into previous commit
# f, fixup = like "squash", but discard this commit's log message
# x, exec = run command (the rest of the line) using shell
# b, break = stop here (continue rebase later with 'git rebase --continue')
# d, drop = remove commit
# l, label = label current HEAD with a name
# t, reset = reset HEAD to a label
# m, merge [-C | -c ] [# ]
# . create a merge commit using the original merge commit's
# . message (or the oneline, if no original merge commit was
# . specified). Use -c to reword the commit message.
#
# These lines can be re-ordered; they are executed from top to bottom.
#
# If you remove a line here THAT COMMIT WILL BE LOST.
#
# However, if you remove everything, the rebase will be aborted.
#
{noformat}
I let it like that, then exited. I did not test all options. Again that makes
sense and is not blocking. I made a hard reset and all is OK with me.
So I agree we have no problems with that. At least so far and if ever we cross
issues they should not be
> Install a Checkstyle pre-push (on every committer machine?)
> ---
>
> Key: OFBIZ-11304
> URL: https://issues.apache.org/jira/browse/OFBIZ-11304
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by
> the check gradle task. It's "hard" to exactly know from where lint errors
> come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like
> https://gist.github.com/davetron5000/37350 to complement
> tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when
> a lint error is present in the commit.
> Every committer would have it installed locally and the problem would be gone
> with some committers good will. I started a discussion about it at
> https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same
> proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-framework] surajkhurana merged pull request #200: Improved: Changed decimals, rounding, zero static variables names as per best practices in manufacturing component.
surajkhurana merged pull request #200: URL: https://github.com/apache/ofbiz-framework/pull/200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11804) Change decimals, rounding, zero static variables names as per best practices
[ https://issues.apache.org/jira/browse/OFBIZ-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134127#comment-17134127 ] ASF subversion and git services commented on OFBIZ-11804: - Commit 575defd088b6e785049646f8f909e6a5da363cd8 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=575defd ] Improved: Changed decimals, rounding, zero static variables names as per best practices in manufacturing component. (#200) (OFBIZ-11804) Also make them private data members of the class. > Change decimals, rounding, zero static variables names as per best practices > > > Key: OFBIZ-11804 > URL: https://issues.apache.org/jira/browse/OFBIZ-11804 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > As we have done it for modules, resources, it is better to get this done for > all similar variables as well. > decimals -> DECIMALS > rounding -> ROUNDING > zero -> ZERO > Also, we should make these variables as private instead of public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element
[
https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134126#comment-17134126
]
Jacques Le Roux commented on OFBIZ-11809:
-
Hi Nicolas,
I have reviewed, applied and succesfully compiled the patch. It looks good to
me and I can see this
when getting to
https://localhost:8443/catalog/control/login?USERNAME=admin=ofbiz=Y
So I guess it's OK (disclaimer: I did not test the areaId thing)
Just a trivial syntax point :) :
* {{if (! context.containsKey("screenStack")) {}} no space after !
I have still to carefully read all the chapters at OFBIZ-1808...
Thank you Nicolas!
> Access to the current screen from any widget element
>
>
> Key: OFBIZ-11809
> URL: https://issues.apache.org/jira/browse/OFBIZ-11809
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Priority: Major
> Labels: screen, widget
> Attachments: OFBIZ-11808-OFBIZ-11809.patch
>
>
> During the rendering process, an element have no information on the screen
> that it depend. This not really help to automatism some refresh treatment and
> force the developer to know the screen structure where is the element.
> To solve this situation we implement a new class, ScreenStack that permit at
> every time for an element to identify who it depend. This help to resolve the
> unique Id that the screen take and can be exploit by the theme.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11820) Resolve issues in the test scripts for the base component
[ https://issues.apache.org/jira/browse/OFBIZ-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-11820: - Summary: Resolve issues in the test scripts for the base component (was: Resolve issues in the tests scripts for the base component) > Resolve issues in the test scripts for the base component > - > > Key: OFBIZ-11820 > URL: https://issues.apache.org/jira/browse/OFBIZ-11820 > Project: OFBiz > Issue Type: Bug >Reporter: Priya Sharma >Priority: Major > Attachments: Screenshot from 2020-06-12 15-36-01.png > > > Execute the tests for the base component using the following command > ./gradlew "ofbiz --test component=base --test suitename=basetests" > A lot of error logs are generated on the console. Refer screenshot. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11820) Resolve issues in the tests scripts for the base component
Priya Sharma created OFBIZ-11820: Summary: Resolve issues in the tests scripts for the base component Key: OFBIZ-11820 URL: https://issues.apache.org/jira/browse/OFBIZ-11820 Project: OFBiz Issue Type: Bug Reporter: Priya Sharma Attachments: Screenshot from 2020-06-12 15-36-01.png Execute the tests for the base component using the following command ./gradlew "ofbiz --test component=base --test suitename=basetests" A lot of error logs are generated on the console. Refer screenshot. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11808) Improve screen engine with decrease technology dependence
[ https://issues.apache.org/jira/browse/OFBIZ-11808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11808: Description: After different presentation on thinking about how improve the end user experience on back office screen, we start a list of issues that cover the minimum need. [chapter 1|https://lists.apache.org/thread.html/5dcc8cff9b5413070079d22833b6a10abee55bcfbfb0233019ed09b1%40%3Cdev.ofbiz.apache.org%3E] [chapter 2|https://lists.apache.org/thread.html/r146f2814691e98e2cfc308ed3ac1db77fb6a356a2b73215517d300aa%40%3Cdev.ofbiz.apache.org%3E] [chapter 3|https://lists.apache.org/thread.html/ra5ed191eecbaf8096ddcdcf98048e70ea8c139fcab75c734ff30b6c0%40%3Cdev.ofbiz.apache.org%3E] Each improvement is designed to decrease the xml form definition, based on functional concept out any technology (relaying to theme). was: After different presentation on thinking about how improve the end user experience on back office screen, we start a list of issues that cover the minimum need. [chapter 1|https://lists.apache.org/thread.html/5dcc8cff9b5413070079d22833b6a10abee55bcfbfb0233019ed09b1%40%3Cdev.ofbiz.apache.org%3E] [chapter 2|https://lists.apache.org/thread.html/r146f2814691e98e2cfc308ed3ac1db77fb6a356a2b73215517d300aa%40%3Cdev.ofbiz.apache.org%3E] chapter 3 (would be come son) Each improvement is designed to decrease the xml form definition, based on functional concept out any technology (relaying to theme). > Improve screen engine with decrease technology dependence > - > > Key: OFBIZ-11808 > URL: https://issues.apache.org/jira/browse/OFBIZ-11808 > Project: OFBiz > Issue Type: Improvement > Components: framework, framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Labels: screen, widget > > After different presentation on thinking about how improve the end user > experience on back office screen, we start a list of issues that cover the > minimum need. > [chapter > 1|https://lists.apache.org/thread.html/5dcc8cff9b5413070079d22833b6a10abee55bcfbfb0233019ed09b1%40%3Cdev.ofbiz.apache.org%3E] > > [chapter > 2|https://lists.apache.org/thread.html/r146f2814691e98e2cfc308ed3ac1db77fb6a356a2b73215517d300aa%40%3Cdev.ofbiz.apache.org%3E] > [chapter > 3|https://lists.apache.org/thread.html/ra5ed191eecbaf8096ddcdcf98048e70ea8c139fcab75c734ff30b6c0%40%3Cdev.ofbiz.apache.org%3E] > Each improvement is designed to decrease the xml form definition, based on > functional concept out any technology (relaying to theme). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11819) Allow definition of external style sheet in multi-block html template
[ https://issues.apache.org/jira/browse/OFBIZ-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133965#comment-17133965 ] ASF subversion and git services commented on OFBIZ-11819: - Commit 33deb945018894613bdc928e0d164529695005ab in ofbiz-framework's branch refs/heads/trunk from James Yong [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=33deb94 ] Improved: Allow definition of external style sheet in multi-block html template (OFBIZ-11819) External style sheet in html template will be extracted to layoutSettings.styleSheets when multi-block=true. > Allow definition of external style sheet in multi-block html template > -- > > Key: OFBIZ-11819 > URL: https://issues.apache.org/jira/browse/OFBIZ-11819 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-11819.patch > > > Propose new function to set the external style sheet in multi-block html > template. -- This message was sent by Atlassian Jira (v8.3.4#803005)
