[jira] [Assigned] (OFBIZ-11555) Convert testInvoicePerShipmentSetOrderFalse test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11555: -- Assignee: Akash Jain > Convert testInvoicePerShipmentSetOrderFalse test from XML to Groovy > --- > > Key: OFBIZ-11555 > URL: https://issues.apache.org/jira/browse/OFBIZ-11555 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > > Convert testInvoicePerShipmentSetOrderFalse test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11540) Convert testDepositWithdrawPayments test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11540: -- Assignee: Akash Jain > Convert testDepositWithdrawPayments test from XML to Groovy > --- > > Key: OFBIZ-11540 > URL: https://issues.apache.org/jira/browse/OFBIZ-11540 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > > Convert testDepositWithdrawPayments test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11545) Convert disabledTestUpdatePaymentMethodAddress test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11545: -- Assignee: Akash Jain > Convert disabledTestUpdatePaymentMethodAddress test from XML to Groovy > -- > > Key: OFBIZ-11545 > URL: https://issues.apache.org/jira/browse/OFBIZ-11545 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > > Convert disabledTestUpdatePaymentMethodAddress test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11544) Convert testGlPostingOnCheckRun test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11544: -- Assignee: Akash Jain > Convert testGlPostingOnCheckRun test from XML to Groovy > --- > > Key: OFBIZ-11544 > URL: https://issues.apache.org/jira/browse/OFBIZ-11544 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > > Convert testGlPostingOnCheckRun test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11556) Convert testInvoicePerShipmentSetOrderTrue test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11556: -- Assignee: Akash Jain > Convert testInvoicePerShipmentSetOrderTrue test from XML to Groovy > -- > > Key: OFBIZ-11556 > URL: https://issues.apache.org/jira/browse/OFBIZ-11556 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > > Convert testInvoicePerShipmentSetOrderTrue test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11543) Convert testGlPostingsOnVoidPayment test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11543: -- Assignee: Akash Jain > Convert testGlPostingsOnVoidPayment test from XML to Groovy > --- > > Key: OFBIZ-11543 > URL: https://issues.apache.org/jira/browse/OFBIZ-11543 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > > Convert testGlPostingsOnVoidPayment test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11538) Convert testCreatePaymentAndPaymentGroupForInvoices test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11538: -- Assignee: Akash Jain > Convert testCreatePaymentAndPaymentGroupForInvoices test from XML to Groovy > --- > > Key: OFBIZ-11538 > URL: https://issues.apache.org/jira/browse/OFBIZ-11538 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > > Convert testCreatePaymentAndPaymentGroupForInvoices test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11539) Convert testCancelCheckRunPayments test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11539: -- Assignee: Akash Jain > Convert testCancelCheckRunPayments test from XML to Groovy > -- > > Key: OFBIZ-11539 > URL: https://issues.apache.org/jira/browse/OFBIZ-11539 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > > Convert testCancelCheckRunPayments test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11535) Convert testCreatePaymentGroupAndMember test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11535: -- Assignee: Akash Jain > Convert testCreatePaymentGroupAndMember test from XML to Groovy > --- > > Key: OFBIZ-11535 > URL: https://issues.apache.org/jira/browse/OFBIZ-11535 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > > Convert testCreatePaymentGroupAndMember test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11533) Convert testGlPostingOnCancelCheckRun test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11533: -- Assignee: Akash Jain > Convert testGlPostingOnCancelCheckRun test from XML to Groovy > - > > Key: OFBIZ-11533 > URL: https://issues.apache.org/jira/browse/OFBIZ-11533 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Fix For: Trunk > > > Convert testGlPostingOnCancelCheckRun test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11536) Convert testVoidPayment test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11536: -- Assignee: Akash Jain > Convert testVoidPayment test from XML to Groovy > --- > > Key: OFBIZ-11536 > URL: https://issues.apache.org/jira/browse/OFBIZ-11536 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > > Convert testVoidPayment test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11531) Covert testCommissionRun test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11531: -- Assignee: Akash Jain > Covert testCommissionRun test from XML to Groovy > > > Key: OFBIZ-11531 > URL: https://issues.apache.org/jira/browse/OFBIZ-11531 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Fix For: Trunk > > > Covert testCommissionRun test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11532) Convert testGlPostingOnCancelInvoice test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11532: -- Assignee: Akash Jain > Convert testGlPostingOnCancelInvoice test from XML to Groovy > > > Key: OFBIZ-11532 > URL: https://issues.apache.org/jira/browse/OFBIZ-11532 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Fix For: Trunk > > > Convert testGlPostingOnCancelInvoice test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11841) Integration using token-based transaction support
Pritam Kute created OFBIZ-11841: --- Summary: Integration using token-based transaction support Key: OFBIZ-11841 URL: https://issues.apache.org/jira/browse/OFBIZ-11841 Project: OFBiz Issue Type: Sub-task Affects Versions: Trunk Reporter: Pritam Kute Assignee: Pritam Kute In this ticket, we will take care of the configurable way to switch to token-based transactions instead of regular card transactions. This is a need to make website PCI DSS compliant. We are going to make this configurable from PaymentGatewayFirstData entity using enableDataVault flag. This entity definition is already pushed in basic card-based integration implementation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11837) First Data Payment Gateway Integration
[ https://issues.apache.org/jira/browse/OFBIZ-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144647#comment-17144647 ] Pritam Kute commented on OFBIZ-11837: - Here is the PR raised for this task. PR contains basic integration of the First Data payment gateway methods like Auth, Capture, Refund, and Release. https://github.com/apache/ofbiz-plugins/pull/34 > First Data Payment Gateway Integration > -- > > Key: OFBIZ-11837 > URL: https://issues.apache.org/jira/browse/OFBIZ-11837 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pritam Kute >Priority: Major > > Dev Thread Link: [https://markmail.org/thread/2p5top4idkeiwlih] > Apache OFBiz has OOTB integrations for most of the widely used payment > gateways around the world. > We are working on integrating First Data Payment Gateway for one of the > websites. The First Data payment gateway is quite popular and comes in the > list of top payment gateways around the globe. We would like to contribute > the basic payment gateway integration of First Data into Apache OFBiz. > Also as discussed over the DEV list, we will be contributing gateway as a > separate plugin. > We will create the subtasks under this main task to deliver different payment > gateway methods. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #34: Adding new plugin for integration of First Data payment gateway with …
sonarcloud[bot] commented on pull request #34: URL: https://github.com/apache/ofbiz-plugins/pull/34#issuecomment-649220205 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=34=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=34=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=34=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=34=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=34=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=34=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=34=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=34=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=34=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=34=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=34=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=34) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=34=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] pritambkute opened a new pull request #34: Adding new plugin for integration of First Data payment gateway with …
pritambkute opened a new pull request #34: URL: https://github.com/apache/ofbiz-plugins/pull/34 …Apache OFBiz. (OFBIZ-11837) Implemented: First Data Payment Gateway Integration (OFBIZ-11837) Implemented the First Data payment gateway integration. Added Auth, Capture, Release and Refund methods. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11823) Refactor PickListServices#isBinComplete method to remove unnecessary iterations
[ https://issues.apache.org/jira/browse/OFBIZ-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144071#comment-17144071 ] Jacques Le Roux commented on OFBIZ-11823: - +1 > Refactor PickListServices#isBinComplete method to remove unnecessary > iterations > --- > > Key: OFBIZ-11823 > URL: https://issues.apache.org/jira/browse/OFBIZ-11823 > Project: OFBiz > Issue Type: Improvement > Components: product/facility >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11823.patch, OFBIZ-11823.patch > > > PickListServices#isBinComplete() is used to check if picklistBin is complete. > This method reduces system performance when a picklistBin contains heavy no > of items in it, this method iterator all the items to check the status of the > item to validate if the bin is complete or not. > Instead of iteration, we can add itemStatusId != PICKITEM_COMPLETED condition > while fetching records from the entity using queryCount() method and if we > found count then picklistBin is not complete. > It can be a major performance factor on a production system working on heavy > orders. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11823) Refactor PickListServices#isBinComplete method to remove unnecessary iterations
[ https://issues.apache.org/jira/browse/OFBIZ-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143781#comment-17143781 ] Suraj Khurana commented on OFBIZ-11823: --- Looks good to me. > Refactor PickListServices#isBinComplete method to remove unnecessary > iterations > --- > > Key: OFBIZ-11823 > URL: https://issues.apache.org/jira/browse/OFBIZ-11823 > Project: OFBiz > Issue Type: Improvement > Components: product/facility >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11823.patch, OFBIZ-11823.patch > > > PickListServices#isBinComplete() is used to check if picklistBin is complete. > This method reduces system performance when a picklistBin contains heavy no > of items in it, this method iterator all the items to check the status of the > item to validate if the bin is complete or not. > Instead of iteration, we can add itemStatusId != PICKITEM_COMPLETED condition > while fetching records from the entity using queryCount() method and if we > found count then picklistBin is not complete. > It can be a major performance factor on a production system working on heavy > orders. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11840) Reflected XSS in content component
Jacques Le Roux created OFBIZ-11840: --- Summary: Reflected XSS in content component Key: OFBIZ-11840 URL: https://issues.apache.org/jira/browse/OFBIZ-11840 Project: OFBiz Issue Type: Sub-task Components: content Affects Versions: 17.12.03 Reporter: Jacques Le Roux Harshit Shukla [mailto:harshit.sh...@gmail.com] reported a Reflected XSS vulnerability in content component to the OFBiz security team, and we thank him for that. I'll later quote here his email message when the vulnerability will be fixed. It's a post-auth vulnerability so we did not ask for a CVE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11468) Convert ShipmentReceiptServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11468. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Wiebke! > Convert ShipmentReceiptServices.xml mini lang to groovy > --- > > Key: OFBIZ-11468 > URL: https://issues.apache.org/jira/browse/OFBIZ-11468 > Project: OFBiz > Issue Type: Sub-task >Reporter: Wiebke Pätzold >Assignee: Wiebke Pätzold >Priority: Minor > Fix For: Upcoming Branch > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11468) Convert ShipmentReceiptServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143675#comment-17143675 ] ASF subversion and git services commented on OFBIZ-11468: - Commit 7335ce021a3d6d241306087a4d0a97dcb8d08234 in ofbiz-framework's branch refs/heads/trunk from wpaetzold [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7335ce0 ] OFBIZ-11468 Improved: Convert ShipmentReceiptServices.xml mini lang to groovy (#150) * Improved: Convert ShipmentReceiptServices.xml mini lang to groovy (OFBIZ-11468) Also converted getTotalIssuedQuantityForOrderItem in IssuanceServices, because it is used in ShipmentReceiptServices and needed more return values. * split to long lines Co-authored-by: Wiebke Pätzold > Convert ShipmentReceiptServices.xml mini lang to groovy > --- > > Key: OFBIZ-11468 > URL: https://issues.apache.org/jira/browse/OFBIZ-11468 > Project: OFBiz > Issue Type: Sub-task >Reporter: Wiebke Pätzold >Assignee: Wiebke Pätzold >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11468) Convert ShipmentReceiptServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143674#comment-17143674 ] ASF subversion and git services commented on OFBIZ-11468: - Commit 7335ce021a3d6d241306087a4d0a97dcb8d08234 in ofbiz-framework's branch refs/heads/trunk from wpaetzold [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7335ce0 ] OFBIZ-11468 Improved: Convert ShipmentReceiptServices.xml mini lang to groovy (#150) * Improved: Convert ShipmentReceiptServices.xml mini lang to groovy (OFBIZ-11468) Also converted getTotalIssuedQuantityForOrderItem in IssuanceServices, because it is used in ShipmentReceiptServices and needed more return values. * split to long lines Co-authored-by: Wiebke Pätzold > Convert ShipmentReceiptServices.xml mini lang to groovy > --- > > Key: OFBIZ-11468 > URL: https://issues.apache.org/jira/browse/OFBIZ-11468 > Project: OFBiz > Issue Type: Sub-task >Reporter: Wiebke Pätzold >Assignee: Wiebke Pätzold >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #150: OFBIZ-11468 Improved: Convert ShipmentReceiptServices.xml mini lang to groovy
JacquesLeRoux merged pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-11833) Replace anonymous types with lambda expressions
[
https://issues.apache.org/jira/browse/OFBIZ-11833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Verma closed OFBIZ-11833.
---
Fix Version/s: Upcoming Branch
Resolution: Implemented
> Replace anonymous types with lambda expressions
> ---
>
> Key: OFBIZ-11833
> URL: https://issues.apache.org/jira/browse/OFBIZ-11833
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11833-plugins.patch, OFBIZ-11833.patch
>
>
> Generally, something like that:
> {code:java}
> new PrivilegedAction() {
> @Override
> public ClassLoader run() {
> ClassLoader cl = null;
> try
> { cl = Thread.currentThread().getContextClassLoader(); }
> catch (SecurityException e) {
> Debug.logError(e, e.getMessage(), MODULE);
> }
> return cl;
> }
> });
> {code}
> is replaced with
> {code:java}
> (PrivilegedAction) () -> {
> ClassLoader cl = null;
> try
> { cl = Thread.currentThread().getContextClassLoader(); }
> catch (SecurityException e) {
> Debug.logError(e, e.getMessage(), MODULE);
> }
> return cl;
> });
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11833) Replace anonymous types with lambda expressions
[
https://issues.apache.org/jira/browse/OFBIZ-11833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143653#comment-17143653
]
ASF subversion and git services commented on OFBIZ-11833:
-
Commit 57fd870878f36311740e65f1a43f0de99d9919bd in ofbiz-plugins's branch
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=57fd870 ]
Improved: Replace anonymous types with lambda expressions(OFBIZ-11833)
> Replace anonymous types with lambda expressions
> ---
>
> Key: OFBIZ-11833
> URL: https://issues.apache.org/jira/browse/OFBIZ-11833
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11833-plugins.patch, OFBIZ-11833.patch
>
>
> Generally, something like that:
> {code:java}
> new PrivilegedAction() {
> @Override
> public ClassLoader run() {
> ClassLoader cl = null;
> try
> { cl = Thread.currentThread().getContextClassLoader(); }
> catch (SecurityException e) {
> Debug.logError(e, e.getMessage(), MODULE);
> }
> return cl;
> }
> });
> {code}
> is replaced with
> {code:java}
> (PrivilegedAction) () -> {
> ClassLoader cl = null;
> try
> { cl = Thread.currentThread().getContextClassLoader(); }
> catch (SecurityException e) {
> Debug.logError(e, e.getMessage(), MODULE);
> }
> return cl;
> });
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11833) Replace anonymous types with lambda expressions
[
https://issues.apache.org/jira/browse/OFBIZ-11833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143652#comment-17143652
]
ASF subversion and git services commented on OFBIZ-11833:
-
Commit 4275825b4af7eb5746ebada46cd68b043b308dd2 in ofbiz-framework's branch
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4275825 ]
Improved: Replace anonymous types with lambda expressions(OFBIZ-11833)
> Replace anonymous types with lambda expressions
> ---
>
> Key: OFBIZ-11833
> URL: https://issues.apache.org/jira/browse/OFBIZ-11833
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11833-plugins.patch, OFBIZ-11833.patch
>
>
> Generally, something like that:
> {code:java}
> new PrivilegedAction() {
> @Override
> public ClassLoader run() {
> ClassLoader cl = null;
> try
> { cl = Thread.currentThread().getContextClassLoader(); }
> catch (SecurityException e) {
> Debug.logError(e, e.getMessage(), MODULE);
> }
> return cl;
> }
> });
> {code}
> is replaced with
> {code:java}
> (PrivilegedAction) () -> {
> ClassLoader cl = null;
> try
> { cl = Thread.currentThread().getContextClassLoader(); }
> catch (SecurityException e) {
> Debug.logError(e, e.getMessage(), MODULE);
> }
> return cl;
> });
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #150: OFBIZ-11468 Improved: Convert ShipmentReceiptServices.xml mini lang to groovy
sonarcloud[bot] commented on pull request #150: URL: https://github.com/apache/ofbiz-framework/pull/150#issuecomment-648640226 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=150=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=150=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=150=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=150=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=150=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=150=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=150=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=150=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=150=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=150=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=150=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=150) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=150=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=150=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11560) Convert testTaxGeoId test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143578#comment-17143578 ] ASF subversion and git services commented on OFBIZ-11560: - Commit bb18170d71b860516bb80fe99201fe2e5cb9e030 in ofbiz-framework's branch refs/heads/trunk from Pawan Verma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bb18170 ] Improved: Converted test-group to test-case as there is only one test case.(OFBIZ-11560) > Convert testTaxGeoId test from XML to Groovy > > > Key: OFBIZ-11560 > URL: https://issues.apache.org/jira/browse/OFBIZ-11560 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Anushi Gupta >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11560.patch > > > Convert testTaxGeoId test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11823) Refactor PickListServices#isBinComplete method to remove unnecessary iterations
[ https://issues.apache.org/jira/browse/OFBIZ-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143563#comment-17143563 ] Pawan Verma commented on OFBIZ-11823: - Hi [~surajk] Are we good with the new patch? Should I commit? > Refactor PickListServices#isBinComplete method to remove unnecessary > iterations > --- > > Key: OFBIZ-11823 > URL: https://issues.apache.org/jira/browse/OFBIZ-11823 > Project: OFBiz > Issue Type: Improvement > Components: product/facility >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11823.patch, OFBIZ-11823.patch > > > PickListServices#isBinComplete() is used to check if picklistBin is complete. > This method reduces system performance when a picklistBin contains heavy no > of items in it, this method iterator all the items to check the status of the > item to validate if the bin is complete or not. > Instead of iteration, we can add itemStatusId != PICKITEM_COMPLETED condition > while fetching records from the entity using queryCount() method and if we > found count then picklistBin is not complete. > It can be a major performance factor on a production system working on heavy > orders. -- This message was sent by Atlassian Jira (v8.3.4#803005)
