[jira] [Commented] (OFBIZ-11846) Introduce support for having condition in EntityQuery#queryList method
[ https://issues.apache.org/jira/browse/OFBIZ-11846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147097#comment-17147097 ] Pawan Verma commented on OFBIZ-11846: - Attaching a patch for this improvement. > Introduce support for having condition in EntityQuery#queryList method > -- > > Key: OFBIZ-11846 > URL: https://issues.apache.org/jira/browse/OFBIZ-11846 > Project: OFBiz > Issue Type: Improvement > Components: framework/entity >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: OFBIZ-11846.patch > > > While reading code with [~nitish.mishra], we found that > EntityQuery.queryList() method does not have support for having conditions > while the queryIterator() method has. > So, It would be good to have the support in EntityQuery.queryList() as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11846) Introduce support for having condition in EntityQuery#queryList method
[ https://issues.apache.org/jira/browse/OFBIZ-11846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11846: Attachment: OFBIZ-11846.patch > Introduce support for having condition in EntityQuery#queryList method > -- > > Key: OFBIZ-11846 > URL: https://issues.apache.org/jira/browse/OFBIZ-11846 > Project: OFBiz > Issue Type: Improvement > Components: framework/entity >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: OFBIZ-11846.patch > > > While reading code with [~nitish.mishra], we found that > EntityQuery.queryList() method does not have support for having conditions > while the queryIterator() method has. > So, It would be good to have the support in EntityQuery.queryList() as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11294) EntityQuery queryCount is throwing error with distinct method
[
https://issues.apache.org/jira/browse/OFBIZ-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147094#comment-17147094
]
ASF subversion and git services commented on OFBIZ-11294:
-
Commit f6353957e233777b15d375ce2ada5cb91f234aad in ofbiz-framework's branch
refs/heads/release17.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f635395 ]
Fixed: EntityQuery queryCount is throwing error with distinct method
(OFBIZ-11294)
Added missing support for selectFields in queryCount and all the subsequent
methods.
Thanks: Deepak Dixit for the review.
> EntityQuery queryCount is throwing error with distinct method
> -
>
> Key: OFBIZ-11294
> URL: https://issues.apache.org/jira/browse/OFBIZ-11294
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release
> Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
>
> We have a bug/missing support for distinct when used with queryCount method
> of EntityQuery.
> Below is the more detail
> {code:java}
> EntityCondition cond = EntityCondition.makeCondition(UtilMisc.toList(
> EntityCondition.makeCondition("locationSeqId", "00test123"),
> EntityCondition.makeCondition("facilityId", EntityOperator.EQUALS,
> "10070"),
> EntityCondition.makeCondition("quantityOnHandTotal",
> EntityOperator.GREATER_THAN, BigDecimal.ZERO)),
> EntityOperator.AND);{code}
> *Case 1:* queryList().size() with distinct
> {code:java}
> int productAtLocation =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).distinct().queryList().size();{code}
> Result Query: SELECT DISTINCT PRODUCT_ID FROM INVENTORY_ITEM WHERE
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case works well.
> *Case 2:* queryCount without distinct
> {code:java}
> Long testCount =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(1) FROM INVENTORY_ITEM WHERE ((LOCATION_SEQ_ID =
> ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case also works well
> *Case 3:* queryCount with distinct
> {code:java}
> Long testCount =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(DISTINCT *) FROM INVENTORY_ITEM WHERE
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case throw an error
> org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception while
> executing the following:SELECT COUNT(DISTINCT *) FROM OFBIZ.INVENTORY_ITEM
> (Syntax error: Encountered "*" at line 1, column 23.)
>
> *Below is the research I have done for the issue:*
> In EntityQuery.queryCount(), return method is
> delegator.findCountByCondition(). This method doesn't have support for
> fieldsToSelect.
> When we reach till GenericDAO.selectCountByCondition() at line 949,
> returning method is setting *null* for selectFields.
> And at the implementation of selectCountByCondition, at line 994 we have a
> check for selectFields, that's why we are having *COUNT(DISTINCT *)* in our
> query.
>
> *To test this, I have used a simple way:*
> Just include below code at any groovy file and run it:
> {code:java}
> testCount = select("productId").from("InventoryItem").distinct().queryCount()
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11294) EntityQuery queryCount is throwing error with distinct method
[
https://issues.apache.org/jira/browse/OFBIZ-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Verma closed OFBIZ-11294.
---
Fix Version/s: 17.12.04
18.12.01
Resolution: Fixed
Thanks, [~amit.gadaley] for the review and test.
> EntityQuery queryCount is throwing error with distinct method
> -
>
> Key: OFBIZ-11294
> URL: https://issues.apache.org/jira/browse/OFBIZ-11294
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release
> Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 18.12.01, 17.12.04
>
>
> We have a bug/missing support for distinct when used with queryCount method
> of EntityQuery.
> Below is the more detail
> {code:java}
> EntityCondition cond = EntityCondition.makeCondition(UtilMisc.toList(
> EntityCondition.makeCondition("locationSeqId", "00test123"),
> EntityCondition.makeCondition("facilityId", EntityOperator.EQUALS,
> "10070"),
> EntityCondition.makeCondition("quantityOnHandTotal",
> EntityOperator.GREATER_THAN, BigDecimal.ZERO)),
> EntityOperator.AND);{code}
> *Case 1:* queryList().size() with distinct
> {code:java}
> int productAtLocation =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).distinct().queryList().size();{code}
> Result Query: SELECT DISTINCT PRODUCT_ID FROM INVENTORY_ITEM WHERE
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case works well.
> *Case 2:* queryCount without distinct
> {code:java}
> Long testCount =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(1) FROM INVENTORY_ITEM WHERE ((LOCATION_SEQ_ID =
> ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case also works well
> *Case 3:* queryCount with distinct
> {code:java}
> Long testCount =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(DISTINCT *) FROM INVENTORY_ITEM WHERE
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case throw an error
> org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception while
> executing the following:SELECT COUNT(DISTINCT *) FROM OFBIZ.INVENTORY_ITEM
> (Syntax error: Encountered "*" at line 1, column 23.)
>
> *Below is the research I have done for the issue:*
> In EntityQuery.queryCount(), return method is
> delegator.findCountByCondition(). This method doesn't have support for
> fieldsToSelect.
> When we reach till GenericDAO.selectCountByCondition() at line 949,
> returning method is setting *null* for selectFields.
> And at the implementation of selectCountByCondition, at line 994 we have a
> check for selectFields, that's why we are having *COUNT(DISTINCT *)* in our
> query.
>
> *To test this, I have used a simple way:*
> Just include below code at any groovy file and run it:
> {code:java}
> testCount = select("productId").from("InventoryItem").distinct().queryCount()
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11294) EntityQuery queryCount is throwing error with distinct method
[
https://issues.apache.org/jira/browse/OFBIZ-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147091#comment-17147091
]
ASF subversion and git services commented on OFBIZ-11294:
-
Commit 11dedfa79fdab3ee2eb701bc8a43c6f5ccfe116c in ofbiz-framework's branch
refs/heads/release18.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=11dedfa ]
Fixed: EntityQuery queryCount is throwing error with distinct method
(OFBIZ-11294)
Added missing support for selectFields in queryCount and all the subsequent
methods.
Thanks: Deepak Dixit for the review.
> EntityQuery queryCount is throwing error with distinct method
> -
>
> Key: OFBIZ-11294
> URL: https://issues.apache.org/jira/browse/OFBIZ-11294
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release
> Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
>
> We have a bug/missing support for distinct when used with queryCount method
> of EntityQuery.
> Below is the more detail
> {code:java}
> EntityCondition cond = EntityCondition.makeCondition(UtilMisc.toList(
> EntityCondition.makeCondition("locationSeqId", "00test123"),
> EntityCondition.makeCondition("facilityId", EntityOperator.EQUALS,
> "10070"),
> EntityCondition.makeCondition("quantityOnHandTotal",
> EntityOperator.GREATER_THAN, BigDecimal.ZERO)),
> EntityOperator.AND);{code}
> *Case 1:* queryList().size() with distinct
> {code:java}
> int productAtLocation =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).distinct().queryList().size();{code}
> Result Query: SELECT DISTINCT PRODUCT_ID FROM INVENTORY_ITEM WHERE
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case works well.
> *Case 2:* queryCount without distinct
> {code:java}
> Long testCount =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(1) FROM INVENTORY_ITEM WHERE ((LOCATION_SEQ_ID =
> ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case also works well
> *Case 3:* queryCount with distinct
> {code:java}
> Long testCount =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(DISTINCT *) FROM INVENTORY_ITEM WHERE
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case throw an error
> org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception while
> executing the following:SELECT COUNT(DISTINCT *) FROM OFBIZ.INVENTORY_ITEM
> (Syntax error: Encountered "*" at line 1, column 23.)
>
> *Below is the research I have done for the issue:*
> In EntityQuery.queryCount(), return method is
> delegator.findCountByCondition(). This method doesn't have support for
> fieldsToSelect.
> When we reach till GenericDAO.selectCountByCondition() at line 949,
> returning method is setting *null* for selectFields.
> And at the implementation of selectCountByCondition, at line 994 we have a
> check for selectFields, that's why we are having *COUNT(DISTINCT *)* in our
> query.
>
> *To test this, I have used a simple way:*
> Just include below code at any groovy file and run it:
> {code:java}
> testCount = select("productId").from("InventoryItem").distinct().queryCount()
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11294) EntityQuery queryCount is throwing error with distinct method
[
https://issues.apache.org/jira/browse/OFBIZ-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147090#comment-17147090
]
ASF subversion and git services commented on OFBIZ-11294:
-
Commit 031592cc32b49ebe873515741190f87f4365cb91 in ofbiz-framework's branch
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=031592c ]
Fixed: EntityQuery queryCount is throwing error with distinct method
(OFBIZ-11294)
Added missing support for selectFields in queryCount and all the subsequent
methods.
Thanks: Deepak Dixit for the review.
> EntityQuery queryCount is throwing error with distinct method
> -
>
> Key: OFBIZ-11294
> URL: https://issues.apache.org/jira/browse/OFBIZ-11294
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release
> Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
>
> We have a bug/missing support for distinct when used with queryCount method
> of EntityQuery.
> Below is the more detail
> {code:java}
> EntityCondition cond = EntityCondition.makeCondition(UtilMisc.toList(
> EntityCondition.makeCondition("locationSeqId", "00test123"),
> EntityCondition.makeCondition("facilityId", EntityOperator.EQUALS,
> "10070"),
> EntityCondition.makeCondition("quantityOnHandTotal",
> EntityOperator.GREATER_THAN, BigDecimal.ZERO)),
> EntityOperator.AND);{code}
> *Case 1:* queryList().size() with distinct
> {code:java}
> int productAtLocation =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).distinct().queryList().size();{code}
> Result Query: SELECT DISTINCT PRODUCT_ID FROM INVENTORY_ITEM WHERE
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case works well.
> *Case 2:* queryCount without distinct
> {code:java}
> Long testCount =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(1) FROM INVENTORY_ITEM WHERE ((LOCATION_SEQ_ID =
> ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case also works well
> *Case 3:* queryCount with distinct
> {code:java}
> Long testCount =
> EntityQuery.use(delegator).select("productId").from("InventoryItem")
> .where(cond).maxRows(2).queryCount();{code}
> Result Query: SELECT COUNT(DISTINCT *) FROM INVENTORY_ITEM WHERE
> ((LOCATION_SEQ_ID = ? AND FACILITY_ID = ? AND QUANTITY_ON_HAND_TOTAL > ?))
> Result: This case throw an error
> org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception while
> executing the following:SELECT COUNT(DISTINCT *) FROM OFBIZ.INVENTORY_ITEM
> (Syntax error: Encountered "*" at line 1, column 23.)
>
> *Below is the research I have done for the issue:*
> In EntityQuery.queryCount(), return method is
> delegator.findCountByCondition(). This method doesn't have support for
> fieldsToSelect.
> When we reach till GenericDAO.selectCountByCondition() at line 949,
> returning method is setting *null* for selectFields.
> And at the implementation of selectCountByCondition, at line 994 we have a
> check for selectFields, that's why we are having *COUNT(DISTINCT *)* in our
> query.
>
> *To test this, I have used a simple way:*
> Just include below code at any groovy file and run it:
> {code:java}
> testCount = select("productId").from("InventoryItem").distinct().queryCount()
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11846) Introduce support for having condition in EntityQuery#queryList method
Pawan Verma created OFBIZ-11846: --- Summary: Introduce support for having condition in EntityQuery#queryList method Key: OFBIZ-11846 URL: https://issues.apache.org/jira/browse/OFBIZ-11846 Project: OFBiz Issue Type: Improvement Components: framework/entity Affects Versions: Trunk Reporter: Pawan Verma Assignee: Pawan Verma While reading code with [~nitish.mishra], we found that EntityQuery.queryList() method does not have support for having conditions while the queryIterator() method has. So, It would be good to have the support in EntityQuery.queryList() as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11779) Use GroovyBaseScript's makeValue utility methods in each Groovy files
[ https://issues.apache.org/jira/browse/OFBIZ-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11779. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks, [~priya.sharma.9362] for the contribution and [~nmalin] for the review. > Use GroovyBaseScript's makeValue utility methods in each Groovy files > - > > Key: OFBIZ-11779 > URL: https://issues.apache.org/jira/browse/OFBIZ-11779 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > > Use GroovyBaseScript's makeValue utility methods instead of using Delegator > in each Groovy files > Currently, we have both patterns in Groovy files, we should replace > delegator.makeValue(args) with makeValue(args) for consistency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11779) Use GroovyBaseScript's makeValue utility methods in each Groovy files
[ https://issues.apache.org/jira/browse/OFBIZ-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147080#comment-17147080 ] ASF subversion and git services commented on OFBIZ-11779: - Commit d931dfb9c9374d1b3d22bfc9ad9f921b2e9bf438 in ofbiz-plugins's branch refs/heads/trunk from Priya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=d931dfb ] Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779) (#33) * Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files(OFBIZ-11779) * Improved: Removed extra bracket added accidentally. (OFBIZ-11779) * Update bi/groovyScripts/DimensionServices.groovy Co-authored-by: Nicolas Malin Co-authored-by: Priya Sharma Co-authored-by: Nicolas Malin > Use GroovyBaseScript's makeValue utility methods in each Groovy files > - > > Key: OFBIZ-11779 > URL: https://issues.apache.org/jira/browse/OFBIZ-11779 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Use GroovyBaseScript's makeValue utility methods instead of using Delegator > in each Groovy files > Currently, we have both patterns in Groovy files, we should replace > delegator.makeValue(args) with makeValue(args) for consistency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11779) Use GroovyBaseScript's makeValue utility methods in each Groovy files
[ https://issues.apache.org/jira/browse/OFBIZ-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147082#comment-17147082 ] ASF subversion and git services commented on OFBIZ-11779: - Commit d931dfb9c9374d1b3d22bfc9ad9f921b2e9bf438 in ofbiz-plugins's branch refs/heads/trunk from Priya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=d931dfb ] Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779) (#33) * Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files(OFBIZ-11779) * Improved: Removed extra bracket added accidentally. (OFBIZ-11779) * Update bi/groovyScripts/DimensionServices.groovy Co-authored-by: Nicolas Malin Co-authored-by: Priya Sharma Co-authored-by: Nicolas Malin > Use GroovyBaseScript's makeValue utility methods in each Groovy files > - > > Key: OFBIZ-11779 > URL: https://issues.apache.org/jira/browse/OFBIZ-11779 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Use GroovyBaseScript's makeValue utility methods instead of using Delegator > in each Groovy files > Currently, we have both patterns in Groovy files, we should replace > delegator.makeValue(args) with makeValue(args) for consistency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11779) Use GroovyBaseScript's makeValue utility methods in each Groovy files
[ https://issues.apache.org/jira/browse/OFBIZ-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147081#comment-17147081 ] ASF subversion and git services commented on OFBIZ-11779: - Commit d931dfb9c9374d1b3d22bfc9ad9f921b2e9bf438 in ofbiz-plugins's branch refs/heads/trunk from Priya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=d931dfb ] Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779) (#33) * Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files(OFBIZ-11779) * Improved: Removed extra bracket added accidentally. (OFBIZ-11779) * Update bi/groovyScripts/DimensionServices.groovy Co-authored-by: Nicolas Malin Co-authored-by: Priya Sharma Co-authored-by: Nicolas Malin > Use GroovyBaseScript's makeValue utility methods in each Groovy files > - > > Key: OFBIZ-11779 > URL: https://issues.apache.org/jira/browse/OFBIZ-11779 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Use GroovyBaseScript's makeValue utility methods instead of using Delegator > in each Groovy files > Currently, we have both patterns in Groovy files, we should replace > delegator.makeValue(args) with makeValue(args) for consistency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] verma-pawan merged pull request #207: Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779))
verma-pawan merged pull request #207: URL: https://github.com/apache/ofbiz-framework/pull/207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] verma-pawan merged pull request #33: Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779)
verma-pawan merged pull request #33: URL: https://github.com/apache/ofbiz-plugins/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11779) Use GroovyBaseScript's makeValue utility methods in each Groovy files
[ https://issues.apache.org/jira/browse/OFBIZ-11779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147079#comment-17147079 ] ASF subversion and git services commented on OFBIZ-11779: - Commit 5a144c0beddf9747176d7523bdde32a5f0a832d3 in ofbiz-framework's branch refs/heads/trunk from Priya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5a144c0 ] Improved: Use GroovyBaseScript's makeValue utility methods in each Groovy files (OFBIZ-11779) Co-authored-by: Priya Sharma > Use GroovyBaseScript's makeValue utility methods in each Groovy files > - > > Key: OFBIZ-11779 > URL: https://issues.apache.org/jira/browse/OFBIZ-11779 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Use GroovyBaseScript's makeValue utility methods instead of using Delegator > in each Groovy files > Currently, we have both patterns in Groovy files, we should replace > delegator.makeValue(args) with makeValue(args) for consistency -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11830) Replace Collection.sort() with List.sort()
[
https://issues.apache.org/jira/browse/OFBIZ-11830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Verma closed OFBIZ-11830.
---
Fix Version/s: Upcoming Branch
Resolution: Implemented
> Replace Collection.sort() with List.sort()
> --
>
> Key: OFBIZ-11830
> URL: https://issues.apache.org/jira/browse/OFBIZ-11830
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11830-plugins.patch, OFBIZ-11830.patch
>
>
> Replace Collection.sort() with List.sort()
> {code:java}
> Collections.sort(billingAccountList, new BillingAccountComparator());{code}
> Replace with
> {code:java}
> billingAccountList.sort(new BillingAccountComparator());{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11830) Replace Collection.sort() with List.sort()
[
https://issues.apache.org/jira/browse/OFBIZ-11830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147078#comment-17147078
]
ASF subversion and git services commented on OFBIZ-11830:
-
Commit 8f14af21c56c58e1b1754bb8eaa28fe5cc5979d9 in ofbiz-plugins's branch
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=8f14af2 ]
Improved: Replace Collection.sort() with List.sort().(OFBIZ-11830)
> Replace Collection.sort() with List.sort()
> --
>
> Key: OFBIZ-11830
> URL: https://issues.apache.org/jira/browse/OFBIZ-11830
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11830-plugins.patch, OFBIZ-11830.patch
>
>
> Replace Collection.sort() with List.sort()
> {code:java}
> Collections.sort(billingAccountList, new BillingAccountComparator());{code}
> Replace with
> {code:java}
> billingAccountList.sort(new BillingAccountComparator());{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11830) Replace Collection.sort() with List.sort()
[
https://issues.apache.org/jira/browse/OFBIZ-11830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147077#comment-17147077
]
ASF subversion and git services commented on OFBIZ-11830:
-
Commit 3da16a182c09a859a680c5c8846867d2a351a510 in ofbiz-framework's branch
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3da16a1 ]
Improved: Replace Collection.sort() with List.sort().(OFBIZ-11830)
> Replace Collection.sort() with List.sort()
> --
>
> Key: OFBIZ-11830
> URL: https://issues.apache.org/jira/browse/OFBIZ-11830
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11830-plugins.patch, OFBIZ-11830.patch
>
>
> Replace Collection.sort() with List.sort()
> {code:java}
> Collections.sort(billingAccountList, new BillingAccountComparator());{code}
> Replace with
> {code:java}
> billingAccountList.sort(new BillingAccountComparator());{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11828) Replace explicit type argument with diamond operator
[
https://issues.apache.org/jira/browse/OFBIZ-11828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147072#comment-17147072
]
ASF subversion and git services commented on OFBIZ-11828:
-
Commit 2e415638b2d63f8caf56ef8d31a7eb9deb382e06 in ofbiz-plugins's branch
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=2e41563 ]
Improved: Replace explicit type argument with diamond operator(OFBIZ-11828)
Since Java 1.7, when defining generic types it is unnecessary to redefine those
types in the constructor when it is already done in the declared type.
> Replace explicit type argument with diamond operator
>
>
> Key: OFBIZ-11828
> URL: https://issues.apache.org/jira/browse/OFBIZ-11828
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11828-plugins.patch, OFBIZ-11828.patch
>
>
> Since Java 1.7, when defining generic types it is unnecessary to redefine
> those types in the constructor when it is already done in the declared type.
>
> {code:java}
> Map> map = new HashMap>();
> {code}
> Replace with
> {code:java}
> Map> map = new HashMap<>();
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11828) Replace explicit type argument with diamond operator
[
https://issues.apache.org/jira/browse/OFBIZ-11828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Verma closed OFBIZ-11828.
---
Fix Version/s: Upcoming Branch
Resolution: Implemented
> Replace explicit type argument with diamond operator
>
>
> Key: OFBIZ-11828
> URL: https://issues.apache.org/jira/browse/OFBIZ-11828
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11828-plugins.patch, OFBIZ-11828.patch
>
>
> Since Java 1.7, when defining generic types it is unnecessary to redefine
> those types in the constructor when it is already done in the declared type.
>
> {code:java}
> Map> map = new HashMap>();
> {code}
> Replace with
> {code:java}
> Map> map = new HashMap<>();
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11828) Replace explicit type argument with diamond operator
[
https://issues.apache.org/jira/browse/OFBIZ-11828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147070#comment-17147070
]
ASF subversion and git services commented on OFBIZ-11828:
-
Commit e19b12eae99c47c2e21f84c3bfb1c3775df4a8eb in ofbiz-framework's branch
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e19b12e ]
Improved: Replace explicit type argument with diamond operator(OFBIZ-11828)
Since Java 1.7, when defining generic types it is unnecessary to redefine those
types in the constructor when it is already done in the declared type.
> Replace explicit type argument with diamond operator
>
>
> Key: OFBIZ-11828
> URL: https://issues.apache.org/jira/browse/OFBIZ-11828
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-11828-plugins.patch, OFBIZ-11828.patch
>
>
> Since Java 1.7, when defining generic types it is unnecessary to redefine
> those types in the constructor when it is already done in the declared type.
>
> {code:java}
> Map> map = new HashMap>();
> {code}
> Replace with
> {code:java}
> Map> map = new HashMap<>();
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #14: Implemented: Added new inventory cycle count feature for warehouse.
sonarcloud[bot] commented on pull request #14: URL: https://github.com/apache/ofbiz-framework/pull/14#issuecomment-650572400 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #14: Implemented: Added new inventory cycle count feature for warehouse.
sonarcloud[bot] removed a comment on pull request #14: URL: https://github.com/apache/ofbiz-framework/pull/14#issuecomment-650558623 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-10174) With Rainbow theme, a scrollbar appears at bottom where it's not needed
[ https://issues.apache.org/jira/browse/OFBIZ-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146982#comment-17146982 ] Jacques Le Roux commented on OFBIZ-10174: - Thanks Nameet, my question remains so I did not close. But I can't assign to you (weird) > With Rainbow theme, a scrollbar appears at bottom where it's not needed > --- > > Key: OFBIZ-10174 > URL: https://issues.apache.org/jira/browse/OFBIZ-10174 > Project: OFBiz > Issue Type: Sub-task >Reporter: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10174.patch > > > With Rainbow theme, even in large screens, a scrollbar appears at bottom > where it's useless. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10174) With Rainbow theme, a scrollbar appears at bottom where it's not needed
[ https://issues.apache.org/jira/browse/OFBIZ-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10174: --- Assignee: (was: Jacques Le Roux) > With Rainbow theme, a scrollbar appears at bottom where it's not needed > --- > > Key: OFBIZ-10174 > URL: https://issues.apache.org/jira/browse/OFBIZ-10174 > Project: OFBiz > Issue Type: Sub-task >Reporter: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10174.patch > > > With Rainbow theme, even in large screens, a scrollbar appears at bottom > where it's useless. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10174) With Rainbow theme, a scrollbar appears at bottom where it's not needed
[ https://issues.apache.org/jira/browse/OFBIZ-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146981#comment-17146981 ] ASF subversion and git services commented on OFBIZ-10174: - Commit db4ee8f9e61c39a45bdbc0756c145851cfeb8ff1 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=db4ee8f ] Fixed: With Rainbow theme, a scrollbar appears at bottom where it's not needed (OFBIZ-10174) With Rainbow theme, even in large screens, a scrollbar appears at bottom where it's useless. The CSS which is adding a border-right on the application bar is adding extra 1px width causing this issue. Attached the patch to remove extra width for the same. Thanks: Nameet Jain for the patch > With Rainbow theme, a scrollbar appears at bottom where it's not needed > --- > > Key: OFBIZ-10174 > URL: https://issues.apache.org/jira/browse/OFBIZ-10174 > Project: OFBiz > Issue Type: Sub-task >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10174.patch > > > With Rainbow theme, even in large screens, a scrollbar appears at bottom > where it's useless. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10174) With Rainbow theme, a scrollbar appears at bottom where it's not needed
[ https://issues.apache.org/jira/browse/OFBIZ-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146980#comment-17146980 ] ASF subversion and git services commented on OFBIZ-10174: - Commit 8358c299e0d337f31b27ea6e6b448f06c46e7506 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8358c29 ] Fixed: With Rainbow theme, a scrollbar appears at bottom where it's not needed (OFBIZ-10174) With Rainbow theme, even in large screens, a scrollbar appears at bottom where it's useless. The CSS which is adding a border-right on the application bar is adding extra 1px width causing this issue. Attached the patch to remove extra width for the same. Thanks: Nameet Jain for the patch > With Rainbow theme, a scrollbar appears at bottom where it's not needed > --- > > Key: OFBIZ-10174 > URL: https://issues.apache.org/jira/browse/OFBIZ-10174 > Project: OFBiz > Issue Type: Sub-task >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10174.patch > > > With Rainbow theme, even in large screens, a scrollbar appears at bottom > where it's useless. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10174) With Rainbow theme, a scrollbar appears at bottom where it's not needed
[ https://issues.apache.org/jira/browse/OFBIZ-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146979#comment-17146979 ] ASF subversion and git services commented on OFBIZ-10174: - Commit 4a71a959a692371e3a3ac1fa78d5502a0707c8b3 in ofbiz-framework's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4a71a95 ] Fixed: With Rainbow theme, a scrollbar appears at bottom where it's not needed (OFBIZ-10174) With Rainbow theme, even in large screens, a scrollbar appears at bottom where it's useless. The CSS which is adding a border-right on the application bar is adding extra 1px width causing this issue. Attached the patch to remove extra width for the same. Changes made by hand > With Rainbow theme, a scrollbar appears at bottom where it's not needed > --- > > Key: OFBIZ-10174 > URL: https://issues.apache.org/jira/browse/OFBIZ-10174 > Project: OFBiz > Issue Type: Sub-task >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10174.patch > > > With Rainbow theme, even in large screens, a scrollbar appears at bottom > where it's useless. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9750) Add new CSS classes for aligning table data
[ https://issues.apache.org/jira/browse/OFBIZ-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146977#comment-17146977 ] Jacques Le Roux commented on OFBIZ-9750: Actually I'm not sure how to exactly test this. I compared https://demo-trunk.ofbiz.apache.org/webtools/control/entity/find/OrderHeader (no patch applied) and https://localhost:8443/webtools/control/entity/find/OrderHeader (patch applied) and I don't see any difference for, for instance, demo1002 What could I miss? Where to test for differences? TIA > Add new CSS classes for aligning table data > --- > > Key: OFBIZ-9750 > URL: https://issues.apache.org/jira/browse/OFBIZ-9750 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mayank Lambhate >Assignee: Nitish Mishra >Priority: Minor > Attachments: OFBIZ-9750.patch > > > The tables used in OFBiz currently don`t have any standard for defining the > alignment of data inside the tables. > Defining following classes to align table data according to the context. > 1. numeric (for numeric data) > 2. currency-amount (for amount fields) > We have selected the names of classes as per OFBiz defined field types in > fieldtype*.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11845) Getting error while generating ApprovedProductRequirementsReport PDF
[ https://issues.apache.org/jira/browse/OFBIZ-11845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chandan Khandelwal updated OFBIZ-11845: --- Attachment: Screenshot from 2020-06-27 19-27-18.png > Getting error while generating ApprovedProductRequirementsReport PDF > > > Key: OFBIZ-11845 > URL: https://issues.apache.org/jira/browse/OFBIZ-11845 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Chandan Khandelwal >Assignee: Chandan Khandelwal >Priority: Major > Attachments: Screenshot from 2020-06-27 19-27-18.png > > > Reference URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/ApprovedProductRequirementsReport] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11845) Getting error while generating ApprovedProductRequirementsReport PDF
Chandan Khandelwal created OFBIZ-11845: -- Summary: Getting error while generating ApprovedProductRequirementsReport PDF Key: OFBIZ-11845 URL: https://issues.apache.org/jira/browse/OFBIZ-11845 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Chandan Khandelwal Assignee: Chandan Khandelwal Reference URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/ApprovedProductRequirementsReport] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10577) New Feature: Inventory Cycle Count
[ https://issues.apache.org/jira/browse/OFBIZ-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146954#comment-17146954 ] Yashwant Dhakad commented on OFBIZ-10577: - Hi [~pawan], I have done all the suggested changes. I see that the checkbox issue is at the framework level It also broken on other screens as well so you can create a new ticket for that. Apart from I agree with you for the status history improvement and we need to add one more entity for status history so can you create a new ticket for this as well? And I will take care of them in a new ticket. > New Feature: Inventory Cycle Count > -- > > Key: OFBIZ-10577 > URL: https://issues.apache.org/jira/browse/OFBIZ-10577 > Project: OFBiz > Issue Type: New Feature > Components: hhfacility, product >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Yashwant Dhakad >Priority: Major > Labels: audit, inventory > Attachments: Checkbox Issue.png, FindSessionIssue.png, > InventoryItemLookup.png, ItemSubSeqId.png, Menu Error.png, Menu Error.png, > OFBIZ-10577-Database-Changes.patch, OFBIZ-10577.patch, Ui Issue.png, Ui > Issue.png, screenshot-1-find-session.png, screenshot-2-pending-locations.png, > screenshot-3-add-location-to-session.png, > screenshot-4-list-of-review-session.png, > screenshot-5-review-session-detail.png, screenshot-6-accept-session.png, > screenshot-7-complete-review.png, screenshot-8-report-screen.png > > > *Here are the design notes for cycle count workflow:* > *Find Session Screen:* In this screen, we will show all the sessions created > in the system with respect to the facility, locations, inventory count item, > current status, and created date. We have a search field to filter the > records on the basis of the facility, status. > *Find Pending Locations:* In this screen, we have a table listing all the > pending locations whose countings are pending and we can create a session for > them. All details regarding the pending locations are listed here with the > location, next count date, last count date and days extended for the count, > total inventory item and product for this location. We have facets for > filtering the records on the basis of the facility, not scanned since and > scheduled for next scan. Also, we have a global search at the top of the > screen. In Pending Locations screen, we have a Create Session button. To > create a session we can either select one or more records from the below list > or create a new session by yourself. > In Create Session screen, the basic overview is shown in the "Overview" > section and the items are listed in the "Items" section. We can create a new > line item by clicking on the 'Add' button and we can also update the item > quantity. After completing this, we can proceed with this session and mark it > with 'Pending for Review' status from the 'Status' button at the top of the > screen or we can simply 'Reject'. 'Reject' status button is available at the > top of the screen. > *Find Review Screen:* In this screen, we have a table listing all the > locations pending for the review. All the details regarding the review > sessions are listed with the facility, locations and counted inventory item. > We have facets for filtering records on the basis of the facility. By > clicking any session we can go to its detail screen, where basic details > regarding this session are listed in the 'Overview' section and items are > listed in the 'Items' section. We can select any number of rows and mark them > as 'Accept' or 'Reject'. When these items are marked as 'Accepted' then the > variance is created and these are added in the Count Progress report. Only > authorized persons can accept or reject the sessions and once the session is > accepted it is marked as 'Completed'. > *Count Progress Report:* In this screen, User can view the advanced counting > related analytics with respect to all the 'Completed' status session from > Reports Screen. We can filter the records on the basis of the facility and > within the date range. We can also see the percentage of the total locations, > inventory items counted and errors occurred during the process. Item variance > details are listed in the below section in tabular form. > Following changes to the existing data model to support end to end counting > process flow: > *New entities:* > *InventoryCount* > inventoryCountId > uploadedByUserLogin > facilityId > statusId > createdDatetime > *InventoryCountItem* > inventoryCountId > inventoryCountItemSeqId > inventoryItemId > itemStatusId > locationSeqId > productId > productIdentifier > quantity > *InventoryCountVariance* > inventoryCountId > inventoryCountItemSeqId >
[jira] [Commented] (OFBIZ-11489) Convert cancelPaymentBatch service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146951#comment-17146951 ] Kirti Arora commented on OFBIZ-11489: - Hello [~pawan], Thanks for reviewing the patch. I have corrected the patch and uploaded it. Please have a look. Thanks! > Convert cancelPaymentBatch service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11489 > URL: https://issues.apache.org/jira/browse/OFBIZ-11489 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Kirti Arora >Priority: Minor > Attachments: OFBIZ-11489.patch, OFBIZ-11489.patch, OFBIZ-11489.patch > > > Convert the cancelPaymentBatch service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11489) Convert cancelPaymentBatch service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirti Arora updated OFBIZ-11489: Attachment: OFBIZ-11489.patch > Convert cancelPaymentBatch service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11489 > URL: https://issues.apache.org/jira/browse/OFBIZ-11489 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Kirti Arora >Priority: Minor > Attachments: OFBIZ-11489.patch, OFBIZ-11489.patch, OFBIZ-11489.patch > > > Convert the cancelPaymentBatch service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] yashwantdhakad opened a new pull request #212: Upgrade the fork repository with framework trunk repository.
yashwantdhakad opened a new pull request #212: URL: https://github.com/apache/ofbiz-framework/pull/212 Fixed: (OFBIZ-10577) Merge the trunk branch into fork repository to resolve the conflicts. Thanks: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11843) Accept return process throwing missing method exception
[ https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146946#comment-17146946 ] ASF subversion and git services commented on OFBIZ-11843: - Commit a7fa31c403256af5386942658a3720bbfdfad72c in ofbiz-framework's branch refs/heads/trunk from pritambkute [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a7fa31c ] Fixed the issues in accept return process. (OFBIZ-11843) (#211) Co-authored-by: Pritam Kute > Accept return process throwing missing method exception > --- > > Key: OFBIZ-11843 > URL: https://issues.apache.org/jira/browse/OFBIZ-11843 > Project: OFBiz > Issue Type: Bug >Reporter: Pritam Kute >Assignee: Pawan Verma >Priority: Major > Fix For: Trunk > > > Steps to regenerate: > 1. Open any return in requested status > 2. Go to 'Return Items' menu > 3. Click on the 'Accept Return' button. > Expected Result: > The return should be marked as accepted in the system. > Actual: > Error screen with error log as: > org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error > (groovy.lang.MissingMethodException: No signature of method: static > java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) > values: [0.01] Possible solutions: minus(java.lang.Character), > minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find()) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11843) Accept return process throwing missing method exception
[ https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11843. --- Fix Version/s: (was: Trunk) Upcoming Branch Resolution: Fixed Thanks, [~pritam.kute] for the contribution. > Accept return process throwing missing method exception > --- > > Key: OFBIZ-11843 > URL: https://issues.apache.org/jira/browse/OFBIZ-11843 > Project: OFBiz > Issue Type: Bug >Reporter: Pritam Kute >Assignee: Pawan Verma >Priority: Major > Fix For: Upcoming Branch > > > Steps to regenerate: > 1. Open any return in requested status > 2. Go to 'Return Items' menu > 3. Click on the 'Accept Return' button. > Expected Result: > The return should be marked as accepted in the system. > Actual: > Error screen with error log as: > org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error > (groovy.lang.MissingMethodException: No signature of method: static > java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) > values: [0.01] Possible solutions: minus(java.lang.Character), > minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find()) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11843) Accept return process throwing missing method exception
[ https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11843: Affects Version/s: Trunk > Accept return process throwing missing method exception > --- > > Key: OFBIZ-11843 > URL: https://issues.apache.org/jira/browse/OFBIZ-11843 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pawan Verma >Priority: Major > Fix For: Upcoming Branch > > > Steps to regenerate: > 1. Open any return in requested status > 2. Go to 'Return Items' menu > 3. Click on the 'Accept Return' button. > Expected Result: > The return should be marked as accepted in the system. > Actual: > Error screen with error log as: > org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error > (groovy.lang.MissingMethodException: No signature of method: static > java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) > values: [0.01] Possible solutions: minus(java.lang.Character), > minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find()) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #14: Implemented: Added new inventory cycle count feature for warehouse.
sonarcloud[bot] removed a comment on pull request #14: URL: https://github.com/apache/ofbiz-framework/pull/14#issuecomment-650557940 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #14: Implemented: Added new inventory cycle count feature for warehouse.
sonarcloud[bot] commented on pull request #14: URL: https://github.com/apache/ofbiz-framework/pull/14#issuecomment-650558623 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] verma-pawan merged pull request #211: Fixed the issues in accept return process. (OFBIZ-11843)
verma-pawan merged pull request #211: URL: https://github.com/apache/ofbiz-framework/pull/211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-11500) Convert createMatchingPaymentApplication service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-11500: - Assignee: Rohit Koushal (was: Devanshu Vyas) > Convert createMatchingPaymentApplication service from mini-lang to groovy DSL > - > > Key: OFBIZ-11500 > URL: https://issues.apache.org/jira/browse/OFBIZ-11500 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > > Convert the createMatchingPaymentApplication service code from mini-lang to > groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #14: Implemented: Added new inventory cycle count feature for warehouse.
sonarcloud[bot] removed a comment on pull request #14: URL: https://github.com/apache/ofbiz-framework/pull/14#issuecomment-650504353 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=14=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-11554) Convert testInvoicePerShipmentSetTrue test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11554. --- Fix Version/s: Upcoming Branch Resolution: Implemented This has been handled in PR: [https://github.com/apache/ofbiz-framework/pull/208] Thanks, [~priya.sharma.9362]! > Convert testInvoicePerShipmentSetTrue test from XML to Groovy > - > > Key: OFBIZ-11554 > URL: https://issues.apache.org/jira/browse/OFBIZ-11554 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > > Convert testInvoicePerShipmentSetTrue test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11555) Convert testInvoicePerShipmentSetOrderFalse test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11555. --- Fix Version/s: Upcoming Branch Resolution: Implemented This has been handled in PR: [https://github.com/apache/ofbiz-framework/pull/208] Thanks, [~priya.sharma.9362]! > Convert testInvoicePerShipmentSetOrderFalse test from XML to Groovy > --- > > Key: OFBIZ-11555 > URL: https://issues.apache.org/jira/browse/OFBIZ-11555 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > > Convert testInvoicePerShipmentSetOrderFalse test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11555) Convert testInvoicePerShipmentSetOrderFalse test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11555: --- Assignee: Pawan Verma (was: Akash Jain) > Convert testInvoicePerShipmentSetOrderFalse test from XML to Groovy > --- > > Key: OFBIZ-11555 > URL: https://issues.apache.org/jira/browse/OFBIZ-11555 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Pawan Verma >Priority: Minor > > Convert testInvoicePerShipmentSetOrderFalse test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11554) Convert testInvoicePerShipmentSetTrue test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11554: --- Assignee: Pawan Verma (was: Priya Sharma) > Convert testInvoicePerShipmentSetTrue test from XML to Groovy > - > > Key: OFBIZ-11554 > URL: https://issues.apache.org/jira/browse/OFBIZ-11554 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Pawan Verma >Priority: Minor > > Convert testInvoicePerShipmentSetTrue test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11844) Unable to upload additional image for a product
Arpit Mor created OFBIZ-11844: - Summary: Unable to upload additional image for a product Key: OFBIZ-11844 URL: https://issues.apache.org/jira/browse/OFBIZ-11844 Project: OFBiz Issue Type: Bug Components: product/catalog Affects Versions: Trunk Reporter: Arpit Mor Attachments: Image1.png Steps to regenerate: 1. Navigate to URL: [https://demo-trunk.ofbiz.apache.org/catalog/control/FindProduct] 2. Click on find button 3. Click on any product Id 4. Click on content tab 5. Near bottom of page, click on choose file button for additional images 6. Select image to be uploaded 7. Click on upload image button Actual: Following error message is displayed, “The Following Errors Occurred: Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error (org.apache.ofbiz.service.GenericServiceException: Service [addAdditionalViewForProduct] target threw an unexpected exception (null))”. Please refer attachment: Image1 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11556) Convert testInvoicePerShipmentSetOrderTrue test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11556: --- Assignee: Pawan Verma (was: Akash Jain) > Convert testInvoicePerShipmentSetOrderTrue test from XML to Groovy > -- > > Key: OFBIZ-11556 > URL: https://issues.apache.org/jira/browse/OFBIZ-11556 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Pawan Verma >Priority: Minor > > Convert testInvoicePerShipmentSetOrderTrue test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11553. --- Fix Version/s: Upcoming Branch Assignee: Pawan Verma (was: Priya Sharma) Resolution: Implemented Thanks [~priya.sharma.9362] and [~jleroux] > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146933#comment-17146933 ] ASF subversion and git services commented on OFBIZ-11553: - Commit 0f9307c0711fff7b8aef5c795918c21b0b9243d8 in ofbiz-framework's branch refs/heads/trunk from Priya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0f9307c ] Improved: Convert InvoicePerShipmentTests.xml tests to groovy (OFBIZ-11553) (#208) * Improved: Convert InvoicePerShipmentTests.xml tests to groovy (OFBIZ-11553) Done following: - converted all xml test implementation to groovy - used MockHttpServletRequest MockHttpServletResponse objects for triggering the events - removed the xml version of the test implementations - updated the test service mapping in the invoicetests.xml (OFBIZ-11553) * Improved: Moved the common code into a method so as to avoid duplication of code. - passed in two parameters i.e. product id and the invoicePerShipment flag, to be used as per the need of the testcase. (OFBIz-11553) * Improved: Added support to get access to the Debug log methods in the groovy tests. (OFBIZ-11553) - Also updated the references in the InvoicePerShipment tests. Co-authored-by: Priya Sharma > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146935#comment-17146935 ] ASF subversion and git services commented on OFBIZ-11553: - Commit 0f9307c0711fff7b8aef5c795918c21b0b9243d8 in ofbiz-framework's branch refs/heads/trunk from Priya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0f9307c ] Improved: Convert InvoicePerShipmentTests.xml tests to groovy (OFBIZ-11553) (#208) * Improved: Convert InvoicePerShipmentTests.xml tests to groovy (OFBIZ-11553) Done following: - converted all xml test implementation to groovy - used MockHttpServletRequest MockHttpServletResponse objects for triggering the events - removed the xml version of the test implementations - updated the test service mapping in the invoicetests.xml (OFBIZ-11553) * Improved: Moved the common code into a method so as to avoid duplication of code. - passed in two parameters i.e. product id and the invoicePerShipment flag, to be used as per the need of the testcase. (OFBIz-11553) * Improved: Added support to get access to the Debug log methods in the groovy tests. (OFBIZ-11553) - Also updated the references in the InvoicePerShipment tests. Co-authored-by: Priya Sharma > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] verma-pawan merged pull request #208: Improved: Convert InvoicePerShipmentTests.xml tests to groovy (OFBIZ-11553)
verma-pawan merged pull request #208: URL: https://github.com/apache/ofbiz-framework/pull/208 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146934#comment-17146934 ] ASF subversion and git services commented on OFBIZ-11553: - Commit 0f9307c0711fff7b8aef5c795918c21b0b9243d8 in ofbiz-framework's branch refs/heads/trunk from Priya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0f9307c ] Improved: Convert InvoicePerShipmentTests.xml tests to groovy (OFBIZ-11553) (#208) * Improved: Convert InvoicePerShipmentTests.xml tests to groovy (OFBIZ-11553) Done following: - converted all xml test implementation to groovy - used MockHttpServletRequest MockHttpServletResponse objects for triggering the events - removed the xml version of the test implementations - updated the test service mapping in the invoicetests.xml (OFBIZ-11553) * Improved: Moved the common code into a method so as to avoid duplication of code. - passed in two parameters i.e. product id and the invoicePerShipment flag, to be used as per the need of the testcase. (OFBIz-11553) * Improved: Added support to get access to the Debug log methods in the groovy tests. (OFBIZ-11553) - Also updated the references in the InvoicePerShipment tests. Co-authored-by: Priya Sharma > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146932#comment-17146932 ] ASF subversion and git services commented on OFBIZ-11553: - Commit 0f9307c0711fff7b8aef5c795918c21b0b9243d8 in ofbiz-framework's branch refs/heads/trunk from Priya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0f9307c ] Improved: Convert InvoicePerShipmentTests.xml tests to groovy (OFBIZ-11553) (#208) * Improved: Convert InvoicePerShipmentTests.xml tests to groovy (OFBIZ-11553) Done following: - converted all xml test implementation to groovy - used MockHttpServletRequest MockHttpServletResponse objects for triggering the events - removed the xml version of the test implementations - updated the test service mapping in the invoicetests.xml (OFBIZ-11553) * Improved: Moved the common code into a method so as to avoid duplication of code. - passed in two parameters i.e. product id and the invoicePerShipment flag, to be used as per the need of the testcase. (OFBIz-11553) * Improved: Added support to get access to the Debug log methods in the groovy tests. (OFBIZ-11553) - Also updated the references in the InvoicePerShipment tests. Co-authored-by: Priya Sharma > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10174) With Rainbow theme, a scrollbar appears at bottom where it's not needed
[
https://issues.apache.org/jira/browse/OFBIZ-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146931#comment-17146931
]
Jacques Le Roux commented on OFBIZ-10174:
-
Thanks Nameet,
Should we not remove it from there too?
{code}
#app-navigation ul li ul li:last-child {
border-right: solid 1px @black;
}
{code}
> With Rainbow theme, a scrollbar appears at bottom where it's not needed
> ---
>
> Key: OFBIZ-10174
> URL: https://issues.apache.org/jira/browse/OFBIZ-10174
> Project: OFBiz
> Issue Type: Sub-task
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-10174.patch
>
>
> With Rainbow theme, even in large screens, a scrollbar appears at bottom
> where it's useless.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10426) When creating blog or forums, it failed to save
[
https://issues.apache.org/jira/browse/OFBIZ-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146923#comment-17146923
]
Aman Mishra commented on OFBIZ-10426:
-
Hello [~nk_smallbee],
Verified the reported issue/behaviour over OFBiz trunk instance and performed
the steps mentioned over the attached [blog-error.png].
Confirmed that functionality worked fine and could able to create blogs &
articles successfully without any error. Please refer:
!OFBIZ-10426-Working.png!
Thanks!
> When creating blog or forums, it failed to save
> ---
>
> Key: OFBIZ-10426
> URL: https://issues.apache.org/jira/browse/OFBIZ-10426
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jason Hao
>Assignee: Aman Mishra
>Priority: Major
> Attachments: OFBIZ-10426-Working.png, blog-error.png
>
>
> Create a blog or forum and click save button, it will popup with error
> message. The reason is because the mapKey passed from front end cannot be
> handled by the service. The solution is not to pass the mapKey to the service.
> Steps:
> 1) navigate to
> [https://demo-trunk.ofbiz.apache.org/content/control/blogContent?blogContentId=BLOGROOTBIGAL|http://example.com]
> 2) create a new article
> [https://demo-trunk.ofbiz.apache.org/content/control/EditBlogArticle?blogContentId=BLOGROOTBIGAL|http://example.com/]
>
> ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/explorer/Documents/ofbiz/ofbiz-framework/applications/content/minilang/content/ContentServices.xml#createArticleContent|file:///Users/explorer/Documents/ofbiz/ofbiz-framework/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [createText] containing
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2018-06-01
> 21:38:24.088(java.sql.Timestamp)][createdTxStamp,2018-06-01
> 21:38:24.086(java.sql.Timestamp)][currentPassword,
> {SHA}
> 47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][externalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Shanghai(java.lang.String)][lastUpdatedStamp,2018-06-02
> 03:00:52.632(java.sql.Timestamp)][lastUpdatedTxStamp,2018-06-02
> 03:00:52.632(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,0(java.lang.Long)][userLdapDn,null()][userLoginId,admin(java.lang.String)],
> textData=hello, dataTemplateTypeId=NONE, mapKey=MAIN, contentIdFrom=ASK,
> description=hello, partyId=admin, locale=en_US,
> dataResourceTypeId=ELECTRONIC_TEXT, contentName=hell world}]: Unknown
> parameter found: [createTextContent.contentIdFrom]Unknown parameter found:
> [createTextContent.mapKey]]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10174) With Rainbow theme, a scrollbar appears at bottom where it's not needed
[ https://issues.apache.org/jira/browse/OFBIZ-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-10174: --- Assignee: Jacques Le Roux > With Rainbow theme, a scrollbar appears at bottom where it's not needed > --- > > Key: OFBIZ-10174 > URL: https://issues.apache.org/jira/browse/OFBIZ-10174 > Project: OFBiz > Issue Type: Sub-task >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10174.patch > > > With Rainbow theme, even in large screens, a scrollbar appears at bottom > where it's useless. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10426) When creating blog or forums, it failed to save
[
https://issues.apache.org/jira/browse/OFBIZ-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aman Mishra updated OFBIZ-10426:
Attachment: OFBIZ-10426-Working.png
> When creating blog or forums, it failed to save
> ---
>
> Key: OFBIZ-10426
> URL: https://issues.apache.org/jira/browse/OFBIZ-10426
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jason Hao
>Assignee: Aman Mishra
>Priority: Major
> Attachments: OFBIZ-10426-Working.png, blog-error.png
>
>
> Create a blog or forum and click save button, it will popup with error
> message. The reason is because the mapKey passed from front end cannot be
> handled by the service. The solution is not to pass the mapKey to the service.
> Steps:
> 1) navigate to
> [https://demo-trunk.ofbiz.apache.org/content/control/blogContent?blogContentId=BLOGROOTBIGAL|http://example.com]
> 2) create a new article
> [https://demo-trunk.ofbiz.apache.org/content/control/EditBlogArticle?blogContentId=BLOGROOTBIGAL|http://example.com/]
>
> ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/explorer/Documents/ofbiz/ofbiz-framework/applications/content/minilang/content/ContentServices.xml#createArticleContent|file:///Users/explorer/Documents/ofbiz/ofbiz-framework/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [createText] containing
> [{userLogin=[GenericEntity:UserLogin][createdStamp,2018-06-01
> 21:38:24.088(java.sql.Timestamp)][createdTxStamp,2018-06-01
> 21:38:24.086(java.sql.Timestamp)][currentPassword,
> {SHA}
> 47b56994cbc2b6d10aa1be30f70165adb305a41a(java.lang.String)][disabledBy,null()][disabledDateTime,null()][enabled,Y(java.lang.String)][externalAuthId,null()][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastTimeZone,Asia/Shanghai(java.lang.String)][lastUpdatedStamp,2018-06-02
> 03:00:52.632(java.sql.Timestamp)][lastUpdatedTxStamp,2018-06-02
> 03:00:52.632(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][requirePasswordChange,null()][successiveFailedLogins,0(java.lang.Long)][userLdapDn,null()][userLoginId,admin(java.lang.String)],
> textData=hello, dataTemplateTypeId=NONE, mapKey=MAIN, contentIdFrom=ASK,
> description=hello, partyId=admin, locale=en_US,
> dataResourceTypeId=ELECTRONIC_TEXT, contentName=hell world}]: Unknown
> parameter found: [createTextContent.contentIdFrom]Unknown parameter found:
> [createTextContent.mapKey]]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #211: Fixed the issues in accept return process. (OFBIZ-11843)
sonarcloud[bot] commented on pull request #211: URL: https://github.com/apache/ofbiz-framework/pull/211#issuecomment-650551811 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=211=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=211=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=211=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=211=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=211=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=211=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=211=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=211=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=211=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=211=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=211=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=211) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=211=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11843) Accept return process throwing missing method exception
[ https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146916#comment-17146916 ] Pritam Kute commented on OFBIZ-11843: - Create the PR at https://github.com/apache/ofbiz-framework/pull/211 Let me know if we are going to fix the typecasting issue in a single commit. I will update the patch accordingly. > Accept return process throwing missing method exception > --- > > Key: OFBIZ-11843 > URL: https://issues.apache.org/jira/browse/OFBIZ-11843 > Project: OFBiz > Issue Type: Bug >Reporter: Pritam Kute >Assignee: Pritam Kute >Priority: Major > Fix For: Trunk > > > Steps to regenerate: > 1. Open any return in requested status > 2. Go to 'Return Items' menu > 3. Click on the 'Accept Return' button. > Expected Result: > The return should be marked as accepted in the system. > Actual: > Error screen with error log as: > org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error > (groovy.lang.MissingMethodException: No signature of method: static > java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) > values: [0.01] Possible solutions: minus(java.lang.Character), > minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find()) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] pritambkute opened a new pull request #211: Fixed the issues in accept return process. (OFBIZ-11843)
pritambkute opened a new pull request #211: URL: https://github.com/apache/ofbiz-framework/pull/211 Fixed: Accept return process throwing missing method exception (OFBIZ-11843) Explanation: This issue was due to wrong coding pattern used for groovy typecasting and map initialization. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11843) Accept return process throwing missing method exception
[
https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146911#comment-17146911
]
Pritam Kute commented on OFBIZ-11843:
-
I have observed that for typecasting in groovy, we have used the wrong coding
pattern like
{code:java}
(BigDecimal) -0.01
{code}
It should be like
{code:java}
-0.01 as BigDecimal
{code}
Making these changes fixes this issue. Let me know if I am missing anything
here.
I also found one more issue at OrderReturnServices.groovy:302
Here the 'ctx' map is initialized directly with the GenericValue
'returnAdjustment'. This is throwing error as the ctx is not getting built up
properly. We can fix it using following code snippet.
{code:java}
Map ctx = [:]
ctx << returnAdjustment
ctx.originalReturnPrice = originalReturnPrice
{code}
> Accept return process throwing missing method exception
> ---
>
> Key: OFBIZ-11843
> URL: https://issues.apache.org/jira/browse/OFBIZ-11843
> Project: OFBiz
> Issue Type: Bug
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Major
> Fix For: Trunk
>
>
> Steps to regenerate:
> 1. Open any return in requested status
> 2. Go to 'Return Items' menu
> 3. Click on the 'Accept Return' button.
> Expected Result:
> The return should be marked as accepted in the system.
> Actual:
> Error screen with error log as:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error
> (groovy.lang.MissingMethodException: No signature of method: static
> java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal)
> values: [0.01] Possible solutions: minus(java.lang.Character),
> minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find())
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11843) Accept return process throwing missing method exception
[ https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pritam Kute reassigned OFBIZ-11843: --- Assignee: Pritam Kute > Accept return process throwing missing method exception > --- > > Key: OFBIZ-11843 > URL: https://issues.apache.org/jira/browse/OFBIZ-11843 > Project: OFBiz > Issue Type: Bug >Reporter: Pritam Kute >Assignee: Pritam Kute >Priority: Major > Fix For: Trunk > > > Steps to regenerate: > 1. Open any return in requested status > 2. Go to 'Return Items' menu > 3. Click on the 'Accept Return' button. > Expected Result: > The return should be marked as accepted in the system. > Actual: > Error screen with error log as: > org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error > (groovy.lang.MissingMethodException: No signature of method: static > java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) > values: [0.01] Possible solutions: minus(java.lang.Character), > minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find()) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11112) Error message not properly displayed while adding postal address
[ https://issues.apache.org/jira/browse/OFBIZ-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146893#comment-17146893 ] Shubham Choudhary edited comment on OFBIZ-2 at 6/27/20, 11:33 AM: -- I verified the steps shared here. For messages notification, we have "Show All" link expending the hidden text. Assigning this ticket back to Rashi Dhakad. was (Author: shubham.choudhary): I verified the steps shared here. For messages notification, we have "Show All" link expending the hidden text. > Error message not properly displayed while adding postal address > > > Key: OFBIZ-2 > URL: https://issues.apache.org/jira/browse/OFBIZ-2 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Rashi Dhagat >Priority: Minor > Attachments: PostalAddressError.png, PostalAddressErrorTest.png > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select postal address as contact type > # Click on Create > # Click on Save > Actual: Error message is not properly visible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11112) Error message not properly displayed while adding postal address
[ https://issues.apache.org/jira/browse/OFBIZ-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146893#comment-17146893 ] Shubham Choudhary edited comment on OFBIZ-2 at 6/27/20, 11:33 AM: -- I verified the steps shared here. For messages notification, we have "Show All" link expending the hidden text. Assigning this ticket back to Rashi Dhagat. was (Author: shubham.choudhary): I verified the steps shared here. For messages notification, we have "Show All" link expending the hidden text. Assigning this ticket back to Rashi Dhakad. > Error message not properly displayed while adding postal address > > > Key: OFBIZ-2 > URL: https://issues.apache.org/jira/browse/OFBIZ-2 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Rashi Dhagat >Priority: Minor > Attachments: PostalAddressError.png, PostalAddressErrorTest.png > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select postal address as contact type > # Click on Create > # Click on Save > Actual: Error message is not properly visible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11112) Error message not properly displayed while adding postal address
[ https://issues.apache.org/jira/browse/OFBIZ-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shubham Choudhary reassigned OFBIZ-2: - Assignee: Rashi Dhagat (was: Shubham Choudhary) > Error message not properly displayed while adding postal address > > > Key: OFBIZ-2 > URL: https://issues.apache.org/jira/browse/OFBIZ-2 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Rashi Dhagat >Priority: Minor > Attachments: PostalAddressError.png, PostalAddressErrorTest.png > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select postal address as contact type > # Click on Create > # Click on Save > Actual: Error message is not properly visible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #210: Fixed: New Employment' widget(s) allows party-groups to be selects as the employee. (OFBIZ-11697)
sonarcloud[bot] commented on pull request #210: URL: https://github.com/apache/ofbiz-framework/pull/210#issuecomment-650546661 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=210=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=210=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=210=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=210=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=210=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=210=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=210=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=210=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=210=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=210=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=210=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=210) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=210=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=210=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11697) 'New Employment' widget(s) allows party-groups to be selects as the employee
[ https://issues.apache.org/jira/browse/OFBIZ-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146897#comment-17146897 ] Ravi Lodhi commented on OFBIZ-11697: Added employee lookup to address this issue. Here is the PR for the same- [https://github.com/apache/ofbiz-framework/pull/210] > 'New Employment' widget(s) allows party-groups to be selects as the employee > > > Key: OFBIZ-11697 > URL: https://issues.apache.org/jira/browse/OFBIZ-11697 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 17.12.03, Trunk >Reporter: Pierre Smits >Priority: Major > Labels: employment > Attachments: image-2020-05-13-13-21-57-713.png > > > See image. This should only be possible for parties with partytypeId="PERSON" > and roleTypeID="EMPLOYEE" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] lodhiravi opened a new pull request #210: Fixed: New Employment' widget(s) allows party-groups to be selects as the employee. (OFBIZ-11697)
lodhiravi opened a new pull request #210: URL: https://github.com/apache/ofbiz-framework/pull/210 Done following- 1. Added employee lookup to search for employees only. 2. Used the newly added employee lookup on the New Employment screen to avoid selection of party group as an employee while create new employment. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-10174) With Rainbow theme, a scrollbar appears at bottom where it's not needed
[ https://issues.apache.org/jira/browse/OFBIZ-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146895#comment-17146895 ] Nameet Jain commented on OFBIZ-10174: - [~jleroux] the CSS which is adding a border-right on the application bar is adding extra 1px width causing this issue. Attached the patch to remove extra width for the same. Thanks > With Rainbow theme, a scrollbar appears at bottom where it's not needed > --- > > Key: OFBIZ-10174 > URL: https://issues.apache.org/jira/browse/OFBIZ-10174 > Project: OFBiz > Issue Type: Sub-task >Reporter: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10174.patch > > > With Rainbow theme, even in large screens, a scrollbar appears at bottom > where it's useless. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11112) Error message not properly displayed while adding postal address
[ https://issues.apache.org/jira/browse/OFBIZ-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shubham Choudhary updated OFBIZ-2: -- Attachment: PostalAddressErrorTest.png > Error message not properly displayed while adding postal address > > > Key: OFBIZ-2 > URL: https://issues.apache.org/jira/browse/OFBIZ-2 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Shubham Choudhary >Priority: Minor > Attachments: PostalAddressError.png, PostalAddressErrorTest.png > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select postal address as contact type > # Click on Create > # Click on Save > Actual: Error message is not properly visible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (OFBIZ-11112) Error message not properly displayed while adding postal address
[ https://issues.apache.org/jira/browse/OFBIZ-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shubham Choudhary updated OFBIZ-2: -- Comment: was deleted (was: !PostalAddressErrorTest.png!) > Error message not properly displayed while adding postal address > > > Key: OFBIZ-2 > URL: https://issues.apache.org/jira/browse/OFBIZ-2 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Shubham Choudhary >Priority: Minor > Attachments: PostalAddressError.png, PostalAddressErrorTest.png > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select postal address as contact type > # Click on Create > # Click on Save > Actual: Error message is not properly visible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11112) Error message not properly displayed while adding postal address
[ https://issues.apache.org/jira/browse/OFBIZ-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146894#comment-17146894 ] Shubham Choudhary commented on OFBIZ-2: --- !PostalAddressErrorTest.png! > Error message not properly displayed while adding postal address > > > Key: OFBIZ-2 > URL: https://issues.apache.org/jira/browse/OFBIZ-2 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Shubham Choudhary >Priority: Minor > Attachments: PostalAddressError.png, PostalAddressErrorTest.png > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select postal address as contact type > # Click on Create > # Click on Save > Actual: Error message is not properly visible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11112) Error message not properly displayed while adding postal address
[ https://issues.apache.org/jira/browse/OFBIZ-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146893#comment-17146893 ] Shubham Choudhary commented on OFBIZ-2: --- I verified the steps shared here. For messages notification, we have "Show All" link expending the hidden text. > Error message not properly displayed while adding postal address > > > Key: OFBIZ-2 > URL: https://issues.apache.org/jira/browse/OFBIZ-2 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Shubham Choudhary >Priority: Minor > Attachments: PostalAddressError.png > > > Steps to regenerate: > # Open url > [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile] > # Click on "Create new" in Contact Information section > # Select postal address as contact type > # Click on Create > # Click on Save > Actual: Error message is not properly visible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9750) Add new CSS classes for aligning table data
[ https://issues.apache.org/jira/browse/OFBIZ-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146892#comment-17146892 ] Jacques Le Roux commented on OFBIZ-9750: Thanks Nitish, Sounds good to me, I'll commit soon, after testing... > Add new CSS classes for aligning table data > --- > > Key: OFBIZ-9750 > URL: https://issues.apache.org/jira/browse/OFBIZ-9750 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mayank Lambhate >Assignee: Nitish Mishra >Priority: Minor > Attachments: OFBIZ-9750.patch > > > The tables used in OFBiz currently don`t have any standard for defining the > alignment of data inside the tables. > Defining following classes to align table data according to the context. > 1. numeric (for numeric data) > 2. currency-amount (for amount fields) > We have selected the names of classes as per OFBiz defined field types in > fieldtype*.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10174) With Rainbow theme, a scrollbar appears at bottom where it's not needed
[ https://issues.apache.org/jira/browse/OFBIZ-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nameet Jain updated OFBIZ-10174: Attachment: OFBIZ-10174.patch > With Rainbow theme, a scrollbar appears at bottom where it's not needed > --- > > Key: OFBIZ-10174 > URL: https://issues.apache.org/jira/browse/OFBIZ-10174 > Project: OFBiz > Issue Type: Sub-task >Reporter: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-10174.patch > > > With Rainbow theme, even in large screens, a scrollbar appears at bottom > where it's useless. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #117: Improved: Update Data Sets (OFBIZ-6976)
PierreSmits commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-650543620 I do. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-9750) Add new CSS classes for aligning table data
[ https://issues.apache.org/jira/browse/OFBIZ-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146886#comment-17146886 ] Nitish Mishra commented on OFBIZ-9750: -- [~jleroux] Thanks again for reviewing. I have updated the patch. Please let me know if I have missed any other themes. > Add new CSS classes for aligning table data > --- > > Key: OFBIZ-9750 > URL: https://issues.apache.org/jira/browse/OFBIZ-9750 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mayank Lambhate >Assignee: Nitish Mishra >Priority: Minor > Attachments: OFBIZ-9750.patch > > > The tables used in OFBiz currently don`t have any standard for defining the > alignment of data inside the tables. > Defining following classes to align table data according to the context. > 1. numeric (for numeric data) > 2. currency-amount (for amount fields) > We have selected the names of classes as per OFBiz defined field types in > fieldtype*.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-9750) Add new CSS classes for aligning table data
[ https://issues.apache.org/jira/browse/OFBIZ-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitish Mishra updated OFBIZ-9750: - Attachment: OFBIZ-9750.patch > Add new CSS classes for aligning table data > --- > > Key: OFBIZ-9750 > URL: https://issues.apache.org/jira/browse/OFBIZ-9750 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mayank Lambhate >Assignee: Nitish Mishra >Priority: Minor > Attachments: OFBIZ-9750.patch > > > The tables used in OFBiz currently don`t have any standard for defining the > alignment of data inside the tables. > Defining following classes to align table data according to the context. > 1. numeric (for numeric data) > 2. currency-amount (for amount fields) > We have selected the names of classes as per OFBiz defined field types in > fieldtype*.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-9750) Add new CSS classes for aligning table data
[ https://issues.apache.org/jira/browse/OFBIZ-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitish Mishra updated OFBIZ-9750: - Attachment: (was: OFBIZ-9750.patch) > Add new CSS classes for aligning table data > --- > > Key: OFBIZ-9750 > URL: https://issues.apache.org/jira/browse/OFBIZ-9750 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mayank Lambhate >Assignee: Nitish Mishra >Priority: Minor > Attachments: OFBIZ-9750.patch > > > The tables used in OFBiz currently don`t have any standard for defining the > alignment of data inside the tables. > Defining following classes to align table data according to the context. > 1. numeric (for numeric data) > 2. currency-amount (for amount fields) > We have selected the names of classes as per OFBiz defined field types in > fieldtype*.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9750) Add new CSS classes for aligning table data
[ https://issues.apache.org/jira/browse/OFBIZ-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146884#comment-17146884 ] Jacques Le Roux commented on OFBIZ-9750: Thanks NItish, Why not Tomahawk (just asking, no ideas)? > Add new CSS classes for aligning table data > --- > > Key: OFBIZ-9750 > URL: https://issues.apache.org/jira/browse/OFBIZ-9750 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mayank Lambhate >Assignee: Nitish Mishra >Priority: Minor > Attachments: OFBIZ-9750.patch > > > The tables used in OFBiz currently don`t have any standard for defining the > alignment of data inside the tables. > Defining following classes to align table data according to the context. > 1. numeric (for numeric data) > 2. currency-amount (for amount fields) > We have selected the names of classes as per OFBiz defined field types in > fieldtype*.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9750) Add new CSS classes for aligning table data
[ https://issues.apache.org/jira/browse/OFBIZ-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146883#comment-17146883 ] Nitish Mishra commented on OFBIZ-9750: -- [~jleroux] Thanks for the review, I have updated the patch and added the rules for all the themes. Please have a look. > Add new CSS classes for aligning table data > --- > > Key: OFBIZ-9750 > URL: https://issues.apache.org/jira/browse/OFBIZ-9750 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mayank Lambhate >Assignee: Nitish Mishra >Priority: Minor > Attachments: OFBIZ-9750.patch > > > The tables used in OFBiz currently don`t have any standard for defining the > alignment of data inside the tables. > Defining following classes to align table data according to the context. > 1. numeric (for numeric data) > 2. currency-amount (for amount fields) > We have selected the names of classes as per OFBiz defined field types in > fieldtype*.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-9750) Add new CSS classes for aligning table data
[ https://issues.apache.org/jira/browse/OFBIZ-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitish Mishra updated OFBIZ-9750: - Attachment: (was: OFBIZ-9750.patch) > Add new CSS classes for aligning table data > --- > > Key: OFBIZ-9750 > URL: https://issues.apache.org/jira/browse/OFBIZ-9750 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mayank Lambhate >Assignee: Nitish Mishra >Priority: Minor > Attachments: OFBIZ-9750.patch > > > The tables used in OFBiz currently don`t have any standard for defining the > alignment of data inside the tables. > Defining following classes to align table data according to the context. > 1. numeric (for numeric data) > 2. currency-amount (for amount fields) > We have selected the names of classes as per OFBiz defined field types in > fieldtype*.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-9750) Add new CSS classes for aligning table data
[ https://issues.apache.org/jira/browse/OFBIZ-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitish Mishra updated OFBIZ-9750: - Attachment: OFBIZ-9750.patch > Add new CSS classes for aligning table data > --- > > Key: OFBIZ-9750 > URL: https://issues.apache.org/jira/browse/OFBIZ-9750 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mayank Lambhate >Assignee: Nitish Mishra >Priority: Minor > Attachments: OFBIZ-9750.patch > > > The tables used in OFBiz currently don`t have any standard for defining the > alignment of data inside the tables. > Defining following classes to align table data according to the context. > 1. numeric (for numeric data) > 2. currency-amount (for amount fields) > We have selected the names of classes as per OFBiz defined field types in > fieldtype*.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11529) Convert testInvoiceWorkerGetInvoiceTotal test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11529: Fix Version/s: (was: Trunk) Upcoming Branch Thanks Rohit > Convert testInvoiceWorkerGetInvoiceTotal test from XML to Groovy > > > Key: OFBIZ-11529 > URL: https://issues.apache.org/jira/browse/OFBIZ-11529 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > Fix For: Upcoming Branch > > > Convert testInvoiceWorkerGetInvoiceTotal test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11529) Convert testInvoiceWorkerGetInvoiceTotal test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri closed OFBIZ-11529. - Resolution: Fixed > Convert testInvoiceWorkerGetInvoiceTotal test from XML to Groovy > > > Key: OFBIZ-11529 > URL: https://issues.apache.org/jira/browse/OFBIZ-11529 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > Fix For: Trunk > > > Convert testInvoiceWorkerGetInvoiceTotal test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11529) Convert testInvoiceWorkerGetInvoiceTotal test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146880#comment-17146880 ] Rohit Hukkeri commented on OFBIZ-11529: --- Closing this issue as it getting resolved under -OFBIZ-11530- > Convert testInvoiceWorkerGetInvoiceTotal test from XML to Groovy > > > Key: OFBIZ-11529 > URL: https://issues.apache.org/jira/browse/OFBIZ-11529 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Rohit Hukkeri >Priority: Minor > Fix For: Trunk > > > Convert testInvoiceWorkerGetInvoiceTotal test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11492) Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11492. --- Fix Version/s: Upcoming Branch Resolution: Implemented > Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL > - > > Key: OFBIZ-11492 > URL: https://issues.apache.org/jira/browse/OFBIZ-11492 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11492.patch, OFBIZ-11492.patch > > > Convert the createFinAccoutnTransFromPayment service code from mini-lang to > groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11492) Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146871#comment-17146871 ] ASF subversion and git services commented on OFBIZ-11492: - Commit 8fc41cb9ae3d6e9af6bc598d63deb1ed31ff2c8e in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8fc41cb ] Improved: Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL (OFBIZ-11492) Fixes previous commit, I used a 1st patch and did not see it was wrong Thanks: Anushi Gupta for the 2nd patch > Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL > - > > Key: OFBIZ-11492 > URL: https://issues.apache.org/jira/browse/OFBIZ-11492 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11492.patch, OFBIZ-11492.patch > > > Convert the createFinAccoutnTransFromPayment service code from mini-lang to > groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11492) Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146868#comment-17146868 ] ASF subversion and git services commented on OFBIZ-11492: - Commit f421af33a35f2c5087ab4a0e1fa292991af3ecb0 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f421af3 ] Improved: Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL (OFBIZ-11492) Thanks: Devanshu Vyas for report, Anushi Gupta for the patch > Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL > - > > Key: OFBIZ-11492 > URL: https://issues.apache.org/jira/browse/OFBIZ-11492 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11492.patch, OFBIZ-11492.patch > > > Convert the createFinAccoutnTransFromPayment service code from mini-lang to > groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11487) Convert voidPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Punyani updated OFBIZ-11487: Attachment: OFBIZ-11487.patch > Convert voidPayment service from mini-lang to groovy DSL > > > Key: OFBIZ-11487 > URL: https://issues.apache.org/jira/browse/OFBIZ-11487 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Attachments: OFBIZ-11487.patch > > > Convert the voidPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11487) Convert voidPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146867#comment-17146867 ] Sourabh Punyani commented on OFBIZ-11487: - Hello Devanshu, I have added a patch (OFBIZ-11487.patch) for the same. Please verify. > Convert voidPayment service from mini-lang to groovy DSL > > > Key: OFBIZ-11487 > URL: https://issues.apache.org/jira/browse/OFBIZ-11487 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Attachments: OFBIZ-11487.patch > > > Convert the voidPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11837) First Data Payment Gateway Integration
[ https://issues.apache.org/jira/browse/OFBIZ-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146864#comment-17146864 ] Pierre Smits commented on OFBIZ-11837: -- My apologies. I meant a separate repository. > First Data Payment Gateway Integration > -- > > Key: OFBIZ-11837 > URL: https://issues.apache.org/jira/browse/OFBIZ-11837 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pritam Kute >Priority: Major > > Dev Thread Link: [https://markmail.org/thread/2p5top4idkeiwlih] > Apache OFBiz has OOTB integrations for most of the widely used payment > gateways around the world. > We are working on integrating First Data Payment Gateway for one of the > websites. The First Data payment gateway is quite popular and comes in the > list of top payment gateways around the globe. We would like to contribute > the basic payment gateway integration of First Data into Apache OFBiz. > Also as discussed over the DEV list, we will be contributing gateway as a > separate plugin. > We will create the subtasks under this main task to deliver different payment > gateway methods. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11483) Convert quickSendPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146862#comment-17146862 ] Rohit Koushal edited comment on OFBIZ-11483 at 6/27/20, 9:56 AM: - Attaching the patch having quickSendPayment mini-lang to groovy DSL conversion was (Author: rohit.koushal): Attaching the patch having quickSendPayment mini-lang to groovy DSL conversion. * [|https://issues.apache.org/jira/secure/AddComment!default.jspa?id=13294604] > Convert quickSendPayment service from mini-lang to groovy DSL > - > > Key: OFBIZ-11483 > URL: https://issues.apache.org/jira/browse/OFBIZ-11483 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-11483.patch > > > Convert the quickSendPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11837) First Data Payment Gateway Integration
[ https://issues.apache.org/jira/browse/OFBIZ-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146863#comment-17146863 ] Pierre Smits commented on OFBIZ-11837: -- Hi [~pritam.kute], If you were to make the functionality available in a separate plugin (not included in ofbiz-plugins), I will do my best to review and evaluate it. Best regards, Pierre > First Data Payment Gateway Integration > -- > > Key: OFBIZ-11837 > URL: https://issues.apache.org/jira/browse/OFBIZ-11837 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pritam Kute >Priority: Major > > Dev Thread Link: [https://markmail.org/thread/2p5top4idkeiwlih] > Apache OFBiz has OOTB integrations for most of the widely used payment > gateways around the world. > We are working on integrating First Data Payment Gateway for one of the > websites. The First Data payment gateway is quite popular and comes in the > list of top payment gateways around the globe. We would like to contribute > the basic payment gateway integration of First Data into Apache OFBiz. > Also as discussed over the DEV list, we will be contributing gateway as a > separate plugin. > We will create the subtasks under this main task to deliver different payment > gateway methods. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11483) Convert quickSendPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146862#comment-17146862 ] Rohit Koushal commented on OFBIZ-11483: --- Attaching the patch having quickSendPayment mini-lang to groovy DSL conversion. * [|https://issues.apache.org/jira/secure/AddComment!default.jspa?id=13294604] > Convert quickSendPayment service from mini-lang to groovy DSL > - > > Key: OFBIZ-11483 > URL: https://issues.apache.org/jira/browse/OFBIZ-11483 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-11483.patch > > > Convert the quickSendPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11492) Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11492: --- Assignee: Jacques Le Roux (was: Anushi Gupta) > Convert createFinAccoutnTransFromPayment service from mini-lang to groovy DSL > - > > Key: OFBIZ-11492 > URL: https://issues.apache.org/jira/browse/OFBIZ-11492 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11492.patch, OFBIZ-11492.patch > > > Convert the createFinAccoutnTransFromPayment service code from mini-lang to > groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11483) Convert quickSendPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-11483: -- Attachment: OFBIZ-11483.patch > Convert quickSendPayment service from mini-lang to groovy DSL > - > > Key: OFBIZ-11483 > URL: https://issues.apache.org/jira/browse/OFBIZ-11483 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-11483.patch > > > Convert the quickSendPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11378) Convert createCommContentDataResource service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anushi Gupta reassigned OFBIZ-11378: Assignee: Anushi Gupta (was: Komal Dayle) > Convert createCommContentDataResource service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11378 > URL: https://issues.apache.org/jira/browse/OFBIZ-11378 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Anushi Gupta >Priority: Minor > > Convert createCommContentDataResource service code from mini-lang to groovy > DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11727) Warning message should be shown when added back date with card details
[ https://issues.apache.org/jira/browse/OFBIZ-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146860#comment-17146860 ] Jacques Le Roux commented on OFBIZ-11727: - Hi Pritam, Better handle the states issues with OFBIZ-11838, TIA > Warning message should be shown when added back date with card details > -- > > Key: OFBIZ-11727 > URL: https://issues.apache.org/jira/browse/OFBIZ-11727 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Dikpal Kanungo >Assignee: Pritam Kute >Priority: Minor > Attachments: Back date should not be selected.png > > > > Steps to regenerate: > 1. Navigate to : [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main] > 2. Add products to cart and proceed with 'Single page checkout' > 3. In step 4 for the checkout process at Billing and shipping form, try > adding a back date for the in reference to card details > 4. It will not prompt the user for adding an expiry date, and the page will > just refresh again and again > > Expected: User should be notified of adding an expired date. > > Reference: > !Back date should not be selected.png! > > Let me know if you need any further help with the same. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
