[jira] [Closed] (OFBIZ-11528) Convert testAcctgTransOnPaymentReceivedFromCustomer test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11528. -- Fix Version/s: Upcoming Branch Resolution: Implemented This has been handled in OFBIZ-11526 Thanks, [~rohit.hukkeri]! > Convert testAcctgTransOnPaymentReceivedFromCustomer test from XML to Groovy > --- > > Key: OFBIZ-11528 > URL: https://issues.apache.org/jira/browse/OFBIZ-11528 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Fix For: Upcoming Branch > > > Convert testAcctgTransOnPaymentReceivedFromCustomer test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11527) Convert testAcctgTransOnSalesInvoice test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11527. -- Fix Version/s: Upcoming Branch Resolution: Implemented This has been handled in OFBIZ-11526 Thanks, [~rohit.hukkeri]! > Convert testAcctgTransOnSalesInvoice test from XML to Groovy > > > Key: OFBIZ-11527 > URL: https://issues.apache.org/jira/browse/OFBIZ-11527 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Fix For: Upcoming Branch > > > Convert testAcctgTransOnSalesInvoice test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11526) Convert AutoAcctgTransTestsSales.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11526. -- Fix Version/s: Upcoming Branch Resolution: Implemented > Convert AutoAcctgTransTestsSales.xml to Groovy > -- > > Key: OFBIZ-11526 > URL: https://issues.apache.org/jira/browse/OFBIZ-11526 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11526.patch > > > Convert AutoAcctgTransTestsSales XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11526) Convert AutoAcctgTransTestsSales.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149118#comment-17149118 ] ASF subversion and git services commented on OFBIZ-11526: - Commit da0002fc4a0dc3ecaf19f8cea351f92f9b42287e in ofbiz-framework's branch refs/heads/trunk from Akash Jain [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=da0002f ] Improved: Convert AutoAcctgTransTestsSales.xml to Groovy (OFBIZ-11526) Thanks, Rohit Hukkeri for the report. > Convert AutoAcctgTransTestsSales.xml to Groovy > -- > > Key: OFBIZ-11526 > URL: https://issues.apache.org/jira/browse/OFBIZ-11526 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Attachments: OFBIZ-11526.patch > > > Convert AutoAcctgTransTestsSales XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11843) Accept return process throwing missing method exception
[ https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149080#comment-17149080 ] Pritam Kute commented on OFBIZ-11843: - Thanks [~jleroux]! > Accept return process throwing missing method exception > --- > > Key: OFBIZ-11843 > URL: https://issues.apache.org/jira/browse/OFBIZ-11843 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pawan Verma >Priority: Major > Fix For: Upcoming Branch > > > Steps to regenerate: > 1. Open any return in requested status > 2. Go to 'Return Items' menu > 3. Click on the 'Accept Return' button. > Expected Result: > The return should be marked as accepted in the system. > Actual: > Error screen with error log as: > org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error > (groovy.lang.MissingMethodException: No signature of method: static > java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) > values: [0.01] Possible solutions: minus(java.lang.Character), > minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find()) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-4602) Null values are not synchronized in http mode
[ https://issues.apache.org/jira/browse/OFBIZ-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4602. -- Resolution: Abandoned > Null values are not synchronized in http mode > - > > Key: OFBIZ-4602 > URL: https://issues.apache.org/jira/browse/OFBIZ-4602 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release 4.0, Release 09.04, Release 09.04.01, Release > 10.04, Trunk > Environment: Using entity synchronization over HTTP (not RMI) >Reporter: Patrick Antivackis >Assignee: Jacques Le Roux >Priority: Major > Attachments: patch-OFBIZ-4602.txt > > > In order to send over http the values to create, store and remove, Ofbiz is > Xml serializing the values. GenericValue xml serialization is managed in > GenericEntity.makeXmlElement, unfortunately this method just don't serialized > null valued fields. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148821#comment-17148821 ] Jacques Le Roux commented on OFBIZ-11553: - Thanks Priya, It seems not easy, maybe it's a data issue because running the simple test works, I'm not sure anyway... > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (OFBIZ-11836) IDOR vulnerability in the order processing feature in ecommerce component
[
https://issues.apache.org/jira/browse/OFBIZ-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11836:
Comment: was deleted
(was: This issue has been requalified and corresponds to CVE-2020-13923)
> IDOR vulnerability in the order processing feature in ecommerce component
> -
>
> Key: OFBIZ-11836
> URL: https://issues.apache.org/jira/browse/OFBIZ-11836
> Project: OFBiz
> Issue Type: Sub-task
> Components: ecommerce, order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.04
>
>
> Harshit Shukla [mailto:harshit.sh...@gmail.com]reported this IDOR
> vulnerability to the OFBiz security team, and we thank him for that.
> I'll later quote here his email message when the vulnerability will be fixed.
> It's a post-auth vulnerability so we did not ask for a CVE.
> Here is Harshit's message slightly edited:
> {quote}
> https://demo-stable.ofbiz.apache.org/ecommerce/control/order.pdf?orderId=WSCO1
> In the above URL, the parameter 'orderId' has the value 'WSCO1' and after
> incrementing the value to 'WSCO10001' or 'WSCO10002' will download the
> receipt of other orders which have been placed by other users.
> All the available order receipts can be downloaded by running an automated
> tool (Burp Intruder) on the parameter 'orderId=WSCOX'
> I have successfully tested this by using 2 different accounts: DemoCustomer
> and DemoCustomer2 ([~jleroux] edited)
> An attacker can download order receipts of other users and this could lead to
> information disclosure.
> The only real solution to this issue is to implement access control. The user
> needs to be authorized for the requested information before the server
> provides it.
> Reference:https://blog.detectify.com/2016/05/25/owasp-top-10-insecure-direct-object-reference-4/
> {quote}
> Only ecommerce is affected because we have secure permissions in backorder
> components (ERP)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11836) IDOR vulnerability in the order processing feature in ecommerce component
[
https://issues.apache.org/jira/browse/OFBIZ-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11836:
Summary: IDOR vulnerability in the order processing feature in ecommerce
component (was: IDOR vulnerability in the order processing feature in
ecommerce component (CVE-2020-13923))
> IDOR vulnerability in the order processing feature in ecommerce component
> -
>
> Key: OFBIZ-11836
> URL: https://issues.apache.org/jira/browse/OFBIZ-11836
> Project: OFBiz
> Issue Type: Sub-task
> Components: ecommerce, order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.04
>
>
> Harshit Shukla [mailto:harshit.sh...@gmail.com]reported this IDOR
> vulnerability to the OFBiz security team, and we thank him for that.
> I'll later quote here his email message when the vulnerability will be fixed.
> It's a post-auth vulnerability so we did not ask for a CVE.
> Here is Harshit's message slightly edited:
> {quote}
> https://demo-stable.ofbiz.apache.org/ecommerce/control/order.pdf?orderId=WSCO1
> In the above URL, the parameter 'orderId' has the value 'WSCO1' and after
> incrementing the value to 'WSCO10001' or 'WSCO10002' will download the
> receipt of other orders which have been placed by other users.
> All the available order receipts can be downloaded by running an automated
> tool (Burp Intruder) on the parameter 'orderId=WSCOX'
> I have successfully tested this by using 2 different accounts: DemoCustomer
> and DemoCustomer2 ([~jleroux] edited)
> An attacker can download order receipts of other users and this could lead to
> information disclosure.
> The only real solution to this issue is to implement access control. The user
> needs to be authorized for the requested information before the server
> provides it.
> Reference:https://blog.detectify.com/2016/05/25/owasp-top-10-insecure-direct-object-reference-4/
> {quote}
> Only ecommerce is affected because we have secure permissions in backorder
> components (ERP)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11836) IDOR vulnerability in the order processing feature in ecommerce component (CVE-2020-13923)
[
https://issues.apache.org/jira/browse/OFBIZ-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11836:
Summary: IDOR vulnerability in the order processing feature in ecommerce
component (CVE-2020-13923) (was: IDOR vulnerability in the order processing
feature in ecommerce component)
> IDOR vulnerability in the order processing feature in ecommerce component
> (CVE-2020-13923)
> --
>
> Key: OFBIZ-11836
> URL: https://issues.apache.org/jira/browse/OFBIZ-11836
> Project: OFBiz
> Issue Type: Sub-task
> Components: ecommerce, order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.04
>
>
> Harshit Shukla [mailto:harshit.sh...@gmail.com]reported this IDOR
> vulnerability to the OFBiz security team, and we thank him for that.
> I'll later quote here his email message when the vulnerability will be fixed.
> It's a post-auth vulnerability so we did not ask for a CVE.
> Here is Harshit's message slightly edited:
> {quote}
> https://demo-stable.ofbiz.apache.org/ecommerce/control/order.pdf?orderId=WSCO1
> In the above URL, the parameter 'orderId' has the value 'WSCO1' and after
> incrementing the value to 'WSCO10001' or 'WSCO10002' will download the
> receipt of other orders which have been placed by other users.
> All the available order receipts can be downloaded by running an automated
> tool (Burp Intruder) on the parameter 'orderId=WSCOX'
> I have successfully tested this by using 2 different accounts: DemoCustomer
> and DemoCustomer2 ([~jleroux] edited)
> An attacker can download order receipts of other users and this could lead to
> information disclosure.
> The only real solution to this issue is to implement access control. The user
> needs to be authorized for the requested information before the server
> provides it.
> Reference:https://blog.detectify.com/2016/05/25/owasp-top-10-insecure-direct-object-reference-4/
> {quote}
> Only ecommerce is affected because we have secure permissions in backorder
> components (ERP)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11836) IDOR vulnerability in the order processing feature in ecommerce component (CVE-2020-13923)
[
https://issues.apache.org/jira/browse/OFBIZ-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148784#comment-17148784
]
Jacques Le Roux commented on OFBIZ-11836:
-
This issue has been requalified and corresponds to CVE-2020-13923
> IDOR vulnerability in the order processing feature in ecommerce component
> (CVE-2020-13923)
> --
>
> Key: OFBIZ-11836
> URL: https://issues.apache.org/jira/browse/OFBIZ-11836
> Project: OFBiz
> Issue Type: Sub-task
> Components: ecommerce, order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.04
>
>
> Harshit Shukla [mailto:harshit.sh...@gmail.com]reported this IDOR
> vulnerability to the OFBiz security team, and we thank him for that.
> I'll later quote here his email message when the vulnerability will be fixed.
> It's a post-auth vulnerability so we did not ask for a CVE.
> Here is Harshit's message slightly edited:
> {quote}
> https://demo-stable.ofbiz.apache.org/ecommerce/control/order.pdf?orderId=WSCO1
> In the above URL, the parameter 'orderId' has the value 'WSCO1' and after
> incrementing the value to 'WSCO10001' or 'WSCO10002' will download the
> receipt of other orders which have been placed by other users.
> All the available order receipts can be downloaded by running an automated
> tool (Burp Intruder) on the parameter 'orderId=WSCOX'
> I have successfully tested this by using 2 different accounts: DemoCustomer
> and DemoCustomer2 ([~jleroux] edited)
> An attacker can download order receipts of other users and this could lead to
> information disclosure.
> The only real solution to this issue is to implement access control. The user
> needs to be authorized for the requested information before the server
> provides it.
> Reference:https://blog.detectify.com/2016/05/25/owasp-top-10-insecure-direct-object-reference-4/
> {quote}
> Only ecommerce is affected because we have secure permissions in backorder
> components (ERP)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-9750) Add new CSS classes for aligning table data
[ https://issues.apache.org/jira/browse/OFBIZ-9750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9750. -- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks Nitish, I created OFBIZ-11863 to use these new CSS classes > Add new CSS classes for aligning table data > --- > > Key: OFBIZ-9750 > URL: https://issues.apache.org/jira/browse/OFBIZ-9750 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Mayank Lambhate >Assignee: Nitish Mishra >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-9750.patch > > > The tables used in OFBiz currently don`t have any standard for defining the > alignment of data inside the tables. > Defining following classes to align table data according to the context. > 1. numeric (for numeric data) > 2. currency-amount (for amount fields) > We have selected the names of classes as per OFBiz defined field types in > fieldtype*.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11863) Use new CSS classes for aligning table data put in with OFBIZ-9750
Jacques Le Roux created OFBIZ-11863: --- Summary: Use new CSS classes for aligning table data put in with OFBIZ-9750 Key: OFBIZ-11863 URL: https://issues.apache.org/jira/browse/OFBIZ-11863 Project: OFBiz Issue Type: New Feature Components: ALL APPLICATIONS, ALL PLUGINS Affects Versions: Trunk Reporter: Jacques Le Roux With OFBIZ-9750 [~nitish.mishra] puts in new CSS classes for aligning table data. These classes are not yet used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11862) BigDecimal casting in Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11862.
---
Fix Version/s: 18.12.01
Assignee: Jacques Le Roux
Resolution: Fixed
> BigDecimal casting in Groovy
>
>
> Key: OFBIZ-11862
> URL: https://issues.apache.org/jira/browse/OFBIZ-11862
> Project: OFBiz
> Issue Type: Bug
> Components: bi, order, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> [Pritam Kute
> noticed|https://issues.apache.org/jira/browse/OFBIZ-11843?focusedCommentId=17146911=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17146911]
> in OFBIZ-11843 that we sometimes use wrong type castings for BigDecimal:
> {quote}
> I have observed that for typecasting in groovy, we have used the wrong coding
> pattern like
> {code:java}
> (BigDecimal) -0.01
> {code}
> It should be like
> {code:java}
> -0.01 as BigDecimal
> {code}
> {quote}
> Actually in this case we don't need to cast, [because in case of decimal, the
> default type is always
> BigDecimal|https://www.logicbig.com/tutorials/misc/groovy/numbers-types-suffix.html].
>
> But there are Integers in trunk (mostly 0) and 2 cases where it's useless to
> cast in R18, nothing in R17
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11862) BigDecimal casting in Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148675#comment-17148675
]
Jacques Le Roux commented on OFBIZ-11862:
-
In the commits above I treated cases I'm not sure were needed. It's the cases
where it's not an initialisation. Anyway I don't think it hurts to do so.
> BigDecimal casting in Groovy
>
>
> Key: OFBIZ-11862
> URL: https://issues.apache.org/jira/browse/OFBIZ-11862
> Project: OFBiz
> Issue Type: Bug
> Components: bi, order, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> [Pritam Kute
> noticed|https://issues.apache.org/jira/browse/OFBIZ-11843?focusedCommentId=17146911=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17146911]
> in OFBIZ-11843 that we sometimes use wrong type castings for BigDecimal:
> {quote}
> I have observed that for typecasting in groovy, we have used the wrong coding
> pattern like
> {code:java}
> (BigDecimal) -0.01
> {code}
> It should be like
> {code:java}
> -0.01 as BigDecimal
> {code}
> {quote}
> Actually in this case we don't need to cast, [because in case of decimal, the
> default type is always
> BigDecimal|https://www.logicbig.com/tutorials/misc/groovy/numbers-types-suffix.html].
>
> But there are Integers in trunk (mostly 0) and 2 cases where it's useless to
> cast in R18, nothing in R17
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11862) BigDecimal casting in Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148672#comment-17148672
]
ASF subversion and git services commented on OFBIZ-11862:
-
Commit 8ca14ec910810810d8e86a767d775b3382202d38 in ofbiz-plugins's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=8ca14ec ]
Fixed: BigDecimal casting in Groovy (OFBIZ-11862)
Sometimes use wrong type castings for BigDecimal:
I have observed that for typecasting in groovy, we have used the wrong coding
pattern like
(BigDecimal) 0
It should be like
0 as BigDecimal
Note that this does not apply to decimal because in case of decimal, the default
type is always BigDecimal in Groovy.
Thanks: Pritam Kute for spotting the issue in OFBIZ-11843
> BigDecimal casting in Groovy
>
>
> Key: OFBIZ-11862
> URL: https://issues.apache.org/jira/browse/OFBIZ-11862
> Project: OFBiz
> Issue Type: Bug
> Components: bi, order, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> [Pritam Kute
> noticed|https://issues.apache.org/jira/browse/OFBIZ-11843?focusedCommentId=17146911=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17146911]
> in OFBIZ-11843 that we sometimes use wrong type castings for BigDecimal:
> {quote}
> I have observed that for typecasting in groovy, we have used the wrong coding
> pattern like
> {code:java}
> (BigDecimal) -0.01
> {code}
> It should be like
> {code:java}
> -0.01 as BigDecimal
> {code}
> {quote}
> Actually in this case we don't need to cast, [because in case of decimal, the
> default type is always
> BigDecimal|https://www.logicbig.com/tutorials/misc/groovy/numbers-types-suffix.html].
>
> But there are Integers in trunk (mostly 0) and 2 cases where it's useless to
> cast in R18, nothing in R17
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11843) Accept return process throwing missing method exception
[ https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148673#comment-17148673 ] ASF subversion and git services commented on OFBIZ-11843: - Commit 8ca14ec910810810d8e86a767d775b3382202d38 in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=8ca14ec ] Fixed: BigDecimal casting in Groovy (OFBIZ-11862) Sometimes use wrong type castings for BigDecimal: I have observed that for typecasting in groovy, we have used the wrong coding pattern like (BigDecimal) 0 It should be like 0 as BigDecimal Note that this does not apply to decimal because in case of decimal, the default type is always BigDecimal in Groovy. Thanks: Pritam Kute for spotting the issue in OFBIZ-11843 > Accept return process throwing missing method exception > --- > > Key: OFBIZ-11843 > URL: https://issues.apache.org/jira/browse/OFBIZ-11843 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pawan Verma >Priority: Major > Fix For: Upcoming Branch > > > Steps to regenerate: > 1. Open any return in requested status > 2. Go to 'Return Items' menu > 3. Click on the 'Accept Return' button. > Expected Result: > The return should be marked as accepted in the system. > Actual: > Error screen with error log as: > org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error > (groovy.lang.MissingMethodException: No signature of method: static > java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) > values: [0.01] Possible solutions: minus(java.lang.Character), > minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find()) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11858) Console warning related to OrderHeader caching
[ https://issues.apache.org/jira/browse/OFBIZ-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148671#comment-17148671 ] Jacques Le Roux commented on OFBIZ-11858: - Thanks Praveen, I did not check if there are other cases but the ones you fixed look good to me. > Console warning related to OrderHeader caching > -- > > Key: OFBIZ-11858 > URL: https://issues.apache.org/jira/browse/OFBIZ-11858 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-11858.patch > > > 2020-06-30 14:52:50,499 |OFBiz-JobQueue-0 |EntityListCache |W| Tried to put a > value of the OrderHeader entity in the cache but this entity has never-cache > set to true, not caching. > As never-cache="true" is set on Order Header, it should never be cached. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11843) Accept return process throwing missing method exception
[ https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148668#comment-17148668 ] ASF subversion and git services commented on OFBIZ-11843: - Commit df179777b68f8d9411b84b3e11d38e0bda5c0bb4 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=df17977 ] Fixed: BigDecimal casting in Groovy (OFBIZ-11862) Sometimes use wrong type castings for BigDecimal: I have observed that for typecasting in groovy, we have used the wrong coding pattern like (BigDecimal) 0 It should be like 0 as BigDecimal Note that this does not apply to decimal because in case of decimal, the default type is always BigDecimal in Groovy. Thanks: Pritam Kute for spotting the issue in OFBIZ-11843 > Accept return process throwing missing method exception > --- > > Key: OFBIZ-11843 > URL: https://issues.apache.org/jira/browse/OFBIZ-11843 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pawan Verma >Priority: Major > Fix For: Upcoming Branch > > > Steps to regenerate: > 1. Open any return in requested status > 2. Go to 'Return Items' menu > 3. Click on the 'Accept Return' button. > Expected Result: > The return should be marked as accepted in the system. > Actual: > Error screen with error log as: > org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error > (groovy.lang.MissingMethodException: No signature of method: static > java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) > values: [0.01] Possible solutions: minus(java.lang.Character), > minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find()) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11862) BigDecimal casting in Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148667#comment-17148667
]
ASF subversion and git services commented on OFBIZ-11862:
-
Commit df179777b68f8d9411b84b3e11d38e0bda5c0bb4 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=df17977 ]
Fixed: BigDecimal casting in Groovy (OFBIZ-11862)
Sometimes use wrong type castings for BigDecimal:
I have observed that for typecasting in groovy, we have used the wrong coding
pattern like
(BigDecimal) 0
It should be like
0 as BigDecimal
Note that this does not apply to decimal because in case of decimal, the default
type is always BigDecimal in Groovy.
Thanks: Pritam Kute for spotting the issue in OFBIZ-11843
> BigDecimal casting in Groovy
>
>
> Key: OFBIZ-11862
> URL: https://issues.apache.org/jira/browse/OFBIZ-11862
> Project: OFBiz
> Issue Type: Bug
> Components: bi, order, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> [Pritam Kute
> noticed|https://issues.apache.org/jira/browse/OFBIZ-11843?focusedCommentId=17146911=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17146911]
> in OFBIZ-11843 that we sometimes use wrong type castings for BigDecimal:
> {quote}
> I have observed that for typecasting in groovy, we have used the wrong coding
> pattern like
> {code:java}
> (BigDecimal) -0.01
> {code}
> It should be like
> {code:java}
> -0.01 as BigDecimal
> {code}
> {quote}
> Actually in this case we don't need to cast, [because in case of decimal, the
> default type is always
> BigDecimal|https://www.logicbig.com/tutorials/misc/groovy/numbers-types-suffix.html].
>
> But there are Integers in trunk (mostly 0) and 2 cases where it's useless to
> cast in R18, nothing in R17
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11862) BigDecimal casting in Groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148666#comment-17148666
]
ASF subversion and git services commented on OFBIZ-11862:
-
Commit 466e426f8b35655d80ce45276218f3693c528a7c in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=466e426 ]
Improved: BigDecimal casting in Groovy (OFBIZ-11862)
It's not a bug here, but casting is not necessary, better keep things simple
> BigDecimal casting in Groovy
>
>
> Key: OFBIZ-11862
> URL: https://issues.apache.org/jira/browse/OFBIZ-11862
> Project: OFBiz
> Issue Type: Bug
> Components: bi, order, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> [Pritam Kute
> noticed|https://issues.apache.org/jira/browse/OFBIZ-11843?focusedCommentId=17146911=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17146911]
> in OFBIZ-11843 that we sometimes use wrong type castings for BigDecimal:
> {quote}
> I have observed that for typecasting in groovy, we have used the wrong coding
> pattern like
> {code:java}
> (BigDecimal) -0.01
> {code}
> It should be like
> {code:java}
> -0.01 as BigDecimal
> {code}
> {quote}
> Actually in this case we don't need to cast, [because in case of decimal, the
> default type is always
> BigDecimal|https://www.logicbig.com/tutorials/misc/groovy/numbers-types-suffix.html].
>
> But there are Integers in trunk (mostly 0) and 2 cases where it's useless to
> cast in R18, nothing in R17
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11843) Accept return process throwing missing method exception
[ https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148656#comment-17148656 ] Jacques Le Roux commented on OFBIZ-11843: - Hi Pritam, Actually in this case we don't need to cast, [because in case of decimal, the default type is always BigDecimal|https://www.logicbig.com/tutorials/misc/groovy/numbers-types-suffix.html]. Nevertheless I have created OFBIZ-11862 for the cases where it's necessary. > Accept return process throwing missing method exception > --- > > Key: OFBIZ-11843 > URL: https://issues.apache.org/jira/browse/OFBIZ-11843 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pawan Verma >Priority: Major > Fix For: Upcoming Branch > > > Steps to regenerate: > 1. Open any return in requested status > 2. Go to 'Return Items' menu > 3. Click on the 'Accept Return' button. > Expected Result: > The return should be marked as accepted in the system. > Actual: > Error screen with error log as: > org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error > (groovy.lang.MissingMethodException: No signature of method: static > java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) > values: [0.01] Possible solutions: minus(java.lang.Character), > minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find()) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11862) BigDecimal casting in Groovy
Jacques Le Roux created OFBIZ-11862:
---
Summary: BigDecimal casting in Groovy
Key: OFBIZ-11862
URL: https://issues.apache.org/jira/browse/OFBIZ-11862
Project: OFBiz
Issue Type: Bug
Components: bi, order, product
Affects Versions: Trunk
Reporter: Jacques Le Roux
[Pritam Kute
noticed|https://issues.apache.org/jira/browse/OFBIZ-11843?focusedCommentId=17146911=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17146911]
in OFBIZ-11843 that we sometimes use wrong type castings for BigDecimal:
{quote}
I have observed that for typecasting in groovy, we have used the wrong coding
pattern like
{code:java}
(BigDecimal) -0.01
{code}
It should be like
{code:java}
-0.01 as BigDecimal
{code}
{quote}
Actually in this case we don't need to cast, [because in case of decimal, the
default type is always
BigDecimal|https://www.logicbig.com/tutorials/misc/groovy/numbers-types-suffix.html].
But there are Integers in trunk (mostly 0) and 2 cases where it's useless to
cast in R18, nothing in R17
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11858) Console warning related to OrderHeader caching
[ https://issues.apache.org/jira/browse/OFBIZ-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148516#comment-17148516 ] Praveen Sharma commented on OFBIZ-11858: Hi [~surajk] I have added a (OFBIZ-11858) patch for the same. Please verify. Thanks! > Console warning related to OrderHeader caching > -- > > Key: OFBIZ-11858 > URL: https://issues.apache.org/jira/browse/OFBIZ-11858 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-11858.patch > > > 2020-06-30 14:52:50,499 |OFBiz-JobQueue-0 |EntityListCache |W| Tried to put a > value of the OrderHeader entity in the cache but this entity has never-cache > set to true, not caching. > As never-cache="true" is set on Order Header, it should never be cached. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11858) Console warning related to OrderHeader caching
[ https://issues.apache.org/jira/browse/OFBIZ-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Praveen Sharma updated OFBIZ-11858: --- Attachment: OFBIZ-11858.patch > Console warning related to OrderHeader caching > -- > > Key: OFBIZ-11858 > URL: https://issues.apache.org/jira/browse/OFBIZ-11858 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Minor > Attachments: OFBIZ-11858.patch > > > 2020-06-30 14:52:50,499 |OFBiz-JobQueue-0 |EntityListCache |W| Tried to put a > value of the OrderHeader entity in the cache but this entity has never-cache > set to true, not caching. > As never-cache="true" is set on Order Header, it should never be cached. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11861) Convert ShoppingListTests.xml to Groovy
Akash Jain created OFBIZ-11861: -- Summary: Convert ShoppingListTests.xml to Groovy Key: OFBIZ-11861 URL: https://issues.apache.org/jira/browse/OFBIZ-11861 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Akash Jain Assignee: Akash Jain Convert ShoppingListTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11860) Convert CustRequestTests.xml to Groovy
Akash Jain created OFBIZ-11860: -- Summary: Convert CustRequestTests.xml to Groovy Key: OFBIZ-11860 URL: https://issues.apache.org/jira/browse/OFBIZ-11860 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Akash Jain Assignee: Akash Jain Convert CustRequestTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11859) Convert CostTests.xml to Groovy
Akash Jain created OFBIZ-11859: -- Summary: Convert CostTests.xml to Groovy Key: OFBIZ-11859 URL: https://issues.apache.org/jira/browse/OFBIZ-11859 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Akash Jain Assignee: Akash Jain Convert CostTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11858) Console warning related to OrderHeader caching
Suraj Khurana created OFBIZ-11858: - Summary: Console warning related to OrderHeader caching Key: OFBIZ-11858 URL: https://issues.apache.org/jira/browse/OFBIZ-11858 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana 2020-06-30 14:52:50,499 |OFBiz-JobQueue-0 |EntityListCache |W| Tried to put a value of the OrderHeader entity in the cache but this entity has never-cache set to true, not caching. As never-cache="true" is set on Order Header, it should never be cached. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11857) Convert ProductTagTest.xml to Groovy
Akash Jain created OFBIZ-11857: -- Summary: Convert ProductTagTest.xml to Groovy Key: OFBIZ-11857 URL: https://issues.apache.org/jira/browse/OFBIZ-11857 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Akash Jain Assignee: Akash Jain Convert ProductTagTest XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11856) Convert ProductPriceTests.xml to Groovy
Akash Jain created OFBIZ-11856: -- Summary: Convert ProductPriceTests.xml to Groovy Key: OFBIZ-11856 URL: https://issues.apache.org/jira/browse/OFBIZ-11856 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Akash Jain Assignee: Akash Jain Convert ProductPriceTests XML fiel to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11855) Convert RoutingServices.xml mini-lang to groovy
Wiebke Pätzold created OFBIZ-11855: -- Summary: Convert RoutingServices.xml mini-lang to groovy Key: OFBIZ-11855 URL: https://issues.apache.org/jira/browse/OFBIZ-11855 Project: OFBiz Issue Type: Sub-task Reporter: Wiebke Pätzold Assignee: Wiebke Pätzold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11854) Convert PartyContactMechTests.xml to Groovy
Akash Jain created OFBIZ-11854: -- Summary: Convert PartyContactMechTests.xml to Groovy Key: OFBIZ-11854 URL: https://issues.apache.org/jira/browse/OFBIZ-11854 Project: OFBiz Issue Type: Sub-task Components: party Affects Versions: Trunk Reporter: Akash Jain Assignee: Akash Jain Convert PartyContactMechTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11853) Convert PartyStatusChangeTests.xml to Groovy
Akash Jain created OFBIZ-11853: -- Summary: Convert PartyStatusChangeTests.xml to Groovy Key: OFBIZ-11853 URL: https://issues.apache.org/jira/browse/OFBIZ-11853 Project: OFBiz Issue Type: Sub-task Components: party Affects Versions: Trunk Reporter: Akash Jain Assignee: Akash Jain Convert PartyStatusChangeTests XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #32: Release17.12
sonarcloud[bot] removed a comment on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-651585717 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=32) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=32=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #32: Release17.12
sonarcloud[bot] commented on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-651662919 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=32) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=32=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-11852) Convert ProductTest.xml to Groovy
Akash Jain created OFBIZ-11852: -- Summary: Convert ProductTest.xml to Groovy Key: OFBIZ-11852 URL: https://issues.apache.org/jira/browse/OFBIZ-11852 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Akash Jain Assignee: Akash Jain Convert ProductTest XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11851) Convert InventoryTests.xml to Groovy
Akash Jain created OFBIZ-11851: -- Summary: Convert InventoryTests.xml to Groovy Key: OFBIZ-11851 URL: https://issues.apache.org/jira/browse/OFBIZ-11851 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Akash Jain Assignee: Akash Jain Convert InventoryTests XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11850) Convert ShipmentTests.xml to Groovy
Akash Jain created OFBIZ-11850: -- Summary: Convert ShipmentTests.xml to Groovy Key: OFBIZ-11850 URL: https://issues.apache.org/jira/browse/OFBIZ-11850 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Akash Jain Assignee: Akash Jain Convert ShipmentTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11849) Convert OrderTests.xml to Groovy
Akash Jain created OFBIZ-11849: -- Summary: Convert OrderTests.xml to Groovy Key: OFBIZ-11849 URL: https://issues.apache.org/jira/browse/OFBIZ-11849 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Akash Jain Assignee: Akash Jain Convert OrderTest XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11526) Convert AutoAcctgTransTestsSales.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-11526: --- Attachment: OFBIZ-11526.patch > Convert AutoAcctgTransTestsSales.xml to Groovy > -- > > Key: OFBIZ-11526 > URL: https://issues.apache.org/jira/browse/OFBIZ-11526 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Attachments: OFBIZ-11526.patch > > > Convert AutoAcctgTransTestsSales XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #32: Release17.12
sonarcloud[bot] removed a comment on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-650730546 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=32) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=32=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #32: Release17.12
sonarcloud[bot] commented on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-651585717 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=32) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=32=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-11525) Convert CheckEntriesBalance test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11525. -- Fix Version/s: Upcoming Branch Resolution: Implemented This has been handled in OFBIZ-11522 Thanks, [~rohit.hukkeri]! > Convert CheckEntriesBalance test from XML to Groovy > --- > > Key: OFBIZ-11525 > URL: https://issues.apache.org/jira/browse/OFBIZ-11525 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Fix For: Upcoming Branch > > > Convert CheckEntriesBalance test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11524) Convert testAcctgTransOnPaymentSentToSupplier test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11524. -- Fix Version/s: Upcoming Branch Resolution: Implemented This has been handled in [OFBIZ-11522|https://issues.apache.org/jira/browse/OFBIZ-11522] Thanks, [~rohit.hukkeri]! > Convert testAcctgTransOnPaymentSentToSupplier test from XML to Groovy > - > > Key: OFBIZ-11524 > URL: https://issues.apache.org/jira/browse/OFBIZ-11524 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Fix For: Upcoming Branch > > > Convert testAcctgTransOnPaymentSentToSupplier test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11523) Convert testAcctgTransOnEditPoInvoice test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11523. -- Fix Version/s: Upcoming Branch Resolution: Implemented This has been handled in OFBIZ-11522 Thanks, [~rohit.hukkeri]! > Convert testAcctgTransOnEditPoInvoice test from XML to Groovy > - > > Key: OFBIZ-11523 > URL: https://issues.apache.org/jira/browse/OFBIZ-11523 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Fix For: Upcoming Branch > > > Convert testAcctgTransOnEditPoInvoice test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11522) Convert AutoAcctgTransTestsPurchase.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-11522. -- Fix Version/s: Upcoming Branch Resolution: Implemented > Convert AutoAcctgTransTestsPurchase.xml to Groovy > - > > Key: OFBIZ-11522 > URL: https://issues.apache.org/jira/browse/OFBIZ-11522 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11522.patch > > > Convert AutoAcctgTransTestsPurchase XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11522) Convert AutoAcctgTransTestsPurchase.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148338#comment-17148338 ] ASF subversion and git services commented on OFBIZ-11522: - Commit 8be1705765e12336b554569ea9c41594c8bfd74a in ofbiz-framework's branch refs/heads/trunk from Akash Jain [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8be1705 ] Improved: Convert AutoAcctgTransTestsPurchase.xml to Groovy (OFBIZ-11522) Thanks, Rohit Hukkeri for the report. > Convert AutoAcctgTransTestsPurchase.xml to Groovy > - > > Key: OFBIZ-11522 > URL: https://issues.apache.org/jira/browse/OFBIZ-11522 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Akash Jain >Priority: Minor > Attachments: OFBIZ-11522.patch > > > Convert AutoAcctgTransTestsPurchase XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
