[jira] [Commented] (OFBIZ-11773) Unable to delete Group Order

2020-07-04 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151482#comment-17151482
 ] 

Pawan Verma commented on OFBIZ-11773:
-

Yes Indeed, I think might be a copy-paste issue. Thanks Jacques for the 
correction :) 

> Unable to delete Group Order
> 
>
> Key: OFBIZ-11773
> URL: https://issues.apache.org/jira/browse/OFBIZ-11773
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
>  Labels: order
> Fix For: Upcoming Branch
>
> Attachments: Error.png
>
>
> Steps to regenerate:
>  # Login into catalog app
>  # Create a new Group Order
>  # Try to delete the group order
>  # An exception is shown on the screen
> See attached screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11697) 'New Employment' widget(s) allows party-groups to be selects as the employee

2020-07-04 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11697.
---
Resolution: Implemented

> 'New Employment' widget(s) allows party-groups to be selects as the employee
> 
>
> Key: OFBIZ-11697
> URL: https://issues.apache.org/jira/browse/OFBIZ-11697
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
>  Labels: employment
> Fix For: Upcoming Branch
>
> Attachments: image-2020-05-13-13-21-57-713.png
>
>
> See image. This should only be possible for parties with partytypeId="PERSON" 
> and roleTypeID="EMPLOYEE"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (OFBIZ-11697) 'New Employment' widget(s) allows party-groups to be selects as the employee

2020-07-04 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-11697:
-

> 'New Employment' widget(s) allows party-groups to be selects as the employee
> 
>
> Key: OFBIZ-11697
> URL: https://issues.apache.org/jira/browse/OFBIZ-11697
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
>  Labels: employment
> Fix For: Upcoming Branch
>
> Attachments: image-2020-05-13-13-21-57-713.png
>
>
> See image. This should only be possible for parties with partytypeId="PERSON" 
> and roleTypeID="EMPLOYEE"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11697) 'New Employment' widget(s) allows party-groups to be selects as the employee

2020-07-04 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151414#comment-17151414
 ] 

Jacques Le Roux commented on OFBIZ-11697:
-

It's disputable that it's only an improvement but I second Pawan here

> 'New Employment' widget(s) allows party-groups to be selects as the employee
> 
>
> Key: OFBIZ-11697
> URL: https://issues.apache.org/jira/browse/OFBIZ-11697
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
>  Labels: employment
> Fix For: Upcoming Branch
>
> Attachments: image-2020-05-13-13-21-57-713.png
>
>
> See image. This should only be possible for parties with partytypeId="PERSON" 
> and roleTypeID="EMPLOYEE"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11773) Unable to delete Group Order

2020-07-04 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151413#comment-17151413
 ] 

Jacques Le Roux commented on OFBIZ-11773:
-

Hi Pawan,

You wrote
{quote}At 
[0da10ea|https://github.com/apache/ofbiz-framework/commit/0da10ea897ae0b9fc9654c8faedc6f435ec21c26],
 We converted deleteProductGroupOrder service from XML to Groovy,
{quote}
But is that not rather related to OFBIZ-10231 and specifically 
[e0a26fce|https://github.com/apache/ofbiz-framework/commit/e0a26fce43eec7c84d87c0d5055ff0a87f2af796]?

 

> Unable to delete Group Order
> 
>
> Key: OFBIZ-11773
> URL: https://issues.apache.org/jira/browse/OFBIZ-11773
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
>  Labels: order
> Fix For: Upcoming Branch
>
> Attachments: Error.png
>
>
> Steps to regenerate:
>  # Login into catalog app
>  # Create a new Group Order
>  # Try to delete the group order
>  # An exception is shown on the screen
> See attached screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues

2020-07-04 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151390#comment-17151390
 ] 

Jacques Le Roux commented on OFBIZ-11805:
-

Thanks Suraj,

After applyting both patches I just ran testIntegration, it's OK and that's 
enough for me to vote +1

> Checkstyle formatting issues
> 
>
> Key: OFBIZ-11805
> URL: https://issues.apache.org/jira/browse/OFBIZ-11805
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11805-plugins.patch, OFBIZ-11805.patch
>
>
> As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj]
> It is better to create component level patches for this enhancement.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11697) 'New Employment' widget(s) allows party-groups to be selects as the employee

2020-07-04 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-11697.
---
Fix Version/s: Upcoming Branch
   Resolution: Fixed

As we have implemented a new lookup, I am fixing it in Trunk only.

Thanks, [~lodhiravi] and [~pierresmits]!

> 'New Employment' widget(s) allows party-groups to be selects as the employee
> 
>
> Key: OFBIZ-11697
> URL: https://issues.apache.org/jira/browse/OFBIZ-11697
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
>  Labels: employment
> Fix For: Upcoming Branch
>
> Attachments: image-2020-05-13-13-21-57-713.png
>
>
> See image. This should only be possible for parties with partytypeId="PERSON" 
> and roleTypeID="EMPLOYEE"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11697) 'New Employment' widget(s) allows party-groups to be selects as the employee

2020-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151387#comment-17151387
 ] 

ASF subversion and git services commented on OFBIZ-11697:
-

Commit 32a0cb865e1ae48c8fb909d339c5f0fbad5aec48 in ofbiz-framework's branch 
refs/heads/trunk from lodhiravi
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=32a0cb8 ]

Fixed: Added employee lookup to search/select employee(person) while creating 
new employment. This will also fixed the issue of party groups being selected 
as a employee. (OFBIZ-11697) (#210)



> 'New Employment' widget(s) allows party-groups to be selects as the employee
> 
>
> Key: OFBIZ-11697
> URL: https://issues.apache.org/jira/browse/OFBIZ-11697
> Project: OFBiz
>  Issue Type: Bug
>  Components: humanres
>Affects Versions: 17.12.03, Trunk
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
>  Labels: employment
> Attachments: image-2020-05-13-13-21-57-713.png
>
>
> See image. This should only be possible for parties with partytypeId="PERSON" 
> and roleTypeID="EMPLOYEE"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] verma-pawan merged pull request #210: Fixed: New Employment' widget(s) allows party-groups to be selects as the employee. (OFBIZ-11697)

2020-07-04 Thread GitBox


verma-pawan merged pull request #210:
URL: https://github.com/apache/ofbiz-framework/pull/210


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11789) Implement EntityBatchIterator for large data set queries

2020-07-04 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-11789.
---
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Implement EntityBatchIterator for large data set queries
> 
>
> Key: OFBIZ-11789
> URL: https://issues.apache.org/jira/browse/OFBIZ-11789
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/entity
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Dev Mail Thread: 
> [https://markmail.org/search/EntityBatchIterator+for+large+data+set+queries]
> While working on the large database we have figured out that very large 
> queries consume all memory and crash ofbiz(because queryIterator() doesn't 
> really work, it's no different from queryList())
> The EntityListIterator attempts to use a cursor to iterate over large result 
> sets but in reality most databases do not give us a cursor unless we ask for 
> it in a very specific way, and instead you get back the full result set and 
> potentially consume a large amount of memory.  For example, the MySql details 
> are here (ResultSet section): 
> [https://dev.mysql.com/doc/connector-j/5.1/en/connector-j-reference-implementation-notes.html]
> To work around this we've built the EntityBatchIterator which instead 
> basically just pages through results like you would do on a webpage that uses 
> pagination.  The iterator takes an EntityQuery and when next() is called it 
> grabs the first 500 records and returns the first record, call next again and 
> you get the second record, once you've called next 500 times it runs the 
> query again with an offset and grabs the next 500 and so on until there are 
> no more records.
> The main downsides to this approach are:
> 1. Same as when using limit/offset you want to be sure your results will come 
> back in a consistent order to avoid accidentally skipping some rows and 
> seeing other rows twice.
> 2. Because the results are a combination of many queries rather than a single 
> query, some of the data may change while you are paging through it. i.e. if 
> you were to sort by lastUpdatedTxStamp you may see some rows twice as they 
> are updated by other transactions (this might be a good thing in some cases).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11789) Implement EntityBatchIterator for large data set queries

2020-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151383#comment-17151383
 ] 

ASF subversion and git services commented on OFBIZ-11789:
-

Commit 71ac32c89b29a56cb76952e641e006eb120b5e8b in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=71ac32c ]

Implemented: EntityBatchIterator which pages through large resultsets (500 at a 
time by default) and added support for EntityBatchIterator to EntityQuery via 
'queryBatchIterator'(OFBIZ-11789) (#191)

Modified GenericDao#makeOffsetString to have OFFSET/FETCH style by default
Modified entityengine's mysql and postgres datasources to have LIMIT/OFFSET 
style, rest can work with default OFFSET/FETCH style

Thanks: Scott for the help.

> Implement EntityBatchIterator for large data set queries
> 
>
> Key: OFBIZ-11789
> URL: https://issues.apache.org/jira/browse/OFBIZ-11789
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/entity
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
>
> Dev Mail Thread: 
> [https://markmail.org/search/EntityBatchIterator+for+large+data+set+queries]
> While working on the large database we have figured out that very large 
> queries consume all memory and crash ofbiz(because queryIterator() doesn't 
> really work, it's no different from queryList())
> The EntityListIterator attempts to use a cursor to iterate over large result 
> sets but in reality most databases do not give us a cursor unless we ask for 
> it in a very specific way, and instead you get back the full result set and 
> potentially consume a large amount of memory.  For example, the MySql details 
> are here (ResultSet section): 
> [https://dev.mysql.com/doc/connector-j/5.1/en/connector-j-reference-implementation-notes.html]
> To work around this we've built the EntityBatchIterator which instead 
> basically just pages through results like you would do on a webpage that uses 
> pagination.  The iterator takes an EntityQuery and when next() is called it 
> grabs the first 500 records and returns the first record, call next again and 
> you get the second record, once you've called next 500 times it runs the 
> query again with an offset and grabs the next 500 and so on until there are 
> no more records.
> The main downsides to this approach are:
> 1. Same as when using limit/offset you want to be sure your results will come 
> back in a consistent order to avoid accidentally skipping some rows and 
> seeing other rows twice.
> 2. Because the results are a combination of many queries rather than a single 
> query, some of the data may change while you are paging through it. i.e. if 
> you were to sort by lastUpdatedTxStamp you may see some rows twice as they 
> are updated by other transactions (this might be a good thing in some cases).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] verma-pawan merged pull request #191: Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support for EntityBatchItera

2020-07-04 Thread GitBox


verma-pawan merged pull request #191:
URL: https://github.com/apache/ofbiz-framework/pull/191


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] verma-pawan closed pull request #76: Fixed: EntityQuery queryCount is throwing error with distinct method

2020-07-04 Thread GitBox


verma-pawan closed pull request #76:
URL: https://github.com/apache/ofbiz-framework/pull/76


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11773) Unable to delete Group Order

2020-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151381#comment-17151381
 ] 

ASF subversion and git services commented on OFBIZ-11773:
-

Commit 52983af7c74da685d3ae42db7e5924b8f2260ac6 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=52983af ]

Fixed: Unable to delete Group Order(OFBIZ-11773) (#172)

At 0da10ea897ae0b9fc9654c8faedc6f435ec21c26, We converted 
deleteProductGroupOrder service from XML to Groovy, which generates this issue.
Reimplemented full groovy service to remove releated records.

> Unable to delete Group Order
> 
>
> Key: OFBIZ-11773
> URL: https://issues.apache.org/jira/browse/OFBIZ-11773
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
>  Labels: order
> Attachments: Error.png
>
>
> Steps to regenerate:
>  # Login into catalog app
>  # Create a new Group Order
>  # Try to delete the group order
>  # An exception is shown on the screen
> See attached screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] verma-pawan merged pull request #172: Fixed: Unable to delete Group Order(OFBIZ-11773)

2020-07-04 Thread GitBox


verma-pawan merged pull request #172:
URL: https://github.com/apache/ofbiz-framework/pull/172


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11773) Unable to delete Group Order

2020-07-04 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-11773.
---
Fix Version/s: Upcoming Branch
   Resolution: Fixed

> Unable to delete Group Order
> 
>
> Key: OFBIZ-11773
> URL: https://issues.apache.org/jira/browse/OFBIZ-11773
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Minor
>  Labels: order
> Fix For: Upcoming Branch
>
> Attachments: Error.png
>
>
> Steps to regenerate:
>  # Login into catalog app
>  # Create a new Group Order
>  # Try to delete the group order
>  # An exception is shown on the screen
> See attached screenshot for more details.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11545) Convert disabledTestUpdatePaymentMethodAddress test from XML to Groovy

2020-07-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11545.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

This has been handled in OFBIZ-11535

Thanks, [~rohit.hukkeri]!

> Convert disabledTestUpdatePaymentMethodAddress test from XML to Groovy
> --
>
> Key: OFBIZ-11545
> URL: https://issues.apache.org/jira/browse/OFBIZ-11545
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Convert disabledTestUpdatePaymentMethodAddress test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11544) Convert testGlPostingOnCheckRun test from XML to Groovy

2020-07-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11544.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

This has been handled in OFBIZ-11535

Thanks, [~rohit.hukkeri]!

> Convert testGlPostingOnCheckRun test from XML to Groovy
> ---
>
> Key: OFBIZ-11544
> URL: https://issues.apache.org/jira/browse/OFBIZ-11544
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Convert testGlPostingOnCheckRun test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11543) Convert testGlPostingsOnVoidPayment test from XML to Groovy

2020-07-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11543.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

This has been handled in OFBIZ-11535

Thanks, [~rohit.hukkeri]!

> Convert testGlPostingsOnVoidPayment test from XML to Groovy
> ---
>
> Key: OFBIZ-11543
> URL: https://issues.apache.org/jira/browse/OFBIZ-11543
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Convert testGlPostingsOnVoidPayment test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11542) Convert testSetFinAccountTransStatus test from XML to Groovy

2020-07-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11542.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

This has been handled in OFBIZ-11535

Thanks, [~rohit.hukkeri]!

> Convert testSetFinAccountTransStatus test from XML to Groovy
> 
>
> Key: OFBIZ-11542
> URL: https://issues.apache.org/jira/browse/OFBIZ-11542
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Convert testSetFinAccountTransStatus test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11541) Convert testDepositWithdrawPaymentsInSingleTrans test from XML to Groovy

2020-07-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11541.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

This has been handled in OFBIZ-11535

Thanks, [~rohit.hukkeri]!

> Convert testDepositWithdrawPaymentsInSingleTrans test from XML to Groovy
> 
>
> Key: OFBIZ-11541
> URL: https://issues.apache.org/jira/browse/OFBIZ-11541
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Convert testDepositWithdrawPaymentsInSingleTrans test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11540) Convert testDepositWithdrawPayments test from XML to Groovy

2020-07-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11540.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

This has been handled in OFBIZ-11535

Thanks, [~rohit.hukkeri]!

> Convert testDepositWithdrawPayments test from XML to Groovy
> ---
>
> Key: OFBIZ-11540
> URL: https://issues.apache.org/jira/browse/OFBIZ-11540
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Convert testDepositWithdrawPayments test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11539) Convert testCancelCheckRunPayments test from XML to Groovy

2020-07-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11539.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

This has been handled in OFBIZ-11535

Thanks, [~rohit.hukkeri]!

> Convert testCancelCheckRunPayments test from XML to Groovy
> --
>
> Key: OFBIZ-11539
> URL: https://issues.apache.org/jira/browse/OFBIZ-11539
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Convert testCancelCheckRunPayments test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11538) Convert testCreatePaymentAndPaymentGroupForInvoices test from XML to Groovy

2020-07-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11538.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

This has been handled in OFBIZ-11535

Thanks, [~rohit.hukkeri]!

> Convert testCreatePaymentAndPaymentGroupForInvoices test from XML to Groovy
> ---
>
> Key: OFBIZ-11538
> URL: https://issues.apache.org/jira/browse/OFBIZ-11538
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Convert testCreatePaymentAndPaymentGroupForInvoices test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11537) Convert testCancelInvoice test from XML to Groovy

2020-07-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11537.
--
Fix Version/s: (was: Trunk)
   Upcoming Branch
   Resolution: Implemented

This has been handled in OFBIZ-11535

Thanks, [~rohit.hukkeri] for report and [~praveen.sharma332] for patch.

> Convert testCancelInvoice test from XML to Groovy
> -
>
> Key: OFBIZ-11537
> URL: https://issues.apache.org/jira/browse/OFBIZ-11537
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11537.patch
>
>
> Convert testCancelInvoice test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11536) Convert testVoidPayment test from XML to Groovy

2020-07-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11536.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

This has been handled in OFBIZ-11535

Thanks, [~rohit.hukkeri]!

> Convert testVoidPayment test from XML to Groovy
> ---
>
> Key: OFBIZ-11536
> URL: https://issues.apache.org/jira/browse/OFBIZ-11536
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Convert testVoidPayment test from XML to Groovy



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11535) Convert AutoPaymentTests.xml to Groovy

2020-07-04 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain closed OFBIZ-11535.
--
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Convert AutoPaymentTests.xml to Groovy
> --
>
> Key: OFBIZ-11535
> URL: https://issues.apache.org/jira/browse/OFBIZ-11535
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11535.patch
>
>
> Convert AutoPaymentTests XML file to Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11535) Convert AutoPaymentTests.xml to Groovy

2020-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151296#comment-17151296
 ] 

ASF subversion and git services commented on OFBIZ-11535:
-

Commit f3997f1feb085c0f18b9a7aeb671f6f82ebc3637 in ofbiz-framework's branch 
refs/heads/trunk from Akash Jain
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f3997f1 ]

Improved: Convert AutoPaymentTests.xml to Groovy (OFBIZ-11535)

Thanks, Rohit Hukkeri for report and Pawan Verma for review.


> Convert AutoPaymentTests.xml to Groovy
> --
>
> Key: OFBIZ-11535
> URL: https://issues.apache.org/jira/browse/OFBIZ-11535
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Rohit Hukkeri
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-11535.patch
>
>
> Convert AutoPaymentTests XML file to Groovy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11382) Convert getContentAndDataResource service from mini-lang to groovy DSL

2020-07-04 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151280#comment-17151280
 ] 

Jacques Le Roux commented on OFBIZ-11382:
-

Ah, indeed, right!

> Convert getContentAndDataResource service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11382
> URL: https://issues.apache.org/jira/browse/OFBIZ-11382
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11382_Trunk.patch
>
>
> Convert getContentAndDataResource service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11805) Checkstyle formatting issues

2020-07-04 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151277#comment-17151277
 ] 

Suraj Khurana commented on OFBIZ-11805:
---

Hello team,

Added initial patch which fixes all "if is not followed by whitespace." 
checkstyle errors. Also I have fixed some ", is not followed by whitespace." 
errors. This was a simple but cautious find/replace from IDE.

This patch fixed more than 250 issues.

> Checkstyle formatting issues
> 
>
> Key: OFBIZ-11805
> URL: https://issues.apache.org/jira/browse/OFBIZ-11805
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11805-plugins.patch, OFBIZ-11805.patch
>
>
> As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj]
> It is better to create component level patches for this enhancement.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11805) Checkstyle formatting issues

2020-07-04 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-11805:
--
Attachment: OFBIZ-11805.patch
OFBIZ-11805-plugins.patch

> Checkstyle formatting issues
> 
>
> Key: OFBIZ-11805
> URL: https://issues.apache.org/jira/browse/OFBIZ-11805
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11805-plugins.patch, OFBIZ-11805.patch
>
>
> As per discussion over dev ML, [https://markmail.org/message/cyagukb7emaxrhbj]
> It is better to create component level patches for this enhancement.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11382) Convert getContentAndDataResource service from mini-lang to groovy DSL

2020-07-04 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151274#comment-17151274
 ] 

Suraj Khurana commented on OFBIZ-11382:
---

Hi Jacques,

I mean we can deprecate it, there is nothing new in getPublicForumMessage 
service it is just calling getContentAndDataResource, its occurence can be 
changed with getContentAndDataResource instead.

> Convert getContentAndDataResource service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11382
> URL: https://issues.apache.org/jira/browse/OFBIZ-11382
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11382_Trunk.patch
>
>
> Convert getContentAndDataResource service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11382) Convert getContentAndDataResource service from mini-lang to groovy DSL

2020-07-04 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151271#comment-17151271
 ] 

Jacques Le Roux commented on OFBIZ-11382:
-

Hi Suraj,

Why to remove getPublicForumMessage? It used once in ecommerce 
"responseTreeLine" screen that is also used in other places.

> Convert getContentAndDataResource service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11382
> URL: https://issues.apache.org/jira/browse/OFBIZ-11382
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11382_Trunk.patch
>
>
> Convert getContentAndDataResource service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11312) DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks

2020-07-04 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11312:

Fix Version/s: 17.12.04

> DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to 
> connection-locks
> --
>
> Key: OFBIZ-11312
> URL: https://issues.apache.org/jira/browse/OFBIZ-11312
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.01, 17.12.04
>
> Attachments: OFBIZ-11312_getColumnInfo_connection_locks_001.patch
>
>
> The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using 
> a  List> object. This does not work properly 
> as it runs into connection-locks. When debugging the error does not occur. I 
> assume that the slower pace of debugging prevents the error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11312) DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks

2020-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151268#comment-17151268
 ] 

ASF subversion and git services commented on OFBIZ-11312:
-

Commit 6622277585bff8dbb65067028d2c01a0ac8b30f3 in ofbiz-framework's branch 
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6622277 ]

Fixed: DatabaseUtil::getColumnInfo does not retrieve PK due to connection-locks 
(OFBIZ-11312)

I wrongly removed a line when backporting by hand


> DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to 
> connection-locks
> --
>
> Key: OFBIZ-11312
> URL: https://issues.apache.org/jira/browse/OFBIZ-11312
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.01
>
> Attachments: OFBIZ-11312_getColumnInfo_connection_locks_001.patch
>
>
> The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using 
> a  List> object. This does not work properly 
> as it runs into connection-locks. When debugging the error does not occur. I 
> assume that the slower pace of debugging prevents the error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11391) Convert deleteContentKeywords service from mini-lang to groovy DSL

2020-07-04 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11391.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Convert deleteContentKeywords service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11391
> URL: https://issues.apache.org/jira/browse/OFBIZ-11391
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11391.patch
>
>
> Convert deleteContentKeywords service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11391) Convert deleteContentKeywords service from mini-lang to groovy DSL

2020-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151264#comment-17151264
 ] 

ASF subversion and git services commented on OFBIZ-11391:
-

Commit ad586a1c14771118e1db8dd800cb99eaf8b946d4 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ad586a1 ]

Improved: Converted deleteContentKeywords service from mini-lang to groovy DSL.
(OFBIZ-11391)
Thanks Devanshu Vyas for reporting and Yogesh Naroliya for the patch.


> Convert deleteContentKeywords service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11391
> URL: https://issues.apache.org/jira/browse/OFBIZ-11391
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11391.patch
>
>
> Convert deleteContentKeywords service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11391) Convert deleteContentKeywords service from mini-lang to groovy DSL

2020-07-04 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11391:
-

Assignee: Suraj Khurana  (was: Yogesh Naroliya)

> Convert deleteContentKeywords service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11391
> URL: https://issues.apache.org/jira/browse/OFBIZ-11391
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11391.patch
>
>
> Convert deleteContentKeywords service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11380) Convert createCommEventContentAssoc service from mini-lang to groovy DSL

2020-07-04 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151262#comment-17151262
 ] 

Suraj Khurana commented on OFBIZ-11380:
---

Hello folks,

I think this can be easily converted to an entity-auto instead.

> Convert createCommEventContentAssoc service from mini-lang to groovy DSL
> 
>
> Key: OFBIZ-11380
> URL: https://issues.apache.org/jira/browse/OFBIZ-11380
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Rushikesh Mawal
>Priority: Minor
> Attachments: OFBIZ-11380.patch
>
>
> Convert createCommEventContentAssoc service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #148: Improved: Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL (OFBIZ-11485)

2020-07-04 Thread GitBox


sonarcloud[bot] commented on pull request #148:
URL: https://github.com/apache/ofbiz-framework/pull/148#issuecomment-653744469


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=148&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=148&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=148&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=148&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=148&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=148&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=148&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=148&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=148&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=148&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=148&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=148)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=148&metric=new_duplicated_lines_density&view=list)
 [6.5% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=148&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11485) Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL

2020-07-04 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11485.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11485
> URL: https://issues.apache.org/jira/browse/OFBIZ-11485
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Convert the getInvoicePaymentInfoList service code from mini-lang to groovy 
> DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11485) Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL

2020-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151259#comment-17151259
 ] 

ASF subversion and git services commented on OFBIZ-11485:
-

Commit 18b21c1e948f213e82682677a75839ddc0419456 in ofbiz-framework's branch 
refs/heads/trunk from Priya Sharma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=18b21c1 ]

[Improved] Convert getInvoicePaymentInfoList service from mini-lang to groovy 
DSL (#148)

(OFBIZ-11485)

Done following:
- removed the mini-lang implementation of the service
- updated the service definition to point the groovy service
- added the groovy implementation of the service

> Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11485
> URL: https://issues.apache.org/jira/browse/OFBIZ-11485
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
>
> Convert the getInvoicePaymentInfoList service code from mini-lang to groovy 
> DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] surajkhurana merged pull request #148: Improved: Convert getInvoicePaymentInfoList service from mini-lang to groovy DSL (OFBIZ-11485)

2020-07-04 Thread GitBox


surajkhurana merged pull request #148:
URL: https://github.com/apache/ofbiz-framework/pull/148


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11377) Convert createContentFromDataResource service from mini-lang to groovy DSL

2020-07-04 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11377.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> Convert createContentFromDataResource service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11377
> URL: https://issues.apache.org/jira/browse/OFBIZ-11377
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11377.patch
>
>
> Convert createContentFromDataResource service code from mini-lang to groovy 
> DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11377) Convert createContentFromDataResource service from mini-lang to groovy DSL

2020-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151258#comment-17151258
 ] 

ASF subversion and git services commented on OFBIZ-11377:
-

Commit 9223d402042e2ed3c10f139dcbf4709f45da8a87 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9223d40 ]

Improved: Converted createContentFromDataResource service from mini-lang to 
groovy DSL.
(OFBIZ-11377)
Thanks Devanshu Vyas for reporting and Anushi Gupta for the patch.


> Convert createContentFromDataResource service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11377
> URL: https://issues.apache.org/jira/browse/OFBIZ-11377
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11377.patch
>
>
> Convert createContentFromDataResource service code from mini-lang to groovy 
> DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11382) Convert getContentAndDataResource service from mini-lang to groovy DSL

2020-07-04 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11382.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Hello Ravi and Devanshu,

Apart from the patch I also corrected one occurence inside 
getPublicForumMessage service, I think we can remove this service 
(getPublicForumMessage), WDYT ?

> Convert getContentAndDataResource service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11382
> URL: https://issues.apache.org/jira/browse/OFBIZ-11382
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11382_Trunk.patch
>
>
> Convert getContentAndDataResource service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11382) Convert getContentAndDataResource service from mini-lang to groovy DSL

2020-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151253#comment-17151253
 ] 

ASF subversion and git services commented on OFBIZ-11382:
-

Commit 84f82a44d15b6bad38b3d89f3e6dcece7edbb659 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=84f82a4 ]

Improved: Converted getContentAndDataResource service from mini-lang to groovy 
DSL.
(OFBIZ-11382)
Thanks Devanshu Vyas for reporting and Ravi Lodhi for the patch.


> Convert getContentAndDataResource service from mini-lang to groovy DSL
> --
>
> Key: OFBIZ-11382
> URL: https://issues.apache.org/jira/browse/OFBIZ-11382
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-11382_Trunk.patch
>
>
> Convert getContentAndDataResource service code from mini-lang to groovy DSL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11692) Convert checkStatusCustRequest from mini-lang to groovy

2020-07-04 Thread Carsten Schinzer (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Schinzer updated OFBIZ-11692:
-
Description: 
See OFBIZ-9350 for motivation

+Acceptance:+
 * A unit test is defined to test all behaviours of checkStatusCustRequest at 
org.apache.ofbiz.order.test.CustRequestStatusCheckTests
 * The existing (minilang) unit test for updateCustRequest is migrated to a 
groovy or java Unit Test and possibly extended in order to test all behaviours 
of the updateCustRequest service
 * The unit test on 
component://order/groovyScripts/request/CustRequestServices.groovy#checkStatusCustRequest
 passes
 * The unit test on 
component://order/groovyScripts/request/CustRequestServices.groovy#updateCustRequest
 passes
 * The new service implementations are configured in 
component://servicedef/services_request.xml (line130-131)
 * Test Extension in CustRequestPermissionTests is added

  was:
See OFBIZ-9350 for motivation

+Acceptance:+
 * A unit test is defined to test all behaviours of checkStatusCustRequest at 
org.apache.ofbiz.order.test.CustRequestStatusCheckTests
 * The existing (minilang) unit test for updateCustRequest is migrated to a 
groovy or java Unit Test and possibly extended in order to test all behaviours 
of the updateCustRequest service
 * The unit test on 
component://order/groovyScripts/request/CustRequestServices.groovy#checkStatusCustRequest
 passes
 * The unit test on 
component://order/groovyScripts/request/CustRequestServices.groovy#updateCustRequest
 passes
 * The new service implementations are configured in 
component://servicedef/services_request.xml (line130-131)


> Convert checkStatusCustRequest from mini-lang to groovy
> ---
>
> Key: OFBIZ-11692
> URL: https://issues.apache.org/jira/browse/OFBIZ-11692
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Carsten Schinzer
>Priority: Major
>  Labels: refactoring, request
>
> See OFBIZ-9350 for motivation
> +Acceptance:+
>  * A unit test is defined to test all behaviours of checkStatusCustRequest at 
> org.apache.ofbiz.order.test.CustRequestStatusCheckTests
>  * The existing (minilang) unit test for updateCustRequest is migrated to a 
> groovy or java Unit Test and possibly extended in order to test all 
> behaviours of the updateCustRequest service
>  * The unit test on 
> component://order/groovyScripts/request/CustRequestServices.groovy#checkStatusCustRequest
>  passes
>  * The unit test on 
> component://order/groovyScripts/request/CustRequestServices.groovy#updateCustRequest
>  passes
>  * The new service implementations are configured in 
> component://servicedef/services_request.xml (line130-131)
>  * Test Extension in CustRequestPermissionTests is added



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.

2020-07-04 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6993.
--
Fix Version/s: 17.12.04
   Resolution: Fixed

> Cannot find the declaration of element 'web-app' in version 3.0 files.
> --
>
> Key: OFBIZ-6993
> URL: https://issues.apache.org/jira/browse/OFBIZ-6993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 15.12, Trunk
>Reporter: Forrest Rae
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 18.12, 17.12.04, 17.12.01
>
> Attachments: 
> 0001-Fixed-when-it-comes-to-web.xml-we-should-rely-solely.patch, web-app.patch
>
>
> Been seeing the error below in the logs.  Strangely, I've not been able to 
> catch the exception in a debugger, but was able to isolate it to the 
> definition of the web-app with version 3.0.  The error disapears when you 
> change the definition from 
> {code:xml}
> 
> {code}
> to this:
> {code:xml}
>   xmlns="http://java.sun.com/xml/ns/javaee";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";>
> {code}
> I only tested on 15.12 and Trunk, but it probably affects any release running 
> Tomcat 7.0.48 or higher.  Here is the error:
> {noformat}
>  [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester 
> error
>  [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot 
> find the declaration of element 'web-app'.
>  [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24; 
> cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
>  [java]   at 
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown 
> Source)
>  [java]   at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
>  [java]   at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
>  [java]   at 
> org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
>  [java]   at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  [java]   at java.lang.reflect.Method.invoke(Method.java:498)
>  [java]   at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
>  [java]   at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
>  [java]   at freemarker.core.MethodCall._eval(MethodCall.java:62)
>  [java]   at freemarker.core.Expression.eval(Expression.java:78)
>  [java]   at freemarker.core.Assignment.accept(Assignment.java:70)
>  [java]   at freemarker.core.Environment.visit(Environment.java:312)
>  [java]   at freemarker.core.MixedContent.accept(MixedContent.java:62)
>  [java]   at 
> freemarker.core.Environment.visitByHiddingParent(Environment.java:333)
>  [java]   at 
> freemarker.core.IteratorBlock$Context.runLoop(IteratorBlock.

[jira] [Updated] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.

2020-07-04 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6993:
---
Fix Version/s: (was: Release Branch 18.12)
   18.12.01

> Cannot find the declaration of element 'web-app' in version 3.0 files.
> --
>
> Key: OFBIZ-6993
> URL: https://issues.apache.org/jira/browse/OFBIZ-6993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 15.12, Trunk
>Reporter: Forrest Rae
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.01, 17.12.04
>
> Attachments: 
> 0001-Fixed-when-it-comes-to-web.xml-we-should-rely-solely.patch, web-app.patch
>
>
> Been seeing the error below in the logs.  Strangely, I've not been able to 
> catch the exception in a debugger, but was able to isolate it to the 
> definition of the web-app with version 3.0.  The error disapears when you 
> change the definition from 
> {code:xml}
> 
> {code}
> to this:
> {code:xml}
>   xmlns="http://java.sun.com/xml/ns/javaee";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";>
> {code}
> I only tested on 15.12 and Trunk, but it probably affects any release running 
> Tomcat 7.0.48 or higher.  Here is the error:
> {noformat}
>  [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester 
> error
>  [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot 
> find the declaration of element 'web-app'.
>  [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24; 
> cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
>  [java]   at 
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown 
> Source)
>  [java]   at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
>  [java]   at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
>  [java]   at 
> org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
>  [java]   at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  [java]   at java.lang.reflect.Method.invoke(Method.java:498)
>  [java]   at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
>  [java]   at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
>  [java]   at freemarker.core.MethodCall._eval(MethodCall.java:62)
>  [java]   at freemarker.core.Expression.eval(Expression.java:78)
>  [java]   at freemarker.core.Assignment.accept(Assignment.java:70)
>  [java]   at freemarker.core.Environment.visit(Environment.java:312)
>  [java]   at freemarker.core.MixedContent.accept(MixedContent.java:62)
>  [java]   at 
> freemarker.core.Environment.visitByHiddingParent(Environment.java:333)
>  [java]   at 
> freemarker.core.IteratorBlock$Context.runLoo

[jira] [Commented] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.

2020-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151237#comment-17151237
 ] 

ASF subversion and git services commented on OFBIZ-6993:


Commit 4b8ee87aefe92c179705fe91afdc29b39242b437 in ofbiz-framework's branch 
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4b8ee87 ]

Improved: Cannot find the declaration of element 'web-app' in version 3.0 
files. (OFBIZ-6993)

I missed to backport changes web.xml (was OK in plugins)


> Cannot find the declaration of element 'web-app' in version 3.0 files.
> --
>
> Key: OFBIZ-6993
> URL: https://issues.apache.org/jira/browse/OFBIZ-6993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 15.12, Trunk
>Reporter: Forrest Rae
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 18.12, 17.12.01
>
> Attachments: 
> 0001-Fixed-when-it-comes-to-web.xml-we-should-rely-solely.patch, web-app.patch
>
>
> Been seeing the error below in the logs.  Strangely, I've not been able to 
> catch the exception in a debugger, but was able to isolate it to the 
> definition of the web-app with version 3.0.  The error disapears when you 
> change the definition from 
> {code:xml}
> 
> {code}
> to this:
> {code:xml}
>   xmlns="http://java.sun.com/xml/ns/javaee";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";>
> {code}
> I only tested on 15.12 and Trunk, but it probably affects any release running 
> Tomcat 7.0.48 or higher.  Here is the error:
> {noformat}
>  [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester 
> error
>  [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot 
> find the declaration of element 'web-app'.
>  [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24; 
> cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
>  [java]   at 
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown 
> Source)
>  [java]   at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
>  [java]   at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
>  [java]   at 
> org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
>  [java]   at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  [java]   at java.lang.reflect.Method.invoke(Method.java:498)
>  [java]   at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
>  [java]   at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
>  [java]   at freemarker.core.MethodCall._eval(MethodCall.java:62)
>  [java]   at freemarker.core.Expression.eval(Expression.java:78)
>  [java]   at fre

[jira] [Reopened] (OFBIZ-6993) Cannot find the declaration of element 'web-app' in version 3.0 files.

2020-07-04 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-6993:

  Assignee: Jacques Le Roux  (was: Mathieu Lirzin)

I reopen, I missed to backport some changes in R17

> Cannot find the declaration of element 'web-app' in version 3.0 files.
> --
>
> Key: OFBIZ-6993
> URL: https://issues.apache.org/jira/browse/OFBIZ-6993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 15.12, Trunk
>Reporter: Forrest Rae
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Release Branch 18.12, 17.12.01
>
> Attachments: 
> 0001-Fixed-when-it-comes-to-web.xml-we-should-rely-solely.patch, web-app.patch
>
>
> Been seeing the error below in the logs.  Strangely, I've not been able to 
> catch the exception in a debugger, but was able to isolate it to the 
> definition of the web-app with version 3.0.  The error disapears when you 
> change the definition from 
> {code:xml}
> 
> {code}
> to this:
> {code:xml}
>   xmlns="http://java.sun.com/xml/ns/javaee";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://java.sun.com/xml/ns/javaee 
> http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd";>
> {code}
> I only tested on 15.12 and Trunk, but it probably affects any release running 
> Tomcat 7.0.48 or higher.  Here is the error:
> {noformat}
>  [java] Apr 07, 2016 4:06:29 PM org.apache.tomcat.util.digester.Digester 
> error
>  [java] SEVERE: Parse Error at line 22 column 24: cvc-elt.1.a: Cannot 
> find the declaration of element 'web-app'.
>  [java] org.xml.sax.SAXParseException; lineNumber: 22; columnNumber: 24; 
> cvc-elt.1.a: Cannot find the declaration of element 'web-app'.
>  [java]   at 
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown 
> Source)
>  [java]   at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.handleStartElement(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.impl.xs.XMLSchemaValidator.startElement(Unknown Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElementAfterName(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLNSDocumentScannerImpl$NSContentDispatcher.scanRootElementHook(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown
>  Source)
>  [java]   at 
> org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
> Source)
>  [java]   at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
>  [java]   at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown 
> Source)
>  [java]   at 
> org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
>  [java]   at 
> org.apache.tomcat.util.digester.Digester.parse(Digester.java:1555)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.parseWebXmlFile(WebAppUtil.java:160)
>  [java]   at org.ofbiz.webapp.WebAppUtil.getWebXml(WebAppUtil.java:131)
>  [java]   at 
> org.ofbiz.webapp.WebAppUtil.getControlServletPath(WebAppUtil.java:67)
>  [java]   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  [java]   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  [java]   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  [java]   at java.lang.reflect.Method.invoke(Method.java:498)
>  [java]   at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1458)
>  [java]   at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:71)
>  [java]   at freemarker.core.MethodCall._eval(MethodCall.java:62)
>  [java]   at freemarker.core.Expression.eval(Expression.java:78)
>  [java]   at freemarker.core.Assignment.accept(Assignment.java:70)
>  [java]   at freemarker.core.Environment.visit(Environment.java:312)
>  [java]   at freemarker.core.MixedContent.accept(MixedContent.java:62)
>  [java]   at 
> freemarker.core.Environment.visitByHiddingParent(Environment.java:333)
>  [java]   at 
> freemarker.c