[jira] [Commented] (OFBIZ-11490) Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to groovy DSL
[
https://issues.apache.org/jira/browse/OFBIZ-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164758#comment-17164758
]
Sourabh Punyani commented on OFBIZ-11490:
-
{code:xml}
{code}
> Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to
> groovy DSL
>
>
> Key: OFBIZ-11490
> URL: https://issues.apache.org/jira/browse/OFBIZ-11490
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Sourabh Punyani
>Priority: Minor
>
> Convert the createPaymentAndPaymentGroupForInvoices service code from
> mini-lang to groovy DSL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Issue Comment Deleted] (OFBIZ-11490) Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to groovy DSL
[
https://issues.apache.org/jira/browse/OFBIZ-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sourabh Punyani updated OFBIZ-11490:
Comment: was deleted
(was:
{code:xml}
{code}
)
> Convert createPaymentAndPaymentGroupForInvoices service from mini-lang to
> groovy DSL
>
>
> Key: OFBIZ-11490
> URL: https://issues.apache.org/jira/browse/OFBIZ-11490
> Project: OFBiz
> Issue Type: Sub-task
> Components: accounting
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Sourabh Punyani
>Priority: Minor
>
> Convert the createPaymentAndPaymentGroupForInvoices service code from
> mini-lang to groovy DSL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11912) Shipment is not created during receiving
Yashwant Dhakad created OFBIZ-11912: --- Summary: Shipment is not created during receiving Key: OFBIZ-11912 URL: https://issues.apache.org/jira/browse/OFBIZ-11912 Project: OFBiz Issue Type: Bug Components: hhfacility Affects Versions: Trunk Reporter: Yashwant Dhakad Purchase shipment is not created during receiving. In demo-stable it is working fine so it breaks in the trunk. Here are the steps to regenerate: # Create the Purchase Order. # Approve the Purchase Order. # Click on the Receive button in Action section on the order view screen. # The user navigated to receive screen and getting error. Expected result: User navigated to receive screen and Purchase shipment should be visible on the Receive screen. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11912) Shipment is not created during receiving
[ https://issues.apache.org/jira/browse/OFBIZ-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yashwant Dhakad reassigned OFBIZ-11912: --- Assignee: Yashwant Dhakad > Shipment is not created during receiving > > > Key: OFBIZ-11912 > URL: https://issues.apache.org/jira/browse/OFBIZ-11912 > Project: OFBiz > Issue Type: Bug > Components: hhfacility >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Yashwant Dhakad >Priority: Minor > > Purchase shipment is not created during receiving. In demo-stable it is > working fine so it breaks in the trunk. > Here are the steps to regenerate: > # Create the Purchase Order. > # Approve the Purchase Order. > # Click on the Receive button in Action section on the order view screen. > # The user navigated to receive screen and getting error. > Expected result: User navigated to receive screen and Purchase shipment > should be visible on the Receive screen. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) Rename a few map files
[
https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164756#comment-17164756
]
Aditya Sharma commented on OFBIZ-11882:
---
Thanks Jacques! Sounds promising.
{quote}I have notably found that I can't view jQuery source
{quote}
We will get source map URL in most of the libraries except jQuery, we will have
to manually add it
[https://github.com/jquery/jquery/issues/4166]
> Rename a few map files
> --
>
> Key: OFBIZ-11882
> URL: https://issues.apache.org/jira/browse/OFBIZ-11882
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.01, 17.12.05
>
> Attachments: ecommerce-js.patch, ecommerce-js2.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> tells a few files to be renamed, to suppress warnings in the browser console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11911) Error in Quick Receive Purchase Order process
Ravi Lodhi created OFBIZ-11911: -- Summary: Error in Quick Receive Purchase Order process Key: OFBIZ-11911 URL: https://issues.apache.org/jira/browse/OFBIZ-11911 Project: OFBiz Issue Type: Bug Components: order, product/facility Affects Versions: Trunk Reporter: Ravi Lodhi Assignee: Ravi Lodhi Quick Receive Purchase Order is not working. Steps to regenerate- # Create a PO by visiting [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry] if there is no PO available to receive. # Approve the PO. Now Quick Receive Purchase Order button appears. # Click on that button. Error appears. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11487) Convert voidPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164746#comment-17164746 ] Sourabh Punyani commented on OFBIZ-11487: - Hello Jacques, Thanks for reviewing the patch. The userLogin was added by mistake. I have updated the patch. Please verify. > Convert voidPayment service from mini-lang to groovy DSL > > > Key: OFBIZ-11487 > URL: https://issues.apache.org/jira/browse/OFBIZ-11487 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11487.patch > > > Convert the voidPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11487) Convert voidPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Punyani updated OFBIZ-11487: Attachment: OFBIZ-11487.patch > Convert voidPayment service from mini-lang to groovy DSL > > > Key: OFBIZ-11487 > URL: https://issues.apache.org/jira/browse/OFBIZ-11487 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11487.patch > > > Convert the voidPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11487) Convert voidPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Punyani updated OFBIZ-11487: Attachment: (was: OFBIZ-11487.patch) > Convert voidPayment service from mini-lang to groovy DSL > > > Key: OFBIZ-11487 > URL: https://issues.apache.org/jira/browse/OFBIZ-11487 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11487.patch > > > Convert the voidPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11487) Convert voidPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Punyani updated OFBIZ-11487: Attachment: OFBIZ-11487.patch > Convert voidPayment service from mini-lang to groovy DSL > > > Key: OFBIZ-11487 > URL: https://issues.apache.org/jira/browse/OFBIZ-11487 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11487.patch > > > Convert the voidPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11487) Convert voidPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sourabh Punyani updated OFBIZ-11487: Attachment: (was: OFBIZ-11487.patch) > Convert voidPayment service from mini-lang to groovy DSL > > > Key: OFBIZ-11487 > URL: https://issues.apache.org/jira/browse/OFBIZ-11487 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11487.patch > > > Convert the voidPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11909) Error while receiving the purchase order
[ https://issues.apache.org/jira/browse/OFBIZ-11909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164744#comment-17164744 ] Ravi Lodhi edited comment on OFBIZ-11909 at 7/25/20, 4:47 AM: -- While working on this ticket two issues are found- # ClassCastException due to GString to String conversion. # After resolving the first one found another issue where the product is getting received two times on a single receive. Whether using Product Receiving or PO receiving. It seems these issues were introduced while converting receiveInventoryProduct service from minilang(xml) to DSL groovy. Fixed the issue in the PR - [https://github.com/apache/ofbiz-framework/pull/218] Thanks! was (Author: lodhiravi): While working on this ticket two issues are found- # ClassCastException due to GString to String conversion. # After resolving the first one found another issue where the product is getting received two times on a single receive. Whether using Product Receiving or PO receiving. These issues were introduced while converting receiveInventoryProduct service from minilang(xml) to DSL groovy. Fixed the issue in the PR - [https://github.com/apache/ofbiz-framework/pull/218] Thanks! > Error while receiving the purchase order > > > Key: OFBIZ-11909 > URL: https://issues.apache.org/jira/browse/OFBIZ-11909 > Project: OFBiz > Issue Type: Bug > Components: product/facility >Affects Versions: Trunk >Reporter: Ravi Lodhi >Priority: Major > Attachments: ReceivePOError.png > > > Steps to regenerate - > 1. Log on to Facility application > (https://demo-trunk.ofbiz.apache.org/facility/control/main). > 2. Select the facility (I used Web Store Warehouse the default one) and > submit. > 3. Now from this Edit Facility page click on the Receive Inventory button > from the top button bar. > 4. Select Purchase Order Number(You can create one purchase order if there is > no PO to receive) and click on Receive Product(s) button. > 5. Select the radio button to receive the entire PO and click on the Receive > Selected Shipment button. > 6. By default, all the products of the PO come selected with the required > detail to receive. So no need to alter anything. Now click on Receive > Selected Product(s) button. > 7. The error message should appear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11909) Error while receiving the purchase order
[ https://issues.apache.org/jira/browse/OFBIZ-11909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi reassigned OFBIZ-11909: -- Assignee: (was: Ravi Lodhi) > Error while receiving the purchase order > > > Key: OFBIZ-11909 > URL: https://issues.apache.org/jira/browse/OFBIZ-11909 > Project: OFBiz > Issue Type: Bug > Components: product/facility >Affects Versions: Trunk >Reporter: Ravi Lodhi >Priority: Major > Attachments: ReceivePOError.png > > > Steps to regenerate - > 1. Log on to Facility application > (https://demo-trunk.ofbiz.apache.org/facility/control/main). > 2. Select the facility (I used Web Store Warehouse the default one) and > submit. > 3. Now from this Edit Facility page click on the Receive Inventory button > from the top button bar. > 4. Select Purchase Order Number(You can create one purchase order if there is > no PO to receive) and click on Receive Product(s) button. > 5. Select the radio button to receive the entire PO and click on the Receive > Selected Shipment button. > 6. By default, all the products of the PO come selected with the required > detail to receive. So no need to alter anything. Now click on Receive > Selected Product(s) button. > 7. The error message should appear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11909) Error while receiving the purchase order
[ https://issues.apache.org/jira/browse/OFBIZ-11909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164744#comment-17164744 ] Ravi Lodhi commented on OFBIZ-11909: While working on this ticket two issues are found- # ClassCastException due to GString to String conversion. # After resolving the first one found another issue where the product is getting received two times on a single receive. Whether using Product Receiving or PO receiving. These issues were introduced while converting receiveInventoryProduct service from minilang(xml) to DSL groovy. Fixed the issue in the PR - [https://github.com/apache/ofbiz-framework/pull/218] Thanks! > Error while receiving the purchase order > > > Key: OFBIZ-11909 > URL: https://issues.apache.org/jira/browse/OFBIZ-11909 > Project: OFBiz > Issue Type: Bug > Components: product/facility >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi >Priority: Major > Attachments: ReceivePOError.png > > > Steps to regenerate - > 1. Log on to Facility application > (https://demo-trunk.ofbiz.apache.org/facility/control/main). > 2. Select the facility (I used Web Store Warehouse the default one) and > submit. > 3. Now from this Edit Facility page click on the Receive Inventory button > from the top button bar. > 4. Select Purchase Order Number(You can create one purchase order if there is > no PO to receive) and click on Receive Product(s) button. > 5. Select the radio button to receive the entire PO and click on the Receive > Selected Shipment button. > 6. By default, all the products of the PO come selected with the required > detail to receive. So no need to alter anything. Now click on Receive > Selected Product(s) button. > 7. The error message should appear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #218: Fixed: Error while receiving the purchase order (OFBIZ-11909)
sonarcloud[bot] commented on pull request #218: URL: https://github.com/apache/ofbiz-framework/pull/218#issuecomment-663808209 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=218=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=218=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=218=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=218=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=218=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=218=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=218=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_ofbiz-framework=218=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=218=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=218=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=218=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=218) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=218=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=218=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] lodhiravi opened a new pull request #218: Fixed: Error while receiving the purchase order (OFBIZ-11909)
lodhiravi opened a new pull request #218: URL: https://github.com/apache/ofbiz-framework/pull/218 Done following- 1. Converted GString to String while setting the success message in receiveInventoryProduct service to avoid the ClassCastException. 2. Also corrected loop condition while creating inventory information during PO receiving to fix the issue where each product is getting received two times (doubled the qty) instead of a single time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-11909) Error while receiving the purchase order
[ https://issues.apache.org/jira/browse/OFBIZ-11909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-11909: --- Issue Type: Bug (was: Task) > Error while receiving the purchase order > > > Key: OFBIZ-11909 > URL: https://issues.apache.org/jira/browse/OFBIZ-11909 > Project: OFBiz > Issue Type: Bug > Components: product/facility >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi >Priority: Major > Attachments: ReceivePOError.png > > > Steps to regenerate - > 1. Log on to Facility application > (https://demo-trunk.ofbiz.apache.org/facility/control/main). > 2. Select the facility (I used Web Store Warehouse the default one) and > submit. > 3. Now from this Edit Facility page click on the Receive Inventory button > from the top button bar. > 4. Select Purchase Order Number(You can create one purchase order if there is > no PO to receive) and click on Receive Product(s) button. > 5. Select the radio button to receive the entire PO and click on the Receive > Selected Shipment button. > 6. By default, all the products of the PO come selected with the required > detail to receive. So no need to alter anything. Now click on Receive > Selected Product(s) button. > 7. The error message should appear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) Rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164458#comment-17164458 ] Jacques Le Roux commented on OFBIZ-11882: - I had a look at the tools for creating maps and minifying. It's all about js and I don't like it much. I want a clean easy solution: a Gradle task :) Despite being kinda abandoned https://github.com/eriwen/gradle-js-plugin is still the best solution for us. Trunk currently uses Gradle 6.3. So we need to find a fork which supports that or need to create our own fork. https://github.com/twwwt/gradle-js-plugin which claims to handle 6.1.1 could be a good start if we don't find better. I came to this conclusion after my last comment at OFBIZ-11882: bq. Sure we should have source maps for CSS files too, even in production: https://css-tricks.com/should-i-use-source-maps-in-production/ I wrote but did not publish this few days ago. In the meantime I have created my own plugin based on eriwen's and modified following twwwt's. I'll publish it soon, will close here and will see what I can get from it. I have notably found that I can't view jQuery source. I never missed that, but if the plugin works as expected we would have all the necessary maps. > Rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Improvement > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: 18.12.01, 17.12.05 > > Attachments: ecommerce-js.patch, ecommerce-js2.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11909) Error while receiving the purchase order
[ https://issues.apache.org/jira/browse/OFBIZ-11909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-11909: --- Environment: (was: Steps to regenerate - 1. Log on to Facility application (https://demo-trunk.ofbiz.apache.org/facility/control/main). 2. Select the facility (I used Web Store Warehouse the default one) and submit. 3. Now from this Edit Facility page click on the Receive Inventory button from the top button bar. 4. Select Purchase Order Number(You can create one purchase order if there is no PO to receive) and click on Receive Product(s) button. 5. Select the radio button to receive the entire PO and click on the Receive Selected Shipment button. 6. By default, all the products of the PO come selected with the required detail to receive. So no need to alter anything. Now click on Receive Selected Product(s) button. 7. The error message should appear.) > Error while receiving the purchase order > > > Key: OFBIZ-11909 > URL: https://issues.apache.org/jira/browse/OFBIZ-11909 > Project: OFBiz > Issue Type: Task > Components: product/facility >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi >Priority: Major > Attachments: ReceivePOError.png > > > Steps to regenerate - > 1. Log on to Facility application > (https://demo-trunk.ofbiz.apache.org/facility/control/main). > 2. Select the facility (I used Web Store Warehouse the default one) and > submit. > 3. Now from this Edit Facility page click on the Receive Inventory button > from the top button bar. > 4. Select Purchase Order Number(You can create one purchase order if there is > no PO to receive) and click on Receive Product(s) button. > 5. Select the radio button to receive the entire PO and click on the Receive > Selected Shipment button. > 6. By default, all the products of the PO come selected with the required > detail to receive. So no need to alter anything. Now click on Receive > Selected Product(s) button. > 7. The error message should appear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11909) Error while receiving the purchase order
[ https://issues.apache.org/jira/browse/OFBIZ-11909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-11909: --- Description: Steps to regenerate - 1. Log on to Facility application (https://demo-trunk.ofbiz.apache.org/facility/control/main). 2. Select the facility (I used Web Store Warehouse the default one) and submit. 3. Now from this Edit Facility page click on the Receive Inventory button from the top button bar. 4. Select Purchase Order Number(You can create one purchase order if there is no PO to receive) and click on Receive Product(s) button. 5. Select the radio button to receive the entire PO and click on the Receive Selected Shipment button. 6. By default, all the products of the PO come selected with the required detail to receive. So no need to alter anything. Now click on Receive Selected Product(s) button. 7. The error message should appear. > Error while receiving the purchase order > > > Key: OFBIZ-11909 > URL: https://issues.apache.org/jira/browse/OFBIZ-11909 > Project: OFBiz > Issue Type: Task > Components: product/facility >Affects Versions: Trunk > Environment: Steps to regenerate - > 1. Log on to Facility application > (https://demo-trunk.ofbiz.apache.org/facility/control/main). > 2. Select the facility (I used Web Store Warehouse the default one) and > submit. > 3. Now from this Edit Facility page click on the Receive Inventory button > from the top button bar. > 4. Select Purchase Order Number(You can create one purchase order if there is > no PO to receive) and click on Receive Product(s) button. > 5. Select the radio button to receive the entire PO and click on the Receive > Selected Shipment button. > 6. By default, all the products of the PO come selected with the required > detail to receive. So no need to alter anything. Now click on Receive > Selected Product(s) button. > 7. The error message should appear. >Reporter: Ravi Lodhi >Assignee: Ravi Lodhi >Priority: Major > Attachments: ReceivePOError.png > > > Steps to regenerate - > 1. Log on to Facility application > (https://demo-trunk.ofbiz.apache.org/facility/control/main). > 2. Select the facility (I used Web Store Warehouse the default one) and > submit. > 3. Now from this Edit Facility page click on the Receive Inventory button > from the top button bar. > 4. Select Purchase Order Number(You can create one purchase order if there is > no PO to receive) and click on Receive Product(s) button. > 5. Select the radio button to receive the entire PO and click on the Receive > Selected Shipment button. > 6. By default, all the products of the PO come selected with the required > detail to receive. So no need to alter anything. Now click on Receive > Selected Product(s) button. > 7. The error message should appear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11905) associated products should show in rows
[ https://issues.apache.org/jira/browse/OFBIZ-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-11905: - Assignee: Aditya Sharma > associated products should show in rows > --- > > Key: OFBIZ-11905 > URL: https://issues.apache.org/jira/browse/OFBIZ-11905 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: ProductDetail.ftl.diff, ProductSummary.ftl.diff, Screen > Shot changed.png, Screen Shot original.png > > > list of associated products is broken by the subtitle. > solution: passing the subtitle as a highlighted label > to be shown in each listed summary. > screenshots are included. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164367#comment-17164367 ] Aditya Sharma commented on OFBIZ-11906: --- Thanks [~alexbodn]. This has been fixed. > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, Screen Shot change.png, Screen Shot > original.png > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-11906. - Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-11906.patch, Screen Shot change.png, Screen Shot > original.png > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164365#comment-17164365 ] ASF subversion and git services commented on OFBIZ-11906: - Commit 486f1d8a591e46e55047fbeec597e8c0dec501fa in ofbiz-plugins's branch refs/heads/release17.12 from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=486f1d8 ] Fixed: ui for the product summary in promotion product list (OFBIZ-11906) The product summary in the row is too slim, leaving 75% of the place unused. Added CSS that forces to take 100% width Thanks Alex Bodnaru for reporting and providing the patch > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, Screen Shot change.png, Screen Shot > original.png > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164363#comment-17164363 ] ASF subversion and git services commented on OFBIZ-11906: - Commit 64b0f25e34a41887d518135ce7a00816811d8f40 in ofbiz-plugins's branch refs/heads/release18.12 from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=64b0f25 ] Fixed: ui for the product summary in promotion product list (OFBIZ-11906) The product summary in the row is too slim, leaving 75% of the place unused. Added CSS that forces to take 100% width Thanks Alex Bodnaru for reporting and providing the patch > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, Screen Shot change.png, Screen Shot > original.png > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164360#comment-17164360 ] ASF subversion and git services commented on OFBIZ-11906: - Commit cfba1f3fe26309168e998090cdc5de898042ef88 in ofbiz-plugins's branch refs/heads/trunk from Aditya Sharma [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=cfba1f3 ] Fixed: ui for the product summary in promotion product list (OFBIZ-11906) The product summary in the row is too slim, leaving 75% of the place unused. Added CSS that forces to take 100% width Thanks Alex Bodnaru for reporting and providing the patch > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, Screen Shot change.png, Screen Shot > original.png > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11910) product summary cards don't have uniform height
Alex Bodnaru created OFBIZ-11910: Summary: product summary cards don't have uniform height Key: OFBIZ-11910 URL: https://issues.apache.org/jira/browse/OFBIZ-11910 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Trunk, Release Branch 17.12 Reporter: Alex Bodnaru Attachments: Screen Shot changed.png, Screen Shot original.png while several product summaries are in the same row, especially products with different statuses and properties, they are terribly unalligned. i did attach classes to the various elements, most of them static but few of them calculated, so stylable in custom.css. a css artist will highly outperform my css capabilities, but even my idea gives a sensibly uniform result. my diff is a little intermingled, but i would be glad to explain everithing. thanks in advance, alex -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11906: -- Affects Version/s: Release Branch 18.12 > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, Screen Shot change.png, Screen Shot > original.png > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11909) Error while receiving the purchase order
Ravi Lodhi created OFBIZ-11909: -- Summary: Error while receiving the purchase order Key: OFBIZ-11909 URL: https://issues.apache.org/jira/browse/OFBIZ-11909 Project: OFBiz Issue Type: Task Components: product/facility Affects Versions: Trunk Environment: Steps to regenerate - 1. Log on to Facility application (https://demo-trunk.ofbiz.apache.org/facility/control/main). 2. Select the facility (I used Web Store Warehouse the default one) and submit. 3. Now from this Edit Facility page click on the Receive Inventory button from the top button bar. 4. Select Purchase Order Number(You can create one purchase order if there is no PO to receive) and click on Receive Product(s) button. 5. Select the radio button to receive the entire PO and click on the Receive Selected Shipment button. 6. By default, all the products of the PO come selected with the required detail to receive. So no need to alter anything. Now click on Receive Selected Product(s) button. 7. The error message should appear. Reporter: Ravi Lodhi Assignee: Ravi Lodhi Attachments: ReceivePOError.png -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164338#comment-17164338 ] Alex Bodnaru commented on OFBIZ-11906: -- yes your patch is better, thanks [~adityasharma] :) > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, ProductSummary.ftl.diff, > PromotionProducts.ftl.diff, Screen Shot change.png, Screen Shot original.png, > custom.css.diff > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru updated OFBIZ-11906: - Attachment: (was: PromotionProducts.ftl.diff) > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, Screen Shot change.png, Screen Shot > original.png > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru updated OFBIZ-11906: - Attachment: (was: custom.css.diff) > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, Screen Shot change.png, Screen Shot > original.png > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru updated OFBIZ-11906: - Attachment: (was: ProductSummary.ftl.diff) > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, Screen Shot change.png, Screen Shot > original.png > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164331#comment-17164331 ] Alex Bodnaru commented on OFBIZ-11906: -- hello [~adityasharma] thank you for considering my patches. first, i'll appologize since they are a little intermingled, as my hands run forward to try a few things before i began reporting. my previous screenshots were not tall enough to show the problem. please look at the ones i've just uploaded. > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, ProductSummary.ftl.diff, > PromotionProducts.ftl.diff, Screen Shot change.png, Screen Shot original.png, > custom.css.diff > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru updated OFBIZ-11906: - Attachment: Screen Shot original.png Screen Shot change.png > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, ProductSummary.ftl.diff, > PromotionProducts.ftl.diff, Screen Shot change.png, Screen Shot original.png, > custom.css.diff > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru updated OFBIZ-11906: - Attachment: (was: Screen Shot original.png) > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, ProductSummary.ftl.diff, > PromotionProducts.ftl.diff, custom.css.diff > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru updated OFBIZ-11906: - Attachment: (was: Screen Shot change.png) > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, ProductSummary.ftl.diff, > PromotionProducts.ftl.diff, Screen Shot original.png, custom.css.diff > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164326#comment-17164326 ] Aditya Sharma commented on OFBIZ-11906: --- Hi Alex, Instead of adding a class to make the width 100%, I would recommend that we could identify the promotion products card with some class and apply CSS to products-card. Check OFBIZ-11906.patch, it will reduce the additional code written just to add class. WDYT? > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, ProductSummary.ftl.diff, > PromotionProducts.ftl.diff, Screen Shot change.png, Screen Shot original.png, > custom.css.diff > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11906: -- Attachment: OFBIZ-11906.patch > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: OFBIZ-11906.patch, ProductSummary.ftl.diff, > PromotionProducts.ftl.diff, Screen Shot change.png, Screen Shot original.png, > custom.css.diff > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11905) associated products should show in rows
[ https://issues.apache.org/jira/browse/OFBIZ-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164175#comment-17164175 ] Alex Bodnaru commented on OFBIZ-11905: -- ok, I will. > associated products should show in rows > --- > > Key: OFBIZ-11905 > URL: https://issues.apache.org/jira/browse/OFBIZ-11905 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: ProductDetail.ftl.diff, ProductSummary.ftl.diff, Screen > Shot changed.png, Screen Shot original.png > > > list of associated products is broken by the subtitle. > solution: passing the subtitle as a highlighted label > to be shown in each listed summary. > screenshots are included. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11905) associated products should show in rows
[ https://issues.apache.org/jira/browse/OFBIZ-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164170#comment-17164170 ] Aditya Sharma commented on OFBIZ-11905: --- Hi Alex, Thanks for your contribution. It would be good if you could provide a single patch file, instead of individual files diff. > associated products should show in rows > --- > > Key: OFBIZ-11905 > URL: https://issues.apache.org/jira/browse/OFBIZ-11905 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: ProductDetail.ftl.diff, ProductSummary.ftl.diff, Screen > Shot changed.png, Screen Shot original.png > > > list of associated products is broken by the subtitle. > solution: passing the subtitle as a highlighted label > to be shown in each listed summary. > screenshots are included. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11905) associated products should show in rows
[ https://issues.apache.org/jira/browse/OFBIZ-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11905: -- Affects Version/s: Release Branch 18.12 > associated products should show in rows > --- > > Key: OFBIZ-11905 > URL: https://issues.apache.org/jira/browse/OFBIZ-11905 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: ProductDetail.ftl.diff, ProductSummary.ftl.diff, Screen > Shot changed.png, Screen Shot original.png > > > list of associated products is broken by the subtitle. > solution: passing the subtitle as a highlighted label > to be shown in each listed summary. > screenshots are included. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11906) product summary looks bad in the promotion products list
[ https://issues.apache.org/jira/browse/OFBIZ-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-11906: - Assignee: Aditya Sharma > product summary looks bad in the promotion products list > > > Key: OFBIZ-11906 > URL: https://issues.apache.org/jira/browse/OFBIZ-11906 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Aditya Sharma >Priority: Major > Attachments: ProductSummary.ftl.diff, PromotionProducts.ftl.diff, > Screen Shot change.png, Screen Shot original.png, custom.css.diff > > > the product summary in the row is too slim, leaving 75% of the place unused. > solution: adding a class to the product summary card by parameter. > the class i'm adding here is forcing a width of 100% in custom.css. > of course, this class may be used in other scenarios too, and multiple > classes may be separed by space. -- This message was sent by Atlassian Jira (v8.3.4#803005)
