[jira] [Assigned] (OFBIZ-11878) Convert PartyTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Hukkeri reassigned OFBIZ-11878: - Assignee: Rohit Hukkeri (was: Akash Jain) > Convert PartyTests.xml to Groovy > > > Key: OFBIZ-11878 > URL: https://issues.apache.org/jira/browse/OFBIZ-11878 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Rohit Hukkeri >Priority: Minor > > Convert PartyTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10313) Capture Transactions are still displayed as Authorize
[ https://issues.apache.org/jira/browse/OFBIZ-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165437#comment-17165437 ] Deepa Barfa edited comment on OFBIZ-10313 at 7/27/20, 5:15 AM: --- Hello Jacques, Ticket verified, It is working fine. Please close this ticket was (Author: deepa.barfa): Verified, It is working fine. > Capture Transactions are still displayed as Authorize > - > > Key: OFBIZ-10313 > URL: https://issues.apache.org/jira/browse/OFBIZ-10313 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk > Environment: https://demo-trunk.ofbiz.apache.org >Reporter: Aayush jain >Assignee: Deepa Barfa >Priority: Major > > Steps: > 1. Open URL > https://demo-trunk.ofbiz.apache.org/accounting/control/FindGatewayResponses > 2. Navigate to Transactions with Authorize > 3. Try to Capture payment > 4. Again navigate to FindGatewayResponses and check for transaction > Actual Result: > The transaction still displayed with Authorize status and no update on > payment capture > Expected Result: > Correct status of transaction should be displayed (Capture/Authorize) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10313) Capture Transactions are still displayed as Authorize
[ https://issues.apache.org/jira/browse/OFBIZ-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165437#comment-17165437 ] Deepa Barfa edited comment on OFBIZ-10313 at 7/27/20, 5:09 AM: --- Verified, It is working fine. was (Author: deepa.barfa): Verified, It is working fine. Closing this ticket. > Capture Transactions are still displayed as Authorize > - > > Key: OFBIZ-10313 > URL: https://issues.apache.org/jira/browse/OFBIZ-10313 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk > Environment: https://demo-trunk.ofbiz.apache.org >Reporter: Aayush jain >Assignee: Deepa Barfa >Priority: Major > > Steps: > 1. Open URL > https://demo-trunk.ofbiz.apache.org/accounting/control/FindGatewayResponses > 2. Navigate to Transactions with Authorize > 3. Try to Capture payment > 4. Again navigate to FindGatewayResponses and check for transaction > Actual Result: > The transaction still displayed with Authorize status and no update on > payment capture > Expected Result: > Correct status of transaction should be displayed (Capture/Authorize) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10313) Capture Transactions are still displayed as Authorize
[ https://issues.apache.org/jira/browse/OFBIZ-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165437#comment-17165437 ] Deepa Barfa commented on OFBIZ-10313: - Verified, It is working fine. Closing this ticket. > Capture Transactions are still displayed as Authorize > - > > Key: OFBIZ-10313 > URL: https://issues.apache.org/jira/browse/OFBIZ-10313 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk > Environment: https://demo-trunk.ofbiz.apache.org >Reporter: Aayush jain >Assignee: Deepa Barfa >Priority: Major > > Steps: > 1. Open URL > https://demo-trunk.ofbiz.apache.org/accounting/control/FindGatewayResponses > 2. Navigate to Transactions with Authorize > 3. Try to Capture payment > 4. Again navigate to FindGatewayResponses and check for transaction > Actual Result: > The transaction still displayed with Authorize status and no update on > payment capture > Expected Result: > Correct status of transaction should be displayed (Capture/Authorize) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11910) product summary cards don't have uniform height
[ https://issues.apache.org/jira/browse/OFBIZ-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru updated OFBIZ-11910: - Description: while several product summaries are in the same row, especially products with different statuses and properties, they are terribly unalligned. i did attach classes to the various elements, most of them static but few of them calculated, so it's stylable in custom.css. a css artist will highly outperform my css capabilities, but even my idea gives a sensibly uniform result. my diff is a little intermingled, but i would be glad to explain everything. thanks in advance, alex was: while several product summaries are in the same row, especially products with different statuses and properties, they are terribly unalligned. i did attach classes to the various elements, most of them static but few of them calculated, so stylable in custom.css. a css artist will highly outperform my css capabilities, but even my idea gives a sensibly uniform result. my diff is a little intermingled, but i would be glad to explain everithing. thanks in advance, alex > product summary cards don't have uniform height > --- > > Key: OFBIZ-11910 > URL: https://issues.apache.org/jira/browse/OFBIZ-11910 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Screen Shot changed.png, Screen Shot original.png > > > while several product summaries are in the same row, especially products with > different statuses and properties, they are terribly unalligned. > i did attach classes to the various elements, most of them static but few of > them calculated, so it's stylable in custom.css. > a css artist will highly outperform my css capabilities, but even my idea > gives a sensibly uniform result. > my diff is a little intermingled, but i would be glad to explain everything. > thanks in advance, > alex -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165421#comment-17165421
]
Devanshu Vyas commented on OFBIZ-9254:
--
I feel bad for mistakenly breaking the startsWith method in the
ContentManagementServices class. I also checked that similar mistakes were done
only in ContentManagementServices.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11922) Checkstyle: has incorrect indentation level
[ https://issues.apache.org/jira/browse/OFBIZ-11922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165251#comment-17165251 ] Suraj Khurana commented on OFBIZ-11922: --- This fixed around *3030* checkstyle issues. > Checkstyle: has incorrect indentation level > --- > > Key: OFBIZ-11922 > URL: https://issues.apache.org/jira/browse/OFBIZ-11922 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11904-plugins.patch, OFBIZ-11904.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11922) Checkstyle: has incorrect indentation level
[ https://issues.apache.org/jira/browse/OFBIZ-11922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana closed OFBIZ-11922. - Fix Version/s: Upcoming Branch Resolution: Implemented > Checkstyle: has incorrect indentation level > --- > > Key: OFBIZ-11922 > URL: https://issues.apache.org/jira/browse/OFBIZ-11922 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11904-plugins.patch, OFBIZ-11904.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11922) Checkstyle: has incorrect indentation level
[ https://issues.apache.org/jira/browse/OFBIZ-11922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165250#comment-17165250 ] ASF subversion and git services commented on OFBIZ-11922: - Commit 743c627f400906327e45c7437f6c3e42e4c0b142 in ofbiz-plugins's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=743c627 ] Improved: Corrected all incorrect indentation level issues in plugins component, also fixed some case indentation checkstyle issues. (OFBIZ-11922) > Checkstyle: has incorrect indentation level > --- > > Key: OFBIZ-11922 > URL: https://issues.apache.org/jira/browse/OFBIZ-11922 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11904-plugins.patch, OFBIZ-11904.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11922) Checkstyle: has incorrect indentation level
[ https://issues.apache.org/jira/browse/OFBIZ-11922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165249#comment-17165249 ] ASF subversion and git services commented on OFBIZ-11922: - Commit d374019465231c66823118e20afd6e0f96802a13 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d374019 ] Improved: Corrected all incorrect indentation level issues in framework component, also fixed some case indentation checkstyle issues. (OFBIZ-11922) > Checkstyle: has incorrect indentation level > --- > > Key: OFBIZ-11922 > URL: https://issues.apache.org/jira/browse/OFBIZ-11922 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11904-plugins.patch, OFBIZ-11904.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11922) Checkstyle: has incorrect indentation level
[ https://issues.apache.org/jira/browse/OFBIZ-11922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165248#comment-17165248 ] ASF subversion and git services commented on OFBIZ-11922: - Commit 3929ff1bd7fd3e04b7c2dbe16a01cd24e19d86d3 in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3929ff1 ] Improved: Corrected all incorrect indentation level issues in application component, also fixed some case indentation checkstyle issues. (OFBIZ-11922) > Checkstyle: has incorrect indentation level > --- > > Key: OFBIZ-11922 > URL: https://issues.apache.org/jira/browse/OFBIZ-11922 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11904-plugins.patch, OFBIZ-11904.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11925) Checkstyle: Redundant modifiers
Suraj Khurana created OFBIZ-11925:
-
Summary: Checkstyle: Redundant modifiers
Key: OFBIZ-11925
URL: https://issues.apache.org/jira/browse/OFBIZ-11925
Project: OFBiz
Issue Type: Sub-task
Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana
{color:#172b4d}Redundant 'static' modifier.{color}
{color:#172b4d}Redundant 'final' modifier.{color}
{color:#172b4d}Redundant 'public' modifier.
Need to fix all these checkstyle occurences{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11915) Handle MethodLength checkstyle rule
[ https://issues.apache.org/jira/browse/OFBIZ-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165232#comment-17165232 ] Suraj Khurana commented on OFBIZ-11915: --- Yes, I will send an email today. > Handle MethodLength checkstyle rule > --- > > Key: OFBIZ-11915 > URL: https://issues.apache.org/jira/browse/OFBIZ-11915 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] danwatford commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
danwatford commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663977565 Hi @JacquesLeRoux , conflict has been fixed now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
sonarcloud[bot] removed a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663113465 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_ofbiz-framework=217=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
sonarcloud[bot] commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663977154 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_ofbiz-framework=217=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
JacquesLeRoux edited a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663956951 Hi Daniel, Sorry, "This branch has conflicts that must be resolved" as reports GH This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
JacquesLeRoux edited a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663956951 Hi Daniel, Sorry "This branch has conflicts that must be resolved" as reports GH This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
JacquesLeRoux commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663956951 Hi Daniel, Sorry "This branch has conflicts that must be resolved" as report GH This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (OFBIZ-10834) Uploading image to data resource
[ https://issues.apache.org/jira/browse/OFBIZ-10834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165179#comment-17165179 ] Jacques Le Roux edited comment on OFBIZ-10834 at 7/26/20, 8:10 AM: --- I answered in OFBIZ-9254 was (Author: jacques.le.roux): I answeredin OFBIZ-9254 > Uploading image to data resource > > > Key: OFBIZ-10834 > URL: https://issues.apache.org/jira/browse/OFBIZ-10834 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Ankush Upadhyay >Priority: Major > > Content --> DataResource --> "Create new" > * Data Resource Id: some Id > * Data Resource Type Id: local file > --> "create" > --> Upload --> "select local file" --> upload > The result is no file uploaded. No error message. > It works fine in ofbiz 16.11 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10834) Uploading image to data resource
[ https://issues.apache.org/jira/browse/OFBIZ-10834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165179#comment-17165179 ] Jacques Le Roux commented on OFBIZ-10834: - I answeredin OFBIZ-9254 > Uploading image to data resource > > > Key: OFBIZ-10834 > URL: https://issues.apache.org/jira/browse/OFBIZ-10834 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Ankush Upadhyay >Priority: Major > > Content --> DataResource --> "Create new" > * Data Resource Id: some Id > * Data Resource Type Id: local file > --> "create" > --> Upload --> "select local file" --> upload > The result is no file uploaded. No error message. > It works fine in ofbiz 16.11 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165178#comment-17165178
]
Jacques Le Roux commented on OFBIZ-9254:
Thanks Ankush,
In 1st place I wonder why we had:
{code:java}
} else if (dataResourceTypeId.equals("SHORT_TEXT")) {
} else if (dataResourceTypeId.startsWith("SURVEY")) {
} else if (dataResourceTypeId.indexOf("_FILE") >=0) {
Map uploadImage = new HashMap();
{code}
The 1st two "if" were useless (doing nothing). We should remove the changed
ones. We could argue that they will be useful in future, but then better to add
them in this hypotetical future.
I looked for {{".startsWith}} and {{".indexOf(}} in all Java files and found
them respectively only in ContentManagementServices and
ContentManagementServices + ContentWorker.java (from pre Apache era, not
related to this issue). So with my suggested changes your concern could be put
away.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Devanshu Vyas
>Priority: Minor
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165169#comment-17165169 ] Jacques Le Roux edited comment on OFBIZ-11553 at 7/26/20, 6:47 AM: --- Thank you much guys, This was bugging me, never good to have a bug pending too long, waiting to me be mixed with others and making us lossing tracks :) was (Author: jacques.le.roux): Thank you much guys, This was bugging me, never good to have a bug pending too long time, waiting to me be mixed with others and lossing tracks :) > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11553-test.patch > > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165168#comment-17165168 ] ASF subversion and git services commented on OFBIZ-11553: - Commit a3fc1e8205995aa8438df9bd0c2927dd8cbc6667 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a3fc1e8 ] Fixed: Convert InvoicePerShipmentTests.xml to Groovy (OFBIZ-11553) The order created with test case testCreateOrderServiceProduct did not get approved so the quick ship process did not work correctly while with specific configurableServiceOrder-test new order has got approved and the quick ship process worked correctly. We got multiple payment methods i.e. EXT_PAYPAL and EXT_COD but in the test case only EXT_COD was defined. Without shopping cart tests testIntegration works perfectly. Shopping cart has multiple payment methods, and as cart has multiple payment methods, order is not approved (org/apache/ofbiz/order/shoppingcart/CheckOutHelper.java:1166) This ensures single paymentMethod. It could reviewed again when converting ShoppingCartTests.xml to Groovy. I have added a comment about that Thanks: Pawan and Suraj > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11553-test.patch > > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165169#comment-17165169 ] Jacques Le Roux commented on OFBIZ-11553: - Thank you much guys, This was bugging me, never good to have a bug pending too long time, waiting to me be mixed with others and lossing tracks :) > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11553-test.patch > > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9901) Unable to create event in SFA component
[ https://issues.apache.org/jira/browse/OFBIZ-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165166#comment-17165166 ] Jacques Le Roux commented on OFBIZ-9901: Hi Aditya, No worries, was benign :) > Unable to create event in SFA component > --- > > Key: OFBIZ-9901 > URL: https://issues.apache.org/jira/browse/OFBIZ-9901 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Aditya Sharma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: OFBIZ-9901.patch, screenshot-1.png > > > Steps- > 1) Open URL > https://demo-trunk.ofbiz.apache.org/sfa/control/createWorkEffortAndPartyAssign > 2) In SFA component, create an event by clicking on "Create new". > 3) Fill in the information with name and select "To party id" (except admin). > Expected: Event should be successfully created > Actual: Unable to create event -- This message was sent by Atlassian Jira (v8.3.4#803005)
