[jira] [Commented] (OFBIZ-11864) Purchase Order Email Support
[ https://issues.apache.org/jira/browse/OFBIZ-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169399#comment-17169399 ] Akash Jain commented on OFBIZ-11864: Attached patch to sent PO email. > Purchase Order Email Support > > > Key: OFBIZ-11864 > URL: https://issues.apache.org/jira/browse/OFBIZ-11864 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Akash Jain >Priority: Minor > Attachments: OFBIZ-11864.patch > > > Will take care of following items, > -- add support to send purchase order (PO) email > -- prepare email template > -- add option to send po email from view order screen -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11864) Purchase Order Email Support
[ https://issues.apache.org/jira/browse/OFBIZ-11864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain updated OFBIZ-11864: --- Attachment: OFBIZ-11864.patch > Purchase Order Email Support > > > Key: OFBIZ-11864 > URL: https://issues.apache.org/jira/browse/OFBIZ-11864 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Akash Jain >Priority: Minor > Attachments: OFBIZ-11864.patch > > > Will take care of following items, > -- add support to send purchase order (PO) email > -- prepare email template > -- add option to send po email from view order screen -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169312#comment-17169312 ] Suraj Khurana commented on OFBIZ-11921: --- Attached initial patch, there will be some more for this changes. This patch fixes around *2150* checkstyle issues. Few general issues are also being take care in this patch > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters
[ https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11921: -- Attachment: OFBIZ-plugins-11921.patch OFBIZ-11921.patch > Checkstyle: Line is longer than 150 characters > -- > > Key: OFBIZ-11921 > URL: https://issues.apache.org/jira/browse/OFBIZ-11921 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11921.patch, OFBIZ-plugins-11921.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration
[
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169300#comment-17169300
]
Jacques Le Roux commented on OFBIZ-10973:
-
Thanks for the explanation Pritam.
> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send
> sms".
> But could we not have another name, more explicit, for this component, like
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not
> associate the name of an open source component to a commercial services
> provider (with a free SMS quota option). Even if hopefully it will stay as
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11930) Remove unused imports from Java files
[ https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169291#comment-17169291 ] Suraj Khurana commented on OFBIZ-11930: --- Hi Priya, Thanks for creating this ticket. This is a small part of checkstyle improvement, I think we can convert it to sub-task of https://issues.apache.org/jira/browse/OFBIZ-11350. WDYT? > Remove unused imports from Java files > - > > Key: OFBIZ-11930 > URL: https://issues.apache.org/jira/browse/OFBIZ-11930 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Priya Sharma >Assignee: Priya Sharma >Priority: Minor > > Unused package imports can be removed for code optimization. > Similar effort was done previously for groovy files > https://issues.apache.org/jira/browse/OFBIZ-7334 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration
[
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169282#comment-17169282
]
Pritam Kute commented on OFBIZ-10973:
-
Hello [~pawan], we can rename this plugin to "sms-msg91" which is suggested by
[~jleroux].
[~jleroux] the initial thought behind having this integration in place was to
have common code in the framework which could be so generic that users can
build any custom plugin and call framework methods to send SMS, WhatsApp
message or even a message on Facebook messenger. So that's why we had called it
"msggateway". But now, I think as it is an independent plugin and all generic
code is in the framework itself, we can rename this plugin as sms-msg91
> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send
> sms".
> But could we not have another name, more explicit, for this component, like
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not
> associate the name of an open source component to a commercial services
> provider (with a free SMS quota option). Even if hopefully it will stay as
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11932) getJs unknown in Webpos
[
https://issues.apache.org/jira/browse/OFBIZ-11932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11932.
---
Fix Version/s: Upcoming Branch
Resolution: Fixed
> getJs unknown in Webpos
> ---
>
> Key: OFBIZ-11932
> URL: https://issues.apache.org/jira/browse/OFBIZ-11932
> Project: OFBiz
> Issue Type: Bug
> Components: webpos
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Here is the error stack:
> {noformat}
> 2020-07-31 15:12:19,227 |jsse-nio-8443-exec-8 |ControlServlet
> |T| [[[webpos::getJs (Domain:https://localhost)] Request Begun,
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-07-31 15:12:19,229 |jsse-nio-8443-exec-8 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [getJs]; this request does not exist or cannot be called directly.
> {noformat}
> IIRW when looking in the browser log it seems related to {{function
> activateHotKeys()}} in Shortcuts.ftl called from Common.js
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11932) getJs unknown in Webpos
[
https://issues.apache.org/jira/browse/OFBIZ-11932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169276#comment-17169276
]
Jacques Le Roux commented on OFBIZ-11932:
-
R17 and R18 are not affected
> getJs unknown in Webpos
> ---
>
> Key: OFBIZ-11932
> URL: https://issues.apache.org/jira/browse/OFBIZ-11932
> Project: OFBiz
> Issue Type: Bug
> Components: webpos
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> Here is the error stack:
> {noformat}
> 2020-07-31 15:12:19,227 |jsse-nio-8443-exec-8 |ControlServlet
> |T| [[[webpos::getJs (Domain:https://localhost)] Request Begun,
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-07-31 15:12:19,229 |jsse-nio-8443-exec-8 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [getJs]; this request does not exist or cannot be called directly.
> {noformat}
> IIRW when looking in the browser log it seems related to {{function
> activateHotKeys()}} in Shortcuts.ftl called from Common.js
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11932) getJs unknown in Webpos
[
https://issues.apache.org/jira/browse/OFBIZ-11932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169277#comment-17169277
]
ASF subversion and git services commented on OFBIZ-11932:
-
Commit 68e603fb4ba63cee75bc22253817065a44763678 in ofbiz-plugins's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=68e603f ]
Fixed: getJs unknown in Webpos (OFBIZ-11932)
R17 is not affected
> getJs unknown in Webpos
> ---
>
> Key: OFBIZ-11932
> URL: https://issues.apache.org/jira/browse/OFBIZ-11932
> Project: OFBiz
> Issue Type: Bug
> Components: webpos
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> Here is the error stack:
> {noformat}
> 2020-07-31 15:12:19,227 |jsse-nio-8443-exec-8 |ControlServlet
> |T| [[[webpos::getJs (Domain:https://localhost)] Request Begun,
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-07-31 15:12:19,229 |jsse-nio-8443-exec-8 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [getJs]; this request does not exist or cannot be called directly.
> {noformat}
> IIRW when looking in the browser log it seems related to {{function
> activateHotKeys()}} in Shortcuts.ftl called from Common.js
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11932) getJs unknown in Webpos
[
https://issues.apache.org/jira/browse/OFBIZ-11932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-11932:
---
Component/s: webpos
Affects Version/s: Trunk
Assignee: Jacques Le Roux
> getJs unknown in Webpos
> ---
>
> Key: OFBIZ-11932
> URL: https://issues.apache.org/jira/browse/OFBIZ-11932
> Project: OFBiz
> Issue Type: Bug
> Components: webpos
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> Here is the error stack:
> {noformat}
> 2020-07-31 15:12:19,227 |jsse-nio-8443-exec-8 |ControlServlet
> |T| [[[webpos::getJs (Domain:https://localhost)] Request Begun,
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-07-31 15:12:19,229 |jsse-nio-8443-exec-8 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [getJs]; this request does not exist or cannot be called directly.
> {noformat}
> IIRW when looking in the browser log it seems related to {{function
> activateHotKeys()}} in Shortcuts.ftl called from Common.js
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11932) getJs unknown in Webpos
[
https://issues.apache.org/jira/browse/OFBIZ-11932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11932:
Description:
Here is the error stack:
{noformat}
2020-07-31 15:12:19,227 |jsse-nio-8443-exec-8 |ControlServlet
|T| [[[webpos::getJs (Domain:https://localhost)] Request Begun,
encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-07-31 15:12:19,229 |jsse-nio-8443-exec-8 |ControlServlet
|E| Error in request handler:
org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
[getJs]; this request does not exist or cannot be called directly.
{noformat}
IIRW when looking in the browser log it seems related to {{function
activateHotKeys()}} in Shortcuts.ftl called from Common.js
was:
Here is the error stack:
{noformat}
2020-07-31 15:12:19,227 |jsse-nio-8443-exec-8 |ControlServlet
|T| [[[webpos::getJs (Domain:https://localhost)] Request Begun,
encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-07-31 15:12:19,229 |jsse-nio-8443-exec-8 |ControlServlet
|E| Error in request handler:
org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
[getJs]; this request does not exist or cannot be called directly.
{noformat}
IIRW when looking in the browser log it seems related to {{function
activateHotKeys() {}} in Shortcuts.ftl called from Common.js
> getJs unknown in Webpos
> ---
>
> Key: OFBIZ-11932
> URL: https://issues.apache.org/jira/browse/OFBIZ-11932
> Project: OFBiz
> Issue Type: Bug
>Reporter: Jacques Le Roux
>Priority: Major
>
> Here is the error stack:
> {noformat}
> 2020-07-31 15:12:19,227 |jsse-nio-8443-exec-8 |ControlServlet
> |T| [[[webpos::getJs (Domain:https://localhost)] Request Begun,
> encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2020-07-31 15:12:19,229 |jsse-nio-8443-exec-8 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [getJs]; this request does not exist or cannot be called directly.
> {noformat}
> IIRW when looking in the browser log it seems related to {{function
> activateHotKeys()}} in Shortcuts.ftl called from Common.js
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
