[jira] [Commented] (OFBIZ-11799) Move page-specific script links to html template

2020-08-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178720#comment-17178720
 ] 

ASF subversion and git services commented on OFBIZ-11799:
-

Commit 0c2c3d4cb92e8e0b9ca7245ed45aea9c63ecc730 in ofbiz-framework's branch 
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0c2c3d4 ]

Improved: Move page-specific script links to html template (OFBIZ-11799)

importLibrary function to check for local environment before setting 
crossDomain.


> Move page-specific script links to html template
> 
>
> Key: OFBIZ-11799
> URL: https://issues.apache.org/jira/browse/OFBIZ-11799
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
>
> As external script can be defined in html template, suggest to move some of 
> the page-specific script links from layoutSettings.javaScripts to the html 
> templates.
> 6 Aug 2020
> Also include moving from layoutSettings.styleSheets, VT_HDR_JAVASCRIPT and 
> VT_STYLESHEET.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

2020-08-16 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178718#comment-17178718
 ] 

Suraj Khurana commented on OFBIZ-11947:
---

Oops, thanks Jacques, I will take care of it while commit.

> Checkstyle: Add Javadoc for classes designed for extension
> --
>
> Key: OFBIZ-11947
> URL: https://issues.apache.org/jira/browse/OFBIZ-11947
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11947-plugins.patch, OFBIZ-11947.patch
>
>
> For checkstyle errors:
> Class 'ResourceInfo' looks like designed for extension (can be subclassed), 
> but the method 'createResourceHandler' does not have javadoc that explains 
> how to do that safely. If class is not designed for extension consider making 
> the class 'ResourceInfo' final or making the method 'createResourceHandler' 
> static/final/abstract/empty, or adding allowed annotation for the method.
> We need to add missing javadocs for all such methods



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-08-16 Thread Tri Vo (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178674#comment-17178674
 ] 

Tri Vo commented on OFBIZ-11328:


{code:java}
Can you please post your request along with header information? Looks like you 
need to disable SSL certificate verification in Postman. You might want to try 
using CURL instead of Postman. But if you do use Postman, please turn off SSL 
Certificate Verifcation.{code}
It work for me. Thank you Girish

> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-16 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178673#comment-17178673
 ] 

James Yong commented on OFBIZ-11686:


Hi Jacques,

Need the crossDomain setting for debugging the script.
Will add restriction like checking for local environment before setting the 
crossDomain attribute.

Regards,
James

> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178482#comment-17178482
 ] 

Jacques Le Roux commented on OFBIZ-11686:
-

Kudos for the good work James!

I understand that this is safe OOTB:
{{crossDomain: true, // set to true to allow the file to be shown under 
browser's sources folder}}
But could this not be used for attacks (just thiking aloud for now)

> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178479#comment-17178479
 ] 

Jacques Le Roux commented on OFBIZ-11686:
-

Ah OK, thanks!

> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-16 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178476#comment-17178476
 ] 

James Yong commented on OFBIZ-11686:


Hi Jacques,

Removing from cache will keep the naming of the script fixed for every request.
This make it easier to work with debugger breakpoints in browser.

Regards,
James

> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178472#comment-17178472
 ] 

Jacques Le Roux commented on OFBIZ-11686:
-

Hi James,

For my enlightenment, why removing script from cache after reading it by getJs?

> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

2020-08-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178471#comment-17178471
 ] 

Jacques Le Roux edited comment on OFBIZ-11954 at 8/16/20, 1:04 PM:
---

BTW, it's maybe our code which " destabilize the Daemon". More at 
https://docs.gradle.org/current/userguide/gradle_daemon.html#sec:what_can_go_wrong_with_daemon


was (Author: jacques.le.roux):
BTW, it's maybe our code which " destabilize the Daemon": 
https://docs.gradle.org/current/userguide/gradle_daemon.html#sec:what_can_go_wrong_with_daemon

> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM 
> memory 
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the 
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on 
> dev ML before increasing 
> org.gradle.jvmargs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

2020-08-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178471#comment-17178471
 ] 

Jacques Le Roux commented on OFBIZ-11954:
-

BTW, it's maybe our code which " destabilize the Daemon": 
https://docs.gradle.org/current/userguide/gradle_daemon.html#sec:what_can_go_wrong_with_daemon

> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM 
> memory 
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the 
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on 
> dev ML before increasing 
> org.gradle.jvmargs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

2020-08-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178468#comment-17178468
 ] 

Jacques Le Roux edited comment on OFBIZ-11954 at 8/16/20, 12:59 PM:


For now I'll add "org.gradle.daemon=false" in gradle.properties

I suggest to make it the default, at least in trunk, until the problem is 
solved by the Gradle team.





was (Author: jacques.le.roux):
For now I'll add "org.gradle.daemon=false" in gradle.properties :)



> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM 
> memory 
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the 
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on 
> dev ML before increasing 
> org.gradle.jvmargs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

2020-08-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178468#comment-17178468
 ] 

Jacques Le Roux commented on OFBIZ-11954:
-

For now I'll add "org.gradle.daemon=false" in gradle.properties :)



> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM 
> memory 
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the 
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on 
> dev ML before increasing 
> org.gradle.jvmargs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

2020-08-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178466#comment-17178466
 ] 

Jacques Le Roux commented on OFBIZ-11954:
-

Using --no-daemon fixes the issue/

Reading https://docs.gradle.org/6.5.1/userguide/gradle_daemon.html may also 
explain why we get an increasing space on demo server due to daemon though we 
are always using --no-daemon  when running any task! I'll digg that...

> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM 
> memory 
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the 
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on 
> dev ML before increasing 
> org.gradle.jvmargs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

2020-08-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178465#comment-17178465
 ] 

Jacques Le Roux commented on OFBIZ-11954:
-

Hi James,

Thank for your tests. I still get the error, so it seems we have a problem w/ 
Gradle 6.5 indeed.


> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM 
> memory 
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the 
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on 
> dev ML before increasing 
> org.gradle.jvmargs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11956) Re-thinking the Log-Level

2020-08-16 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178459#comment-17178459
 ] 

James Yong commented on OFBIZ-11956:


+1 
Most timing-related logs should be finer than info level.  

> Re-thinking the Log-Level
> -
>
> Key: OFBIZ-11956
> URL: https://issues.apache.org/jira/browse/OFBIZ-11956
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content, framework
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Priority: Minor
>
> The following log messages have all a log level of "info" or "warning". In 
> our experience, however, this is a very large source of noise during 
> operation. The messages are in my opinion only of interpretation, if it is 
> necessary to examine the signal flow in case of error. I know that there is a 
> difference of opinion on this subject, so I have listed the places that we 
> have put on Verbose in our projects. I am looking forward to hearing your 
> thoughts on this topic.
>  # {{ScreenFactory |I| Got %s screens in 0.004s from: %s}}
>  # {{ConfigXMLReader |I| controller loaded: 0.001s, 115 requests, 59 views in 
> file: %s}}
>  # {{ModelService |I| Set default value [%s] for parameter [%s]}}
>  # {{ServiceEcaCondition |I| From Field (%s) is not found in context for %s, 
> defaulting to null.
> }}
>  # {{ServiceEcaCondition |W| doRealCompare returned null, returning false}}
>  # {{DataResourcePermissionServices.xml#genericDataResourcePermission line 
> 69] }}
>  # {{DataResourcePermissionServices.xml#genericDataResourcePermission line 
> 73]}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11799) Move page-specific script links to html template

2020-08-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178457#comment-17178457
 ] 

ASF subversion and git services commented on OFBIZ-11799:
-

Commit 06b4333c546dc59966f352decc75731700bf78b0 in ofbiz-framework's branch 
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=06b4333 ]

Improved: Move page-specific script links to html template (OFBIZ-11799)

refactoring +
use importLibrary js function to load readmore and jgrowl js.


> Move page-specific script links to html template
> 
>
> Key: OFBIZ-11799
> URL: https://issues.apache.org/jira/browse/OFBIZ-11799
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
>
> As external script can be defined in html template, suggest to move some of 
> the page-specific script links from layoutSettings.javaScripts to the html 
> templates.
> 6 Aug 2020
> Also include moving from layoutSettings.styleSheets, VT_HDR_JAVASCRIPT and 
> VT_STYLESHEET.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11799) Move page-specific script links to html template

2020-08-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178453#comment-17178453
 ] 

ASF subversion and git services commented on OFBIZ-11799:
-

Commit 39c1e280f9b4ee8d7b6b4d939b278ab4f653aa4f in ofbiz-framework's branch 
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=39c1e28 ]

Improved: Move page-specific script links to html template (OFBIZ-11799)

refactoring +
importLibrary function to use crossDomain = true to allow js file to be shown 
under browser's sources folder


> Move page-specific script links to html template
> 
>
> Key: OFBIZ-11799
> URL: https://issues.apache.org/jira/browse/OFBIZ-11799
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
>
> As external script can be defined in html template, suggest to move some of 
> the page-specific script links from layoutSettings.javaScripts to the html 
> templates.
> 6 Aug 2020
> Also include moving from layoutSettings.styleSheets, VT_HDR_JAVASCRIPT and 
> VT_STYLESHEET.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11799) Move page-specific script links to html template

2020-08-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178435#comment-17178435
 ] 

ASF subversion and git services commented on OFBIZ-11799:
-

Commit 55df1c7db06103ed0006cf741019f5ad2291fe0f in ofbiz-framework's branch 
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=55df1c7 ]

Improved: Move page-specific script links to html template (OFBIZ-11799)

Use importLibrary js function to load elrte js and css
Tested on
https://localhost:8443/content/control/findForumMessages?forumGroupId=WebStoreFORUM=1
https://localhost:8443/content/control/WebSiteCms?webSiteId=CmsSite


> Move page-specific script links to html template
> 
>
> Key: OFBIZ-11799
> URL: https://issues.apache.org/jira/browse/OFBIZ-11799
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
>
> As external script can be defined in html template, suggest to move some of 
> the page-specific script links from layoutSettings.javaScripts to the html 
> templates.
> 6 Aug 2020
> Also include moving from layoutSettings.styleSheets, VT_HDR_JAVASCRIPT and 
> VT_STYLESHEET.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)