[jira] [Commented] (OFBIZ-11982) Expired product images showing on product detail page

2020-08-24 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183490#comment-17183490
 ] 

Akash Jain commented on OFBIZ-11982:


Attached patch to fix the reported issue.

> Expired product images showing on product detail page
> -
>
> Key: OFBIZ-11982
> URL: https://issues.apache.org/jira/browse/OFBIZ-11982
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-11982.patch
>
>
> Expired product images showing in sliding box on product detail page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11982) Expired product images showing on product detail page

2020-08-24 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-11982:
---
Attachment: OFBIZ-11982.patch

> Expired product images showing on product detail page
> -
>
> Key: OFBIZ-11982
> URL: https://issues.apache.org/jira/browse/OFBIZ-11982
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-11982.patch
>
>
> Expired product images showing in sliding box on product detail page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11981) Additional images not showing correctly on product detail page

2020-08-24 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183486#comment-17183486
 ] 

Akash Jain commented on OFBIZ-11981:


Attached patch to fix the reported issue.

> Additional images not showing correctly on product detail page
> --
>
> Key: OFBIZ-11981
> URL: https://issues.apache.org/jira/browse/OFBIZ-11981
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-11981.patch, OFBIZ-11981.png
>
>
> Additional images not showing correctly on product detail page, attached 
> screen-shot.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11981) Additional images not showing correctly on product detail page

2020-08-24 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-11981:
---
Attachment: OFBIZ-11981.patch

> Additional images not showing correctly on product detail page
> --
>
> Key: OFBIZ-11981
> URL: https://issues.apache.org/jira/browse/OFBIZ-11981
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-11981.patch, OFBIZ-11981.png
>
>
> Additional images not showing correctly on product detail page, attached 
> screen-shot.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11982) Expired product images showing on product detail page

2020-08-24 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-11982:
--

 Summary: Expired product images showing on product detail page
 Key: OFBIZ-11982
 URL: https://issues.apache.org/jira/browse/OFBIZ-11982
 Project: OFBiz
  Issue Type: Improvement
  Components: ecommerce
Reporter: Akash Jain
Assignee: Akash Jain


Expired product images showing in sliding box on product detail page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11981) Additional images not showing correctly on product detail page

2020-08-24 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-11981:
---
Attachment: OFBIZ-11981.png

> Additional images not showing correctly on product detail page
> --
>
> Key: OFBIZ-11981
> URL: https://issues.apache.org/jira/browse/OFBIZ-11981
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Reporter: Akash Jain
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-11981.png
>
>
> Additional images not showing correctly on product detail page, attached 
> screen-shot.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11981) Additional images not showing correctly on product detail page

2020-08-24 Thread Akash Jain (Jira)
Akash Jain created OFBIZ-11981:
--

 Summary: Additional images not showing correctly on product detail 
page
 Key: OFBIZ-11981
 URL: https://issues.apache.org/jira/browse/OFBIZ-11981
 Project: OFBiz
  Issue Type: Improvement
  Components: ecommerce
Reporter: Akash Jain
Assignee: Akash Jain


Additional images not showing correctly on product detail page, attached 
screen-shot.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11924) Issues with additional image on ecommerce

2020-08-24 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183424#comment-17183424
 ] 

Akash Jain commented on OFBIZ-11924:


Hi [~arpit.mor],

I explored code around images on product detail page. There is showing product 
images in sliding style if product images ('product content type id' is 
'IMAGE') available in the system. If product image is not available then only 
additional images showing one by one.

As per the implementation,

#1 is working as expected. We can create separate ticket as improvement if 
product images and additional images both should be shown.

#2 is also working as expected. Product images showing in sliding style and 
additional images showing one by one.

> Issues with additional image on ecommerce
> -
>
> Key: OFBIZ-11924
> URL: https://issues.apache.org/jira/browse/OFBIZ-11924
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Akash Jain
>Priority: Minor
> Attachments: Add1.jpg, Add2.jpg, Add3.jpg, Image2.1.png, Image2.2.png
>
>
> Following issues were found:
>  
> #1) Additional image uploaded for product is not displayed (if product 
> already has additional image)
> Steps to regenerate:
>  * Download additional images attached in the ticket
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=WG-5569]
>  * Browse additional images that are downloaded in the earlier step
>  * Click on upload button
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ecomseo/product/Tiny-Chrome-Widget-WG-5569.html]
>  
> Actual: Uploaded additional images are not displayed
>  
> Expected: Uploaded additional image should be displayed on ecommerce
>  
> Note: This issue is product specific, for product: Tiny Chrome Widget (Id: 
> WG-5569), uploaded additional images are not displayed. But for product: Nan 
> Gizmo (Id: GZ-1001), uploaded additional images are displayed
>  
> #2) UI issue on ecommerce when additional images are uploaded for product
> Steps to regenerate:
>  * Download additional images attached in the ticket
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1001]
>  * Browse additional images that are downloaded in the earlier step
>  * Click on upload button
>  * Navigate to URL: 
> [https://demo-trunk.ofbiz.apache.org/ecomseo/product/Nan-Gizmo-GZ-1001.html]
>  
> Actual: Please refer attachment: Image2.1
> Expected: Please refer attachment: Image 2.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183404#comment-17183404
 ] 

Jacques Le Roux edited comment on OFBIZ-11686 at 8/24/20, 4:10 PM:
---

Hi James,

After a "cleanAll eclipse loadAll ofbiz" I don't see the Category tree in 
ecommerce. I suppose, this is due to an interaction between getJs and 
ServerHit. Here it the error in log

{noformat}
2020-08-24 17:54:51,637 |jsse-nio-8443-exec-4 |ControlEventListener  
|I| Creating session:  hidden sessionId by default.
2020-08-24 17:54:51,670 |jsse-nio-8443-exec-4 |SeoContextFilter  
|I| Can NOT forward this url: /ecomseo
2020-08-24 17:54:51,714 |jsse-nio-8443-exec-4 |ConfigXMLReader   
|I| controller loaded: 0.002s, 289 requests, 96 views in 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
2020-08-24 17:54:51,714 |jsse-nio-8443-exec-4 |ConfigXMLReader   
|I| controller loaded: 0.024s, 0 requests, 0 views in 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/webapp/ecomseo/WEB-INF/controller.xml
2020-08-24 17:54:51,714 |jsse-nio-8443-exec-4 |ControlServlet
|T| [[[ecomseo::main (Domain:https://localhost)] Request Begun, 
encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-24 17:54:51,714 |jsse-nio-8443-exec-4 |VisitHandler  
|I| Found visitorId [1] in cookie
2020-08-24 17:54:51,718 |jsse-nio-8443-exec-4 |RequestHandler
|I| This is the first request in this visit. Hidden sessionId by default.
2020-08-24 17:54:51,718 |jsse-nio-8443-exec-4 |LoginWorker   
|I| Running autoLogin check.
2020-08-24 17:54:51,817 |jsse-nio-8443-exec-4 |RequestHandler
|I| Rendering View [main].  Hidden sessionId by default.
2020-08-24 17:54:51,818 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/getUserPreferenceGroup] finished in [1] milliseconds
2020-08-24 17:54:51,856 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 17 screens in 0.035s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/CommonScreens.xml
2020-08-24 17:54:52,611 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 9 screens in 0.016s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/CartScreens.xml
2020-08-24 17:54:52,644 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 38 screens in 0.028s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/CatalogScreens.xml
2020-08-24 17:54:53,565 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [70] milliseconds
2020-08-24 17:54:53,610 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [1] milliseconds
2020-08-24 17:54:53,738 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 7 screens in 0.014s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/EmailContactListScreens.xml
2020-08-24 17:54:54,110 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 8 screens in 0.018s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/ContentScreens.xml
2020-08-24 17:54:54,111 |jsse-nio-8443-exec-4 |ProductStoreWorker
|I| getSurvey for product null
2020-08-24 17:54:54,354 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 6 screens in 0.01s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/ForumScreens.xml

2020-08-24 17:54:54,403 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 15 screens in 0.014s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/blog/BlogScreens.xml
2020-08-24 17:54:54,864 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/getProductCategoryAndLimitedMembers] finished in 
[93] milliseconds
2020-08-24 17:54:55,303 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/getInventoryAvailableByFacility] finished in [114] 
milliseconds
2020-08-24 17:54:55,314 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [10] milliseconds
2020-08-24 17:54:55,315 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [1] milliseconds
2020-08-24 17:54:55,468 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [44] milliseconds
2020-08-24 17:54:55,469 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [1] milliseconds
2020-08-24 17:54:55,471 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service 

[jira] [Reopened] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-11686:
-

Hi James,

After a "cleanAll eclipse loadAll ofbiz" I don't see the Catetgory tree in 
ecommerce. I suppose, this is not due to an interaction between getJs and 
ServerHit. Here it the error in log

{noformat}
2020-08-24 17:54:51,637 |jsse-nio-8443-exec-4 |ControlEventListener  
|I| Creating session:  hidden sessionId by default.
2020-08-24 17:54:51,670 |jsse-nio-8443-exec-4 |SeoContextFilter  
|I| Can NOT forward this url: /ecomseo
2020-08-24 17:54:51,714 |jsse-nio-8443-exec-4 |ConfigXMLReader   
|I| controller loaded: 0.002s, 289 requests, 96 views in 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
2020-08-24 17:54:51,714 |jsse-nio-8443-exec-4 |ConfigXMLReader   
|I| controller loaded: 0.024s, 0 requests, 0 views in 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/webapp/ecomseo/WEB-INF/controller.xml
2020-08-24 17:54:51,714 |jsse-nio-8443-exec-4 |ControlServlet
|T| [[[ecomseo::main (Domain:https://localhost)] Request Begun, 
encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-08-24 17:54:51,714 |jsse-nio-8443-exec-4 |VisitHandler  
|I| Found visitorId [1] in cookie
2020-08-24 17:54:51,718 |jsse-nio-8443-exec-4 |RequestHandler
|I| This is the first request in this visit. Hidden sessionId by default.
2020-08-24 17:54:51,718 |jsse-nio-8443-exec-4 |LoginWorker   
|I| Running autoLogin check.
2020-08-24 17:54:51,817 |jsse-nio-8443-exec-4 |RequestHandler
|I| Rendering View [main].  Hidden sessionId by default.
2020-08-24 17:54:51,818 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/getUserPreferenceGroup] finished in [1] milliseconds
2020-08-24 17:54:51,856 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 17 screens in 0.035s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/CommonScreens.xml
2020-08-24 17:54:52,611 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 9 screens in 0.016s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/CartScreens.xml
2020-08-24 17:54:52,644 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 38 screens in 0.028s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/CatalogScreens.xml
2020-08-24 17:54:53,565 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [70] milliseconds
2020-08-24 17:54:53,610 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [1] milliseconds
2020-08-24 17:54:53,738 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 7 screens in 0.014s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/EmailContactListScreens.xml
2020-08-24 17:54:54,110 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 8 screens in 0.018s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/ContentScreens.xml
2020-08-24 17:54:54,111 |jsse-nio-8443-exec-4 |ProductStoreWorker
|I| getSurvey for product null
2020-08-24 17:54:54,354 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 6 screens in 0.01s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/ForumScreens.xml

2020-08-24 17:54:54,403 |jsse-nio-8443-exec-4 |ScreenFactory 
|I| Got 15 screens in 0.014s from: 
file:/C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/widget/blog/BlogScreens.xml
2020-08-24 17:54:54,864 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/getProductCategoryAndLimitedMembers] finished in 
[93] milliseconds
2020-08-24 17:54:55,303 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/getInventoryAvailableByFacility] finished in [114] 
milliseconds
2020-08-24 17:54:55,314 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [10] milliseconds
2020-08-24 17:54:55,315 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [1] milliseconds
2020-08-24 17:54:55,468 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [44] milliseconds
2020-08-24 17:54:55,469 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [1] milliseconds
2020-08-24 17:54:55,471 |jsse-nio-8443-exec-4 |ServiceDispatcher 
|T| Sync service [ecommerce/calculateProductPrice] finished in [1] milliseconds
2020-08-24 17:54:55,472 |jsse-nio-8443-exec-4 

[jira] [Comment Edited] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-24 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183271#comment-17183271
 ] 

Alex Bodnaru edited comment on OFBIZ-11955 at 8/24/20, 1:17 PM:


ok [~jleroux]

let's go to the search for wg3-.

if you wish to see both products side by side, apply the div.row patch, but 
this is not needed for now.

are you there? do you see wg- and wg3- on your screen?


was (Author: alexbodn):
ok [~jleroux]

let's go to the search for wg3-.

if you wish to see both products side by side, apply the div.row patch, but 
this is not needed for now.

are you there?

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-24 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183271#comment-17183271
 ] 

Alex Bodnaru commented on OFBIZ-11955:
--

ok [~jleroux]

let's go to the search for wg3-.

if you wish to see both products side by side, apply the div.row patch, but 
this is not needed for now.

are you there?

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11978) "cart" should be "card"

2020-08-24 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183266#comment-17183266
 ] 

Alex Bodnaru commented on OFBIZ-11978:
--

hello [~surajk]

i found it in version 17 too.

> "cart" should be "card"
> ---
>
> Key: OFBIZ-11978
> URL: https://issues.apache.org/jira/browse/OFBIZ-11978
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Assignee: Suraj Khurana
>Priority: Trivial
> Attachments: p-card-typo.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183228#comment-17183228
 ] 

Jacques Le Roux edited comment on OFBIZ-11955 at 8/24/20, 1:08 PM:
---

After loading the data again, I see the 2 products using either:
* the product tree, at the node Micro Widgets. As mentionned at OFBIZ-11975, on 
the main page, getting there using https://localhost:8443/ecomseo/ or 
https://localhost:8443/ecommerce you don't *ever* see  the category tree (not 
sure I missed to see on screen, I can't reproduce now :/). The products are 
then side by side and both "Select Unit of Measure" dropdowns work.
* The catalog search using the "WG3-" word. But then not side by side. both 
"Select Unit of Measure" dropdowns work.
* The category search shown on the page you get with the point just above (ie 
using the catalog search with the "WG3-" word). Then again both products 
side by side and "Select Unit of Measure" dropdowns work.

I wonder now what the problem is?


was (Author: jacques.le.roux):
After loading the data again, I see the 2 products using either:
* the product tree, at the node Micro Widgets. As mentionned at OFBIZ-11975, on 
the main page, getting there using https://localhost:8443/ecomseo/ or 
https://localhost:8443/ecommerce you don't *ever* see  the category tree (not 
sure I missed to see on screen, I can't reproduce now :/). The products are 
then side by side and both "Select Unit of Measure" dropdowns work.
* The catalog search using the "WG3-" word. But then not side by side. both 
"Select Unit of Measure" dropdowns work.
* The category search shown on the page you get with the point just above (ie 
using the catalog search with the "WG3-" word). Then again both products 
side by side and "Select Unit of Measure" dropdowns work.

I wonder know what the problem is?

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183263#comment-17183263
 ] 

Jacques Le Roux commented on OFBIZ-11955:
-

After doing that, as I supposed, this is not due to DB switching but much 
certainly to an interaction between getJs and ServerHit. We can forget that by 
now here. It's unrelated to this issue, just the origin of the Category tree 
not showing, which is confusin. I'll report later in OFBIZ-11686, must got now 
:)

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183232#comment-17183232
 ] 

Jacques Le Roux edited comment on OFBIZ-11955 at 8/24/20, 12:50 PM:


When you get to 
[https://localhost:8443/ecomseo/product/Micro-Chrome-Widget3-WG3-.html] the 
UOM dropdown works.

Back from there, again I don't see the Catetgory tree. I see this error in log 
which is maybe dur to using the same DB with different branches (trunk, R18 and 
R17) while testing things


{noformat}
2020-08-24 14:47:56,696 |jsse-nio-8443-exec-1 |TransactionUtil |W| Calling 
transaction setRollbackOnly; this stack trace shows where this is happening:
java.lang.Exception: rollback called in Entity Engine SQLProcessor
 at 
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:362)
 [main/:?]
 at org.apache.ofbiz.entity.jdbc.SQLProcessor.rollback(SQLProcessor.java:190) 
[main/:?]
 at org.apache.ofbiz.entity.datasource.GenericDAO.insert(GenericDAO.java:111) 
[main/:?]
 at 
org.apache.ofbiz.entity.datasource.GenericHelperDAO.create(GenericHelperDAO.java:68)
 [main/:?]
 at org.apache.ofbiz.entity.GenericDelegator.create(GenericDelegator.java:897) 
[main/:?]
 at org.apache.ofbiz.entity.GenericValue.create(GenericValue.java:76) [main/:?]
 at org.apache.ofbiz.webapp.stats.ServerHitBin.saveHit(ServerHitBin.java:538) 
[main/:?]
 at org.apache.ofbiz.webapp.stats.ServerHitBin.countHit(ServerHitBin.java:249) 
[main/:?]
 at org.apache.ofbiz.webapp.stats.ServerHitBin.countHit(ServerHitBin.java:97) 
[main/:?]
 at 
org.apache.ofbiz.webapp.stats.ServerHitBin.countRequest(ServerHitBin.java:75) 
[main/:?]
 at 
org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:367) 
[main/:?]
 at 
org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:96) 
[main/:?]
 at 
org.apache.ofbiz.product.category.SeoControlServlet.doGet(SeoControlServlet.java:87)
 [main/:?]
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:626) 
[tomcat-servlet-api-9.0.37.jar:4.0.FR]
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:733) 
[tomcat-servlet-api-9.0.37.jar:4.0.FR]
 at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53) 
[tomcat-embed-websocket-9.0.37.jar:9.0.37]
 at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 
org.apache.ofbiz.product.category.SeoContextFilter.doFilter(SeoContextFilter.java:233)
 [main/:?]
 at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 
org.apache.ofbiz.product.category.SeoContentUrlFilter.doFilter(SeoContentUrlFilter.java:101)
 [main/:?]
 at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 
org.apache.ofbiz.product.category.CatalogUrlFilter.doFilter(CatalogUrlFilter.java:328)
 [main/:?]
 at 
org.apache.ofbiz.product.category.CatalogUrlSeoFilter.doFilter(CatalogUrlSeoFilter.java:66)
 [main/:?]
 at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 
org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:185) 
[main/:?]
 at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 
org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
 [log4j-web-2.11.2.jar:2.11.2]
 at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
 [tomcat-catalina-9.0.37.jar:9.0.37]
 at 

[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183232#comment-17183232
 ] 

Jacques Le Roux commented on OFBIZ-11955:
-

When you get to 
[https://localhost:8443/ecomseo/product/Micro-Chrome-Widget3-WG3-.html] the 
UOM dropdown works.

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183231#comment-17183231
 ] 

Jacques Le Roux commented on OFBIZ-11955:
-

In "Last searches" I have:

{noformat}
Last Searches...
Clear Search History
Clear Search History Note

Search Number1
Search Refine

- Category: Micro Widgets (Include All Sub Categories)

- Catalog: Demo Catalog

- Keywords: "WG3-", where any word matches

- Exclude Variants

Search Number2
Search Refine

- Category: Demo Default Search (Include All Sub Categories)

- Keywords: "WG3-", where any word matches

- Exclude Variants

Search Number3
Search Refine

- Category: Demo Default Search (Include All Sub Categories)

- Keywords: " wg3-", where any word matches

- Exclude Variants

Search Number4
Search Refine

- Category: Demo Default Search (Include All Sub Categories)

- Keywords: " wg3-", where any word matches

- Exclude Variants

Search Number5
Search Refine

- Category: Demo Default Search (Include All Sub Categories)

- Keywords: " wg3-", where any word matches

- Exclude Variants
{noformat}


> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183228#comment-17183228
 ] 

Jacques Le Roux commented on OFBIZ-11955:
-

After loading the data again, I see the 2 products using either:
* the product tree, at the node Micro Widgets. As mentionned at OFBIZ-11975, on 
the main page, getting there using https://localhost:8443/ecomseo/ or 
https://localhost:8443/ecommerce you don't *ever* see  the category tree (not 
sure I missed to see on screen, I can't reproduce now :/). The products are 
then side by side and both "Select Unit of Measure" dropdowns work.
* The catalog search using the "WG3-" word. But then not side by side. both 
"Select Unit of Measure" dropdowns work.
* The category search shown on the page you get with the point just above (ie 
using the catalog search with the "WG3-" word). Then again both products 
side by side and "Select Unit of Measure" dropdowns work.

I wonder know what the problem is?

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11975) products loaded from xml file don't show in category

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183211#comment-17183211
 ] 

Jacques Le Roux edited comment on OFBIZ-11975 at 8/24/20, 12:36 PM:


Indeed as reported earlier in OFBIZ-11955, after loading the data with  
[variantinfojs-data.xml],  you see the "Micro Chrome Widget3" product in "Quick 
Reorder... " left column section; but not at 
https://localhost:8443/ecomseo/category/Widgets-BEST-SELL-2.html, when you 
click on the "Widget" link the main page. Maybe because "Micro Chrome Widget3" 
is not part of best selling product?

I also notice that on the main page, getting there using 
https://localhost:8443/ecomseo/ or https://localhost:8443/ecommerce you don't 
see *ever* the category tree. To not confuse more things. I'll continue my 
investigation at OFBIZ-11955.





was (Author: jacques.le.roux):
Indeed as reported earlier in OFBIZ-11955, after loading the data with  
[variantinfojs-data.xml],  you see the "Micro Chrome Widget3" product in "Quick 
Reorder... " left column section; but not at 
https://localhost:8443/ecomseo/category/Widgets-BEST-SELL-2.html, when you 
click on the "Widget" link the main page. Maybe because "Micro Chrome Widget3" 
is not part of best selling product?

I also notice that on the main page, getting there using 
https://localhost:8443/ecomseo/ or https://localhost:8443/ecommerce you don't 
see the category tree. To not confuse more things. I'll continue my 
investigation at OFBIZ-11955.




> products loaded from xml file don't show in category
> 
>
> Key: OFBIZ-11975
> URL: https://issues.apache.org/jira/browse/OFBIZ-11975
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: variantinfojs-data.xml
>
>
> i loaded the attached xml (in admin).
> the product (wg3-) shows in the product search in admin.
> it also shows in keyword search in ecomseo.
> the attached file is my example, it loads without error messages.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-24 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183215#comment-17183215
 ] 

Alex Bodnaru commented on OFBIZ-11955:
--

hello [~jleroux] ,

may we continue?

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11975) products loaded from xml file don't show in category

2020-08-24 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183213#comment-17183213
 ] 

Alex Bodnaru commented on OFBIZ-11975:
--

right, please let's go there.

> products loaded from xml file don't show in category
> 
>
> Key: OFBIZ-11975
> URL: https://issues.apache.org/jira/browse/OFBIZ-11975
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: variantinfojs-data.xml
>
>
> i loaded the attached xml (in admin).
> the product (wg3-) shows in the product search in admin.
> it also shows in keyword search in ecomseo.
> the attached file is my example, it loads without error messages.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11978) "cart" should be "card"

2020-08-24 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-11978:
-

Assignee: Suraj Khurana

> "cart" should be "card"
> ---
>
> Key: OFBIZ-11978
> URL: https://issues.apache.org/jira/browse/OFBIZ-11978
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Assignee: Suraj Khurana
>Priority: Trivial
> Attachments: p-card-typo.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11978) "cart" should be "card"

2020-08-24 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183212#comment-17183212
 ] 

Suraj Khurana commented on OFBIZ-11978:
---

Hi Alex,
Will you please confirm if this if for trunk only or update affect/s version 
accordingly.
TIA.

> "cart" should be "card"
> ---
>
> Key: OFBIZ-11978
> URL: https://issues.apache.org/jira/browse/OFBIZ-11978
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Trivial
> Attachments: p-card-typo.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11975) products loaded from xml file don't show in category

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183211#comment-17183211
 ] 

Jacques Le Roux commented on OFBIZ-11975:
-

Indeed as reported earlier in OFBIZ-11955, after loading the data with  
[variantinfojs-data.xml],  you see the "Micro Chrome Widget3" product in "Quick 
Reorder... " left column section; but not at 
https://localhost:8443/ecomseo/category/Widgets-BEST-SELL-2.html, when you 
click on the "Widget" link the main page. Maybe because "Micro Chrome Widget3" 
is not part of best selling product?

I also notice that on the main page, getting there using 
https://localhost:8443/ecomseo/ or https://localhost:8443/ecommerce you don't 
see the category tree. To not confuse more things. I'll continue my 
investigation at OFBIZ-11955.




> products loaded from xml file don't show in category
> 
>
> Key: OFBIZ-11975
> URL: https://issues.apache.org/jira/browse/OFBIZ-11975
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: variantinfojs-data.xml
>
>
> i loaded the attached xml (in admin).
> the product (wg3-) shows in the product search in admin.
> it also shows in keyword search in ecomseo.
> the attached file is my example, it loads without error messages.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11975) products loaded from xml file don't show in category

2020-08-24 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183209#comment-17183209
 ] 

Alex Bodnaru commented on OFBIZ-11975:
--

this is not a patch, but data to showcase both bugs.

this bug is some [maybe wrong] expectation of mine to list the imported product 
with the category of the product it duplicates.

> products loaded from xml file don't show in category
> 
>
> Key: OFBIZ-11975
> URL: https://issues.apache.org/jira/browse/OFBIZ-11975
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: variantinfojs-data.xml
>
>
> i loaded the attached xml (in admin).
> the product (wg3-) shows in the product search in admin.
> it also shows in keyword search in ecomseo.
> the attached file is my example, it loads without error messages.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

2020-08-24 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183205#comment-17183205
 ] 

Suraj Khurana commented on OFBIZ-11954:
---

I also faced this few days ago while working on an issue, didn't got a chance 
to look deeper.

> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM 
> memory 
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the 
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on 
> dev ML before increasing 
> org.gradle.jvmargs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-24 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183203#comment-17183203
 ] 

Suraj Khurana commented on OFBIZ-11686:
---

Hi [~jleroux],

I remember we have enabled git pre-hook for direct commits to repo and we were 
working to enable same for github PR's as well. Wasn't it done for PR's yet? So 
that anyone won't be able to add code into repo violating checkstyle rules.

 

> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11975) products loaded from xml file don't show in category

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183196#comment-17183196
 ] 

Jacques Le Roux commented on OFBIZ-11975:
-

Just as a note: [^variantinfojs-data.xml] is the same than in OFBIZ-11955


> products loaded from xml file don't show in category
> 
>
> Key: OFBIZ-11975
> URL: https://issues.apache.org/jira/browse/OFBIZ-11975
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: variantinfojs-data.xml
>
>
> i loaded the attached xml (in admin).
> the product (wg3-) shows in the product search in admin.
> it also shows in keyword search in ecomseo.
> the attached file is my example, it loads without error messages.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11978) "cart" should be "card"

2020-08-24 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183186#comment-17183186
 ] 

Alex Bodnaru commented on OFBIZ-11978:
--

thank you very much priya, 
i have quite a few open tickets.
some of them harder to explain.

> "cart" should be "card"
> ---
>
> Key: OFBIZ-11978
> URL: https://issues.apache.org/jira/browse/OFBIZ-11978
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Trivial
> Attachments: p-card-typo.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11978) "cart" should be "card"

2020-08-24 Thread Priya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183180#comment-17183180
 ] 

Priya Sharma commented on OFBIZ-11978:
--

Hi [~alexbodn], I have just updated the ticket status to patch available so 
that someone can merge it. 
Please feel free to update, if you are still working on it.

> "cart" should be "card"
> ---
>
> Key: OFBIZ-11978
> URL: https://issues.apache.org/jira/browse/OFBIZ-11978
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Trivial
> Attachments: p-card-typo.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

2020-08-24 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-11954:
-

Actually I rebotted my machine and the same appears again

> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM 
> memory 
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the 
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on 
> dev ML before increasing 
> org.gradle.jvmargs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11980) Allow logging to be disabled for getJs request

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183121#comment-17183121
 ] 

Jacques Le Roux commented on OFBIZ-11980:
-

Hi James,

It's elegant but I still see 28 of the previous 32 I referred to at 
https://issues.apache.org/jira/browse/OFBIZ-11686?focusedCommentId=17182378=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17182378

> Allow logging to be disabled for getJs request
> --
>
> Key: OFBIZ-11980
> URL: https://issues.apache.org/jira/browse/OFBIZ-11980
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11980.patch
>
>
> Hide logs related to getJs request as it doesn't provide meaningful data.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11973) enclose productsummary list in div.row to better use the screen

2020-08-24 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183118#comment-17183118
 ] 

Alex Bodnaru commented on OFBIZ-11973:
--

but there's one more patch here, 
and i didn't resolve to test it properly yet.

> enclose productsummary list in div.row to better use the screen
> ---
>
> Key: OFBIZ-11973
> URL: https://issues.apache.org/jira/browse/OFBIZ-11973
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Trivial
> Attachments: missing-div-row.patch
>
>
> as the summary says.
> showcase: the list of products from a keyword search shows products in narrow 
> summary format, but not side by side.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11973) enclose productsummary list in div.row to better use the screen

2020-08-24 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183116#comment-17183116
 ] 

Alex Bodnaru commented on OFBIZ-11973:
--

unless I'm missing something, 
here and there.

> enclose productsummary list in div.row to better use the screen
> ---
>
> Key: OFBIZ-11973
> URL: https://issues.apache.org/jira/browse/OFBIZ-11973
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Trivial
> Attachments: missing-div-row.patch
>
>
> as the summary says.
> showcase: the list of products from a keyword search shows products in narrow 
> summary format, but not side by side.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11973) enclose productsummary list in div.row to better use the screen

2020-08-24 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183115#comment-17183115
 ] 

Alex Bodnaru commented on OFBIZ-11973:
--

as you require, 
I'm separating the issues and patches
for the 2 repositories.

> enclose productsummary list in div.row to better use the screen
> ---
>
> Key: OFBIZ-11973
> URL: https://issues.apache.org/jira/browse/OFBIZ-11973
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Trivial
> Attachments: missing-div-row.patch
>
>
> as the summary says.
> showcase: the list of products from a keyword search shows products in narrow 
> summary format, but not side by side.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11917) Error message is displayed while creating order with Tax Identification and Exemption

2020-08-24 Thread Ashish Sharma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Sharma closed OFBIZ-11917.
-
Resolution: Cannot Reproduce

> Error message is displayed while creating order with Tax Identification and 
> Exemption
> -
>
> Key: OFBIZ-11917
> URL: https://issues.apache.org/jira/browse/OFBIZ-11917
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Ashish Sharma
>Assignee: Shubham Choudhary
>Priority: Minor
> Attachments: OFBIZ-11917.png
>
>
> *Step to reproduce*
> 1. Login with a valid username and password.
>  2. Navigate to 
> "[https://demo-trunk.ofbiz.apache.org/ecommerce/control/main|https://demo-trunk.ofbiz.apache.org/ecommerce/control];
>  3. Create an order with Tax Identification and Exemption
> *Actual Result:* The error message is displayed.
> *Screenprint attached*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11917) Error message is displayed while creating order with Tax Identification and Exemption

2020-08-24 Thread Ashish Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183109#comment-17183109
 ] 

Ashish Sharma commented on OFBIZ-11917:
---

Issue no more exist. Hence close the ticket.

> Error message is displayed while creating order with Tax Identification and 
> Exemption
> -
>
> Key: OFBIZ-11917
> URL: https://issues.apache.org/jira/browse/OFBIZ-11917
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Ashish Sharma
>Assignee: Shubham Choudhary
>Priority: Minor
> Attachments: OFBIZ-11917.png
>
>
> *Step to reproduce*
> 1. Login with a valid username and password.
>  2. Navigate to 
> "[https://demo-trunk.ofbiz.apache.org/ecommerce/control/main|https://demo-trunk.ofbiz.apache.org/ecommerce/control];
>  3. Create an order with Tax Identification and Exemption
> *Actual Result:* The error message is displayed.
> *Screenprint attached*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183102#comment-17183102
 ] 

Jacques Le Roux commented on OFBIZ-11926:
-

Hi Suraj,

About
bq. Some class names in JsLanguageFilesMapping.java, as there was a note in the 
file:

I think you should look at JsLanguageFileMappingCreator.java. At 1st glance I 
see no reasons why you could not change the method names.

> Checkstyle: Variable name must match pattern
> 
>
> Key: OFBIZ-11926
> URL: https://issues.apache.org/jira/browse/OFBIZ-11926
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11926-plugins.patch, OFBIZ-11926.patch
>
>
> All final data members of the class must match this naming pattern 
> '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11973) enclose productsummary list in div.row to better use the screen

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183089#comment-17183089
 ] 

Jacques Le Roux commented on OFBIZ-11973:
-

Hi Alex,

Is that in order or ecommerce UI or both?

> enclose productsummary list in div.row to better use the screen
> ---
>
> Key: OFBIZ-11973
> URL: https://issues.apache.org/jira/browse/OFBIZ-11973
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Trivial
> Attachments: missing-div-row.patch
>
>
> as the summary says.
> showcase: the list of products from a keyword search shows products in narrow 
> summary format, but not side by side.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9687) Bug in order manager main page when using Arab language

2020-08-24 Thread Mohammed Rehan Khan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183084#comment-17183084
 ] 

Mohammed Rehan Khan commented on OFBIZ-9687:


Thanks [~jleroux] !!

> Bug in order manager main page when using Arab language
> ---
>
> Key: OFBIZ-9687
> URL: https://issues.apache.org/jira/browse/OFBIZ-9687
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Jacques Le Roux
>Assignee: Mohammed Rehan Khan
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9687-Trunk.patch
>
>
> Here is the error
> {code}
> 2017-09-08 08:38:27,272 |http-nio-8459-exec-7 |ServiceDispatcher 
> |T| Sync service [order/getVisualThemeResources] finished in [1] milliseconds
> 2017-09-08 08:38:27,304 |http-nio-8459-exec-7 |ModelScreenWidget 
> |E| Error rendering widgets section [] in screen named [GlobalDecorator]: 
> freemarker.core.ParseException: Syntax error in template
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> freemarker.core.ParseException: Syntax error in template 
> "org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer@fbbee19_1000" in 
> line 1, column 185:
> Lexical error: encountered "\u0627" (1575), after "\"\u0645\u062f\u064a\u0631 
> \u0623\u0645\u0631 \u0627\u0644\u0628\u064a\u0639\\".
> at 
> freemarker.core.TokenMgrError.toParseException(TokenMgrError.java:260) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:267) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:207) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:183) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at freemarker.template.Template.(Template.java:125) 
> ~[freemarker-2.3.24-incubating.jar:2.3.24]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:103)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.executeMacro(MacroMenuRenderer.java:130)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.renderer.macro.MacroMenuRenderer.renderMenuOpen(MacroMenuRenderer.java:369)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderSimpleMenuString(ModelMenu.java:515)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelMenu.renderMenuString(ModelMenu.java:505) 
> ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Menu.renderWidgetString(ModelScreenWidget.java:1585)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  ~[ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:294)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ScreenFactory.renderReferencedScreen(ScreenFactory.java:214)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget$IncludeScreen.renderWidgetString(ModelScreenWidget.java:780)
>  [ofbiz.jar:?]
> at 
> org.apache.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
>  [ofbiz.jar:?]
> at 
> 

[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183019#comment-17183019
 ] 

Jacques Le Roux commented on OFBIZ-11686:
-

Thank you James!

> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)