[jira] [Commented] (OFBIZ-9339) adding product to purchase order auto assigned PRODUCT_ORDER_ITEM

2020-08-31 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187976#comment-17187976
 ] 

Akash Jain commented on OFBIZ-9339:
---

I researched around it and confirm that PRODUCT_ORDER_ITEM will be default if 
order item type not selected for purchase order. So, there are two ways to fix 
this issue either add 'PRODUCT_ORDER_ITEM' as an option in drop-down or simply 
show a tooltip, like, PRODUCT_ORDER_ITEM will be default / Default value will 
be PRODUCT_ORDER_ITEM / similar...

> adding product to purchase order auto assigned PRODUCT_ORDER_ITEM
> -
>
> Key: OFBIZ-9339
> URL: https://issues.apache.org/jira/browse/OFBIZ-9339
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Akash Jain
>Priority: Major
>
> When creating a purchase order. Adding an product without specifying the 
> "Item Type" is automatically given value of PRODUCT_ORDER_ITEM. The permitted 
> values should be: ASSET_ORDER_ITEM, SUPPLIES_ORDER_ITEM, INVENTORY_ORDER_ITEM 
> (as shown in the dropdown)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-7249) Error on removing scrum members

2020-08-31 Thread Akash Jain (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187935#comment-17187935
 ] 

Akash Jain commented on OFBIZ-7249:
---

Attached patch to fix reported issue.

> Error on removing scrum members
> ---
>
> Key: OFBIZ-7249
> URL: https://issues.apache.org/jira/browse/OFBIZ-7249
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Affects Versions: Release Branch 14.12, Release Branch 15.12, Trunk
>Reporter: Anurag Chandak
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-7249.patch, OFBIZ-7249.patch
>
>
> Steps to regenerate:
> - Go to Scrum --> Administration --> Scrum Members
> - Try to remove only those scrum members whose party and role type are 
> similar to product members
> - The following error is shown:
> {code}
> The Following Errors Occurred:
> Error:Error doing entity-auto operation for entity PartyRole in service 
> deletePartyRole: org.ofbiz.entity.GenericEntityException: 
> org.ofbiz.entity.GenericDataSourceException: Exception while deleting the 
> following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)) (Exception 
> while deleting the following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)))
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-7249) Error on removing scrum members

2020-08-31 Thread Akash Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Akash Jain updated OFBIZ-7249:
--
Attachment: OFBIZ-7249.patch

> Error on removing scrum members
> ---
>
> Key: OFBIZ-7249
> URL: https://issues.apache.org/jira/browse/OFBIZ-7249
> Project: OFBiz
>  Issue Type: Bug
>  Components: scrum
>Affects Versions: Release Branch 14.12, Release Branch 15.12, Trunk
>Reporter: Anurag Chandak
>Assignee: Akash Jain
>Priority: Major
> Attachments: OFBIZ-7249.patch, OFBIZ-7249.patch
>
>
> Steps to regenerate:
> - Go to Scrum --> Administration --> Scrum Members
> - Try to remove only those scrum members whose party and role type are 
> similar to product members
> - The following error is shown:
> {code}
> The Following Errors Occurred:
> Error:Error doing entity-auto operation for entity PartyRole in service 
> deletePartyRole: org.ofbiz.entity.GenericEntityException: 
> org.ofbiz.entity.GenericDataSourceException: Exception while deleting the 
> following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)) (Exception 
> while deleting the following entity: 
> [GenericEntity:PartyRole][partyId,SCRUMASTER(java.lang.String)][roleTypeId,SCRUM_MASTER(java.lang.String)]
>  (SQL Exception while executing the following:DELETE FROM OFBIZ.PARTY_ROLE 
> WHERE PARTY_ID=? AND ROLE_TYPE_ID=? (DELETE on table 'PARTY_ROLE' caused a 
> violation of foreign key constraint 'PROD_RLE_PTYRLE' for key 
> (SCRUMASTER,SCRUM_MASTER). The statement has been rolled back.)))
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187924#comment-17187924
 ] 

ASF subversion and git services commented on OFBIZ-11328:
-

Commit fb8cae5df45ae7598558034eaab68676e92f2472 in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=fb8cae5 ]

Fixed: Issue with service out schema for nested attributes (OFBIZ-11328)


> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187918#comment-17187918
 ] 

Jacques Le Roux commented on OFBIZ-11686:
-

bq. I don't know what happened 3 days ago. 

Oh, I guess I did updated framework but not plugins, my bad anyway :/

> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187918#comment-17187918
 ] 

Jacques Le Roux edited comment on OFBIZ-11686 at 8/31/20, 5:52 PM:
---

bq. I don't know what happened 3 days ago. 

Oh, I guess I did update framework but not plugins, my bad anyway :/


was (Author: jacques.le.roux):
bq. I don't know what happened 3 days ago. 

Oh, I guess I did updated framework but not plugins, my bad anyway :/

> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187916#comment-17187916
 ] 

Jacques Le Roux commented on OFBIZ-11686:
-

Hi James, 

Sorry, I don't know what happened 3 days ago. 

It's already in for 6 days with 
https://github.com/apache/ofbiz-plugins/commit/1c9f2ab9c65f5fae2ff346183fb27592acc69ae5/
 and it's OK here. 
There is also 
https://github.com/apache/ofbiz-framework/commit/fd85450c4dd331b15056d3aca8127583633b5caa/,
 looks like there are no longer any problems. I let you close, if you think so 
:)

> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11980) Allow logging to be disabled for getJs request

2020-08-31 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11980.
---
Resolution: Implemented

Works, thanks James!

> Allow logging to be disabled for getJs request
> --
>
> Key: OFBIZ-11980
> URL: https://issues.apache.org/jira/browse/OFBIZ-11980
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11980.patch, OFBIZ-11980.patch, OFBIZ-11980.patch
>
>
> Hide logs related to getJs request as it doesn't provide meaningful data.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag

2020-08-31 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187800#comment-17187800
 ] 

James Yong commented on OFBIZ-11686:


Hi Jacques,

Can check track-serverhit="false" for uri="getJs" at 
plugins/ecommerce/webapp/ecommerce/WEB-INF/controller.xml?
{code:java}

 
 
 
{code}

Regards,
James
 

> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new  widget tag that adds an external script after 
> body tag.
> The external script will contain the rendered result of the specified 
> template file location.
>  e.g.
> {code:xml}
> 
>  
> {code}
> 
>  will render as:
> {code:xml}
> 
>  type="application/javascript"/> 
> 
> {code}
> This will allow inline script from a freemarker file, to be rendered as 
> external script in html.
>  
>  Discussion was started at 
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>  
> *15th May 2020*
> While extracting the scripts from html-template to script-template and 
> testing the changes, I found the process to be cumbersome.
>  So I made a change not to use script-template tag but add a multi-block 
> attribute to html-template tag.
>  When *multi-block=true*, inline scripts will be extracted automatically from 
> script tag and converted to external script. 
>  So no need to manually extract script from the existing freemarker template. 
>  Coding for script-template tag is removed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11980) Allow logging to be disabled for getJs request

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187785#comment-17187785
 ] 

ASF subversion and git services commented on OFBIZ-11980:
-

Commit 61a714c6d18dbec6c9ec57a118a352daa435176b in ofbiz-framework's branch 
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=61a714c ]

Improved: Allow logging to be disabled for getJs request (OFBIZ-11980)

Try fixing error compiling OFBizDynamicThresholdFilter.java in Buildbot

Thanks Jacques for reporting


> Allow logging to be disabled for getJs request
> --
>
> Key: OFBIZ-11980
> URL: https://issues.apache.org/jira/browse/OFBIZ-11980
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11980.patch, OFBIZ-11980.patch, OFBIZ-11980.patch
>
>
> Hide logs related to getJs request as it doesn't provide meaningful data.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

2020-08-31 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187776#comment-17187776
 ] 

Suraj Khurana commented on OFBIZ-11921:
---

Thanks Jacques for review.

Both the patches are loaded into trunk and this fixed around *1020* checkstyle 
issues.

> Checkstyle: Line is longer than 150 characters
> --
>
> Key: OFBIZ-11921
> URL: https://issues.apache.org/jira/browse/OFBIZ-11921
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, 
> OFBIZ-11921.patch, OFBIZ-plugins-11921.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187772#comment-17187772
 ] 

ASF subversion and git services commented on OFBIZ-11921:
-

Commit 6dfc3c19e756dba7d0563d4fc8e920a72cc8bef9 in ofbiz-plugins's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=6dfc3c1 ]

Improved: Corrected some extra spaces and naming conventions related checkstyle 
issues.
(OFBIZ-11921)
Also fixed some access modifiers for some private class members. Thanks Jacques 
Le Roux for review.


> Checkstyle: Line is longer than 150 characters
> --
>
> Key: OFBIZ-11921
> URL: https://issues.apache.org/jira/browse/OFBIZ-11921
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, 
> OFBIZ-11921.patch, OFBIZ-plugins-11921.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187770#comment-17187770
 ] 

ASF subversion and git services commented on OFBIZ-11921:
-

Commit ca9fa4fba49fe7391bd6b6e681729aaef66fc78f in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ca9fa4f ]

Improved: Corrected line is longer than 150 characters checkstyle issues in 
framework and applications component.
(OFBIZ-11921)
Also fixed some extra spaces and naming conventions related checkstyle issues.
Thanks Jacques for review.


> Checkstyle: Line is longer than 150 characters
> --
>
> Key: OFBIZ-11921
> URL: https://issues.apache.org/jira/browse/OFBIZ-11921
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, 
> OFBIZ-11921.patch, OFBIZ-plugins-11921.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

2020-08-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187678#comment-17187678
 ] 

Jacques Le Roux commented on OFBIZ-11921:
-

After a cursorily review of the framework patch: +1 for commit both

> Checkstyle: Line is longer than 150 characters
> --
>
> Key: OFBIZ-11921
> URL: https://issues.apache.org/jira/browse/OFBIZ-11921
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, 
> OFBIZ-11921.patch, OFBIZ-plugins-11921.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11946) Upgrade Gradle to V6.5.1

2020-08-31 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-11946:

Description: To Gradle upgrade, I ran: ./gradlew wrapper 
--gradle-version=6.5.1 --distribution-type=bin   (was: To Gradle upgrade, I 
ran: ./gradlew wrapper --gradle-version=6.3 --distribution-type=bin )

> Upgrade Gradle to V6.5.1
> 
>
> Key: OFBIZ-11946
> URL: https://issues.apache.org/jira/browse/OFBIZ-11946
> Project: OFBiz
>  Issue Type: Improvement
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> To Gradle upgrade, I ran: ./gradlew wrapper --gradle-version=6.5.1 
> --distribution-type=bin 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

2020-08-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187675#comment-17187675
 ] 

Jacques Le Roux edited comment on OFBIZ-11954 at 8/31/20, 12:12 PM:


Thanks Suraj,

So maybe the best solution is to revert Gradle to 6.3


was (Author: jacques.le.roux):
So maybe the best solution is to revert Gradle to 6.3

> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM 
> memory 
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the 
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on 
> dev ML before increasing 
> org.gradle.jvmargs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

2020-08-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187675#comment-17187675
 ] 

Jacques Le Roux commented on OFBIZ-11954:
-

So maybe the best solution is to revert Gradle to 6.3

> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM 
> memory 
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the 
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on 
> dev ML before increasing 
> org.gradle.jvmargs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11921) Checkstyle: Line is longer than 150 characters

2020-08-31 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187661#comment-17187661
 ] 

Suraj Khurana commented on OFBIZ-11921:
---

Yes, this one of plugins is kind of mixed and thus small, nothing major of same 
kind left in plugins. :) 

> Checkstyle: Line is longer than 150 characters
> --
>
> Key: OFBIZ-11921
> URL: https://issues.apache.org/jira/browse/OFBIZ-11921
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-11921-2.patch, OFBIZ-11921-plugins-2.patch, 
> OFBIZ-11921.patch, OFBIZ-plugins-11921.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187652#comment-17187652
 ] 

ASF subversion and git services commented on OFBIZ-11328:
-

Commit 0f8ca8cbcc551c457a095702406edabf57761444 in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=0f8ca8c ]

Fixed: Removed unncessary check for userLogin claim
2. Modified code to return 401 instead of 403 in case JWT auth fails.
(OFBIZ-11328)


> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187639#comment-17187639
 ] 

ASF subversion and git services commented on OFBIZ-11328:
-

Commit 3174bd92ec9b46fc781cd9550955bdaeece9af54 in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=3174bd9 ]

Fixed: Issue with checking Authentication Scheme(OFBIZ-11328)


> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-31 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187632#comment-17187632
 ] 

Alex Bodnaru commented on OFBIZ-11955:
--

not yet, i wish to fine-tune further

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, 
> variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

2020-08-31 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187630#comment-17187630
 ] 

Suraj Khurana commented on OFBIZ-11954:
---

Hi Jacques,

I faced it on both, Linux (18.04) as well as Mac OS (Catalina).
HTH.

> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM 
> memory 
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the 
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on 
> dev ML before increasing 
> org.gradle.jvmargs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11954) Expiring Daemon because JVM heap space is exhausted

2020-08-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187611#comment-17187611
 ] 

Jacques Le Roux commented on OFBIZ-11954:
-

Hi Suraj,

I guess you use a *nix machine, right? Because I wonder if it's a "Windows 7" 
issue only...

> Expiring Daemon because JVM heap space is exhausted
> ---
>
> Key: OFBIZ-11954
> URL: https://issues.apache.org/jira/browse/OFBIZ-11954
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Today I got this in log out of the blue:
> {quote}
> Daemon will be stopped at the end of the build after running out of JVM 
> memory 
> Expiring Daemon because JVM heap space is exhausted
> {quote}
> I checked there was no OutOfMemoryError exception. And apart that in log the 
> applications were running well
> The most relevant articles I found on the Net were:
> https://stackoverflow.com/questions/56075455/expiring-daemon-because-jvm-heap-space-is-exhausted
> https://medium.com/@tiwarishani/expiring-daemon-because-jvm-heap-space-is-exhausted-in-react-native-e17c2248c8af
> I'm not sure this issue will reproduce (why just now?). I'll discuss this on 
> dev ML before increasing 
> org.gradle.jvmargs



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (OFBIZ-11980) Allow logging to be disabled for getJs request

2020-08-31 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-11980:
-

Hi James,

I reopen, it's easily reproductible if you remove the plugins

> Allow logging to be disabled for getJs request
> --
>
> Key: OFBIZ-11980
> URL: https://issues.apache.org/jira/browse/OFBIZ-11980
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11980.patch, OFBIZ-11980.patch, OFBIZ-11980.patch
>
>
> Hide logs related to getJs request as it doesn't provide meaningful data.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187571#comment-17187571
 ] 

Jacques Le Roux commented on OFBIZ-11955:
-

Alex, 

I let you decide if we should close

> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, 
> variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187569#comment-17187569
 ] 

ASF subversion and git services commented on OFBIZ-11955:
-

Commit 8a5107e498f5d9fc03be2f1c39baafbc13e5f1e8 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8a5107e ]

Fixed: display/selection of unit of measure is broken (OFBIZ-11955)

Fixes UOM dropdown for products like WG-9943

Thanks: Alex


> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, 
> variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187567#comment-17187567
 ] 

ASF subversion and git services commented on OFBIZ-11955:
-

Commit 26075f06a84fff2e84c7fdb79cdcabed6e56fbdf in ofbiz-framework's branch 
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=26075f0 ]

Fixed: display/selection of unit of measure is broken (OFBIZ-11955)

Fixes UOM dropdown for products like WG-9943

Thanks: Alex


> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, 
> variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187568#comment-17187568
 ] 

ASF subversion and git services commented on OFBIZ-11955:
-

Commit d670f3671301825f3bdc0bab7ae3592e0c9d3519 in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d670f36 ]

Fixed: display/selection of unit of measure is broken (OFBIZ-11955)

Fixes UOM dropdown for products like WG-9943

Thanks: Alex


> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, 
> variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11993) display/selection of unit of measure is broken/plugins

2020-08-31 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11993.
---
Fix Version/s: 17.12.05
   18.12.01
   Resolution: Fixed

> display/selection of unit of measure is broken/plugins
> --
>
> Key: OFBIZ-11993
> URL: https://issues.apache.org/jira/browse/OFBIZ-11993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>  Labels: patch
> Fix For: 18.12.01, 17.12.05
>
> Attachments: p-variantinfojs-1.patch, p-variantinfojs-2.patch
>
>
> allow selection of uom for multiple products on the same web page



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11993) display/selection of unit of measure is broken/plugins

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187545#comment-17187545
 ] 

ASF subversion and git services commented on OFBIZ-11993:
-

Commit bf60a20d9d712f78fc8de807d0677b0619b7a96d in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=bf60a20 ]

Fixed: display/selection of unit of measure is broken/plugins (OFBIZ-11993)

Allows selection of uom for multiple products on the same web page

Thanks: Alex


> display/selection of unit of measure is broken/plugins
> --
>
> Key: OFBIZ-11993
> URL: https://issues.apache.org/jira/browse/OFBIZ-11993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>  Labels: patch
> Attachments: p-variantinfojs-1.patch, p-variantinfojs-2.patch
>
>
> allow selection of uom for multiple products on the same web page



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11993) display/selection of unit of measure is broken/plugins

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187544#comment-17187544
 ] 

ASF subversion and git services commented on OFBIZ-11993:
-

Commit ab61110dc5243eca60b24b8c8cb56386b4e982fe in ofbiz-plugins's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=ab61110 ]

Fixed: display/selection of unit of measure is broken/plugins (OFBIZ-11993)

Allows selection of uom for multiple products on the same web page

Thanks: Alex


> display/selection of unit of measure is broken/plugins
> --
>
> Key: OFBIZ-11993
> URL: https://issues.apache.org/jira/browse/OFBIZ-11993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>  Labels: patch
> Attachments: p-variantinfojs-1.patch, p-variantinfojs-2.patch
>
>
> allow selection of uom for multiple products on the same web page



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11993) display/selection of unit of measure is broken/plugins

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187543#comment-17187543
 ] 

ASF subversion and git services commented on OFBIZ-11993:
-

Commit 1ada36d74df296293d4df6559d7afe4253c22934 in ofbiz-plugins's branch 
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=1ada36d ]

Fixed: display/selection of unit of measure is broken/plugins (OFBIZ-11993)

Allows selection of uom for multiple products on the same web page

Thanks: Alex


> display/selection of unit of measure is broken/plugins
> --
>
> Key: OFBIZ-11993
> URL: https://issues.apache.org/jira/browse/OFBIZ-11993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>  Labels: patch
> Attachments: p-variantinfojs-1.patch, p-variantinfojs-2.patch
>
>
> allow selection of uom for multiple products on the same web page



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-5040) Backend widget & application HTML clean-up

2020-08-31 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5040.
--
Resolution: Won't Do

> Backend widget & application HTML clean-up
> --
>
> Key: OFBIZ-5040
> URL: https://issues.apache.org/jira/browse/OFBIZ-5040
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Paul Piper
>Priority: Major
>  Labels: css, ftl, html, webapp, widget, widgetrendering
>
> I am sure that this is a common thing to know: the current backoffice 
> application relies heavily on widgets. This is good, but the current 
> standard-html-structure is not flexible enough and often lacks proper w3c 
> implementation. 
> To make matters worse, you can often find applications avoiding widgets at 
> all and rather overriding the standards with custom ftl implementations. It 
> is these customizations that break the html on numerous screens and make it 
> difficult, if not tedious to create new themes for the backoffice. 
> This task is hence to:
> * Find a consensus on a new widget standard
> * Go over each of the application ftls and convert these to the new standard 
> * Recreate the themes and simplify/clean-up special rules
> Since redoing the theme is a rather large task, we should consider to add an 
> additional css for now which stylises the replacement html instead of working 
> with the old. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9994) Improves service-eca.xsd documentation

2020-08-31 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187505#comment-17187505
 ] 

ASF subversion and git services commented on OFBIZ-9994:


Commit b263ddc2d2ff7c4439e6b92447945d808392b47f in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b263ddc ]

Revert "Improved: Improves service-eca.xsd documentation  (OFBIZ-9994)"

This reverts commit 0231626f1c1b39390a2a6bc6aa80dba0bf5aa6b5. These changes
should not have been backported


> Improves service-eca.xsd documentation 
> ---
>
> Key: OFBIZ-9994
> URL: https://issues.apache.org/jira/browse/OFBIZ-9994
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> service-eca.xsd seriously lacks documentation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10302) Display/functionality improvement in findParty of OOTB regarding classification group

2020-08-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187503#comment-17187503
 ] 

Jacques Le Roux commented on OFBIZ-10302:
-

+1 for commit after review (no test)

> Display/functionality  improvement in findParty of OOTB regarding 
> classification group
> --
>
> Key: OFBIZ-10302
> URL: https://issues.apache.org/jira/browse/OFBIZ-10302
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: 16.11.04
>Reporter: Rajesh Kumar Mallah
>Assignee: Akash Jain
>Priority: Minor
> Attachments: OFBIZ-10302.patch, OFBIZ-10302.patch, Screenshot 
> 2018-03-21 23-18-40.png, Screenshot 2018-03-21 23-19-06.png
>
>
> If a classification Group exists in system the multi-select dropdown only 
> displays the 
> type id of classification not the description of the classification group. 
> Additionally there seems to be a defect that this filter does not really work
> at all.
>  
> regds
> -- mallah.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11993) display/selection of unit of measure is broken/plugins

2020-08-31 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187490#comment-17187490
 ] 

Alex Bodnaru commented on OFBIZ-11993:
--

i think 2 includes 1.
could you please reverse 1?

> display/selection of unit of measure is broken/plugins
> --
>
> Key: OFBIZ-11993
> URL: https://issues.apache.org/jira/browse/OFBIZ-11993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>  Labels: patch
> Attachments: p-variantinfojs-1.patch, p-variantinfojs-2.patch
>
>
> allow selection of uom for multiple products on the same web page



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11994) deprecation warnings in build

2020-08-31 Thread Alex Bodnaru (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187487#comment-17187487
 ] 

Alex Bodnaru commented on OFBIZ-11994:
--

sure, thanks

> deprecation warnings in build
> -
>
> Key: OFBIZ-11994
> URL: https://issues.apache.org/jira/browse/OFBIZ-11994
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>
> i'm getting these warnings when building with openjdk 11, i think
> /apache/ofbiz/security/CsrfUtil.java:73: warning: [deprecation] newInstance() 
> in Class has been deprecated
>  setStrategy((ICsrfDefenseStrategy) c.newInstance());
>  ^
>  where T is a type-variable:
>  T extends Object declared in class Class
> /usr/local/src/ofbiz/trunk/ofbiz-framework/plugins/ofbiz-rest-impl/src/main/java/org/apache/ofbiz/ws/rs/openapi/OFBizOpenApiReader.java:211:
>  warning: [deprecation] newInstance() in Class has been deprecated
>  schema = (Schema) schemaClass.newInstance();
>  ^
>  where T is a type-variable:
>  T extends Object declared in class Class
> /usr/local/src/ofbiz/trunk/ofbiz-framework/plugins/ofbiz-rest-impl/src/main/java/org/apache/ofbiz/ws/rs/openapi/OFBizOpenApiReader.java:234:
>  warning: [deprecation] newInstance() in Class has been deprecated
>  schema = (Schema) schemaClass.newInstance();
>  ^
>  where T is a type-variable:
>  T extends Object declared in class Class
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11993) display/selection of unit of measure is broken/plugins

2020-08-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187481#comment-17187481
 ] 

Jacques Le Roux commented on OFBIZ-11993:
-

Alex,

Please merge your patches in a sole one. It's impossible to apply them one 
after the other.

> display/selection of unit of measure is broken/plugins
> --
>
> Key: OFBIZ-11993
> URL: https://issues.apache.org/jira/browse/OFBIZ-11993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>  Labels: patch
> Attachments: p-variantinfojs-1.patch, p-variantinfojs-2.patch
>
>
> allow selection of uom for multiple products on the same web page



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11994) deprecation warnings in build

2020-08-31 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187472#comment-17187472
 ] 

Jacques Le Roux commented on OFBIZ-11994:
-

Hi Alex,

I guess, you know we only officially support Java 8 for now (see OFBIZ-10757)? 
Can be useful later though...

> deprecation warnings in build
> -
>
> Key: OFBIZ-11994
> URL: https://issues.apache.org/jira/browse/OFBIZ-11994
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>
> i'm getting these warnings when building with openjdk 11, i think
> /apache/ofbiz/security/CsrfUtil.java:73: warning: [deprecation] newInstance() 
> in Class has been deprecated
>  setStrategy((ICsrfDefenseStrategy) c.newInstance());
>  ^
>  where T is a type-variable:
>  T extends Object declared in class Class
> /usr/local/src/ofbiz/trunk/ofbiz-framework/plugins/ofbiz-rest-impl/src/main/java/org/apache/ofbiz/ws/rs/openapi/OFBizOpenApiReader.java:211:
>  warning: [deprecation] newInstance() in Class has been deprecated
>  schema = (Schema) schemaClass.newInstance();
>  ^
>  where T is a type-variable:
>  T extends Object declared in class Class
> /usr/local/src/ofbiz/trunk/ofbiz-framework/plugins/ofbiz-rest-impl/src/main/java/org/apache/ofbiz/ws/rs/openapi/OFBizOpenApiReader.java:234:
>  warning: [deprecation] newInstance() in Class has been deprecated
>  schema = (Schema) schemaClass.newInstance();
>  ^
>  where T is a type-variable:
>  T extends Object declared in class Class
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)