[jira] [Commented] (OFBIZ-10303) Add a Global Glossary for Documentation Guides

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196265#comment-17196265
 ] 

Jacques Le Roux commented on OFBIZ-10303:
-

bq. + at the end of line are same as 
thanks

> Add a Global Glossary for Documentation Guides
> --
>
> Key: OFBIZ-10303
> URL: https://issues.apache.org/jira/browse/OFBIZ-10303
> Project: OFBiz
>  Issue Type: Task
>Reporter: Olivier Heintz
>Priority: Minor
> Attachments: 
> OFBIZ-10303_Documented-Add-a-Global-Glossary-for-user-documentat.patch, 
> humanres.adoc.patch, ofbiz-glossary.adoc, ofbiz-glossary.adoc, 
> ofbiz-glossary.adoc, user-manual.adoc.patch
>
>
> Create a ofbiz-glossary.adoc in _include directory at the top level (near 
> user-manual.adoc and developer-manual.adoc)
> This file will be used for all terms which are global to ofbiz (not link to a 
> component).
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11036) User Manual : change the level of from 2 to 1

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196264#comment-17196264
 ] 

Jacques Le Roux commented on OFBIZ-11036:
-

Thanks, I think I'll continue as I do now :)

> User Manual : change the level  of  from 2 to 1
> --
>
> Key: OFBIZ-11036
> URL: https://issues.apache.org/jira/browse/OFBIZ-11036
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Kaustubh Choudhary
>Priority: Minor
> Attachments: 
> 0001-Documented-User-Manual-change-the-level-of-Core-Busi.patch
>
>
> If  is on level 1,  it become a main separator in 
> TOC not a chapter
>   TOC become
> {code:java}
> ...
>  2. Quick start
>  Core Business Applications
>      3. Accounting
>      4. Human Resources
>  {code}
> and so we have one more level (in TOC) for each application



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10251) Move Human Resources Guide into OFBiz Asciidoc Framework

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196262#comment-17196262
 ] 

Jacques Le Roux commented on OFBIZ-10251:
-

I see no problems with that.

> Move Human Resources Guide into OFBiz Asciidoc Framework
> 
>
> Key: OFBIZ-10251
> URL: https://issues.apache.org/jira/browse/OFBIZ-10251
> Project: OFBiz
>  Issue Type: Task
>Reporter: Sharan Foga
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: asciidoc, documentation, humanres
> Attachments: introduction.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is a general umbrella issue for managing the creation and migration of 
> all OFBiz related Human Resources documentation into the OFBiz code base.
> Subtasks will be created for each of the documents that need to be created. 
> Also created as a sub task will the task to create empty documents for each 
> of the sub-files in the list
> An initial list is as follows:
>  # human-resources.adoc
>  # human-resources-intro.adoc
>  # employee-evaluations.adoc
>  # human-resources-glossary.adoc
>  # employee-positions.adoc
>  # employees.adoc
>  # employments.adoc
>  # performance-review.adoc
>  # positions.adoc
>  # qualifications.adoc
>  # recruitment.adoc
>  # skiils.adoc
>  # resumes.adoc
>  # training.adoc
>  # leave.adoc
>  # human-resources-security.adoc
>  # human-resources-global-settings.adoc
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11995) Define schema for RESTFul resources mapping.

2020-09-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196197#comment-17196197
 ] 

ASF subversion and git services commented on OFBIZ-11995:
-

Commit 476b42a15df5b60d2d83d0b6a9c3cdf8e52bc69a in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=476b42a ]

Implemented: Added support to read Rest XML DSL definitions(OFBIZ-11995)


> Define schema for RESTFul resources mapping.
> 
>
> Key: OFBIZ-11995
> URL: https://issues.apache.org/jira/browse/OFBIZ-11995
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Major
> Attachments: rest-api.xsd
>
>
> As a developer, I need to have the ability to define REST resources using XML 
> DSL allowing to plug in OFBiz services to the resources that can serve the 
> HTTP requests.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10251) Move Human Resources Guide into OFBiz Asciidoc Framework

2020-09-15 Thread Olivier Heintz (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196181#comment-17196181
 ] 

Olivier Heintz commented on OFBIZ-10251:


Thank you very mush for the review,

You are right, currently there are still some points to discuss.
I think, it's necessary to have a ready to read place for the different tasks, 
it's why I update the patch after the main part of docbook migration to 
asciidoc.

I propose to finish first, the docbook migration to asccidoc (only 2-3 commit, 
one or two week), before starting the discussion.

> Move Human Resources Guide into OFBiz Asciidoc Framework
> 
>
> Key: OFBIZ-10251
> URL: https://issues.apache.org/jira/browse/OFBIZ-10251
> Project: OFBiz
>  Issue Type: Task
>Reporter: Sharan Foga
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: asciidoc, documentation, humanres
> Attachments: introduction.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is a general umbrella issue for managing the creation and migration of 
> all OFBiz related Human Resources documentation into the OFBiz code base.
> Subtasks will be created for each of the documents that need to be created. 
> Also created as a sub task will the task to create empty documents for each 
> of the sub-files in the list
> An initial list is as follows:
>  # human-resources.adoc
>  # human-resources-intro.adoc
>  # employee-evaluations.adoc
>  # human-resources-glossary.adoc
>  # employee-positions.adoc
>  # employees.adoc
>  # employments.adoc
>  # performance-review.adoc
>  # positions.adoc
>  # qualifications.adoc
>  # recruitment.adoc
>  # skiils.adoc
>  # resumes.adoc
>  # training.adoc
>  # leave.adoc
>  # human-resources-security.adoc
>  # human-resources-global-settings.adoc
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11036) User Manual : change the level of from 2 to 1

2020-09-15 Thread Olivier Heintz (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196175#comment-17196175
 ] 

Olivier Heintz commented on OFBIZ-11036:


to apply patch generated by git format-patch, you have just to do (after 
downloading the patch file)

git am 
this apply the patch by adding a commit in your environment so it's better to 
do it on a local test branch

it's very similar to a PR with only one commit

> User Manual : change the level  of  from 2 to 1
> --
>
> Key: OFBIZ-11036
> URL: https://issues.apache.org/jira/browse/OFBIZ-11036
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Kaustubh Choudhary
>Priority: Minor
> Attachments: 
> 0001-Documented-User-Manual-change-the-level-of-Core-Busi.patch
>
>
> If  is on level 1,  it become a main separator in 
> TOC not a chapter
>   TOC become
> {code:java}
> ...
>  2. Quick start
>  Core Business Applications
>      3. Accounting
>      4. Human Resources
>  {code}
> and so we have one more level (in TOC) for each application



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10303) Add a Global Glossary for Documentation Guides

2020-09-15 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-10303:
---
Attachment: (was: 
OFBIZ-10303_Documented-Add-a-Global-Glossary-for-user-documentat.patch)

> Add a Global Glossary for Documentation Guides
> --
>
> Key: OFBIZ-10303
> URL: https://issues.apache.org/jira/browse/OFBIZ-10303
> Project: OFBiz
>  Issue Type: Task
>Reporter: Olivier Heintz
>Priority: Minor
> Attachments: 
> OFBIZ-10303_Documented-Add-a-Global-Glossary-for-user-documentat.patch, 
> humanres.adoc.patch, ofbiz-glossary.adoc, ofbiz-glossary.adoc, 
> ofbiz-glossary.adoc, user-manual.adoc.patch
>
>
> Create a ofbiz-glossary.adoc in _include directory at the top level (near 
> user-manual.adoc and developer-manual.adoc)
> This file will be used for all terms which are global to ofbiz (not link to a 
> component).
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10303) Add a Global Glossary for Documentation Guides

2020-09-15 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-10303:
---
Attachment: 
OFBIZ-10303_Documented-Add-a-Global-Glossary-for-user-documentat.patch

> Add a Global Glossary for Documentation Guides
> --
>
> Key: OFBIZ-10303
> URL: https://issues.apache.org/jira/browse/OFBIZ-10303
> Project: OFBiz
>  Issue Type: Task
>Reporter: Olivier Heintz
>Priority: Minor
> Attachments: 
> OFBIZ-10303_Documented-Add-a-Global-Glossary-for-user-documentat.patch, 
> humanres.adoc.patch, ofbiz-glossary.adoc, ofbiz-glossary.adoc, 
> ofbiz-glossary.adoc, user-manual.adoc.patch
>
>
> Create a ofbiz-glossary.adoc in _include directory at the top level (near 
> user-manual.adoc and developer-manual.adoc)
> This file will be used for all terms which are global to ofbiz (not link to a 
> component).
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10303) Add a Global Glossary for Documentation Guides

2020-09-15 Thread Olivier Heintz (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196165#comment-17196165
 ] 

Olivier Heintz commented on OFBIZ-10303:


Thanks you very much for the review,

I have made some corrections, and some other later ;)
I should finish the docbook to asciidoc before, and the previous patch update 
was only to be able to have an environment with all my pending modifications on 
documentation to publish them on ofbizextra documentation websitewebsite

Some component are not yet link to corresponding chapter because when I have 
created this first release, asciidoc for these components not exist

+ at the end of line are same as 

> Add a Global Glossary for Documentation Guides
> --
>
> Key: OFBIZ-10303
> URL: https://issues.apache.org/jira/browse/OFBIZ-10303
> Project: OFBiz
>  Issue Type: Task
>Reporter: Olivier Heintz
>Priority: Minor
> Attachments: 
> OFBIZ-10303_Documented-Add-a-Global-Glossary-for-user-documentat.patch, 
> humanres.adoc.patch, ofbiz-glossary.adoc, ofbiz-glossary.adoc, 
> ofbiz-glossary.adoc, user-manual.adoc.patch
>
>
> Create a ofbiz-glossary.adoc in _include directory at the top level (near 
> user-manual.adoc and developer-manual.adoc)
> This file will be used for all terms which are global to ofbiz (not link to a 
> component).
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-09-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196146#comment-17196146
 ] 

ASF subversion and git services commented on OFBIZ-11926:
-

Commit 346c63bfdf89be1354291ff2d8c4f564930d50c2 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=346c63b ]

Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)

We have a lot of "do nothing" in Java code. In case of catch we should at least
have Debug.logError(e, MODULE); and maybe an explanation in the comment.


> Checkstyle: Variable name must match pattern
> 
>
> Key: OFBIZ-11926
> URL: https://issues.apache.org/jira/browse/OFBIZ-11926
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, 
> OFBIZ-11926.patch
>
>
> All final data members of the class must match this naming pattern 
> '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-09-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196147#comment-17196147
 ] 

ASF subversion and git services commented on OFBIZ-11926:
-

Commit 6ac7dc934adb0329f7fd585d46cd6cc7c72dd1d3 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=6ac7dc9 ]

Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)

We have a lot of "do nothing" in Java code. In case of catch we should at least
have Debug.logError(e, MODULE); and maybe an explanation in the comment.


> Checkstyle: Variable name must match pattern
> 
>
> Key: OFBIZ-11926
> URL: https://issues.apache.org/jira/browse/OFBIZ-11926
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, 
> OFBIZ-11926.patch
>
>
> All final data members of the class must match this naming pattern 
> '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-09-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196149#comment-17196149
 ] 

ASF subversion and git services commented on OFBIZ-11926:
-

Commit 418f7d6242eaaee85e1cbd5f47fb527225df86af in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=418f7d6 ]

Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)

Slightly decreases tasks.checkstyleMain.maxErrors from 545 to 543


> Checkstyle: Variable name must match pattern
> 
>
> Key: OFBIZ-11926
> URL: https://issues.apache.org/jira/browse/OFBIZ-11926
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, 
> OFBIZ-11926.patch
>
>
> All final data members of the class must match this naming pattern 
> '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11995) Define schema for RESTFul resources mapping.

2020-09-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196101#comment-17196101
 ] 

ASF subversion and git services commented on OFBIZ-11995:
-

Commit 93f5b6f4fb09c7e558c8a1615e97175d9316e198 in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=93f5b6f ]

Improved: Corrected formatting(OFBIZ-11995)


> Define schema for RESTFul resources mapping.
> 
>
> Key: OFBIZ-11995
> URL: https://issues.apache.org/jira/browse/OFBIZ-11995
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Major
> Attachments: rest-api.xsd
>
>
> As a developer, I need to have the ability to define REST resources using XML 
> DSL allowing to plug in OFBiz services to the resources that can serve the 
> HTTP requests.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11995) Define schema for RESTFul resources mapping.

2020-09-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196070#comment-17196070
 ] 

ASF subversion and git services commented on OFBIZ-11995:
-

Commit dabca1e416cb129d51e76cc90f0847674547f5f9 in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=dabca1e ]

Improved: Structural changes in the OpenAPI reader to allow for reading 
resources defined in XML schema(OFBIZ-11995)


> Define schema for RESTFul resources mapping.
> 
>
> Key: OFBIZ-11995
> URL: https://issues.apache.org/jira/browse/OFBIZ-11995
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Major
> Attachments: rest-api.xsd
>
>
> As a developer, I need to have the ability to define REST resources using XML 
> DSL allowing to plug in OFBiz services to the resources that can serve the 
> HTTP requests.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11995) Define schema for RESTFul resources mapping.

2020-09-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196035#comment-17196035
 ] 

ASF subversion and git services commented on OFBIZ-11995:
-

Commit 2a85d30fddfcd269f7a41ea66e779239b5c4f4ef in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=2a85d30 ]

Fixed: javadoc generation error fixed. Dereferenced 'Service' link (OFBIZ-11995)


> Define schema for RESTFul resources mapping.
> 
>
> Key: OFBIZ-11995
> URL: https://issues.apache.org/jira/browse/OFBIZ-11995
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Major
> Attachments: rest-api.xsd
>
>
> As a developer, I need to have the ability to define REST resources using XML 
> DSL allowing to plug in OFBiz services to the resources that can serve the 
> HTTP requests.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #43: Fixed: javadoc generation error fixed. Dereferenced 'Service' link (OFBIZ-11995)

2020-09-15 Thread GitBox


sonarcloud[bot] commented on pull request #43:
URL: https://github.com/apache/ofbiz-plugins/pull/43#issuecomment-692620920


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=43=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=43=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=43=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=43=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=43=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=43=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=43=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_
 ofbiz-plugins=43=false=SECURITY_HOTSPOT) to review) 
 
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=43=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=43=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=43=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=43)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=43=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] girishvasmatkar closed pull request #43: Fixed: javadoc generation error fixed. Dereferenced 'Service' link (OFBIZ-11995)

2020-09-15 Thread GitBox


girishvasmatkar closed pull request #43:
URL: https://github.com/apache/ofbiz-plugins/pull/43


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] girishvasmatkar opened a new pull request #43: Fixed: javadoc generation error fixed. Dereferenced 'Service' link (OFBIZ-11995)

2020-09-15 Thread GitBox


girishvasmatkar opened a new pull request #43:
URL: https://github.com/apache/ofbiz-plugins/pull/43


   Fixed: javadoc generation error fixed. Dereferenced 'Service' link 
(OFBIZ-11995)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #42: WIP: Model classes added corresponding to REST XML schema

2020-09-15 Thread GitBox


sonarcloud[bot] commented on pull request #42:
URL: https://github.com/apache/ofbiz-plugins/pull/42#issuecomment-692544188


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=42=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=42=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=42=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=42=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=42=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=42=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=42=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_
 ofbiz-plugins=42=false=SECURITY_HOTSPOT) to review) 
 
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=42=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=42=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=42=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=42)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=42=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] girishvasmatkar merged pull request #42: WIP: Model classes added corresponding to REST XML schema

2020-09-15 Thread GitBox


girishvasmatkar merged pull request #42:
URL: https://github.com/apache/ofbiz-plugins/pull/42


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] girishvasmatkar opened a new pull request #42: WIP: Model classes added corresponding to REST XML schema

2020-09-15 Thread GitBox


girishvasmatkar opened a new pull request #42:
URL: https://github.com/apache/ofbiz-plugins/pull/42


   Implemented: Added Model classes for the corresponding XML schema 
(OFBIZ-11995)
   
   Explanation
   First in a series of commits. This commit adds Model classes corresponding 
to the proposed XML schema file. The implementation may change in future.
   
   Thanks:
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11039) add a chapter "About this documentation"

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195931#comment-17195931
 ] 

Jacques Le Roux commented on OFBIZ-11039:
-

I have cursorily reviewed and applied the patch. I have mostly put my comments 
in the umbrella Jira: OFBIZ-10251

> add a chapter "About this documentation"
> 
>
> Key: OFBIZ-11039
> URL: https://issues.apache.org/jira/browse/OFBIZ-11039
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Major
> Fix For: Trunk
>
> Attachments: Employee_Main_Screen.png, 
> HR-Employee_Submenu_Rainbow_Stone.png, HR-Employee_Submenu_Tomahawk.png, 
> HR_Application_Submenu_Rainbow_Stone.png, 
> HR_Application_Submenu_Tomahawk.png, 
> OFBIZ-11039_Documented-add-a-chapter-About-this-documentation-in.patch, 
> hr-about-doc.adoc
>
>
> This chapter present the main OFBiz GUI rules with some screenshot and link 
> between tutorial and video of "Scenario GUI Test"
> Currently it's in HR, but when other application will be done it can be 
> generalize and go to User Manual introduction.
> The file hr-about-doc.adoc associated with this task is included via a 
> include:: line in the humanres.adoc



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11027) HR Doc, Associated a scenario UI test for each process

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195932#comment-17195932
 ] 

Jacques Le Roux commented on OFBIZ-11027:
-

I have cursorily reviewed and applied the patch. I have mostly put my comments 
in the umbrella Jira: OFBIZ-10251

> HR Doc, Associated a scenario UI test for each process
> --
>
> Key: OFBIZ-11027
> URL: https://issues.apache.org/jira/browse/OFBIZ-11027
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: Documentation, humanres, tutorial
> Attachments: 
> OFBIZ-11027_Documented-HR-Doc-Associated-a-scenario-UI-test-for-.patch, 
> OFBIZ-11027_hr-intro.adoc.patch, hr-tuto-define-company-organization.adoc, 
> hr-tuto-employment-and-salary.adoc
>
>
> I propose that in HR documentation, each process is described via a scenario 
> explained like a tutorial.
> To realize the tutorial, and to have more quality, I propose to create a UI 
> Test for each process.
> In these tests, some user messages are added and a video recording is in 
> place when it run, so result is usable as a tutorial
> With this method to create tutorial we are sure it are up to date and it 
> works !
> Currently a tutorial / test exist for process "Organization, Job Position and 
> Definition" and it run ona daily base on Apache OFBiz trunk demo.
> A second one exist for process "Employee Salary and Benefits Administration" 
> but for runing some modification /enhancement are needed, so currenlty it not 
> run on Apache OFBiz trunk demo.
> Result video are readeable 
> https://video.ploud.fr/video-channels/ofbizextra_tutorial/videos  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11036) User Manual : change the level of from 2 to 1

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195930#comment-17195930
 ] 

Jacques Le Roux commented on OFBIZ-11036:
-

I have cursorily reviewed and applied the patch. I have mostly put my comments 
in the umbrella Jira: OFBIZ-10251

> User Manual : change the level  of  from 2 to 1
> --
>
> Key: OFBIZ-11036
> URL: https://issues.apache.org/jira/browse/OFBIZ-11036
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Kaustubh Choudhary
>Priority: Minor
> Attachments: 
> 0001-Documented-User-Manual-change-the-level-of-Core-Busi.patch
>
>
> If  is on level 1,  it become a main separator in 
> TOC not a chapter
>   TOC become
> {code:java}
> ...
>  2. Quick start
>  Core Business Applications
>      3. Accounting
>      4. Human Resources
>  {code}
> and so we have one more level (in TOC) for each application



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11026) HR Doc drive by process

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195929#comment-17195929
 ] 

Jacques Le Roux commented on OFBIZ-11026:
-

I have cursorily reviewed and applied the patch. I have mostly put my comments 
in the umbrella Jira: OFBIZ-10251

> HR Doc drive by process
> ---
>
> Key: OFBIZ-11026
> URL: https://issues.apache.org/jira/browse/OFBIZ-11026
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Michael Brohl
>Priority: Major
>  Labels: Documentation, humanres
> Attachments: 
> OFBIZ-11026_Documented-HR-Doc-drive-by-process-OFBIZ-11026.patch, 
> OFBIZ-11026_hr-intro.adoc.patch, OFBIZ-11026_humanres.adoc.patch, 
> OFBIZ-11026_humanres.adoc_with_hr-about-doc.patch
>
>
> Currently HR doc main chapters are on core HR object, I propose to group them 
> in a chapter and having a chapter by process in the same level bot group in 
> the HR Process.
> Each process is described via a scenario explained like a tutorial, and each 
> time a core object is used, a link is done to its chapter.
> To help review : doc with these modifications are available at 
> [https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources]
> and Apache OFBiz standard (without modifications) is available too at 
> https://ofbizadoc.ofbizextra.org/html5/user-manual-std.html#_human_resources
> current HR TOC
>  --
>  3.2. Human Resources
>      3.2.1. About Human Resources
>      3.2.2. Human Resources Processes
>      3.2.3. Employee Positions
>      3.2.4. Employees
>      3.2.5. Employments
>      3.2.6. Performance Review
>      3.2.7. Qualifications
>      3.2.8. Recruitment
>      3.2.9. Skills
>      3.2.10. Resumes
>      3.2.11. Training
>      3.2.12. Leave
>      3.2.13. Security
>      3.2.14. Global HR Settings
>      3.2.15. Glossary
>  Proposed HR TOC
>  
>  4. Human Resources
>      4.1. About this documentation
>      4.2. About Human Resources
>      4.3. HR Processes
>      4.3.1. Organization, Job Position and Definition
>      4.3.2. Recruitment, Candidate Selection and Hiring
>      4.3.3. Employee Training and Development
>      4.3.4. Performance Management and Employee Evaluation
>      4.3.5. Employee Salary and Benefits Administration
>      4.4. HR core object
>      4.4.1. Employee Positions
>      4.4.2. Employees
>      4.4.3. Employments
>      4.4.4. Performance Review
>      4.4.5. Qualifications
>      4.4.6. Recruitment
>      4.4.7. Skills
>      4.4.8. Resumes
>      4.4.9. Training
>      4.4.10. Leave
>      4.4.11. Security
>      4.5. Global HR Settings
>      4.5.1. Skills Types
>      4.6. HR Data model
>      4.6.1. Employee Position
>      4.6.2. Employment
>      4.6.3. Qualification, Skill, Review
>      4.6.4. HR App intra-application integration
>      4.7. Glossary



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11026) HR Doc drive by process

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195928#comment-17195928
 ] 

Jacques Le Roux commented on OFBIZ-11026:
-

Olivier, the link in the description don't work, I mean
{quote} To help review : doc with these modifications are available at 
[https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources 
|https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources]
 and Apache OFBiz standard (without modifications) is available too at 
[https://ofbizadoc.ofbizextra.org/html5/user-manual-std.html#_human_resources]
{quote}

> HR Doc drive by process
> ---
>
> Key: OFBIZ-11026
> URL: https://issues.apache.org/jira/browse/OFBIZ-11026
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Michael Brohl
>Priority: Major
>  Labels: Documentation, humanres
> Attachments: 
> OFBIZ-11026_Documented-HR-Doc-drive-by-process-OFBIZ-11026.patch, 
> OFBIZ-11026_hr-intro.adoc.patch, OFBIZ-11026_humanres.adoc.patch, 
> OFBIZ-11026_humanres.adoc_with_hr-about-doc.patch
>
>
> Currently HR doc main chapters are on core HR object, I propose to group them 
> in a chapter and having a chapter by process in the same level bot group in 
> the HR Process.
> Each process is described via a scenario explained like a tutorial, and each 
> time a core object is used, a link is done to its chapter.
> To help review : doc with these modifications are available at 
> [https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources]
> and Apache OFBiz standard (without modifications) is available too at 
> https://ofbizadoc.ofbizextra.org/html5/user-manual-std.html#_human_resources
> current HR TOC
>  --
>  3.2. Human Resources
>      3.2.1. About Human Resources
>      3.2.2. Human Resources Processes
>      3.2.3. Employee Positions
>      3.2.4. Employees
>      3.2.5. Employments
>      3.2.6. Performance Review
>      3.2.7. Qualifications
>      3.2.8. Recruitment
>      3.2.9. Skills
>      3.2.10. Resumes
>      3.2.11. Training
>      3.2.12. Leave
>      3.2.13. Security
>      3.2.14. Global HR Settings
>      3.2.15. Glossary
>  Proposed HR TOC
>  
>  4. Human Resources
>      4.1. About this documentation
>      4.2. About Human Resources
>      4.3. HR Processes
>      4.3.1. Organization, Job Position and Definition
>      4.3.2. Recruitment, Candidate Selection and Hiring
>      4.3.3. Employee Training and Development
>      4.3.4. Performance Management and Employee Evaluation
>      4.3.5. Employee Salary and Benefits Administration
>      4.4. HR core object
>      4.4.1. Employee Positions
>      4.4.2. Employees
>      4.4.3. Employments
>      4.4.4. Performance Review
>      4.4.5. Qualifications
>      4.4.6. Recruitment
>      4.4.7. Skills
>      4.4.8. Resumes
>      4.4.9. Training
>      4.4.10. Leave
>      4.4.11. Security
>      4.5. Global HR Settings
>      4.5.1. Skills Types
>      4.6. HR Data model
>      4.6.1. Employee Position
>      4.6.2. Employment
>      4.6.3. Qualification, Skill, Review
>      4.6.4. HR App intra-application integration
>      4.7. Glossary



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-10251) Move Human Resources Guide into OFBiz Asciidoc Framework

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195919#comment-17195919
 ] 

Jacques Le Roux edited comment on OFBIZ-10251 at 9/15/20, 7:11 AM:
---

Hi Olivier,

I'm currently reviewing subtasks here. I noticed a point: you use ofbizextra 
and relations to it in subtasks patches. I see no harm doing so, but I think we 
should 1st discuss that in dev ML to be sure things are clear for everyone.

BTW, I believe it should be better to move these resources to "big files" (ie 
under https://ofbiz-vm3.apache.org/) like 
https://cwiki.apache.org/confluence/display/OFBIZ/Framework+Introduction+Videos+and+Diagrams
 are in https://ofbiz-vm3.apache.org/FrameworkIntro/


was (Author: jacques.le.roux):
Hi Olivier,

I'm currently reviewing subtasks here. I noticed a point: you use ofbizextra 
and relations to it in subtasks patches. I see no harm doing so, but I think we 
should 1st discuss that in dev ML to be sure things are clear for everyone.

BTW, I believe it should be better to move these resource to "big files" (ie 
under https://ofbiz-vm3.apache.org/) like 
https://cwiki.apache.org/confluence/display/OFBIZ/Framework+Introduction+Videos+and+Diagrams
 are in https://ofbiz-vm3.apache.org/FrameworkIntro/

> Move Human Resources Guide into OFBiz Asciidoc Framework
> 
>
> Key: OFBIZ-10251
> URL: https://issues.apache.org/jira/browse/OFBIZ-10251
> Project: OFBiz
>  Issue Type: Task
>Reporter: Sharan Foga
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: asciidoc, documentation, humanres
> Attachments: introduction.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is a general umbrella issue for managing the creation and migration of 
> all OFBiz related Human Resources documentation into the OFBiz code base.
> Subtasks will be created for each of the documents that need to be created. 
> Also created as a sub task will the task to create empty documents for each 
> of the sub-files in the list
> An initial list is as follows:
>  # human-resources.adoc
>  # human-resources-intro.adoc
>  # employee-evaluations.adoc
>  # human-resources-glossary.adoc
>  # employee-positions.adoc
>  # employees.adoc
>  # employments.adoc
>  # performance-review.adoc
>  # positions.adoc
>  # qualifications.adoc
>  # recruitment.adoc
>  # skiils.adoc
>  # resumes.adoc
>  # training.adoc
>  # leave.adoc
>  # human-resources-security.adoc
>  # human-resources-global-settings.adoc
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-10251) Move Human Resources Guide into OFBiz Asciidoc Framework

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195919#comment-17195919
 ] 

Jacques Le Roux edited comment on OFBIZ-10251 at 9/15/20, 7:10 AM:
---

Hi Olivier,

I'm currently reviewing subtasks here. I noticed a point: you use ofbizextra 
and relations to it in subtasks patches. I see no harm doing so, but I think we 
should 1st discuss that in dev ML to be sure things are clear for everyone.

BTW, I believe it should be better to move these resource to "big files" (ie 
under https://ofbiz-vm3.apache.org/) like 
https://cwiki.apache.org/confluence/display/OFBIZ/Framework+Introduction+Videos+and+Diagrams
 are in https://ofbiz-vm3.apache.org/FrameworkIntro/


was (Author: jacques.le.roux):
Hi Olivier,

I'm currently reviewing subtasks here. I noticed a point: you use ofbizextra 
and relations to it in subtasks patches. I see no harm doing so, but I think we 
should 1st discuss that in dev ML to be sure things are clear for everyone.

> Move Human Resources Guide into OFBiz Asciidoc Framework
> 
>
> Key: OFBIZ-10251
> URL: https://issues.apache.org/jira/browse/OFBIZ-10251
> Project: OFBiz
>  Issue Type: Task
>Reporter: Sharan Foga
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: asciidoc, documentation, humanres
> Attachments: introduction.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is a general umbrella issue for managing the creation and migration of 
> all OFBiz related Human Resources documentation into the OFBiz code base.
> Subtasks will be created for each of the documents that need to be created. 
> Also created as a sub task will the task to create empty documents for each 
> of the sub-files in the list
> An initial list is as follows:
>  # human-resources.adoc
>  # human-resources-intro.adoc
>  # employee-evaluations.adoc
>  # human-resources-glossary.adoc
>  # employee-positions.adoc
>  # employees.adoc
>  # employments.adoc
>  # performance-review.adoc
>  # positions.adoc
>  # qualifications.adoc
>  # recruitment.adoc
>  # skiils.adoc
>  # resumes.adoc
>  # training.adoc
>  # leave.adoc
>  # human-resources-security.adoc
>  # human-resources-global-settings.adoc
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11036) User Manual : change the level of from 2 to 1

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195920#comment-17195920
 ] 

Jacques Le Roux commented on OFBIZ-11036:
-

Hi Olivier,

You said
bq.  (apply it with git am)
I'm not used to git am (I use either patch, git apply or more often simply 
apply in IDE). Reading https://git-scm.com/docs/git-am they say
bq. Splits mail messages in a mailbox into commit log message, authorship 
information and patches, and applies them to the current branch.
How do you use it from a Jira, or else?

> User Manual : change the level  of  from 2 to 1
> --
>
> Key: OFBIZ-11036
> URL: https://issues.apache.org/jira/browse/OFBIZ-11036
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Kaustubh Choudhary
>Priority: Minor
> Attachments: 
> 0001-Documented-User-Manual-change-the-level-of-Core-Busi.patch
>
>
> If  is on level 1,  it become a main separator in 
> TOC not a chapter
>   TOC become
> {code:java}
> ...
>  2. Quick start
>  Core Business Applications
>      3. Accounting
>      4. Human Resources
>  {code}
> and so we have one more level (in TOC) for each application



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10251) Move Human Resources Guide into OFBiz Asciidoc Framework

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195919#comment-17195919
 ] 

Jacques Le Roux commented on OFBIZ-10251:
-

Hi Olivier,

I'm currently reviewing subtasks here. I noticed a point: you use ofbizextra 
and relations to it in subtasks patches. I see no harm doing so, but I think we 
should 1st discuss that in dev ML to be sure things are clear for everyone.

> Move Human Resources Guide into OFBiz Asciidoc Framework
> 
>
> Key: OFBIZ-10251
> URL: https://issues.apache.org/jira/browse/OFBIZ-10251
> Project: OFBiz
>  Issue Type: Task
>Reporter: Sharan Foga
>Assignee: Michael Brohl
>Priority: Minor
>  Labels: asciidoc, documentation, humanres
> Attachments: introduction.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is a general umbrella issue for managing the creation and migration of 
> all OFBiz related Human Resources documentation into the OFBiz code base.
> Subtasks will be created for each of the documents that need to be created. 
> Also created as a sub task will the task to create empty documents for each 
> of the sub-files in the list
> An initial list is as follows:
>  # human-resources.adoc
>  # human-resources-intro.adoc
>  # employee-evaluations.adoc
>  # human-resources-glossary.adoc
>  # employee-positions.adoc
>  # employees.adoc
>  # employments.adoc
>  # performance-review.adoc
>  # positions.adoc
>  # qualifications.adoc
>  # recruitment.adoc
>  # skiils.adoc
>  # resumes.adoc
>  # training.adoc
>  # leave.adoc
>  # human-resources-security.adoc
>  # human-resources-global-settings.adoc
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-09-15 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195909#comment-17195909
 ] 

Suraj Khurana commented on OFBIZ-11926:
---

Yes, +1 to have this for all "do nothing" kind of code occurences. It should be 
atleast logged properly. 

> Checkstyle: Variable name must match pattern
> 
>
> Key: OFBIZ-11926
> URL: https://issues.apache.org/jira/browse/OFBIZ-11926
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, 
> OFBIZ-11926.patch
>
>
> All final data members of the class must match this naming pattern 
> '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195905#comment-17195905
 ] 

Jacques Le Roux commented on OFBIZ-11926:
-

Hi Suraj,

Since we have only 10 of them and it's not a big deal I suggest that we handle 
them by hand. I tried to put a semicolon but I then got "Instruction vide" (ie 
Empty instruction). What do you suggest?

I also noticed that we have a lot of "do nothing" in Java code. I'll have a 
look at those. In case of catch we should at least have {{Debug.logError(e, 
MODULE);}} and maybe an explanation in the comment.

> Checkstyle: Variable name must match pattern
> 
>
> Key: OFBIZ-11926
> URL: https://issues.apache.org/jira/browse/OFBIZ-11926
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: JsLanguageFilesMapping.patch, OFBIZ-11926-plugins.patch, 
> OFBIZ-11926.patch
>
>
> All final data members of the class must match this naming pattern 
> '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10303) Add a Global Glossary for Documentation Guides

2020-09-15 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195893#comment-17195893
 ] 

Jacques Le Roux commented on OFBIZ-10303:
-

Hi Olivier,

I very like it (did not apply just reviewed).

I'd replace "ofbiz "by "OFBiz" in "and with ofbiz plugins you can find 
application more business specifics" :) 
Also
why "Key Users" has Capitals? 
technicaly should be technically
Why some, like <<_accounting>> are surrounded by << >> but not some like 
Product management?
Why do we have "+" at end of lines like?
{noformat}
+type entities, like BenefitType for HR. +  
+
+[NOTE]
+For creation, as Primary keys must be entered manually apply the ID general 
advice. +
{noformat}


> Add a Global Glossary for Documentation Guides
> --
>
> Key: OFBIZ-10303
> URL: https://issues.apache.org/jira/browse/OFBIZ-10303
> Project: OFBiz
>  Issue Type: Task
>Reporter: Olivier Heintz
>Priority: Minor
> Attachments: 
> OFBIZ-10303_Documented-Add-a-Global-Glossary-for-user-documentat.patch, 
> humanres.adoc.patch, ofbiz-glossary.adoc, ofbiz-glossary.adoc, 
> ofbiz-glossary.adoc, user-manual.adoc.patch
>
>
> Create a ofbiz-glossary.adoc in _include directory at the top level (near 
> user-manual.adoc and developer-manual.adoc)
> This file will be used for all terms which are global to ofbiz (not link to a 
> component).
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)