[jira] [Updated] (OFBIZ-12031) Move SeoConfigUtil.java from Product to Widget component
[ https://issues.apache.org/jira/browse/OFBIZ-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Yong updated OFBIZ-12031: --- Description: SeoConfigUtil contains helper methods for SEO Configuration. When constructing links like getJs, need to use SeoConfigUtil to check whether to exclude control path to avoid redirection in ecomseo. Propose to move SeoConfigUtil from product to widget component. was: SeoConfigUtil contains helper methods for SEO Configuration. When constructing links like getJs, need to use SeoConfigUtil to check whether to include control path to avoid redirection in ecomseo. Propose to move SeoConfigUtil from product to widget component. > Move SeoConfigUtil.java from Product to Widget component > > > Key: OFBIZ-12031 > URL: https://issues.apache.org/jira/browse/OFBIZ-12031 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > > SeoConfigUtil contains helper methods for SEO Configuration. > When constructing links like getJs, need to use SeoConfigUtil to check > whether to exclude control path to avoid redirection in ecomseo. > Propose to move SeoConfigUtil from product to widget component. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12031) Move SeoConfigUtil.java from Product to Widget component
James Yong created OFBIZ-12031: -- Summary: Move SeoConfigUtil.java from Product to Widget component Key: OFBIZ-12031 URL: https://issues.apache.org/jira/browse/OFBIZ-12031 Project: OFBiz Issue Type: Improvement Components: base Affects Versions: Upcoming Branch Reporter: James Yong Assignee: James Yong Fix For: Upcoming Branch SeoConfigUtil contains helper methods for SEO Configuration. When constructing links like getJs, need to use SeoConfigUtil to check whether to include control path to avoid redirection in ecomseo. Propose to move SeoConfigUtil from product to widget component. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203252#comment-17203252
]
James Yong commented on OFBIZ-12018:
Hi Jacques,
Still WIP for named borders in ecomseo.
Regards,
James
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11686) multi-block attribute for html-template tag
[
https://issues.apache.org/jira/browse/OFBIZ-11686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203245#comment-17203245
]
ASF subversion and git services commented on OFBIZ-11686:
-
Commit 91d8a2f02ab9b7366a722e29feaeba7661468614 in ofbiz-framework's branch
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=91d8a2f ]
Improved: multi-block attribute for html-template tag (OFBIZ-11686)
Form getJs link according to SEO Config setting
> multi-block attribute for html-template tag
> ---
>
> Key: OFBIZ-11686
> URL: https://issues.apache.org/jira/browse/OFBIZ-11686
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11686.patch, OFBIZ-11686.patch, OFBIZ-11686.patch
>
>
> Propose a new widget tag that adds an external script after
> body tag.
> The external script will contain the rendered result of the specified
> template file location.
> e.g.
> {code:xml}
>
>
> {code}
>
> will render as:
> {code:xml}
>
> type="application/javascript"/>
>
> {code}
> This will allow inline script from a freemarker file, to be rendered as
> external script in html.
>
> Discussion was started at
> [https://lists.apache.org/thread.html/r7f8db3a8f5de057c5c5ca6c00608e477acfeaf5507a20b72b8daa3a8%40%3Cdev.ofbiz.apache.org%3E]
>
> *15th May 2020*
> While extracting the scripts from html-template to script-template and
> testing the changes, I found the process to be cumbersome.
> So I made a change not to use script-template tag but add a multi-block
> attribute to html-template tag.
> When *multi-block=true*, inline scripts will be extracted automatically from
> script tag and converted to external script.
> So no need to manually extract script from the existing freemarker template.
> Coding for script-template tag is removed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12018) Open FTL File from browser
[
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203242#comment-17203242
]
ASF subversion and git services commented on OFBIZ-12018:
-
Commit c9110198568e988e65ba6b9d3881b7edb60254cc in ofbiz-framework's branch
refs/heads/trunk from James Yong
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c911019 ]
Improved: Open FTL File from browser (OFBIZ-12018)
Better usability when clicking on named border
> Open FTL File from browser
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-12030) Help system can be on user language (help using asciidoc files)
Olivier Heintz created OFBIZ-12030: -- Summary: Help system can be on user language (help using asciidoc files) Key: OFBIZ-12030 URL: https://issues.apache.org/jira/browse/OFBIZ-12030 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Olivier Heintz Previous help system, using docbook and content component was able to be on multiple language. The goal of this Jira is to propose a solution for the help system using asciidoc files. Currently there are not a lot of files which are not in English (less than 10) but it's necessary to have a solution for users / customers which use ofbiz documentation system as the internal process documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203227#comment-17203227 ] ASF subversion and git services commented on OFBIZ-11587: - Commit 9eaf180a4bbddbb66436ab9fec064f53ba9fd1fb in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9eaf180 ] Documented: migration to help system using asciidoc files (OFBIZ-11587) Add Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203180#comment-17203180 ] ASF subversion and git services commented on OFBIZ-11587: - Commit 19a97b5819c5c2ab92fcc9742af42d09df8a4c7e in ofbiz-plugins's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=19a97b5 ] Documented: ofbiz-plugins / Example, migration of docbook help files to asciidoc, forgot on previous commit to add example in plugins-user-manual (OFBIZ-11587) > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7675) Investigate if we should turn Freemarker autoescaping on
[
https://issues.apache.org/jira/browse/OFBIZ-7675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203123#comment-17203123
]
Jacques Le Roux commented on OFBIZ-7675:
Hi Deepak,
Today working on OFBIZ-12029 I tried to simply make the changes in
FreeMarkerWorker class and *MacroLibrary.ftl. Found, as you already reported
above - and more, that it's more complicated and decided again to not do it.
> Investigate if we should turn Freemarker autoescaping on
>
>
> Key: OFBIZ-7675
> URL: https://issues.apache.org/jira/browse/OFBIZ-7675
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Deepak Dixit
>Priority: Minor
> Attachments: OFBIZ-7675-plugins.patch, OFBIZ-7675.patch
>
>
> At OFBIZ-7041 [~f...@14x.net] suggested that we turn Freemarker autoescaping
> on. Quoting him there:
> {quote}
> This new version of FreeMarker includes auto-escaping and output formats. The
> <#escape> directive has been deprecated. Notice the comment at the very end
> of this page:
> "FreeMarker automatically escapes all values printed ... if it's properly
> configured (that's the responsibility of the programmers; [see here
> how|http://freemarker.org/docs/pgui_config_outputformatsautoesc.html])."
> Would be good to turn autoescaping on, and set the configuration to match
> .ftl as HTML and .fo.ftl as XML.
> {quote}
> [~pfm.smits] asked
> {quote}
> If we are going down that path I guess we have to visit a lot of Freemarker
> template files, right?
> {quote}
> Here is my answer
> {quote}
> We don' t use any <#escape> directives in all OFBiz. We have a couple of
> <#noescape> which should be replaced by <#noautoesc>. So I agree we could set
> the Freemarker environement to auto-escaping, and test if it has not
> unexpected side-effects.
> Could be that this will fix or complicate the issue I crossed (at bottom) of
> OFBIZ-7041 and more recently at OFBIZ-7343, let's see...
> {quote}
> Reply
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12029) Handle special characters like single quote in Freemarker template (prevent encoding)
[ https://issues.apache.org/jira/browse/OFBIZ-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203086#comment-17203086 ] Jacques Le Roux commented on OFBIZ-12029: - I continue in the thread referenced in the description... > Handle special characters like single quote in Freemarker template (prevent > encoding) > - > > Key: OFBIZ-12029 > URL: https://issues.apache.org/jira/browse/OFBIZ-12029 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12029-StringUtil.wrapString-plugins.patch, > OFBIZ-12029-StringUtil.wrapString.patch > > > A such case was reported by Amit Gadaley at > https://markmail.org/message/ybyjkngdiwrywut6 > The solution is to use StringUtil.wrapString() to prevent encoding. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12029) Handle special characters like single quote in Freemarker template (prevent encoding)
[ https://issues.apache.org/jira/browse/OFBIZ-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12029: Attachment: OFBIZ-12029-StringUtil.wrapString.patch > Handle special characters like single quote in Freemarker template (prevent > encoding) > - > > Key: OFBIZ-12029 > URL: https://issues.apache.org/jira/browse/OFBIZ-12029 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12029-StringUtil.wrapString-plugins.patch, > OFBIZ-12029-StringUtil.wrapString.patch > > > A such case was reported by Amit Gadaley at > https://markmail.org/message/ybyjkngdiwrywut6 > The solution is to use StringUtil.wrapString() to prevent encoding. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12029) Handle special characters like single quote in Freemarker template (prevent encoding)
[ https://issues.apache.org/jira/browse/OFBIZ-12029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12029: Attachment: OFBIZ-12029-StringUtil.wrapString-plugins.patch > Handle special characters like single quote in Freemarker template (prevent > encoding) > - > > Key: OFBIZ-12029 > URL: https://issues.apache.org/jira/browse/OFBIZ-12029 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12029-StringUtil.wrapString-plugins.patch, > OFBIZ-12029-StringUtil.wrapString.patch > > > A such case was reported by Amit Gadaley at > https://markmail.org/message/ybyjkngdiwrywut6 > The solution is to use StringUtil.wrapString() to prevent encoding. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12029) Handle special characters like single quote in Freemarker template (prevent encoding)
Jacques Le Roux created OFBIZ-12029: --- Summary: Handle special characters like single quote in Freemarker template (prevent encoding) Key: OFBIZ-12029 URL: https://issues.apache.org/jira/browse/OFBIZ-12029 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS, ALL PLUGINS Affects Versions: Trunk Reporter: Jacques Le Roux A such case was reported by Amit Gadaley at https://markmail.org/message/ybyjkngdiwrywut6 The solution is to use StringUtil.wrapString() to prevent encoding. -- This message was sent by Atlassian Jira (v8.3.4#803005)
