[jira] [Updated] (OFBIZ-12037) Bug in seed data for UomType / Uom

2020-10-05 Thread ddev (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ddev updated OFBIZ-12037:
-
Description: 
I found a problem in the seed data.  The kilogram, is under the wrong measure 
type.  The kilogram is a unit of mass, not a unit of weight. 

Explanation: The weight of a product/object changes with altitude, the mass 
does not.  (example: If you want to lower your mass, then you need to diet, but 
if you just want to weigh less, then just live on mars.)

(These are easy to confuse because of a naming collision:  there is a unit of 
mass called the pound and also unit of force called the pound)

Basically, we should change:



 To be:
 
 

 

With seperate Uoms under each UomType

 

Update: I've also found power Uom's in the ENERGY_MEASURE

 

  was:
I found a problem in the seed data.  The kilogram, is under the wrong measure 
type.  The kilogram is a unit of mass, not a unit of weight. 

Explanation: The weight of a product/object changes with altitude, the mass 
does not.  (example: If you want to lower your mass, then you need to diet, but 
if you just want to weigh less, then just live on mars.)

(These are easy to confuse because of a naming collision:  there is a unit of 
mass called the pound and also unit of force called the pound)

Basically, we should change:



 To be:
 
 

 

With seperate Uoms under each UomType

 


> Bug in seed data for UomType / Uom
> --
>
> Key: OFBIZ-12037
> URL: https://issues.apache.org/jira/browse/OFBIZ-12037
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Reporter: ddev
>Priority: Minor
>
> I found a problem in the seed data.  The kilogram, is under the wrong measure 
> type.  The kilogram is a unit of mass, not a unit of weight. 
> Explanation: The weight of a product/object changes with altitude, the mass 
> does not.  (example: If you want to lower your mass, then you need to diet, 
> but if you just want to weigh less, then just live on mars.)
> (These are easy to confuse because of a naming collision:  there is a unit of 
> mass called the pound and also unit of force called the pound)
> Basically, we should change:
> 
>  To be:
>  
>  
>  
> With seperate Uoms under each UomType
>  
> Update: I've also found power Uom's in the ENERGY_MEASURE
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-12037) Bug in seed data for UomType / Uom

2020-10-05 Thread ddev (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206307#comment-17206307
 ] 

ddev edited comment on OFBIZ-12037 at 10/5/20, 5:22 PM:


 

How would we handle erasing "WEIGHT_MEASURE"? 

 

If we erase the "weight measure" type and the related Uom's from the seed data, 
and someone already wrote a ofbiz application that did a "where UomType = 
'WEIGHT_MEASURE'" kind of thing, it would break that for them when they went to 
set up their new installation.

 

We could tell those people who were upgrading to use the new seed data, but 
then  they would still have the old data laying around.

 

What's the expected way to handle something like this?

 


was (Author: ddev):
 

How would we handle erasing "WEIGHT_MEASURE"?  

 

If we erasing the "weight measure" type and the related Uom's from the seed 
data, and someone already wrote a ofbiz application that did a "where UomType = 
'WEIGHT_MEASURE'" kind of thing, it would break that for them when they went to 
set up their new installation.

 

We could tell those people who were upgrading to use the new seed data, but 
then  they would still have the old data laying around.

 

What's the expected way to handle something like this?

 

> Bug in seed data for UomType / Uom
> --
>
> Key: OFBIZ-12037
> URL: https://issues.apache.org/jira/browse/OFBIZ-12037
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Reporter: ddev
>Priority: Minor
>
> I found a problem in the seed data.  The kilogram, is under the wrong measure 
> type.  The kilogram is a unit of mass, not a unit of weight. 
> Explanation: The weight of a product/object changes with altitude, the mass 
> does not.  (example: If you want to lower your mass, then you need to diet, 
> but if you just want to weigh less, then just live on mars.)
> (These are easy to confuse because of a naming collision:  there is a unit of 
> mass called the pound and also unit of force called the pound)
> Basically, we should change:
> 
>  To be:
>  
>  
>  
> With seperate Uoms under each UomType
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-9597) Documentation: Customer Relationship Management (CRM) Process Overview

2020-10-05 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-9597:
--
Labels: BPRB CRM Documentation OBPRB  (was: BPRB CRM OBPRB)

> Documentation: Customer Relationship Management (CRM) Process Overview 
> ---
>
> Key: OFBIZ-9597
> URL: https://issues.apache.org/jira/browse/OFBIZ-9597
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Pranay Pandey
>Assignee: Shivangi Tanwar
>Priority: Major
>  Labels: BPRB, CRM, Documentation, OBPRB
>
> CRM process overview to be documented. 
> *Doc Content:* 
> Every CRM business activity to be covered with below-given headings-
> - Process Overview
> - Business Purpose (significance of having efficient CRM capabilities in real 
> world)
> - Activity Diagrams (Level-1,2, and 3 as applicable to demonstrate the 
> process flow)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10255) Add Document Content: humanres.adoc

2020-10-05 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-10255:
---
Labels: Documentation  (was: )

> Add Document Content: humanres.adoc
> ---
>
> Key: OFBIZ-10255
> URL: https://issues.apache.org/jira/browse/OFBIZ-10255
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Sharan Foga
>Assignee: Sharan Foga
>Priority: Minor
>  Labels: Documentation
> Attachments: OFBIZ-10255.patch, humanres.adoc, humanres.adoc.patch
>
>
> Using details from the OFBiz wiki workspaces and the Human Resources Guide 
> and other human resources asciidoc file,  write or organise the content for 
> the humanres.adoc file.
> An copy of the existing file will be attached.
> Please update the template and re-attach it.
> NOTE: This document might not be able to be completed until other sections 
> for Human Resources are done.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-05 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz closed OFBIZ-12035.
--
Fix Version/s: Trunk
   Resolution: Fixed

All seem to works correctly, on *nix directory in doc/images is created at the 
beginning and removed at the end.

There are still warning message when pdf is generated, but these are wrong 
because all images are present in html and pdf. I will post an issue in 
ascidoctor project for that.

> asciidoc Image directory convention for plugins and components
> --
>
> Key: OFBIZ-12035
> URL: https://issues.apache.org/jira/browse/OFBIZ-12035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Major
>  Labels: Documentation
> Fix For: Trunk
>
> Attachments: 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch
>
>
> Plugins documentation (in asciidoc) can be generated with one document per 
> plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
> directory) or include in the general 
> [user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
>  or 
> [developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]
> Currently, image usage not works in the two case, because image path is 
> relative to the root document.
> To solve the problem, I propose to put image(s) relative to a component in 
> the src/docs/asciidoc/images/${component.name} of the component and modifying 
> gradle generateDocumentation task to copy the subdirectory in the general 
> docs/asciidoc/images/ directory before generation and remove it after.
> Currently only birt is concern but it's better to have schema and other image 
> in documentation, so in future all components should be concerned.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11893) Error messages when generating HTML and PDF file from AsciiDoc files

2020-10-05 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz closed OFBIZ-11893.
--
Fix Version/s: Trunk
   Release Branch 17.12
   Release Branch 18.12
 Assignee: Olivier Heintz
   Resolution: Fixed

> Error messages when generating HTML and PDF file from AsciiDoc files
> 
>
> Key: OFBIZ-11893
> URL: https://issues.apache.org/jira/browse/OFBIZ-11893
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Olivier Heintz
>Priority: Minor
>  Labels: Documentation
> Fix For: Release Branch 18.12, Release Branch 17.12, Trunk
>
>
> {noformat}
> ERROR: hr-employments.adoc: line 58: invalid part, must have at least one 
> section (e.g., chapter, appendix, etc.)
> invalid part, must have at least one section (e.g., chapter, appendix, etc.) 
> :: hr-employments.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/applications/hu
> manres/src/docs/asciidoc/_include/hr-employments.adoc:58
> juil. 10, 2020 2:24:54 PM
> ERROR: manufacturing_NL.adoc: line 29: include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
> include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
>  :: manufacturing_NL.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/C:
> /projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/manufacturing_NL.adoc:29
> juil. 10, 2020 2:24:57 PM
> ERROR: hr-employments.adoc: line 58: invalid part, must have at least one 
> section (e.g., chapter, appendix, etc.)
> invalid part, must have at least one section (e.g., chapter, appendix, etc.) 
> :: hr-employments.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/applications/hu
> manres/src/docs/asciidoc/_include/hr-employments.adoc:58
> include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
>  :: manufacturing_NL.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/C:
> /projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/manufacturing_NL.adoc:29
> juil. 10, 2020 2:26:01 PM
> ERROR: manufacturing_NL.adoc: line 29: include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
> juil. 10, 2020 2:26:19 PM 
> uri:classloader:/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb 
> convert_inline_icon
> {noformat}
> There are also warnings and infos:
> {noformat}
> AVERTISSEMENT: sy-CSRF-defense.adoc: line 31: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-CSRF-defense.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs
> /asciidoc/_include/sy-CSRF-defense.adoc:31
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:31
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 31: section title out of sequence: 
> expected levels 0 or 1, got level 2
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 36: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:36
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 53: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:53
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-password-and-JWT.adoc: line 31: section title out of 
> 

[jira] [Commented] (OFBIZ-11893) Error messages when generating HTML and PDF file from AsciiDoc files

2020-10-05 Thread Olivier Heintz (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208050#comment-17208050
 ] 

Olivier Heintz commented on OFBIZ-11893:


I close this Jira because last Warning message are wrong (images are correct in 
html and pdf)

I suppose it's a asciidoctorPdf bug, I will open an issue on the asciidoctor 
project

> Error messages when generating HTML and PDF file from AsciiDoc files
> 
>
> Key: OFBIZ-11893
> URL: https://issues.apache.org/jira/browse/OFBIZ-11893
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>  Labels: Documentation
>
> {noformat}
> ERROR: hr-employments.adoc: line 58: invalid part, must have at least one 
> section (e.g., chapter, appendix, etc.)
> invalid part, must have at least one section (e.g., chapter, appendix, etc.) 
> :: hr-employments.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/applications/hu
> manres/src/docs/asciidoc/_include/hr-employments.adoc:58
> juil. 10, 2020 2:24:54 PM
> ERROR: manufacturing_NL.adoc: line 29: include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
> include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
>  :: manufacturing_NL.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/C:
> /projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/manufacturing_NL.adoc:29
> juil. 10, 2020 2:24:57 PM
> ERROR: hr-employments.adoc: line 58: invalid part, must have at least one 
> section (e.g., chapter, appendix, etc.)
> invalid part, must have at least one section (e.g., chapter, appendix, etc.) 
> :: hr-employments.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/applications/hu
> manres/src/docs/asciidoc/_include/hr-employments.adoc:58
> include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
>  :: manufacturing_NL.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/C:
> /projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/manufacturing_NL.adoc:29
> juil. 10, 2020 2:26:01 PM
> ERROR: manufacturing_NL.adoc: line 29: include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
> juil. 10, 2020 2:26:19 PM 
> uri:classloader:/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb 
> convert_inline_icon
> {noformat}
> There are also warnings and infos:
> {noformat}
> AVERTISSEMENT: sy-CSRF-defense.adoc: line 31: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-CSRF-defense.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs
> /asciidoc/_include/sy-CSRF-defense.adoc:31
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:31
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 31: section title out of sequence: 
> expected levels 0 or 1, got level 2
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 36: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:36
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 53: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:53
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-password-and-JWT.adoc: line 31: section title out of 
> sequence: expected levels 0 or 1, got level 2
> section 

[jira] [Commented] (OFBIZ-11893) Error messages when generating HTML and PDF file from AsciiDoc files

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207958#comment-17207958
 ] 

ASF subversion and git services commented on OFBIZ-11893:
-

Commit ccfb388999068707a4e1f88d794f55356cad49e6 in ofbiz-plugins's branch 
refs/heads/release18.12 from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=ccfb388 ]

Improved: Error messages when generating HTML and PDF file from AsciiDoc files 
(OFBIZ-11893)

re-encode birt image Report-Master.png to be supported by asciidoctor

> Error messages when generating HTML and PDF file from AsciiDoc files
> 
>
> Key: OFBIZ-11893
> URL: https://issues.apache.org/jira/browse/OFBIZ-11893
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>  Labels: Documentation
>
> {noformat}
> ERROR: hr-employments.adoc: line 58: invalid part, must have at least one 
> section (e.g., chapter, appendix, etc.)
> invalid part, must have at least one section (e.g., chapter, appendix, etc.) 
> :: hr-employments.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/applications/hu
> manres/src/docs/asciidoc/_include/hr-employments.adoc:58
> juil. 10, 2020 2:24:54 PM
> ERROR: manufacturing_NL.adoc: line 29: include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
> include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
>  :: manufacturing_NL.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/C:
> /projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/manufacturing_NL.adoc:29
> juil. 10, 2020 2:24:57 PM
> ERROR: hr-employments.adoc: line 58: invalid part, must have at least one 
> section (e.g., chapter, appendix, etc.)
> invalid part, must have at least one section (e.g., chapter, appendix, etc.) 
> :: hr-employments.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/applications/hu
> manres/src/docs/asciidoc/_include/hr-employments.adoc:58
> include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
>  :: manufacturing_NL.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/C:
> /projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/manufacturing_NL.adoc:29
> juil. 10, 2020 2:26:01 PM
> ERROR: manufacturing_NL.adoc: line 29: include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
> juil. 10, 2020 2:26:19 PM 
> uri:classloader:/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb 
> convert_inline_icon
> {noformat}
> There are also warnings and infos:
> {noformat}
> AVERTISSEMENT: sy-CSRF-defense.adoc: line 31: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-CSRF-defense.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs
> /asciidoc/_include/sy-CSRF-defense.adoc:31
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:31
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 31: section title out of sequence: 
> expected levels 0 or 1, got level 2
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 36: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:36
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 53: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> 

[jira] [Commented] (OFBIZ-11893) Error messages when generating HTML and PDF file from AsciiDoc files

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207939#comment-17207939
 ] 

ASF subversion and git services commented on OFBIZ-11893:
-

Commit 009beb4b11c5fc4fc4823ba0cc0609e09482c2ee in ofbiz-framework's branch 
refs/heads/release18.12 from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=009beb4 ]

Improvement: Error messages when generating HTML and PDF file from AsciiDoc 
files (OFBIZ-11893)

minor correction, title level and anchor definition

> Error messages when generating HTML and PDF file from AsciiDoc files
> 
>
> Key: OFBIZ-11893
> URL: https://issues.apache.org/jira/browse/OFBIZ-11893
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>  Labels: Documentation
>
> {noformat}
> ERROR: hr-employments.adoc: line 58: invalid part, must have at least one 
> section (e.g., chapter, appendix, etc.)
> invalid part, must have at least one section (e.g., chapter, appendix, etc.) 
> :: hr-employments.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/applications/hu
> manres/src/docs/asciidoc/_include/hr-employments.adoc:58
> juil. 10, 2020 2:24:54 PM
> ERROR: manufacturing_NL.adoc: line 29: include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
> include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
>  :: manufacturing_NL.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/C:
> /projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/manufacturing_NL.adoc:29
> juil. 10, 2020 2:24:57 PM
> ERROR: hr-employments.adoc: line 58: invalid part, must have at least one 
> section (e.g., chapter, appendix, etc.)
> invalid part, must have at least one section (e.g., chapter, appendix, etc.) 
> :: hr-employments.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/applications/hu
> manres/src/docs/asciidoc/_include/hr-employments.adoc:58
> include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
>  :: manufacturing_NL.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/C:
> /projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/manufacturing_NL.adoc:29
> juil. 10, 2020 2:26:01 PM
> ERROR: manufacturing_NL.adoc: line 29: include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
> juil. 10, 2020 2:26:19 PM 
> uri:classloader:/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb 
> convert_inline_icon
> {noformat}
> There are also warnings and infos:
> {noformat}
> AVERTISSEMENT: sy-CSRF-defense.adoc: line 31: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-CSRF-defense.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs
> /asciidoc/_include/sy-CSRF-defense.adoc:31
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:31
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 31: section title out of sequence: 
> expected levels 0 or 1, got level 2
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 36: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:36
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 53: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> 

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #169: OFBIZ-11756 vue js renderer

2020-10-05 Thread GitBox


sonarcloud[bot] commented on pull request #169:
URL: https://github.com/apache/ofbiz-framework/pull/169#issuecomment-703496128


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issue
 
s?id=apache_ofbiz-framework=169=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=169)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=169=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=169=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #169: OFBIZ-11756 vue js renderer

2020-10-05 Thread GitBox


sonarcloud[bot] removed a comment on pull request #169:
URL: https://github.com/apache/ofbiz-framework/pull/169#issuecomment-702649920


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=SECURITY_HOTSPOT)
 [0 Security Hotspots](https://sonarcloud.io/project/issue
 
s?id=apache_ofbiz-framework=169=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=169)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=169=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=169=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Comment Edited] (OFBIZ-11976) svg files not removed on clean

2020-10-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207902#comment-17207902
 ] 

Jacques Le Roux edited comment on OFBIZ-11976 at 10/5/20, 8:13 AM:
---

Ha we crossed on wire. I did not spot that my commit was empty :) No problems


was (Author: jacques.le.roux):
Ha we crossed on wire, no problems :)

> svg files not removed on clean
> --
>
> Key: OFBIZ-11976
> URL: https://issues.apache.org/jira/browse/OFBIZ-11976
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL PLUGINS
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: documentation
> Fix For: 18.12.01, 17.12.05
>
>
> files like birt/src/docs/asciidoc/images/OFBiz-Logo.svg,
> in many plugins, don't get removed on clean.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207903#comment-17207903
 ] 

Jacques Le Roux commented on OFBIZ-12035:
-

If I have not missed anything we can close here, right?


> asciidoc Image directory convention for plugins and components
> --
>
> Key: OFBIZ-12035
> URL: https://issues.apache.org/jira/browse/OFBIZ-12035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Major
>  Labels: Documentation
> Attachments: 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch
>
>
> Plugins documentation (in asciidoc) can be generated with one document per 
> plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
> directory) or include in the general 
> [user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
>  or 
> [developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]
> Currently, image usage not works in the two case, because image path is 
> relative to the root document.
> To solve the problem, I propose to put image(s) relative to a component in 
> the src/docs/asciidoc/images/${component.name} of the component and modifying 
> gradle generateDocumentation task to copy the subdirectory in the general 
> docs/asciidoc/images/ directory before generation and remove it after.
> Currently only birt is concern but it's better to have schema and other image 
> in documentation, so in future all components should be concerned.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11976) svg files not removed on clean

2020-10-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207902#comment-17207902
 ] 

Jacques Le Roux commented on OFBIZ-11976:
-

Ha we crossed on wire, no problems :)

> svg files not removed on clean
> --
>
> Key: OFBIZ-11976
> URL: https://issues.apache.org/jira/browse/OFBIZ-11976
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL PLUGINS
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: documentation
> Fix For: 18.12.01, 17.12.05
>
>
> files like birt/src/docs/asciidoc/images/OFBiz-Logo.svg,
> in many plugins, don't get removed on clean.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207899#comment-17207899
 ] 

Jacques Le Roux edited comment on OFBIZ-12035 at 10/5/20, 8:06 AM:
---

Hi Olivier,

Above is with trunk HEAD using generateAllPluginsDocumentation. Running 
generateOfbizDocumentation just after clear them.

I think we shoul dnot worry too much about that because as I said at 
OFBIZ-11976:
bq. The documentation generation is mostly done for us by Buildbot and we have 
no problem on *nix systems.



was (Author: jacques.le.roux):
Hi Olivier,

Above is with trunk HEAD using generateAllPluginsDocumentation. Running 
generateOfbizDocumentation just after clear them.


> asciidoc Image directory convention for plugins and components
> --
>
> Key: OFBIZ-12035
> URL: https://issues.apache.org/jira/browse/OFBIZ-12035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Major
>  Labels: Documentation
> Attachments: 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch
>
>
> Plugins documentation (in asciidoc) can be generated with one document per 
> plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
> directory) or include in the general 
> [user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
>  or 
> [developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]
> Currently, image usage not works in the two case, because image path is 
> relative to the root document.
> To solve the problem, I propose to put image(s) relative to a component in 
> the src/docs/asciidoc/images/${component.name} of the component and modifying 
> gradle generateDocumentation task to copy the subdirectory in the general 
> docs/asciidoc/images/ directory before generation and remove it after.
> Currently only birt is concern but it's better to have schema and other image 
> in documentation, so in future all components should be concerned.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11976) svg files not removed on clean

2020-10-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207897#comment-17207897
 ] 

Jacques Le Roux edited comment on OFBIZ-11976 at 10/5/20, 8:06 AM:
---

Hi [~holivier],

Closing, I backported and pushed. I could not test because of a JRuby issue I 
have on Windows:

bq. Caused by: org.jruby.exceptions.RaiseException: (SystemCallError) Unknown 
error (SystemCallError) 123 - FindFirstFile

I tried to update Ruby and JRuby to no avail. It's maybe  related to 
OFBIZ-9873. I gave up at this stage. The documentation generation is mostly 
done for us by Buildbot and we have no problem on *nix systems.


was (Author: jacques.le.roux):
Hi [~holivier],

Closing, I backported and pushed. I could not test because of a JRuby issue I 
have on Windows:

bq. Caused by: org.jruby.exceptions.RaiseException: (SystemCallError) Unknown 
error (SystemCallError) 123 - FindFirstFile

I tried to update Ruby and JRuby to no avail. It's maybe  related to 
OFBIZ-9873. I gave up at this stage. The documentation generation is mostly 
bone for us by Buildbot and we have no problem on *nix systems.

> svg files not removed on clean
> --
>
> Key: OFBIZ-11976
> URL: https://issues.apache.org/jira/browse/OFBIZ-11976
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL PLUGINS
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: documentation
> Fix For: 18.12.01, 17.12.05
>
>
> files like birt/src/docs/asciidoc/images/OFBiz-Logo.svg,
> in many plugins, don't get removed on clean.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207899#comment-17207899
 ] 

Jacques Le Roux commented on OFBIZ-12035:
-

Hi Olivier,

Above is with trunk HEAD using generateAllPluginsDocumentation. Running 
generateOfbizDocumentation just after clear them.


> asciidoc Image directory convention for plugins and components
> --
>
> Key: OFBIZ-12035
> URL: https://issues.apache.org/jira/browse/OFBIZ-12035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Major
>  Labels: Documentation
> Attachments: 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch
>
>
> Plugins documentation (in asciidoc) can be generated with one document per 
> plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
> directory) or include in the general 
> [user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
>  or 
> [developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]
> Currently, image usage not works in the two case, because image path is 
> relative to the root document.
> To solve the problem, I propose to put image(s) relative to a component in 
> the src/docs/asciidoc/images/${component.name} of the component and modifying 
> gradle generateDocumentation task to copy the subdirectory in the general 
> docs/asciidoc/images/ directory before generation and remove it after.
> Currently only birt is concern but it's better to have schema and other image 
> in documentation, so in future all components should be concerned.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11976) svg files not removed on clean

2020-10-05 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11976.
---
Resolution: Fixed

Hi [~holivier],

Closing, I backported and pushed. I could not test because of a JRuby issue I 
have on Windows:

bq. Caused by: org.jruby.exceptions.RaiseException: (SystemCallError) Unknown 
error (SystemCallError) 123 - FindFirstFile

I tried to update Ruby and JRuby to no avail. It's maybe  related to 
OFBIZ-9873. I gave up at this stage. The documentation generation is mostly 
bone for us by Buildbot and we have no problem on *nix systems.

> svg files not removed on clean
> --
>
> Key: OFBIZ-11976
> URL: https://issues.apache.org/jira/browse/OFBIZ-11976
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL PLUGINS
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: documentation
> Fix For: 18.12.01, 17.12.05
>
>
> files like birt/src/docs/asciidoc/images/OFBiz-Logo.svg,
> in many plugins, don't get removed on clean.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11976) svg files not removed on clean

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207883#comment-17207883
 ] 

ASF subversion and git services commented on OFBIZ-11976:
-

Commit 72ae6c8e37c8fcdc24d09101e50166329a054bdb in ofbiz-framework's branch 
refs/heads/release18.12 from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=72ae6c8 ]

fixed: svg files not removed on clean (OFBIZ-11976)

Backport build.gradle correction from OFBIZ-12035, correction in 
generateAllPluginsDocumentation to put copy of OFBiz-Logo in doFirst to avoid 
it's run during gradle Configure project

> svg files not removed on clean
> --
>
> Key: OFBIZ-11976
> URL: https://issues.apache.org/jira/browse/OFBIZ-11976
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL PLUGINS
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Major
>  Labels: documentation
> Fix For: 18.12.01, 17.12.05
>
>
> files like birt/src/docs/asciidoc/images/OFBiz-Logo.svg,
> in many plugins, don't get removed on clean.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207884#comment-17207884
 ] 

ASF subversion and git services commented on OFBIZ-12035:
-

Commit 72ae6c8e37c8fcdc24d09101e50166329a054bdb in ofbiz-framework's branch 
refs/heads/release18.12 from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=72ae6c8 ]

fixed: svg files not removed on clean (OFBIZ-11976)

Backport build.gradle correction from OFBIZ-12035, correction in 
generateAllPluginsDocumentation to put copy of OFBiz-Logo in doFirst to avoid 
it's run during gradle Configure project

> asciidoc Image directory convention for plugins and components
> --
>
> Key: OFBIZ-12035
> URL: https://issues.apache.org/jira/browse/OFBIZ-12035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Major
>  Labels: Documentation
> Attachments: 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch
>
>
> Plugins documentation (in asciidoc) can be generated with one document per 
> plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
> directory) or include in the general 
> [user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
>  or 
> [developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]
> Currently, image usage not works in the two case, because image path is 
> relative to the root document.
> To solve the problem, I propose to put image(s) relative to a component in 
> the src/docs/asciidoc/images/${component.name} of the component and modifying 
> gradle generateDocumentation task to copy the subdirectory in the general 
> docs/asciidoc/images/ directory before generation and remove it after.
> Currently only birt is concern but it's better to have schema and other image 
> in documentation, so in future all components should be concerned.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)