[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #244: Fixed: Single product tile is displayed on one row in product search (OFBIZ-12045)
sonarcloud[bot] commented on pull request #244: URL: https://github.com/apache/ofbiz-framework/pull/244#issuecomment-735051187 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=244=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=244=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=244=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=244=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=244=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=244=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=244=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=244=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=244=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=244=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=244=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=244=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=244) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=244=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-12068) Order processing issue for dropship only products
Amit Gadaley created OFBIZ-12068: Summary: Order processing issue for dropship only products Key: OFBIZ-12068 URL: https://issues.apache.org/jira/browse/OFBIZ-12068 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Amit Gadaley When a dropship only (or dropship on low ATP) product with no qualified supplier added to shopping cart and cart converted to sales order. System only logs error messages, it should also return errors and should not create sales order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] isdixit opened a new pull request #244: Fixed: Single product tile is displayed on one row in product search (OFBIZ-12045)
isdixit opened a new pull request #244: URL: https://github.com/apache/ofbiz-framework/pull/244 Cause: Wrong use of bootstrap grid classes. Fixed: Used row class as a parent to col-* class while rendering the products. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #243: Improved: Update IND Geo data as per 2020-11-24 notification
sonarcloud[bot] commented on pull request #243: URL: https://github.com/apache/ofbiz-framework/pull/243#issuecomment-735050085 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=243=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=243=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=243=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=243=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=243=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=243=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=243=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=243=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=243=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=243=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=243=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=243=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=243) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=243=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=243=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-12067) Update IND Geo data as per 2020-11-24 notification
[ https://issues.apache.org/jira/browse/OFBIZ-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-12067. Fix Version/s: 17.12.05 Upcoming Branch 18.12.01 Resolution: Done > Update IND Geo data as per 2020-11-24 notification > --- > > Key: OFBIZ-12067 > URL: https://issues.apache.org/jira/browse/OFBIZ-12067 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > Fix For: 18.12.01, Upcoming Branch, 17.12.05 > > > * Deletion of Union territory IN-DD, IN-DN; > * Addition of Union territory IN-DH; > * Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, > IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, > IN-TN, IN-UT; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12067) Update IND Geo data as per 2020-11-24 notification
[ https://issues.apache.org/jira/browse/OFBIZ-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239910#comment-17239910 ] Deepak Dixit edited comment on OFBIZ-12067 at 11/28/20, 7:13 AM: - Here is the PR for this task Trunk: [https://github.com/apache/ofbiz-framework/pull/240] Release18.12: [https://github.com/apache/ofbiz-framework/pull/242] Release17.12: https://github.com/apache/ofbiz-framework/pull/243 was (Author: deepak.dixit): Here is the PR for this task https://github.com/apache/ofbiz-framework/pull/240 > Update IND Geo data as per 2020-11-24 notification > --- > > Key: OFBIZ-12067 > URL: https://issues.apache.org/jira/browse/OFBIZ-12067 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Deepak Dixit >Priority: Major > > * Deletion of Union territory IN-DD, IN-DN; > * Addition of Union territory IN-DH; > * Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, > IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, > IN-TN, IN-UT; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #242: Improved: Update IND Geo data as per 2020-11-24 notification
sonarcloud[bot] commented on pull request #242: URL: https://github.com/apache/ofbiz-framework/pull/242#issuecomment-735049782 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=242=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=242=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=242=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=242=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=242=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=242=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=242=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=242=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=242=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=242=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=242=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=242=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=242) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=242=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=242=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-12067) Update IND Geo data as per 2020-11-24 notification
[ https://issues.apache.org/jira/browse/OFBIZ-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-12067: Assignee: Deepak Dixit > Update IND Geo data as per 2020-11-24 notification > --- > > Key: OFBIZ-12067 > URL: https://issues.apache.org/jira/browse/OFBIZ-12067 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > > * Deletion of Union territory IN-DD, IN-DN; > * Addition of Union territory IN-DH; > * Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, > IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, > IN-TN, IN-UT; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] dixitdeepak merged pull request #243: Improved: Update IND Geo data as per 2020-11-24 notification
dixitdeepak merged pull request #243: URL: https://github.com/apache/ofbiz-framework/pull/243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] dixitdeepak opened a new pull request #243: Improved: Update IND Geo data as per 2020-11-24 notification
dixitdeepak opened a new pull request #243: URL: https://github.com/apache/ofbiz-framework/pull/243 - Deletion of Union territory IN-DD, IN-DN; - Addition of Union territory IN-DH; - Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, IN-TN, IN-UT; OFBIZ-12067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] dixitdeepak merged pull request #242: Improved: Update IND Geo data as per 2020-11-24 notification
dixitdeepak merged pull request #242: URL: https://github.com/apache/ofbiz-framework/pull/242 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] dixitdeepak opened a new pull request #242: Improved: Update IND Geo data as per 2020-11-24 notification
dixitdeepak opened a new pull request #242: URL: https://github.com/apache/ofbiz-framework/pull/242 - Deletion of Union territory IN-DD, IN-DN; - Addition of Union territory IN-DH; - Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, IN-TN, IN-UT; OFBIZ-12067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #241: Updated ind geo data as per 2020-11-24 notification
sonarcloud[bot] commented on pull request #241: URL: https://github.com/apache/ofbiz-framework/pull/241#issuecomment-735048889 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=241=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=241=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=241=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=241=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=241=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=241=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=241=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=241=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=241=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=241=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=241=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=241=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=241) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=241=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=241=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] dixitdeepak closed pull request #241: Updated ind geo data as per 2020-11-24 notification
dixitdeepak closed pull request #241: URL: https://github.com/apache/ofbiz-framework/pull/241 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #240: Updated IND geo data as per 2020-11-24 notification
sonarcloud[bot] commented on pull request #240: URL: https://github.com/apache/ofbiz-framework/pull/240#issuecomment-735048435 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=240=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=240=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=240=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=240=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=240=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=240=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=240=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=240=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=240=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=240=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=240=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=240=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=240) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=240=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=240=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] dixitdeepak opened a new pull request #241: Updated ind geo data as per 2020-11-24 notification
dixitdeepak opened a new pull request #241: URL: https://github.com/apache/ofbiz-framework/pull/241 Improved:Updated ind geo data as per 2020 11 24 notification (OFBIZ-12067) Explanation - Deletion of Union territory IN-DD, IN-DN; - Addition of Union territory IN-DH; - Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, IN-TN, IN-UT; This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-12025) Unable to add address while selecting option split shipment
[ https://issues.apache.org/jira/browse/OFBIZ-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Patidar reassigned OFBIZ-12025: --- Assignee: Chinmay Patidar > Unable to add address while selecting option split shipment > --- > > Key: OFBIZ-12025 > URL: https://issues.apache.org/jira/browse/OFBIZ-12025 > Project: OFBiz > Issue Type: Bug >Affects Versions: 17.12.04 >Reporter: Rashi Dhagat >Assignee: Chinmay Patidar >Priority: Major > Attachments: NewAddress-SplitShipmenterror.png, > SplitShipmentError.webm > > > Steps to regenerate: > 1. Add multiple items in the cart > 2. Click on View cart > 3. Click on checkout > 4. Click on Split shipment option > 5. Click on Add new address > Actual: Error renders while trying to add the address or selecting the > existing address. > Please refer to the attachment. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12067) Update IND Geo data as per 2020-11-24 notification
[ https://issues.apache.org/jira/browse/OFBIZ-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239910#comment-17239910 ] Deepak Dixit commented on OFBIZ-12067: -- Here is the PR for this task > Update IND Geo data as per 2020-11-24 notification > --- > > Key: OFBIZ-12067 > URL: https://issues.apache.org/jira/browse/OFBIZ-12067 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Deepak Dixit >Priority: Major > > * Deletion of Union territory IN-DD, IN-DN; > * Addition of Union territory IN-DH; > * Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, > IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, > IN-TN, IN-UT; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12067) Update IND Geo data as per 2020-11-24 notification
[ https://issues.apache.org/jira/browse/OFBIZ-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239910#comment-17239910 ] Deepak Dixit edited comment on OFBIZ-12067 at 11/28/20, 6:54 AM: - Here is the PR for this task https://github.com/apache/ofbiz-framework/pull/240 was (Author: deepak.dixit): Here is the PR for this task > Update IND Geo data as per 2020-11-24 notification > --- > > Key: OFBIZ-12067 > URL: https://issues.apache.org/jira/browse/OFBIZ-12067 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Deepak Dixit >Priority: Major > > * Deletion of Union territory IN-DD, IN-DN; > * Addition of Union territory IN-DH; > * Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, > IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, > IN-TN, IN-UT; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] dixitdeepak merged pull request #240: Updated IND geo data as per 2020-11-24 notification
dixitdeepak merged pull request #240: URL: https://github.com/apache/ofbiz-framework/pull/240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-12067) Update IND Geo data as per 2020-11-24 notification
[ https://issues.apache.org/jira/browse/OFBIZ-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sourabh jain reassigned OFBIZ-12067: Assignee: (was: Deepak Dixit) > Update IND Geo data as per 2020-11-24 notification > --- > > Key: OFBIZ-12067 > URL: https://issues.apache.org/jira/browse/OFBIZ-12067 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Deepak Dixit >Priority: Major > > * Deletion of Union territory IN-DD, IN-DN; > * Addition of Union territory IN-DH; > * Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, > IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, > IN-TN, IN-UT; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] dixitdeepak opened a new pull request #240: Updated IND geo data as per 2020-11-24 notification
dixitdeepak opened a new pull request #240: URL: https://github.com/apache/ofbiz-framework/pull/240 Improved:Updated ind geo data as per 2020 11 24 notification (OFBIZ-12067) Explanation * Deletion of Union territory IN-DD, IN-DN; * Addition of Union territory IN-DH; * Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, IN-TN, IN-UT; This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-12067) Update IND Geo data as per 2020-11-24 notification
[ https://issues.apache.org/jira/browse/OFBIZ-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit reassigned OFBIZ-12067: Assignee: Deepak Dixit (was: sourabh jain) > Update IND Geo data as per 2020-11-24 notification > --- > > Key: OFBIZ-12067 > URL: https://issues.apache.org/jira/browse/OFBIZ-12067 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Major > > * Deletion of Union territory IN-DD, IN-DN; > * Addition of Union territory IN-DH; > * Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, > IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, > IN-TN, IN-UT; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12067) Update IND Geo data as per 2020-11-24 notification
[ https://issues.apache.org/jira/browse/OFBIZ-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sourabh jain reassigned OFBIZ-12067: Assignee: sourabh jain > Update IND Geo data as per 2020-11-24 notification > --- > > Key: OFBIZ-12067 > URL: https://issues.apache.org/jira/browse/OFBIZ-12067 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Deepak Dixit >Assignee: sourabh jain >Priority: Major > > * Deletion of Union territory IN-DD, IN-DN; > * Addition of Union territory IN-DH; > * Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, > IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, > IN-TN, IN-UT; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12067) Update IND Geo data as per 2020-11-24 notification
[ https://issues.apache.org/jira/browse/OFBIZ-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-12067: - Description: * Deletion of Union territory IN-DD, IN-DN; * Addition of Union territory IN-DH; * Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, IN-TN, IN-UT; > Update IND Geo data as per 2020-11-24 notification > --- > > Key: OFBIZ-12067 > URL: https://issues.apache.org/jira/browse/OFBIZ-12067 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Deepak Dixit >Priority: Major > > * Deletion of Union territory IN-DD, IN-DN; > * Addition of Union territory IN-DH; > * Correction of spelling for IN-AR, IN-BR, IN-CH, IN-CT, IN-DH, IN-GJ, > IN-HP, IN-HR, IN-JH, IN-JK, IN-KA, IN-LA, IN-MH, IN-ML, IN-NL, IN-RJ, IN-TG, > IN-TN, IN-UT; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12067) Update IND Geo data as per 2020-11-24 notification
[ https://issues.apache.org/jira/browse/OFBIZ-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-12067: - Affects Version/s: 17.12.05 Release Branch 18.12 Trunk > Update IND Geo data as per 2020-11-24 notification > --- > > Key: OFBIZ-12067 > URL: https://issues.apache.org/jira/browse/OFBIZ-12067 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Deepak Dixit >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12067) Update IND Geo data as per 2020-11-24 notification
[ https://issues.apache.org/jira/browse/OFBIZ-12067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit updated OFBIZ-12067: - Component/s: framework/common > Update IND Geo data as per 2020-11-24 notification > --- > > Key: OFBIZ-12067 > URL: https://issues.apache.org/jira/browse/OFBIZ-12067 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Deepak Dixit >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12066) init-gradle-wrapper.sh fails to install wrapper files using wget
[
https://issues.apache.org/jira/browse/OFBIZ-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239903#comment-17239903
]
Girish Vasmatkar commented on OFBIZ-12066:
--
Remove -q from the arguments to wget, reveals exactly what is happening ...
{code:java}
--2020-11-28 11:54:26-- http://2%3E&1/
Resolving 2>&1 (2>&1)... failed: nodename nor servname provided, or not known.
wget: unable to resolve host address ‘2>&1’
--2020-11-28 11:54:26-- http://%3E/
Resolving > (>)... failed: nodename nor servname provided, or not known.
wget: unable to resolve host address ‘>’
/dev/null: Scheme missing.
--2020-11-28 11:54:27-- http://%7C/
Resolving | (|)... failed: nodename nor servname provided, or not known.
wget: unable to resolve host address ‘|’
--2020-11-28 11:54:28-- http://grep/
Resolving grep (grep)... failed: nodename nor servname provided, or not known.
wget: unable to resolve host address ‘grep’
Warning: wildcards not supported in HTTP.
--2020-11-28 11:54:28-- http://%22http/.*
Resolving "http ("http)... failed: nodename nor servname provided, or not known.
wget: unable to resolve host address ‘"http’
--2020-11-28 11:54:28-- http://200%22/
Resolving 200" (200")... failed: nodename nor servname provided, or not known.
wget: unable to resolve host address ‘200"’
FINISHED --2020-11-28 11:54:29--
Total wall clock time: 6.0s
Downloaded: 1 files, 54K in 0.8s (68.1 KB/s)
{code}
> init-gradle-wrapper.sh fails to install wrapper files using wget
>
>
> Key: OFBIZ-12066
> URL: https://issues.apache.org/jira/browse/OFBIZ-12066
> Project: OFBiz
> Issue Type: Bug
> Components: ALL PLUGINS
>Affects Versions: Trunk, 17.12.04
>Reporter: Girish Vasmatkar
>Priority: Minor
>
> Running init-gradle-wrapper.sh does not download gradle wrapper files on
> systems with wget implementation.
> Here's the error.
> Download files gradle-wrapper.jar gradle-wrapper.properties from
> [https://dl.bin|https://dl.bin/]$Please check the logs, fix the problem and
> run the script again.
> === Control downloaded files ===
> shasum: gradle/wrapper/gradle-wrapper.jar:
> gradle/wrapper/gradle-wrapper.jar: FAILED open or read
> shasum: gradle/wrapper/gradle-wrapper.properties: No such file or directory
> gradle/wrapper/gradle-wrapper.properties: FAILED open or read
> gradlew: OK
> shasum: WARNING: 2 listed files could not be read
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-12067) Update IND Geo data as per 2020-11-24 notification
Deepak Dixit created OFBIZ-12067: Summary: Update IND Geo data as per 2020-11-24 notification Key: OFBIZ-12067 URL: https://issues.apache.org/jira/browse/OFBIZ-12067 Project: OFBiz Issue Type: Improvement Reporter: Deepak Dixit -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11788) Edit button(s) are shown for shipments received or shipped
[ https://issues.apache.org/jira/browse/OFBIZ-11788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Joshi reassigned OFBIZ-11788: --- Assignee: Ankit Joshi > Edit button(s) are shown for shipments received or shipped > -- > > Key: OFBIZ-11788 > URL: https://issues.apache.org/jira/browse/OFBIZ-11788 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: 17.12.03, Trunk >Reporter: Pierre Smits >Assignee: Ankit Joshi >Priority: Major > Labels: refactoring, usability > Attachments: Screen Shot 2020-06-02 at 09.52.54.png, Screen Shot > 2020-06-02 at 09.54.16.png, Screen Shot 2020-06-02 at 09.54.37.png, Screen > Shot 2020-06-02 at 09.55.08.png, Screen Shot 2020-06-02 at 09.55.28.png, > Screen Shot 2020-06-02 at 09.56.01.png > > > When a shipment has been received (purchase) or shipped (sales), the shipment > process should be concluded. And thus the shipment should be editable anymore. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12066) init-gradle-wrapper.sh fails to install wrapper files using wget
Girish Vasmatkar created OFBIZ-12066: Summary: init-gradle-wrapper.sh fails to install wrapper files using wget Key: OFBIZ-12066 URL: https://issues.apache.org/jira/browse/OFBIZ-12066 Project: OFBiz Issue Type: Bug Components: ALL PLUGINS Affects Versions: 17.12.04, Trunk Reporter: Girish Vasmatkar Running init-gradle-wrapper.sh does not download gradle wrapper files on systems with wget implementation. Here's the error. Download files gradle-wrapper.jar gradle-wrapper.properties from [https://dl.bin|https://dl.bin/]$Please check the logs, fix the problem and run the script again. === Control downloaded files === shasum: gradle/wrapper/gradle-wrapper.jar: gradle/wrapper/gradle-wrapper.jar: FAILED open or read shasum: gradle/wrapper/gradle-wrapper.properties: No such file or directory gradle/wrapper/gradle-wrapper.properties: FAILED open or read gradlew: OK shasum: WARNING: 2 listed files could not be read -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-735045349 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=45=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=45=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=45=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=45) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=45=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=45=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-735039140 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=45=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=45=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=45=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=45) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=45=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=45=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-12024) Error renders while adding gift card
[ https://issues.apache.org/jira/browse/OFBIZ-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prakhar Kumar updated OFBIZ-12024: -- Priority: Minor (was: Critical) > Error renders while adding gift card > > > Key: OFBIZ-12024 > URL: https://issues.apache.org/jira/browse/OFBIZ-12024 > Project: OFBiz > Issue Type: Bug >Affects Versions: 17.12.04 >Reporter: Rashi Dhagat >Assignee: Prakhar Kumar >Priority: Minor > Attachments: ErrorGiftcard.webm, GiftCardError.png > > > Steps to regenerate: > 1. Click on gift card > 2. Select the variant > 3. Enter the additional information and click on submit. > Actual: Nothing to do here and error message displays whereas gift card is > added in the cart. > Please refer to the attachment. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12024) Error renders while adding gift card
[ https://issues.apache.org/jira/browse/OFBIZ-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239886#comment-17239886 ] Prakhar Kumar commented on OFBIZ-12024: --- [~rashi.dhagat] I have verified the reported case and it seems to work fine. The error message which you mentioned only appears when you try to refresh the page. Despite that, the gift card is successfully added and is available for checkout. I think this is not causing any major impact and hence I am updating the ticket's priority to Minor. > Error renders while adding gift card > > > Key: OFBIZ-12024 > URL: https://issues.apache.org/jira/browse/OFBIZ-12024 > Project: OFBiz > Issue Type: Bug >Affects Versions: 17.12.04 >Reporter: Rashi Dhagat >Assignee: Prakhar Kumar >Priority: Critical > Attachments: ErrorGiftcard.webm, GiftCardError.png > > > Steps to regenerate: > 1. Click on gift card > 2. Select the variant > 3. Enter the additional information and click on submit. > Actual: Nothing to do here and error message displays whereas gift card is > added in the cart. > Please refer to the attachment. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12046) Edit record in product promotion, "Promotion Last Modified Date" is invalid, but don't notice to user
[ https://issues.apache.org/jira/browse/OFBIZ-12046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lalit Dashora reassigned OFBIZ-12046: - Assignee: Lalit Dashora > Edit record in product promotion, "Promotion Last Modified Date" is invalid, > but don't notice to user > - > > Key: OFBIZ-12046 > URL: https://issues.apache.org/jira/browse/OFBIZ-12046 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: 17.12.04 > Environment: * PostgreSQL 13 > * Google Chrome 68 > * Windows 10 x64 version 2004 > * Ofbiz 17.12.04 > Source code: > > E:\foo\ofbiz-framework>git log --oneline -1 > *d56e3977e9* (HEAD -> trunk, origin/trunk, origin/HEAD) Improved: Upgrade > Gradle to V6.5.1 (OFBIZ-11946) > >Reporter: Do Nhu Vy >Assignee: Lalit Dashora >Priority: Minor > Attachments: 2020-10-25_22-20-39.mp4, console_log.txt, ofbiz_bug.png > > > Edit record in product promotion, "Promotion Last Modified Date" is invalid, > but don't notice to user -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-735039140 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=45=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=45=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=45=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=45) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=45=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=45=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-731978548 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ ofbiz-plugins=45=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=45) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=45=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=45=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12064) Load language js for date.js only when required
[ https://issues.apache.org/jira/browse/OFBIZ-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239690#comment-17239690 ] ASF subversion and git services commented on OFBIZ-12064: - Commit bc5b0d595cab9103e9ec0c03234cec81c80f47c3 in ofbiz-framework's branch refs/heads/trunk from James Yong [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bc5b0d5 ] Improved: Load language js for date.js only when required (OFBIZ-12064) Tested on 1) date time field at /ordermgr/control/orderentry and 2) date find field at /ordermgr/control/findreturn > Load language js for date.js only when required > > > Key: OFBIZ-12064 > URL: https://issues.apache.org/jira/browse/OFBIZ-12064 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12064.patch > > > Only load language js for Date.js when there is a date time picker in the > page. The library is located at > themes/common-themes/webapp/common/js/jquery/plugins/datejs. > Discussion started at > https://lists.apache.org/thread.html/re9288f4d70f216677f08d859bba8d6fc195d0d2d754f0e93838d87f9%40%3Cdev.ofbiz.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12065) migrated Wiki How to Create the main Company in Party Manager to user-manual
Olivier Heintz created OFBIZ-12065: -- Summary: migrated Wiki How to Create the main Company in Party Manager to user-manual Key: OFBIZ-12065 URL: https://issues.apache.org/jira/browse/OFBIZ-12065 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: Trunk Reporter: Olivier Heintz Assignee: Olivier Heintz Add a first "process" in Party user-manual chapter with the How to Create the main Company in Party Manager coming from the [https://cwiki.apache.org/confluence/display/OFBENDUSER/How+to+Create+the+main+Company+in+Party+Manager] page -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-12063) Replace java.io.File::renameTo by java.nio.file.Files::move
[
https://issues.apache.org/jira/browse/OFBIZ-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reopened OFBIZ-12063:
-
> Replace java.io.File::renameTo by java.nio.file.Files::move
> ---
>
> Key: OFBIZ-12063
> URL: https://issues.apache.org/jira/browse/OFBIZ-12063
> Project: OFBiz
> Issue Type: Bug
> Components: product/catalog
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> This is a bug because the behaviour is not assured on Windows for instance.
> So it's impossible to correctly develop and test.
> As explained at
> https://docs.oracle.com/javase/8/docs/api/java/io/File.html#renameTo-java.io.File-
> {quote}
> Renames the file denoted by this abstract pathname.
> Many aspects of the behavior of this method are inherently
> platform-dependent: The rename operation might not be able to move a file
> from one filesystem to another, it might not be atomic, and it might not
> succeed if a file with the destination abstract pathname already exists. The
> return value should always be checked to make sure that the rename operation
> was successful.
> Note that the Files class defines the move method to move or rename a file in
> a platform independent manner.
> {quote}
> So the expression
> {code:java}
> file.renameTo(file1)
> {code}
> used in 5 Application Product Groovy scripts, can be easily replaced by
> {code:java}
> Path source = file.toPath()
> Files.move(source, source.resolveSibling(filenameToUse))
> {code}
> that is working on all platforms as explained at
> https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#move-java.nio.file.Path-java.nio.file.Path-java.nio.file.CopyOption...-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-12063) Replace java.io.File::renameTo by java.nio.file.Files::move
[
https://issues.apache.org/jira/browse/OFBIZ-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-12063.
---
Fix Version/s: (was: 17.12.05)
(was: 18.12.01)
Resolution: Not A Problem
> Replace java.io.File::renameTo by java.nio.file.Files::move
> ---
>
> Key: OFBIZ-12063
> URL: https://issues.apache.org/jira/browse/OFBIZ-12063
> Project: OFBiz
> Issue Type: Bug
> Components: product/catalog
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> This is a bug because the behaviour is not assured on Windows for instance.
> So it's impossible to correctly develop and test.
> As explained at
> https://docs.oracle.com/javase/8/docs/api/java/io/File.html#renameTo-java.io.File-
> {quote}
> Renames the file denoted by this abstract pathname.
> Many aspects of the behavior of this method are inherently
> platform-dependent: The rename operation might not be able to move a file
> from one filesystem to another, it might not be atomic, and it might not
> succeed if a file with the destination abstract pathname already exists. The
> return value should always be checked to make sure that the rename operation
> was successful.
> Note that the Files class defines the move method to move or rename a file in
> a platform independent manner.
> {quote}
> So the expression
> {code:java}
> file.renameTo(file1)
> {code}
> used in 5 Application Product Groovy scripts, can be easily replaced by
> {code:java}
> Path source = file.toPath()
> Files.move(source, source.resolveSibling(filenameToUse))
> {code}
> that is working on all platforms as explained at
> https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#move-java.nio.file.Path-java.nio.file.Path-java.nio.file.CopyOption...-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12063) Replace java.io.File::renameTo by java.nio.file.Files::move
[
https://issues.apache.org/jira/browse/OFBIZ-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239624#comment-17239624
]
ASF subversion and git services commented on OFBIZ-12063:
-
Commit f81bd885257dfeef35508c16787f0e889ae09c74 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f81bd88 ]
Reverted: Replace java.io.File::renameTo by java.nio.file.Files::move
(OFBIZ-12063)
This reverts commit 2c86f9a8c0219fe8779dcb5620ee29e3efa1df86.
Actually the problem was due to another WIP where 2 streams were not closed
> Replace java.io.File::renameTo by java.nio.file.Files::move
> ---
>
> Key: OFBIZ-12063
> URL: https://issues.apache.org/jira/browse/OFBIZ-12063
> Project: OFBiz
> Issue Type: Bug
> Components: product/catalog
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> This is a bug because the behaviour is not assured on Windows for instance.
> So it's impossible to correctly develop and test.
> As explained at
> https://docs.oracle.com/javase/8/docs/api/java/io/File.html#renameTo-java.io.File-
> {quote}
> Renames the file denoted by this abstract pathname.
> Many aspects of the behavior of this method are inherently
> platform-dependent: The rename operation might not be able to move a file
> from one filesystem to another, it might not be atomic, and it might not
> succeed if a file with the destination abstract pathname already exists. The
> return value should always be checked to make sure that the rename operation
> was successful.
> Note that the Files class defines the move method to move or rename a file in
> a platform independent manner.
> {quote}
> So the expression
> {code:java}
> file.renameTo(file1)
> {code}
> used in 5 Application Product Groovy scripts, can be easily replaced by
> {code:java}
> Path source = file.toPath()
> Files.move(source, source.resolveSibling(filenameToUse))
> {code}
> that is working on all platforms as explained at
> https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#move-java.nio.file.Path-java.nio.file.Path-java.nio.file.CopyOption...-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12063) Replace java.io.File::renameTo by java.nio.file.Files::move
[
https://issues.apache.org/jira/browse/OFBIZ-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239622#comment-17239622
]
ASF subversion and git services commented on OFBIZ-12063:
-
Commit 3201b163c89e6eeaa7dec7ccb283c30ed07f89de in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3201b16 ]
Reverted: Replace java.io.File::renameTo by java.nio.file.Files::move
(OFBIZ-12063)
This reverts commit 2c86f9a8c0219fe8779dcb5620ee29e3efa1df86.
Actually the problem was due to another WIP where 2 streams were not closed
> Replace java.io.File::renameTo by java.nio.file.Files::move
> ---
>
> Key: OFBIZ-12063
> URL: https://issues.apache.org/jira/browse/OFBIZ-12063
> Project: OFBiz
> Issue Type: Bug
> Components: product/catalog
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> This is a bug because the behaviour is not assured on Windows for instance.
> So it's impossible to correctly develop and test.
> As explained at
> https://docs.oracle.com/javase/8/docs/api/java/io/File.html#renameTo-java.io.File-
> {quote}
> Renames the file denoted by this abstract pathname.
> Many aspects of the behavior of this method are inherently
> platform-dependent: The rename operation might not be able to move a file
> from one filesystem to another, it might not be atomic, and it might not
> succeed if a file with the destination abstract pathname already exists. The
> return value should always be checked to make sure that the rename operation
> was successful.
> Note that the Files class defines the move method to move or rename a file in
> a platform independent manner.
> {quote}
> So the expression
> {code:java}
> file.renameTo(file1)
> {code}
> used in 5 Application Product Groovy scripts, can be easily replaced by
> {code:java}
> Path source = file.toPath()
> Files.move(source, source.resolveSibling(filenameToUse))
> {code}
> that is working on all platforms as explained at
> https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#move-java.nio.file.Path-java.nio.file.Path-java.nio.file.CopyOption...-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12063) Replace java.io.File::renameTo by java.nio.file.Files::move
[
https://issues.apache.org/jira/browse/OFBIZ-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239623#comment-17239623
]
ASF subversion and git services commented on OFBIZ-12063:
-
Commit bb4c815dfc702d930e8e6d80223202418e7d6ab3 in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bb4c815 ]
Reverted: Replace java.io.File::renameTo by java.nio.file.Files::move
(OFBIZ-12063)
This reverts commit 1be480b68c52b8c8403b7c935b35981e943f5057.
Actually the problem was due to another WIP where 2 streams were not closed
> Replace java.io.File::renameTo by java.nio.file.Files::move
> ---
>
> Key: OFBIZ-12063
> URL: https://issues.apache.org/jira/browse/OFBIZ-12063
> Project: OFBiz
> Issue Type: Bug
> Components: product/catalog
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> This is a bug because the behaviour is not assured on Windows for instance.
> So it's impossible to correctly develop and test.
> As explained at
> https://docs.oracle.com/javase/8/docs/api/java/io/File.html#renameTo-java.io.File-
> {quote}
> Renames the file denoted by this abstract pathname.
> Many aspects of the behavior of this method are inherently
> platform-dependent: The rename operation might not be able to move a file
> from one filesystem to another, it might not be atomic, and it might not
> succeed if a file with the destination abstract pathname already exists. The
> return value should always be checked to make sure that the rename operation
> was successful.
> Note that the Files class defines the move method to move or rename a file in
> a platform independent manner.
> {quote}
> So the expression
> {code:java}
> file.renameTo(file1)
> {code}
> used in 5 Application Product Groovy scripts, can be easily replaced by
> {code:java}
> Path source = file.toPath()
> Files.move(source, source.resolveSibling(filenameToUse))
> {code}
> that is working on all platforms as explained at
> https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#move-java.nio.file.Path-java.nio.file.Path-java.nio.file.CopyOption...-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12063) Replace java.io.File::renameTo by java.nio.file.Files::move
[
https://issues.apache.org/jira/browse/OFBIZ-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239625#comment-17239625
]
ASF subversion and git services commented on OFBIZ-12063:
-
Commit 19ef23a3e270c512f00847b5e40be3587a15fbf0 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=19ef23a ]
Reverted: Replace java.io.File::renameTo by java.nio.file.Files::move
(OFBIZ-12063)
This reverts commit 1be480b68c52b8c8403b7c935b35981e943f5057.
Actually the problem was due to another WIP where 2 streams were not closed
> Replace java.io.File::renameTo by java.nio.file.Files::move
> ---
>
> Key: OFBIZ-12063
> URL: https://issues.apache.org/jira/browse/OFBIZ-12063
> Project: OFBiz
> Issue Type: Bug
> Components: product/catalog
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> This is a bug because the behaviour is not assured on Windows for instance.
> So it's impossible to correctly develop and test.
> As explained at
> https://docs.oracle.com/javase/8/docs/api/java/io/File.html#renameTo-java.io.File-
> {quote}
> Renames the file denoted by this abstract pathname.
> Many aspects of the behavior of this method are inherently
> platform-dependent: The rename operation might not be able to move a file
> from one filesystem to another, it might not be atomic, and it might not
> succeed if a file with the destination abstract pathname already exists. The
> return value should always be checked to make sure that the rename operation
> was successful.
> Note that the Files class defines the move method to move or rename a file in
> a platform independent manner.
> {quote}
> So the expression
> {code:java}
> file.renameTo(file1)
> {code}
> used in 5 Application Product Groovy scripts, can be easily replaced by
> {code:java}
> Path source = file.toPath()
> Files.move(source, source.resolveSibling(filenameToUse))
> {code}
> that is working on all platforms as explained at
> https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#move-java.nio.file.Path-java.nio.file.Path-java.nio.file.CopyOption...-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12063) Replace java.io.File::renameTo by java.nio.file.Files::move
[
https://issues.apache.org/jira/browse/OFBIZ-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239621#comment-17239621
]
ASF subversion and git services commented on OFBIZ-12063:
-
Commit 9b45ab7affd1b2e0e0edd7ac4e4edeed8be832b0 in ofbiz-framework's branch
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9b45ab7 ]
Reverted: Replace java.io.File::renameTo by java.nio.file.Files::move
(OFBIZ-12063)
This reverts commit 1be480b68c52b8c8403b7c935b35981e943f5057.
Actually the problem was due to another WIP where 2 streams were not closed
> Replace java.io.File::renameTo by java.nio.file.Files::move
> ---
>
> Key: OFBIZ-12063
> URL: https://issues.apache.org/jira/browse/OFBIZ-12063
> Project: OFBiz
> Issue Type: Bug
> Components: product/catalog
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> This is a bug because the behaviour is not assured on Windows for instance.
> So it's impossible to correctly develop and test.
> As explained at
> https://docs.oracle.com/javase/8/docs/api/java/io/File.html#renameTo-java.io.File-
> {quote}
> Renames the file denoted by this abstract pathname.
> Many aspects of the behavior of this method are inherently
> platform-dependent: The rename operation might not be able to move a file
> from one filesystem to another, it might not be atomic, and it might not
> succeed if a file with the destination abstract pathname already exists. The
> return value should always be checked to make sure that the rename operation
> was successful.
> Note that the Files class defines the move method to move or rename a file in
> a platform independent manner.
> {quote}
> So the expression
> {code:java}
> file.renameTo(file1)
> {code}
> used in 5 Application Product Groovy scripts, can be easily replaced by
> {code:java}
> Path source = file.toPath()
> Files.move(source, source.resolveSibling(filenameToUse))
> {code}
> that is working on all platforms as explained at
> https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#move-java.nio.file.Path-java.nio.file.Path-java.nio.file.CopyOption...-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12063) Replace java.io.File::renameTo by java.nio.file.Files::move
[
https://issues.apache.org/jira/browse/OFBIZ-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239620#comment-17239620
]
ASF subversion and git services commented on OFBIZ-12063:
-
Commit 7400899b58b5d1ce84fd175093bc1349160f27a1 in ofbiz-framework's branch
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7400899 ]
Reverted: Replace java.io.File::renameTo by java.nio.file.Files::move
(OFBIZ-12063)
This reverts commit 2c86f9a8c0219fe8779dcb5620ee29e3efa1df86.
Actually the problem was due to another WIP where 2 streams were not closed
> Replace java.io.File::renameTo by java.nio.file.Files::move
> ---
>
> Key: OFBIZ-12063
> URL: https://issues.apache.org/jira/browse/OFBIZ-12063
> Project: OFBiz
> Issue Type: Bug
> Components: product/catalog
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> This is a bug because the behaviour is not assured on Windows for instance.
> So it's impossible to correctly develop and test.
> As explained at
> https://docs.oracle.com/javase/8/docs/api/java/io/File.html#renameTo-java.io.File-
> {quote}
> Renames the file denoted by this abstract pathname.
> Many aspects of the behavior of this method are inherently
> platform-dependent: The rename operation might not be able to move a file
> from one filesystem to another, it might not be atomic, and it might not
> succeed if a file with the destination abstract pathname already exists. The
> return value should always be checked to make sure that the rename operation
> was successful.
> Note that the Files class defines the move method to move or rename a file in
> a platform independent manner.
> {quote}
> So the expression
> {code:java}
> file.renameTo(file1)
> {code}
> used in 5 Application Product Groovy scripts, can be easily replaced by
> {code:java}
> Path source = file.toPath()
> Files.move(source, source.resolveSibling(filenameToUse))
> {code}
> that is working on all platforms as explained at
> https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#move-java.nio.file.Path-java.nio.file.Path-java.nio.file.CopyOption...-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12063) Replace java.io.File::renameTo by java.nio.file.Files::move
[
https://issues.apache.org/jira/browse/OFBIZ-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239591#comment-17239591
]
ASF subversion and git services commented on OFBIZ-12063:
-
Commit 41faac6a3c14fab6f90d792a4c7bb7d789eb7d94 in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=41faac6 ]
Fixed: Replace java.io.File::renameTo by java.nio.file.Files::move (OFBIZ-12063)
On Windows in EditProductContent.groovy neither file.renameTo(), Files.move()
nor FileUtils.moveFile works. Copy and delete works.
> Replace java.io.File::renameTo by java.nio.file.Files::move
> ---
>
> Key: OFBIZ-12063
> URL: https://issues.apache.org/jira/browse/OFBIZ-12063
> Project: OFBiz
> Issue Type: Bug
> Components: product/catalog
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> This is a bug because the behaviour is not assured on Windows for instance.
> So it's impossible to correctly develop and test.
> As explained at
> https://docs.oracle.com/javase/8/docs/api/java/io/File.html#renameTo-java.io.File-
> {quote}
> Renames the file denoted by this abstract pathname.
> Many aspects of the behavior of this method are inherently
> platform-dependent: The rename operation might not be able to move a file
> from one filesystem to another, it might not be atomic, and it might not
> succeed if a file with the destination abstract pathname already exists. The
> return value should always be checked to make sure that the rename operation
> was successful.
> Note that the Files class defines the move method to move or rename a file in
> a platform independent manner.
> {quote}
> So the expression
> {code:java}
> file.renameTo(file1)
> {code}
> used in 5 Application Product Groovy scripts, can be easily replaced by
> {code:java}
> Path source = file.toPath()
> Files.move(source, source.resolveSibling(filenameToUse))
> {code}
> that is working on all platforms as explained at
> https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#move-java.nio.file.Path-java.nio.file.Path-java.nio.file.CopyOption...-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12063) Replace java.io.File::renameTo by java.nio.file.Files::move
[
https://issues.apache.org/jira/browse/OFBIZ-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239590#comment-17239590
]
ASF subversion and git services commented on OFBIZ-12063:
-
Commit ce0b8903eac7795fd660f2fd3d0959c711ff0291 in ofbiz-framework's branch
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ce0b890 ]
Fixed: Replace java.io.File::renameTo by java.nio.file.Files::move (OFBIZ-12063)
On Windows in EditProductContent.groovy neither file.renameTo(), Files.move()
nor FileUtils.moveFile works. Copy and delete works.
> Replace java.io.File::renameTo by java.nio.file.Files::move
> ---
>
> Key: OFBIZ-12063
> URL: https://issues.apache.org/jira/browse/OFBIZ-12063
> Project: OFBiz
> Issue Type: Bug
> Components: product/catalog
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> This is a bug because the behaviour is not assured on Windows for instance.
> So it's impossible to correctly develop and test.
> As explained at
> https://docs.oracle.com/javase/8/docs/api/java/io/File.html#renameTo-java.io.File-
> {quote}
> Renames the file denoted by this abstract pathname.
> Many aspects of the behavior of this method are inherently
> platform-dependent: The rename operation might not be able to move a file
> from one filesystem to another, it might not be atomic, and it might not
> succeed if a file with the destination abstract pathname already exists. The
> return value should always be checked to make sure that the rename operation
> was successful.
> Note that the Files class defines the move method to move or rename a file in
> a platform independent manner.
> {quote}
> So the expression
> {code:java}
> file.renameTo(file1)
> {code}
> used in 5 Application Product Groovy scripts, can be easily replaced by
> {code:java}
> Path source = file.toPath()
> Files.move(source, source.resolveSibling(filenameToUse))
> {code}
> that is working on all platforms as explained at
> https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#move-java.nio.file.Path-java.nio.file.Path-java.nio.file.CopyOption...-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12063) Replace java.io.File::renameTo by java.nio.file.Files::move
[
https://issues.apache.org/jira/browse/OFBIZ-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17239592#comment-17239592
]
ASF subversion and git services commented on OFBIZ-12063:
-
Commit 2c86f9a8c0219fe8779dcb5620ee29e3efa1df86 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2c86f9a ]
Fixed: Replace java.io.File::renameTo by java.nio.file.Files::move (OFBIZ-12063)
On Windows in EditProductContent.groovy neither file.renameTo(), Files.move()
nor FileUtils.moveFile works. Copy and delete works.
> Replace java.io.File::renameTo by java.nio.file.Files::move
> ---
>
> Key: OFBIZ-12063
> URL: https://issues.apache.org/jira/browse/OFBIZ-12063
> Project: OFBiz
> Issue Type: Bug
> Components: product/catalog
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> This is a bug because the behaviour is not assured on Windows for instance.
> So it's impossible to correctly develop and test.
> As explained at
> https://docs.oracle.com/javase/8/docs/api/java/io/File.html#renameTo-java.io.File-
> {quote}
> Renames the file denoted by this abstract pathname.
> Many aspects of the behavior of this method are inherently
> platform-dependent: The rename operation might not be able to move a file
> from one filesystem to another, it might not be atomic, and it might not
> succeed if a file with the destination abstract pathname already exists. The
> return value should always be checked to make sure that the rename operation
> was successful.
> Note that the Files class defines the move method to move or rename a file in
> a platform independent manner.
> {quote}
> So the expression
> {code:java}
> file.renameTo(file1)
> {code}
> used in 5 Application Product Groovy scripts, can be easily replaced by
> {code:java}
> Path source = file.toPath()
> Files.move(source, source.resolveSibling(filenameToUse))
> {code}
> that is working on all platforms as explained at
> https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#move-java.nio.file.Path-java.nio.file.Path-java.nio.file.CopyOption...-
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
