[jira] [Commented] (OFBIZ-12141) Add support for Romania
[ https://issues.apache.org/jira/browse/OFBIZ-12141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267724#comment-17267724 ] Jacques Le Roux commented on OFBIZ-12141: - Hi Eugen, As we use to say IANAL, but it seems to me that a mention of the "product" (data) and license in the LICENSE file should be enough. I though recommend to open a Legal Jira before doing that. To be sure we don't miss anything: https://issues.apache.org/jira/browse/LEGAL-1 > Add support for Romania > --- > > Key: OFBIZ-12141 > URL: https://issues.apache.org/jira/browse/OFBIZ-12141 > Project: OFBiz > Issue Type: New Feature >Reporter: Ioan Eugen Stan >Priority: Major > > I would like to add support for Romania to OFBiz: provinces, taxes and the > rest. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-12142) Creating a new Customer create a wrong record in CommunicationEvent
[
https://issues.apache.org/jira/browse/OFBIZ-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-12142.
---
Fix Version/s: 18.12.01
Resolution: Fixed
I also fixed in R17, more by habit...
> Creating a new Customer create a wrong record in CommunicationEvent
> ---
>
> Key: OFBIZ-12142
> URL: https://issues.apache.org/jira/browse/OFBIZ-12142
> Project: OFBiz
> Issue Type: Bug
> Components: framework/common, party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01
>
>
> Excerpts from this user ML thread:
> [https://markmail.org/message/pf3d3qyjfucicbj7]
> Reportedby Emad Radwan :
> {quote}While creating a new Customer a new related record is created in
> CommunicationEvent table
> {quote}
> Answered by Pritam Kute :
> {quote}In OOTB flow, after creating a customer, the system calls
> sendCreatePartyEmailNotification service asynchronously. This service is
> called to send an email notification to the customer about account creation.
> This causes the creation of a record in CommunicationEvent table.
> I feel that sending email should be configurable but an initial cursory look
> at the codebase doesn't guarantee about it.
> Also, one thing to notice is that the CommunicationEvent created has a
> record with partyIdFrom as FrenchCustomer which is completely wrong as it
> should be a company party. The logic in createCommEventFromEmail (line no.
> 776) to find out "fromCm" is what causing this problem.
> {quote}
> Answered by myself:
> {quote}
> I think found the reason. In demo data 13 parties use
> <> as in
> infoString="ofbizt...@example.com"/>
> I guess this one is loaded last. Rather
> infoString="ofbizt...@example.com"/>
> which is the 1st one, should be loaded last.
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-12139) Terms are not shown correctly on the Invoice overview
[ https://issues.apache.org/jira/browse/OFBIZ-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12139. --- Fix Version/s: Upcoming Branch Resolution: Fixed > Terms are not shown correctly on the Invoice overview > - > > Key: OFBIZ-12139 > URL: https://issues.apache.org/jira/browse/OFBIZ-12139 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-12139.patch, image-2021-01-15-20-09-04-736.png > > > When we have multiple Payment (Net Days) terms on the invoice say > 20% in 15Days (FIN_PAY_NETDAYS_1) > 80% in 30Days (FIN_PAY_NETDAYS_2) > The terms section shows incorrect term data as shown in the screenshot. > !image-2021-01-15-20-09-04-736.png! > Also, we do not get the correct sales invoice on this reporting screen > https://demo-trunk.ofbiz.apache.org/accounting/control/FindSalesInvoicesByDueDate -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12139) Terms are not shown correctly on the Invoice overview
[ https://issues.apache.org/jira/browse/OFBIZ-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267478#comment-17267478 ] Jacques Le Roux commented on OFBIZ-12139: - I'm not sure about: bq. Also I don't see any differences at /accounting/control/FindSalesInvoicesByDueDate before and after applying the patch So I did not comment about it in the commit. > Terms are not shown correctly on the Invoice overview > - > > Key: OFBIZ-12139 > URL: https://issues.apache.org/jira/browse/OFBIZ-12139 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12139.patch, image-2021-01-15-20-09-04-736.png > > > When we have multiple Payment (Net Days) terms on the invoice say > 20% in 15Days (FIN_PAY_NETDAYS_1) > 80% in 30Days (FIN_PAY_NETDAYS_2) > The terms section shows incorrect term data as shown in the screenshot. > !image-2021-01-15-20-09-04-736.png! > Also, we do not get the correct sales invoice on this reporting screen > https://demo-trunk.ofbiz.apache.org/accounting/control/FindSalesInvoicesByDueDate -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12139) Terms are not shown correctly on the Invoice overview
[ https://issues.apache.org/jira/browse/OFBIZ-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267476#comment-17267476 ] ASF subversion and git services commented on OFBIZ-12139: - Commit bee1b11831f6d0bd9baa2b17a9cbb4c33d71bc04 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bee1b11 ] Fixed: Terms are not shown correctly on the Invoice overview (OFBIZ-12139) When we have multiple Payment (Net Days) terms on the invoice say 20% in 15Days (FIN_PAY_NETDAYS_1) 80% in 30Days (FIN_PAY_NETDAYS_2) The terms section shows incorrect term data as shown in the screenshot. Thanks: Nameet Jain for report and fix, Jacopo for confirmation > Terms are not shown correctly on the Invoice overview > - > > Key: OFBIZ-12139 > URL: https://issues.apache.org/jira/browse/OFBIZ-12139 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12139.patch, image-2021-01-15-20-09-04-736.png > > > When we have multiple Payment (Net Days) terms on the invoice say > 20% in 15Days (FIN_PAY_NETDAYS_1) > 80% in 30Days (FIN_PAY_NETDAYS_2) > The terms section shows incorrect term data as shown in the screenshot. > !image-2021-01-15-20-09-04-736.png! > Also, we do not get the correct sales invoice on this reporting screen > https://demo-trunk.ofbiz.apache.org/accounting/control/FindSalesInvoicesByDueDate -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12142) Creating a new Customer create a wrong record in CommunicationEvent
[
https://issues.apache.org/jira/browse/OFBIZ-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267469#comment-17267469
]
ASF subversion and git services commented on OFBIZ-12142:
-
Commit 20e7fc54358c42b22c81f6e4a2d43da1a9c14e0b in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=20e7fc5 ]
Fixed: Creating a new Customer create a wrong record in CommunicationEvent
(OFBIZ-12142)
In https://markmail.org/message/pf3d3qyjfucicbj7 I initially answered:
In demo data 13 parties use <> as in
This one is loaded last. Rather
which is the 1st one, should be loaded last.
A better solution is to use "ofbizsupp...@example.com" in EmailServices.xml
Indeed, fortunately the Company party also uses this infoString and using it in
EmailServices.xml does not affect the integration test and should not affect
other parts of the (only) demo data
Thanks: Emad Radwan for opiniated report :) and Pritam Kute for issue analysis
> Creating a new Customer create a wrong record in CommunicationEvent
> ---
>
> Key: OFBIZ-12142
> URL: https://issues.apache.org/jira/browse/OFBIZ-12142
> Project: OFBiz
> Issue Type: Bug
> Components: framework/common, party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> Excerpts from this user ML thread:
> [https://markmail.org/message/pf3d3qyjfucicbj7]
> Reportedby Emad Radwan :
> {quote}While creating a new Customer a new related record is created in
> CommunicationEvent table
> {quote}
> Answered by Pritam Kute :
> {quote}In OOTB flow, after creating a customer, the system calls
> sendCreatePartyEmailNotification service asynchronously. This service is
> called to send an email notification to the customer about account creation.
> This causes the creation of a record in CommunicationEvent table.
> I feel that sending email should be configurable but an initial cursory look
> at the codebase doesn't guarantee about it.
> Also, one thing to notice is that the CommunicationEvent created has a
> record with partyIdFrom as FrenchCustomer which is completely wrong as it
> should be a company party. The logic in createCommEventFromEmail (line no.
> 776) to find out "fromCm" is what causing this problem.
> {quote}
> Answered by myself:
> {quote}
> I think found the reason. In demo data 13 parties use
> <> as in
> infoString="ofbizt...@example.com"/>
> I guess this one is loaded last. Rather
> infoString="ofbizt...@example.com"/>
> which is the 1st one, should be loaded last.
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12142) Creating a new Customer create a wrong record in CommunicationEvent
[
https://issues.apache.org/jira/browse/OFBIZ-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267467#comment-17267467
]
ASF subversion and git services commented on OFBIZ-12142:
-
Commit e1d57fba007684f1aaec9cdcc358ec526548aec3 in ofbiz-framework's branch
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e1d57fb ]
Fixed: Creating a new Customer create a wrong record in CommunicationEvent
(OFBIZ-12142)
In https://markmail.org/message/pf3d3qyjfucicbj7 I initially answered:
In demo data 13 parties use <> as in
This one is loaded last. Rather
which is the 1st one, should be loaded last.
A better solution is to use "ofbizsupp...@example.com" in EmailServices.xml
Indeed, fortunately the Company party also uses this infoString and using it in
EmailServices.xml does not affect the integration test and should not affect
other parts of the (only) demo data
Thanks: Emad Radwan for opiniated report :) and Pritam Kute for issue analysis
> Creating a new Customer create a wrong record in CommunicationEvent
> ---
>
> Key: OFBIZ-12142
> URL: https://issues.apache.org/jira/browse/OFBIZ-12142
> Project: OFBiz
> Issue Type: Bug
> Components: framework/common, party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> Excerpts from this user ML thread:
> [https://markmail.org/message/pf3d3qyjfucicbj7]
> Reportedby Emad Radwan :
> {quote}While creating a new Customer a new related record is created in
> CommunicationEvent table
> {quote}
> Answered by Pritam Kute :
> {quote}In OOTB flow, after creating a customer, the system calls
> sendCreatePartyEmailNotification service asynchronously. This service is
> called to send an email notification to the customer about account creation.
> This causes the creation of a record in CommunicationEvent table.
> I feel that sending email should be configurable but an initial cursory look
> at the codebase doesn't guarantee about it.
> Also, one thing to notice is that the CommunicationEvent created has a
> record with partyIdFrom as FrenchCustomer which is completely wrong as it
> should be a company party. The logic in createCommEventFromEmail (line no.
> 776) to find out "fromCm" is what causing this problem.
> {quote}
> Answered by myself:
> {quote}
> I think found the reason. In demo data 13 parties use
> <> as in
> infoString="ofbizt...@example.com"/>
> I guess this one is loaded last. Rather
> infoString="ofbizt...@example.com"/>
> which is the 1st one, should be loaded last.
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12142) Creating a new Customer create a wrong record in CommunicationEvent
[
https://issues.apache.org/jira/browse/OFBIZ-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267468#comment-17267468
]
ASF subversion and git services commented on OFBIZ-12142:
-
Commit b7ee7fc397055128c95bfeedaf281f82f6919ad2 in ofbiz-framework's branch
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b7ee7fc ]
Fixed: Creating a new Customer create a wrong record in CommunicationEvent
(OFBIZ-12142)
In https://markmail.org/message/pf3d3qyjfucicbj7 I initially answered:
In demo data 13 parties use <> as in
This one is loaded last. Rather
which is the 1st one, should be loaded last.
A better solution is to use "ofbizsupp...@example.com" in EmailServices.xml
Indeed, fortunately the Company party also uses this infoString and using it in
EmailServices.xml does not affect the integration test and should not affect
other parts of the (only) demo data
Thanks: Emad Radwan for opiniated report :) and Pritam Kute for issue analysis
> Creating a new Customer create a wrong record in CommunicationEvent
> ---
>
> Key: OFBIZ-12142
> URL: https://issues.apache.org/jira/browse/OFBIZ-12142
> Project: OFBiz
> Issue Type: Bug
> Components: framework/common, party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> Excerpts from this user ML thread:
> [https://markmail.org/message/pf3d3qyjfucicbj7]
> Reportedby Emad Radwan :
> {quote}While creating a new Customer a new related record is created in
> CommunicationEvent table
> {quote}
> Answered by Pritam Kute :
> {quote}In OOTB flow, after creating a customer, the system calls
> sendCreatePartyEmailNotification service asynchronously. This service is
> called to send an email notification to the customer about account creation.
> This causes the creation of a record in CommunicationEvent table.
> I feel that sending email should be configurable but an initial cursory look
> at the codebase doesn't guarantee about it.
> Also, one thing to notice is that the CommunicationEvent created has a
> record with partyIdFrom as FrenchCustomer which is completely wrong as it
> should be a company party. The logic in createCommEventFromEmail (line no.
> 776) to find out "fromCm" is what causing this problem.
> {quote}
> Answered by myself:
> {quote}
> I think found the reason. In demo data 13 parties use
> <> as in
> infoString="ofbizt...@example.com"/>
> I guess this one is loaded last. Rather
> infoString="ofbizt...@example.com"/>
> which is the 1st one, should be loaded last.
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12143) Incorrect mapping for Lookup Purchase Order
[
https://issues.apache.org/jira/browse/OFBIZ-12143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajesh Kumar updated OFBIZ-12143:
-
Description:
Lookup screen for {color:#33}Purchase Order Header and Ship Info{color} has
{color:#032f62}ListLookupOrderHeaderAndShipInfo{color} for result list. This
mapping has {color:#032f62}LookupOrderHeaderAndShipInfo{color} as
paginate-target due to this pagination buttons are failing when result has
multiple pages.
This can be fixed by adding a new form as
{color:#032f62}ListPurchaseOrderHeaderAndShipInfo.{color}
{color:#032f62}filename: {color}
*applications\order\widget\ordermgr\LookupScreens.xml*
{color:#032f62}!image-2021-01-19-02-43-58-567.png!{color}
was:
Lookup screen for {color:#33}Purchase Order Header and Ship Info{color} has
{color:#032f62}ListLookupOrderHeaderAndShipInfo{color} for result list. This
mapping has {color:#032f62}LookupOrderHeaderAndShipInfo{color} as
paginate-target due to this pagination buttons are failing when result has
multiple pages.
This can be fixed by adding a new form as
{color:#032f62}ListPurchaseOrderHeaderAndShipInfo.{color}
applications\order\widget\ordermgr\LookupScreens.xml
{color:#032f62}!image-2021-01-19-02-43-58-567.png!{color}
> Incorrect mapping for Lookup Purchase Order
>
>
> Key: OFBIZ-12143
> URL: https://issues.apache.org/jira/browse/OFBIZ-12143
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12,
> Trunk, 17.12.05
> Environment: All
>Reporter: Rajesh Kumar
>Priority: Major
> Attachments: image-2021-01-19-02-43-58-567.png
>
>
> Lookup screen for {color:#33}Purchase Order Header and Ship Info{color}
> has {color:#032f62}ListLookupOrderHeaderAndShipInfo{color} for result list.
> This mapping has {color:#032f62}LookupOrderHeaderAndShipInfo{color} as
> paginate-target due to this pagination buttons are failing when result has
> multiple pages.
>
> This can be fixed by adding a new form as
> {color:#032f62}ListPurchaseOrderHeaderAndShipInfo.{color}
> {color:#032f62}filename: {color}
> *applications\order\widget\ordermgr\LookupScreens.xml*
>
> {color:#032f62}!image-2021-01-19-02-43-58-567.png!{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12143) Incorrect mapping for Lookup Purchase Order
[
https://issues.apache.org/jira/browse/OFBIZ-12143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajesh Kumar updated OFBIZ-12143:
-
Description:
Lookup screen for {color:#33}Purchase Order Header and Ship Info{color} has
{color:#032f62}ListLookupOrderHeaderAndShipInfo{color} for result list. This
mapping has {color:#032f62}LookupOrderHeaderAndShipInfo{color} as
paginate-target due to this pagination buttons are failing when result has
multiple pages.
This can be fixed by adding a new form as
{color:#032f62}ListPurchaseOrderHeaderAndShipInfo.{color}
applications\order\widget\ordermgr\LookupScreens.xml
{color:#032f62}!image-2021-01-19-02-43-58-567.png!{color}
was:
Lookup screen for {color:#33}Purchase Order Header and Ship Info{color} has
{color:#032f62}ListLookupOrderHeaderAndShipInfo{color} for result list. This
mapping has {color:#032f62}LookupOrderHeaderAndShipInfo{color} as
paginate-target due to this pagination buttons are failing when result has
multiple pages.
This can be fixed by adding a new form as
{color:#032f62}ListPurchaseOrderHeaderAndShipInfo.{color}
{color:#032f62}!image-2021-01-19-02-43-58-567.png!{color}
> Incorrect mapping for Lookup Purchase Order
>
>
> Key: OFBIZ-12143
> URL: https://issues.apache.org/jira/browse/OFBIZ-12143
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12,
> Trunk, 17.12.05
> Environment: All
>Reporter: Rajesh Kumar
>Priority: Major
> Attachments: image-2021-01-19-02-43-58-567.png
>
>
> Lookup screen for {color:#33}Purchase Order Header and Ship Info{color}
> has {color:#032f62}ListLookupOrderHeaderAndShipInfo{color} for result list.
> This mapping has {color:#032f62}LookupOrderHeaderAndShipInfo{color} as
> paginate-target due to this pagination buttons are failing when result has
> multiple pages.
>
> This can be fixed by adding a new form as
> {color:#032f62}ListPurchaseOrderHeaderAndShipInfo.{color}
> applications\order\widget\ordermgr\LookupScreens.xml
>
> {color:#032f62}!image-2021-01-19-02-43-58-567.png!{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-12143) Incorrect mapping for Lookup Purchase Order
Rajesh Kumar created OFBIZ-12143:
Summary: Incorrect mapping for Lookup Purchase Order
Key: OFBIZ-12143
URL: https://issues.apache.org/jira/browse/OFBIZ-12143
Project: OFBiz
Issue Type: Bug
Affects Versions: 17.12.05, Trunk, Release Branch 18.12, 18.12.01, Release
Branch 17.12
Environment: All
Reporter: Rajesh Kumar
Attachments: image-2021-01-19-02-43-58-567.png
Lookup screen for {color:#33}Purchase Order Header and Ship Info{color} has
{color:#032f62}ListLookupOrderHeaderAndShipInfo{color} for result list. This
mapping has {color:#032f62}LookupOrderHeaderAndShipInfo{color} as
paginate-target due to this pagination buttons are failing when result has
multiple pages.
This can be fixed by adding a new form as
{color:#032f62}ListPurchaseOrderHeaderAndShipInfo.{color}
{color:#032f62}!image-2021-01-19-02-43-58-567.png!{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-12142) Creating a new Customer create a wrong record in CommunicationEvent
Jacques Le Roux created OFBIZ-12142:
---
Summary: Creating a new Customer create a wrong record in
CommunicationEvent
Key: OFBIZ-12142
URL: https://issues.apache.org/jira/browse/OFBIZ-12142
Project: OFBiz
Issue Type: Bug
Components: framework/common, party
Affects Versions: Trunk
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Excerpts from this user ML thread:
[https://markmail.org/message/pf3d3qyjfucicbj7]
Reportedby Emad Radwan :
{quote}While creating a new Customer a new related record is created in
CommunicationEvent table
{quote}
Answered by Pritam Kute :
{quote}In OOTB flow, after creating a customer, the system calls
sendCreatePartyEmailNotification service asynchronously. This service is called
to send an email notification to the customer about account creation. This
causes the creation of a record in CommunicationEvent table.
I feel that sending email should be configurable but an initial cursory look at
the codebase doesn't guarantee about it.
Also, one thing to notice is that the CommunicationEvent created has a record
with partyIdFrom as FrenchCustomer which is completely wrong as it should be a
company party. The logic in createCommEventFromEmail (line no. 776) to find out
"fromCm" is what causing this problem.
{quote}
Answered by myself:
{quote}
I think found the reason. In demo data 13 parties use
<> as in
I guess this one is loaded last. Rather
which is the 1st one, should be loaded last.
{quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12139) Terms are not shown correctly on the Invoice overview
[ https://issues.apache.org/jira/browse/OFBIZ-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-12139: --- Assignee: Jacques Le Roux > Terms are not shown correctly on the Invoice overview > - > > Key: OFBIZ-12139 > URL: https://issues.apache.org/jira/browse/OFBIZ-12139 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12139.patch, image-2021-01-15-20-09-04-736.png > > > When we have multiple Payment (Net Days) terms on the invoice say > 20% in 15Days (FIN_PAY_NETDAYS_1) > 80% in 30Days (FIN_PAY_NETDAYS_2) > The terms section shows incorrect term data as shown in the screenshot. > !image-2021-01-15-20-09-04-736.png! > Also, we do not get the correct sales invoice on this reporting screen > https://demo-trunk.ofbiz.apache.org/accounting/control/FindSalesInvoicesByDueDate -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12139) Terms are not shown correctly on the Invoice overview
[ https://issues.apache.org/jira/browse/OFBIZ-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267250#comment-17267250 ] Jacopo Cappellato commented on OFBIZ-12139: --- yes, I have tested it and it fixes the issue > Terms are not shown correctly on the Invoice overview > - > > Key: OFBIZ-12139 > URL: https://issues.apache.org/jira/browse/OFBIZ-12139 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Nameet Jain >Priority: Major > Attachments: OFBIZ-12139.patch, image-2021-01-15-20-09-04-736.png > > > When we have multiple Payment (Net Days) terms on the invoice say > 20% in 15Days (FIN_PAY_NETDAYS_1) > 80% in 30Days (FIN_PAY_NETDAYS_2) > The terms section shows incorrect term data as shown in the screenshot. > !image-2021-01-15-20-09-04-736.png! > Also, we do not get the correct sales invoice on this reporting screen > https://demo-trunk.ofbiz.apache.org/accounting/control/FindSalesInvoicesByDueDate -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12139) Terms are not shown correctly on the Invoice overview
[ https://issues.apache.org/jira/browse/OFBIZ-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267203#comment-17267203 ] Jacques Le Roux commented on OFBIZ-12139: - Thanks Jacopo, So you confirm Nameet's fix works, right? > Terms are not shown correctly on the Invoice overview > - > > Key: OFBIZ-12139 > URL: https://issues.apache.org/jira/browse/OFBIZ-12139 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Nameet Jain >Priority: Major > Attachments: OFBIZ-12139.patch, image-2021-01-15-20-09-04-736.png > > > When we have multiple Payment (Net Days) terms on the invoice say > 20% in 15Days (FIN_PAY_NETDAYS_1) > 80% in 30Days (FIN_PAY_NETDAYS_2) > The terms section shows incorrect term data as shown in the screenshot. > !image-2021-01-15-20-09-04-736.png! > Also, we do not get the correct sales invoice on this reporting screen > https://demo-trunk.ofbiz.apache.org/accounting/control/FindSalesInvoicesByDueDate -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12139) Terms are not shown correctly on the Invoice overview
[ https://issues.apache.org/jira/browse/OFBIZ-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267175#comment-17267175 ] Jacopo Cappellato commented on OFBIZ-12139: --- Hi Jacques, clear() doesn't work because the issue in the code is that, when there are more than one terms, we are adding to the list the reference of the same Java object to several times: since the references are pointing to the same object, the code will update the object (with clear() and then repopulating its fields) with the information from the last term only. This issue was introduced with the migration to Groovy. In order to recreate the issue, you need to add two terms of type "Payment net days" to the order, then create the invoice and then you will see the duplicated terms in the invoice detail screen (and in the FindSalesInvoicesByDueDate research screen). > Terms are not shown correctly on the Invoice overview > - > > Key: OFBIZ-12139 > URL: https://issues.apache.org/jira/browse/OFBIZ-12139 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Nameet Jain >Priority: Major > Attachments: OFBIZ-12139.patch, image-2021-01-15-20-09-04-736.png > > > When we have multiple Payment (Net Days) terms on the invoice say > 20% in 15Days (FIN_PAY_NETDAYS_1) > 80% in 30Days (FIN_PAY_NETDAYS_2) > The terms section shows incorrect term data as shown in the screenshot. > !image-2021-01-15-20-09-04-736.png! > Also, we do not get the correct sales invoice on this reporting screen > https://demo-trunk.ofbiz.apache.org/accounting/control/FindSalesInvoicesByDueDate -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11855) Convert RoutingServices.xml mini-lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267174#comment-17267174 ] Ioan Eugen Stan commented on OFBIZ-11855: - Hi [~yashwant.dhakad] , I've noticed the PR is still open on github [https://github.com/apache/ofbiz-framework/pull/235] . Has this been merged? It would be nice to be one step closer to removing minilang. Thanks, Eugen > Convert RoutingServices.xml mini-lang to groovy > --- > > Key: OFBIZ-11855 > URL: https://issues.apache.org/jira/browse/OFBIZ-11855 > Project: OFBiz > Issue Type: Sub-task >Reporter: Wiebke Pätzold >Assignee: Yashwant Dhakad >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267172#comment-17267172 ] Ioan Eugen Stan commented on OFBIZ-11587: - Thank you. I agree. > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267168#comment-17267168 ] Olivier Heintz commented on OFBIZ-11587: done, Thank you very much for your notice, it's really better when all is clear > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] Olivier-Heintz closed pull request #15: OFBIZ-11587 ofbiz-plugins delete related docbook files migrated to asciidoc
Olivier-Heintz closed pull request #15: URL: https://github.com/apache/ofbiz-plugins/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] Olivier-Heintz commented on pull request #15: OFBIZ-11587 ofbiz-plugins delete related docbook files migrated to asciidoc
Olivier-Heintz commented on pull request #15: URL: https://github.com/apache/ofbiz-plugins/pull/15#issuecomment-762165116 all has been merge in trunk This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] Olivier-Heintz commented on pull request #13: OFBIZ-11587 ofbiz-plugins docbook migration to asciidoc
Olivier-Heintz commented on pull request #13: URL: https://github.com/apache/ofbiz-plugins/pull/13#issuecomment-762164456 All have been integrated in trunk This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] Olivier-Heintz closed pull request #13: OFBIZ-11587 ofbiz-plugins docbook migration to asciidoc
Olivier-Heintz closed pull request #13: URL: https://github.com/apache/ofbiz-plugins/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267154#comment-17267154 ] Ioan Eugen Stan commented on OFBIZ-11587: - Glad to be of assistance. I've noticed PR 13 and 15 are still open - should they also be closed? > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267112#comment-17267112 ] Olivier Heintz commented on OFBIZ-11587: Thank you Eugen for the reminder Thank you Jacques for the checking, I've just deleted the branch and thus closed the PR (65 & 66), I have forgot this step when I have done the last commit. Thanks > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Assignee: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] Olivier-Heintz closed pull request #66: OFBIZ-11587 docbook to asciidoc, delete docbook files
Olivier-Heintz closed pull request #66: URL: https://github.com/apache/ofbiz-framework/pull/66 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #65: OFBIZ-11587 docbook to asciidoc
JacquesLeRoux commented on pull request #65: URL: https://github.com/apache/ofbiz-framework/pull/65#issuecomment-762099128 Thanks Eugen, done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux closed pull request #65: OFBIZ-11587 docbook to asciidoc
JacquesLeRoux closed pull request #65: URL: https://github.com/apache/ofbiz-framework/pull/65 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #247: Fixed: Unique form names for promo actions (OFBIZ-12082)
JacquesLeRoux commented on pull request #247: URL: https://github.com/apache/ofbiz-framework/pull/247#issuecomment-762098220 Thanks Deepak, done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux closed pull request #247: Fixed: Unique form names for promo actions (OFBIZ-12082)
JacquesLeRoux closed pull request #247: URL: https://github.com/apache/ofbiz-framework/pull/247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
