[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #260: OFBIZ-11461 Improved: Converted OrderDeliveryServices.xml minilang to groovy

2021-02-01 Thread GitBox


sonarcloud[bot] commented on pull request #260:
URL: https://github.com/apache/ofbiz-framework/pull/260#issuecomment-771424631


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=260=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=260=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=260=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=260=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=260=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=260=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=260=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=260=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=260=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=260=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=260=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=260=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=260)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=260=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=260=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-11461) Convert OrderDeliveryServices.xml minilang to groovy

2021-02-01 Thread Sebastian Berg (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebastian Berg updated OFBIZ-11461:
---
Attachment: (was: 
OFBIZ-11461-OrderDeliveryServices.xml-minilang-to-groovy.patch)

> Convert OrderDeliveryServices.xml minilang to groovy
> 
>
> Key: OFBIZ-11461
> URL: https://issues.apache.org/jira/browse/OFBIZ-11461
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11461) Convert OrderDeliveryServices.xml minilang to groovy

2021-02-01 Thread Sebastian Berg (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276898#comment-17276898
 ] 

Sebastian Berg commented on OFBIZ-11461:


I removed the patch and created a PR instead for easier merging.

> Convert OrderDeliveryServices.xml minilang to groovy
> 
>
> Key: OFBIZ-11461
> URL: https://issues.apache.org/jira/browse/OFBIZ-11461
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] SebastianEcomify opened a new pull request #260: OFBIZ-11461 Improved: Converted OrderDeliveryServices.xml minilang to groovy

2021-02-01 Thread GitBox


SebastianEcomify opened a new pull request #260:
URL: https://github.com/apache/ofbiz-framework/pull/260


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-10772) OFBiz On a Diet

2021-02-01 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276509#comment-17276509
 ] 

Jacques Le Roux commented on OFBIZ-10772:
-

OK with me, +1 to close

> OFBiz On a Diet
> ---
>
> Key: OFBIZ-10772
> URL: https://issues.apache.org/jira/browse/OFBIZ-10772
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Minor
>
> OFBiz is laden with superfluous redundancies and approaches for 'novice' 
> developers, when it comes to handling labels (titles) for screens and fields 
> in forms in both Freemarker templates and widgets.
> In screens we have defined elements such as: 
> {code:java}
> 
> {code}
> and
>  
> {code:java}
> 
> {code}
> Equally so we have defined elements in widget forms and templates, such as:
> {code:java}
> ${uiLabelMap.FormFieldTitle_}
> {code}
> or
> {code:java}
> ${uiLabelMap.}
> {code}
> This all has led to a situation where we have a product that, label-wise, 
> overflown with exceptions on exceptions, and unnecessary 'explanations' - 
> such as the 'componentName', or 'PageTitle' or 'FormFieldTitle_', in any of 
> the files.
> Equally so, having to have the name of the component in the identifier of a 
> label is unnecessary and reduces reuse. An 'Amount' label has the same 
> meaning everywhere (given its context), so there is no need to have 
> definitions like:
>  * AccountingAmount
>  * PaymentAmount
>  * ProductAmount
>  * OrderAmount
>  * TermAmount
>  * FormFieldTitle_amount
>  * etc.
> Having done a quick assessment I get to over 90.000 unnecessary identifiers 
> in our files that  hampers us in reusing labels as much as possible.
> We can save 100.000s of bytes in our product by removing these unnecessary 
> 'novice' developer requirements, resulting in cost- and time-saving benefits 
> for our adopters, their developers and our contributors.
> This is the umbrella ticket to capture related sub-tasks (tickets/sub-tasks).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager

2021-02-01 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276506#comment-17276506
 ] 

Jacques Le Roux commented on OFBIZ-10476:
-

Hi Michael, +1 to remove

> Remove Compdoc functionality from content manager
> -
>
> Key: OFBIZ-10476
> URL: https://issues.apache.org/jira/browse/OFBIZ-10476
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10476_Content-CompDoc.patch
>
>
> While creating a theme and looking for not correctly styled elements I came 
> across "some" not functional links and buttons in Compdoc.
> This module seems not to be finished or working properly, because most of the 
> times, the buttons inside the appbar produce errors or just empty pages.
> Even when searching for existing elements and then clicking on them to 
> examine or edit them will mostly create an error (example: go to compdoc, 
> search for template child, click edit on some random found element -> error).
> Sometimes the menu which is included inside the appbar, mostly the menu 
> called "tree", need the contentId for the buttons to work.
> Including this menu while creating a new entry will result in every button 
> not working and throwing an error, except the edit button, which will produce 
> a completely empty page.
> Those things appear all over the module, trying some button or clicking some 
> link resulted in an error screen more than it resulted in something actually 
> working.
> This should either be fixed or removed, if this doesn't has a real purpose at 
> all.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager

2021-02-01 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276499#comment-17276499
 ] 

Michael Brohl commented on OFBIZ-10476:
---

[~jleroux]  any objections to remove CompDoc and backport to 18.12?

> Remove Compdoc functionality from content manager
> -
>
> Key: OFBIZ-10476
> URL: https://issues.apache.org/jira/browse/OFBIZ-10476
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10476_Content-CompDoc.patch
>
>
> While creating a theme and looking for not correctly styled elements I came 
> across "some" not functional links and buttons in Compdoc.
> This module seems not to be finished or working properly, because most of the 
> times, the buttons inside the appbar produce errors or just empty pages.
> Even when searching for existing elements and then clicking on them to 
> examine or edit them will mostly create an error (example: go to compdoc, 
> search for template child, click edit on some random found element -> error).
> Sometimes the menu which is included inside the appbar, mostly the menu 
> called "tree", need the contentId for the buttons to work.
> Including this menu while creating a new entry will result in every button 
> not working and throwing an error, except the edit button, which will produce 
> a completely empty page.
> Those things appear all over the module, trying some button or clicking some 
> link resulted in an error screen more than it resulted in something actually 
> working.
> This should either be fixed or removed, if this doesn't has a real purpose at 
> all.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10507) LoginServices.userLogin: Respond "fail" instead of "error" to avoid the (automatic service engine) logging of a stack trace on missing/invalid credentials

2021-02-01 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276496#comment-17276496
 ] 

Michael Brohl commented on OFBIZ-10507:
---

[~bjugl] can you provide a PR based on your patch?

> LoginServices.userLogin: Respond "fail" instead of "error" to avoid the 
> (automatic service engine) logging of a stack trace on missing/invalid 
> credentials
> --
>
> Key: OFBIZ-10507
> URL: https://issues.apache.org/jira/browse/OFBIZ-10507
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: 
> OFBIZ-10507_org.apache.ofbiz.common.login.LoginServices.patch
>
>
> There are a lot of login-related entries in the logfile, that stem from user 
> related errors (like no or wrong password, user not found and so on). To 
> reduce this, the patch introduces a distinction between ERROR messages and 
> FAIL messages in the Service-Result.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-10688) textareas do not save data, when visual-editor is used

2021-02-01 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10688.
-
Resolution: Not A Problem

I cannot reproduce this on the latest trunk demo, closing.

> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Bildschirmfoto 2020-02-28 um 12.45.18.png, 
> OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums 
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry 
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
>  process [problem invoking the [createTextContent] service with the map named 
> [...]"
> Data is not stored.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10772) OFBiz On a Diet

2021-02-01 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276479#comment-17276479
 ] 

Michael Brohl commented on OFBIZ-10772:
---

I tend to close this issue and open subtask with "Won't do". The reporter does 
not seem to bring this further and we already decided for "Won't do" in some 
subtasks.

Any objections?

> OFBiz On a Diet
> ---
>
> Key: OFBIZ-10772
> URL: https://issues.apache.org/jira/browse/OFBIZ-10772
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Minor
>
> OFBiz is laden with superfluous redundancies and approaches for 'novice' 
> developers, when it comes to handling labels (titles) for screens and fields 
> in forms in both Freemarker templates and widgets.
> In screens we have defined elements such as: 
> {code:java}
> 
> {code}
> and
>  
> {code:java}
> 
> {code}
> Equally so we have defined elements in widget forms and templates, such as:
> {code:java}
> ${uiLabelMap.FormFieldTitle_}
> {code}
> or
> {code:java}
> ${uiLabelMap.}
> {code}
> This all has led to a situation where we have a product that, label-wise, 
> overflown with exceptions on exceptions, and unnecessary 'explanations' - 
> such as the 'componentName', or 'PageTitle' or 'FormFieldTitle_', in any of 
> the files.
> Equally so, having to have the name of the component in the identifier of a 
> label is unnecessary and reduces reuse. An 'Amount' label has the same 
> meaning everywhere (given its context), so there is no need to have 
> definitions like:
>  * AccountingAmount
>  * PaymentAmount
>  * ProductAmount
>  * OrderAmount
>  * TermAmount
>  * FormFieldTitle_amount
>  * etc.
> Having done a quick assessment I get to over 90.000 unnecessary identifiers 
> in our files that  hampers us in reusing labels as much as possible.
> We can save 100.000s of bytes in our product by removing these unnecessary 
> 'novice' developer requirements, resulting in cost- and time-saving benefits 
> for our adopters, their developers and our contributors.
> This is the umbrella ticket to capture related sub-tasks (tickets/sub-tasks).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11026) HR Doc drive by process

2021-02-01 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-11026:
-

Assignee: (was: Michael Brohl)

> HR Doc drive by process
> ---
>
> Key: OFBIZ-11026
> URL: https://issues.apache.org/jira/browse/OFBIZ-11026
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: Documentation, humanres
> Attachments: 
> OFBIZ-11026_Documented-HR-Doc-drive-by-process-OFBIZ-11026.patch, 
> OFBIZ-11026_hr-intro.adoc.patch, OFBIZ-11026_humanres.adoc.patch, 
> OFBIZ-11026_humanres.adoc_with_hr-about-doc.patch
>
>
> Currently HR doc main chapters are on core HR object, I propose to group them 
> in a chapter and having a chapter by process in the same level bot group in 
> the HR Process.
> Each process is described via a scenario explained like a tutorial, and each 
> time a core object is used, a link is done to its chapter.
> To help review : doc with these modifications are available at 
> [https://ofbizadoc.ofbizextra.org/html5/user-manual.html#_human_resources]
> and Apache OFBiz standard (without modifications) is available too at 
> https://ofbizadoc.ofbizextra.org/html5/user-manual-std.html#_human_resources
> current HR TOC
>  --
>  3.2. Human Resources
>      3.2.1. About Human Resources
>      3.2.2. Human Resources Processes
>      3.2.3. Employee Positions
>      3.2.4. Employees
>      3.2.5. Employments
>      3.2.6. Performance Review
>      3.2.7. Qualifications
>      3.2.8. Recruitment
>      3.2.9. Skills
>      3.2.10. Resumes
>      3.2.11. Training
>      3.2.12. Leave
>      3.2.13. Security
>      3.2.14. Global HR Settings
>      3.2.15. Glossary
>  Proposed HR TOC
>  
>  4. Human Resources
>      4.1. About this documentation
>      4.2. About Human Resources
>      4.3. HR Processes
>      4.3.1. Organization, Job Position and Definition
>      4.3.2. Recruitment, Candidate Selection and Hiring
>      4.3.3. Employee Training and Development
>      4.3.4. Performance Management and Employee Evaluation
>      4.3.5. Employee Salary and Benefits Administration
>      4.4. HR core object
>      4.4.1. Employee Positions
>      4.4.2. Employees
>      4.4.3. Employments
>      4.4.4. Performance Review
>      4.4.5. Qualifications
>      4.4.6. Recruitment
>      4.4.7. Skills
>      4.4.8. Resumes
>      4.4.9. Training
>      4.4.10. Leave
>      4.4.11. Security
>      4.5. Global HR Settings
>      4.5.1. Skills Types
>      4.6. HR Data model
>      4.6.1. Employee Position
>      4.6.2. Employment
>      4.6.3. Qualification, Skill, Review
>      4.6.4. HR App intra-application integration
>      4.7. Glossary



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11215) Email password is not working

2021-02-01 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276469#comment-17276469
 ] 

Michael Brohl commented on OFBIZ-11215:
---

Should we close this issue now that r17.12 has reached it's final release last 
year?

> Email password is not working
> -
>
> Key: OFBIZ-11215
> URL: https://issues.apache.org/jira/browse/OFBIZ-11215
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 16.11, 17.12.03
>Reporter: Rashi Dhagat
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01
>
>
> Steps to regenerate:
>  # User should be on the login page 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/login]
>  # Enter username
>  # Click on email password
> Actual: Email is not received.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes

2021-02-01 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-11229:
-

Assignee: (was: Michael Brohl)

> Merge UrlRegexpTransform and OfbizUrlTransform classes
> --
>
> Key: OFBIZ-11229
> URL: https://issues.apache.org/jira/browse/OFBIZ-11229
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch, 
> OfbizUrlTransform vs UrlRegexpTransform.patch
>
>
> This improvemnt follows Paul's suggestion and this discussion which contains 
> other references:
> https://markmail.org/message/bobj2uhnkzjddrtt.
> Globally can be summarised by my comment in this thread:
> bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used 
> it everywhere. Now there are maybe few features in OfbizUrlTransform that are 
> not in UrlRegexpTransform. That needs to be checked. If we can merge 
> OfbizUrlTransform in UrlRegexpTransform then the later could be used 
> everywhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11385) Possible NPE in DatabaseUtil.getColumnInfo(...)

2021-02-01 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11385.
-
Fix Version/s: 18.12.01
   Resolution: Fixed

Manually backported to 18.12. Thanks Benjamin.

> Possible NPE in DatabaseUtil.getColumnInfo(...)
> ---
>
> Key: OFBIZ-11385
> URL: https://issues.apache.org/jira/browse/OFBIZ-11385
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 18.12.01, Upcoming Branch
>
> Attachments: OFBIZ-11385_Possible_NPE_in_DatabaseUtil_001.patch
>
>
> Right at the start DatabaseUtil.getColumnInfo() does an if comparison to 
> 0 with the unchecked parameter tableNames.
> The way this method and especially the parameter is used in 
> DatabaseUtil.induceModelFromDb(Collection messages) is not secure to 
> not provide null-values for this parameter.
> I suggest using a UtilValidate.isEmpty(...) instead of the unsave comparison.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11385) Possible NPE in DatabaseUtil.getColumnInfo(...)

2021-02-01 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-11385:
--
Labels:   (was: backport-needed)

> Possible NPE in DatabaseUtil.getColumnInfo(...)
> ---
>
> Key: OFBIZ-11385
> URL: https://issues.apache.org/jira/browse/OFBIZ-11385
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11385_Possible_NPE_in_DatabaseUtil_001.patch
>
>
> Right at the start DatabaseUtil.getColumnInfo() does an if comparison to 
> 0 with the unchecked parameter tableNames.
> The way this method and especially the parameter is used in 
> DatabaseUtil.induceModelFromDb(Collection messages) is not secure to 
> not provide null-values for this parameter.
> I suggest using a UtilValidate.isEmpty(...) instead of the unsave comparison.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11385) Possible NPE in DatabaseUtil.getColumnInfo(...)

2021-02-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276455#comment-17276455
 ] 

ASF subversion and git services commented on OFBIZ-11385:
-

Commit c7f4a27f662015e2e96b68ef0697196c0565f4e0 in ofbiz-framework's branch 
refs/heads/release18.12 from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c7f4a27 ]

Fixed: Possible NPE in DatabaseUtil.getColumnInfo(...) (OFBIZ-11385)

Manually backported to 18.12 because of code differences.

> Possible NPE in DatabaseUtil.getColumnInfo(...)
> ---
>
> Key: OFBIZ-11385
> URL: https://issues.apache.org/jira/browse/OFBIZ-11385
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11385_Possible_NPE_in_DatabaseUtil_001.patch
>
>
> Right at the start DatabaseUtil.getColumnInfo() does an if comparison to 
> 0 with the unchecked parameter tableNames.
> The way this method and especially the parameter is used in 
> DatabaseUtil.induceModelFromDb(Collection messages) is not secure to 
> not provide null-values for this parameter.
> I suggest using a UtilValidate.isEmpty(...) instead of the unsave comparison.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11469) Convert DataServices.xml minilang to groovy

2021-02-01 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11469.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks Benjamin.

> Convert DataServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11469
> URL: https://issues.apache.org/jira/browse/OFBIZ-11469
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Fix For: Upcoming Branch
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350,  convert DataServices.xml



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11469) Convert DataServices.xml minilang to groovy

2021-02-01 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-11469:
-

Assignee: Michael Brohl  (was: Benjamin Jugl)

> Convert DataServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11469
> URL: https://issues.apache.org/jira/browse/OFBIZ-11469
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
>
> With the purpose to deprecate mini-lang OFBIZ-9350,  convert DataServices.xml



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11469) Convert DataServices.xml minilang to groovy

2021-02-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276431#comment-17276431
 ] 

ASF subversion and git services commented on OFBIZ-11469:
-

Commit f5788b2a81ebf37df7f9d32ba9634ccbdabc2424 in ofbiz-framework's branch 
refs/heads/trunk from Benjamin Jugl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f5788b2 ]

Improved: Converts DataServices.xml to Groovy. (OFBIZ-11469)


> Convert DataServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11469
> URL: https://issues.apache.org/jira/browse/OFBIZ-11469
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Major
>
> With the purpose to deprecate mini-lang OFBIZ-9350,  convert DataServices.xml



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] mbrohl merged pull request #259: Improved: Converts DataServices.xml to Groovy. (OFBIZ-11469)

2021-02-01 Thread GitBox


mbrohl merged pull request #259:
URL: https://github.com/apache/ofbiz-framework/pull/259


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11868) Convert EmailServices.xml mini lang to groovy

2021-02-01 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11868.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks Harut and Sebastian.

> Convert EmailServices.xml mini lang to groovy
> -
>
> Key: OFBIZ-11868
> URL: https://issues.apache.org/jira/browse/OFBIZ-11868
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Harutyun Farajyan
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11868) Convert EmailServices.xml mini lang to groovy

2021-02-01 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-11868:
-

Assignee: Michael Brohl  (was: Sebastian Berg)

> Convert EmailServices.xml mini lang to groovy
> -
>
> Key: OFBIZ-11868
> URL: https://issues.apache.org/jira/browse/OFBIZ-11868
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Harutyun Farajyan
>Assignee: Michael Brohl
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11868) Convert EmailServices.xml mini lang to groovy

2021-02-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276415#comment-17276415
 ] 

ASF subversion and git services commented on OFBIZ-11868:
-

Commit a33ac5cff38aac816b5917f49897e36ae45c7396 in ofbiz-framework's branch 
refs/heads/trunk from Sebastian Berg
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a33ac5c ]

Improved: Convert EmailServices.xml mini lang to groovy (OFBIZ-11868)


> Convert EmailServices.xml mini lang to groovy
> -
>
> Key: OFBIZ-11868
> URL: https://issues.apache.org/jira/browse/OFBIZ-11868
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Harutyun Farajyan
>Assignee: Sebastian Berg
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] mbrohl merged pull request #257: Improved: Convert EmailServices.xml mini lang to groovy (OFBIZ-11868)

2021-02-01 Thread GitBox


mbrohl merged pull request #257:
URL: https://github.com/apache/ofbiz-framework/pull/257


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] mbrohl commented on pull request #236: Improved: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047)

2021-02-01 Thread GitBox


mbrohl commented on pull request #236:
URL: https://github.com/apache/ofbiz-framework/pull/236#issuecomment-770928894


   @ingo-koenemann please provide a new PR with modified commit message "Fixed: 
..." because we have classified this as a bug now. Thank you!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #233: OFBIZ-11604 Improved: Convert ImageManagementServices.xml mini lang to groovy

2021-02-01 Thread GitBox


sonarcloud[bot] commented on pull request #233:
URL: https://github.com/apache/ofbiz-framework/pull/233#issuecomment-770925109


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=233=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=233=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=233=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=233=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=233=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=233=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=233=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=233=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=233=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=233=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=233=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=233=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=233)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=233=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=233=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #75: OFBIZ-11599 Improved: Convert CheckoutServices.xml minilang to groovy

2021-02-01 Thread GitBox


sonarcloud[bot] commented on pull request #75:
URL: https://github.com/apache/ofbiz-framework/pull/75#issuecomment-770924235


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=75=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=75=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=75=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=75=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=75=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=75=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=75=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=75=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=75=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=75=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=75=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=75=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=75)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=75=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=75=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11604) Convert ImageManagementServices.xml minilang to groovy

2021-02-01 Thread Sebastian Berg (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276392#comment-17276392
 ] 

Sebastian Berg commented on OFBIZ-11604:


I updated the PR for easier merging.

> Convert ImageManagementServices.xml minilang to groovy
> --
>
> Key: OFBIZ-11604
> URL: https://issues.apache.org/jira/browse/OFBIZ-11604
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #74: OFBIZ-11595 Improved: Convert CostService.xml minilang to groovy

2021-02-01 Thread GitBox


sonarcloud[bot] commented on pull request #74:
URL: https://github.com/apache/ofbiz-framework/pull/74#issuecomment-770920258


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=74=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=74=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=74=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=74=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=74=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=74=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=74=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=74=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=74=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=74=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=74=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=74=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=74)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=74=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=74=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-11599) Convert CheckoutServices.xml minilang to groovy

2021-02-01 Thread Sebastian Berg (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276389#comment-17276389
 ] 

Sebastian Berg commented on OFBIZ-11599:


I updated the PR for easier merging.

> Convert CheckoutServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11599
> URL: https://issues.apache.org/jira/browse/OFBIZ-11599
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11595) Convert CostServices.xml minilang to groovy

2021-02-01 Thread Sebastian Berg (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276386#comment-17276386
 ] 

Sebastian Berg commented on OFBIZ-11595:


I have updated the PR for easier merging.

> Convert CostServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11595
> URL: https://issues.apache.org/jira/browse/OFBIZ-11595
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #259: OFBIZ-11469 Improved:

2021-02-01 Thread GitBox


sonarcloud[bot] commented on pull request #259:
URL: https://github.com/apache/ofbiz-framework/pull/259#issuecomment-770849387


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=259=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=259=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=259=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=259=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=259=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=259=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=259=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=259=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=259=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=259=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=259=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=259=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=259)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=259=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=259=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] bjugl opened a new pull request #259: OFBIZ-11469 Improved:

2021-02-01 Thread GitBox


bjugl opened a new pull request #259:
URL: https://github.com/apache/ofbiz-framework/pull/259


   Improved: Converts DataServices.xml to Groovy. 
   
   (OFBIZ-11469)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] bjugl closed pull request #255: Improved: Converts DataServices.xml minilang to groovy (OFBIZ-11469)

2021-02-01 Thread GitBox


bjugl closed pull request #255:
URL: https://github.com/apache/ofbiz-framework/pull/255


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12101) partymgr fails to upload image

2021-02-01 Thread Wai (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276237#comment-17276237
 ] 

Wai commented on OFBIZ-12101:
-

The setting for http.upload.max.size=-1 at the time this issue was found.

> partymgr fails to upload image
> --
>
> Key: OFBIZ-12101
> URL: https://issues.apache.org/jira/browse/OFBIZ-12101
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
> Environment: OS: Ubuntu 20.04
> $ java -version
> java version "1.8.0_271"
> Java(TM) SE Runtime Environment (build 1.8.0_271-b09)
> Java HotSpot(TM) 64-Bit Server VM (build 25.271-b09, mixed mode)
>Reporter: Wai
>Assignee: Ankit Joshi
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
> Attachments: v.jpeg
>
>
> partymgr fails to upload image
>  
> Steps to reproduce issue:
> open https://localhost:8443/partymgr/control/viewprofile?partyId=admin
> in Party Content panel
>  select image to upload
>  select "Logo Image URL"
> click ok
> console output:
> 2020-12-25 16:24:06,533 |sse-nio-18443-exec-4 |UtilHttp |E| File upload 
> errororg.apache.commons.fileupload.FileUploadBase$IOFileUploadException: 
> Processing of multipart/form-data request failed. java.io.EOFException
> 2020-12-25 16:24:06,573 |sse-nio-18443-exec-4 |ModelService |I| Set default 
> value [DOCUMENT] for parameter [contentTypeId]
> 2020-12-25 16:24:06,661 |sse-nio-18443-exec-4 |UtilProperties |I| 
> ResourceBundle ServiceErrorUiLabels (en) created in 0.087s with 40 properties
> 2020-12-25 16:24:06,662 |sse-nio-18443-exec-4 |ModelService |E| 
> [ModelService.validate] : \{uploadPartyContentFile} : (IN) Required test 
> error: org.apache.ofbiz.service.ServiceValidationException: The following 
> required parameter is missing: [IN] 
> [uploadPartyContentFile.partyContentTypeId]
> 2020-12-25 16:24:06,662 |sse-nio-18443-exec-4 |ServiceDispatcher |E| Incoming 
> context (in runSync : uploadPartyContentFile) does not match expected 
> requirements
> org.apache.ofbiz.service.ServiceValidationException: The following required 
> parameter is missing: [IN] [uploadPartyContentFile.partyContentTypeId]
>  at org.apache.ofbiz.service.ModelService.validate(ModelService.java:1305) 
> ~[main/:?]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12101) partymgr fails to upload image

2021-02-01 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276186#comment-17276186
 ] 

Jacques Le Roux commented on OFBIZ-12101:
-

Hi Wai,

It should not be related to the size of image. I fixed that with OFBIZ-11534. 
It's now possible to load files at least as heavy as 2,5 GB.
Note that, for security reason, with OFBIZ-12080 I changed how files are 
uploaded. The size is OOTB illimited (http.upload.max.size properties in 
general.properties).

I'll have a look when I'll get a chance, any help is apprectiated...

> partymgr fails to upload image
> --
>
> Key: OFBIZ-12101
> URL: https://issues.apache.org/jira/browse/OFBIZ-12101
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
> Environment: OS: Ubuntu 20.04
> $ java -version
> java version "1.8.0_271"
> Java(TM) SE Runtime Environment (build 1.8.0_271-b09)
> Java HotSpot(TM) 64-Bit Server VM (build 25.271-b09, mixed mode)
>Reporter: Wai
>Assignee: Ankit Joshi
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
> Attachments: v.jpeg
>
>
> partymgr fails to upload image
>  
> Steps to reproduce issue:
> open https://localhost:8443/partymgr/control/viewprofile?partyId=admin
> in Party Content panel
>  select image to upload
>  select "Logo Image URL"
> click ok
> console output:
> 2020-12-25 16:24:06,533 |sse-nio-18443-exec-4 |UtilHttp |E| File upload 
> errororg.apache.commons.fileupload.FileUploadBase$IOFileUploadException: 
> Processing of multipart/form-data request failed. java.io.EOFException
> 2020-12-25 16:24:06,573 |sse-nio-18443-exec-4 |ModelService |I| Set default 
> value [DOCUMENT] for parameter [contentTypeId]
> 2020-12-25 16:24:06,661 |sse-nio-18443-exec-4 |UtilProperties |I| 
> ResourceBundle ServiceErrorUiLabels (en) created in 0.087s with 40 properties
> 2020-12-25 16:24:06,662 |sse-nio-18443-exec-4 |ModelService |E| 
> [ModelService.validate] : \{uploadPartyContentFile} : (IN) Required test 
> error: org.apache.ofbiz.service.ServiceValidationException: The following 
> required parameter is missing: [IN] 
> [uploadPartyContentFile.partyContentTypeId]
> 2020-12-25 16:24:06,662 |sse-nio-18443-exec-4 |ServiceDispatcher |E| Incoming 
> context (in runSync : uploadPartyContentFile) does not match expected 
> requirements
> org.apache.ofbiz.service.ServiceValidationException: The following required 
> parameter is missing: [IN] [uploadPartyContentFile.partyContentTypeId]
>  at org.apache.ofbiz.service.ModelService.validate(ModelService.java:1305) 
> ~[main/:?]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)