[GitHub] [ofbiz-framework] james-yong commented on pull request #266: Improved: Display last-visited-time popup after login (OFBIZ-12148)
james-yong commented on pull request #266: URL: https://github.com/apache/ofbiz-framework/pull/266#issuecomment-774561622 Hi @mbrohl , Thanks for approval. Need your help to merge this pull request as I have no write access. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12170) All Links Redirect to An IP Address
[ https://issues.apache.org/jira/browse/OFBIZ-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280306#comment-17280306 ] Christen Erika Johnson commented on OFBIZ-12170: Maybe I should explain it differently. Everytime it has to touch fetch data that isn;t initially loaded, it redirects to the localhost ip address. But like I said, this is a cloud server and the ip address technically doesn't route straight to my server. Where can I change the URI split? So instead of using that ip, it will use the virtual ip? > All Links Redirect to An IP Address > --- > > Key: OFBIZ-12170 > URL: https://issues.apache.org/jira/browse/OFBIZ-12170 > Project: OFBiz > Issue Type: Task >Affects Versions: 17.12.05 > Environment: CentOS 8 >Reporter: Christen Erika Johnson >Priority: Major > > I have OFBiz set up with a valid URL and it seems as though everything loads > fine. I have my security.properties file correct, my url.properties file is > correct and my start.properties files seem correct. When I click on any link > or the login button I get redirected to an IP address. If I type in the > valid domain and port with the full address, the page will load but it > doesn't send correctly when trying to login, or clicking any links. I tried > adding a redirect to my httpd virtual host and a URL rewrite but neither > worked. What is the issue and how do I fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12170) All Links Redirect to An IP Address
[ https://issues.apache.org/jira/browse/OFBIZ-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280282#comment-17280282 ] Christen Erika Johnson commented on OFBIZ-12170: I looked at the git patches and I am still having the same problem. Everything loads and I know its working because ecommerce shows up like the demo store. I can view the items but if I go to add them to my cart or click on any of the links in the menu bar, it redirects to an ip address. There is no error page just a grey screen. > All Links Redirect to An IP Address > --- > > Key: OFBIZ-12170 > URL: https://issues.apache.org/jira/browse/OFBIZ-12170 > Project: OFBiz > Issue Type: Task >Affects Versions: 17.12.05 > Environment: CentOS 8 >Reporter: Christen Erika Johnson >Priority: Major > > I have OFBiz set up with a valid URL and it seems as though everything loads > fine. I have my security.properties file correct, my url.properties file is > correct and my start.properties files seem correct. When I click on any link > or the login button I get redirected to an IP address. If I type in the > valid domain and port with the full address, the page will load but it > doesn't send correctly when trying to login, or clicking any links. I tried > adding a redirect to my httpd virtual host and a URL rewrite but neither > worked. What is the issue and how do I fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12170) All Links Redirect to An IP Address
[ https://issues.apache.org/jira/browse/OFBIZ-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280263#comment-17280263 ] Jacques Le Roux commented on OFBIZ-12170: - I'm not sure about what you call "host url to my domain name" in start.properties, but I see no reasons to change anything there. The only needed changes for our 3 demos are at https://github.com/apache/ofbiz-tools/tree/master/demo-backup/ I suggest you have a look at the stable demo version: https://github.com/apache/ofbiz-tools/tree/master/demo-backup/patch/stable. Also, it's certainly different from yours, because we host 3 demos and big-files is the root of them, but looking at https://github.com/apache/ofbiz-tools/tree/master/demo-backup/site-enabled3 should not hurt. > All Links Redirect to An IP Address > --- > > Key: OFBIZ-12170 > URL: https://issues.apache.org/jira/browse/OFBIZ-12170 > Project: OFBiz > Issue Type: Task >Affects Versions: 17.12.05 > Environment: CentOS 8 >Reporter: Christen Erika Johnson >Priority: Major > > I have OFBiz set up with a valid URL and it seems as though everything loads > fine. I have my security.properties file correct, my url.properties file is > correct and my start.properties files seem correct. When I click on any link > or the login button I get redirected to an IP address. If I type in the > valid domain and port with the full address, the page will load but it > doesn't send correctly when trying to login, or clicking any links. I tried > adding a redirect to my httpd virtual host and a URL rewrite but neither > worked. What is the issue and how do I fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12170) All Links Redirect to An IP Address
[ https://issues.apache.org/jira/browse/OFBIZ-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280254#comment-17280254 ] Christen Erika Johnson commented on OFBIZ-12170: I am running a CentOS 8 cloud server with Apache httpd. There was not an existing tomcat server prior to installing OFBiz but there were some other virtual hosts. In my Apache conf file I have ofbiz set up on 80/8080 and 443/8443 to the domain name but the file only listens on 80/443. In my start.properties file I changed the host url to my domain name from the default 127.0.0.1. (I didn’t change the start.properties file in build folder, only the other one) And set the ports to force 8080 and 8443. In my security.properties I changed host-headers-allowed to only my domain name. I installed firewalld and audit. My firewall is set up for public on 8080/8443 and I am using Derby. I have mod_md installed, mod_ssl, mod_session and I am not using a proxy. > All Links Redirect to An IP Address > --- > > Key: OFBIZ-12170 > URL: https://issues.apache.org/jira/browse/OFBIZ-12170 > Project: OFBiz > Issue Type: Task >Affects Versions: 17.12.05 > Environment: CentOS 8 >Reporter: Christen Erika Johnson >Priority: Major > > I have OFBiz set up with a valid URL and it seems as though everything loads > fine. I have my security.properties file correct, my url.properties file is > correct and my start.properties files seem correct. When I click on any link > or the login button I get redirected to an IP address. If I type in the > valid domain and port with the full address, the page will load but it > doesn't send correctly when trying to login, or clicking any links. I tried > adding a redirect to my httpd virtual host and a URL rewrite but neither > worked. What is the issue and how do I fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12170) All Links Redirect to An IP Address
[ https://issues.apache.org/jira/browse/OFBIZ-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280251#comment-17280251 ] Michael Brohl commented on OFBIZ-12170: --- We will need to know more of your setup. Any Webserver before OFBIz/Tomcat? Any SystemProperty data configurations which might overwrite the properties? Some WebSite data configured to the IP? ...? > All Links Redirect to An IP Address > --- > > Key: OFBIZ-12170 > URL: https://issues.apache.org/jira/browse/OFBIZ-12170 > Project: OFBiz > Issue Type: Task >Affects Versions: 17.12.05 > Environment: CentOS 8 >Reporter: Christen Erika Johnson >Priority: Major > > I have OFBiz set up with a valid URL and it seems as though everything loads > fine. I have my security.properties file correct, my url.properties file is > correct and my start.properties files seem correct. When I click on any link > or the login button I get redirected to an IP address. If I type in the > valid domain and port with the full address, the page will load but it > doesn't send correctly when trying to login, or clicking any links. I tried > adding a redirect to my httpd virtual host and a URL rewrite but neither > worked. What is the issue and how do I fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12170) All Links Redirect to An IP Address
[ https://issues.apache.org/jira/browse/OFBIZ-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280249#comment-17280249 ] Christen Erika Johnson commented on OFBIZ-12170: Hello!!! It could be the actual server ip but it's not an ip that I can use. At least I don't think I can use it. How do I simply stop it from requesting that ip and instead use the domain name that I've set up? I won't be able to post my actual properties files but I can tell you the changes that I made. > All Links Redirect to An IP Address > --- > > Key: OFBIZ-12170 > URL: https://issues.apache.org/jira/browse/OFBIZ-12170 > Project: OFBiz > Issue Type: Task >Affects Versions: 17.12.05 > Environment: CentOS 8 >Reporter: Christen Erika Johnson >Priority: Major > > I have OFBiz set up with a valid URL and it seems as though everything loads > fine. I have my security.properties file correct, my url.properties file is > correct and my start.properties files seem correct. When I click on any link > or the login button I get redirected to an IP address. If I type in the > valid domain and port with the full address, the page will load but it > doesn't send correctly when trying to login, or clicking any links. I tried > adding a redirect to my httpd virtual host and a URL rewrite but neither > worked. What is the issue and how do I fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] james-yong commented on a change in pull request #266: Improved: Display last-visited-time popup after login (OFBIZ-12148)
james-yong commented on a change in pull request #266:
URL: https://github.com/apache/ofbiz-framework/pull/266#discussion_r571442746
##
File path:
framework/webapp/src/main/java/org/apache/ofbiz/webapp/AfterLoginEvents.java
##
@@ -0,0 +1,93 @@
+/***
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+
***/
+package org.apache.ofbiz.webapp;
+
+import org.apache.ofbiz.base.util.Debug;
+import org.apache.ofbiz.base.util.UtilHttp;
+import org.apache.ofbiz.common.JsLanguageFilesMappingUtil;
+import org.apache.ofbiz.entity.Delegator;
+import org.apache.ofbiz.entity.GenericEntityException;
+import org.apache.ofbiz.entity.GenericValue;
+import org.apache.ofbiz.entity.util.EntityListIterator;
+import org.apache.ofbiz.entity.util.EntityQuery;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.HttpSession;
+import java.sql.Timestamp;
+import java.text.SimpleDateFormat;
+import java.util.Locale;
+
+public class AfterLoginEvents {
+
+private static final String MODULE = AfterLoginEvents.class.getName();
+private static final String SCRIPT_SHOW_LAST_VISIT_DATE;
+
+static {
+SCRIPT_SHOW_LAST_VISIT_DATE = ""
++ "importLibrary(%s, function () {\n"
++ "var dateFormat = Date.CultureInfo.formatPatterns.shortDate
+ ' ' + Date.CultureInfo.formatPatterns.longTime;\n"
++ "var message = 'Your last visit was on '+new
Date('%s').toString(dateFormat);\n"
++ "$('#showLastLogin').replaceWith(message);\n"
++ "});\n";
+}
+
+public static String showLastVisit(HttpServletRequest request,
HttpServletResponse response) {
+
+// guard against re-popup while moving to other web application when
tomcat SSO is enabled
Review comment:
Added "afterlogin.lastvisit.show" in security.properties
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [ofbiz-framework] james-yong commented on a change in pull request #266: Improved: Display last-visited-time popup after login (OFBIZ-12148)
james-yong commented on a change in pull request #266:
URL: https://github.com/apache/ofbiz-framework/pull/266#discussion_r571442509
##
File path:
framework/webapp/src/main/java/org/apache/ofbiz/webapp/AfterLoginEvents.java
##
@@ -0,0 +1,93 @@
+/***
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+
***/
+package org.apache.ofbiz.webapp;
+
+import org.apache.ofbiz.base.util.Debug;
+import org.apache.ofbiz.base.util.UtilHttp;
+import org.apache.ofbiz.common.JsLanguageFilesMappingUtil;
+import org.apache.ofbiz.entity.Delegator;
+import org.apache.ofbiz.entity.GenericEntityException;
+import org.apache.ofbiz.entity.GenericValue;
+import org.apache.ofbiz.entity.util.EntityListIterator;
+import org.apache.ofbiz.entity.util.EntityQuery;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.HttpSession;
+import java.sql.Timestamp;
+import java.text.SimpleDateFormat;
+import java.util.Locale;
+
+public class AfterLoginEvents {
+
+private static final String MODULE = AfterLoginEvents.class.getName();
+private static final String SCRIPT_SHOW_LAST_VISIT_DATE;
+
+static {
+SCRIPT_SHOW_LAST_VISIT_DATE = ""
++ "importLibrary(%s, function () {\n"
++ "var dateFormat = Date.CultureInfo.formatPatterns.shortDate
+ ' ' + Date.CultureInfo.formatPatterns.longTime;\n"
++ "var message = 'Your last visit was on '+new
Date('%s').toString(dateFormat);\n"
++ "$('#showLastLogin').replaceWith(message);\n"
++ "});\n";
+}
+
+public static String showLastVisit(HttpServletRequest request,
HttpServletResponse response) {
+
+// guard against re-popup while moving to other web application when
tomcat SSO is enabled
+if (!"login".equals(request.getAttribute("thisRequestUri"))) {
+return "success";
+}
+
+HttpSession session = request.getSession();
+Delegator delegator = (Delegator) request.getAttribute("delegator");
+GenericValue userLogin = (GenericValue)
session.getAttribute("userLogin");
+
+String userLoginId = (String) userLogin.get("userLoginId");
+
+try (EntityListIterator eli = EntityQuery.use(delegator)
+.from("Visit")
+.where("userLoginId", userLoginId)
+.orderBy("-fromDate")
+.cursorScrollInsensitive()
+.maxRows(2)
+.queryIterator()) {
+if (eli != null) {
+GenericValue visit = null;
+int count = 0;
+while ((visit = eli.next()) != null) {
+if (count == 1) {
+Timestamp fromDate = visit.getTimestamp("fromDate");
+Locale locale = UtilHttp.getLocale(request);
+String libJs = "['" +
JsLanguageFilesMappingUtil.getFile("datejs", locale.toString()) + "']";
+SimpleDateFormat formatter = new SimpleDateFormat("EE
MMM d y H:m:s ZZZ");
+String dateString = formatter.format(fromDate);
+request.setAttribute("_UNSAFE_EVENT_MESSAGE_",
String.format(SCRIPT_SHOW_LAST_VISIT_DATE, libJs, dateString));
+}
+count++;
+}
+}
+} catch (GenericEntityException e) {
+Debug.logError(e, MODULE);
+request.setAttribute("_ERROR_MESSAGE_", e.getMessage());
Review comment:
Removed the following:
request.setAttribute("_ERROR_MESSAGE_", e.getMessage());
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [ofbiz-framework] james-yong commented on a change in pull request #266: Improved: Display last-visited-time popup after login (OFBIZ-12148)
james-yong commented on a change in pull request #266:
URL: https://github.com/apache/ofbiz-framework/pull/266#discussion_r571442383
##
File path:
framework/webapp/src/main/java/org/apache/ofbiz/webapp/AfterLoginEvents.java
##
@@ -0,0 +1,93 @@
+/***
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+
***/
+package org.apache.ofbiz.webapp;
+
+import org.apache.ofbiz.base.util.Debug;
+import org.apache.ofbiz.base.util.UtilHttp;
+import org.apache.ofbiz.common.JsLanguageFilesMappingUtil;
+import org.apache.ofbiz.entity.Delegator;
+import org.apache.ofbiz.entity.GenericEntityException;
+import org.apache.ofbiz.entity.GenericValue;
+import org.apache.ofbiz.entity.util.EntityListIterator;
+import org.apache.ofbiz.entity.util.EntityQuery;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import javax.servlet.http.HttpSession;
+import java.sql.Timestamp;
+import java.text.SimpleDateFormat;
+import java.util.Locale;
+
+public class AfterLoginEvents {
+
+private static final String MODULE = AfterLoginEvents.class.getName();
+private static final String SCRIPT_SHOW_LAST_VISIT_DATE;
+
+static {
+SCRIPT_SHOW_LAST_VISIT_DATE =
[jira] [Commented] (OFBIZ-12148) Display last-visited-time popup after login
[ https://issues.apache.org/jira/browse/OFBIZ-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280206#comment-17280206 ] James Yong commented on OFBIZ-12148: Hi Michael, Thanks for the review. Agree with the points made. I have amended with another commit. > Display last-visited-time popup after login > --- > > Key: OFBIZ-12148 > URL: https://issues.apache.org/jira/browse/OFBIZ-12148 > Project: OFBiz > Issue Type: Improvement > Components: base >Affects Versions: Upcoming Branch >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-12148, OFBIZ-12148.patch > > > Popup last-visited time from database after user has logged in. > So users can know of any unauthorised access to their accounts. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #266: Improved: Display last-visited-time popup after login (OFBIZ-12148)
sonarcloud[bot] removed a comment on pull request #266: URL: https://github.com/apache/ofbiz-framework/pull/266#issuecomment-774050121 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=266=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=266=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=266=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=266) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=266=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #266: Improved: Display last-visited-time popup after login (OFBIZ-12148)
sonarcloud[bot] commented on pull request #266: URL: https://github.com/apache/ofbiz-framework/pull/266#issuecomment-774482558 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=266=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=266=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=266=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=266=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=266) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=266=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown
[ https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280192#comment-17280192 ] Jacques Le Roux commented on OFBIZ-12171: - That's quite a good news, thanks Michael > Handling the JCenter shutdown > - > > Key: OFBIZ-12171 > URL: https://issues.apache.org/jira/browse/OFBIZ-12171 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Michael Brohl >Priority: Major > > Citing Taher's message at [2]: > Hello Everyone, > > I received emails and checked resources [1] that seem to confirm JCenter from > JFrog is going down and that the last day of operation for the repository is > going to be May 1st 2021. > > This is a big deal as many running instances will crash unless updated, so > not only do future versions of OFBiz need to adapt, but also existing > installations. > > I'm not sure how to best handle this? Especially for production instances out > there on older versions of OFBiz. Maybe one solution is to host the existing > libraries in some temporary location or try to migrate them to MavenCentral > ... Whatever is the solution I think we should make a fast move. > > [1] > [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter] > > [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure] > [2] > [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown
[
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280155#comment-17280155
]
Michael Brohl commented on OFBIZ-12171:
---
Using maven central with configured url to https://repo1.maven.org/maven2 the
number of errors is drastically reduced to about 7 problems:
{noformat}
> Could not resolve all files for configuration ':runtimeClasspath'.
> Could not find
com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
Searched in the following locations:
-
https://repo1.maven.org/maven2/com/sun/syndication/com.springsource.com.sun.syndication/1.0.0/com.springsource.com.sun.syndication-1.0.0.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find net.fortuna.ical4j:ical4j:1.0-rc3-atlassian-11.
Searched in the following locations:
-
https://repo1.maven.org/maven2/net/fortuna/ical4j/ical4j/1.0-rc3-atlassian-11/ical4j-1.0-rc3-atlassian-11.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find org.opensaml:opensaml:1.1b.
Searched in the following locations:
-
https://repo1.maven.org/maven2/org/opensaml/opensaml/1.1b/opensaml-1.1b.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project : > project :plugins:ldap > org.jasig.cas:cas-server-core:3.3.5
> Could not find org.inspektr:inspektr-core:0.7.0.
Searched in the following locations:
-
https://repo1.maven.org/maven2/org/inspektr/inspektr-core/0.7.0/inspektr-core-0.7.0.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project : > project :plugins:ldap > org.jasig.cas:cas-server-core:3.3.5
> Could not find org.restlet.jee:org.restlet:2.4.0.
Searched in the following locations:
-
https://repo1.maven.org/maven2/org/restlet/jee/org.restlet/2.4.0/org.restlet-2.4.0.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project : > project :plugins:solr > org.apache.solr:solr-core:8.5.2
> Could not find org.restlet.jee:org.restlet.ext.servlet:2.4.0.
Searched in the following locations:
-
https://repo1.maven.org/maven2/org/restlet/jee/org.restlet.ext.servlet/2.4.0/org.restlet.ext.servlet-2.4.0.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project : > project :plugins:solr > org.apache.solr:solr-core:8.5.2
> Could not resolve org.milyn:flute:1.3.
Required by:
project : > project :plugins:birt >
org.eclipse.birt.runtime:viewservlets:4.5.0 >
org.eclipse.birt.runtime:org.eclipse.birt.runtime:4.4.1
> Could not resolve org.milyn:flute:1.3.
> inconsistent module metadata found. Descriptor: milyn:flute:1.3
Errors: bad group: expected='org.milyn' found='milyn'{noformat}
> Handling the JCenter shutdown
> -
>
> Key: OFBIZ-12171
> URL: https://issues.apache.org/jira/browse/OFBIZ-12171
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
>Reporter: Michael Brohl
>Priority: Major
>
> Citing Taher's message at [2]:
> Hello Everyone,
>
> I received emails and checked resources [1] that seem to confirm JCenter from
> JFrog is going down and that the last day of operation for the repository is
> going to be May 1st 2021.
>
> This is a big deal as many running instances will crash unless updated, so
> not only do future versions of OFBiz need to adapt, but also existing
> installations.
>
> I'm not sure how to best handle this? Especially for production instances out
> there on older versions of OFBiz. Maybe one solution is to host the existing
> libraries in some temporary location or try to migrate them to MavenCentral
> ... Whatever is the solution I think we
[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown
[ https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280151#comment-17280151 ] Michael Brohl commented on OFBIZ-12171: --- I'm sure the above list of errors can be reduced by configuration. I quick checked some of them and their artifacts are on maven central as well. Checking... > Handling the JCenter shutdown > - > > Key: OFBIZ-12171 > URL: https://issues.apache.org/jira/browse/OFBIZ-12171 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Michael Brohl >Priority: Major > > Citing Taher's message at [2]: > Hello Everyone, > > I received emails and checked resources [1] that seem to confirm JCenter from > JFrog is going down and that the last day of operation for the repository is > going to be May 1st 2021. > > This is a big deal as many running instances will crash unless updated, so > not only do future versions of OFBiz need to adapt, but also existing > installations. > > I'm not sure how to best handle this? Especially for production instances out > there on older versions of OFBiz. Maybe one solution is to host the existing > libraries in some temporary location or try to migrate them to MavenCentral > ... Whatever is the solution I think we should make a fast move. > > [1] > [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter] > > [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure] > [2] > [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12169) Handle remaining checkstyle errors
[ https://issues.apache.org/jira/browse/OFBIZ-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280149#comment-17280149 ] Michael Brohl commented on OFBIZ-12169: --- My proposal would be to leave worker classes and other classes which reasonably could be extended in custom projetcs as is and only change other classes like inner classes to be final. We can make them final anytime later if we decide so. Still better as today. I am currently at it so I would provide a commit with this approach. Happy to get more opinions also. > Handle remaining checkstyle errors > -- > > Key: OFBIZ-12169 > URL: https://issues.apache.org/jira/browse/OFBIZ-12169 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > There are still a ggod amount of checkstyle errors which should be addressed. > We will work on it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown
[ https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280148#comment-17280148 ] Michael Brohl commented on OFBIZ-12171: --- Infra is also at it, see https://issues.apache.org/jira/browse/INFRA-21376 > Handling the JCenter shutdown > - > > Key: OFBIZ-12171 > URL: https://issues.apache.org/jira/browse/OFBIZ-12171 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Michael Brohl >Priority: Major > > Citing Taher's message at [2]: > Hello Everyone, > > I received emails and checked resources [1] that seem to confirm JCenter from > JFrog is going down and that the last day of operation for the repository is > going to be May 1st 2021. > > This is a big deal as many running instances will crash unless updated, so > not only do future versions of OFBiz need to adapt, but also existing > installations. > > I'm not sure how to best handle this? Especially for production instances out > there on older versions of OFBiz. Maybe one solution is to host the existing > libraries in some temporary location or try to migrate them to MavenCentral > ... Whatever is the solution I think we should make a fast move. > > [1] > [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter] > > [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure] > [2] > [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12169) Handle remaining checkstyle errors
[ https://issues.apache.org/jira/browse/OFBIZ-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280147#comment-17280147 ] Jacques Le Roux commented on OFBIZ-12169: - Hi Michael, With 59 cases it seems reasonnable to me to check before taking a such decision. > Handle remaining checkstyle errors > -- > > Key: OFBIZ-12169 > URL: https://issues.apache.org/jira/browse/OFBIZ-12169 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > There are still a ggod amount of checkstyle errors which should be addressed. > We will work on it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12170) All Links Redirect to An IP Address
[ https://issues.apache.org/jira/browse/OFBIZ-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280146#comment-17280146 ] Jacques Le Roux commented on OFBIZ-12170: - Hi Christen Erika, What is this IP address? Related to a domain of yours? If it's not an issue for you, it would be good that you upload here the content of your modified properties files... > All Links Redirect to An IP Address > --- > > Key: OFBIZ-12170 > URL: https://issues.apache.org/jira/browse/OFBIZ-12170 > Project: OFBiz > Issue Type: Task >Affects Versions: 17.12.05 > Environment: CentOS 8 >Reporter: Christen Erika Johnson >Priority: Major > > I have OFBiz set up with a valid URL and it seems as though everything loads > fine. I have my security.properties file correct, my url.properties file is > correct and my start.properties files seem correct. When I click on any link > or the login button I get redirected to an IP address. If I type in the > valid domain and port with the full address, the page will load but it > doesn't send correctly when trying to login, or clicking any links. I tried > adding a redirect to my httpd virtual host and a URL rewrite but neither > worked. What is the issue and how do I fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12171) Handling the JCenter shutdown
[
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280143#comment-17280143
]
Michael Brohl edited comment on OFBIZ-12171 at 2/6/21, 10:26 AM:
-
I did a build with wiped Gradle cache and removed JCenter repositoty
configuration in build.gradle and got the following errors:
{noformat}
1: Task failed with an exception.
---
* Where:
Build file '/Users/mbrohl/Projects/ecomify/ofbiz-framework/build.gradle' line:
1096* What went wrong:
A problem occurred evaluating root project 'ofbiz'.
> Could not resolve all files for configuration ':runtimeClasspath'.
> Could not find xerces:xercesImpl:2.12.0.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/xerces/xercesImpl/2.12.0/xercesImpl-2.12.0.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find com.google.zxing:core:3.4.1.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/google/zxing/core/3.4.1/core-3.4.1.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find
com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/googlecode/concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/concurrentlinkedhashmap-lru-1.4.2.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find com.googlecode.ez-vcard:ez-vcard:0.9.10.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/googlecode/ez-vcard/ez-vcard/0.9.10/ez-vcard-0.9.10.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find
com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:20200713.1.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/googlecode/owasp-java-html-sanitizer/owasp-java-html-sanitizer/20200713.1/owasp-java-html-sanitizer-20200713.1.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find com.googlecode.libphonenumber:libphonenumber:8.12.15.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/googlecode/libphonenumber/libphonenumber/8.12.15/libphonenumber-8.12.15.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find com.ibm.icu:icu4j:68.1.
Searched in the following locations:
- file:/Users/mbrohl/.m2/repository/com/ibm/icu/icu4j/68.1/icu4j-68.1.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find com.lowagie:itext:2.1.7.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/lowagie/itext/2.1.7/itext-2.1.7.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find com.sun.mail:javax.mail:1.6.2.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/sun/mail/javax.mail/1.6.2/javax.mail-1.6.2.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find
com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
Searched in the following locations:
-
[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown
[
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280143#comment-17280143
]
Michael Brohl commented on OFBIZ-12171:
---
I did a build with wiped Gradle cache and removed JCenter repositoty
configuration in build.gradle and got the following errors:
{noformat}
1: Task failed with an exception.
---
* Where:
Build file '/Users/mbrohl/Projects/ecomify/ofbiz-framework/build.gradle' line:
1096* What went wrong:
A problem occurred evaluating root project 'ofbiz'.
> Could not resolve all files for configuration ':runtimeClasspath'.
> Could not find xerces:xercesImpl:2.12.0.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/xerces/xercesImpl/2.12.0/xercesImpl-2.12.0.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find com.google.zxing:core:3.4.1.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/google/zxing/core/3.4.1/core-3.4.1.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find
com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/googlecode/concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/concurrentlinkedhashmap-lru-1.4.2.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find com.googlecode.ez-vcard:ez-vcard:0.9.10.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/googlecode/ez-vcard/ez-vcard/0.9.10/ez-vcard-0.9.10.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find
com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:20200713.1.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/googlecode/owasp-java-html-sanitizer/owasp-java-html-sanitizer/20200713.1/owasp-java-html-sanitizer-20200713.1.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find com.googlecode.libphonenumber:libphonenumber:8.12.15.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/googlecode/libphonenumber/libphonenumber/8.12.15/libphonenumber-8.12.15.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find com.ibm.icu:icu4j:68.1.
Searched in the following locations:
- file:/Users/mbrohl/.m2/repository/com/ibm/icu/icu4j/68.1/icu4j-68.1.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find com.lowagie:itext:2.1.7.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/lowagie/itext/2.1.7/itext-2.1.7.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find com.sun.mail:javax.mail:1.6.2.
Searched in the following locations:
-
file:/Users/mbrohl/.m2/repository/com/sun/mail/javax.mail/1.6.2/javax.mail-1.6.2.pom
If the artifact you are trying to retrieve can be found in the repository
but without metadata in 'Maven POM' format, you need to adjust the
'metadataSources { ... }' of the repository declaration.
Required by:
project :
> Could not find
com.sun.syndication:com.springsource.com.sun.syndication:1.0.0.
Searched in the following locations:
-
[jira] [Created] (OFBIZ-12171) Handling the JCenter shutdown
Michael Brohl created OFBIZ-12171: - Summary: Handling the JCenter shutdown Key: OFBIZ-12171 URL: https://issues.apache.org/jira/browse/OFBIZ-12171 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS Affects Versions: 17.12.05, Trunk, Release Branch 18.12 Reporter: Michael Brohl Citing Taher's message at [2]: Hello Everyone, I received emails and checked resources [1] that seem to confirm JCenter from JFrog is going down and that the last day of operation for the repository is going to be May 1st 2021. This is a big deal as many running instances will crash unless updated, so not only do future versions of OFBiz need to adapt, but also existing installations. I'm not sure how to best handle this? Especially for production instances out there on older versions of OFBiz. Maybe one solution is to host the existing libraries in some temporary location or try to migrate them to MavenCentral ... Whatever is the solution I think we should make a fast move. [1] [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter] [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure] [2] [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E] -- This message was sent by Atlassian Jira (v8.3.4#803005)
