[jira] [Comment Edited] (OFBIZ-10746) Error while uploading file in Ecommerce Profile's File Manager

2021-02-20 Thread Priya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287855#comment-17287855
 ] 

Priya Sharma edited comment on OFBIZ-10746 at 2/21/21, 7:04 AM:


Hi guys, sorry for the delay, but here are my findings

UtilHttp method getParameterMap is responsible for fetching and populating the 
multiPartMap form fields on the request map, as per the following code block
{code:java}
Map multiPartMap = params.isEmpty() ? 
getMultiPartParameterMap(req) : Collections.emptyMap();
params.putAll(multiPartMap);
req.setAttribute("multiPartMap", multiPartMap);
{code}
so it happens to be that once the params map has got values, the multiPartMap 
is initialized with an empty map and set on the request.

Thus it is no longer available to the target service after the 
"getParameterMap" is invoked multiple times before the service is executed.

I replaced this code with the following on my local machine and it worked to 
suffix the findings above.
{code:java}
Map multiPartMap = params.isEmpty() ? 
getMultiPartParameterMap(req) : Collections.emptyMap();
params.putAll(multiPartMap);
if (req.getAttribute("multiPartMap") == null) {
req.setAttribute("multiPartMap", multiPartMap);
}
{code}
[~jleroux], could you please suggest if there is a better way to handle this, 
or any other problems that might be induced due to this change.


was (Author: priya.sharma.9362):
Hi guys, sorry for the delay, but here are my findings

UtilHttp method getParameterMap is responsible for fetching and populating the 
multiPartMap form fields on the request map, as per the following code block
{code:java}
Map multiPartMap = params.isEmpty() ? 
getMultiPartParameterMap(req) : Collections.emptyMap();
params.putAll(multiPartMap);
req.setAttribute("multiPartMap", multiPartMap);
{code}
so it happens to be that once the params map has got values, the multiPartMap 
is initialized with an empty map and set on the request.

Thus it is no longer available to the target service after the 
"getParameterMap" is invoked multiple times before the service is executed.

I replaced this code with the following on my local machine and it worked to 
suffix the findings above.
{code:java}
Map multiPartMap = params.isEmpty() ? 
getMultiPartParameterMap(req) : Collections.emptyMap();
params.putAll(multiPartMap);
if (!multiPartMap.isEmpty()) {
req.setAttribute("multiPartMap", multiPartMap);
}
{code}

[~jleroux], could you please suggest if there is a better way to handle this, 
or any other problems that might be induced due to this change.

> Error while uploading file in Ecommerce Profile's File Manager 
> ---
>
> Key: OFBIZ-10746
> URL: https://issues.apache.org/jira/browse/OFBIZ-10746
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Aishwary Shrivastava
>Assignee: Priya Sharma
>Priority: Major
> Attachments: ErroUploadingFileOnFileManagerEcommerce.png
>
>
> On uploading File in Ecommerce Profile's File Manager,
> "The following required parameter is missing: [IN] 
> [uploadPartyContentFile.partyContentTypeId]" error is displaying.
>  
> Steps to regenerate the issue:
>  # Open Ecommerce on Ofbiz.
>  # Login with any user.
>  # Go to Profile.
>  # Navigate down to File Manager.
>  # Select Purpose.
>  # Seletct Mime Type
>  # Click upload.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10746) Error while uploading file in Ecommerce Profile's File Manager

2021-02-20 Thread Priya Sharma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287855#comment-17287855
 ] 

Priya Sharma commented on OFBIZ-10746:
--

Hi guys, sorry for the delay, but here are my findings

UtilHttp method getParameterMap is responsible for fetching and populating the 
multiPartMap form fields on the request map, as per the following code block
{code:java}
Map multiPartMap = params.isEmpty() ? 
getMultiPartParameterMap(req) : Collections.emptyMap();
params.putAll(multiPartMap);
req.setAttribute("multiPartMap", multiPartMap);
{code}
so it happens to be that once the params map has got values, the multiPartMap 
is initialized with an empty map and set on the request.

Thus it is no longer available to the target service after the 
"getParameterMap" is invoked multiple times before the service is executed.

I replaced this code with the following on my local machine and it worked to 
suffix the findings above.
{code:java}
Map multiPartMap = params.isEmpty() ? 
getMultiPartParameterMap(req) : Collections.emptyMap();
params.putAll(multiPartMap);
if (!multiPartMap.isEmpty()) {
req.setAttribute("multiPartMap", multiPartMap);
}
{code}

[~jleroux], could you please suggest if there is a better way to handle this, 
or any other problems that might be induced due to this change.

> Error while uploading file in Ecommerce Profile's File Manager 
> ---
>
> Key: OFBIZ-10746
> URL: https://issues.apache.org/jira/browse/OFBIZ-10746
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Aishwary Shrivastava
>Assignee: Priya Sharma
>Priority: Major
> Attachments: ErroUploadingFileOnFileManagerEcommerce.png
>
>
> On uploading File in Ecommerce Profile's File Manager,
> "The following required parameter is missing: [IN] 
> [uploadPartyContentFile.partyContentTypeId]" error is displaying.
>  
> Steps to regenerate the issue:
>  # Open Ecommerce on Ofbiz.
>  # Login with any user.
>  # Go to Profile.
>  # Navigate down to File Manager.
>  # Select Purpose.
>  # Seletct Mime Type
>  # Click upload.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown

2021-02-20 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287826#comment-17287826
 ] 

Michael Brohl commented on OFBIZ-12171:
---

No sure what I can do about the

> INFO: No Spring WebApplicationInitializer types detected on classpath

logs. Maybe with the dependency/repository changes there is some extra library 
loaded which causes this.

 

> Handling the JCenter shutdown
> -
>
> Key: OFBIZ-12171
> URL: https://issues.apache.org/jira/browse/OFBIZ-12171
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01, Upcoming Branch, 17.12.06
>
> Attachments: OFBIZ-12171-1712-README.patch
>
>
> Citing Taher's message at [2]:
> Hello Everyone, 
>  
> I received emails and checked resources [1] that seem to confirm JCenter from 
> JFrog is going down and that the last day of operation for the repository is 
> going to be May 1st 2021. 
>  
> This is a big deal as many running instances will crash unless updated, so 
> not only do future versions of OFBiz need to adapt, but also existing 
> installations. 
>  
> I'm not sure how to best handle this? Especially for production instances out 
> there on older versions of OFBiz. Maybe one solution is to host the existing 
> libraries in some temporary location or try to migrate them to MavenCentral 
> ... Whatever is the solution I think we should make a fast move. 
>  
> [1] 
> [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter]
>  
> [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure]
> [2] 
> [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #276: Improved: Switch from jCenter to mavenCentral to handle the jCenter shutdown r18.12 (OFBIZ-12171)

2021-02-20 Thread GitBox


sonarcloud[bot] commented on pull request #276:
URL: https://github.com/apache/ofbiz-framework/pull/276#issuecomment-782764813


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=276=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=276=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=276=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=276)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=276=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #276: Improved: Switch from jCenter to mavenCentral to handle the jCenter shutdown r18.12 (OFBIZ-12171)

2021-02-20 Thread GitBox


sonarcloud[bot] removed a comment on pull request #276:
URL: https://github.com/apache/ofbiz-framework/pull/276#issuecomment-778756132


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=276=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=276=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=276=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=276=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=276)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=276=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown

2021-02-20 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287814#comment-17287814
 ] 

Michael Brohl commented on OFBIZ-12171:
---

> Also since we updated trunk, I find 48 of
{quote}INFO: No Spring WebApplicationInitializer types detected on classpath
{quote}
> There are many answers on Stackoverflow  but I'm not sure which one applies 
> to us. I'll have a look...

> Maybe related to the log4j changes?
> [https://github.com/apache/ofbiz-framework/commit/8ea75c9e2e218f350980ff104df9cdd4e2d1ad4e/]

The diff is a bit misleading here. log4j-core was not replaced by log4j-jcl. It 
is already in the compile section so I removed the double entry.

Effectively, only log4j-jcl was added.

 

> Handling the JCenter shutdown
> -
>
> Key: OFBIZ-12171
> URL: https://issues.apache.org/jira/browse/OFBIZ-12171
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01, Upcoming Branch, 17.12.06
>
> Attachments: OFBIZ-12171-1712-README.patch
>
>
> Citing Taher's message at [2]:
> Hello Everyone, 
>  
> I received emails and checked resources [1] that seem to confirm JCenter from 
> JFrog is going down and that the last day of operation for the repository is 
> going to be May 1st 2021. 
>  
> This is a big deal as many running instances will crash unless updated, so 
> not only do future versions of OFBiz need to adapt, but also existing 
> installations. 
>  
> I'm not sure how to best handle this? Especially for production instances out 
> there on older versions of OFBiz. Maybe one solution is to host the existing 
> libraries in some temporary location or try to migrate them to MavenCentral 
> ... Whatever is the solution I think we should make a fast move. 
>  
> [1] 
> [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter]
>  
> [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure]
> [2] 
> [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12184) Textarea fields do not expand when typing into them

2021-02-20 Thread Pawan Verma (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287754#comment-17287754
 ] 

Pawan Verma commented on OFBIZ-12184:
-

Hi [~ddev]

What about this solution?
{code:java}
var textarea = document.getElementById("textarea");
if (textarea) {
textarea.oninput = function() {
textarea.style.height = "";
textarea.style.height = Math.min(textarea.scrollHeight, 200) + "px";
};
}
{code}

> Textarea fields do not expand when typing into them
> ---
>
> Key: OFBIZ-12184
> URL: https://issues.apache.org/jira/browse/OFBIZ-12184
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: ddev
>Priority: Minor
> Attachments: autoexpand-textarea.js
>
>
> When typing into a textarea field with a large number of lines, you often can 
> only see 2 lines of text at a time. It would make sense to add it to the HTML 
> specification, but for whatever reason that did not happen, so it must be 
> done in javascript.
>  
> I am attaching a javascript file that includes one way of fixing it.  One way 
> of loading this would be to include it via themes/common/widget/Themes.xml
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10971) Use ReturnContactMech entity

2021-02-20 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287747#comment-17287747
 ] 

Michael Brohl commented on OFBIZ-10971:
---

It is not related. It should have been OFBIZ-10791 in the commit message...

> Use ReturnContactMech entity
> 
>
> Key: OFBIZ-10971
> URL: https://issues.apache.org/jira/browse/OFBIZ-10971
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Vaibhav Jain
>Assignee: Devanshu Vyas
>Priority: Major
>
> Use ReturnContactMech entity to capture the contactMech information of 
> parties involved in a return like OrderContactMech is used of orders



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11347) Add GraphQL component

2021-02-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287670#comment-17287670
 ] 

Jacques Le Roux commented on OFBIZ-11347:
-

Also, despite your effortd, your patch put in several checkstyle issues:

Checkstyle files with violations: 77
Checkstyle violations by severity: [error:326]

instead of 127 errors in trunk HEAD

> Add GraphQL component
> -
>
> Key: OFBIZ-11347
> URL: https://issues.apache.org/jira/browse/OFBIZ-11347
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-12-26-22-46-10-859.png
>
>
> Here's the relevant discussion around having a GraphQL component for OFBiz- 
> [https://lists.apache.org/thread.html/r2fd1decca7a71ae2270a0e2d1f03ed69a69253f68f957626c386a11a%40%3Cdev.ofbiz.apache.org%3E]
>  Also, add the capability for OFBiz to communicate with a GraphQL endpoint.
> Below repository contains GraphQL endpoint configuration for OFBiz. Further 
> details can be found in README.
> https://github.com/girishvasmatkar/ofbiz-graphql
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11221) Wrong heading on creating quote under order component.

2021-02-20 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287666#comment-17287666
 ] 

ASF subversion and git services commented on OFBIZ-11221:
-

Commit 26a2be13929d153f225b29e28d03b9d7d1c844b2 in ofbiz-framework's branch 
refs/heads/release17.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=26a2be1 ]

Fixed: Wrong heading on creating quote under order component (OFBIZ-11221)

Steps to re-generate :

1. Login with the username and password.
2. Go to order component order.
3. Click on Quotes
4. Click on new quotes

Error: Edit quote is shown on the place of New quote.
Actual: New quote should be shown on the place of edit quote on UI.

Thanks: jai kumar raghuwanshi for report, Pradyum Dharwa  for 1st patch,
Ratnesh Upadhyay for better suggestion and Ankit Joshi for the patch


> Wrong heading on creating quote under order component.
> --
>
> Key: OFBIZ-11221
> URL: https://issues.apache.org/jira/browse/OFBIZ-11221
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: jai kumar raghuwanshi
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.01, 17.12.06
>
> Attachments: OFBIZ-11221.patch, OFBIZ-11221.patch, ordermgr.png
>
>
> Steps to re-generate :
> 1. Login with the username and password.
> 2. Go to order component order.
> 3. Click on Quotes
> 4. Click on new quotes
> Error: Edit quote is shown on the place of New quote.
> Actual: New quote should be shown on the place of edit quote on UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11221) Wrong heading on creating quote under order component.

2021-02-20 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287668#comment-17287668
 ] 

ASF subversion and git services commented on OFBIZ-11221:
-

Commit 7fb64ba5b562fb03880a86d73db529ceff5707d3 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7fb64ba ]

Fixed: Wrong heading on creating quote under order component (OFBIZ-11221)

Steps to re-generate :

1. Login with the username and password.
2. Go to order component order.
3. Click on Quotes
4. Click on new quotes

Error: Edit quote is shown on the place of New quote.
Actual: New quote should be shown on the place of edit quote on UI.

Thanks: jai kumar raghuwanshi for report, Pradyum Dharwa  for 1st patch,
Ratnesh Upadhyay for better suggestion and Ankit Joshi for the patch


> Wrong heading on creating quote under order component.
> --
>
> Key: OFBIZ-11221
> URL: https://issues.apache.org/jira/browse/OFBIZ-11221
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: jai kumar raghuwanshi
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.01, 17.12.06
>
> Attachments: OFBIZ-11221.patch, OFBIZ-11221.patch, ordermgr.png
>
>
> Steps to re-generate :
> 1. Login with the username and password.
> 2. Go to order component order.
> 3. Click on Quotes
> 4. Click on new quotes
> Error: Edit quote is shown on the place of New quote.
> Actual: New quote should be shown on the place of edit quote on UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11221) Wrong heading on creating quote under order component.

2021-02-20 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287667#comment-17287667
 ] 

ASF subversion and git services commented on OFBIZ-11221:
-

Commit f2b04b53395e04b57704b633adde927295fdd50a in ofbiz-framework's branch 
refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f2b04b5 ]

Fixed: Wrong heading on creating quote under order component (OFBIZ-11221)

Steps to re-generate :

1. Login with the username and password.
2. Go to order component order.
3. Click on Quotes
4. Click on new quotes

Error: Edit quote is shown on the place of New quote.
Actual: New quote should be shown on the place of edit quote on UI.

Thanks: jai kumar raghuwanshi for report, Pradyum Dharwa  for 1st patch,
Ratnesh Upadhyay for better suggestion and Ankit Joshi for the patch


> Wrong heading on creating quote under order component.
> --
>
> Key: OFBIZ-11221
> URL: https://issues.apache.org/jira/browse/OFBIZ-11221
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: jai kumar raghuwanshi
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.01, 17.12.06
>
> Attachments: OFBIZ-11221.patch, OFBIZ-11221.patch, ordermgr.png
>
>
> Steps to re-generate :
> 1. Login with the username and password.
> 2. Go to order component order.
> 3. Click on Quotes
> 4. Click on new quotes
> Error: Edit quote is shown on the place of New quote.
> Actual: New quote should be shown on the place of edit quote on UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11221) Wrong heading on creating quote under order component.

2021-02-20 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-11221.
---
Fix Version/s: 17.12.06
   18.12.01
   Resolution: Fixed

> Wrong heading on creating quote under order component.
> --
>
> Key: OFBIZ-11221
> URL: https://issues.apache.org/jira/browse/OFBIZ-11221
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: jai kumar raghuwanshi
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 18.12.01, 17.12.06
>
> Attachments: OFBIZ-11221.patch, OFBIZ-11221.patch, ordermgr.png
>
>
> Steps to re-generate :
> 1. Login with the username and password.
> 2. Go to order component order.
> 3. Click on Quotes
> 4. Click on new quotes
> Error: Edit quote is shown on the place of New quote.
> Actual: New quote should be shown on the place of edit quote on UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11221) Wrong heading on creating quote under order component.

2021-02-20 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-11221:
---

Assignee: Jacques Le Roux

> Wrong heading on creating quote under order component.
> --
>
> Key: OFBIZ-11221
> URL: https://issues.apache.org/jira/browse/OFBIZ-11221
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: jai kumar raghuwanshi
>Assignee: Jacques Le Roux
>Priority: Trivial
> Attachments: OFBIZ-11221.patch, OFBIZ-11221.patch, ordermgr.png
>
>
> Steps to re-generate :
> 1. Login with the username and password.
> 2. Go to order component order.
> 3. Click on Quotes
> 4. Click on new quotes
> Error: Edit quote is shown on the place of New quote.
> Actual: New quote should be shown on the place of edit quote on UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11599) Convert CheckoutServices.xml minilang to groovy

2021-02-20 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-11599:
---

Assignee: Jacques Le Roux  (was: Sebastian Berg)

> Convert CheckoutServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11599
> URL: https://issues.apache.org/jira/browse/OFBIZ-11599
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11347) Add GraphQL component

2021-02-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287652#comment-17287652
 ] 

Jacques Le Roux commented on OFBIZ-11347:
-

Ah last point, it's OK as is (just above rest in vertical menu in rainbow 
theme), but you might want to give a position to GraphQL appli (see OFBIZ-12166)

> Add GraphQL component
> -
>
> Key: OFBIZ-11347
> URL: https://issues.apache.org/jira/browse/OFBIZ-11347
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-12-26-22-46-10-859.png
>
>
> Here's the relevant discussion around having a GraphQL component for OFBiz- 
> [https://lists.apache.org/thread.html/r2fd1decca7a71ae2270a0e2d1f03ed69a69253f68f957626c386a11a%40%3Cdev.ofbiz.apache.org%3E]
>  Also, add the capability for OFBiz to communicate with a GraphQL endpoint.
> Below repository contains GraphQL endpoint configuration for OFBiz. Further 
> details can be found in README.
> https://github.com/girishvasmatkar/ofbiz-graphql
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11347) Add GraphQL component

2021-02-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287650#comment-17287650
 ] 

Jacques Le Roux commented on OFBIZ-11347:
-

Ah cool, I can see it in the console :) But I have still to learn how to use 
GraphQL queries it seems :D

> Add GraphQL component
> -
>
> Key: OFBIZ-11347
> URL: https://issues.apache.org/jira/browse/OFBIZ-11347
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-12-26-22-46-10-859.png
>
>
> Here's the relevant discussion around having a GraphQL component for OFBiz- 
> [https://lists.apache.org/thread.html/r2fd1decca7a71ae2270a0e2d1f03ed69a69253f68f957626c386a11a%40%3Cdev.ofbiz.apache.org%3E]
>  Also, add the capability for OFBiz to communicate with a GraphQL endpoint.
> Below repository contains GraphQL endpoint configuration for OFBiz. Further 
> details can be found in README.
> https://github.com/girishvasmatkar/ofbiz-graphql
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11347) Add GraphQL component

2021-02-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287648#comment-17287648
 ] 

Jacques Le Roux commented on OFBIZ-11347:
-

Hi Girish,

I'm not sure to understand the steps you gave. I have simply applied the patch 
at
https://patch-diff.githubusercontent.com/raw/apache/ofbiz-plugins/pull/47.patch
Did a "gradlew loadAll ofbiz",
Using my old FF version (56) I can't see anything at 
https://localhost:8443/graphql/control/graphiql
Using Edge (I'm on Windows 7) it works. I saw the explanation and hastily tried

{noformat}
{
  field(arg: "value") {
subField
  }
}
{noformat}

in the left panel, and got

{noformat}
{
  "errors": [
{
  "message": "Validation error of type FieldUndefined: Field 'field' in 
type 'QueryRootObjectType' is undefined @ 'field'",
  "locations": [
{
  "line": 2,
  "column": 3
}
  ],
  "extensions": {
"classification": "ValidationError"
  }
}
  ],
  "data": null
}
{noformat}

which is not a big deal, but how can I get back to the explanation?

TIA

> Add GraphQL component
> -
>
> Key: OFBIZ-11347
> URL: https://issues.apache.org/jira/browse/OFBIZ-11347
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-12-26-22-46-10-859.png
>
>
> Here's the relevant discussion around having a GraphQL component for OFBiz- 
> [https://lists.apache.org/thread.html/r2fd1decca7a71ae2270a0e2d1f03ed69a69253f68f957626c386a11a%40%3Cdev.ofbiz.apache.org%3E]
>  Also, add the capability for OFBiz to communicate with a GraphQL endpoint.
> Below repository contains GraphQL endpoint configuration for OFBiz. Further 
> details can be found in README.
> https://github.com/girishvasmatkar/ofbiz-graphql
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11595) Convert CostServices.xml minilang to groovy

2021-02-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287624#comment-17287624
 ] 

Jacques Le Roux commented on OFBIZ-11595:
-

Hi Daniel, would you mind committing?

> Convert CostServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11595
> URL: https://issues.apache.org/jira/browse/OFBIZ-11595
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10971) Use ReturnContactMech entity

2021-02-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287622#comment-17287622
 ] 

Jacques Le Roux commented on OFBIZ-10971:
-

HI Michael,

I don't understand how the commit is related to this issue (?)

> Use ReturnContactMech entity
> 
>
> Key: OFBIZ-10971
> URL: https://issues.apache.org/jira/browse/OFBIZ-10971
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Vaibhav Jain
>Assignee: Devanshu Vyas
>Priority: Major
>
> Use ReturnContactMech entity to capture the contactMech information of 
> parties involved in a return like OrderContactMech is used of orders



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-4483) Upload content file with upload form and on-event-update-area element

2021-02-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287621#comment-17287621
 ] 

Jacques Le Roux commented on OFBIZ-4483:


Hi Nicolas, what is the status here?

> Upload content file with upload form and on-event-update-area element
> -
>
> Key: OFBIZ-4483
> URL: https://issues.apache.org/jira/browse/OFBIZ-4483
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-4483.patch, OFBIZ-4483.patch, OFBIZ-4483.png
>
>
> At this time, if you have :
> {quote}
>  
> 
>  area-id="XXX"/>
>  
> {quote}
> The called service have an empty uploadFile.
> The problem came from ajaxSubmitUpdateAreas that doesn't compliant with 
> "multi-part"
> To solve it, I added a new jquery plugin : JQuery.upload, create a new 
> javascript function ajaxUploadUpdateAreas and synchronize MacroRenderer.
> I also add an exemple on myportal with view profile (see image).
> The upload plugin have a problem with return type : application/x-json, I 
> extend json controller to return a text/html 
> (http://lagoscript.org/jquery/upload/documentation)
> I analyse sascha jira : OFBIZ-3878. I think it's possible to mixte both issue 
> to have a progressbar when the form is on upload type with js submit, I need 
> more analyse to set good id on js progressbar function.
> Nicolas



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9577) Manage File upload with auto-fields-service

2021-02-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287620#comment-17287620
 ] 

Jacques Le Roux commented on OFBIZ-9577:


Hi Nicolas, what is the status here?

> Manage File upload with auto-fields-service
> ---
>
> Key: OFBIZ-9577
> URL: https://issues.apache.org/jira/browse/OFBIZ-9577
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
>
> When you use a auto-fields-service element on form, if the service wait a 
> file, manage it directly



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12016) DiskFileItem as request attribute creates problems

2021-02-20 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287619#comment-17287619
 ] 

Jacques Le Roux commented on OFBIZ-12016:
-

Hi Sebastian,

Is that still reproductible? I made several changes in this area since...

> DiskFileItem as request attribute creates problems
> --
>
> Key: OFBIZ-12016
> URL: https://issues.apache.org/jira/browse/OFBIZ-12016
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: 18.12.01, Trunk
>Reporter: Sebastian Berg
>Priority: Major
>
> Hi,
> while working on a custom project based on the 18.12.01 version, I noticed a 
> problem with the request handling during a request-redirect-noparam if a 
> DiskFileItem was involved.
> So the situation for me is as follows: during the first request a file is 
> uploaded. I choose a wrong format on purpose, which results in an error 
> respond for that event. Nevertheless the DiskFileItem is set as request 
> attribute together with the error message.
> The request is finished and based on the controller configurations redirected 
> to a second request.
> While handling the second request the previous request's attributes get 
> restored (RequestHandler.java line 733ff). This goes down into 
> SafeObjectInfo.resolveClass() where an Incompatible class exception is 
> thrown. I compared my custom project with the current development status and 
> worked in the changes from commit 3f60efb343a11723aa56c1bc1f5afac3a2f26e9f in 
> OFBIZ-10837.
> While this fixes the issue with the incompatible class exception it also 
> makes it impossible to retrieve any attributes from the first request. 
> Therefore my error message cannot be shown.
> Is there a way to fix it or is it otherwise necessary to always set 
> "fileItems" as request attribute as added in -OFBIZ-11246-?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12101) partymgr fails to upload image

2021-02-20 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12101.
---
Resolution: Cannot Reproduce

> partymgr fails to upload image
> --
>
> Key: OFBIZ-12101
> URL: https://issues.apache.org/jira/browse/OFBIZ-12101
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
> Environment: OS: Ubuntu 20.04
> $ java -version
> java version "1.8.0_271"
> Java(TM) SE Runtime Environment (build 1.8.0_271-b09)
> Java HotSpot(TM) 64-Bit Server VM (build 25.271-b09, mixed mode)
>Reporter: Wai
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
> Attachments: v.jpeg
>
>
> partymgr fails to upload image
>  
> Steps to reproduce issue:
> open https://localhost:8443/partymgr/control/viewprofile?partyId=admin
> in Party Content panel
>  select image to upload
>  select "Logo Image URL"
> click ok
> console output:
> 2020-12-25 16:24:06,533 |sse-nio-18443-exec-4 |UtilHttp |E| File upload 
> errororg.apache.commons.fileupload.FileUploadBase$IOFileUploadException: 
> Processing of multipart/form-data request failed. java.io.EOFException
> 2020-12-25 16:24:06,573 |sse-nio-18443-exec-4 |ModelService |I| Set default 
> value [DOCUMENT] for parameter [contentTypeId]
> 2020-12-25 16:24:06,661 |sse-nio-18443-exec-4 |UtilProperties |I| 
> ResourceBundle ServiceErrorUiLabels (en) created in 0.087s with 40 properties
> 2020-12-25 16:24:06,662 |sse-nio-18443-exec-4 |ModelService |E| 
> [ModelService.validate] : \{uploadPartyContentFile} : (IN) Required test 
> error: org.apache.ofbiz.service.ServiceValidationException: The following 
> required parameter is missing: [IN] 
> [uploadPartyContentFile.partyContentTypeId]
> 2020-12-25 16:24:06,662 |sse-nio-18443-exec-4 |ServiceDispatcher |E| Incoming 
> context (in runSync : uploadPartyContentFile) does not match expected 
> requirements
> org.apache.ofbiz.service.ServiceValidationException: The following required 
> parameter is missing: [IN] [uploadPartyContentFile.partyContentTypeId]
>  at org.apache.ofbiz.service.ModelService.validate(ModelService.java:1305) 
> ~[main/:?]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12158) Unable to upload product images

2021-02-20 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12158.
---
Resolution: Cannot Reproduce

> Unable to upload product images
> ---
>
> Key: OFBIZ-12158
> URL: https://issues.apache.org/jira/browse/OFBIZ-12158
> Project: OFBiz
>  Issue Type: Bug
>  Components: product/catalog
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Priority: Major
> Attachments: Screenshot from 2021-01-23 17-28-07.png
>
>
> Unable to upload product images (tried multiple image file formats)
> URL - catalog/control/ImageUpload
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)